From nobody Mon Sep 28 02:05:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1785366061; cv=none; d=zohomail.com; s=zohoarc; b=WMSvVQkyCjiIXSDn1dKNomLR800ifWpk4whtUgh0OGxOehN8jyVfXKGmfVBtvKuI9QcEF+BPrSKEekGVLLFzeygaGiWmFA+2Pxa4bPWefZhKLMd3tkSjcktmNbR3TDvtYSUNP1nuVZ0dEI/LSEbOh26TgEwNhAAgnKItaP6ygs8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785366061; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=BXYpGfodJPSXEOwaOqS7Hh15kpJ8daBroc8+Qw9cSh4=; b=hstJbnpuNNZKNc1ldwB5NuLw1nYT1qI5/QWYE044hiPDJIKeJf5P/lsEabiNwwOJH4nG9ToU6KRRLnhI2YZ0SZ10fcMq7+eMtfz+cuvpzlRxJwmbzp+jVPrmbGc7UyeQkaHu6LhkWeTCST1JmZ9vFDJRSzE+n8ByRII0H1Z9C9Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from=<314abh@gmail.com> (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1785366061705813.4507179090189; Wed, 29 Jul 2026 16:01:01 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wpDGd-0004vN-MW; Wed, 29 Jul 2026 19:00:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <314abh@gmail.com>) id 1wpDGb-0004v5-9R for qemu-devel@nongnu.org; Wed, 29 Jul 2026 19:00:50 -0400 Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <314abh@gmail.com>) id 1wpDGZ-0005PQ-Ht for qemu-devel@nongnu.org; Wed, 29 Jul 2026 19:00:48 -0400 Received: by mail-pg1-x52b.google.com with SMTP id 41be03b00d2f7-c9e7391839cso1343715a12.0 for ; Wed, 29 Jul 2026 16:00:46 -0700 (PDT) Received: from arch ([112.133.246.13]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31504b88e12sm13804534eec.11.2026.07.29.16.00.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jul 2026 16:00:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785366045; x=1785970845; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=BXYpGfodJPSXEOwaOqS7Hh15kpJ8daBroc8+Qw9cSh4=; b=ZFJ3se7VaI9+4miQa6QSpXqQVGQABFxgJZlegKYeo3e+uYlPPsTDw3leU0vNlsJwj1 YIq0rylQmv0ciLwf/kpkbwAJfHz7X9j+Saagni+PU+edN2oWaYYw2MOUzc9qcxQbSQpN LB59ZOsEzfqGaAZ2g4vO71PIZnIqxKXC9nIj+/1wAmTzf/UmJbK462ZP/chn0De3OhUY Ic/kcFr/fU9Vrm9OKTr9QSsCv5Oi7iVfHrLjYW63jUZTOKQJLTflfgefaEHYf7wX/uhM 1HVhidSKAmUZGYMTm9FWb3BStNVj2nZijjw6f3T3VxdBNEBBbaQlCGwSCeb9DFKEBKEI hmHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785366045; x=1785970845; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BXYpGfodJPSXEOwaOqS7Hh15kpJ8daBroc8+Qw9cSh4=; b=qc478OCMdIz0yku13SNOI9Cl0BXUzkP7xO9tOZpnXVTEaSmUpJPHffAwxwx6jZ6Nv/ 6cHrAwH0jzj37IwPkXUekBCH6O/S+nEyYA8ot6Re77LDdQl/51lymuGT8iYTcBkOPaAZ FCv/QUhBAU5aq2vy2Yyw7QC/Hc+640t9MiK14AWVzZrzriI7sYrnUZGcmikVOqTl4HeI OLPDInjYiodlLQsDfdS0Q7HhudC9mx/unPfQ0/8VRXm/G+k1V3xolomHo6SAf6C8QcyU Ef6SpkB0RJcKV0aWp55rt+hNF23p1CmEyuuKpuNLphpKYMdibyYkCtxlxh1mA5XA/U16 C3xQ== X-Gm-Message-State: AOJu0YxhzTV7H2dj4p4zYIJaIHQbBHxnirc/8Y9S2tRzsCCDwiH7lqbT 0a6qlarPhqe78pgBSEF8o1XI1g5G8wNSF9+7qBpZLd75Hb15StAuRvstoKXMK/eQ X-Gm-Gg: AR+sD101omrjtlYLegD7g6BPuzf/8KfYez9ppf0zlnFEPRHbnhkmiBPmdEoPHzewtV5 e188TRMMWFAs5yrRLKhc+ljcK5zraPw5fXsc8mgKfADRDF9zwXDPqTs/nkUG27/dGHXC4FbDtlE wBJYKY8CER/siGuhegmxDZenWEktOL7vERR9E0hKZ3AG/eSJWJ2LYwavw7uh8i4ih5KmgUsQ1Tu 5HEF2Y3Z78FNxm1VSTZB4nWppEcBdLV1rbE8dJZ70ADzvZXvd2ibvtHGMYu5rtOByu4Jl+N5dvs kT/mXuyE6qLw7mSN8mp1DHzGlmhL/cJi1lUg438FrhinH30ElCA1p+re0gWnX+BZz03dIvJzmwy 4SlFz86DFr5tQ3gRgD45jMubU+fsUgVKK+sAg+mUf3pt+P4SC/C+HSKJs2ISZEpRQOB6jPIIbEj 1M/Lkcz506MwW2Y7h+znCjTZhqZ4SCD6LYzAGngSVDIHa4jyI= X-Received: by 2002:a05:6a21:3390:b0:3c3:7bb9:c93 with SMTP id adf61e73a8af0-3c9006b6c93mr30100637.53.1785366045233; Wed, 29 Jul 2026 16:00:45 -0700 (PDT) From: Abhigyan Kumar <314abh@gmail.com> To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Chao Liu , Palmer Dabbelt , Abhigyan Kumar <314abh@gmail.com> Subject: [PATCH] target/riscv: prevent abrupt abortion on unassigned value write to tdata Date: Thu, 30 Jul 2026 04:30:28 +0530 Message-ID: <20260729230028.1797355-1-314abh@gmail.com> X-Mailer: git-send-email 2.55.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::52b; envelope-from=314abh@gmail.com; helo=mail-pg1-x52b.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FROM_STARTS_WITH_NUMS=0.738, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1785366062615158500 Content-Type: text/plain; charset="utf-8" tdata_csr_write is approachable by guest programs. In case of unassigned values written to a tdata CSR in debug mode, the switch-case falls through straight to default causing an immediate abort. The risc-v spec says: All tdata registers follow write-any-read-legal semantics. If a debugger writes an unsupported configuration, the register will read back a value that is supported (which may simply be a disabled trigger). This means that a debugger must always read back values it writes to tdata registers, unless it already knows what is supported. This fix correctly ensures that the WARL behaviour of tdata CSRs. Fixes: a42bd001 ("target/riscv: debug: Determine the trigger type from tdata1.type") Signed-off-by: Abhigyan Kumar <314abh@gmail.com> Reviewed-by: Alistair Francis --- target/riscv/tcg/debug.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/riscv/tcg/debug.c b/target/riscv/tcg/debug.c index 3c0fe7010..ae493235d 100644 --- a/target/riscv/tcg/debug.c +++ b/target/riscv/tcg/debug.c @@ -913,7 +913,8 @@ void tdata_csr_write(CPURISCVState *env, int tdata_inde= x, target_ulong val) trigger_type); break; default: - g_assert_not_reached(); + qemu_log_mask(LOG_GUEST_ERROR, "trigger type: %d is unassigned\n", + trigger_type); } } =20 --=20 2.55.0