From nobody Mon Sep 28 02:05:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1785098705; cv=none; d=zohomail.com; s=zohoarc; b=QFodFleezHYy0/9oOJwOs8wz/8C/NqEPhW6gXh7rgYkV72pDbzBgvEdNdInR1F1NwvNLsKNhxQPR9x27XNzil5jZQ1+JjbQ2ptqIEoweoA9HDmNr6xLyE9zfA8Xv4DQG7X9H1+At2MySZNP1IZ5N2LSgXT6nlDNMxBzGwwtvgIE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785098705; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=jdyS0SwdNs3vUAKy88HJSJe2GUYkTH6E4XHdR6+6wqI=; b=UHF/hHBSe7rR1CrEBx6zmjf1L6J5d2bPSqnEg1odr4h3GVqfS00Pc28DEe0qVWwViQvMWV80onEbBpRyxveJBeHMk2E9TUCKV1Tqay8GLUv19Y05Yrpp+fXbdSnc3XFs/dtmLpSNyX2Fxxs9O02YwAow5pTTxtzNg06GDHdB40Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17850987056081007.4274040786457; Sun, 26 Jul 2026 13:45:05 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wo5iA-0007yT-Ux; Sun, 26 Jul 2026 16:44:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wo5i8-0007y1-1M for qemu-devel@nongnu.org; Sun, 26 Jul 2026 16:44:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wo5i6-00048T-F3 for qemu-devel@nongnu.org; Sun, 26 Jul 2026 16:44:35 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-379-RMfQBsV9NAOEXuRf76343A-1; Sun, 26 Jul 2026 16:44:30 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 524BD195606A; Sun, 26 Jul 2026 20:44:26 +0000 (UTC) Received: from localhost (unknown [10.44.24.5]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id AE296180049F; Sun, 26 Jul 2026 20:44:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785098673; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jdyS0SwdNs3vUAKy88HJSJe2GUYkTH6E4XHdR6+6wqI=; b=K6ovLZrAP3Q20XPMyf+fuw//AObAKse4eWXUhMsSLXnh3F13j6prxRmYb9lMy4K22+bS+B rLzCGMwJCbLLe/Oa3gtlAW5avRVBF+Nx2lLVytJnGyfzjVZF/T00oN2H/WR1fZ/pfKLs5v sRpf6dKxcB4fl7nW8N50xQmsbSlaxa8= X-MC-Unique: RMfQBsV9NAOEXuRf76343A-1 X-Mimecast-MFC-AGG-ID: RMfQBsV9NAOEXuRf76343A_1785098667 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Jul 2026 00:44:00 +0400 Subject: [PATCH v2 01/12] hw/display/virtio-gpu-rutabaga: zero-init capset info response MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260727-fix2-v2-1-d0c4831ed7ea@redhat.com> References: <20260727-fix2-v2-0-d0c4831ed7ea@redhat.com> In-Reply-To: <20260727-fix2-v2-0-d0c4831ed7ea@redhat.com> To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , =?utf-8?q?Alex_Benn=C3=A9e?= , Akihiko Odaki , Dmitry Osipenko , Stefan Hajnoczi , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org, Jonathan Cameron , Paolo Bonzini , Fam Zheng , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Zhao Liu , Roman Bolshakov , Phil Dennis-Jordan , Wei Liu , linux-cxl@vger.kernel.org, Brian Cain , Pierrick Bouvier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Peter Xu , Fabiano Rosas , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Haotian Jiang X-Developer-Signature: v=1; a=openpgp-sha256; l=1561; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=sa9k8gsEJKtuI61HuTaU2/NIFGh87rAtJ9OvBXauOqE=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqZnGWjRL3ARaU20KwN0Bb+7EEi0O/EflVGeLkQ iimEn+6/LSJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCamZxlgAKCRDa6OEJdZac 5WM4D/9x27KZwhBuvvOFyHz35ZYKZK9Ekzxnlff1k5tQH8c/hl4wPSlgBIhQD90Lvo7XR+/CnsL P8SRIQryA3R2QQNhiW3dP4lMdjKq4CWbRdZ+hUu6FiUL7RvM26rOSij8TM2dSpp6KOoXqu06udj VAnymkChW4d+DiYR2B10e4IYKHwa7aXRezN5uxKXdZ2X/UucYPCOGFYRGiXxSkwOMhyGmuZ8VMm AfP/nKkb+noc2HdBjU4tA0r9aahUmN4U/GhjjHkxLotYGio7A9TmokZvZ25xyJb9MXjyPlQeEea ojVTXgXMHi3np8So7VTQaWwUU8PXThBfd4f1eCE+WZkXWuoBYpZGcIqL1KzyER6ZZMKoU0btbUN ZVuzvQ13q1KhP4AJhuw9HrZGe6AraE/GHv9SD2Z715QZvSBzvRmxv+7b4b2Th/WdrDESgv/Y+qe p2GxVQb8F6aDy0SuaBjDbSNTBkRdKsDE6qyY3WcyRu8PAr9gSyqvbYq883+t85KL//L6agVvLPk V3DtINPa0Irm0Uo7+SaHoz6Y7K6Zy/EZFlAS/bhR4/8Mkx60nQtulIH2K84OXsy9YMjT7EqKE/b xAumi3Si3TuoQSqdfKpauvxdz033WLprVDCa0/58x2TnlWAopUK/BjxxXwiUBGHZ1lVXdZo5uD0 uKKSHJw+BLt5ygw== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -2 X-Spam_score: -0.3 X-Spam_bar: / X-Spam_report: (-0.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.58, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1785098707288158500 rutabaga_cmd_get_capset_info() only fills in capset_id, capset_max_version and capset_max_size before sending the response to the guest. The remaining fields of struct virtio_gpu_resp_capset_info, including hdr.fence_id, hdr.ctx_id and hdr.ring_idx, are left with stack garbage and leaked to the guest, including host pointers useful for an ASLR bypass. Zero the response first, matching virgl_cmd_get_capset_info(). Not a real risk thanks to -ftrivial-auto-var-init=3Dzero, but only with gcc >=3D 12 or clang >=3D 16. Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3609 Fixes: 1dcc6adbc168 ("gfxstream + rutabaga: add initial support for gfxstre= am") Reported-by: Haotian Jiang Reviewed-by: Akihiko Odaki Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/display/virtio-gpu-rutabaga.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/display/virtio-gpu-rutabaga.c b/hw/display/virtio-gpu-rutab= aga.c index 4d7d7b245929..95a19eed7eda 100644 --- a/hw/display/virtio-gpu-rutabaga.c +++ b/hw/display/virtio-gpu-rutabaga.c @@ -555,6 +555,8 @@ rutabaga_cmd_get_capset_info(VirtIOGPU *g, struct virti= o_gpu_ctrl_command *cmd) =20 VIRTIO_GPU_FILL_CMD(info); =20 + memset(&resp, 0, sizeof(resp)); + result =3D rutabaga_get_capset_info(vr->rutabaga, info.capset_index, &resp.capset_id, &resp.capset_max_ve= rsion, &resp.capset_max_size); --=20 2.55.0 From nobody Mon Sep 28 02:05:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1785098713; cv=none; d=zohomail.com; s=zohoarc; b=XvHajSSLRdI7bOFBScAomYq9yTj4bjv9b3uB2etX5XLsqYv4yvbOcMeg909E6lOtedKgVX6RC8sMOcIcvgOeB+Bb6BzfGwzIrUrgmqRHVMZ5QucmQrzyp7K8/OLSs61GvtUySA65frbn8Jz9ryewXzgRC8SPDr6+6M/ZoQF9m5M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785098713; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ZD9c+t7MILB/tiCBpv52ymj4SpFNv8fK+VqJytjmOdk=; b=aXLvyr/nqmTM9CHEWxpXGG6/C1ldtJaG6ISljpeFt8Qhc2Cz5iQB0ldgPx8Qzmg6aw3XGdoYamWps83KW5En4FCQBodmo5niFN8YAkFDBDAJgCkFS3+AiOtvipnSJ0+nYIcccS35WuFiZChNuh6pG0+x10Mq5FruWJYcxynGFbQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1785098713810603.4066349303856; Sun, 26 Jul 2026 13:45:13 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wo5iE-0007zj-8r; Sun, 26 Jul 2026 16:44:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wo5iC-0007z5-3h for qemu-devel@nongnu.org; Sun, 26 Jul 2026 16:44:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wo5iA-000499-No for qemu-devel@nongnu.org; Sun, 26 Jul 2026 16:44:39 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-225-Ugweij-7MW6f7RU7UILbNA-1; Sun, 26 Jul 2026 16:44:35 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 13F5B1956053; Sun, 26 Jul 2026 20:44:33 +0000 (UTC) Received: from localhost (unknown [10.44.24.5]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7A33C18001E0; Sun, 26 Jul 2026 20:44:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785098676; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZD9c+t7MILB/tiCBpv52ymj4SpFNv8fK+VqJytjmOdk=; b=WK9asMESIzRNY2gLctGaPL6jsmIuP6JS0jXlNEDR14LfrAy7GkcM6xeKQeYWyvwOyZl9Zx kCc2pF8JNb6dnshJUyZ2HwosjKV1/dwZdHbdXhp4DYu1NyLwccatUVCBaCV5Rx7zfOoaYu cMtdJH1D6eiVdLMCbceNLDOWm/lbII0= X-MC-Unique: Ugweij-7MW6f7RU7UILbNA-1 X-Mimecast-MFC-AGG-ID: Ugweij-7MW6f7RU7UILbNA_1785098673 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Jul 2026 00:44:01 +0400 Subject: [PATCH v2 02/12] block/blkio: fix error return value on getlength() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260727-fix2-v2-2-d0c4831ed7ea@redhat.com> References: <20260727-fix2-v2-0-d0c4831ed7ea@redhat.com> In-Reply-To: <20260727-fix2-v2-0-d0c4831ed7ea@redhat.com> To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , =?utf-8?q?Alex_Benn=C3=A9e?= , Akihiko Odaki , Dmitry Osipenko , Stefan Hajnoczi , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org, Jonathan Cameron , Paolo Bonzini , Fam Zheng , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Zhao Liu , Roman Bolshakov , Phil Dennis-Jordan , Wei Liu , linux-cxl@vger.kernel.org, Brian Cain , Pierrick Bouvier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Peter Xu , Fabiano Rosas , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=656; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=KUwdh4qWkjrixCjRkFzF1AESBuEqtaV7DKeiZd1uFaU=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqZnGX7YpxQWXaaGmDfwVLM1l+jDrPKhzdn7f+i DybceyvvueJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCamZxlwAKCRDa6OEJdZac 5fDJD/0X6NzR1k+kircKGc+Criog16ENyjwtcAo4cq+m7UNuaNHJ2+o2YmFdO41zEn/eS8MKVZJ c69+HhlSLjM7hU5EdcklCJoSl4v5TwZGVQeAJuGBsH/ezGTi07YKlmRh8iFUHWInZrX7PuoxFbU 1cxFkqz1NwvmWmwlnp37t5RfjsDHbHgHFFBGXuQOLXjsA1RehMVWEyshVyONXeIp/69YJEd1O/M NsfNuHYGeDNBlPY49uHCSyDt2o8OtnU5ex+v8VL3W8u64X++RLmSqstlGL46ZdTlXGPZiKRF43+ FRehK14fBGDW2MeV6hMfrMFCOT9eKOl1bYyu6Gt5SII5FWc1nOcXhNTRli1EfSK5VKdmFxobUEw e6kx+IU5h09/onPe2bQIu1zhWtJOfdC1tuFl5pq0mrZJPCBf1eC6wRuM1aXgGetF1pGWvl1MlPZ skrYenapjTYwjyqhKZbDn9PLc7yXht64XwfVhLq7JDINu67BhYEjFFs4Wbsj7FlOgs1qPwHcXBF QdIDpGtCJz1LXBWMFhnm3fUaQc6pNqXXkq4WasvfI9srvIKx4U5ygjkDPke0PNg6B7ZDYhcFDTx 8XZ3rGr27+wBSNYlVKsNKfAaxy8Pftk0Qdx//GfhkcXpSYomBCWOl/OUE4omtLNfrghWB26AWgv JusPeLjgfzl8qiw== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -2 X-Spam_score: -0.3 X-Spam_bar: / X-Spam_report: (-0.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.58, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1785098715352158500 Negative values should be returned for errors. Fixes: fd66dbd424 ("blkio: add libblkio block driver") Signed-off-by: Marc-Andr=C3=A9 Lureau --- block/blkio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/blkio.c b/block/blkio.c index fb8bec27d71a..52a8be220d1c 100644 --- a/block/blkio.c +++ b/block/blkio.c @@ -941,7 +941,7 @@ static int64_t coroutine_fn blkio_co_getlength(BlockDri= verState *bs) ret =3D blkio_get_uint64(s->blkio, "capacity", &capacity); } if (ret < 0) { - return -ret; + return ret; } =20 return capacity; --=20 2.55.0 From nobody Mon Sep 28 02:05:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1785098733; cv=none; d=zohomail.com; s=zohoarc; b=Mycbz/whX6NSGciNBapHe7IHXOehAkIB9fMTtlpDDC26a07Wsgo8nWSfjhsnC/FqKXSsCgUdlY2+3TpZzlP2m6UiT8WfuTw6W1ijEJcSMP41iSet+gYBJDE2nJIHol9nY0zXXsiz7PrjcAwTYlmopdeB76o1otPZyFzVrXT+VYw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785098733; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=3BDR4lCetSgPYsi2iCxOJ+ghjRU3eO1cdueUfdeq7eM=; b=Jg5TADoGJRCzH5ug/8T0K+VHnBhINZpjfwygUdkxUi4vUKDySurfv21m00PajFZoYT7EfP/9+YWsxs62aSdGbJtN0bH2FfWwwSBzJrkzm3WiZXIpgyTADSkoOwvT418v6yTO7iF+9twK9LlULh0UMzwX8kb0OfOSQLRyXsZQ6zQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1785098733971285.73852920619606; Sun, 26 Jul 2026 13:45:33 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wo5iM-00080m-QR; Sun, 26 Jul 2026 16:44:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wo5iK-00080V-L6 for qemu-devel@nongnu.org; Sun, 26 Jul 2026 16:44:48 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wo5iI-00049t-U4 for qemu-devel@nongnu.org; Sun, 26 Jul 2026 16:44:48 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-272-JWdTkM33PvexWva_5tj5CA-1; Sun, 26 Jul 2026 16:44:42 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B4C2F1956071; Sun, 26 Jul 2026 20:44:39 +0000 (UTC) Received: from localhost (unknown [10.44.24.5]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 509E142C; Sun, 26 Jul 2026 20:44:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785098686; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3BDR4lCetSgPYsi2iCxOJ+ghjRU3eO1cdueUfdeq7eM=; b=cZhhUT48zslaBlFhPMsCD+CTKiPhEqpXua2IhtZQYywPBczYmYH+Z7Y+r/61ouX8oRN4cv /QG073yby1TIEOWquHWXosht121buhd/zs7bEw5No8BvibYvVK+wsGMiQ50rXxS6AR2klW sEb9AwUEXt6Mji+BrCQuGTpWKudm3zw= X-MC-Unique: JWdTkM33PvexWva_5tj5CA-1 X-Mimecast-MFC-AGG-ID: JWdTkM33PvexWva_5tj5CA_1785098680 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Jul 2026 00:44:02 +0400 Subject: [PATCH v2 03/12] block/blkio: fix compiler false-positive warning MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260727-fix2-v2-3-d0c4831ed7ea@redhat.com> References: <20260727-fix2-v2-0-d0c4831ed7ea@redhat.com> In-Reply-To: <20260727-fix2-v2-0-d0c4831ed7ea@redhat.com> To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , =?utf-8?q?Alex_Benn=C3=A9e?= , Akihiko Odaki , Dmitry Osipenko , Stefan Hajnoczi , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org, Jonathan Cameron , Paolo Bonzini , Fam Zheng , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Zhao Liu , Roman Bolshakov , Phil Dennis-Jordan , Wei Liu , linux-cxl@vger.kernel.org, Brian Cain , Pierrick Bouvier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Peter Xu , Fabiano Rosas , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1098; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=FrHzIsDpkWChX+K7JOQIlcwNZG9jTUeVV/tUOTaHIVo=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqZnGXxYBcWQtZJhWSeAtprOzrLPhE7ldi+fXY8 bstbq2PYW2JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCamZxlwAKCRDa6OEJdZac 5VzmD/wJ+Uf764IPoo1uhCLJ7gOmtO25e/GAV+QqhufUlYTMiECisWjhidpfOa7aokUrKKXr1Up WzQsXFw+8kJdgrbUVqHrSzKDoUgEpTFdosi6kLaSbbcG6dVd6EBh3p3MUOX54O33sZm0edSGnO2 fEXAVXRFfjAD//rpc74YP0JscqafPDjhFFyxm4/ASjChpZBuksPo38e/f91fIZVHqd0Vog6qNIs kg3LD3HjXOqBqNM6BbmiJezvp0Kx3n3S5zp+i52WCjy3QSxv8Wqp9AsVRqPzoa5bkQ5MSMDR4Et kqQAH6qc33bkRK/AuzOBJHAmNrTRhRsUQegYKB8yR69pxEgCL8qbOWud2bdCJq+P1MhVK0Wj3aB aFiMPe3u0lBqXa5GMLZIXhw0b3hwPO/5t03104aD/G7H+ZTRSS5H+iOWay8jk/EOPr4gwpNYQj9 p0Cm7X2792+1rdVlgHs0IhpFRpVPi3zt7zHhek2Td0zxf7CTQB413Sm/Md9brIx/B2qrdEJpW5R COQ3F9kj341+pZ5q1DBnyto91kQPFq4wNT8bL8rndWBo6+hdtqJycurWc7v7LlOXpBWgP7/FKsh YCBdiubkWaGfLEWbcF/dsp8x7fr+PF6L3l6jwv75Y8L7gRh/HFJSKZ6u9b099kpBVR/hvgSIG/N dXNcRGr1QTjhD4w== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -2 X-Spam_score: -0.3 X-Spam_bar: / X-Spam_report: (-0.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.58, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1785098735451158500 Under some optimization, gcc produces a false-positive: ../block/blkio.c: In function =E2=80=98blkio_co_getlength=E2=80=99: ../block/blkio.c:943:8: error: =E2=80=98ret=E2=80=99 may be used uninit= ialized [-Werror=3Dmaybe-uninitialized] 943 | if (ret < 0) { | ^ Replace WITH_QEMU_LOCK_GUARD with the simpler QEMU_LOCK_GUARD. Suggested-by: Akihiko Odaki Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- block/blkio.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/block/blkio.c b/block/blkio.c index 52a8be220d1c..4801339f98b2 100644 --- a/block/blkio.c +++ b/block/blkio.c @@ -937,9 +937,8 @@ static int64_t coroutine_fn blkio_co_getlength(BlockDri= verState *bs) uint64_t capacity; int ret; =20 - WITH_QEMU_LOCK_GUARD(&s->blkio_lock) { - ret =3D blkio_get_uint64(s->blkio, "capacity", &capacity); - } + QEMU_LOCK_GUARD(&s->blkio_lock); + ret =3D blkio_get_uint64(s->blkio, "capacity", &capacity); if (ret < 0) { return ret; } --=20 2.55.0 From nobody Mon Sep 28 02:05:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1785098779; cv=none; d=zohomail.com; s=zohoarc; b=NrPMjNeB1qJoOZDm84+6otzh7gdjQfzxjIy8E3GTq9pCb6LP5wzJDduh2zchX6+717ZSBzEd4DNaO6mk7uYuVU/wAcn9rUDakB9+wuBJYSiZKuyTzkt9XhO7USBuibKPTbXPNDiSB2n1TmPX3A0eXTtdnEOWLigald+5BDKpWUc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785098779; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=8NwVZZIn/w654birzBXvL0uPjZxjge0gQHrGZXU1O00=; b=SJm9kur+FtiRCltMlgcof0aNjjNo+JNRaXrkpAX3/lOXsitLPRsExu2zRfzdGN+/4jz6x04SuI1OzM1efaiCbUTOIsdh7N8buWeOf6Ctx8E5l63S2rK55fPzmVLhEKEkfjwLCPSeGH2TdYzEk6HSv9loDVvEG0oIh/kz2CwT3/k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1785098779346543.7879748615823; Sun, 26 Jul 2026 13:46:19 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wo5iR-00082P-Gh; Sun, 26 Jul 2026 16:44:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wo5iP-00081h-Me for qemu-devel@nongnu.org; Sun, 26 Jul 2026 16:44:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wo5iO-0004AY-2Q for qemu-devel@nongnu.org; Sun, 26 Jul 2026 16:44:53 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-463-R1SXSgAwOairw3KAFZQkNQ-1; Sun, 26 Jul 2026 16:44:47 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 186C71955F7A; Sun, 26 Jul 2026 20:44:45 +0000 (UTC) Received: from localhost (unknown [10.44.24.5]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A8E3C18001E6; Sun, 26 Jul 2026 20:44:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785098691; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8NwVZZIn/w654birzBXvL0uPjZxjge0gQHrGZXU1O00=; b=XJgo9zGcDWbyVnmXVzo9I7qIw3EIo0sRTiSN7/Tt9+tiqkH9WRXPYi8V9O9SFLUQLlwhpa hNIOaj99Zyij4LVgjlh+VQVZrsJtbABFJGbR9cC3fqdTfEfMYu01t/REeXrTO8nAFwhyAy vl+bV46xz2n47sbGuncmntkYWpMAPRM= X-MC-Unique: R1SXSgAwOairw3KAFZQkNQ-1 X-Mimecast-MFC-AGG-ID: R1SXSgAwOairw3KAFZQkNQ_1785098685 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Jul 2026 00:44:03 +0400 Subject: [PATCH v2 04/12] include/qemu: adjust LOCK_GUARD macros to avoid potential warning MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260727-fix2-v2-4-d0c4831ed7ea@redhat.com> References: <20260727-fix2-v2-0-d0c4831ed7ea@redhat.com> In-Reply-To: <20260727-fix2-v2-0-d0c4831ed7ea@redhat.com> To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , =?utf-8?q?Alex_Benn=C3=A9e?= , Akihiko Odaki , Dmitry Osipenko , Stefan Hajnoczi , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org, Jonathan Cameron , Paolo Bonzini , Fam Zheng , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Zhao Liu , Roman Bolshakov , Phil Dennis-Jordan , Wei Liu , linux-cxl@vger.kernel.org, Brian Cain , Pierrick Bouvier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Peter Xu , Fabiano Rosas , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=3805; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=+bBGCP3R5q2tbR+800PYqErga8FAlOuwLp/htqBMock=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqZnGXn0QZUp3tUC6uaoSvmdKBBdFYKE02mVjoO 2ZIpqOSh7eJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCamZxlwAKCRDa6OEJdZac 5VrTD/936zW3B3vsx6iLSY5/yTBjfYS6nC4mWSx/8jgv6Z6ar3VOnXtTrYoH/sPvGwaWVfT40z0 h22sW8LZap6GS5pbCTGrbcZmQzJBKk+FggAzmYwdWCxADQxP347wEAw2hjFIujgQ64HyZdePCSg uvUOaC07KnRSAMSLWzdIzqXvJtgG5xfLSen7sHNqbOkSrlsgAHh/4RJEh6eeEWD6vu32lWl/PKo YOBjM0vbk67HUxlmpaz/qMDgga855xSU8Pz11Da77ozqHMRuirU1K/yChWUAPqzaPiKfmzJkauZ cJyvLW6/aIVm6XaSZNLJOTCNYZ3uEgN5qQakflYR9U+5UqtwcIBvdTCbTUxNwJfUltPVPgmS2A7 RkusJCo1eiLg4RgOw1gsBI9dEt1jIHNLD8MZMFNLnegxsJtCekzhSW1nihRdu35q5Y2pfGuHEWj khiAjKwn1FrkJyEM+M0YqHoC/+Dqk9NjgpUp43vvl1B1QHi2kEZbpc9P2kE4Ep+xraR9u3T8uY4 6q0aHEhAGxEh9vYbOUq1iZ+Q2HfMexVQF6ONt7La8U+1mSDHTM/GIIHeQGDA0jN2VAFoc6nVCEN GJFeC39Cj1hBX84i+Hl9HF9I5Cn9H2sKVxUAyBtqvC5EkoXOGtaCOPyNY4uWtlJF35ObRtT5+L5 MyQM4d7JhXUKyww== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -2 X-Spam_score: -0.3 X-Spam_bar: / X-Spam_report: (-0.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.58, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1785098781552158500 Use the same trick used by Linux (https://git.kernel.org/pub/scm/linux/kern= el/git/torvalds/linux.git/commit/?id=3Dfcc22ac5baf06dd17193de44b60dbcee): use the compound statement expression with "goto" jumping past the "loop", effectively leaving only the subscope part of the loop semantics. The old loop had to handle auto_unlock to set the var to NULL, but now it can rely on autoptr. Suggested-by: Akihiko Odaki Signed-off-by: Marc-Andr=C3=A9 Lureau --- include/qemu/lockable.h | 19 ++++++++++++------- include/qemu/rcu.h | 17 +++++++++++------ 2 files changed, 23 insertions(+), 13 deletions(-) diff --git a/include/qemu/lockable.h b/include/qemu/lockable.h index 66713bd42921..2704a1ec077d 100644 --- a/include/qemu/lockable.h +++ b/include/qemu/lockable.h @@ -130,11 +130,15 @@ static inline void qemu_lockable_auto_unlock(QemuLock= able *x) =20 G_DEFINE_AUTOPTR_CLEANUP_FUNC(QemuLockable, qemu_lockable_auto_unlock) =20 -#define WITH_QEMU_LOCK_GUARD_(x, var) \ - for (g_autoptr(QemuLockable) var =3D \ - qemu_lockable_auto_lock(QEMU_MAKE_LOCKABLE_NONNULL((x))); \ - var; \ - qemu_lockable_auto_unlock(var), var =3D NULL) +#define WITH_QEMU_LOCK_GUARD_(x, var, label) \ + for (g_autoptr(QemuLockable) var =3D \ + qemu_lockable_auto_lock( \ + QEMU_MAKE_LOCKABLE_NONNULL((x))); \ + ; ({ goto label; })) \ + if (0) { \ + label: \ + break; \ + } else =20 /** * WITH_QEMU_LOCK_GUARD - Lock a lock object for scope @@ -158,8 +162,9 @@ G_DEFINE_AUTOPTR_CLEANUP_FUNC(QemuLockable, qemu_lockab= le_auto_unlock) * ... * } */ -#define WITH_QEMU_LOCK_GUARD(x) \ - WITH_QEMU_LOCK_GUARD_((x), glue(qemu_lockable_auto, __COUNTER__)) +#define WITH_QEMU_LOCK_GUARD(x) \ + WITH_QEMU_LOCK_GUARD_((x), glue(qemu_lockable_auto, __COUNTER__), \ + glue(qemu_lockable_label_, __COUNTER__)) =20 /** * QEMU_LOCK_GUARD - Lock an object until the end of the scope diff --git a/include/qemu/rcu.h b/include/qemu/rcu.h index 020dbe4d8b77..41d02255ceae 100644 --- a/include/qemu/rcu.h +++ b/include/qemu/rcu.h @@ -178,12 +178,17 @@ static inline void rcu_read_auto_unlock(RCUReadAuto *= r) =20 G_DEFINE_AUTOPTR_CLEANUP_FUNC(RCUReadAuto, rcu_read_auto_unlock) =20 -#define WITH_RCU_READ_LOCK_GUARD() \ - WITH_RCU_READ_LOCK_GUARD_(glue(_rcu_read_auto, __COUNTER__)) - -#define WITH_RCU_READ_LOCK_GUARD_(var) \ - for (g_autoptr(RCUReadAuto) var =3D rcu_read_auto_lock(); \ - (var); rcu_read_auto_unlock(var), (var) =3D NULL) +#define WITH_RCU_READ_LOCK_GUARD() \ + WITH_RCU_READ_LOCK_GUARD_(glue(_rcu_read_auto, __COUNTER__), \ + glue(_rcu_read_label_, __COUNTER__)) + +#define WITH_RCU_READ_LOCK_GUARD_(var, label) \ + for (g_autoptr(RCUReadAuto) var =3D rcu_read_auto_lock(); \ + ; ({ goto label; })) \ + if (0) { \ + label: \ + break; \ + } else =20 #define RCU_READ_LOCK_GUARD() \ g_autoptr(RCUReadAuto) _rcu_read_auto __attribute__((unused)) =3D rcu_= read_auto_lock() --=20 2.55.0 From nobody Mon Sep 28 02:05:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1785098785; cv=none; d=zohomail.com; s=zohoarc; b=Voe/Aa1iTdyAxMIzD2vZWRvcGEt7hZpocOnOt66KqKLhF6F0qDpu/nQBIY+YK2dpY7tC+MNddsPnUnSoRfwMFATouRuaIIvk0yL5k0Wt0dAKQcO9VPIib+fVP3Gk6MJaOqpA7X3ygRm2naXQCoZ+L/kjOzR8DiqOVt4BZeTrqN4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785098785; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=E/POaYwIz7h1//1YrnKweU5fHiZe4sgfVD5NET1i974=; b=T2WF14s9u6R3vBf2kx/1yIXawVRTI+rCeys2Auyr10cjl/9azWwb8Cw5R7BmAbB292c1tlKhPBrhhypFRnty4/Ykr6FPPQEWBTpjottjbiNRgjFKtK33DEepKqRN+OdEb5Jw/j+EOvdJrKtVuWmkPN3a4H+ZGjHSMRSTKm2dQaA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1785098785227919.5717525664237; Sun, 26 Jul 2026 13:46:25 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wo5iV-00083D-Ro; Sun, 26 Jul 2026 16:44:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wo5iV-00082x-4u for qemu-devel@nongnu.org; Sun, 26 Jul 2026 16:44:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wo5iT-0004BI-Qw for qemu-devel@nongnu.org; Sun, 26 Jul 2026 16:44:58 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-458-BjhnSJ1GPq6lxd1wDejhgQ-1; Sun, 26 Jul 2026 16:44:53 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 99C671800590; Sun, 26 Jul 2026 20:44:50 +0000 (UTC) Received: from localhost (unknown [10.44.24.5]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0495318001E0; Sun, 26 Jul 2026 20:44:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785098697; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E/POaYwIz7h1//1YrnKweU5fHiZe4sgfVD5NET1i974=; b=Wh7de3EERW3FuFple8rpmu/KfK1H/AEE+a81XO7T7wySEDxtwwfKbGniYayNHUUGDGpQs6 KEnIQF7YENLIcixRp8BCBJyMLfeq/peS+HMLVBxFPBOFOoddNLsR8HMRXcK4kUN0MnDr5/ 7KGZUkKZbjh3Dda9YJgocg4M4rmG1NM= X-MC-Unique: BjhnSJ1GPq6lxd1wDejhgQ-1 X-Mimecast-MFC-AGG-ID: BjhnSJ1GPq6lxd1wDejhgQ_1785098691 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Jul 2026 00:44:04 +0400 Subject: [PATCH v2 05/12] hw/cxl: fix invalid free on early return MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260727-fix2-v2-5-d0c4831ed7ea@redhat.com> References: <20260727-fix2-v2-0-d0c4831ed7ea@redhat.com> In-Reply-To: <20260727-fix2-v2-0-d0c4831ed7ea@redhat.com> To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , =?utf-8?q?Alex_Benn=C3=A9e?= , Akihiko Odaki , Dmitry Osipenko , Stefan Hajnoczi , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org, Jonathan Cameron , Paolo Bonzini , Fam Zheng , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Zhao Liu , Roman Bolshakov , Phil Dennis-Jordan , Wei Liu , linux-cxl@vger.kernel.org, Brian Cain , Pierrick Bouvier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Peter Xu , Fabiano Rosas , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=778; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=BvH11bAGqVafjw/9JvRuhekLdJbHoBFg9BIf/wU6vRM=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqZnGXHbn11IZQ/CDpUaKI05AbxWrb9OZgBYekD XuyRkyAFmWJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCamZxlwAKCRDa6OEJdZac 5TYkEAC0/2zRf5blPzTCAoJEW0pHJuoT9U8kH4ZlWJmNB3kkCelOXhj4bOA+ruA/vDQ84R1H6DB naJaP6PBqRfjYiDIzb11fNEqGIvqeo3GpQZfgDwn0UYjrBmQxNLzPst8NURBymGu75UmKEiYIWz l89a4uaSsUqPRlXyOmzjxDUL2c6OqMSJkCVx9WaDVRqhIlMaW8MkdUCsW8ezdLScTWNSJnQw0yJ 7SpNkb9o/iTFiV0Txec3oqoxoSaQD2foMqM8V8a4AQMyUNA6ug0i3v4L8sgfDadt1pO6GR/2eA+ yL5uzreMw/jotkO8M11vR/GlsvmYa0Uj7knOrCBTs37cy+axWflxBK3/k0V2RdpywlfMwHz9O9K w9jwOiaYELCwHcWmfZObOWAt9m31trcUeJ8iskULfPBrMKef2sR1a/bUcfhBTnuLjWTHaJQq84h 946xKgjQ0zPiEE+dywIZQAukm83YoIekyQDTjZNLmV7SNfurUs778wu9H/x8nnLYO8DVgBa1COu 3+6PYOWkNEvxzy6I1XvrRzjsKbYYlxKeNZ+VJ08v5Nc79pjtYsFi+jDIEb8e6rlb86AblPrin4E K4Wk2O5MzpHmPZtOC2/RwmnpXwIKWrDqtfib+1taDAHhnY0C1+1yZn+eK0qSJQZgVvRHqKjvDrg AQ5C84uCth0eyJQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -36 X-Spam_score: -3.7 X-Spam_bar: --- X-Spam_report: (-3.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.58, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1785098785685158500 Fixes: 680935c9a6ff ("hw/cxl: Add a performant (and correct) path for the n= on interleaved cases") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Akihiko Odaki Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/cxl/cxl-host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/cxl/cxl-host.c b/hw/cxl/cxl-host.c index 7e744312f1d8..eba13c9e7cba 100644 --- a/hw/cxl/cxl-host.c +++ b/hw/cxl/cxl-host.c @@ -279,7 +279,7 @@ static void cxl_fmws_direct_passthrough_setup(CXLDirect= PTState *state, MemoryRegion *mr =3D NULL; uint64_t vmr_size =3D 0, pmr_size =3D 0, offset =3D 0; MemoryRegion *direct_mr; - g_autofree char *direct_mr_name; + g_autofree char *direct_mr_name =3D NULL; unsigned int idx =3D state->hdm_decoder_idx; =20 if (ct3d->hostvmem) { --=20 2.55.0 From nobody Mon Sep 28 02:05:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1785098851; cv=none; d=zohomail.com; s=zohoarc; b=aIRvBtdQWeDACDcxHalhYuDA5XP6639lk46yIjNd7jdks7FW1GIC/4akA/c0gnHoHrLSlQWOYVJtbYEb8jTjTZppNnD19BOm4l0L+hsexUh7h2z4lRYhZRt96AExongqxcplQPSt54sN9sZgL7n47Ypoc9BYjomDCU5s2gX77rE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785098851; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=u5JdBKnDUC0tRVlexJlfFKHyzLpG60H+XeK97IeZmTM=; b=DqnOKAWke6h8L5HenecS3E6dWxot3nLdYZPw9RZEYLUogvo9XJnhb6UBGS3GtWkde5aWEIgcfbdWf5x5jqN8nls5iZW0SEqRXVqClSrdUfyL+f40QeTKbncexACQFXTzpUVFUZG0SZj/gSuk9legI/CBiS3OXnZSVI/Yf3c5lZA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1785098851302401.96546717552746; Sun, 26 Jul 2026 13:47:31 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wo5ic-0008A5-Fg; Sun, 26 Jul 2026 16:45:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wo5ia-00087W-Kr for qemu-devel@nongnu.org; Sun, 26 Jul 2026 16:45:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wo5iZ-0004C9-4c for qemu-devel@nongnu.org; Sun, 26 Jul 2026 16:45:04 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-508-P7Uo06K4NSC0igOr9KJzpw-1; Sun, 26 Jul 2026 16:44:59 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C7E3418005BA; Sun, 26 Jul 2026 20:44:56 +0000 (UTC) Received: from localhost (unknown [10.44.24.5]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 71EA61956047; Sun, 26 Jul 2026 20:44:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785098702; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u5JdBKnDUC0tRVlexJlfFKHyzLpG60H+XeK97IeZmTM=; b=dmGDcfKw+HtVsbAclDcx9f/s8MpCcFsrSbZ2BVO0nAjKRzpqpQ7xV7cE+M7G4OF0WnR2E5 Mxz+PdEaqkf4/7Ayr5eJPHz5pITvqwPLOpQFAT5zVhkcRYqKLGSPJxBhzDN6wr9PQhGEeV 2qCSa9z3Osb8lyiawblDd64Gr5ogv2o= X-MC-Unique: P7Uo06K4NSC0igOr9KJzpw-1 X-Mimecast-MFC-AGG-ID: P7Uo06K4NSC0igOr9KJzpw_1785098696 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Jul 2026 00:44:05 +0400 Subject: [PATCH v2 06/12] hw/i3c: fix default return value of d2_i3c_send() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260727-fix2-v2-6-d0c4831ed7ea@redhat.com> References: <20260727-fix2-v2-0-d0c4831ed7ea@redhat.com> In-Reply-To: <20260727-fix2-v2-0-d0c4831ed7ea@redhat.com> To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , =?utf-8?q?Alex_Benn=C3=A9e?= , Akihiko Odaki , Dmitry Osipenko , Stefan Hajnoczi , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org, Jonathan Cameron , Paolo Bonzini , Fam Zheng , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Zhao Liu , Roman Bolshakov , Phil Dennis-Jordan , Wei Liu , linux-cxl@vger.kernel.org, Brian Cain , Pierrick Bouvier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Peter Xu , Fabiano Rosas , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=671; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=yLUYCOVVGOOzvkcMBJDU+EkijY7q7UFVkrLi3+nOZyw=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqZnGXzCOsJ4UKngjdieqOOoqYb+7p0YsyJGWAa zSctAlLU+mJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCamZxlwAKCRDa6OEJdZac 5U6SD/9ZiIj1kKHx72+YPi6++0gcQKFWDo07L8J/vSGP9PLw1OjpJsYO1+JSP3ZhSDUg+IavGLW xB1LZ/VrZVDy8vG9It1Y9GJYpHX95IfJuJAuSgVhvUQJ5qZTxYF9w+rc30pZwrExeUzo8g9oCUX EPBuS7iaa9OF+SpEcc33UvW/bprKIKm+ltBVMF0U6Laq5FvJYhljDEnY54cW8U6uTbGb8AGAimy YLCp9bPAghEgfLCZY+UXVrydpYKA/mQNOwLMZmNbLtH7rN0+euH0w2+aMxZ20ULGz+9IT1wgqYS jBpAf5u0Ymt12hq3wxguch6LiMB/C3RhQ9AbruW6JgkxW5s6FkxB/OJRgJacq75KGdkhY8MLjPN 3ODGX950kl+zpsoGH3Bd2BK14XzPXtygb2bGrUjO7WgDKZ38Gbo1jSzlQX9NIGesgOCrhBfdg99 F8wHNbcKJH23L+LvJbMnTmsa7hcSPxz5P0yNNE01B0SLNR2m/pNQ7z2NBJx6eX6HaM3leBnFFFf OwVD5nj2ULMMg3lv9qddX7dGgsCsDYPhgoT80OM3nGW+Ts58dgtGD6m1RwSx2RZU1mxD2hDvUAX KLogy3MGtIJv/LDpqgcZPMRIDSOFZntq7YNDxgKUWhhm57maFkhKh2QVc6Cq7h19Nol6ttMTCWd 2GJmNIwb0el05jg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -36 X-Spam_score: -3.7 X-Spam_bar: --- X-Spam_report: (-3.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.58, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1785098851721158500 Fixes: 208772a189f9 ("hw/i3c/dw-i3c: Add data TX and RX") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/i3c/dw-i3c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i3c/dw-i3c.c b/hw/i3c/dw-i3c.c index 6386499dd9fc..7b887fbd60cb 100644 --- a/hw/i3c/dw-i3c.c +++ b/hw/i3c/dw-i3c.c @@ -430,7 +430,7 @@ static int dw_i3c_send_start(DWI3C *s, uint8_t addr, bo= ol is_recv, bool is_i2c) static int dw_i3c_send(DWI3C *s, const uint8_t *data, uint32_t num_to_send, uint32_t *num_sent, bool is_i2c) { - int ret; + int ret =3D 0; uint32_t i; =20 *num_sent =3D 0; --=20 2.55.0 From nobody Mon Sep 28 02:05:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1785098783; cv=none; d=zohomail.com; s=zohoarc; b=WKLCO56ujyZLQH/EYly1yvRGwwcljl2Ot3Rxd/J7UdOeZe84ChlCKQfNIZCdngQouEKDj/7gCXzC4Li+HOLU3SbT1VWmZnpc1weCYhCOTp3EsMVvr1GWQhwr+dl6ihMOmgRR9C8a8SEQwzXQ8+uPTcN+hQQzprDWGEBeym/TO5M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785098783; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=+FFIp2SBJj7/UmITR6GElKqfeokWCJ3beC16SLLIWMY=; b=eTSecgDNGxaznGnkpMZQqbuN3Dz2UemfpGzrrXDtkT+j/MnGomJ8iFWMQDOuzdD/dtbCmyJ6/LeCStI1F6NEWstGKwSSabVSOECB0JeEEYw8rnC4n80ywilj6H00egtalcu/K9CC6cJtt8CRucTn2tWbGcU0Rp9OFZMIwr+UZ2Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1785098783606670.6608880944221; Sun, 26 Jul 2026 13:46:23 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wo5ii-0008CU-75; Sun, 26 Jul 2026 16:45:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wo5ig-0008Bd-SI for qemu-devel@nongnu.org; Sun, 26 Jul 2026 16:45:10 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wo5if-0004O8-E5 for qemu-devel@nongnu.org; Sun, 26 Jul 2026 16:45:10 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-34-SXfvALBEOgO8GzBQWRvcbg-1; Sun, 26 Jul 2026 16:45:05 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 939971955F01; Sun, 26 Jul 2026 20:45:02 +0000 (UTC) Received: from localhost (unknown [10.44.24.5]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8B77419560AB; Sun, 26 Jul 2026 20:45:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785098708; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+FFIp2SBJj7/UmITR6GElKqfeokWCJ3beC16SLLIWMY=; b=d9eUFR7cxRmwYZbxxVIBUHFWhWeIwQ4LIBbLel9oXgyWYbHz9wj2YXjtGFpSs0QU8C5iCp rg+zGjSlCHaODJe7M4i8MvHCQ6vqO3W9JfnwmlrnzLWFYBdWPeEMUcnODhTs0eGX/kQyKb l1bS40IFncIuqhQSu6XjqkdHzsqjqdY= X-MC-Unique: SXfvALBEOgO8GzBQWRvcbg-1 X-Mimecast-MFC-AGG-ID: SXfvALBEOgO8GzBQWRvcbg_1785098703 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Jul 2026 00:44:06 +0400 Subject: [PATCH v2 07/12] Fix some -Werror=maybe-uninitialized MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260727-fix2-v2-7-d0c4831ed7ea@redhat.com> References: <20260727-fix2-v2-0-d0c4831ed7ea@redhat.com> In-Reply-To: <20260727-fix2-v2-0-d0c4831ed7ea@redhat.com> To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , =?utf-8?q?Alex_Benn=C3=A9e?= , Akihiko Odaki , Dmitry Osipenko , Stefan Hajnoczi , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org, Jonathan Cameron , Paolo Bonzini , Fam Zheng , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Zhao Liu , Roman Bolshakov , Phil Dennis-Jordan , Wei Liu , linux-cxl@vger.kernel.org, Brian Cain , Pierrick Bouvier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Peter Xu , Fabiano Rosas , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1803; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=3UnWZex6baDzxFVuUrTLJxfd3oiqd2OltWOdP/euIvM=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqZnGXzJ0ABEJmKJsuXsfXQAGERWo8tNNTFGByc JHhjqKvqcOJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCamZxlwAKCRDa6OEJdZac 5SpYEACJH1ameo9+zi+gvE2TYQV/5Rnkbi+pq0DNMvr3n2gHRm9HYCvTbYghyNbND/7wzjF8bVw d4CylRj13bri14R7cvmOKxT4AiRWNOPo7DBUmTZByXdxHd1iLYgPpMRuzNirJSu1YeKnsYBpV4k ZB32b3FlbOzQxaBXiClHdDZ1pqoLYb3YVoAtvT/S6umIxEzYVVhw9OBzm5K0+JZVTkl+Ny6yJY+ S92cvphIO3im9VMutVJpnRHGA9uAGXZXwprk1efpQEWfGZsSnM6YTZuk6Y/nWDDC6RL4KQEGPFR jDu6MNA2KwQDDyQ5IwJRGVxqnbUdJA7/UCCiRzrIWRaa4NpH/l+Zv6MCXrXSoFBh8LbciBh5MeI KmBw0QDxK69trDgPpaqxi0Azuv3Qu9TbOzfFf6U7zKzo+3tr4QKXhMC+3yLNM1aukxVH2HK1N6U yOLZxZxNPvFonjx91Be1KiWJUG86iV6CouCeuWNlxwc//3hSixcLvYGfVMQHC620mWGbl/kQ+ib zu55xP0PR7oFVKAkrSSn+lL2U+nEzIEUHAXYCxnNnkagGoT1yV6+8NImV2Bx5KZTPAX1pylJDmz PIW5kkYMr2NumoNyF57sJFjLlhpF3Cy0l86nFJ/Ulk65JNnnsEIYNgUqckUJjjhtuh5vv0OADJm +zpaTFFRkp7JHSw== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -2 X-Spam_score: -0.3 X-Spam_bar: / X-Spam_report: (-0.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.58, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1785098785677158500 When compiled with -Og, gcc produces many false-positives gcc (GCC) 16.1.1 20260515 (Red Hat 16.1.1-2). We already use auto-var-init=3Dzero, but better be explicit. Signed-off-by: Marc-Andr=C3=A9 Lureau --- target/i386/cpu.c | 3 ++- target/i386/emulate/x86_mmu.c | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 5805d33ab92d..28e4435df23f 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -7734,7 +7734,7 @@ static void x86_cpuid_get_avx10_version(Object *obj, = Visitor *v, static bool x86_cpu_apply_avx10_features(X86CPU *cpu, uint8_t version, Error **errp) { - const AVX10VersionDefinition *def; + const AVX10VersionDefinition *def =3D NULL; CPUX86State *env =3D &cpu->env; =20 if (!version) { @@ -7757,6 +7757,7 @@ static bool x86_cpu_apply_avx10_features(X86CPU *cpu,= uint8_t version, break; } } + assert(def !=3D NULL); =20 if (def->version < version) { error_setg(errp, "avx10-version can be at most %d", def->version); diff --git a/target/i386/emulate/x86_mmu.c b/target/i386/emulate/x86_mmu.c index 8d4371467fd7..65bcccd4751e 100644 --- a/target/i386/emulate/x86_mmu.c +++ b/target/i386/emulate/x86_mmu.c @@ -185,8 +185,8 @@ static MMUTranslateResult walk_gpt(CPUState *cpu, targe= t_ulong addr, MMUTranslat int largeness =3D 0; target_ulong cr3 =3D x86_read_cr(cpu, 3); uint64_t page_mask =3D pae ? PAE_PTE_PAGE_MASK : LEGACY_PTE_PAGE_MASK; - MMUTranslateResult res; - =20 + MMUTranslateResult res =3D MMU_TRANSLATE_PAGE_NOT_MAPPED; + memset(pt, 0, sizeof(*pt)); top_level =3D gpt_top_level(cpu, pae); =20 --=20 2.55.0 From nobody Mon Sep 28 02:05:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1785098823; cv=none; d=zohomail.com; s=zohoarc; b=WxHq6RvYv3fART7ZnuIO/Nw9Hb2XQP0GqNp/USzcqK5VP/OhwTyR44BIWhLcQyUaVfGaXPKb0Xd0CARsgVmbDu8U12PThQMpCqgqot7ZpjxAP73GoaIC/PpVS6aUGbtNwZKTs/Ri257/9Qe52IeVcugk3uiFjAbsDTpmrzdW+zI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785098823; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=5wYVe5coY+/gP5ZW+DnrDyDBSPmW8qWvLqlbb+wP5hE=; b=btU8iSZJK5k1AL7NAc28Z9GR8baSl1CaLSFVqgM+oWDgG4eMJ5rECMxtGkh5LrTYEHxWhjZidhG6KIcO0okSahBpVtbUAh1XK26nzQqKMxB8dJHBrlFjBwk1aC6ydZKsVWwYAhJr8xs/rNFoNinqNbtVFSazRl6W7i56NM8phcA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1785098823032197.81810274711756; Sun, 26 Jul 2026 13:47:03 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wo5in-0008La-Nm; Sun, 26 Jul 2026 16:45:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wo5im-0008Jo-Dc for qemu-devel@nongnu.org; Sun, 26 Jul 2026 16:45:16 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wo5il-0004P8-0X for qemu-devel@nongnu.org; Sun, 26 Jul 2026 16:45:16 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-230-oNRUeo_LOfSNNKM-VRXetg-1; Sun, 26 Jul 2026 16:45:10 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D7C5F1954B35; Sun, 26 Jul 2026 20:45:07 +0000 (UTC) Received: from localhost (unknown [10.44.24.5]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 76D5619560AB; Sun, 26 Jul 2026 20:45:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785098714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5wYVe5coY+/gP5ZW+DnrDyDBSPmW8qWvLqlbb+wP5hE=; b=CfFaWNzJyKcgHWJVTS6QQr3kpIHhKTBe9tc2u1zHMkIqooqPSAhBKiwIIYLvREgHk9UOf+ gJ8is+8wly7qoYh6JkNiHRmlgSLe81beeUTSBpgbVj6wK/vXlNNQDUDczkbJJMFh9a3Ko2 NpugPZHoDEaYWDIYhInTmcDuFV67kbk= X-MC-Unique: oNRUeo_LOfSNNKM-VRXetg-1 X-Mimecast-MFC-AGG-ID: oNRUeo_LOfSNNKM-VRXetg_1785098708 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Jul 2026 00:44:07 +0400 Subject: [PATCH v2 08/12] hw/hexagon: fix machine->fdt leak in qom-test MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260727-fix2-v2-8-d0c4831ed7ea@redhat.com> References: <20260727-fix2-v2-0-d0c4831ed7ea@redhat.com> In-Reply-To: <20260727-fix2-v2-0-d0c4831ed7ea@redhat.com> To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , =?utf-8?q?Alex_Benn=C3=A9e?= , Akihiko Odaki , Dmitry Osipenko , Stefan Hajnoczi , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org, Jonathan Cameron , Paolo Bonzini , Fam Zheng , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Zhao Liu , Roman Bolshakov , Phil Dennis-Jordan , Wei Liu , linux-cxl@vger.kernel.org, Brian Cain , Pierrick Bouvier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Peter Xu , Fabiano Rosas , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1778; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=sHbc1QFubXFvCqldzNTjZD5Y3aSuMfriFlxuneTvSTA=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqZnGXGk6SvtrQGOkQAChwsOc7oRmQrtBARLsPr glA40doeoSJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCamZxlwAKCRDa6OEJdZac 5ctCEACiiHpn1U1s4n1r6sQSG5lKVEW8A5zMYdjwsHzdcY6oanhHI3iemp+JK0Bhb6Qd7I6HNpi TUX2sP5efuZCZw9DR0nHwsUitVvOu/i4IyrGGzaA8vJqEQtx2bKZS+TC2KFzsDFTQXwe/bUWxND F1Q69uIyHc4NpC58Bv3lnq1Nzau4pYxrnxfTxNc2HD2GmegXATZoMLukSQQ4C9FzizP4nWHtZbk tWBrvCt7+pTAoE7rdSCgnpppGibWM6G1k2hMU0jwNq48AXYZrVtbxD/MpbpZ9iTpCUpqBVQ1cUc jsAxwRDK/keseA3ETQO4BvlbNsmaHAVx5oqsqGWk78zS5cj5hGzsE55V2ivRFzxJYzDKXHZ3KrL CxVouIUnQhifCpNzDUxa5paf3dv9LGczsgnrgHw+DnrhAOl1WPTxUlKO2A2liFmwebF2gphm07q TXaaLPFLCF9XS81I8/zBB4vd2RzKezENRHYPpfw74J9zAVg6ogd9dxJspNwcOAZ/C2NcXtu21oJ 6BIMwwMWpcomLYqxtM9PtqidOcVCtbsBKUyZSRjskgKDYUBYIqgYp674nRwq+cXX9kyh1gFSe3l yLeFthtAjP80MNea+FwR+MGlufwtxTgNPZfRCJp36nmgveu6yqtdWDubgJtGJPfhc9KbIUaqPcd qRuBofHkfP3CCbQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -2 X-Spam_score: -0.3 X-Spam_bar: / X-Spam_report: (-0.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.58, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1785098823692158500 virt_instance_init() built the FDT unconditionally at QOM instance-init time, so simply instantiating the object (e.g. via qom-test's introspection, without ever realizing the machine) leaked the 1MB FDT blob: machine_finalize() does not free machine->fdt. Other boards (arm/virt, riscv/virt, ...) build the FDT lazily from their MachineClass::init callback, which only runs when the machine is actually selected to boot. Do the same here by moving create_fdt() into virt_init(). Fixes: 88a8bc7f43ff ("hw/hexagon: Define hexagon "virt" machine") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/hexagon/virt.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/hw/hexagon/virt.c b/hw/hexagon/virt.c index a3638998b873..b75047250260 100644 --- a/hw/hexagon/virt.c +++ b/hw/hexagon/virt.c @@ -175,13 +175,6 @@ static void fdt_add_cpu_nodes(const HexagonVirtMachine= State *vms) =20 =20 =20 -static void virt_instance_init(Object *obj) -{ - HexagonVirtMachineState *vms =3D HEXAGON_VIRT_MACHINE(obj); - - create_fdt(vms); -} - void hexagon_load_fdt(const HexagonVirtMachineState *vms) { MachineState *ms =3D MACHINE(vms); @@ -242,6 +235,7 @@ static void virt_init(MachineState *ms) DeviceState *cpu0; int32_t clk_phandle; =20 + create_fdt(vms); qemu_fdt_setprop_string(ms->fdt, "/chosen", "bootargs", ms->kernel_cmd= line); =20 vms->sys =3D get_system_memory(); @@ -341,7 +335,6 @@ static const TypeInfo virt_machine_types[] =3D { { .parent =3D TYPE_HEXAGON_COMMON_MACHINE, .instance_size =3D sizeof(HexagonVirtMachineState), .class_init =3D virt_class_init, - .instance_init =3D virt_instance_init, } }; =20 DEFINE_TYPES(virt_machine_types) --=20 2.55.0 From nobody Mon Sep 28 02:05:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1785098869; cv=none; d=zohomail.com; s=zohoarc; b=gKwvQex8S6F0A4jrQSFzaTmn07JDjZIj2cBcDdkF1AlODGx3jLKLI1IdOog+5E7SOOMDGhN0h6hZke5fsfZ06xAX3pX+nNhzO+GHQu0xeGgVTrbqExfQnyopW3zhPm2m6fft4pyFZpjgmMdnt14x9OAnU2HenXeHdmq2C1P/qu8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785098869; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=s7WPHlfybK9wgT6X16AjorCstp8vZ/94rL5kznfJWio=; b=S1DLm3cc4kfN6PbRYM6ArRB621N/azI9r0XAO1yN40zOYnWhVbzOamyXD6aDPGZNvxzCjuPVaO2w5ZESV7dkz2ISwzMAuCHHL5SvXI/ZN/4qE3qYYEsvBcLI0p6xGLBtTpyrkSRrAZLnmHG4B6pJT1cSQpFE6BI4r2oEjHPfeDM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1785098869056851.8749352503628; Sun, 26 Jul 2026 13:47:49 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wo5j3-0008QF-41; Sun, 26 Jul 2026 16:45:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wo5it-0008Pk-B8 for qemu-devel@nongnu.org; Sun, 26 Jul 2026 16:45:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wo5ir-0004QM-Ez for qemu-devel@nongnu.org; Sun, 26 Jul 2026 16:45:23 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-665-sq1FeV81PO6gnCoRPG_YDA-1; Sun, 26 Jul 2026 16:45:16 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A82EB1956068; Sun, 26 Jul 2026 20:45:13 +0000 (UTC) Received: from localhost (unknown [10.44.24.5]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B835A180049F; Sun, 26 Jul 2026 20:45:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785098720; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s7WPHlfybK9wgT6X16AjorCstp8vZ/94rL5kznfJWio=; b=IRsNaB2NxdlJXkSkSoIJxGqtDUqWAzAtPxuH0euCAylILUCu528p0e0iBC5RmHB4Htn4pP YW5dIlifn7xSFjlQx+BPn+Q9ChHQBh+65kC4myfMS3VPsN0Q9MCojjS7kNg0a4cLskBV4p PD7IOJXgF+qrK4VGcG5KIbkAlXnzD1I= X-MC-Unique: sq1FeV81PO6gnCoRPG_YDA-1 X-Mimecast-MFC-AGG-ID: sq1FeV81PO6gnCoRPG_YDA_1785098714 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Jul 2026 00:44:08 +0400 Subject: [PATCH v2 09/12] hw/ppc: fix dangling fdt reference MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260727-fix2-v2-9-d0c4831ed7ea@redhat.com> References: <20260727-fix2-v2-0-d0c4831ed7ea@redhat.com> In-Reply-To: <20260727-fix2-v2-0-d0c4831ed7ea@redhat.com> To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , =?utf-8?q?Alex_Benn=C3=A9e?= , Akihiko Odaki , Dmitry Osipenko , Stefan Hajnoczi , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org, Jonathan Cameron , Paolo Bonzini , Fam Zheng , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Zhao Liu , Roman Bolshakov , Phil Dennis-Jordan , Wei Liu , linux-cxl@vger.kernel.org, Brian Cain , Pierrick Bouvier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Peter Xu , Fabiano Rosas , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1191; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=xVw6bhj6Lyb5iaDKjsHTyu75/0clDHHxVE1UNjqqjMw=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqZnGX2Y+rWTiYiQt1e+yf1EHsB+qZXRe7kZsoO SpPByrEy0mJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCamZxlwAKCRDa6OEJdZac 5RB/EACr+9Kc6bCEszt9T3iHIwv94R/fghtv5Kp9Yh1KBXH0pg2Up9jaSZldWAwW3Uk8hkCs1YZ p3J864iaDVaiulOz91BUVcXWc+lf4i5J0CcldHsrMqNVEp5ugXAUnbIkHdFQ3IEYeqiCRzETpzl 2jbjAIIABmyQyqp+QWG7w7fHnAl+BTWk3/NilkDd1UJFPUGLWtazpVrBkExzRm0Cn6mW3YNh+vY O4PEmtY6OxCkVx+c8HLg7y4uHS1daWlcC3QThwKl7ayMkL2D+eO8Kupom7OUAvpxrlTxkTQVPsv 8vEB0jOXYriXcL7eazHDL0u/F/XU4zsQMevwM8B4/ZaacGIJDScRA4LTRCpH28t1wZF29aW0nIG 7rKEYuGcTIW1+ZgIefsC5gXWcUeLGPSIzrEPZ+19JCgKKhGLwd2Om27/KLTvic3qoYoD/WeKbXP aDUk9jCQZss/2F3WoxR7w/wk4l4QfbjA7NYgiUmceBhWk/T+xGC/DTwq+vUGuEsFlS33wLAK2X6 y7q8dlu/CWQQCAjafpoBdbVBq6hShuLeR4mISm01dM99TVtmTSHxnX44sWPXFn4QXHukX2+osk4 qDx3OxmmNzlB/6QsnafaeVhIYJqSRnIIQLsjXe1aINRgwHAYwk0zZLKFntXG0Iii3145tIOcNbg /2/VKc7644O4fUw== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -2 X-Spam_score: -0.3 X-Spam_bar: / X-Spam_report: (-0.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.58, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1785098869791158500 machine->fdt is aliasing fdt_blob. We need to make sure it is cleared or updated when we free fdt_blob. Fixes: d890f2fa9f1e ("hw/ppc: set machine->fdt in spapr machine") Reported-by: Akihiko Odaki Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/ppc/spapr.c | 1 + hw/ppc/spapr_hcall.c | 1 + 2 files changed, 2 insertions(+) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index b79828b4e90c..2fa4db3d493a 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -2137,6 +2137,7 @@ static int spapr_dtb_pre_load(void *opaque) g_free(spapr->fdt_blob); spapr->fdt_blob =3D NULL; spapr->fdt_size =3D 0; + MACHINE(spapr)->fdt =3D NULL; =20 return 0; } diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c index 23bcd788daf6..2ed063279200 100644 --- a/hw/ppc/spapr_hcall.c +++ b/hw/ppc/spapr_hcall.c @@ -1511,6 +1511,7 @@ static target_ulong h_update_dt(PowerPCCPU *cpu, Spap= rMachineState *spapr, g_free(spapr->fdt_blob); spapr->fdt_size =3D cb; spapr->fdt_blob =3D fdt; + MACHINE(spapr)->fdt =3D fdt; trace_spapr_update_dt(cb); =20 return H_SUCCESS; --=20 2.55.0 From nobody Mon Sep 28 02:05:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1785098763; cv=none; d=zohomail.com; s=zohoarc; b=WPPT3P9qVv9ob5exMMAXrYM/CASD2VfLplABE7PqVaxqyCnr0tyXC0bAqT0JjxVZ2VU9t4pMaHyL1OOyVnN9nxc2k/i9qN34p6okVQLluhJLIsQMZkArmlD0QjEoNI8yBpiAis0C9egV3JJ/WROES1AOYPY+5g4UwgnkN6A7AwA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785098763; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=+TTlcmViaW/jr0GgH0ehJXptanXZXliFPnYWOw9ddzY=; b=mM1BWwqRwxCtu43dTd/KJXUWN0k/9moahM71MVxLZz1HiI2mLGPEvjyHYmEi2WkmHm9+jCn/H0/2zx59/OYvYPq8lVoFlgehL1sE9u5fszNvnZdZpYsL1Ea0e0Zjh3dOnkPCcGwAIo/wkytsoYXHD8h/kvWSBfFpgIEVIUmQkTY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1785098763765191.3688717891564; Sun, 26 Jul 2026 13:46:03 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wo5jF-0000C3-R8; Sun, 26 Jul 2026 16:45:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wo5ix-00005a-DV for qemu-devel@nongnu.org; Sun, 26 Jul 2026 16:45:31 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wo5iv-0004RC-RV for qemu-devel@nongnu.org; Sun, 26 Jul 2026 16:45:26 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-610-4FWo0WPTPb6Hu_l50vZDeA-1; Sun, 26 Jul 2026 16:45:21 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AA331195607B; Sun, 26 Jul 2026 20:45:19 +0000 (UTC) Received: from localhost (unknown [10.44.24.5]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A9A3630001BE; Sun, 26 Jul 2026 20:45:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785098725; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+TTlcmViaW/jr0GgH0ehJXptanXZXliFPnYWOw9ddzY=; b=aZFHpBTZgq50zpH5AKfpj5Jm1PaWEs5zovfkTt44vEozHCzzsSCAmNZFhWFdpX+h9QemUP iWsb3G6gT9o/klLfGonHtFGBht4gfxNi43q0HI+pw1PQcMgs/1tRF5yan5dezuKO3AlgQx VxQKAZ5QGNawzMnSsOZPTLbyCjAte2c= X-MC-Unique: 4FWo0WPTPb6Hu_l50vZDeA-1 X-Mimecast-MFC-AGG-ID: 4FWo0WPTPb6Hu_l50vZDeA_1785098719 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Jul 2026 00:44:09 +0400 Subject: [PATCH v2 10/12] hw/core/machine: free machine->fdt in machine_finalize() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260727-fix2-v2-10-d0c4831ed7ea@redhat.com> References: <20260727-fix2-v2-0-d0c4831ed7ea@redhat.com> In-Reply-To: <20260727-fix2-v2-0-d0c4831ed7ea@redhat.com> To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , =?utf-8?q?Alex_Benn=C3=A9e?= , Akihiko Odaki , Dmitry Osipenko , Stefan Hajnoczi , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org, Jonathan Cameron , Paolo Bonzini , Fam Zheng , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Zhao Liu , Roman Bolshakov , Phil Dennis-Jordan , Wei Liu , linux-cxl@vger.kernel.org, Brian Cain , Pierrick Bouvier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Peter Xu , Fabiano Rosas , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=816; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=sIBVNLsGCOna3Hd2Wy4wJ32pRVDvMFiol07f6gVUCMU=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqZnGXv6fr/VusynUuJj+7991gNH6KtKVK0aAzQ YHC1MBl1J2JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCamZxlwAKCRDa6OEJdZac 5Z5QD/4wWnnfTAOKE1y1toBi/3+xqSlAbzCU1yNo25LhIFeg6ovEG7WRWFtpS1JS40df1o4yInL u7AWArOtmKtK4+t8eahOiXoYNo/xoE1P9MGX1pPIv8knrfCrNS2WLr/4mTy+gZVdWJDYkKMNxPc 0wpRzr/a8VT9Mkmb03NFoPR8sNFYq0KpQmd26ItLvA39hBxcpzZjM02PRtg3tUH4EsQnoiv971g u+438RwibEet6RdZXNsaYn0/kzo3D1a6tKguF8mrk9q4zaP54UblrAbgl2jhtBYSunT+IFKlCDj fe3aRKKtNYYKXQEQ26YaoYAJVaupRiRUUNqqcdI4t/fvg/nFfwDsIrQcndIXyafN6DFn++DPnJC hBZILSGXx2rZoYC77dlYghbp53qgYPGzYB8O1R/OHhVUs5MJM2dA4wgoGwlDrrrTCPLzFMZI0fv Yjt/vtrDAjj0Q4NNVnWDnC/OOTcG4dRqBf07sXJS0EFFXN/kWUKVFIfDm4AavoxS+mTs4J91pUH yjQTnw5zTcpdVOldmjZm8Wzcujc2xZyovTdxEuhGkMlH/S3zvWcUSxE6kJLCZNYOjeTpSR+Uc9J hYDXC/aSs6wA/G9M7O8pc/ahqo98Y/BhIT7FozEnQ73laditARDQoPio9M2pSW1Q6SsjdtucKKD yUIrMAEUkf0q+UQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -2 X-Spam_score: -0.3 X-Spam_bar: / X-Spam_report: (-0.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.58, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1785098765517158500 machine->fdt is a plain g_malloc0() buffer (see create_device_tree()) that boards populate during MachineClass::init, but machine_finalize() never freed it, unlike the other boot-time buffers (dtb, dumpdtb, kernel_filename, ...). Free it for consistency. Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/core/machine.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/core/machine.c b/hw/core/machine.c index 805148678d57..2b24d711d76f 100644 --- a/hw/core/machine.c +++ b/hw/core/machine.c @@ -1301,6 +1301,7 @@ static void machine_finalize(Object *obj) g_free(ms->kernel_cmdline); g_free(ms->dtb); g_free(ms->dumpdtb); + g_free(ms->fdt); g_free(ms->dt_compatible); g_free(ms->firmware); g_free(ms->device_memory); --=20 2.55.0 From nobody Mon Sep 28 02:05:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1785098770; cv=none; d=zohomail.com; s=zohoarc; b=HXIWURLPPThb0UXUs4JkjBIoUjyqKX/IdvFzDWQTnCw8o1qZ6EXAKkw62x2nOV4AeZ7e57/I8C2iakHeNvwm2ICjyj9h3K9sWE+uISkT10UGBIF9Mnc4h7IlacrQtz1fpqcw1AckopLJr81Szow16eXnqbSF26aJ86IESmk9MfY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785098770; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=sgwF7jkNJLhj6j+139aaPY14IWX2xoRAqge3G7njsEU=; b=e9jvL/swV7ZtiNc/cilPHyp09wVcNb017uLbaB/91Ivpa8TnyFvBtqkpfCHeLRMWyZ1dZWDuHwB9mGFUMUIrfqFzsvPPyzK7wQ7ki9Q4YOaEI+TLONX/3fI/QVWltCDhU1MgELLCTqlXLvCHMlKSVVdnPh+KUPAOi/j+j6Y6nhU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1785098770607246.00953805508493; Sun, 26 Jul 2026 13:46:10 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wo5ja-0000GZ-Qd; Sun, 26 Jul 2026 16:46:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wo5j5-0000AK-Ea for qemu-devel@nongnu.org; Sun, 26 Jul 2026 16:45:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wo5j3-0004Rv-8F for qemu-devel@nongnu.org; Sun, 26 Jul 2026 16:45:34 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-672-4NpKxJpOMJKlDubQtrOMeg-1; Sun, 26 Jul 2026 16:45:27 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7AB091800590; Sun, 26 Jul 2026 20:45:25 +0000 (UTC) Received: from localhost (unknown [10.44.24.5]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id AEE531956047; Sun, 26 Jul 2026 20:45:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785098732; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sgwF7jkNJLhj6j+139aaPY14IWX2xoRAqge3G7njsEU=; b=h19dBEail9vSgwe7Pq4oQaQ+hx5+oEnykJ7nCXHio2FenbETqRySouA/FoMf94kcIMxkSx uc5xsKTw85G11vPtzI1V8pvS0Rlv+AHSXzQkdJF9xF+buKyKiVf+WKEQWZM8RoYhqm56He ZiQwxcCjGqsq/ezfxRmntsNCVxyoB/8= X-MC-Unique: 4NpKxJpOMJKlDubQtrOMeg-1 X-Mimecast-MFC-AGG-ID: 4NpKxJpOMJKlDubQtrOMeg_1785098725 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Jul 2026 00:44:10 +0400 Subject: [PATCH v2 11/12] migration/multifd: fix Error leak in multifd_recv_terminate_threads() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260727-fix2-v2-11-d0c4831ed7ea@redhat.com> References: <20260727-fix2-v2-0-d0c4831ed7ea@redhat.com> In-Reply-To: <20260727-fix2-v2-0-d0c4831ed7ea@redhat.com> To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , =?utf-8?q?Alex_Benn=C3=A9e?= , Akihiko Odaki , Dmitry Osipenko , Stefan Hajnoczi , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org, Jonathan Cameron , Paolo Bonzini , Fam Zheng , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Zhao Liu , Roman Bolshakov , Phil Dennis-Jordan , Wei Liu , linux-cxl@vger.kernel.org, Brian Cain , Pierrick Bouvier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Peter Xu , Fabiano Rosas , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=654; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=8V4SbETfqA20e58q6VCGWaqhSb6JTXgkzFqcys/62CY=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqZnGXqtL4DYX9fMBDVrhGbWRZ/5vbN92kSAgN+ 0aizcq2HCSJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCamZxlwAKCRDa6OEJdZac 5Y+tD/9qjL26Hwgig0DMmnbLIrFIqE27KE226meUw/u9RE0E3MUY18KW3AcEYHjr6JwdPCQx9oL TkTOszT0vzToFQHDuoPcQZ7zm4YERQxTOtNFEmqbN6LOMSOWG8KhcexF2uga1FsAAQA8daRiDxD eLmnhu4k0JPgSZWsqyLeL+PL4TCLXTDulglfPg4SN44JBsTysPvnKwFbhQFjeMx6OzEbVw+ipb3 sumjSr2mkyEc5UpMu0hS0JUvwLvarPtH6cByPFWnYYBs1yAzkRu1m86r9I9s67tt6VoDGQdBBPn cXqNQiJKfgAUGPuLY6QmugdGhCu4xKR78l0q7zRuCOuNwrjAkXZUESKPlSlAOHhvpCBvzp7ADg7 BpPHvf2gnVKdaAUggS57RD6eCtb2D5QMjsA3dfHvuGVaIJsi9PZov1L+GPbiPR6Dlh+pxdvqnfe MhzchAgRmakbAH6ipHQTy7axxsvHY0LHVnQMW2gDQBzDNpXFaQ6yTCJeMuoua9XvCR1EyDGtRtQ JhLJmfQ3dqV5MMhRDfgoYe8scj0IkgK2luKnkZ3vo441ydpBzfH6rrxfJH7zbLZVrOdd0gE/+Ll wytmCWs74YesvP9HH5uqVTmL6ADR5upoh9OlTKLwZEPBqKEDx6xG5jx5za/B4XH1Tdz/8cD8mCG UAdVFiWx3U0E41g== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -36 X-Spam_score: -3.7 X-Spam_bar: --- X-Spam_report: (-3.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.58, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1785098771523158500 If err !=3D NULL, free it. Fixes: 11dd7be57524 ("migration/multifd: Remove p->quit from recv side") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Fabiano Rosas Reviewed-by: Peter Xu --- migration/multifd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/multifd.c b/migration/multifd.c index dbad525d2a28..503014f76ba5 100644 --- a/migration/multifd.c +++ b/migration/multifd.c @@ -1056,6 +1056,7 @@ static void multifd_recv_terminate_threads(Error *err) trace_multifd_recv_terminate_threads(err !=3D NULL); =20 if (qatomic_xchg(&multifd_recv_state->exiting, 1)) { + error_free(err); return; } =20 --=20 2.55.0 From nobody Mon Sep 28 02:05:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1785098824; cv=none; d=zohomail.com; s=zohoarc; b=TM/V+H5/IzVK3IXzqtgzyCZy1mGPMdg1oW6FnVarG516tL7sA/bAFYWWtGpbOqSN3dL1ga3SOdl2doQUlL8NJ3C6EXxUL9pWnRPedJ4QMcv3n+QPyuFc8vETVPGToH8K+4hDKgewiSVpRoQHClxfn+bkbzcY0RzKTkCsJ1ZH8CA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785098824; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=/1qaXwrZ97SmSwNI4+ReXuIEhgm8sWXcmQboUN67GDk=; b=D1q6jj/bCiMAHQ/T3vjztZi0DjZQTgMX/xVoTJ7PDG4eSV0AIx841D30riiiE5iLXJcGy6ylGg9ZYjzILZ3yXpSJoQ6gZYAW1/ZQVzARUF1c+BwY6TmpTga9jPme8zTe3PfuVrmyroc1X8UfBqyYFwNTnTHFkegLp1YowKUALXk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1785098824092368.3202513254197; Sun, 26 Jul 2026 13:47:04 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wo5jc-0000b3-4p; Sun, 26 Jul 2026 16:46:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wo5jB-0000Av-71 for qemu-devel@nongnu.org; Sun, 26 Jul 2026 16:45:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wo5j9-0004T2-Ih for qemu-devel@nongnu.org; Sun, 26 Jul 2026 16:45:40 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-611-iFhpVBxaMWyFtW2ZHR5y5Q-1; Sun, 26 Jul 2026 16:45:33 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3AFC018007FD; Sun, 26 Jul 2026 20:45:31 +0000 (UTC) Received: from localhost (unknown [10.44.24.5]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id BE22F1956047; Sun, 26 Jul 2026 20:45:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785098738; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/1qaXwrZ97SmSwNI4+ReXuIEhgm8sWXcmQboUN67GDk=; b=jGb8iZZwoXatPw1NAbfAxPEBINtmdtyoAFFxjMCIMgQDrvbS0US5ADIzWvQhg6pK4yO8T8 8C9tm93MYI3cyUPQOZPOrtvDBzT8V7b1vdeDy6Ff7WRoS7IYeQBoILkfVFQ4d7HpFUTvD6 BbSwmSmPpTwOtriGJF5NR8HGiYE5GwM= X-MC-Unique: iFhpVBxaMWyFtW2ZHR5y5Q-1 X-Mimecast-MFC-AGG-ID: iFhpVBxaMWyFtW2ZHR5y5Q_1785098731 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Jul 2026 00:44:11 +0400 Subject: [PATCH v2 12/12] qdev-monitor: drain RCU callbacks in qdev_device_add_from_qdict MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260727-fix2-v2-12-d0c4831ed7ea@redhat.com> References: <20260727-fix2-v2-0-d0c4831ed7ea@redhat.com> In-Reply-To: <20260727-fix2-v2-0-d0c4831ed7ea@redhat.com> To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , =?utf-8?q?Alex_Benn=C3=A9e?= , Akihiko Odaki , Dmitry Osipenko , Stefan Hajnoczi , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org, Jonathan Cameron , Paolo Bonzini , Fam Zheng , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Zhao Liu , Roman Bolshakov , Phil Dennis-Jordan , Wei Liu , linux-cxl@vger.kernel.org, Brian Cain , Pierrick Bouvier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Peter Xu , Fabiano Rosas , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=5862; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=fcpLJyqHW+NBPjd22Abqq192DosvFzwYSWsrX/V2B3w=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqZnGXjUhIMgw39+zUP7myS8AIr8NMr5KcG+Ttc EcD7MASeTqJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCamZxlwAKCRDa6OEJdZac 5U+wD/9+PsTDyw71Fsn83Zo+U1bHBfaQbsh9EQfdc/qxGoGLnhbTTF9ICc+fSNydwdqMGv4WcQl kfQWMbfo2UArbrRdSdPW2IkXj0dNWPGfQ+XjL9BlKDqQknaMU38VO0rAOz7IQj/RUrEjTG6tr0G vxrVnOW7bvbvfxC/IfD1qGvWlt+XPaDF8cMTJSkWkCVX/s3+fCFEbab1XVhWjF1TsHJ1+pbxjV/ OZXDt/nyGL7Dr9aQ7BNPpunzzyOb92UAzfAxVoJ4Naz2tluKb0929GKQSHvvLaVQSDOyFNLreIb En0fsHIhQk5RfuX4XKX4W8GM/NGDfqXtt1nQ6aLVuFcJwZDnzZqQtzVjIHoB+x9UbtgYyVpTkwq MyEXWgJZkcYzxfL1YYxRQWbMUzY7KnxtulYFsl6GwTVZ+abzWMt2ktP1qR0vOjVzblMd6bWYUyC NmVBueISfxAMCtsKWbR1iBAux6nG5k7jw0lLgKMtVyjVHuydwcqudVzFHm2cxj5zRWPBfgZH980 LnqEWshuNFTnwEfWGKuc7PDx5S5mnE9xw0bgg/pVMmNzQ3ZWQ1fGwcEUGcsetWXT34tBPs1I9cI C7ouFzyNa1PYmyOaX+lkgeSf0e88g1XxRbAQEkakdUwVboAnikK2oN27CCuYWW5lE+WYhKPyFyh YXc2EacOuMEht8w== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -36 X-Spam_score: -3.7 X-Spam_bar: --- X-Spam_report: (-3.7 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.58, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1785098825699158500 qmp_device_add() and hmp_device_add() drain pending RCU callbacks after a failed device_add, since some bus teardown (e.g. bus_remove_child()) is deferred to call_rcu(). -device on the command line reaches the same qdev_device_add_from_qdict() with errp pointing at error_fatal, whose ERRP_GUARD() exits before control returns to the caller, so the caller's drain_call_rcu() never runs. Move the drain into qdev_device_add_from_qdict()'s own err_del_dev path and drop the now-redundant calls in qmp_device_add() and hmp_device_add(). Gate it behind a new drain_rcu parameter, because virtio-net failover can reach qdev_device_add_from_qdict() from an MMIO write dispatched under address_space_write()'s RCU read lock. Signed-off-by: Marc-Andr=C3=A9 Lureau --- include/monitor/qdev.h | 3 ++- hw/audio/intel-hda.c | 2 +- hw/net/virtio-net.c | 2 +- system/qdev-monitor.c | 42 ++++++++++++++++-------------------------- 4 files changed, 20 insertions(+), 29 deletions(-) diff --git a/include/monitor/qdev.h b/include/monitor/qdev.h index f85f25738d58..72d2fa4654d3 100644 --- a/include/monitor/qdev.h +++ b/include/monitor/qdev.h @@ -12,7 +12,8 @@ void qmp_device_add(QDict *qdict, QObject **ret_data, Err= or **errp); int qdev_device_help(QemuOpts *opts); DeviceState *qdev_device_add(QemuOpts *opts, Error **errp); DeviceState *qdev_device_add_from_qdict(const QDict *opts, - bool from_json, Error **errp); + bool from_json, bool drain_rcu, + Error **errp); BusState *qdev_find_default_bus(DeviceClass *dc, Error **errp); =20 /** diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c index 3d361a4976c6..128c5ee612ce 100644 --- a/hw/audio/intel-hda.c +++ b/hw/audio/intel-hda.c @@ -1313,7 +1313,7 @@ static void intel_hda_and_codec_init(const char *audi= odev) BusState *hdabus; =20 qdict_put_str(props, "driver", "intel-hda"); - intel_hda =3D qdev_device_add_from_qdict(props, false, &error_fatal); + intel_hda =3D qdev_device_add_from_qdict(props, false, true, &error_fa= tal); hdabus =3D QLIST_FIRST(&intel_hda->child_bus); =20 codec =3D qdev_new("hda-duplex"); diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index f0e3beb29032..0c5da8cb71af 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -916,7 +916,7 @@ static void failover_add_primary(VirtIONet *n, Error **= errp) =20 dev =3D qdev_device_add_from_qdict(n->primary_opts, n->primary_opts_from_json, - &err); + false, &err); if (err) { qobject_unref(n->primary_opts); n->primary_opts =3D NULL; diff --git a/system/qdev-monitor.c b/system/qdev-monitor.c index 00fed791cce1..77508bb1c3f1 100644 --- a/system/qdev-monitor.c +++ b/system/qdev-monitor.c @@ -650,7 +650,8 @@ BusState *qdev_find_default_bus(DeviceClass *dc, Error = **errp) } =20 DeviceState *qdev_device_add_from_qdict(const QDict *opts, - bool from_json, Error **errp) + bool from_json, bool drain_rcu, + Error **errp) { ERRP_GUARD(); DeviceClass *dc; @@ -746,6 +747,18 @@ err_del_dev: object_unparent(OBJECT(dev)); object_unref(OBJECT(dev)); =20 + /* + * Some bus teardown (e.g. bus_remove_child()) is deferred via + * call_rcu(). When safe, drain those callbacks so the failed + * device is fully torn down before we return. Callers that are + * already inside an RCU read-side critical section (e.g. MMIO + * dispatch during virtio-net failover) must pass drain_rcu=3Dfalse + * to avoid deadlocking on the grace period. + */ + if (drain_rcu) { + drain_call_rcu(); + } + return NULL; } =20 @@ -755,7 +768,7 @@ DeviceState *qdev_device_add(QemuOpts *opts, Error **er= rp) QDict *qdict =3D qemu_opts_to_qdict(opts, NULL); DeviceState *ret; =20 - ret =3D qdev_device_add_from_qdict(qdict, false, errp); + ret =3D qdev_device_add_from_qdict(qdict, false, true, errp); if (ret) { qemu_opts_del(opts); } @@ -869,19 +882,7 @@ void qmp_device_add(QDict *qdict, QObject **ret_data, = Error **errp) { DeviceState *dev; =20 - dev =3D qdev_device_add_from_qdict(qdict, true, errp); - if (!dev) { - /* - * Drain all pending RCU callbacks. This is done because - * some bus related operations can delay a device removal - * (in this case this can happen if device is added and then - * removed due to a configuration error) - * to a RCU callback, but user might expect that this interface - * will finish its job completely once qmp command returns result - * to the user - */ - drain_call_rcu(); - } + dev =3D qdev_device_add_from_qdict(qdict, true, true, errp); object_unref(OBJECT(dev)); } =20 @@ -1017,17 +1018,6 @@ void hmp_device_add(Monitor *mon, const QDict *qdict) } dev =3D qdev_device_add(opts, &err); if (!dev) { - /* - * Drain all pending RCU callbacks. This is done because - * some bus related operations can delay a device removal - * (in this case this can happen if device is added and then - * removed due to a configuration error) - * to a RCU callback, but user might expect that this interface - * will finish its job completely once qmp command returns result - * to the user - */ - drain_call_rcu(); - qemu_opts_del(opts); } object_unref(dev); --=20 2.55.0