From nobody Sun Jul 26 10:07:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1784988121; cv=none; d=zohomail.com; s=zohoarc; b=DjLuwMpISptZMZbYF/EaZiqlwvzW/xAgtfQEIunMQ0gBpPV2ptAhB9i5B5kJ/Lt/nzCjkn/NVvXmcr8OV8+6dI/jBD5+ieWj5m1Ri2umVKBVZOSWYhA+By8rHKHz3KJQVK1FQ8XEhX4SY+4/nMqiJF0ixjp+pRb0o5ZY6PYISzc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784988121; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=+2QvmsMbZq6HxVKl0q+cNVQuSts58ffZqW4LJ1FpBXw=; b=FWTLTBVpSdLyPt5kOVm/kXDcaiEwDNME1WLS+KsnfxqXgZBl1hSn5Tc0pjryJFf4oBHHev32Ay02ARm/itFnX+x9ze1mws+yjSb3BrFlWx2c/AT+pfg9/r93IxOqMJs5RJ8PZqWh+D/GBCmG2q2nJOtAyXeK8os4nHeEnTuI5oQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784988121003759.7379483588451; Sat, 25 Jul 2026 07:02:01 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wncvX-0003Xz-G2; Sat, 25 Jul 2026 10:00:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wncvV-0003Xb-Eg for qemu-devel@nongnu.org; Sat, 25 Jul 2026 10:00:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wncvU-00051h-2M for qemu-devel@nongnu.org; Sat, 25 Jul 2026 10:00:29 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-411-UzdeTn1GNI61I7j9eW2ppw-1; Sat, 25 Jul 2026 10:00:23 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EFFE319560BF; Sat, 25 Jul 2026 14:00:19 +0000 (UTC) Received: from localhost (unknown [10.44.22.7]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6E67D180058C; Sat, 25 Jul 2026 14:00:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784988027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+2QvmsMbZq6HxVKl0q+cNVQuSts58ffZqW4LJ1FpBXw=; b=UqGbzuhDK8CuOaIKfsxOGpRhU4WIDasGozZreeaRUI958bseDJXPldhuQ/cTMcfFePCtrp Ya4b+TWCPHs/DkN0GOsT01eSTdh3HJ43LgqY81z443LQBiAH1BtgpzERrnCiPkh7IQLUix B1Rm5sorr71Nqy3jnFbXD/bRuUMWOHA= X-MC-Unique: UzdeTn1GNI61I7j9eW2ppw-1 X-Mimecast-MFC-AGG-ID: UzdeTn1GNI61I7j9eW2ppw_1784988021 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 25 Jul 2026 18:00:02 +0400 Subject: [PATCH 1/7] hw/display/virtio-gpu-rutabaga: zero-init capset info response MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260725-fix2-v1-1-5c9a6ce7b96a@redhat.com> References: <20260725-fix2-v1-0-5c9a6ce7b96a@redhat.com> In-Reply-To: <20260725-fix2-v1-0-5c9a6ce7b96a@redhat.com> To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , =?utf-8?q?Alex_Benn=C3=A9e?= , Akihiko Odaki , Dmitry Osipenko , Stefan Hajnoczi , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org, Jonathan Cameron , Paolo Bonzini , Fam Zheng , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Zhao Liu , Roman Bolshakov , Phil Dennis-Jordan , Wei Liu , linux-cxl@vger.kernel.org, Brian Cain , Pierrick Bouvier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Peter Xu , Fabiano Rosas , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Haotian Jiang X-Developer-Signature: v=1; a=openpgp-sha256; l=1461; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=i6aG/+m9MW1saa93R8BeXUCOlYyxsLU70+4agx0S76E=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqZMFl6n3FXGeka2GqVWAr7DfN3yU1cJsO+7fyG ZCXBCbeNSqJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCamTBZQAKCRDa6OEJdZac 5TQNEAC5lnm/WyMGw3mTaHRhojYRmDb8uhNbmYbgBkqHeUv2WmoN/gszPoL7+u0gtJZ8Hl15Sjr zj90sK1yghWmWEQ+7+eMB/bLoU2rtYGmba6QJ9UevBGIjx4Cy0n2UXjr4naa1T4zCXDNa93Qt5w Ebjiks3mliMcjA50OHg4HfJtPr54eXPM6eWtLnFxx/wrvR6qCCAo3dxcy6GFsx/iBP6H61DT0EN PiqtIqgaN58UEC2ouYpcEyaxW9BcDwRj4MIAx8W2gu9iHhUZSmjhCHpY/Vu8uuUPdBSN8sOiMwt WzalKhKY5FWgD26ZQdy7UhksxSVAlIEytj+cd1ArTwsp7hYYYcbE+Y3Y1U8npYOndfey9oz+YU4 CrK7Gkz4wDHoFqvSk0otXOiOnDjXBmv4ma2EbardiBYqwTrXBmnjqroWjiqAJvcBEQfVKYlvjph hMH7TVO1IcGnbWPHtktoG1yKWy46bJ73vHIhJnW+/lCEj4bES7p5oDevwSL6BjFUD2u99b+duHq BH0wSpvZAP+ZykceZlfHfg4o96sj+spXrDdW1CcoLzpl2pjnm7abvM+P8UG7E6yTOyRp3fawqo8 3kGT3he1dKmZlcxitCW1h7aLM+/1LhMHJwu/iYmz7LZPvBd2FMTCYiSbPh0ggzoSkde6YqPbx/c foJ/baWu3fdsvsg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -1 X-Spam_score: -0.2 X-Spam_bar: / X-Spam_report: (-0.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.419, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1784988124309154100 rutabaga_cmd_get_capset_info() only fills in capset_id, capset_max_version and capset_max_size before sending the response to the guest. The remaining fields of struct virtio_gpu_resp_capset_info, including hdr.fence_id, hdr.ctx_id and hdr.ring_idx, are left with stack garbage and leaked to the guest, including host pointers useful for an ASLR bypass. Zero the response first, matching virgl_cmd_get_capset_info(). Not a real risk thanks to -ftrivial-auto-var-init=3Dzero. Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3609 Fixes: 1dcc6adbc168 ("gfxstream + rutabaga: add initial support for gfxstre= am") Reported-by: Haotian Jiang Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Akihiko Odaki --- hw/display/virtio-gpu-rutabaga.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/display/virtio-gpu-rutabaga.c b/hw/display/virtio-gpu-rutab= aga.c index 4d7d7b245929..95a19eed7eda 100644 --- a/hw/display/virtio-gpu-rutabaga.c +++ b/hw/display/virtio-gpu-rutabaga.c @@ -555,6 +555,8 @@ rutabaga_cmd_get_capset_info(VirtIOGPU *g, struct virti= o_gpu_ctrl_command *cmd) =20 VIRTIO_GPU_FILL_CMD(info); =20 + memset(&resp, 0, sizeof(resp)); + result =3D rutabaga_get_capset_info(vr->rutabaga, info.capset_index, &resp.capset_id, &resp.capset_max_ve= rsion, &resp.capset_max_size); --=20 2.55.0 From nobody Sun Jul 26 10:07:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1784988125; cv=none; d=zohomail.com; s=zohoarc; b=aiYQ/Ibfp3UkILByPhsCtXn+pR+tmoHyghQJc7ptFfGtm7mtgxvS4+SoT54INK+dxl9DuliGZY8qMlv8zJJma31j7++zziwQAm1T9d8jIhVoNZ6xGKvXm6C2BjGWL8YtfeTNF3tBAUGL1o2E9emxYhwRGjTzcHqvbNq6S3uhNqU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784988125; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ZqYGAMQYTE7NgCivyeQuW01dQY8Lzslgx4hiMYj0PE0=; b=QH8JabMI1QiDIzyuEwACVCN7OsS0bZYpDiZE4trAnPyGznGeyE3nSiTYjY9H8miNeL6tdl99xoeNXW8bMWcuvvGC0tvkBRb3VaFlfXgqNyQ8UJD6iaPnPYVZpCLkGzLffyrzVllv/mYqpchP2qc8oiPLgtDJjcbjHKF1vr+CABA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784988125611414.61131994334164; Sat, 25 Jul 2026 07:02:05 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wncws-00059M-A4; Sat, 25 Jul 2026 10:01:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wncwg-00053z-NY for qemu-devel@nongnu.org; Sat, 25 Jul 2026 10:01:44 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wncwe-000586-8k for qemu-devel@nongnu.org; Sat, 25 Jul 2026 10:01:41 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-155-RXRoJnUNOCi3x4xGMBHJ7A-1; Sat, 25 Jul 2026 10:00:29 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1EE8A18002A2; Sat, 25 Jul 2026 14:00:27 +0000 (UTC) Received: from localhost (unknown [10.44.22.7]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7A216195422A; Sat, 25 Jul 2026 14:00:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784988099; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZqYGAMQYTE7NgCivyeQuW01dQY8Lzslgx4hiMYj0PE0=; b=NDVnN/Ek3vgSu2pgwfZAR23Z/GPpMPw4yfQtM8ADfsqzRg8npvMHd3M1Z6YqOxZ0++nmgY azNGshMwoTLhDBFVY3Gk9EP5/SI0jIUwaVn55rwtXkCxef8wz+pQJ2Ng7mSqubDxPUDOlr Gf6G9CAIPUfPg1+B0MNCTGwqetVMs50= X-MC-Unique: RXRoJnUNOCi3x4xGMBHJ7A-1 X-Mimecast-MFC-AGG-ID: RXRoJnUNOCi3x4xGMBHJ7A_1784988027 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 25 Jul 2026 18:00:03 +0400 Subject: [PATCH 2/7] block/blkio: fix error return value on getlength() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260725-fix2-v1-2-5c9a6ce7b96a@redhat.com> References: <20260725-fix2-v1-0-5c9a6ce7b96a@redhat.com> In-Reply-To: <20260725-fix2-v1-0-5c9a6ce7b96a@redhat.com> To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , =?utf-8?q?Alex_Benn=C3=A9e?= , Akihiko Odaki , Dmitry Osipenko , Stefan Hajnoczi , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org, Jonathan Cameron , Paolo Bonzini , Fam Zheng , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Zhao Liu , Roman Bolshakov , Phil Dennis-Jordan , Wei Liu , linux-cxl@vger.kernel.org, Brian Cain , Pierrick Bouvier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Peter Xu , Fabiano Rosas , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1054; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=mk7xOY7MrP6hzIZ9/rwfiY5pmK/wzv9sLr3O7waARAo=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqZMFl3l+pb8+oFbJ8vFGbzbVFnDmVOYYa1trpI EI5hHN9bT2JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCamTBZQAKCRDa6OEJdZac 5SF6D/9Fbz48ox7+C5SOvyXLlKChpwF+aIQtuyeE7dl1B+1zJ3hR6HBf9Ur7fotHIwFuzTbybjq ePsAqcsWTP4X1PfTTvMRmjU9MeTFmfFO5kPaxF/DpTGZwish/jZgcbg5/MP6BDS7kr2Hs05v21s zIT3vgQrzXkeD5pVIG4q/qzDoFm1mwdNMPteUstuo1GnG29/sQMmfAaw9WRPN09tMBi586pUn2R AlmX2LczK0mgxjVvh0+5zpx6yOL0uiXqWTZ5+2BY5H44Wx5rRm5Dg6easLcXccix+PyLP1dIbU8 67BifWKhf4vHoiJbownhFmP0iLpZaos/J8qYwrGn5E38hmxroFTU9v2zbn1BuP5S5ONU/39UDh0 13CMv7kZk/2KlEeymGvlTbChRorkgxXlrutYqTQRymTzNxBuPKyuL+O4VDR7flCrf2PM02SclYa 0wwqgJ5iDdT0ov/Jo6ZfucWWJ2Y8FArGg+2wQLPIARKEgC7e8YLsW5IsKYu4O1+w45eBocINcGj 6rcV0dMVY09KdEJdGVwwFZvL9aX9ucwLUNOj73nZIn28DTBKvt0uLhffLhRFXlDNlP/28HtBdl7 ZbOYr+oRp7G7QDbxvW9+inZRNEa77v7qhyuYuNpB1x5+NfMOfeEaUMdo3ZD3nvy4oa85ATckw+m 8gSLleNfUYrVPCA== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.419, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1784988128394154100 Negative values should be return for errors. It also helps with GCC false-positives: ../block/blkio.c: In function =E2=80=98blkio_co_getlength=E2=80=99: ../block/blkio.c:943:8: error: =E2=80=98ret=E2=80=99 may be used uninitiali= zed [-Werror=3Dmaybe-uninitialized] 943 | if (ret < 0) { | ^ Fixes: fd66dbd424 ("blkio: add libblkio block driver") Signed-off-by: Marc-Andr=C3=A9 Lureau --- block/blkio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/blkio.c b/block/blkio.c index fb8bec27d71a..d2ba2a4d58dc 100644 --- a/block/blkio.c +++ b/block/blkio.c @@ -935,13 +935,13 @@ static int64_t coroutine_fn blkio_co_getlength(BlockD= riverState *bs) { BDRVBlkioState *s =3D bs->opaque; uint64_t capacity; - int ret; + int ret =3D -1; =20 WITH_QEMU_LOCK_GUARD(&s->blkio_lock) { ret =3D blkio_get_uint64(s->blkio, "capacity", &capacity); } if (ret < 0) { - return -ret; + return ret; } =20 return capacity; --=20 2.55.0 From nobody Sun Jul 26 10:07:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1784988084; cv=none; d=zohomail.com; s=zohoarc; b=dNJS4BABFyZJiVXtnYo/uyaSlz2ey3su2D21xhdpEVBPbKdwJxlC9uZds8FgcXgoEqEFw9hxPqbWOQqlxpBosQOk8Ysalnyz0lwWsLDoNhZWM3kb5+tMAt6RDmKbzVz6zq168Tfq5eoW7HP8Jqt0t6VNHQGRMY55FVMbz+N4aUA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784988084; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=AtLVIwc0ChM1DAVD/TK9Kdk+EW2zZ0ZeWIrt7VGyKwA=; b=VSAKavu9gxwN+XgIB6JHsMdEGMA2QoSHiJlRpdOgqcHj/bECg+QCq4gXlLDYFL2hTgtpBSE22/NC4d79HzovaG8fzP71Bu7ZIu5eLk320fz+dnWveqAZNZGGh33toY/byN6AaCwvD+0twx86kgJKLG7ZyZ8xGGyIZdvX3OUUAVA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784988084678360.1703431146576; Sat, 25 Jul 2026 07:01:24 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wncvk-0003Zv-4J; Sat, 25 Jul 2026 10:00:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wncvi-0003ZN-2j for qemu-devel@nongnu.org; Sat, 25 Jul 2026 10:00:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wncvg-00052c-FA for qemu-devel@nongnu.org; Sat, 25 Jul 2026 10:00:41 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-73-x8aZ-dWwN-uPiL_crLLRfA-1; Sat, 25 Jul 2026 10:00:35 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 324E919560B3; Sat, 25 Jul 2026 14:00:33 +0000 (UTC) Received: from localhost (unknown [10.44.22.7]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2D23D180057F; Sat, 25 Jul 2026 14:00:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784988039; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AtLVIwc0ChM1DAVD/TK9Kdk+EW2zZ0ZeWIrt7VGyKwA=; b=O0in+3H7CQBE7qr/QZYsCuGOJS4EkwmPUNunF/vawxNFt/cQdt8AgHx26GJBwq/X+O2Oti gQKvJcrxtZs1gg3bf4Y2DXaVI/CTQB1QfYRQkMe48RoWJINmGw+uaGKUWIhW4I8O4Qw0IO ISJ7h58v/arkk7KT3m8EhxCViGqXXRU= X-MC-Unique: x8aZ-dWwN-uPiL_crLLRfA-1 X-Mimecast-MFC-AGG-ID: x8aZ-dWwN-uPiL_crLLRfA_1784988033 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 25 Jul 2026 18:00:04 +0400 Subject: [PATCH 3/7] Fix many -Werror=maybe-uninitialized MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260725-fix2-v1-3-5c9a6ce7b96a@redhat.com> References: <20260725-fix2-v1-0-5c9a6ce7b96a@redhat.com> In-Reply-To: <20260725-fix2-v1-0-5c9a6ce7b96a@redhat.com> To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , =?utf-8?q?Alex_Benn=C3=A9e?= , Akihiko Odaki , Dmitry Osipenko , Stefan Hajnoczi , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org, Jonathan Cameron , Paolo Bonzini , Fam Zheng , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Zhao Liu , Roman Bolshakov , Phil Dennis-Jordan , Wei Liu , linux-cxl@vger.kernel.org, Brian Cain , Pierrick Bouvier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Peter Xu , Fabiano Rosas , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=6067; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=cHf62MM7xs8MyYaKCneLSpmy1ZQnYtBo02wawGmze8I=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqZMFlCWxHn7jIomyURmJuovkpyjcBlkf/N5odt oLz9/9EtPmJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCamTBZQAKCRDa6OEJdZac 5Y0vD/0SR5HxF/C+Z0FR/NpAEwtvAKL/to877Y2j6riXG+XLJGlctWPOti3dSsJ2We4/6N0phS4 jX+SrUb7I3yTddkVQJ1ANziFWaCtAefJazJHT2ZPzH9fELWM+6q4oSOBUREBowYo/KiMHqBSbmA eyNjbN7xd+t5AV8oQ2/Ldl6zRx24TovNrqCWGRLd0ebp78O+Mqq6S41tyYa/z0e1U9CFxtIb3Ue Y9rRJ6b+Be4JkfgFD9RQKCxcS3m/6ENa41I5NRRVZzNsTqC8lIMGDmtpaXqQGrkOPb1oY/Dg1YM +qp4kZFfOU0fRkGsXYrCbjP7QXJ5FXpOC0+9KId/cPH4pDq7Q1MoApbO9f3C2SrF0JVBqAGd6/P 6tAyz2TFDbqEBCo5Uzoff/5Z7GhrMejYrCkE/6291iWv1fw5pyPJDOXiW6YdQPH85YcWHazzwpC 6Ca5rg2yEZehVMQwsRPUrf8SSQvI3XcijEsIbEcVjO/hrQOb5RJFwFBJvT5NPJ8aVVvQouzKel0 2YABqudcIlWwGFtVCExjnY31NZpAxLjxHD6VUqT6JUsoi3hwKAXX36+jPYIumVPTy+/yWCNASAB 9vuz22kVOruymo1ap02Nu86OIC0N4AnDW/sIQ3wEAM/mOnJDWzuL0/1i/NDwnHcbCdt4JRGbs+t 3DEggiEc3Vykt+A== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -1 X-Spam_score: -0.2 X-Spam_bar: / X-Spam_report: (-0.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.419, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1784988088227154100 When compiled with -Og, gcc produces many false-positives gcc (GCC) 16.1.1 20260515 (Red Hat 16.1.1-2). We already use auto-var-init=3Dzero, but better be explicit. Signed-off-by: Marc-Andr=C3=A9 Lureau --- block/blkio.c | 4 ++-- block/qcow2.c | 2 +- hw/cxl/cxl-host.c | 2 +- hw/scsi/scsi-disk.c | 2 +- hw/scsi/scsi-generic.c | 4 ++-- hw/scsi/virtio-scsi.c | 2 +- io/net-listener.c | 10 +++++----- target/i386/cpu.c | 3 ++- target/i386/emulate/x86_mmu.c | 4 ++-- 9 files changed, 17 insertions(+), 16 deletions(-) diff --git a/block/blkio.c b/block/blkio.c index d2ba2a4d58dc..f7cb6e0b57d4 100644 --- a/block/blkio.c +++ b/block/blkio.c @@ -278,7 +278,7 @@ static bool blkio_completion_fd_poll(void *opaque) { BlockDriverState *bs =3D opaque; BDRVBlkioState *s =3D bs->opaque; - int ret; + int ret =3D -1; =20 /* Just in case we already fetched a completion */ if (s->poll_completion.user_data !=3D NULL) { @@ -559,7 +559,7 @@ static bool blkio_register_buf(BlockDriverState *bs, vo= id *host, size_t size, BDRVBlkioState *s =3D bs->opaque; struct blkio_mem_region region; BlkioMemRegionResult region_result; - int ret; + int ret =3D -1; =20 /* * Mapping memory regions conflicts with RAM discard (virtio-mem) when diff --git a/block/qcow2.c b/block/qcow2.c index 19271b10a49f..639593d737c8 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -838,7 +838,7 @@ static const char *overlap_bool_option_names[QCOW2_OL_M= AX_BITNR] =3D { static void coroutine_fn cache_clean_timer(void *opaque) { BDRVQcow2State *s =3D opaque; - uint64_t wait_ns; + uint64_t wait_ns =3D 0; =20 WITH_QEMU_LOCK_GUARD(&s->lock) { wait_ns =3D s->cache_clean_interval * NANOSECONDS_PER_SECOND; diff --git a/hw/cxl/cxl-host.c b/hw/cxl/cxl-host.c index 7e744312f1d8..eba13c9e7cba 100644 --- a/hw/cxl/cxl-host.c +++ b/hw/cxl/cxl-host.c @@ -279,7 +279,7 @@ static void cxl_fmws_direct_passthrough_setup(CXLDirect= PTState *state, MemoryRegion *mr =3D NULL; uint64_t vmr_size =3D 0, pmr_size =3D 0, offset =3D 0; MemoryRegion *direct_mr; - g_autofree char *direct_mr_name; + g_autofree char *direct_mr_name =3D NULL; unsigned int idx =3D state->hdm_decoder_idx; =20 if (ct3d->hostvmem) { diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 1b0cce128c5e..82dc75cb7d10 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -3263,7 +3263,7 @@ static bool scsi_disk_pr_state_needed(void *opaque) { SCSIDiskState *s =3D opaque; SCSIPRState *pr_state =3D &s->qdev.pr_state; - bool ret; + bool ret =3D false; =20 if (!s->qdev.migrate_pr) { return false; diff --git a/hw/scsi/scsi-generic.c b/hw/scsi/scsi-generic.c index 8999f3b72006..b044561ae2dd 100644 --- a/hw/scsi/scsi-generic.c +++ b/hw/scsi/scsi-generic.c @@ -553,8 +553,8 @@ bool scsi_generic_pr_state_preempt(SCSIDevice *s, Error= **errp) SCSIPRState *pr_state =3D &s->pr_state; Error *local_err =3D NULL; bool check_stale_key =3D true; - uint64_t key; - uint8_t resv_type; + uint64_t key =3D 0; + uint8_t resv_type =3D 0; =20 /* Get the migrated PR state */ WITH_QEMU_LOCK_GUARD(&pr_state->mutex) { diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index 6c7376801190..833f773d7f6c 100644 --- a/hw/scsi/virtio-scsi.c +++ b/hw/scsi/virtio-scsi.c @@ -1093,7 +1093,7 @@ static void virtio_scsi_push_event(VirtIOSCSI *s, =20 static void virtio_scsi_handle_event_vq(VirtIOSCSI *s, VirtQueue *vq) { - bool events_dropped; + bool events_dropped =3D false; =20 WITH_QEMU_LOCK_GUARD(&s->event_lock) { events_dropped =3D s->events_dropped; diff --git a/io/net-listener.c b/io/net-listener.c index 1fd0f6cb5ab8..8df19c35bd8f 100644 --- a/io/net-listener.c +++ b/io/net-listener.c @@ -54,11 +54,11 @@ static gboolean qio_net_listener_channel_func(QIOChanne= l *ioc, gpointer opaque) { QIONetListener *listener =3D QIO_NET_LISTENER(opaque); - QIOChannelSocket *sioc; - QIONetListenerClientFunc io_func; - gpointer io_data; - GMainContext *context; - AioContext *aio_context; + QIOChannelSocket *sioc =3D NULL; + QIONetListenerClientFunc io_func =3D NULL; + gpointer io_data =3D NULL; + GMainContext *context =3D NULL; + AioContext *aio_context =3D NULL; =20 sioc =3D qio_channel_socket_accept(QIO_CHANNEL_SOCKET(ioc), NULL); diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 5805d33ab92d..e9759ab25077 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -7734,7 +7734,7 @@ static void x86_cpuid_get_avx10_version(Object *obj, = Visitor *v, static bool x86_cpu_apply_avx10_features(X86CPU *cpu, uint8_t version, Error **errp) { - const AVX10VersionDefinition *def; + const AVX10VersionDefinition *def =3D NULL; CPUX86State *env =3D &cpu->env; =20 if (!version) { @@ -7758,6 +7758,7 @@ static bool x86_cpu_apply_avx10_features(X86CPU *cpu,= uint8_t version, } } =20 + assert(def !=3D NULL); if (def->version < version) { error_setg(errp, "avx10-version can be at most %d", def->version); return false; diff --git a/target/i386/emulate/x86_mmu.c b/target/i386/emulate/x86_mmu.c index 8d4371467fd7..c1cb385b3228 100644 --- a/target/i386/emulate/x86_mmu.c +++ b/target/i386/emulate/x86_mmu.c @@ -185,8 +185,8 @@ static MMUTranslateResult walk_gpt(CPUState *cpu, targe= t_ulong addr, MMUTranslat int largeness =3D 0; target_ulong cr3 =3D x86_read_cr(cpu, 3); uint64_t page_mask =3D pae ? PAE_PTE_PAGE_MASK : LEGACY_PTE_PAGE_MASK; - MMUTranslateResult res; - =20 + MMUTranslateResult res =3D 0; + memset(pt, 0, sizeof(*pt)); top_level =3D gpt_top_level(cpu, pae); =20 --=20 2.55.0 From nobody Sun Jul 26 10:07:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1784988118; cv=none; d=zohomail.com; s=zohoarc; b=bGNgy7uhCj7zSWxLDx+wrNzZqLXU9ORAPzvcwc5c7qkSL/fwdSUMPhOMVW2ilQHgS5kHHGBltltcVRv8WN7MXPwb0lErNIbB5q+u40llwdEYt4z43p0xQ1zh6xAR/4fYaJmzktEGikTS7uJsVqGQPAkyIuI58HJvt94WqENlNMU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784988118; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=5wYVe5coY+/gP5ZW+DnrDyDBSPmW8qWvLqlbb+wP5hE=; b=ai0aTqBXqNdOh1QQWBq6leyr3QVmG+wOPMztSDdM3XIm7dTI9K5jbXiWq8qiiTg4oz78XIqM/Z8kgwaYeN1ETZniZ5Wv8SmbKPmBg4xqwq2ilKF+ceUrHZxjC+lxOId9SpTNfHkWS8QjF2hr7YvAdLPVdCeOOMMsHvB4PMnWmj4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784988118218253.46830855276175; Sat, 25 Jul 2026 07:01:58 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wncvp-0003bA-MW; Sat, 25 Jul 2026 10:00:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wncvo-0003at-Fb for qemu-devel@nongnu.org; Sat, 25 Jul 2026 10:00:48 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wncvn-000531-6r for qemu-devel@nongnu.org; Sat, 25 Jul 2026 10:00:48 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-583-HSljVq6cNuityrvDnuqJnw-1; Sat, 25 Jul 2026 10:00:41 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A2631195608E; Sat, 25 Jul 2026 14:00:38 +0000 (UTC) Received: from localhost (unknown [10.44.22.7]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4B4F3190BAD8; Sat, 25 Jul 2026 14:00:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784988046; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5wYVe5coY+/gP5ZW+DnrDyDBSPmW8qWvLqlbb+wP5hE=; b=d8Qmk8nN837mZ95x4axckf5o1YDgVFCYXvM7wucySuJWz/Djk4K1DS+cqXZGny0MHNJr2B 2Qr451o5kEhknjy5oKJbjpL0pNJ8Xsbe4i9JxrU+GGp1q5qva7uruf7J6oMFSpG46jTkl8 fdjt6ouPn7jcOdDA8N6VoX0I5oBGuOc= X-MC-Unique: HSljVq6cNuityrvDnuqJnw-1 X-Mimecast-MFC-AGG-ID: HSljVq6cNuityrvDnuqJnw_1784988038 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 25 Jul 2026 18:00:05 +0400 Subject: [PATCH 4/7] hw/hexagon: fix machine->fdt leak in qom-test MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260725-fix2-v1-4-5c9a6ce7b96a@redhat.com> References: <20260725-fix2-v1-0-5c9a6ce7b96a@redhat.com> In-Reply-To: <20260725-fix2-v1-0-5c9a6ce7b96a@redhat.com> To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , =?utf-8?q?Alex_Benn=C3=A9e?= , Akihiko Odaki , Dmitry Osipenko , Stefan Hajnoczi , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org, Jonathan Cameron , Paolo Bonzini , Fam Zheng , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Zhao Liu , Roman Bolshakov , Phil Dennis-Jordan , Wei Liu , linux-cxl@vger.kernel.org, Brian Cain , Pierrick Bouvier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Peter Xu , Fabiano Rosas , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1778; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=sHbc1QFubXFvCqldzNTjZD5Y3aSuMfriFlxuneTvSTA=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqZMFmccR1sOhKJLjubdgeqiWoOQhkY4UNOtveg jPMRqeZwE6JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCamTBZgAKCRDa6OEJdZac 5YaZD/0RpfmrTuzTydjwDRCPi61LJoY4ZXv9qHeMGA4RKwU57PH/dDnYoYLk/n7TuGOLNCOweT9 P1GOBp4WxUp8P9N1eigROTqHwWqbawa7o8OHbMi1RXkUOkR3IVJ/VY/EbjvTw433iTR6ibsuhK0 42hUVCgzCyv988GNwlKsh3xKAB5FvWN2bsq34XYZW8Drev+lgF37VsxqvCJZVHntUL6vL7TcSrZ JH1l9jpMT0F8gRYXX/HMKv7VSqiupP6MAxwm7Z6tusmHsZrh4oRC2JME79fDaTCXO5AEi+i/A31 Nxr7a6eSmnWdYHON5DcmzLR8VkL2GXxtq7n9EyKHpRajp8+pLL50ZcgFx7pe0YsEZOmV+GLSSy4 W3ytHVKnxpy7exY/iQpLW2GR4FZQC5DE5JsduCVXxqvCoaPNzCLm4alsocU/4DEciWmVMcKEQVg D01+2k3Cb9GUv5ED37Zq68KVOlmoxEB5MSP5E2YiNoSml5sCA+uma3hnZcDnXXe3DEBHvP+g5Ww c2Be4LvG7EY4iHaZoPppaZpDUkPPMAS0jMLSga8Qm/NIrhi014iYVUtdYu/XyVat7w3bDliLTUV rTvSjo0i8g5zDi2kReYPTOE/u6nWLYGhd5mij3FPqsqH6Z42NpZh5uN2LU8XAVVpDQP3GTZcAxT NMIfYli77pmQn/Q== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -1 X-Spam_score: -0.2 X-Spam_bar: / X-Spam_report: (-0.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.419, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1784988120420154100 virt_instance_init() built the FDT unconditionally at QOM instance-init time, so simply instantiating the object (e.g. via qom-test's introspection, without ever realizing the machine) leaked the 1MB FDT blob: machine_finalize() does not free machine->fdt. Other boards (arm/virt, riscv/virt, ...) build the FDT lazily from their MachineClass::init callback, which only runs when the machine is actually selected to boot. Do the same here by moving create_fdt() into virt_init(). Fixes: 88a8bc7f43ff ("hw/hexagon: Define hexagon "virt" machine") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/hexagon/virt.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/hw/hexagon/virt.c b/hw/hexagon/virt.c index a3638998b873..b75047250260 100644 --- a/hw/hexagon/virt.c +++ b/hw/hexagon/virt.c @@ -175,13 +175,6 @@ static void fdt_add_cpu_nodes(const HexagonVirtMachine= State *vms) =20 =20 =20 -static void virt_instance_init(Object *obj) -{ - HexagonVirtMachineState *vms =3D HEXAGON_VIRT_MACHINE(obj); - - create_fdt(vms); -} - void hexagon_load_fdt(const HexagonVirtMachineState *vms) { MachineState *ms =3D MACHINE(vms); @@ -242,6 +235,7 @@ static void virt_init(MachineState *ms) DeviceState *cpu0; int32_t clk_phandle; =20 + create_fdt(vms); qemu_fdt_setprop_string(ms->fdt, "/chosen", "bootargs", ms->kernel_cmd= line); =20 vms->sys =3D get_system_memory(); @@ -341,7 +335,6 @@ static const TypeInfo virt_machine_types[] =3D { { .parent =3D TYPE_HEXAGON_COMMON_MACHINE, .instance_size =3D sizeof(HexagonVirtMachineState), .class_init =3D virt_class_init, - .instance_init =3D virt_instance_init, } }; =20 DEFINE_TYPES(virt_machine_types) --=20 2.55.0 From nobody Sun Jul 26 10:07:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1784988116; cv=none; d=zohomail.com; s=zohoarc; b=j4klT3mCl7Z5LOqmBSc4M67FP3KZGR3KHL7GOH4ukdGHmbJStJhCWuVDxR7rPFVq47sU4ydNGkymOoLhyOa65vBI+ocd0cq7YY1x34XRzF6bAw2X8HJRfwDWAqKXh9rQZrsPZ9uK6LIpN7BeryKwctwhvfZPuCha4AHG8IXKvAY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784988116; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=+TTlcmViaW/jr0GgH0ehJXptanXZXliFPnYWOw9ddzY=; b=KEt5iqBcpbcYIIq6MPjR5pmcYJYM7yJ6BVIW8SuL6mkGnSq2mtgYmqr1j7x4QuuG7CjpI5qd9tEhtjAEDQq4lmi4w5NPIWW+5J8r6acV0k2zHtycu6TjimfO5ezJiBQuGdkDPbEGDkxTyghpYeONwR48unch/F3aknP3ygGEJns= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784988116728828.2525175040032; Sat, 25 Jul 2026 07:01:56 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wncw2-0003fR-1y; Sat, 25 Jul 2026 10:01:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wncvw-0003cO-7K for qemu-devel@nongnu.org; Sat, 25 Jul 2026 10:00:57 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wncvu-00053l-U1 for qemu-devel@nongnu.org; Sat, 25 Jul 2026 10:00:55 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-442-WH263RbIOW2pp-hkSTLwBA-1; Sat, 25 Jul 2026 10:00:48 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 56BDD19560BF; Sat, 25 Jul 2026 14:00:45 +0000 (UTC) Received: from localhost (unknown [10.44.22.7]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 103BA1591; Sat, 25 Jul 2026 14:00:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784988054; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+TTlcmViaW/jr0GgH0ehJXptanXZXliFPnYWOw9ddzY=; b=iBDYGROvXbG/JGSAFI1jXLS2PmdZ4qy7bBjz9TuNZ22oY0RQsXEwxZwmm5D0nuUDWqwnTm KzlICp+B796/sBxiukTCBBXgYTZkOfHzsYCWyHp8Lp3MRoouf2VQjXemsnG/25kix4cMIF Zwq7YZpwLGbsn+jSvso5K6BJ3jlZFYs= X-MC-Unique: WH263RbIOW2pp-hkSTLwBA-1 X-Mimecast-MFC-AGG-ID: WH263RbIOW2pp-hkSTLwBA_1784988046 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 25 Jul 2026 18:00:06 +0400 Subject: [PATCH 5/7] hw/core/machine: free machine->fdt in machine_finalize() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260725-fix2-v1-5-5c9a6ce7b96a@redhat.com> References: <20260725-fix2-v1-0-5c9a6ce7b96a@redhat.com> In-Reply-To: <20260725-fix2-v1-0-5c9a6ce7b96a@redhat.com> To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , =?utf-8?q?Alex_Benn=C3=A9e?= , Akihiko Odaki , Dmitry Osipenko , Stefan Hajnoczi , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org, Jonathan Cameron , Paolo Bonzini , Fam Zheng , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Zhao Liu , Roman Bolshakov , Phil Dennis-Jordan , Wei Liu , linux-cxl@vger.kernel.org, Brian Cain , Pierrick Bouvier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Peter Xu , Fabiano Rosas , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=816; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=sIBVNLsGCOna3Hd2Wy4wJ32pRVDvMFiol07f6gVUCMU=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqZMFmXwTAgpjiHXIDQP2F6pFQaQP0mTaHjVngT nIkCxm+8KOJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCamTBZgAKCRDa6OEJdZac 5d3oEAC1km7RbdV4XtCIKL8zA60V13xVkEzvtfqeWr/f9ALV+CqbVUN/wGdnv+8tnxmdT/YhVLx LifdyHD0stZaS22zhP+OIRFbMi/WKRzf7cYTyZsiyTpUm+ifAhxxpMUz/0u6wCy2f6EdJH9vDI9 bkzHeqgDzYgcbCAFtcD9YOlJOm3BgLf9f3V3WZhmhPMWWAbXPy4NggSwma+M+I3J1M/atI/prZc W2ye63zNk41kC7h/41Kv6ieo7aDgJabx0Mz0b/rpjclfi4F+z5tQynn4b6/89PJC61VcHI91oWh XBxo5JhwG0g1hwnS5GK9vW8NJRr4Hg9TtLC+wpg72iVIOrAXqvBSF6RfELEurXtI8NcW6+eWHdp GFoNxVyTzfoavUfm4c54ZHNo2p3grXc2Wcp5d1TE2AEr5YzVqEV93zNkMnYEMElB4Xw556igetm KZ8m5o5RTd/HGzmOrbkhUGrUDaJJK295U+tJ0HKSwGb1IvFzMu2fSOf+VRfc8jTHPeMwcngOxQ/ TM11p9NassLY1PbS4JmJ7MOr/DDvoMgY3UBELSzMS80dAmWb8CcLtx0crjPwJy8S/UEtUV2KwlP YO8ImD9hYIR6TtfFbJS60yMEIkMxIh/utU7BSF6o4hpgB0RrM5DDUS1bcm60Zj5/By8PUa3cZKc +HV5Oo7iwKniXAg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -1 X-Spam_score: -0.2 X-Spam_bar: / X-Spam_report: (-0.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.419, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1784988118317154100 machine->fdt is a plain g_malloc0() buffer (see create_device_tree()) that boards populate during MachineClass::init, but machine_finalize() never freed it, unlike the other boot-time buffers (dtb, dumpdtb, kernel_filename, ...). Free it for consistency. Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/core/machine.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/core/machine.c b/hw/core/machine.c index 805148678d57..2b24d711d76f 100644 --- a/hw/core/machine.c +++ b/hw/core/machine.c @@ -1301,6 +1301,7 @@ static void machine_finalize(Object *obj) g_free(ms->kernel_cmdline); g_free(ms->dtb); g_free(ms->dumpdtb); + g_free(ms->fdt); g_free(ms->dt_compatible); g_free(ms->firmware); g_free(ms->device_memory); --=20 2.55.0 From nobody Sun Jul 26 10:07:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1784988093; cv=none; d=zohomail.com; s=zohoarc; b=dM170CgvtgM0G89FfXiDQYFl1NVIrWehmbPEXCXPqvG6eUAzNdc4OeUd8DPKzwMVAk86atCZQ3mvPc/r/lMV6MM4xYAyibLHealbg30WQ9MdAFZcB0QDBygioXDQ8MLTVAADXLY5EgwW/NNaw27UtCfGJ9azKmO/yO6gQ+CSqsQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784988093; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=sgwF7jkNJLhj6j+139aaPY14IWX2xoRAqge3G7njsEU=; b=JtZZ8RLG9LUCj2FtUXeWsbHCFUUdyGiMIVwL2wt+IkaeKB1znq50maD3qbDadUm20+0wfgnNn54ibltqwvqDdJkHVYBwV2omh7J2q+PywVRbDa7KjJlu7Zh6G5l/qDF2Kkrap9+cPs4urVRHQmIVzrkhvgWmA/y6OQZbMNSQ6uY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784988093269502.1021362394928; Sat, 25 Jul 2026 07:01:33 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wncw4-0003jy-1j; Sat, 25 Jul 2026 10:01:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wncvz-0003el-4k for qemu-devel@nongnu.org; Sat, 25 Jul 2026 10:00:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wncvx-00054I-T7 for qemu-devel@nongnu.org; Sat, 25 Jul 2026 10:00:58 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-37-sxELkOo0Nxm4eGyza9UWKA-1; Sat, 25 Jul 2026 10:00:53 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 60D4319560AD; Sat, 25 Jul 2026 14:00:51 +0000 (UTC) Received: from localhost (unknown [10.44.22.7]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C102018001DA; Sat, 25 Jul 2026 14:00:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784988057; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sgwF7jkNJLhj6j+139aaPY14IWX2xoRAqge3G7njsEU=; b=XaZyYOo/g6i+grb2CSczgfC5dgP36YDMsR7iAQqASh3OdNDw2M1Tkj+Lr/aQweMnAoL7Hv 6tz0Ft7lKHmDTdP59lp+ikFvCWz6zDRcq4jjahHUJxU56DHJWAKWEAG06AuZGV48nu8jPA ExQb7svlezwRxs3kk1KFoO5elB/6kJc= X-MC-Unique: sxELkOo0Nxm4eGyza9UWKA-1 X-Mimecast-MFC-AGG-ID: sxELkOo0Nxm4eGyza9UWKA_1784988051 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 25 Jul 2026 18:00:07 +0400 Subject: [PATCH 6/7] migration/multifd: fix Error leak in multifd_recv_terminate_threads() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260725-fix2-v1-6-5c9a6ce7b96a@redhat.com> References: <20260725-fix2-v1-0-5c9a6ce7b96a@redhat.com> In-Reply-To: <20260725-fix2-v1-0-5c9a6ce7b96a@redhat.com> To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , =?utf-8?q?Alex_Benn=C3=A9e?= , Akihiko Odaki , Dmitry Osipenko , Stefan Hajnoczi , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org, Jonathan Cameron , Paolo Bonzini , Fam Zheng , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Zhao Liu , Roman Bolshakov , Phil Dennis-Jordan , Wei Liu , linux-cxl@vger.kernel.org, Brian Cain , Pierrick Bouvier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Peter Xu , Fabiano Rosas , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=654; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=8V4SbETfqA20e58q6VCGWaqhSb6JTXgkzFqcys/62CY=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqZMFmNAkgl2xEbUo9EDHoKtnbnGWWKiCA9f1c7 w/JnJfJ58CJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCamTBZgAKCRDa6OEJdZac 5QEfEACXyaWaIRPdYyDbzJF90W4hI7CRu9vhXtTaIGGqKUdpKEw1dDd+TxowUq8CqLugHr6cK3q +uwLO9+gCkfgquQzkACO3h8Wwp++W5hOiHyahV2wpaupJMcGtxax0YfPcwRv4D6yU7AjOggAyOg YSbepCIij7JVEY8iMrfWA/sPc5mBOM0xYAg1rFk6EckJi94w/AAmVxi/gMcEELYvCm9r4eQxakA H35K21T38uvL4CmSCr0U//Dcvojofk4oDD4hfp+/5lheKFdqHB5kp1xqnxTJaAgdjXXlg/OgYHa QvtUMXERNQzTLKni1pUFJ2rt00UCs3MZjroibopQ5kzmJii0v78wVUiwML3wiqnAdV4hcwe0165 PNpUKm8kTpb9Hq7rkYJe0rbUkcuJH8eATFR7zOJUHfhWIRBrux9acLWCX6fWYHWdPg6HHQMwrAu Rb1g2ZUo5vHsldTRZReSywB5opuObrjrBBTPI1DjFZYO9m+L7z7+Q+JJp2St8S3S6IzTCQ8O/Js p9tleZPkzskXqY5eoko5AZJqhTAKIM4XTZrIXEYy4tAl1Z/p5uWzolvN5WhASqgXG3J4h/CbMmX BlC6MjnuqcL2393G5ry/ylUOV3O1xvMlxSS16o80yn8/2hfmPJcOLfmtDTRmw4ldy0dvQ1ORtTY /G2CvnqnmyOd28w== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -1 X-Spam_score: -0.2 X-Spam_bar: / X-Spam_report: (-0.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.419, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1784988094021154100 If err !=3D NULL, free it. Fixes: 11dd7be57524 ("migration/multifd: Remove p->quit from recv side") Signed-off-by: Marc-Andr=C3=A9 Lureau --- migration/multifd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/multifd.c b/migration/multifd.c index dbad525d2a28..503014f76ba5 100644 --- a/migration/multifd.c +++ b/migration/multifd.c @@ -1056,6 +1056,7 @@ static void multifd_recv_terminate_threads(Error *err) trace_multifd_recv_terminate_threads(err !=3D NULL); =20 if (qatomic_xchg(&multifd_recv_state->exiting, 1)) { + error_free(err); return; } =20 --=20 2.55.0 From nobody Sun Jul 26 10:07:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1784988123; cv=none; d=zohomail.com; s=zohoarc; b=lT2fMIQ7W4l5Xoc/vIHjxejO+eMvUVKXsd/gHOwEIz2rBH+16p45B9KT8ScciwbZjpWGa+7jj4eqzTwfN5XTf7neYoiO9XvaDp+mmWwWzMoEf8HOAmWZTNkjRHpQSJr4dEuUbxCduITOxs2sVuKEZc7hLK4C5tJG3QwR+J46PYk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784988123; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ayGYuMqLtdZ4tO4DWqG//BYWp/04yuY/5uhQAQdO2WU=; b=ZbjEm8NraGJ8fQp0SuUntWYYjwF3yQCnN96dq16fBFKjEJHEkVwlxQ+CXY0Q9rBzgMHHRZUdwcT/wtq3XvoYppura8Dd6Q8LoZ8D2kKjlxCHg4Siy8JZfc1wpSMXwJxbP4rVUZQfe58Y751vi8Liw4fmgJsat2zBsVhR9B6o5ZY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178498812333191.31631767367946; Sat, 25 Jul 2026 07:02:03 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wncw5-0003mX-LB; Sat, 25 Jul 2026 10:01:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wncw3-0003jw-GT for qemu-devel@nongnu.org; Sat, 25 Jul 2026 10:01:03 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wncw1-00054e-VJ for qemu-devel@nongnu.org; Sat, 25 Jul 2026 10:01:03 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-263-UIgTjnWwPw-WTRys6eze3Q-1; Sat, 25 Jul 2026 10:00:59 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4366E1800366; Sat, 25 Jul 2026 14:00:57 +0000 (UTC) Received: from localhost (unknown [10.44.22.7]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9723B300019F; Sat, 25 Jul 2026 14:00:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784988061; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ayGYuMqLtdZ4tO4DWqG//BYWp/04yuY/5uhQAQdO2WU=; b=c0Kq6RyMB5GygXemYIIR8lN25GM+dd670Lucc21gXtSg1RRzlmwfLe67RKS9unAqiiiGCO KgV6KgrSAdpkpvKnWZKNeP682FssFwqGY0IMSIQ4m8fGEyM7bNCHdrcBhc8cqVggYIok6F pcIv4dpWpmuBaPUI4AntPGPbN+O3PaE= X-MC-Unique: UIgTjnWwPw-WTRys6eze3Q-1 X-Mimecast-MFC-AGG-ID: UIgTjnWwPw-WTRys6eze3Q_1784988057 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 25 Jul 2026 18:00:08 +0400 Subject: [PATCH 7/7] qdev-monitor: drain RCU callbacks in qdev_device_add_from_qdict MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260725-fix2-v1-7-5c9a6ce7b96a@redhat.com> References: <20260725-fix2-v1-0-5c9a6ce7b96a@redhat.com> In-Reply-To: <20260725-fix2-v1-0-5c9a6ce7b96a@redhat.com> To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , =?utf-8?q?Alex_Benn=C3=A9e?= , Akihiko Odaki , Dmitry Osipenko , Stefan Hajnoczi , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org, Jonathan Cameron , Paolo Bonzini , Fam Zheng , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Zhao Liu , Roman Bolshakov , Phil Dennis-Jordan , Wei Liu , linux-cxl@vger.kernel.org, Brian Cain , Pierrick Bouvier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Peter Xu , Fabiano Rosas , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=2906; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=tc59tpUIOnJATfZj0Ow9IZihAQ/ju8XXCdAihZfGr0Q=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqZMFmg2IQSzXLgb1HeD4VQxrb08w/yBiPzE55j 2UdhTQdlO+JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCamTBZgAKCRDa6OEJdZac 5RgpD/46Kwqoedezh17/7AwZORHSgHU7hKbFErb7X4Ikhq1/dLQSkXBtm5abklnGQO7N8TO4sS8 OfbbNBDS/aeA+btHMl5bLz/O7y3tWsqLYR76CbHnw+iWqxre97mP4BVZzLr1YyhxzsGM6xMQndb zV+npve/xAPguVU5RtwD4l9qK3BQAhLagSqG5zWC0otLwxithRDCHnVRVtDGpiO0i3QkmlzLTjq HHuCMUOKjJZNHFuCej8YbXh78jDonklWR/aBbeONo2zlTo9k5vGjOp2unuKBB+SftjxALcevMGu e4ivmu6IKX83FV9zzfo8M3bshxBabng6IzOITBfuDh7KTAdHyC0F+H9CuS5aCIk3eHXJebdYcDK fi51MqFwAukd/0ePcpgm8loFqF6gJGoeiaA7n6SmkYtdV6mlkpyzw3BWftmoxMWob+6QU2OIszu LHsbC3TBB/suz8NCRQLpuLIf6f3HmO7pcUW6FLP5S4UvKX73xCwh+wuJCz1Db50DpTvwbiPJfEH S8S9v0H9tD1SNUuPILRTVH6U7iSfQ+6zUXRBfKDebGFmsgypyReuwWpSODYgP/qEJdet3krd74m GHVq0aVf0YH7DTRUU1zmpI6q3tLCdRl9XlD+PZAVfuFqiSonRAF9X5dJ6qwv2bvDia/Dx+5FmJ/ GijtQUiJ8r6cJCg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.419, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1784988124372154100 qmp_device_add() and hmp_device_add() drain pending RCU callbacks after a failed device_add, since some bus teardown (e.g. bus_remove_child()) is deferred to call_rcu(). -device on the command line reaches the same qdev_device_add_from_qdict() with errp pointing at error_fatal, whose ERRP_GUARD() exits before control returns to the caller, so the caller's drain_call_rcu() never runs. Move the drain into qdev_device_add_from_qdict()'s own err_del_dev path so it always runs, and drop the now-redundant calls in qmp_device_add() and hmp_device_add(). Signed-off-by: Marc-Andr=C3=A9 Lureau --- system/qdev-monitor.c | 33 ++++++++++----------------------- 1 file changed, 10 insertions(+), 23 deletions(-) diff --git a/system/qdev-monitor.c b/system/qdev-monitor.c index 00fed791cce1..884d407d60d4 100644 --- a/system/qdev-monitor.c +++ b/system/qdev-monitor.c @@ -746,6 +746,16 @@ err_del_dev: object_unparent(OBJECT(dev)); object_unref(OBJECT(dev)); =20 + /* + * Drain all pending RCU callbacks. This is done because some bus + * related operations can delay a device removal (in this case this + * can happen if device is added and then removed due to a + * configuration error) to a RCU callback, but a caller might expect + * the failed device to be fully torn down once this function + * returns. + */ + drain_call_rcu(); + return NULL; } =20 @@ -870,18 +880,6 @@ void qmp_device_add(QDict *qdict, QObject **ret_data, = Error **errp) DeviceState *dev; =20 dev =3D qdev_device_add_from_qdict(qdict, true, errp); - if (!dev) { - /* - * Drain all pending RCU callbacks. This is done because - * some bus related operations can delay a device removal - * (in this case this can happen if device is added and then - * removed due to a configuration error) - * to a RCU callback, but user might expect that this interface - * will finish its job completely once qmp command returns result - * to the user - */ - drain_call_rcu(); - } object_unref(OBJECT(dev)); } =20 @@ -1017,17 +1015,6 @@ void hmp_device_add(Monitor *mon, const QDict *qdict) } dev =3D qdev_device_add(opts, &err); if (!dev) { - /* - * Drain all pending RCU callbacks. This is done because - * some bus related operations can delay a device removal - * (in this case this can happen if device is added and then - * removed due to a configuration error) - * to a RCU callback, but user might expect that this interface - * will finish its job completely once qmp command returns result - * to the user - */ - drain_call_rcu(); - qemu_opts_del(opts); } object_unref(dev); --=20 2.55.0