From nobody Sun Jul 26 10:08:10 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1784898257; cv=none; d=zohomail.com; s=zohoarc; b=Jyb7DkXv7t/Hu65KfILiDxWXdDJSH8WN3GdgMNSIt0hTcYMJ3L9w2E/m6U5UsI8uC7uIvMS5kbsXmyaq8Nsu5jcTRrZD2EUICRPuNKbUs3VyM+TOjGVrPqVItax4reWw1uMZk6N3VtgpxPKYkwO+cNHCTu/X6C5/GzQlVHLK4Ds= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784898257; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=/NYB5VPamLxRl003Nr1YAoItm9vYqHIxFyNoTTbDu5k=; b=Bb5eQyQR0/z0XilGnh7+hZdH136PjOzH0X+AE68QrRTJDWXcFY+13QgaWbQXiZ+cVKzMh7N4eAksc8klwZw+7zxhF8hDehkN1ntNg3Tqx8X2QZTU0vuaU4otQvBTxOD3j9EcPwwqszgiqH6mjMQx4V8FKIbihSFsGUoGJSOAAdE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178489825770026.423234546611297; Fri, 24 Jul 2026 06:04:17 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wnFZ4-0006GS-Mi; Fri, 24 Jul 2026 09:03:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wnFMq-0002kI-VR for qemu-devel@nongnu.org; Fri, 24 Jul 2026 08:51:19 -0400 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wnFMp-0001KI-CI for qemu-devel@nongnu.org; Fri, 24 Jul 2026 08:51:08 -0400 Received: by mail-pj1-x1030.google.com with SMTP id 98e67ed59e1d1-38e08baf860so345274a91.2 for ; Fri, 24 Jul 2026 05:51:02 -0700 (PDT) Received: from botszhome.. (118-171-20-196.dynamic-ip.hinet.net. [118.171.20.196]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f03adb224sm1449004a91.2.2026.07.24.05.50.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 05:51:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784897461; x=1785502261; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=/NYB5VPamLxRl003Nr1YAoItm9vYqHIxFyNoTTbDu5k=; b=Cm75Dhio4Ijm2AjNQPIAMHB+q/a2KwNRCQaWYcw5wBV4Ldulou3sTlgGh009Sa2bq+ DqUxv6HbjpVO04lka1yNI/jV4i+HyU5znBluD/Rjre1rRItRwkymNgJWLoJR6Wz8MUp9 pXtfMLMWsXp7Gzf5WzCYu2jhUV2vI0KvtCpYYK4wivz7UYafkHMyp4/ldAEglPhOzE7d +GZYn1OT+gFwd6EjjK6YNYxwjmGyDYBroJ8nrQh/OegY6eIexE5CbR0YhSYZ5W3jkl0u FViRhtWqL55CvRAz7hH9tRH17zjFZuXdvSS2HxFKdiqUyrkgbH8PpR2ByddvV8EfBD+H DXag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784897461; x=1785502261; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/NYB5VPamLxRl003Nr1YAoItm9vYqHIxFyNoTTbDu5k=; b=XmR1Rr3YGR9MhcIC82BsdwU3X8wRuCmX3+QpWLLCtdewgGproqkT0ZZBRbe8hri0vp OoWyjvHDFOciTnPYE0kMUbjXKe3Ppo+4JhjeMlpBAeVsexrACYuNQmZF1h5UJUw14uoe SSly6FjRr2ddhvKEW/sGB3JSoFtJByY3Jv+NJoa2fJMoqH6trZ1ZMKXzhQhI6mdryVll Itj1BS9MbvPs4NXCjow6kfn0ktaGB5EznddNAgOLYS2BR2IlD8nlbrQjnpVWzanyyWiZ 60YkvDX495+dOeKbk6UYUxiHyUNc/NMWiSTWARPQUcIpkwBYsYD6TCTQ9G2b3jJaztmm uHhA== X-Gm-Message-State: AOJu0YxTHBX01gUsVw3LXvSmcvkaXBDipfHmfyyele+mC6i31AiraDTS pfP0fOyZ0ApBogzixA/At27jr/iINcdWrwH8Qc/TLyGUvgvFdPKFdqqMBxCSUvZE X-Gm-Gg: AR+sD121wUAxubCYK3lEk2Zovgrm238T8iqPkwPqt8F3lTvEkLPmhL4uXwYzIUph9+U EXlrwFDZ04Exep5rDOqSNRuKzt4Q3pJpbxEeHozogeR5g6j6ZS1zMvC8sfOEMYQYeZHBtf0kbTe pRIFUfgnJglZzyNUu3hA2TysZwbC4KOu/5kx2NM+tcEqRGjqu3Qs0vetKlYnZD9hmqGK0Hinz5f Zey9lNEx9NGZL0iO/QAWtPKR+zbkLPqVDzilwiSAe7YabJIepygQ9hlj9cZXXPV9OFAihpN5gof Tyu1ImcVqKP8OvtiIAb19Nhf17dx68Tk0+V5e8/EPKKHzXvf+4TuTzjj26Kbe6FLaS7BqvQcD6F yVvmkJRY/UrFN0zCvbMIcgva8yMnHiOnT9m9fKbaRYjklZzMKiL19R3uvhWgnaVsSz3UChcbDPN 4nIm5wyHowFfxzbldsu51EiVXkOTrnbjLQyxS2hdi0ISRd1HxzPjpUQnFLsoge84Lj4TU1yrNqb K6FzoFOOO3Sa71fh+bWHsxEFRgmZb46mVVHGmPLEPUqlbQXVkv/iWPLMhU+R2SPmwMB/bhfjr5L v0y+yzv51LbPjTdWBw== X-Received: by 2002:a17:90b:2b47:b0:36a:5d1f:7b6 with SMTP id 98e67ed59e1d1-38ec6453e68mr6966372a91.2.1784897461185; Fri, 24 Jul 2026 05:51:01 -0700 (PDT) From: botszhuang X-Google-Original-From: botszhuang <22925483+botszhuang@users.noreply.github.com> To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, philmd@mailo.com, qemu-arm@nongnu.org, sef1548@gmail.com, botszhuang <22925483+botszhuang@users.noreply.github.com>, botszhuang Subject: [PATCH] fix BCM2835_I2C_CLKT Date: Fri, 24 Jul 2026 20:42:20 +0800 Message-ID: <20260724124220.24152-1-22925483+botszhuang@users.noreply.github.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1030; envelope-from=huang.botsz@gmail.com; helo=mail-pj1-x1030.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 24 Jul 2026 09:03:41 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1784898259217158500 Content-Type: text/plain; charset="utf-8" hw/i2c/bcm2835_i2c: Correct CLKT register offset The Clock Stretch Timeout (CLKT) register for the BCM2835 I2C controller is= actually located at offset 0x1c, not 0x20. The previous incorrect value caused the guest OS to read from and write to = the wrong memory address when configuring the I2C timeout, which could lead= to unexpected controller behavior. Update the BCM2835_I2C_CLKT macro to match the hardware specification. Signed-off-by: botszhuang Tested-by: Nick Huang --- include/hw/i2c/bcm2835_i2c.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/i2c/bcm2835_i2c.h b/include/hw/i2c/bcm2835_i2c.h index 45f876df22..519c65f765 100644 --- a/include/hw/i2c/bcm2835_i2c.h +++ b/include/hw/i2c/bcm2835_i2c.h @@ -38,7 +38,7 @@ OBJECT_DECLARE_SIMPLE_TYPE(BCM2835I2CState, BCM2835_I2C) #define BCM2835_I2C_FIFO 0x10 /* FIFO */ #define BCM2835_I2C_DIV 0x14 /* Clock Divider */ #define BCM2835_I2C_DEL 0x18 /* Data Delay */ -#define BCM2835_I2C_CLKT 0x20 /* Clock Stretch Timeout= */ +#define BCM2835_I2C_CLKT 0x1c /* Clock Stretch Timeout= */ =20 #define BCM2835_I2C_C_I2CEN BIT(15) /* I2C enable */ #define BCM2835_I2C_C_INTR BIT(10) /* Interrupt on RXR */ --=20 2.43.0