From nobody Sat Jul 25 06:39:02 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1784886561; cv=none; d=zohomail.com; s=zohoarc; b=hiUPOPinXFh9SV6+Ek0YgPmfFzTYt2W+nyZvhby6sbgo7LIIkWImXIWaDgDJZVViVwyRQhKEQYnMiuI5tB1l+yE6RL1nwNfUKbqS5sfGKs2RDRRGLE5Qx93ZpY5AP69zoCfpzuW4AwZyOiEWsSo0JvRn8fSo0V/N/XdmYxJ03cU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784886561; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=mzdswAa+bbfIlNkCOEN5KAhvMxsNWWjvmUPlgb96SYQ=; b=QVn3mAnbI9Tf7ghzq++rKkqFd0dPLtnwG3P4IIOe+guwiOk2Lap5BIgdsBtfDcLB9QOGornSLnLXZeiOiHmwTfTyZUxKV9V2BJfdj1WRmCgU7nBdshX87UJ+5rUyv7+EAcArwkwDROjIQ/Fj+1pL9Z+8yyWMVAo8kEZvnnaW7j0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784886561629803.3077525702755; Fri, 24 Jul 2026 02:49:21 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wnCVn-0003EK-Fm; Fri, 24 Jul 2026 05:48:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wnCVl-0003DS-TD; Fri, 24 Jul 2026 05:48:09 -0400 Received: from isrv.corpit.ru ([212.248.84.144]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wnCVk-00058W-1g; Fri, 24 Jul 2026 05:48:09 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id 4B35F1C4572; Fri, 24 Jul 2026 12:47:43 +0300 (MSK) Received: from gandalf.tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by tsrv.corpit.ru (Postfix) with ESMTP id 45F783F46B1; Fri, 24 Jul 2026 12:48:04 +0300 (MSK) Received: by gandalf.tls.msk.ru (Postfix, from userid 1000) id 42DC518542; Fri, 24 Jul 2026 12:47:54 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tls.msk.ru; s=202602; t=1784886463; bh=7DKwXLqoNYSCKItdII5a3Fp4ks2eieikV51uYNMU7dc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=tDqeU4qiisSSG5eXhqJdDSDHnfSiKkuCM646mWHwCaZI2ni1KE3KOGCO7O48AN4mR wmrafXzqQlftPFtxwvXvqIHwMVDRAD5lZBcB0gufHwfGi5OEf4FFolBRkz3Dd7acbH pfucrDQ25gWeZMvlosVvQi4iiZNf86J9YJ7F25Bz3iLMRQA24HdaXkfY+Ggu/9BOwt q5ojss6nq/1qngGO2fUDC49tCrWUBV/fwp6nolVhgtqFXTKgP74uYqRvDHIM0+twHF cERsRKxdAsvzigsXWrsY+O0fKyH8FJnBjk56LaCy2mftJGrZ52UG0V0QbRrneiT7RP M0PL+nhnlY1OQ== From: Michael Tokarev To: qemu-devel@nongnu.org Cc: Michael Tokarev , qemu-trivial@nongnu.org Subject: [PULL 1/7] spelling: happend Date: Fri, 24 Jul 2026 12:47:43 +0300 Message-ID: <20260724094754.1053970-2-mjt@tls.msk.ru> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260724094754.1053970-1-mjt@tls.msk.ru> References: <20260724094754.1053970-1-mjt@tls.msk.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=212.248.84.144; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @tls.msk.ru) X-ZM-MESSAGEID: 1784886562692158500 Content-Type: text/plain; charset="utf-8" Fixes: 44adb5fcc20d "target/riscv: Remove spike as default machine" Fixes: 48814111366b "migration: Always set DEVICE state" Fixes: 3345fb3b6d7f "migration/postcopy: Add latency distribution report fo= r blocktime" Signed-off-by: Michael Tokarev --- docs/about/removed-features.rst | 2 +- migration/migration.c | 2 +- qapi/migration.json | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.= rst index f7a2aa326de..0735b4ea1d5 100644 --- a/docs/about/removed-features.rst +++ b/docs/about/removed-features.rst @@ -1241,7 +1241,7 @@ RISC-V default machine (removed in 11.1) '''''''''''''''''''''''''''''''''''''''' =20 RISC-V used to define ``spike`` as the default machine if no machine option -was given via the command line. This happend because ``spike`` was the fi= rst +was given via the command line. This happened because ``spike`` was the f= irst RISC-V machine implemented in QEMU and setting it as default was convenient at that time. Now we have 7 riscv64 and 6 riscv32 machines and having ``spike`` as a default is no longer justified. diff --git a/migration/migration.c b/migration/migration.c index 9736c14458b..9df6da131ce 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -2806,7 +2806,7 @@ static bool migration_switchover_prepare(MigrationSta= te *s) bql_lock(); /* * After BQL released and retaken, the state can be CANCELLING if it - * happend during sem_wait().. Only change the state if it's still + * happened during sem_wait().. Only change the state if it's still * pre-switchover. */ migrate_set_state(&s->state, MIGRATION_STATUS_PRE_SWITCHOVER, diff --git a/qapi/migration.json b/qapi/migration.json index 66bd900465a..b1eaf7b0545 100644 --- a/qapi/migration.json +++ b/qapi/migration.json @@ -270,8 +270,8 @@ # (Since 10.1) # # @postcopy-non-vcpu-latency: average remote page fault latency for -# all faults happend in non-vCPU threads (in ns). It has the same -# definition of @postcopy-latency but this only provides +# all faults happened in non-vCPU threads (in ns). It has the +# same definition of @postcopy-latency but this only provides # statistics to non-vCPU faults. This is only present when the # postcopy-blocktime migration capability is enabled. # (Since 10.1) --=20 2.47.3 From nobody Sat Jul 25 06:39:02 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1784886509; cv=none; d=zohomail.com; s=zohoarc; b=A3aXLHDF5Y0DdjMmo8yaqx1WBcRAMJZqwBRvyb7O1Wdi5Ay0u1hzuGS2++hMoj2XAKMb/gvp+ucZx/DfkZH64GRJUn2Opvmht8Uqk7C2AKedsAYpgy2cSwoDHE6a2nqUjKt2nl3P8I0kKmI/NMnh5Kkf+uWBV/7UupI9tifje+Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784886509; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=oj89CtfTzljZxogsPDa5cVneEk/Mj8BO2dyHFs6lWYU=; b=nsDY0PfTzBrh0nSLeXB8QQF1F6FBwoY0+jEndCaQM6WidqiPTKF+1mHlBsiN8aM+u/wxJoTkocWtvT9RdPAF7YostBfEuAcG0JZ59UTDCPRXBSV35uUgcG7n9/nszW/JMvbjoVj7ildStmRgI6hlkXfZUXQ4OW1/Er0GuyDKxB0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784886508185127.07345790914133; Fri, 24 Jul 2026 02:48:28 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wnCVr-0003Fq-04; Fri, 24 Jul 2026 05:48:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wnCVo-0003Ew-Pq; Fri, 24 Jul 2026 05:48:12 -0400 Received: from isrv.corpit.ru ([212.248.84.144]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wnCVn-00058y-9t; Fri, 24 Jul 2026 05:48:12 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id 522331C4573; Fri, 24 Jul 2026 12:47:43 +0300 (MSK) Received: from gandalf.tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by tsrv.corpit.ru (Postfix) with ESMTP id 4D5BB3F46B2; Fri, 24 Jul 2026 12:48:04 +0300 (MSK) Received: by gandalf.tls.msk.ru (Postfix, from userid 1000) id 450E018544; Fri, 24 Jul 2026 12:47:54 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tls.msk.ru; s=202602; t=1784886463; bh=QOd08d1h55mBSGcMarer7Abhnc2GmuO+qLdLlQmp6So=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=SrDhjOVKM5lCRnWClpmduI1EZnS2Ro/DIL9K3DEV4Ae8Oxu2zqHH5zaxBKEEYKZtq CJ+8xrEdq0M8OM6yB9+HsuPt6loI7+xs8+EO2zmJYPkOtmYDWoaJczyiGzyI4PwSJ3 nFHawBG8tiwdYjQZHfBHf+3FePtXPZXSYaX0I+/TDdpOLA0fdoc+ReeqhLS2lEBiFT 3Km3Eiq1kLoOXRwufUxJcXK7jF3zgKnm2Um46hER9eO1+Ex8Pu9XPChpWnKO4LSXBm +nPtcZcHakpa8FZv+3AWT29JFHQj3GwAfCz5nes9ZnHGgUWCLm3Uwzj+rs0ns3T2Oo xritTCmhhsy7Q== From: Michael Tokarev To: qemu-devel@nongnu.org Cc: Filip Hejsek , qemu-trivial@nongnu.org, Michael Tokarev Subject: [PULL 2/7] char-win-stdio: fix typo in spelling of 'stdio' Date: Fri, 24 Jul 2026 12:47:44 +0300 Message-ID: <20260724094754.1053970-3-mjt@tls.msk.ru> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260724094754.1053970-1-mjt@tls.msk.ru> References: <20260724094754.1053970-1-mjt@tls.msk.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=212.248.84.144; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @tls.msk.ru) X-ZM-MESSAGEID: 1784886514430158500 From: Filip Hejsek Signed-off-by: Filip Hejsek Reviewed-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Stefan Weil Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- chardev/char-win-stdio.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/chardev/char-win-stdio.c b/chardev/char-win-stdio.c index bb9c195a8b1..0deba3bffb0 100644 --- a/chardev/char-win-stdio.c +++ b/chardev/char-win-stdio.c @@ -128,7 +128,7 @@ static void win_stdio_thread_wait_func(void *opaque) SetEvent(stdio->hInputDoneEvent); } =20 -static void win_stiod_chr_set_echo(Chardev *chr, bool echo) +static void win_stdio_chr_set_echo(Chardev *chr, bool echo) { WinStdioChardev *stdio =3D WIN_STDIO_CHARDEV(chr); DWORD dwMode =3D 0; @@ -205,7 +205,7 @@ static bool win_stdio_chr_open(Chardev *chr, =20 SetConsoleMode(stdio->hStdIn, dwMode); =20 - win_stiod_chr_set_echo(chr, false); + win_stdio_chr_set_echo(chr, false); =20 qemu_chr_be_event(chr, CHR_EVENT_OPENED); return true; @@ -263,7 +263,7 @@ static void char_win_stdio_class_init(ObjectClass *oc, = const void *data) =20 cc->chr_open =3D win_stdio_chr_open; cc->chr_write =3D win_stdio_chr_write; - cc->chr_set_echo =3D win_stiod_chr_set_echo; + cc->chr_set_echo =3D win_stdio_chr_set_echo; } =20 static const TypeInfo char_win_stdio_type_info =3D { --=20 2.47.3 From nobody Sat Jul 25 06:39:02 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1784886562; cv=none; d=zohomail.com; s=zohoarc; b=AEQZiw0r+ZlZFUnR7Y4VxSb0OCW40Xgk4Ym7a/PjunXDgxwJqBCxHxUfHccYoLH37IELu17vajy9q7ll9FWsTitmDlSrpttOtjTxRo7/YGNBoU9AgTjIFyR7aimO1PjpWCQCyWqxN154npxiRO2j0rIywHK3SKXsi9JlPRpz5e8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784886562; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=SLuIFSika28oD1fGOqjJNPmIMxZVha8u2sldyHIkZsM=; b=WrRCfexe1nktY57eAbDMsPpGt0sZn83m8+sl8gB3palR3mvBVDqYLI9WZdPAacs6AHteM/YRwgKaxrRkxgCVZ45V9zrD3qpO6ZjLSSXitcukYExFTCm+5i1bQ+yvG8z8BVINs39dm93qmqWdOpE3VOo1wutV9sI53oj65GJMBXk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784886562245746.574521434611; Fri, 24 Jul 2026 02:49:22 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wnCVs-0003GS-0Q; Fri, 24 Jul 2026 05:48:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wnCVo-0003Ey-SQ; Fri, 24 Jul 2026 05:48:12 -0400 Received: from isrv.corpit.ru ([212.248.84.144]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wnCVn-000590-Ar; Fri, 24 Jul 2026 05:48:12 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id 592DD1C4574; Fri, 24 Jul 2026 12:47:43 +0300 (MSK) Received: from gandalf.tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by tsrv.corpit.ru (Postfix) with ESMTP id 5454E3F46B3; Fri, 24 Jul 2026 12:48:04 +0300 (MSK) Received: by gandalf.tls.msk.ru (Postfix, from userid 1000) id 4777C18546; Fri, 24 Jul 2026 12:47:54 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tls.msk.ru; s=202602; t=1784886463; bh=XNT16mHos7Uw+RJumfGsNuq2H7pOdc57nzpxpskiNe4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=sjvsksSnYdXDSXAG6bFRtVzV60GMHYUR0cMq+eKljsHNBzmU6jnjOa72vHvoh+neb 8cCRG6nIj6R/A3lA5OZbfDjJ7wrNtnJsZVf4wbdP/a53jfKicHbvp0cE5nrW/+BhLT CgA9+y9BnD+skMlSM3sJktY9AN+lE64Y4BMeSmiRdQXX6U5P0eAvHa4sNU0/hu+C4m gg//2AD8ZXx09ivn/TdEjyM22sKGPeBpnU7xJRfb7QFuK3R8LcJQQR0zMU8gZufStY gras+QxSnG7qWaw/ja0u/ZysimMyZeEEfuOwJfFHo+gWAn0sXpm3VsyuTRPySq7FZ2 LpUS7ONUbzpZg== From: Michael Tokarev To: qemu-devel@nongnu.org Cc: Vladimir Lobanov , qemu-trivial@nongnu.org, Michael Tokarev Subject: [PULL 3/7] block/curl: set User-Agent header Date: Fri, 24 Jul 2026 12:47:45 +0300 Message-ID: <20260724094754.1053970-4-mjt@tls.msk.ru> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260724094754.1053970-1-mjt@tls.msk.ru> References: <20260724094754.1053970-1-mjt@tls.msk.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=212.248.84.144; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @tls.msk.ru) X-ZM-MESSAGEID: 1784886564701158500 Content-Type: text/plain; charset="utf-8" From: Vladimir Lobanov Some HTTP servers and WAFs (e.g. Amazon CloudFront) reject requests without a User-Agent header with 403 Forbidden. This makes qemu-img info and other curl-based operations fail on such URLs without any obvious indication of the root cause. Set a "QEMU/" User-Agent string on all curl handles to ensure compatibility with these endpoints. Signed-off-by: Vladimir Lobanov Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- block/curl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/curl.c b/block/curl.c index 684c677ef71..1958eb80d12 100644 --- a/block/curl.c +++ b/block/curl.c @@ -482,6 +482,8 @@ static int curl_init_state(BDRVCURLState *s, CURLState = *state) } } if (curl_easy_setopt(state->curl, CURLOPT_TIMEOUT, (long)s->timeou= t) || + curl_easy_setopt(state->curl, CURLOPT_USERAGENT, + "QEMU/" QEMU_VERSION) || curl_easy_setopt(state->curl, CURLOPT_WRITEFUNCTION, (void *)curl_read_cb) || curl_easy_setopt(state->curl, CURLOPT_WRITEDATA, (void *)state= ) || --=20 2.47.3 From nobody Sat Jul 25 06:39:02 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1784886577; cv=none; d=zohomail.com; s=zohoarc; b=bXe3rh5dl1cj3AZ+AxTR4RaktkfmP7JxHLoZXfVsgcc7WwGVA594+szQ7qogrsdefs4rUgDPCltzF+Q35+F3JC2ufbIaIUSl+DeWoBg3AMM7++pKFDiBd5UlSsbF+kViXABNcfXodlzq/vLzJjdB/AI2kze2GHmH6QbuE6Dh2e0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784886577; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=HEcpOyUgZh4YLLtRWopQ9Lu8Wtaufbi2pCksSU5EPWY=; b=m6RtSr3eKC3Lvs7APfVrtsJmKUNla+wOfg3KzKBd5FxRCRxCxZkBU45UroVXju9ElJiiWwOKLDoCHfQEHffKkqbvpbsK8N9X4v9fBiFwapkahXqg++dlDIKGdAm3ihOkJ03sGgIg3WEG2VzoxGF21U9XBqCBdcFFxBGGvk6wfu8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784886577597845.9427486768225; Fri, 24 Jul 2026 02:49:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wnCVu-0003IS-89; Fri, 24 Jul 2026 05:48:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wnCVs-0003GY-0N; Fri, 24 Jul 2026 05:48:16 -0400 Received: from isrv.corpit.ru ([212.248.84.144]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wnCVq-00059Q-98; Fri, 24 Jul 2026 05:48:15 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id 5E79B1C4575; Fri, 24 Jul 2026 12:47:43 +0300 (MSK) Received: from gandalf.tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by tsrv.corpit.ru (Postfix) with ESMTP id 59E8A3F46B4; Fri, 24 Jul 2026 12:48:04 +0300 (MSK) Received: by gandalf.tls.msk.ru (Postfix, from userid 1000) id 49B8418548; Fri, 24 Jul 2026 12:47:54 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tls.msk.ru; s=202602; t=1784886463; bh=cPvw3ePXs8shmBDqHUndvFZx2VzYLNP0c8YSpdRzICk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=HZA6ViqaROs/CSX77FMG5vPDZOTrpZmq9bn08U6rTl3xBLXUHbnrPnOnIptzsWR7r INjzEy+i1kUmbO5gkOXbO4UVq1BGezBkrdniTImIOOAO49Rm9O+TA3yczY1d5yd+3p KsgvacGMLS1T5MmIRBfZAeKuDQ576zuvPqUlnzFRXcKS+UqnGmr3Sf/bxfY7ooklQl xxl041L/E+KQ/2wMT8YFv6Zu2Zmnmlb2pD4mIPDvd0dQMX+7BJK/xdK/WPAKdcVho0 sUVqZsq8niqNn6+MFNeOcbYHXsgqhBRb4W6XxoKlB+zJlQXL0Q3psStf7/vM7rjl1d L/80/MfvxKxlQ== From: Michael Tokarev To: qemu-devel@nongnu.org Cc: Thomas Huth , qemu-trivial@nongnu.org, Michael Tokarev Subject: [PULL 4/7] hw/display/vmware_vga: Don't allow guest to trigger long running loop in host Date: Fri, 24 Jul 2026 12:47:46 +0300 Message-ID: <20260724094754.1053970-5-mjt@tls.msk.ru> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260724094754.1053970-1-mjt@tls.msk.ru> References: <20260724094754.1053970-1-mjt@tls.msk.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=212.248.84.144; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @tls.msk.ru) X-ZM-MESSAGEID: 1784886578700158500 From: Thomas Huth The code in the SVGA_CMD_DEFINE_ALPHA_CURSOR handler in vmsvga_fifo_run() basically does: x =3D vmsvga_fifo_read(s); y =3D vmsvga_fifo_read(s); args =3D x * y; goto badcmd; ... badcmd: len -=3D args; if (len < 0) { goto rewind; } while (args--) { vmsvga_fifo_read(s); } Thus by supplying huge values for x and y that overflow the result of the multiplication, the guest can trigger a long-running loop here that burns the host's CPU cycles. Add some sanity checks so that this cannot happen anymore. Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3782 Reported-by: Feifan Qian Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/4026 Reported-by: Tristan Madani Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/4076 Reported-by: Sunday Jiang Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- hw/display/vmware_vga.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c index f6f9edfd1d9..567806f0e47 100644 --- a/hw/display/vmware_vga.c +++ b/hw/display/vmware_vga.c @@ -737,6 +737,10 @@ static void vmsvga_fifo_run(struct vmsvga_state_s *s) vmsvga_fifo_read(s); x =3D vmsvga_fifo_read(s); y =3D vmsvga_fifo_read(s); + if (x < 0 || x >=3D SVGA_MAX_WIDTH || + y < 0 || y >=3D SVGA_MAX_HEIGHT) { + goto rewind; + } args =3D x * y; goto badcmd; case SVGA_CMD_RECT_ROP_FILL: @@ -776,7 +780,7 @@ static void vmsvga_fifo_run(struct vmsvga_state_s *s) if (len < 0) { goto rewind; } - while (args--) { + while (args-- > 0) { vmsvga_fifo_read(s); } printf("%s: Unknown command 0x%02x in SVGA command FIFO\n", --=20 2.47.3 From nobody Sat Jul 25 06:39:02 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1784886510; cv=none; d=zohomail.com; s=zohoarc; b=H4RLxHSk/b8laG4HaSozoPMav7PtiEk54dWy8I978ry8ekh0JwHTnBAj2csgbsTmqK3iG7SzUeg6vrcOCYdqqkOT4kTYaS+CcCQqmyaG4z0hCnSKjmAoRJmUzBk0IYmBLnHUO/qr16aQP3+UOCjsBb+okQEL21OXw/M1Loumvx4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784886510; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=jMLV2n3r/9+Vc1wvEW8JBB+Dd+/fFo7gEoqfK33fnEs=; b=ha8aoI9RQpq3VAy7ytwV1kvK1zo0ZDNqlXymE6rkUvYAukz8eAiDStAh27mXPsfw9PwEmtrg9bVJjPwztqB89hzBje8fIBUw+3xs8VTbJzT1xyJ2s2ReI67tDVbJiXVPiMeu9OGHmaJYjvAWCEgkaZeakgA+hhwe2a1CFIRZtAw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784886509738812.6362379903552; Fri, 24 Jul 2026 02:48:29 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wnCVs-0003HT-Vn; Fri, 24 Jul 2026 05:48:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wnCVr-0003GR-Rb; Fri, 24 Jul 2026 05:48:15 -0400 Received: from isrv.corpit.ru ([212.248.84.144]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wnCVq-00059U-B3; Fri, 24 Jul 2026 05:48:15 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id 657501C4576; Fri, 24 Jul 2026 12:47:43 +0300 (MSK) Received: from gandalf.tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by tsrv.corpit.ru (Postfix) with ESMTP id 5FAB23F46B5; Fri, 24 Jul 2026 12:48:04 +0300 (MSK) Received: by gandalf.tls.msk.ru (Postfix, from userid 1000) id 4BF401854A; Fri, 24 Jul 2026 12:47:54 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tls.msk.ru; s=202602; t=1784886463; bh=Ed7IB/Ssxjee4lM+vHXFTzTBO/kOLZPEpfJwG/DnMVs=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=n0u3Dgt4+Sr0PSrJlgH0T48Ujt6fBweSt3+73NCcqyzz+FtEfYe7+MUpWuUprDhSR 9/VhtiwNOgL5yTi+0jFabpbkVM0HBW01SaZ91Bq8jxIIS9pT+7l1d/aknBCjGzdPWp pcZaExeTX1TtjzVlxU8pqdwt7K3YYl4VB42hJ5Hk+DpMUxo9F2V+HGe5SqOTN6xMfv dLYNycVPzkGyC79XMrEpDlAls8yCIe+WfGUpUkRcEpEyCtnmGws+1LlF99bReKDX7a QQHIGX7OH4Em6IuLStDti6qCvERHp1wyAP/LmFK3sCwXDkZ+GhW0aOAzuF8IsXihYd +sEi9pRFlQllw== From: Michael Tokarev To: qemu-devel@nongnu.org Cc: Evgeny Kolmakov , qemu-trivial@nongnu.org, Michael Tokarev Subject: [PULL 5/7] hw/hyperv/vmbus: Use QEMU_LOCK_GUARD() Date: Fri, 24 Jul 2026 12:47:47 +0300 Message-ID: <20260724094754.1053970-6-mjt@tls.msk.ru> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260724094754.1053970-1-mjt@tls.msk.ru> References: <20260724094754.1053970-1-mjt@tls.msk.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=212.248.84.144; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @tls.msk.ru) X-ZM-MESSAGEID: 1784886513147158500 Content-Type: text/plain; charset="utf-8" From: Evgeny Kolmakov Replace manual qemu_mutex_(un)lock() calls with QEMU_LOCK_GUARD() to remove 'goto out' code Signed-off-by: Evgeny Kolmakov Reviewed-by: Maciej S. Szmigiero Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- hw/hyperv/vmbus.c | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/hw/hyperv/vmbus.c b/hw/hyperv/vmbus.c index c5259d1a764..ab99f082d10 100644 --- a/hw/hyperv/vmbus.c +++ b/hw/hyperv/vmbus.c @@ -1525,14 +1525,12 @@ static VMBusChannel *find_channel(VMBus *vmbus, uin= t32_t id) static int enqueue_incoming_message(VMBus *vmbus, const struct hyperv_post_message_input= *msg) { - int ret =3D 0; uint8_t idx, prev_size; =20 - qemu_mutex_lock(&vmbus->rx_queue_lock); + QEMU_LOCK_GUARD(&vmbus->rx_queue_lock); =20 if (vmbus->rx_queue_size =3D=3D HV_MSG_QUEUE_LEN) { - ret =3D -ENOBUFS; - goto out; + return -ENOBUFS; } =20 prev_size =3D vmbus->rx_queue_size; @@ -1544,9 +1542,7 @@ static int enqueue_incoming_message(VMBus *vmbus, if (!prev_size) { vmbus_resched(vmbus); } -out: - qemu_mutex_unlock(&vmbus->rx_queue_lock); - return ret; + return 0; } =20 static uint16_t vmbus_recv_message(const struct hyperv_post_message_input = *msg, @@ -2097,10 +2093,10 @@ static void process_message(VMBus *vmbus) void *msgdata; uint32_t msglen; =20 - qemu_mutex_lock(&vmbus->rx_queue_lock); + QEMU_LOCK_GUARD(&vmbus->rx_queue_lock); =20 if (!vmbus->rx_queue_size) { - goto unlock; + return; } =20 hv_msg =3D &vmbus->rx_queue[vmbus->rx_queue_head]; @@ -2149,8 +2145,6 @@ out: vmbus->rx_queue_head %=3D HV_MSG_QUEUE_LEN; =20 vmbus_resched(vmbus); -unlock: - qemu_mutex_unlock(&vmbus->rx_queue_lock); } =20 static const struct { --=20 2.47.3 From nobody Sat Jul 25 06:39:02 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1784886540; cv=none; d=zohomail.com; s=zohoarc; b=aCNYIRWlrA6sDFa3zZWdXMzPKDYfN3REeHYV065BaSZ8koeODWkzTkgTTjjOz/CbmfbH9VXM+nvJ/LLiPsqZ35JU5iODlTZxMULHVRbgkE3Fwc9E/G4oT3I4iUPD5Yvr5feEojLPy8l1rAWziZKIPBF6bB99nkHk73/ttUKPzQE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784886540; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=2uVXM9VCWICPV67bK5+gVFG1tdW/R/DJ3nZcDoyOvCM=; b=NRK6VKUXtlJTh22hCZ4bQhDGKmCceTlQHI58EYxf04az8ExzxDRw3wVbpASJRnmFQHVYxPbVbSOLox4NmVadeG8cCeQ57/AlWUuSslBItItB6FXBR3O2rhL4+s9V9/27eN43BYDBRgsq9l2lheCihzd50Refy1ZfMt/7nC8rKQI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784886539029129.34028574317585; Fri, 24 Jul 2026 02:48:59 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wnCVw-0003Jh-Uq; Fri, 24 Jul 2026 05:48:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wnCVu-0003Ie-Qz; Fri, 24 Jul 2026 05:48:18 -0400 Received: from isrv.corpit.ru ([212.248.84.144]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wnCVt-00059x-9s; Fri, 24 Jul 2026 05:48:18 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id 6B5A51C4577; Fri, 24 Jul 2026 12:47:43 +0300 (MSK) Received: from gandalf.tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by tsrv.corpit.ru (Postfix) with ESMTP id 664A93F46B6; Fri, 24 Jul 2026 12:48:04 +0300 (MSK) Received: by gandalf.tls.msk.ru (Postfix, from userid 1000) id 4E28F1854C; Fri, 24 Jul 2026 12:47:54 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tls.msk.ru; s=202602; t=1784886463; bh=7yxIdw9pIhOAMkkgE7ZM1Jdt4fCXj6Y2Rbh5xcT6uyI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=jm3XILG0O4kOq/FVDS8bLkepz1GWC6lwnbKA8zI7vx/CSMLx0nVlN3jVG1fD8n1hs qSB2PJgMa34qotQMkF0esnPVO1TFJuFd0Zb7NxZB8ITy/ZTsKKUdAqja9PRVKG/A5I MpyyU3CcMRU5pPQRqXeov1HxlcFJW5ORuN86mMUPTal2XeHo+ba24J2AsdC+wDOPJ7 KyXSOOoby4gO8UTm9Te3FxKvQoyfnBcPbdyb7enPX9Un1dCG9M0Rv/+vqWsbFWnscv KEjJdoFGvrDlgCcm3PO9oMoPrOZ94bjOaIRX5EHqdDjdXIGeeTaY9/G5oTvBI5nelQ HyisIPHELdh4w== From: Michael Tokarev To: qemu-devel@nongnu.org Cc: Ziyi Fu , qemu-trivial@nongnu.org, Michael Tokarev Subject: [PULL 6/7] hw/usb: record async control completion for parameter transfers Date: Fri, 24 Jul 2026 12:47:48 +0300 Message-ID: <20260724094754.1053970-7-mjt@tls.msk.ru> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260724094754.1053970-1-mjt@tls.msk.ru> References: <20260724094754.1053970-1-mjt@tls.msk.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=212.248.84.144; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @tls.msk.ru) X-ZM-MESSAGEID: 1784886545907158500 From: Ziyi Fu Record the completion side of parameter-based control transfers when they complete asynchronously. This lets pcap captures include descriptor response data for requests such as GET_DESCRIPTOR from usb-host devices. The synchronous path already recorded the completion, but the async SETUP_STATE_PARAM path was missing it. Signed-off-by: Ziyi Fu Reviewed-by: Marc-Andr=C3=A9 Lureau Fixes: 0f6dba145a4b ("usb: add pcap support.") Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- hw/usb/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/usb/core.c b/hw/usb/core.c index 9572a870cc0..d71204c5c80 100644 --- a/hw/usb/core.c +++ b/hw/usb/core.c @@ -345,6 +345,7 @@ void usb_generic_async_ctrl_complete(USBDevice *s, USBP= acket *p) p->actual_length =3D 0; usb_packet_copy(p, s->data_buf, s->setup_len); } + usb_pcap_ctrl(p, false); break; =20 default: --=20 2.47.3 From nobody Sat Jul 25 06:39:02 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1784886572; cv=none; d=zohomail.com; s=zohoarc; b=OeqLDIRw2vo3WPZWIJ/sjZA4d7huUC7FU0AEViSyDbppX2un1MvzgOfmTvGTC3Pvw/X/32OhnlrrJuwN4kMpfIMWJnViwC76n7iOZQli3gfCAtzcxFKuI7upCb6ZFA3wlUyII6woalLBI+jB6W+9iUSQ8OFyQ9J4oQVrreICAHo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784886572; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=yBK4/0bpMWD5u922H1Cej/5cT1vTha/HiXvmtNtiU/k=; b=GqEYJoKNwWKAGRRqeFIywIjAkC4TtCInM8AGPl4V2bfAW3wK7XUhLJ3LeKWlEIERAhsf+59/s+t0gu0LYY4Q2vg5oj+kdDhvX6w1hNhIAteScygqj17bt2EDzYjzLk+ZM2GEG/qIGMoy8mOJjpS01jyk9TCHRLu54FJ+PYzsrtk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784886570824807.7880277606729; Fri, 24 Jul 2026 02:49:30 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wnCVy-0003Ka-8z; Fri, 24 Jul 2026 05:48:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wnCVv-0003Iu-Pb; Fri, 24 Jul 2026 05:48:19 -0400 Received: from isrv.corpit.ru ([212.248.84.144]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wnCVt-0005A2-RJ; Fri, 24 Jul 2026 05:48:19 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id 723891C4578; Fri, 24 Jul 2026 12:47:43 +0300 (MSK) Received: from gandalf.tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by tsrv.corpit.ru (Postfix) with ESMTP id 6D3793F46B7; Fri, 24 Jul 2026 12:48:04 +0300 (MSK) Received: by gandalf.tls.msk.ru (Postfix, from userid 1000) id 508031854E; Fri, 24 Jul 2026 12:47:54 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tls.msk.ru; s=202602; t=1784886463; bh=lJ0KOHlmYNtetNrX/X0QxvrRjmwPc3lBUMLgwct/Bds=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=i2Kw5JbGu4y3dMrpK2RWbOEB2yD16xcEhhZWqyBJfnbPpIqKVeqMQbtW9qyMwrNZo iJS/HUb7vs8Tw4A+bHjRBXxmfyZA6d3goGjTsVbpdnVJCW1fc7M2vKWJQ84nRcXJ8M BHps8NrobeReqEJDnABJOtxg8yBq6PABiWgNXCK8bSjzle++mYUb8wKa1V9a1XzQXN cZpjODT424dImLcFHUw+yX5xN9FjoYaXjuxHWoMQXjqju35HmsWh+Ydi0iMT4McybS IsfK0Ml1QpStJM1Q+L5fG69LaIaI8ZaIkC2g9nt/ZKmU3P2M2fEWmvHugx0oMOn/1V tV1F625Nh2FSQ== From: Michael Tokarev To: qemu-devel@nongnu.org Cc: Artem Nasonov , qemu-trivial@nongnu.org, qemu-stable@nongnu.org, Michael Tokarev Subject: [PULL 7/7] hw/ide: replace assert with proper error handling Date: Fri, 24 Jul 2026 12:47:49 +0300 Message-ID: <20260724094754.1053970-8-mjt@tls.msk.ru> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260724094754.1053970-1-mjt@tls.msk.ru> References: <20260724094754.1053970-1-mjt@tls.msk.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=212.248.84.144; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @tls.msk.ru) X-ZM-MESSAGEID: 1784886574676158500 Content-Type: text/plain; charset="utf-8" From: Artem Nasonov In ide_dma_cb(), the call to prepare_buf() might return a negative result and cause an assertion failure. This was found during fuzzing and can be triggered with some qtest commands. Replace the assert with proper error handling in case the result is negative, but keep the assert for failing to respect the limit upon success. If that happens, it is an implementation error. Found by Linux Verification Center (linuxtesting.org) with libFuzzer. Cc: qemu-stable@nongnu.org Fixes: ed78352a59 ("ide: Fix incorrect handling of some PRDTs in ide_dma_cb= ()") Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/2777 Signed-off-by: Artem Nasonov Link: https://lore.kernel.org/qemu-devel/20250116111600.2570490-1-anasonov@= astralinux.ru [FE: improve commit message keep assert for failing to respect the limit] Signed-off-by: Fiona Ebner Reviewed-by: Thomas Huth Signed-off-by: Michael Tokarev --- hw/ide/core.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index f78b00220b8..4c1ee19d8e8 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -921,8 +921,12 @@ static void ide_dma_cb(void *opaque, int ret) s->io_buffer_index =3D 0; s->io_buffer_size =3D n * 512; prep_size =3D s->bus->dma->ops->prepare_buf(s->bus->dma, s->io_buffer_= size); - /* prepare_buf() must succeed and respect the limit */ - assert(prep_size >=3D 0 && prep_size <=3D n * 512); + if (prep_size < 0) { + ide_dma_error(s); + return; + } + /* If prepare_buf() succeeds, it must respect the limit. */ + assert(prep_size <=3D n * 512); =20 /* * Now prep_size stores the number of bytes in the sglist, and --=20 2.47.3