From nobody Sat Jul 25 06:37:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1784885089; cv=none; d=zohomail.com; s=zohoarc; b=fby0RHo5/6lCzTfhpder+IW54ONWn3v8Mo9SgVGgF8+3iqijJhEmq+WJDeS7oarOXrG8Fvtj+tLLuOKvdwUqy5D9zL+4j4w7ox3ggmjbtQ9Ixohs5T32pzwUO8ymRmxf+pucPzY1LT4c1mTG1de4h6OOIBgAitgg6llmgCSX4zI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784885089; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Qhsnhgo1BviKaIM56hsegpeQFVGCELZXvoY0iGeM2Ag=; b=Bu6RyJ8Ipul8vIOHwgKTnKs2pl2DE3NIlLSm/EuFCI6puysMwwGdMypmEYu3ryNWuwJkD5hUSAcKh7cyOABkyQQjrXXMugA3pTm04aQ34IJ7dB09jkebJJvFNjQCdSBKgPjQAFnbGAzT6ocT9ip6z7BCYpA5uDCtVNekjV/b1bI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784885089457603.5769736617056; Fri, 24 Jul 2026 02:24:49 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wnC8s-0007Xs-L5; Fri, 24 Jul 2026 05:24:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wnC8o-0007S3-Sx for qemu-devel@nongnu.org; Fri, 24 Jul 2026 05:24:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wnC8l-0001IS-VB for qemu-devel@nongnu.org; Fri, 24 Jul 2026 05:24:26 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-621-CEDN4ZgwNqC_vmgHF1wCow-1; Fri, 24 Jul 2026 05:24:18 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 381021809A27; Fri, 24 Jul 2026 09:24:17 +0000 (UTC) Received: from corto.redhat.com (unknown [10.44.48.11]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6E51E1954226; Fri, 24 Jul 2026 09:24:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784885061; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Qhsnhgo1BviKaIM56hsegpeQFVGCELZXvoY0iGeM2Ag=; b=a/hvk5KMIGbtFYlSaPcy1wnuP6VG20+CsYaVT8O/UwUkzuILtEeDRSvPKmh2oCU8sWeQ6c guvGbMn/umlTx/JduyLWz7Fn/F1dGt0XyXoPwLYFmq26B0J57IDiRy7plIN32G2aDaAKLB mIAAdNrtrTn0QnnR0xZ1oXbdnHc2Vzc= X-MC-Unique: CEDN4ZgwNqC_vmgHF1wCow-1 X-Mimecast-MFC-AGG-ID: CEDN4ZgwNqC_vmgHF1wCow_1784885057 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-devel@nongnu.org Cc: Alex Williamson , mcasquer@redhat.com, =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PATCH] vfio/pci: Fix ROM load failure handling in vfio_rom_read() Date: Fri, 24 Jul 2026 11:24:13 +0200 Message-ID: <20260724092413.348354-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.951, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1784885091334158500 When vfio_pci_load_rom() fails, vdev->rom is NULL but the memcpy still computes a source pointer from it, which is undefined behavior. Guard the access and return a 0xff pattern instead, which is what hardware returns for an absent ROM. Signed-off-by: C=C3=A9dric Le Goater --- hw/vfio/pci.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index a3147d28665abd29fd804bd08bdffc3c7440033c..16d4f70ea58c9e5b174dd57950d= f55dc2ab91f6f 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -1176,8 +1176,13 @@ static uint64_t vfio_rom_read(void *opaque, hwaddr a= ddr, unsigned size) } } =20 - memcpy(&val, vdev->rom + addr, - (addr < vdev->rom_size) ? MIN(size, vdev->rom_size - addr) : 0); + /* If ROM loading failed, return 0xff pattern */ + if (vdev->rom_read_failed) { + memset(&val, 0xff, sizeof(val)); + } else { + memcpy(&val, vdev->rom + addr, + (addr < vdev->rom_size) ? MIN(size, vdev->rom_size - addr) = : 0); + } =20 switch (size) { case 1: --=20 2.55.0