From nobody Sat Jul 25 06:35:14 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1784865620; cv=none; d=zohomail.com; s=zohoarc; b=h8cSU0463YL41/xB8QB/eb8AlnARJKkZSAkmH6s3IMvd/pmW1RFVODVx9A32FpmcWCe2jUkrmakiufv5a/DOsjwdgHkk5grMmJopO7jfE2ZSpVb9RodZuVW4A0v7VPuQ8uNRDzT4P+IVgwhyVHsfZUlD3h5dNmUowxVxfHZaKgo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784865620; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=DlFgiOgz3MpAX3lOOIcBo19JybVEA6Ma0tK0ZBICvQ0=; b=hSlFQH299QXW36fnjXAwNFM7Eyw38r4w/BeZLLcP4nE4tRvqd9CmSWnEJEUoNCIHNdnigeK+Hj1Eub6eP1VHk1rnLMLfA88rViAk60DBHArFguWmGj10pLtA1g49dKP3MyTR59DF5fwOe0YZePfTem0tBAi4Wo8zWGsH62UeUYc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784865620791860.8283494210406; Thu, 23 Jul 2026 21:00:20 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wn74u-00008K-Ki; Fri, 24 Jul 2026 00:00:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wn74s-00007L-MJ for qemu-devel@nongnu.org; Fri, 24 Jul 2026 00:00:02 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wn74q-0007Md-KK for qemu-devel@nongnu.org; Fri, 24 Jul 2026 00:00:02 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-679-C4aeSseDPle2TuW8Ss4WkQ-1; Thu, 23 Jul 2026 23:59:56 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A27B919560BC; Fri, 24 Jul 2026 03:59:54 +0000 (UTC) Received: from localhost (unknown [10.44.22.7]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id BC2AB1800259; Fri, 24 Jul 2026 03:59:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784865599; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DlFgiOgz3MpAX3lOOIcBo19JybVEA6Ma0tK0ZBICvQ0=; b=Ct0FEyVYBnCEfFlNPB4HE1e5LMNJwUfdrJRboXSeuvWIgBNqTbtzulZGpnH3DMnrctS/PM Asq3lWxZo2ExzA3WNYnww1A5mvHF7BJmuASAIV5O3f+O1AWEVZ/7qoGDXVNhsOD2PKRZnZ He0ULR0TeHLvGqnl362dHPSPBw+ESWM= X-MC-Unique: C4aeSseDPle2TuW8Ss4WkQ-1 X-Mimecast-MFC-AGG-ID: C4aeSseDPle2TuW8Ss4WkQ_1784865595 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , "Michael S. Tsirkin" , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Akihiko Odaki , Dmitry Osipenko Subject: [PATCH] hw/display/virtio-gpu: clear res->blob after detaching backing Date: Fri, 24 Jul 2026 07:59:49 +0400 Message-ID: <20260724035949.862331-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 3 X-Spam_score: 0.3 X-Spam_bar: / X-Spam_report: (0.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.951, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1784865623141158500 From: Marc-Andr=C3=A9 Lureau virtio_gpu_cleanup_mapping() tears down the udmabuf mapping (or, for the small-iov case, the guest memory mapping) via virtio_gpu_fini_udmabuf(), but leaves res->blob pointing at it afterwards. Once a blob resource goes through RESOURCE_DETACH_BACKING, res->blob is left dangling while res->blob_size is still non-zero. virtio_gpu_update_cursor_data() only checks res->blob_size before copying from res->blob, so UPDATE_CURSOR on a detached blob resource makes QEMU memcpy from freed memory. Clear res->blob once its backing is torn down, and check it before dereferencing in virtio_gpu_update_cursor_data(), logging both invalid conditions. Fixes: CVE-2026-66020 Fixes: bdd53f739273 ("virtio-gpu: Update cursor data using blob") Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3881 Reported-by: =E7=AB=A0=E9=B1=BC=E5=93=A5@aipy (www.aipyaipy.com) and swing = (swing@mail.exp.sh) Signed-off-by: Marc-Andr=C3=A9 Lureau Reported-by: swing Reported-by: =E7=AB=A0=E9=B1=BC=E5=93=A5@aipy (www.aipyaipy.com) --- hw/display/virtio-gpu.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c index cc6dbd116618..36d2bd9edee6 100644 --- a/hw/display/virtio-gpu.c +++ b/hw/display/virtio-gpu.c @@ -57,8 +57,16 @@ void virtio_gpu_update_cursor_data(VirtIOGPU *g, } =20 if (res->blob_size) { + if (!res->blob) { + qemu_log_mask(LOG_GUEST_ERROR, "%s: resource %d has no blob\n", + __func__, resource_id); + return; + } if (res->blob_size < (s->current_cursor->width * s->current_cursor->height * 4)) { + qemu_log_mask(LOG_GUEST_ERROR, + "%s: blob size too small for resource %d\n", + __func__, resource_id); return; } data =3D res->blob; @@ -968,6 +976,7 @@ void virtio_gpu_cleanup_mapping(VirtIOGPU *g, =20 if (res->blob) { virtio_gpu_fini_udmabuf(g, res); + res->blob =3D NULL; } } =20 --=20 2.55.0