From nobody Sat Jul 25 09:38:11 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1784647759; cv=none; d=zohomail.com; s=zohoarc; b=ZoP0OURVXk5S+UpB04Z81gidzaNQceWhr9opL5EHeMCHEwm0XOTKuilT9naeAXg8QKcST+nETY4hD2BcBcMRmvwfndiBVqhGtypsp9pUZwUm1m3KATTEeabnYh6QV4/VRKlWNnqgUvLosqmpwQbA8WXXBa78hDhO6SF2vuhyL+Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784647759; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=RrHP2yWqqGHlL7EfyvxdhZMwMroJeGKUGaFeuCZpCbU=; b=VCEBSbKMrxbVae/QzD/ghurZtHFQPEDC5aDSjJO0KauEZj88HZ1fxxToCE5dK9qyFZrQmJLJLLk3+ggw1srZY03aULhCnATwelsVZW4Ca82AHMXpKPO+Dm0FPLMfV/wih5GbZQdutwIiTUha0K9TD/d5S4Z+AjXm769e+Fwdx9k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784647759711234.4707532455866; Tue, 21 Jul 2026 08:29:19 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wmCOY-0004P8-JB; Tue, 21 Jul 2026 11:28:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wmCOX-0004Od-6H for qemu-devel@nongnu.org; Tue, 21 Jul 2026 11:28:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wmCOV-0008MY-9p for qemu-devel@nongnu.org; Tue, 21 Jul 2026 11:28:32 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-538-NPWIBBj1Oxiqx96P51cPJg-1; Tue, 21 Jul 2026 11:28:24 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 57F8B1955F2F for ; Tue, 21 Jul 2026 15:28:23 +0000 (UTC) Received: from localhost (unknown [10.44.22.7]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2B92F1598; Tue, 21 Jul 2026 15:28:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784647705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=RrHP2yWqqGHlL7EfyvxdhZMwMroJeGKUGaFeuCZpCbU=; b=hKdaHy0v5ckAOtft7BlU7pZs/pyG/8nhLA3n5kVGADbs101V3D4PyAb9sUO4YGaCtvmz3l HABvovdyc99/XoGHymCHLyr0cb5vE5gX5hUXFpuN6eCUbLO38w5Qu6ijD5Q2AC9TjmO47G eaAUkbUGbzT74ZtjE7cJhNgHYv799lo= X-MC-Unique: NPWIBBj1Oxiqx96P51cPJg-1 X-Mimecast-MFC-AGG-ID: NPWIBBj1Oxiqx96P51cPJg_1784647703 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PATCH] ui/vnc: remove redundant rows computation Date: Tue, 21 Jul 2026 19:28:15 +0400 Message-ID: <20260721152815.610844-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: permerror client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, T_SPF_PERMERROR=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1784647763044158500 From: Marc-Andr=C3=A9 Lureau "rows" was already computed in an earlier commit 3543c2b855 ("ui/vnc: fix OOB write in vnc_refresh_lossy_rect"). Fixes: e650e4fe0f ("ui/vnc: fix out-of-bounds write in lossy refresh dirty = marking") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- ui/vnc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/ui/vnc.c b/ui/vnc.c index 24aa40f7308..656768f9c99 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -3016,7 +3016,6 @@ static int vnc_refresh_lossy_rect(VncDisplay *vd, int= x, int y, =20 y =3D QEMU_ALIGN_DOWN(y, VNC_STAT_RECT); x =3D QEMU_ALIGN_DOWN(x, VNC_STAT_RECT); - rows =3D MIN(VNC_STAT_RECT, height - y); =20 rows =3D MIN(VNC_STAT_RECT, height - y); if (rows <=3D 0) { --=20 2.55.0