From nobody Sat Jul 25 09:32:10 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1784636526; cv=none; d=zohomail.com; s=zohoarc; b=K7g3bMAaI4D9eI0q8sI91CnjwZ0AV89tp71NA8bMXzUr+Bf79DUBn4yji+fCPT1VyP4NuLRdtYfAR+5KuLsu6/+tReF/+OYumfR8cfbJC+5aikQWUwwKmH1n0/nfbPAbutLKmTNS5L9ZzHM5I0OjB05tEwDLqBA9y4FefwHeMYg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784636526; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=CCs6xzzmYXlvnPqjtMYRNkoTvkbP9Kw7t9pq1Mn1d5g=; b=jHNFdt+aFOVnckIVYfD6M3vvRc+3afJqPOuAPx2Lhtls3y3ywePLgxfx78WQwye3O13I9zYcSDEUXL/w0rS2EbjnVirOJyOYDwjQDEAxYLpM8qZ7dWp9d8G1WhIM1BYCub2cLpX/PxzAh5WrKYrCrrgAx83UB2M8UnfiwCTrZzg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784636526170699.867327235602; Tue, 21 Jul 2026 05:22:06 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wm9Tu-0002ul-V1; Tue, 21 Jul 2026 08:21:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wm9Tp-0002kj-V5 for qemu-devel@nongnu.org; Tue, 21 Jul 2026 08:21:51 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wm9Tn-0003tz-Vt for qemu-devel@nongnu.org; Tue, 21 Jul 2026 08:21:49 -0400 Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66LARJwV1385792 for ; Tue, 21 Jul 2026 12:21:46 GMT Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fj1se23qh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Jul 2026 12:21:46 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-520a00c7a03so130769171cf.1 for ; Tue, 21 Jul 2026 05:21:46 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f63ee0086sm41657086f8f.30.2026.07.21.05.21.43 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 21 Jul 2026 05:21:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= CCs6xzzmYXlvnPqjtMYRNkoTvkbP9Kw7t9pq1Mn1d5g=; b=P9J6/4jc/bbOYzbr LoWP4YVYGc5OuqCXzj/lyAoQ+bObpPOPAuOmyzZK0IowCViaPdxJboGu1nFZBrB6 ateFtVon/ovH/tYfvqiIBezUJ4akc+sDFYISf7JRAdYSfu+GLAyBfsYobNqo9X48 zFOv/fRl1UKSLhyVoK6zwve8g4vWiPnWpQL8gUomeOgSYF7a/H9pF/3W0krQNp7P i4vFElifHAZpJS8oTRJ7/AoRDt7It/OSzauEuQ6iPkNdJN2pg0WVcm+1k+poERLE HHcm2ySLah2+jD/OXFmOg0mG5Fn7TdxIaaRwaMspI48iMxk+OrV6UK9sHKK7EGi7 VAniow== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784636506; x=1785241306; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=CCs6xzzmYXlvnPqjtMYRNkoTvkbP9Kw7t9pq1Mn1d5g=; b=A5M93Aw52BkAEJqGD8VkWi+jXdncj7mkM/GkxFPcsP873XPxjIrGG26X4yrQwcv9c/ Vn58qa0mLdVxFY536U+wIELfmpjztEFO5/4Ug3cJ4kDLBGpUJp6OqviL9z/WkrtB6Vub 19iTb4ynMN6UEBSZaisa0vuGajDlRUcrW/Cv8AKcXJ78AviptL5yxhmQ02Z26AUcACkD vaVUczV3VBDsl9Mhvpmyl2LN4tOPtxhaKcrJqW6yoqqrbD+n8NoctLkBuKa8qonMWhFr yihfKkj42NX78CJkkXBITHDfaJCOlsSjJwI+yhRUggGqKWum5TNTefC+SXqI5aN2z+lZ F1DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784636506; x=1785241306; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=CCs6xzzmYXlvnPqjtMYRNkoTvkbP9Kw7t9pq1Mn1d5g=; b=jt+tM4BKZP15zuxf11JD4B4ger6bLKNpauxD2zktrZGOrJvtkq5040Z89QQH8zBeFX FT8EQE17IiQ9978/fLcl4nXtpNfpVMYx/cxh/SP9FP4VoZXjPa87JSwFj+F86cfuzmUu M3T8tq/QzNfHcM24mER/LVbgNLK66g8Y47sDaj/QXf0qBdpoOIo1t6i3ryL4cg0GBGph ZSp8bRDQ0llwEx0TH4VicAr2wCpm3N7cW9/FpKUOwAGJ3E4xPRf32EoK2Yw/PJ8NXBdV Qq1N515E5UKDLLdWylNYjGhzXsMD6Y3/bbcYp3Frlor5TVCic71LLdl9S+xbdCgXbznt UoPg== X-Gm-Message-State: AOJu0YwSMq8vn4kXMnbKOdX5vAd3rFYYfNNZELNpTjR76+LD77bwdKse kmnxHKnBTDQEqSZ6KtTGuJUDqkEUdM6LWqefKK47MGxi3u/755lO06V066bcJeZ6UXsTYhxerah sz3/yY4nOBAKSNA49cTZNoV6csKs9L453uFTLMQU0SDSZ+HhYzqzlLBzNLNVcOy77cQ== X-Gm-Gg: AfdE7ckcd05PoztMznsFE96APSA5be7G9iOVyph3EARFRxNesz2eE43D3aUMRzLDb0G Qe1BimnVvGKMCuePNyD8vINymoMHAuflgrZbgbd/Ajl/oKWvWDR79DIlOzYqKRJVX9cIK7t1xnZ zgsRJcJ66Ax4kNQR9odmiy4rFDLn60aWNPbQh0oYfah9N+SU73IK/V2WSOCjM0QvZzw7OQrjeef UghVCDeRgCTGFm1DczQhc3Ko48TqZfQpvat9PF379P4Nf6VIya0J109FvAMx6YOjx/V3UfBzb/Y JbtzF1EtTSxOIjyWpbq4jWcciM06ehzcyE0UU6WVQYgBzr77E9M0Pv8bqZFkVL4MKkoyLIB4Jde dw/WcDhOn0J702h1fAAVejou/dzRrfVwd35uFKjaFeI6apMo+rf12hYU5Lw== X-Received: by 2002:a05:622a:60a:b0:516:db5d:ebf9 with SMTP id d75a77b69052e-5213e8769f5mr180499941cf.48.1784636505639; Tue, 21 Jul 2026 05:21:45 -0700 (PDT) X-Received: by 2002:a05:622a:60a:b0:516:db5d:ebf9 with SMTP id d75a77b69052e-5213e8769f5mr180499481cf.48.1784636505044; Tue, 21 Jul 2026 05:21:45 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Peter Maydell , qemu-arm@nongnu.org, Pierrick Bouvier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 1/4] hw/intc/arm_gicv3: Fix ARM_GICV3 dependency for KVM / WHPX Date: Tue, 21 Jul 2026 14:21:31 +0200 Message-ID: <20260721122135.6288-2-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260721122135.6288-1-philmd@oss.qualcomm.com> References: <20260721122135.6288-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: 4O-ZVAhd6KhzuU-u425j6mv-RJEYvgdk X-Authority-Analysis: v=2.4 cv=TIZ1jVla c=1 sm=1 tr=0 ts=6a5f645a cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=PZoDgyjJWSAZIzKEYywA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIxMDEzMSBTYWx0ZWRfX0KtF1FdXVwuS NbCq1ZDiPamWU8VlpCJMWT1lhuY3FKSBfEJImzzO9qaqLknFDiqpXTmr4DCHfzxoOIjq1lJtt8D +vP1a3b3t03hlirwoRxm3FBtEJzW4Is= X-Proofpoint-GUID: 4O-ZVAhd6KhzuU-u425j6mv-RJEYvgdk X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIxMDEzMSBTYWx0ZWRfX/eLoG4NBDcqs YJkC20o88Py6itc21KgywPUaSv7qNYEXc6qID8g5ZWIgA5s+/A8v5r+GnYZkI6hYp6EW2kqp1ge p/xkLXPYGleUCLESQ6nZZ95UTo4AO2eyrJATaEoqFvts5ctCDy/XiANWn8SIBipdGag8yuchxKW Gt8XehtfyOCUvaBDRs7SV9xsHoZX/uSnf71YRxxKgMRR1sG+zTwgLjTrbxnVA+fRW/Um5Zn+0f3 vz9Ya4jHUIeh+2iB0iGWXBz/j+uZkZWDMnTg+3zyyTEDqV+icRmN5wjShomDp8NqXYwZrUe+152 57gQ2BfuEDSN50SoHV/8vbhnpoUMbQThGo9lgc88WoF24D2LVCigjFu62GEskMV4XGCZT7s0Ea4 IvG5v6cTaYh7SoFRxI9knfyeJVFowQKtflgZbJNu3HXuwpERwtRCtoozpwRXUMP3IRobwwdbCw5 CsmEuN92s0vCnpEzyHQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-21_01,2026-07-20_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 priorityscore=1501 spamscore=0 clxscore=1015 malwarescore=0 bulkscore=0 suspectscore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607210131 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1784636526809158500 KVM and WHPX GICv3 implementations call gicv3_init_irqs_and_mmio() which is defined in arm_gicv3_common.c, itself build when ARM_GIC is selected. Both KVM and WHPX are conditional on ARM_GICV3, itself selecting ARM_GIC. Only build the ARM_GICV3 accelerator variants when ARM_GICV3 is selected. $ git grep -w gicv3_init_irqs_and_mmio hw/intc/arm_gicv3_common.c:314:void gicv3_init_irqs_and_mmio(GICv3State *s, hw/intc/arm_gicv3.c:450: gicv3_init_irqs_and_mmio(s, gicv3_set_irq, gic= _ops); hw/intc/arm_gicv3_hvf.c:710: gicv3_init_irqs_and_mmio(s, hvf_gicv3_set_= irq, NULL); hw/intc/arm_gicv3_kvm.c:822: gicv3_init_irqs_and_mmio(s, kvm_arm_gicv3_= set_irq, NULL); hw/intc/arm_gicv3_whpx.c:186: gicv3_init_irqs_and_mmio(s, whpx_gicv3_se= t_irq, NULL); Fixes: a7bf30342e6 ("hw/intc: Initial implementation of vGICv3") Fixes: e4c95f78a47 ("hw, target, accel: whpx: change apic_in_platform to ke= rnel_irqchip") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- hw/intc/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/intc/meson.build b/hw/intc/meson.build index fac2d228f9b..377de78bb41 100644 --- a/hw/intc/meson.build +++ b/hw/intc/meson.build @@ -45,10 +45,10 @@ specific_ss.add(when: 'CONFIG_APIC', if_true: files('ap= ic.c', 'apic_common.c')) arm_common_ss.add(when: 'CONFIG_ARM_GIC', if_true: files('arm_gicv3_cpuif_= common.c')) arm_common_ss.add(when: 'CONFIG_ARM_GICV3', if_true: files('arm_gicv3_cpui= f.c')) specific_ss.add(when: 'CONFIG_ARM_GIC_KVM', if_true: files('arm_gic_kvm.c'= )) -specific_ss.add(when: ['CONFIG_WHPX', 'TARGET_AARCH64'], if_true: files('a= rm_gicv3_whpx.c')) +specific_ss.add(when: ['CONFIG_WHPX', 'CONFIG_ARM_GICV3'], if_true: files(= 'arm_gicv3_whpx.c')) specific_ss.add(when: ['CONFIG_HVF', 'CONFIG_ARM_GICV3'], if_true: files('= arm_gicv3_hvf.c')) stub_ss.add(files('arm_gicv3_hvf_stub.c')) -specific_ss.add(when: ['CONFIG_ARM_GIC_KVM', 'TARGET_AARCH64'], if_true: f= iles('arm_gicv3_kvm.c', 'arm_gicv3_its_kvm.c')) +specific_ss.add(when: ['CONFIG_ARM_GIC_KVM', 'CONFIG_ARM_GICV3'], if_true:= files('arm_gicv3_kvm.c', 'arm_gicv3_its_kvm.c')) arm_common_ss.add(when: 'CONFIG_ARM_V7M', if_true: files('armv7m_nvic.c')) specific_ss.add(when: 'CONFIG_GRLIB', if_true: files('grlib_irqmp.c')) specific_ss.add(when: 'CONFIG_IOAPIC', if_true: files('ioapic.c')) --=20 2.53.0 From nobody Sat Jul 25 09:32:10 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1784636623; cv=none; d=zohomail.com; s=zohoarc; b=C9UqYNEjpcODE+9wqmgJazs9PSKLPWJPpntjovXAgrTLVfxX3Bh46UUTO4ww+u3u37gD7bmoM6z5JlKkRdcqYQtPka2okaRpn5hXVbks2c0khfPnjaRDxJ9fN8ub0HvwmpDiGt2jTWRrFnlUik+SpHxGGwscrcztgiHdR+EHgAo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784636623; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=rCdfC/fttUV6f/HWgpjNV1h6VJQ5cWJzdCAYU6K9+cA=; b=BH5Dbi7ZOnPDVLEG4Ftz5fF1g5NQZqK31Onl0aOjulKaXUpJBe8Twou345uNBtBdAVkA+jqinnEQk2/H3ctWMG1ni3Fej2aOOgdHpZi0h8zK4qrtO1lg2UwgaCSCUfAC3aDniwb4TN9xIcx7O+MHmFQPMJKxmnTO99Cspl8rNVk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784636623853814.7527141220672; Tue, 21 Jul 2026 05:23:43 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wm9U4-000396-AP; Tue, 21 Jul 2026 08:22:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wm9Tw-0002zC-Dj for qemu-devel@nongnu.org; Tue, 21 Jul 2026 08:21:57 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wm9Tu-0003ve-NP for qemu-devel@nongnu.org; Tue, 21 Jul 2026 08:21:56 -0400 Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66LARvft1252118 for ; Tue, 21 Jul 2026 12:21:53 GMT Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fhqvccewf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Jul 2026 12:21:53 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-5174a23afcbso98149171cf.3 for ; Tue, 21 Jul 2026 05:21:53 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49565373200sm63597595e9.5.2026.07.21.05.21.51 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 21 Jul 2026 05:21:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rCdfC/fttUV6f/HWgpjNV1h6VJQ5cWJzdCAYU6K9+cA=; b=p7rTyuMVzfGlYVzF Z8TDBsDs1l7daNU4ZsuL3uBWbySkDzQM1ATSDMPI31+uRba9uQ4MBeiB4T8iIDvA Mify4a+MKnMyHQHIrZJKwMttmfVgca6txxLkM7AmfQebxIMIw7gsAdajY/hFCsSN RQiR5Jotq9H/RsskiipCraUPHZ1qukQxoBLd2LuvZNKtyfbAyZH90Y5qthR33MFY qFIVbnmPGQucRup+0HvpEBxNv/vh+D6mtGwUIDzjoYJWhMueZB7mkjdnhLueaiDw BJd61BtxZauKm7KbLl7G5gonNM3sfLyxpkkPtjG5fMpx8xenic+TLSG+zrrsMOHF +QDctw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784636513; x=1785241313; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=rCdfC/fttUV6f/HWgpjNV1h6VJQ5cWJzdCAYU6K9+cA=; b=gDm8b9DF0O8UtubKeWoRulKymxYExypmaJi962wujLvyzSJg9xfHgaoLj8bNYqBByV Xb4CcEcsVQRAAAzrZUiV2MRafECvbkarml7IJssYDl19acdbY8awLrVbWvEOwZ9U6wK4 /MNz2H9fmcSwUZV5iqvIJzVTBXEBUBKj6VStrT19QXQbw/mq7lQsddc4zo3ZgbSHmiA1 UHGF16zt3BzuTflDIRQWHh/QltLYVv6FgdgJbcmPOoAb9tMqeZlpv+0lt16kCVfrYwze 0gAtihp4uIPUN1+PSBZ8UommTbxB3UcO+uy9DRzqODicqA61r6eKy4eiPLt75vuxu+Aa yKxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784636513; x=1785241313; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=rCdfC/fttUV6f/HWgpjNV1h6VJQ5cWJzdCAYU6K9+cA=; b=g5qUuOB09eZZDDudbBi8KMspMSC0kx0V7EtzmLc7FraV0nQwz/cmXjf3oLr+O9O46g Jl8khCsiECLVzeXOiT8AllJz49wWwFqAroI0+Yz2qZV9WLsU1Dz6Sl0TlSkmTXB36mRW AJGwoO+RGqwazzPqQiMA3eN35KiW09+3C/ck5ZNrXQRT/x8VpIanhkup3YPStpRUyuUg SBWCT5futy84VZvhbjFQvMzmJUU3NhSrIfBz4+PG53tOw7dauvUEczJ45v0VGndCsFoA nJexXN9284i0roWKRtonUvJZKXkaybymckKWBZcG0p7c/k0j3sNffDthXMFFb+YY0L+D 7MWA== X-Gm-Message-State: AOJu0YwUN3tV1D3ce3fibYzdNacb04A8M1TjPwNJjmRANskhxBt8VDm9 HLKITAIcrXiEtpIPl5JkbPUoIFdq70OKwzBok8G17hTfF6XGgZWVqJhIRW0oiYx0GEjSluejdY2 PK6oXyoPc26LYE2c4/hvXjley9NsXt0N9G7j5zbQ9CdmrcCT37rCcEwAilpx+K+1rrg== X-Gm-Gg: AfdE7ck3jmwEZdYIcpCds32wL629DY4TPVdcsDok1zsAI/fqMPspCERIx//kRzPWTsj eHwMXTwIoXY1TPrXCCq9f9avfp1VWP7qR/G2PfYOtPxt/3deLNFI8Xb1mLfi6nUIfOllza28elA Y1BS6sA28/7VD6bK8jdzvvaW3/Du2xp3KpzLQ3SXSZr8cWlB0IQLN5SdEiBsb1q8N0td8Quc5dM lW9/wDy1whO97CVT4jEQGGQ1vWXB7piJ+U0py12oV6EpvQxBDFjfhXhXWcCji6rjZMlPhl/URMm e4gzWImm1jhTUJs8GdbEgTnuwcqzDL0laaJL5aV6/bmyQyBM3KN52ErhExM1EthjFyDhyAIAboK 9NUVUEAJl5Ew6qbXNP6Kjf2jyVUtXPs2N4Ka6heq5/NYRJyK/McvNVGe7gQ== X-Received: by 2002:a05:622a:2616:b0:51c:10aa:9ba with SMTP id d75a77b69052e-5213e48b0d0mr161920841cf.46.1784636512756; Tue, 21 Jul 2026 05:21:52 -0700 (PDT) X-Received: by 2002:a05:622a:2616:b0:51c:10aa:9ba with SMTP id d75a77b69052e-5213e48b0d0mr161920411cf.46.1784636512197; Tue, 21 Jul 2026 05:21:52 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Peter Maydell , qemu-arm@nongnu.org, Pierrick Bouvier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 2/4] target/arm: Add stub for define_gicv5_cpuif_regs() Date: Tue, 21 Jul 2026 14:21:32 +0200 Message-ID: <20260721122135.6288-3-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260721122135.6288-1-philmd@oss.qualcomm.com> References: <20260721122135.6288-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIxMDEzMSBTYWx0ZWRfX7r6nD2RYUMRW v68IIvM6G7cD7WqE+CTeyJYcbv82DvcfU5To7WVZOEEiG4yiQ9XPyb3pw7cwDkixiOogTgSGfo4 1bptIJdU+EvbwV/8OgDQ8RyBzNLPnJE= X-Proofpoint-GUID: EyFQJHik0YVZhxzCr18ANQbKdCrt5G9J X-Authority-Analysis: v=2.4 cv=OMYXGyaB c=1 sm=1 tr=0 ts=6a5f6461 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=TAc-z3PBzWRmM4gypW4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-ORIG-GUID: EyFQJHik0YVZhxzCr18ANQbKdCrt5G9J X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIxMDEzMSBTYWx0ZWRfX6T0Y5owO2rbY +SEhx+uyjvTGvx9kw605pSXawA2BQWeVFlCGBhUvTKK4w6C/2q+iIsz0kH1oAw1fcGNR40+6qFK zY313gk6Ti4dVWDQxX4dR1YF4seyCDhY+1uBQ1utiyPsBRbP738txJCntjpO5PNlXSLLK+5VgF7 ea9vXgn+zu9fp8pVJH6yDDGuVKQV7tOMDJ9pW7f7UKtBzjbyggqmsKddR6ZXXEGITm7zX1d1+wS nB8sEYguJqP/gDhEyP2iT5rNwrQi+mc4s4+W1ba2kC/78cBqd5IcazknK1pM/9Cjc+yAq51okYV 6rCYWqHxJnVjIfxzXmO2KNZ+X26xtmzEk/CZmGVDbCsMP27LoQIEvYDtJBpF4tKj8PfR33aQx47 J1l/vBDkau3iT6tlgYSrq8/P1rxEI47yHlOKL46BtfLaOetBy4+q6tJ+kYribiOAHKo0AmnRnY1 991fPeWmvk37mijiA4A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-21_01,2026-07-20_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 clxscore=1015 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607210131 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1784636624147158500 The common helper.c file calls define_gicv5_cpuif_regs() which is only defined when TCG is built: $ git grep -w define_gicv5_cpuif_regs target/arm/internals.h:1885:void define_gicv5_cpuif_regs(ARMCPU *cpu); target/arm/helper.c:6334: define_gicv5_cpuif_regs(cpu); target/arm/tcg/gicv5-cpuif.c:923:void define_gicv5_cpuif_regs(ARMCPU *cpu) This fixes when building on macOS with --disable-tcg: Undefined symbols for architecture arm64: "_define_gicv5_cpuif_regs", referenced from: _register_cp_regs_for_features in target_arm_helper.c.o Define the GICv5 stubs in their own compilation unit, otherwise we get the following error: duplicate symbol '_raise_exception_ra' in: libsystem_arm.a.p/target_arm_tcg_op_helper.c.o libstubs_arm.a[4](target_arm_tcg-stubs.c.o) Fixes: ee0f1ce00db ("target/arm: GICv5 cpuif: Initial skeleton and GSB barr= ier insns") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/gicv5-stubs.c | 17 +++++++++++++++++ target/arm/tcg-stubs.c | 4 ---- target/arm/meson.build | 1 + 3 files changed, 18 insertions(+), 4 deletions(-) create mode 100644 target/arm/gicv5-stubs.c diff --git a/target/arm/gicv5-stubs.c b/target/arm/gicv5-stubs.c new file mode 100644 index 00000000000..845626d7c6b --- /dev/null +++ b/target/arm/gicv5-stubs.c @@ -0,0 +1,17 @@ +/* + * QEMU ARM stubs for GICv5 TCG helper functions + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include "qemu/osdep.h" +#include "internals.h" + +void define_gicv5_cpuif_regs(ARMCPU *cpu) +{ + g_assert_not_reached(); +} + +void gicv5_update_ppi_state(CPUARMState *env, int ppi, bool level) +{ +} diff --git a/target/arm/tcg-stubs.c b/target/arm/tcg-stubs.c index 8d97449cfc6..aeeede80661 100644 --- a/target/arm/tcg-stubs.c +++ b/target/arm/tcg-stubs.c @@ -43,7 +43,3 @@ void vfp_clear_float_status_exc_flags(CPUARMState *env) void vfp_set_fpcr_to_host(CPUARMState *env, uint32_t val, uint32_t mask) { } - -void gicv5_update_ppi_state(CPUARMState *env, int ppi, bool level) -{ -} diff --git a/target/arm/meson.build b/target/arm/meson.build index 4412fde065f..f6ae8934d1b 100644 --- a/target/arm/meson.build +++ b/target/arm/meson.build @@ -37,6 +37,7 @@ arm_system_ss.add(when: 'CONFIG_HVF', if_true: files('hyp= _gdbstub.c')) arm_user_ss.add(files('cpu.c')) arm_stubs_ss.add(files( 'cpu32-stubs.c', + 'gicv5-stubs.c', 'kvm-stub.c' )) arm_user_ss.add(files( --=20 2.53.0 From nobody Sat Jul 25 09:32:10 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1784636576; cv=none; d=zohomail.com; s=zohoarc; b=DKXiBy2zhWU1MA5MSyjCGYMwXwq9aO3PjjXMA2XUy6gn1RU5KFyTVoKcfa3XYb6WAPKt3rc7rTR0NF1CH3uV4L5V35+qMjWbzRD06EU9EmMygkjl+yubRCGt63QK9tOeTKXP34mclizgJl0TKFK4YOVLzhy8ZfSDLG2VSSkXtnM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784636576; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Sg+aRlSfL1je4BTZTcRTkOp9Hr5XLA1t0eyNuOYYM9s=; b=iw5VC7B1QeXVjKjXi3rFaxzvHdOTpKKpKQBFv0ABPG2Y7QXbygYafFskC6kVhVFdsMhbAJk0gynw3R+TW5DpPo8zBaGbaxWiQvKqjx7JoSDZdD7eXvPBWHyRWH2AgRbx8VHb1iYHP9z6mMjXqNZygQGv3wNSnY9u05hOmmz13eg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784636576611711.6901662516309; Tue, 21 Jul 2026 05:22:56 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wm9UN-0003cJ-4G; Tue, 21 Jul 2026 08:22:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wm9U5-0003Gw-OB for qemu-devel@nongnu.org; Tue, 21 Jul 2026 08:22:05 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wm9U4-0003wZ-5J for qemu-devel@nongnu.org; Tue, 21 Jul 2026 08:22:05 -0400 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66LART7v1455614 for ; Tue, 21 Jul 2026 12:22:01 GMT Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fj1duj855-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Jul 2026 12:22:00 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-52769fc3f2eso1901171cf.0 for ; Tue, 21 Jul 2026 05:22:00 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49548e0fcdbsm309001545e9.2.2026.07.21.05.21.58 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 21 Jul 2026 05:21:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Sg+aRlSfL1je4BTZTcRTkOp9Hr5XLA1t0eyNuOYYM9s=; b=Um1G55YFxtOpIwik YxKX58AksiBbWDaHidB6DZZwxRbH94d7NiGo57rLHZf3Y/Gd0KXw4yB2lKM5pz8z hjKN4qPsj/d9ppLZ9wATGpgWWu8kSfRnHOZsNdTy3tUqQyoiQ74LLVIy86rHaTd+ UPEuZwa/Ntez7PqWKZ31JOjxwgpkPHlCbmpAXY8d8edmV1BRLWn3DsaSRy2ffP59 BIf2njiGZ3swIVXF9dyCUr0L6CKd0sAlhLEUyK39GPssGum+lBCNwnHbQiaAJcHC pFp2pGcP0JhtVj7esDuQmWR5SkuEjrSUgkS3zBeQhbAo7tv66RAYfn5BT1hISoFs vKjxmw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784636520; x=1785241320; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=Sg+aRlSfL1je4BTZTcRTkOp9Hr5XLA1t0eyNuOYYM9s=; b=PG2GF+2S61eQMBd36Er1O9FLV0ZBkQjFRok91ekKpMwni8iXVwuf9MvquROAybaqQ5 dGjCYSQ/qM3yCakFNHSKAqzD5HP9OgwOShUQsTAco4Ll7F/pDJhlv3a28kvQYz7BRiz9 ZMrsmuFduQ0A+KWmD5AxuvKH2+p5+TQROcjw+Q4cCNw2KjgS2OLSt1V5dAbvDPj2/oF1 J7t6/rXwMBqT+S1FCT7ooA1ZVmjfBTYHKl9TjuJVzLJP7EyA/DFMzx5vqkNfeBeX+e6A 53Ce/B1XAvfQ1RE/C6sbAqpRtArshBmGgtpKWDh3uDLnlpS+s+vQqaU2Q4BpRyys112O 2oNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784636520; x=1785241320; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Sg+aRlSfL1je4BTZTcRTkOp9Hr5XLA1t0eyNuOYYM9s=; b=H1kAk0bohE/4wZlJD8v5QzOkTjf6rxStZ+/cygJAfBpbmnaqt61WK1LY53o2rm2JG6 bpvFC4TE4G+YYkTO5+1p9LuEIoY/6Jp6E2D3zpjSeXPpOjoPtdWmTcyqQLjiBGtHh1L8 7psISZRU92YtG1AydDW7a4pc4ddXj+6bco2cvrh06DDowEw3KiBnNVk6vWtlC9dbCEBa jlFqT+Ijl9vski5gmAwnM2cbvnDMTEoxDizaRI4bOCoORqrhcTKSmL30O6Z96FBtUaTl WZMC6003aLEm3gCWrkWfVA74te79Ul1UU2nlqrHDNYFgsRDMjFOJIjXcGN+s6nBMsDLk KtvA== X-Gm-Message-State: AOJu0Yyxrc8cETOULGkLx9+M3CJneMPRMHhUgdVlwcvOPrF/vNcV56Ek cfLW9I1imWAYdMohyXkB0muiZ+djd3dw44Gfnig8d73FX5ds2S7Kao0vkdAdfuP5uk8ukebD2NU yAtH1rT2o4wkzild/CGb4RdV0e6+RlS4T9WfHIVdLDTfRtz8R1tDxMs8JgzxfjfXvXw== X-Gm-Gg: AfdE7cn2du7k6udTqGMdCKuCnQWW2nfOP6ZdZozVhqDlyDd8EVQ+12OSEONIzedo5UZ Fy84IuSo0BRqF4J6ap1EVyv5vkkJSeGlMLBknxqz8DG/m7GNU/DT3IhPoJCWZuFb9m8PugPEXJ+ TpRp6mmKtc8qts2mNNRAA2LxBQL//ZgSMLUGLDYTRqO9KIabKiuG0+UG17t6fs57rEf0jFfumWi tLYQGpeowcy0/FQ7ZOc4ClajThASmFh+Fqw7+i7xn+iZDvCT9wWnkw0QfDon5eZSiSf/I55ASeC 0F4N2Y6LKiOLHZze8QtpzOF65mSD3jeIutJuRSj5JtmJ5AQFOxq6P7ytqygYSYCNINMBfNgawAY XfjJndEMwqnZxNU4JJIeP2rvyM/zueYF8+kY/Hj9Vq0crRoZYenklstokjg== X-Received: by 2002:a05:622a:2b07:b0:51c:7b12:5fe6 with SMTP id d75a77b69052e-5213f378922mr180367251cf.82.1784636519991; Tue, 21 Jul 2026 05:21:59 -0700 (PDT) X-Received: by 2002:a05:622a:2b07:b0:51c:7b12:5fe6 with SMTP id d75a77b69052e-5213f378922mr180366871cf.82.1784636519457; Tue, 21 Jul 2026 05:21:59 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Peter Maydell , qemu-arm@nongnu.org, Pierrick Bouvier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 3/4] target/arm: Only compile gicv5-cpuif.c when GICv5 is selected Date: Tue, 21 Jul 2026 14:21:33 +0200 Message-ID: <20260721122135.6288-4-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260721122135.6288-1-philmd@oss.qualcomm.com> References: <20260721122135.6288-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: I0_36NrA4adraf_nRG9L0j3A1Ivwq_D3 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIxMDEzMSBTYWx0ZWRfX4OsOV6xpOYxT 1VKG28d/QjdEzszG7B97j1E+N0xc/kefCmqfSeOoFrVdAeYXE+acU0mqpeBW4AMP+jUI1qJbfIe 7fpKuNjMgQtWrmzi/56RluV4XbqsvA1wGp7KoTYwNZMHM6FufrHCW4H/+tmzlWoHY5xBkuApUlu DFauoTTPGNki3QUorDa286IvHfLJJkWLpVWMeWzPL5AHH5A+FpYK793St+DLd8Nsq99VqeJkLuH +P+SW4glMv7gvdJcaI8dW86+LawqUz9+O67p/WZ512WTpWM+XRJL23umafqwwINXsut939hLPHE 0SFeitJr+a2OB/ZQeGN0KxWJXol/YeREGApqjH4daArjyg36qlu+AsPh0XKyNIsObr580lOMsHb iefo82pFuycw3FPRY5GMSfGH96pHUtk3o6TuvDNvPIJ4BiZvpvwNwnvrkRzUqZ6a4zJ58jz9FCP NVppVwaNFn4L5UgKUbw== X-Authority-Analysis: v=2.4 cv=I9JVgtgg c=1 sm=1 tr=0 ts=6a5f6468 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=EH4q0pLv-eCGfy9bPtsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-GUID: I0_36NrA4adraf_nRG9L0j3A1Ivwq_D3 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIxMDEzMSBTYWx0ZWRfX02NCleBmJXAV v15d4vLpYSuCFGSlfz4D4hBq8ZRvpF+/JShgulfADirZgXOma/1gkGM6BAt/wMCMdQmU8vTCPeg kfzlPZsr3wS26Fy1yzpWHxaQK0eBi4Q= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-21_01,2026-07-20_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 spamscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607210131 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1784636577883158500 Only compile gicv5-cpuif.c when ARM_GICV5 is Kconfig-selected, otherwise we get when building with --without-default-devices: Undefined symbols for architecture arm64: "_gicv5_activate", referenced from: _gicr_cdia_read in target_arm_tcg_gicv5-cpuif.c.o "_gicv5_deactivate", referenced from: _gic_cddi_write in target_arm_tcg_gicv5-cpuif.c.o "_gicv5_get_hppi", referenced from: _gic_hppi in target_arm_tcg_gicv5-cpuif.c.o "_gicv5_request_config", referenced from: _gic_cdrcfg_write in target_arm_tcg_gicv5-cpuif.c.o "_gicv5_set_enabled", referenced from: _gic_cddis_write in target_arm_tcg_gicv5-cpuif.c.o _gic_cden_write in target_arm_tcg_gicv5-cpuif.c.o "_gicv5_set_handling", referenced from: _gic_cdhm_write in target_arm_tcg_gicv5-cpuif.c.o "_gicv5_set_pending", referenced from: _gic_cdpend_write in target_arm_tcg_gicv5-cpuif.c.o "_gicv5_set_priority", referenced from: _gic_cdpri_write in target_arm_tcg_gicv5-cpuif.c.o "_gicv5_set_target", referenced from: _gic_cdaff_write in target_arm_tcg_gicv5-cpuif.c.o Fixes: ee0f1ce00db ("target/arm: GICv5 cpuif: Initial skeleton and GSB barr= ier insns") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/tcg/meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/arm/tcg/meson.build b/target/arm/tcg/meson.build index 573e8b5af48..1cd98c1b857 100644 --- a/target/arm/tcg/meson.build +++ b/target/arm/tcg/meson.build @@ -83,11 +83,13 @@ arm_common_user_system_ss.add(when: 'TARGET_AARCH64', i= f_true: files( arm_common_system_ss.add(files( 'cpregs-at.c', 'cpu32-system.c', - 'gicv5-cpuif.c', 'psci.c', 'tlb_helper.c', 'tlb-insns.c', )) +arm_common_system_ss.add(when: 'CONFIG_ARM_GICV5', if_true: files( + 'gicv5-cpuif.c', +)) arm_user_ss.add(files( 'tlb_helper.c', )) --=20 2.53.0 From nobody Sat Jul 25 09:32:10 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1784636576; cv=none; d=zohomail.com; s=zohoarc; b=b5MJAjMWHa65Z8SObLrmGUqdhlDnAvtMn87Ba5d4ybCAVWMVvezLWTWGxsby7JBkPA77kcUYXTpQvvHQsI0lc3zesR8zmzC/gS9w7vhAew2y/oIMajnXJ1d4hFdQLxGkm5hMlq49+0Jf3bw00binabayBnRUfRHJw3jbfcvM5oE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784636576; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=sW0H4vPzhW2N5b8QWJcMqMYu6iN7HTkZwHNpnDBN3VY=; b=loNEpCLmzukBFIMimTUvV6XRt0lMCE2cio8hiGMzV+CzcCu06zC6TmJoKE/w9zonOeTtiZX65oyohJ5Dav/zvFYcNlkdO0OqlASs86NB+hrb5+7un9OqPoi9IuxARFE4i/ynfF6jNjlBM9Tlh2zC8SIyfnxncaQA32bg4nEY0CM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784636576935727.4395251367022; Tue, 21 Jul 2026 05:22:56 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wm9Ug-0003qi-LQ; Tue, 21 Jul 2026 08:22:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wm9UA-0003QU-DZ for qemu-devel@nongnu.org; Tue, 21 Jul 2026 08:22:12 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wm9U8-0003x5-Rf for qemu-devel@nongnu.org; Tue, 21 Jul 2026 08:22:10 -0400 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66LARNHL1499956 for ; Tue, 21 Jul 2026 12:22:08 GMT Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fj1bvt89w-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Jul 2026 12:22:07 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51c1d30035dso143634181cf.2 for ; Tue, 21 Jul 2026 05:22:07 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4956537c7desm86665805e9.7.2026.07.21.05.22.05 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 21 Jul 2026 05:22:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sW0H4vPzhW2N5b8QWJcMqMYu6iN7HTkZwHNpnDBN3VY=; b=TgbVVe/W1AhaBuJz jKO5zXm0GiI+PwpHbYAifkCk5MsU0/+/l1IV81x2NuZYoHrjdG5mBAkSNNCfNg9v YBw+hTz5oY0ZCrGRKEM1s8EUcXvXiJ2wwGA9eMD0aaIeWJQ51uKNv7ZQ8Lkf7gHH HKB/mIMnmUyCbTUDDS17TjOj104zkI6ZsjptaMcZlPDML2aV4r9q/4oiG+F7k4zP UVFuiMv7P9vdCaYEgr5AS/6ZUQD5RnpTb51yzv8DsuNiWIsS8ApFTf9beHF1uEiK RfIIv7bLf+UIq3z/H+y4E7foGZQxfUCui0NBnqNyg4fZtgjyc7pEDCySb+bXhrMf tBthRQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784636527; x=1785241327; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=sW0H4vPzhW2N5b8QWJcMqMYu6iN7HTkZwHNpnDBN3VY=; b=cn8lYKDJ8jbx1JyR66r8bWLT9dqUHG97C7aOt3kxK12Z368V7VrKVoj8kYO+Ip82cP 9W1LnaWsqhbQnN6DopvE6A/QIBSgQ7IRKGsK9Gz9w0dJHBfUcxzYJc9emN8lE76iCQt5 7FU2OhoiKgiujcCYXv/xhMTQahrRQTtfpqpj8G3zhoFKPOTe/3n8WY4XR71CIfdMROAZ aKAidhAqjFIBjOrftyXQlv6VJ7sgFwuArOMRPtry0wuA7iIC/Wacou+k56//if0pyi1G 9Q2OHONa9kTzcwWgkYmFTCx4mstbLL1+C3pk7vLecrJFLU+XHxPy1LDrDGqqe5bJ9v88 tytQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784636527; x=1785241327; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=sW0H4vPzhW2N5b8QWJcMqMYu6iN7HTkZwHNpnDBN3VY=; b=G7PMNihxFfyH1dxnpgKsCq2npqo8mjOxZRSpnsYTMp5mMbXUVzH6L05a/n/bVNki7A vP9+NWo6xMExKHet2xKfKNLKk8btIEGEuKyQwS49IJzPHwqADqVwI98SD/0HYjKl1HzO LnKx6ehdM6wotQOvL3r30sP79r97r4Hgx0Blj/V88M5DM6X82cqnCbERnTn5jAOB9C3L aRond0U0/6Zi6hVzKI9I8wlcH6VhWw+Nm8636KKOF8LjQ2FAj50qBbYhCTrXuAH20fos 0BiYOE9LZMVkgfXJLNaYjCYXSUQAmNXsry5b4k+u0EYtUtMoi0uYzANELO93yvc46vrM FJFQ== X-Gm-Message-State: AOJu0YxuZ7bIfXl/QIB2IFZkwnMkz13x7KNma9tKrgcobEsnM9tODE6c 53DS+8zixtI2qQCVNebBGoyHCBbLlYxhi9acilKXNQg/Rnp/Up+wYZ1foV1CLkGxFEwC9NlRDmq 7hDoNfVhCi7064g6pGx95LUm0b+wjqR/cTjmisnhw73WEAGYRhlvRZePzenEJtw2IvA== X-Gm-Gg: AfdE7cnMfnDkyWAH+qYcPn9ywkD5cZmXPjflPI72iLVl/GiDOav3h3V4WBbS2r2y7rC xWfJYplNTZil5xDRZHtMe5tocdbOwF5zvDuss+/4smTn087+og6Xaq0uFxGZxn1N7kKsE9m2Lim A0xFxV8mOQMXBUFDwhyQgnfEFs8cEAGO1gUrYOSa27ch03etR7kT5VeameKIdqbcSV9jVg6wo5S BYFlPGJkjawSb3ssPk+LD+3zat5pjiad8iVseFK9F/F7QwLMY1tpQbIElqISkVXNYwv6dktgC7x 36aOpRHhkSBQQ2tyX0MGYfpcWX/N5tZBry8OS37h2zbBKqezbBeKgMZ/4O3Qm+q2UnOo4AdWfLK my2XcE7fyhkOZIgNgx5wUUiSBVR33TcuwNNgKU2WGiZilGvcojinFfreEsA== X-Received: by 2002:ac8:7dcb:0:b0:51a:8c97:938e with SMTP id d75a77b69052e-5213e188626mr163570421cf.69.1784636527135; Tue, 21 Jul 2026 05:22:07 -0700 (PDT) X-Received: by 2002:ac8:7dcb:0:b0:51a:8c97:938e with SMTP id d75a77b69052e-5213e188626mr163570081cf.69.1784636526685; Tue, 21 Jul 2026 05:22:06 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Peter Maydell , qemu-arm@nongnu.org, Pierrick Bouvier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 4/4] target/arm: Build TCG stubs as stub library Date: Tue, 21 Jul 2026 14:21:34 +0200 Message-ID: <20260721122135.6288-5-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260721122135.6288-1-philmd@oss.qualcomm.com> References: <20260721122135.6288-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: ml7CHUhWQn0RLffc-jOUG04gUz_aB15y X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIxMDEzMSBTYWx0ZWRfXwtI0Po9Q5Pjf +f28Os1Qzq41+zU9K4TjYkE4L63XdK/Hor9K7s0ZE0Ys5sNbZ6VaJSabnPNybZNU2nYmjsTFxAh m3IPlQ4LB1dlQTIqchUShc5ZDtc9bu4= X-Proofpoint-GUID: ml7CHUhWQn0RLffc-jOUG04gUz_aB15y X-Authority-Analysis: v=2.4 cv=Sb7HsPRu c=1 sm=1 tr=0 ts=6a5f646f cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=dYXcIrvnCqDwK9geEd8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=0lgtpPvCYYIA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIxMDEzMSBTYWx0ZWRfX9ceHaQgiXPdg L8QH2kTjvxZyNJTmY8aUcd8AoxYVuuxVIrXW25n1q4vpZZsJXLTHl+fwSyuBmMdGBNdYksOR3Vp A0B3tfC5uoSIkWBWk/hpb9m19HqtUvK1xL9Vcnq46IqnSJfIcuYwtwx1Z8xR3mYxvp6L9qV8qxu goHFhiwE4ohpCXO7TzYzTX08ScYN8SlXanqDzBOJE5brdesHwHvG7/JI42whVlN+0mXnP9Jy4IV 3pAo+O1r7DkxMl28ok5p9nqTkIq8gUbeoC+MtHTJbYxTugQ0a+HJbcWVxpYy0gqP/StygcP9Tag 68ZWPn9UYBr/iskRHO/20N6oYpmMTUWZMpzi8C73Zuzp9/aO0qY/i5EvajMgFI9/gtbjdxhiMDT T9Py1QPAptgDJNCxYYHV064H4T2GxkUhtHzop2AS7RROxRgc1pZwTYZfaCZ59yBVLAHgeysPxqN wmx4lrVhhPQvt4DNmKg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-21_01,2026-07-20_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 spamscore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607210131 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1784636577866158500 Use the stub library introduced in commit 0da978cdbc6 ("target/arm: define stub library") to prevent symbol conflicts. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/meson.build | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/target/arm/meson.build b/target/arm/meson.build index f6ae8934d1b..0369f96b4cc 100644 --- a/target/arm/meson.build +++ b/target/arm/meson.build @@ -38,7 +38,8 @@ arm_user_ss.add(files('cpu.c')) arm_stubs_ss.add(files( 'cpu32-stubs.c', 'gicv5-stubs.c', - 'kvm-stub.c' + 'kvm-stub.c', + 'tcg-stubs.c', )) arm_user_ss.add(files( 'el2-stubs.c', @@ -65,8 +66,6 @@ subdir('whpx') =20 if 'CONFIG_TCG' in config_all_accel subdir('tcg') -else - arm_common_system_ss.add(files('tcg-stubs.c')) endif =20 arm_user_ss.add_all(arm_common_user_system_ss) --=20 2.53.0