From nobody Sat Jul 25 13:40:27 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1784315788; cv=none; d=zohomail.com; s=zohoarc; b=liGEv1X8Oyrf11zhcLy7tSo+ukwq4aXugPYRw6YBd2tQvDNeFUQKOBJcrCXNgpCsmQv8vRlQ3iEIA8En31A2ngrk/XBtKYS5EHF+HQqubC7b9gO4o4mAXCrVMcaxG5VvqN4Xo1vzrQyTooKV1I9sEk5CG/NJm4gzlZDvnFIwTJM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784315788; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=mxXJevFcd/n8CZD5ELOwHmvJeo9/m5LpxRY+ceTLUBY=; b=k5e5SpaqYEFEfh69GLMqkiAe1yEOLW4U1f6fSDEVbUA4+mi7O0cyGd5bPERHxIjqb8ZOuWJ++oql6CynDFnJzUevB2x1Oca0KVGx8JqRuJmbRfEquHWojzQTKWCss2qcxHFwSM5+CpzM51nXY/6PUrTvnOwcix9bBBGwsZ8dP7I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784315788583668.6582855722937; Fri, 17 Jul 2026 12:16:28 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wko2Q-0006lc-5l; Fri, 17 Jul 2026 15:15:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wko2P-0006lD-1n for qemu-devel@nongnu.org; Fri, 17 Jul 2026 15:15:57 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wko2N-00083i-95 for qemu-devel@nongnu.org; Fri, 17 Jul 2026 15:15:56 -0400 Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66HGo5qn2372091 for ; Fri, 17 Jul 2026 19:15:54 GMT Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fff9gu00y-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Jul 2026 19:15:54 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2cc7e86e7c5so143977675ad.3 for ; Fri, 17 Jul 2026 12:15:53 -0700 (PDT) Received: from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31429f9d444sm11602463eec.6.2026.07.17.12.15.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 12:15:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mxXJevFcd/n8CZD5ELOwHmvJeo9/m5LpxRY+ceTLUBY=; b=jbmW0mYWvjbPB3Uc /IVeYcfAasPCHQ0lOlUI9e72j7ZxweYioHm7nYH6MO+gISwEoxY8P+g2j+j2yB7J eFrd37a6XUlT1xaqGL0qS+u3gv3UCM7ye5IomsG7U+LFqbQKL3KCF1h9rw5fk9gU tJptl1P3eyKaHoJGr5ClXSn2KE5KXRiVNdLEnvH5qOwoG7rc2QwqCSfQ3dbGKLpa YmbeXFE/7seBQ+O6oh2pg6b9GjCl3lP+T2jOSau5N8MaeU1V6nR5HDkkJY9ADv41 vLHYEstRZnjdkvcHByq+XAhW3dfJR0Gq9L8Zc3yDJHW5o3Pc7rcOEx5ClTwlzJyp OIlmlA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784315753; x=1784920553; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=mxXJevFcd/n8CZD5ELOwHmvJeo9/m5LpxRY+ceTLUBY=; b=Bz8Uysl8Lsb32mpqAexN+h061W9TeBFpSI+/M+5a4Zt6aFM8yYTOIyCTvS0GKnLnH4 Ta8gN8sJBzQ8BvHEkZf2OciYOsZp+Zq3bsFo7sQISCzgugeXxUED9hTUBqrfeGkkFVcz lG86t0TtSe9h1ooWcuzal7GHdMo9I+SUIT2h+XdrV18KPKmFJQf21cX86UeU62VQFwHG yBCXZ4bHT/C5LYDN6S5zMhfgUNnEDeB77viu+5YjEQkgmupt0rJgph854/344genhkL4 HaGuVtSYMSIjrnf5UcxDfFcnt+6avzxt0DtaDvrZSc/OsAIqYTfa+6vkIOsaq1a9QMP2 OFjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784315753; x=1784920553; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=mxXJevFcd/n8CZD5ELOwHmvJeo9/m5LpxRY+ceTLUBY=; b=rPHwmzFdnqGaimGeYtNspGLoxgSLPd/PAzEVvP269eeUYr0j6IF/fpFqvn3tDbQh6q tQbyhSeICRQ99Bq0SplYXR0QH6rK7YY8P0XsRNiosLSh9aT5GEEPjOe5+pmy0NfV+Nta 4/erWueBi2ErPpyFR2+IIAhjWHTW0h7KFTj+jr1JEbxJvB9EQ1vaBQnUisrfGFOCOwQA E6vknj7H6+2c+d43XTY0g7ko6x0nvTuXYrWOfXZq7VHKoxLXGVEXZEjZdxXNDf1hZT7N VvPXx6kSVvLJn2oQjyHwevYaf/5x5tEJipO5NcrG/yAiudmO1UhJGdyhyKzRuBac8WpF g/XA== X-Gm-Message-State: AOJu0YwXZ2etg083/Q1N1rYn1I8c0XiwjjznUE8hTPi3OMsd+pkUCes0 NGs7ELVQtL7OuAvjMAvuJJeh5ZQGWxuvE6oFyNnKWxF63KocpGOM6wiTjSk/RHi9LccwY8tTBDt D/O45VphMXCBy6Hz0kYw6kQzOrwkR8fQb1jcy/Am6O4eKTkj143D9ZKA7XPhiDoxKtA== X-Gm-Gg: AfdE7cnGcTB6+YfL9xhx8mSpgVB2Q6YqlNW4HKO3H9tWydVJlB3KflwiQkAoENwGlZd Ul4PwJYcTojaC4uIHBBBU97tZiywJxYtD9aVIsKW5dQZqNRvVY/qBuif/C4xIWoU2ZPqwhixKgT elnOk5X9wPN0HIDfu1K6HbN3ENg77N/usMQ3nTXlF0IrEn/bW9tKbFqwLfFutxoF5HqtxHn/yU3 R52pIImHbk3dPq9XioYzzYu+ngGyojRJiMvzYWV09eVWFL04khFn3hdeS6Kw8t7UAVRRdSeToT9 koWCPF6XE0AvTadfL6d/fhG1lK74dOeDhET9DxPZrAQPLtM2OzZaZO60Ul9ZJLO/i52BJiNoMZH +xRCET41sCHsNGl50dtLGo0zXwkFval084GD5AqVerpYMyidm X-Received: by 2002:a17:90b:250f:b0:38e:4b60:e01 with SMTP id 98e67ed59e1d1-38e4b602953mr2849022a91.12.1784315751944; Fri, 17 Jul 2026 12:15:51 -0700 (PDT) X-Received: by 2002:a17:90b:250f:b0:38e:4b60:e01 with SMTP id 98e67ed59e1d1-38e4b602953mr2848995a91.12.1784315751519; Fri, 17 Jul 2026 12:15:51 -0700 (PDT) From: Brian Cain To: qemu-devel@nongnu.org Cc: brian.cain@oss.qualcomm.com, stefanha@redhat.com, Matheus Tavares Bernardino , Pierrick Bouvier , =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [PULL 01/12] tests/docker: hexagon fix podman untar, 22.1.8 Date: Fri, 17 Jul 2026 12:15:36 -0700 Message-Id: <20260717191547.920048-2-brian.cain@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260717191547.920048-1-brian.cain@oss.qualcomm.com> References: <20260717191547.920048-1-brian.cain@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE3MDE5NyBTYWx0ZWRfX17CMBKq+WG87 c8AQV2DzS6+v/1hedCpr0x7/otvIxCUtQQkckQdTNlFDrB1gbLmElBCYo2QqrEy3xa8KVQUShf9 ddbjExTLa68SR7gCs+Iwx8gUJ3JlASU= X-Proofpoint-ORIG-GUID: -q2oOUTAYuglOiqfsNLnm38Dgx_BMEgF X-Proofpoint-GUID: -q2oOUTAYuglOiqfsNLnm38Dgx_BMEgF X-Authority-Analysis: v=2.4 cv=TaumcxQh c=1 sm=1 tr=0 ts=6a5a7f6a cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=qC_FGOx9AAAA:8 a=Twlkf-z8AAAA:8 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=KiFxOH7L81jTK52PPKYA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 a=fsdK_YakeE02zTmptMdW:22 a=-74SuR6ZdpOK_LpdRCUo:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE3MDE5NyBTYWx0ZWRfX24cs2y7qQ+gI lg1mG+Wc8Jgj1TDyMCV6Idx9j0TRNq+GZ3HzuvAwL+rJRK3Kfi586b/zXcqu2KFLrdZpRHKvEk0 B+JspF6Y74V5t80w7yjKVpq3l/V/0vuXnYMV0JDHAji9HQCnJY6du1ZczgSui4EstOPM6Ou7CKi EMiWh9K8OZQo6rKMQpR1keArQAgNdlptdlHIEJUc75CP6O/EKSfA/q+Kjpxn/1EyDtkRJnDJbqF zCw1w6rRz4c/haLM16OOTkz/ZbvPKl5boCxdU9eHhM5FtYfw/NKEvvBdS2iryLYjJGCoA5ktBuM Jjk/DBj/3vRPkOrbmn6gcH9utQV0r276BW3NoOT4Gqb7vBejAu+NsKULd9sySINW3Zu0O3U+aGE mLIZWFu6PAKAz/6PtSYwpi70cZV54DLvuDt+7IUN7A3cBD9rra612ltlfpdGJYbnS0iwcU+mNWe 6e5dIzHpjqcnal/bGNw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-17_05,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 clxscore=1015 adultscore=0 phishscore=0 spamscore=0 bulkscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607170197 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=brian.cain@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1784315791437158500 The debian-hexagon-cross image previously unpacked the codelinaro clang+llvm hexagon toolchain by piping a .tar.zst archive straight into "tar --zstd -xC". GNU tar restores the archive's stored file modes on extraction, including lchmod() on symlinks. Under rootless podman, where the build runs in a user namespace on overlay storage, those chmod()/lchmod() calls are rejected with EPERM: tar: .../libclang_rt.builtins.a: Cannot change mode to rwxrwxrwx: \ Operation not permitted tar: .../x86_64-linux-gnu: Cannot change mode to rwxr-xr-x: \ Operation not permitted tar: Exiting with failure status due to previous errors tar then exits non-zero and aborts the build, so debian-hexagon-cross only builds reliably under docker, not rootless podman. So instead we can switch to a different packaging. clang, lld come from LLVM Debian builds from apt.llvm.org, instead of custom ones for hexagon. And only the hexagon linux sysroot is required, avoiding the tar issues. Reviewed-by: Matheus Tavares Bernardino Reviewed-by: Pierrick Bouvier Signed-off-by: Brian Cain --- .../dockerfiles/debian-hexagon-cross.docker | 27 ++++++++++++------- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/tests/docker/dockerfiles/debian-hexagon-cross.docker b/tests/d= ocker/dockerfiles/debian-hexagon-cross.docker index 23e8bb2fb26..e07a2be37e2 100644 --- a/tests/docker/dockerfiles/debian-hexagon-cross.docker +++ b/tests/docker/dockerfiles/debian-hexagon-cross.docker @@ -17,13 +17,13 @@ RUN apt-get update && \ # Install common build utilities apt-get install -y --no-install-recommends \ curl \ + wget \ + gnupg \ + lsb-release \ ccache \ xz-utils \ zstd \ ca-certificates \ - libc++1 \ - libc++abi1 \ - libunwind-19 \ bison \ flex \ git \ @@ -43,15 +43,22 @@ RUN apt-get update && \ ln -s /usr/bin/ccache /usr/libexec/ccache-wrappers/gcc && \ dpkg-query --showformat '${Package}_${Version}_${Architecture}\n' --sh= ow > /packages.txt =20 -ENV TOOLCHAIN_INSTALL=3D/opt -ENV TOOLCHAIN_RELEASE=3D22.1.0 -ENV TOOLCHAIN_BASENAME=3Dclang+llvm-${TOOLCHAIN_RELEASE}-cross-hexagon-unk= nown-linux-musl -ENV TOOLCHAIN_URL=3Dhttps://artifacts.codelinaro.org/artifactory/codelinar= o-toolchain-for-hexagon/${TOOLCHAIN_RELEASE}_/${TOOLCHAIN_BASENAME}.tar.zst +ENV LLVM_VERSION=3D22 +ENV TOOLCHAIN_RELEASE=3D22.1.8 +ENV TOOLCHAIN_URL=3Dhttps://artifacts.codelinaro.org/artifactory/codelinar= o-toolchain-for-hexagon/${TOOLCHAIN_RELEASE}________/hexagon-debs-${TOOLCHA= IN_RELEASE}________.tar.gz ENV CCACHE_WRAPPERSDIR=3D/usr/libexec/ccache-wrappers - -RUN curl -#SL "$TOOLCHAIN_URL" | tar --zstd -xC "$TOOLCHAIN_INSTALL" -ENV PATH=3D$PATH:${TOOLCHAIN_INSTALL}/${TOOLCHAIN_BASENAME}/x86_64-linux-g= nu/bin ENV MAKE=3D/usr/bin/make + +RUN curl -#SL https://apt.llvm.org/llvm.sh -o /tmp/llvm.sh && \ + chmod +x /tmp/llvm.sh && \ + DEBIAN_FRONTEND=3Dnoninteractive eatmydata /tmp/llvm.sh ${LLVM_VERSION= } && \ + rm -f /tmp/llvm.sh && \ + mkdir -p /tmp/hexagon-debs && \ + curl -#SL "$TOOLCHAIN_URL" | tar -xzC /tmp/hexagon-debs && \ + DEBIAN_FRONTEND=3Dnoninteractive eatmydata \ + apt-get install -y /tmp/hexagon-debs/*.deb && \ + rm -rf /tmp/hexagon-debs + # As a final step configure the user (if env is defined) ARG USER ARG UID --=20 2.34.1 From nobody Sat Jul 25 13:40:27 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1784315820; cv=none; d=zohomail.com; s=zohoarc; b=jybH3VOAyFaMKMJLLKrQ3bZL3J4OLlx3MLgKrkVcBT+NJlwTVjOdUhhUzbUTVFIL5nphw0TpJAQJqo8OY1EuzgpAjPvrAzWRUmTBYRPoy7MW6vxpfCPRvT+5KL67zqDWCtkO00DA7Vz0hgsw2QKMLAPDVgzcSe7IPkIy7Rscmpg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784315820; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=XRvglzUbyC2Ww8q58tleaeYbLAgDEV8B5n9HheKhV5o=; b=EDwBHxQ1NJpD33Wzt7woR3orvyNWsDC8amhIiRgbHsc82eSC2rhY3vJdGLRjvzIMSCAqN+WVmGAKnPmJ/feC2R/UC9JD4PKtNVzCRcVWVXzvPmDFMiBosSkOHHXuMajjLc4CtDLcl41Qm2QyYc1bMdThnxAWVYQ1TkRXcEUk1ak= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784315820900296.88046537832076; Fri, 17 Jul 2026 12:17:00 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wko2S-0006m9-1N; Fri, 17 Jul 2026 15:16:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wko2Q-0006ld-9n for qemu-devel@nongnu.org; Fri, 17 Jul 2026 15:15:58 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wko2O-00083s-SE for qemu-devel@nongnu.org; Fri, 17 Jul 2026 15:15:58 -0400 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66HGoCqM2478193 for ; Fri, 17 Jul 2026 19:15:56 GMT Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ffhpfjb14-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Jul 2026 19:15:55 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-38de842a1a9so7735209a91.3 for ; Fri, 17 Jul 2026 12:15:55 -0700 (PDT) Received: from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31429f9d444sm11602463eec.6.2026.07.17.12.15.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 12:15:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XRvglzUbyC2Ww8q58tleaeYbLAgDEV8B5n9HheKhV5o=; b=GpUrGVwn1V9gKFJq RyIw1QviR0UflTYGDwDd7w3Xz/GllTSAjCfLx+uQ23HGuAMEa9LgF/vrBytyHFAX qS6tdKVomUsbOEl5CEKwjOCagDDt5qzvRulVo8qlpUcf84ijuLrL/lWfKqtLJh7m Q00rsJ4QFQymRBNzXaOQQ3t71XQgHPA7LJv2IAg+8RSTFAJssJRfPB28d0WgeSIa czx58ZmKqgl6vsqQPcU6rPcqAu/M0PeUb42EIBTOdsTIWYlCRLypVdux03p302Ma D+/xXPtZwGWN/XE9IinlXwwrS4RN+oCliH1jNr6XaoUnH4PeFM2BoU98XC62lzv2 ErzGtQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784315755; x=1784920555; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=XRvglzUbyC2Ww8q58tleaeYbLAgDEV8B5n9HheKhV5o=; b=jBgrZyBQ50l19FHcUQASw8dD4lo/ilrhk4T11CgG7x4dKyH8coZAATiVpugcnvCXXg D09QUead6Fyb2CrJI17PGQHHFOm/6DdBJAgfuGp3okGjO1DOOH7SI7isLqqmzjAMppiY gaO7nVv56rZoq+LU8UDGIiIzk9CwGk89hyx9CVpO7hkOiyXAa/WMkNaugmom+a/Ul/YT fFQov12LUKaU2IFuPW8wVdhj0DnrYIVAF/x8BCYxJGjEwQNXZVbkukXreuFnjpLzVcnF xo4lB8G+RjlOelyLQrJ3Op+1oAWbqwu6MjHLbVXovGE3Fff6biZlOses/ZCRp4Nb1e6D 5V4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784315755; x=1784920555; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=XRvglzUbyC2Ww8q58tleaeYbLAgDEV8B5n9HheKhV5o=; b=qJvL6FuvGJ44hbvEUIt1HwIMQF2DZflys4fNZCBMF5DUBN7OmKdcpJH/JPub/dVeWf MHoublNbMIOAc9l/ihBIAxUnXO445smpEjnAz1qrNJGKNDMyiRj+Pr9MqvSGXCX+yg11 IfCFsDm3CQ4vlAF7JUZm/5VtBSRj9c6ZFClcXyEg5bB4Pjia+nJG3UozYhYcAYh3PNXx 3RRB0i5lBLegMHo3/XXE+Z0rGUyBbdJilFLRXjRb2BImGh137KBCPzryUW7O7cXAzU6X D9grRcPaS4j1jparT5eZQEw6vU39mOVq+1UqFH69OqVgL/WmhU7//zWp+ams2sxLwWAU IluA== X-Gm-Message-State: AOJu0Yycz8FxHgG2RJxDveEKqEwjskxFSk7gUMzHOIt9fW/W08fQRC7C 47dhpQxiY43STPmOXqCjU1wHnXPnYFJDfoDAxp6oXA4yR+LL1dN6LIp4mWrcrp2lqZ4qqFuox1o aMi4wO6PmpbOR7qUtu67DaVRS242Rw9GqhduE3H+wiA4UQ+fwZZgS/lKyV+gsiFZ4Yw== X-Gm-Gg: AfdE7ckktUSBPnYjESAXKbEqbK8csf1wz+diGgx563eIp+edFykdaM5ryy4Chl8hIrx v6vQieZvDGEZyBLdDSpP4ytoCxhipH1UdIw0/jzQrQAFufPPIqlWT066/+Ezmy6oL6woU3qYSCG zbaypJCVrFicYH2fB8Iniqjii51+I1Pzg33k/J7dreT3jsmwFZxIBPFVWNTMjy7lQAUFi/I+m1o 09QgLJB953V9arKsCm6c7vE2DB8yaooCcV7oXFs2qH119mNS/CNI+gMwdel+c+G+O+aIulerhs1 NPK99dabO/ZfPyRWyvkaz1kzZn0Gr+GR9TW2sVHR6haN7tOnCQDUNPxlVVgpnSOXKD67QIkiOCU JqpbyN+ibL98765l4R4Zyb8Mjy4m50T4zWStUV9qA/aXigLGK X-Received: by 2002:a17:90b:4b90:b0:38d:ee84:b1ff with SMTP id 98e67ed59e1d1-38e4b5aad77mr3790892a91.40.1784315754782; Fri, 17 Jul 2026 12:15:54 -0700 (PDT) X-Received: by 2002:a17:90b:4b90:b0:38d:ee84:b1ff with SMTP id 98e67ed59e1d1-38e4b5aad77mr3790835a91.40.1784315754275; Fri, 17 Jul 2026 12:15:54 -0700 (PDT) From: Brian Cain To: qemu-devel@nongnu.org Cc: brian.cain@oss.qualcomm.com, stefanha@redhat.com, Thomas Huth , Pierrick Bouvier , =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [PULL 02/12] gitlab-ci: build hexagon-softmmu to enable functional test Date: Fri, 17 Jul 2026 12:15:37 -0700 Message-Id: <20260717191547.920048-3-brian.cain@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260717191547.920048-1-brian.cain@oss.qualcomm.com> References: <20260717191547.920048-1-brian.cain@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE3MDE5NyBTYWx0ZWRfX0IBLUxj9aWfB nV//afCBUk+V02lhL6/iEY70CKRQU+Tv0rW3ve4k9zsMLZAfDc4/kG+/pb9KE6Em00VOhOq+jHg pd7FKupRQvyNK53kgUm9bvhBe8yLdX4H3z0mXixjLah33tvYnREMlDB73Bjzv1oXx87IsOHVGWr M/Z6R+tHm+LPOoRKg6dveLdKkwz5F/M7KbKM4uvJR28s1EMNb4CIOGG748RygKzWPDVZnhOYJNY Ok6weFnHVd0mu17qzC6EUK0bGmb3XHQsXJGryS3w8LX85etDER7jGMNRRTStrVhoBOj2GyAWlnc 4dtCJLx61sp98PdwepAQB6xw/e/dq0hVJQc0G+fLYeg7mOuBkdEHuIHFSNrWdFYkT0605OTcb3O RWAO206Ajaq17/SRoVjAtGJmom4uesyoDq9fjsrtDPiZOUfzUcn8Xtkt3Nwg3b1momsrPQ+fVC+ bvgif4JNWPadAN8JBMA== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE3MDE5NyBTYWx0ZWRfXx/3vgQ0tVBRt Xdba6g4lzE2HJpt4yu/xV83FiHHNV2OxdyuwFxx7OG9NgpdD+r3+zOefDULPnMNHuaZpQBgZtLT LcPf6PrYiOKAm4a4Oxmadt83KuRI4F4= X-Authority-Analysis: v=2.4 cv=YeWNIQRf c=1 sm=1 tr=0 ts=6a5a7f6b cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=20KFwNOVAAAA:8 a=EUspDBNiAAAA:8 a=AQ9b_f4qHiFF19MPkWIA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-GUID: dWUBvbo7kl_tcUUs598U3gNRH6gZSpi9 X-Proofpoint-ORIG-GUID: dWUBvbo7kl_tcUUs598U3gNRH6gZSpi9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-17_05,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 suspectscore=0 priorityscore=1501 clxscore=1015 spamscore=0 lowpriorityscore=0 adultscore=0 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607170197 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=brian.cain@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1784315822968158500 Add hexagon-softmmu to build-system-debian's target list so that the existing functional-system-debian job picks up hexagon functional test. Reviewed-by: Thomas Huth Reviewed-by: Pierrick Bouvier Signed-off-by: Brian Cain --- .gitlab-ci.d/buildtest.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index e2553e7326f..831d9a26742 100644 --- a/.gitlab-ci.d/buildtest.yml +++ b/.gitlab-ci.d/buildtest.yml @@ -70,8 +70,8 @@ build-system-debian: variables: IMAGE: debian CONFIGURE_ARGS: --with-coroutine=3Dsigaltstack --enable-rust - TARGETS: arm-softmmu i386-softmmu riscv64-softmmu sh4eb-softmmu - sparc-softmmu xtensa-softmmu + TARGETS: arm-softmmu hexagon-softmmu i386-softmmu riscv64-softmmu + sh4eb-softmmu sparc-softmmu xtensa-softmmu MAKE_CHECK_ARGS: check-build =20 check-system-debian: --=20 2.34.1 From nobody Sat Jul 25 13:40:27 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1784315789; cv=none; d=zohomail.com; s=zohoarc; b=WkterIx+kmr1GBvrLC+JhbwrkMj6Myovlw6Perafy4UI5rDxi6960NVFI69rBi/8iYD0veqiD1v9JF8+AFdA51BQ8nwVH1C1qEMzF0SLMslTNryDgnp+8XDYWPpdEXG8mHxdAj+HVJFBO4x6g/zVS6pxbNxGEpPd+6AhywIP8Jg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784315789; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=KDJzGtVRreS6z/6TMGz95VQOL0sQrxpRLTHH3sel420=; b=kVlyiuWzzPUMqYTITcpPuh72HbkNmUOSYGIMx4BgoPatd2iaWtgCwG28ckn17gi4sO4Fa3EUW+QaIsrMtvVwDIksdv2HdtsLq41Psg4VirxC7yyha7zu7DDBB3FIHOlXVntAWuqMxjauHCMpgtEAU8oCg7uAxGPqNkjm7RepO8c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784315789241961.4181122735325; Fri, 17 Jul 2026 12:16:29 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wko2U-0006mi-Ey; Fri, 17 Jul 2026 15:16:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wko2S-0006mS-GC for qemu-devel@nongnu.org; Fri, 17 Jul 2026 15:16:00 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wko2Q-000849-Vd for qemu-devel@nongnu.org; Fri, 17 Jul 2026 15:16:00 -0400 Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66HGo99f2245287 for ; Fri, 17 Jul 2026 19:15:58 GMT Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fff9pay3q-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Jul 2026 19:15:57 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-381250979d5so5494290a91.0 for ; Fri, 17 Jul 2026 12:15:57 -0700 (PDT) Received: from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31429f9d444sm11602463eec.6.2026.07.17.12.15.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 12:15:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= KDJzGtVRreS6z/6TMGz95VQOL0sQrxpRLTHH3sel420=; b=OxCvb/7JGjpYH3u/ Wl/SopaHdAHqDHWp47RNGcq4/2cS+dRcDNJT9yK0Pe1DbN0XD+joe6qrgFs1EjUI nq3OQon7SGTIc6XHvqaV5hw0RG9493xr3dPhc9BJXwZtiFqai+u7ks3ATEjqKPy0 Paw6wiWxLZkaFrCeSAGc8Te9HWjUWYKmAc5xk6rQuZhRqMXklGtPv/fAd0FGWhqN snJYL4FCNOqmNvo9JKjomKVBa1O5fs+jFLEDxoIDCjL1QCSKYoSCtFMNhKOwSeYt jjmHpR31omWgY/uWETNnwBU2SeLDorPjyl8/ZDfZZDsDwTW6UAsmCv1YcTUv02xv 0xT2yA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784315757; x=1784920557; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=KDJzGtVRreS6z/6TMGz95VQOL0sQrxpRLTHH3sel420=; b=gNEkkOIhQhf/Mvpg6if03IOHoYqyQqZiHSAI8iUP2PEUfOqMABKlbKPDyBV/+Dmb0A wPYFVVTZXg4J/yNmBwyuf+pPLp1WPuL9zQSDjaK+g0GvRpNqUpcOndgOg91Ajl8MVvFJ xDOjrzRERjD7mRjwuM9ZvgeU7DDwCHyprrwcAqIvA32dtJM2SalK0D9B+2EuP1/QwxSK f4xicCzqLvvxs34vQzOvaAVZwTGnO6cVXRlbJFbRZbs3z9HTq3xEcd/J1yKrF8UfWfqr VJLuSI5FISS1/RS+ZYTtoQ2hDXB7bXKQN/6UJqAN2Gadj1f4P1R/xY0iRZ2fl+HmQIYC v/8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784315757; x=1784920557; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=KDJzGtVRreS6z/6TMGz95VQOL0sQrxpRLTHH3sel420=; b=UktleH4yRCc/wkWadARye0pI6McyFt629ZsdV96Y8qTC5VyAvYhx7XsSF2ocVzmtW9 Sgu3X/d50ggiu49Vj9o9QZf8lBIdYOXiRJ0G88ekN7qCFzO7l9qi+zKZiVK80AxhcGHR S/5249BzYPaEjALMAmqNLGKzHOEaCtrXYb+CBEFbaSQBnMxA0c+zt+D9f3OpmmEb+wMV DhFWAuTdNG7xgyFwNTec94+9pCU6WJsCgK7sqMF2ABBxSjC/3pYexF+YbExqO9ducJ2D P+r32PNmWYXB9Ba0fdPE3EkIK10ro9dBMyyfLwFxnlCwzXz3qKi3r1lP/idlL+qk5g1E 8Jjw== X-Gm-Message-State: AOJu0YzXHDdBb5cVZe0ewzsQIzjVY+V6A3hEWPWWVNvkD2Gu9PnQzLj4 9SAU3Omc6yPZitWw5LKsi+7Wlygh5Rwda+oniZtUTLZ3/Ga8VL6QSZquVaVaklW1mlQ0enz72YE Uj49Yhfd2/UNznO5BvcBJjUeAWmFmoMxAjrdG8iCPeRe0SJkNoPmJzeINfrH3fksiOw== X-Gm-Gg: AfdE7ckhxtVsE/nK6zRfscmaKKHmO4/QS+MzmjF+liGiSVee/iu5/udARzDgcmziiGl tA0W4B44idzjm4Qbku9b5WN5kNK/sMhMLiHh9gTJ8L5trfj0baRKG4YMB2ki8ZZfFkIsUG3msgg AHfyZ+27YrUamDFaTeguohEbMu3voKo+OVk4xxUcxlLJZpHCqyTdQatRoLrholgEBywJ39biD3z XjJh6M00ZcntTYjVjp60c2kriCfA/H15Mw1XZm18+kcry+tnv5xB5Cim1rgYbpSSxOf1nrccwdf 7AVaYikLpraF/TMzvDFRwCG26o/I/fIsQPoZnUQmdz7bME5lKj9oYmjJCke2Jp9yB3ptGExlva9 ufCtmq/AclXBC2KVB/8BoX9OiM48OWOjb8VTkk6NcmYjDi5vs X-Received: by 2002:a17:90b:2f0f:b0:387:e0db:bc31 with SMTP id 98e67ed59e1d1-38e4b56ed5fmr3914797a91.39.1784315756972; Fri, 17 Jul 2026 12:15:56 -0700 (PDT) X-Received: by 2002:a17:90b:2f0f:b0:387:e0db:bc31 with SMTP id 98e67ed59e1d1-38e4b56ed5fmr3914734a91.39.1784315756211; Fri, 17 Jul 2026 12:15:56 -0700 (PDT) From: Brian Cain To: qemu-devel@nongnu.org Cc: brian.cain@oss.qualcomm.com, stefanha@redhat.com, Pierrick Bouvier Subject: [PULL 03/12] target/hexagon: fix -Wshadow=local build error on GCC 14 Date: Fri, 17 Jul 2026 12:15:38 -0700 Message-Id: <20260717191547.920048-4-brian.cain@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260717191547.920048-1-brian.cain@oss.qualcomm.com> References: <20260717191547.920048-1-brian.cain@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: K9x_mouJK22wW7HrlHdqZ-MIjNVUW-4u X-Proofpoint-ORIG-GUID: K9x_mouJK22wW7HrlHdqZ-MIjNVUW-4u X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE3MDE5NyBTYWx0ZWRfX2/vbuRcGSoQO LE2r6zdPaxA0bnlExbursM/JMjIfDnBWJeuJOB3k/ZKMR6cPyd8AKumrxo9klgTIWHIpo4HieXI CmOoH9MX7YZvq6+lXfCBOcwp7yLeoPuWF7U5ABmfATrpL3JrV/mk3JvU7kEtj0Nd4tA9wBCPqjn i3ZKdn5K1AUNYoTpu9SRtfgsK52HZOnz5u0MdE7dSGmNcNDW6Sh6adlet9lKO+Yg8QXQSPETbc2 bFk274YGEiC6NB5jEBnnNTvNgkpiQSWZo2vdNCzrwzS1tacAfxpFlxXN1TRQMe15G6oQmwnZou+ rLJaHnU2aCJfDOwclfAxN/Wnu48wez+gssltOqhFh9HFHtB/1HqdiP2sW8zcyi0Dop61CYJd8jk waEbbcAIqbDbtUisTi08nNhHlcEGsUdtOBFrQmXaAG/MJnqFr1l1SB6YOjG5potgZ+khV/O3PTz EwamfElh5p1Wri8EXHw== X-Authority-Analysis: v=2.4 cv=TaqmcxQh c=1 sm=1 tr=0 ts=6a5a7f6d cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=BJvf2dmcNa1hIKecAfkA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE3MDE5NyBTYWx0ZWRfX8xWWD8xAlzcm mef+LSanyd/8m8vaTOydBVfJtNwi3gMiMtL3bjxqCts5VGromJwCELNf0CHUHzPJ09xkiW5t3KZ twmQf49ygDcdoVYZLgmXJTMISEx1t5E= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-17_05,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 adultscore=0 spamscore=0 bulkscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607170197 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=brian.cain@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1784315791402158500 With --disable-hexagon-idef-parser, tcg_funcs_generated.c.inc fails to build under GCC 14 with: error: declaration of 'HALF' shadows a previous local [-Werror=3Dshadow=3Dlocal] This became a hard error with GCC ced651b7757e `c23: tag compatibility rules for enums`. After that GCC change, DECL_FILE_SCOPE_P is false for all enumerators, so shadowing now falls under -Wshadow=3Dlocal. Rename the local variable to tmp_half to avoid the collision. Reviewed-by: Pierrick Bouvier Signed-off-by: Brian Cain --- target/hexagon/gen_tcg.h | 4 ++-- target/hexagon/macros.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/target/hexagon/gen_tcg.h b/target/hexagon/gen_tcg.h index a28af0c245b..40e03781d36 100644 --- a/target/hexagon/gen_tcg.h +++ b/target/hexagon/gen_tcg.h @@ -414,7 +414,7 @@ =20 #define fGEN_TCG_STORE(SHORTCODE) \ do { \ - TCGv HALF G_GNUC_UNUSED =3D tcg_temp_new(); \ + TCGv tmp_half G_GNUC_UNUSED =3D tcg_temp_new(); \ TCGv BYTE G_GNUC_UNUSED =3D tcg_temp_new(); \ SHORTCODE; \ } while (0) @@ -422,7 +422,7 @@ #define fGEN_TCG_STORE_pcr(SHIFT, STORE) \ do { \ TCGv ireg =3D tcg_temp_new(); \ - TCGv HALF G_GNUC_UNUSED =3D tcg_temp_new(); \ + TCGv tmp_half G_GNUC_UNUSED =3D tcg_temp_new(); \ TCGv BYTE G_GNUC_UNUSED =3D tcg_temp_new(); \ tcg_gen_mov_tl(EA, RxV); \ gen_read_ireg(ireg, MuV, SHIFT); \ diff --git a/target/hexagon/macros.h b/target/hexagon/macros.h index 21ab8ae5bbf..8a32d5f79c2 100644 --- a/target/hexagon/macros.h +++ b/target/hexagon/macros.h @@ -576,8 +576,8 @@ static inline TCGv gen_read_ireg(TCGv result, TCGv val,= int shift) } while (0) =20 #ifdef QEMU_GENERATE -#define fGETHALF(N, SRC) gen_get_half(HALF, N, SRC, true) -#define fGETUHALF(N, SRC) gen_get_half(HALF, N, SRC, false) +#define fGETHALF(N, SRC) gen_get_half(tmp_half, N, SRC, true) +#define fGETUHALF(N, SRC) gen_get_half(tmp_half, N, SRC, false) #else #define fGETHALF(N, SRC) ((int16_t)((SRC >> ((N) * 16)) & 0xffff)) #define fGETUHALF(N, SRC) ((uint16_t)((SRC >> ((N) * 16)) & 0xffff)) --=20 2.34.1 From nobody Sat Jul 25 13:40:27 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1784315789; cv=none; d=zohomail.com; s=zohoarc; b=i6Y6S12H9t8sPDcJ5rVFg9tvXizAIgMKeO2zwKiACWjZwUnVGZeMZ9CgxiE6DjARao5lTuUZjHQ4WhuSVjiJUDwEue854cBzkfwzQ/y0FObCkGAwnQoVrVydm9f8iTf8YZUNMRhdmeTuRCXv0aR6Ff+mKoWu4jh1+1MRW+5qSS4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784315789; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=MEYet0uqamc/vXc7Rua4NfRuCOnL9XaSxQ5CjDJicls=; b=kXs6fvbLc6QlDgN5ze8AhKZdCehL4oBbXH5h7BK1ZM8DPJiZkOoYtPsWHSURqHOHoLvDG77m7tBZ2bUgk9ersAswqPACQCLWqlLUXw9JdKaysKeCXPJpSjw8xadRZRkFyUiEkNVcTA2OxYJcbLDHDxhMv7CcCBSb7Xs+0IEW5+A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784315789040745.466462752276; Fri, 17 Jul 2026 12:16:29 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wko2V-0006nD-JE; Fri, 17 Jul 2026 15:16:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wko2T-0006ma-Rs for qemu-devel@nongnu.org; Fri, 17 Jul 2026 15:16:01 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wko2S-00084K-GR for qemu-devel@nongnu.org; Fri, 17 Jul 2026 15:16:01 -0400 Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66HGoD2I2372320 for ; Fri, 17 Jul 2026 19:15:59 GMT Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fff9gu017-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Jul 2026 19:15:59 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-380b630c505so10016428a91.1 for ; Fri, 17 Jul 2026 12:15:59 -0700 (PDT) Received: from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31429f9d444sm11602463eec.6.2026.07.17.12.15.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 12:15:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MEYet0uqamc/vXc7Rua4NfRuCOnL9XaSxQ5CjDJicls=; b=WUHZt2D8V8V57G27 QKO+FhWUALSMuMcchWNqn0aUIBmuoYP3ZZVJLKYSHdkD91+GG3y5gHlyT2gSGyn6 1bAXdXqnjmED+rszzjgoDcxENPE9l3OfpUlzVaHfZdbCshFry/IyEkgk3Jxt73Gl TAgxHCvhuJyOBJMHVIsXrT+OLDNUQ8F7GZqhf0TO5k70Za59kghX9hjhXWyo9AEV IzuJHSvynnKZMClpMsNwV7w8OZQqxi5j04WAq4I1gsD01isUxe3ihdR/3gt2YiEQ r8RrU9ZcOYjeCGni/wd75wJSQlX+liGgAA/gL3r3W+UNrfnQo/w6QhJvvdeS9wQG ajTOYg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784315758; x=1784920558; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=MEYet0uqamc/vXc7Rua4NfRuCOnL9XaSxQ5CjDJicls=; b=VKoUEQoVdPib8/XLte3PvE3PcOeXAoHIaSiF/xTx+MvjnoiG7BNW32wK5z/8J6Oq31 942CkSFnB2tUpb1Rl3f2SZkMGi3iqZQ39O2VfIkS/DVoTHK/0A5KVhYY/ZB3oHOOW6BE gljNviBkK/fLVA25nUCxS3mCa6+Mt9ph/6cKr/FCAgXjA2vZ22F6vquQF+dDQ1JTHcw/ WecghjAyGvoo+p1rQ9rVOMPU0QbR11iwSyRiRf1EJFWKYaEfd6e66ZsKKGATz9hSr7xa W3ZS9GIaZfvuWz3Nk3D2KfepVovaH7jB3KsjfmQNnmyXJIkgcZXa1nNb9rpE+WAu9KF3 29KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784315758; x=1784920558; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MEYet0uqamc/vXc7Rua4NfRuCOnL9XaSxQ5CjDJicls=; b=tAU1MlV5NWfhzOGQ64vjuWYDyLQBEovDgTvjgmgaJKyDJ2wTmCWBcPSWmzqgcQWZ8m eB4Q9YsOYFqaKiLh8LIYlsMUYvy28OQi80N0cWpx0NKN9PxTAFS7l7XbWxI4+rsIXfr1 pMuszMsVmmi7PBBJHGBKuvW+nrkMa/NsRze7Ei5UYIJhuMdB95rUYbwikJJ+EK0eR/+J oJ+kc9UFF9ltUevVV7eOGbq28112ww3oN0gniEp1ZIkxImUppSX7A8M44Ilh3VgmIyHO Lm1L5YqrhCHD+Q2fjHVzt/gEhkIZb8FtLMsz51mquHrIIYq1/GMUUxWg7qUIA/ywS50R FejQ== X-Gm-Message-State: AOJu0YzIDJRx0QQP0TJP14hSNcRgeMQyTGKuXhwZwb4d7KxZmcwrI1IK pqYFAkejScKj3PJZy2s2l3AUKBAwO2BrT2DCH7DQvaCeRf+Xw/UjCxMjlJWV+rxOYVPscwcfONN o0dT2UvrpAtyMP8Vn2o8q96ozwE/b6TkQAd6D6SHjRHrUjLFxFALvnOsAw/iRRto2Tg== X-Gm-Gg: AfdE7cmk9DBM2pjz+6F8HpOZyyFU2xjquIHD6pv44zfOR4H+/vmpI7RqicN0Nk2ina6 LlcPrd2z5gWZD6aIVYqXzKEoUIAFb3q9V55sUYzfxsaQsg6HUDNE9hKt3c/T5PRnt1jrsV67gtZ /etfiUMXJj31BZ7caVXGMupwO+GY9MyPdaQ+YINrILok4Y4BdgQfk7sXoOhWinkfj6EwVRM6AoN FyNCM50VMI9/v5NGjL6tXwRanzFqYDGc7H9H7OSMU+L4cgMG1njDkP7JSBNtpJpHZbvMRJkQ6rT 439/mHo3yj2TX6wgjlMG/nluc7ez0PmuxY2zKl1i7aCIytp1KjY36iqcLDd5pfS8eVwgYsX8fc8 K2fM8t3itcqZ9ubyVk8LM3WFIrghgt3aCteV2To5UkQmw5rjp X-Received: by 2002:a17:90b:1c81:b0:387:e0bb:57f1 with SMTP id 98e67ed59e1d1-38e4b56bd45mr4162133a91.34.1784315758427; Fri, 17 Jul 2026 12:15:58 -0700 (PDT) X-Received: by 2002:a17:90b:1c81:b0:387:e0bb:57f1 with SMTP id 98e67ed59e1d1-38e4b56bd45mr4162089a91.34.1784315757920; Fri, 17 Jul 2026 12:15:57 -0700 (PDT) From: Brian Cain To: qemu-devel@nongnu.org Cc: brian.cain@oss.qualcomm.com, stefanha@redhat.com, Pierrick Bouvier , Matheus Tavares Bernardino , Laurent Vivier , Helge Deller Subject: [PULL 04/12] target/hexagon: handle misaligned load/store cause codes in cpu_loop Date: Fri, 17 Jul 2026 12:15:39 -0700 Message-Id: <20260717191547.920048-5-brian.cain@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260717191547.920048-1-brian.cain@oss.qualcomm.com> References: <20260717191547.920048-1-brian.cain@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE3MDE5NyBTYWx0ZWRfX/7hqtZWxYLBO 8PIo91vGnQWZh7AKmDgJOcFppZ+T9T5x/ZJbSAeeAHDyNZaspXCuaAMVH6D5iEdIFWtM1SDNE2B GEFoTRyr2SsBy/H3absst9BdaMEXj6w= X-Proofpoint-ORIG-GUID: YTZd5UyXI2wgiNqsw0cH9oPyzKkZZ70F X-Proofpoint-GUID: YTZd5UyXI2wgiNqsw0cH9oPyzKkZZ70F X-Authority-Analysis: v=2.4 cv=TaumcxQh c=1 sm=1 tr=0 ts=6a5a7f6f cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=tYl-21R0sE5cWuHd9JgA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE3MDE5NyBTYWx0ZWRfX3uPiBIfrARno o3uxS0rErIA4AjWyPAcCowaw9Kf3ZRTx+cXMuUzSsQTEg7GarCI+NJWpXxhRupchNqAgqI24RLp lJAcf9WRQxNKxvhoNNBb/sHQ9GRKzTMwzK53F9dLkaMHf0rrO4pXwdv5REuyM4uT8pQ57e7Il/t 5uXNL3qFBF55awd+FAnLWZLIls7QTnVVanccKkDADHZUIvFaH4GVslVIM9weqlsVZ2u69WyNT/x M6t0ZoM9HEpKcGxvCuM2JYoBvIvTQ0f7f6i2SkQMVi1QyDPDZAMitcNu+Q0iYZXqTKJW/10/1+u Bf0yOmBh3+YAqyhdl2EzOey2RAOnXR+RrzQ1O9plE7DIgiZwbrveEyVUB+5OOB08DnmPzmZhmeI HfXDsP2SnVE55//yGvkHHCv2WXrkv6Zbsy2i+Jwj/UgFEpQsOYSM4e0lDKZEEM3mLWXKdO5Kdxr 1OsQdpUctRerFK0bV3Q== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-17_05,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 clxscore=1015 adultscore=0 phishscore=0 spamscore=0 bulkscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607170197 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=brian.cain@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1784315791415158500 Add a linux-user cpu_loop handler for HEX_CAUSE_MISALIGNED_LOAD and HEX_CAUSE_MISALIGNED_STORE, raising SIGBUS for consistency with hexswi.c's sysemu handling, even though linux-user's own alignment check in accel/tcg/user-exec.c currently raises SIGBUS before Hexagon's cause-code machinery is reached. Reviewed-by: Pierrick Bouvier Reviewed-by: Matheus Tavares Bernardino Signed-off-by: Brian Cain --- linux-user/hexagon/cpu_loop.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/linux-user/hexagon/cpu_loop.c b/linux-user/hexagon/cpu_loop.c index 0958c51fbb3..d7f73439dbc 100644 --- a/linux-user/hexagon/cpu_loop.c +++ b/linux-user/hexagon/cpu_loop.c @@ -76,6 +76,11 @@ void cpu_loop(CPUHexagonState *env) force_sig_fault(TARGET_SIGILL, TARGET_ILL_ILLOPC, env->gpr[HEX_REG_PC]); break; + case HEX_CAUSE_MISALIGNED_LOAD: + case HEX_CAUSE_MISALIGNED_STORE: + force_sig_fault(TARGET_SIGBUS, TARGET_BUS_ADRALN, + env->gpr[HEX_REG_PC]); + break; default: EXCP_DUMP(env, "\nqemu: unhandled CPU precise exception " "cause code 0x%x - aborting\n", --=20 2.34.1 From nobody Sat Jul 25 13:40:27 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1784315834; cv=none; d=zohomail.com; s=zohoarc; b=gLXEVapbdaGU5np1GflcHkVlfaxzw7kjbZSwdcPCQrzUA2KkjXwC7OH39S6OwIM2dCF+pEFdP84zbF+txYGBwi1BOPCVIfqliy3k2a01LEbIFlW2mZFhUM1v9p7N09DMNeuwrsn6no/d6Dd2mNi/uHDOOMTCyny7nS7tCN7JVf0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784315834; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=dtdOH53AMHLIX3SwaSQjU1e9K4NoiOgfgUpgSnC/+rs=; b=nu4SZ5JBuhyE8oGzhxnmogSimZ/u10WLJlOI0eHob7GlXIE5SELzU1qvXjSpRUo5oA/w7NhMevMHLhw4fy4GnP54xuNO/+rpO3NU2WkhsphO6KsDwMn6tiMbNOyYLZgip5nxs2Ws98cJFdblEmrPmUnJKiGH/SPbLnLBM1hMAWs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784315834608838.7491112052113; Fri, 17 Jul 2026 12:17:14 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wko2X-0006oD-Fq; Fri, 17 Jul 2026 15:16:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wko2W-0006nG-5u for qemu-devel@nongnu.org; Fri, 17 Jul 2026 15:16:04 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wko2U-00084V-J8 for qemu-devel@nongnu.org; Fri, 17 Jul 2026 15:16:03 -0400 Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66HGo4sV2372001 for ; Fri, 17 Jul 2026 19:16:01 GMT Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fff9gu01d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Jul 2026 19:16:01 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-38e54b6556aso589970a91.2 for ; Fri, 17 Jul 2026 12:16:01 -0700 (PDT) Received: from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31429f9d444sm11602463eec.6.2026.07.17.12.15.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 12:15:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= dtdOH53AMHLIX3SwaSQjU1e9K4NoiOgfgUpgSnC/+rs=; b=NM8QgQMcUpjwYzJK erFph/coKkDtTj/O7jIUA79gPKKYCOa2G2JSHxDJ7bCl66CtT+ITGu4RFqprNWTr /sV3nYHQGKKnRiHbJqkyFKJK0+pWumI+8HrzZMhq3WcUvfcMZteyTXbwndFK6HWB mleZDdGt2WEUQ/YV8FqZv1rQno4uGA+50CwXohP8zfidAvBTmsBoUEnlbET3AcEQ sPQS63Zp4+8uQ8zeQFF0oueg324RJfBihvWsXGKv7MuqRiMMiKm0aQhkeH61muI0 LCMfUUMvJ19cOdXz9Ds0rH/LnfJe17dTJaW5fQF08J5nneiG9Ky5PX7so8z6iqlY BI5zxA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784315760; x=1784920560; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=dtdOH53AMHLIX3SwaSQjU1e9K4NoiOgfgUpgSnC/+rs=; b=OIxww6lpjWYIaN2qNwCsOhbWVRYASdnDrDkr8Aywq2yFU3hWr2qh5UfvSiaVmx6lDL gOpysHcsFvIGN9Yw7GGH8U5ynwzq2W5PUG+Lw/Nn28tnCzzsTMivh4Rw3vJqtdrTuk1U a9kcVObSLPrCdxzUGQslPcW1rFbj08Al1UHnV7VS3nhvTPqzpTJ9Jju1aUU/MGFrrSc9 +CcGXo6zpy0JxE0pmD8tFCqjz2LhoU1gtmKQimNYBXJlwA3v1XHGlCXvlIKm0YRQEbwT C4HyPr+YTbCfLsfaJU/8mH2Os10RyiW2kYPFuS/CumCu7y+QlxFHAzBf6xLGOzTyYesp 1P2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784315760; x=1784920560; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=dtdOH53AMHLIX3SwaSQjU1e9K4NoiOgfgUpgSnC/+rs=; b=Dze/4wMi+Ok5sD9i8X8j170nyf0oXOtnDvEQhs8PVXe7k27dPUwVK1XBOfu0ZHBcoK yKNvl3I8lYiBv8gGW5oO8axb4PwR6jPQYuPhmKXFuwomce5trpCn/wEdOFtDLZFnb2Cw 0ADnhjwn1D41a/08CCnmbaeyVTXAWzjHsLuzldNNTTWdSSW1sbQjFC6Y8Lq3ZSGI3acT pZBKY081VfLDeOri20rve1wcwc5V5QceDY/yhCnYIR/9XrqMmSnSr7Vjdtzi15QB1ECa qLEJLElN5fyi67QXALrZs777am6sqjalHcOpJ/3FMtjftR2iFU79lWyWA9IDuqVa7kYu yaow== X-Gm-Message-State: AOJu0YxnMF1Mcat6EMty3QVbKOQTkWmqMEQkZYjK8o2NsjJFUFLKTNLK +sZDmT2ML3dYe5TfhSYxzZlppXBd475mf0M3BqxvBPKjOS2PyOl+mdS9Lwl9QODL9ysIBaVzr5o g2gSg9H5qrOhLPqoIOM1vd1Xsdej61F+IoVAq+83S5nYGWCG37u8SITEL0i2z0oCpOA== X-Gm-Gg: AfdE7clNr0XkKstSwd5AISgsGISDGMkkMTpvdEyGVCBi9hxuJHFeOgS3OhnH2tHhuhx nCZIM4Cru3Mgp37tMrDgiJgeeHZ2ox1LFqK//yIqz33TyNozVByIXrYIokuDSDaEtJeziWANj2V Zge86SzBp4dUq7b9MjWdTDNIYdmPZj3CBO5oZ4GHEbagjPAB6eTsUmlan07SjQMjvh2GIkh7+OE ZwueBlqZP9jexMq7xKhctwgUGv1KlJ4MCQgPbeJP6yUriIzZREp1H5YYiS/QOz/BG5jmDeZsULq rfbHVaf1QK2WRD5aQ74m6kop8PeXL4R1LjAxo+JQBUbpSczMnGqEh/A1kWHfLqSXsDot9gHnWL/ mFznsxiQ86Epdc1/rUmc0yhAgDTKm+boSaGAAy0Ft53Qg22u1 X-Received: by 2002:a17:90b:2642:b0:381:6466:7160 with SMTP id 98e67ed59e1d1-38e4b56d7b2mr4468640a91.26.1784315760183; Fri, 17 Jul 2026 12:16:00 -0700 (PDT) X-Received: by 2002:a17:90b:2642:b0:381:6466:7160 with SMTP id 98e67ed59e1d1-38e4b56d7b2mr4468577a91.26.1784315759453; Fri, 17 Jul 2026 12:15:59 -0700 (PDT) From: Brian Cain To: qemu-devel@nongnu.org Cc: brian.cain@oss.qualcomm.com, stefanha@redhat.com, Pierrick Bouvier , Matheus Tavares Bernardino , Alessandro Di Federico , Anton Johansson Subject: [PULL 05/12] target/hexagon: raise SIGBUS on unaligned scalar loads Date: Fri, 17 Jul 2026 12:15:40 -0700 Message-Id: <20260717191547.920048-6-brian.cain@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260717191547.920048-1-brian.cain@oss.qualcomm.com> References: <20260717191547.920048-1-brian.cain@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE3MDE5NyBTYWx0ZWRfX1YaW7qC4/obb fSAOVCBCT/lvG2JBnpHtZzVNDmBcatxm/QuprVkr4ajl1bvD6uusDluEp07ljtqXqsfWV7WSo4Y PJU3fyyyCNN4rkbrGamNKjA6ZOgn57s= X-Proofpoint-ORIG-GUID: NyGbvNuAIbLy0CWfgWKCTuKCvuHyedd_ X-Proofpoint-GUID: NyGbvNuAIbLy0CWfgWKCTuKCvuHyedd_ X-Authority-Analysis: v=2.4 cv=TaumcxQh c=1 sm=1 tr=0 ts=6a5a7f71 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=f50odatAX-H4vQHS3akA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE3MDE5NyBTYWx0ZWRfX0vU45JmIiDAI c8AbroA5C0cloJQzvrHaWu4SRFmMgjx7ls6AROahPweIadKlnHNj96SVXo/c0prl3eH7ciFUW2k ocf8RrhdYDDKmDNaQnG2XtqqneUxzw5lscfOdmdLEy8EQYzIwGZGYSgIw1ORnUdhfggnt6QUmAQ 5ua8ryRs0iQEgBJAwMEzRhV4KvLOgdjbGULw87deepp/8r4g10xd3u8bBt8OW9yA/h2O+hm0TU7 ywXM5/g8128Gbyfv2tLFf/tLdHq0aEJqfNlXeZ4nqwdAQ5UAka4GMy2mJwbBghLUHkFcHDW7LUP JTN/jldl45vBkSAwRe2s0xyeTJEAM/F5gz12H5nCuc12Gsq0bCUbl97g7flCETsxF600l5l41ky dakZdXVek3s0rogWew3GbU+ROTYK3C5WBdkNS10LF5PC4dFlHmBmYXZHYyZfK27SjDFgUpR9gbU VYpj8JDI6vmW1hZ7ClA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-17_05,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 clxscore=1015 adultscore=0 phishscore=0 spamscore=0 bulkscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607170197 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=brian.cain@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1784315835232158500 hexagon-linux-user had no enforcement of alignment for scalar load exceptions, and unaligned loads silently succeeded instead of raising SIGBUS. Add MO_ALIGN to the MEM_LOAD* macros, the locked-load and load-frame helpers in genptr.c, and the idef-parser's fLOAD. Reviewed-by: Pierrick Bouvier Reviewed-by: Matheus Tavares Bernardino Signed-off-by: Brian Cain --- target/hexagon/macros.h | 26 +++++++++++++-------- target/hexagon/genptr.c | 6 ++--- target/hexagon/idef-parser/parser-helpers.c | 2 +- 3 files changed, 20 insertions(+), 14 deletions(-) diff --git a/target/hexagon/macros.h b/target/hexagon/macros.h index 8a32d5f79c2..a5b9c24c6bb 100644 --- a/target/hexagon/macros.h +++ b/target/hexagon/macros.h @@ -106,37 +106,37 @@ #define MEM_LOAD1s(DST, VA) \ do { \ CHECK_NOSHUF(VA, 1); \ - tcg_gen_qemu_ld_tl(DST, VA, ctx->mem_idx, MO_SB); \ + tcg_gen_qemu_ld_tl(DST, VA, ctx->mem_idx, MO_SB | MO_ALIGN); \ } while (0) #define MEM_LOAD1u(DST, VA) \ do { \ CHECK_NOSHUF(VA, 1); \ - tcg_gen_qemu_ld_tl(DST, VA, ctx->mem_idx, MO_UB); \ + tcg_gen_qemu_ld_tl(DST, VA, ctx->mem_idx, MO_UB | MO_ALIGN); \ } while (0) #define MEM_LOAD2s(DST, VA) \ do { \ CHECK_NOSHUF(VA, 2); \ - tcg_gen_qemu_ld_tl(DST, VA, ctx->mem_idx, MO_LE | MO_SW); \ + tcg_gen_qemu_ld_tl(DST, VA, ctx->mem_idx, MO_LE | MO_SW | MO_ALIGN= ); \ } while (0) #define MEM_LOAD2u(DST, VA) \ do { \ CHECK_NOSHUF(VA, 2); \ - tcg_gen_qemu_ld_tl(DST, VA, ctx->mem_idx, MO_LE | MO_UW); \ + tcg_gen_qemu_ld_tl(DST, VA, ctx->mem_idx, MO_LE | MO_UW | MO_ALIGN= ); \ } while (0) #define MEM_LOAD4s(DST, VA) \ do { \ CHECK_NOSHUF(VA, 4); \ - tcg_gen_qemu_ld_tl(DST, VA, ctx->mem_idx, MO_LE | MO_SL); \ + tcg_gen_qemu_ld_tl(DST, VA, ctx->mem_idx, MO_LE | MO_SL | MO_ALIGN= ); \ } while (0) #define MEM_LOAD4u(DST, VA) \ do { \ CHECK_NOSHUF(VA, 4); \ - tcg_gen_qemu_ld_tl(DST, VA, ctx->mem_idx, MO_LE | MO_UL); \ + tcg_gen_qemu_ld_tl(DST, VA, ctx->mem_idx, MO_LE | MO_UL | MO_ALIGN= ); \ } while (0) #define MEM_LOAD8u(DST, VA) \ do { \ CHECK_NOSHUF(VA, 8); \ - tcg_gen_qemu_ld_i64(DST, VA, ctx->mem_idx, MO_LE | MO_UQ); \ + tcg_gen_qemu_ld_i64(DST, VA, ctx->mem_idx, MO_LE | MO_UQ | MO_ALIG= N); \ } while (0) =20 #define MEM_STORE1_FUNC(X) \ @@ -519,9 +519,15 @@ static inline TCGv gen_read_ireg(TCGv result, TCGv val= , int shift) #define fLOAD(NUM, SIZE, SIGN, EA, DST) MEM_LOAD##SIZE##SIGN(DST, EA) #else #define MEM_LOAD1 cpu_ldub_data_ra -#define MEM_LOAD2 cpu_lduw_le_data_ra -#define MEM_LOAD4 cpu_ldl_le_data_ra -#define MEM_LOAD8 cpu_ldq_le_data_ra +#define MEM_LOAD2(ENV, EA, RA) \ + cpu_ldw_mmu(ENV, EA, make_memop_idx(MO_LEUW | MO_ALIGN, \ + cpu_mmu_index(env_cpu(ENV), false)= ), RA) +#define MEM_LOAD4(ENV, EA, RA) \ + cpu_ldl_mmu(ENV, EA, make_memop_idx(MO_LEUL | MO_ALIGN, \ + cpu_mmu_index(env_cpu(ENV), false)= ), RA) +#define MEM_LOAD8(ENV, EA, RA) \ + cpu_ldq_mmu(ENV, EA, make_memop_idx(MO_LEUQ | MO_ALIGN, \ + cpu_mmu_index(env_cpu(ENV), false)= ), RA) =20 #define fLOAD(NUM, SIZE, SIGN, EA, DST) \ do { \ diff --git a/target/hexagon/genptr.c b/target/hexagon/genptr.c index 1ebc7471409..05c9aa04467 100644 --- a/target/hexagon/genptr.c +++ b/target/hexagon/genptr.c @@ -470,14 +470,14 @@ void gen_set_byte_i64(int N, TCGv_i64 result, TCGv sr= c) =20 static inline void gen_load_locked4u(TCGv dest, TCGv vaddr, int mem_index) { - tcg_gen_qemu_ld_tl(dest, vaddr, mem_index, MO_LE | MO_UL); + tcg_gen_qemu_ld_tl(dest, vaddr, mem_index, MO_LE | MO_UL | MO_ALIGN); tcg_gen_mov_tl(hex_llsc_addr, vaddr); tcg_gen_mov_tl(hex_llsc_val, dest); } =20 static inline void gen_load_locked8u(TCGv_i64 dest, TCGv vaddr, int mem_in= dex) { - tcg_gen_qemu_ld_i64(dest, vaddr, mem_index, MO_LE | MO_UQ); + tcg_gen_qemu_ld_i64(dest, vaddr, mem_index, MO_LE | MO_UQ | MO_ALIGN); tcg_gen_mov_tl(hex_llsc_addr, vaddr); tcg_gen_mov_i64(hex_llsc_val_i64, dest); } @@ -890,7 +890,7 @@ static void gen_load_frame(DisasContext *ctx, TCGv_i64 = frame, TCGv EA) { Insn *insn =3D ctx->insn; /* Needed for CHECK_NOSHUF */ CHECK_NOSHUF(EA, 8); - tcg_gen_qemu_ld_i64(frame, EA, ctx->mem_idx, MO_LE | MO_UQ); + tcg_gen_qemu_ld_i64(frame, EA, ctx->mem_idx, MO_LE | MO_UQ | MO_ALIGN); } =20 /* Stack overflow check */ diff --git a/target/hexagon/idef-parser/parser-helpers.c b/target/hexagon/i= def-parser/parser-helpers.c index b942d9ea16b..49cc11fddd8 100644 --- a/target/hexagon/idef-parser/parser-helpers.c +++ b/target/hexagon/idef-parser/parser-helpers.c @@ -1770,7 +1770,7 @@ void gen_load(Context *c, YYLTYPE *locp, HexValue *wi= dth, if (signedness =3D=3D SIGNED) { OUT(c, locp, " | MO_SIGN"); } - OUT(c, locp, " | MO_LE);\n"); + OUT(c, locp, " | MO_LE | MO_ALIGN);\n"); } =20 void gen_store(Context *c, YYLTYPE *locp, HexValue *width, HexValue *ea, --=20 2.34.1 From nobody Sat Jul 25 13:40:27 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1784315803; cv=none; d=zohomail.com; s=zohoarc; b=V+D1sJbx2fBvaa0ibaEeD/ZYlQkDiXOrrSP7ltOzY4et+92UvFPwRB8kehpwa3iydn7R5O9vaSgGhPOklqn2L+d9PjY8NgHtYESXeiCUnRcpXsiZ9QnYfT5Gvwv0XTBfXUA+p+joFtLlQ9MXskOnfg1Laq52soZ4Xw1rbujNK7k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784315803; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=KsCgaxXgQZRglc26o60q1xAo+WS9Co5pcgBKtlNLAGk=; b=GNu+SVzvxoBIwBB3Ntro1UCQ4CJ7/NUJotgvYMg+jjvm5A0QaXmSEN8TosFT6/N679gzBxcE9tFtvg5t6NEq6Z4DbwPUT+/EBP+KCwnMjBnZyldkj54LT3TTpb2sbSfxj7yLTRAP10v9lXejNfLk3PO5k0+bOXOlli55rwhqIUI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784315803499326.8785768774587; Fri, 17 Jul 2026 12:16:43 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wko2a-0006pd-4b; Fri, 17 Jul 2026 15:16:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wko2Y-0006oV-3w for qemu-devel@nongnu.org; Fri, 17 Jul 2026 15:16:06 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wko2W-00084h-IA for qemu-devel@nongnu.org; Fri, 17 Jul 2026 15:16:05 -0400 Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66HGoC4q2245302 for ; Fri, 17 Jul 2026 19:16:03 GMT Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fff9pay3y-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Jul 2026 19:16:02 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-38869800848so12250721a91.0 for ; Fri, 17 Jul 2026 12:16:02 -0700 (PDT) Received: from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31429f9d444sm11602463eec.6.2026.07.17.12.15.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 12:16:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= KsCgaxXgQZRglc26o60q1xAo+WS9Co5pcgBKtlNLAGk=; b=oPhC+cJoMQ6sFkl4 6ZiNdJGdtIw1YFd+XKMPDi19idUPoa+T5PuoCpfEM6iRUb8tSozPop/NGjs07wdX ns2OZJeWpB4xLMWGG0Ixu6cLMhdhTcfVSpXLluiMnZ83hCrUBfK3brNazWfZkFnR /1JsApr0DYNZpAGh9AKdka/qkou2pxNvSRalBADmF+2UJ73i0SUixmqvXQTxU+9i D1lh2Ul5Vz9XILH4I2aF0B5+t8RUsgKsnpl5Srussumb9WYXauSn75Jq7qpR0DOT XIxUQuoYx5bWR7WbmI8CfEEmYyZlehQrWtAr0XqnhVwTKeEzpW6Ic8tdK/lJdypj lNqGvQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784315762; x=1784920562; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=KsCgaxXgQZRglc26o60q1xAo+WS9Co5pcgBKtlNLAGk=; b=dF2sul/6JVsgh7yxffxc8UBAb0KNZFncibFGL0z88+Jedo86TP2bZjYe/KgLJMzOfj xcsmaEOwr7EK6cmebUNym/NrtBQNPdPgMCFGA9SDifPlHGGxuswEPa1T5bPPxxw/paym yUbD902kE8ogEion03o0KEzRJ23ZYxYwbj3rD+AupZhrYO8DzSh/frmJDZmI2pM3+ha+ pq+VbpCx83iIENxah9LCHS/Cb5krXSF4UOYp1PteVnujZHf4IJB/XFeuP/mRangOyGKz DK1eR6ruog3XQwbOy2+FrdvzaSGcXklpV4UzbeVtZ6NNCmdhTE0TyLBmFzU8EMFLaoGC KXcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784315762; x=1784920562; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=KsCgaxXgQZRglc26o60q1xAo+WS9Co5pcgBKtlNLAGk=; b=Qw6EL68GlipO1LLJJhrkmDAN8MAYvesIeJegvR1fnXGS1CFFhetZQpjzaE0CCBiibe opXNals9cyTFZfZ4S2i+HMrI376wtS4Np0cJkqcFxIXbTrAOM/3bpjFEn38bMB7OQnrQ HD+UPyf7lc82EpyKHFkgYPld4YukukOIm4ev8RsWsa2xs6N+/JvPK7IvyAiz7ZAPaHpD 6QzMkB9fhv/yZWyqyzf/udwpmHQ3bBKCnl+RLgYpCLmd2CpZhnEn2CsmvyfT5IIzvoCE Y4VDP7G8kHsxlUk4Oxzm6pQjZCBZJBeVjWNGdHsfquoxq/utr6Uz3xciN2PntjmBO58Z du/Q== X-Gm-Message-State: AOJu0YzlOgg0/vafXJK5sbp/OGTWLFXfQZP27F2o7RpBHxkYPwRXVbb5 TSbmEZsgr/2BuBnvtQA3NbKHKB/0mNKV43rTk5Y0hN74oMPb00H3+dc2U17kVETdCRWVzTYFgJr ig26dyDeLGVEYVzRSLrTkC40CnIsRUCRlR2/t260oOqFEHOL4ZzuKnwKP637T7rIYYg== X-Gm-Gg: AfdE7cluEbAHvPmBvwRHYp5977J+84MBAm6kFDxBPIMUutvcNi4z5h1OemQ+kZonfb2 eXDbySnDeMrlEdvjrR7foxllP/L7D7RipIrm5be2H8ER34AiiwO5MNzabsl84UXTAQ09GS6O58J oxCQDaP1WiyGsmQ/ZS5aZLIzOtCRVAkvukc66Ya7QC68OJn3hAio0CAYtPkho/UG2OQ8O00Ikre v2kDtlYSYVAC1jMEHXVu6oy9BmKfEEICRiZIUGu+mfOacNiSdR5mTfx97l2Gurk7E+z7gMmZjBJ Hxpv0ZC2FztafuqlwzsVPcpEfkB4ldgo9Ei0PU6yaAhiSUlVCX+E1rzRieZVACqpf07TYTJtw7f ZT76yQ/5TntYc8W3F78Xtp2M6/8JL8knVdvCP66ZHve4+CRv9 X-Received: by 2002:a17:90b:2dc1:b0:37f:fdc8:71b4 with SMTP id 98e67ed59e1d1-38e4b3e1424mr3976173a91.2.1784315761696; Fri, 17 Jul 2026 12:16:01 -0700 (PDT) X-Received: by 2002:a17:90b:2dc1:b0:37f:fdc8:71b4 with SMTP id 98e67ed59e1d1-38e4b3e1424mr3976126a91.2.1784315761142; Fri, 17 Jul 2026 12:16:01 -0700 (PDT) From: Brian Cain To: qemu-devel@nongnu.org Cc: brian.cain@oss.qualcomm.com, stefanha@redhat.com, Pierrick Bouvier , Matheus Tavares Bernardino Subject: [PULL 06/12] target/hexagon: raise SIGBUS on unaligned scalar stores Date: Fri, 17 Jul 2026 12:15:41 -0700 Message-Id: <20260717191547.920048-7-brian.cain@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260717191547.920048-1-brian.cain@oss.qualcomm.com> References: <20260717191547.920048-1-brian.cain@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: N8l47iohQmSX1XmngtUpCMSpl4nMuPNt X-Proofpoint-ORIG-GUID: N8l47iohQmSX1XmngtUpCMSpl4nMuPNt X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE3MDE5NyBTYWx0ZWRfX0vD6VdcFyzz0 pTNGNVdkG8VDye1V6/83JhRlWoJk5lK+SvUZQlb2ede7iFDVNvCJ31ZjmE0xJmdx97TJojaX6oI jbDjN0qbzJ/py3tU7Ly+NIKjOzzWQDs+bUUTgRK/QAqfuCIVuTbCopIr3V26l70BdxHbL+RmQq2 65Cv+Fe70DMAlu1m3aNDPqQXWwgg7F0OghRPcMdqOmLrfljicO9GzO8HpHm9Vxhc3R6fm9s4lsn /54aCVddOzgKB7xwpVU6Rgq3yWZWIu9gjKsSdkpsNAscDHOKQ6dYurRt9Lq0gtkEEszQsST9Ec6 rnnMzcX4Cj8V7ROWDO7G3YTTO2EJFvl0/0t7LI4cAKwOxyjm+bL4TVw+ADdhal7SGYXmprxatIu rUfKZdIaxwfda+PKdAl6+RFrgdqApw57Ih6L6I5cRAyOToKoyqJZsMIFx0Dm3DN9ODsGuoJ6W7I GWBrGUTANAR9vWJoDwQ== X-Authority-Analysis: v=2.4 cv=TaqmcxQh c=1 sm=1 tr=0 ts=6a5a7f72 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=MHlpfT5McVMPhJjrq0IA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE3MDE5NyBTYWx0ZWRfX97kw30WlTjMg 1XkY1sO0VL2MGgBzUyJNfZsPrgpVBeF0DQr/eR4mwDN0Yr1YRy5wQyrKP8LhBA/MneegFVEge8S twkvdVhHamjmrlu45vc+WzxuIK8dtok= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-17_05,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 adultscore=0 spamscore=0 bulkscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607170197 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=brian.cain@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1784315804986158500 hexagon-linux-user had no enforcement of alignment for scalar store exceptions, and unaligned stores silently succeeded instead of raising SIGBUS. Stores are logged rather than committed immediately, so both commit paths need the fix. Reviewed-by: Pierrick Bouvier Reviewed-by: Matheus Tavares Bernardino Signed-off-by: Brian Cain --- target/hexagon/genptr.c | 4 ++-- target/hexagon/op_helper.c | 13 ++++++++++--- target/hexagon/translate.c | 6 +++--- 3 files changed, 15 insertions(+), 8 deletions(-) diff --git a/target/hexagon/genptr.c b/target/hexagon/genptr.c index 05c9aa04467..f48a27bc09b 100644 --- a/target/hexagon/genptr.c +++ b/target/hexagon/genptr.c @@ -495,7 +495,7 @@ static inline void gen_store_conditional4(DisasContext = *ctx, zero =3D tcg_constant_tl(0); tmp =3D tcg_temp_new(); tcg_gen_atomic_cmpxchg_tl(tmp, hex_llsc_addr, hex_llsc_val, src, - ctx->mem_idx, MO_32); + ctx->mem_idx, MO_32 | MO_ALIGN); tcg_gen_movcond_tl(TCG_COND_EQ, pred, tmp, hex_llsc_val, one, zero); tcg_gen_br(done); @@ -520,7 +520,7 @@ static inline void gen_store_conditional8(DisasContext = *ctx, zero =3D tcg_constant_i64(0); tmp =3D tcg_temp_new_i64(); tcg_gen_atomic_cmpxchg_i64(tmp, hex_llsc_addr, hex_llsc_val_i64, src, - ctx->mem_idx, MO_64); + ctx->mem_idx, MO_64 | MO_ALIGN); tcg_gen_movcond_i64(TCG_COND_EQ, tmp, tmp, hex_llsc_val_i64, one, zero); tcg_gen_extrl_i64_i32(pred, tmp); diff --git a/target/hexagon/op_helper.c b/target/hexagon/op_helper.c index 125952aee59..3ce223caba3 100644 --- a/target/hexagon/op_helper.c +++ b/target/hexagon/op_helper.c @@ -95,19 +95,26 @@ static void commit_store(CPUHexagonState *env, int slot= _num, uintptr_t ra) { uint32_t width =3D env->mem_log_stores[slot_num].width; target_ulong va =3D env->mem_log_stores[slot_num].va; + MemOpIdx oi; =20 switch (width) { case 1: cpu_stb_data_ra(env, va, env->mem_log_stores[slot_num].data32, ra); break; case 2: - cpu_stw_le_data_ra(env, va, env->mem_log_stores[slot_num].data32, = ra); + oi =3D make_memop_idx(MO_LEUW | MO_ALIGN, + cpu_mmu_index(env_cpu(env), false)); + cpu_stw_mmu(env, va, env->mem_log_stores[slot_num].data32, oi, ra); break; case 4: - cpu_stl_le_data_ra(env, va, env->mem_log_stores[slot_num].data32, = ra); + oi =3D make_memop_idx(MO_LEUL | MO_ALIGN, + cpu_mmu_index(env_cpu(env), false)); + cpu_stl_mmu(env, va, env->mem_log_stores[slot_num].data32, oi, ra); break; case 8: - cpu_stq_le_data_ra(env, va, env->mem_log_stores[slot_num].data64, = ra); + oi =3D make_memop_idx(MO_LEUQ | MO_ALIGN, + cpu_mmu_index(env_cpu(env), false)); + cpu_stq_mmu(env, va, env->mem_log_stores[slot_num].data64, oi, ra); break; default: g_assert_not_reached(); diff --git a/target/hexagon/translate.c b/target/hexagon/translate.c index 77235916f4b..5d54ce8caa4 100644 --- a/target/hexagon/translate.c +++ b/target/hexagon/translate.c @@ -896,17 +896,17 @@ void process_store(DisasContext *ctx, int slot_num) case 2: tcg_gen_qemu_st_tl(hex_store_val32[slot_num], hex_store_addr[slot_num], - ctx->mem_idx, MO_LE | MO_UW); + ctx->mem_idx, MO_LE | MO_UW | MO_ALIGN); break; case 4: tcg_gen_qemu_st_tl(hex_store_val32[slot_num], hex_store_addr[slot_num], - ctx->mem_idx, MO_LE | MO_UL); + ctx->mem_idx, MO_LE | MO_UL | MO_ALIGN); break; case 8: tcg_gen_qemu_st_i64(hex_store_val64[slot_num], hex_store_addr[slot_num], - ctx->mem_idx, MO_LE | MO_UQ); + ctx->mem_idx, MO_LE | MO_UQ | MO_ALIGN); break; default: { --=20 2.34.1 From nobody Sat Jul 25 13:40:27 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1784315789; cv=none; d=zohomail.com; s=zohoarc; b=KvO5sCdcc2+PCXtysypu0d1q+zistGX2YcjLdzHrE97K3a1npKaZ2exjRrdjh8osdRLyMGlQ8Md0WorVGnvPEE0vOhqZF+AkklXsmRcw5fEQe3oLoHoAIlIYAlZK4Jn4Ecnc3elsvPiUbUJtEiEu3XS3ZLgm0fUDfaqt0Tzj/3Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784315789; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=njuO05NTJQp6SvpT4Ks6OjCaxWfJHjkBxMIIyz4Wbzs=; b=Ql7YVg0LbPcXmZBKCCkwGs7DtQJ/4Lm4JA0zQTBSIGu/aoJHH1H+FOHTdNTKLUpmDJvGVlckXXHIJb5PevBkskAIHsD+f3dUtir5uhOJ0bX66dszE1t9alWLbEoPLmnAWKpDV+wAtr731p9KPaH6b7D+aSCCrRzwvwz3uDzBO34= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784315789412691.527439693072; Fri, 17 Jul 2026 12:16:29 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wko2a-0006pk-WA; Fri, 17 Jul 2026 15:16:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wko2Z-0006p9-2s for qemu-devel@nongnu.org; Fri, 17 Jul 2026 15:16:07 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wko2X-00084y-J6 for qemu-devel@nongnu.org; Fri, 17 Jul 2026 15:16:06 -0400 Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66HGo6Of2344734 for ; Fri, 17 Jul 2026 19:16:04 GMT Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ffpug10t0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Jul 2026 19:16:04 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2cca5e0a0c9so156927795ad.1 for ; Fri, 17 Jul 2026 12:16:04 -0700 (PDT) Received: from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31429f9d444sm11602463eec.6.2026.07.17.12.16.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 12:16:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= njuO05NTJQp6SvpT4Ks6OjCaxWfJHjkBxMIIyz4Wbzs=; b=FQ4ipItGt0o1W8t9 bMJ5nh7u4SOIhmvWaQfUmgrcCw7MClSO6WZlK98mr0om4XhQxJvK3XprGPV3zj16 YTfxCDJm8TyRKHeJt7gkgk5X7dfhX358meEUeMfnjBV7NReXlc1kj2A9PoPS0BDr FP0YVl6ZLrSoNihl74S7OlBYefxo6d785DP78Fje7eMavvlSpJYx+aGizXfu9l3d 3BLbGhqh/wVxGF0s1+gTMDJ8swq9TgAOhftMFvZ6oUDnXTHBjNSYGfGsy76DSDB1 iK/rMzDS0t/72zE4K1VJt9OhVrqH3xZG15L1ghuy4+UvQvrFhXC/o34syA/a1C+/ ouW4zg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784315763; x=1784920563; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=njuO05NTJQp6SvpT4Ks6OjCaxWfJHjkBxMIIyz4Wbzs=; b=FR3+YLAxAOGUAFuiQGjl/WaBLBVns+cHBIITIBKrd+SOYp4xcx1xCD9Rwv2gCZbLRF ik/JhSMSx0+O7rYl6D6eJySlVWQdCGGM9XwZ0zZiZnQxGD6BKb/eEOi169/C467yWC1W sJRqyrjvkNQdYgrMssrKmzQl0qskITSyyTLyTsDYc5eEaVbT+s5gxnri5mUccjdkZLlF WktV8Voyua+1sBdoFS/IBTE+29eLJ/aq4aeWeoOAdVQmWzl4JI/viK+FgowA+Agk6Pbd V8DdAqmjzwyD3a70m9kRFJGfIy9vf29LF1xzRJRDzOtcR/WEec9bBElxQgwNSkHFGHy9 bdnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784315763; x=1784920563; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=njuO05NTJQp6SvpT4Ks6OjCaxWfJHjkBxMIIyz4Wbzs=; b=DfmGimanS8ojsuhCy/pIoH6NcYCDEQT6d4kXRDrRHrTP08hp6jx9lXDzl/6R7MJ/LQ Df1kyfoHe8jB7jTN5+5DIYa0UC8AADHmLEc83Pk1/XtzTYg63/T79LRSWhrcH4+ufjnj zXy9hcjLbKPa4dw8S9ohjPrAPfqk6c7ZnzzDC3J0rVqDtWtE0foWF1gAryEbg+Z8E33O cGfLN8VwD6UsRK7apTl9VQ2EvyC3aZSqM4i7yfZNI0VDr8YidhR/VX++JL9LEGNO+hbY muZoyYjbXqA1PnHbcAdI4wBtHTevRsRUF4TKA9EXYFmP/xji14pdWKlicsu3itMabNFQ 46wQ== X-Gm-Message-State: AOJu0YzIJo6Nmiut+R+ZEzSGUwxY50CH/Ha7Q7udhDVIKPx3B2p4oChZ xdXPoGO0CUQJiDQ0z4M9TDF2gGxvKBGXrXPskfMFYDpeC0Y8JbFjABfukDRn2pZJzIkd5/PM/57 ZrjYwnC0BdY0W4toMhEiO/andvK6RNBx2gSfojBvodk0wi96j/Ey4HOv+0B1bUoazNg== X-Gm-Gg: AfdE7ck4FSNmkQJOEaH8AvWDd5orIuF/A0kglr7QajZ3Y606FSZRg0p1eze8XDQu78n 213WAad0pvIig44nR4atvXaiGKAvc8j9/CobnHqCjFByiuRS5FFkV0ZMMVsecYaGzwPheoO7WRn V3fc9ijN0HI6hniqRD+Fj1HisrvjtWnzkxc2s+WE/JnS8XwZy72nZcL+IPhwoqxasNdgVEFY/3I RBTmfemBTfd4vg6p47KlSpilqfvDDxjEpjaygqM7R01kY+j03sYelAmv9QZE0CBLgCZrmfcDgFh L8zAypIoGUSB3/azVbigMX+zF1HCA/YBDkTwYFpC7Axn/rxVauk1LyrPLeDmI2WLpedzB9Y5Puj pCpqLCQdg7iKFD1/uNt6AFAVdXzD3pVNuQPT3wZ4ZwcyWl68e X-Received: by 2002:a17:90b:4b0e:b0:38d:e5d0:9bd with SMTP id 98e67ed59e1d1-38e4b52ebfcmr4452004a91.26.1784315763432; Fri, 17 Jul 2026 12:16:03 -0700 (PDT) X-Received: by 2002:a17:90b:4b0e:b0:38d:e5d0:9bd with SMTP id 98e67ed59e1d1-38e4b52ebfcmr4451950a91.26.1784315762853; Fri, 17 Jul 2026 12:16:02 -0700 (PDT) From: Brian Cain To: qemu-devel@nongnu.org Cc: brian.cain@oss.qualcomm.com, stefanha@redhat.com, Pierrick Bouvier , Matheus Tavares Bernardino Subject: [PULL 07/12] target/hexagon: raise SIGBUS on unaligned data access in sysemu Date: Fri, 17 Jul 2026 12:15:42 -0700 Message-Id: <20260717191547.920048-8-brian.cain@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260717191547.920048-1-brian.cain@oss.qualcomm.com> References: <20260717191547.920048-1-brian.cain@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE3MDE5NyBTYWx0ZWRfX1ZaRDkWJgEas qmF0IVdpj70gvfRTSefKtI8U13+CtIoAAG+RDXqESjvyc/Rf7ofnzxidC65qz88+oTD7HXQhW7D e8JrJz7QcIz8c6pVc/F+948+Rv9sdCOmnYFXlUtfUmE/83Zgc1PRej3FoblwVkZCQ4vBRZ3GgTW 5feCTtROSgjXIoDH7dgMomDQtAFTUBtIVU6wMfKR8rYJ8xc+9VWTPOz4TiGyN2lxaqiV21VVNHB /nOySnkwreeymB/Zha6ke8cLSUZFdvMlsbm8XjkZ6FCoxfMJ0RXVBGdePfC8PjfLyxcvPeQyzwy P7UU0WyCO7m0QIRMSf32GPtBfro5Ur95vyyFUXN7kB88FDRX6+XniiNx9EmpLhk8yLP0Ui+nPiK jgm7hBHnwM+hr4rtl8SX44LOvqPQS/lEWzSk8OfzvIOjHlL27NIU8zFPxJAoO3RHhu6W33bvkxW 3BUu+jYXserLpF8l7bw== X-Proofpoint-GUID: drCmZamzb9cFjxzt-tqOI1E7gPV-KypE X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE3MDE5NyBTYWx0ZWRfXwxhWVFWzyIPF gSjlSFGPcCkc2cSuYkj0rvXpR5tinoVlHC/3T52oTC3RUSyrG4uAZC1sRGpg+PAkHJ2EuDlnq9o mjIq50NjGom5b2ZlbrYeBgoyszsNM2M= X-Proofpoint-ORIG-GUID: drCmZamzb9cFjxzt-tqOI1E7gPV-KypE X-Authority-Analysis: v=2.4 cv=Q63iJY2a c=1 sm=1 tr=0 ts=6a5a7f74 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=QWbXAH-yNWLVfgUa_9MA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-17_05,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 spamscore=0 bulkscore=0 suspectscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607170197 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=brian.cain@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1784315791403158500 hexagon-softmmu had no enforcement of alignment for scalar loads and stores: the MO_ALIGN flag added by the previous two commits triggers TLB_INVALID_MASK/alignment faults in cputlb.c, but Hexagon's TCGCPUOps did not implement do_unaligned_access, so the fault was never delivered to the guest. Add hexagon_cpu_do_unaligned_access(), which raises HEX_CAUSE_MISALIGNED_LOAD/_STORE via the existing HEX_EVENT_PRECISE path, mirroring raise_tlbmiss_exception()/raise_perm_exception(). Reviewed-by: Pierrick Bouvier Reviewed-by: Matheus Tavares Bernardino Signed-off-by: Brian Cain --- target/hexagon/cpu.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/target/hexagon/cpu.c b/target/hexagon/cpu.c index 42d93e5da47..e2af736a99d 100644 --- a/target/hexagon/cpu.c +++ b/target/hexagon/cpu.c @@ -637,6 +637,18 @@ static void raise_perm_exception(CPUState *cs, uint32_= t VA, int slot, cs->exception_index =3D excp; } =20 +static void raise_misaligned_exception(CPUState *cs, uint32_t VA, int slot, + MMUAccessType access_type) +{ + CPUHexagonState *env =3D cpu_env(cs); + int32_t excp =3D (access_type =3D=3D MMU_DATA_STORE) ? + HEX_CAUSE_MISALIGNED_STORE : HEX_CAUSE_MISALIGNED_LOAD; + + set_badva_regs(env, VA, slot, access_type); + cs->exception_index =3D HEX_EVENT_PRECISE; + env->cause_code =3D excp; +} + static const char *access_type_names[] =3D { "MMU_DATA_LOAD ", "MMU_DATA_S= TORE", "MMU_INST_FETCH" }; =20 @@ -715,6 +727,18 @@ static vaddr hexagon_pointer_wrap(CPUState *cs, int mm= u_idx, return result; } =20 +static G_NORETURN +void hexagon_cpu_do_unaligned_access(CPUState *cs, vaddr addr, + MMUAccessType access_type, int mmu_id= x, + uintptr_t retaddr) +{ + CPUHexagonState *env =3D cpu_env(cs); + + raise_misaligned_exception(cs, addr, 0, access_type); + do_raise_exception(env, cs->exception_index, env->gpr[HEX_REG_PC], + retaddr); +} + #endif =20 static const TCGCPUOps hexagon_tcg_ops =3D { @@ -732,6 +756,7 @@ static const TCGCPUOps hexagon_tcg_ops =3D { .pointer_wrap =3D hexagon_pointer_wrap, .cpu_exec_reset =3D cpu_reset, .tlb_fill =3D hexagon_tlb_fill, + .do_unaligned_access =3D hexagon_cpu_do_unaligned_access, .cpu_exec_halt =3D hexagon_cpu_has_work, .do_interrupt =3D hexagon_cpu_do_interrupt, #endif /* !CONFIG_USER_ONLY */ --=20 2.34.1 From nobody Sat Jul 25 13:40:27 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1784315801; cv=none; d=zohomail.com; s=zohoarc; b=dhEyYl5hH3Pvq8fAqPaqL4XamEPPE6wNiKqgMs09ibJDnrprTtZu0voH9resPvp2kNZ4Nco51wkScWI7EjWAtbBiCBQxMxWXmAIHiR4jTaLCnhV6RgxXMFV6Y7tvPxI6aLO/sSGleCivvpqZV0Nt78FAwCQIhwtfIWlgSVIrnPA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784315801; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=zqu/caR8qUOFriN6mz6fEU2gUD5dQmgerya3OVTiR0g=; b=QEurhV301xUH5H+Baa07j8PQBkWyldxmHzIjOQyhFcqKjvTI9a7UZLwQsy8USzOiIBhgwpw/auEST3Rm3kPCKdhGeR6RYBw01z2Tj71GxziEGDSIJ/z9eIoWMhNIuRb7eQL03RXEJhr9FGzY4zhPzrwxmuyg3YkfhLhB8fSUZiw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784315801076809.3546246477309; Fri, 17 Jul 2026 12:16:41 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wko2c-0006qU-HE; Fri, 17 Jul 2026 15:16:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wko2b-0006pv-3P for qemu-devel@nongnu.org; Fri, 17 Jul 2026 15:16:09 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wko2Z-00085r-CU for qemu-devel@nongnu.org; Fri, 17 Jul 2026 15:16:08 -0400 Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66HGoNY02372999 for ; Fri, 17 Jul 2026 19:16:06 GMT Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fff9gu01x-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Jul 2026 19:16:06 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-38dde0df80bso10407106a91.3 for ; Fri, 17 Jul 2026 12:16:06 -0700 (PDT) Received: from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31429f9d444sm11602463eec.6.2026.07.17.12.16.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 12:16:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zqu/caR8qUOFriN6mz6fEU2gUD5dQmgerya3OVTiR0g=; b=L+KGkRf6p+oKOC5x LNz7cjCiLwJKo4EXDipOQLx1Hh8GNgn2v/l+aK76PjKZ0qP2w5Hb0rE7fcR752Av YR4cOH3FGKD9bS01+HmbpjhIViwOHlJcHfuGpQ/wc4/uIsKJ8WFgTtoS3/bh7uim 3+diHeZ6yA0qM6OMwD50abU8xfX18+lUQDwcTE0kdtofnLtNjNH65zC76CCFXzD2 4evuyp6ap8wK0rlyMWrYHist3va/Fhi48gVbAX8U5k+H0LDuP8iKxamxNVMKYTbN s4HQiN+aVUOsrj/PfwAM0nyTPhlrChKyx0fUmB4mACDayW4GdhfTCZxmiwyywg/Z hppLoA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784315765; x=1784920565; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=zqu/caR8qUOFriN6mz6fEU2gUD5dQmgerya3OVTiR0g=; b=dxPe7NsKQnet3akJtx4U385BWxmsPPaNMR+BblwbJYt99Gn3gvKuNFRWQC9yjJKzfA IJLSvisgJ1YUdiBvjaitl8cQ+oJp2n3Si/J/U+RLtFD4DMAkMyOwZfYsiPqDZtwBKzjW /dR4hzgGWzTo6eaPLMT2z/54Me8Qr9UOS/8thLb2LW/rsTe2/Aj5FxhAaM8d8TSN7rkC YrP0as5jwiCc3tfj3ssU1IdqMDHld9UKr+4R96xp8XsGUK4nsHWluM4lTCfJUVmZFDaC OoDK8zoSwpq/vKbDlSsz3wIlsZaZ7nMdsNKY+uvC2oHF1XGuo/qc9OjfX/IrriIsN2f8 gd1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784315765; x=1784920565; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=zqu/caR8qUOFriN6mz6fEU2gUD5dQmgerya3OVTiR0g=; b=avaVGs3TgyB3FyRN0X36p3ntY3WFH7BsHhxq21lAXI8i9iC54FToKy/a4vgOoWDA8E BDF+iqzOLTlhc3twLKAcmYbWYSp/8lGK5ME6pu81dkQ05SVSNasl+FQSlviHYJyJDqA1 5uK1sE8tDYVMR6sw7hiE3Zsslk9ZlfhENH7wFrzm34GbJsVRPjheapKJ1Pi4X3qlfbtX rAQZSPVwrzk74Sn45FU7C/kbW5F9TrIDvb+R98f+qx0PsTyyd04b14WLYEqtk91qijzJ AEwZjO23HSA34dI0X0yZHgJCsFyx33WMumbn776qv8AnNqp3XVu6kzNquj0aqOWAK+FX W01g== X-Gm-Message-State: AOJu0Yx5vNWz9dQp9esu0YA3A0pmzG6Wl/BfCV3ZWRq/s+Wzk5WpEwo2 IgeeumFWwuTziKcN3wHiu+mE1ea79GZLmGwAazt2puFD0lp/l2T4AmROm872HzdUFeHe4R9Hy6w 6vBuqESLXCvxQCvtJVmMEPVZ8WOB2d2PwwM0ZcUtXk+snev74RyJxK70J5jnFT37MtQ== X-Gm-Gg: AfdE7cnOFKU3QdJmT3KyqNTfaes7dxbdhUgR+AfXZrzhwqBYd8m4y/SRhkuU18AVONB SWU8IdNykDTkSoasb2MOM/NNP7/F7MNZBlH0To3vqdoNW0aWqSRmyFipy9r9OCCmSCkQu7WlQhT p7FXAiqSxSmSGolNpP6/Q8U+6/5ABhNCt4SjFhCfODdWq2bkEnc0ul+k4Zw2ns1es6DU9IOsBUq X8pkRMeaMnhUZPGGdMcDCxOXX9M3f6+ENKCwLSFjYbOB6mAlZRFqm3bqPyoH81Ye0BfjKkbeaoc H9dH6dvPbyP29TChLwGh9SW2D7/tszFIsX5cDKbRPLQDf1Hk9DPbypIbD4KyeXzMRkz8L2Gzzas OJG2/uo6d6HxmnO5QbxDUKW2bkPTvO2iRIhAtMjyfFf25iVm2 X-Received: by 2002:a17:90b:58ee:b0:387:e0cb:7f3 with SMTP id 98e67ed59e1d1-38e4b58a223mr3574619a91.39.1784315764934; Fri, 17 Jul 2026 12:16:04 -0700 (PDT) X-Received: by 2002:a17:90b:58ee:b0:387:e0cb:7f3 with SMTP id 98e67ed59e1d1-38e4b58a223mr3574580a91.39.1784315764346; Fri, 17 Jul 2026 12:16:04 -0700 (PDT) From: Brian Cain To: qemu-devel@nongnu.org Cc: brian.cain@oss.qualcomm.com, stefanha@redhat.com, Pierrick Bouvier Subject: [PULL 08/12] tests/tcg/hexagon: add unaligned scalar test Date: Fri, 17 Jul 2026 12:15:43 -0700 Message-Id: <20260717191547.920048-9-brian.cain@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260717191547.920048-1-brian.cain@oss.qualcomm.com> References: <20260717191547.920048-1-brian.cain@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE3MDE5NyBTYWx0ZWRfXweRiHIGii0Xt kffyDD39kvkOI+7kvUldw8ZSMrKlehPNItu8FbPG4m1jtdVUXUexa5eIWfQDSpMCAA6UcDBHH50 dg3FNT/8wfqbYqW2Hck3i1QdrpdyvFc= X-Proofpoint-ORIG-GUID: OMmqL4F5y0shn1eYAv4qX1rsSXcjyDfN X-Proofpoint-GUID: OMmqL4F5y0shn1eYAv4qX1rsSXcjyDfN X-Authority-Analysis: v=2.4 cv=TaumcxQh c=1 sm=1 tr=0 ts=6a5a7f76 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=JA4W_Hs6HDHytmC4mdIA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE3MDE5NyBTYWx0ZWRfXyQ4odsj1NHm+ ds/IkmNn6/2utKSt45iRM8IrA4PokODqr4oanNhMG9IXYNeG4t9Lguo9KTHOtaMvn6QYOWXohyP 6kXAJZ2ggQm5LuTP+byK9qH9AGaaOZI41TiwyRyPveS45B4EkvXPgmC4DwsXwtbM6Z/q4Hgt1FU cj2pCxIuyVoTDRecjn6ZdU7nKkQBMsJBFbjaxnc3U6BAwEe1obHbE4Daa9HQHxSjHnxgjolV1Nk dERcqowP6dDH1eO3eaWKBeHJwfbUfmW8yepOlCMNbLbN1KrUQo6Wy8D8+Q8U1grdd5GI/kqWOrY aG6L7QDagHXgH25cLp1ueVIECzUReQN1sHAe+vlqIUO/j3vJAqatdq1M6EPat2XsYM0Xo0Rzgtu HEloyO8S+WYIiNlUpBjGcxzfcPtVfP9yfJjcT/GQVFr8u+IYB3X8c/zCICsurYyFtd6JaZqixgy SvtrnuyNJDSAxQimxbw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-17_05,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 clxscore=1015 adultscore=0 phishscore=0 spamscore=0 bulkscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607170197 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=brian.cain@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1784315802862158500 Add unaligned_data.c to exercise unaligned memh/memw/memd accesses and verify SIGBUS is raised and caught. Reviewed-by: Pierrick Bouvier Signed-off-by: Brian Cain --- tests/tcg/hexagon/unaligned_data.c | 118 +++++++++++++++++++++++++++++ tests/tcg/hexagon/Makefile.target | 2 + 2 files changed, 120 insertions(+) create mode 100644 tests/tcg/hexagon/unaligned_data.c diff --git a/tests/tcg/hexagon/unaligned_data.c b/tests/tcg/hexagon/unalign= ed_data.c new file mode 100644 index 00000000000..e0375faafbe --- /dev/null +++ b/tests/tcg/hexagon/unaligned_data.c @@ -0,0 +1,118 @@ +/* + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +/* + * Test that unaligned scalar loads raise SIGBUS. + */ + +#include +#include +#include +#include +#include +#include + +int err; + +#include "hex_test.h" + +static bool sigbus_caught; +static sigjmp_buf jmp_env; +static uint64_t buf[2] =3D { 0, 0 }; + +static void sigbus_handler(int sig, siginfo_t *info, void *puc) +{ + check32(sig, SIGBUS); + sigbus_caught =3D true; + siglongjmp(jmp_env, 1); +} + +static void test_unaligned_load(int size, int offset) +{ + char *p =3D (char *)buf + offset; + uint32_t dummy32; + uint64_t dummy64; + + sigbus_caught =3D false; + if (sigsetjmp(jmp_env, 1) =3D=3D 0) { + switch (size) { + case 2: + asm volatile("%[dst] =3D memh(%[src])\n\t" + : [dst] "=3Dr"(dummy32) : [src] "r"(p) : "memory= "); + break; + case 4: + asm volatile("%[dst] =3D memw(%[src])\n\t" + : [dst] "=3Dr"(dummy32) : [src] "r"(p) : "memory= "); + break; + case 8: + asm volatile("%[dst] =3D memd(%[src])\n\t" + : [dst] "=3Dr"(dummy64) : [src] "r"(p) : "memory= "); + break; + default: + abort(); + } + } + check32(sigbus_caught, true); +} + +static void test_unaligned_store(int size, int offset) +{ + char *p =3D (char *)buf + offset; + uint32_t val32 =3D 0x11223344; + uint64_t val64 =3D 0x1122334455667788ULL; + + sigbus_caught =3D false; + if (sigsetjmp(jmp_env, 1) =3D=3D 0) { + switch (size) { + case 2: + asm volatile("memh(%[addr]) =3D %[val]\n\t" + : : [addr] "r"(p), [val] "r"(val32) : "memory"); + break; + case 4: + asm volatile("memw(%[addr]) =3D %[val]\n\t" + : : [addr] "r"(p), [val] "r"(val32) : "memory"); + break; + case 8: + asm volatile("memd(%[addr]) =3D %[val]\n\t" + : : [addr] "r"(p), [val] "r"(val64) : "memory"); + break; + default: + abort(); + } + } + check32(sigbus_caught, true); +} + +int main() +{ + struct sigaction act; + + act.sa_sigaction =3D sigbus_handler; + sigemptyset(&act.sa_mask); + act.sa_flags =3D SA_SIGINFO; + chk_error(sigaction(SIGBUS, &act, NULL)); + + test_unaligned_load(2, 1); + test_unaligned_load(4, 1); + test_unaligned_load(4, 2); + test_unaligned_load(4, 3); + test_unaligned_load(8, 1); + test_unaligned_load(8, 4); + + test_unaligned_store(2, 1); + test_unaligned_store(4, 1); + test_unaligned_store(4, 2); + test_unaligned_store(4, 3); + test_unaligned_store(8, 1); + test_unaligned_store(8, 4); + + act.sa_handler =3D SIG_DFL; + sigemptyset(&act.sa_mask); + act.sa_flags =3D 0; + chk_error(sigaction(SIGBUS, &act, NULL)); + + puts(err ? "FAIL" : "PASS"); + return err ? EXIT_FAILURE : EXIT_SUCCESS; +} diff --git a/tests/tcg/hexagon/Makefile.target b/tests/tcg/hexagon/Makefile= .target index 70a8ec2e7fb..a2a0ffc69b2 100644 --- a/tests/tcg/hexagon/Makefile.target +++ b/tests/tcg/hexagon/Makefile.target @@ -54,6 +54,7 @@ HEX_TESTS +=3D invalid-slots HEX_TESTS +=3D invalid-encoding HEX_TESTS +=3D multiple-writes HEX_TESTS +=3D unaligned_pc +HEX_TESTS +=3D unaligned_data =20 HEX_TESTS +=3D test_abs HEX_TESTS +=3D test_bitcnt @@ -108,6 +109,7 @@ preg_alias: preg_alias.c hex_test.h read_write_overlap: read_write_overlap.c hex_test.h reg_mut: reg_mut.c hex_test.h test_pnew_jump_loads: test_pnew_jump_loads.c hex_test.h +unaligned_data: unaligned_data.c hex_test.h unaligned_pc: unaligned_pc.c =20 # Compile for v66 so that the ELF selects a v66 CPU; the test then --=20 2.34.1 From nobody Sat Jul 25 13:40:27 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1784315842; cv=none; d=zohomail.com; s=zohoarc; b=fd0UWEIKRWhYw97e0Sb8QzrFIQMea9m53PPyGN2VbW5zT54COjsoFns2Q/ONGTpaPdLeQ7/p1WpqsCqOHYNbk0O4ogZatXVlvWTyBxDFgwRHtV3ZNqXDxysMwL4avVeSNx2JprXmpNBzePoLjx6/3wP7Htl3UDlzzZgHQzlGABk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784315842; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=NdMMhEbDc69DiNKN5npdtwEGSf6iczbzW5UzZR/p13Q=; b=ZI8rrE7lhhN99owVQQZfxujjJ9RPQct8KKik7LgomtS+cWZ7wCqXC2/nUtWL8eoF7L2AuExLT7B12g8eZbpzKm5q/zUtWHk0UREAL1nsq5KIqAripGDmL9Gvq1vyyt/g3kY/Mcftw5289KTbCfvxeKmxtlEIseL4e2du0mN4HVY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784315842158715.3773667831534; Fri, 17 Jul 2026 12:17:22 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wko2e-0006qr-A8; Fri, 17 Jul 2026 15:16:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wko2c-0006qY-VJ for qemu-devel@nongnu.org; Fri, 17 Jul 2026 15:16:10 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wko2b-00086F-Gs for qemu-devel@nongnu.org; Fri, 17 Jul 2026 15:16:10 -0400 Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66HGo4WV2244912 for ; Fri, 17 Jul 2026 19:16:08 GMT Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fff9pay4j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Jul 2026 19:16:08 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-38827cee19eso8709783a91.3 for ; Fri, 17 Jul 2026 12:16:08 -0700 (PDT) Received: from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31429f9d444sm11602463eec.6.2026.07.17.12.16.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 12:16:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= NdMMhEbDc69DiNKN5npdtwEGSf6iczbzW5UzZR/p13Q=; b=nd7/PPdZL45WshAf 7wEBLTOLQNLaBy5zh3gE7MB/SA+JSaOWNdji+rM0DLLCx8zSI9/ZGQSw1+v8TOP+ H186271rGpfbF1C6BYuu6b1+SuEei7n1/EhSWj39VVHjQRa4VxchXb2KEEATqznT 9HIiqzQ2worV+aXy/TUM/yNTflErBYoqjmHqIc/DJQZhMb2qfzKao75sqOUYmJ37 JWhLbT43VeGdssspmlfK/FRc5xdyjSy3KjcAomNiPrtRo6LbV0g4DSt0stbzEEVN z3jfz+yBA+g9T3J5mrEWrX/XDyz4aGuH1axUUNUeFtVOenUX2+RtTqgPu5B+eGaD 5VxHAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784315767; x=1784920567; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=NdMMhEbDc69DiNKN5npdtwEGSf6iczbzW5UzZR/p13Q=; b=Nb5bEFCBpoHxVpvqEhyJ5xAQ7ZgIU8fhJJBszRzT7E076yj3OzoTpfMoN+hAUcTAb9 vpijpLlwa6MQEyYFXLFR39IE/1vdw1MmaIqIQ/BxI4Tn8L7orLvgMOU1RKmlcT5yM/dz H+4xfatYrqz885FjrvacqPsM2rWiv40O5y199K+X/7yhL/2o4FHx4x98/833Ak/tzPWQ WfnBtwsMy7kjF1stT8RovqS65z8Y+LKJVTygC6PuV6WY8lyhx+FdzzkkLUghj7yPU2Yt hN8btfJWa+OkIrjZXImf7UgkTNdmRRt/C2F6lldGd0a1NzIJb3jg4A3hIV86MKx5urMU GMFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784315767; x=1784920567; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=NdMMhEbDc69DiNKN5npdtwEGSf6iczbzW5UzZR/p13Q=; b=PBpfwvUwaaXhk9HVcTiA0X++ehufVmVkbKpHrwfvPX24eEztBDnaYjF7NDfJbTC7HY FMCATOaagJOpr68duNqJT97YMpY4b7FAOgilyymDmhpPCbwhQAhUo+6BuD+WuNiJjayC BnFSY0Fvee5o9oLHdMWpODgOJXjcNJyw31uAMIBRwMJyanyewxJEF8V6Ei7Pz2D51ZQ9 xpmKhkdAMZ+VEDVnFiBpSNs6i0SkDEBw34R3QEciFwhu3BImoumQFvuhylrUFHovjutb QjLBQq0GVD/eV79nmWeZFNaWSvd9uogI5fPfq3WY7MVl0Md1t+3tOtxwSTDCylnjjtbD u6pA== X-Gm-Message-State: AOJu0Yyq9wKUirh7MMUugiTCqtkTuDp0cpaS0l4JwG+afI7cp+GpcICU MzWk4ZeF/Be/n24NzQosiFhRzzlv3T7pNrOXdOnKrbW8ua/W68q5XjdjN1rewlsd4KMHUMSxY8T engNF201yLzmr2w3ZH6tNBq7BA36mlxK3c6+R7bJVBHEa/udZx5p6cURg33uqTSh7mQ== X-Gm-Gg: AfdE7clpr2LtBnNGdtFDIYM2bmlP6MmTXG6OrRkHz4koYmcCJXiP1hjmJwSDpf7EOKX EZqVRKK4UOYYVt6mHhZYfkxnM6OKe5JGNQxBTwtTyO1TfLkZLnokuV4FidcqAg2HUoTVsuaQb3U Ss7hF6+akTXTXOz+HLKwV34THgRtiLNvPLHhPVRYJSjnqh02EW+lZY7v54g5VBCrrxlPrgRib7S blmWnB7Ks5A6tW7qCtrGQvURHgZ9mJgXChXfrcQNirATKv9pSh5DJ3N/u7viUZo/SYsaUzyEDWX 6GO9UV3+iTEHSXCUh/62uOpGTDMyRZFbjtu+W2RN3MQINXAmkdXClt7AEo3LFCAFA9P6QtFLjrp rrr23a5BkbR9a5Vkdnn81DXGdbcp8sM/NY7GHFsSJX8aoFgc7 X-Received: by 2002:a17:90b:2f85:b0:38e:1497:af5b with SMTP id 98e67ed59e1d1-38e4b3e1015mr3983286a91.1.1784315767273; Fri, 17 Jul 2026 12:16:07 -0700 (PDT) X-Received: by 2002:a17:90b:2f85:b0:38e:1497:af5b with SMTP id 98e67ed59e1d1-38e4b3e1015mr3983261a91.1.1784315766762; Fri, 17 Jul 2026 12:16:06 -0700 (PDT) From: Brian Cain To: qemu-devel@nongnu.org Cc: brian.cain@oss.qualcomm.com, stefanha@redhat.com, Matheus Tavares Bernardino , Pierrick Bouvier Subject: [PULL 09/12] target/hexagon: fix get_phys_addr_debug with in-page offset Date: Fri, 17 Jul 2026 12:15:44 -0700 Message-Id: <20260717191547.920048-10-brian.cain@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260717191547.920048-1-brian.cain@oss.qualcomm.com> References: <20260717191547.920048-1-brian.cain@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: QWRtnRvDTHKETEvH7uv45G0DUdl92Aaf X-Proofpoint-ORIG-GUID: QWRtnRvDTHKETEvH7uv45G0DUdl92Aaf X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE3MDE5NyBTYWx0ZWRfX2Ui6PNiiDwAI I6fMNF3jPMXGACn5VVySkN7BfVmIeW/N3MGb99rOr2hvgfgVKpwP+DgJz0/mTk77fhaRd14wthv axWv61K/OrDKdXANUfGaQZk6kf9O8wZdlLdYtbtne4jovclcmHi9j2H3kraGau/JXYQ0uewbsjL JoKcGsxN3vAALWQ7cYqgwaB4mNr6sRXMulWi+YkYzp5E0AxF4fZe21CU6gm3jbWUC+rLGL6NBf9 2S7ogQnaGcKLMzXM111joovqi8j5ekm3oT2mBvawGrl9SChSIsK+AkXdnsXpBw+sehTSf2nDegu v3cAp2upMdV6vRmAGsvfjLGajosIZfJhdEagAu5Y9NBCTWEECcNGgy5sKN8UatFxpCjwPkWA8Vs 143I3gyixK/k2BIq0mGQikAhZEptvp75I744gJm30FXgKLvP11tnSFpizbNgJw2vJwV43m1ZX8/ KiDu5zLkbutPhZWph5w== X-Authority-Analysis: v=2.4 cv=TaqmcxQh c=1 sm=1 tr=0 ts=6a5a7f78 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=ERpe_kbT2-JOHJ70sIsA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE3MDE5NyBTYWx0ZWRfX9wx7CvZ7yFuQ wgsC7b38hU7s/Ouk9jnqh4/v1qQtK7PUMCr821c+zHvZwSg6sRAcZIQVyWVQeGOFngR3ECUzUvK GBb/gJvHzCM8HFgKHmzENvCW+z/Phk4= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-17_05,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 adultscore=0 spamscore=0 bulkscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607170197 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=brian.cain@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1784315843074158500 From: Matheus Tavares Bernardino As documented: * @get_phys_addr_debug: Callback for obtaining a physical address. * This must be able to handle a non-page-aligned address, and will * return the physical address corresponding to that address. When MMU is enabled, hexagon_cpu_get_phys_addr_debug() returns the physical address page-aligned, not corrected to reflect the exact byte the virtual addr maps to within the page. Let's fix that. The MMU-disabled case is already correct. This would break semihosting argument reads when it is added for Hexagon. Signed-off-by: Matheus Tavares Bernardino Reviewed-by: Brian Cain Reviewed-by: Pierrick Bouvier Signed-off-by: Brian Cain --- target/hexagon/cpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/hexagon/cpu.c b/target/hexagon/cpu.c index e2af736a99d..12d27ce1381 100644 --- a/target/hexagon/cpu.c +++ b/target/hexagon/cpu.c @@ -569,7 +569,9 @@ static hwaddr hexagon_cpu_get_phys_addr_debug(CPUState = *cs, vaddr addr) =20 if (get_physical_address(env, &phys_addr, &prot, &page_size, &excp, addr, 0, mmu_idx)) { + vaddr page_offset =3D addr & (TARGET_PAGE_SIZE - 1); find_qemu_subpage(&addr, &phys_addr, page_size); + phys_addr +=3D hexagon_cpu_mmu_enabled(env) ? page_offset : 0; return phys_addr; } =20 --=20 2.34.1 From nobody Sat Jul 25 13:40:27 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1784315846; cv=none; d=zohomail.com; s=zohoarc; b=bBY2C69rU4INwXOMYw1MOEkmkkcdrDTDvhx9cnRZDi3J4Q9OaxorX2W2vDjSZmnuH5anxn+1fczBWyU25aXr4C8Q5iYFxTuqBXGTJk1omijtPk8vQ3O476qdQgmg3MOeO/u4VQmlwsUbe30+nHM9Dd2enLqrA6I/zlVmzye5MW8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784315846; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=My6IW5fffRJRMezR/GjObKT6jUGTiTD+1poE1sgWj9w=; b=Br9O3i7Z+WtLZBq7xBtQW8/I1OfIBfY0f8lFUmP/HofRkFyP/lp4lF/StgPNZp7gyS8HYlgyJa3zJ0t+FzxH3+6nAY62qt7nQB5wAOSdylTHmTYoezZlMruKj3fz/KRIb+IIRBmxiwyruNcvohlbOU0+Hj8pPBY8pKRbDA6L2h8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784315846444263.0921488397904; Fri, 17 Jul 2026 12:17:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wko2f-0006rR-U3; Fri, 17 Jul 2026 15:16:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wko2e-0006r4-Pz for qemu-devel@nongnu.org; Fri, 17 Jul 2026 15:16:12 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wko2d-00086b-8u for qemu-devel@nongnu.org; Fri, 17 Jul 2026 15:16:12 -0400 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66HGobUm2478561 for ; Fri, 17 Jul 2026 19:16:10 GMT Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ffhpfjb27-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Jul 2026 19:16:10 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-38de842a1a9so7735429a91.3 for ; Fri, 17 Jul 2026 12:16:10 -0700 (PDT) Received: from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31429f9d444sm11602463eec.6.2026.07.17.12.16.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 12:16:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= My6IW5fffRJRMezR/GjObKT6jUGTiTD+1poE1sgWj9w=; b=WrQSoesB2OvACwoa /8ej8hcwPThVqSnyNEYR8tfgV5YPpSUfylhBIgxlW9bWe7cZsWf97+qwXhhMXl+L R0JMFifMgPkwLEt4CBkkQ5Ve7+D4Kxim7Xreld842jmrAoJq1ynxHklxFNTivPJ/ wX0rQM5lIW1wuTBPQMYxo7psyFk/X6MsxPqHDHww2ddQSm9XeSnhOpETl0+dJOuz jqvF24lT8VOiaE/LQtBRpvxnUyacIpv3qfSdNinaRKbfURUPW8U41FET3TwUqkXj SqhZr8cknEhAMhYjxp9nWjpKOxKmbaYZ2YEhZRD23zjqO2cx0br5x8OZ6N/EAcav b6awHQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784315769; x=1784920569; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=My6IW5fffRJRMezR/GjObKT6jUGTiTD+1poE1sgWj9w=; b=gphKpb49WSOuSfoTfM5YsuMDIJHv3+VWyU4t9yY/9R1vD7yVI9bfruNb90IiIkbXt8 qCqjLuFkkLr7/fRNYr/7a35x1Fv+PMCoY08JTxIstat6s4O7JtQR+Bx0lMNwRmfabcWy oi5mrWGHX7fuEK444OF3Q9yWZo0cgoHK8Hgb3mKAnV5pyF1M2ZMnw4FypE5AWe4F0rnm jbGBbUAIMM9ePUsdjPZ5hVm5azKeErtMqohkbZvuJ4qRDObnqTxhBKE/TMvgKasScLPt NahQ4PU9Q3cO9BxNgdv6u+LtNS+1pvP8REwpb71wxxy5CcHfoShu2wfpJ3uA/ySnAxR6 5WrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784315769; x=1784920569; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=My6IW5fffRJRMezR/GjObKT6jUGTiTD+1poE1sgWj9w=; b=GMgsRNLHVGXrnx+PZxL9T6J2Kg6XMOoLU1iRqiFOgl3STB7UUvhtKZZr/CFMgWyj2x Ah2Jh8KTDFpWghmc4OVcXUCnYkCTKRoDXAXz5d1eU/VwCteQVT3og6q81kMPGVJwG2hM T3Vi1opbkNBTMzPU4X7P91zfRD6GxOo1OkQruq7hx5HiaS+fFFF5YqFlz2JhDDqTb4SP rKTxCirtoNBET6rXj/M78Zp2kMEz+4Kpd9bTSLkozTOEZncxuhsznWlj+TDNbtHnMzwe pErEQWfhoO5cZgDPXmeNsjC42B2I/nB9YqI4eqye+AWFHMPdd0DYccgzEyCoNraIT6QN 48fQ== X-Gm-Message-State: AOJu0YyulYRkttfeVjp2sQUDp8aQlPloE0yNTJcFOpyExusNe1OUsrEV pH+VGwCuwDZSG99OweG0GD2eZh8JS96TsqwK+30mQCNes5uq9Z1g4R9uG/dPcuXCkDYbptU3pz5 1L0o7MbZFu91Mt8mfewAdbRsmLozB+DGCsgDVaE6KmFef2sNly/Qs8KkdSpnC1lLqIA== X-Gm-Gg: AfdE7cldRYsjwZSnK1wO6ruT0H+mwNolZc0FNIOeceZXRA8++FTOkvDl5vbJLFQ1Ni7 YjlEirLg2uSOYz58O/+iZfFPewEmVuvoqOoqb4G0pwF4rdzk64cUAV5gooDmWMlVD7f7XsI7/tT OkJ9HJORTYDLyulpA0egN5RpIA63g6uEDeEfIf2wpYepUzfGVXLMAihKGZR+6eQ46LPC/TNAfHG gPafmoxbUEq9OxwZYx0VfZ8mnWSYQ5nOaiGj9a6h/NmW/kfd9K5xzC8NPz6tbAIdYPhnf3jm7b0 AVgXnw7ZUCFaWBIenBalgizO8GIyp12wt+ZAgFFu+X9Gry1Zc7PR0VIz2VN4s78aRaR8xxBlpLA W/5MiZ66CmvqG1LN5I1pp9LjZLGutjKexDwqMzMJ+6lUaeDtX X-Received: by 2002:a17:90b:574c:b0:387:df8f:1401 with SMTP id 98e67ed59e1d1-38e4b57df01mr3910399a91.34.1784315769417; Fri, 17 Jul 2026 12:16:09 -0700 (PDT) X-Received: by 2002:a17:90b:574c:b0:387:df8f:1401 with SMTP id 98e67ed59e1d1-38e4b57df01mr3910351a91.34.1784315768774; Fri, 17 Jul 2026 12:16:08 -0700 (PDT) From: Brian Cain To: qemu-devel@nongnu.org Cc: brian.cain@oss.qualcomm.com, stefanha@redhat.com, Pierrick Bouvier Subject: [PULL 10/12] target/hexagon: initialize deferred sreg-write temps to current value Date: Fri, 17 Jul 2026 12:15:45 -0700 Message-Id: <20260717191547.920048-11-brian.cain@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260717191547.920048-1-brian.cain@oss.qualcomm.com> References: <20260717191547.920048-1-brian.cain@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE3MDE5NyBTYWx0ZWRfX5XUnGQunjCwJ c3AREock/jdNo0i1jWO7n9DGjmPip4GdJSgaxaGeL4I8N95oGkBtPPAkITtrWroH7MmCEX2R9i9 dcHU9najHla0DjjjUjDzM8I57xfGl9VZP9ognDZPhk8hHYa2Lwdm1cjN/0EK0bVL/W3kprtveuw NWGkL6DMwMFHqL1AwdkthwTCGhZrWQ3rLw8bg+YGLPnAc15zDFN8/zYokQdHiZE/FXnMMi1O+i2 2oBpE2a7N3DJz+q9VpnH2arD4EXHI1VFz/vFVUPoTF0NROyE9+ks/jW2Ql4HtomcIUr3y4cR6nI E+7xiGd5s/Hg/+dug+Wlr05Cbl5/rufwVdCluBnxdek64XTALIWnkSzZamTWoCOcPpbthMOVsuy O9zT09md4i8yInatA2pirKXrcGq5hJW9KhbpvCD31APGaLimHY1zegUTnbiqEexnktO3eQYxrfp cxEPOEVZq0ncLRqClkQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE3MDE5NyBTYWx0ZWRfXwYiNBMe5rwJh VuWYO63TwQ6DCgdmTa8DVuxsjiAx/sq44cgHgdnUjte8IAE4mf0MgjnyCX/vlGlM7q9qxskkX0V luwuSD4eMpJClOj5I1Mhmxnoqk84+h4= X-Authority-Analysis: v=2.4 cv=YeWNIQRf c=1 sm=1 tr=0 ts=6a5a7f7a cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=IlOZXNdbeIrMSDKviAkA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-GUID: vP6pZhin4ESS8B6F5QKbt4k9lOy8sQtp X-Proofpoint-ORIG-GUID: vP6pZhin4ESS8B6F5QKbt4k9lOy8sQtp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-17_05,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 suspectscore=0 priorityscore=1501 clxscore=1015 spamscore=0 lowpriorityscore=0 adultscore=0 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607170197 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=brian.cain@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1784315847140158500 Unconditionally allocate and initialize the temp to the sreg's current value for every logged sreg write, rather than only allocating when need_commit is set or the register is SSR. Without this, reading a deferred sreg write within the same packet before it is committed can observe an uninitialized temp instead of the register's pre-packet value. Reviewed-by: Pierrick Bouvier Signed-off-by: Brian Cain --- target/hexagon/translate.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/target/hexagon/translate.c b/target/hexagon/translate.c index 5d54ce8caa4..115b6912553 100644 --- a/target/hexagon/translate.c +++ b/target/hexagon/translate.c @@ -615,9 +615,10 @@ static void gen_start_packet(DisasContext *ctx) } for (i =3D 0; i < ctx->sreg_log_idx; i++) { int reg_num =3D ctx->sreg_log[i]; - if (reg_num < HEX_SREG_GLB_START && - (ctx->need_commit || reg_num =3D=3D HEX_SREG_SSR)) { + if (reg_num < HEX_SREG_GLB_START) { ctx->t_sreg_new_value[reg_num] =3D tcg_temp_new(); + tcg_gen_mov_tl(ctx->t_sreg_new_value[reg_num], + hex_t_sreg[reg_num]); } } for (i =3D 0; i < NUM_GREGS; i++) { --=20 2.34.1 From nobody Sat Jul 25 13:40:27 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1784315833; cv=none; d=zohomail.com; s=zohoarc; b=gk0++MX9RQ8ConpmVOzvor+RykfRQEgNV5VRRnWGwUY7FTOBATElHw9k2lKmDflvdoNId4o63o19OtDHD11Ft+o1JXytPMsFEKZcSiAUQR12xih9zx01UnlPut4ZL9jWOdKKQDjnvACL/umLIxKlL0aKkDxiC9c6LTV0Y6GJXCg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784315833; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=lugjZ1j5nK4olh3ti3ja//BRds5+vAYwEouD5ajmkz0=; b=L0pfda6fLEQs9txM7EdSelUiMKpzpARfLmNW9T4q09qlhV6qSKIbHI64AMYyZ2ksFu13gajrOoN13PCtEfSJu2uCc4KSPOWG51peuEZlhlfE9QVPhtVa9lB2cRExlaeucslsOI9u3Gd2G969HAxmM90PvuM3Y8y5NeT5L9qilzQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784315833499588.0395164891772; Fri, 17 Jul 2026 12:17:13 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wko2t-0006tb-AQ; Fri, 17 Jul 2026 15:16:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wko2r-0006tD-BO for qemu-devel@nongnu.org; Fri, 17 Jul 2026 15:16:25 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wko2p-00086z-H3 for qemu-devel@nongnu.org; Fri, 17 Jul 2026 15:16:25 -0400 Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66HGoD2J2372320 for ; Fri, 17 Jul 2026 19:16:12 GMT Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fff9gu02c-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Jul 2026 19:16:12 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-38e2237bc43so6962646a91.1 for ; Fri, 17 Jul 2026 12:16:12 -0700 (PDT) Received: from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31429f9d444sm11602463eec.6.2026.07.17.12.16.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 12:16:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= lugjZ1j5nK4olh3ti3ja//BRds5+vAYwEouD5ajmkz0=; b=SdF8JzPGS5hrW3xv hD60WKmb0VRMWEUfJcdekmXv7TZnzNZoAjuv08al0YnPNQzfcolmNuuKCEgomshl SC/9y6kzYTTWwLZkGYVjdmoR5tdI05ZRfZr/K3E9/+/RvEQHfsejLr1h0NbRRtaH A4CrGqb3MlIIVjinTr61jX8/xhXgVc6MAq77D7AMyxuPjZOTjoMiNY3qdNrFQBTo wgmR0fzasdKckNm4kwB8h292aO/pLqxk9DSpvu139XI1lyxeJx3uMJSdZJZii35r 31xnB09PLLzou9n/lMze8tggML1ucENdfC1pxMWXggPA0Tc0Z+rWlaT+QZYLG4uk FD8Vvg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784315771; x=1784920571; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=lugjZ1j5nK4olh3ti3ja//BRds5+vAYwEouD5ajmkz0=; b=jcHGXItaTGXq2CYjNbV8Gr5cW2YBe/BGKtdwZ+k0hXhKDTzVdIBaI/aq6elU+BzbfW AF+yVMXf1c4cbhtMik64/R+SlCMOX4rqC8F3wOhvCvgT16OPAuf0I1L5KDdqcQQ5FSha 0G8fyPu2TfcmPx3HIZtO/Ylj8pdtzPplmGsoz/JCcuz/Y//zC0AcXeJf5OxFIW/w1I/4 /FlHaSsaSdCMKUL82ZILHYOY2pw5G+x+7y7P9Fllg/HSC4SRaGz4+N28F4vceTifQjQT CGs0iq0+64yB+6Muzy+yY1JQL4FiZsb9AMj4Qma+nbnbWDwB+LhLcuThHGOtn10k+gAR 6Sbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784315771; x=1784920571; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=lugjZ1j5nK4olh3ti3ja//BRds5+vAYwEouD5ajmkz0=; b=fsxOVorCIa005E9gBSJLJ7qoUFZgtyGf6rk3ebj93FkaIsjPjrolbH+MWkFeGbXtl6 tbdBXjG88Om60FJCQYP/46NuQiVHgZu1iFsGS52wpJi+tbIKvs0n9F7HKADz28NEifDo 2UBfFBJInniLRN2PHLtFIGkIy5Of1xaXCamQpDEYQI1qTju7Mf3jgoEgw2VKxvM26wi1 RVYaiCUAcZpGDGLnMO9U2NA+dF6sBXc3VY06TrI3QE96wxtyy7RuWiooOBTVlhZzcTZF xLvktJN9YTrLzhYKdiw7aS68JjevqymNmF2o8JK/6jsKuIJy7PR8KKfhHgpm5+JaZ+Ft C6tQ== X-Gm-Message-State: AOJu0YzMb5RQzIm5gZRXE2DS/7N1/4rAFbaADWvPBDU2hrV+o3IBFS50 3JTijV+Y+Y3BiVrefqkzyOy7pSIIaN0w6HHGg3+KFJ7XT8EX/LcX8v6vCGICS8ZQ5U3u5Ql9Rra cZM/FYX/R1Ws7IaHuUoURHVIXotHJnagdtyEPtFm1jdT9C4q1NdZFhdlaWwucBhsSmQ== X-Gm-Gg: AfdE7cnlWx8EExETyXIrKAXVAjaBXdPdf5HRqAjNR9R4N45rm6lfwt8a7ArKI1HvjIC sNKqHzQt3Aih2aKrcnx7vVwx+fhomtSSksBh1bRXkpMFZYxqW1jZHx4k2Iz1wqQexkP+Q17J4wt vknAXOro+GBoxaSAA8fJ2vC/D1tEeh4EAsgOFh28oLD8LcAZVrRlxdt6PGoPI7C5iaW7UARdkOg iRyjdsEREput+nEBYyy6w9DvXDMJuxIIgwQEHg8nIFtPGUumpEgwEh2o747cgJo513jauklMHG7 9y0NWFsbHPnM+AZu8u9yJ5/qu/PmGtYBhrfZ9O1x193uARzyNlzv09/qRZvg14X+0tQa1E6bNYq XW62ho5GzRwZU1ELBB2FGjT4FlMVDkMrCRejU5RXQpLr/UGUj X-Received: by 2002:a17:90a:d2cf:b0:38e:4cb:51f with SMTP id 98e67ed59e1d1-38e4b446353mr4041147a91.11.1784315771412; Fri, 17 Jul 2026 12:16:11 -0700 (PDT) X-Received: by 2002:a17:90a:d2cf:b0:38e:4cb:51f with SMTP id 98e67ed59e1d1-38e4b446353mr4041120a91.11.1784315770842; Fri, 17 Jul 2026 12:16:10 -0700 (PDT) From: Brian Cain To: qemu-devel@nongnu.org Cc: brian.cain@oss.qualcomm.com, stefanha@redhat.com, Pierrick Bouvier Subject: [PULL 11/12] target/hexagon: fix PC not advancing for non-COF TB-ending packets Date: Fri, 17 Jul 2026 12:15:46 -0700 Message-Id: <20260717191547.920048-12-brian.cain@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260717191547.920048-1-brian.cain@oss.qualcomm.com> References: <20260717191547.920048-1-brian.cain@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE3MDE5NyBTYWx0ZWRfX6pBbvWF0IW6S VFfm3XWMsc4dHyfGIpjAh/nFdWf4UBQA6uWqBk9tgvCdPNLpY4mD4364XqwyG1wob7t8lkVuV91 mr+pGvteivY2naTFKHBYn/dyqPZBmoY= X-Proofpoint-ORIG-GUID: l51AURoxfrtd-5y6qdwPtVw4YpI0b0MD X-Proofpoint-GUID: l51AURoxfrtd-5y6qdwPtVw4YpI0b0MD X-Authority-Analysis: v=2.4 cv=TaumcxQh c=1 sm=1 tr=0 ts=6a5a7f7c cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=j_Ogrd1p5-rMj9Zg3YEA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE3MDE5NyBTYWx0ZWRfX9i4+h60NfFvW dhb0rPkZ1D3jcRKaGLTfJzWhdQKKCvrSe1kwB8k2TyVSug0tPQTHX1btrw+lPHPLSxc2+04KQ6D 0e30Np3mKSRpzZ6eAiE8O3D9uZhRPm5mJjZK4Y1ckdwGXBZ1uScT//3SlBm3dXINO/fzmRY8oiz 1N+h80uY+orPXEB9DO6Ua08NbZ+tBc0cmXkevG2F3NSVjfyuzFjMs1EXuit9q8BgH/FJpsDxG8o TFBHgOXB2/l/GQZTALnlhFQB5TKMuOuyQuq08omaxvurLk+R0Mzqn9lURiw0ppGEhhuPU692V6p RIiWMa5VvtkEDqyslT3WrbIx2dLYznUgJuw2JGh9h38pTeCKAs2Fwrl4hIUda7Xv24fWw/yB8OO NtKtqAq/p8ktLgINsX17zzz7C53bU+eQ7gk2XICn9Q/oWmxRsJtJX3AMIJhfwdtYzewF39KPSr+ PdJ2WewClIPvTRauKhQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-17_05,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 clxscore=1015 adultscore=0 phishscore=0 spamscore=0 bulkscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607170197 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=brian.cain@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1784315835324158501 Add hex_next_PC, a global mirroring CPUHexagonState::next_PC, and ctx->need_next_pc, so that gen_write_new_pc_addr() can write the branch target through hex_next_PC instead of hex_gpr[HEX_REG_PC] when a later unconditional write of PC is expected. gen_end_tb() then commits hex_next_PC into hex_gpr[HEX_REG_PC] at the end of the packet. Previously, non-COF instructions that still end a TB did not advance the PC, since next_PC's value was never written back into the PC register. Reviewed-by: Pierrick Bouvier Signed-off-by: Brian Cain --- target/hexagon/translate.h | 3 +++ target/hexagon/genptr.c | 14 ++++++++--- target/hexagon/translate.c | 51 ++++++++++++++++++++++++++------------ 3 files changed, 49 insertions(+), 19 deletions(-) diff --git a/target/hexagon/translate.h b/target/hexagon/translate.h index 0a7f37d5842..2fca157553b 100644 --- a/target/hexagon/translate.h +++ b/target/hexagon/translate.h @@ -40,6 +40,7 @@ typedef struct DisasContext { int reg_log_idx; DECLARE_BITMAP(regs_written, TOTAL_PER_THREAD_REGS); DECLARE_BITMAP(predicated_regs, TOTAL_PER_THREAD_REGS); + bool pkt_ends_tb; bool implicit_usr_write; #ifndef CONFIG_USER_ONLY int greg_log[GREG_WRITES_MAX]; @@ -75,6 +76,7 @@ typedef struct DisasContext { DECLARE_BITMAP(insn_qregs_read, NUM_QREGS); bool pre_commit; bool need_commit; + bool need_next_pc; TCGCond branch_cond; target_ulong branch_dest; bool is_tight_loop; @@ -310,6 +312,7 @@ extern TCGv hex_gpr[TOTAL_PER_THREAD_REGS]; extern TCGv hex_pred[NUM_PREGS]; extern TCGv hex_slot_cancelled; extern TCGv hex_new_value_usr; +extern TCGv hex_next_PC; extern TCGv hex_store_addr[STORES_MAX]; extern TCGv_i32 hex_store_width[STORES_MAX]; extern TCGv hex_store_val32[STORES_MAX]; diff --git a/target/hexagon/genptr.c b/target/hexagon/genptr.c index f48a27bc09b..3f310377097 100644 --- a/target/hexagon/genptr.c +++ b/target/hexagon/genptr.c @@ -613,14 +613,22 @@ static void gen_write_new_pc_addr(DisasContext *ctx, = TCGv addr, tcg_gen_brcondi_tl(cond, pred, 1, pred_false); } =20 + /* + * If gen_end_tb() will unconditionally overwrite PC with hex_next_PC + * (because this packet has a predicated COF that may not execute), + * write the branch target there instead of directly into the PC + * global, or the overwrite in gen_end_tb() would clobber it. + */ + TCGv pc_wr =3D ctx->need_next_pc ? hex_next_PC : hex_gpr[HEX_REG_PC]; + if (ctx->pkt.pkt_has_multi_cof) { /* If there are multiple branches in a packet, ignore the second o= ne */ - tcg_gen_movcond_tl(TCG_COND_NE, hex_gpr[HEX_REG_PC], + tcg_gen_movcond_tl(TCG_COND_NE, pc_wr, ctx->branch_taken, tcg_constant_tl(0), - hex_gpr[HEX_REG_PC], addr); + pc_wr, addr); tcg_gen_movi_tl(ctx->branch_taken, 1); } else { - tcg_gen_mov_tl(hex_gpr[HEX_REG_PC], addr); + tcg_gen_mov_tl(pc_wr, addr); } =20 if (cond !=3D TCG_COND_ALWAYS) { diff --git a/target/hexagon/translate.c b/target/hexagon/translate.c index 115b6912553..199b4f8c2ec 100644 --- a/target/hexagon/translate.c +++ b/target/hexagon/translate.c @@ -54,6 +54,7 @@ static const AnalyzeInsn opcode_analyze[XX_LAST_OPCODE] = =3D { TCGv hex_gpr[TOTAL_PER_THREAD_REGS]; TCGv hex_pred[NUM_PREGS]; TCGv hex_slot_cancelled; +TCGv hex_next_PC; TCGv hex_new_value_usr; TCGv hex_store_addr[STORES_MAX]; TCGv_i32 hex_store_width[STORES_MAX]; @@ -184,10 +185,16 @@ static void gen_goto_tb(DisasContext *ctx, unsigned t= b_slot_idx, } } =20 +static bool need_next_PC(DisasContext *ctx); + static void gen_end_tb(DisasContext *ctx) { gen_exec_counters(ctx); =20 + if (ctx->need_next_pc) { + tcg_gen_mov_tl(hex_gpr[HEX_REG_PC], hex_next_PC); + } + if (ctx->branch_cond !=3D TCG_COND_NEVER) { if (ctx->branch_cond !=3D TCG_COND_ALWAYS) { TCGLabel *skip =3D gen_new_label(); @@ -391,17 +398,25 @@ static bool pkt_ends_tb(Packet *pkt) =20 static bool need_next_PC(DisasContext *ctx) { - /* Check for conditional control flow or HW loop end */ - for (int i =3D 0; i < ctx->pkt.num_insns; i++) { - uint16_t opcode =3D ctx->pkt.insn[i].opcode; - if (GET_ATTRIB(opcode, A_CONDEXEC) && GET_ATTRIB(opcode, A_COF)) { - return true; - } - if (GET_ATTRIB(opcode, A_HWLOOP0_END) || - GET_ATTRIB(opcode, A_HWLOOP1_END)) { - return true; + Packet *pkt =3D &ctx->pkt; + if (pkt->pkt_has_cof || ctx->pkt_ends_tb) { + for (int i =3D 0; i < pkt->num_insns; i++) { + uint16_t opcode =3D pkt->insn[i].opcode; + if ((GET_ATTRIB(opcode, A_CONDEXEC) && GET_ATTRIB(opcode, A_CO= F)) || + GET_ATTRIB(opcode, A_HWLOOP0_END) || + GET_ATTRIB(opcode, A_HWLOOP1_END)) { + return true; + } } } + /* + * We end the TB on some instructions that do not change the flow (for + * other reasons). In these cases, we must set pc too, as the insn won= 't + * do it themselves. + */ + if (ctx->pkt_ends_tb && !check_for_attrib(pkt, A_COF)) { + return true; + } return false; } =20 @@ -637,12 +652,14 @@ static void gen_start_packet(DisasContext *ctx) ctx->branch_taken =3D NULL; if (ctx->pkt.pkt_has_cof) { ctx->branch_taken =3D tcg_temp_new(); - if (ctx->pkt.pkt_has_multi_cof) { - tcg_gen_movi_tl(ctx->branch_taken, 0); - } - if (need_next_PC(ctx)) { - tcg_gen_movi_tl(hex_gpr[HEX_REG_PC], next_PC); - } + } + if (ctx->pkt.pkt_has_multi_cof) { + tcg_gen_movi_tl(ctx->branch_taken, 0); + } + ctx->pkt_ends_tb =3D pkt_ends_tb(&ctx->pkt); + ctx->need_next_pc =3D need_next_PC(ctx); + if (ctx->need_next_pc) { + tcg_gen_movi_tl(hex_next_PC, next_PC); } =20 /* Preload the predicated registers into get_result_gpr(ctx, i) */ @@ -1142,7 +1159,7 @@ static void gen_commit_packet(DisasContext *ctx) ctx->pkt.vhist_insn->generate(ctx); } =20 - if (pkt_ends_tb(&ctx->pkt) || ctx->base.is_jmp =3D=3D DISAS_NORETURN) { + if (ctx->pkt_ends_tb || ctx->base.is_jmp =3D=3D DISAS_NORETURN) { gen_end_tb(ctx); } } @@ -1327,6 +1344,8 @@ void hexagon_translate_init(void) } hex_new_value_usr =3D tcg_global_mem_new(tcg_env, offsetof(CPUHexagonState, new_value_usr), "new_value_usr"); + hex_next_PC =3D tcg_global_mem_new(tcg_env, + offsetof(CPUHexagonState, next_PC), "next_PC"); =20 for (i =3D 0; i < NUM_PREGS; i++) { hex_pred[i] =3D tcg_global_mem_new(tcg_env, --=20 2.34.1 From nobody Sat Jul 25 13:40:27 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1784315839; cv=none; d=zohomail.com; s=zohoarc; b=Pagb6SXgDX7AloIIDrf+mJ5oJxcAb+OmSOkT+lzAwA1kzTzYBeMoX2aQfUT1nr8DPn/oJc7yoezr4Ip1pxGJvfEyxhtAhs0o4anjpNQWgOIGibnRxp1dOa6YyfAH9LyeHva2eW0LK6hfEih/brkus8VnujGbmJPW7to4RBdChM0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784315839; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=WUAUQQf5qgHBKQNziG8kgNpwG/tVRFOL0DSOzWaTCb4=; b=mGUHqmcVYHqpNBWvvK53RIu2SNjxR4GF4ouqgB2GhLIUwRYfNFuAz3HBB0f7aL1HcKbxzmhSpPyYX+uumG6ERuZtAhjhaNtLRZKFGY6qPjLCp6cyAbNcbY1cf2zOGyuVLaWVfcQYZHmMGrwo9CmKsvjEe7iE2kdZ36jyj7qAIss= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784315839888319.81772173072943; Fri, 17 Jul 2026 12:17:19 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wko2u-00070M-OP; Fri, 17 Jul 2026 15:16:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wko2t-0006tc-9Y for qemu-devel@nongnu.org; Fri, 17 Jul 2026 15:16:27 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wko2r-000875-K3 for qemu-devel@nongnu.org; Fri, 17 Jul 2026 15:16:27 -0400 Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66HGo6Wt2245131 for ; Fri, 17 Jul 2026 19:16:14 GMT Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fff9pay51-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Jul 2026 19:16:14 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-38dd87656d3so7227980a91.2 for ; Fri, 17 Jul 2026 12:16:14 -0700 (PDT) Received: from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31429f9d444sm11602463eec.6.2026.07.17.12.16.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 12:16:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WUAUQQf5qgHBKQNziG8kgNpwG/tVRFOL0DSOzWaTCb4=; b=Knxgvlvt6Xq+pE81 E2Iq0HW2CywAT+0XqHxYP9NEKQ+xUE58WrolqFT3LvSYTZbd1s2pxwtxYHUCaY2n YtayuNAsN6HraxMPUF8asDfkx36vFqNeBK2lUZobej5EMdzhdEpEDbrfz4d10wN2 z960Iz3eQuhhPXI11DtOKmfviGXjvz1ojR2yU9VQGZEV+u78ZN2tNSeg7bQqFB+n 5qktOfqF9F45JCnlC2gVP8H53OwwC2l2pzznUds0E09dZrPzHN24R6Vy066acrQC V8DA2ZHVqncr7bVOCk8j4pccB7z3HFLHRoCAx+vJ8y23nMZFcl/ITsh4scsUcQeK Vvwz0w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784315773; x=1784920573; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=WUAUQQf5qgHBKQNziG8kgNpwG/tVRFOL0DSOzWaTCb4=; b=kiUjEGMMU3VUPn4RyvQRz1dNEoyhtzmFBdwUd64LHZysYYHw/Z8KcPPCxX/06pi1v8 M0ToSk+QlB6vbE3M/GQsnJl6KdoPQU2fNSJedG8qvDZsQrSAHwzK/TB6QxnLWU+lRaGC Y0B5C3lAsjJhaUTdlvTYTNDQJ3/7YtehRgOqqNRUyax5dlQ81Lu8m+6SjLMTYYK5T+MX jhLZb7mceByu7r5LOIxgwC0GoTC1QPFDJtQOwJabDJTnWv2XvaMnHvNrSMddbz2irJrG izeVLQx722/Mq5ssz+KoLKyRggryOp7FTH7v8pztOLyP90P2NXG9K6QX4R632ICUsoXb +Nvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784315773; x=1784920573; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=WUAUQQf5qgHBKQNziG8kgNpwG/tVRFOL0DSOzWaTCb4=; b=ah+WEns3FsgZ7SbUXgpy9PquRg0vqmRsmbpWDJrlDYRezT8MC3hMNXbWinBkfTb/gR 2roRY+4Zo5WqIM5prcnTpcMWWKV/qVkwX3gKnrT3xS1JxOfYs561wlEyKDo94D8JUzL8 TzhlqCp1f7njraXrEU/DhLdyEQM3BlGyNhXLX/XxaqbVQK14AP6BNM2lt9kBF39Lr47C x/tihTnkGtP/7WYdDREQf9LkSp/rV54DKXVX6km93PESx+06iI3WhXZ/V8hw2hc+obvM Vl9R4ASwPcHkJstKP7PddNjpPdk1DPyj8L7igbl794QrDHNe2Zq01doR0AOge+mbOlQF aJLQ== X-Gm-Message-State: AOJu0YzQtK8KYig0NJ5wDun/inj5ec+saMZ+PKD5FaKAqWUcS6DPaNDN hVckcwEMXOeW/hTdzCAYq/7TFGbgnIPMNHlaT3N13gzlv0op5o5pYa8DpFhqmDgow87xmLddUb8 4ZTucXdEeNabvNPKMfYT1R3Ldtht7DGd/g1++WWjLfoiDMWWwS75hxGCC2Cc3uIx7JA== X-Gm-Gg: AfdE7cm76XcICqwxFvHvenMXCqgXLSGIojjMC7rrrcZ9SFFyzsteescsuN+utBG4MRg rGjnTl3rxOfDxZCe/P3S8vHwz5mmr2rvRrxkeOWKs59/3pgZIfvvz9eKcif0K/HLaqgua2nWaWz ayQE80MmLpV8QW24R5OD3x4KnzE8Viux6yIvXJYT8NX7WvWMNcz7rKQr3HS9UW35KJvYFb2vQpm M383ULW2QJ5mu6GiwBHheew6xho3mVfT+xaDAOgQn/nqIzjlOxQJBNCvz5qsAD0qPpZWL48p4+u YWqx8NrhccZQOM37XFl7VfhOO5nX2pqf9ZyhTUA5spKkgEG+8QWYZT7o7FWHxzP+5QviH8NBaGg EvJ5XblL7R04JLFF6uyq+vTn6roUi/VLglLVxVvLuZjc+y0EN X-Received: by 2002:a17:90b:250f:b0:38e:4b60:e01 with SMTP id 98e67ed59e1d1-38e4b602953mr2850212a91.12.1784315773133; Fri, 17 Jul 2026 12:16:13 -0700 (PDT) X-Received: by 2002:a17:90b:250f:b0:38e:4b60:e01 with SMTP id 98e67ed59e1d1-38e4b602953mr2850177a91.12.1784315772651; Fri, 17 Jul 2026 12:16:12 -0700 (PDT) From: Brian Cain To: qemu-devel@nongnu.org Cc: brian.cain@oss.qualcomm.com, stefanha@redhat.com, Pierrick Bouvier , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PULL 12/12] tests/functional/hexagon: add arch_tests functional test Date: Fri, 17 Jul 2026 12:15:47 -0700 Message-Id: <20260717191547.920048-13-brian.cain@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260717191547.920048-1-brian.cain@oss.qualcomm.com> References: <20260717191547.920048-1-brian.cain@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: I2IGykUbxc_51efvUnJY79KLSTPFux-r X-Proofpoint-ORIG-GUID: I2IGykUbxc_51efvUnJY79KLSTPFux-r X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE3MDE5NyBTYWx0ZWRfX5yNfkbgnhmbf eJ6eNnh7l6+KTl1DoTSubkYHtf9XXavLxRYBNFQuWdVxIM0W9335KNUZNU6674BwHzEbUSLTHZN DoiYJPflahYtOq3re4wcmxR64rBeMfzBr1kHd5Yf136r9ogUpV7iDONP9ewE5daQ09C9pBfT7qu bfwnDSAuhjHcJlPNjx92CGZE08AxCghi9VPFL/C0RO8HZRf3rW+gpWy0SwdbzV68HFQJhjonQLt 8DjQF79efKywVsejMiFccKnZGfmwabDMo5XK1NlgPWRJREZ19pvIycVidpfVlYRBZxWW70ls/TC JP4JLThcHtLptP22nIrLB5XN8ztYPazjjv802GfUlZrAXIUmgjhE8XpsTuts1D3EOCyaF1HbwrT B00XHoO9/E7GLO362apr6h87609lJldE4dz+dEJVFAG0APu+PZv5kn8/xrswnQ7kBThzOvVi5i6 kx9llAalTs02HTv9Y0g== X-Authority-Analysis: v=2.4 cv=TaqmcxQh c=1 sm=1 tr=0 ts=6a5a7f7e cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=5vFef2XoAAAA:20 a=EUspDBNiAAAA:8 a=kSmQlivvWz0e5I5yAQ8A:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 a=bA3UWDv6hWIuX7UZL3qL:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE3MDE5NyBTYWx0ZWRfX/SpVKA+meuF/ F4ybATgsAK/rIlBJP5gd9D+v4/pUsdVGCGxLHqPIvVyc5WzyHlgbxoyQqEgDfw+pzXJvrwuhhja ZiZZb57qm9wJHEm4vIas/OghNqw6aSo= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-17_05,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 adultscore=0 spamscore=0 bulkscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607170197 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=brian.cain@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1784315841298158500 Add new test cases from hexagon-arch-tests to exercise exceptions, guest mode. Reviewed-by: Pierrick Bouvier Signed-off-by: Brian Cain --- MAINTAINERS | 1 + tests/functional/hexagon/meson.build | 5 ++ tests/functional/hexagon/test_arch_tests.py | 57 +++++++++++++++++++++ tests/functional/meson.build | 1 + 4 files changed, 64 insertions(+) create mode 100644 tests/functional/hexagon/meson.build create mode 100755 tests/functional/hexagon/test_arch_tests.py diff --git a/MAINTAINERS b/MAINTAINERS index ec56e5c5577..74fc43f5f20 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1357,6 +1357,7 @@ F: hw/hexagon/ F: include/hw/hexagon/ F: configs/devices/hexagon-softmmu/default.mak F: docs/system/hexagon/ +F: tests/functional/hexagon/ F: docs/devel/hexagon-sys.rst =20 LoongArch Machines diff --git a/tests/functional/hexagon/meson.build b/tests/functional/hexago= n/meson.build new file mode 100644 index 00000000000..2b5a1a8f264 --- /dev/null +++ b/tests/functional/hexagon/meson.build @@ -0,0 +1,5 @@ +# SPDX-License-Identifier: GPL-2.0-or-later + +tests_hexagon_system_thorough =3D [ + 'arch_tests', +] diff --git a/tests/functional/hexagon/test_arch_tests.py b/tests/functional= /hexagon/test_arch_tests.py new file mode 100755 index 00000000000..54a1412c597 --- /dev/null +++ b/tests/functional/hexagon/test_arch_tests.py @@ -0,0 +1,57 @@ +#!/usr/bin/env python3 +# +# Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. +# +# SPDX-License-Identifier: GPL-2.0-or-later + +from qemu_test import QemuSystemTest, Asset +from qemu_test.cmd import wait_for_console_pattern + + +class ArchTestsUart(QemuSystemTest): + """ + Hexagon architecture verification tests + + These are bare-metal tests from hexagon-arch-tests that exercise + system functionality. + + Tests output results via UART. + """ + timeout =3D 60 + + ASSET_TARBALL =3D Asset( + "https://github.com/qualcomm/qemu-hexagon-testing/releases/" + "download/v0.2.5/arch_tests_uart.tar.gz", + "edb4f37b877a3a72a0e10920477458a43b40045d34398fee8cb763fefd342f4f", + ) + + def run_uart_test(self, test_name: str, + machine: str =3D "virt") -> None: + """ + Run an arch test binary and verify PASS via UART console output. + """ + self.set_machine(machine) + self.archive_extract(self.ASSET_TARBALL) + target_bin =3D self.scratch_file('arch_tests_uart_package', + 'bin', test_name) + self.vm.set_console() + self.set_vm_arg("-display", "none") + self.set_vm_arg("-kernel", target_bin) + self.vm.launch() + wait_for_console_pattern(self, "PASS") + + def test_exceptions(self) -> None: + """Tests exception delivery for trap instructions, privilege + violations, and verifies SSR cause codes and ELR values. + """ + self.run_uart_test("test_exceptions") + + def test_guest_mode(self) -> None: + """Tests guest mode entry/exit via CCR configuration, verifying + GSR fields, GELR, and guest event vector table dispatch. + """ + self.run_uart_test("test_guest_mode") + + +if __name__ =3D=3D "__main__": + QemuSystemTest.main() diff --git a/tests/functional/meson.build b/tests/functional/meson.build index c158197c4b7..c7362dd00ef 100644 --- a/tests/functional/meson.build +++ b/tests/functional/meson.build @@ -14,6 +14,7 @@ subdir('aarch64') subdir('alpha') subdir('arm') subdir('avr') +subdir('hexagon') subdir('hppa') subdir('i386') subdir('loongarch64') --=20 2.34.1