From nobody Sat Jul 25 14:40:04 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1784277208; cv=none; d=zohomail.com; s=zohoarc; b=ZmDrsPbtl7W6rcdS6+1hAgLM6hlkHnTjFE7U3neivZOiIxDeUzH/nzuIZfHJyCDADKNx7FtGxirUZQyRYGRbSKPNC5laFjMqJ8uxpMjjAF28ZxXz/ALPobbC/ZpyqxDxBptJ+OqNHi+WG534JS071nMnnCCCE6FlnbjwJkdlN40= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784277208; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=PLxR5/zdjkUO27N60gXOi9bDuitb3Ij55GO3qVURNp8=; b=K8ffEXGNaORSnfQdxuQhxPEnlNxJd1i58QRxq1Jzq2g+7niZmFCwlpNMTSmJ9hE71/rvp+Bsj1tumQC8y6C6V/oHY+F2na1qTWGeyGwFQRO7gObN0rJvtr8LqfTSjKFqNrg9gfy4YxifoPnSchNByFOVv5aTIvzayOkMM7Mri88= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784277208893525.7167677342753; Fri, 17 Jul 2026 01:33:28 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wkdzo-0006WW-V8; Fri, 17 Jul 2026 04:32:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wkdzk-0006W6-CI for qemu-devel@nongnu.org; Fri, 17 Jul 2026 04:32:33 -0400 Received: from mail-pj2-x04.google.com ([2607:f8b0:4864:39::4]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wkdzi-000277-7M for qemu-devel@nongnu.org; Fri, 17 Jul 2026 04:32:32 -0400 Received: by mail-pj2-x04.google.com with SMTP id d9443c01a7336-2cabfb70501so24553885ad.1 for ; Fri, 17 Jul 2026 01:32:29 -0700 (PDT) Received: from VM-210-252-ubuntu.. ([14.22.11.167]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84c2af9e922sm584026b3a.54.2026.07.17.01.32.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 01:32:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784277148; x=1784881948; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=PLxR5/zdjkUO27N60gXOi9bDuitb3Ij55GO3qVURNp8=; b=B3GZoBiMQYcd5RbsKzf+NCSN+So5qCkoDNLFcwyM4sFwRD6YgTZlWlv+OUk3IGL9T3 Wmm7cI+f6nVlF04JL7N97/X895JHCp8vq7d3SQWkGRfpYL1ZSsy7CeL63WmTr5iQODKm hNAWATHkebnr35mQM7npCYsc7QHwqm4gpz3FXSIJnlVfUY+qJwsHUr3NIXjlKtJxZOIP r4CM59zYwWF935kisBRlai0mTjfmpjl0U0ZsQq0pC0cwvdnhcS/4ZPgO9qT0Xcw3IOKL wTzvAnSGX09btHF4gY1asefqMy/z0o2f1KjUHFpnal6P5D8pXFCaJZeJSVpUWHmiQVhZ 4igg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784277148; x=1784881948; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=PLxR5/zdjkUO27N60gXOi9bDuitb3Ij55GO3qVURNp8=; b=s683Je6wZMJDlmndilLxWVEUHjfPwzOfLhQVK1C9tlNy+HOpfHMTJKSQmMLgVocIlt KWanty3tsEYxYDWRkL8ainQma6tUhV7T9mrLXwejb45lu6csvO4rkIJN+ShPmwcGxXs9 CI8AhCQWRrtM31jKDt2Rgv3CzayOnC1z/vkw8tyYpo5wT8wEuB2V0sr3rgrtKOAKnLSc pdW4jKDGQz1ipdwURKJRRnPIgv7HVgaGYxk+DTomQiQEQN1shoxzAzyHbdd6oSg60tIA bg1t/TjuoT1pm9/xH2Omeu2HGDDtoPJXs9BOPOAgVAwQw4AAmhOnKhPPCctE8lnkTWIV PFLg== X-Gm-Message-State: AOJu0YyTyiWgA3QQPddO2OdGm6btudu6OQnuIyXnIIRLSjpSACV0yFdz 4OONawkEewe6FUiI6993UdNRv8T8n3+sDi0YCoLKX4N8OYgPByqxUrKjOmi+gHFjIQQolDtf X-Gm-Gg: AfdE7cmi8sHKK5UCllVrMqsisx+DLlgYUy/GrS7Q0+JsvUBeYKrhRcimfwTGtjwEs54 CrqolpfqehEMbq3yPrSctA1FD7J1Q7wtdzaPHBxa6ADeoGH6MvwpgG4R80IepWa1ww7Nfyc+bwU jFAUD+5eL62hgqpfaSl1jOjHUjZ/t7z9+Cu7RQ0nvtTy6LgANvw9Bt82UrnzZvNYjrZg0wqsiWO lIeilWyG4TdZauk6oKoNKGmONQXEPXwNb3q1EonnreFqqkXcJq8PsTrJPJz0Czqwc4KFe5HbqST NErUqh03B26BYpcu/BJMjOfu3qUzLDr6/oHbVDEaAHbMs6JEE+ojtsmXngjY94WiGMdwijHMiVO A5easHgtVS8W0bWPr2C56KiUg196uKNXhhc0ykaIzVA8vol+Rl3xVo6+5f54AaN9qhwUM0mhp/S MKBKmpnb9yJ6Gw71T4+msat8+UCp244cckfRlOQPnHHW3CvdqhIp4dYX/k1qIH/hckMudMvk/qh sqzlI59CYKuZ/Upj1qEDIvSgYnT X-Received: by 2002:a05:6a00:190e:b0:82f:2b0:2809 with SMTP id d2e1a72fcca58-84c29305388mr1703593b3a.1.1784277148483; Fri, 17 Jul 2026 01:32:28 -0700 (PDT) From: jianghaotian.sunday@gmail.com To: qemu-devel@nongnu.org Cc: mst@redhat.com, alex.bennee@linaro.org, odaki@rsg.ci.i.u-tokyo.ac.jp, dmitry.osipenko@collabora.com, qemu-stable@nongnu.org, Haotian Jiang Subject: [PATCH] virtio-gpu: fix NULL deref in rutabaga set_scanout Date: Fri, 17 Jul 2026 16:32:08 +0800 Message-Id: <20260717083208.291036-1-jianghaotian.sunday@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:39::4; envelope-from=jianghaotian.sunday@gmail.com; helo=mail-pj2-x04.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1784277209762158501 Content-Type: text/plain; charset="utf-8" From: Haotian Jiang rutabaga_cmd_set_scanout() checks scanout_id < VIRTIO_GPU_MAX_SCANOUTS (16), but does not check scanout_id < conf.max_outputs like the base class (virtio-gpu.c) and virgl backend (virtio-gpu-virgl.c) do. With the default max_outputs=3D1, virtio_gpu_base_device_realize only initializes scanout[0].con. A guest submitting SET_SCANOUT with scanout_id >=3D 1 takes the con=3DNULL path, and qemu_console_set_surface(NULL, NULL) dereferences con->ds, crashing QEMU. Add the same max_outputs check used by the base class and virgl backend. Fixes: 1dcc6adbc1 ("gfxstream + rutabaga: add initial support for gfxstream= ") Reported-by: Haotian Jiang of Tencent Security (Yunding Lab) Signed-off-by: Haotian Jiang Cc: qemu-stable@nongnu.org --- hw/display/virtio-gpu-rutabaga.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/hw/display/virtio-gpu-rutabaga.c b/hw/display/virtio-gpu-rutab= aga.c index 6ff1263901..24386487ba 100644 --- a/hw/display/virtio-gpu-rutabaga.c +++ b/hw/display/virtio-gpu-rutabaga.c @@ -303,6 +303,14 @@ rutabaga_cmd_set_scanout(VirtIOGPU *g, struct virtio_g= pu_ctrl_command *cmd) ss.r.width, ss.r.height, ss.r.x, ss.r= .y); =20 CHECK(ss.scanout_id < VIRTIO_GPU_MAX_SCANOUTS, cmd); + + if (ss.scanout_id >=3D vb->conf.max_outputs) { + qemu_log_mask(LOG_GUEST_ERROR, "%s: illegal scanout id specified %= d", + __func__, ss.scanout_id); + cmd->error =3D VIRTIO_GPU_RESP_ERR_INVALID_SCANOUT_ID; + return; + } + scanout =3D &vb->scanout[ss.scanout_id]; =20 if (ss.resource_id =3D=3D 0) { --=20 2.34.1