From nobody Sat Jul 25 15:17:43 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1784252911; cv=pass; d=zohomail.com; s=zohoarc; b=eDv03ngCjsnyxix9Rlkz4E6LrePjAEV9UKS6qyNloDiyKFMiR2d89+li6MApyih1Cv/RgZi+ZSMqb6ACXGRszaBjXKhUeRSTbwfrx+7xeqX8YjttI73aL6hHC/1byicxA9yxSA0VWdr0v18xnzkLHPVX14HaY/+RfH3NJsHAjvM= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784252911; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=3gFhdE37jxGY0F0zgQQWydIf9nlbeKqplrQErJc8RlQ=; b=BZIS+zBU92tfwjYBptOeGXDeZqvvyb/WZKwQvAi5FE+Wxv8Vd/wt0Qx/WWK9jiVBLBZi6U3NC9IAgxOeX3cBn4etmher6bUgxJZWnLZg1QqQNvMYD67cCMUFdpDPnZtbkcHf6GrpxqIE/1HI6gPh/x3dASQHif7igMa2PvH2NhU= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784252911061105.74164932435303; Thu, 16 Jul 2026 18:48:31 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wkXfa-00061S-M6; Thu, 16 Jul 2026 21:47:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wkXfZ-000619-AJ; Thu, 16 Jul 2026 21:47:17 -0400 Received: from mail-japaneastazlp170130007.outbound.protection.outlook.com ([2a01:111:f403:c405::7] helo=TYDPR03CU002.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wkXfX-0001j6-Kg; Thu, 16 Jul 2026 21:47:17 -0400 Received: from TYZPR06MB4980.apcprd06.prod.outlook.com (2603:1096:400:1cc::10) by KUYPR06MB9015.apcprd06.prod.outlook.com (2603:1096:d10:74::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.12; Fri, 17 Jul 2026 01:47:03 +0000 Received: from TYZPR06MB4980.apcprd06.prod.outlook.com ([fe80::ea8a:7cb7:4822:2fb3]) by TYZPR06MB4980.apcprd06.prod.outlook.com ([fe80::ea8a:7cb7:4822:2fb3%6]) with mapi id 15.21.0223.011; Fri, 17 Jul 2026 01:47:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dQYmaAyl7W+WKnep3/3l9Eh7kJaQumt3IFoqQCTHz0uf00K49h/7fFk3kAMOae5CX7xx2+HeO0Xd8SujVF96ch1YKKoPJ8Y/aTM70v/3IauHvlCAXqVX8G+bo/g9/S2yfQAtFU/InK7B0hxI1biHRm5pq2McjQmx3a11qeuvI507cI7e1QmVfXI93GQpNpCbSM5yVcrqq1lETvFdhPJGaRjniMn8NfhwwuXlu8NY9Dff1gXNtuDg6FlIjGoDGBIE800lLoDTebGSWoYlsl0gy2Hs12reb8Bw54ydptHVeeXCh1cS/yR3pa7GryKf2g3EnLydAZzOPk7vpmlPBT6fCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3gFhdE37jxGY0F0zgQQWydIf9nlbeKqplrQErJc8RlQ=; b=yienp8DOYO4qsdH97DdCWfWBXhHIG3UQXhSjPYNjGqe5i0Kz40G0mAIYlQ3ubSqwNYvWWa8/67sBGAFczxYStTy15r664fmb8QGvlRhooF9V4R3zYaM3T9XVbOYZWpe8WRZHAXogFE2wqtlRpeI8WDDrQRdz5BdE9RPC//v4Oc97LkI7pG8DFvsPBcFyav1FEEuc0gRHxZTYxC+BR6RDfJ6n0AWfJ2ALBzrX1bTOGtJ/9l3bn5DIrjToaz4oNuxB7qbiKU5iTSZi76sOuiOepJikYOjwL1SaMMD83BzBN8llSbHs/meU1wq3KNxcsuDglv0Ojpw1BkKjCzd0frWh/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3gFhdE37jxGY0F0zgQQWydIf9nlbeKqplrQErJc8RlQ=; b=V0zNcBNxzF3Dnl4X8ekvYS2eqf1X/2AkqcsU3shkaaUOfEdb1GcN4JwHg+dr0KzRvP3BARR/9sEPA4jtikZiTa2nUTLShU7Fs1PL4bv2oCL7Nq1SepnF2/7YOc9fAZgBnG5xCGAedKiFycxXBk2NaSLghh9MpkNEcDMz2FwzR/K84VvheTGiTSUrXh5NqAxxUI2xZMulxrCMn0MSkyxIjAv/ScaXrCqPjW3HVwS4NebQhZ4OTzQrYCTxOEVIknVHCxPNnTYP26qJq2VR+whoZ8oHW3jKs3V0HopnG2reftFC/jOq7BsiWj2apZiZEERzBJqQeuHg2QIeYm3Wp8Mz1w== From: Jamin Lin To: Alistair Francis , =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , Fabiano Rosas , Laurent Vivier , Paolo Bonzini , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee Subject: [PATCH v1 1/3] tests/qtest/ast2700-smc-test: Add Data FIFO mode test Thread-Topic: [PATCH v1 1/3] tests/qtest/ast2700-smc-test: Add Data FIFO mode test Thread-Index: AQHdFY4q0yXGjpzV00CALja7dvFrpg== Date: Fri, 17 Jul 2026 01:47:03 +0000 Message-ID: <20260717014701.1683876-2-jamin_lin@aspeedtech.com> References: <20260717014701.1683876-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260717014701.1683876-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYZPR06MB4980:EE_|KUYPR06MB9015:EE_ x-ms-office365-filtering-correlation-id: cd8014d7-77b5-41aa-a1e0-08dee3a54d03 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|7416014|376014|366016|23010399003|1800799024|10067099003|921020|38070700021|56012099006|5023799004|3023799007|22082099003|18002099003; x-microsoft-antispam-message-info: lnZrWtBpf+yvMZb2m8FM/TrMR0RY4RejwM0f14MwILJg1V5X9koKUnVanHBhOR8h/JWoHnBVzeMqqScvxhN+uttSeRGBxPBDCV/ljWMKmQcLRIx7wn4uQEikHWqZVgwt+kvn9nrFfgyQRu0cSDppLudXS4vrV9R08xpgdiuI0T63IdTwQR+DbJ023zqzJIXukTxj5zNSjQOD+BkNzmc5G97+2f/3PKCU9XNgD5tZcZ9De9WnegqFdmKZKkbB7l4msrRY5PVuImXcm20rfFni/6lnRUD1Ge15EIZSPfefzqKVAQmN42rBLdLTeuqhpgd5fZaJx92jupTte1GWdsW0hltjCwv1c4govh3AMZ+5i8jH2pn3ry6oGJmZkevqjRluClCSfXCUCAJy2D5FNgKmWzYuRnXysakefuZjaev9cITh79yjl9bi5aEipHg8j9Vct13ZrK542FWvTsk+ZVdIvbzO33ydhFfzj92zbSWNbyOYugbtCpEpPzlAeEuxD1Yq9Lo15cqdF2646JamViLJZ+p1uNCqSqtYaPfezzCyQ7DNJhU/U1D7pfC6YLGYDoVe6iNchYOEGc4wPiAFtu34+OFFuT8nwPYLfchxKcKTY5fihBjPkrrAR9y5ap6uP6q6yPHmSXaiwjHTzNRsqPhhnEwtrCrNFBL2Q3DuTlnjT20RvbaX1C/Nb2S3VwX+k8xfElMioWfZpWeyoAgDSVAuyuVLwo9533cXNrQm9IXEdS3Wlp5WLvwedQ4iyOvw6uoX x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYZPR06MB4980.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(7416014)(376014)(366016)(23010399003)(1800799024)(10067099003)(921020)(38070700021)(56012099006)(5023799004)(3023799007)(22082099003)(18002099003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?KANrDSaamsUHBeRFc1zOJ1QnA3h7kyZ3oKjLI6qh3DEaLtQuip9gxoBX9o?= =?iso-8859-1?Q?leQwjPKFEgQHR8GUCUx52zVo6norp2Tm8hOQqPoGi3lwfyWNOxpp02L0xY?= =?iso-8859-1?Q?4CsUah0t2t6Hkw7UfwOV+b9qeBSkP7EnepacXUtM5l7ZIP4zIu3tdcGYmt?= =?iso-8859-1?Q?URQJjZ0SCy7kuV/ZfWV63e8gmUkSFbjF44vkSYyUY6DpW5l164Vld/QNdN?= =?iso-8859-1?Q?kfu4S8sOmzQZlf+t8T+6PLcPp3C3wyEifwYi9E6iVBZHowJ+0oYTdQRIWZ?= =?iso-8859-1?Q?Dv97YgbyEuStbmoy3eDji3AEiH1pqiKyE11a0uDc7xao/rO++AqP5L6bSy?= =?iso-8859-1?Q?iH50h0yehtzbqOtRSk+kC5NHLU25UioqXdUeKjihmKRaPvVFhNH/HFCXTs?= =?iso-8859-1?Q?eVFbgHnJ6zW4e+MiWc6vUQiv+qpxk6sFnI0v9Egn3YpX0R7P6Q1kjOhBNC?= =?iso-8859-1?Q?evgGLnkapCibXOOErwjzOWS1opXE1hKg5aXXTCadkkZ9WbOtpP+BVjtxeE?= =?iso-8859-1?Q?EK0NOGE5t7wTjTPQ1s4vFcd3ozJBfNwmuHvEHG1U99FxYpbvsg5vxRHLww?= =?iso-8859-1?Q?Z9p0RydHqtQYOxBxFAz+gPynVAaY9Omu+X1BM9zdEQkleJSMZNCo7Wh5MC?= =?iso-8859-1?Q?XtVI1H9bCqnq7gkNOr9UX+SkmWw1U9Zjjeef0GX9vJZlxCZRVI5zKq4cFx?= =?iso-8859-1?Q?fi7Ef71obhcSyZ5HmjFuN3A+fl9K9vhvWxy/9q3aNvvXRCXHXtCoyFJtra?= =?iso-8859-1?Q?5FKYDDlH/bggT+pph/GmyYiAHZLtYJeR/YWAMagGCTtZciUlfh3/zEWNax?= =?iso-8859-1?Q?LcU3tiY4eWa0jKtqCLsqt+I7UzT2VqM66V6vTdfF2jBoNapjRiwL82v1uQ?= =?iso-8859-1?Q?hltbDQzEmpZXcqcoCxg5I2mvNXKL43kFkPuejifGFHyu7wwv3Zy2JzGJjP?= =?iso-8859-1?Q?0WfZ36CzWJlrHQEETgxNluOldW7sKktFlTdEqZ2/CVYjwIunZWDIdAu0gG?= =?iso-8859-1?Q?0UQ+EpMuBe9i05CrZipPBwrmyWwr6Kg8PSXZw+b4+gMBF4xVaCQ+K8kaop?= =?iso-8859-1?Q?icYUh7XEK6UVYaYlmWGY5ACtMJ/QorEZvuqcCTON2bxI9kbTbKgm9LmpbG?= =?iso-8859-1?Q?lOCIf9SU4ae4EbOovRXc0JyinlIgCW8NszBd6j6/dERm4RrGYh4mlBeqrp?= =?iso-8859-1?Q?rWuBeFuPRL1W+in/a+34Nw1ruBiatqeuzD264scqi9kPvv1HdX5K4rfmhj?= =?iso-8859-1?Q?PjQwx0r+vpnfpOA27MJPxwKyvwtPwWB54riyTwgBMVAvst3gov+BvE8ZQn?= =?iso-8859-1?Q?mMpTcbU4wNQhUNINnyE1sIJZGlU4uUdtnGsYLLuzrimhOMkj66SD8xmy/q?= =?iso-8859-1?Q?mZNYRu6MBfB0+eIG9aGYtT0zrU1MVos5dq7ocgsr4K6/L7N5Ic9lu7AXAq?= =?iso-8859-1?Q?dyjSFJDjkwALBbS0CT9jEqUTCrKCArdKcA6FB1M7p7oAMaAMeQ8eYBzEjk?= =?iso-8859-1?Q?4x+GoDxwN82Pa5uMaRjb/7U6e1KhUvf5JpANe+C53H/bX3WZ3dTH0luxpH?= =?iso-8859-1?Q?SczQeiyY4Oe+wHoJpl1MPD6ytTvkKeohl3zUxGJEaxml1AS6a34zfcplhu?= =?iso-8859-1?Q?30/uNcFkitW2t0XZ/hD1zPelNSieYpMZu+Y6x9bDPxQaFjppFN1Dyn52rc?= =?iso-8859-1?Q?Re6thJLP9J4R1QCSwu9HcfP8QiB1KcVZgADyKKuHI7S7uJ695VwRrq1Iu2?= =?iso-8859-1?Q?AM3qpUTAE+LWfv4WqSewNnr8SJCwmnqsx2AZK13m/y2qZiHoecFFj17QHe?= =?iso-8859-1?Q?j9ouXpIp5A=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: L/tZvlFL3YWiAdY+0jAlYz4Dxq6WPNl7sYiNCiwMmBUGQlPPR4rzvGavokYHVVGQZJU4GE0bNcdSZsqA9hfdxgOlY4wbcDrz13Wk4Lf5TvC0bFClaJbGE/5KU1/pM90TQ7D3PSusX5qHq09NoWBezUKc193tbHfbI22vg8T+sOJrUsQhyokomCO5BrB+90gYkCdGruPjvlsR8QgzRM8AF0IHa7SRZz4+W3utyJcVTyZrVgaNlkHeAifotTQ1xF/Ekev1mZlujcF7PWh2MgsNa9etZtjKXN+3TJIJQgNwyOFyOYK097Z6O8O7Nh7Q5ytur40EeIvFvy4NP8dXhRkLig== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4980.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cd8014d7-77b5-41aa-a1e0-08dee3a54d03 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jul 2026 01:47:03.3820 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IZ9ke/39E8mIHlS3eBQNXKFf9+O/Fr1NUtip0w9G0A17S3xUHGQ+U5pd8LShXnAs9+/1Fb8YXADKIjcmjgeH/FXNuoUw/5B/RyURVRTlpBY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: KUYPR06MB9015 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c405::7; envelope-from=jamin_lin@aspeedtech.com; helo=TYDPR03CU002.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1784252914433158500 Content-Type: text/plain; charset="utf-8" Add two qtest cases exercising the new AST2700 Data FIFO-based flash access path (R_DATA_FIFO at spi_base + 0x200). Write_page_datafifo sends the page-program command and data through the FIFO port, then verifies the result via the regular read path. Read_page_datafifo writes a page the regular way, then reads it back through the FIFO port, so both directions are checked independently. Signed-off-by: Jamin Lin --- tests/qtest/aspeed-smc-utils.h | 4 ++ tests/qtest/aspeed-smc-utils.c | 102 +++++++++++++++++++++++++++++++++ tests/qtest/ast2700-smc-test.c | 4 ++ 3 files changed, 110 insertions(+) diff --git a/tests/qtest/aspeed-smc-utils.h b/tests/qtest/aspeed-smc-utils.h index e2fd8ff1bd..485cb92ede 100644 --- a/tests/qtest/aspeed-smc-utils.h +++ b/tests/qtest/aspeed-smc-utils.h @@ -45,6 +45,8 @@ #define CTRL_WRITEMODE 0x2 #define CTRL_USERMODE 0x3 #define SR_WEL BIT(1) +/* Data fifo */ +#define R_DATA_FIFO 0x200 =20 /* * Flash commands @@ -90,5 +92,7 @@ void aspeed_smc_test_status_reg_write_protection(const vo= id *data); void aspeed_smc_test_write_block_protect(const void *data); void aspeed_smc_test_write_block_protect_bottom_bit(const void *data); void aspeed_smc_test_write_page_qpi(const void *data); +void aspeed_smc_test_write_page_datafifo(const void *data); +void aspeed_smc_test_read_page_datafifo(const void *data); =20 #endif /* TESTS_ASPEED_SMC_UTILS_H */ diff --git a/tests/qtest/aspeed-smc-utils.c b/tests/qtest/aspeed-smc-utils.c index c27d09e767..a1be4e02f8 100644 --- a/tests/qtest/aspeed-smc-utils.c +++ b/tests/qtest/aspeed-smc-utils.c @@ -73,6 +73,28 @@ static inline uint32_t flash_readl(const AspeedSMCTestDa= ta *data, return qtest_readl(data->s, data->flash_base + offset); } =20 +/* + * Data FIFO port, in spi_base's register bank (not flash_base). Accesses + * through the FIFO require the complete user-mode transaction (opcode, + * address, and data). Assumes CS0, whose FIFO slot is at R_DATA_FIFO. + */ +static inline void datafifo_writeb(const AspeedSMCTestData *data, + uint8_t value) +{ + qtest_writeb(data->s, data->spi_base + R_DATA_FIFO, value); +} + +static inline void datafifo_writel(const AspeedSMCTestData *data, + uint32_t value) +{ + spi_writel(data, R_DATA_FIFO, value); +} + +static inline uint32_t datafifo_readl(const AspeedSMCTestData *data) +{ + return spi_readl(data, R_DATA_FIFO); +} + static void spi_conf(const AspeedSMCTestData *data, uint32_t value) { uint32_t conf =3D spi_readl(data, R_CONF); @@ -684,3 +706,83 @@ void aspeed_smc_test_write_page_qpi(const void *data) flash_reset(test_data); } =20 +void aspeed_smc_test_write_page_datafifo(const void *data) +{ + const AspeedSMCTestData *test_data =3D (const AspeedSMCTestData *)data; + uint32_t my_page_addr =3D test_data->page_addr; + uint32_t some_page_addr =3D my_page_addr + FLASH_PAGE_SIZE; + uint32_t page[FLASH_PAGE_SIZE / 4]; + int i; + + spi_conf(test_data, 1 << (CONF_ENABLE_W0 + test_data->cs)); + + /* + * Send the complete user-mode transaction (opcode, address, data) + * through the Data FIFO port. + */ + spi_ctrl_start_user(test_data); + datafifo_writeb(test_data, EN_4BYTE_ADDR); + datafifo_writeb(test_data, WREN); + datafifo_writeb(test_data, PP); + datafifo_writel(test_data, make_be32(my_page_addr)); + + for (i =3D 0; i < FLASH_PAGE_SIZE / 4; i++) { + datafifo_writel(test_data, make_be32(my_page_addr + i * 4)); + } + spi_ctrl_stop_user(test_data); + + /* Check what was written, using the regular read path */ + read_page(test_data, my_page_addr, page); + for (i =3D 0; i < FLASH_PAGE_SIZE / 4; i++) { + g_assert_cmphex(page[i], =3D=3D, my_page_addr + i * 4); + } + + /* Check some other page. It should be full of 0xff */ + read_page(test_data, some_page_addr, page); + for (i =3D 0; i < FLASH_PAGE_SIZE / 4; i++) { + g_assert_cmphex(page[i], =3D=3D, 0xffffffff); + } + + flash_reset(test_data); +} + +void aspeed_smc_test_read_page_datafifo(const void *data) +{ + const AspeedSMCTestData *test_data =3D (const AspeedSMCTestData *)data; + uint32_t my_page_addr =3D test_data->page_addr; + uint32_t page[FLASH_PAGE_SIZE / 4]; + int i; + + spi_conf(test_data, 1 << (CONF_ENABLE_W0 + test_data->cs)); + + /* Write the page the regular way */ + spi_ctrl_start_user(test_data); + flash_writeb(test_data, 0, EN_4BYTE_ADDR); + flash_writeb(test_data, 0, WREN); + flash_writeb(test_data, 0, PP); + flash_writel(test_data, 0, make_be32(my_page_addr)); + for (i =3D 0; i < FLASH_PAGE_SIZE / 4; i++) { + flash_writel(test_data, 0, make_be32(my_page_addr + i * 4)); + } + spi_ctrl_stop_user(test_data); + + /* + * Read it back through the data FIFO port, again sending the whole + * transaction (opcode, address, data) through it. + */ + spi_ctrl_start_user(test_data); + datafifo_writeb(test_data, EN_4BYTE_ADDR); + datafifo_writeb(test_data, READ); + datafifo_writel(test_data, make_be32(my_page_addr)); + for (i =3D 0; i < FLASH_PAGE_SIZE / 4; i++) { + page[i] =3D make_be32(datafifo_readl(test_data)); + } + spi_ctrl_stop_user(test_data); + + for (i =3D 0; i < FLASH_PAGE_SIZE / 4; i++) { + g_assert_cmphex(page[i], =3D=3D, my_page_addr + i * 4); + } + + flash_reset(test_data); +} + diff --git a/tests/qtest/ast2700-smc-test.c b/tests/qtest/ast2700-smc-test.c index 33fc47230e..58f796ce0b 100644 --- a/tests/qtest/ast2700-smc-test.c +++ b/tests/qtest/ast2700-smc-test.c @@ -52,6 +52,10 @@ static void test_ast2700_evb(AspeedSMCTestData *data) data, aspeed_smc_test_read_status_reg); qtest_add_data_func("/ast2700/smc/write_page_qpi", data, aspeed_smc_test_write_page_qpi); + qtest_add_data_func("/ast2700/smc/write_page_datafifo", + data, aspeed_smc_test_write_page_datafifo); + qtest_add_data_func("/ast2700/smc/read_page_datafifo", + data, aspeed_smc_test_read_page_datafifo); } =20 int main(int argc, char **argv) --=20 2.43.0 From nobody Sat Jul 25 15:17:43 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1784252911; cv=pass; d=zohomail.com; s=zohoarc; b=WSybvxyy8uqa8IOBX0I0gt9JlItdBA8AA9QLTkgm41e3SXSl414F9INvkYTAwd2b4s7snPzPoLRZtfVCk65JLOpjPB43P5I5dcpbSISP6H/W0xiSRorkgMo56DbvComwOkjzi0OH/D3is9kVQwOW+Wigvf/KpyDVkjQRkT4pAnE= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784252911; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1JG8Etd7Q5/RqtTKxkWB95q5LspQcFuqJhr4/+ZuyjE=; b=OwOqi+1nqJQ4VPJ6bfS+cBopBC+I2NGjyHDwmCBm13X4hpeicxSdNavF7WmXPLiSwXqus8qzwY+rc3vl7TD3zLy/0HraZbQbH20CW7IVJLad2KiMeenmi/rcheqZNuZGtSo+OFAn7qPnJN3IAaHJJHzWkoNHio+S8NBlSgv1isg= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178425291130691.91743457916516; Thu, 16 Jul 2026 18:48:31 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wkXfd-00062T-QH; Thu, 16 Jul 2026 21:47:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wkXfb-00061z-RV; Thu, 16 Jul 2026 21:47:19 -0400 Received: from mail-japaneastazlp170130007.outbound.protection.outlook.com ([2a01:111:f403:c405::7] helo=TYDPR03CU002.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wkXfa-0001j6-DS; Thu, 16 Jul 2026 21:47:19 -0400 Received: from TYZPR06MB4980.apcprd06.prod.outlook.com (2603:1096:400:1cc::10) by KUYPR06MB9015.apcprd06.prod.outlook.com (2603:1096:d10:74::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.12; Fri, 17 Jul 2026 01:47:04 +0000 Received: from TYZPR06MB4980.apcprd06.prod.outlook.com ([fe80::ea8a:7cb7:4822:2fb3]) by TYZPR06MB4980.apcprd06.prod.outlook.com ([fe80::ea8a:7cb7:4822:2fb3%6]) with mapi id 15.21.0223.011; Fri, 17 Jul 2026 01:47:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BDfQrwnm5RF31i/32ypu9vbVpONNrNIroD+cTVFucnB/7VfU3NAea/1nRiO72GEwrZs7qpkqPQOQYG3gYEV6vfpaNXteHYRQIJpN59F6p0Z9AQ9VTKPet9SmY4aFCg4rfZFg5jpfuGbvH0f996Ubgr0HSsG+MzF896jP1M3fqRTw/CRoh8ShXEYretXsMGOnkzUu9AqO2svDQs34wHr0JNM5F/THBY7WRTAz71g/8LGe18R4GyCtx9V5oPaWdicu+FROKTWCvp3AbKSTnQS5dm8V9TTfwa2ULQzWhr9973++7e854Egz8xyU/50Y2glREPR0paHpRl9y2ZSRWf1u8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1JG8Etd7Q5/RqtTKxkWB95q5LspQcFuqJhr4/+ZuyjE=; b=V5QXNCARZ2lZJiGf0hixK5guYKCBU/b6OLwaY9yQ+NQJmIXpHBlQUugkfv0wNMAR7cR1IajbO7826/R2I9iSgqKZKiIvwTuXzGYR6VozJxWWeKKmg5IFJLmlugAPtbLK8svBnTdYyiyPDLqsMfL88nzLnNpjVPlDkbpensJZMcN4llsWGkBfZPFMKPxiXIAT4auFvmaydrtFvCex2Opri1M0dl2yifA9xaw9sIhhD7dafKm2mkDuD88hA77lehjjWM8sIrl71YJe2qJNrIKFCFGXMxS3eCWtvHLz5o0qDGVVvSl5MQUOpiqrWJk2+NMYzEyYZ1Is4rxZonal4FfmgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1JG8Etd7Q5/RqtTKxkWB95q5LspQcFuqJhr4/+ZuyjE=; b=HZk2uPXOSLkeUzPJrgMWZV5OIM0PIVSNqozATF4ItVthJsyK2gpqYx3c5NP33wQQEorYh9jTjgg/Ifq2axfEiwYXocacWSjttTGfqoXn1/wRQPbfwTN35TyVTWDXbMv8i3mnqqUEFp4Ufhk1CPFmtYn5fymNo8RJj/12k+M75zjMebZfEkVXkPzovYUw2DGy04VJ90xybrKQTvBPMaVABuihGQI1yzLSnbbmN7v3TZdmj4v0AH4GiS8lup4Hkus9hOG0vAf7d/QX57ilF0pzvl7VYGxtIJqS+TJ4tKO0m4l45GYgXzy3TIMaqBEyHe1oTvXR8ATpDqsrsRzmzfOnXA== From: Jamin Lin To: =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , Alistair Francis , Fabiano Rosas , Laurent Vivier , Paolo Bonzini , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee Subject: [PATCH v1 2/3] hw/arm/aspeed_coprocessor: Clarify SCU/SCUIO/FMC fields are shared with PSP SoC to AST2700 Thread-Topic: [PATCH v1 2/3] hw/arm/aspeed_coprocessor: Clarify SCU/SCUIO/FMC fields are shared with PSP SoC to AST2700 Thread-Index: AQHdFY4rJZ+Mzc92gkK7ngV/9xBGng== Date: Fri, 17 Jul 2026 01:47:04 +0000 Message-ID: <20260717014701.1683876-3-jamin_lin@aspeedtech.com> References: <20260717014701.1683876-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260717014701.1683876-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYZPR06MB4980:EE_|KUYPR06MB9015:EE_ x-ms-office365-filtering-correlation-id: 772dcc05-bec0-46b7-c6da-08dee3a54da6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|7416014|376014|366016|23010399003|1800799024|10067099003|921020|38070700021|56012099006|22082099003|18002099003; x-microsoft-antispam-message-info: pp4MvTBGO1Pxu2sqDapUaTj3xlg4qoNQfKtoCC0dmGr8Dru39Vv4yyjtiBhifp9GsRDhjAPnaEGzmK47xRpubHXjmMDjeUByHJP8hfwMLPMnYDXPMVJaSvMM1/te8LezYBbKqRdV8+z1x43GmzIIR5YVaDPe29bLiZtSyzKYxe2oBDT30DCJUklP5dJoBgNcR2SH9mKH8A+d8p9HdHoPsKvKPQJ0qGW09DXUe/orA4bZ7kPYMIjMQENF4nJI2YVjUyoFY4SF09hHsoE5dVwogxvPN/9YB9QF0I1L4yufAH5NX+yR7ww3pHhkY4UiyKtH5gS5yLYjkkBmRclSK/XBTJQRqVXZ0FlG5hCCTSBzDUpvz5ywAN6k8IK/aeOFJYF5YZxJr92UeVmjpxc9eD3DLkk21e3jY3mhXBztPvNU74+Cfdrxo6/SVG93x3P+IOEl62guK8dlfkSimAvypkXn7Mti8uwqsgz+W3uq1xiOXpSIOCPFXKTX3XG5rHQcIwNWnTDK0f5jyk+486yyl49TB8TfLlnN1hcQJFq3doQLjzP6ZoRsL812V7I5TYMWjGv+55WdgAFjPzbJuuB7+7ALS+cPW59cOjylgV8V4aSdGASwPlFy84joXxBMYbAT5krrBxFZJQeFPdVbvvtLe+wzmsyXqt3TyFWYqzuLTNRj1Vq9D3cTuWkJsnd8wFxhCTTX5bwc2Dxa8351WxkhRrNOLm2eEQt+zFToRO3h5+J3MW7qIw5ujIPD/ObmggaNXzHY x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYZPR06MB4980.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(7416014)(376014)(366016)(23010399003)(1800799024)(10067099003)(921020)(38070700021)(56012099006)(22082099003)(18002099003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?ZKFpV6cCa888Ph1S+e4gXhuSdkxub8YEwyPuHj0Q90ppvzvgIX+Zs+apo/?= =?iso-8859-1?Q?nPSZgPZcCJ/Qtu49J979XkdQqRWmy6RTn0MH4K/pYgfCJLuH8/WUyefTJ/?= =?iso-8859-1?Q?/CUncRy4pDjp1Ra6vJcb4Y/rBuCfXM+1zNzFvhGrlFsb2u1ZHDeITPTQhe?= =?iso-8859-1?Q?qtrfpAngQXN4oPzeNF88pNSpCQ2C7kQKj60dzQhciKAdtktjyUOrEWaIyk?= =?iso-8859-1?Q?/83BEn/HjW/9CbzWkR74WQuApe4RekIK2z2OwkqQBvAZinIl8aRCf9TP/G?= =?iso-8859-1?Q?LGkIlHW9A4cpFlCCAkXYAMvZqEBcvgzPi5fuZuQTxcl1Eot/WwiEm9B8my?= =?iso-8859-1?Q?gOO+3f1868M6q5QxKPWx6KlyONodY5E5LehyIiPkn09bjbz611X1igShFi?= =?iso-8859-1?Q?jm8VM2hczXDZ66V13Y+MMwO7zbQ0qiD5YLr1KQWxK9POertB85Oq1LlSYc?= =?iso-8859-1?Q?QRPfA+J5cWi4jt83vaFxbylTkyj0Sm5SxjKjZr+lPFF0mNR+XHbIVF+u/f?= =?iso-8859-1?Q?mWCsCh9ji6bU91C5AoBSTGm6K/8+zdm1jg7iYu0Eu9XQWHY98psbkrvqYF?= =?iso-8859-1?Q?pVxdx7jIsoJ0p/94TwIJlSwX34qA16ZPu9qBOV2pkAe8YisW+DwwbjIsSc?= =?iso-8859-1?Q?K3syo/HPtyHAEAqEY9cdZ78ge/Wz9ANccdgyl5I8Y85soSlBX/DNd16LyE?= =?iso-8859-1?Q?/Nq6TVWHFuMF0c1lHGr9/ZbblsniziHfJzvPNw5B/vjAGM9KgvgMH03IIU?= =?iso-8859-1?Q?Ay9Xjvagn4Ae2js8+KN/ZQGHv6VABPGYgD0j+rBP9jNItgwkU+m0Evvcnn?= =?iso-8859-1?Q?/2iSW0JWb5v/WQ+bX3ckrNGt/GowsRvJGMp/e1o2EGsfdSwXh6Czx5P2+A?= =?iso-8859-1?Q?Dx/ey0W/XOs/3PV/Qnp1nbfmssqyPOGpkGyOAv9OnyNkXE1FIOu8zdWJQo?= =?iso-8859-1?Q?+qEzJuvx48JqARWG+mzrM0KICVFe1t+fz66WMzM0c61StANuU26jm2RIWS?= =?iso-8859-1?Q?R8Q34n/TAL3/5Lr6pvg9K2rBLvACecBbx8Yo54WNK0YvyY8qxlrqXwVl65?= =?iso-8859-1?Q?NoGSGjVbSPbo0x0xmm6c3Qq06Pqfo5VNcnuaSYE+ESYdHgKbmIrZPC/0+3?= =?iso-8859-1?Q?0MDYtn0Y7ofEjzMIGK4LxIFWzP3MvF7qErG0zrT3MQVqi9WDD2Y3fcAuSg?= =?iso-8859-1?Q?vB+1TXQR7DkK980ZUHt65IW2oSW7zw2EHxw7p0YR/uAhmKe6ox5MVld9SD?= =?iso-8859-1?Q?Teu4WCIoGVVL4IKCm/ijxeYE3f8LBbWSbjQ/olGPsmNuaJq9RE2lFraHJp?= =?iso-8859-1?Q?SUUT99GecBU8mOV3IwzEyisI0nkIBSn/E67CKtB8gFJh5CUTQebe8ECq/A?= =?iso-8859-1?Q?yBku6+wDrxyMD30EkFSyK1EBBFrIjWgTDWtSI2eCe7mBO9+6g6X2rk8DC1?= =?iso-8859-1?Q?fLhoGdZERjJQfAxYQ8+stHu41GPIa7J8Gfq+7RJv68NgXY30PhUqYsHRBu?= =?iso-8859-1?Q?mTifB10g7rgj0NCo1YgnZgHFmFdIv0BC7yYdejsZL9pxt8OjaqlVXxmCvw?= =?iso-8859-1?Q?TJSwB32ggAGaZvfcwuxUZL+snhZ5sE5+hMvb5w3w/l4/UQ/DqVNkqwHRib?= =?iso-8859-1?Q?SKtul3xdAfFewaGzoMEQ3j8CvKHGsJDT56NjEk+UZHoVVbwW9hxD23a5j4?= =?iso-8859-1?Q?C33GAJQS0ltLaPhRZ2P94BP2CcIgLsVzmcIZl6FIv26JJ6WRs+qCz8glPN?= =?iso-8859-1?Q?J+KaKu6RvjTDE6NAx6e4twgnjZwfGyOmJmfKnwUHeVrSwRVSb//AZFQPUK?= =?iso-8859-1?Q?MZkl6lQUQA=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: Xk2sb6B4HlOakSG5Tz9iPDDQVKdMYhfKf8e3yg+Hwa4N9WWbf1I7hYelGAHIwn9mY/EllLIimS1jncR67+BRoix8N0isVHv7483A9XCz4Z3v3xxNeaUjrachPMdAKlSLzGm6k+5YsmShqFIDa2nzbxo1P4Lc7X0EpQDRwxj0eZm/QfjKL+9HlTa3Iijv/n6qJvYShooljf8ssleuoiVem3jdRRIkCd/dU/3PXVXOgMSFvyBv85rX+tWExp0gIEQs97kr955MND3GY5QuAkSvSlROkgbXj0d4pnCDhQq5nTG13gHC2LaIaubIkqiEAqwev400mBO5E416CkfeAblDSg== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4980.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 772dcc05-bec0-46b7-c6da-08dee3a54da6 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jul 2026 01:47:04.4803 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZSBOtQ21sGD3zqqVugqhuSlm6Whs4XK3PZfC0zAwR2AZTdkaMBEc6WOpwyvpCAmEA5fpyjznw8MuAg0us8FAblGPM2iHSTvrGx6j0esyjfk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: KUYPR06MB9015 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c405::7; envelope-from=jamin_lin@aspeedtech.com; helo=TYDPR03CU002.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1784252914356158500 Content-Type: text/plain; charset="utf-8" Add a comment above Aspeed27x0CoprocessorState's scu_alias/scuio_alias/ fmc_alias and scu/scuio/fmc fields noting that they are not owned by the coprocessor: they point at resources owned by the main PSP SoC, only aliased into this coprocessor's own address space. No functional change. Signed-off-by: Jamin Lin --- include/hw/arm/aspeed_coprocessor.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/include/hw/arm/aspeed_coprocessor.h b/include/hw/arm/aspeed_co= processor.h index 23c3b97f06..ff359ab532 100644 --- a/include/hw/arm/aspeed_coprocessor.h +++ b/include/hw/arm/aspeed_coprocessor.h @@ -49,6 +49,11 @@ struct Aspeed27x0CoprocessorState { =20 ARMv7MState armv7m; =20 + /* + * SCU, SCUIO and FMC are not owned by this coprocessor: they are + * shared with the main PSP SoC, and only aliased into this + * coprocessor's own address space here. + */ MemoryRegion scu_alias; MemoryRegion scuio_alias; MemoryRegion fmc_alias; --=20 2.43.0 From nobody Sat Jul 25 15:17:43 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass(p=quarantine dis=none) header.from=aspeedtech.com ARC-Seal: i=2; a=rsa-sha256; t=1784252911; cv=pass; d=zohomail.com; s=zohoarc; b=mV9HYnUdiWgc8JZxbc8+yHG2wT24OHW0YsAoBP7weA/BCf6v3Bj6zVmggYIJmb12MyO0cmObV4bcC0b87GJ7jNPCCj5mkWMWtIuqo/KZztk2pqYfGL+5cwnZ7thV8T44pqXHD7rqu8ILj2iNRsyweg1ehqU+4qsbIGxN8Y90V1c= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784252911; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=JV6esXMmLD0/CGcJHDlMvm7/i1D64lv0/nJcTHpv4Lc=; b=KL4gOrSf9hutgQdBmmmj77BY1Wt5hwEkT/hB/BpSLbhtgMgjAwGHv+sOmFobSY5DVTfC1i6Dyz8tXSa5EUbK8fd4VoIIod9xUNsWT93bgqnZpLzGcYTPKBsL8c6D6nQzfkFFjmafyrjrfk8w7OlQaXv0LgphrV3mFTp1uga+SWI= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=aspeedtech.com); dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784252910932290.0997011797432; Thu, 16 Jul 2026 18:48:30 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wkXfi-00063J-33; Thu, 16 Jul 2026 21:47:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wkXfe-00062i-GM; Thu, 16 Jul 2026 21:47:22 -0400 Received: from mail-japaneastazlp170130007.outbound.protection.outlook.com ([2a01:111:f403:c405::7] helo=TYDPR03CU002.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wkXfc-0001j6-W5; Thu, 16 Jul 2026 21:47:22 -0400 Received: from TYZPR06MB4980.apcprd06.prod.outlook.com (2603:1096:400:1cc::10) by KUYPR06MB9015.apcprd06.prod.outlook.com (2603:1096:d10:74::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.12; Fri, 17 Jul 2026 01:47:05 +0000 Received: from TYZPR06MB4980.apcprd06.prod.outlook.com ([fe80::ea8a:7cb7:4822:2fb3]) by TYZPR06MB4980.apcprd06.prod.outlook.com ([fe80::ea8a:7cb7:4822:2fb3%6]) with mapi id 15.21.0223.011; Fri, 17 Jul 2026 01:47:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZT9k/jNqSloIwv+aeIt/9V3Wdjj87LEhdyf/Hl2IH+YXXAPC2uoY3txZE2mw+Wb5SFL/Lru+DIrVY1QBEDk+nkoxYb0aaqGZWiZC2m/bHVQKgNWkLcaQua6trCwPnMOFZmbOaFFBj/fdwiRzGlGfRas8FLSCBP5vUbrmGt2isfyUS36p0o+eNbLhd6sloY61JMiZoWWL7KProY7UF70r4iK6Q4j4bbHi6nRFLy7Uslj+UiKmAKChWIujqFYyaE0HSnkRS2a2aE6TCeQM6Oi5P+agCaSqAHoHwfUI5stlIjay6NWORkcG0pqTIJQTJmYMj2RZQ9ivdPXn/Oa4+fuRfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JV6esXMmLD0/CGcJHDlMvm7/i1D64lv0/nJcTHpv4Lc=; b=HKArjt86qPb0Mz1UeN7jy0aWRoLEXSRsI4bEY/Uaj5DV1qD8OrSoa9euTaSSkMyy04Lhi/0tWHo0OJHbz8+MQqrZAoNt2p/SVG+CUdXKQBfF86vb6B3Luks8/5A5re4SUAeKgm9vOn4ftJgxG9rg9UyGXQcMAisJ9OtyKxz3wF+8qAWKZY2QrHt/XROwGFw2GBjzb5ExpA8/h83eeS2ucQ8tkt5VpUdNxezcoknfXy5VnVFbLrnfLQpByt/S3xM8X4Nrwgi/FVuKZfUNOlcqm7k8WKk3iDZrdFUQNe7ISeo7Gw+LX5OAEZI0/RK0ueln3Xl4U9HIaIWPAyhvJCTz/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JV6esXMmLD0/CGcJHDlMvm7/i1D64lv0/nJcTHpv4Lc=; b=DNhLdlsOsGU1KxzPjoJ+1Ye80404/I7e1Onn++y6CMQUONcIVSkv6vn1O658Nq9no2IxFKT0Yyu35BXfDWx5hQFYbPZBJBtbc9U4mbNO2hVyqp3Nl1rxYOHKjQhY67ZRAFtZVeG6w4wIEUj+FJoCiuUQAdQkMPN392IPHOHB65rn8PO4sS9/mO+OyvgyLPoX7wtwKXAd+bAHu35vB9Waux3wbA3CDKFebfTSt+Frc4gnodGyJhZfHImqlt6+NF1iKdeIb25ZNu/2uE2JaGSQl4n+k3fvLb+gAhaNjjCBRohQ672YhV4Tyojt1bfD+KiBmlk38zXeqCC0cWph0cq+Iw== From: Jamin Lin To: =?iso-8859-1?Q?C=E9dric_Le_Goater?= , Peter Maydell , Steven Lee , Troy Lee , Kane Chen , Andrew Jeffery , Joel Stanley , Alistair Francis , Fabiano Rosas , Laurent Vivier , Paolo Bonzini , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: Jamin Lin , Troy Lee Subject: [PATCH v1 3/3] hw/ssi/aspeed_smc: Bump vmstate version after ASPEED_SMC_R_MAX increase Thread-Topic: [PATCH v1 3/3] hw/ssi/aspeed_smc: Bump vmstate version after ASPEED_SMC_R_MAX increase Thread-Index: AQHdFY4rxqckSWEwFkSu1flEV22jgw== Date: Fri, 17 Jul 2026 01:47:05 +0000 Message-ID: <20260717014701.1683876-4-jamin_lin@aspeedtech.com> References: <20260717014701.1683876-1-jamin_lin@aspeedtech.com> In-Reply-To: <20260717014701.1683876-1-jamin_lin@aspeedtech.com> Accept-Language: zh-TW, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: TYZPR06MB4980:EE_|KUYPR06MB9015:EE_ x-ms-office365-filtering-correlation-id: c42e2159-af3e-4877-c003-08dee3a54e5d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|7416014|376014|366016|23010399003|1800799024|10067099003|921020|38070700021|56012099006|22082099003|18002099003; x-microsoft-antispam-message-info: H9tNjmGSwFfgVbCCT69jFrV4ePaHh++qyJbNXi1A13uhrz615a9lfyxIeAkKot+rAQLaN34FbNkXB4vWaLV/hZhny2zMQmcm3prLB/fd6kDORyFh+gLRDHYs0ZtNchrk4lZ+lUkvrR/9mziSMcK413f2S3gAKLI3weMWjqpKoHOaFbILbXlXF+E5YtKDbSbWRy1xJRPMj7HcLSuD2r+fIbfguuI55iuobx1IaNJS3mnXwpskbsRlqT+SvKl9W3nRbnyMZJUFv9488aColjhYQ5H7iAcyHWepfnrqm0YVErPkUkk7EwIoY83q4tnLROq8QyGWwXY4Q3gvaDOXtV66+uZfJ5AAxYisD5nqZnjfIhxMG9qFq7RI68ps2lEkCa86z9yuNq1XgHu0v/SCI4WVWsVO0wNPZu77y9dPAGF6ynvlTP41jmIXh6KsgY8A4pJeS0MwVMZbpA1FVprCl/k1Mb5ejpyha1HPAkidKmDmvLn2+3AKQV4A6ABA0lpe24/dU9pqC/ksmgGBwNpY1B0LNTJCQjrWYKl8SSrOf5KkeBt8BbvXF6tUEV1pTz6jhrQTAsIYhIuD60LNKE7elrAv6/FF7so2M1PqZ6dziCrD+1Y90ZQcdGq9ODj3bf/0YlgOEYYTEZ7bZ9mNlB3nUvBvaEqylAWdVSzKNQv6th7tSUemJQ2tHDJ0o7jLcOTG8cT+5LLh7VUnwvpesl6+GSmHl87+Jk8wtGod0pc5kqcxK+4= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYZPR06MB4980.apcprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(7416014)(376014)(366016)(23010399003)(1800799024)(10067099003)(921020)(38070700021)(56012099006)(22082099003)(18002099003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?7LD6oMtW2c5TrZexUp2JILN7dpeTvBYVc1wg7QlcYdbx/leRzTGG9No0Fr?= =?iso-8859-1?Q?8KyvH03diBtv/x3aaHvg7CkcghPWbxpKpJc9Wq60N2y9jqVT1VKSZkAXxz?= =?iso-8859-1?Q?T3ZLR2Ex1hJBdORiNfRMU1MD15mTC6otg9KRkafL4pfXixXjwFNmXj6G++?= =?iso-8859-1?Q?gfg9biYidIAlNzKPTvUkXAg2eszacTa82fySunClQPVI6UM9bVrEQz20sY?= =?iso-8859-1?Q?66Nlz0r4uRQCr5cUuMu0iq9riPUPM5wFeq8BW+dJ1lMbZ4AgxMP5R8qgMg?= =?iso-8859-1?Q?+oVRNZBaTmgGFs4HIo5UCq9elhmlKXHhaowxBBFJhdwO3oL6lkcUpfL3Cg?= =?iso-8859-1?Q?SFNsnqTz3JduJDcrJcOSahRS0a29N4lUg2zuthB4BkT2N9ZF1vFEA+BJJ1?= =?iso-8859-1?Q?KBII67e9ZEpSwKPGyUbBS0Jqdjwq1C2F+439fvBc5DaAGQOHPl37u4+ZV0?= =?iso-8859-1?Q?Wvd/nni8vaZj05SYT+Gw4LelgHTFo2enOIX2Rs6Oqe6ER8bK/lkcN4JEq+?= =?iso-8859-1?Q?vJ7TSS7+I/a/aBHi/lgBYcG9QeoEpX1WT8bd4/4V0tutoz1+V3qQMm9Y0C?= =?iso-8859-1?Q?96wCCzU/Gjk4d0sXkRg9uYo7adTTl/07LtgP6J6NwOKeDIJ/vtNi1qugwk?= =?iso-8859-1?Q?DmR8RVvx57mDwRJC01yfcGGSIt4fHFtoELJp2x2qik0YUrSYnjyMI+HH2Q?= =?iso-8859-1?Q?Zm7T7KWB/mVIaWBPLnQfnPjdp4qmE53mbdhV8dWFenPLjp+zDGZIDHT2uO?= =?iso-8859-1?Q?94q0r23xG6FPZO9hsJ8iPdAxnQVz1iRKAukwp0M5BvlbMZsIy3wh8k+vLy?= =?iso-8859-1?Q?IGODLICoeIxxKAAXlA3zOU8k81incC7fdD6y12pGi0TLJJV+Kar0I34+rM?= =?iso-8859-1?Q?A0Fgp4mLcZ7Ey31bu0IuOFEdbfQ98cR6/BnxtQAau4jcVXRa/4L35agtys?= =?iso-8859-1?Q?deJPuI4AG0AV7szK4P+lZ95Lqa/IrEwUkaJlqp0C+D74mBHgnJ1aaA6r/F?= =?iso-8859-1?Q?iCwcdP4Ue4PpuZbwzPI9bBBHYKiLoJDJR2MnKlfJFSe6DOMe7teMJr0YnY?= =?iso-8859-1?Q?2U1rkX8j9l0ymkZvdydeROVidqR4n7KOaMTRkCzWRLtKkj0Zf+I0rkEUQW?= =?iso-8859-1?Q?DnjKNN1odKnSAjcqQx1Nht+wK37F3BVcZILA7pAtjtd3E5LPNNmM3ZgWjv?= =?iso-8859-1?Q?452psnL0eerlCRKK2xpxjstkfQL26K+CXsQGimqTVnTS81FjIA2dyb86hr?= =?iso-8859-1?Q?HCZwBb+RIwJToEZLBHtILfqp9Nol0KPJ9H7TkNILEfbwVHJ4XgeTwnEJha?= =?iso-8859-1?Q?CEcX8H8mOEoaEIEJLG6IvUo+yiF6UP7zteiAeB/G5hvjvomCpxAg8suCoh?= =?iso-8859-1?Q?mmZfuUEMnwtoFNpHxhR/yKkO1pKq19czCdKDOg3LVDJ1/d10Cuslxr7SGT?= =?iso-8859-1?Q?QQvpVUBUM/XTMuVLEqJ6qFzJrM911Ob9KxO6BejBfZGcWqpBnL/fMnHdTP?= =?iso-8859-1?Q?j44L2099HJE8m5DI48/R56mdUsQo/xfwDPU2pK/5tW78y2BvI9K88kYHKZ?= =?iso-8859-1?Q?Qw37cNhnNQjBL59DwhtjmDuvC81pnIoNH7kzkKP8dbHCm9nFsPPUFeiLln?= =?iso-8859-1?Q?hP/cK5bP6jUkgxFzfF6s28KnjfTwNpXmP0i4UPQF3Bn3Do6sOIxGePr8LV?= =?iso-8859-1?Q?2vn77XV1Us6YfmHIAL6jdBd8u72tfejWrGzuB4syLB5urM1kEVBqSeCBqR?= =?iso-8859-1?Q?r3HPAgIt1xAPK4gG48oUnmhRy5/Sx2AGzSLrP18Szjtw3eEUMqhA4pxRkY?= =?iso-8859-1?Q?oZ9uO4DC0A=3D=3D?= Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Exchange-RoutingPolicyChecked: tB4swLBC+dseaKh9Dis/1ez7iamcgMZWCy99Q3FAR3VlUuKsFARF7uMg8zv78RDFSN54Bz30Iaee4TXfxFSraSmlaY0Db7v2sgXnf2GlMIxqTtCpRrKNouLyUsca1PdZsepA7ihxxwCPUqfeZfZ7eBhTkbOsUMAcA2YpzXEwyfSa0JlMz7tKoCrOD9HBrfFDXrASTfHDkLAaqyoWO99otVVnnZF39jhxZ71XrP5xvUOZE9NfWpQNddQLRczlhVXXewkmro83b1uXjRdalji5EXn857rFSFoV0Tl3nSJq7nGxv0m9qxA7qsI+s2L5CaTCzaqqzh2++aHf8zlqWTriZA== X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4980.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c42e2159-af3e-4877-c003-08dee3a54e5d X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jul 2026 01:47:05.6922 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WkcKqpPtFsHR89ysFukc5zdkaeYVXEWYMy6rjtnMW/bhYTaWQ+j66EdhPKHVCAcV7/STkffMZ/zd5h/zkd1V05DyJmeK9krSsx2NBanYi9s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: KUYPR06MB9015 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:111:f403:c405::7; envelope-from=jamin_lin@aspeedtech.com; helo=TYDPR03CU002.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aspeedtech.com) X-ZM-MESSAGEID: 1784252914357158501 Content-Type: text/plain; charset="utf-8" ASPEED_SMC_R_MAX grew from (0x100 / 4) to (0x300 / 4) to cover the new AST2700 data fifo registers. This breaks migration compatibility with older QEMU builds for the affected models, even though Aspeed machines are not officially covered by migration compatibility guarantees. Bump version_id to 4 and minimum_version_id to 2 to reflect the incompatible format. Signed-off-by: Jamin Lin --- hw/ssi/aspeed_smc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ssi/aspeed_smc.c b/hw/ssi/aspeed_smc.c index 5cc4dd5e42..bf596f7b2d 100644 --- a/hw/ssi/aspeed_smc.c +++ b/hw/ssi/aspeed_smc.c @@ -1218,8 +1218,8 @@ static void aspeed_smc_realize(DeviceState *dev, Erro= r **errp) =20 static const VMStateDescription vmstate_aspeed_smc =3D { .name =3D "aspeed.smc", - .version_id =3D 3, - .minimum_version_id =3D 1, + .version_id =3D 4, + .minimum_version_id =3D 2, .fields =3D (const VMStateField[]) { VMSTATE_UINT32_ARRAY(regs, AspeedSMCState, ASPEED_SMC_R_MAX), VMSTATE_UNUSED_V(2, 2), /* was snoop_index/snoop_dummies */ --=20 2.43.0