From nobody Sat Jul 25 15:25:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1784230457; cv=none; d=zohomail.com; s=zohoarc; b=lbQwNaE2+xP59SSeVIgEMhCpspMwZu8XUqnlfBZ06MfrLIVMlz6ysOcXOuJTE65CQ9SfGyy8bFpMPLL2LlekTbzi5zDsvcbXUWWtCp309Gc0o1Qd/XPfud23tpf32Cr2GjFSTeKuUpUrZWYMP/n1A9sZGPl8Y2z3I3lJ7omc9q0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784230457; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=esVHY9gqyyu9JCDoSbr4qjILp7A8+XrQkoBrzUOlL30=; b=INAAjkscF2r+TmRpJoPHsCAjtZEwfzJZvxNfRNdFesOZPKKzmUflstbiJA5vXAw6ifP77FRu5LM11yr9cNYZorsR+bNNBscFR8m0kamd7olKJGZ0qQn53uhxq4lmNbyGgppTPXjljxX+Y8qDpEQz7pktxfbpWCVpp6+eZaV5E+c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784230457000785.0853883795612; Thu, 16 Jul 2026 12:34:17 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wkRpv-0002zB-5H; Thu, 16 Jul 2026 15:33:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wkRps-0002yM-Sc for qemu-devel@nongnu.org; Thu, 16 Jul 2026 15:33:32 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wkRpq-0005Xi-3w for qemu-devel@nongnu.org; Thu, 16 Jul 2026 15:33:32 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-104-ph6J_GohP7-n9RXpnimqVQ-1; Thu, 16 Jul 2026 15:33:27 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 94C1A1955EAC; Thu, 16 Jul 2026 19:33:25 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.32.163]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A7F1842D; Thu, 16 Jul 2026 19:33:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784230408; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=esVHY9gqyyu9JCDoSbr4qjILp7A8+XrQkoBrzUOlL30=; b=Tx6hKeU/jKCECbo9p+ARIrNph1BmDv1zNbLq8V7F5wfGiZopF2GxIuyey6tdm5KZ7bv9rC sAHm3D0z2hSavkg+wLTiR+pfjvMFvY/9XIdS1iFdCLF5O3YSyC4mtL4A0wdxvpy+FrQoQi 1of6d4uDawwcAteNDUjoLM6wI27oaN0= X-MC-Unique: ph6J_GohP7-n9RXpnimqVQ-1 X-Mimecast-MFC-AGG-ID: ph6J_GohP7-n9RXpnimqVQ_1784230405 From: Thomas Huth To: qemu-devel@nongnu.org Cc: kraxel@redhat.com, Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-trivial@nongnu.org, qemu-stable@nongnu.org Subject: [PATCH] hw/usb/dev-uas: Fix guest-triggerable heap OOB access Date: Thu, 16 Jul 2026 21:33:21 +0200 Message-ID: <20260716193321.256391-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: permerror client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, T_SPF_PERMERROR=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1784230459974158500 Content-Type: text/plain; charset="utf-8" From: Thomas Huth The stream ID is under control of the guest, so we must not use it for indexing into the status3[] array without checking it for being in range. Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3612 Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3986 Signed-off-by: Thomas Huth Reported-by: Tristan Madani --- hw/usb/dev-uas.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/hw/usb/dev-uas.c b/hw/usb/dev-uas.c index 8576dfec96f..7df58cdeee7 100644 --- a/hw/usb/dev-uas.c +++ b/hw/usb/dev-uas.c @@ -383,8 +383,15 @@ static void usb_uas_send_status_bh(void *opaque) =20 static void usb_uas_queue_status(UASDevice *uas, UASStatus *st, int length) { - USBPacket *p =3D uas_using_streams(uas) ? - uas->status3[st->stream] : uas->status2; + USBPacket *p =3D NULL; + + if (!uas_using_streams(uas)) { + p =3D uas->status2; + } else if (st->stream <=3D UAS_MAX_STREAMS) { + p =3D uas->status3[st->stream]; + } else { + warn_report_once(TYPE_USB_UAS ": bad stream ID 0x%x", st->stream); + } =20 st->length +=3D length; QTAILQ_INSERT_TAIL(&uas->results, st, next); --=20 2.55.0