From nobody Sun Jul 26 11:54:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linux.alibaba.com ARC-Seal: i=1; a=rsa-sha256; t=1784197237; cv=none; d=zohomail.com; s=zohoarc; b=FPrmW6z7neOR2azwZVtmMwbvh1EAjYKBiavhpS/zdVQq4UUKcB2SCRr6iXwBHLdXR+/zRRdjEPY28+Mrh551MA5+o60gSZThYW1fpuII1gjsRrW4xdJNYPGZHpWHihMmHxf6+uigRfYr9r8UWgVsU9PFiyi5q62kDwcAorsmk6A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784197237; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Qi8jL2Z+EwBGgRPNYf4vM9alBFo+pHcArfdwBiOMkxY=; b=OC5P+m2nsnfFNF1YoMxdwsQD4qFtCjTYvFdCOl7q+H87uyg3BPk7GdX6jYkWSBDuz4vZ37w0yZSskInbRHA7OF2kak+pdUmwFnkStU7m1cMI3ASAfHPDUEpuvDQ3mW4D+WXJPy8ezY7XcaZetSMPfGcwLzIn4V54C5tpols841I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784197237576502.2153175912075; Thu, 16 Jul 2026 03:20:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wkJCR-00040S-Gj; Thu, 16 Jul 2026 06:20:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wkJCO-000403-Ih for qemu-devel@nongnu.org; Thu, 16 Jul 2026 06:20:12 -0400 Received: from [115.124.30.124] (helo=out30-124.freemail.mail.aliyun.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wkJCI-00054j-9p for qemu-devel@nongnu.org; Thu, 16 Jul 2026 06:20:12 -0400 Received: from localhost(mailfrom:guobin@linux.alibaba.com fp:SMTPD_---0X7E6Rlx_1784197194 cluster:ay36) by smtp.aliyun-inc.com; Thu, 16 Jul 2026 18:19:54 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1784197195; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=Qi8jL2Z+EwBGgRPNYf4vM9alBFo+pHcArfdwBiOMkxY=; b=BgCnz46ZT0uVy3i6daEd7PbVlauqSVba9HWmaRo9PgHlKzeO1vjHsAiN7FrC0vTzSriaJJMKOE/jfaTDr9OWyq5L6hgEXkl/FclNqv4XOxJrs3v8Tr2SkNMULwhpXDe+RXrvwH6cvi4261sAOa03a+jfWd5IcaMyReDnn+HgXJ0= X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R941e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=maildocker-contentspam033037026112; MF=guobin@linux.alibaba.com; NM=1; PH=DS; RN=3; SR=0; TI=SMTPD_---0X7E6Rlx_1784197194; From: Bin Guo To: qemu-devel@nongnu.org Cc: peterx@redhat.com, farosas@suse.de Subject: [PATCH 1/3] migration: fix ineffective overflow assert in postcopy blocktime Date: Thu, 16 Jul 2026 18:19:50 +0800 Message-ID: <20260716101952.65329-2-guobin@linux.alibaba.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260716101952.65329-1-guobin@linux.alibaba.com> References: <20260716101952.65329-1-guobin@linux.alibaba.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 115.124.30.124 (deferred) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=115.124.30.124; envelope-from=guobin@linux.alibaba.com; helo=out30-124.freemail.mail.aliyun.com X-Spam_score_int: -166 X-Spam_score: -16.7 X-Spam_bar: ---------------- X-Spam_report: (-16.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01, UNPARSEABLE_RELAY=0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linux.alibaba.com) X-ZM-MESSAGEID: 1784197238995158500 Content-Type: text/plain; charset="utf-8" vcpu_faults_current[] is uint8_t. The overflow assert was checked after the post-increment, so 255 would wrap to 0 and the assert would pass silently. Move the check before the increment and use < 255. Signed-off-by: Bin Guo --- migration/postcopy-ram.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c index f5ef93f193..341cad264a 100644 --- a/migration/postcopy-ram.c +++ b/migration/postcopy-ram.c @@ -1093,7 +1093,11 @@ void mark_postcopy_blocktime_begin(uintptr_t addr, u= int32_t ptid, /* * Account how many concurrent faults on this vCPU we trapped. See * comments above vcpu_faults_current[] on why it can be more than= one. + * + * vcpu_faults_current[] is uint8_t, so assert before incrementing= to + * catch overflow before it wraps. */ + assert(dc->vcpu_faults_current[cpu] < 255); if (dc->vcpu_faults_current[cpu]++ =3D=3D 0) { dc->smp_cpus_down++; /* @@ -1103,9 +1107,6 @@ void mark_postcopy_blocktime_begin(uintptr_t addr, ui= nt32_t ptid, */ dc->last_begin =3D current; } - - /* Making sure it won't overflow - it really should never! */ - assert(dc->vcpu_faults_current[cpu] <=3D 255); } else { /* * For non-vCPU thread faults, we don't care about tid or cpu index --=20 2.50.1 (Apple Git-155) From nobody Sun Jul 26 11:54:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linux.alibaba.com ARC-Seal: i=1; a=rsa-sha256; t=1784197261; cv=none; d=zohomail.com; s=zohoarc; b=DQJYTLKrbAU5oaxoie00gnJpVVu3HcXf75rY2ptz/obO8ANRVfOCEp0LGjRxSJqNoX/r2uvw/FW5BA5ChmH2ZdqYxMO0rX96GovJJu52ZAR9OIWSOffjTfjXZrb816RR+8yy0adMPSGMUF920OUdFXcc/MF/PaERV0XLwe5QYb8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784197261; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ANb5OyyCZT/FApULtSqZ9QNYrtKLeWbtrDaSoNGlUyI=; b=gr5PuGfioIP7+L6MDQDy/kWL9dTIvFPcCeG3ndSj5AgSzaqRRkYNmAOxqlrrCf8fSmZrBCQkZdHm7tMXCC/KeFCOpRDrowR5BGG+PycsXodlLHwKONiopwrtdcN5jGUIl6K+jteIqhMdyRrjXc1J9rmJ4uYp7/2nfWq6YICACJk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784197260946742.7103067080047; Thu, 16 Jul 2026 03:21:00 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wkJCS-00041V-87; Thu, 16 Jul 2026 06:20:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wkJCP-00040R-TN for qemu-devel@nongnu.org; Thu, 16 Jul 2026 06:20:13 -0400 Received: from [115.124.30.131] (helo=out30-131.freemail.mail.aliyun.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wkJCJ-00054q-VQ for qemu-devel@nongnu.org; Thu, 16 Jul 2026 06:20:13 -0400 Received: from localhost(mailfrom:guobin@linux.alibaba.com fp:SMTPD_---0X7E6RmL_1784197194 cluster:ay36) by smtp.aliyun-inc.com; Thu, 16 Jul 2026 18:19:55 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1784197198; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=ANb5OyyCZT/FApULtSqZ9QNYrtKLeWbtrDaSoNGlUyI=; b=JGJD9RWRDDn7UvQRhmHfNJQV6qyADZBrY5k7hemQjZiTCix99DcqbHzs+qm8/bh0ybsF5KF2t20R5+GBw8K6RH37FVyktnSz2OZeE4EUO8CX9eKJsKXtodmMwzaY22eGOD3EIs2NcZvRNEDaV+kCaOO5NwWafpvF8++e2sbAYqA= X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R901e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=maildocker-contentspam011083073210; MF=guobin@linux.alibaba.com; NM=1; PH=DS; RN=3; SR=0; TI=SMTPD_---0X7E6RmL_1784197194; From: Bin Guo To: qemu-devel@nongnu.org Cc: peterx@redhat.com, farosas@suse.de Subject: [PATCH 2/3] migration: fix const mismatch in format_time_str() Date: Thu, 16 Jul 2026 18:19:51 +0800 Message-ID: <20260716101952.65329-3-guobin@linux.alibaba.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260716101952.65329-1-guobin@linux.alibaba.com> References: <20260716101952.65329-1-guobin@linux.alibaba.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 115.124.30.131 (deferred) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=115.124.30.131; envelope-from=guobin@linux.alibaba.com; helo=out30-131.freemail.mail.aliyun.com X-Spam_score_int: -166 X-Spam_score: -16.7 X-Spam_bar: ---------------- X-Spam_report: (-16.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01, UNPARSEABLE_RELAY=0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linux.alibaba.com) X-ZM-MESSAGEID: 1784197263135158500 Content-Type: text/plain; charset="utf-8" format_time_str() returns a newly allocated string from g_strdup_printf(), so the caller owns it. Return gchar * rather than const gchar * to match the g_autofree callers. Signed-off-by: Bin Guo --- migration/migration-hmp-cmds.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/migration/migration-hmp-cmds.c b/migration/migration-hmp-cmds.c index 502ca704da..6bedf786df 100644 --- a/migration/migration-hmp-cmds.c +++ b/migration/migration-hmp-cmds.c @@ -54,7 +54,7 @@ static void migration_global_dump(Monitor *mon) ms->clear_bitmap_shift); } =20 -static const gchar *format_time_str(uint64_t us) +static gchar *format_time_str(uint64_t us) { const char *units[] =3D {"us", "ms", "sec"}; int index =3D 0; @@ -123,8 +123,8 @@ static void migration_dump_blocktime(Monitor *mon, Migr= ationInfo *info) monitor_printf(mon, "Postcopy Latency Distribution:\n"); =20 while (item) { - g_autofree const gchar *from =3D format_time_str(1UL << count); - g_autofree const gchar *to =3D format_time_str(1UL << (count += 1)); + g_autofree gchar *from =3D format_time_str(1UL << count); + g_autofree gchar *to =3D format_time_str(1UL << (count + 1)); =20 monitor_printf(mon, " [ %8s - %8s ]: %10"PRIu64"\n", from, to, item->value); --=20 2.50.1 (Apple Git-155) From nobody Sun Jul 26 11:54:38 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linux.alibaba.com ARC-Seal: i=1; a=rsa-sha256; t=1784197241; cv=none; d=zohomail.com; s=zohoarc; b=OdgwivcUJofuOldLMT/YPV61hyw5RK5V1X7olHmlnuIaGozxlXAzyizSRpm1+FmPF4ao0JMIi7cWqwu5/qq8gTvDUvJ5n0ACFXC1ew+LoX25rpEj++GJqP1OmoNFLAkwY76rKSYGmZ0jgnzyrnBoT4shPumY95SbI3K9xe3wvJ4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784197241; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=tZtJ9o1OGLraNBGTQRGuVYRTBcoj0U7p+LKhOmdV6NA=; b=eG1M8qfsX+Cj08fAQ5Nv9+OGvF+Jm54G199tAYI+CiZD6qxXKZFJY5fFhF6UVkv+IttMM0kJrprF2lwpEoXCkZewm+KXnSuoAiLOpI+DrKn0yMFTQdDJ4KS3Lh2SlHWOFO8SAVIyMzuDLS5DmaxCgRodFshA8zK6Ka5sxZk+F9k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1784197241747826.6086771159372; Thu, 16 Jul 2026 03:20:41 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wkJCS-00040y-GU; Thu, 16 Jul 2026 06:20:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wkJCP-00040B-6k for qemu-devel@nongnu.org; Thu, 16 Jul 2026 06:20:13 -0400 Received: from [115.124.30.110] (helo=out30-110.freemail.mail.aliyun.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wkJCI-00054p-Tt for qemu-devel@nongnu.org; Thu, 16 Jul 2026 06:20:12 -0400 Received: from localhost(mailfrom:guobin@linux.alibaba.com fp:SMTPD_---0X7E4g61_1784197195 cluster:ay36) by smtp.aliyun-inc.com; Thu, 16 Jul 2026 18:19:55 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1784197197; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=tZtJ9o1OGLraNBGTQRGuVYRTBcoj0U7p+LKhOmdV6NA=; b=coKg8z8Oes1houwTPr1LY3kJpATYt07V7J26VyN300TXHe0LGmNMf61rmDHPZb+i0apyeaS/M9QTc3Mtu0n2te1VFODacbtCBqG/lZn0gzmkFIbjeBzVb1KZT8Csg5BD9HvXsC28QnUqqDwZMeIo+yHpOyZ7CWII3DkrgbAMybw= X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R151e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=maildocker-contentspam033037009110; MF=guobin@linux.alibaba.com; NM=1; PH=DS; RN=3; SR=0; TI=SMTPD_---0X7E4g61_1784197195; From: Bin Guo To: qemu-devel@nongnu.org Cc: peterx@redhat.com, farosas@suse.de Subject: [PATCH 3/3] migration: clean up postcopy blocktime presentation Date: Thu, 16 Jul 2026 18:19:52 +0800 Message-ID: <20260716101952.65329-4-guobin@linux.alibaba.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260716101952.65329-1-guobin@linux.alibaba.com> References: <20260716101952.65329-1-guobin@linux.alibaba.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 115.124.30.110 (deferred) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=115.124.30.110; envelope-from=guobin@linux.alibaba.com; helo=out30-110.freemail.mail.aliyun.com X-Spam_score_int: -166 X-Spam_score: -16.7 X-Spam_bar: ---------------- X-Spam_report: (-16.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01, UNPARSEABLE_RELAY=0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linux.alibaba.com) X-ZM-MESSAGEID: 1784197243054158500 Content-Type: text/plain; charset="utf-8" Small cleanups for the postcopy blocktime fine-grained tracking feature: * Remove a redundant memset() on latency_buckets after g_new0(). * Use singular "Latency" in the HMP label for postcopy non-vCPU latency, consistent with other single-value labels. Signed-off-by: Bin Guo --- migration/migration-hmp-cmds.c | 2 +- migration/postcopy-ram.c | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/migration/migration-hmp-cmds.c b/migration/migration-hmp-cmds.c index 6bedf786df..4a18ca8bba 100644 --- a/migration/migration-hmp-cmds.c +++ b/migration/migration-hmp-cmds.c @@ -96,7 +96,7 @@ static void migration_dump_blocktime(Monitor *mon, Migrat= ionInfo *info) } =20 if (info->has_postcopy_non_vcpu_latency) { - monitor_printf(mon, "Postcopy non-vCPU Latencies (ns): %" PRIu64 "= \n", + monitor_printf(mon, "Postcopy non-vCPU Latency (ns): %" PRIu64 "\n= ", info->postcopy_non_vcpu_latency); } =20 diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c index 341cad264a..28d698260e 100644 --- a/migration/postcopy-ram.c +++ b/migration/postcopy-ram.c @@ -297,9 +297,6 @@ static struct PostcopyBlocktimeContext *blocktime_conte= xt_new(void) unsigned int smp_cpus =3D ms->smp.cpus; PostcopyBlocktimeContext *ctx =3D g_new0(PostcopyBlocktimeContext, 1); =20 - /* Initialize all counters to be zeros */ - memset(ctx->latency_buckets, 0, sizeof(ctx->latency_buckets)); - ctx->vcpu_blocktime_total =3D g_new0(uint64_t, smp_cpus); ctx->vcpu_faults_count =3D g_new0(uint64_t, smp_cpus); ctx->vcpu_faults_current =3D g_new0(uint8_t, smp_cpus); --=20 2.50.1 (Apple Git-155)