[v2] Support the ASPEED HACE crypto command

[PATCH v2 06/17] tests/qtest/aspeed-hace: Test the crypto command on the AST1030

Posted by Jamin Lin 1 month, 4 weeks ago

The AST1030 reuses the AST2600 crypto engine, so it drives the same
scatter-gather transfers and supports the same ECB/CBC/CTR modes. Reuse
the crypto known-answer tests to cover it, registering the AST1030 with
the same modes and scatter-gather flag as the AST2600.

Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
 tests/qtest/aspeed_hace-test.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tests/qtest/aspeed_hace-test.c b/tests/qtest/aspeed_hace-test.c
index 61a3e3feb5..42130df1e2 100644
--- a/tests/qtest/aspeed_hace-test.c
+++ b/tests/qtest/aspeed_hace-test.c
@@ -210,6 +210,12 @@ int main(int argc, char **argv)
     qtest_add_func("ast1030/hace/sha384_accum", test_sha384_accum_ast1030);
     qtest_add_func("ast1030/hace/sha256_accum", test_sha256_accum_ast1030);
 
+    /* The AST1030 reuses the AST2600 crypto engine (scatter-gather, CTR). */
+    aspeed_add_crypto_tests("ast1030", "-machine ast1030-evb", 0x7e6d0000,
+                            0x00000000,
+                            CRYPT_MODE_ECB | CRYPT_MODE_CBC | CRYPT_MODE_CTR,
+                            true);
+
     qtest_add_func("ast2600/hace/addresses", test_addresses_ast2600);
     qtest_add_func("ast2600/hace/sha512", test_sha512_ast2600);
     qtest_add_func("ast2600/hace/sha384", test_sha384_ast2600);
-- 
2.43.0

RE: [PATCH v2 06/17] tests/qtest/aspeed-hace: Test the crypto command on the AST1030

Posted by Kane Chen 1 month ago

> -----Original Message-----
> From: Jamin Lin <jamin_lin@aspeedtech.com>
> Sent: Wednesday, July 15, 2026 11:33 AM
> To: Daniel P. Berrangé <berrange@redhat.com>; Cédric Le Goater
> <clg@kaod.org>; Peter Maydell <peter.maydell@linaro.org>; Steven Lee
> <steven_lee@aspeedtech.com>; Troy Lee <leetroy@gmail.com>; Kane Chen
> <kane_chen@aspeedtech.com>; Andrew Jeffery
> <andrew@codeconstruct.com.au>; Joel Stanley <joel@jms.id.au>; Eric Blake
> <eblake@redhat.com>; Markus Armbruster <armbru@redhat.com>; Fabiano
> Rosas <farosas@suse.de>; Laurent Vivier <lvivier@redhat.com>; Paolo Bonzini
> <pbonzini@redhat.com>; open list:All patches CC here
> <qemu-devel@nongnu.org>; open list:ASPEED BMCs
> <qemu-arm@nongnu.org>
> Cc: Jamin Lin <jamin_lin@aspeedtech.com>; Troy Lee
> <troy_lee@aspeedtech.com>
> Subject: [PATCH v2 06/17] tests/qtest/aspeed-hace: Test the crypto command
> on the AST1030
> 
> The AST1030 reuses the AST2600 crypto engine, so it drives the same
> scatter-gather transfers and supports the same ECB/CBC/CTR modes. Reuse
> the crypto known-answer tests to cover it, registering the AST1030 with the
> same modes and scatter-gather flag as the AST2600.
> 
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
> ---
>  tests/qtest/aspeed_hace-test.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/tests/qtest/aspeed_hace-test.c b/tests/qtest/aspeed_hace-test.c
> index 61a3e3feb5..42130df1e2 100644
> --- a/tests/qtest/aspeed_hace-test.c
> +++ b/tests/qtest/aspeed_hace-test.c
> @@ -210,6 +210,12 @@ int main(int argc, char **argv)
>      qtest_add_func("ast1030/hace/sha384_accum",
> test_sha384_accum_ast1030);
>      qtest_add_func("ast1030/hace/sha256_accum",
> test_sha256_accum_ast1030);
> 
> +    /* The AST1030 reuses the AST2600 crypto engine (scatter-gather, CTR).
> */
> +    aspeed_add_crypto_tests("ast1030", "-machine ast1030-evb",
> 0x7e6d0000,
> +                            0x00000000,
> +                            CRYPT_MODE_ECB | CRYPT_MODE_CBC |
> CRYPT_MODE_CTR,
> +                            true);
> +
>      qtest_add_func("ast2600/hace/addresses", test_addresses_ast2600);
>      qtest_add_func("ast2600/hace/sha512", test_sha512_ast2600);
>      qtest_add_func("ast2600/hace/sha384", test_sha384_ast2600);
> --
> 2.43.0

Reviewed-by: Kane Chen <kane_chen@aspeedtech.com>