hw/ppc: reorg PowerPC RAS code for better maintainability

[PATCH 2/3] MAINTAINERS: add dedicated PowerPC RAS section

Posted by Shivang Upadhyay 2 months ago

Introduce a new "PowerPC RAS (Reliability, Availability and
Serviceability)" entry in the PowerPC Machines block, replacing the
existing Fadump/MPIPL sections. Retaining the maintainer and
reviewer entries from Fadump/MPIPL sections for this broader umbrella.

Additionally adding spapr_events.c, as it implements RTAS error logging
infrastructure and spapr_pci_vfio.c, since its all EEH related code.

Signed-off-by: Shivang Upadhyay <shivangu@linux.ibm.com>
---
 MAINTAINERS | 32 +++++++++++++++-----------------
 1 file changed, 15 insertions(+), 17 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index e25df9493c..4a010d4807 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1745,6 +1745,21 @@ F: include/hw/ppc/vof*
 F: pc-bios/vof/*
 F: pc-bios/vof*
 
+PowerPC RAS (Reliability, Availability and Serviceability)
+M: Aditya Gupta <adityag@linux.ibm.com>
+R: Sourabh Jain <sourabhjain@linux.ibm.com>
+R: Hari Bathini <hbathini@linux.ibm.com>
+L: qemu-ppc@nongnu.org
+S: Maintained
+F: hw/ppc/spapr_events.c
+F: hw/ppc/spapr_fadump.c
+F: hw/ppc/spapr_pci_vfio.c
+F: hw/ppc/spapr_rtas_ras.c
+F: hw/ppc/pnv_mpipl.c
+F: include/hw/ppc/spapr_fadump.h
+F: include/hw/ppc/pnv_mpipl.h
+F: tests/functional/ppc64/test_fadump.py
+
 RISC-V Machines
 ---------------
 OpenTitan
@@ -3361,23 +3376,6 @@ F: scripts/coccinelle/remove_local_err.cocci
 F: scripts/coccinelle/use-error_fatal.cocci
 F: scripts/coccinelle/errp-guard.cocci
 
-Firmware Assisted Dump (fadump) for sPAPR (pseries)
-M: Aditya Gupta <adityag@linux.ibm.com>
-R: Sourabh Jain <sourabhjain@linux.ibm.com>
-S: Maintained
-F: include/hw/ppc/spapr_fadump.h
-F: hw/ppc/spapr_fadump.c
-F: tests/functional/ppc64/test_fadump.py
-
-Memory-Preserving Initial Program Load (MPIPL) for PowerNV
-M: Aditya Gupta <adityag@linux.ibm.com>
-R: Hari Bathini <hbathini@linux.ibm.com>
-R: Sourabh <sourabhjain@linux.ibm.com>
-S: Maintained
-F: include/hw/ppc/pnv_mpipl.h
-F: hw/ppc/pnv_mpipl.c
-F: tests/functional/ppc64/test_fadump.py
-
 GDB stub
 M: Alex Bennée <alex.bennee@linaro.org>
 R: Philippe Mathieu-Daudé <philmd@mailo.com>
-- 
2.54.0

Re: [PATCH 2/3] MAINTAINERS: add dedicated PowerPC RAS section

Posted by Sourabh Jain 4 weeks ago


On 14/07/26 22:17, Shivang Upadhyay wrote:
> Introduce a new "PowerPC RAS (Reliability, Availability and
> Serviceability)" entry in the PowerPC Machines block, replacing the
> existing Fadump/MPIPL sections. Retaining the maintainer and
> reviewer entries from Fadump/MPIPL sections for this broader umbrella.
>
> Additionally adding spapr_events.c, as it implements RTAS error logging
> infrastructure and spapr_pci_vfio.c, since its all EEH related code.
>
> Signed-off-by: Shivang Upadhyay <shivangu@linux.ibm.com>
> ---
>   MAINTAINERS | 32 +++++++++++++++-----------------
>   1 file changed, 15 insertions(+), 17 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e25df9493c..4a010d4807 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1745,6 +1745,21 @@ F: include/hw/ppc/vof*
>   F: pc-bios/vof/*
>   F: pc-bios/vof*
>   
> +PowerPC RAS (Reliability, Availability and Serviceability)
> +M: Aditya Gupta <adityag@linux.ibm.com>
> +R: Sourabh Jain <sourabhjain@linux.ibm.com>
> +R: Hari Bathini <hbathini@linux.ibm.com>
> +L: qemu-ppc@nongnu.org
> +S: Maintained
> +F: hw/ppc/spapr_events.c
> +F: hw/ppc/spapr_fadump.c
> +F: hw/ppc/spapr_pci_vfio.c
> +F: hw/ppc/spapr_rtas_ras.c

As there is a suggestion to drop the 1/3, some of the above file names 
need to be
corrected accordingly. The rest of the changes look good to me.

Feel free to include in 2/3 and 3/3:

Acked-by: Sourabh Jain <sourabhjain@linux.ibm.com>


> +F: hw/ppc/pnv_mpipl.c
> +F: include/hw/ppc/spapr_fadump.h
> +F: include/hw/ppc/pnv_mpipl.h
> +F: tests/functional/ppc64/test_fadump.py
> +
>   RISC-V Machines
>   ---------------
>   OpenTitan
> @@ -3361,23 +3376,6 @@ F: scripts/coccinelle/remove_local_err.cocci
>   F: scripts/coccinelle/use-error_fatal.cocci
>   F: scripts/coccinelle/errp-guard.cocci
>   
> -Firmware Assisted Dump (fadump) for sPAPR (pseries)
> -M: Aditya Gupta <adityag@linux.ibm.com>
> -R: Sourabh Jain <sourabhjain@linux.ibm.com>
> -S: Maintained
> -F: include/hw/ppc/spapr_fadump.h
> -F: hw/ppc/spapr_fadump.c
> -F: tests/functional/ppc64/test_fadump.py
> -
> -Memory-Preserving Initial Program Load (MPIPL) for PowerNV
> -M: Aditya Gupta <adityag@linux.ibm.com>
> -R: Hari Bathini <hbathini@linux.ibm.com>
> -R: Sourabh <sourabhjain@linux.ibm.com>
> -S: Maintained
> -F: include/hw/ppc/pnv_mpipl.h
> -F: hw/ppc/pnv_mpipl.c
> -F: tests/functional/ppc64/test_fadump.py
> -
>   GDB stub
>   M: Alex Bennée <alex.bennee@linaro.org>
>   R: Philippe Mathieu-Daudé <philmd@mailo.com>

Re: [PATCH 2/3] MAINTAINERS: add dedicated PowerPC RAS section

Posted by Aditya Gupta 4 weeks ago

On 14/07/26 22:17, Shivang Upadhyay wrote:

> Introduce a new "PowerPC RAS (Reliability, Availability and
> Serviceability)" entry in the PowerPC Machines block, replacing the
> existing Fadump/MPIPL sections. Retaining the maintainer and
> reviewer entries from Fadump/MPIPL sections for this broader umbrella.
>
> Additionally adding spapr_events.c, as it implements RTAS error logging
> infrastructure and spapr_pci_vfio.c, since its all EEH related code.
>
> Signed-off-by: Shivang Upadhyay <shivangu@linux.ibm.com>

Good to have a common entry for RAS. Looks good to me.

Acked-by: Aditya Gupta <adityag@linux.ibm.com>


Thanks,

- Aditya G