From nobody Sat Jul 25 21:20:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1783959409; cv=none; d=zohomail.com; s=zohoarc; b=MN4jJVX8dTQc8HHRqxaIhbJaArEGqGLSGDyXrSnCUGjauHSbEkqX8YYOl13Wv2jC2aX4MAW5LPAMrSXksguo2156orkYgVGXw4KGnCDydz1vNGyAZG/U/SuLnWs5ilIStEMmiX8VQl4llfMiFv4qA8Z6tUNkb3nxPuz9yfj6Uq8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783959409; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=XPlGJFyu+y5EyZy0Bsg+GltpOP2CIqZxcPgX7AOCiTE=; b=g4DTGiKeNCLrjW87I13jpzakNpQwtDme4evWNfCy8KByO9VnOyg89nwZad2a/Djfwk1ve045iqHhHucgXzJq8o/JIk8/69AZwwse2ks2vGukmrZC5yFxzARuxCQ4WHe/FQHKLIMiWe94IaKE4AzWycINXjCci488+t5uppPEvHo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783959409270590.2813796322993; Mon, 13 Jul 2026 09:16:49 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wjJKa-0008FN-NX; Mon, 13 Jul 2026 12:16:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wjJJF-0007B3-JM for qemu-devel@nongnu.org; Mon, 13 Jul 2026 12:15:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wjJJB-0007PW-4H for qemu-devel@nongnu.org; Mon, 13 Jul 2026 12:15:08 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-101-H7M3g2Q9OA-WT0yCafRbqQ-1; Mon, 13 Jul 2026 12:14:16 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3E60118052C1; Mon, 13 Jul 2026 16:14:15 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.48.15]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 472331771; Mon, 13 Jul 2026 16:14:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783959260; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XPlGJFyu+y5EyZy0Bsg+GltpOP2CIqZxcPgX7AOCiTE=; b=Ez7WPEn6QBcG9LO3q/NjBvuHuBSrcFoIpriZo70ylHRtOZkS9tbaVL29RYPFRDcrFQ3z05 PUjYxVfObE7b2sW/TCx4lFEfATpsCIQV9rdccE8rsugv+J46bX02M2ysmEss3QluTBPjsy 7igBwXxYgs84BONe0wLACbfOWonG0X0= X-MC-Unique: H7M3g2Q9OA-WT0yCafRbqQ-1 X-Mimecast-MFC-AGG-ID: H7M3g2Q9OA-WT0yCafRbqQ_1783959255 From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Gerd Hoffmann , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v4 1/3] hw/usb/hcd-xhci: Turn guest-triggerable abort() into qemu_log_mask() Date: Mon, 13 Jul 2026 18:14:04 +0200 Message-ID: <20260713161406.361197-2-thuth@redhat.com> In-Reply-To: <20260713161406.361197-1-thuth@redhat.com> References: <20260713161406.361197-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: permerror client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.01, SPF_HELO_PASS=-0.001, T_SPF_PERMERROR=0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1783959411242158500 From: Thomas Huth The FIXME macros in xhci_alloc_device_streams() can be triggered by a (malicious) guest. Since the macro also contains an abort() statement, this terminates QEMU. Turn the FIXME statements into a qemu_log_mask() instead to avoid that a guest can shoot itself this way. Reported-by: Feifan Qian Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3784 Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Thomas Huth --- hw/usb/hcd-xhci.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 2cdab3ba0e4..f5bb7d25600 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -965,11 +965,13 @@ static TRBCCode xhci_alloc_device_streams(XHCIState *= xhci, unsigned int slotid, * together and make an usb_device_alloc_streams call per group. */ if (epctxs[i]->nr_pstreams !=3D req_nr_streams) { - FIXME("guest streams config not identical for all eps"); + qemu_log_mask(LOG_UNIMP, + "guest streams config not identical for all eps\= n"); return CC_RESOURCE_ERROR; } if (eps[i]->max_streams !=3D dev_max_streams) { - FIXME("device streams config not identical for all eps"); + qemu_log_mask(LOG_UNIMP, + "device streams config not identical for all eps= \n"); return CC_RESOURCE_ERROR; } } --=20 2.55.0 From nobody Sat Jul 25 21:20:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1783959363; cv=none; d=zohomail.com; s=zohoarc; b=Sa3j5DAZd4naHK/ltOVIYIpnDv+p7HaNB69uawEqvKfxw2lVrdEVkDNRoHCrMfcuV963f+bd3BkYgoIlOtejYerV+pqw7fI8Iu7NWzvuGOFUucrCP2PWOFMpII/OIUpGpVjoIaPOcNiOcJyiRyV4/l2QZGhdHtxr1A17LcciiYM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783959363; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=HTOMK3fcmMCkp4dhDMZgh5tSVKGqnbXYTq2/OhZjHXc=; b=Uh3jl6t+37Fpb1gk1JfVSIHNG0BzYb2q3wsSSanMA4oSoWLgU/9IlXWhmhfq4vA/aOEtbTdet8kfb0EkE3JXcTMpN3OYH7LYL4S0ELWhFdy7/oV5/KbOlF2RqIGwzeZWkOkCXwTRrtXLF8huwiur3RSzHsnHGA0gGFRzb/ph/V0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783959363128423.83188214670895; Mon, 13 Jul 2026 09:16:03 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wjJJg-0007R9-7W; Mon, 13 Jul 2026 12:15:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wjJIv-00076i-Id for qemu-devel@nongnu.org; Mon, 13 Jul 2026 12:14:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wjJIo-0007Pq-5g for qemu-devel@nongnu.org; Mon, 13 Jul 2026 12:14:46 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-696-w8V0s9PHNxSxcLdb2Zl3Pw-1; Mon, 13 Jul 2026 12:14:19 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 951061955D50; Mon, 13 Jul 2026 16:14:18 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.48.15]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E372F765; Mon, 13 Jul 2026 16:14:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783959261; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HTOMK3fcmMCkp4dhDMZgh5tSVKGqnbXYTq2/OhZjHXc=; b=N0UlcAv/MFseH0ujww6IjATbJ/0hNkOgRQj5GzjKsp62K7dP+GvTnPXCCvWR0rNpB9mrFd xa5jEAts+hHnyOWk7nlJrZAWhIBQKRTWXj2Sk6sjwbgw/ODSlaKqGotOmdp3Oa6j9BNBLl Ef/RvawanPrfI51tajp8UjeWngYx6EY= X-MC-Unique: w8V0s9PHNxSxcLdb2Zl3Pw-1 X-Mimecast-MFC-AGG-ID: w8V0s9PHNxSxcLdb2Zl3Pw_1783959258 From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Gerd Hoffmann , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v4 2/3] hw/usb/hcd-xhci: Remove the FIXME macro Date: Mon, 13 Jul 2026 18:14:05 +0200 Message-ID: <20260713161406.361197-3-thuth@redhat.com> In-Reply-To: <20260713161406.361197-1-thuth@redhat.com> References: <20260713161406.361197-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: permerror client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, T_SPF_PERMERROR=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1783959365544158500 From: Thomas Huth The FIXME macro is only used in one case, which should hopefully never trigger: The containing function handles all the USB_RET_* values except for USB_RET_ADD_TO_QUEUE and USB_RET_REMOVE_FROM_QUEUE, which are both internal return values for when an async packet needs to be queued or dequeued, and which shouldn't still be the status by the time we get to this function. Thus let's simplify this spot and use a g_assert_not_reached() instead (and remove the DPRINT() in front of it to avoid that code analyzers trip over unreachable code here). Suggested-by: Peter Maydell Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Thomas Huth --- hw/usb/hcd-xhci.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index f5bb7d25600..cc61e28d33b 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -39,8 +39,6 @@ #else #define DPRINTF(...) do {} while (0) #endif -#define FIXME(_msg) do { fprintf(stderr, "FIXME %s:%d %s\n", \ - __func__, __LINE__, _msg); abort(); } whi= le (0) =20 #define TRB_LINK_LIMIT 32 #define COMMAND_LIMIT 256 @@ -1673,9 +1671,7 @@ static int xhci_try_complete_packet(XHCITransfer *xfe= r) xhci_stall_ep(xfer); break; default: - DPRINTF("%s: FIXME: status =3D %d\n", __func__, - xfer->packet.status); - FIXME("unhandled USB_RET_*"); + g_assert_not_reached(); } return 0; } --=20 2.55.0 From nobody Sat Jul 25 21:20:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1783959312; cv=none; d=zohomail.com; s=zohoarc; b=GgrhFU1OfzX0nXumNWVt4058rfQ8jyoEqqWw2hVpmhi/zOfMkK/FsC/DFxgSFCU3eY1s880LQ0dHXD1oDO9Boi5xseMrE7+MNXy45Iee1yLf7QBGLoxPwj7CcRpPokkucWHH6HVWHt78xc5rdRrJiVExIOhywwCaKrRDoHApiE4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783959312; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=QXFvKHZafWQB2aCCxVGPAVGhoy2QEIBhjBUYjxwcq5k=; b=kXtigoF7lThNtJqNQadQV3356ChQV8/D+lBKYZvuQ0ICEJlsfHuhqErrBUgHYqZPVbVbcQiI+2EaQbQ8/DRRULU/OZ2mGhklDhyhia7+UL0xQ8vjp1LBkyMhRag1cNzZHQt2Cmg3StulDhbjY5IOGBfKS7dZcRrDXGHSBvnd1sk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783959312188787.0345860348515; Mon, 13 Jul 2026 09:15:12 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wjJJ3-00077P-OY; Mon, 13 Jul 2026 12:14:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wjJIv-00076h-6X for qemu-devel@nongnu.org; Mon, 13 Jul 2026 12:14:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wjJIi-0007RW-Qk for qemu-devel@nongnu.org; Mon, 13 Jul 2026 12:14:45 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-108-0cjrd41LNymmr3UACLkP7g-1; Mon, 13 Jul 2026 12:14:23 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B086918052F9; Mon, 13 Jul 2026 16:14:21 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.48.15]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 39976765; Mon, 13 Jul 2026 16:14:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783959268; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QXFvKHZafWQB2aCCxVGPAVGhoy2QEIBhjBUYjxwcq5k=; b=QFfxdHrv0sSak2d3jgVIVrb5H337zXfs0rkNqtke4vSwUhd+hMe80CoQpRf+7Luite/V5s LSfOIbf2aemHnp+y2O7FuCpyxPN8EN78XGl4IIcqNNogGKNoU2M8wB28ZIep1F7y/+AulT ZmprwdVeu8xKQrrtfdNTYtCaxOcOB8E= X-MC-Unique: 0cjrd41LNymmr3UACLkP7g-1 X-Mimecast-MFC-AGG-ID: 0cjrd41LNymmr3UACLkP7g_1783959261 From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Gerd Hoffmann , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v4 3/3] hw/usb/hcd-xhci: Use qemu_log_mask() instead of fprintf() statement Date: Mon, 13 Jul 2026 18:14:06 +0200 Message-ID: <20260713161406.361197-4-thuth@redhat.com> In-Reply-To: <20260713161406.361197-1-thuth@redhat.com> References: <20260713161406.361197-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: permerror client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, T_SPF_PERMERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1783959313256158500 Content-Type: text/plain; charset="utf-8" From: Thomas Huth We've got a proper way for logging unimplemented hardware features, so use qemu_log_mask() instead of the fprintf() here now. Suggested-by: Peter Maydell Reviewed-by: Peter Maydell Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/usb/hcd-xhci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index cc61e28d33b..c7e050e38fd 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -1017,7 +1017,8 @@ static XHCIStreamContext *xhci_find_stream(XHCIEPCont= ext *epctx, } sctx =3D epctx->pstreams + streamid; } else { - fprintf(stderr, "xhci: FIXME: secondary streams not implemented ye= t"); + qemu_log_mask(LOG_UNIMP, + "xhci: secondary streams not implemented yet\n"); *cc_error =3D CC_INVALID_STREAM_TYPE_ERROR; return NULL; } --=20 2.55.0