From nobody Sat Jul 25 22:03:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1783937149; cv=none; d=zohomail.com; s=zohoarc; b=mhvFxiamSpRhRYKQSyw/IkWw+1c3vjz8NmCVnzaNtZjXF92JSv9eWrToExzf1uf0jEhrelv5rEf3ngGnfSkZnjG7fwsg10M8wMQVSTnJquGY6DBhbDciBjpBf5jLPUcmFA1ii6KgEOyRDpavtO+gPU2Hvqli9Sau/7aP9pZjBnw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783937149; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=XPlGJFyu+y5EyZy0Bsg+GltpOP2CIqZxcPgX7AOCiTE=; b=gkt+ThwrE1++90uD1QeSOOE8YixbRKKfHLiVqdUv++LxLJvHLZanXQ37LHIdyptR49XCjG7NzE/YHC5d7VZz4Xzt7015cdr7Ys+I3vnSnOQMWNdRzzl7c17c6gE55UuaBajN1eOFO8ggN8+iNrLRTAh3deH8jzH/lOE7vKd51EE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783937149881146.5803389903573; Mon, 13 Jul 2026 03:05:49 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wjDXT-0006Kw-Pg; Mon, 13 Jul 2026 06:05:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wjDXQ-0006Jc-0O for qemu-devel@nongnu.org; Mon, 13 Jul 2026 06:05:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wjDXO-0006S0-9s for qemu-devel@nongnu.org; Mon, 13 Jul 2026 06:05:23 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-221-hZ0yhOvTOim-ju9e6fWmVA-1; Mon, 13 Jul 2026 06:05:18 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CBA811955DA4; Mon, 13 Jul 2026 10:05:16 +0000 (UTC) Received: from thuth-p1g4.redhat.corp (headnet03.pony-001.prod.iad2.dc.redhat.com [10.2.32.114]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 984C61686; Mon, 13 Jul 2026 10:05:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783937121; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XPlGJFyu+y5EyZy0Bsg+GltpOP2CIqZxcPgX7AOCiTE=; b=FgRkCFRMJgCm3bxSo0ONG3Oihe/LAeTDhE5Ft+IpZ8cnYSRjuMcSO4T8BtBttBVsE4tTdc tBuHzZrn0haQsW/0adMd3C8faB8SEbN/rX+oneIkgm2UBiWFxjg47zMD2yynT9WJNda5BI MR7kmTvgNII3c56qFGxKHo12nzr7Id8= X-MC-Unique: hZ0yhOvTOim-ju9e6fWmVA-1 X-Mimecast-MFC-AGG-ID: hZ0yhOvTOim-ju9e6fWmVA_1783937117 From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Gerd Hoffmann , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 1/3] hw/usb/hcd-xhci: Turn guest-triggerable abort() into qemu_log_mask() Date: Mon, 13 Jul 2026 12:05:06 +0200 Message-ID: <20260713100508.123623-2-thuth@redhat.com> In-Reply-To: <20260713100508.123623-1-thuth@redhat.com> References: <20260713100508.123623-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: permerror client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, T_SPF_PERMERROR=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1783937151025158500 From: Thomas Huth The FIXME macros in xhci_alloc_device_streams() can be triggered by a (malicious) guest. Since the macro also contains an abort() statement, this terminates QEMU. Turn the FIXME statements into a qemu_log_mask() instead to avoid that a guest can shoot itself this way. Reported-by: Feifan Qian Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3784 Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Thomas Huth Reviewed-by: Peter Maydell --- hw/usb/hcd-xhci.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 2cdab3ba0e4..f5bb7d25600 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -965,11 +965,13 @@ static TRBCCode xhci_alloc_device_streams(XHCIState *= xhci, unsigned int slotid, * together and make an usb_device_alloc_streams call per group. */ if (epctxs[i]->nr_pstreams !=3D req_nr_streams) { - FIXME("guest streams config not identical for all eps"); + qemu_log_mask(LOG_UNIMP, + "guest streams config not identical for all eps\= n"); return CC_RESOURCE_ERROR; } if (eps[i]->max_streams !=3D dev_max_streams) { - FIXME("device streams config not identical for all eps"); + qemu_log_mask(LOG_UNIMP, + "device streams config not identical for all eps= \n"); return CC_RESOURCE_ERROR; } } --=20 2.55.0 From nobody Sat Jul 25 22:03:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1783937179; cv=none; d=zohomail.com; s=zohoarc; b=Ehe1NKT6GZYRrtDyGeqpWIpePXXlqUlPZpAlzEG4IcL7Vce5K+FZ2ThXOfPD1nuodPH0cZRqjWJFJZhldDCBvbprNB2sXkyczunimy+uDhabOBIrrOsQPz1CDLhmmTIpeMkGKDOXLzg3dcAbyFz8o3AVNOzxqIHa5hIEvMOUgtQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783937179; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=vu5+x+nHAb3ctlgrRKS2jMLxdHzuLJf8Jvx8rPiRhkE=; b=jDaI5HA7DXz3cVyJdhFX50yWl4jDBJ8L6emZThn+vopnoXecQI4fbDwGhnpB5cqbteN46SLOfemtnTgnxsFD8UF31xqabh4p47gX7MIt3EPxKHOtpI4rnad/aGN/9GqoMI5WmtZZYjq+oZ8G5irRRMinW8Q2pab1E3oIc/MGCEo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783937179941536.035492645212; Mon, 13 Jul 2026 03:06:19 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wjDXV-0006M1-QX; Mon, 13 Jul 2026 06:05:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wjDXT-0006Ku-EF for qemu-devel@nongnu.org; Mon, 13 Jul 2026 06:05:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wjDXR-0006SY-Ks for qemu-devel@nongnu.org; Mon, 13 Jul 2026 06:05:27 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-287-BR4si9kjNQaazprRvy6OHw-1; Mon, 13 Jul 2026 06:05:20 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CFFE11955DB3; Mon, 13 Jul 2026 10:05:19 +0000 (UTC) Received: from thuth-p1g4.redhat.corp (headnet03.pony-001.prod.iad2.dc.redhat.com [10.2.32.114]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 537881686; Mon, 13 Jul 2026 10:05:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783937124; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vu5+x+nHAb3ctlgrRKS2jMLxdHzuLJf8Jvx8rPiRhkE=; b=ZYsy0Bgjgu9M1MDTZEikdfhMHUZVgsnL6+s3/yISEGmyZmA1NIQIg/K11BZ5dxRh5RKSq8 U3wfz/mPEO8N1QoEE1zjsUfMzmbjXX1z09RLPXdwdBavBN8xC3tazOXIXNtMPQ/je/r1d6 +XLyBUJ8wt0lIMGrdGehf4/VA58nss4= X-MC-Unique: BR4si9kjNQaazprRvy6OHw-1 X-Mimecast-MFC-AGG-ID: BR4si9kjNQaazprRvy6OHw_1783937119 From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Gerd Hoffmann , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 2/3] hw/usb/hcd-xhci: Remove the FIXME macro Date: Mon, 13 Jul 2026 12:05:07 +0200 Message-ID: <20260713100508.123623-3-thuth@redhat.com> In-Reply-To: <20260713100508.123623-1-thuth@redhat.com> References: <20260713100508.123623-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: permerror client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, T_SPF_PERMERROR=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1783937181195158500 Content-Type: text/plain; charset="utf-8" From: Thomas Huth The FIXME macro is only used in one case, which should hopefully never trigger: The containing function handles all the USB_RET_* values except for USB_RET_ADD_TO_QUEUE and USB_RET_REMOVE_FROM_QUEUE, which are both internal return values for when an async packet needs to be queued or dequeued, and which shouldn't still be the status by the time we get to this function. Thus let's simplify this spot and use a g_assert_not_reached() instead. Suggested-by: Peter Maydell Signed-off-by: Thomas Huth Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/usb/hcd-xhci.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index f5bb7d25600..ee913d5c4d5 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -39,8 +39,6 @@ #else #define DPRINTF(...) do {} while (0) #endif -#define FIXME(_msg) do { fprintf(stderr, "FIXME %s:%d %s\n", \ - __func__, __LINE__, _msg); abort(); } whi= le (0) =20 #define TRB_LINK_LIMIT 32 #define COMMAND_LIMIT 256 @@ -1675,7 +1673,7 @@ static int xhci_try_complete_packet(XHCITransfer *xfe= r) default: DPRINTF("%s: FIXME: status =3D %d\n", __func__, xfer->packet.status); - FIXME("unhandled USB_RET_*"); + g_assert_not_reached(); } return 0; } --=20 2.55.0 From nobody Sat Jul 25 22:03:31 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1783937145; cv=none; d=zohomail.com; s=zohoarc; b=cxR88MZBsIHScZs1Pr+qr5mNIvX7zeQ3Tg+n3DjDUcr9lZPFGmNq49BxBtz3oiLnLrQcoBjJxJRNJZv09bstI1+64QbVWYFqJYfNVBBMzI0O85lPCumNvRhlXCqP5tGBxQL0T+z2woWuiT0gHG5j+ZSiTSxgoN7fV7b7mrHKCp8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783937145; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=VOJwklUEQ8Mub0KPu+2trNh461ZWY5s7bnxYeKpK3vE=; b=hSZQ61u6grkxt06H50NZ5AFCN4pn5sP5HdxZYTuisE83lklmXRiguD2Lz9TbDBAStSvo+pitG7a3IqC/5VsBhKt9BYx5cVAT4p+ltR+Y3/AIRYOKkC54dISDWC3VrmvHEiFoxOdRZPhyDLRAqiLMjR4lv4bzQK8N+9T7XVG1XcU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783937144966182.4941300162352; Mon, 13 Jul 2026 03:05:44 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wjDXY-0006MS-P2; Mon, 13 Jul 2026 06:05:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wjDXT-0006Kx-Lb for qemu-devel@nongnu.org; Mon, 13 Jul 2026 06:05:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wjDXS-0006Sf-6c for qemu-devel@nongnu.org; Mon, 13 Jul 2026 06:05:27 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-609-8SIJIqQVPuuYwc0XKp7tWw-1; Mon, 13 Jul 2026 06:05:23 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 94B0118009F0; Mon, 13 Jul 2026 10:05:22 +0000 (UTC) Received: from thuth-p1g4.redhat.corp (headnet03.pony-001.prod.iad2.dc.redhat.com [10.2.32.114]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 59EBC36919; Mon, 13 Jul 2026 10:05:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783937125; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VOJwklUEQ8Mub0KPu+2trNh461ZWY5s7bnxYeKpK3vE=; b=YVPEMr/XzspK+KOVR+AGSAnomcsXZuaqUIa8ZvbC4G74LcEktA8L0IRCZT+/EGG3Oqu+aM TJfBSgWHVDHaasXSOb6kkMlC4pWYyC0Ip7hpASHFLUtOl2WGDPeOpR6gnQwdGPTffnlKM9 ybvd4tQCkbibrPCIbC1ziMI4BFVIDHc= X-MC-Unique: 8SIJIqQVPuuYwc0XKp7tWw-1 X-Mimecast-MFC-AGG-ID: 8SIJIqQVPuuYwc0XKp7tWw_1783937122 From: Thomas Huth To: qemu-devel@nongnu.org, Peter Maydell Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Gerd Hoffmann , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 3/3] hw/usb/hcd-xhci: Use qemu_log_mask() instead of fprintf() statement Date: Mon, 13 Jul 2026 12:05:08 +0200 Message-ID: <20260713100508.123623-4-thuth@redhat.com> In-Reply-To: <20260713100508.123623-1-thuth@redhat.com> References: <20260713100508.123623-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: permerror client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, T_SPF_PERMERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1783937147189158500 Content-Type: text/plain; charset="utf-8" From: Thomas Huth We've got a proper way for logging unimplemented hardware features, so use qemu_log_mask() instead of the fprintf() here now. Suggested-by: Peter Maydell Signed-off-by: Thomas Huth Reviewed-by: Peter Maydell --- hw/usb/hcd-xhci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index ee913d5c4d5..527910d92d2 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -1017,7 +1017,8 @@ static XHCIStreamContext *xhci_find_stream(XHCIEPCont= ext *epctx, } sctx =3D epctx->pstreams + streamid; } else { - fprintf(stderr, "xhci: FIXME: secondary streams not implemented ye= t"); + qemu_log_mask(LOG_UNIMP, + "xhci: secondary streams not implemented yet"); *cc_error =3D CC_INVALID_STREAM_TYPE_ERROR; return NULL; } --=20 2.55.0