From nobody Sun Jul 12 00:39:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1783694509; cv=none; d=zohomail.com; s=zohoarc; b=KIXJZngq6hQQ6hSDB1tFXuHKXtU3v/jtppPp5Nv5/k90fez5/7ZpfJAym2H8s8Ux7Y4u0KUC3q71poO0sbEeA0nWJUDM2rquNRcX+SRT0pAVi5CMXZEjoYJEtPmDjmO5StF3CkTroaEDzXniDw58P8s5ny0/AIS21gpbUBwhXLw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783694509; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=QPWJeCNNngU7FqaVsznAi5bRHUfWVCKx5JmJR5Xq2Tw=; b=a0H45d9hxBewNdUkelt2tPK4Kd3ganfF3qIKi/0l34SYtBwC1ienUt4mjPrwjCFxYrnU0YHGYVY/t52OxLCjMbvtRk+4M6Jukqztz78NGxu9l0Y2UcDWIU9XMSzIOFSPSM2l3bYNn40OXW7yBE0x97Zq9d3RAO96OYCCsjN7Fcc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783694509532236.10669533663793; Fri, 10 Jul 2026 07:41:49 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wiCPx-0000mP-PK; Fri, 10 Jul 2026 10:41:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wiCPq-0000h3-LK for qemu-devel@nongnu.org; Fri, 10 Jul 2026 10:41:24 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wiCPl-0005VO-7E for qemu-devel@nongnu.org; Fri, 10 Jul 2026 10:41:19 -0400 Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66ADIGCP971305; Fri, 10 Jul 2026 14:41:13 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4f6sw5797h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 10 Jul 2026 14:41:13 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 66AEYciQ013526; Fri, 10 Jul 2026 14:41:12 GMT Received: from smtprelay02.dal12v.mail.ibm.com ([172.16.1.4]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4f7e0htb7s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 10 Jul 2026 14:41:12 +0000 (GMT) Received: from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com [10.39.53.230]) by smtprelay02.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 66AEfBtM62325224 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 10 Jul 2026 14:41:11 GMT Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 82F5A58054; Fri, 10 Jul 2026 14:41:11 +0000 (GMT) Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 047AC5805A; Fri, 10 Jul 2026 14:41:11 +0000 (GMT) Received: from sbct-3.pok.ibm.com (unknown [9.47.158.153]) by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP; Fri, 10 Jul 2026 14:41:10 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=QPWJeCNNngU7FqaVs znAi5bRHUfWVCKx5JmJR5Xq2Tw=; b=Xw5wCYHU9DBrIf0aMNxyB6kBmnsOBAbrT 2cDU6hSw7Wql75RNu8wzWvwrgFLc0ymCnbQ3TA4tJgfryeLaDtd66AuIYvgpySjW 6oTziZ2iOcJ9UqI5dqqtoOS7ZK+u7j4TLvIE3UU+I50H4eUZgy6xWTfQixeCXdBe JOp4GU1cj6a0SSy9NA0r3u5dAdxZbTc0MlL83EssEEkof3lmKPh/pXKr4aV49P9Z XR9NatRYLxOMngyrToD00qLQoSbOFwPn/rCPm6PLw1eQHe7t1wBc6T/Md/aPojjT rlkLfHa10hgHPRrDfe2iUAgczGNKurG4Yi7Rt0a+E7+WZRrkN7x0g== From: Stefan Berger To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Mohammadfaiz Bawa , Stefan Berger Subject: [PULL v1 1/3] hw/core/platform-bus: guard platform_bus_get_mmio_addr() against NULL Date: Fri, 10 Jul 2026 10:41:06 -0400 Message-ID: <20260710144108.621828-2-stefanb@linux.ibm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260710144108.621828-1-stefanb@linux.ibm.com> References: <20260710144108.621828-1-stefanb@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-GUID: wtW4jHzerNpnWVcuJXKUapm8NwMeGtkY X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEwMDE0MiBTYWx0ZWRfX13u+0NtAhhn2 5dU7dI7UuCsuCoVQdOwOzH1DE1+XWm41Lc90fyOy3o2TGIuOO9UKjSkcYQANnB0AHifgGB32fnE IovoXt/7Oo4CSENIN7dH+AjPcQqUhLKFo5bg9PFocxcqWnjoWUiRk3mM8NP+QQ4Op3FF970I6rd Le6z2kThO5uGOss8wdTiog3q6hmeh3RYjnjZUt7O7duQzPpoF7pE0Y+7jUBl5AwWM/ArphLbiL1 M7xO6ShTR/d9P6R0NHuFD/43ErYfM1qNvHWb0Rz6azBZ/Z7ZGMfETvpVtn1xNkZHf80odo/5WLh o5PgbjAAJRKg29BOMTdwsSZO/vBoN8C5IOPlkXHKtzZG4bKJCpCqwJTEY1R5gDmmrrGQ4dsP3K7 yNtpKZTQwsw6CrHSra8MaALUiQPsSxyfAMY1Ar45rn8/R+TPHOBvisBye2RzSG7AfwaF9I/7nLL nq/AC+oa6tYJbiBisGQ== X-Proofpoint-ORIG-GUID: wtW4jHzerNpnWVcuJXKUapm8NwMeGtkY X-Authority-Analysis: v=2.4 cv=FqQ1OWrq c=1 sm=1 tr=0 ts=6a510489 cx=c_pps a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17 a=RAioF0-LDSMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=U7nrCbtTmkRpXpFmAIza:22 a=VwQbUJbxAAAA:8 a=20KFwNOVAAAA:8 a=KKAkSRfTAAAA:8 a=VnNF1IyMAAAA:8 a=-kfjqqwatEbdier3Q44A:9 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEwMDE0MiBTYWx0ZWRfX/zA8fJH+l+Ui H3kNJlBkM3aJYfozC1XZDexDSqRaZzeXPM9XO3+OTPgWIrQ3R3/nitLsiLWVMiCPjZ2p9OrWLVh UpTanXfUgK9SwnlV9A8KmEYH/RjzizM= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-10_03,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607100142 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=148.163.156.1; envelope-from=stefanb@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ibm.com) X-ZM-MESSAGEID: 1783694511367158500 Content-Type: text/plain; charset="utf-8" From: Mohammadfaiz Bawa sysbus_mmio_get_region() returns NULL when a device has fewer MMIO regions than the requested slot index. platform_bus_get_mmio_addr() passes the result directly to memory_region_is_mapped() without a NULL check, causing a SIGSEGV. Return -1 early when the region pointer is NULL, consistent with the existing "not mapped" path. Reviewed-by: Peter Maydell Signed-off-by: Mohammadfaiz Bawa Link: https://lore.kernel.org/qemu-devel/20260619093140.832136-2-mbawa@redh= at.com Signed-off-by: Stefan Berger --- hw/core/platform-bus.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/core/platform-bus.c b/hw/core/platform-bus.c index a2217a2dee..16d0ecc0f3 100644 --- a/hw/core/platform-bus.c +++ b/hw/core/platform-bus.c @@ -59,8 +59,7 @@ hwaddr platform_bus_get_mmio_addr(PlatformBusDevice *pbus= , SysBusDevice *sbdev, Object *pbus_mr_obj =3D OBJECT(pbus_mr); Object *parent_mr; =20 - if (!memory_region_is_mapped(sbdev_mr)) { - /* Region is not mapped? */ + if (!sbdev_mr || !memory_region_is_mapped(sbdev_mr)) { return -1; } =20 --=20 2.55.0 From nobody Sun Jul 12 00:39:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1783694504; cv=none; d=zohomail.com; s=zohoarc; b=bKNjcEHFf4qjEcDIMzQrOcbdeW1EuvDMwd+StBui1rvh3Zd2zRPQbs1G0s2TYk+RrgIrzfOsGOX8nFh5EGREc2YQDRYXNjJQYflQU9JLOGFKQylDYqk1ZC/7SECSL3dhQbgDlnA8UXSYz5yjDKdnr9MoNMdtalI5UdlJmGDOoYY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783694504; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=5sUN3aY1SEIaIMqzM/v+nyCI8fuHCvxkw6Kn4YZhYdc=; b=PC4ebFZrJplgLVZNMCLcmkoUi8QcvS+6AUE8peb4Bm5gBBebTsKNYoqpVXS+VmEBlNg3/nFVYpk8EE+O1SB+nBAeEAwLh+OqexTR6DoTDRuFPJWFaQghX0FknZJ5hHw5Wy1iaOYYv+cjUxYIm/hDp4fBjSUemrHOPZrJPFmaXPE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783694504521499.30741945003; Fri, 10 Jul 2026 07:41:44 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wiCPy-0000nO-Pl; Fri, 10 Jul 2026 10:41:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wiCPq-0000h2-LK for qemu-devel@nongnu.org; Fri, 10 Jul 2026 10:41:24 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wiCPl-0005Vq-Q3 for qemu-devel@nongnu.org; Fri, 10 Jul 2026 10:41:20 -0400 Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66ADIGZB1713152; Fri, 10 Jul 2026 14:41:14 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4f6sur6yx8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 10 Jul 2026 14:41:14 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 66AEJwTn023925; Fri, 10 Jul 2026 14:41:13 GMT Received: from smtprelay03.dal12v.mail.ibm.com ([172.16.1.5]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4f7dgkjf0c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 10 Jul 2026 14:41:13 +0000 (GMT) Received: from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com [10.39.53.230]) by smtprelay03.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 66AEfCs49044642 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 10 Jul 2026 14:41:12 GMT Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 286BD5805C; Fri, 10 Jul 2026 14:41:12 +0000 (GMT) Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A79CF5805A; Fri, 10 Jul 2026 14:41:11 +0000 (GMT) Received: from sbct-3.pok.ibm.com (unknown [9.47.158.153]) by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP; Fri, 10 Jul 2026 14:41:11 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=5sUN3aY1SEIaIMqzM /v+nyCI8fuHCvxkw6Kn4YZhYdc=; b=MFIz0Ur0SydITEZnHAA5j+iEYmBK2H1An FK8X+6RgVm2l2xa9F384qB7PTjGKQ08s/EFkqHMtdGv4GhGNXCOMqLUcj//Gkag9 h2/2MvCJaBZPMJTQT283EkHoF62JMRRK1emgltfsa41qE1s4LPftXAeJyhqYbFic LIZQUVuoT23eXlX/vs8RbORz26Ajdpyr6oTbn1MROB2Of9mARrCFpYEN94MO506Z FqQ7eNhoYaypBlxc6ES8ZjKrdNm1xW4yLSeWbe8kNFcYEZ8M2tiaoa4XMnaTlHkH HYiLsWEkRFdtUUD6oP46SayFOqdk4LfVd+igTte9YebaxeFRDtwCg== From: Stefan Berger To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Mohammadfaiz Bawa , Stefan Berger Subject: [PULL v1 2/3] hw/tpm: gate PPI support on tpm-tis-device behind a device property Date: Fri, 10 Jul 2026 10:41:07 -0400 Message-ID: <20260710144108.621828-3-stefanb@linux.ibm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260710144108.621828-1-stefanb@linux.ibm.com> References: <20260710144108.621828-1-stefanb@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEwMDE0MiBTYWx0ZWRfX7rb1cB3DLshg WQ5PXrYS18JlvzOC2y1Mc9DcCj3GXWP/aMnN7IiKw2BJPepS6rSfUXcKO6OBWStaUrRf29NE3T4 96WWYOf9zuNVCCyWInw/b3XwXI/gr6Q= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEwMDE0MiBTYWx0ZWRfX09qJGfYJ2vQl dr/qUJELWTByOI29tfQVN4hB2qh+u2phx6PyAAvokVgotwU5IJ8LFPg8MhcJZ4wlkgnYD+edodz R6YjxZPJ8sdU6CNyis6WKcxW8X/t5aMZ8yQf0LbdsB9Rc2oXVKAti35h9n0R8g/zQmkBIKjdBIW mFAXjYAn7PG84JrTfkwCVuquGz+0xaYlXqwj/eOAnU142eoEWBTwSvolb8cslA/zljliEESeqbs z6Mny0XI7DK2xkrcnpXl1C0MGb1aeVIZ3jEHDUBFTUiDZvUepMWa/qTIQXY/pzH0WQdnt8t31AY 59ORqGoM2/UTNTQQaum3qX/M9GlNBjDAfwMEUNjyJ26yRo8q0iUqLeJEbPro2ycj8bpsKxLn0LG 1KCDwuypRHoO61Ux/XW0YJvUDI8w+tQQjiBoc/xQgop+yjuR0qb9QImdDdsRljYlwux+eayv4AL uKq0g4TiqqVw05gLGiA== X-Proofpoint-GUID: rGhlN8FMs48yqR8SX0_HQcMWqLFCQxlQ X-Authority-Analysis: v=2.4 cv=Oot/DS/t c=1 sm=1 tr=0 ts=6a51048a cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=RAioF0-LDSMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=uAbxVGIbfxUO_5tXvNgY:22 a=VwQbUJbxAAAA:8 a=20KFwNOVAAAA:8 a=VnNF1IyMAAAA:8 a=QC3pr3st6DBKPxuHkVwA:9 X-Proofpoint-ORIG-GUID: rGhlN8FMs48yqR8SX0_HQcMWqLFCQxlQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-10_03,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 phishscore=0 malwarescore=0 suspectscore=0 spamscore=0 adultscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607100142 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=148.163.156.1; envelope-from=stefanb@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ibm.com) X-ZM-MESSAGEID: 1783694505350158500 Content-Type: text/plain; charset="utf-8" From: Mohammadfaiz Bawa Add a "ppi" boolean property (default: true) to tpm-tis-device. When ppi=3Doff the RAMBlock is never registered and the migration stream omits "tpm-ppi", restoring backward compatibility. Move sysbus_init_mmio() calls from instance_init to realizefn so the memory regions are initialized before being registered. When ppi=3Doff, the PPI MMIO region is simply not exposed. Fixes: 46cd2c1050f0 ("hw/tpm: add PPI support to tpm-tis-device for ARM64 v= irt") Signed-off-by: Mohammadfaiz Bawa Reviewed-by: Stefan Berger Link: https://lore.kernel.org/qemu-devel/20260619093140.832136-3-mbawa@redh= at.com Signed-off-by: Stefan Berger --- hw/tpm/tpm_tis.h | 1 + hw/tpm/tpm_tis_sysbus.c | 18 +++++++++++------- 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/hw/tpm/tpm_tis.h b/hw/tpm/tpm_tis.h index 1531620bf9..6ac9804050 100644 --- a/hw/tpm/tpm_tis.h +++ b/hw/tpm/tpm_tis.h @@ -76,6 +76,7 @@ typedef struct TPMState { size_t be_buffer_size; =20 TPMPPI ppi; + bool ppi_enabled; } TPMState; =20 extern const VMStateDescription vmstate_locty; diff --git a/hw/tpm/tpm_tis_sysbus.c b/hw/tpm/tpm_tis_sysbus.c index 16bb17874b..a7b0002d82 100644 --- a/hw/tpm/tpm_tis_sysbus.c +++ b/hw/tpm/tpm_tis_sysbus.c @@ -94,6 +94,7 @@ static void tpm_tis_sysbus_reset(DeviceState *dev) static const Property tpm_tis_sysbus_properties[] =3D { DEFINE_PROP_UINT32("irq", TPMStateSysBus, state.irq_num, TPM_TIS_IRQ), DEFINE_PROP_TPMBE("tpmdev", TPMStateSysBus, state.be_driver), + DEFINE_PROP_BOOL("ppi", TPMStateSysBus, state.ppi_enabled, true), }; =20 static void tpm_tis_sysbus_initfn(Object *obj) @@ -101,9 +102,7 @@ static void tpm_tis_sysbus_initfn(Object *obj) TPMStateSysBus *sbdev =3D TPM_TIS_SYSBUS(obj); TPMState *s =3D &sbdev->state; =20 - sysbus_init_mmio(SYS_BUS_DEVICE(obj), &s->mmio); sysbus_init_irq(SYS_BUS_DEVICE(obj), &s->irq); - sysbus_init_mmio(SYS_BUS_DEVICE(obj), &s->ppi.ram); } =20 static void tpm_tis_sysbus_realizefn(DeviceState *dev, Error **errp) @@ -122,14 +121,19 @@ static void tpm_tis_sysbus_realizefn(DeviceState *dev= , Error **errp) return; } =20 - s->ppi.buf =3D qemu_memalign(host_page_size, - ROUND_UP(TPM_PPI_ADDR_SIZE, host_page_size)= ); memory_region_init_io(&s->mmio, OBJECT(dev), &tpm_tis_memory_ops, s, "tpm-tis-mmio", TPM_TIS_NUM_LOCALITIES << TPM_TIS_LOCALITY_SHIFT= ); - memory_region_init_ram_device_ptr(&s->ppi.ram, OBJECT(dev), "tpm-ppi", - TPM_PPI_ADDR_SIZE, s->ppi.buf); - vmstate_register_ram(&s->ppi.ram, dev); + sysbus_init_mmio(SYS_BUS_DEVICE(dev), &s->mmio); + + if (s->ppi_enabled) { + s->ppi.buf =3D qemu_memalign(host_page_size, + ROUND_UP(TPM_PPI_ADDR_SIZE, host_page_s= ize)); + memory_region_init_ram_device_ptr(&s->ppi.ram, OBJECT(dev), "tpm-p= pi", + TPM_PPI_ADDR_SIZE, s->ppi.buf); + sysbus_init_mmio(SYS_BUS_DEVICE(dev), &s->ppi.ram); + vmstate_register_ram(&s->ppi.ram, dev); + } } =20 static void tpm_tis_sysbus_class_init(ObjectClass *klass, const void *data) --=20 2.55.0 From nobody Sun Jul 12 00:39:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1783694505; cv=none; d=zohomail.com; s=zohoarc; b=M1FkPNX0lKPtaTicR0io6LuOiGJs1+pwbs5P37APk4kc1Cx1HXa2iDUaQib9E7+olSGj072wo+O3rtfLQJAXdsW5lVVosatnjBgczr8kglgj7d2LA1QixD8GxEj/B+KqS5DPRu4n4jmrzx4viS3qd1UwDLHOGIWx52JyC0w/UuU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783694505; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Injt72dZqXaLqp0VKvq6bhjajR5N2OsVmf2yOdoeZEg=; b=buocl1NYOxWHXOrI5Tph50v0q+jisFZTbbS8JHdtl4teomvPwObfT5MGyuepqFogaSr0Cmna7NcGGzLoTfs/R6eO0ytIbiUrnsMiV1Wn16RbK9kDDYZxdM1F2M3lQPHGNlG4vb9grPXn0HM5It7bMHcxAD1VP739GrvsqupN660= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17836945054741016.4747065170991; Fri, 10 Jul 2026 07:41:45 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wiCPv-0000lE-Rx; Fri, 10 Jul 2026 10:41:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wiCPq-0000h1-L9 for qemu-devel@nongnu.org; Fri, 10 Jul 2026 10:41:24 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wiCPl-0005Vs-Tn for qemu-devel@nongnu.org; Fri, 10 Jul 2026 10:41:20 -0400 Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66ADIWQT971630; Fri, 10 Jul 2026 14:41:14 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4f6sw5797j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 10 Jul 2026 14:41:14 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 66AEYb88030004; Fri, 10 Jul 2026 14:41:13 GMT Received: from smtprelay03.dal12v.mail.ibm.com ([172.16.1.5]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4f7eqgj81q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 10 Jul 2026 14:41:13 +0000 (GMT) Received: from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com [10.39.53.230]) by smtprelay03.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 66AEfC2C22807248 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 10 Jul 2026 14:41:13 GMT Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CB7775805C; Fri, 10 Jul 2026 14:41:12 +0000 (GMT) Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4D28F5805A; Fri, 10 Jul 2026 14:41:12 +0000 (GMT) Received: from sbct-3.pok.ibm.com (unknown [9.47.158.153]) by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP; Fri, 10 Jul 2026 14:41:12 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=Injt72dZqXaLqp0VK vq6bhjajR5N2OsVmf2yOdoeZEg=; b=Nt5OVJOmZ8Y4gv564XAIl/LShfXnmaTCJ HV+A07FB8umPtPqdmOopsi380oMWr/99po0+aWyYCPQeAby8C1Tyg7PBmWkwSnc0 2hIyIer4oVup2c8baTvBuIoN1Zp2zEGRVgL6aZIgbqeV+DBPPaDi738jK9zAfQXh 5K/3mwz0pbaiEqlda4rJIUk+/98S7lU9PdMnObqyaY51Ru4Fwq5y6SG5+UTeQ82/ 57MK9GaNegFowLLvZYWoNinMOeKpY1o8hJfYb5uBwQ1GtuvrR9SjJE8Y+V3YmYFa /D01kAjuXFE/Awn2egDY9TCmvqHXWhwDpumCjXiSoOiAiFpRifhJA== From: Stefan Berger To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Mohammadfaiz Bawa , Stefan Berger Subject: [PULL v1 3/3] hw/core/machine: disable tpm-tis-device PPI for machine type <= 11.0 Date: Fri, 10 Jul 2026 10:41:08 -0400 Message-ID: <20260710144108.621828-4-stefanb@linux.ibm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260710144108.621828-1-stefanb@linux.ibm.com> References: <20260710144108.621828-1-stefanb@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-GUID: TBBNV1m_ZLZWa-Sjb-JoCfc7xQ_2b2YS X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEwMDE0MiBTYWx0ZWRfX9PYZUl17lbkO PXG7UfRkWDRAGA3G5yK8xemYbdU0jMi/3MclrCEH/n2Fs1qPWfaHvHaQaf6VWywn4jASHQUJ41A L+Zl1vBapwln7Dzwxg3mvfLOM+JrdsHcZIoGbglXjk6zlc01sBe2DWV6xJzYMSHMi7zxRQywh4/ 95XhsUYfR8s19tfmW7ft3Njmmh2o8NAcYwvnRbb6qxVvReHbm5zt1F+gz/VpJh0EwTKtu0dwU8z u/aeoBWrc8kpQiyZTAUf9h5UFBYh3pBrGsWTfgsng2F+RzklhejbZ9s29+samjpCdUyJVLFtX9Z LWs5kYr5PSFN9xfTNetCBbpDj5/ZnVJG2r145uctkL4LD5LmO01AEEodFOkF5AJhoUiX+m7NxnL Cntws1WrLfu7KoGCdcJfOxBvdZxZ07ZWHNtap3Y9eENHMMZmggi+qDZErZUVuRFPL+qEmyMiIKu ymwsgn+ENwz360bln4g== X-Proofpoint-ORIG-GUID: TBBNV1m_ZLZWa-Sjb-JoCfc7xQ_2b2YS X-Authority-Analysis: v=2.4 cv=FqQ1OWrq c=1 sm=1 tr=0 ts=6a51048a cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=RAioF0-LDSMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=U7nrCbtTmkRpXpFmAIza:22 a=VwQbUJbxAAAA:8 a=20KFwNOVAAAA:8 a=VnNF1IyMAAAA:8 a=BVZ489IyuOhHAO5klUcA:9 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEwMDE0MiBTYWx0ZWRfX8jFQon3T3sAD PXDdIDZstE3ToHlZL3vshORJwADPJ0JsYcjcgxcomIFsoRXypkFeHY30nvaEYg2CYkIrNeSS6za DK6xg06Q/qBT+Ems98wC8Pxc/WabCp8= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-10_03,2026-07-10_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607100142 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=148.163.156.1; envelope-from=stefanb@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ibm.com) X-ZM-MESSAGEID: 1783694507334158500 Content-Type: text/plain; charset="utf-8" From: Mohammadfaiz Bawa Set ppi=3Doff in hw_compat_11_0[] so that older machine types do not register the "tpm-ppi" RAMBlock, restoring backward migration. Signed-off-by: Mohammadfaiz Bawa Reviewed-by: Stefan Berger Link: https://lore.kernel.org/qemu-devel/20260619093140.832136-4-mbawa@redh= at.com Signed-off-by: Stefan Berger --- hw/core/machine.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/core/machine.c b/hw/core/machine.c index 15886a56b1..805148678d 100644 --- a/hw/core/machine.c +++ b/hw/core/machine.c @@ -44,6 +44,7 @@ GlobalProperty hw_compat_11_0[] =3D { { "chardev-vc", "encoding", "cp437" }, { "tpm-crb", "cap-chunk", "off" }, { "tpm-crb", "x-allow-chunk-migration", "off" }, + { "tpm-tis-device", "ppi", "off" }, { TYPE_ARM_SMMUV3, "ats", "off" }, { TYPE_ARM_SMMUV3, "ril", "on" }, { TYPE_ARM_SMMUV3, "ssidsize", "0" }, --=20 2.55.0