From nobody Sun Jul 12 00:34:15 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1783693705; cv=none; d=zohomail.com; s=zohoarc; b=jFZh2O4CJsAMZ4bM20CTSWaK3QlmLCa8pS7TClxjSMBwkTUXQ7oYOlA7Fl7VhhcyrkBTAJPRvIeWMKbsF+ii2Pu9bjjeyJ3yyTtmvs0eUwi0QU3abCPktGteE/+NDmkDhFDlQwy8sYNC9NOe2tE6gcHdo59EVpSthr0AwYHocF0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783693705; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=s7bqSPE0+h6E2uo2f7LBnH1MZIKQeHIa4sG2I7ZIKG8=; b=TbepfcFtc0m2xNqzXAkBPapvID0JeMsdXbM8lPYGGukDVfFM7SWnBKRHbf2eRk+HAkd5/jkDA7fAxSqSpJQG5QyeOxxmPicCrlJ/bbt9YuI7v89XyupG8bkf94mm7BKUqE2awKn6rd/50LEQRugR9ezBY1UIJm06WpA3HHBV+3E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178369370516661.18598074201532; Fri, 10 Jul 2026 07:28:25 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wiCCY-00051J-Th; Fri, 10 Jul 2026 10:27:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wiCCX-000514-Ve for qemu-devel@nongnu.org; Fri, 10 Jul 2026 10:27:37 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wiCCW-0000i2-FC for qemu-devel@nongnu.org; Fri, 10 Jul 2026 10:27:37 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-399-LBBHJ9VXMdOJy0pXIeqD8w-1; Fri, 10 Jul 2026 10:27:32 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 83ECA1955EBC; Fri, 10 Jul 2026 14:27:31 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.49.56]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5F2B9414; Fri, 10 Jul 2026 14:27:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783693655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=s7bqSPE0+h6E2uo2f7LBnH1MZIKQeHIa4sG2I7ZIKG8=; b=iWDZsatPfg3E1XO0iPyws7YCSLMvtJA8Wrdir8tHvkPP84zBT0QzxRfp+FeWEpY0LWGdfb Yujj1endsXl9nnIKP2rERn/crHNUZYllH1XiICirH4gqca1wCJvv0WDrG51JvHg8Ns33KD E4FWIqIs68lr5ucfhgBizN1k2N+AdqM= X-MC-Unique: LBBHJ9VXMdOJy0pXIeqD8w-1 X-Mimecast-MFC-AGG-ID: LBBHJ9VXMdOJy0pXIeqD8w_1783693651 From: Thomas Huth To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Gerd Hoffmann Subject: [PATCH] hw/usb/hcd-xhci: Turn guest-triggerable abort() into qemu_log_mask() Date: Fri, 10 Jul 2026 16:27:27 +0200 Message-ID: <20260710142727.592667-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1783693707604158500 Content-Type: text/plain; charset="utf-8" From: Thomas Huth The FIXME macros in xhci_alloc_device_streams() can be triggered by a (malicious) guest. Since the macro also contains an abort() statement, this terminates QEMU. Turn the FIXME statements into a qemu_log_mask() instead to avoid that a guest can shoot itself this way. Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3784 Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/usb/hcd-xhci.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 2cdab3ba0e4..9ff50d0b7f9 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -965,11 +965,13 @@ static TRBCCode xhci_alloc_device_streams(XHCIState *= xhci, unsigned int slotid, * together and make an usb_device_alloc_streams call per group. */ if (epctxs[i]->nr_pstreams !=3D req_nr_streams) { - FIXME("guest streams config not identical for all eps"); + qemu_log_mask(LOG_GUEST_ERROR, + "guest streams config not identical for all eps"= ); return CC_RESOURCE_ERROR; } if (eps[i]->max_streams !=3D dev_max_streams) { - FIXME("device streams config not identical for all eps"); + qemu_log_mask(LOG_GUEST_ERROR, + "device streams config not identical for all eps= "); return CC_RESOURCE_ERROR; } } --=20 2.55.0