From nobody Sun Jul 26 10:12:25 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1783590700; cv=none; d=zohomail.com; s=zohoarc; b=Ve+6jocLCEA30PHma8M4SsNsjESMOh9botLAIX8tUE6NX3uZFWLyLbRoGCoc1wjVVhebvt8B0rTlH/Z9/uolMEJUu8uxeihFTWR6wzHJRJ46Hh8D83i9RO2M+Ck0z8mfSBQQjbdz71bBssPDS0PEKpwkH3374K2owxlb+Ay5Lu8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783590700; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=fftu9YTeWRktJwqkL+gul7AqzfbpXEjTPuVqzY9QqbE=; b=J59vCBXEycBBNXbznCdJGpFrgDqBnWSC38eIwBSDt24ESAIv+vlN+wqE2042w7jYdFXDh8hs2W68j7jleqzv4ewrDkxGY9+1FK1JAAG0M0ohoRw2RyRsk6XCFvYqzdJLI8bufNED9Q2x+Dz2vpPUvxKQbulmbXkJWFRy1rMT8SE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783590700867350.0139095295433; Thu, 9 Jul 2026 02:51:40 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1whlPM-0001Nu-TE; Thu, 09 Jul 2026 05:51:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1whlPK-0001Ne-Eb for qemu-devel@nongnu.org; Thu, 09 Jul 2026 05:51:02 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1whlPI-0000Yn-Nr for qemu-devel@nongnu.org; Thu, 09 Jul 2026 05:51:02 -0400 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-490cf322ed0so9641315e9.1 for ; Thu, 09 Jul 2026 02:51:00 -0700 (PDT) Received: from lanath.. (wildly.archaic.org.uk. [81.2.115.145]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493eb74835esm54491245e9.14.2026.07.09.02.50.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 02:50:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1783590658; x=1784195458; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=fftu9YTeWRktJwqkL+gul7AqzfbpXEjTPuVqzY9QqbE=; b=wKG4doJHTMLQ1rjF+GmIee3dLnMW58A/aLKv3E9CfludHuvJo03SNR+vINkJfImMuy EH0YjEe/DuvpFjvasr2Gvs7vUnyFV3cLwzuifPu7isi9iLnzq1spUVZJwNU6da5hZxe9 4Vc3F1YbTz+wHzeWfXgrEtaDAIuCfnkxVucSn/yFwkTWACTXxCnDHNA0L8TouZjDhq0n Z6lgNs81+wh+C25GCfiVz4h6ejk2OEmkq7wLpKTv0pM+Juh8wXVntBA3Dwv5n7J0wGuV RqFZV1McMiyQnvxurmeB4uL/YySD1b1OERkzD/TTan2u0Iast/u9/6mSTNDYn+fbXwik 6lpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783590658; x=1784195458; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fftu9YTeWRktJwqkL+gul7AqzfbpXEjTPuVqzY9QqbE=; b=kiBpz+paEM37UDx9xWp2lA1Iggk0t0PdPLFGGihmlcVq/RhkSgDiYJrTkIl2Oso81r nPAst4a7jCFvG6MWyJiwUm9AVTDgSASUq2Ss2f8Zi6gkNPpNplnc8Q0HQYGQzv1oYlZV w3cUx75A/itHW5wOLuzyqzgjbjC/hLnRODukT1O50EdU3i5qSHx8j3FmCQFxUfJ/rwX5 JYGw8iW2+rPgAhCOMdwjkKEGNnStdokfwEalP5bNYJPStUC/1eQqXKJnZMYGg66vHHQX UgqIfMnb0cOiHgJ7eMdyFR7w9EXpN9x0xLy/bFYdz9djpgmXkX3DuFPkgsq8gvDcmu46 vG5g== X-Gm-Message-State: AOJu0YzoU9b+siVdZFWHwH2l/numttCtbNbCGk3ym5c/gAUKtBY9cISx 8wmrF/3lYbjN3BBCMUO7NZeV3dr/RWOVaO94QmSWEDH3rYagOp/3ncUktQPdlWQgyYZdqJ9omoG RPvHba6nI0g== X-Gm-Gg: AfdE7clcAPCG5WGtHUWI/Zc4vUUaPj/QHLPSBqw8373aaq+nb5KB46iPqWW4dALB162 GIqFslroxNgryHRsr71yXBorMQaVtLVaPYqWC9KQLcUh+bOk+H5NeBo8lxTVJteL9WupYXqKR0L /CMw2VvcLcIqEWB/otN/ey7H5Tqk1nGdauoCyWzj0XCN6P3L6jYrcWNJ978viFMe3mIj1kXcMNK 7Mc7U6PGUQERIgQnMLOz/3/r8zQveVszHNxawrqAonv2j9e/Z4ilswtm/wqtSFA67TirqjyH5us u3/rj7SfZqolxFFS7gvoqn1QnjIrwMtpM1y3ubVJU+I6n8ChIRvvERwYRVhAAaZoBbPONyFkZ26 wjiphHEkNuRXWMnjtcQSQzkBzw7KykFDwgKvlvR3rfGFI6mXs7GN0ArwKZDS39yfPEees+x74Dk 5KHOaWy3KOG1h6J7WWUOLRwqpGxKaju4sC81MT1EzoRs1xAgYzkU4ExQoqzsTB0V4AGCjVXdQ5q tElAiqZSE3zKAvOjitoXw== X-Received: by 2002:a05:600c:1554:b0:493:bacb:1341 with SMTP id 5b1f17b1804b1-493e6859938mr63798165e9.4.1783590657863; Thu, 09 Jul 2026 02:50:57 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, Nicholas Piggin , Chinmay Rath , Glenn Miles , Harsh Prateek Bora Subject: [PATCH] target/ppc: Remove unused helper_lscbx() Date: Thu, 9 Jul 2026 10:50:56 +0100 Message-ID: <20260709095056.1803725-1-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1783590702408158500 Content-Type: text/plain; charset="utf-8" The helper_lscbx() function isn't called anywhere. It used to be used by the PPC 601 CPU support; we removed that in commit 005b69fdcc in 2022 but missed this helper function. Fixes: 005b69fdcc ("target/ppc: Remove PowerPC 601 CPUs") Signed-off-by: Peter Maydell Reviewed-by: Amit Machhiwal --- This came to my attention because Coverity reported a "shifts into sign bit" issue in the function: CID 1663681 --- target/ppc/helper.h | 1 - target/ppc/mem_helper.c | 28 ---------------------------- 2 files changed, 29 deletions(-) diff --git a/target/ppc/helper.h b/target/ppc/helper.h index e99c8c824b..6b2d19a3ad 100644 --- a/target/ppc/helper.h +++ b/target/ppc/helper.h @@ -54,7 +54,6 @@ DEF_HELPER_FLAGS_2(dcbzl, TCG_CALL_NO_WG, void, env, tl) #endif DEF_HELPER_FLAGS_2(icbi, TCG_CALL_NO_WG, void, env, tl) DEF_HELPER_FLAGS_2(icbiep, TCG_CALL_NO_WG, void, env, tl) -DEF_HELPER_5(lscbx, tl, env, tl, i32, i32, i32) =20 #if defined(TARGET_PPC64) DEF_HELPER_4(DIVDEU, i64, env, i64, i64, i32) diff --git a/target/ppc/mem_helper.c b/target/ppc/mem_helper.c index 119dc1df23..787ba2cdec 100644 --- a/target/ppc/mem_helper.c +++ b/target/ppc/mem_helper.c @@ -367,34 +367,6 @@ void helper_icbiep(CPUPPCState *env, target_ulong addr) #endif } =20 -/* XXX: to be tested */ -target_ulong helper_lscbx(CPUPPCState *env, target_ulong addr, uint32_t re= g, - uint32_t ra, uint32_t rb) -{ - int i, c, d; - - d =3D 24; - for (i =3D 0; i < xer_bc; i++) { - c =3D cpu_ldub_data_ra(env, addr, GETPC()); - addr =3D addr_add(env, addr, 1); - /* ra (if not 0) and rb are never modified */ - if (likely(reg !=3D rb && (ra =3D=3D 0 || reg !=3D ra))) { - env->gpr[reg] =3D (env->gpr[reg] & ~(0xFF << d)) | (c << d); - } - if (unlikely(c =3D=3D xer_cmp)) { - break; - } - if (likely(d !=3D 0)) { - d -=3D 8; - } else { - d =3D 24; - reg++; - reg =3D reg & 0x1F; - } - } - return i; -} - /*************************************************************************= ****/ /* Altivec extension helpers */ #if HOST_BIG_ENDIAN --=20 2.43.0