From nobody Sun Jul 26 11:05:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1783354448; cv=none; d=zohomail.com; s=zohoarc; b=jbcAU5dcjYLBF3z3owQ3pAKrIFaOz5v1GiTq+EmdifIXLlijpf84LaRX48Rlup9jFtWJBzmwhCDB+YY/CtEodJYc2hTqWNoh0WYGBZOOqlhEiC8AL4tsVRdV8FsL23A8wGpsHaoXaHGNN1S/NX/u4TurxPFSHSNPIFCAFc3mF6E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783354448; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=GJfBAZo48ipyur4FhX6eUhoVRER5129Xg7oPqFbKcrA=; b=HLcSZAV3HFT0tLvztpOLRRXbkE4uOCaksWF/wfpDfiHaN8HmElmXOz5fGF7hWYQan5TbTJGdtbxCuXGxAqgjq8cizzEWI4KqrICmeB2/piEgeI2EZjB9ptpAo/Cazx3HJE5cTeUfLld2dssr5DK/OwYN7uQ0zbGCpzzHYDK2tKs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783354448367722.685876979542; Mon, 6 Jul 2026 09:14:08 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wglx7-0002G9-Ck; Mon, 06 Jul 2026 12:13:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wglx5-00029k-Jp for qemu-devel@nongnu.org; Mon, 06 Jul 2026 12:13:47 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wglx3-0005oc-98 for qemu-devel@nongnu.org; Mon, 06 Jul 2026 12:13:47 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-480-GJRyekYBNqixyPy69uQpPA-1; Mon, 06 Jul 2026 12:13:39 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1B4DE1955D87; Mon, 6 Jul 2026 16:13:38 +0000 (UTC) Received: from corto.redhat.com (unknown [10.44.32.54]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2C236195604B; Mon, 6 Jul 2026 16:13:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783354423; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=GJfBAZo48ipyur4FhX6eUhoVRER5129Xg7oPqFbKcrA=; b=d1tOOZDVrFtnj1zGV2RJ2zlkFHOdFz1m5r3x9nGyCZPrgk2DH6jpwLAQzQLy+M646JA+Jo 7S84BvvyYUkZ1Ckllp5aazkT3Aa2N76MNnDK60BZJ5Iv3g1PVcEsdyRcWxCkSFuVb5kzLL Y3+m7jI/EHhckqHCi9ntm+NbPNkz7vw= X-MC-Unique: GJRyekYBNqixyPy69uQpPA-1 X-Mimecast-MFC-AGG-ID: GJRyekYBNqixyPy69uQpPA_1783354418 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-devel@nongnu.org Cc: Alex Williamson , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Feifan Qian Subject: [PATCH v2] vfio/pci: Reject invalid MSI-X Table and PBA BIR values Date: Mon, 6 Jul 2026 18:13:34 +0200 Message-ID: <20260706161334.2165482-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1783354450135158500 The 3-bit MSI-X BIR fields permit values 0-7, but VFIOPCIDevice::bars[] only contains BAR0-BAR5 (6 entries). An invalid BIR value of 6 or 7 can cause an out-of-bounds array access (CWE-129) in vfio_msix_early_setup(= ). Add range checks immediately after extracting the BIR values. Reported-by: Feifan Qian Fixes: 65501a745dba ("vfio: vfio-pci device assignment driver") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3878 Reviewed-by: Alex Williamson Signed-off-by: C=C3=A9dric Le Goater --- hw/vfio/pci.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index e6d1adfd3655ce3c1baf8977c82223d23af9b770..c204706e63045c930bda7977adc= 8034f907b6890 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -1791,6 +1791,14 @@ static bool vfio_msix_early_setup(VFIOPCIDevice *vde= v, Error **errp) msix->pba_offset =3D pba & ~PCI_MSIX_FLAGS_BIRMASK; msix->entries =3D (ctrl & PCI_MSIX_FLAGS_QSIZE) + 1; =20 + if (msix->table_bar >=3D ARRAY_SIZE(vdev->bars) || + msix->pba_bar >=3D ARRAY_SIZE(vdev->bars)) { + error_setg(errp, "invalid MSI-X BIR, table_bar=3D%d pba_bar=3D%d", + msix->table_bar, msix->pba_bar); + g_free(msix); + return false; + } + ret =3D vfio_device_get_irq_info(&vdev->vbasedev, VFIO_PCI_MSIX_IRQ_IN= DEX, &irq_info); if (ret < 0) { --=20 2.54.0