From nobody Sun Jul 26 11:01:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783345579; cv=none; d=zohomail.com; s=zohoarc; b=O2O3sD68/f5Et+R4ew0lOWGkEmdKdQp092iimex8yskb288gEqht3n4LE+bEbZBGh0JQ1ZTwdevtoUAW3Gj4TeYws4qRemijg6C40Fr8BUSU2VIU7Q1fnQyWou2uub/fI0NIEToptzWmgsWr5R7gFfL4hhLJkoWtOgi6m6MSOkw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783345579; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=FdZQ/hXJPnQHh8pxClBbjH2cf/RH4LMCCU4QJ17vy7M=; b=O3N1De8tGuXCUmDMZ4MoM3NVOqa9xOTtgHW4AUhivdnXsRo6ocQE00MeObO8vpktUB0u3FPBSML3PgelIt7mPlrDSFFOp6B3f2AmZCUw+T2cmjUJo/C0qCCjUDEi5PEbHYhvj+z5Yx+qFGjCsnx1MhZ9O3SbaCOPj0jJJAZeurI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783345579917595.7851126798657; Mon, 6 Jul 2026 06:46:19 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgjdt-0006DV-6p; Mon, 06 Jul 2026 09:45:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjdr-0006DN-56 for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:45:47 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjdp-00069s-E7 for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:45:46 -0400 Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666AxIG9391280 for ; Mon, 6 Jul 2026 13:45:43 GMT Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f89kgs14k-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 13:45:43 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92d1cae5740so350825885a.0 for ; Mon, 06 Jul 2026 06:45:43 -0700 (PDT) Received: from localhost.localdomain (1.171.88.92.rev.sfr.net. [92.88.171.1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493ccdb62d3sm310087935e9.8.2026.07.06.06.45.40 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 06 Jul 2026 06:45:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= FdZQ/hXJPnQHh8pxClBbjH2cf/RH4LMCCU4QJ17vy7M=; b=M2uq49UVvnz+E/MU cpBJq+ad0zAw6Q+p5MouZuQrAMiYSiE1SWMVMRJTEeWEgXhJBQW0G01b0dfKKWcB QZIwA1qrrLhTd9qYD8Lp5YJ9VxYj8i/m9hHem7HHspiJR6gIl2BUz8fg5NlZJUX3 EoRo0BguPCqxwPsYtn7y9lc4IAksPOeIQsEg1hxpXuU2fxQT43tsHFSOI8DRroBP MQ9odcuntDdOa6D/0VUuFWVavZxf5+FiOD+CKbyqt/7SSCoxXIqz1rd0/CCi8+zv 3rn/aeAuqPLGpIVAM44rp2b05kFdTKEnZiCtiWM2v9Yxov11wBJgE5LGb0nF/BBc rBqmGQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783345542; x=1783950342; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FdZQ/hXJPnQHh8pxClBbjH2cf/RH4LMCCU4QJ17vy7M=; b=Xc5Q0ZfcHqO91Y3XZaiu9x5/Zs3WaEboQh7doCLByC9WgKVhPAUc9MW3GLETLW3VlX 6rtUhivAJoL9JD5+w83P6ZM/UZyPp3nrVgsEfxMTKd+lqu3m5eQGfM8jkwwEVuOPpTzA X/DYiwavRHjNIhbuMXZGz4WOc3Q2BNeuZjfptoOM6gFz0EaROMHWraCRaLk5yK9cxz/n g6HK/P+DUYSMooNEebXhJWqC2owEHsCQvPxd3fKdJvX7i6eeCyohmQK8V8ewn/DMXsZs FOXsTaRlqx/1leNtJUH3LuI5+i3r/OCWqAcAtndDfiyrruTHMppfiS0pfS82XkXS9Noy fVmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783345542; x=1783950342; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=FdZQ/hXJPnQHh8pxClBbjH2cf/RH4LMCCU4QJ17vy7M=; b=Jv4V6ffPLpppcAYLFa+UmhStEP8uJSRx9geTWjHGYa6lQ9lPbiYE1Evc012YhO7tDd DPPsnO6gK/sCDsUr5Ls1JiYKuhZ+FdgzjcKj1MDSDmLtJ90LpZmV2Ugkl2C7R89uu97D Z95aqoex5SQrseDPSk7+d6yMdh44EzKeHnSnu7grbC0e2ecMINqcV8e68Hf77eI9aHD5 KyNWUublockJ67H6YPcrLotymCmFQkCUbYLnbKkS89PkjWIer/6qwF1UCCANxvlLC7cU tcEGQygHTBWg+2SD1d4VVizq8AXYrYhiqyYG2sMlY9D0r4RD6ARuyq+lVQgfvJS/Z9jp 8/yQ== X-Gm-Message-State: AOJu0Yzb/r8LTQwhUOZHdpn6XErxrZ5eO5hMieuM7C0Oq706uLCfJE+Z 4tOxYj2FZqrjza42YjAi8iyBvgINqSedGB8MZ5E3nZCKjkkMUtAGsDdaKN6zejjfPDKcEdxnEJp tFA+6gp7toGLRCjq51NByI4pxU2/lu4dtRAY+/pQ+MzM2zUuN5hmHTVe2GMlCH4LAug== X-Gm-Gg: AfdE7clb/IEi5QytJdX5CJ6CLAY7Ubgofzrkycxmw7qzDaLz5u89oVOEU0+JlgrRmdE sPlfJUvK27Oy3RdZcA95RUHOCM9CPQO73dEoB0NzBXdPGqkiBToAnBjONt3HdEVZgtkG+dEpblg SLaAlzp0B3V2CweBrj/7zPYP1Rv4M0NF77FtZA2KSFQi9dEzmKFDu6/dt/DtAWdDN84LU0POOwH YowvYVOkBintS5tqu2o7I26z2ZVh9rHEBTzqo6OQqSooUH90nsI4qgjygf1NxRRiSoDF04wdjY6 kcH4KU7BrfVA8z9ouY9Gr27+geC+pklxSdxpeNYZwNf9V6W1fDJv2/RM1bY7ibgkfsLZcp7WDTS FJEBkfcDbj2Vuuqv5gxpnRE2dufFwMMUHdR12uaYXRqJoZlbOtCcQzjGtQQ== X-Received: by 2002:a05:620a:440d:b0:92e:6d2a:776c with SMTP id af79cd13be357-92ebb5dec11mr79818585a.46.1783345542366; Mon, 06 Jul 2026 06:45:42 -0700 (PDT) X-Received: by 2002:a05:620a:440d:b0:92e:6d2a:776c with SMTP id af79cd13be357-92ebb5dec11mr79813485a.46.1783345541729; Mon, 06 Jul 2026 06:45:41 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 01/32] cpu: Constify CPUState::cc (cached CPUClass pointer) Date: Mon, 6 Jul 2026 15:44:56 +0200 Message-ID: <20260706134527.84808-2-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706134527.84808-1-philmd@oss.qualcomm.com> References: <20260706134527.84808-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: A6t35uOiR8emNq1bZ6oSDArVSb8D0Nbm X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE0MCBTYWx0ZWRfX9VNbOlsC930I K4vPu6xrMTX7vvL7a8AYwHKBy/qu6FQc4fPiWpERLp7LgT5qtThKtFXtk6KN6yIMvFmgWnxXiQg FBYABwJ1kp1Uy179HcpKaVsAPwW0H/pbSJ5XSSlUwaW8+MkK2YaKKum1mnmkPpWrOxW4eVMQITX NzqPFFOrPeuog/upy0JshpVf/b5SEUkqzRDHs8/rwwrVgltQasfm+k3EgbNcankAapwDQWK3f2W feII5Gk+R8uN1Cv3rYpGi0V2LxtIQKD38FqaIIHIYLnorZ75UbTzg4UnELRdpaOemlAgNV1rBhj badskLtI9+wnzCK/jdGqR2kGanadx7w2jYpYw5XRb7LPY7cE/wGACZyQNVQbnq8eHneCCoQ47vZ MmKnIpuOsb17nTQ65Kxr0yPsDVd72f+okF/udwj1+TDE19CHQ6xrv6HDNYLlm2k0NkaGGw0h5j4 nJpJTpA9LWFkSMQ9MqQ== X-Proofpoint-ORIG-GUID: A6t35uOiR8emNq1bZ6oSDArVSb8D0Nbm X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE0MCBTYWx0ZWRfX26Ib3/3eOzYS Aew0tN8DFl+Kuly3mTRqCjQXpAmDetg3ZzklLOj/hxDrTDRmGFUb3a7wfNpGiUlJkTykwId3sZO cHYOdbz2WnlY+rGI66BJx5EK5JaJGDo= X-Authority-Analysis: v=2.4 cv=c6Sbhx9l c=1 sm=1 tr=0 ts=6a4bb187 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=PLEY+c9/kVlxBKEpvFYBUQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=pGLkceISAAAA:8 a=O_p9N0DIn41U_kaacwQA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=O8hF6Hzn-FEA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 clxscore=1015 adultscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060140 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783345580740158500 Various CPUState can share the same CPUClass parent, and must not update its fields. Protect the CPUClass by marking the CPUState pointer const. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson Reviewed-by: Chao Liu Message-ID: <20260705215729.62196-2-philmd@oss.qualcomm.com> --- include/hw/core/cpu.h | 2 +- accel/tcg/cpu-exec.c | 2 +- accel/tcg/translate-all.c | 3 +-- gdbstub/gdbstub.c | 2 +- 4 files changed, 4 insertions(+), 5 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 59d601465b4..60a23d6f38b 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -480,7 +480,7 @@ struct CPUState { /*< private >*/ DeviceState parent_obj; /* cache to avoid expensive CPU_GET_CLASS */ - CPUClass *cc; + const CPUClass *cc; /*< public >*/ =20 int nr_threads; diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 9c754b03656..d7f91dce9db 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -460,7 +460,7 @@ cpu_tb_exec(CPUState *cpu, TranslationBlock *itb, int *= tb_exit) * counter hit zero); we must restore the guest PC to the address * of the start of the TB. */ - CPUClass *cc =3D cpu->cc; + const CPUClass *cc =3D cpu->cc; const TCGCPUOps *tcg_ops =3D cc->tcg_ops; =20 if (tcg_ops->synchronize_from_tb) { diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index 3f1a3a28438..328d96aba30 100644 --- a/accel/tcg/translate-all.c +++ b/accel/tcg/translate-all.c @@ -575,7 +575,7 @@ void tb_check_watchpoint(CPUState *cpu, uintptr_t retad= dr) void cpu_io_recompile(CPUState *cpu, uintptr_t retaddr) { TranslationBlock *tb; - CPUClass *cc; + const CPUClass *cc =3D cpu->cc; uint32_t n; =20 tb =3D tcg_tb_lookup(retaddr); @@ -591,7 +591,6 @@ void cpu_io_recompile(CPUState *cpu, uintptr_t retaddr) * to account for the re-execution of the branch. */ n =3D 1; - cc =3D cpu->cc; if (cc->tcg_ops->io_recompile_replay_branch && cc->tcg_ops->io_recompile_replay_branch(cpu, tb)) { cpu->neg.icount_decr.u16.low++; diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index c3c944e965b..26366acb674 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -578,7 +578,7 @@ static void gdb_register_feature(CPUState *cpu, int bas= e_reg, =20 static const char *gdb_get_core_xml_file(CPUState *cpu) { - CPUClass *cc =3D cpu->cc; + const CPUClass *cc =3D cpu->cc; =20 /* * The CPU class can provide the XML filename via a method, --=20 2.53.0 From nobody Sun Jul 26 11:01:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783345591; cv=none; d=zohomail.com; s=zohoarc; b=lCy1V0cpgNK8evRw9LKT78/X1SsUyhewmNKi4l6eM2k1La8EXXzTKz1dP/IFxCXCz7PeAYYuUskMvGWSZmBMZ7O3dQJFkM2+sPhMbL3rY6yOQMtimHijHtUP/AReLUZua76CpXvuJbbgvhpLthqZZ+tIr5RDZa8QrgWlHpiMV2k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783345591; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=4EtMpkgj0GkYsE/DLtkwyBvThOft3GO+shbpIHeHnLM=; b=LQBI/LkHYD/GVoDAjff86e+gzuDx0wNExPYRry25+Hq1CJ/74XOSRSin7fu6NK38P4mVE9LM8kYIS3X/xRmbUe3yaI2oSR6SYqBOJsP/MQ+QHUzJKoKTOyxyDZYcyYVlpRYzo5nvhstSYV/wnibjfYGJrRetbxL9RtNOD+IUa48= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178334559174862.83686796065558; Mon, 6 Jul 2026 06:46:31 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgjeL-0006LJ-0l; Mon, 06 Jul 2026 09:46:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjdz-0006GU-GL for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:45:56 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjdx-0006Ad-Pr for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:45:55 -0400 Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666AxEZB366750 for ; Mon, 6 Jul 2026 13:45:52 GMT Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f891us68g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 13:45:52 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-91ed0e140c5so549788085a.0 for ; Mon, 06 Jul 2026 06:45:52 -0700 (PDT) Received: from localhost.localdomain (1.171.88.92.rev.sfr.net. [92.88.171.1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47a9de1d910sm24167062f8f.6.2026.07.06.06.45.49 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 06 Jul 2026 06:45:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4EtMpkgj0GkYsE/DLtkwyBvThOft3GO+shbpIHeHnLM=; b=bsS9Hv6VEY2MCCT2 Z/Gkf7zG0iR11LLvfXscSSR9zDHpPV6IOkYrrL3HWLIRgQ93cPyj9gsI/3nfMcbb Osi1yQhdA8nnZQWP2jWjhsNX6YFm/H2qvrhn2RqeqE7wnNHD/w0USolxltVUv1Lu zeNxv7YH2MHOJMhfiZ7iydhkgU/gS8dJ/o/LQ945BVHz2+7rwxd63PkyBR8Mmz2Z b5tm71sDRPR0tBcIxFN/nUa3baayqExxQsnjvt2JC0sithqx2AL5+xX+yG5m72JZ H6BKQ0ere1O0JAEZfngkf7mvPtOyz/S4HMGPtKw9dELLAUlW+1/4KaDlJo0wvbEx 0dHx9A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783345551; x=1783950351; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=4EtMpkgj0GkYsE/DLtkwyBvThOft3GO+shbpIHeHnLM=; b=JQQGw2ZVp0r1k7QEJ6EwRAyud2+HeiOQ5K3rpa91xo1XfnfIIMoJbpUWHGeP6JMTLk RuMVrjQWXpzthVXevju1LT/cvs7NYZcYdjzpEehBS56Nrn8l75tSUMu9Q+SfFvT+Q5zs 8vSX/20XpLtR9l4Irpe6Z7EJoy/tUDlpt+rXK9F76s2oCdRiXX/AUFQf5eBAj4YRu2ws 82Mi+zpse+7YAGHu3IdtSl7wg91bVRjL80X5I75SzvkpWaKqejguDekFJNPRASCca628 dJw7pueetKpkRf0MvS1VXQUruwkeOpPTmF6OBlLgXWbcFbGmgwTjAhCgm40HGC33/ZRh kp2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783345551; x=1783950351; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=4EtMpkgj0GkYsE/DLtkwyBvThOft3GO+shbpIHeHnLM=; b=VmodYcVIN2kUYBkvgYfo1ByjkHhj9Ffg8NKpNqzhSkZFHMEfGRls0gRznjZoEraeaj QJqukjhQpWsdX2EgPphO9159ylKNbnfYXphA2k1TOXm+gtkknV/2udkAEXM+nSaJvx8s I3N1HMC6cLol4l+nuiCJXy6nrhsrYCY36I9tFAQN5VonpC/oUhYRUj4n1Ar00I2htrwv kN/bqyjFg35vQ0et0IPXRinhEmgXBdqY/kAF5zcQj+EcpllOxNRi+tj/A+wvERuvlzNH SAeNUfzoCQnx089fwcffOSRAwM2y0sl0A6fBuJFAs/QU9WrPgeSYB9/ZnZFGYumUtuHY kXMw== X-Gm-Message-State: AOJu0YxxXBIhabrrVQ2k7cAGWbgRJq9SqS2pplqD21q3olrHEcqDyVhb Vt6AKTQrJarqZkegfiAgAeCIp1O6HHLTZPwZa6cqslUIAIFJmny1p4fLmUvokSV4cJoh51rS9Lm DYgiZvDditEz3zvh6fovUUKLKnDobCeDrdIfGMEGwK32sE+JBAGXpy8jTutBhR+dYuA== X-Gm-Gg: AfdE7cne1GYhl3ZSjG6HFGCY/009WYy6BFqH2E9PiHiucyf2eMZOTYkd/TobyQgQcs7 dmqsdqzyqTtxF3gl4S3nVxhHoaf0USOkVKpZLzbOeiV2WxumFa7CfoyJQ4pQymt51heVmeZiCAy kwXH+znU/kDGvJ3lQFKNa7KB5AYSZdMm3C/uZ00wNhe9ABDm+sHsc5ktD9n2KpaMz0g9ofuX5yw pPCIyDWau9URpr2zaxhevEehi0gemY1KQvzq2ILxLO4tRAvU5ZCye+V1VexrLSN6gyHHp05D7XW QZDJ/zLdXjDRFgddo7bkZUzSw0U6HYVU3ZalYYKYOEFND5UIXQHkPXB/EWWLyA0PrpjjSutzcWD ENGlz6CIXIlZbGB/pMawLcmdF25Y5/W+QkwxlorBgiyqb7E+AeaXG7I2kiw== X-Received: by 2002:a05:620a:19a6:b0:92e:5936:f65f with SMTP id af79cd13be357-92ebb4b5a83mr90724285a.7.1783345551285; Mon, 06 Jul 2026 06:45:51 -0700 (PDT) X-Received: by 2002:a05:620a:19a6:b0:92e:5936:f65f with SMTP id af79cd13be357-92ebb4b5a83mr90718985a.7.1783345550723; Mon, 06 Jul 2026 06:45:50 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 02/32] target/i386: Remove duplicate tlb_flush() call in cpu_post_load() Date: Mon, 6 Jul 2026 15:44:57 +0200 Message-ID: <20260706134527.84808-3-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706134527.84808-1-philmd@oss.qualcomm.com> References: <20260706134527.84808-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: kY3LSWoA3pxKAfvEZcO1u5YYT5vwh5cd X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE0MCBTYWx0ZWRfX3tFXhFNLjBeS Oce0stoofWJicMYCkbR60hcyJja6iG51uNMfRvFpCLHGAu6Usr4VsP9sio+3q4WJtryu0nXPlch aVP0gvSBB6lAE8VrL1XsPMEDV4RAEL8= X-Authority-Analysis: v=2.4 cv=Mo1iLWae c=1 sm=1 tr=0 ts=6a4bb190 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=PLEY+c9/kVlxBKEpvFYBUQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=pGLkceISAAAA:8 a=Cu_OB6cER5A0ZMY7a4UA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE0MCBTYWx0ZWRfX5QJyrHNKYHwN pTYVo3a1LLUREuJpQEPquuX8IOqoqAXCw77XSZKA2Bg9eS4hOKECHqF4ZzvtBRjH23m/ILzYZnq 8YZ1GhxMCZRTjPV4z/xlIygpKxhgx2n6s9DPGYaHMJxoEjpyYec/BJCz0YSiJwWDYKcPCwZf54l Sw6C9ba35cOA3bwDv0uB/lADK1inc8/ELv5fd1dMfMjfQF7NCQBkUwYZuqCEc9Q664lvSP+03Jw r67PRKP/DKqWlRDX9p55pFE4v1BK/AacEOgp4or4fXN1LPdzbML52AlHsxfj1/rkQVRl8QEqkww 5aZn1MqfiApFOEqA3NaDHKIDhMw36WEaGJSoBgspf9WNmMYNbJx4nAcnTEgfBQA5E7Xr6EyOoFP Tq8RICD7jY2McLKTje637eSeAKbA0CokbcdNh7PdQhOfI3F19+gAecIFlFIiNiiEsrGVxlb9tTj 0snhOvRUvuOqg4x+NiA== X-Proofpoint-ORIG-GUID: kY3LSWoA3pxKAfvEZcO1u5YYT5vwh5cd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 bulkscore=0 adultscore=0 priorityscore=1501 suspectscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060140 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783345594785158500 Common vCPU cpu_common_post_load() handler calls tlb_flush() since commit 9656f324d25 ("Move interrupt_request and user_mode_only to common cpu state..."), no need to call it twice. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Chao Liu Message-ID: <20260705215729.62196-3-philmd@oss.qualcomm.com> --- target/i386/machine.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/i386/machine.c b/target/i386/machine.c index 1f5c517e562..df0e0c178e4 100644 --- a/target/i386/machine.c +++ b/target/i386/machine.c @@ -401,7 +401,6 @@ static int cpu_post_load(void *opaque, int version_id) env->dr[7] =3D dr7 & ~(DR7_GLOBAL_BP_MASK | DR7_LOCAL_BP_MASK); cpu_x86_update_dr7(env, dr7); } - tlb_flush(cs); return 0; } =20 --=20 2.53.0 From nobody Sun Jul 26 11:01:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783345613; cv=none; d=zohomail.com; s=zohoarc; b=Zczp+rZl4OMZ5SaIr29o06NB8mB3RQU03XyNXCxBAhfyXwxZwQXCSL8QjGfKaKlxzcO7ZNqMD8ubBv8tPTKh3Qd4lQaRpsAHjpFI2vJZBxXCPegXwB9TxlIf6aEAqtOFoCzG4YVZARc7JuDU2NxTi7WhRI2cCejZEW+0M2RT8JE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783345613; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=Ce1sLUDroG8UkuFIYnhKQTJrjdvF9gdtq70M46Gkvxc=; b=kqbUplRlMyxGVNVw1q2LsAozFvv596rrPABf4woW3m2nIequzNTAdQv1iUXdNmDZ4NgdhRJoEZcS9CfQdWDjz9AfuDuVpl1hVpy2pEPfGMzbptv+jbdXd1aDHFN/Rlgi7ZWmKGi5nPcMEXOAObdyKgT/a9/avJLE2eO3YA1ZXDw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783345613152100.81092580398706; Mon, 6 Jul 2026 06:46:53 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgjeX-0006Vq-IY; Mon, 06 Jul 2026 09:46:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgje8-0006Lw-Hb for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:46:11 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgje6-0006B4-IO for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:46:04 -0400 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666AxHXU395393 for ; Mon, 6 Jul 2026 13:46:01 GMT Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f89qph07v-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 13:46:01 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-92e5fc4c7e9so333029885a.3 for ; Mon, 06 Jul 2026 06:46:01 -0700 (PDT) Received: from localhost.localdomain (1.171.88.92.rev.sfr.net. [92.88.171.1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493bef248b7sm290298735e9.2.2026.07.06.06.45.58 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 06 Jul 2026 06:45:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Ce1sLUDroG8UkuFIYnhKQTJrjdvF9gdtq70M46Gkvxc=; b=nIe/h8m7VluzKqAl Q5sWQy+6LwLoSqwDdEiQ7d52UX5TErxWb7oUde6l3wsDZeJaQXtpck1GWxmTf2f7 ScAigQEMufCCqw8+QgT8149lsReaZMXtISopSZ9LSDv5SP8oc3zJRxQl+jO5lOml Gf2vrsBlT6QWY0O9JwRBJ5yIuHhOXlaFrx08u5U53p3mPGUJJKcGiOEA+hLph0RN RKbfNuK6HuoWnyStXoFt+x7MMCndwTzVaiuriolhg3p8K9rU21JPIt48oZnvt0Lz u9qhmSsd47x0zSyRztzyOX/GotWNemWAjBpV1jD3ANLQd2aZa/PcFMrQ410EVX8q fRh08Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783345561; x=1783950361; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Ce1sLUDroG8UkuFIYnhKQTJrjdvF9gdtq70M46Gkvxc=; b=C6efEAB4EHvGaesn5/fOXXu8LIKcB9aVX6immTnrt5QWonENRNW5OqMiv1pHRHk/Xu qAxvmtqnA4zKHMxY3OFBIUZz2vZFivVJZByTAQv3mj2VjI72zRNiV+YD3ihq194OHfx0 UOu63xqyJladwHlA1BrAd0/5bDUttUNlGQCQeciVTxMW663TE+1nWv6Cf1bj/RnBYmpJ 02W1Yh8UJqP2fuW+IGp3G5aQQrCdoI43aUt+njLpT5v8pm+JXHZ4VLT7JmMkzs9d6taj PAsPRHb0VpsO3qSTBk4cUfI1HeX9nNtmBXEH931dXm8zwW/Qkk9/PkHbqeNjTyppUROV kB/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783345561; x=1783950361; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Ce1sLUDroG8UkuFIYnhKQTJrjdvF9gdtq70M46Gkvxc=; b=cg8ZCN3uPwJLCw34kDHGQYdg6mnqvwjpQ8YW9HX3N/eQ3/pW7EiaVrR85LpJz36XDK oM6vzkEH7S52zrX7sidWY4oVHUoeW7nyPCrJRM5qMDxjuO7aOXj/ceUgE6alQUNbYd+n TFgBZFJKI8bGvlrWWWJfv0kck9SGSR3efB66tJuQ60m4Pfr92jBDjhhHbEh1OFo5uGNl 9IouOsvkTjAZbrQ/zbiTSsyKZLtJVHd1cA1QwJPiOEbKjcCXuuCXliDuSMyP8ct4KkDv HStYocSUFIJPZ01OBwSEcQfC+/2ovocoyY0D/1bTILUevL9f6myxAO0kDF/W+CWrHRK4 JYOQ== X-Gm-Message-State: AOJu0YzuVl1ITiStdrxUb6V/afsdsYtyqOV9ybE2JXvI7+v0yyfIh2lj dhvD5g5bJrIZ+Pa3PT0rUSnpNuTGrZw6mzmUI9tKEGz+yeS47CHiK43sf3nNSBQF01haqaOSMR5 WZvEPaMoQmJh9g5DKHgQObqae6ASmmGJwOOhS4YZgk4PQclqg/Z1XAvYxckEZ4CGBKw== X-Gm-Gg: AfdE7cmAqnX8Jc3bSZFO+OfiT0QxMYIXQPtxMWRSrt9B0H+0EbD4v8sZyeumD5v76zo 5zXI5c0ZnF0FeQPtRZ4SyRtduVBIFHZFeZFhuMAhvZ/UcIKnUKocKTVXAB1WVzdgAx82bW6CoOz T3kS+4dMdrQ2lU59jdyS1ePH4RJyreQw0T4NB58oIsCcLMRxI5BsS2EELwOpjQpG6LD4ZxU7tqp t2I9MmiZTbP5qEZpthG4WRxKV45wO4ONZ94nqgYRcfScrV1JO/OXytjt2krb+oTXltH4LEavaU/ OOcmaFlf0fnqmPKCy2GNI0yW3f1XuDQxLlHIM7CuFa8X5jY73Zt5YKanzCcyhqUJoJ/zAf0aBcH sPuvLIEIKki1Z3WGWGTmKg+4XMg0ljUKysOZ+L/cE8Iol60P4buRdB95NRw== X-Received: by 2002:a05:620a:4693:b0:92e:73bf:e920 with SMTP id af79cd13be357-92ebb5f5b35mr80522485a.50.1783345560810; Mon, 06 Jul 2026 06:46:00 -0700 (PDT) X-Received: by 2002:a05:620a:4693:b0:92e:73bf:e920 with SMTP id af79cd13be357-92ebb5f5b35mr80517985a.50.1783345560255; Mon, 06 Jul 2026 06:46:00 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 03/32] accel/tcg: Restrict tlb_protect/unprotect_code() to TCG Date: Mon, 6 Jul 2026 15:44:58 +0200 Message-ID: <20260706134527.84808-4-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706134527.84808-1-philmd@oss.qualcomm.com> References: <20260706134527.84808-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=c6qbhx9l c=1 sm=1 tr=0 ts=6a4bb199 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=PLEY+c9/kVlxBKEpvFYBUQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=pGLkceISAAAA:8 a=glojBnVPa3CR4aLdIrwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: c_pkW0J2QHTrVNtCoo_ERWxX_A8pSQqC X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE0MCBTYWx0ZWRfX2M8fy5bi8szi YTPA05yQzlO1AQTW8eKlYjd/eRUknz6OcyAJJMUfCvt1IwrNpGbs+o0BTwAMYJiKd35LBB8dCEb 86wLx1PoVTe2DUjnTMrhXybOqhWvCvfj6TaA31n3/WHCrIgO6Mv3ZlV9GnybBItlphUwvg+MukU qvqOhJlIFxAqtQBmKECVZn3pAWDD0VR2L9AcVwE2JJ5/qzkaTTcQXfOEPQTCDJ6qu/2t21zkCOY u7rXvpxTYks91GZ3PGRleSmeGTzxJ2PLUkeggjLPcaisffeCGV5Tfg1pq1Hfv+ibd9A6QWPKCbN LzbYxnW+32Tc2Z/wrysPNxR/JrEAWVn3BzWCGLpHOtkzTphT3q/xpYPHejEjINkwwkfNeOJVmGz n2ApZgBOE73Kjjj6+QgjndHbtToEZJ64cotIolPfb4DyRmwBfvNOoMlALpEdxWAxb0ZMXyqDPnF yGrVT0CMxKh20A38rYQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE0MCBTYWx0ZWRfX5nHSJrl2XlFo YkRoslLiUdbCR1IV7RBPbdJdTUP0OQ+Jq15wBHiKqTPIYHXg3swn6zkxRWbQ2X5l59Wfb+DJLVw qFcfGyCjaU7GowVSpwMo7194TsnvQhE= X-Proofpoint-GUID: c_pkW0J2QHTrVNtCoo_ERWxX_A8pSQqC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 impostorscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 clxscore=1015 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060140 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783345614942158500 Both tlb_protect() and tlb_unprotect_code() are only used within accel/tcg/. Avoid exposing them to the whole code base, declare them in a new "system-page-protection.h" local header (maintaining the previous LGPL-2.1-or-later license). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson Reviewed-by: Chao Liu Message-ID: <20260705215729.62196-4-philmd@oss.qualcomm.com> --- accel/tcg/system-page-protection.h | 17 +++++++++++++++++ include/exec/cputlb.h | 8 ++------ accel/tcg/cputlb.c | 3 ++- accel/tcg/tb-maint.c | 1 + 4 files changed, 22 insertions(+), 7 deletions(-) create mode 100644 accel/tcg/system-page-protection.h diff --git a/accel/tcg/system-page-protection.h b/accel/tcg/system-page-pro= tection.h new file mode 100644 index 00000000000..52896c6d24a --- /dev/null +++ b/accel/tcg/system-page-protection.h @@ -0,0 +1,17 @@ +/* + * QEMU page protection (system emulation) + * + * Copyright (c) 2003 Fabrice Bellard + * + * SPDX-License-Identifier: LGPL-2.1-or-later + */ +#ifndef SYSTEM_PAGE_PROTECTION_H +#define SYSTEM_PAGE_PROTECTION_H + +#include "system/ram_addr.h" + +void tlb_protect_code(ram_addr_t ram_addr); +void tlb_unprotect_code(ram_addr_t ram_addr); + +#endif + diff --git a/include/exec/cputlb.h b/include/exec/cputlb.h index 3a9603a6965..f7f7020382d 100644 --- a/include/exec/cputlb.h +++ b/include/exec/cputlb.h @@ -24,14 +24,10 @@ #include "exec/hwaddr.h" #include "exec/memattrs.h" #include "exec/vaddr.h" -#include "system/ram_addr.h" - -#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY) -void tlb_protect_code(ram_addr_t ram_addr); -void tlb_unprotect_code(ram_addr_t ram_addr); -#endif =20 #ifndef CONFIG_USER_ONLY +#include "system/ram_addr.h" + void tlb_reset_dirty(CPUState *cpu, uintptr_t start, uintptr_t length); void tlb_reset_dirty_range_all(ram_addr_t start, ram_addr_t length); #endif diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c index 6e66f3c6e93..7f7c208ba12 100644 --- a/accel/tcg/cputlb.c +++ b/accel/tcg/cputlb.c @@ -1,5 +1,5 @@ /* - * Common CPU TLB handling + * Common CPU TLB handling (system emulation) * * Copyright (c) 2003 Fabrice Bellard * @@ -47,6 +47,7 @@ #include "tb-hash.h" #include "tlb-bounds.h" #include "internal-common.h" +#include "system-page-protection.h" #ifdef CONFIG_PLUGIN #include "qemu/plugin-memory.h" #endif diff --git a/accel/tcg/tb-maint.c b/accel/tcg/tb-maint.c index c33dbf65e7f..4313864d2c5 100644 --- a/accel/tcg/tb-maint.c +++ b/accel/tcg/tb-maint.c @@ -38,6 +38,7 @@ #include "user/page-protection.h" #define runstate_is_running() true #else +#include "system-page-protection.h" #include "system/runstate.h" #endif #include "trace.h" --=20 2.53.0 From nobody Sun Jul 26 11:01:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783345617; cv=none; d=zohomail.com; s=zohoarc; b=gGzlTMPYStZAwYNdIQGz7AGwHEQXYzQOXMqXFAmt9vP2RMUDks3mAauoWBrRiJAQsAkSU2enzBymo4mcERQRA13gD1ssagWcHokgF/XZREsj+A0AoIB7Puj3wrJJwaB3+cWbkwFkvC+qfb02CKDh1xp5V3pIh0XxOuxlq80lUKk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783345617; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=prUV9jPrIyyxVkROHeQLYlkopX77R4wBHak5R4ybLUs=; b=iMoguRORzgfVJOJeBTfryMf0aOzRDqMkUGAgfnN7vOqXMPdNfz0Cmp2dslzMOWEfctrJo5MNwG5q+9++rulmQdww2iwJ+HACMqqclhR62EkpaLz5ek/hGd1F8DLn56bIsL2kRD4l0EyzkraG+InggeLMteM9vembs5DMSMT7UV8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783345617644605.4328088325469; Mon, 6 Jul 2026 06:46:57 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgjeh-0006ee-0Y; Mon, 06 Jul 2026 09:46:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjeJ-0006P9-Aj for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:46:22 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjeH-0006FD-K6 for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:46:15 -0400 Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666Ax9Cd391072 for ; Mon, 6 Jul 2026 13:46:11 GMT Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f89kgs16n-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 13:46:11 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92d1cae5740so350898385a.0 for ; Mon, 06 Jul 2026 06:46:10 -0700 (PDT) Received: from localhost.localdomain (1.171.88.92.rev.sfr.net. [92.88.171.1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c63bfba1sm425277175e9.15.2026.07.06.06.46.08 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 06 Jul 2026 06:46:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= prUV9jPrIyyxVkROHeQLYlkopX77R4wBHak5R4ybLUs=; b=fnfSQ0GJa01GAeh9 2pHl2c46hY7mkMT2LEbS2dy1Ou7yZSvocXbszmYiIf72ei5snDsHzvhsrGKoZFeT x/gxAMGfk/qbCPjXJoskxx5s6uOYuhuTOTintRaBvVQBwiAxh6YCfLLBVzcyHg6o DjVWmvBWojpa68/dPNMvlNENwWhiMJwul90w/B/kV6tDtEVyFudtRP2Mv4L4/Vsl 3fDsJHjtaT5C2N/IaTILcclF2ZSKWb8GWF8fkg0TWOrMDjHKA3+o7liGd1359VQ4 RxbOwCZhzFQjsI46KWjBRDK08ayTwRiDwvphpuX9P83nDZce2qiEfg5G1fjq5oEP K8royw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783345570; x=1783950370; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=prUV9jPrIyyxVkROHeQLYlkopX77R4wBHak5R4ybLUs=; b=iBwSxXm468YlRLHNvHWTZpmyUt15nDFJ3GQdjIpsco+IKtr1waA2mEG7k0syP9Z/hw y+WgsugoFDum1EfCtADBq3N2NOYtijUGC+Ce6QDQ+ibKVPRXy6bgNN4ECNwsBtRMByfc 1YgOKo1Lst8Bgb9v3QkwZKWxQyiICtkSvrBs/GqmXZGIPFYI7kHm/KDTw2E/IjG1/B77 yOnyANjmWq8DUebuNQVJ75w2FsyX5qRxNbKE6pAJ/Rcc5M7Rfp3wlX5BBBeogKjMeGzh /9gSs/v1Rld2YgLX0fZiK89HJ4YxHOzWven16Nlm83jG3gqFi92JxmqfeV4+11bnb8ON +g6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783345570; x=1783950370; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=prUV9jPrIyyxVkROHeQLYlkopX77R4wBHak5R4ybLUs=; b=Plpa3rSVmwoQTI/chEiQXGaGkkoSLUTJA5CS7PeCxkAgumEkyPDMhCq88uoH+PQZe3 gXN+0HHbx3EXe0cP3ycNEEXPWnpdYTS89zzeCMn3BXuiuFxwsR0uY3D5waUm6jDzZwlR 0mlpnezB5172HsUSjH4EIXkw2jUJMDyAgQ/SGh9luSSkZXPSfdOO73q7S9eaYmXrK8u5 0s37yXKKUeEdc00ijwhiaqKfT7C4oAiaXhjgaya0qcGQRYTzbn55/FnQLKUqtdIAF/No neJKcJZdB2h0L64MxyzdRFeEiBI0D93jtfyDLrqRvfMeWEfhbnD1E4xi/4zKcksGbPKW uzcA== X-Gm-Message-State: AOJu0YyDktXcys1d3mQzilK+Qh0hl5qhxqsGd+QjzCLKy6PmWjV6ArIS 5OZE+8kd6hvO3MO7Th4m6SEFb25U1gq+7KR8UexSxv5OssKGvXiRJO4MLCZd7vITNLQNiFOXAe6 Q8nZCkzD0gIvuHFO3lOQpHIWQ4IUdq+4UMwmcyj0WGL+pzx+viYxfgfEdxIMKKNIg2A== X-Gm-Gg: AfdE7ckwbxTr7WlhJ3QAXRdBYErwVtgJiC0uTIdd3byz9G7mNDa3R4HGzJ/IXJ0Moqm k38tLBtPLyOA/IYy+QVrDzw2sTZM8+Gq0IPltBsDxdn6uVmtrQoTXaRfyu9HSOPwMhDY8cID6rw FEK6gaW2lQ4AkF3qNJyODh0cFRV2TQp5isVXl+HaxuVnHn4igCxThNOII8fDM6QuZ2AwFUCiZiF Dl2n3TMG/OFYjxVhosXxVOk0Z9IPThpvGR/kvfdJTqO15+LozTcSXWR5GXBbjVksTm5Dv+nfGHH bRf9UQBnPr1nIlEJEV344FuRhDi/olGDVUSWJvAleyqlAox0m7RW0Ce5KCQKONad+6n2U+i+v6f TPnAkJpWH+iUApS42mB2UKDjB7vGE1ZzveVDrbGO3FrPnOGCHRno4ILHAMg== X-Received: by 2002:a05:620a:17a4:b0:915:f96b:8f5a with SMTP id af79cd13be357-92ebb5df141mr85059185a.36.1783345569936; Mon, 06 Jul 2026 06:46:09 -0700 (PDT) X-Received: by 2002:a05:620a:17a4:b0:915:f96b:8f5a with SMTP id af79cd13be357-92ebb5df141mr85055585a.36.1783345569365; Mon, 06 Jul 2026 06:46:09 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 04/32] accel/hvf: Remove left-over comment Date: Mon, 6 Jul 2026 15:44:59 +0200 Message-ID: <20260706134527.84808-5-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706134527.84808-1-philmd@oss.qualcomm.com> References: <20260706134527.84808-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: v8NKPDbz-xUryx1nr0cFZg-ckyhXH85O X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE0MCBTYWx0ZWRfXywOv0mlshalG p7D8bkZQGp/jV6DgbD4l+zc056Q1PSxzhyZkovw+K34z4alhFPcH1POezUzfP10iG8Mmilaqg4w lsC8o5TFwMnUFmvf1Lliu188doPy5QV8lmI/17cV+X6TytiljW9tFdO+vmnkl8jtg41JxKX3Cnj gpmfCw3QpsF7STSsXon4zr6ieXESSmaxC5r6P42n2AMyMsXOeb07AtOmAV503CAP3tz5PRLj2wR BT5QgDsYtn5uTpFEaQYV+gL55wKKpAa8os6g3mlciNI8neQdmVeoxb+qkdqTPtWGFIMhmG4EUYi LQcRBNVSIfglEYVVIRozE5L77M9OsS1wWbJv01Wxv4+kvuXH6ReAd54rOo0S0QzPdtIc4uZQL15 tbCrIL9//gwo3C0yRKDYg3HotlbDosqw0p1nabUisYovqc7zSLhfseONaMPdP3x8CX5231i3k0F 3wFm04BuojqP1OmszzA== X-Proofpoint-ORIG-GUID: v8NKPDbz-xUryx1nr0cFZg-ckyhXH85O X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE0MCBTYWx0ZWRfX89YCZnCt9zH8 tgj065G29Skwfg4O33pKAbf/ZMspX5SMYIxH6saOTJwmKHj9FDEv/aFCNaBFh4lSkP9WqlZ4nLb +6EA7GONqEZ77jhrt+piq/xJ6ARXfEI= X-Authority-Analysis: v=2.4 cv=c6Sbhx9l c=1 sm=1 tr=0 ts=6a4bb1a3 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=PLEY+c9/kVlxBKEpvFYBUQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=nS8E-dRYisaDM6zJQEoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 clxscore=1015 adultscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060140 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783345619081158500 Missed in commit 6bf331164c5 ("accel/hvf: Drop hvf_slot and hvf_find_overlap_slot"). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson Message-ID: <20260705215729.62196-5-philmd@oss.qualcomm.com> --- accel/hvf/hvf-accel-ops.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-ops.c index b74a5779c3d..dd2b45b7cb5 100644 --- a/accel/hvf/hvf-accel-ops.c +++ b/accel/hvf/hvf-accel-ops.c @@ -62,8 +62,6 @@ =20 HVFState *hvf_state; =20 -/* Memory slots */ - static void do_hvf_cpu_synchronize_state(CPUState *cpu, run_on_cpu_data ar= g) { if (!cpu->vcpu_dirty) { --=20 2.53.0 From nobody Sun Jul 26 11:01:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783345617; cv=none; d=zohomail.com; s=zohoarc; b=GLWaTP+Kob32B+T/X43WLZC0VnSstDYzMeWWYSBtuYuqKOk1QZyxhbe0euj0Njmd4Z7lEsND0q////Mti+mC4auLJOAY+/4lcdg7aCkKcsS0bAc4ng7QfvA3ekOjekBIQY09lQspnkEg0K+Nsawea4DtLFC/1BKMTdD2HusxL5g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783345617; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=ydw1wznZXSAB0x9OfCcI5F+1RiZNU1iwVhUsvHWYtEQ=; b=lhiG4CapVU8A475cMrRudaHE5bwwJe/ezbFGQCfMLPNUsvZr93yUoHhVWeblIy6zSRng8q6PicSpIuFSiMXc2bxSHwqaOMSAX/3LGT+KrHXkCkvAW0Ozomoz/2/ACMIxegwrw1e36y5xZGhY6W+4oTMz/sAF3Crua7CgDfC7m3Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783345617773125.90663881831335; Mon, 6 Jul 2026 06:46:57 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgjef-0006d5-7d; Mon, 06 Jul 2026 09:46:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjeS-0006UE-5s for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:46:25 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjeP-0006Ip-LG for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:46:23 -0400 Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666AxDm8238262 for ; Mon, 6 Jul 2026 13:46:20 GMT Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f88t898md-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 13:46:20 +0000 (GMT) Received: by mail-vk1-f200.google.com with SMTP id 71dfb90a1353d-5bdad49fe15so3102450e0c.0 for ; Mon, 06 Jul 2026 06:46:20 -0700 (PDT) Received: from localhost.localdomain (1.171.88.92.rev.sfr.net. [92.88.171.1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c63ba971sm618972245e9.13.2026.07.06.06.46.17 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 06 Jul 2026 06:46:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ydw1wznZXSAB0x9OfCcI5F+1RiZNU1iwVhUsvHWYtEQ=; b=ZP4vQymQvbSNw3Cc 0L5a9jofDXwNqMeQYoLsbPRlc38nmONlhXXstI/vQVrWNArmM1mk11A57UJ8xOtQ 5ZRwBcTFrGf0fnIfWDyJS8EkbwuT1XrtkVkYP/D3yFO3y4bC9lOAJJgktVfw7x3o VibloAZoaHnxruSqeP8KV/K6bBC/FhIDPI5dq0KOqpnZWbTxQDXK/DkyWUpN2gRS JuF9U/Jqx9h5XokPlgWqOq22r9PB79irPvHTpKWRMRtW6qarUGrW2ABWF0dpKmHr t+u8CKWQ24qKLKIICPEyH3Z3qTCnTZFMOt1iEhGm0+Uv6fm3dZ8q0v3APFhcMtZ+ vLaGOg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783345579; x=1783950379; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=ydw1wznZXSAB0x9OfCcI5F+1RiZNU1iwVhUsvHWYtEQ=; b=V98FEMcw3B+gFV59WuT6sV+I5O7UmWZq9TWVAuxC6MmhFrHhHAicaGJZ5mGujU1JqA xNejEBwUkxQbY8dAXeNKD2DAAHpkD4eLkwIfrSZknBmiFRFTcY0Trnnwz+xo/4f2deka eppFyHOZToRB2GAsCy3y6zgybHLm97R5BaztYqqYSIHVe8a47R08MJpGle7gAYNkR14E swJhsAHMmn/SjCilsuMbotTYgtHl/Zhk4up0fBz3NFdk8fSg/2BlhsTi7Qy5LbdS5Lb/ tM+No87OpPQLIujjjgAcf1DoodaBl1p00V+DXU3I8isGSDIrcCWbrvJafuKhYrXzWza9 6poA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783345579; x=1783950379; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ydw1wznZXSAB0x9OfCcI5F+1RiZNU1iwVhUsvHWYtEQ=; b=Azr1y7zojgdS8BBa6fAuL1VT6Zqx5jJaLjFE3yaCrZsDE4sSwvDN5FTGZiUR1t7ltU u+dd/fw3Q1TEkamI3OrI+55oN+S402ijEDLL1xG8Q5nNVN/ubpGzv9baFNTXnSmlN1Mg 3MQWdNFso2RxdtYaIlS9P9gM/iErWD/I1YI31ELGqyGVHFsYkaIy+M1ESbJuKhBMtfKJ 9hNOrFoxUI42KTczfFtDHLjNyQN0j4NGoso13SBVr8s36k40exRxXy1oF30D16d2gglG VuWMUgI6hRoCZWZHCW2EtCx270PlHccIUhtijkY0AEpoI8yfN9Cf0R0bmwC9n6bNpVt0 UNmA== X-Gm-Message-State: AOJu0YyDwT0G2ByL6zvnmlbAI92LZuDowlPoB3lybiREZ/AdkpH+KF7c KlFrygGMpC3Uqs0mC54N6hPneV2S8DMNTUgu+yTl2pDCa2u/khHzIxhAp7nD+mZzcBAZ2RvPt6m 7A1dLHzSULbgYuur3qnhRf5lKRDxBk5BuUh/Tfr3iKlQq2CLmV3pUbya8MCJdWefS9w== X-Gm-Gg: AfdE7ckl+VpnjjjHf3KVdqSHBfsvEu7bjxffucRv5+PKsoOBVQMh3dzbXHS23KAhr6A 87x9nbwL1sdZQTKbTR+6Cvvz8KVNXcDht4jqFtFI8FbY9GSXM9EFv8WxRQFs4fggllW85tZnmMs pJX4d2cxMV4p3s5D/FB/GVaOX4WOMtkO05QSiGDOTMWE56aWFamQQ4MNjgooL3IAg+3qtwkcdeg kVnOLdZ00qZ/bGZnlTEOfTmzfENQSfA7LA4y8zTYgGKguwLU1JuTWxff6knDJgyswfSnWPBCtF4 C2PQprhHNWCRl0wSrGzrpBB6D5RWUxWdGaeZfNwJgSjZ62QRwDjt9nzPKQWmXCa6Mk5/YHFinM0 KQlpZGmXU9JLCztbtclDh+z3CBOp7TDuU6wnUkVMH5DMfR14AcIBQIR5G+A== X-Received: by 2002:a05:6123:161:b0:5be:bea:6ed with SMTP id 71dfb90a1353d-5be90720aaamr353455e0c.4.1783345579248; Mon, 06 Jul 2026 06:46:19 -0700 (PDT) X-Received: by 2002:a05:6123:161:b0:5be:bea:6ed with SMTP id 71dfb90a1353d-5be90720aaamr353404e0c.4.1783345578626; Mon, 06 Jul 2026 06:46:18 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 05/32] accel/mshv: Replace @dirty field by generic CPUState::vcpu_dirty field Date: Mon, 6 Jul 2026 15:45:00 +0200 Message-ID: <20260706134527.84808-6-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706134527.84808-1-philmd@oss.qualcomm.com> References: <20260706134527.84808-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE0MCBTYWx0ZWRfX4r/ZqpWU4WhW qCaxPJ1tfA+Rr4nRSwYuP3gGe/AEsamfCQKu7P6gAn1FbCwrBm9q4QKwprIUZzLsYajERRZM5bg TfODmrckplDtRSWMgdTUA9vDjTb+0aw= X-Proofpoint-GUID: fw1QdA3ax92oHrCV84MKWV2-IcV74i-P X-Authority-Analysis: v=2.4 cv=C6zZDwP+ c=1 sm=1 tr=0 ts=6a4bb1ac cx=c_pps a=wuOIiItHwq1biOnFUQQHKA==:117 a=PLEY+c9/kVlxBKEpvFYBUQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=yMhMjlubAAAA:8 a=KKAkSRfTAAAA:8 a=lTdEn7Fablbk7hdpwAcA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=O8hF6Hzn-FEA:10 a=XD7yVLdPMpWraOa8Un9W:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: fw1QdA3ax92oHrCV84MKWV2-IcV74i-P X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE0MCBTYWx0ZWRfX/OkFpPAUat0d 7rRfdT6dB+8cS2Z+uuLoQFSK48vCAlCbOArYzDF8iFZi7HLqP1aW+3Ox1onmLLkPvCFL5wrfDFg AWuQhrGYbU8w2SOXWRQPDTZDVA9l+CqeTnjOwN/7sUFbU5EvsJONwxQKfi9dZdEP5WjHUmOseQq cGfb63qGo3UX7Iw1mLcLGrquhvOYrVM7W+I854cogvbZbkqrBDPsQwJF3ZqJwBvSjGOXATeAiTL J3yNLfEUeXXdi764y7H+NxkH51ulzZhJbnGTB96f3feRtq9EfaG33dLaM6/LouRnM8Lcb7DCTi5 KnH+V4QFWbhoVojeVTr68EgH+Qi91DFmb6eF7kwP2ntxUqS19/gi9nax2uZremxL5fciRgPSTOW vzILvGCOqiqdyaKjsbXJsMWSPU6OO9Pq1N7bp0DVb26E6b2EixPlyLTQfdFR6F2juXnVcVLfFOf jAkApPbZKWf5xz+IsIA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 clxscore=1015 spamscore=0 adultscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060140 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783345619133158500 No need for accel-specific @dirty field when we have a generic one in CPUState. (Other accelerators already did that in commits 6f13a0ada01..36ab216b81d). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Magnus Kulke Reviewed-by: Richard Henderson Message-ID: <20260705215729.62196-6-philmd@oss.qualcomm.com> --- include/system/mshv_int.h | 1 - accel/mshv/mshv-all.c | 18 +++++++++--------- target/i386/mshv/mshv-cpu.c | 6 +++--- 3 files changed, 12 insertions(+), 13 deletions(-) diff --git a/include/system/mshv_int.h b/include/system/mshv_int.h index ba3073888ac..b91c4d661a3 100644 --- a/include/system/mshv_int.h +++ b/include/system/mshv_int.h @@ -43,7 +43,6 @@ typedef struct MshvHvCallArgs { =20 struct AccelCPUState { int cpufd; - bool dirty; MshvHvCallArgs hvcall_args; }; =20 diff --git a/accel/mshv/mshv-all.c b/accel/mshv/mshv-all.c index 9452504ac28..1959baf6672 100644 --- a/accel/mshv/mshv-all.c +++ b/accel/mshv/mshv-all.c @@ -531,7 +531,7 @@ static int mshv_init_vcpu(CPUState *cpu) } =20 mshv_arch_init_vcpu(cpu); - cpu->accel->dirty =3D true; + cpu->vcpu_dirty =3D true; =20 return 0; } @@ -617,7 +617,7 @@ static int mshv_cpu_exec(CPUState *cpu) cpu_exec_start(cpu); =20 do { - if (cpu->accel->dirty) { + if (cpu->vcpu_dirty) { ret =3D mshv_arch_store_vcpu_state(cpu); if (ret) { error_report("Failed to put registers after init: %s", @@ -625,7 +625,7 @@ static int mshv_cpu_exec(CPUState *cpu) ret =3D -1; break; } - cpu->accel->dirty =3D false; + cpu->vcpu_dirty =3D false; } =20 ret =3D mshv_run_vcpu(mshv_state->vm, cpu, &mshv_msg, &exit_reason= ); @@ -746,7 +746,7 @@ static void do_mshv_cpu_synchronize_post_init(CPUState = *cpu, abort(); } =20 - cpu->accel->dirty =3D false; + cpu->vcpu_dirty =3D false; } =20 static void mshv_cpu_synchronize_post_init(CPUState *cpu) @@ -763,13 +763,13 @@ static void mshv_cpu_synchronize_post_reset(CPUState = *cpu) cpu_dump_state(cpu, stderr, CPU_DUMP_CODE); vm_stop(RUN_STATE_INTERNAL_ERROR); } - cpu->accel->dirty =3D false; + cpu->vcpu_dirty =3D false; } =20 static void do_mshv_cpu_synchronize_pre_loadvm(CPUState *cpu, run_on_cpu_data arg) { - cpu->accel->dirty =3D true; + cpu->vcpu_dirty =3D true; } =20 static void mshv_cpu_synchronize_pre_loadvm(CPUState *cpu) @@ -779,7 +779,7 @@ static void mshv_cpu_synchronize_pre_loadvm(CPUState *c= pu) =20 static void do_mshv_cpu_synchronize(CPUState *cpu, run_on_cpu_data arg) { - if (!cpu->accel->dirty) { + if (!cpu->vcpu_dirty) { int ret =3D mshv_arch_load_vcpu_state(cpu); if (ret < 0) { error_report("Failed to load registers for vcpu %d", @@ -789,13 +789,13 @@ static void do_mshv_cpu_synchronize(CPUState *cpu, ru= n_on_cpu_data arg) vm_stop(RUN_STATE_INTERNAL_ERROR); } =20 - cpu->accel->dirty =3D true; + cpu->vcpu_dirty =3D true; } } =20 static void mshv_cpu_synchronize(CPUState *cpu) { - if (!cpu->accel->dirty) { + if (!cpu->vcpu_dirty) { run_on_cpu(cpu, do_mshv_cpu_synchronize, RUN_ON_CPU_NULL); } } diff --git a/target/i386/mshv/mshv-cpu.c b/target/i386/mshv/mshv-cpu.c index 126ca40b481..1c433c408c8 100644 --- a/target/i386/mshv/mshv-cpu.c +++ b/target/i386/mshv/mshv-cpu.c @@ -1692,7 +1692,7 @@ static int pio_write(uint64_t port, const uint8_t *da= ta, uintptr_t size, return ret; } =20 -static int handle_pio_non_str(const CPUState *cpu, +static int handle_pio_non_str(CPUState *cpu, hv_x64_io_port_intercept_message *info) { size_t len =3D info->access_info.access_size; @@ -1748,7 +1748,7 @@ static int handle_pio_non_str(const CPUState *cpu, return -1; } =20 - cpu->accel->dirty =3D false; + cpu->vcpu_dirty =3D false; =20 return 0; } @@ -1909,7 +1909,7 @@ static int handle_pio_str(CPUState *cpu, hv_x64_io_po= rt_intercept_message *info) return -1; } =20 - cpu->accel->dirty =3D false; + cpu->vcpu_dirty =3D false; =20 return 0; } --=20 2.53.0 From nobody Sun Jul 26 11:01:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783345657; cv=none; d=zohomail.com; s=zohoarc; b=MIgCEVAdbqdwdvUO/0S2A6ubdNlavXG6HzhnbVNOurm9NRJn5XoHh6q6rL7jmETyOTkhpuP31ViIk/8ZmB2H99F/4pB4bBDEirfxoY32k0XBCCP+YjPNSebQZPgotZDZc7EmhUe8PG7LN+JljuWrLTwbb7XbjPQ95iunsZIr4B4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783345657; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=VgjHWAw6InKlS+1lEYDJ+TpMs8mphoE9ISbtQeMuI8A=; b=EpMTUe/2GZDj0OJPgasUovlbGv8WPDdXeFQvXF+tLf1wMtL9CYe5y9Uyy8IB5RwCOvrC3P4bNmfCI6fLWNkYKBOZlWtTelZd8cMWcUSN58kVeuZz1lhTjtry+NTUEEFUeQK6zs8+GW+7adcUoBLYd9yQyMcnyuszcK9TQXFPX+Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783345657493616.8762715584273; Mon, 6 Jul 2026 06:47:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgjf1-0006qb-OK; Mon, 06 Jul 2026 09:46:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjeZ-0006aX-Hp for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:46:33 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjeX-0006LC-QE for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:46:31 -0400 Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666AxMHx316792 for ; Mon, 6 Jul 2026 13:46:28 GMT Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f87q7hhwn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 13:46:28 +0000 (GMT) Received: by mail-vk1-f198.google.com with SMTP id 71dfb90a1353d-5ab02fb3054so1438689e0c.0 for ; Mon, 06 Jul 2026 06:46:28 -0700 (PDT) Received: from localhost.localdomain (1.171.88.92.rev.sfr.net. [92.88.171.1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47a9e4d7801sm25533406f8f.16.2026.07.06.06.46.26 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 06 Jul 2026 06:46:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VgjHWAw6InKlS+1lEYDJ+TpMs8mphoE9ISbtQeMuI8A=; b=kX/0r9CvPi0SC/h/ QAwoVyILqXEzricP2XmQZWorBknPb1jH6jrAxqyI7tVX1xJcggip96Yb02/rUf2v ehq512zy8wmAH4UTlRQRFvJ15eoNQImh2nBeqiRL0+RRAWKyfX+oyqhftVsah4mH MfJpUSewINyhQBRujGH9+oOdHMj5uV3wcfI7bPHJULuOGkj2PmDsFkCH1TZlVsjm +pI1tv4sBOjl7M8ozJEmaqkeXqVpqlZRAOSbcr3qLwhpVN2yyZ63hgIA7Rc2C4Vu BS0N83T6CYm9vgAF34DNjUnGw8295SYGJiZxkygOZRhAi6/zNW17e16ZZMz1um0J bNQyjQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783345588; x=1783950388; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=VgjHWAw6InKlS+1lEYDJ+TpMs8mphoE9ISbtQeMuI8A=; b=cz4ipw/3bsmt0CX9Zq4MqeGykK0rBp0B/27JzvUi/Ql//keeOxTappXNyIxLIZ1Q6L KiKM+bFBpQ4M0JBo8sBuJ8HEaQ4i/LQe59OStBSWE8Ls6sYpMCmy+7ntVo/fpIhTClWT dPobxEnVfqINnbP/IGNgdxVhMvyQNXyeoULwlweGgbMEERW/4Bo8j8OWQh3axxdhq4Pp GLv7w1UBw41TEv3WT2BdRPxCs0s0Djv2tSw4lBU+gyUtSCCkZVGD4Mmw1Lmae1HJR/yt 5jb+/bk1PpgPCc/POVTzRDlvUJfX+5GoiZW8ydouDC7PcYFkGhcQEKs8qyk4moNjmV47 VhIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783345588; x=1783950388; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=VgjHWAw6InKlS+1lEYDJ+TpMs8mphoE9ISbtQeMuI8A=; b=AD8ge9c8Jlyj8FSSNrcB79sE5UEph58iHxRRJGzvGgB8Mvpx/XeGUt7FFF4GJhPZQR xG0OhsWO7VOD2Wodcm41sxiZqnY5XJKwXgC8qH68WsPzwYCPlriJnph6jMwMWbm2nE3B NXWLQu18+L46SR2hVT3GnO/MAx0gdkycn3Zv6GpeY18yN2/KkDB32sbIyeprGthwSGSy CVf/i8C5ab3OIZweg3xGXMIGgHVeVTOszg3lUKsc1+DvCN21p9AYbZTVbr4QdlB20vfc UFK1cN9+nzi3O1pB4BE87bjBA8zp6wAqhYITmQs+0HPBxlOPhan7hmSXy+i5is2uALrB a69w== X-Gm-Message-State: AOJu0YzP/kP7PI8ivm+EY/ClV4N5SZ3PUalZlOzsm1CWf1/r3GnSzJr5 B1yR4q1FzAJyRoxNHtndysiKp9jEnFZJfxOBe0f30wj6MhV9GbZstA6pZ/StfC+64zojoW5NWSy FY11qxoBi1rJHOIxnjf78vLIWenY54vEaF1AYOs9Y5t1PiLFS1yS6rlwxDauX88Dvzw== X-Gm-Gg: AfdE7cnzOULNoq2gvCY6m5Om+Z6wLYDle2hLlgHTksUPP45Yd1u9TpXD9+C7j9GwVe4 nocfzy1m1ZVHVWFlF9wa0JdH1SW6heywHZzA/nI4YPtt5sIaqca3e8rF5oVW7RwrNip4VqGj/0L Wmvyt/6g4KB6M+4gFH1TcdY/lhfjoWFNt+EvggepHul0xVpD1bZ7CP8j9RzXEbsS2BuNBlKtPZU pz4hX6q5facuprSaPoo1D5GdcoY+fubd494bPGrdWAdmdZzzRNOCKqGV+4CR1CVthUvguYIoulI iisUu+EKoKErc7byLaaeJaRhJt1HXeHoXUMCshM/PnSy6cQrpiQC2Uraje7uEWAby2G+6xwjmVi IXA50YofVMYWuwfS3Rl7cy9lX4Xe86QYQA7zvhE1Xz6eWAsqnpH5BWoOsmw== X-Received: by 2002:a05:6122:e183:b0:5bd:ac45:5b04 with SMTP id 71dfb90a1353d-5be9085f27fmr299530e0c.9.1783345587950; Mon, 06 Jul 2026 06:46:27 -0700 (PDT) X-Received: by 2002:a05:6122:e183:b0:5bd:ac45:5b04 with SMTP id 71dfb90a1353d-5be9085f27fmr299511e0c.9.1783345587493; Mon, 06 Jul 2026 06:46:27 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 06/32] accel/mshv: Fix pointer to proc feature bitfield Date: Mon, 6 Jul 2026 15:45:01 +0200 Message-ID: <20260706134527.84808-7-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706134527.84808-1-philmd@oss.qualcomm.com> References: <20260706134527.84808-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE0MCBTYWx0ZWRfX8UWlJkIZUcl4 oZNEuPLZSdOfk1py17rOSGerbL4oR2oZyrNrjC4Yaxnq3JT99KqPLWK5Dl7zJivuZU7Xxi2PlSe CCUkaeGCSjuFHqYe9xAozlooJtTsD38hvYyDbozNf8UAjS3FTFaPHYbWBv8eBg0a69OkXDpKW6Z yf6CLfopiJL+zYSCTtOuXR1AMFXJtLCfLgmNaoVu7MmA1f2F19u84gdk7jKB++p0JT4FvHg+b0t 6NLh1Kkvn+8wASfPI+EyT5P1gzO5S15QAoJEqfmZovJgimH6xOdmq04c41ZYLtO+gtfAKDcaCUY GaIzArrcVN6/eTf9o3Nhvutv8m+f1ysXdOJsCQi46uAPfrL1hbKmU3qDtIEfY66C/Iu7BRhjnnf 09Bwl+VlqyhTx85wDJGW1zaHzqk3Pa1uJUXPGVahpXQqSQ2+H1/Uc2QertCUrgVKRP///ayUFYT 1m+qmlYgWL7/Os0Xm1g== X-Proofpoint-ORIG-GUID: 7XrRev4UXDUZ3m5nFDLkAv-G82aleLrG X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE0MCBTYWx0ZWRfX/HvJPgOw0+px 5Cov+ZgP84N5Mh9rH36Dmr0XeI19uXk+slMarUGGekz9wwlAshpvHMXYdjOoU19WAyRZR6ui0PA uWAAD2V/sZrue4E7BdWRPFJwHeUH+wU= X-Proofpoint-GUID: 7XrRev4UXDUZ3m5nFDLkAv-G82aleLrG X-Authority-Analysis: v=2.4 cv=f9N4wuyM c=1 sm=1 tr=0 ts=6a4bb1b4 cx=c_pps a=1Os3MKEOqt8YzSjcPV0cFA==:117 a=PLEY+c9/kVlxBKEpvFYBUQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=yMhMjlubAAAA:8 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=E3Kq4i6MJonbbSQa9EIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=hhpmQAJR8DioWGSBphRh:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 impostorscore=0 bulkscore=0 suspectscore=0 clxscore=1015 spamscore=0 phishscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060140 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783345659353158500 From: Magnus Kulke Processor features are stored in a union containing two "banks": union hv_partition_processor_features { uint64_t as_uint[2]; struct { uint64_t sse3_support:1; ... } } get_proc_features() to retrieve the 2nd bank was passing a pointer that steps over the whole union (+16B) instead of picking the 2nd bank _in_ the union. This manifests in mismatching feature bits for the 2nd bank and possibly other side-effects caused by writing beyond the union. We need to step over the first bank (+8B) by using as_uint64[0/1] to correct this behaviour. Resolves: Coverity CID 1660876 Fixes: 2f6da91e8a ("accel/mshv: store partition proc features") Signed-off-by: Magnus Kulke Reviewed-by: Doru Bl=C3=A2nzeanu Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Peter Maydell Message-ID: <20260701130335.418156-1-magnuskulke@linux.microsoft.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- accel/mshv/mshv-all.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/accel/mshv/mshv-all.c b/accel/mshv/mshv-all.c index 1959baf6672..72721d0f0de 100644 --- a/accel/mshv/mshv-all.c +++ b/accel/mshv/mshv-all.c @@ -167,7 +167,7 @@ static int get_proc_features(int vm_fd, =20 ret =3D get_partition_property(vm_fd, HV_PARTITION_PROPERTY_PROCESSOR_FEATURES0, - features[0].as_uint64); + &features->as_uint64[0]); if (ret < 0) { error_report("Failed to get processor features bank 0"); return -1; @@ -175,7 +175,7 @@ static int get_proc_features(int vm_fd, =20 ret =3D get_partition_property(vm_fd, HV_PARTITION_PROPERTY_PROCESSOR_FEATURES1, - features[1].as_uint64); + &features->as_uint64[1]); if (ret < 0) { error_report("Failed to get processor features bank 1"); return -1; --=20 2.53.0 From nobody Sun Jul 26 11:01:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783345658; cv=none; d=zohomail.com; s=zohoarc; b=jLHe4FcdpBgb7Z0BPB7h90XKFhx9xlV0VTzb5MxLixWY8JnfVtisfS+UVDUvclzdFc6MscHxCgFIDk0HkFAiZPFH+60tZqhwIrPha+LtNayJqcdjj4ZTLH18TP/RMA6R4KNsQsZ1jw4FdCAvEhYCscnB/0QZwa2anlrqzQ14/48= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783345658; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=wg2IMCq5o4M/IqZkqQnUukZyM3Q8liJmRPUOO+zAvSs=; b=abMjl9tUnrTdIbQFPJqW9uOZGOUK8emAoX5ilKveaIEe+NsI5WaNpPadgoiONR5R1ieS9jiwpIMioIKsRd0Qj9sxCDWpQ839c5fb+6i04uUpr2O7XvzHKMObV11JUoe9wN5mDC4gpJwi+cjYxN/WHL3Cv4qF3bYplZr9mb+uRNo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783345658969828.4880345662627; Mon, 6 Jul 2026 06:47:38 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgjfY-0007Oi-Sb; Mon, 06 Jul 2026 09:47:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjen-0006jk-5W for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:46:46 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjei-0006MA-6h for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:46:42 -0400 Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666Ax90c391056 for ; Mon, 6 Jul 2026 13:46:39 GMT Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f89kgs18n-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 13:46:38 +0000 (GMT) Received: by mail-vk1-f197.google.com with SMTP id 71dfb90a1353d-5bbecd25037so403376e0c.0 for ; Mon, 06 Jul 2026 06:46:38 -0700 (PDT) Received: from localhost.localdomain (1.171.88.92.rev.sfr.net. [92.88.171.1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c636e9e9sm355798385e9.2.2026.07.06.06.46.35 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 06 Jul 2026 06:46:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wg2IMCq5o4M/IqZkqQnUukZyM3Q8liJmRPUOO+zAvSs=; b=BKDsceUdjGBzROu0 gGg3On6kSZdq9gH6R5Y19Vu6+tNTNDylnDpCBGPLa/ViouJ7w+e3TXdW4siePobf Xrua+8RLADaG9kVzKEWjI/a4gbq6SZj4NmXX7O9hdn2awoj3pZohjj+ZpLcN2wa2 J/FhaKdc/EMMXj1RdN/skbvDGDBHpR09tH7dZjsh9MYj+rddlPOFtFotm8nNWYqa hP/nVREecbDjlPWv3MOkp9tO0JxXVayIaKFBKYZ69hmp9L6gn7n9U0KnI2oiI7QW LuOdRQe+nfBTZ+Xis6MoNYMtO1l+9nphijZREc80ukJKVf58qwnlExCXtT0JI161 rRCoKQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783345598; x=1783950398; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=wg2IMCq5o4M/IqZkqQnUukZyM3Q8liJmRPUOO+zAvSs=; b=dI2tBdZC+A6x82idQegMfmimbjBpKkoBtNg8RTfNXGvhbsUkZywi6qsnSTG4srnvao JkqZc8HGJOeigrXOsYvm27B3OzcZ1Q/338jkDPw6YFZzPsp2SqF1Jx56JILsSjv0YAxi rbrYn+PNDsuz4neobszQ6m/N1WoYx9eLtLA26El8l6OSIjh1tDxCGaVlctCIdq5LsMqu JydmqX6lBw7rWqL1HfJeqfnt5jFAvRpRrt5nqV6kpSkQx0illZQg9xabTZnpRgxiB4+v aOFbEMG/UMghhvd0HGN4WlgA815tak4xqWCuo0BCUKMVfjm5N50X27bUnDcJaIr1mu4L PQMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783345598; x=1783950398; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=wg2IMCq5o4M/IqZkqQnUukZyM3Q8liJmRPUOO+zAvSs=; b=R1x7OyhOM5LlUceEO9+P6q/Ztcvz5wIVpod/0N3alfSWkO2QrKBc0a/dcDT0Rpf71n fnADIr8MvDms2ggzrqcvS+nSIAUuFouS+hjTwiRS1Qt1TdcBEeWfJWDkVRpr8Yjw6HfU FwXOLN0qHI1tO1YL2Q6DWdbbwrB2Ug40NB4sOn/l9lnE96aYANlJy7Wkd6ItvvMx+Se+ mQd8x9SQzLfr9RulZk7DXhQszwJL8062XyEPdGVUE8ruARwRWUFR/2eTmn+DcZ8Aoysf N3xydcXcv37ZDBSyGGFNfrn2JCAdBkci7YnBA6k69QrYRxeY0SCQzg5IIjuTHGD9FhT6 azMA== X-Gm-Message-State: AOJu0Yy8d5hf3WNlHC0S7OMjNL6jH8A8sPxzHRUcOi7xuS3wkhl56eI4 bblVP7zl5qPSlSP/FyYd3n6QTNqtXZKDBkXzvJOa+v0O258SVeHV3dKFVRY2G70+ktznx+ocbVF Ab7+rsJIdCCJ2DnW/g623U6w7JQ4herUE6RmHoefvpwnTAGaKvHzpPeNiKVPTgTrvRg== X-Gm-Gg: AfdE7clfTH8hIWooNDi7t1PSJK3hV2iw9o177SLqBx5puJmuZx74a4qnABQFk26TUj5 /jtdNZubbOcXtcmPkrWJ5p+WMsZ+/c/ayNeDvn8XZSc4DDh0CHhRzWvPIeZr7rpyGVnuXCqrEeb H3w3lA6KKImJYWDao8uNM3R0Mj3SCkct1yS3m7u+1X4snRQV37fcKSm3FiEm/uNVG2E7NrF75SZ Gfq7ZjTT2BoCHXYZymBHOJC7sbcZOPraVeEDPCJuEE9BqcpokfMD1kCun8eVcL9dVv1JpKJxJnw jbVNfjboTLU/X4DVkIB/wq0gCn332azPiJr7L6Mcy5SzVn2ggtHuLSY+rOjEUh0on8PHmaWoHTe gShteH1YbCYElthhdmknWxEJNCg8pbMxpMCzQ+IsoalhYcQlmf1kyshkQsQ== X-Received: by 2002:a05:6122:3a10:b0:5bd:9ea9:3de5 with SMTP id 71dfb90a1353d-5be907c16b7mr276846e0c.8.1783345597744; Mon, 06 Jul 2026 06:46:37 -0700 (PDT) X-Received: by 2002:a05:6122:3a10:b0:5bd:9ea9:3de5 with SMTP id 71dfb90a1353d-5be907c16b7mr276836e0c.8.1783345597274; Mon, 06 Jul 2026 06:46:37 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 07/32] gdbstub: Add trace event for STEP packet handler Date: Mon, 6 Jul 2026 15:45:02 +0200 Message-ID: <20260706134527.84808-8-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706134527.84808-1-philmd@oss.qualcomm.com> References: <20260706134527.84808-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: lWXeEy83OJMm-NGtXeNlxF2Fpl8dUQQH X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE0MCBTYWx0ZWRfX6OYI22zdMKZb cawwXEmmFfgsHRkk3OPYQqH69UOQYCLnmJgoOtOzSS8RziZg65oFmNPGpYnW6dGZSl/5/uyM12L w55LKW2lDGqSDKoMQAYarLO1qQVItqMv2jx8Gj5vFq2EkAvwSBi9QgbjqT3AFB0qBR0miHjUYwH GnsK8nVSgRLUlOFjq4hXcEUx26WGV8YKDFpf6G0ZSxlBRGpDM5UjSwuetkuzqSvpDwIlj1OHJ4K I22CVApusuBQOC9EL6GPu29iC7AcEbP9u6W/9zGoSqZtZfKC03QoagnDy8XJ+pbuDQcgST5QdEY D0j/NOcMA4S6SzRag8vHBTDJUtEzxI+o9p2rtqVHfUNp0kxeI+QTvr5r9lNa5Eck4/pXyLyuViI dPbvEG0fd1fbSdjJmI0ayCQDGKLQkl0le2v+eB49sGe0Ck/ZOSUv/qK/rj7YaQzc27yOT9azb2u RAPlUL9S7ldjV/lRkuA== X-Proofpoint-ORIG-GUID: lWXeEy83OJMm-NGtXeNlxF2Fpl8dUQQH X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE0MCBTYWx0ZWRfX/oSQ6/L+ZLgr rPUj3TdvNZ+ZiMizKiT/WIMYfhZlwMQ+NTn7Vp21EGPpSorXNKdkjN9g2No+r2GFsWjRqHKjeEC lfJ0fxD9x+60Q5j/qJtkNobVerVKI8A= X-Authority-Analysis: v=2.4 cv=c6Sbhx9l c=1 sm=1 tr=0 ts=6a4bb1be cx=c_pps a=JIY1xp/sjQ9K5JH4t62bdg==:117 a=PLEY+c9/kVlxBKEpvFYBUQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=nS8E-dRYisaDM6zJQEoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=tNoRWFLymzeba-QzToBc:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 clxscore=1015 adultscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060140 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783345659307158501 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Acked-by: Alex Benn=C3=A9e Message-ID: <20260705215729.62196-7-philmd@oss.qualcomm.com> --- gdbstub/gdbstub.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 26366acb674..246e7746300 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -1369,6 +1369,7 @@ static void handle_step(GArray *params, void *user_ct= x) gdb_set_cpu_pc(gdb_get_cmd_param(params, 0)->val_ull); } =20 + trace_gdbstub_op_stepping(gdbserver_state.c_cpu->cpu_index); cpu_single_step(gdbserver_state.c_cpu, gdbserver_state.sstep_flags); gdb_continue(); } --=20 2.53.0 From nobody Sun Jul 26 11:01:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783345658; cv=none; d=zohomail.com; s=zohoarc; b=brd+zA06nQBvC/diAMJQnDE8+mRpSDdtap3QGkpwGqMmlf+WahDZe8x9QBCVgJ1Z5XjQXefl0AfUnt1kXMzruQdyzQ9/CPnc2r6O9OXhVnu5JEFY5EA3cA5MCR+Ti6uRHXBvctuFItViEknhmc1imxSjCLx8mCtAqbL8hvteqvM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783345658; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=Ywcft/LQOg/AUbGKSvPPmBtK9CP8mXb/1dMcOlTHzQI=; b=FBs67zZzMAHRWeTybI7BrIiJgfKarA+rKFWuy1B+iMKqwEcpKIopl9Y4WOK2lg5l5DHacjueQMrO3jZHqw5BdKlvlSZSWmN+++mTd2yrciFbnmJVOkCr3Hca4+HndHK/mTOAOnJJzrDrYV14OX8znBNLEhUclj5p77Lpk+ePR+Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783345658421750.9894362890913; Mon, 6 Jul 2026 06:47:38 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgjfI-00078J-8n; Mon, 06 Jul 2026 09:47:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjeu-0006mn-TN for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:46:53 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjep-0006O5-RI for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:46:52 -0400 Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666AxGF0369006 for ; Mon, 6 Jul 2026 13:46:46 GMT Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f88h99c0p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 13:46:46 +0000 (GMT) Received: by mail-ua1-f71.google.com with SMTP id a1e0cc1a2514c-96939fcd33dso418955241.1 for ; Mon, 06 Jul 2026 06:46:46 -0700 (PDT) Received: from localhost.localdomain (1.171.88.92.rev.sfr.net. [92.88.171.1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47a9e3e2702sm25093965f8f.9.2026.07.06.06.46.44 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 06 Jul 2026 06:46:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Ywcft/LQOg/AUbGKSvPPmBtK9CP8mXb/1dMcOlTHzQI=; b=PMS9Sxn/zKGio/u6 rRg1OQF7DNnmpYbO3s9BfcSClmqJX5RqMwVlKEh3kfffrV2RfsSZRHvBsbShkxub CQVOwVDYX3clnw8ymwOR3nM2uOuc4pOxLyU6AfWI3G26fyVw4KSUKmsprvD49QZX 9ojSrDMtW0kx8R64Fw9S/VAxFmZU/8VrdhZpIWkQB45EbX4TylfHiid5uFwQAL7G eM2A61Eh61Ug8XVv46rII9FS3N1aag54IzQPwXvEKxq8HC2xAXZ0Cj51RCdTGdn0 wZQl/f+JAUN0Cynmhiv+V9WxX5aM738hu01Fu73sQEaJnWQ7DZFC1h3DgsSPdyWg moqhow== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783345606; x=1783950406; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Ywcft/LQOg/AUbGKSvPPmBtK9CP8mXb/1dMcOlTHzQI=; b=KQXcy+CqnzLh0JE1BjzopoDf8xfxBFcmFb23KXXneb21s5pMlGCBZQkErRjA7Lom2Z 3ujwGItnNCWnI50piAcoAm37VVO3Wh7C6Bc7eFtDtCcryum2EH5F4gDYd6x0/NCf6cph bRDTMoBi0iRBGVSiSWVMc0DMiZUbrxEVi/HPvcvKlV/4pr0WcnU6Wnu7nEdnJT5Ja72e f/YrKljYZIHYusarPyg4jh3W84pqYvpCdWTQjkBWO/oN8c8UWutt8yw2vGnPHb+7kuOo hs9KGLz1E9uv4LVNbr/E4eKV3SF30p3i2k8AY56Dv90AjIPRm/nk8IHAjRxpVv8MqJ27 jB/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783345606; x=1783950406; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Ywcft/LQOg/AUbGKSvPPmBtK9CP8mXb/1dMcOlTHzQI=; b=iSexsO5aWF1DNjzfntKDUWHMHoN6kPW7whyvFu7CJ+eKwwavvBcalicVzlGpe3u1sq u1fo9r380pKzJ93OG3OYJvwr/2O2t3yOsNWXn0/7vXluyl2sgr/AeMsXMow4h3m0KdgL ROA9Y/3RZfOmgjkP8rciU1KNn8qwu5AcsOyr/ox6znAh2u6n7py7Q7ou2RrY7Nk73iOk k7hxlfUWFnVsM/LGvpa/tavcczr7iRn3MsoaHtDcQb4TMF3cp9DXtbP1Yboj+WyrbZPu qeoy1dAgdtHkcgwtsgiJdv0v+33XE3gIUjMMwtcp/BD1pY38OJT/++NR3DC5nCmeKNZ7 WCpA== X-Gm-Message-State: AOJu0Yz/JQJrFaoFwm1Y12I0fCqvTCdpcet12LwApT/h2k/ZJYbSIWBr xDYhA7/FM907ty2EWVj5DjqeDPiGmUgNw0/BCBJidAdKsZCqWGTCPi3PpK0/n66Ac1tTE8M1rri CYtBfzoqxbh+Uz1x+t5oZGMwxTeFtfLSfEqAn/PbtsGP3b13IKxjP60qxNjaFz5Bh1Q== X-Gm-Gg: AfdE7cnQOmkQbfifGTHzdPmmDUIwyD03blTnJXhU9NBC7yN/BsogS7LRt+cHpVi9Dt7 uMnAkUstemOlZsGWNoI2DWPzyGzoEWLUtlXAxIgGsiUltuTNXhXTQxw1dPawTmoNnWJdAJlVyHT hBsBBHeoZ+5yf6fw4SfMZpeRzgKarfqq2OmBGv/ZLi77ZPN+nr34enGZLBaVcPV/AxNqmsF9k5h Mj+8bvRWXBkch9gIYCiVrfQsoA2Up3hFhTykH6uGPV8sCHokw5E3wr+SjysjPkapUlbksJ1rs20 uw5HJTvM7tLIz9ZqeFS0NlvZ4af9OpJJtQ2aiL0zx6d2dlWK6Mnsfby54nQEIfWf0CfnRG/r66F EmxUaKpUWDrQEaCW2KWw4zXVCDsjLlLGbnhhaQP8EquBzW2/jrsxdgcWtFg== X-Received: by 2002:a05:6122:e183:b0:5bd:ac45:5b04 with SMTP id 71dfb90a1353d-5be9085f27fmr300091e0c.9.1783345605737; Mon, 06 Jul 2026 06:46:45 -0700 (PDT) X-Received: by 2002:a05:6122:e183:b0:5bd:ac45:5b04 with SMTP id 71dfb90a1353d-5be9085f27fmr300072e0c.9.1783345605270; Mon, 06 Jul 2026 06:46:45 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 08/32] gdbstub: Only return E22 when reverse GDB is not supported Date: Mon, 6 Jul 2026 15:45:03 +0200 Message-ID: <20260706134527.84808-9-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706134527.84808-1-philmd@oss.qualcomm.com> References: <20260706134527.84808-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: DJfPT6Rk893u77nfgnOlbHx-TPeHSwfR X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE0MCBTYWx0ZWRfX5ZmNY/2OAi7l hamZM2k/i14Th2BqiQYmyK06oV0Gf33d3xT4I6DelWXTNeD5Pjbw2NliottHnBL2UYPG+CxW213 Q3ZNuBBjkfSD4VEUfY1kfR1yT4WhLlA= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE0MCBTYWx0ZWRfXxD1MqiKswrz2 naozMQqRqr9bcg2nLSEoCQ2KfJDjSZyTHXv+YPanjphjTuT76i8n9pYXHAL+SnsX+p2D2ukOAyO /vuFWXVWmEqZmLtgp3dCwsCDQ4BH36xn6ui3CEMBOvipjZYM/qc4kYGXPedWZBzvvE4sz3yl+ny DFYG1oJIqIclP7SN9YwHYPLi3dmr4GRKmjihOreqs6sZLp55EfFK4KqijA8DhzTGPYy7vkAm/2L zOnWJcaCpCch6lNNK2IKrNIJ7EMrzOSnbv4so0zOs/dcyeD6/K4jYKYXJIpJKKV/GdLM0X7neP1 fcE7xtKsBIN8NLXARrVJKL0qaLK2Xj21WYFVZaQhr1laW0CNslCdh14AwlI/4aPZRT7gVCzEiNp ZtVOKIgXBUX7/tWmkgxsytNMrYS+BPpIM9kD7pyhhO1SWZq2j0CioA1wF5BBg7UIwN83TDij8Uv 5ozAuX5ObVsBtUNVc4g== X-Proofpoint-GUID: DJfPT6Rk893u77nfgnOlbHx-TPeHSwfR X-Authority-Analysis: v=2.4 cv=GulyPE1C c=1 sm=1 tr=0 ts=6a4bb1c6 cx=c_pps a=KB4UBwrhAZV1kjiGHFQexw==:117 a=PLEY+c9/kVlxBKEpvFYBUQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=0n23ylXGgdPVI_k3iFEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=o1xkdb1NAhiiM49bd1HK:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 clxscore=1015 malwarescore=0 impostorscore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060140 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783345659318158500 No need to keep processing the arguments when we know reverse debugging is not available. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Alex Benn=C3=A9e Message-ID: <20260705215729.62196-8-philmd@oss.qualcomm.com> --- gdbstub/gdbstub.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 246e7746300..f54415a9db7 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -1378,6 +1378,7 @@ static void handle_backward(GArray *params, void *use= r_ctx) { if (!gdb_can_reverse()) { gdb_put_packet("E22"); + return; } if (params->len =3D=3D 1) { switch (gdb_get_cmd_param(params, 0)->opcode) { --=20 2.53.0 From nobody Sun Jul 26 11:01:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783345655; cv=none; d=zohomail.com; s=zohoarc; b=mWA5PVwpIYYuCq0E5WTSBlpXCZwsB7AxBIQnrZeo4FhTUFsmbalhrGpAhhHhJF+lPaI4e3samLb3Hg/x1vbYKSEwWCUhEt70KUYpKVxSg7fZW/BnyUnZroMQmUI49KCxuLIF3hqSHMPY7kdmC4QPZtw7WWbWSTQoS2RXdFhMLlk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783345655; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=+2Y6xs+e5q7Ac5D5TaolKIfbNfpiD9x7cxSRMpKjPIs=; b=BifWx/MMIWe1LHtPhnyHSK+oKOL4H3qyw/bRDtLf+2cvIfUJfQMqT8yJ/evifWUXdXNznHOSqIYNW4X4xBy/qPB+SiDWNhDIv4Zp2QGDTheU1xgmDPBXBeZvANdQZ+vWNIH6h1mBSxJNm2EHgdLimnDy5J8A6xgC+UKhu27+XUQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783345655215109.08740891206173; Mon, 6 Jul 2026 06:47:35 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgjfR-0007Cl-DZ; Mon, 06 Jul 2026 09:47:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjf2-0006xX-8n for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:47:03 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjf0-0006P2-Hq for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:46:59 -0400 Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666Ax7xc245538 for ; Mon, 6 Jul 2026 13:46:57 GMT Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f8a98gu95-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 13:46:57 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92e820609d9so223330785a.2 for ; Mon, 06 Jul 2026 06:46:56 -0700 (PDT) Received: from localhost.localdomain (1.171.88.92.rev.sfr.net. [92.88.171.1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493be4a343csm327560275e9.0.2026.07.06.06.46.53 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 06 Jul 2026 06:46:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +2Y6xs+e5q7Ac5D5TaolKIfbNfpiD9x7cxSRMpKjPIs=; b=Ty410otBa6acz1m1 l2c03wjdBA4gABAT57kUldioYMCG9iZyLTkU3uQTIIErXfSmvPywavHGJgt3+4CC +iVfr3e2+ut+EnWaNx9tPtSEXDkXpfqZK0yPmZQtm3uVxv2uzDMQYL5w2werLKqq 6A5fSAN3Nrk3+AXfkgcFCePs/K7/PE+RqrarctjaQCrs3i+aiFTuOZZVhF4bZsuB Tt2DzEcNfPtINfffzcIqPsoqBh7o39CICzJmgvUCtwIweyzptRBQ2km0DhXcIhH4 BWU1l8FbnHOpJuHG/vat/LxR1gh/wRfPGcgARbknT//noBnRkmgJSSOtC+KzAHZW +UOzqw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783345616; x=1783950416; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=+2Y6xs+e5q7Ac5D5TaolKIfbNfpiD9x7cxSRMpKjPIs=; b=D/LJwI1wUhNh/8hAifbODi4OsCTzSks2NP/1F4zBCXkF/sLsGj/PbeGCAl0f+L8A0S Hho6jZdOgVNUyXpq0RVjib1uSiPCIIsXyCkiPOidLUOBKUj60CmZx973zBjQeK9L4/Fg RZW8LKfYpBR5rS0hM4hJNA1A3GMq3kws6BmR/Rag55givw9uyJo98UOkUsLYD7kzmigM GtfauxsHEuyKPwJED4qSc7hdCEy3n+buvS4ANG17htyh6jAPQzS7QpnkRbPA//WZuYeV F6pbgBalQ2Bt9STQQxLSOQhAabfjQoSqVZS1MyUeS0c3wMQMH/fl8RT+KDoI1FEdpTyo JJAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783345616; x=1783950416; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=+2Y6xs+e5q7Ac5D5TaolKIfbNfpiD9x7cxSRMpKjPIs=; b=Bj4NFDIw0/EGoiPVzeqYY1sUwfNPE4MUVz0AeB7gK3X6nYG1NCXS+JGECvRnMVfj0e l11OewecgzF6GOVkO+xss+m46//aYbabJLIsOP4507arcWzj9kYBQGCdVzWKpCxhvt4M YxgQnGdFXHN1w2ndEFvYCuWJdOSAYKT9lqhQW4hv6YCZz+E6VPMnOltKFZUNSbNMNKz1 TPDxuwG6TZBxMsiDNs4sSJ1qddYxxbcFTV52Lgeg4Lc9YXwIXcUhBfbQuNLvadXYtkis iQgUZcnd3ZSJysyiOtRiJSi33MGtlml9TSlP7u6Q8Bei07/n6JtM5TSOiBEY0HoIfpO7 sk0A== X-Gm-Message-State: AOJu0YxVQyZo/5YfW35NlENBQiSXpYwqYQpTjqbuBthoLowYAy/3WsnG xrA+hNL6/7iRg99cxrJlZBHZZLn7Z9qK3k7SuI6p9Lq2ECVmJ6ScQ7HIzXCfi05byNZaXvH7kgd kotDZglw3EAAV04KixAEySgpgPXA1SH9NQGcYIXE2QcEcsu29ArT6uddzs2rUUI+q5w== X-Gm-Gg: AfdE7ckTKyzBmPwvY2xNAxMiEh/rpWNbI455vhaCgBy1W+w81yJ/uJ7JM8Tps6Zxxoy v2257iVD/M9qVFhsNCUcXX5EqVMEyEfrvGpc+tCguZpj3SKhh0NZNbSKHdHagoh3DBlb548/yyC kdlllNURMH6JoARgVqK1mGGb/y4j93WebHrnH24wrT6eUHdQ7qYW8VZiCV8OSoPeB5rOzRT1xeT kBXKbHjCOdCdZ6JPARXDbZZCKljpzoU9lxxSAM3bWyaXRBw9hvsqKPHdWCdT4C9tUXNYlT2Z8RU NKhAHnF/SGnMc8SKsrqteEgZdq6rKveRK5EYdWHEf8aG6lOPKnPaSHiYP2U6XBziAuLsoBkUyJd jZx8i4HK3yesPBPf9LMie7DUI3tTxDak49vdB4JCnIECMpD4EGN//30sK9Q== X-Received: by 2002:a05:620a:a80d:b0:92e:bbd0:3157 with SMTP id af79cd13be357-92ebbd033c7mr49210885a.66.1783345616024; Mon, 06 Jul 2026 06:46:56 -0700 (PDT) X-Received: by 2002:a05:620a:a80d:b0:92e:bbd0:3157 with SMTP id af79cd13be357-92ebbd033c7mr49206085a.66.1783345615400; Mon, 06 Jul 2026 06:46:55 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 09/32] accel/whpx: Implement missing AccelClass::gdbstub_supported_sstep_flags Date: Mon, 6 Jul 2026 15:45:04 +0200 Message-ID: <20260706134527.84808-10-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706134527.84808-1-philmd@oss.qualcomm.com> References: <20260706134527.84808-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=SpigLvO0 c=1 sm=1 tr=0 ts=6a4bb1d1 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=PLEY+c9/kVlxBKEpvFYBUQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=glojBnVPa3CR4aLdIrwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE0MCBTYWx0ZWRfX82FSr788E5qU Ba0q/D/NOp+YWzmYx3H3nZyhQF/Yaa+0b0KCsH/CwMDDzxysFv0RnH5pZsHMj0J8aQ0gThfr6vd yqXXVHDmtoFwhH3D87KTGuJ6gn9eZ4iPD3nwWX/GzY4se4Z7T6EgdhGcUbHD/hWsfajjl4yKZWY ol98099oS6V0dNuOopIVEcHDsOOy6K5vM3oxVX478FLQtJx6jAXL7MYQYvTo5WC7jdJoqwxZnAU C+q/MkKkxzto5whva3mu4ch2VH6u9UjQ1NpQebXBv7AAdPd4dC9nHUvvFrL5lB4IDvOBKd6VJa3 4NNzGLmGQP+8pLG6BiQ8aB2BcLL5/MbghGHTulK21SVx6NkWl15B3Ba9qBoD20m7pXmuQFfMxsb VsNtsYycqOHCGHR+bgFnrno0goknzk0LJDLIde9fTJm213aQ43UzTVKg5h6+MItIVCiieamkfu2 wqfD4joAYzuLxL7wZCA== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE0MCBTYWx0ZWRfXxOhWjn4jrfuw WperrJJ1fGfwtpS+w9II6asKGSyp+H3dR5JI/qowEAnT7wecpf09+FYo2sAqERZpH/KW1KAtrY4 KH9DqPHiaeZqnzGcHFJMvmASBEhmiGY= X-Proofpoint-GUID: E7KuPz5waCpKfioBXrjTwkNF1zvzz_8B X-Proofpoint-ORIG-GUID: E7KuPz5waCpKfioBXrjTwkNF1zvzz_8B X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 spamscore=0 clxscore=1015 phishscore=0 bulkscore=0 adultscore=0 suspectscore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060140 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783345657460158500 Correct gdbstub support requires some gdbstub_supported_sstep_flags. Apparently missed in commit d7482ffe975 ("whpx: Added support for breakpoints and stepping"), even with the recent 19b48084f71 ("whpx: i386: re-enable guest debug support") fixes. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson Message-ID: <20260705215729.62196-9-philmd@oss.qualcomm.com> --- include/system/whpx-all.h | 1 + accel/whpx/whpx-common.c | 1 + target/arm/whpx/whpx-all.c | 5 +++++ target/i386/whpx/whpx-all.c | 5 +++++ 4 files changed, 12 insertions(+) diff --git a/include/system/whpx-all.h b/include/system/whpx-all.h index 4022571ffff..0e2d333e919 100644 --- a/include/system/whpx-all.h +++ b/include/system/whpx-all.h @@ -23,6 +23,7 @@ void whpx_arch_destroy_vcpu(CPUState *cpu); void whpx_arch_accel_class_init(ObjectClass *oc); =20 /* called by whpx-accel-ops */ +int whpx_arch_gdbstub_sstep_flags(AccelState *as); bool whpx_arch_supports_guest_debug(void); =20 #endif diff --git a/accel/whpx/whpx-common.c b/accel/whpx/whpx-common.c index 247e12db812..e3f93efc61f 100644 --- a/accel/whpx/whpx-common.c +++ b/accel/whpx/whpx-common.c @@ -527,6 +527,7 @@ static void whpx_accel_class_init(ObjectClass *oc, cons= t void *data) ac->init_machine =3D whpx_accel_init; ac->pre_resume_vm =3D whpx_pre_resume_vm; ac->allowed =3D &whpx_allowed; + ac->gdbstub_supported_sstep_flags =3D whpx_arch_gdbstub_sstep_flags; =20 object_class_property_add(oc, "kernel-irqchip", "on|off|split", NULL, whpx_set_kernel_irqchip, diff --git a/target/arm/whpx/whpx-all.c b/target/arm/whpx/whpx-all.c index 3079c6293c8..5208d7e1dfe 100644 --- a/target/arm/whpx/whpx-all.c +++ b/target/arm/whpx/whpx-all.c @@ -295,6 +295,11 @@ void whpx_translate_cpu_breakpoints( /* Breakpoints aren=E2=80=99t supported on this platform */ } =20 +int whpx_arch_gdbstub_sstep_flags(AccelState *as) +{ + return 0; +} + bool whpx_arch_supports_guest_debug(void)=20 { return false; diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index e626acef2f0..f6e1636a4e0 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -1853,6 +1853,11 @@ void whpx_apply_breakpoints( } } =20 +int whpx_arch_gdbstub_sstep_flags(AccelState *as) +{ + return SSTEP_ENABLE; +} + bool whpx_arch_supports_guest_debug(void)=20 { return true; --=20 2.53.0 From nobody Sun Jul 26 11:01:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783345687; cv=none; d=zohomail.com; s=zohoarc; b=D8JPJeJqw5q9ivi2i8kIwTKa4xMnj5gy05K4BmBzGn1QNgh+UWW48FV5LW2d+6xADHlW3z9vGqpx0oqPhPjJWTMXUwB8N1fSbiGWrJ9TFTZhbe9mfDHYWhVpX7525YQK0r3Z5Mrm09j5mpPw84qvQmF+VBkkWWhSMWe1E97yOyg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783345687; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=6c7Bta3Iey9lpxW/WU4lYojkkssrvRUhxkbTpmvSrxM=; b=E8c/LZDODFBd0PY/4ElQdUtEtOBVQBFRk8N1ymgJX39tuMPDnBdtJK/gGfQI8V9FGXgGAwHvgnVwUeiRm6ufysPh9untURf8ErxR6RlPAnYsMfF0sHY5UeQgKjS0gqlx8ccLGQ5lTHBuY5kaanMY/+5FZWxc0eAkVvY68V1PnnE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783345687419850.4896696171674; Mon, 6 Jul 2026 06:48:07 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgjfa-0007T0-Vi; Mon, 06 Jul 2026 09:47:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjf9-00076J-VK for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:47:09 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjf8-0006RK-CL for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:47:07 -0400 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666AxTom387522 for ; Mon, 6 Jul 2026 13:47:05 GMT Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f8a3r0w1g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 13:47:05 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-92e55721a8cso312336285a.1 for ; Mon, 06 Jul 2026 06:47:05 -0700 (PDT) Received: from localhost.localdomain (1.171.88.92.rev.sfr.net. [92.88.171.1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c63bfba1sm425339425e9.15.2026.07.06.06.47.02 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 06 Jul 2026 06:47:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6c7Bta3Iey9lpxW/WU4lYojkkssrvRUhxkbTpmvSrxM=; b=emW5DI0hhsUMUX6B AwoS/E7WCUM7QiisaejRtoqUzeGwNDbuwy2iPOg+Io39pByAvq/zwnDX+2NC6pPh YQKA7xZUfb9G9/y+drZsQH4++InbTnokrumjsfpSV1/m/aWlcqzZs9wtMxLT1Lvc 4E4m31jfgvxaKl7aZPljrjdEAlxHombV2/o9YNdXvce4yMSaYvTSvCKWcK0mL71E Rgg9EhyQf8hjJdPPWX2U+D5mDhXPXYfeVLNTfSW0Vf8Wfnjszz40+1MWFcsG6xdO XOtlyGze5z/nzpW35+bAr8c1gffjLTPjAwO3713JhZnQVu7fFprOo09Qkuas4Tuo dkZFXA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783345625; x=1783950425; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=6c7Bta3Iey9lpxW/WU4lYojkkssrvRUhxkbTpmvSrxM=; b=YF3mJvypfS1bfzOjfBZumQ9Nnt9oQVsakdJcjw+FYPEOVZhaGGHMeOIZpxOQGOTHul +dbbqAmtdrZ4crVI9B4d9+7JOHKAl8qBrUfbU3vyzWo0+PRqsNoJ+ocja1nDYbp079pQ PdIT05EriqswEwzvA2CBg3Wg7Wf7G0YgRYi5CvYUnLK17vTqh+Zl268/s72kbjl+lTwT 80clN+ZXKCQ6kCvrJ7ZgjurSiaaHANQAfkWWI72LBK3s++LijICfuaGKr/UvyrTmUSXx f9efJmmROLsqrImKgyn+jKVnneuPzhSDfPsr+iOPxJwvljLI9BfffdENs/r4KtmV1MW4 gUyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783345625; x=1783950425; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=6c7Bta3Iey9lpxW/WU4lYojkkssrvRUhxkbTpmvSrxM=; b=foVaj/VLcRxbdeWF5tpCL1SosmVavz/82Zuq2wqEJnxz3tK02r6TBUblZup8XBAmX7 fv+rTfzQTQpFqdEJmcfwPchXmZNUSM6NKL+xCrXHb0VfT3evP8ND+D99jQSKcLGZ/S3v +UpZvVsmRqLq8BekAyQW3TvcrZeklqITekO9Y4ry/YaQnGIJ9DZgPaST99175x+hoI57 A6rgllzloYDMO+4VDdlvaJj6NDO/oiEHZquTYVGv+UMcj39njnnItZlvyHCCzaqn23K9 PEc3QWK2kyHU2O/vucsdC1kcAxcZL4sVhIHMwryRtrz/1uLqBaH95or9vHVQwuRncmEB JXOg== X-Gm-Message-State: AOJu0YxFEZmpv6mTgY4rrwVSy0E8eldUQ0V6yVJlR4cmrv3uYlnt2o57 aqYCtsv6cw97YoZlYjSNd2r3fuzejsPQve27AqDs8IO4LsRdjCBL4PhG7pU9RcYLbj2JOdjJnwJ Pewzi827lw8ajNHSTPXNvOdq6JcoxRI4i2JhEH97AwU7iupBbY//sEU4g/T+exkm7KA== X-Gm-Gg: AfdE7ckFn9n4VtSj22b69qTBasyhmVAHjbAZvDnxqIc2lvPtGsNAg2kI/WoICTuglLK sIF/W4viCn/Sjwy+1kC5TOonXElQorlh764uwroeIXD6H38U9ryLXjuyLfiYdJOEpF2+FqjF7Sj 4c68l1sTiDmw+I/F9Vrtu8PQ4GUk0NAgyIlkkL8NpdMuYt3Khmxmu+QMoyaojbljGWLDc+UZ8C0 GDMXIcSGDBbxTpUDCRe98kuiiq6Zh9bDDvY1/w0km2U25oduALB2IjnFomtuvuOKggb/1+oO3XS 4yoS8UhcW0yGIq+S9ZalbQvyB2Yn3QjFBy1Hl2Nlp3sPr/p1Z4h4vlKDbm3/jx1UaIowxS7HuOB 5OJSHxffL7dqrfyxcDrsmxp3auwSzSULzUbuBgY1VpWRCuDN5zIEPxf1aCg== X-Received: by 2002:a05:620a:28d3:b0:915:75ba:1797 with SMTP id af79cd13be357-92ebb50ee23mr86724085a.29.1783345624699; Mon, 06 Jul 2026 06:47:04 -0700 (PDT) X-Received: by 2002:a05:620a:28d3:b0:915:75ba:1797 with SMTP id af79cd13be357-92ebb50ee23mr86716985a.29.1783345624066; Mon, 06 Jul 2026 06:47:04 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 10/32] accel/kvm: Always define AccelOpsClass::supports_guest_debug Date: Mon, 6 Jul 2026 15:45:05 +0200 Message-ID: <20260706134527.84808-11-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706134527.84808-1-philmd@oss.qualcomm.com> References: <20260706134527.84808-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE0MCBTYWx0ZWRfXwWKU3uTHHXRs q1mBKsISda0+OC6GJW6NahNcmzAUc3Rxl/sh7JwHZZJ3A5gNSrQ6BcIVhfbsPtpPrDwyioginaE t8yVVOvPa3G5J0QQfTV6/lh0/f8V2n6uCtdXlLJby6FRtpiWGIVkPEngHgoaY5gi0jEgDYaFtE6 hUBqKhaNe56dNYI1MIFrUSmMcS4EzhtfHWPnTa8wop380nf9VPCCQzR4c8v5abDsuO58NqvBgYo 2Ywl0ukPO2TmiN9rg0Iw1tKpdTE/oS/7DIQqALhntE3AS0N3whS+xiRysXPqLtQYSvJc0v1sxdW 0qzOiGZoUxe6cSbmInKCn1JjiNmwRWLivZHdcYNBnsVbsCkHyFIdlXm9pXCIKYCXzHeEb7mlW7S AAzjsw0TOS7cby9ORSAVI+E457zN3OnTxesPXATSglhLYeMXhfFbCHgt9WVbqfRVvZcrVyju7d0 HHaEgLQEajv2U1GgJ5A== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE0MCBTYWx0ZWRfX0dSH2QGVR0JB 9QweE1oHHodWHHik4fhfDty7LblLa3MAmL81XkpgWraEh9Bgi0dHu2PchV5wP0pCIXzlHLafl6n rgqi3xgKude/Eoq2gZjZB/Zchk/7KFk= X-Proofpoint-GUID: nnsd17f3PdgD7wKDML8F8M7tQ3nLwOYT X-Proofpoint-ORIG-GUID: nnsd17f3PdgD7wKDML8F8M7tQ3nLwOYT X-Authority-Analysis: v=2.4 cv=OKcXGyaB c=1 sm=1 tr=0 ts=6a4bb1d9 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=PLEY+c9/kVlxBKEpvFYBUQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=j4hjfWolugK9Oy_fDxEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 malwarescore=0 clxscore=1015 suspectscore=0 spamscore=0 phishscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060140 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783345689510158500 Whether TARGET_KVM_HAVE_GUEST_DEBUG is defined or not, kvm_supports_guest_debug() still exists and can be called. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson Message-ID: <20260705215729.62196-10-philmd@oss.qualcomm.com> --- accel/kvm/kvm-accel-ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/kvm/kvm-accel-ops.c b/accel/kvm/kvm-accel-ops.c index 6d9140e549f..d7967bc922f 100644 --- a/accel/kvm/kvm-accel-ops.c +++ b/accel/kvm/kvm-accel-ops.c @@ -105,9 +105,9 @@ static void kvm_accel_ops_class_init(ObjectClass *oc, c= onst void *data) ops->synchronize_pre_loadvm =3D kvm_cpu_synchronize_pre_loadvm; ops->handle_interrupt =3D generic_handle_interrupt; =20 + ops->supports_guest_debug =3D kvm_supports_guest_debug; #ifdef TARGET_KVM_HAVE_GUEST_DEBUG ops->update_guest_debug =3D kvm_update_guest_debug_ops; - ops->supports_guest_debug =3D kvm_supports_guest_debug; ops->insert_breakpoint =3D kvm_insert_breakpoint; ops->remove_breakpoint =3D kvm_remove_breakpoint; ops->remove_all_breakpoints =3D kvm_remove_all_breakpoints; --=20 2.53.0 From nobody Sun Jul 26 11:01:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783345673; cv=none; d=zohomail.com; s=zohoarc; b=S8sEi4W7q9cW19aOANZiTOwE6cs0LeA3PEK5Lz5ZnaTE3C/oNg9rBwdNFeU9KMtdK4ufa3cgj8sOJzcRjT0rocLug0rTWWdtbpwwxBthkveQu60eCAEh37T2eg6+/JYLDh4pIqyQ/VmqAqiHLyeW4WOMt3YtmbeUC3Ufb7dxOmE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783345673; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=MbjzyS2vyKB7M5fl/op/EmZHIEWbw2ST+XTV9X+k+G4=; b=Pb8kbrMXrAZSw4ilAqFwsNh/YGHVa+XEfIKYExTJUh8SwGS13Jq42Kpuo4Y/uScP/JnTrKC+1gNlgIRGjLzyrhVMWjc8Ss0IlnYOVQzVZNPQF6SASIPkCDeh0RB+MfO/drIucEWsqmU44U0xJ1CHuKBzpTxkV9VTZB6a3EjrnfQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17833456730471012.7861568497626; Mon, 6 Jul 2026 06:47:53 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgjfd-0007x6-FD; Mon, 06 Jul 2026 09:47:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjfK-0007DL-8J for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:47:21 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjfH-0006Xk-7u for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:47:16 -0400 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666B03Ov389752 for ; Mon, 6 Jul 2026 13:47:14 GMT Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f8a3r0w2p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 13:47:14 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-92d1cae5939so303596085a.0 for ; Mon, 06 Jul 2026 06:47:14 -0700 (PDT) Received: from localhost.localdomain (1.171.88.92.rev.sfr.net. [92.88.171.1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa039bcdasm25670118f8f.21.2026.07.06.06.47.11 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 06 Jul 2026 06:47:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MbjzyS2vyKB7M5fl/op/EmZHIEWbw2ST+XTV9X+k+G4=; b=I9YUk+MepRExRo4l /XggrhaC5hBrVLbBAne4RyFmf4ruS+9jC9BS0X4nx6vWydbYfC+cOvK+EeXvrjOT lwEj+yGPfzXurqtuCTFFQHrFJJUi1GyqBCQRS1gjANnmb2T1cvk6taS55VRhJUKR pVQEBfjPxwwWb8tf/lMvcB0N7jOlaf/KmCbeiFVBG2ic7daWidmTx1S70hiAaBFa R5GfK+7+ajGy63ZJuwm7NV5THm4oSViGddHOSxQRTE5ellyyct4qBZ2sxBjDhD3V z4LYPMn36ECyJccYUkeO3VnQrndiX17ZV62TqwnwLRTbfVidLhXYk27EIBdlf92O QDKHgA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783345634; x=1783950434; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=MbjzyS2vyKB7M5fl/op/EmZHIEWbw2ST+XTV9X+k+G4=; b=iZpV3tnw/g9co+MAmbSBLF/WTVMd9w75yovmJeFSFNcUA0+gvl1om1ULhDrjgAvzzE ssCF8EgJv5YkOFyioug6CDFNWuZ8Bj2tK3KV2BqwSkBNfXHogKi0rPn0NJD2qwz4TCAC 5AH3SmuuqJAn6BypE3RMtDVvx7PNU6aT0HOFzwsit9QYRx53q6kZs6/B9V85XaQxIu9Z dDZ4I/6Pw9f3HQZY0uXi/pP5hox0k3iT/sVJqCjTbv7OSvfboTMjXglhQN/Xg34qmfvu axk36uTGBL9A8fDjX68BGMY1ah862bmfoAKwF0e+Q4a2MulwRTD1K1fiwP4IvPTJG8bc 98mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783345634; x=1783950434; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=MbjzyS2vyKB7M5fl/op/EmZHIEWbw2ST+XTV9X+k+G4=; b=fipWnBPgtVWteJN7boDmpnN4DwY9ZQzqC1QcZ0/6ajDoedXuRD6SW69QvuIw8gnFOA 6fZvIq24zPkrqXOWex1NRqDFXOIq9YG8Ap+wFloBbztrH0OCPpeq3FVmdmoUY+Qkl3u0 WkdL1VeAI1bcxtVEh3yrjr9l5jnTPdPBCqGYyCK5onawWyhKoSkLS7Q3R5kVNxVS+fbO 77TgKNx1if7OdReBehhDcs/vBMraYo5Z4C06PMriic7+DmN0LTGmh/2f7jn/wFlnDhXu Q+8ifPwui0K92Up3neq5LW2vIqFdLzK8/jpefiLZNSdNZBJ7iH43WotnQVlbXY6JcTtN DbXw== X-Gm-Message-State: AOJu0Yy2QbpbiEiRxdbjt/kYwULvUcT1aG4BbkSxkKaw76sUz0jr5CuY qhDqECvJCnVeLB4YygAzfFFCOPdDp57PvBT5G0ZL/g/X13hiYEWLzNQIKD/M5+XjUhQje+MJn3d KsYAk3u+7KQBw0l5cKfpEhsizAODICyo5ejeqmSc8hwvikMV1fAbI47RizstkYn1ToA== X-Gm-Gg: AfdE7ckpuuqU6M72ZVYVIxm190EebrvXwp5TxSGjKeBDTokY1y1xO+Fp0rbinFDF7BV /xsTOp1KYh32tLYdipvi2eRMrH5n03RhQ6mtbv5Yeyn9R34Lk7B9mdl43yK+e8yR4OvWEJ0YMCE G2c8+tCpWkbj49Io9z+Pxx9UHHD+UeZ6wugPEywz8ss7NBuS8jp2AeOAWEoLLSLOV/x40bQNMRZ gW0z84GxwU26RJSQNRVOTrvkztEQSE9PZLgAh9FZ2nbIYa8yizXR8dDZACmBjH3TKWQ02VOGjcG kaSWgc5NkNDxW4xW0lagdnAvLZJATL6jS4HM9U9fLols3lvTN0nLscPRGeb6TOvK/Fd4Zz5GNIp Mgt/byvfPcGw3Y87fMnOzCw7V+weKfNA0kX1+ZjxEAGWKTcWaURu6KuRNsQ== X-Received: by 2002:a05:620a:4103:b0:92b:5408:b6be with SMTP id af79cd13be357-92ebb4fa30cmr81581285a.23.1783345633740; Mon, 06 Jul 2026 06:47:13 -0700 (PDT) X-Received: by 2002:a05:620a:4103:b0:92b:5408:b6be with SMTP id af79cd13be357-92ebb4fa30cmr81575885a.23.1783345633049; Mon, 06 Jul 2026 06:47:13 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 11/32] accel/kvm: Simplify kvm_init() w.r.t. TARGET_KVM_HAVE_GUEST_DEBUG Date: Mon, 6 Jul 2026 15:45:06 +0200 Message-ID: <20260706134527.84808-12-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706134527.84808-1-philmd@oss.qualcomm.com> References: <20260706134527.84808-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE0MCBTYWx0ZWRfX4oSWKvM984mx wyPyNiMiefpKcwYhqxgXF11mDIvIX35EL2wkMQyqoZ1q0u8QXZlEcP+aSsjJjZ9MYTwgHbkvLgp x/5KA03cZKbfGiYQp4++Td6gVfw4/veAF29Y6ePYG5vXfA1R4QtCDQYoN6G6MRo9tlDoHLOAe6v 8qdlywZ+f1IP6hMkbPJGpROP+VHuyXkfQjJ1ErrStGxJcCfUeOwYEtr/d0o7NKQmnKDMsWe8kg7 R0uO02vZmbiLx4vEIIzNK7gLPmNTZvrC1Ii7sLdWL3X/zKwqaK/Xh07/Iugeecw3qQkK9iF1+h8 nzb9jUSgoBjCjTNJ/TqyF6JO4/mLFCSvGrdQtVs5/gG1S2gP2ey2PKuQuE+GJhixEJUNfjyzvMK nj1whVhJwHLniBM9Z2riX65PHjJ/WUmOkh9Nx49QCeZZRICvYeMGgnkDkmVc0Oo/wPzYGUD1tzZ iOZDb4Ppg7JIeB1Qoqw== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE0MCBTYWx0ZWRfX2Oao2YXJGBxt 26W7THoNFD3c1XIy4kEH05M2VtFLGIvuYsMgwrShnEsJ+DnmOyuwXgVRWcVcEd/GmPyfCVjT/Lj 7O874BldOduH6LF0bhtEtQQUQepH6hE= X-Proofpoint-GUID: 9CwNiTUx3wfP-xJzBPIHgK2X5HSAWRTn X-Proofpoint-ORIG-GUID: 9CwNiTUx3wfP-xJzBPIHgK2X5HSAWRTn X-Authority-Analysis: v=2.4 cv=OKcXGyaB c=1 sm=1 tr=0 ts=6a4bb1e2 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=PLEY+c9/kVlxBKEpvFYBUQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=snbnvTbt-5-dSQZ-83gA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 malwarescore=0 clxscore=1015 suspectscore=0 spamscore=0 phishscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060140 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783345673380158500 Simplify #ifdef'ry using TARGET_KVM_HAVE_GUEST_DEBUG in kvm_init(). No need to zero-initialize kvm_sstep_flags again. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-ID: <20260705215729.62196-11-philmd@oss.qualcomm.com> --- accel/kvm/kvm-all.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 5d55cb45cf7..304467704ee 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -3040,21 +3040,18 @@ static int kvm_init(AccelState *as, MachineState *m= s) #ifdef TARGET_KVM_HAVE_GUEST_DEBUG kvm_has_guest_debug =3D (kvm_check_extension(s, KVM_CAP_SET_GUEST_DEBUG) > 0); -#endif =20 - kvm_sstep_flags =3D 0; if (kvm_has_guest_debug) { kvm_sstep_flags =3D SSTEP_ENABLE; =20 -#if defined TARGET_KVM_HAVE_GUEST_DEBUG int guest_debug_flags =3D kvm_check_extension(s, KVM_CAP_SET_GUEST_DEBUG2); =20 if (guest_debug_flags & KVM_GUESTDBG_BLOCKIRQ) { kvm_sstep_flags |=3D SSTEP_NOIRQ; } -#endif } +#endif =20 kvm_state =3D s; =20 --=20 2.53.0 From nobody Sun Jul 26 11:01:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783345674; cv=none; d=zohomail.com; s=zohoarc; b=lmO37PxykkQ1b7QdPWkzydMBIdaOLhl4ex3s7V5EEWRtskz2tAtvnKVGcwFZhhUi05kbA4VyweIE8XOqrUvk+ygBoQNR+YB7amUhivuWtbpcXYqGy4lyM4JCp/1RfCjs2j6XlULUEkSI5KQq2p75fIyYgrMdj0MnApd8CbWrC+o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783345674; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=mkt8zo5ut3AEpdB800hQyITq4DLwrZk2lzRGpXglHSI=; b=Jq8SFIyjA6dsm3kF/mhgR1QyR5oKJgJAr35yS3vDN2yLRKI2hP/plbUPNaweLgVgbkgXS3CJaKATBvLil78No7Ps1Pa0PhJqEaj78bUGdDGw0HtlZcKEC0FuiKR83wN8d/QOfWmHyN++aRCe9pz0VGUgBAvx8T5Q+v5s4bCWvXg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783345674917656.9501841456045; Mon, 6 Jul 2026 06:47:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgjfg-0008IN-PO; Mon, 06 Jul 2026 09:47:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjfU-0007Jj-86 for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:47:29 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjfS-0006dY-N3 for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:47:28 -0400 Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666AxAVQ391078 for ; Mon, 6 Jul 2026 13:47:25 GMT Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f89kgs1c9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 13:47:25 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-8ea75996387so63980646d6.1 for ; Mon, 06 Jul 2026 06:47:25 -0700 (PDT) Received: from localhost.localdomain (1.171.88.92.rev.sfr.net. [92.88.171.1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493cce03fa1sm275898175e9.11.2026.07.06.06.47.21 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 06 Jul 2026 06:47:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mkt8zo5ut3AEpdB800hQyITq4DLwrZk2lzRGpXglHSI=; b=cu7ozZSlzR59qMkM /VoUuno170HRf2YQBAgQ04Wb73oOVAZ6PRTi+PbAhjKotPq2Qj10feeFaqcHRVyV TFM5Le4eTOKDeSeor4Xv4qwF7XIpsxNj8n88rEzchkWPdAsYgfJ+aN72SVJE4dsc oZjYkVue0QV+UHJf63RYh/2zHCsiSvzffSNoODklTtzeY3QpkL+VldJXvIwVi5Zs bYNCeTbOH0tSITJ0IWwb6fI0UUdK7+DE+9OYcWN9xJcOR17wAGjB1aUnVc1/iq+4 oQnJMdbfxv54fUz81k0GluTgPPVv11rs2MgzIUpxmwfOkzOH3qWW7URaRu2wvnDf kzh1xg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783345644; x=1783950444; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=mkt8zo5ut3AEpdB800hQyITq4DLwrZk2lzRGpXglHSI=; b=jHtp6lFmm3q/Tq4ULgB/hQOGHIkosGlFEYm/tpJUk77GwMiOBXZjizl3BS47zWvjSD wseNueMZ7OAzvux44lhCnLYWXne5RwYMMw4yH8VehrTrCTOtD5TUO6dGTbYks3BiNy6D ZSOO0S/kayUXNaoF/lpKquFYW0HsBskrkD3wWn6QsQiJBETFE/bqfEsgKJw1o3q5AGl5 W4MIthpjhziLzl7taIIHUV3vlICxdgCBzg8xlFGA7r1NGBSBpZ0AaYgexQmq7xiwRZ8M i3utScZ4RlMkLzckobDaydru5PUTKXtn6pJyxJzu472SVJGQAeiuT0l3XtB6XyaJENk2 J5lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783345644; x=1783950444; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=mkt8zo5ut3AEpdB800hQyITq4DLwrZk2lzRGpXglHSI=; b=UvjLD6+lAiSRk1pq2bOfYd88RDaEcyAyJbq49Lt8Lu8gFN0xTXn4Ub5faU6j6dK9W+ xPXyYRfIAeYhlNeY+g/wanQ7is38R/3Om0CozHRBY3UoccngDU7l4+tY3Jnlam41Ikox J9avSXQz402oW45RcBjk5OHPw/MoUF2PxcBFnCMla6eZGNIfKOlM+PDkFYfhfPxUWgli n5BVPcXOQYDoB/+23QKmaQ0a3DkrLMM/qt0D329gctM3OcB/9iitLXCnOMDAeBkiJ9iT 3W2avw3AWzD8RhchU41pNNIwqEvP8DmzL+3V1ozNW43+U3IjJP4ZjEpwGvr9srZOfKqO jmnQ== X-Gm-Message-State: AOJu0YwmU4/tJQ+Nn3YLhOpA+ZordF1yHp8qcr2RjWdG55uAEbFua/Hd FTMmRsWwmi8opuhJdMRz5ZnN2x/GaXo8AvRDkc0K2JD8PCoWK04g50QGHJFcaZWyRgOLuI+/cTv seRrS/9xMW4H6J5dERBDl5DWv1C+o3HHd3S8Vnfq2SlY2Wz9MMXx0fwE95QWiBdbrgA== X-Gm-Gg: AfdE7cklp98gfKoSoNQW1IQ/zIfBrpdDYx6nCig8qZ0G7Yt9ikNYRPYoZfElPVW7ujD tlaKwJrgvZtgBsvI4JaFcvU4o4Z6b1xdW5AHCBUQCF1XCjMjMlHsYjAFxF9st1xwg3LZ2QJO3Rv IKhsjso+MHkuGyvPmGNgmS7ZlPadpIvcwsAoQK1c8CPeu5DIU46U0uy1HGy9UVEAVF5RAEJNX5n +WvAzmPPDE9xv3yfIWwcfXVfDMFMEQCVJsuLbywqCWbpQKA73Psw1eOhRpL0idBuu8fHrr7RnB4 Lx0SdmLz7RlmHLyncAFj8vVDs29jY240Oho4M1tmauPLiFEXbhOJbT1IwcAntWvirF+G6zbqYm8 STEqawLcQGnQn5gI24zlJBTOUgY+2LbSesiCLb4rnY0HfSh4kZvOo5n4qsg== X-Received: by 2002:a05:620a:4014:b0:92e:7afc:93ed with SMTP id af79cd13be357-92ebb5c7efamr83737485a.71.1783345643923; Mon, 06 Jul 2026 06:47:23 -0700 (PDT) X-Received: by 2002:a05:620a:4014:b0:92e:7afc:93ed with SMTP id af79cd13be357-92ebb5c7efamr83733085a.71.1783345643340; Mon, 06 Jul 2026 06:47:23 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 12/32] accel/kvm: Hold have_guest_debug in KVMState Date: Mon, 6 Jul 2026 15:45:07 +0200 Message-ID: <20260706134527.84808-13-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706134527.84808-1-philmd@oss.qualcomm.com> References: <20260706134527.84808-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: y9iRh26xwzl_EACl-WtrprmB7SutnuNO X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE0MCBTYWx0ZWRfXx2X4qskXs4GI eKo1bGDuRkrabGOzjFrTdNOU7lL9Vt0pmFbZJk1DV9vS7ux4FbmZhckfsZUi5XP9cM/4wOe7YZE /KhmFUqB1cL35Xv9x+gCnAso5a735q9yUzxDfdEyBZo+ImoC8q4F1Ng1WhTqxQF+3CHUEl7K1pi eQZ/pxJt3FkOHqErbFevgTrlk9GMamf+3JWUFZ/dLoGHFjN804AO+mjOWJ8OjQQNaByMzeoU7Tx rRC4mm0Zz0EClUaIS8MLH0yQxbuk9qGKTEHjO+kMO+Z73M6AYp6gIR8QR6YAOwhz7qmRoAw3Pje diZu8gDpb7B/sJC1IX0Gp/gCAny83XmovOTRHREB3rfy30Iim0RiYrD3TYsHrtFAhU9L2onbRM9 0x7/0slihtRyfgrvD8zptnSGjoCIBVpB6eLsBu9DzNg5rPfWhAX/suGbn2rxf36dRBRCSWqQeif SF2E3fLm+E2hLqgUgKg== X-Proofpoint-ORIG-GUID: y9iRh26xwzl_EACl-WtrprmB7SutnuNO X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE0MCBTYWx0ZWRfX+fz2G6oEvttx drZIOStelh0JxAcfXRWlm/PTQ0uA9W6OOfMu42YYkTmQEoJ9QYzs9ObyvxFl2vP1GUtmHfnSY1c qFDsIp1pbfqNCBzLZ5q5JfwtBeAWdaM= X-Authority-Analysis: v=2.4 cv=c6Sbhx9l c=1 sm=1 tr=0 ts=6a4bb1ed cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=PLEY+c9/kVlxBKEpvFYBUQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=O5kNlQXW-qQlE3Y8R88A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 clxscore=1015 adultscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060140 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783345675419158500 Prefer to store per-accelerator variables in the per-accelerator state, rather than as static variables. This is a good practice to allow concurrent accelerators in the future. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson Message-ID: <20260705215729.62196-12-philmd@oss.qualcomm.com> --- include/system/kvm_int.h | 1 + accel/kvm/kvm-all.c | 9 +++++---- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/include/system/kvm_int.h b/include/system/kvm_int.h index 0876aac938d..53bb0fcf180 100644 --- a/include/system/kvm_int.h +++ b/include/system/kvm_int.h @@ -118,6 +118,7 @@ struct KVMState #endif int max_nested_state_len; int kvm_shadow_mem; + bool have_guest_debug; bool kernel_irqchip_allowed; bool kernel_irqchip_required; OnOffAuto kernel_irqchip_split; diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 304467704ee..b6125125f82 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -104,7 +104,6 @@ bool kvm_readonly_mem_allowed; bool kvm_vm_attributes_allowed; bool kvm_msi_use_devid; bool kvm_pre_fault_memory_supported; -static bool kvm_has_guest_debug; static int kvm_sstep_flags; static bool kvm_immediate_exit; static uint64_t kvm_supported_memory_attributes; @@ -3038,10 +3037,10 @@ static int kvm_init(AccelState *as, MachineState *m= s) (kvm_check_extension(s, KVM_CAP_VM_ATTRIBUTES) > 0); =20 #ifdef TARGET_KVM_HAVE_GUEST_DEBUG - kvm_has_guest_debug =3D + s->have_guest_debug =3D (kvm_check_extension(s, KVM_CAP_SET_GUEST_DEBUG) > 0); =20 - if (kvm_has_guest_debug) { + if (s->have_guest_debug) { kvm_sstep_flags =3D SSTEP_ENABLE; =20 int guest_debug_flags =3D @@ -3833,8 +3832,10 @@ int kvm_update_guest_debug(CPUState *cpu, unsigned l= ong reinject_trap) =20 bool kvm_supports_guest_debug(void) { + KVMState *s =3D KVM_STATE(as); + /* probed during kvm_init() */ - return kvm_has_guest_debug; + return s->have_guest_debug; } =20 int kvm_insert_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len) --=20 2.53.0 From nobody Sun Jul 26 11:01:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783345666; cv=none; d=zohomail.com; s=zohoarc; b=Qq93gf3SPkIlmldign3r9/PNF2w8AjVgGu8npfwSnq9BZEr4gGQmbsQTqN1oMOYzQkBiVtZXCZfEvCACFSjSUFow20VVk3sKTORDWNi11TTsZdECL/lCCL6+fzkNl6y3CTx+VyQ9hSaP85rH5a3G8hFDIy9MkHL5zzrLakjEfjE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783345666; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=NdBTd+WvzQi4nySk/yevAlv5usvJ/B8ISNHXKWOfYPM=; b=eGSqnOq0xB27NEl8E640Rtf9wCoo/0XhY513ssxx1pLzSkvPcSTcMbxCJKfBCK6yX+yvjCCz5j3P0/78C69T86cPYdhcLy1f1wzu0/kdE7o6TW9Jhd29MV+sUijFRtCYqViQrS4y2T7/YckFRpSMgeEzuAyZ4t8pvU+faUJRQ0k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783345666350391.3174571420474; Mon, 6 Jul 2026 06:47:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgjfj-0008Ut-3A; Mon, 06 Jul 2026 09:47:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjfe-00086h-CP for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:47:38 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjfc-0006eo-Mq for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:47:38 -0400 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666AxE2j395314 for ; Mon, 6 Jul 2026 13:47:35 GMT Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f89qph0e6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 13:47:35 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8e9489f62bfso4608706d6.2 for ; Mon, 06 Jul 2026 06:47:35 -0700 (PDT) Received: from localhost.localdomain (1.171.88.92.rev.sfr.net. [92.88.171.1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c6381e4fsm429530315e9.8.2026.07.06.06.47.30 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 06 Jul 2026 06:47:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= NdBTd+WvzQi4nySk/yevAlv5usvJ/B8ISNHXKWOfYPM=; b=P/gScUS+knzi/J9H 7ZNI93INetx6ruJhBo7xRYhWAayd/0UedqmUr9ILH60m5GZevKkDJfFW7qsklG2X ab/+7Tqv5tk+pW+DxIfRgym7SopGZwFXX+mrp6OyM6nvHOvlYz1lOLVWmi8LE83w ZK/RkUeCQWgfKUVZqarv5bkFOYhlMz0itvOlwWrJGEfWVermYAFd8SWlMSRCL1Iz pCK+CCdksiBW6gSc1Lxf5Avj8Y4vZncvQOxoLtqDbip6yO8Yk3GTXoGlNngI4+4j teYf8g2pIKGeAQezhEYApzsiCXl/XAOUnWJbbqNDYpWrCJv7n3a3jVJ/kiDx0Tfi dR5/FA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783345655; x=1783950455; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=NdBTd+WvzQi4nySk/yevAlv5usvJ/B8ISNHXKWOfYPM=; b=InM+da75WTQSx62EYVQmUoSVdVllp1luF/21h92hGMt8aG6P+DuwwDpVp/oREbDjUZ g7ut56IUMhQqjZYx+K4H7CTzFXuVIq9tmp6Oryimbhn4tzctAmNtwJvaVA++ESWRDgob cDDxCeY7ht5Srde+PtFFcAPSwmb6aaUBFfg60zsQne43wEDvDRsa+D3M6IiNreF3Ip3e xEfPfTV0klKgX+PMcWF96LNRSOjrWXlkOg+FnjKw4kDxEYy9fM6GKG/sVn3GyM9ADuBH 2qZHdlUBN1U0c8CwArMYnwmfHbR2qLTGVegkYnBwx7HN0alNJV5Jzav035dUVaT5QHeG JxHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783345655; x=1783950455; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=NdBTd+WvzQi4nySk/yevAlv5usvJ/B8ISNHXKWOfYPM=; b=T0nYF6SP+a+rqyNiXYWF7aBo+9hNkessqalwPJWE56NG3RcXQagEqF93aUBzEwdCLz 0x1GwmeRoL/q/g+UMyo7aaTxLcgkuZg2BqvefQG2yGFjpXJoBDY3fzKZnby7NODZdZkH U+PwpIVjt05egE8F3mg/Lfvsym2x+vTxuVOqwvOoYpj1VBOYerBxrQMtiYDCyypSjaf6 gBedm+1cGQ663cw74ICrAmiAf6zxCoeAzALDNK7iP4BTQK6rfbZYGflxeze9nRsWZMZW 6j+Ay2idNzTLbinQ/d0JJKYJQzuOamzzFL0a0SQ3xriRZZJWzjFkpuxzyx531yOjqMvF ui/g== X-Gm-Message-State: AOJu0YxYzvE0C7Abd4EkB3jWK6tvVcI3wPXUOhsbI3UE5vm/vgmZ8wuc g83kMRATY0IPCeyRzLDbtmAX1M9SeWmTXy2SFYZ6Lh6NADl2g5RHYIIcvUf7e3OWSn+lhIJbWjU qcZWaP8Dtw6uDpQrxIuTcolP4BDyo0Etqp23nOcl+G/tf0jcFO74e/wfasxc32byvag== X-Gm-Gg: AfdE7cmhQz0prdyA534wf77otlBIaJONk9wSkBu31ME7jOIpMiT9CXSw9bQIovo1eKS m6YFVt5foGrQ70cgj7DrWRJ5SBzYPwMMFjOt91zTLvIPJtEfnkYKd1ksNGAeMwQ9rumV7XBbch3 id/RFRtp5i5n7jlrVYHFGv+lA2IPDmKF26uc7IbRixYOeYmuFPTNG9gkpKOiv20cyN0QCL724nP L7iMYD+CZFQManCE/dft5U4cQAN1PBf2tl1gufIniBa+X0QXMY9m3y1+EBM0g3plM9bRRiKSw/m TJciy9hdv1D5vXBL6g6iJWNYC0EZVBTdFUy1HxErDQhwJ74LdjElsHPXSzPwxPkT8hLu/osEx+v RzZw8/4R1Cl87h4D+xKsQncoHFXXoipg2RLEYBFCBleeKT2ZzVLBBEOrWeg== X-Received: by 2002:a05:620a:28cf:b0:92e:5d76:743b with SMTP id af79cd13be357-92ebb600d64mr78100485a.56.1783345653867; Mon, 06 Jul 2026 06:47:33 -0700 (PDT) X-Received: by 2002:a05:620a:28cf:b0:92e:5d76:743b with SMTP id af79cd13be357-92ebb600d64mr78090385a.56.1783345652673; Mon, 06 Jul 2026 06:47:32 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 13/32] gdbstub: Reduce gdb_supports_guest_debug() scope Date: Mon, 6 Jul 2026 15:45:08 +0200 Message-ID: <20260706134527.84808-14-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706134527.84808-1-philmd@oss.qualcomm.com> References: <20260706134527.84808-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=c6qbhx9l c=1 sm=1 tr=0 ts=6a4bb1f7 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=PLEY+c9/kVlxBKEpvFYBUQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=EGoLRYcDdwmvoyRlCl8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: QoBGI0VmVBzkr_lumUFHsBUHClr-dg2K X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE0MCBTYWx0ZWRfX1KusOvbhbMhf MPiuqbah0xBNfZcTppKVID+alMBO3a+3EgSqzj0RzPJD3v0so/dJEx34yn6JNOAoQjn7xULOIzW CbL35qomSSmIE9/DBugbX8E5+PKEGwMd+aYZX0lneSjrpv95OYa3vSNoKXCjJwVnz6jinugeTAF C3ovFhI+P4BqS9Ug/VrcQ87lJYe7Nl4VOV1oibI96lxmOYGb7OPNJMMm84++JkcctUXUoZOLIOZ FBpNYzIBuPmGe1MerDdLi8llHsbdqlw4LqQI8pVojmVju9FAVdrB2y07Iv/mrEAp7ijgtatlEP4 Hx3Dsdx38GWsSASmL5/qxVbsWXYbV5ecyyCmtS6w6DjWL3frXxla3yQ+gKtO4r6papXO2cn4XPN ibVCyMRfieGeMFpz17MIgfyKsAu8WggQkUc/kDCsM9jWGkpfok1FWDuHlWvGWtqENcd4UMP+XnF lv+1LvXNBtPqwpWUxow== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE0MCBTYWx0ZWRfX7sYACjfn14Uy muUum4U5Ev+hsVrIlX6YYJIy3B/mQ0bu+QAxY7YpDIalsbEqkQOyx1eAkgBMfmZmFU++p4Z4YDe dRM4tqG1EmApOKoxH1MHpw6ZgWKhX5w= X-Proofpoint-GUID: QoBGI0VmVBzkr_lumUFHsBUHClr-dg2K X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 impostorscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 clxscore=1015 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060140 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783345667417158500 gdb_supports_guest_debug() is only required for system emulation, reduce its scope by making it private; remove the user emulation variant. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20260705215729.62196-13-philmd@oss.qualcomm.com> --- gdbstub/internals.h | 1 - gdbstub/system.c | 4 +++- gdbstub/user.c | 6 ------ 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/gdbstub/internals.h b/gdbstub/internals.h index 9b25bf58b8e..60ddc146661 100644 --- a/gdbstub/internals.h +++ b/gdbstub/internals.h @@ -217,7 +217,6 @@ void gdb_syscall_handling(const char *syscall_packet); * Break/Watch point support - there is an implementation for system * and user mode. */ -bool gdb_supports_guest_debug(void); int gdb_breakpoint_insert(CPUState *cs, int type, vaddr addr, vaddr len); int gdb_breakpoint_remove(CPUState *cs, int type, vaddr addr, vaddr len); void gdb_breakpoint_remove_all(CPUState *cs); diff --git a/gdbstub/system.c b/gdbstub/system.c index 2063b63b2f8..1179c82cb86 100644 --- a/gdbstub/system.c +++ b/gdbstub/system.c @@ -331,6 +331,8 @@ static void create_processes(GDBState *s) gdb_create_default_process(s); } =20 +static bool gdb_supports_guest_debug(void); + bool gdbserver_start(const char *device, Error **errp) { Chardev *chr =3D NULL; @@ -627,7 +629,7 @@ int gdb_signal_to_target(int sig) * Break/Watch point helpers */ =20 -bool gdb_supports_guest_debug(void) +static bool gdb_supports_guest_debug(void) { const AccelOpsClass *ops =3D cpus_get_accel(); if (ops->supports_guest_debug) { diff --git a/gdbstub/user.c b/gdbstub/user.c index 97eb13e796a..f7bc4e63dfd 100644 --- a/gdbstub/user.c +++ b/gdbstub/user.c @@ -796,12 +796,6 @@ bool gdb_can_reverse(void) * Break/Watch point helpers */ =20 -bool gdb_supports_guest_debug(void) -{ - /* user-mode =3D=3D TCG =3D=3D supported */ - return true; -} - int gdb_breakpoint_insert(CPUState *cs, int type, vaddr addr, vaddr len) { CPUState *cpu; --=20 2.53.0 From nobody Sun Jul 26 11:01:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783345697; cv=none; d=zohomail.com; s=zohoarc; b=KAnNNjD3vvcMKC8+glfrAEp/FqbfIYseXmwJfYyQnOeTai1hfdDbB2JGWilOjZBDdRMZXA/RluASUwAPA4dlAauEgD1G/MgnXi32pVPhEDUV4hwk/yylZv9yWJ0oEPdlZumDlZPs97TPXdhReI5KBCFyeEXG5MkHHPOOb7um1oc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783345697; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=MvoQnDtozHt73wE+jbszXo6UD42kabePeJj9Cd77CHA=; b=cd1jIDWyywki1KNX9aQbjr1R+8Q6lAyJbw/esOqAKLcgj/ZQ9swN0jh3G5BLw71wSrXzQpGdu+btZWejBKLfUO0FLobdsVBzg9+62xdpdI0ae/vVB1MaNVtEOeGahaSfDNg289xggcsgr0Q3dMULR1L8i+ML8Y8Uuxn689fTeBE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783345697653723.0707506068931; Mon, 6 Jul 2026 06:48:17 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgjg6-0000gU-OJ; Mon, 06 Jul 2026 09:48:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjfn-0000PE-G5 for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:47:49 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjfl-0006fW-N5 for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:47:47 -0400 Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666Ax8Qd391051 for ; Mon, 6 Jul 2026 13:47:43 GMT Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f89kgs1ds-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 13:47:43 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e68cb7a3eso564790585a.2 for ; Mon, 06 Jul 2026 06:47:43 -0700 (PDT) Received: from localhost.localdomain (1.171.88.92.rev.sfr.net. [92.88.171.1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c6381e4fsm429542855e9.8.2026.07.06.06.47.40 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 06 Jul 2026 06:47:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MvoQnDtozHt73wE+jbszXo6UD42kabePeJj9Cd77CHA=; b=KUFL9ARDSle9mYox S9lQlt34hA/AY5pHYTDFkA7noH1bBMysUAWj8CZ9nczmTmL+zhIu2VFj5kFIhg4V FbHWA3k1jHqnh1MwrhFL6Ll3fy9u/lrfX4QXtiBoJ2Ba/6UuPDMZEinpQ8TXplD9 WLEwdPaZB7HirAzLjGe/bUQbbnnPRsHYWz6YRC2vhG5eK0T1nn4czNwq+WfqQT6c TmYACew5oKgfspnjG8E8OrFlND7/7NsUUVy8bTXFFtKuojhZmsoFK6lj6ZZq/IbK tTOjREDq/q8ISFeuuS/qVJch447/VrFCV26NJN3H13tqojY+3pFn5TO7GF7kkQjR JIi8ig== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783345662; x=1783950462; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MvoQnDtozHt73wE+jbszXo6UD42kabePeJj9Cd77CHA=; b=DRKh5+Mp1nJ6JgcQ6avE/IyP4igigcCjfzgcVVwkh4bcvfM8R7Zh5YkwaghhPgaYu7 p727bboSbx+rWI+lZUe+OMOLyze6Zl5j0a/BkS5i5I99DE7P8USPj8Pv4NnjRmMMEIhJ 4pDfg/oRwms73aCA1roZA/5eB8KE5phvT/dAmzzH17jEqIukNPmvFxPuO/Clo7qSeztm EW8K3I8lGU77te8JIc4IOI7DREeV2D+38B+2+tC1wm78bUrgAOncTe8tuF9Fz4SDc7be tZ8gOUdl0VTNwTuQYmwgKSbC37e7RgdJCne7y9y+b56fKEJtUkv7T05jSe+u5xgcSv/A 0XgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783345662; x=1783950462; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=MvoQnDtozHt73wE+jbszXo6UD42kabePeJj9Cd77CHA=; b=Hq9E2ogfHgqkRLQqjb7Y6bjeRjH5q1Qg0Av67H+CtbLOKHFH6kiVJtOFQq+2F2wpC4 ADf/0fdxF7SaC68VEhFWgd/Il4qUUj8UGUZnhkUg2B8SjDn9vD6fLxIS3UecLErFzMdq ZyxIQr9h4X1wNuwZFOoUfsY6LOIDiG47yWEofcP6BdY6pHsdxK6EC+lZ/S9naOlv/GCe cNQgRGCdLesj/z1r8QVXuVoZNi+hgmvZHhYry7aa5Dd4SYnRol+3EhkWide3sceHr3ZO niKVhyoXEnjSCC4Eoml9BmAYZxNHtTMRUAqdATK4xvksSds83DtB88zfR6sVFVIdFcx+ JKpA== X-Gm-Message-State: AOJu0Yw0Taxxq+QuO4bH/8P5nLw1AzB6pMv9I20EPethCegSQ6x2TsoU 8UcmQQOTxo68uqhRhzPuU0dqGTwq51dYn5Yn6G/rIiqBe+h/eGYyx4Lah4sFFDDmlimDWzrCvZv VkE3yukOsjW7JvFmf6Q0G7USHmEoAX0ucAJqpyAyTB2gjynaSX69bMqq6LWM8SPu3aw== X-Gm-Gg: AfdE7clB8oilHcigdfBtdSVqs55DvD7brdWql5AwFXAYkaPDQCbsS1BR5A+VVoQPaHS l1DqArhSu94FDE/zGxIEY5trb5xVwSHPppA4kyQL42D/bIh6TiUF/Oa1IxDgf8GqMz5Ij+1MiJC mSmKvZaeJWDSgZdBrAeLH43hXnz5NSZu9RizONGUfAOHhX8l8b14wNKh/1LR/uotwu4KGniH8B8 HHwFgmg4E+sqeiRsP127V1zR1M3gj+hBnLfcyEEm82cSKkZkerguhx2AoXP6iEhm6b/rnlo80UJ FTXtRZMo1EzkKpZXrtKSgUu5ZWiwWrRax7A7GMkbrrDUQszoKG8r+kxSimv6wO6shyy3V2xgCAH DW7llvcG52/bRT8QOhoBd7NnkziYyBOIVdwC85CWGyJX9k2Yz6p+kEpaRrw== X-Received: by 2002:a05:620a:4694:b0:923:5e7:1664 with SMTP id af79cd13be357-92ebb557e2bmr84906285a.45.1783345662231; Mon, 06 Jul 2026 06:47:42 -0700 (PDT) X-Received: by 2002:a05:620a:4694:b0:923:5e7:1664 with SMTP id af79cd13be357-92ebb557e2bmr84900785a.45.1783345661593; Mon, 06 Jul 2026 06:47:41 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 14/32] gdbstub: Move supported_sstep_flags in AccelGdbConfig structure Date: Mon, 6 Jul 2026 15:45:09 +0200 Message-ID: <20260706134527.84808-15-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706134527.84808-1-philmd@oss.qualcomm.com> References: <20260706134527.84808-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: OwiT_ZnMO41N8aJ4bHlw949XLEkRUXek X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE0MCBTYWx0ZWRfXzNe6PI1inihu 6yBwT3WVt8W/FEm2qzmo/FiAPPXMp6EjVDAnsZuUZPFD3M/BQMzmCV/2bFM8tbq8IWYWygc/0Iy 58bBFJTwBUOj4OnJSJlrth94mg9rO5pWfLTb1cTQdyKanzxChRFIjQvTDU24Erh6uh0tCy0sGkq TB0Rxv+ABR85o1LVRuXOKP6Is0Je++uKZ8LuFKxB3K6OG+vqk8fdOrva+sIOVVoJ8DfpYOpOQkI Bc6kTy54JGTU42B09SpTr0x84C+WZQqcF13Cv5KkY3v0uE40jZq1MSS3FqtTiYyblprMP6Ylloo V8UcESpP5quPfIhT2uQw/G9wd3tUDUwsrFlT8UMsrJiKUswO2W1c8NJgqJAqdWzIP6yPvgDWeT1 B8J3J7bvKhNsYx8mhbq1evdeHMiK51vFbi/2O8/YpuNjpZhkUVQjC0oNLg58MNR40h30LavYYtW wyrU+GA9JFeo95AzYLg== X-Proofpoint-ORIG-GUID: OwiT_ZnMO41N8aJ4bHlw949XLEkRUXek X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE0MCBTYWx0ZWRfX3m5s7W6oKu+y YsL0aF3cBxW1E48ufvWxik73adenUF6ABiYx0C3d6Z4E3/NsRev4cvWhsZkYceJOI2Ag6jcnPM4 Gwxln+EDLby4f3fWO0Tm0Xu2Y2ytMm0= X-Authority-Analysis: v=2.4 cv=c6Sbhx9l c=1 sm=1 tr=0 ts=6a4bb1ff cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=PLEY+c9/kVlxBKEpvFYBUQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=-SUpAgEnhvh4vktFIKIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 clxscore=1015 adultscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060140 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783345699647158500 supported_sstep_flags are per-accelerators. Move them to a new AccelGdbConfig structure, still in GDBState. Suggested-by: Alex Benn=C3=A9e Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-ID: <20260705215729.62196-14-philmd@oss.qualcomm.com> --- gdbstub/internals.h | 3 ++- include/qemu/accel.h | 9 +++++++++ gdbstub/gdbstub.c | 10 +++++----- 3 files changed, 16 insertions(+), 6 deletions(-) diff --git a/gdbstub/internals.h b/gdbstub/internals.h index 60ddc146661..0444dee2246 100644 --- a/gdbstub/internals.h +++ b/gdbstub/internals.h @@ -9,6 +9,7 @@ #ifndef GDBSTUB_INTERNALS_H #define GDBSTUB_INTERNALS_H =20 +#include "qemu/accel.h" #include "exec/cpu-common.h" =20 /* @@ -83,8 +84,8 @@ typedef struct GDBState { int process_num; GString *str_buf; GByteArray *mem_buf; + AccelGdbConfig accel_config; int sstep_flags; - int supported_sstep_flags; /* * Whether we are allowed to send a stop reply packet at this moment. * Must be set off after sending the stop reply itself. diff --git a/include/qemu/accel.h b/include/qemu/accel.h index d3638c7bfda..052b4c59313 100644 --- a/include/qemu/accel.h +++ b/include/qemu/accel.h @@ -73,6 +73,15 @@ bool accel_cpu_common_realize(CPUState *cpu, Error **err= p); */ void accel_cpu_common_unrealize(CPUState *cpu); =20 +/** + * struct AccelGdbConfig - gdbstub configuration for an accelerator. + * + * @sstep_flags: Set SSTEP_* flags that accelerator supports for guest deb= ug. + */ +typedef struct AccelGdbConfig { + unsigned sstep_flags; +} AccelGdbConfig; + /** * accel_supported_gdbstub_sstep_flags: * diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index f54415a9db7..06b712562c5 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -72,9 +72,9 @@ void gdb_init_gdbserver_state(void) * By default try to use no IRQs and no timers while single * stepping so as to make single stepping like a typical ICE HW step. */ - gdbserver_state.supported_sstep_flags =3D accel_supported_gdbstub_sste= p_flags(); + gdbserver_state.accel_config.sstep_flags =3D accel_supported_gdbstub_s= step_flags(); gdbserver_state.sstep_flags =3D SSTEP_ENABLE | SSTEP_NOIRQ | SSTEP_NOT= IMER; - gdbserver_state.sstep_flags &=3D gdbserver_state.supported_sstep_flags; + gdbserver_state.sstep_flags &=3D gdbserver_state.accel_config.sstep_fl= ags; } =20 /* writes 2*len+1 bytes in buf */ @@ -1537,12 +1537,12 @@ static void handle_query_qemu_sstepbits(GArray *par= ams, void *user_ctx) { g_string_printf(gdbserver_state.str_buf, "ENABLE=3D%x", SSTEP_ENABLE); =20 - if (gdbserver_state.supported_sstep_flags & SSTEP_NOIRQ) { + if (gdbserver_state.accel_config.sstep_flags & SSTEP_NOIRQ) { g_string_append_printf(gdbserver_state.str_buf, ",NOIRQ=3D%x", SSTEP_NOIRQ); } =20 - if (gdbserver_state.supported_sstep_flags & SSTEP_NOTIMER) { + if (gdbserver_state.accel_config.sstep_flags & SSTEP_NOTIMER) { g_string_append_printf(gdbserver_state.str_buf, ",NOTIMER=3D%x", SSTEP_NOTIMER); } @@ -1560,7 +1560,7 @@ static void handle_set_qemu_sstep(GArray *params, voi= d *user_ctx) =20 new_sstep_flags =3D gdb_get_cmd_param(params, 0)->val_ul; =20 - if (new_sstep_flags & ~gdbserver_state.supported_sstep_flags) { + if (new_sstep_flags & ~gdbserver_state.accel_config.sstep_flags) { gdb_put_packet("E22"); return; } --=20 2.53.0 From nobody Sun Jul 26 11:01:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783345695; cv=none; d=zohomail.com; s=zohoarc; b=JsJZQuAIOgpCcE/OPYNPTiGNpeH74+uHLZ9rV8P17JKSQPs/silsV5Einy7QSq0COBdqEmco4lGQ/vsYXwbits02iZhcGXTX0myFzIcY14BTnhmWmfhEVNoJ4L1D5GO26GCPet1o5mCnCu2CyL6jynMj/ZFXFEkaNUd5thpFkek= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783345695; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=J6D4Yodpkn4OP2pzSX/8GBdziIU+/sc6tXgwv7yudBk=; b=ayVApl/Xp2VdapTDTCi5ziATuyucZWR8/AStF0681jkHZa8XuLk7rP/3+uwfs0+ror34HUOS7E5+/WzU0wI3hgXI+yUdikygfX7dYTLJGpf2cQZTgtpwV4LET7EwT0q5DjUqaVAJNdwTAw9OyNFQS6qQdGMURXHXUsWnxlX0BqM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783345695623659.2853933668843; Mon, 6 Jul 2026 06:48:15 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgjgA-00010j-8r; Mon, 06 Jul 2026 09:48:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjfv-0000ZP-Oe for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:48:00 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjft-0006kN-KE for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:47:55 -0400 Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666AxFpk368946 for ; Mon, 6 Jul 2026 13:47:52 GMT Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f88h99c6d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 13:47:52 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e55721a8cso312445985a.1 for ; Mon, 06 Jul 2026 06:47:52 -0700 (PDT) Received: from localhost.localdomain (1.171.88.92.rev.sfr.net. [92.88.171.1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa039bcdasm25674453f8f.21.2026.07.06.06.47.48 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 06 Jul 2026 06:47:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= J6D4Yodpkn4OP2pzSX/8GBdziIU+/sc6tXgwv7yudBk=; b=kGIkm7Ox1RgNQhUL EBOgTuD2jfD32gr6iMTBLea1TndUK3bAGqr+6aVlf0SO4+k/Q9jsnnnA+w9BCaY2 bMXi+l9SHI2e8yMjUB9uSAYVq+zr0VvogZt+Qxq5KtoZ7Qtu56/t6s16HCBkW4as nEeEwbpGMpuulDUHkfRewkI9xBEuOlhTt8AoB8Zi53Hoz1DvH/ANK1L2aYE6ojMs B9ABp9qUhhk7z7SBmiFqyJuo2T+q9kueFHMTdQmtaxsumgqpHsfQYdL7dLYzLN/D 4xE5wNhEywQ1JZzV5uUXc+Uv0pVfGBpTDhRsAFy34eh7yOV2NbP2yhvOz4AMRSvS hkAjTA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783345672; x=1783950472; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=J6D4Yodpkn4OP2pzSX/8GBdziIU+/sc6tXgwv7yudBk=; b=H9v5aQhPOia6Td3dxvX1zLXd0KYxQElb4TF+jBvgGBoQhDhTHpyhhWunJRxpatqbc7 Tvcl6mHLiTxWxuuiZZ2qrnWvM8MS115RGnXafiL31k2umkQXX7T/L/x1aTyzKB9wue0e xy4UCV9ir+zS5/saZfzr+N8bseGE2EWquo6tUz79lliAzKLD/tXGOCRtRIpY2nyAGbUY 1yHJjru86MZmlK0jWsBnkjP6+LT6McbFEUbKHKPvPm/bfTvJ2It+T/taPe2Ze6yMRIyk xCHjhaQUSBKYXJfLfmRqsIO6Rt4j3FrxqbNYTr7qMNeZr+8XH6Nn6b0PfahV2dwSv8j2 ep6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783345672; x=1783950472; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=J6D4Yodpkn4OP2pzSX/8GBdziIU+/sc6tXgwv7yudBk=; b=D5ex2U6D59QIN/ykS/iO+WXheCO5udUbcF80ydXtR+jZxPut8wm+bry/Vq90X1lqs1 EGfQMCotmz0HBNWx4sMeH11TV33XV6dHm4S3IbvcoAwfHuN5nUrM0cU2Vka6vhGkZ1FC +M4VTUhk7htjFXPf4Cx/MeX4DW0ivcq2vnnhqTpBmjcTuzj6/HJPETSNepg2wn376VO1 rGdHP4AyV9mUq96xZTA7t17gZFJ+qddz6iwn9wBBKfTE0jxTcDG5nX+WhZXHyqc5NWE1 ovz1bLCclfvQ8f6w+hpF1+4Q9pK5/jms0DJyWL0O3s2QdvBbFY6TJnnFybdIq8CawYXY AIMg== X-Gm-Message-State: AOJu0YwKPmxIutTikd7QKcC1AkfJkwg63v/racDdOaMroDiJM1zlW5pL DaW8vxVw8Mhskg0GRctU0oTFL5Dy4MbR31PiN7Z1AAPn2Plg9ZfqA3O47D1w0u1RIgbMgjd/m49 G00UUkkaFbzmoX5qyuQ7WEuafnzGjLEHg9bBOpcSLpX2mq2Ie9ENC0WECKj5GA587vA== X-Gm-Gg: AfdE7cnm9X/5uXt1kEU7i1KFqVDAsr8ij1SwCQyTSssO88fYQCgDgM/3tGexf4Xk6Ya UNSgzNbKcwEG2tZDpTPevFsNjFk+IbjSQ8s0Zo+9fmLCHl+3K/VMfUi1D93rET8SllHiXSnGDtd 9RVytfY+Oiz4MUO/7yKdeY0hThKn6OfmWLppDjpusswU4vTCIiMUmh1P6IFDVEz+f1nqQl7i6aO 8ZXu5AJiyfv9Tjrd+9YcV757dg0eO9SkYusQrZmuzUBBA6+96JJS/WVEM7sgDZkt5VUqxtpvs21 Trnr4opeQiuD1rnwGavGseBV82fz5QhTD9ptvR128j3WVziICezPkk5cYEv/Pkij0lZpY614ihD 0FCLxfdGRHrYj1ZgCKbx4tWLxdgehr8f/ADM7bKuC3doSmKzJlgJLkFJTHA== X-Received: by 2002:a05:620a:4408:b0:92a:e2a7:d55b with SMTP id af79cd13be357-92ebb56675amr89447185a.47.1783345671081; Mon, 06 Jul 2026 06:47:51 -0700 (PDT) X-Received: by 2002:a05:620a:4408:b0:92a:e2a7:d55b with SMTP id af79cd13be357-92ebb56675amr89441185a.47.1783345670267; Mon, 06 Jul 2026 06:47:50 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 15/32] accel: Have each implementation return their AccelGdbConfig Date: Mon, 6 Jul 2026 15:45:10 +0200 Message-ID: <20260706134527.84808-16-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706134527.84808-1-philmd@oss.qualcomm.com> References: <20260706134527.84808-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: cICZiUuQ94vv-Wof-6mpDNyB52aHkP6N X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE0MCBTYWx0ZWRfX2A7wHm7+qK6X MGfUQiTx4BxJ5rCz2PLYJlBX30T1/jK7pi4qbQ2UmGZzpvaxNzqZubF3i8RX7Z+4hn44IxKC+D1 PxGiB0XpQE4rpuT28iGgrvyvUtzihHk= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE0MCBTYWx0ZWRfX3HNT2cEkBPdy K3mTN1tJD73HkJDUAn1H+vpASLg04BVfOiotUXoGP+cS9a3sAXIZL0agP2CcN1DjK8pMa+BGpB1 l5jh278DNjO34x4bkI/5O1vPdTpV1heTipI1wj+nWvQvb5uNvQYfKC4wa5UmkwHxxha7h8BjBtK q9/NTeTDw2CsEVjW/dZLo4NUwgD+0vkOMKPcbE2exyb4PIiyPlJQ+2UTVY+8HhuPuRgBip9fZTd fWBH7UHg5yh1kAuhBEbSjgaB362noXtpSN0H0GzGsUdDuqptz4vuWbaL3ClQRXZKoZKlDcYPwQe 5yPxcc+NWvFZIAygZcPYkWN4w0kjkAHLOZbRYqLTaFM3ArlTGB/msAwXAXzIgRZID7resBelPbe WLDbOY/sOeU0pndOfD1JDhsBflf4ZFAkRRG9IlBTdLRwYHpIQ1QDEPc5aoudGq1VrQwG5mBThSV 2vrh2WXM7+WX4rPYGNQ== X-Proofpoint-GUID: cICZiUuQ94vv-Wof-6mpDNyB52aHkP6N X-Authority-Analysis: v=2.4 cv=GulyPE1C c=1 sm=1 tr=0 ts=6a4bb208 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=PLEY+c9/kVlxBKEpvFYBUQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=GIYXWNLsZHjPOkf-ILAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 clxscore=1015 malwarescore=0 impostorscore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060140 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783345697768158500 Hold the per-accelerator AccelGdbConfig in AccelState, set its single @sstep_flags field in AccelClass::init_machine handlers. Remove the AccelClass::gdbstub_supported_sstep_flags() getter and inline the single accel_supported_gdbstub_sstep_flags() call in gdb_init_gdbserver_state(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-ID: <20260705215729.62196-15-philmd@oss.qualcomm.com> --- include/accel/accel-ops.h | 5 ++--- include/qemu/accel.h | 8 -------- include/system/whpx-all.h | 1 - accel/accel-common.c | 10 ---------- accel/hvf/hvf-all.c | 8 ++------ accel/kvm/kvm-all.c | 17 ++--------------- accel/tcg/tcg-all.c | 27 +++++++++++---------------- accel/whpx/whpx-common.c | 1 - gdbstub/gdbstub.c | 2 +- target/arm/whpx/whpx-all.c | 5 ----- target/i386/whpx/whpx-all.c | 7 ++----- 11 files changed, 20 insertions(+), 71 deletions(-) diff --git a/include/accel/accel-ops.h b/include/accel/accel-ops.h index f46492e3fe1..9f3f329c448 100644 --- a/include/accel/accel-ops.h +++ b/include/accel/accel-ops.h @@ -13,6 +13,8 @@ =20 struct AccelState { Object parent_obj; + + AccelGdbConfig gdbstub; }; =20 struct AccelClass { @@ -36,9 +38,6 @@ struct AccelClass { bool (*has_memory)(AccelState *accel, AddressSpace *as, hwaddr start_addr, hwaddr size); =20 - /* gdbstub related hooks */ - int (*gdbstub_supported_sstep_flags)(AccelState *as); - bool *allowed; /* * Array of global properties that would be applied when specific diff --git a/include/qemu/accel.h b/include/qemu/accel.h index 052b4c59313..3b01d55741b 100644 --- a/include/qemu/accel.h +++ b/include/qemu/accel.h @@ -82,12 +82,4 @@ typedef struct AccelGdbConfig { unsigned sstep_flags; } AccelGdbConfig; =20 -/** - * accel_supported_gdbstub_sstep_flags: - * - * Returns the supported single step modes for the configured - * accelerator. - */ -int accel_supported_gdbstub_sstep_flags(void); - #endif /* QEMU_ACCEL_H */ diff --git a/include/system/whpx-all.h b/include/system/whpx-all.h index 0e2d333e919..4022571ffff 100644 --- a/include/system/whpx-all.h +++ b/include/system/whpx-all.h @@ -23,7 +23,6 @@ void whpx_arch_destroy_vcpu(CPUState *cpu); void whpx_arch_accel_class_init(ObjectClass *oc); =20 /* called by whpx-accel-ops */ -int whpx_arch_gdbstub_sstep_flags(AccelState *as); bool whpx_arch_supports_guest_debug(void); =20 #endif diff --git a/accel/accel-common.c b/accel/accel-common.c index 62590a7d9a6..f31d68a9b78 100644 --- a/accel/accel-common.c +++ b/accel/accel-common.c @@ -113,16 +113,6 @@ void accel_cpu_common_unrealize(CPUState *cpu) } } =20 -int accel_supported_gdbstub_sstep_flags(void) -{ - AccelState *accel =3D current_accel(); - AccelClass *acc =3D ACCEL_GET_CLASS(accel); - if (acc->gdbstub_supported_sstep_flags) { - return acc->gdbstub_supported_sstep_flags(accel); - } - return 0; -} - static const TypeInfo accel_types[] =3D { { .name =3D TYPE_ACCEL, diff --git a/accel/hvf/hvf-all.c b/accel/hvf/hvf-all.c index 21b9b71a6df..8bd9154a50b 100644 --- a/accel/hvf/hvf-all.c +++ b/accel/hvf/hvf-all.c @@ -220,6 +220,8 @@ static int hvf_accel_init(AccelState *as, MachineState = *ms) } assert_hvf_ok(ret); =20 + as->gdbstub.sstep_flags =3D SSTEP_ENABLE | SSTEP_NOIRQ; + QTAILQ_INIT(&s->hvf_sw_breakpoints); =20 hvf_state =3D s; @@ -228,11 +230,6 @@ static int hvf_accel_init(AccelState *as, MachineState= *ms) return hvf_arch_init(); } =20 -static int hvf_gdbstub_sstep_flags(AccelState *as) -{ - return SSTEP_ENABLE | SSTEP_NOIRQ; -} - static void hvf_set_kernel_irqchip(Object *obj, Visitor *v, const char *name, void *opaque, Error **errp) @@ -278,7 +275,6 @@ static void hvf_accel_class_init(ObjectClass *oc, const= void *data) ac->name =3D "HVF"; ac->init_machine =3D hvf_accel_init; ac->allowed =3D &hvf_allowed; - ac->gdbstub_supported_sstep_flags =3D hvf_gdbstub_sstep_flags; hvf_kernel_irqchip_override =3D false; hvf_kernel_irqchip =3D false; object_class_property_add(oc, "kernel-irqchip", "on|off|split", diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index b6125125f82..ceb0b33abdd 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -104,7 +104,6 @@ bool kvm_readonly_mem_allowed; bool kvm_vm_attributes_allowed; bool kvm_msi_use_devid; bool kvm_pre_fault_memory_supported; -static int kvm_sstep_flags; static bool kvm_immediate_exit; static uint64_t kvm_supported_memory_attributes; static bool kvm_guest_memfd_supported; @@ -3041,13 +3040,13 @@ static int kvm_init(AccelState *as, MachineState *m= s) (kvm_check_extension(s, KVM_CAP_SET_GUEST_DEBUG) > 0); =20 if (s->have_guest_debug) { - kvm_sstep_flags =3D SSTEP_ENABLE; + as->gdbstub.sstep_flags =3D SSTEP_ENABLE; =20 int guest_debug_flags =3D kvm_check_extension(s, KVM_CAP_SET_GUEST_DEBUG2); =20 if (guest_debug_flags & KVM_GUESTDBG_BLOCKIRQ) { - kvm_sstep_flags |=3D SSTEP_NOIRQ; + as->gdbstub.sstep_flags |=3D SSTEP_NOIRQ; } } #endif @@ -4279,17 +4278,6 @@ static void kvm_accel_instance_init(Object *obj) s->honor_guest_pat =3D ON_OFF_AUTO_OFF; } =20 -/** - * kvm_gdbstub_sstep_flags(): - * - * Returns: SSTEP_* flags that KVM supports for guest debug. The - * support is probed during kvm_init() - */ -static int kvm_gdbstub_sstep_flags(AccelState *as) -{ - return kvm_sstep_flags; -} - static void kvm_accel_class_init(ObjectClass *oc, const void *data) { AccelClass *ac =3D ACCEL_CLASS(oc); @@ -4298,7 +4286,6 @@ static void kvm_accel_class_init(ObjectClass *oc, con= st void *data) ac->rebuild_guest =3D kvm_reset_vmfd; ac->has_memory =3D kvm_accel_has_memory; ac->allowed =3D &kvm_allowed; - ac->gdbstub_supported_sstep_flags =3D kvm_gdbstub_sstep_flags; =20 object_class_property_add(oc, "kernel-irqchip", "on|off|split", NULL, kvm_set_kernel_irqchip, diff --git a/accel/tcg/tcg-all.c b/accel/tcg/tcg-all.c index 8eb4a6b89e8..d30b53cd3b7 100644 --- a/accel/tcg/tcg-all.c +++ b/accel/tcg/tcg-all.c @@ -149,6 +149,17 @@ static int tcg_init_machine(AccelState *as, MachineSta= te *ms) =20 tcg_allowed =3D true; =20 + as->gdbstub.sstep_flags =3D SSTEP_ENABLE; + if (replay_mode =3D=3D REPLAY_MODE_NONE) { + /* + * In replay mode all events will come from the log and can't be + * suppressed otherwise we would break determinism. However as tho= se + * events are tied to the number of executed instructions we won't= see + * them occurring every time we single step. + */ + as->gdbstub.sstep_flags |=3D SSTEP_NOIRQ | SSTEP_NOTIMER; + } + page_init(); tb_htable_init(); tcg_init(s->tb_size * MiB, s->splitwx_enabled, max_threads); @@ -242,21 +253,6 @@ static void tcg_set_one_insn_per_tb(Object *obj, bool = value, Error **errp) qatomic_set(&one_insn_per_tb, value); } =20 -static int tcg_gdbstub_supported_sstep_flags(AccelState *as) -{ - /* - * In replay mode all events will come from the log and can't be - * suppressed otherwise we would break determinism. However as those - * events are tied to the number of executed instructions we won't see - * them occurring every time we single step. - */ - if (replay_mode !=3D REPLAY_MODE_NONE) { - return SSTEP_ENABLE; - } else { - return SSTEP_ENABLE | SSTEP_NOIRQ | SSTEP_NOTIMER; - } -} - static void tcg_accel_class_init(ObjectClass *oc, const void *data) { AccelClass *ac =3D ACCEL_CLASS(oc); @@ -266,7 +262,6 @@ static void tcg_accel_class_init(ObjectClass *oc, const= void *data) ac->cpu_common_unrealize =3D tcg_exec_unrealizefn; ac->get_stats =3D tcg_get_stats; ac->allowed =3D &tcg_allowed; - ac->gdbstub_supported_sstep_flags =3D tcg_gdbstub_supported_sstep_flag= s; =20 object_class_property_add_str(oc, "thread", tcg_get_thread, diff --git a/accel/whpx/whpx-common.c b/accel/whpx/whpx-common.c index e3f93efc61f..247e12db812 100644 --- a/accel/whpx/whpx-common.c +++ b/accel/whpx/whpx-common.c @@ -527,7 +527,6 @@ static void whpx_accel_class_init(ObjectClass *oc, cons= t void *data) ac->init_machine =3D whpx_accel_init; ac->pre_resume_vm =3D whpx_pre_resume_vm; ac->allowed =3D &whpx_allowed; - ac->gdbstub_supported_sstep_flags =3D whpx_arch_gdbstub_sstep_flags; =20 object_class_property_add(oc, "kernel-irqchip", "on|off|split", NULL, whpx_set_kernel_irqchip, diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 06b712562c5..6c4fa065638 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -72,7 +72,7 @@ void gdb_init_gdbserver_state(void) * By default try to use no IRQs and no timers while single * stepping so as to make single stepping like a typical ICE HW step. */ - gdbserver_state.accel_config.sstep_flags =3D accel_supported_gdbstub_s= step_flags(); + gdbserver_state.accel_config =3D current_accel()->gdbstub; gdbserver_state.sstep_flags =3D SSTEP_ENABLE | SSTEP_NOIRQ | SSTEP_NOT= IMER; gdbserver_state.sstep_flags &=3D gdbserver_state.accel_config.sstep_fl= ags; } diff --git a/target/arm/whpx/whpx-all.c b/target/arm/whpx/whpx-all.c index 5208d7e1dfe..3079c6293c8 100644 --- a/target/arm/whpx/whpx-all.c +++ b/target/arm/whpx/whpx-all.c @@ -295,11 +295,6 @@ void whpx_translate_cpu_breakpoints( /* Breakpoints aren=E2=80=99t supported on this platform */ } =20 -int whpx_arch_gdbstub_sstep_flags(AccelState *as) -{ - return 0; -} - bool whpx_arch_supports_guest_debug(void)=20 { return false; diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index f6e1636a4e0..467ac6bed45 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -1853,11 +1853,6 @@ void whpx_apply_breakpoints( } } =20 -int whpx_arch_gdbstub_sstep_flags(AccelState *as) -{ - return SSTEP_ENABLE; -} - bool whpx_arch_supports_guest_debug(void)=20 { return true; @@ -3348,6 +3343,8 @@ int whpx_accel_init(AccelState *as, MachineState *ms) whpx_memory_init(); whpx_init_emu(); =20 + as->gdbstub.sstep_flags =3D SSTEP_ENABLE; + return 0; =20 error: --=20 2.53.0 From nobody Sun Jul 26 11:01:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783345695; cv=none; d=zohomail.com; s=zohoarc; b=frfr+UtML81+aSZu3aXGWFN9QHCuiV+iK3py9j7zgJJIiNe3ZTpZBhO+OjFQ6/YkL0s7CUYAvbFVMTyYF/87cGeYm1t4kauqhvPNrSCHjg7lZKrpc8NPG2mJmphLhaxIlqJQ3WO0p/bpiD/T9u2UgwsjTfUwsUVcj6quG6w5A0Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783345695; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=W6pxmg0IQ16jzDnIcEZehtTwwvA0mwamCMGIfnC8430=; b=UHuvym6jZPGeRT07LwlymrORrfQmWTBdrgIKikK3ZWvy0zQVzXEsZ7fMf2KRfjAfX8Ck+TkqUzTIquDIHi2wv26DtSdC3TzZVJn4pdbXZC8xVLA3WxLIUdxQQrtPgk2zk6RLJ54YfWYQKrPGbDVWUlkglxgWFXYsIZgoM2UnsXQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783345695289720.291662034607; Mon, 6 Jul 2026 06:48:15 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgjgA-00015H-OC; Mon, 06 Jul 2026 09:48:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjg2-0000eH-Nv for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:48:05 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjg1-0006nU-Dd for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:48:02 -0400 Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666AxMII316792 for ; Mon, 6 Jul 2026 13:48:00 GMT Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f87q7hj5b-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 13:48:00 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92e82060977so319267785a.1 for ; Mon, 06 Jul 2026 06:48:00 -0700 (PDT) Received: from localhost.localdomain (1.171.88.92.rev.sfr.net. [92.88.171.1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c637bc21sm667249545e9.7.2026.07.06.06.47.57 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 06 Jul 2026 06:47:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= W6pxmg0IQ16jzDnIcEZehtTwwvA0mwamCMGIfnC8430=; b=p8U22raW0f4CV+TO uPh98T8yf8nLvhlcS49LBsXXqFZlYmw/EI5Pdqvw5cNiIkRfklPz/z736XiW488w e3II9yhtShG13Cv6qKHq+RItTNnN73xS704G3Jf6aY/fHy2QMuGI7FX3LxuXssoj Jxc9G014vGmZwhwLzJMHXrwpF7FlNd6syJgdWfLz20IuTgdCZLw4NZemkfvZTasC y25JACs+OpsyAgSrgsHNiDnmcUcM/ECYJK3uLHL8IQfFdLbmE/CRGqYRrXXGvC8q v05rgzyyN3TWlkfCKho7foefIW1yrP9d2FETIZ+8FeGNdxcUdRt27lqiOzQ/3mCY of5OKA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783345680; x=1783950480; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=W6pxmg0IQ16jzDnIcEZehtTwwvA0mwamCMGIfnC8430=; b=Mcc93YxPyrQkl0jfiquAHqmiSxnnfAfBt0Rzz/4RhO1MNlXIjvt0CViJHm+673NrsH /VLu+yu7JMwBDFamCs0FMPl7qT3ndvStKfL7mh3CTixy9ePx+uOz51fAtMlfP8OaBpmq kv8vJwDe3FoMLZ7EgkdSQ1gP5MxQML6t9iDwpKgiJcRK4gArIFaRQlJ926NuKMqPahtL E5o0gy6yYG8xMU6zp4UPBRal8VuI9zIX1+1iszE6FWauUiXxcavbOfX/2gndDvMirJrO 1Bkz4DAtFd2fVcVxfFp7T2guwC6ovGaubJgl/6Us/mdYgK96UhrueMJ/3ymOXoFcoNJ0 OIXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783345680; x=1783950480; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=W6pxmg0IQ16jzDnIcEZehtTwwvA0mwamCMGIfnC8430=; b=IMlS+tzZ3Ox1+aCkU3idAPupu+9e/aBIn+FCq953+nolygvd4PpQcTvKozg2eX84S9 6mGwdWbN4ZLCYVj68QuefS/LD4HnxgVNdEUeR0BxTaQz3NKLCxZMoOb0sRPQ3qj1GbNr 4SiOJbQIpiFolVnBgKh16lxxxpONxPq7lbutVcEIuUxLLVwdjIdlt7yQQN6L3ZP5y8hq HDpcrUXlqEvpei/DFLleTcry/rRktwjjhZR3UpCsR2WzExarbZykjb4/Z4hwXN6haor0 ys8PpFxIN4Ca77km/hZM1h7eIB8stQvtFdFeEc41fwhx0VZpZmUSYToWyvMlyge9dd+z agXw== X-Gm-Message-State: AOJu0YyfIBh30t2U7e81N+7soPHBsyDV6sfNPErNDd9RkJqibNZhohvv kj/bImwtOR7VBzTOQBRdNQyo0UF/bsKjw/0U5IylDbRKwK04BlY/fGbk8R29AvqFsAH065pq6Z5 uYcndQg2uOUpMTth2d+1988h89dszY8w+wP/+aIe3+tmQ/2jjEXMUxA/1sb4U2oIS1A== X-Gm-Gg: AfdE7clGITOaFHpOsZwkLwaYDGedlTXg1wtCNy6GymHQsR/66bHheMjgqa+PwwzRvR3 fdHsZHPhoGJ8uerrtTS3zG9M5Yum8Gi8CUKV/6xEhXe2+tz88I61KaSlZ9TMIvbQfFACp1Tfkn/ 3L5j2pKAYp3huR9FZGGnhZvKzYxY8KBr7d92r7n2fVjPZkcLt6JPL10DVFDTzRaBtq0crfG/Q+n yN+tLeAvcs75IPlBB0sbb/DxnqGW8TdAFDBYguIfbO1Ncvj9X18/GtI9zv/G2icXk/RvIGqF8Ib ULzFQY6Ko+xXKv+qoXKDKN8vV92rNTY8ucoqtKXKB+gCNYVaXYo17aSS7efHIAKKT6IPNJ+UO7S tMVLp40FGfo5cQiSLzCQIEn+R1wRRwSuLKrceya5awr2CA0ODPAsNITkLpg== X-Received: by 2002:a05:620a:3912:b0:915:9931:3a3e with SMTP id af79cd13be357-92e8b50c64cmr1706674185a.27.1783345679779; Mon, 06 Jul 2026 06:47:59 -0700 (PDT) X-Received: by 2002:a05:620a:3912:b0:915:9931:3a3e with SMTP id af79cd13be357-92e8b50c64cmr1706669385a.27.1783345679202; Mon, 06 Jul 2026 06:47:59 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 16/32] gdbstub: Make default replay_mode value explicit in stubs Date: Mon, 6 Jul 2026 15:45:11 +0200 Message-ID: <20260706134527.84808-17-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706134527.84808-1-philmd@oss.qualcomm.com> References: <20260706134527.84808-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE0MCBTYWx0ZWRfXyznjd+EDz/C1 2lbBnS8cYEp28I5Kw44KfKik4KH0iqXLQgYHD4Ux0Fe7IWExCyimuipimu/nT7Hyu5C9/elQrnV F/BvMWzwbjS+pEevq12h3lVNjL1KYhgmvLzzT5xRsfcrMqEO9EbSK99xMfBcjwiBi+16EwOioGp R9j3peXhdp+jwJrEwKu+b3Cb93J9qny2y9cusRG0fHtQLxE3Zv5DDk2vzP4xD2isfy3fl4VXEqJ 9/LX9rsHNf1vt6O6tgSdl+Um5glt1TN3VO05b0+lN5T8TZAvdNoXGfmtBih40pTPZgcw/TKeMsi 2TOEDICUUZaafjjqXSBhI76awuI5nHj0HTTi3AnbezVfQsLi1KePYLCYMrkOQHzAH6hHs9Otcmh +XP08hyoSLIHcQEGGgi00BcDWa5cNPco0YqEhSZXG5ALNCZp2yVOggZlm9EBLg8rwDunojlZ+sT dCkpz6CNyophyHgazzQ== X-Proofpoint-ORIG-GUID: sk2TzX9OSavan0NKI_ikS1gcORx6Hr8V X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE0MCBTYWx0ZWRfX3Acth6oz7AwD r0E3MsNtjZM46LcE4+Ij1d2AR7FlS9CLdpR6C9lcTQuDxK7EuN/sZDWatxrvgNpaPkf2ZvMasgp /YgCL1YdnJeqSqAt9T0O+qVvmTCXjHo= X-Proofpoint-GUID: sk2TzX9OSavan0NKI_ikS1gcORx6Hr8V X-Authority-Analysis: v=2.4 cv=f9N4wuyM c=1 sm=1 tr=0 ts=6a4bb210 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=PLEY+c9/kVlxBKEpvFYBUQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=Cu_OB6cER5A0ZMY7a4UA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 impostorscore=0 bulkscore=0 suspectscore=0 clxscore=1015 spamscore=0 phishscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060140 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783345695626158500 Make explicit @replay_mode is stubbed as REPLAY_MODE_NONE. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-ID: <20260705215729.62196-16-philmd@oss.qualcomm.com> --- stubs/replay-mode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stubs/replay-mode.c b/stubs/replay-mode.c index 439d97e4a87..5bc8f7d6589 100644 --- a/stubs/replay-mode.c +++ b/stubs/replay-mode.c @@ -1,4 +1,4 @@ #include "qemu/osdep.h" #include "system/replay.h" =20 -ReplayMode replay_mode; +ReplayMode replay_mode =3D REPLAY_MODE_NONE; --=20 2.53.0 From nobody Sun Jul 26 11:01:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783345706; cv=none; d=zohomail.com; s=zohoarc; b=UNt/IZF3EpHRlW8EVdE8ItvGVFjX1pHA2osn4zSb9KqAF61bU3uf1PZihfke9JnkWxeq0bTfmUL/w0cutZyvqizQHDlOy3suPqzK1ApzU5zxgFEgBshDPXcUM4QiswhT4ERxD57YfbFtK5CCy3YwTWjkJy8n35PAYMvatNx5hp4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783345706; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=rjq83pfJV2nVYU3+zqImMenwqXneWXWnmXXzu7JibtA=; b=gcwO+GgJsEVCDZscec6BHWGxRftD5b34O/PJ6+D7XgzaqDp97r3VUjaZyfAV+W6YjKrXbN7YJWbJZfTVjGmVgxZICPCWCJk7ZJ6cPvAiqAGRx17pkXTnzLDixr2CKwgfMU06lxdKjV5ERxwCJBiO9l/XugA9GZkvyFX8yr8Dht4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783345706371447.4474287266378; Mon, 6 Jul 2026 06:48:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgjgI-00025C-6v; Mon, 06 Jul 2026 09:48:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjgD-0001WB-Hz for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:48:13 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjgB-0006no-MD for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:48:13 -0400 Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666AxCeP238118 for ; Mon, 6 Jul 2026 13:48:10 GMT Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f88t898u1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 13:48:10 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-92d1cae5740so351150085a.0 for ; Mon, 06 Jul 2026 06:48:10 -0700 (PDT) Received: from localhost.localdomain (1.171.88.92.rev.sfr.net. [92.88.171.1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493bef1807asm323576865e9.1.2026.07.06.06.48.07 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 06 Jul 2026 06:48:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rjq83pfJV2nVYU3+zqImMenwqXneWXWnmXXzu7JibtA=; b=jsMcmOaCMke+BwdC LDFhB2BQ43RAPwj+7fHV9s/LDXoC7K6BaQrCct/HNRHpiDggmLBK2Kh/39vQxK5R qafXIblzM51mNLV1ejhTgWycLZeqpHh1ugdEL/xCQnT0FFrcOwYkFIZ+uDN1W+2l fIAuvR5a9kf4s7AlhsiqDjGWZcKe2xSh8+4Y+VsIQPC92BaktXuZifqv/DU71Amx 1sOwkJ1nHo5U4QENkwY5JP91+EZq2pyek7B2m4tu/ntYoKT+pg7UkLdtiQo+lEl7 d5WBg1NW+JabedP5kJgMLEudWDrR4MmH8/jSLySKC68ARrPYjzuYzHCTdb+iGrcu zdpRLg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783345689; x=1783950489; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=rjq83pfJV2nVYU3+zqImMenwqXneWXWnmXXzu7JibtA=; b=ErSPQGi/QYihqyogiGDtzx3P10HZmybCG58olVOJFrM48ujZ+3M4HAPDzf7zfcm4ax DsPMrwZ3e4YUx657iItwsl5sIRmLKtmSS4fzC0r8shyo5n+FBT40F2oTl0NMy7MQhykx OkPpAgszlD1qWmlO3AW2CkDT6FFr8Mf7vQIlaHK1sKALxLvUe7jN/eXAVg/GJcJKo6mq d1Hvi8COVws6dBTNdfyxINZzp9KyBzEyevquUrT4eB1QKBHJvAoshIbHjzdlSBiuBNGx 5rbC7GPe55o0X6EJs1IbLgSS9ulp9dCUhUB+QRQDeB8WEJ/c4oWEl/URVzxq5BClFOYe UzDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783345689; x=1783950489; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=rjq83pfJV2nVYU3+zqImMenwqXneWXWnmXXzu7JibtA=; b=Y9bwnb7gTGQ7Iz1jNBrkyOE5ys6DYJrmeZ7C8ok0F/OOMsbiXscwe3DF+1m7UR1gD3 fWAe96fwqEd6YBf2P9BxBQi+P03PLKp9Ko8fWys8nEyZo1xU69ih83B8rpqw7w/7NQ9J p9tP5+e9VlgUwsggiW5XiUA9XO3AT86eCDPKm/niBW17Wwzf9/w3e7q2whfkV8WXq+ED W5QTS0d2S6FWQS7ds4cnuxL38hX6wpSu8g9cYHDnS07kt1kAiK6GsOo5luBZUOHtCSzC nfafYbFnYh39inn7fyfV4aZGn+/seP306brLL7SG0JLND1Sue3i9ovpR7GHdiR0x5P4w ciWA== X-Gm-Message-State: AOJu0Yytx5ocOnafzp/njc6WUuNepZcwsTHyZqOVodunw+ItFIGWh7FC /Qt+GGPaW21Tz6qZoZ8DwkYsZaw/S1CsSH4+R5ZAdZ7enjJA3meX3JGCKrCjnrr7Q02/2rDOQqX YkVCZ7ipAAaBWd864ynT0JXpfc/1aJDXtPnJDroQeDvQnxIJBnpEtlQ2eVeZQLTlmkQ== X-Gm-Gg: AfdE7clzkn585lzJgd0RYsPHifBkwlEE59Q7jHAihp96BcWvOuvb/49Btjj/Ocoh+rq sIidYkRUUsPPrKJK7HKoUjiCcvJhUGf94sIt0c8JTIdIZSYmt70ssi2P8bwYxDeEiOskGc4V+wR qaW7nhR4lBCX/ZVER5EXlqzatzWCc0iLlUw85s3dJszGs1tuXhryoqrTTqgricQoG0QQPNV3Vqe zUfZoGg120JjtjANRJ4QAap/f0zZxGIH+VzcAkBksEk12IY+ETRZ2jKwUVramaRi4MJ6WhoaUCB LN7DDpLr2vpZvW69bUUYpTwRJgo30bKcDTi0O3zQemIprdN2/CtQgdr/OQXydUtLPW638GzedgE 31wI03uhBiN7NcrGtjT/Rjj3CWHNuWaPuVFhE8cDIpv2Ap89HK5LEK+WkvQ== X-Received: by 2002:a05:620a:1997:b0:92e:7533:ef67 with SMTP id af79cd13be357-92ebb568212mr88266985a.20.1783345688998; Mon, 06 Jul 2026 06:48:08 -0700 (PDT) X-Received: by 2002:a05:620a:1997:b0:92e:7533:ef67 with SMTP id af79cd13be357-92ebb568212mr88261285a.20.1783345688392; Mon, 06 Jul 2026 06:48:08 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 17/32] accel: Hold @can_reverse information in AccelGdbConfig Date: Mon, 6 Jul 2026 15:45:12 +0200 Message-ID: <20260706134527.84808-18-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706134527.84808-1-philmd@oss.qualcomm.com> References: <20260706134527.84808-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfXwRxaVh2gV/d2 fq0n1FD7PwOSWYEIC2PsNULQmdChirAaobKT3NtWqKvXvj4t0tTjD6SqFP7+d0J6wEiGBDeat9q 8P3at0Kt/SRiDfeTOMmO6SylmHfRMYQ= X-Proofpoint-GUID: LdvtBKb-0TRU8IVdFeqKV5zDQDIvusxx X-Authority-Analysis: v=2.4 cv=C6zZDwP+ c=1 sm=1 tr=0 ts=6a4bb21a cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=PLEY+c9/kVlxBKEpvFYBUQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=Zu86EXcvoz0JJFEs46oA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: LdvtBKb-0TRU8IVdFeqKV5zDQDIvusxx X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfXyXj08RRAUf5c NV1IDGuPuWO7HyRZd+HwupTGVjkdjw154/QYDncL0FTrd6Nehea94zmax74cmTHK3HtrWyeKgSP cWB+kZ+MVjKmCHPC4zNQx1XZl4K37uqy0P5+aegXcxNvboFS1r2run5Xzw7v4YXSdYbWtbSxK3U YCNMcRMB/lUci/BGuZO4YLK5ishb+7qHduR4a2mu+dn4dmgZaTWjDPMpZGLJA46bglmkcH85DWH f1BIoh7mVOW9ZcIWnP9TnanG5y9s/m04BZ730Qjy4HOyV94fY6Emrn6wA3Z3V8+IHtVOquBhwh8 H76hgrCC8ZE6GEqcmOxBIWZedb85wDcCYQoWAKGvNQpqyBW3ooYns1hJdASSpbVLNC3wz3G7Lpn qQhHeXCnNy6nmhDLwRIgY3VZ/Gysgg9WBiV4+wHGuE462g+AZLidxKAEapKsabOfyFW2bfioBHk yYgQBWZ8G2qlQhAeqkw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 clxscore=1015 spamscore=0 adultscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060141 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783345707808158500 Hold @can_reverse in AccelGdbConfig, set it when initializing AccelState in AccelClass::init_machine handlers (only TCG sets it). Remove gdb_can_reverse() as now unused. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Manos Pitsidianakis Message-ID: <20260705215729.62196-17-philmd@oss.qualcomm.com> --- gdbstub/internals.h | 1 - include/qemu/accel.h | 2 ++ accel/tcg/tcg-all.c | 3 +++ gdbstub/gdbstub.c | 4 ++-- gdbstub/system.c | 5 ----- gdbstub/user.c | 6 ------ 6 files changed, 7 insertions(+), 14 deletions(-) diff --git a/gdbstub/internals.h b/gdbstub/internals.h index 0444dee2246..0b74ea4000f 100644 --- a/gdbstub/internals.h +++ b/gdbstub/internals.h @@ -154,7 +154,6 @@ CPUState *gdb_first_attached_cpu(void); void gdb_append_thread_id(CPUState *cpu, GString *buf); int gdb_get_cpu_index(CPUState *cpu); unsigned int gdb_get_max_cpus(void); /* both */ -bool gdb_can_reverse(void); /* system emulation, stub for user */ int gdb_target_sigtrap(void); /* user */ =20 void gdb_create_default_process(GDBState *s); diff --git a/include/qemu/accel.h b/include/qemu/accel.h index 3b01d55741b..8e0c3dfe088 100644 --- a/include/qemu/accel.h +++ b/include/qemu/accel.h @@ -77,9 +77,11 @@ void accel_cpu_common_unrealize(CPUState *cpu); * struct AccelGdbConfig - gdbstub configuration for an accelerator. * * @sstep_flags: Set SSTEP_* flags that accelerator supports for guest deb= ug. + * @can_reverse: Whether reverse mode is supported. */ typedef struct AccelGdbConfig { unsigned sstep_flags; + bool can_reverse; } AccelGdbConfig; =20 #endif /* QEMU_ACCEL_H */ diff --git a/accel/tcg/tcg-all.c b/accel/tcg/tcg-all.c index d30b53cd3b7..7186c10cf02 100644 --- a/accel/tcg/tcg-all.c +++ b/accel/tcg/tcg-all.c @@ -159,6 +159,9 @@ static int tcg_init_machine(AccelState *as, MachineStat= e *ms) */ as->gdbstub.sstep_flags |=3D SSTEP_NOIRQ | SSTEP_NOTIMER; } + if (replay_mode =3D=3D REPLAY_MODE_PLAY) { + as->gdbstub.can_reverse =3D true; + } =20 page_init(); tb_htable_init(); diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 6c4fa065638..0a328b0dd48 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -1376,7 +1376,7 @@ static void handle_step(GArray *params, void *user_ct= x) =20 static void handle_backward(GArray *params, void *user_ctx) { - if (!gdb_can_reverse()) { + if (!gdbserver_state.accel_config.can_reverse) { gdb_put_packet("E22"); return; } @@ -1684,7 +1684,7 @@ static void handle_query_supported(GArray *params, vo= id *user_ctx) g_string_append(gdbserver_state.str_buf, ";qXfer:features:read+"); } =20 - if (gdb_can_reverse()) { + if (gdbserver_state.accel_config.can_reverse) { g_string_append(gdbserver_state.str_buf, ";ReverseStep+;ReverseContinue+"); } diff --git a/gdbstub/system.c b/gdbstub/system.c index 1179c82cb86..2e8c457097b 100644 --- a/gdbstub/system.c +++ b/gdbstub/system.c @@ -479,11 +479,6 @@ unsigned int gdb_get_max_cpus(void) return ms->smp.max_cpus; } =20 -bool gdb_can_reverse(void) -{ - return replay_mode =3D=3D REPLAY_MODE_PLAY; -} - /* * Softmmu specific command helpers */ diff --git a/gdbstub/user.c b/gdbstub/user.c index f7bc4e63dfd..299388b9f71 100644 --- a/gdbstub/user.c +++ b/gdbstub/user.c @@ -786,12 +786,6 @@ unsigned int gdb_get_max_cpus(void) return max_cpus; } =20 -/* replay not supported for user-mode */ -bool gdb_can_reverse(void) -{ - return false; -} - /* * Break/Watch point helpers */ --=20 2.53.0 From nobody Sun Jul 26 11:01:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783345707; cv=none; d=zohomail.com; s=zohoarc; b=eoS4wcws+psTe79yJ8cYYvO9/64/P7a9Nx5xI41WKNX3THtjakdUZ4/z+cvQg0SNL5YPBUfO6eFVtzehlrPKcRsDJXQ9MyLlr7s4dSAPLTpj0p86e9DKcFR2CqomiDpfD80QLzAEFE+a8xjuw8q11yz1dnWaLJ/F7gnhesocOwI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783345707; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=PJwFDn/oYUlgyh+vrkNeWnLqkInjmkCBFCNkS7Cm5xc=; b=nX7YMnTbiAiMxPnp/+HBXmh280/aF+VrhZRW6QOwJorqN99j2HGHEFOaiJwVJGe6jAvtSoi9t7jYAsx0xq7Ew/XwqCJlJoWn2iKpzg5yYFfI6NFWy46Elnfjd7BmQ6E29BPQ2nHEfVhgHbzHViUaZuUEUJcIeYQ/875mpiHFMTc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783345707658620.3205271247288; Mon, 6 Jul 2026 06:48:27 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgjgP-0003Al-O7; Mon, 06 Jul 2026 09:48:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjgN-0002s9-4C for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:48:23 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjgK-0006ok-Gu for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:48:22 -0400 Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666Ax7hi245529 for ; Mon, 6 Jul 2026 13:48:19 GMT Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f8a98guf3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 13:48:19 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e61b38eddso552004285a.2 for ; Mon, 06 Jul 2026 06:48:18 -0700 (PDT) Received: from localhost.localdomain (1.171.88.92.rev.sfr.net. [92.88.171.1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa0f21543sm23819551f8f.35.2026.07.06.06.48.15 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 06 Jul 2026 06:48:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= PJwFDn/oYUlgyh+vrkNeWnLqkInjmkCBFCNkS7Cm5xc=; b=COTkm4oLssADz64k 1OlTwuzLvJ6Myng/W6BviftDXTGTZzhnKbaqCm+0Fn4Omhh1EJxB/SGC2Z4Y9ZTH Ml2XSxMne7Kb7Ppd8G1N4X+6mz9tUpb1PVmPqrlJLhKs1vXiTGkP2nVElYesvy2k vzP+3zoqVUD9pifaO+e05ep7khywUjwG/8hw/lW9dnOSlkQB2dOltpPAbFANYuyQ EOesVkN+ALcLoZQVwwepw4Bau9alQxih9WtuSug/wnSmJXVHDffuDGAiyArgArFS FUfpG5mtMPiUnruy8PV/5QTeLcpiSziBbhuylGlcttVnt8EJP3D7W01n5oia8zcj DziIXg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783345698; x=1783950498; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=PJwFDn/oYUlgyh+vrkNeWnLqkInjmkCBFCNkS7Cm5xc=; b=Vf0sCN/ADhahDaFe9ZblZs0Mm3a6FJPhaQdVQeQbWITwxGiNmpOQ+hnC2S1LhwL+s4 erG6JQSpjH9c2F/LGH2QFuMR0UfD1hSs8pNW6PUqH5JAaSCnf9sXXynBEBRq+0HFYpXz 2JFibjI3aPE6d9ccwV56NgrkMqGaVhN0tIouh3l0JPF43fA5F62zBAsHgLO2h6RcY3Ut sLwl+cDhk9kh/PfhBRaaFvp+1tyGgrOcuDlxuIvKLJtYFNOKHq3CEMVlsGuXbOtv95dq pRcpK96Ii7VKcrfznXqPziJCB3N4RzI2LzWobY1vRrWIROmHqB0hxTWLc59H+pwJIl7G iRcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783345698; x=1783950498; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=PJwFDn/oYUlgyh+vrkNeWnLqkInjmkCBFCNkS7Cm5xc=; b=RY46VHBgVX12EF20Eegk6Oc9kftS6SnhPeuFMdrg+jeReZDyLW5/0N8//b0lb08oV1 9X0TD/kO9cV6IJPQP7yp4nxCXWRcnJ5GhZedOrTNgfMRMDeHrQF91ziWfz4a1DOdVjvk T4/623iWCowD1vhv96LohY47CN0PscIPCdCUVltc4jzc9SwcxvH0ALqO3qfRJiWXx6yZ ZGiZjTZaQzd/K4rTki9zx4EgS1jPjxc+IXnSFgRQEYM0sUCOSwsa6s1yd0F4IyCA0a69 3mUcO61tXzrSjFD9OQRWkSU4QnW2xsbx4vQ8ViCjdb3YI3FpA8iylWWN9UKSk4Fw6vyz +EeA== X-Gm-Message-State: AOJu0YyxfruoyHPtP7YNrpeNUHzyWNs40SDlJUgLKqwh/Pe8TFybkv7r u1xyuI7/59qwGH0E3DOUgTcYH0EFhtEGQ0jeBBYlrfMyoB+5d/tVtCnOSFxNtjloAICc0KfM9w/ 1Ml9PysLAWHyKx5jwnGWEXanMWjaYPPyu7kBN7Wxc88D0l83cbc/usdOQVhROCGKbiA== X-Gm-Gg: AfdE7cmiG2inKjwR6HmXNBBkwnTHvZ87J2uy8W/yT/fLHSv7sIFDBxFu+Zzq7cnkxUg Fa2fu5k/u6yddH+PMBGbNN8LBD68REACjC/Kb2rW9prkkRTQ4XlHTh+RjB9u9MXHgtfPg6USx2K nygNfZZsjP3fb3J8D3zLOJPwIXzlhgWYFNtZGzvTQ8Hb0C+3KmdfgykKov28mGva/deWBS6P8Yl sNPLXYD1wE0dlCeELrhwRZsI/gnVUzoMhSoTh8AG7G4lyNHSX9piG5Lz8fVVfHirQwWGg/5gDCi c/xzgd+cbUfgXfvLCl9FGiyRRnpjRsLygdxW8A5uJpo7N0TBuV+LDUeHfcokSUSkZ3RpZ3BcjNM 3mCldKGIpQH+wmwW6KgCz0untXMwizwVDyW8GV3AF04Kz+Z6I77DOgvHSyQ== X-Received: by 2002:a05:620a:808c:b0:92e:5554:a80e with SMTP id af79cd13be357-92ebb5601acmr86657585a.39.1783345697848; Mon, 06 Jul 2026 06:48:17 -0700 (PDT) X-Received: by 2002:a05:620a:808c:b0:92e:5554:a80e with SMTP id af79cd13be357-92ebb5601acmr86651285a.39.1783345697190; Mon, 06 Jul 2026 06:48:17 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 18/32] accel: Remove AccelOpsClass::supports_guest_debug Date: Mon, 6 Jul 2026 15:45:13 +0200 Message-ID: <20260706134527.84808-19-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706134527.84808-1-philmd@oss.qualcomm.com> References: <20260706134527.84808-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=SpigLvO0 c=1 sm=1 tr=0 ts=6a4bb223 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=PLEY+c9/kVlxBKEpvFYBUQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=u5zfA1t3EaNT3PtHZxEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfX+1bEVRQrdJVX 2zT2KTsw8N8W8eU7ZMbQ75L2YpeAEarJwXT1jBYhKPoi5ZUYEn04TdvhkG8D3WcnweHrh+cnFUH Uv7aOyl9Va363MTcQcyZQUs0ayt4VbsHa52k+nx/LVyZFcfN2cBD9jLMo6Ufa9HXRAlar6+KO9a gYRorft6S/+5m++C36tStK59DHISjKx7NOhwXWTEAkEy4KbVlFUbILpJ7Wq0/2bxrAP33974krR d9+5T4ExRaK9fFfyzqq/a5Q9lnxTx3vN5NEUnDNBXIsUM6Lyb9LAyFs9eJSxlOufzGslYiAI7rl y3EkJItkrr0CZ1WIHwsJlWf18/8o2SwkMVYo9/znSX/c/Lf9HZnZBH9tehLrOMzShfiA+EjMl6U Dej2C0OaXlmwjWbMMCtkfFr5IsneyQEXSqi4ncrqKsHq5hM9m5+mUD+tvntUzPF5PN0xCzU3V3J GLjCaeHSOUdT24EpqLQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfX+mEjZ+31wzIt +ME76D06dIVTmNa5W/1hbLLIwbWe0P5uf2zbFoeLAV9UpHtmEh5DYxuUnFJ4RYXS9qR6vnvfJxt ibjs1I7ADopJCEzoi3IHa54Nz8YdlWw= X-Proofpoint-GUID: PipPyxZCczzqFVQhP8fP88zsKMPHuxut X-Proofpoint-ORIG-GUID: PipPyxZCczzqFVQhP8fP88zsKMPHuxut X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 spamscore=0 clxscore=1015 phishscore=0 bulkscore=0 adultscore=0 suspectscore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060141 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783345709841158500 Now accelerators hold the 'guest debug supported' information in their state, accessible by the common code. No need to call a per-accelerator handler, simply check for the SSTEP_ENABLE in AccelGdbConfig::sstep_flags. Remove all AccelOpsClass::supports_guest_debug implementations, inline gdb_supports_guest_debug() and remove the now unnecessary KVMState::have_guest_debug field. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-ID: <20260705215729.62196-18-philmd@oss.qualcomm.com> --- docs/system/gdb.rst | 2 +- accel/kvm/kvm-cpus.h | 1 - include/accel/accel-cpu-ops.h | 1 - include/qemu/accel.h | 2 ++ include/system/hvf_int.h | 5 ----- include/system/kvm_int.h | 1 - include/system/whpx-all.h | 3 --- accel/accel-common.c | 5 +++++ accel/hvf/hvf-accel-ops.c | 1 - accel/kvm/kvm-accel-ops.c | 1 - accel/kvm/kvm-all.c | 13 +------------ accel/tcg/tcg-accel-ops.c | 6 ------ accel/whpx/whpx-accel-ops.c | 6 ------ gdbstub/system.c | 13 +------------ target/arm/hvf/hvf.c | 5 ----- target/arm/whpx/whpx-all.c | 5 ----- target/i386/hvf/hvf.c | 5 ----- target/i386/whpx/whpx-all.c | 5 ----- 18 files changed, 10 insertions(+), 70 deletions(-) diff --git a/docs/system/gdb.rst b/docs/system/gdb.rst index d50470b135e..b6d8f8e77da 100644 --- a/docs/system/gdb.rst +++ b/docs/system/gdb.rst @@ -54,7 +54,7 @@ While GDB can always fall back to inserting breakpoints i= nto memory accelerator. For TCG system emulation we advertise an infinite number of hardware assisted breakpoints and watchpoints. For other accelerators it will depend on if support has been added (see -supports_guest_debug and related hooks in AccelOpsClass). +the AccelGdbConfig structure). =20 As TCG cannot track all memory accesses in user-mode there is no support for watchpoints. diff --git a/accel/kvm/kvm-cpus.h b/accel/kvm/kvm-cpus.h index 688511151c8..3185659562d 100644 --- a/accel/kvm/kvm-cpus.h +++ b/accel/kvm/kvm-cpus.h @@ -16,7 +16,6 @@ void kvm_destroy_vcpu(CPUState *cpu); void kvm_cpu_synchronize_post_reset(CPUState *cpu); void kvm_cpu_synchronize_post_init(CPUState *cpu); void kvm_cpu_synchronize_pre_loadvm(CPUState *cpu); -bool kvm_supports_guest_debug(void); int kvm_insert_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len); int kvm_remove_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len); void kvm_remove_all_breakpoints(CPUState *cpu); diff --git a/include/accel/accel-cpu-ops.h b/include/accel/accel-cpu-ops.h index 9c07a903ea0..b23a0606c7e 100644 --- a/include/accel/accel-cpu-ops.h +++ b/include/accel/accel-cpu-ops.h @@ -84,7 +84,6 @@ struct AccelOpsClass { int64_t (*get_elapsed_ticks)(void); =20 /* gdbstub hooks */ - bool (*supports_guest_debug)(void); int (*update_guest_debug)(CPUState *cpu); int (*insert_breakpoint)(CPUState *cpu, int type, vaddr addr, vaddr le= n); int (*remove_breakpoint)(CPUState *cpu, int type, vaddr addr, vaddr le= n); diff --git a/include/qemu/accel.h b/include/qemu/accel.h index 8e0c3dfe088..6f65f1cb89a 100644 --- a/include/qemu/accel.h +++ b/include/qemu/accel.h @@ -84,4 +84,6 @@ typedef struct AccelGdbConfig { bool can_reverse; } AccelGdbConfig; =20 +bool accel_supports_guest_debug(AccelState *accel); + #endif /* QEMU_ACCEL_H */ diff --git a/include/system/hvf_int.h b/include/system/hvf_int.h index 58fb865ebae..d64f4942556 100644 --- a/include/system/hvf_int.h +++ b/include/system/hvf_int.h @@ -104,11 +104,6 @@ void hvf_arch_remove_all_hw_breakpoints(void); */ int hvf_update_guest_debug(CPUState *cpu); =20 -/* - * Return whether the guest supports debugging. - */ -bool hvf_arch_supports_guest_debug(void); - bool hvf_arch_cpu_realize(CPUState *cpu, Error **errp); uint32_t hvf_arch_get_default_ipa_bit_size(void); uint32_t hvf_arch_get_max_ipa_bit_size(void); diff --git a/include/system/kvm_int.h b/include/system/kvm_int.h index 53bb0fcf180..0876aac938d 100644 --- a/include/system/kvm_int.h +++ b/include/system/kvm_int.h @@ -118,7 +118,6 @@ struct KVMState #endif int max_nested_state_len; int kvm_shadow_mem; - bool have_guest_debug; bool kernel_irqchip_allowed; bool kernel_irqchip_required; OnOffAuto kernel_irqchip_split; diff --git a/include/system/whpx-all.h b/include/system/whpx-all.h index 4022571ffff..d018e67e4f7 100644 --- a/include/system/whpx-all.h +++ b/include/system/whpx-all.h @@ -22,7 +22,4 @@ void whpx_translate_cpu_breakpoints( void whpx_arch_destroy_vcpu(CPUState *cpu); void whpx_arch_accel_class_init(ObjectClass *oc); =20 -/* called by whpx-accel-ops */ -bool whpx_arch_supports_guest_debug(void); - #endif diff --git a/accel/accel-common.c b/accel/accel-common.c index f31d68a9b78..00a400243f0 100644 --- a/accel/accel-common.c +++ b/accel/accel-common.c @@ -70,6 +70,11 @@ void accel_init_interfaces(AccelClass *ac) accel_init_cpu_interfaces(ac); } =20 +bool accel_supports_guest_debug(AccelState *accel) +{ + return accel->gdbstub.sstep_flags & SSTEP_ENABLE; +} + void accel_cpu_instance_init(CPUState *cpu) { if (cpu->cc->accel_cpu && cpu->cc->accel_cpu->cpu_instance_init) { diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-ops.c index dd2b45b7cb5..ecc0cd1b558 100644 --- a/accel/hvf/hvf-accel-ops.c +++ b/accel/hvf/hvf-accel-ops.c @@ -369,7 +369,6 @@ static void hvf_accel_ops_class_init(ObjectClass *oc, c= onst void *data) ops->remove_breakpoint =3D hvf_remove_breakpoint; ops->remove_all_breakpoints =3D hvf_remove_all_breakpoints; ops->update_guest_debug =3D hvf_update_guest_debug; - ops->supports_guest_debug =3D hvf_arch_supports_guest_debug; =20 ops->get_vcpu_stats =3D hvf_get_vcpu_stats; }; diff --git a/accel/kvm/kvm-accel-ops.c b/accel/kvm/kvm-accel-ops.c index d7967bc922f..45330327909 100644 --- a/accel/kvm/kvm-accel-ops.c +++ b/accel/kvm/kvm-accel-ops.c @@ -105,7 +105,6 @@ static void kvm_accel_ops_class_init(ObjectClass *oc, c= onst void *data) ops->synchronize_pre_loadvm =3D kvm_cpu_synchronize_pre_loadvm; ops->handle_interrupt =3D generic_handle_interrupt; =20 - ops->supports_guest_debug =3D kvm_supports_guest_debug; #ifdef TARGET_KVM_HAVE_GUEST_DEBUG ops->update_guest_debug =3D kvm_update_guest_debug_ops; ops->insert_breakpoint =3D kvm_insert_breakpoint; diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index ceb0b33abdd..b03488ebac3 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -3036,10 +3036,7 @@ static int kvm_init(AccelState *as, MachineState *ms) (kvm_check_extension(s, KVM_CAP_VM_ATTRIBUTES) > 0); =20 #ifdef TARGET_KVM_HAVE_GUEST_DEBUG - s->have_guest_debug =3D - (kvm_check_extension(s, KVM_CAP_SET_GUEST_DEBUG) > 0); - - if (s->have_guest_debug) { + if (kvm_check_extension(s, KVM_CAP_SET_GUEST_DEBUG) > 0) { as->gdbstub.sstep_flags =3D SSTEP_ENABLE; =20 int guest_debug_flags =3D @@ -3829,14 +3826,6 @@ int kvm_update_guest_debug(CPUState *cpu, unsigned l= ong reinject_trap) return data.err; } =20 -bool kvm_supports_guest_debug(void) -{ - KVMState *s =3D KVM_STATE(as); - - /* probed during kvm_init() */ - return s->have_guest_debug; -} - int kvm_insert_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len) { struct kvm_sw_breakpoint *bp; diff --git a/accel/tcg/tcg-accel-ops.c b/accel/tcg/tcg-accel-ops.c index c179cd4adeb..927af6c1db0 100644 --- a/accel/tcg/tcg-accel-ops.c +++ b/accel/tcg/tcg-accel-ops.c @@ -109,11 +109,6 @@ void tcg_handle_interrupt(CPUState *cpu, int mask) } } =20 -static bool tcg_supports_guest_debug(void) -{ - return true; -} - /* Translate GDB watchpoint type to a flags value for cpu_watchpoint_* */ static inline int xlat_gdb_type(CPUState *cpu, int gdbtype) { @@ -221,7 +216,6 @@ static void tcg_accel_ops_init(AccelClass *ac) } =20 ops->cpu_reset_hold =3D tcg_cpu_reset_hold; - ops->supports_guest_debug =3D tcg_supports_guest_debug; ops->insert_breakpoint =3D tcg_insert_breakpoint; ops->remove_breakpoint =3D tcg_remove_breakpoint; ops->remove_all_breakpoints =3D tcg_remove_all_breakpoints; diff --git a/accel/whpx/whpx-accel-ops.c b/accel/whpx/whpx-accel-ops.c index b8f41544cbe..ca5a119521a 100644 --- a/accel/whpx/whpx-accel-ops.c +++ b/accel/whpx/whpx-accel-ops.c @@ -82,11 +82,6 @@ static bool whpx_vcpu_thread_is_idle(CPUState *cpu) return !whpx_irqchip_in_kernel(); } =20 -static bool whpx_supports_guest_debug(void) -{ - return whpx_arch_supports_guest_debug(); -} - =20 static void whpx_accel_ops_class_init(ObjectClass *oc, const void *data) { @@ -96,7 +91,6 @@ static void whpx_accel_ops_class_init(ObjectClass *oc, co= nst void *data) ops->kick_vcpu_thread =3D whpx_kick_vcpu_thread; ops->cpu_thread_is_idle =3D whpx_vcpu_thread_is_idle; ops->handle_interrupt =3D generic_handle_interrupt; - ops->supports_guest_debug =3D whpx_supports_guest_debug; =20 ops->synchronize_post_reset =3D whpx_cpu_synchronize_post_reset; ops->synchronize_post_init =3D whpx_cpu_synchronize_post_init; diff --git a/gdbstub/system.c b/gdbstub/system.c index 2e8c457097b..bf7aa1ac234 100644 --- a/gdbstub/system.c +++ b/gdbstub/system.c @@ -331,8 +331,6 @@ static void create_processes(GDBState *s) gdb_create_default_process(s); } =20 -static bool gdb_supports_guest_debug(void); - bool gdbserver_start(const char *device, Error **errp) { Chardev *chr =3D NULL; @@ -345,7 +343,7 @@ bool gdbserver_start(const char *device, Error **errp) return false; } =20 - if (!gdb_supports_guest_debug()) { + if (!accel_supports_guest_debug(current_accel())) { error_setg(errp, "gdbstub: current accelerator doesn't " "support guest debugging"); return false; @@ -624,15 +622,6 @@ int gdb_signal_to_target(int sig) * Break/Watch point helpers */ =20 -static bool gdb_supports_guest_debug(void) -{ - const AccelOpsClass *ops =3D cpus_get_accel(); - if (ops->supports_guest_debug) { - return ops->supports_guest_debug(); - } - return false; -} - int gdb_breakpoint_insert(CPUState *cs, int type, vaddr addr, vaddr len) { const AccelOpsClass *ops =3D cpus_get_accel(); diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index 8b902c68829..e16457c3cfb 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -2900,8 +2900,3 @@ void hvf_arch_update_guest_debug(CPUState *cpu) =20 hvf_arch_set_traps(cpu); } - -bool hvf_arch_supports_guest_debug(void) -{ - return true; -} diff --git a/target/arm/whpx/whpx-all.c b/target/arm/whpx/whpx-all.c index 3079c6293c8..00a5de8cdc1 100644 --- a/target/arm/whpx/whpx-all.c +++ b/target/arm/whpx/whpx-all.c @@ -295,11 +295,6 @@ void whpx_translate_cpu_breakpoints( /* Breakpoints aren=E2=80=99t supported on this platform */ } =20 -bool whpx_arch_supports_guest_debug(void)=20 -{ - return false; -} - void whpx_arch_destroy_vcpu(CPUState *cpu) { /* currently empty on Arm */ diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c index 2d1a943b96c..19ad64a1d93 100644 --- a/target/i386/hvf/hvf.c +++ b/target/i386/hvf/hvf.c @@ -1066,8 +1066,3 @@ void hvf_arch_remove_all_hw_breakpoints(void) void hvf_arch_update_guest_debug(CPUState *cpu) { } - -bool hvf_arch_supports_guest_debug(void) -{ - return false; -} diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index 467ac6bed45..11b5d1fc607 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -1853,11 +1853,6 @@ void whpx_apply_breakpoints( } } =20 -bool whpx_arch_supports_guest_debug(void)=20 -{ - return true; -} - void whpx_arch_destroy_vcpu(CPUState *cpu) { X86CPU *x86cpu =3D X86_CPU(cpu); --=20 2.53.0 From nobody Sun Jul 26 11:01:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783345724; cv=none; d=zohomail.com; s=zohoarc; b=ltrMfJOl4NvxtuP4MWfo/mtvZ+4LLv3GyObw+vxJAPHZJAyEbxf2drarapwvz1is+9u8HMd5MYd5lK4L+kiXQzTtACPBRiTnMAN8z0rvKK8WkXkE2gtjH0xl07ZP5Mt//JHf11/0K7NbwLL6sBWaq/snJie4ZrRa4OVXGQCmo1c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783345724; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=f2XEj2PlllcBzQqnMQrbGx7gzvTWdi3R1nv6ZLolQOY=; b=AzeQ4/leI7M1bXXDxwTOL/Xsr1PhokLSn00iwfGGbbrauinlkN+HKt8LUl3hm6unpgzIt+eFMfJgycAnWLCiWWVF9SrTfC1vms8Kf4mSU4fCqfRf/sQ2VDjtR0BCPeoLe/LMRGdqV5EDyMiP71o1UbsVQZ4tHm+ATzEBLgGQ4Q0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783345724828253.20666861750158; Mon, 6 Jul 2026 06:48:44 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgjgX-0003o1-En; Mon, 06 Jul 2026 09:48:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjgW-0003na-KD for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:48:32 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjgV-0006sq-3C for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:48:32 -0400 Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666AxL62218457 for ; Mon, 6 Jul 2026 13:48:30 GMT Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f88hs9cdx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 13:48:30 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92e55f0613cso238179585a.3 for ; Mon, 06 Jul 2026 06:48:29 -0700 (PDT) Received: from localhost.localdomain (1.171.88.92.rev.sfr.net. [92.88.171.1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493ccdb566csm273752335e9.7.2026.07.06.06.48.27 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 06 Jul 2026 06:48:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= f2XEj2PlllcBzQqnMQrbGx7gzvTWdi3R1nv6ZLolQOY=; b=fp7x5SXO9zdnp34X SNKs/0s3KtV8tz2FO7GjaJIPT8uiTCBolPbZ8C+uNTnkcvjgG7EXFqDJhHUFaaGb M97on/dDgWCNxLKIJiQyrWiG938rsBvElv6HuvgDhQ54n4DXmfqkjWN2ji92CCOJ f/yoxC9FgDrqN45+elJ3Aj1rRePjg8UqWzEsMhu3vqnPOnyhv13wi2gcXM99Hyu6 Bwbsy3jphjYrpawP6DdIA0v5t1jjiOUmj19Te3i9YUc/Vqha/TYGt2DC46k7/N70 J3lN8zc50FMNWDehe0RHYrig/u67gQpP7FEcbtOr1bTL39WGe+5excQsfSEKzTmb TFPYIQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783345709; x=1783950509; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=f2XEj2PlllcBzQqnMQrbGx7gzvTWdi3R1nv6ZLolQOY=; b=AKgPcxpIHSO0Da5UnE8uuvLS/yBaqh5BznDFoMu0SXqR5kBhVXRoKu1XLt2mNaW9yQ W0GBNxCt/npMRbynn+wMSNcoKNGW10TvDKUJd6wB/iGtJcXLXrlDZGEKZEaTr4rWajOj BOByhGRbCKJj2KOkSIEmQcuvyOKOvOmGdutqqQiaRsHBZEDc2rQ3bthWVr07dYC3a33c 7cwGox0/ra6oi0uX7Bc1ai4mNHJXLgoLDxz6CR7htr5aip56Bg46oJ3AyQrQpjO/Yire 7b3/X/7s9WXqKGXKCDJEIq6rrytAMTTZrNZUr1tkcqAhhnHrGaHn28SLVJWb+Imxw3/2 c1sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783345709; x=1783950509; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=f2XEj2PlllcBzQqnMQrbGx7gzvTWdi3R1nv6ZLolQOY=; b=AVT/DZhnz/LtLMWRwKZT8bZ2va904SspxIE12oLlezYQK0Y7tM0VElVXU0QgetM8vO 2Sx+gGhYCZg3ADluaiFNAPAkmsdbqDol4rdLbuLknqcAOEwhSPaOIVK5Vd65dUp/nfsd A68u3z3/31przLKLVEThNCeR57HETCvR1Tlvld5gmQ2vBp81sAtaKQkqzKteaIofiLOV EvWmDaRL2r8thL3OIaLNY0KN2MaG78tws8/piittagqItirCPABV8MvOmjb+ODK7XdEy dtT7hWq3kNPzmu2InuJGsiBgng9/C1DSLI2Y4yYN2mEdmFHfHpeEiS15ClBsidY9+zaa KlZA== X-Gm-Message-State: AOJu0YwctG+6byQvxUcvZTdYp2qhjpmWM+O1qgao0l7PHiC8HD4hoHwm sdwVor6MrWdAC1vAZG023wMOL43zCjaWcuyXY+tqSCNgJqMYZ23IvkmxfCfSg0Z+jiUATDs6Nrj QE+nrLcizziLylXJ+wVQ1NOndLAp91IPIX0lUYTv7pCKd9jsF/PRcQiHkijvlbH8ePg== X-Gm-Gg: AfdE7cnCjjcZaS2qQCZJoZtSkC1HfbCeGEq1CMg8a7lmAIf5EBgtkQhqQnp5MobMXeo DCDc4QaVLlr3lgDm4eebMbztQonwkTvPUY3quo/0lCYggrEddT/scjQDYP0/nOHVwNZsEtajZF1 g8ibWH4jduqPYXkSQ12m9I13OiYouNoe50Ivt23SJVMVzBz30tDAR+iajUsg8pA3j4p00jRqCmM ITWdF9txBXO+a8+aU40kfb92TMXik4iitbaALvo+aKiC8Q7dEh/apywucOVcnsVBgkOAsHThBtp 5Q/H5mDr/YexjdxOAwBfAUawNH+K/FfqAyjQdVxzZecUzqWvbtMFohC/Bugq0Jw/wR1Wpo+MpnK TuD/IOjoNgPpGW+LtoFz2sZpsla5nhw3gqZ3XR2jW6x+445IfvPr/reUjbw== X-Received: by 2002:a05:620a:701a:b0:92e:6858:2ed1 with SMTP id af79cd13be357-92ebb58ecf8mr86669385a.53.1783345709384; Mon, 06 Jul 2026 06:48:29 -0700 (PDT) X-Received: by 2002:a05:620a:701a:b0:92e:6858:2ed1 with SMTP id af79cd13be357-92ebb58ecf8mr86663585a.53.1783345708632; Mon, 06 Jul 2026 06:48:28 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 19/32] cpu: Move cpu_breakpoint_test out of line Date: Mon, 6 Jul 2026 15:45:14 +0200 Message-ID: <20260706134527.84808-20-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706134527.84808-1-philmd@oss.qualcomm.com> References: <20260706134527.84808-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: r0B5-wJf75JVIpplbeoZ2HQtDRHEOC7y X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfX5dkmkygSKyaD KahXRzQa0uHop3gsLSS76bKDB95SZtGkGqOGBoN8qqKTZfubcvSEZ312VJpVC/rwfisk70KxbPQ pMD5rLsic/3iewKPeKzXi11BJPAz3pqSfPlf4LAwB9ZWe8H9xxU7FiCreN9972HYsG3ruuUB9+e Am/NkCbKAKN/K162L47HH3z0qCslglexPxZcFUFrcAmIIDtn/gYBW9xsNQR93OE4kXTa3fjs4Y3 dPrs9tDKyauopCcsv8rCZJ84YvLCqqe7Q34rKIf3BCJhzzJXRiFTt4VBMTdINYhnXnmKpRnh7yq 5clhVP7sBfIE9dOZBX5naVqg73HUBmV2VQAFn7SKJWNsFd7Eb+GZTsgcQGYDjm2T39InZXt0FM9 acOaL5WbvzrZ/2ne6KaHbAf/SX7AAJasV09Os1kVcgsOH9aTeEfI2JQnlDS1xtN2u5gb185aos9 uHVsxMHtXQb1O10STKg== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfX8dtPaIqYiB+T VBRP1nMtG9Airc7Wl85kMSBwKOqHQPDfpY+oYhwqB4bnIVZwzEroSN+mgldWhrOsK8UG6v5x6yR 7FYsZvXUEF7iXB5Sty8E3Zk6t67AR58= X-Authority-Analysis: v=2.4 cv=XIwAjwhE c=1 sm=1 tr=0 ts=6a4bb22e cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=PLEY+c9/kVlxBKEpvFYBUQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=f0gnTpezwqI1Ju9rGxMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: r0B5-wJf75JVIpplbeoZ2HQtDRHEOC7y X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 bulkscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060141 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783345725902158500 From: Richard Henderson Move the function to cpu-common.c, with the other breakpoint functions. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20260705215729.62196-19-philmd@oss.qualcomm.com> --- include/hw/core/cpu.h | 16 +--------------- cpu-common.c | 15 +++++++++++++++ 2 files changed, 16 insertions(+), 15 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 60a23d6f38b..31753f331fb 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -1157,21 +1157,7 @@ int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, i= nt flags, int cpu_breakpoint_remove(CPUState *cpu, vaddr pc, int flags); void cpu_breakpoint_remove_by_ref(CPUState *cpu, CPUBreakpoint *breakpoint= ); void cpu_breakpoint_remove_all(CPUState *cpu, int mask); - -/* Return true if PC matches an installed breakpoint. */ -static inline bool cpu_breakpoint_test(CPUState *cpu, vaddr pc, int mask) -{ - CPUBreakpoint *bp; - - if (unlikely(!QTAILQ_EMPTY(&cpu->breakpoints))) { - QTAILQ_FOREACH(bp, &cpu->breakpoints, entry) { - if (bp->pc =3D=3D pc && (bp->flags & mask)) { - return true; - } - } - } - return false; -} +bool cpu_breakpoint_test(CPUState *cpu, vaddr pc, int mask); =20 /** * cpu_get_address_space: diff --git a/cpu-common.c b/cpu-common.c index 988d057d844..adb76b3a786 100644 --- a/cpu-common.c +++ b/cpu-common.c @@ -388,6 +388,21 @@ void process_queued_cpu_work(CPUState *cpu) qemu_cond_broadcast(&qemu_work_cond); } =20 +/* Return true if PC matches an installed breakpoint. */ +bool cpu_breakpoint_test(CPUState *cpu, vaddr pc, int mask) +{ + CPUBreakpoint *bp; + + if (unlikely(!QTAILQ_EMPTY(&cpu->breakpoints))) { + QTAILQ_FOREACH(bp, &cpu->breakpoints, entry) { + if (bp->pc =3D=3D pc && (bp->flags & mask)) { + return true; + } + } + } + return false; +} + /* Add a breakpoint. */ int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, int flags, CPUBreakpoint **breakpoint) --=20 2.53.0 From nobody Sun Jul 26 11:01:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783345733; cv=none; d=zohomail.com; s=zohoarc; b=nBEA/jrGvA5GbujY4EUAYvPm57x0u8XMZd1C3BnidJ7aeFPP0T0NYj2GR2BqHcXB70GcLUqEgUzF3KkTq4fRbPwLzPZZH4CaalE0nCuQcEp9Kp4DqekQhT2xgIcZkmA3k/vhxZiHKJW98Yf+KYXFR2JdThjH4pvO1TeoH/F70Qs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783345733; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=A0O3Do8cLpQEuezC0KActk8gus15oyWkrKJ8LmcCGs0=; b=D4650aWsz0EUMVRcElewFQke5RjEwALx2oOiR1g4Pbc4I8YwoHvdK3y8GFgOXC9IkYY+dSlgobd2hGkG2TRkAMm+QIn2X/eSg020ykX8MajjWCuH4FwbbSU0bv/ycdj+KSJh7N9LZbVa0F9gK+/ompDtteRR0CTv0AjJHnIgUIw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783345733344673.4077094037923; Mon, 6 Jul 2026 06:48:53 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgjgk-0004PI-FX; Mon, 06 Jul 2026 09:48:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjgh-0004Ix-3U for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:48:43 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjgf-0006vD-0p for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:48:42 -0400 Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666Ax69V391044 for ; Mon, 6 Jul 2026 13:48:39 GMT Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f89kgs1hq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 13:48:39 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92e59b0e0f4so229854985a.1 for ; Mon, 06 Jul 2026 06:48:39 -0700 (PDT) Received: from localhost.localdomain (1.171.88.92.rev.sfr.net. [92.88.171.1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa039ae4fsm25734267f8f.18.2026.07.06.06.48.36 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 06 Jul 2026 06:48:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= A0O3Do8cLpQEuezC0KActk8gus15oyWkrKJ8LmcCGs0=; b=UffN+pnuyXoiHHYp c67xVt2Xsx4jiSBYYGDTetQxkkaUt6000ggAYhhX3d9L+1nSZjvPBtpb7GzvabTM Oj77BO6rWBz92l63Qrj+8Yyv6z9Vv7p4xEZguvNg8pkXi7yZHDK6V4Dh9V7+Z3pz QuZvhMhK00+HRn/1YTrrgA/+GYxak4clr9PJnR4r40lhlkCEzCl/NCfwlP0YX1Lx elO/9REVhu9cjQesxMlupUhqq85VsV8hJoYcXdHQ4ZUmtWAESpdUqS1xPRPhgx/P Le52eCvCxUBGC1yL8TSFoRRPc4U/0HP9vYnseya/+aiEPhK1Ao5beBm2JV52MK9x rlN6QA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783345719; x=1783950519; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=A0O3Do8cLpQEuezC0KActk8gus15oyWkrKJ8LmcCGs0=; b=N7KxekliJZhADTtfCw1axQ/iviODIaOshcECPdeS445UzyEmasJ/RT6SCUv8ezwwxo v+9G+N4W/zshMT6cLHP5HfHC5c2oz8/En2JTP9pyUJvPUmtcjArbX1tn/5wALPDigjKX iH53Pq6Bsn+0bRkLQeCbhvp+KDdks+VFi02kHyOwrg7/8QMXQDbhBu6THVClcDMfHKT0 YGPBOiUsm/Xj2g0bm8N0MdMnkJZ0Ksgj6rOFYbS9rqx3UCWoZGCVybiBqbkvjS6lMLJH 9NHsHu3BIyZDJ27rNMfU0PP4pFvUSFIU5ePDO8AfzDUHpPVgHO/4AbjpiapagYiPn1Xb jVJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783345719; x=1783950519; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=A0O3Do8cLpQEuezC0KActk8gus15oyWkrKJ8LmcCGs0=; b=eLS1F4z87e4dAcojQ1p2F+vfeZmBJHuShIC1nDx9OLEj43hFXu36ZhLeWSDuA6+Xm0 wnV5AvHay+BUuH6B6MpuM8ZEoXgTHpLf7zfgZV1p5HXD8p3aBs6gIPbizJ9Pzw1zLiu5 /JcvmVP5m5UHbsS54KYXGR9/e+jvLt+KCLtj2TxahhpxQK2r+xAU3eFL67AJO29VXKtt KULTmkGq7GmX3aHFMH1RkcvB9t9v/9VPxAvAdGl/9idjzMPEHPjXlsTNCr8aE4EVdq4Y VPRyW6LcY62KwMyPBcBaIjveBDoDFLDThn60wQCLVz81ImmF6HZ+9rm/Y4XT081CIyOp L2YQ== X-Gm-Message-State: AOJu0Yw1/05uKf+57CTcW4UFFix+k+XHNDgtESirmHKrqrlIaIo53yiY 9NFhJQSC362EXHyW98fW4j6xvm76F0fhjiw5LAT0FmmpSDYAQYIGxk0c6JRcIU3DzTfw7BxTmxX fGUoYUQ85n20BdTYLKCST01sy5/plP8P2CETg1Gjil12/JgQoH6pKNv6++1M/U/sGvA== X-Gm-Gg: AfdE7clYub2HWoS7v/jbpNkehuDKZE+S2jpdf/v1PuOWayv+7UWxgICTq35p7GwTGLk 2VLHmbdFsOw/HAq/7PvKM1hjfttdQr5UFsVVWECXKMRxG3lM2TDriChRV16/1aKDKaK9VGgeeh+ zfK+8YiOh7epulsM79E5GcblIOsH5lftOgD7WSHW09kLyOIxGrmLa6+osGynuu8E8m9TegJXdw/ X7wQ4nAEH9lD1wsMaw85Ji1D9On5TuJlE2JUz4Lj3tHWIy06LPrlFQCBhfp6Eh4tJGIxcW7BXdK WSIKyl0geELYOmaxc8GYgtP9IkDAhLA3HPaXp/QXrYUVzSjXV5+LAduOvCWDckedexhcoD+8ETu BrlN3a0NztQvRlt3wHBZh69J6Nz7zZZtHvJEFQXgqAYByRdnwnjU3Z41bag== X-Received: by 2002:a05:620a:40c3:b0:927:620f:d0b0 with SMTP id af79cd13be357-92ebb5680camr90861885a.22.1783345718447; Mon, 06 Jul 2026 06:48:38 -0700 (PDT) X-Received: by 2002:a05:620a:40c3:b0:927:620f:d0b0 with SMTP id af79cd13be357-92ebb5680camr90856785a.22.1783345717837; Mon, 06 Jul 2026 06:48:37 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 20/32] cpu: Move BREAKPOINT definitions to 'exec/breakpoint.h' Date: Mon, 6 Jul 2026 15:45:15 +0200 Message-ID: <20260706134527.84808-21-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706134527.84808-1-philmd@oss.qualcomm.com> References: <20260706134527.84808-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: ndwHoT8t69LHJY4Y9UqVe8STfqSNwuS6 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfX1ICSwMUNm/vd 64laNS47kAvh/k1bT00sY+XDd7TNfclHQ1nqAJlOw153IGnm/Rm1TlvkUPINfinf906igpA3XX4 GrWgzpubLjATfcwYyEv+97sA0NQ5v6WOugGhFNnoLyNhEwfmAZJ7BFligIh4QRjCLNL88H1J32X kKyoYbcLgEcUeGfMV6rN5z7CF/wjYCmyhb9zdpGtD/OctZPGCUmhfQgrPBTaISdvjicYoVpCwxO 1iTPeFX0X1ktcMWme0Dbh67nZIizd+aeYNuml6j2SvnBAjv1Z+CgAiuewHGn9g7K3t1kfrmqrhE SQghXtLkQeCyJ9zFj80XGnLCJ8fptK2Kh/OU5K+waj2ugKDWzL9Dv640Ldmg2PSNerFx5mxIvR/ uLZFwe+SGVE+8H3h/3ZxpcHNuLuiUgimqDJ3ld+nrvNZCfkqqmphmSRZloeom8Sq9IfDrY55GcL IvoCboBF7T05iVwL6gg== X-Proofpoint-ORIG-GUID: ndwHoT8t69LHJY4Y9UqVe8STfqSNwuS6 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfX0SUbrgA6Jpw3 64zEMSbD0Yey6vSr7Z0v0DiJxi5ymLOD6m144MEXVCoh39U0TIfA1/qk6VQwFyAZEXJq3REa9v0 +gLV2AnynvDDFY2ULUY4SiybCfEp3mk= X-Authority-Analysis: v=2.4 cv=c6Sbhx9l c=1 sm=1 tr=0 ts=6a4bb237 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=PLEY+c9/kVlxBKEpvFYBUQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=yZPQLu4l72ctXTxYlJYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 clxscore=1015 adultscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060141 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783345733925158500 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson Message-ID: <20260705215729.62196-20-philmd@oss.qualcomm.com> --- include/exec/breakpoint.h | 14 ++++++++++++++ include/hw/core/cpu.h | 14 -------------- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/include/exec/breakpoint.h b/include/exec/breakpoint.h index 95f0482e6d0..cc6fedd09fe 100644 --- a/include/exec/breakpoint.h +++ b/include/exec/breakpoint.h @@ -12,6 +12,20 @@ #include "exec/vaddr.h" #include "exec/memattrs.h" =20 +/* Breakpoint/watchpoint flags */ +#define BP_MEM_READ 0x01 +#define BP_MEM_WRITE 0x02 +#define BP_MEM_ACCESS (BP_MEM_READ | BP_MEM_WRITE) +#define BP_STOP_BEFORE_ACCESS 0x04 +/* 0x08 currently unused */ +#define BP_GDB 0x10 +#define BP_CPU 0x20 +#define BP_ANY (BP_GDB | BP_CPU) +#define BP_HIT_SHIFT 6 +#define BP_WATCHPOINT_HIT_READ (BP_MEM_READ << BP_HIT_SHIFT) +#define BP_WATCHPOINT_HIT_WRITE (BP_MEM_WRITE << BP_HIT_SHIFT) +#define BP_WATCHPOINT_HIT (BP_MEM_ACCESS << BP_HIT_SHIFT) + typedef struct CPUBreakpoint { vaddr pc; int flags; /* BP_* */ diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 31753f331fb..e5b68bced3d 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -1138,20 +1138,6 @@ void qemu_init_vcpu(CPUState *cpu); */ void cpu_single_step(CPUState *cpu, int enabled); =20 -/* Breakpoint/watchpoint flags */ -#define BP_MEM_READ 0x01 -#define BP_MEM_WRITE 0x02 -#define BP_MEM_ACCESS (BP_MEM_READ | BP_MEM_WRITE) -#define BP_STOP_BEFORE_ACCESS 0x04 -/* 0x08 currently unused */ -#define BP_GDB 0x10 -#define BP_CPU 0x20 -#define BP_ANY (BP_GDB | BP_CPU) -#define BP_HIT_SHIFT 6 -#define BP_WATCHPOINT_HIT_READ (BP_MEM_READ << BP_HIT_SHIFT) -#define BP_WATCHPOINT_HIT_WRITE (BP_MEM_WRITE << BP_HIT_SHIFT) -#define BP_WATCHPOINT_HIT (BP_MEM_ACCESS << BP_HIT_SHIFT) - int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, int flags, CPUBreakpoint **breakpoint); int cpu_breakpoint_remove(CPUState *cpu, vaddr pc, int flags); --=20 2.53.0 From nobody Sun Jul 26 11:01:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783345739; cv=none; d=zohomail.com; s=zohoarc; b=D05dFdJVqIwWXM3uTjHZCs+52l3SONKZ4Bl6cakXEGhjdYLKQcJgdLyb0GB1tmd2Po+LZ4X+4tWks1mmVZZwwJ/hM97zQcY2PEduU7FRGHsfq06lny/xlYyQ4duBqtqdh+o+bEk7TT1ET4NNcqH2hAcHWGsuGTzd1wuDeMYsZl8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783345739; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=JWKui+psW7jN2NrTTr/B6Utcfax1vmqny1Trqz6686w=; b=JSNhifPOu4FpT8YuZS569tbBgQxfkKHOL+5m8feNhdJCwQbWeSV8dzL+KcCJ4iJUtR2scx8uAoTIB2wZcsPCJLA3H86Jza+509HRXlbG4Rs9ba5y15VSozqcUNCgLNQ/dji9ygW2Ed8tTfsV1aqGGlH59BdSumDNQZZvz+9gRrY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783345739334640.8778732319155; Mon, 6 Jul 2026 06:48:59 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgjgs-0004wM-4v; Mon, 06 Jul 2026 09:48:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjgp-0004mf-IM for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:48:51 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjgn-0006xu-U8 for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:48:51 -0400 Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666AxEZY366750 for ; Mon, 6 Jul 2026 13:48:48 GMT Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f891us6nt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 13:48:48 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e68cb7a3eso564985885a.2 for ; Mon, 06 Jul 2026 06:48:48 -0700 (PDT) Received: from localhost.localdomain (1.171.88.92.rev.sfr.net. [92.88.171.1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa039ad21sm24746903f8f.20.2026.07.06.06.48.45 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 06 Jul 2026 06:48:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= JWKui+psW7jN2NrTTr/B6Utcfax1vmqny1Trqz6686w=; b=H8J9Fxch+Cvv8/Aa UcSeNJ11cAtVCb1miYNXE9lG2BAut83kagAwx9gcT4PXpilzjmXgzTPj7IBoyBW4 jwYGHaHfrQv7b8W10+qHqztPnjWBxUG+6qacYPGrBmCprCB4Uk44cIPMH3AXFOUV XrBmjvG99qxjwHSHsyJPRwsD/cdHlBCl4fmWXscy9lMi1L6ud6KFV3oMQBR86LY7 CLITljhYfN3uISkBsIblfpaUNIL6JgUrOCC2rAbArBiDyrEh2Rc/4v9qjodobuuw aS043ZUX9/3jNDxJ2EVZiQP/qaaBzOBbJ3bAirj5gjzmo65PbnDB2LSlsyqe4mOZ 9mwASw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783345727; x=1783950527; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=JWKui+psW7jN2NrTTr/B6Utcfax1vmqny1Trqz6686w=; b=LK4Hly6oFDBlfvprN/g6LcrlJEWGyfFE7HnXKQINJXEzYpsRuS6ruq37ofuQF2omJ5 KZ/0dAMIy3Rw/YzCagVyfeJW96W0rEFeIu4ZEi1gwhllrTaIOk1D1i2/VI+pbPFnKzKE vqVuTyyJ30DUSDndERewwaUoSNi3oCXs9drscCw4RuqTdhY4+ed2bt2KviUReuyX3nEN oJYIW4uR4mtJ3pmrsBHgmHiKN68IhUx36SYS1y6cLsflrzeNF/5PhyA/dd2GQqPQnPKY AVSGBsRC77rNKUwkI78wdoAj5qEt/I9MiyOBZ61r8LkWpqfjXs5o76AGxT5QTzHC7cE2 ZLkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783345727; x=1783950527; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=JWKui+psW7jN2NrTTr/B6Utcfax1vmqny1Trqz6686w=; b=HYU1CRn72IVx3xyevy19wJdeOI1bKYg4Xwe98QQwRdBU1McfV5N+eGm6zDK4px8CUP ANEfpy4R7z1KgHfJsAY/MeM9HNTAqlwWDKhuprPqyNIWLT+4XcjXyEBrOmSU6ZO8lPde lZ5dEqr3XbWIpVtkYjw0esrUKXjLCAa/rtbhAbjbjUCbnhXqcLVA+Yt9wnzcnlGsPKuj KaNh2AxTPrPfAacvIiUvFG31Xk0DXAIfYia6mYllblsz8mSnByTbDgGlC+FilIfqd6al RXIRjwlbTCcLqMDhcERrTGnS2cK9+AI+9eY2CD6WLWecg3D/4HcU9cfipluzd43ctK5R pvdw== X-Gm-Message-State: AOJu0Yxu5K1dkUPnZK2wxXFgrRbl0CWD5TWvTrQgGTLWS7xEa7Aa0FWW gdg/hXHn62vxPmEhgC6Za95RN1fMZJ6/R+5yrI/oGbVH9K2i2jDLgZSWEPJP5S5+cGc3+7j//IB nLdIey6IGrtLfcyGaggsS4mp9ntAAGdRlxOXxn8ileb7zZArqIdD5Ac3Yudhm5Dt5GQ== X-Gm-Gg: AfdE7cn4n8pD7OVwvP2Qt8a3JGhI99RhvSCsVlna/9zG46lGb5Ofl9YfbyFahyA/rZW p7oJHoWBx0/WXd3tVQvOtGAh/pWpkY9pvZJlCuIUZHpK7SB54bXrE/TTcXzISvBhVOVtbwuci5M gf4NnkH4OeJqqWH8iu7x5Mhp9oJcQ3qd8XZ2f+fUSxmzy/+L32G1Cqi1jwlyf01leIqgJwzeGjl yv/oCj/WE0oDAemB6emUQ+V+5pbAN3YpITSCTJ7MevPJdCX8GruKHKYcSfd8a6sGaLnl1/2nV0T Srk60PgYtte3HTCUpwHFia3NzsYZFpGVAZxXnKTg7syJz9MM5eZFhByI3/F1yRUQ0YJv88P7vx/ wEJtZz706r6jChj906+Ew4M15nY3J/6QIBNwpqVTG5RbgSkWqKqKjyaj8Dw== X-Received: by 2002:a05:620a:684a:b0:92e:57ec:a4d7 with SMTP id af79cd13be357-92ebb5c05a1mr81009285a.73.1783345727481; Mon, 06 Jul 2026 06:48:47 -0700 (PDT) X-Received: by 2002:a05:620a:684a:b0:92e:57ec:a4d7 with SMTP id af79cd13be357-92ebb5c05a1mr81003785a.73.1783345726820; Mon, 06 Jul 2026 06:48:46 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 21/32] accel: Remove unnecessary 'inline' qualifier in remove_all_breakpoints Date: Mon, 6 Jul 2026 15:45:16 +0200 Message-ID: <20260706134527.84808-22-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706134527.84808-1-philmd@oss.qualcomm.com> References: <20260706134527.84808-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: 5XLK7vvC71xp0Kt3b6sgOWEQpdK8G-XX X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfX8Kcxa1Yfsxr7 EaAyj4P+1Ec7+4vxeAK+q0fl9/HJ6Yj/bc12V+1pTpgFdlNSpf48oicGKkTEpNhaRVnjJHv7exG 6xHcy37WXHzh8yMTEPvDj5FLYylFs7I= X-Authority-Analysis: v=2.4 cv=Mo1iLWae c=1 sm=1 tr=0 ts=6a4bb240 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=PLEY+c9/kVlxBKEpvFYBUQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=Ucb4Co1tYGy3ov5cU_AA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfXw9i4IrDGAo67 8K2jWo0NB8L20CCnStmu7VaUo4kfGnPQkcbyg9pGdwpw3LpepyXPNtnNiewur6ecvAOjHfqaD6O 6UfcCR1kfFeWzRzmmYKpRzDW33DS1RbD3w0R3gT6xLig35e72wvwlW0adh/oW/SS3oUuF6K3E2u cUNHno8xhCoYT+BaO9bXpjfNX0XK2zg4dJQYnEXEW2FtNiVZpW8NkNrteF9pv5Z8/Sm8ZsXBkwE B427lbnFagVIpUJs/49HzKdL/qnizqGTXhmVEopzhdr0noVocJvZ4qBF2zcHukjf4joQ7NSNUsq 7I0rGgD4JmVHSsuVfq83hwmP7aZnYR6dRY0ol1A3t63v4mBxCeIq5nY08YRTU2NwfdFK5c/CW1w S9CxQFX2JWa1UR9HD+moyKnn+/NCzWv3A0zoKSSgUMX/KSC0q10waJFZwdT5oRU4R8JZ/cq59+k G6zdcqxeGJ2sns11uzw== X-Proofpoint-ORIG-GUID: 5XLK7vvC71xp0Kt3b6sgOWEQpdK8G-XX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 bulkscore=0 adultscore=0 priorityscore=1501 suspectscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060141 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783345739940158500 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson Message-ID: <20260705215729.62196-22-philmd@oss.qualcomm.com> --- accel/tcg/tcg-accel-ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/tcg/tcg-accel-ops.c b/accel/tcg/tcg-accel-ops.c index 927af6c1db0..1043fc61874 100644 --- a/accel/tcg/tcg-accel-ops.c +++ b/accel/tcg/tcg-accel-ops.c @@ -188,7 +188,7 @@ static int tcg_remove_breakpoint(CPUState *cs, int type= , vaddr addr, vaddr len) } } =20 -static inline void tcg_remove_all_breakpoints(CPUState *cpu) +static void tcg_remove_all_breakpoints(CPUState *cpu) { cpu_breakpoint_remove_all(cpu, BP_GDB); cpu_watchpoint_remove_all(cpu, BP_GDB); --=20 2.53.0 From nobody Sun Jul 26 11:01:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783345742; cv=none; d=zohomail.com; s=zohoarc; b=mZA23YI+C0Bpn0OPXn+gNoUoPbZ+JYgK4RHv1mAd8RhEX6pA7bHJnzSYLnpBWsoLktTJxOIXZ7cvvTEnx27BGLqnaHxMv/eoHfNWC2kfDZ6medfMTUevS9MKl5p2MM0q8fsW1z57Co1NoZI7PM4dZxC+r3UW6APwvqcMPJ0wDGU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783345742; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=ezeLT7Aa/ivxmDquoUgoQqlFhX4EdGQYaOxRI/LK0QM=; b=Qd6itMDdAS2KF/l8T9aaLJdQydl6i93zmEtbxez35mc6mo8wULEkiEJg4ED6SROMfQbLBD7ANijcbcuTweVdTIr7r0+CP9FAcDYxwz+bYTz0PtPnt+VLbpxr4JbElLUcNz4GfIlVmPgILZ1aWRbhNdzzCh+jiVw+G1JT9e8nyTY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783345742261235.18054832418125; Mon, 6 Jul 2026 06:49:02 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgjgy-000571-4b; Mon, 06 Jul 2026 09:49:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjgx-00055w-AW for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:48:59 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjgv-00070L-SJ for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:48:59 -0400 Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666AxM44218465 for ; Mon, 6 Jul 2026 13:48:57 GMT Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f88hs9cfr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 13:48:56 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92d1cae5740so351251585a.0 for ; Mon, 06 Jul 2026 06:48:56 -0700 (PDT) Received: from localhost.localdomain (1.171.88.92.rev.sfr.net. [92.88.171.1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493cfb6f199sm261861475e9.3.2026.07.06.06.48.54 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 06 Jul 2026 06:48:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ezeLT7Aa/ivxmDquoUgoQqlFhX4EdGQYaOxRI/LK0QM=; b=kzMFlwvbvlcxPeef Xc0lv7SUdCCaRatqKX/KLYRU8cOavylDMYX+ME5h1OB3o5K4PLYxijvjbC50H1lB SISpi1/8eYiBfHjLo5Lgj3UAN398oqRjJVI6WtZQC0DITNXIayLPGV4y6V1GhrjJ GJrJOMgk1CCT9Zr2fili6ozJ0BShQavaS+CTavKCHkFfhZafVFSU9IcrxteqYL8Z 2uaBUCAcminVHJC3M4FPMkkZhUGXoCsgj1mPlTDkoDCEQ5p6qBiS04yEuQirzCaX YWW8q6u4tztETXEZ9w6d160VA67xov0yuISQ6C8KnmK9jJ675PULiU9ygnArKvQg /Oj9lQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783345736; x=1783950536; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=ezeLT7Aa/ivxmDquoUgoQqlFhX4EdGQYaOxRI/LK0QM=; b=Jtn1FAyqESJ1pUm+g2SBKc0N15hOhoMWP+3zK90sNOCfAghENu9P68ihaWIL3r/73a uVWzFaXK+PRCyry7E4iuKjGqVv0JjCoZo73SfkFpfnsVo4DToz1jSw5nUeUzG8rz/OUo 78gjlXZKAf0VM7pgec0o6hA5NEtyl8BCFF7qwipez2EOkHVEoedE3UlmPqJ8s6X3f5sh /tqi5Y6j0SIW9NgEJAJcBduJaZdA2CxcxlMPtoyPG2D3+2F+jy9AXXNSUwtciWBOBEej RqjQVkbUrll2tIfOwPHA9NpmUowVDVvaxIciCyZQemtqSHZfE/34jR/ABDBE9i0QeIc1 qQaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783345736; x=1783950536; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ezeLT7Aa/ivxmDquoUgoQqlFhX4EdGQYaOxRI/LK0QM=; b=BmbDvIGBu/LZkqN6zJM8vkxv5vYdFKopbXUhF5L+bNIv3qzoeYqzyhcovzo4TNANT/ p77vsPwxpeo7Fs0rfOYJ3G7roHy8a8iEbUPZwkFVep/UTWDr7OrBNIBJ0z+pHIld3c25 qbpEQT3atrtQFpt+TwI7YJvg8YUceV3iVwbUGIufc/1MIZAT8kM9i0d9kVgsRrvu1tjR TVvhaLlJxByYSTtRxWuCLNLHmTAFuWbn3QDXYLKRg7I46Zf8BBDP66vebb4dbWHVWQmo +aWLxKU2bbSCkD0TXMyQwhqVAwl/XMn1fWCsEIUTT0pmAvKhgtXndDeJHyUsNDzh69tn r5dw== X-Gm-Message-State: AOJu0YwuUwh8sxfN1JWwDDZCSkgVzhK0iDC+jZs1UJ5TG2EgX6T+TCwP I8jAVh17dsNNNw2AqPDLb/buw6jH9tIpyTHc+Ek+MdeP2JybwIgt5no0NA7tfcvajBc2LXMtzxW BDALy76hDOClyHMz/1rtwH2+Y2ibXHWvmjYWkK1oc5Sy5PrO/U0Qcb3gafLKtuTWxiw== X-Gm-Gg: AfdE7clT2SMcKEwqwHr4meZ0KylCkS/9boN5EtTBiqa8jZE63MG2x2MkA3DyC+nG1FD fvbZrD5QpuNKHnzpmR+Y93InrTz2l+atwoBeghxTzY6Is2dyIy9/WhBl+z5YDAAviQWeBSv8FgE mHU+RlxuE8h4mT8kMK9QGpSH5JsusgFj3lS2xtiqzHKFaV13DdNjcJTtSitHpbLpRTn4WCaq7Cf 5IcYqij23hS6hNg6lH1GU1BYvmGNSCrpdgDoyWjh9F1rr54LSp4eoUP11HXv9PYqdFEGRAi3Abc L7doyvRZRLc6ubrhVxmkJnQemruqB3yXXMbTr74dR3CRUtOLvJ15dz2hc4cgYkIVSH4DVqawAhn JYB2tZ2X/Mjs8CAnwhJXnjeVsL8oSft+KBvG8rHSaXLegQcXHApU6AbKrrg== X-Received: by 2002:a05:620a:1a0b:b0:92e:76a1:96d3 with SMTP id af79cd13be357-92ebb5e23d0mr77959885a.34.1783345736215; Mon, 06 Jul 2026 06:48:56 -0700 (PDT) X-Received: by 2002:a05:620a:1a0b:b0:92e:76a1:96d3 with SMTP id af79cd13be357-92ebb5e23d0mr77954285a.34.1783345735474; Mon, 06 Jul 2026 06:48:55 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 22/32] gdbstub/user: Directly call gdb_breakpoint_remove_all() in user mode Date: Mon, 6 Jul 2026 15:45:17 +0200 Message-ID: <20260706134527.84808-23-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706134527.84808-1-philmd@oss.qualcomm.com> References: <20260706134527.84808-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: AgLh_rmb3eQ9Ug1ouBgNnWSv-xvC5No3 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfX8ndhkazqgIkI SHcgXiYLUOO7JzCq5ww1MkRx2ifRY649dVcOFJk/vMnJqjRQ7ydjrls60ppqgUVHtWJgNO4azCg OrGC3wYdYZxUXCYayKm9G+3ZLKcEoxHIssk8qLRd9KGSui6ioqsUr1OMs41rlS/vcKAHAVe+fJ1 I1mA5eyVBb8VTLyZ4eSqnLiZQzA7tc3ojYaYaITQJdi2raWAbQH3G40ltro21gpJ0QJRPuOWfx3 QIUxBgJSmlp44wjFF/3EXPAbr4ySxkXjkXNBiHPOrZX03EUDHhHcgLAwX5KiGpRcu+7FFTJEeiT T+IhLbKVP4jdhlUp+rdq8bcSqPhHvSKZ3Dhd3QXUDTNdZqAiekig2rS9YpcjymxW22iAwJRKRsB E+/19HCgatw1dRSPbUiNToI+CUHXxEMrICvsrqlgHWQ/ajKhUGS78MwsnRJZ+3cLE+SIOSsYcG2 anpwLb8PGKmFq4gbZlQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfX8Og3fJpW2MnL kCyW9uiIrp2PCdqA8Ffpeggo1XR7spMV0v1HOzkj1gjqI2zFGAKwi7vT8BgnhwLLzUXUwLtEdUa MvXcUDzzf+FHzacF7P/5bPksWdmvn38= X-Authority-Analysis: v=2.4 cv=XIwAjwhE c=1 sm=1 tr=0 ts=6a4bb248 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=PLEY+c9/kVlxBKEpvFYBUQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=zxLOgqzoZ8asriTz2EMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: AgLh_rmb3eQ9Ug1ouBgNnWSv-xvC5No3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 bulkscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060141 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783345744004158500 No need to deref external methods with unused argument to end up calling a method defined in the same unit file, call it directly. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson Message-ID: <20260705215729.62196-23-philmd@oss.qualcomm.com> --- gdbstub/user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdbstub/user.c b/gdbstub/user.c index 299388b9f71..90d6ee49fb5 100644 --- a/gdbstub/user.c +++ b/gdbstub/user.c @@ -557,7 +557,7 @@ static void disable_gdbstub(CPUState *thread_cpu) close(gdbserver_user_state.fd); gdbserver_user_state.fd =3D -1; CPU_FOREACH(cpu) { - cpu_breakpoint_remove_all(cpu, BP_GDB); + gdb_breakpoint_remove_all(cpu); /* no cpu_watchpoint_remove_all for user-mode */ cpu_single_step(cpu, 0); } --=20 2.53.0 From nobody Sun Jul 26 11:01:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783345767; cv=none; d=zohomail.com; s=zohoarc; b=bXdU1Rnj34BVN6hsX4xGhMbH6Vxivq1/yzZNHWQrMu57MsU46Z7YWtHMqLTZkgBP/bAmZcAjTOx50i/wPFQIYH5q3nf+3uE0DSSFNH+Hn7m2sNbv+B4/4QggqGatVwmjbgYISphkc/L7yileBan3Vta8cc1WNe4SxVYShkYdoOU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783345766; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=7/CNwPThXA5iwRd/mCekZEsKWAHu5BWzhtJdQEGE6bI=; b=A/DkHL0K28S3lkjqUxY5ZVPOHqVNxoEh7MMiVFQiIM8XzLwU6ARzf+ugT1h9DBkrBo573JPNrU5ja3RDZeIbd8D85DOPdQmvvIHYuIy3cdz9V820fAg1CwP6HI1hV4MK2AAXhIx8mmhsQC7uQyji2FQdb+ipTEuPzFSjnLpJxyU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783345766991636.1148972767664; Mon, 6 Jul 2026 06:49:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgjhA-0005VF-5q; Mon, 06 Jul 2026 09:49:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjh6-0005Qn-N5 for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:49:09 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjh5-00070w-86 for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:49:08 -0400 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666AxHXv395393 for ; Mon, 6 Jul 2026 13:49:06 GMT Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f89qph0md-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 13:49:06 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e8004d60eso486739585a.1 for ; Mon, 06 Jul 2026 06:49:06 -0700 (PDT) Received: from localhost.localdomain (1.171.88.92.rev.sfr.net. [92.88.171.1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493bfe7427dsm259610615e9.2.2026.07.06.06.49.03 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 06 Jul 2026 06:49:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7/CNwPThXA5iwRd/mCekZEsKWAHu5BWzhtJdQEGE6bI=; b=Ij7DsglQQoJltJmy SQof4cdRzGJl8uypAxmOVRCuSORqcfp6zZqWsgPCPNVPhLbBu4UKNswj/AzxFf/2 LTtupd6/nliHEQew1j1cjVf7QlNKGrCaPgtZ439KFn+T6yhcSLZSPkC/uCIlGy3S lH8I/GTElTcATa5z4pw/tu5V6qrhs4wd+2ZzilgQtvOECGm2RpK3YFamU1p9KXhk Y2Ng+CmaIyv09QD2tUdDvdaK9FXPRu1/iQRWUOwfJ3AJs8Ri2UIlsS6+edlh/X0v yxS1C9cSCl8F4TVUNWvbcSlluCBpNhHniJfj6wK+cToPbPXPPHM5MCTa1Wzx5p4/ BBXisA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783345745; x=1783950545; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7/CNwPThXA5iwRd/mCekZEsKWAHu5BWzhtJdQEGE6bI=; b=TJ6ZNa5yPBqrChbdwuOIiwm3MzvWyE9A8jIH+LWSREyy9STbuBPEtRq16AIEVol/rD K/CV/zao4FBH03SjY6tfVrz9rRp0CswM1pVPk1TsA3MUt5O0QpDOtZu9jxO7nyg642tG FkMuPd6QXmFCCpVDppAjnV35H05O3MAQjEbcKItNHlMUGSyI1rE8GrGiqKcTyhi008g4 7Fq2MVGUn8VzvzIN/ExHByEuI6Ven8xbBc5Tk2W+hszIKOPtx7jbl9Rb24N7lIk0P42D G3R3p70WxdCQTw6vTmb38I80+ZxQhhGY6gy6iYwzBr/DMucihpI1+8MJHk3G3uX5wd0z oBqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783345745; x=1783950545; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7/CNwPThXA5iwRd/mCekZEsKWAHu5BWzhtJdQEGE6bI=; b=M8c+d97+Fzz+FgHyZgVct20zW0rdF1MTkun35HM7cLvrq8/zw7hLqMlpjAS9WgO6Ls +ZWtg3FvTNzmpMdzA8xnvTI4lSKheO0TkbRJHbWMiCtnaIB/bEJgJd/5+mWErhXQOT7q 9rd2dIjQYDUQhoF59XrrIOzsJjybGKpGwyJTRFH4m3SReDXNlG82ytSB1dWIS+FOi9Xm j5MaZ5V78KoB3CAaUCnrTNaogj2Im6KFjyyTuYMQGs6wijZPznNA6/obdEFCXiOZFgsq bKE60IUu7FlHs5+yMTF5f12bSaj0AqrGUEIIzJfjpEZOaXYAbe8KJXO2WvnCOdLRKVaz 3c9A== X-Gm-Message-State: AOJu0YzV9sUiJe7FGJNFGSE44G1Z84vwtV6Rv+RBoTbtSvorgr33GU6I 4xWkWV2oMFVxIHXbQDZ4FTDA63RhIGww/YMOD2m+hFLSbpRoRquMYKb8+Ft3oogepuotRZIUWjm WK6hn4DGGiMBDZW2fftGgTufPHa3sxUpXYc+fbX67v1z4VMdOxCxNVcApj8CAgInRHA== X-Gm-Gg: AfdE7ck2QE9C1HlBIb234Sq82PahvH1udaPQjYXWgfu8yzAXGNjdT7XbmED8jkG1TA3 0vEK8eBcs9IzomL84l+622GVkBxaKxaCHK8+Zb/kG8gLVAABSi0e30oyeiD+C5F9VaEzFYVoArX zwR5jMrd4AkhgAn3kSnVTT9bBiSg3+GWw55RFJN4tpIBW8ySw4OFN63ZlYo5yDjyIUI47SFPOj5 OXn6/xtF784hG3QwV0P8xI3YDhNp7AqiY+IIAixqqEbZiOLiHkYN71RB+nVSUP7pRv4jAG1kvt1 YZ9Z1mqyIEakV9nD/Uh3w7fVgrMl2Yrsuits3gporj+TlPh2cqzUl3jP4aEQOBxmDaRMCdI1yU2 rjZMsDugdJy+0S67/GMEemHe21EKx6eB+27UovuSmUM5I/Hv0kl8FtQaxfA== X-Received: by 2002:a05:620a:3711:b0:92e:76a1:96cf with SMTP id af79cd13be357-92ebb5db684mr77840885a.39.1783345745536; Mon, 06 Jul 2026 06:49:05 -0700 (PDT) X-Received: by 2002:a05:620a:3711:b0:92e:76a1:96cf with SMTP id af79cd13be357-92ebb5db684mr77835785a.39.1783345744904; Mon, 06 Jul 2026 06:49:04 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 23/32] gdbstub: Reduce @type variable scope Date: Mon, 6 Jul 2026 15:45:18 +0200 Message-ID: <20260706134527.84808-24-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706134527.84808-1-philmd@oss.qualcomm.com> References: <20260706134527.84808-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=c6qbhx9l c=1 sm=1 tr=0 ts=6a4bb252 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=PLEY+c9/kVlxBKEpvFYBUQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=3yY2QiCzES6IJYuWj7AA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: NDmVszaRCSM_XDXU9wCwNJEANxkFNaVH X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfX9VBwbg3y655H h+tz75SxqVojJT0Peff+OuIlmNi9pa8xf0blQFSYM+8bkpV8kXnkfGrqTps45xLaKWwtrbitm9b ZIKunbetz/cnLa6yDwI9bqe+Hl3edB11WXjmVcmXZB5iV7GpmEauB4W6khAdypUMielAbofQoM9 eGT69+07veg5/FB+KyV6Z/F6bw+rYF3kNthaAIzlDq5/4LDBYqFdADRqVzEUj+8tlW1PoITLNUG IS3/wWio7eyBkIjLK4OUOkDMx7q2y/0kURX8eNGLz2d35tKd7nbpvgdcprlCzTX001JQC2qgLR2 GP/kj5FBzHpbnH/APEgFEz19BNPPXZQR2fT/8XpOpoeMJEENp+5xp9xW7H5AxRWh+4SkxMJn9f8 7E5zA9LaxIFlgMe8oywr7T9luRb2rHzuA59RZWFggWuTBcsWkvyxekunK4DtT2kRzg0UYgsGQ7V zPx6fqH/xmpG9FgriDg== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfX4dzMN02cb5UX u1GJxkndJ9ZlH+pgw35DMC1oUsxcKOj6iXXQcf71b/jnXPSzoouHeDQVCrdKRPEM/QIBKaPxseL HQ+G1gra92mSLxjYcwEZQnRq9YVm7V4= X-Proofpoint-GUID: NDmVszaRCSM_XDXU9wCwNJEANxkFNaVH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 impostorscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 clxscore=1015 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060141 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783345768206158500 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson Message-ID: <20260705215729.62196-24-philmd@oss.qualcomm.com> --- gdbstub/system.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gdbstub/system.c b/gdbstub/system.c index bf7aa1ac234..9c4bd8ebcba 100644 --- a/gdbstub/system.c +++ b/gdbstub/system.c @@ -125,7 +125,6 @@ static void gdb_vm_state_change(void *opaque, bool runn= ing, RunState state) CPUState *cpu =3D gdbserver_state.c_cpu; g_autoptr(GString) buf =3D g_string_new(NULL); g_autoptr(GString) tid =3D g_string_new(NULL); - const char *type; int ret; =20 if (running || gdbserver_state.state =3D=3D RS_INACTIVE) { @@ -151,6 +150,8 @@ static void gdb_vm_state_change(void *opaque, bool runn= ing, RunState state) switch (state) { case RUN_STATE_DEBUG: if (cpu->watchpoint_hit) { + const char *type; + switch (cpu->watchpoint_hit->flags & BP_MEM_ACCESS) { case BP_MEM_READ: type =3D "r"; --=20 2.53.0 From nobody Sun Jul 26 11:01:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783345776; cv=none; d=zohomail.com; s=zohoarc; b=JJOxTGRUTrRgk0hcKbBy7rymxiRmVVzsDL1lChftXTaNTdj8vaYH02ZZUmAU+xFiIcBeXvqvfEpoxH8Y+bZB7zqk3D3nLA1BenzzCLz59V5s6cdHv1eTRjhrWR27XJ6LkX8ECzuRkv99VKWvSYwEslaVwXAzv7fZYyd09woBE6M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783345776; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=NspIlLUgF9SndTa4e5c2rmKsjIKQXU8I7T8WHNuuwsc=; b=keu7IQi+Yn3qK2aTqOA/cqGOoZLWx/MieS4Zu6VDz3kekZ+1MCca0p2sCcKGQaP/KfMdMAeLBuTZcCqH5h3MpWszKUKqzC7LRXgP9AtqDyVZLDZD+mgDPiCQjbFae0vxQO3DXGLx/FI+1TP1FQsU1ojEZuljh73f5y4GFjWCS8Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783345776336628.8020971585183; Mon, 6 Jul 2026 06:49:36 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgjhH-0005nT-DA; Mon, 06 Jul 2026 09:49:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjhG-0005jG-6z for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:49:18 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjhE-00072V-Ep for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:49:17 -0400 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666AxTWm361576 for ; Mon, 6 Jul 2026 13:49:15 GMT Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f88h51bg2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 13:49:15 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92e55721a8cso312632685a.1 for ; Mon, 06 Jul 2026 06:49:15 -0700 (PDT) Received: from localhost.localdomain (1.171.88.92.rev.sfr.net. [92.88.171.1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47a9e4d6e4csm23212110f8f.10.2026.07.06.06.49.12 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 06 Jul 2026 06:49:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= NspIlLUgF9SndTa4e5c2rmKsjIKQXU8I7T8WHNuuwsc=; b=Y65HMkYOM85G7a95 FBokLdgI6OYAoZjYx4GwdiiQGNClzOqVbo4gTUpMmFnccNLxmuX3GhGOkVF8LpBF X1cs52vwDn5P15dzzC4s0pQNgKB+Ieq5TLt1RW1mWdV2cdTFnsfxolgtoBZonkVw MwxjNpcj48VoQ6QBoU6exA01G+TuUxSab4DFwJHIJ3MVZNQrBZYG12QAS5EneMqq nqAfyVcXd2GH0Rf+ezCRCXMNqIxX/CZmzCHhvnqTwzSWtCeLSGEEFbznmpDtQ0DC +VwPXbv1VACrYhjo4X8z61si5xaUu+sPgNlCXu3OH3tYNaYLn4p+EngaTkiC4OK7 eURUnA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783345755; x=1783950555; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=NspIlLUgF9SndTa4e5c2rmKsjIKQXU8I7T8WHNuuwsc=; b=iByxWjPUVpPFCIloME6MdzbOUwkMLHtQvWL6g2+i6vjsuIeDfT4Em57UlaVazOBUhs jR98OfbknoGG2yQrqVCcStbRZLQGgTZjMQCtvoujIX4tlPDwY7CpbRJuC7u0gjEMerVo P6arw+MBRLylZrM7W982/VN+Hr+mTmfQtO+PxVQdk3Lo7M4vz6iUwjZUUn7LbU4k6VwM M4XuthnrpbYIBpjnS9Bhu9D1WW1+0oCKD3pPydbgzJiXOrMddl0c090E3ovgoF1YuqTC LmyZ0093IO0+vSi42qP2ofFgvgp8xCL130XslFMcCmQNl18LqgqUq/SllDEfUdujuDY7 11jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783345755; x=1783950555; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=NspIlLUgF9SndTa4e5c2rmKsjIKQXU8I7T8WHNuuwsc=; b=JViGdSTK+vGGzIq8oGFU91XHPxVcbVmtViIB/wqZxZGeUQj8FWMCaJMie9M7ol3jGc mE5Ex95VzDhe9PH1Egq8nqbbvWKAwTf0juG2OVNNBDd4T8EuvDvVWIO9jDfvbanBZnUN FFxmcPx2XTHGQ5RJf3WtchnmNP29t4f96kOLrXwFfPAhkJdEn7ahtMh3q5h6QSnFUZfv iIJTJi7k4ad+LngiWhSDZktp1Ro5GGs0f7gHhZRmzc2S2AogoGTQs+jgqVpPWR8r2bE5 JX6R33rHCDdPpLNawMKiGo3eZRbqqam9usRqQengS1LU61lba3rRzbVNXZPQsZ5azJzc +ISQ== X-Gm-Message-State: AOJu0YxuwHDdfQzMTD8JqiPPug7eUJaQc3LMoqIGrGiraM7Wdn/o+8Ze v8VHjsIdvJtbuB8oUcQvle2ngvzt749YJjQdI3SPpJdZ/mGcsKq+ZuP5LQw2aWpcSZa+r8BRq7O YovqGS2x8XE7MZ/T3bBIuWFCl4NPgixt+sbRNamhcUM5mETuu67CnyTmJVDJXoGx/GQ== X-Gm-Gg: AfdE7cmaff4jBGI2pMv1hE97PUMrCCgu4e48xEcY2IjGkcjBmzml89hyPbCTiQPvpGn vO72Kg5uiyABjaDH7EGR2K6c1wnQdgixQqOUN9m98TMC6HxwnysMnD6nVAWcfmie3KN7X6SzaMF jzm4ad9RCckt6dM3FEzFssOo1iD2djqJ318wvhcdURSXB2R2pPFS1T98rgbi4KYYhlCTYwWz7Kg xnn7DAUBJAd9qlo43NOG6TRmdmoGxRCoyMT/qOKkQQieePjc3H95W7+USsIIUzdY1mx3DBdj91K PCEpxrL/sS1rwT5hLXL8LCBNch2KHBpnru4ndGR22Wk0uIZ/VExCKggGCm9u/bw/tY3nBfBfSi3 YWBCoq7QAFEibmxlrA/nwLe9BG+HUMniK1uMmnna+DLkXTzkYHHXXlZpWhQ== X-Received: by 2002:a05:620a:4588:b0:92b:6805:91a6 with SMTP id af79cd13be357-92ebb5b4a9cmr88390485a.62.1783345754581; Mon, 06 Jul 2026 06:49:14 -0700 (PDT) X-Received: by 2002:a05:620a:4588:b0:92b:6805:91a6 with SMTP id af79cd13be357-92ebb5b4a9cmr88385885a.62.1783345754009; Mon, 06 Jul 2026 06:49:14 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 24/32] gdbstub: Introduce GdbBreakpointType enumerator Date: Mon, 6 Jul 2026 15:45:19 +0200 Message-ID: <20260706134527.84808-25-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706134527.84808-1-philmd@oss.qualcomm.com> References: <20260706134527.84808-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: _RYl2cMLREB80vDo0Q5VShpe5l2lF1nl X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfX5Xp8DFJY3q1E QcMtDeiz1PGJifcT2t6LB2RJCQ1l4lUetK257VOvS3sY475/FneiDECSUthd2uOmx5PjWyBoIDp KvOaI0MvPrca6tMMARiASDmSbhtHA9o= X-Authority-Analysis: v=2.4 cv=EPU2FVZC c=1 sm=1 tr=0 ts=6a4bb25b cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=PLEY+c9/kVlxBKEpvFYBUQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=z_0bWbdd-CfuK1dINPUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfX2GMT+pu/2f5S zTGbCfdtGntdPWWV2puyLHq+j0Qo+RXQnPfd3PqASEwyFvfli/ai1/YAa7Izlip5a98/+wVfu5W 2XbdNUk6uz5ynNmfu0YwXkHBiewjGCjzB220S7VC8e5WIFLGfHWTKnnUmCdTfDKSibURcebpI7j Q/4UoCsMj3Yi2AKqlAbmm+Qhbi+LPsJwGiIST/8gBLjKaUFVFytbDUcwtrROj7nuQCX+vzN62xH H4eekok/rctyhj5iSO/ukcsO5JSuM+fN0PRRQVGY/pSvhDY18rS3iHAzZbby6SygohOoxnyvAq7 A1qUX2IarnfXxZfQ3pmwxLXf9rS0YX8yikCc239QpRvuLF1Nsc6L/pXvRh4rDDuBCoQvE7X9Mig Nis/oKhtjb5WPbsJtqgdsNnJzlWO071NSnbySapCbcUyV6N0VKB9jLU/R3CuUz/zdkzMCM1uj3w VELckJyzBUqwZ9RJQ5A== X-Proofpoint-ORIG-GUID: _RYl2cMLREB80vDo0Q5VShpe5l2lF1nl X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 malwarescore=0 spamscore=0 adultscore=0 suspectscore=0 phishscore=0 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060141 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783345778282158500 Introduce the GdbBreakpointType enumerator to better follow code related to GDB protocol handling. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson Message-ID: <20260705215729.62196-25-philmd@oss.qualcomm.com> --- gdbstub/internals.h | 7 +++++-- include/gdbstub/enums.h | 12 +++++++----- gdbstub/system.c | 6 ++++-- gdbstub/user.c | 6 ++++-- 4 files changed, 20 insertions(+), 11 deletions(-) diff --git a/gdbstub/internals.h b/gdbstub/internals.h index 0b74ea4000f..33f68672d1f 100644 --- a/gdbstub/internals.h +++ b/gdbstub/internals.h @@ -11,6 +11,7 @@ =20 #include "qemu/accel.h" #include "exec/cpu-common.h" +#include "gdbstub/enums.h" =20 /* * Most "large" transfers (e.g. memory reads, feature XML @@ -217,8 +218,10 @@ void gdb_syscall_handling(const char *syscall_packet); * Break/Watch point support - there is an implementation for system * and user mode. */ -int gdb_breakpoint_insert(CPUState *cs, int type, vaddr addr, vaddr len); -int gdb_breakpoint_remove(CPUState *cs, int type, vaddr addr, vaddr len); +int gdb_breakpoint_insert(CPUState *cs, GdbBreakpointType type, + vaddr addr, vaddr len); +int gdb_breakpoint_remove(CPUState *cs, GdbBreakpointType type, + vaddr addr, vaddr len); void gdb_breakpoint_remove_all(CPUState *cs); =20 /** diff --git a/include/gdbstub/enums.h b/include/gdbstub/enums.h index c4d54a1d083..e4e2043d92c 100644 --- a/include/gdbstub/enums.h +++ b/include/gdbstub/enums.h @@ -12,10 +12,12 @@ #define DEFAULT_GDBSTUB_PORT "1234" =20 /* GDB breakpoint/watchpoint types */ -#define GDB_BREAKPOINT_SW 0 -#define GDB_BREAKPOINT_HW 1 -#define GDB_WATCHPOINT_WRITE 2 -#define GDB_WATCHPOINT_READ 3 -#define GDB_WATCHPOINT_ACCESS 4 +typedef enum GdbBreakpointType { + GDB_BREAKPOINT_SW =3D 0, + GDB_BREAKPOINT_HW =3D 1, + GDB_WATCHPOINT_WRITE =3D 2, + GDB_WATCHPOINT_READ =3D 3, + GDB_WATCHPOINT_ACCESS =3D 4, +} GdbBreakpointType; =20 #endif /* GDBSTUB_ENUMS_H */ diff --git a/gdbstub/system.c b/gdbstub/system.c index 9c4bd8ebcba..6e2dbc823e3 100644 --- a/gdbstub/system.c +++ b/gdbstub/system.c @@ -623,7 +623,8 @@ int gdb_signal_to_target(int sig) * Break/Watch point helpers */ =20 -int gdb_breakpoint_insert(CPUState *cs, int type, vaddr addr, vaddr len) +int gdb_breakpoint_insert(CPUState *cs, GdbBreakpointType type, + vaddr addr, vaddr len) { const AccelOpsClass *ops =3D cpus_get_accel(); if (ops->insert_breakpoint) { @@ -632,7 +633,8 @@ int gdb_breakpoint_insert(CPUState *cs, int type, vaddr= addr, vaddr len) return -ENOSYS; } =20 -int gdb_breakpoint_remove(CPUState *cs, int type, vaddr addr, vaddr len) +int gdb_breakpoint_remove(CPUState *cs, GdbBreakpointType type, + vaddr addr, vaddr len) { const AccelOpsClass *ops =3D cpus_get_accel(); if (ops->remove_breakpoint) { diff --git a/gdbstub/user.c b/gdbstub/user.c index 90d6ee49fb5..9e6f9a6f376 100644 --- a/gdbstub/user.c +++ b/gdbstub/user.c @@ -790,7 +790,8 @@ unsigned int gdb_get_max_cpus(void) * Break/Watch point helpers */ =20 -int gdb_breakpoint_insert(CPUState *cs, int type, vaddr addr, vaddr len) +int gdb_breakpoint_insert(CPUState *cs, GdbBreakpointType type, + vaddr addr, vaddr len) { CPUState *cpu; int err =3D 0; @@ -811,7 +812,8 @@ int gdb_breakpoint_insert(CPUState *cs, int type, vaddr= addr, vaddr len) } } =20 -int gdb_breakpoint_remove(CPUState *cs, int type, vaddr addr, vaddr len) +int gdb_breakpoint_remove(CPUState *cs, GdbBreakpointType type, + vaddr addr, vaddr len) { CPUState *cpu; int err =3D 0; --=20 2.53.0 From nobody Sun Jul 26 11:01:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783345819; cv=none; d=zohomail.com; s=zohoarc; b=Qh0g50VOe1FavxUutlyM4uAQw0n/VjtmnyfsPhJtCXBY4Eazn5/IzLr2BM1Ab4Tj3nZeITQgcLGCaT2QnnO9HV29xUSrdYww0zJx6XL+QJ+HFOGTJLEG4xe3rHzxtcQYE2H6sGGuq5HpEzndnGBSASbw3BfPCanzu/h+69X3Gns= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783345819; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=WcpkIGHjhwQR0SDiD0tAqIwSLlRtqtm9/MDOtUpPkm4=; b=FN3YCVugADqh8755OGXJgDvXTvo6emoHR3Q/qIpfF6pluuMGEFLNNawB5Y0W5xKIwjh0rjUFktmV/GhXgTxS2OPm9EwhIRmU9trqnPAWrEGBpVBGGGvq4dmajxYJNaMKH/KHjXbo2Y3WfIxESAFTskRRS5iGXE0XrEXzm9+V9O8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783345819127399.13323792107406; Mon, 6 Jul 2026 06:50:19 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgjhg-00068q-FC; Mon, 06 Jul 2026 09:49:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjhQ-00064m-Np for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:49:29 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjhN-00076Z-DO for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:49:28 -0400 Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666AxL30369098 for ; Mon, 6 Jul 2026 13:49:24 GMT Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f88h99ccb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 13:49:24 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92d1cae5740so351322885a.0 for ; Mon, 06 Jul 2026 06:49:24 -0700 (PDT) Received: from localhost.localdomain (1.171.88.92.rev.sfr.net. [92.88.171.1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493cce0a7cfsm283003345e9.9.2026.07.06.06.49.21 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 06 Jul 2026 06:49:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WcpkIGHjhwQR0SDiD0tAqIwSLlRtqtm9/MDOtUpPkm4=; b=GHABsOIOamXEb2Y6 4iW3zOiF4mGCtryFuRJYLhqlnadsc91NkEw4B2VEFwmmd4HgFHkuHhQoTwzUxaEH vgZuVU0fbmfKvm8cwIbEzsXYOfhxnjt6vtK+4U7cTpn7Ly2XSOlvZbSno/QWUvUh BXNnxpSAw9cNaJNhj7gixUQKsB/JqsapcTBhhXbocg6Aka1GWZd2XopN0IshzleI 4dTOkH99k2Hl/AjwKRjkS0IuRUBqb1VoQ9yG7imycxQy2uU9vNxATfQdZDhSUZ+N hVVgTg/lHqr1IXyyWYE84XG6Jdf1rn6HK+e9u/RG05/adc6NC7cO88d0S8LTno+B CJyIzw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783345764; x=1783950564; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=WcpkIGHjhwQR0SDiD0tAqIwSLlRtqtm9/MDOtUpPkm4=; b=hUuKY1SOIiiFljSwB+QHvdfVqVXXe/fIbL3yCnETiagUxAsBh1nsZtaSL7+MAp2eET pWz9DwzoXqxT62FwSL42fqts5madw23o7i4u7txngD/HIvwNJ9mxMxms13mnk+5GfD5N LiXy+NMm0Twam0yKU6NKhA1Kr6GmcW6aWNOzq+v1LC9Oam79NpkPD2gMArTUDQwS44He hNnEx1YIev8Y89RGQuUUo4CrADCnpa7fQFx5qnTWKMk0sPACpLOsgu4vc4jfRE/y/pRq EwDE0qo8bGqBpyrHDos+UqzlzHZy/UiDHjpXKuEBYlS9IMFgbE2+iqHU3Gy1rimTxy6m VNJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783345764; x=1783950564; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=WcpkIGHjhwQR0SDiD0tAqIwSLlRtqtm9/MDOtUpPkm4=; b=cL0/BFgpY8j8VvEyqeGjIYeVJY4uHnbROVxszHUBae6ZWIPBjTx7iPWOI1dhaXi4yk DyVzRzC+kcrHmV4oII6BKHSSk3NFSPR3TBJKggwMJfckhHFkFcJFSKOB+Y+IV61xR7Ro CBCltGw4y2JwYnZ774cqG2I9cSip+USK+a3zjHjg8wKKkGGwlAuuMeDwxIBhQTSAS+rh WDDD2E1KqT8oLhOy7UgrR+oY515RsWhhXWk0wSUHfkBGtyOUnI3D9o4cGSvGHdhn37FU nUmli831HcsYqd7hFB1kwo4dgH7UZC7ZQVK0C+UUVphd8f0h5E9+lMaI3P7pwBOmBA9h gjog== X-Gm-Message-State: AOJu0YwK6sA0ShT/o2UQqQVqZTtsBgL97v22bqTz1WR4p0uQup5rHGfn i7x2NSnJgtUgpyCLqKP6u/OEBLo7RNDr5rSkHeqbDHVW3VXIiMRNq+VQBphSnFoe8yOJO4QCAYN 0TQ9Z51OjAbEg3ZtX8rCR4XhsSnNhpE2nCAqUxV3BTcL0luCkdVzoDc7b7pZKD9Zzaw== X-Gm-Gg: AfdE7cmBK70EEXeZhTA4g6ryh80h4nwmxpNyqw0YwDXTZKhoCajmWnMerP0E8HJ/Iet cefSiunMbmt4oiO2E0TCvM39BctvchJ33AswtwKEun9xpZmZn+HNX2Oja0fZHOghdtizZwnGni0 sn7YPdBanb/FNPfDn+eUQbvtOotqmCFyuTuxrlf3lvC1WmZgHEWlYYuwwT+efAXcV3SXkBUEArj tPvJzlVaokh2vcrVOzu+Nht9/t+SSmk/E3WhZoeVNNGVguzitaOgkG/P2CY8zP6flg9J1AoEnKf aoNv0m6B6Rug5Dz6TgOqjMBq+pH+YOXAYAs1MToqgquLlS3MxZBelLbIVa/Ptpp+LunCn9pguuJ evO+22ZlELPHoggmlZ7mMfi8OepvKHhuBlzi7dIdSuHw/VKLnrszimwZcwA== X-Received: by 2002:a05:620a:4626:b0:92e:6dc0:7b13 with SMTP id af79cd13be357-92ebb6072ccmr87019585a.53.1783345763428; Mon, 06 Jul 2026 06:49:23 -0700 (PDT) X-Received: by 2002:a05:620a:4626:b0:92e:6dc0:7b13 with SMTP id af79cd13be357-92ebb6072ccmr87009585a.53.1783345762408; Mon, 06 Jul 2026 06:49:22 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 25/32] accel: Use GdbBreakpointType enum Date: Mon, 6 Jul 2026 15:45:20 +0200 Message-ID: <20260706134527.84808-26-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706134527.84808-1-philmd@oss.qualcomm.com> References: <20260706134527.84808-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: NISZlFUxOdsXww8dU8MaOylENmFe0h6i X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfX62XWEi/KanHr ydlZpu9cmaJ5y00XxY7oECs+7hgG9qQ+2eIazWgzBVdDH/R+nPjTX52kVMEjpcwBnVTsi0adsDK oiUEeUG471bPSic1y/ivlW8nLASRpu0= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfXx/qwaZ8l/lF7 dC1UBzJ60lrkIInoEqXxW7c2Csqf1aBHAkN5orKoSX2r6G8paa30xZXJFL2a89HEQkKVEYxGf1M hY8CjUhSXBo7q+g77wjXyM51xQMco470t3llqWjlF6b849pM1Q/1Hq0vSIDi4H8z8PCPH9dkE4Z SGhZMckvYuC3n4KNazdRQS0337/EYUsNmS4CkY7snDfeF/Zo8r27/XiCKxO4aYuDLTVG6E0NkdR 1D+Wqs4VZfFJJ8GTPArtax+sqSxgejUTh6VCBjFL/rqS0MLHmFVQlz2uDSRphRxwsu0D7jgTfet ZPVBYhMFuMz+qRJOw0r59JUdNPBmDHbzeZtpm6BBM71xPJZi5pVJ3MaiGlzGpwx9CgpRIEbcYhK 0rStJijAa+RFpW5L8pY+3OiBmV5Vw9ypC+c44EkOd4lGY2AGIVtl0Xx6WC4PLBOa71+YYxDp/R9 GCV6r3IwdC1MOtSHmgw== X-Proofpoint-GUID: NISZlFUxOdsXww8dU8MaOylENmFe0h6i X-Authority-Analysis: v=2.4 cv=GulyPE1C c=1 sm=1 tr=0 ts=6a4bb264 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=PLEY+c9/kVlxBKEpvFYBUQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=j3PXfpA4_7De4rqNWBgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=O8hF6Hzn-FEA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 clxscore=1015 malwarescore=0 impostorscore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060141 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783345820769158500 Include '_gdbstub_' in the AccelOpsClass handlers to emphasize we are handling gdbstub-related requests. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson Message-ID: <20260705215729.62196-26-philmd@oss.qualcomm.com> --- accel/kvm/kvm-cpus.h | 11 ++++++++--- include/accel/accel-cpu-ops.h | 9 ++++++--- include/system/hvf_int.h | 9 ++++++--- include/system/kvm.h | 9 ++++++--- target/arm/internals.h | 5 +++-- accel/hvf/hvf-accel-ops.c | 20 +++++++++++--------- accel/kvm/kvm-accel-ops.c | 6 +++--- accel/kvm/kvm-all.c | 14 ++++++++------ accel/tcg/tcg-accel-ops.c | 16 +++++++++------- gdbstub/system.c | 12 ++++++------ target/arm/hvf/hvf.c | 12 +++++++----- target/arm/hyp_gdbstub.c | 8 ++++---- target/arm/kvm.c | 12 +++++++----- target/i386/hvf/hvf.c | 8 +++++--- target/i386/kvm/kvm.c | 12 +++++++----- target/loongarch/kvm/kvm.c | 8 +++++--- target/ppc/kvm.c | 12 +++++++----- target/riscv/kvm/kvm-cpu.c | 8 +++++--- target/s390x/kvm/kvm.c | 8 +++++--- 19 files changed, 118 insertions(+), 81 deletions(-) diff --git a/accel/kvm/kvm-cpus.h b/accel/kvm/kvm-cpus.h index 3185659562d..bc2dd82e68e 100644 --- a/accel/kvm/kvm-cpus.h +++ b/accel/kvm/kvm-cpus.h @@ -10,13 +10,18 @@ #ifndef KVM_CPUS_H #define KVM_CPUS_H =20 +#include "gdbstub/enums.h" + int kvm_init_vcpu(CPUState *cpu, Error **errp); int kvm_cpu_exec(CPUState *cpu); void kvm_destroy_vcpu(CPUState *cpu); void kvm_cpu_synchronize_post_reset(CPUState *cpu); void kvm_cpu_synchronize_post_init(CPUState *cpu); void kvm_cpu_synchronize_pre_loadvm(CPUState *cpu); -int kvm_insert_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len); -int kvm_remove_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len); -void kvm_remove_all_breakpoints(CPUState *cpu); +int kvm_insert_gdbstub_breakpoint(CPUState *cpu, GdbBreakpointType type, + vaddr addr, vaddr len); +int kvm_remove_gdbstub_breakpoint(CPUState *cpu, GdbBreakpointType type, + vaddr addr, vaddr len); +void kvm_remove_all_gdbstub_breakpoints(CPUState *cpu); + #endif /* KVM_CPUS_H */ diff --git a/include/accel/accel-cpu-ops.h b/include/accel/accel-cpu-ops.h index b23a0606c7e..f0c7ee7542c 100644 --- a/include/accel/accel-cpu-ops.h +++ b/include/accel/accel-cpu-ops.h @@ -13,6 +13,7 @@ #include "qemu/accel.h" #include "exec/vaddr.h" #include "qom/object.h" +#include "gdbstub/enums.h" =20 #define ACCEL_OPS_SUFFIX "-ops" #define TYPE_ACCEL_OPS "accel" ACCEL_OPS_SUFFIX @@ -85,9 +86,11 @@ struct AccelOpsClass { =20 /* gdbstub hooks */ int (*update_guest_debug)(CPUState *cpu); - int (*insert_breakpoint)(CPUState *cpu, int type, vaddr addr, vaddr le= n); - int (*remove_breakpoint)(CPUState *cpu, int type, vaddr addr, vaddr le= n); - void (*remove_all_breakpoints)(CPUState *cpu); + int (*insert_gdbstub_breakpoint)(CPUState *cpu, GdbBreakpointType type, + vaddr addr, vaddr len); + int (*remove_gdbstub_breakpoint)(CPUState *cpu, GdbBreakpointType type, + vaddr addr, vaddr len); + void (*remove_all_gdbstub_breakpoints)(CPUState *cpu); }; =20 void generic_handle_interrupt(CPUState *cpu, int mask); diff --git a/include/system/hvf_int.h b/include/system/hvf_int.h index d64f4942556..a01691ce172 100644 --- a/include/system/hvf_int.h +++ b/include/system/hvf_int.h @@ -13,6 +13,7 @@ =20 #include "qemu/queue.h" #include "exec/vaddr.h" +#include "gdbstub/enums.h" #include "qom/object.h" #include "accel/accel-ops.h" =20 @@ -91,9 +92,11 @@ int hvf_sw_breakpoints_active(CPUState *cpu); =20 int hvf_arch_insert_sw_breakpoint(CPUState *cpu, struct hvf_sw_breakpoint = *bp); int hvf_arch_remove_sw_breakpoint(CPUState *cpu, struct hvf_sw_breakpoint = *bp); -int hvf_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type); -int hvf_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type); -void hvf_arch_remove_all_hw_breakpoints(void); +int hvf_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type); +int hvf_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type); +void hvf_arch_remove_all_gdbstub_hw_breakpoints(void); =20 /* * hvf_update_guest_debug: diff --git a/include/system/kvm.h b/include/system/kvm.h index cdd1856ac5f..714b8c7b011 100644 --- a/include/system/kvm.h +++ b/include/system/kvm.h @@ -17,6 +17,7 @@ #define QEMU_KVM_H =20 #include "exec/memattrs.h" +#include "gdbstub/enums.h" #include "qemu/accel.h" #include "accel/accel-route.h" #include "qom/object.h" @@ -412,9 +413,11 @@ int kvm_arch_insert_sw_breakpoint(CPUState *cpu, struct kvm_sw_breakpoint *bp); int kvm_arch_remove_sw_breakpoint(CPUState *cpu, struct kvm_sw_breakpoint *bp); -int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type); -int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type); -void kvm_arch_remove_all_hw_breakpoints(void); +int kvm_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type); +int kvm_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type); +void kvm_arch_remove_all_gdbstub_hw_breakpoints(void); =20 void kvm_arch_update_guest_debug(CPUState *cpu, struct kvm_guest_debug *db= g); =20 diff --git a/target/arm/internals.h b/target/arm/internals.h index fcce3804f34..067c3f2b8bb 100644 --- a/target/arm/internals.h +++ b/target/arm/internals.h @@ -29,6 +29,7 @@ #include "exec/vaddr.h" #include "exec/breakpoint.h" #include "exec/memop.h" +#include "gdbstub/enums.h" #ifdef CONFIG_TCG #include "accel/tcg/tb-cpu-state.h" #include "tcg/tcg-gvec-desc.h" @@ -1968,8 +1969,8 @@ int delete_hw_breakpoint(vaddr pc); =20 bool check_watchpoint_in_range(int i, vaddr addr); CPUWatchpoint *find_hw_watchpoint(CPUState *cpu, vaddr addr); -int insert_hw_watchpoint(vaddr addr, vaddr len, int type); -int delete_hw_watchpoint(vaddr addr, vaddr len, int type); +int insert_gdbstub_hw_watchpoint(vaddr addr, vaddr len, GdbBreakpointType = type); +int delete_gdbstub_hw_watchpoint(vaddr addr, vaddr len, GdbBreakpointType = type); =20 /* Return the current value of the system counter in ticks */ uint64_t gt_get_countervalue(CPUARMState *env); diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-ops.c index ecc0cd1b558..d2276d8513e 100644 --- a/accel/hvf/hvf-accel-ops.c +++ b/accel/hvf/hvf-accel-ops.c @@ -233,7 +233,8 @@ int hvf_update_guest_debug(CPUState *cpu) return 0; } =20 -static int hvf_insert_breakpoint(CPUState *cpu, int type, vaddr addr, vadd= r len) +static int hvf_insert_gdbstub_breakpoint(CPUState *cpu, GdbBreakpointType = type, + vaddr addr, vaddr len) { struct hvf_sw_breakpoint *bp; int err; @@ -256,7 +257,7 @@ static int hvf_insert_breakpoint(CPUState *cpu, int typ= e, vaddr addr, vaddr len) =20 QTAILQ_INSERT_HEAD(&hvf_state->hvf_sw_breakpoints, bp, entry); } else { - err =3D hvf_arch_insert_hw_breakpoint(addr, len, type); + err =3D hvf_arch_insert_gdbstub_hw_breakpoint(addr, len, type); if (err) { return err; } @@ -271,7 +272,8 @@ static int hvf_insert_breakpoint(CPUState *cpu, int typ= e, vaddr addr, vaddr len) return 0; } =20 -static int hvf_remove_breakpoint(CPUState *cpu, int type, vaddr addr, vadd= r len) +static int hvf_remove_gdbstub_breakpoint(CPUState *cpu, GdbBreakpointType = type, + vaddr addr, vaddr len) { struct hvf_sw_breakpoint *bp; int err; @@ -295,7 +297,7 @@ static int hvf_remove_breakpoint(CPUState *cpu, int typ= e, vaddr addr, vaddr len) QTAILQ_REMOVE(&hvf_state->hvf_sw_breakpoints, bp, entry); g_free(bp); } else { - err =3D hvf_arch_remove_hw_breakpoint(addr, len, type); + err =3D hvf_arch_remove_gdbstub_hw_breakpoint(addr, len, type); if (err) { return err; } @@ -310,7 +312,7 @@ static int hvf_remove_breakpoint(CPUState *cpu, int typ= e, vaddr addr, vaddr len) return 0; } =20 -static void hvf_remove_all_breakpoints(CPUState *cpu) +static void hvf_remove_all_gdbstub_breakpoints(CPUState *cpu) { struct hvf_sw_breakpoint *bp, *next; CPUState *tmpcpu; @@ -328,7 +330,7 @@ static void hvf_remove_all_breakpoints(CPUState *cpu) QTAILQ_REMOVE(&hvf_state->hvf_sw_breakpoints, bp, entry); g_free(bp); } - hvf_arch_remove_all_hw_breakpoints(); + hvf_arch_remove_all_gdbstub_hw_breakpoints(); =20 CPU_FOREACH(cpu) { hvf_update_guest_debug(cpu); @@ -365,9 +367,9 @@ static void hvf_accel_ops_class_init(ObjectClass *oc, c= onst void *data) ops->synchronize_state =3D hvf_cpu_synchronize_state; ops->synchronize_pre_loadvm =3D hvf_cpu_synchronize_pre_loadvm; =20 - ops->insert_breakpoint =3D hvf_insert_breakpoint; - ops->remove_breakpoint =3D hvf_remove_breakpoint; - ops->remove_all_breakpoints =3D hvf_remove_all_breakpoints; + ops->insert_gdbstub_breakpoint =3D hvf_insert_gdbstub_breakpoint; + ops->remove_gdbstub_breakpoint =3D hvf_remove_gdbstub_breakpoint; + ops->remove_all_gdbstub_breakpoints =3D hvf_remove_all_gdbstub_breakpo= ints; ops->update_guest_debug =3D hvf_update_guest_debug; =20 ops->get_vcpu_stats =3D hvf_get_vcpu_stats; diff --git a/accel/kvm/kvm-accel-ops.c b/accel/kvm/kvm-accel-ops.c index 45330327909..c8e7aa38709 100644 --- a/accel/kvm/kvm-accel-ops.c +++ b/accel/kvm/kvm-accel-ops.c @@ -107,9 +107,9 @@ static void kvm_accel_ops_class_init(ObjectClass *oc, c= onst void *data) =20 #ifdef TARGET_KVM_HAVE_GUEST_DEBUG ops->update_guest_debug =3D kvm_update_guest_debug_ops; - ops->insert_breakpoint =3D kvm_insert_breakpoint; - ops->remove_breakpoint =3D kvm_remove_breakpoint; - ops->remove_all_breakpoints =3D kvm_remove_all_breakpoints; + ops->insert_gdbstub_breakpoint =3D kvm_insert_gdbstub_breakpoint; + ops->remove_gdbstub_breakpoint =3D kvm_remove_gdbstub_breakpoint; + ops->remove_all_gdbstub_breakpoints =3D kvm_remove_all_gdbstub_breakpo= ints; #endif } =20 diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index b03488ebac3..feffca0d82d 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -3826,7 +3826,8 @@ int kvm_update_guest_debug(CPUState *cpu, unsigned lo= ng reinject_trap) return data.err; } =20 -int kvm_insert_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len) +int kvm_insert_gdbstub_breakpoint(CPUState *cpu, GdbBreakpointType type, + vaddr addr, vaddr len) { struct kvm_sw_breakpoint *bp; int err; @@ -3849,7 +3850,7 @@ int kvm_insert_breakpoint(CPUState *cpu, int type, va= ddr addr, vaddr len) =20 QTAILQ_INSERT_HEAD(&cpu->kvm_state->kvm_sw_breakpoints, bp, entry); } else { - err =3D kvm_arch_insert_hw_breakpoint(addr, len, type); + err =3D kvm_arch_insert_gdbstub_hw_breakpoint(addr, len, type); if (err) { return err; } @@ -3864,7 +3865,8 @@ int kvm_insert_breakpoint(CPUState *cpu, int type, va= ddr addr, vaddr len) return 0; } =20 -int kvm_remove_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len) +int kvm_remove_gdbstub_breakpoint(CPUState *cpu, GdbBreakpointType type, + vaddr addr, vaddr len) { struct kvm_sw_breakpoint *bp; int err; @@ -3888,7 +3890,7 @@ int kvm_remove_breakpoint(CPUState *cpu, int type, va= ddr addr, vaddr len) QTAILQ_REMOVE(&cpu->kvm_state->kvm_sw_breakpoints, bp, entry); g_free(bp); } else { - err =3D kvm_arch_remove_hw_breakpoint(addr, len, type); + err =3D kvm_arch_remove_gdbstub_hw_breakpoint(addr, len, type); if (err) { return err; } @@ -3903,7 +3905,7 @@ int kvm_remove_breakpoint(CPUState *cpu, int type, va= ddr addr, vaddr len) return 0; } =20 -void kvm_remove_all_breakpoints(CPUState *cpu) +void kvm_remove_all_gdbstub_breakpoints(CPUState *cpu) { struct kvm_sw_breakpoint *bp, *next; KVMState *s =3D cpu->kvm_state; @@ -3921,7 +3923,7 @@ void kvm_remove_all_breakpoints(CPUState *cpu) QTAILQ_REMOVE(&s->kvm_sw_breakpoints, bp, entry); g_free(bp); } - kvm_arch_remove_all_hw_breakpoints(); + kvm_arch_remove_all_gdbstub_hw_breakpoints(); =20 CPU_FOREACH(cpu) { kvm_update_guest_debug(cpu, 0); diff --git a/accel/tcg/tcg-accel-ops.c b/accel/tcg/tcg-accel-ops.c index 1043fc61874..560fe2554ba 100644 --- a/accel/tcg/tcg-accel-ops.c +++ b/accel/tcg/tcg-accel-ops.c @@ -110,7 +110,7 @@ void tcg_handle_interrupt(CPUState *cpu, int mask) } =20 /* Translate GDB watchpoint type to a flags value for cpu_watchpoint_* */ -static inline int xlat_gdb_type(CPUState *cpu, int gdbtype) +static inline int xlat_gdb_type(CPUState *cpu, GdbBreakpointType gdbtype) { static const int xlat[] =3D { [GDB_WATCHPOINT_WRITE] =3D BP_GDB | BP_MEM_WRITE, @@ -126,7 +126,8 @@ static inline int xlat_gdb_type(CPUState *cpu, int gdbt= ype) return cputype; } =20 -static int tcg_insert_breakpoint(CPUState *cs, int type, vaddr addr, vaddr= len) +static int tcg_insert_gdbstub_breakpoint(CPUState *cs, GdbBreakpointType t= ype, + vaddr addr, vaddr len) { CPUState *cpu; int err =3D 0; @@ -157,7 +158,8 @@ static int tcg_insert_breakpoint(CPUState *cs, int type= , vaddr addr, vaddr len) } } =20 -static int tcg_remove_breakpoint(CPUState *cs, int type, vaddr addr, vaddr= len) +static int tcg_remove_gdbstub_breakpoint(CPUState *cs, GdbBreakpointType t= ype, + vaddr addr, vaddr len) { CPUState *cpu; int err =3D 0; @@ -188,7 +190,7 @@ static int tcg_remove_breakpoint(CPUState *cs, int type= , vaddr addr, vaddr len) } } =20 -static void tcg_remove_all_breakpoints(CPUState *cpu) +static void tcg_remove_all_gdbstub_breakpoints(CPUState *cpu) { cpu_breakpoint_remove_all(cpu, BP_GDB); cpu_watchpoint_remove_all(cpu, BP_GDB); @@ -216,9 +218,9 @@ static void tcg_accel_ops_init(AccelClass *ac) } =20 ops->cpu_reset_hold =3D tcg_cpu_reset_hold; - ops->insert_breakpoint =3D tcg_insert_breakpoint; - ops->remove_breakpoint =3D tcg_remove_breakpoint; - ops->remove_all_breakpoints =3D tcg_remove_all_breakpoints; + ops->insert_gdbstub_breakpoint =3D tcg_insert_gdbstub_breakpoint; + ops->remove_gdbstub_breakpoint =3D tcg_remove_gdbstub_breakpoint; + ops->remove_all_gdbstub_breakpoints =3D tcg_remove_all_gdbstub_breakpo= ints; } =20 static void tcg_accel_ops_class_init(ObjectClass *oc, const void *data) diff --git a/gdbstub/system.c b/gdbstub/system.c index 6e2dbc823e3..3098fd55740 100644 --- a/gdbstub/system.c +++ b/gdbstub/system.c @@ -627,8 +627,8 @@ int gdb_breakpoint_insert(CPUState *cs, GdbBreakpointTy= pe type, vaddr addr, vaddr len) { const AccelOpsClass *ops =3D cpus_get_accel(); - if (ops->insert_breakpoint) { - return ops->insert_breakpoint(cs, type, addr, len); + if (ops->insert_gdbstub_breakpoint) { + return ops->insert_gdbstub_breakpoint(cs, type, addr, len); } return -ENOSYS; } @@ -637,8 +637,8 @@ int gdb_breakpoint_remove(CPUState *cs, GdbBreakpointTy= pe type, vaddr addr, vaddr len) { const AccelOpsClass *ops =3D cpus_get_accel(); - if (ops->remove_breakpoint) { - return ops->remove_breakpoint(cs, type, addr, len); + if (ops->remove_gdbstub_breakpoint) { + return ops->remove_gdbstub_breakpoint(cs, type, addr, len); } return -ENOSYS; } @@ -646,8 +646,8 @@ int gdb_breakpoint_remove(CPUState *cs, GdbBreakpointTy= pe type, void gdb_breakpoint_remove_all(CPUState *cs) { const AccelOpsClass *ops =3D cpus_get_accel(); - if (ops->remove_all_breakpoints) { - ops->remove_all_breakpoints(cs); + if (ops->remove_all_gdbstub_breakpoints) { + ops->remove_all_gdbstub_breakpoints(cs); } } =20 diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index e16457c3cfb..d5b1966a867 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -2726,7 +2726,8 @@ int hvf_arch_remove_sw_breakpoint(CPUState *cpu, stru= ct hvf_sw_breakpoint *bp) return 0; } =20 -int hvf_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type) +int hvf_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { switch (type) { case GDB_BREAKPOINT_HW: @@ -2734,13 +2735,14 @@ int hvf_arch_insert_hw_breakpoint(vaddr addr, vaddr= len, int type) case GDB_WATCHPOINT_READ: case GDB_WATCHPOINT_WRITE: case GDB_WATCHPOINT_ACCESS: - return insert_hw_watchpoint(addr, len, type); + return insert_gdbstub_hw_watchpoint(addr, len, type); default: return -ENOSYS; } } =20 -int hvf_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type) +int hvf_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { switch (type) { case GDB_BREAKPOINT_HW: @@ -2748,13 +2750,13 @@ int hvf_arch_remove_hw_breakpoint(vaddr addr, vaddr= len, int type) case GDB_WATCHPOINT_READ: case GDB_WATCHPOINT_WRITE: case GDB_WATCHPOINT_ACCESS: - return delete_hw_watchpoint(addr, len, type); + return delete_gdbstub_hw_watchpoint(addr, len, type); default: return -ENOSYS; } } =20 -void hvf_arch_remove_all_hw_breakpoints(void) +void hvf_arch_remove_all_gdbstub_hw_breakpoints(void) { if (cur_hw_wps > 0) { g_array_remove_range(hw_watchpoints, 0, cur_hw_wps); diff --git a/target/arm/hyp_gdbstub.c b/target/arm/hyp_gdbstub.c index bb5969720ce..dda6946ddaa 100644 --- a/target/arm/hyp_gdbstub.c +++ b/target/arm/hyp_gdbstub.c @@ -94,7 +94,7 @@ int delete_hw_breakpoint(vaddr pc) } =20 /** - * insert_hw_watchpoint() + * insert_gdbstub_hw_watchpoint() * @addr: address of watch point * @len: size of area * @type: type of watch point @@ -125,7 +125,7 @@ int delete_hw_breakpoint(vaddr pc) * need to ensure you mask the address as required and set BAS=3D0xff */ =20 -int insert_hw_watchpoint(vaddr addr, vaddr len, int type) +int insert_gdbstub_hw_watchpoint(vaddr addr, vaddr len, GdbBreakpointType = type) { HWWatchpoint wp =3D { .wcr =3D R_DBGWCR_E_MASK, /* E=3D1, enable */ @@ -208,13 +208,13 @@ bool check_watchpoint_in_range(int i, vaddr addr) } =20 /** - * delete_hw_watchpoint() + * delete_gdbstub_hw_watchpoint() * @addr: address of breakpoint * * Delete a breakpoint and shuffle any above down */ =20 -int delete_hw_watchpoint(vaddr addr, vaddr len, int type) +int delete_gdbstub_hw_watchpoint(vaddr addr, vaddr len, GdbBreakpointType = type) { int i; for (i =3D 0; i < cur_hw_wps; i++) { diff --git a/target/arm/kvm.c b/target/arm/kvm.c index a54ef51ec2a..01f42f42538 100644 --- a/target/arm/kvm.c +++ b/target/arm/kvm.c @@ -1784,7 +1784,8 @@ void kvm_arch_accel_class_init(ObjectClass *oc) "Eager Page Split chunk size for hugepages. (default: 0, disabled)= "); } =20 -int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { switch (type) { case GDB_BREAKPOINT_HW: @@ -1793,13 +1794,14 @@ int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr= len, int type) case GDB_WATCHPOINT_READ: case GDB_WATCHPOINT_WRITE: case GDB_WATCHPOINT_ACCESS: - return insert_hw_watchpoint(addr, len, type); + return insert_gdbstub_hw_watchpoint(addr, len, type); default: return -ENOSYS; } } =20 -int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { switch (type) { case GDB_BREAKPOINT_HW: @@ -1807,13 +1809,13 @@ int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr= len, int type) case GDB_WATCHPOINT_READ: case GDB_WATCHPOINT_WRITE: case GDB_WATCHPOINT_ACCESS: - return delete_hw_watchpoint(addr, len, type); + return delete_gdbstub_hw_watchpoint(addr, len, type); default: return -ENOSYS; } } =20 -void kvm_arch_remove_all_hw_breakpoints(void) +void kvm_arch_remove_all_gdbstub_hw_breakpoints(void) { if (cur_hw_wps > 0) { g_array_remove_range(hw_watchpoints, 0, cur_hw_wps); diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c index 19ad64a1d93..150598418e2 100644 --- a/target/i386/hvf/hvf.c +++ b/target/i386/hvf/hvf.c @@ -1049,17 +1049,19 @@ int hvf_arch_remove_sw_breakpoint(CPUState *cpu, st= ruct hvf_sw_breakpoint *bp) return -ENOSYS; } =20 -int hvf_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type) +int hvf_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { return -ENOSYS; } =20 -int hvf_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type) +int hvf_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { return -ENOSYS; } =20 -void hvf_arch_remove_all_hw_breakpoints(void) +void hvf_arch_remove_all_gdbstub_hw_breakpoints(void) { } =20 diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c index 64cc421abe6..1e09155e92c 100644 --- a/target/i386/kvm/kvm.c +++ b/target/i386/kvm/kvm.c @@ -6159,12 +6159,12 @@ int kvm_arch_remove_sw_breakpoint(CPUState *cs, str= uct kvm_sw_breakpoint *bp) static struct { target_ulong addr; int len; - int type; + GdbBreakpointType type; } hw_breakpoint[4]; =20 static int nb_hw_breakpoint; =20 -static int find_hw_breakpoint(target_ulong addr, int len, int type) +static int find_hw_breakpoint(target_ulong addr, int len, GdbBreakpointTyp= e type) { int n; =20 @@ -6177,7 +6177,8 @@ static int find_hw_breakpoint(target_ulong addr, int = len, int type) return -1; } =20 -int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { switch (type) { case GDB_BREAKPOINT_HW: @@ -6217,7 +6218,8 @@ int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr l= en, int type) return 0; } =20 -int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { int n; =20 @@ -6231,7 +6233,7 @@ int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr l= en, int type) return 0; } =20 -void kvm_arch_remove_all_hw_breakpoints(void) +void kvm_arch_remove_all_gdbstub_hw_breakpoints(void) { nb_hw_breakpoint =3D 0; } diff --git a/target/loongarch/kvm/kvm.c b/target/loongarch/kvm/kvm.c index d6539c12acd..beda6965f8c 100644 --- a/target/loongarch/kvm/kvm.c +++ b/target/loongarch/kvm/kvm.c @@ -1418,17 +1418,19 @@ int kvm_arch_remove_sw_breakpoint(CPUState *cs, str= uct kvm_sw_breakpoint *bp) return 0; } =20 -int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { return -ENOSYS; } =20 -int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { return -ENOSYS; } =20 -void kvm_arch_remove_all_hw_breakpoints(void) +void kvm_arch_remove_all_gdbstub_hw_breakpoints(void) { } =20 diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index b94c2997a07..93ec0cf6a72 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -455,7 +455,7 @@ unsigned long kvm_arch_vcpu_id(CPUState *cpu) =20 static struct HWBreakpoint { target_ulong addr; - int type; + GdbBreakpointType type; } hw_debug_points[MAX_HW_BKPTS]; =20 static CPUWatchpoint hw_watchpoint; @@ -1412,7 +1412,7 @@ int kvm_arch_remove_sw_breakpoint(CPUState *cs, struc= t kvm_sw_breakpoint *bp) return 0; } =20 -static int find_hw_breakpoint(target_ulong addr, int type) +static int find_hw_breakpoint(target_ulong addr, GdbBreakpointType type) { int n; =20 @@ -1454,7 +1454,8 @@ static int find_hw_watchpoint(target_ulong addr, int = *flag) return -1; } =20 -int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { const unsigned breakpoint_index =3D nb_hw_breakpoint + nb_hw_watchpoin= t; if (breakpoint_index >=3D ARRAY_SIZE(hw_debug_points)) { @@ -1498,7 +1499,8 @@ int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr l= en, int type) return 0; } =20 -int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { int n; =20 @@ -1526,7 +1528,7 @@ int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr l= en, int type) return 0; } =20 -void kvm_arch_remove_all_hw_breakpoints(void) +void kvm_arch_remove_all_gdbstub_hw_breakpoints(void) { nb_hw_breakpoint =3D nb_hw_watchpoint =3D 0; } diff --git a/target/riscv/kvm/kvm-cpu.c b/target/riscv/kvm/kvm-cpu.c index 39d48a9db4d..2a5440d5846 100644 --- a/target/riscv/kvm/kvm-cpu.c +++ b/target/riscv/kvm/kvm-cpu.c @@ -2215,19 +2215,21 @@ int kvm_arch_remove_sw_breakpoint(CPUState *cs, str= uct kvm_sw_breakpoint *bp) return 0; } =20 -int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { /* TODO; To be implemented later. */ return -EINVAL; } =20 -int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { /* TODO; To be implemented later. */ return -EINVAL; } =20 -void kvm_arch_remove_all_hw_breakpoints(void) +void kvm_arch_remove_all_gdbstub_hw_breakpoints(void) { /* TODO; To be implemented later. */ } diff --git a/target/s390x/kvm/kvm.c b/target/s390x/kvm/kvm.c index fdef8f9e8ac..195e39df032 100644 --- a/target/s390x/kvm/kvm.c +++ b/target/s390x/kvm/kvm.c @@ -907,7 +907,8 @@ static int insert_hw_breakpoint(vaddr addr, int len, in= t type) return 0; } =20 -int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { switch (type) { case GDB_BREAKPOINT_HW: @@ -925,7 +926,8 @@ int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len= , int type) return insert_hw_breakpoint(addr, len, type); } =20 -int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { int size; struct kvm_hw_breakpoint *bp =3D find_hw_breakpoint(addr, len, type); @@ -954,7 +956,7 @@ int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len= , int type) return 0; } =20 -void kvm_arch_remove_all_hw_breakpoints(void) +void kvm_arch_remove_all_gdbstub_hw_breakpoints(void) { nb_hw_breakpoints =3D 0; g_free(hw_breakpoints); --=20 2.53.0 From nobody Sun Jul 26 11:01:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783345857; cv=none; d=zohomail.com; s=zohoarc; b=VMJIVIHuzoDlNEW41wh2H0B/d5mrKjMrtuXOF4937XmMRevxxQ0AjIR2mkXEq+ORBYaG7Mc8YNihLCOyV2SrVQS4h0CxA0MNNbqkwQbDU+nrNtbp1ND1wlS9aFOYikNCrESLilY2IhGw1Cepfv0uysJg45ORelItFqlrTeMDWYI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783345857; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=UNLBNmEEOTthboq5Q1P/L6moygeY0HagU9zFilGJEb0=; b=RBgHFPRpeKoncXvuT18put6o6FdDy3Fwd6K5HXSNo3SlfMAdKIJrn2JXY31+jiarggBf5qg7yR0TeJr8/jYSPz8fZHa7a6KXYzjQUXT0DzQesfLyLiHamWHn2Pb3XJp0cbfqgWGssR7zCISkJA96BoSJ0+Mo+lLmxKSs+UMGc20= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783345857478498.12201518088125; Mon, 6 Jul 2026 06:50:57 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgjhh-0006Bt-TC; Mon, 06 Jul 2026 09:49:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjhX-00065z-6L for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:49:41 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjhV-0007A0-I0 for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:49:34 -0400 Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666AxJuG316462 for ; Mon, 6 Jul 2026 13:49:32 GMT Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f87q7hjbc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 13:49:32 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92e61b38eddso552212185a.2 for ; Mon, 06 Jul 2026 06:49:32 -0700 (PDT) Received: from localhost.localdomain (1.171.88.92.rev.sfr.net. [92.88.171.1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c0e92687sm366328855e9.0.2026.07.06.06.49.29 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 06 Jul 2026 06:49:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UNLBNmEEOTthboq5Q1P/L6moygeY0HagU9zFilGJEb0=; b=cBVKeClfg6s3rEvI Oo1IM9e/bXhVOLSMG2nEyRJpC6pUdGG5ik7xBsNoaf+hv9boCT35CN4owjiv+cOL BUOTvFQOY+O6f9RFY6QqXqmnEMWh8lFPZwLM4TOXiyueOc7Y5HgIkJc38cZ27mdH 3i1aROooAT3CilMfPIKVUaxKbPpiLhE5uYPo0QFUS2o1x3NH9LkRr50z9dfVMNUJ NuMlzJLBbyaCpirc7t3i1doGSR1kb5jJdHoPfl2HO0IM8kdAG6ONCAkWjzd2Srgy t0gmmb4FfZt4qwplDvEZ9/KsQLlNv+1DX98khY8QspeH6rNjj8MV1iyygAZkgAME pP7xFg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783345772; x=1783950572; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=UNLBNmEEOTthboq5Q1P/L6moygeY0HagU9zFilGJEb0=; b=Vq3fKg9SvjYcF0IgluZGh9j+S92xGvLnzaPT3FkVRkdoXWFj0EN6Z3k/8vt5bRJp30 Aw2LuYLJsS6yNfodw50HiYndkt/w++i2K0aogSQhqGVgN0/lj+rI4Qx9YJefXgTRBkOx zYRXfI6dOAXXemW4mhNsCuotpcyEw++9mN4HjyAZnF83OaRgRu6cAimFsCN3FLMb4VuC o1IzFOZaBy2uPU1xceiBqeVmN87e24qhtFODo04v9Gcy1iGJTWC7fb9v7NPVgf6NYLuF nPxUNTPUERprdk7haKyNpRVcZQ1tuS8vsWWpu1cBkMOCM0pqO/ifVUlaeBJt/IqyfiYz 51EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783345772; x=1783950572; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=UNLBNmEEOTthboq5Q1P/L6moygeY0HagU9zFilGJEb0=; b=h5f6ZLHoUWHZ/c++vol3cVNI/05TZS/O+Sgv4ybr6DixSGij5u/BGWoKG7fo1BpeIF jdZuBEk7fknXaCrS1IMhmBFfR57LsqPjyskI1NLy7TJ1zjvuohipD1BvxkZ7XlBGOEOP Jqr/1FcF0G2JvV6neM7eoM2sp1g5rfZuPBaJhYypErsFEbHhEYDj9sF0JSOiKcmQlxlh ID3YStbGq0US20L+yEm08ump4q1iNmxU3gZYJtYx+VGCtH0DXxVpG9SkeIAhO0DkemAe TO6WmiZqDxlrjE2iZrMVUFXqycrh8VXBvIAkcOo0iPlrLrkAKKD6p1yr9QrsmbqjSqcj l9+w== X-Gm-Message-State: AOJu0YzEv9HP6DkzQFw6MpeKyvLDllhDRM2CFXriqdgeYZ8ODdCpIrM9 UUgN4kJCaRCM9WT4rPbPup7pGh+/vg54Mzf7KwaXmEZQlP1b///1HLtAmdNQBm7frxEgsJ0Ft2/ MfKHcQwoBLGGX1lMjIXcckEmcq/gTgm6ZMLlq2NnjOC3HLwVq0kBPHlYCDWg5aw0ofQ== X-Gm-Gg: AfdE7cluRZZwlc4sUefjPARVDGB893C53a62c6WEZ1vva+mra8Z4XNlaf1K5XyrfEW0 hs9hOrp/Gqp3cFWSIa13gYKdCKJ4jJm66DyrA+TM+bTEaOAGh8YObq6N2oWwnLp6gPCiD3pQ024 rqGpjyTFEMzcJQVvamluSvSN/jgsEF2q66/Nf2fT4zpJOfAkAg/qHsRz2gNyS1WmgWAbwc+imGy J7OkxSEMeCWYyzckjSSxvrITyb6720SdeR/Iw1UXN1iBCDjrUceV9aJO2/vbV+HTxg2j4nQ+bip CxTxOapUIuUj2sYgMNLhlqsDihd1dPhD/e4fNCLMqRp3JsDXrXEXxxsTzsNvvI7TJsB/Y70GZMf sLSN2GT60bzBYgxOmbs/tlaZu+u4RhEOwDVw6RDOirfl1MWW4ubtGc/tFWw== X-Received: by 2002:a05:620a:808c:b0:92d:f034:7c39 with SMTP id af79cd13be357-92ebb59067dmr88016585a.55.1783345771882; Mon, 06 Jul 2026 06:49:31 -0700 (PDT) X-Received: by 2002:a05:620a:808c:b0:92d:f034:7c39 with SMTP id af79cd13be357-92ebb59067dmr88011585a.55.1783345771214; Mon, 06 Jul 2026 06:49:31 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 26/32] target/arm: Inline check_watchpoints() in arm_debug_check_watchpoint() Date: Mon, 6 Jul 2026 15:45:21 +0200 Message-ID: <20260706134527.84808-27-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706134527.84808-1-philmd@oss.qualcomm.com> References: <20260706134527.84808-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfXzI6rRo3FHbCH 2mvc2BR6ZwYUSQQkO0OtpQWH0fNzaa1T0NsZwh/2rMX/XBioxuGj6xB9Z1zVwq4cQDAP2JB8BVh IdXl3laK0K15x5gZrFnKjGSfbEJoR8Amv0qHYC5eg7pUnz9l71Nl7V7/9TmjTkqpjuOgvmVb/vA wb2V0UcQFfE7bTik67Fk/qc7f6L2j8EAehG4D97jV8hp6Cdq5zns6IeD/wrac6eDVRx0cHdQEXB ppkzin0qEfe9ZVUnjCZPkwrMty3y2znJtcdt3Is4j/EJyIdbRfcqqOgS3gEE6jfSS43YpXyh6ku IT5ns8ufS3vrCNrKLjJjDuu/CbzbqcAUDv+c6cswrOby+HHSKeJbx3/q/P/zzZKvqxDcQJDWeyH 579EAiXhingz6M/89EWtL2BJmxB6kepI59BccaMgl1YCa+DckGJzw0eHHhkZ6SVpK6dkKRgAZsm TH3ADeOwE9dbJGRTrag== X-Proofpoint-ORIG-GUID: 76M2pc7civTDQvyDNWe1okMMnvh34MFd X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfXwdHo+OK2u6w1 H6axgzaCqxeVMoBlITMOkJ4rxEnLQsWLrXScvuucAJDpJtNirl0lcPfgD9REzPfhZwpsgFu2/wT Y8MfpOBqjGmucSbAosEAtgu0lnhKRLs= X-Proofpoint-GUID: 76M2pc7civTDQvyDNWe1okMMnvh34MFd X-Authority-Analysis: v=2.4 cv=f9N4wuyM c=1 sm=1 tr=0 ts=6a4bb26c cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=PLEY+c9/kVlxBKEpvFYBUQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=FSafjcPV3XuXVNEPM0UA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 impostorscore=0 bulkscore=0 suspectscore=0 clxscore=1015 spamscore=0 phishscore=0 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060141 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783345858886158500 check_watchpoints() is called once, by arm_debug_check_watchpoint(), which doesn't do more than this call. Merge both. No logical change intended. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-ID: <20260705215729.62196-27-philmd@oss.qualcomm.com> --- target/arm/tcg/debug.c | 40 +++++++++++++++++----------------------- 1 file changed, 17 insertions(+), 23 deletions(-) diff --git a/target/arm/tcg/debug.c b/target/arm/tcg/debug.c index 07a52643e71..528d2889c3a 100644 --- a/target/arm/tcg/debug.c +++ b/target/arm/tcg/debug.c @@ -351,28 +351,6 @@ static bool bp_wp_matches(ARMCPU *cpu, int n, bool is_= wp) return true; } =20 -static bool check_watchpoints(ARMCPU *cpu) -{ - CPUARMState *env =3D &cpu->env; - int n; - - /* - * If watchpoints are disabled globally or we can't take debug - * exceptions here then watchpoint firings are ignored. - */ - if (extract32(env->cp15.mdscr_el1, 15, 1) =3D=3D 0 - || !arm_generate_debug_exceptions(env)) { - return false; - } - - for (n =3D 0; n < ARRAY_SIZE(env->cpu_watchpoint); n++) { - if (bp_wp_matches(cpu, n, true)) { - return true; - } - } - return false; -} - bool arm_debug_check_breakpoint(CPUState *cs) { ARMCPU *cpu =3D ARM_CPU(cs); @@ -426,8 +404,24 @@ bool arm_debug_check_watchpoint(CPUState *cs, CPUWatch= point *wp) * is also an architectural watchpoint match. */ ARMCPU *cpu =3D ARM_CPU(cs); + CPUARMState *env =3D &cpu->env; + int n; =20 - return check_watchpoints(cpu); + /* + * If watchpoints are disabled globally or we can't take debug + * exceptions here then watchpoint firings are ignored. + */ + if (extract32(env->cp15.mdscr_el1, 15, 1) =3D=3D 0 + || !arm_generate_debug_exceptions(env)) { + return false; + } + + for (n =3D 0; n < ARRAY_SIZE(env->cpu_watchpoint); n++) { + if (bp_wp_matches(cpu, n, true)) { + return true; + } + } + return false; } =20 /* --=20 2.53.0 From nobody Sun Jul 26 11:01:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783345882; cv=none; d=zohomail.com; s=zohoarc; b=U/Qal1VpyrMM5K4v+JV3gt3eJURYIpafDwre8GVb4DncKgKiu5WPu0Au4/Hr61pe3ETAQD2L060CpGgC8kmz3Li3QLd60YhzLNM1/6I9Yssb3fft1z09wc+Atn5uQynZFetHfxYLm+n68if291Hy/s8ICoH9vu9c1eWRpH0wPR8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783345882; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=95uP1MDX1SArng5LXH/Zib9HBpw+pSTQCshJHngSnZI=; b=PWY946Fp+nYAomz9vZnE4n3RQ8KH9SAP3AXwYdtGs0i43yg+6k2AUvSiDXokQX8i60BmexTxyCU+dZPPUO7jXUHlnItjPYy5KgCMeGtSf/8fWRwgYusdyAxtDHtmlNJSs0xcurHQq3QpJRAL6MglYevD+RW/zltyqm48NCxDMK8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783345882156916.1936957186664; Mon, 6 Jul 2026 06:51:22 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgjhi-0006CL-9R; Mon, 06 Jul 2026 09:49:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjhg-00069Y-IH for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:49:44 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjhf-0007E8-1E for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:49:44 -0400 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666AxIHx387415 for ; Mon, 6 Jul 2026 13:49:42 GMT Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f8a3r0wd7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 13:49:41 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92ac0a54110so342924485a.2 for ; Mon, 06 Jul 2026 06:49:41 -0700 (PDT) Received: from localhost.localdomain (1.171.88.92.rev.sfr.net. [92.88.171.1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47a9de1d905sm25147271f8f.2.2026.07.06.06.49.39 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 06 Jul 2026 06:49:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 95uP1MDX1SArng5LXH/Zib9HBpw+pSTQCshJHngSnZI=; b=dqhS88I7umOEhT/+ T1SXeb+aWd0UJq9tzfPCVgNULgbMS2WGVyg6PjEq6n8DUScIswvtV1h05rFaCcbM /ItXvMcVX+jno60+7k4VgYArnOibBaNYPUZ/nJ3L1xUYDVXsY+jXHuQEdtLZKma2 l+OgQZNgZ0kgDWvMGl6s5ei2lcdQLG9aUa9T7Ztz0+5gtXHlNcjCKa4hJchq/AMz Cqspo2ekR6U0Dt10EHSPEBwwEayfo08LkjIDxtG6dgthc/B7HoY3jLF303BdG8ez iiiBRp3hLZCKLKWFt9RDjNwATWf/MNA0O1743JkG2T1LKbw0yVNj4MsLX3nDwIep 08GEVg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783345781; x=1783950581; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=95uP1MDX1SArng5LXH/Zib9HBpw+pSTQCshJHngSnZI=; b=av7OOBXaaLOaw+4HVsv3+Bq++cgK2p6sfEknJSo8UCJxtZXHQaWexQuUZO7NmQDOE/ XFX8RbbmFqa6VbEFhekTDrd1FGizlV0F0/r5DZ4B2/ZxuYy//uYhc3yIi4aNSCiWdJnI mwRL9dCnA81P5jkaw5ch3dyTCz+vKtglyuarezAsqtTjDo1v+tEQYcD/XZ27+7rPPdNT nH9gz444/O4vtCKLwGCAa+LSUO4TJbBkfO5Bscil0K6BtxByu9cDJSEjVJcxTkF70f1S Cf8I/9xqx4RdsFPM4rumYo5ZfPHFlljr8LS3bvZhV0C0tDiMV4TKfemp3Rl3Lpc+ymJA X9Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783345781; x=1783950581; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=95uP1MDX1SArng5LXH/Zib9HBpw+pSTQCshJHngSnZI=; b=ZVjlMl5wOVDfCMZ/hH8sRpsYJDAtMDdVy4YLwAtmVVmfcNmmfa91EK6Iy/aw9HKt9s 1ZKo9eCxmt8ob26m5VCdkJ1pm3FYg0iW9HlnZ7oz/6uFGs6ZJTlwxdV3w6ccJ+A955nj uUOuomsUdoJ+awjdvHMxCc4brOeJPZO8eKpSzqMnfMBLDLyR/o3/N6QzjQik08ZyaH3J QJT3VKS+HappzvxBsASwAiOgPF+bsOzl9kOoC8kl2o2oWvZTZO3fVazkjUJAR4zU0cgI jgd8K4hqCkjJ4Zk5y0yV6Kb46O7KecUoj8FexYJUF1w4kHRsMtWKBVb2E6X789Q1XKBe h+qw== X-Gm-Message-State: AOJu0YyoeHNmOCruI3XGsLuPYOulbzMoyJtuU9L/i1zsuBxNy7sRXXez GjML+7LFoAsTLqRGYrJJeg5fiR4IbYQRdbvM9a16uWV5Clx7a3E2+gtkCGMQOP2+6Blz93o6zz8 TAd6qJzJLeGufdImfJ7HqrlEduWH9s8A6sx5HfCXE8mUvv4OaZpYHR7CDiatmgpxhww== X-Gm-Gg: AfdE7cm+2Ko3UVVdJNgjBN8YM1CP7uZ12vIsT61SR1seZY2FsxEoyCZWD8ZCsYMfdyG CdXLpCeQCJbHHxKWn5aPkewuW4fGr5232nlME0IWeyzYjorb6jgEQsBY+8AAfG6tecHVbkKSMfH VxqlpnKNmhOW0yg7nSZapx9nYyGDYY98lNHlQj0e52MNVE1C9X+bcbGZkIsGW9GnbtoX9jzZSpN hk+9wY5tQTyZLrsFr46tWfzPGutkSiY5jPnN+FqrFvs4jM5jm/QmnFLbRqfT8MufDT8jLlKvN0W sLZK9wt8uYIvCKnH1e7y1Mtg0bEi3Kg1QbRxiY+EXw3b5h9RifUq1FU4Pth8qGpPih5qA4nQuaa 2/4DH/gAz9yZyP1dAzAFKOfFa1KH36zW8wgEDR67AzNEmmq2H71Ay9ycy+g== X-Received: by 2002:a05:620a:2913:b0:92e:5610:e479 with SMTP id af79cd13be357-92ebb5ef0cdmr94035885a.52.1783345780988; Mon, 06 Jul 2026 06:49:40 -0700 (PDT) X-Received: by 2002:a05:620a:2913:b0:92e:5610:e479 with SMTP id af79cd13be357-92ebb5ef0cdmr94031585a.52.1783345780448; Mon, 06 Jul 2026 06:49:40 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 27/32] target/ppc: Ensure TCG is used in ppc_update_daw() Date: Mon, 6 Jul 2026 15:45:22 +0200 Message-ID: <20260706134527.84808-28-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706134527.84808-1-philmd@oss.qualcomm.com> References: <20260706134527.84808-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfX8ePfC5/wburJ A9CNQBoZHEFK0I4Bjp/nzn5uKbA4/N82iYAj88+MBFwhK+gpwNKY3LHkm12w1hOxh3q24oC1Rkv nt16QtgkHSLc5nwnp3OClvI6n0bqERiUbIQjXCgCl8phqsQ/pDg+5Uk2vgWquoN4K//BsEuosqq vrGlwf+FPsORZcY3Jmn84x6fl1E19fwo4dEIaZLbq3U1z857Y3ePsOnYlkJujjb6myI0PP1yK4/ Rn+m233kOexne6UmvUVXJC582QOIkb9z2WCDQKhO5uV39mKD7JrX92MRXim9oEFgMb6cbmfA+qc /lYrg3hc10usMPJeRXqhNmOJyrdxIsSsVg9K+wLZ0Os5zK+XgJyWXN1AnKUjuek57BBn+U0vjfv 7vmANDC/bqJglib+OdNiEHmqB2cSMFk/dbOyPxOrKyfwerBukr2gkUxeYUS6Rdas9nNRE0VSBhX 82TCkqQf3//0sKVVVyw== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfXybL8TIOxsmYH HKI/8SR1wTF59IApKSSOM8mi9KN2zaA/O06Dtde7un8PMKHGYpcwy+F658ID/XhhCSwyemuk4W/ 6ypEqEmlRoAew0grT/bJ4+xSC+kweuA= X-Proofpoint-GUID: jBH258jzUsVrVhoJzJV3mjZikQfIXyqY X-Proofpoint-ORIG-GUID: jBH258jzUsVrVhoJzJV3mjZikQfIXyqY X-Authority-Analysis: v=2.4 cv=OKcXGyaB c=1 sm=1 tr=0 ts=6a4bb275 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=PLEY+c9/kVlxBKEpvFYBUQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=nS8E-dRYisaDM6zJQEoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 malwarescore=0 clxscore=1015 suspectscore=0 spamscore=0 phishscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060141 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783345883166158500 Per commit d5ee641cfc5 ("target/ppc: Implement watchpoint debug facility for v2.07S"), only TCG is implemented: ISA v2.07S introduced the watchpoint facility based on the DAWR0 and DAWRX0 SPRs. Implement this in TCG. ^^^^^^^^^^^^^^^^^^^^^ Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Message-ID: <20260705215729.62196-28-philmd@oss.qualcomm.com> --- target/ppc/cpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/ppc/cpu.c b/target/ppc/cpu.c index 41edb18643d..47467ee1635 100644 --- a/target/ppc/cpu.c +++ b/target/ppc/cpu.c @@ -147,6 +147,8 @@ void ppc_update_daw(CPUPPCState *env, int rid) vaddr len; int flags; =20 + assert(tcg_enabled()); + if (env->dawr_watchpoint[rid]) { cpu_watchpoint_remove_by_ref(cs, env->dawr_watchpoint[rid]); env->dawr_watchpoint[rid] =3D NULL; --=20 2.53.0 From nobody Sun Jul 26 11:01:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783345958; cv=none; d=zohomail.com; s=zohoarc; b=a6/1Gl6viTCtaBJGBcOe6vbYTmHs7ZVhTZgjTfmxiBX43fxIKqcuORe9MtKJyHYxLG1o51VGzwrBtX5lh/0KzX+kkyMdRzIokamUa9BJSf7256fsddM0GbhYTCeQ63TK35GQ3ffAeic3JlnGh476b3iGaVhAL+ZhxFcM6NoOoXg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783345958; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=cGnamiTRYUgEc4DFS7LafOuXM7GAB1v9CFpTervKBzo=; b=LYBoMCcBJOjCYjtnDakLbBcQG3mTomiV7ujdkPCHUk3IztSzEMddmKz9NlBXy+GmlbYzfRHu5L+Y1LsL3WgFJsDfhxFxEWwB6jZ3MtrGZNyyZfQQDBM/VN1vwhy3N8FvIRmzCwauwwA0GSDG/2CQVUN6aIqMqSKfvTMJlD/EIGw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783345958383858.3512734291122; Mon, 6 Jul 2026 06:52:38 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgjht-0006UC-8s; Mon, 06 Jul 2026 09:49:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjhp-0006Qz-Tw for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:49:53 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjho-0007Ej-5y for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:49:53 -0400 Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666AxPb5369525 for ; Mon, 6 Jul 2026 13:49:51 GMT Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f88h99cdv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 13:49:51 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-92e6ed4fe99so520888685a.0 for ; Mon, 06 Jul 2026 06:49:51 -0700 (PDT) Received: from localhost.localdomain (1.171.88.92.rev.sfr.net. [92.88.171.1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493ccdabda3sm290309865e9.5.2026.07.06.06.49.48 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 06 Jul 2026 06:49:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= cGnamiTRYUgEc4DFS7LafOuXM7GAB1v9CFpTervKBzo=; b=gXYPztZzM1jg3cia uzV4OMHVlGNaA74vsxfcYjFrMj3I8f7pk8NjEsMDh2tCDPBbuFdNC8v2FWqeP6ws NJlhWbd81Olu0J3ub4/NbHKMEkItujVMOA7RtNO6ma93U3LWVl3b5H/3rwNbH3of hN5bxGmlLLzp5FFChneNHJlH6jbFZPejA4zrO5/wFL5o5CXeCixkEpSIwls8yZY1 1JTel77IK9WNYwStUXmtu3rhysUimShYpViVHjJLx5DECaNdmjOhsQIy5pb/s6Yk TopnmPYb016wYmvf5kQz94idGoRySC8yKlQgzpdtTGuUqwbw1WAALEE/mZ/rF6yw y9sNDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783345790; x=1783950590; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=cGnamiTRYUgEc4DFS7LafOuXM7GAB1v9CFpTervKBzo=; b=MCVLi+cbpAjhuWcvN6cfVGNqJeurTeCOAhnVgAXwiej0YDU7PT/6to4d7l3Rrpxiyu ljzkFH+DRlDqCvSQ8st7JSW8FWW1x7cCbOk+4+DEFByA8NNtQoGBDpy4PKJ4bggSyYyP HUHv1ytNFqJSpS2iTtU0kGo941pNlUloglpha26U44WFRBbRzb8y+CAE7rPJ/WGzc/IC MR2nvNO/loCJijmgl+xCZGsdkOSxNJgGoXRC/U4Ku6b9LaxOR2zRyTzITDBANew0dtu7 5q3J/dUPcuJbszMKSamdj/CrncqFppSyphAclp11JlC31uktS/S6TCwsWmLiHF1wAXPk DBbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783345790; x=1783950590; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=cGnamiTRYUgEc4DFS7LafOuXM7GAB1v9CFpTervKBzo=; b=pk8oARIlaQDV1VlrBOPGsDH4iyDt43xzNrT0xnB0/J8kPAJX0yOH2BCjFT05o/03v/ mImsYX9l9vYS9xPDpfL9AICRMIMPX4BdEnD5HmWfXjZFomsT96s+4RUS2MBNVc+e4mBD U+ia3YDUpkOmjV3rFD7rUgsnWsSoWvVisv17aXVfVPgGofz4C0DXJFznrumPCc7p73x2 JYf8U+ONhs09ks6OCM0/SO951akap6+vHkgP5i23USZzGZMSc4PWxK3jgCYiLS2IukeW y5B6Kcg3s6lMfbpX1vWwzJyszDg/THn+YZbNDkGeOWLxTdlkhR+LYCZjb/LlWYN/otZJ SXsg== X-Gm-Message-State: AOJu0Yy9J1IDYzuNCYTXMTs+3yaOnvF+ajNqSLQ8/y6kJuyAMZusVoEG FItIalsx7Q5Vt2HXdZ9GFttiByyiNAkUG/v+YqSdhHyQJefBB/VvY9MFJeD2t0xrlJHMrzjf3bH SFWn6PIsp0XTZM3U+/t4kElHDkG/5cvARMX7Z0MT9STYGZ7p8j1+YmaIFCkpq/lfGLw== X-Gm-Gg: AfdE7clWEondB9HW5Hhqy5Vv1tfL82ataFMU+payLTY/T6m7YvhMcW7YU4tLz/DBtRu r0WBZkVVuZFPGuMIJB0x615Gx+NWqJRMP6gXDr4UtadLc3Q/gxsgTe8R/I8PUyKH1ieScs8ilwD BBXavJtZjQmMssdlIdBc/PEaDEcKaU++/8hQM3ijZnGLqZso2sjQrpzMmqg433gICt+TGzjhgOu JKIG9CnzcyZUQooMoezgvJelR98RfrdH497Iplo98OU1OQXsD6m/0VZFu+uO0x6CPpA+UGQThAs IlGWmgMzG7/ig7TiLUnDT6H0W6W6qhwZpYBp1IZZ2dsYhZHYUksJOm3LAGzbs/bttePiXgOt+kv vsZQZ8GehPCpyIHRYVItH8O+2N9qZJH04HBerJ0XDPnjDiESsf72n0131Zg== X-Received: by 2002:a05:620a:170c:b0:915:abc4:b570 with SMTP id af79cd13be357-92ebb56a756mr83856485a.48.1783345790360; Mon, 06 Jul 2026 06:49:50 -0700 (PDT) X-Received: by 2002:a05:620a:170c:b0:915:abc4:b570 with SMTP id af79cd13be357-92ebb56a756mr83851185a.48.1783345789683; Mon, 06 Jul 2026 06:49:49 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 28/32] accel/tcg: Improve docstrings around TCGCPUOps::*watchpoint* handlers Date: Mon, 6 Jul 2026 15:45:23 +0200 Message-ID: <20260706134527.84808-29-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706134527.84808-1-philmd@oss.qualcomm.com> References: <20260706134527.84808-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: tMQVnwqd_LzvWh-w6PuIYzIou_77C_gm X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfX3DjBC6k+vjPf S/LRv+8RhCRK+hDcCK1aVS7jBOWdlOTTlxy8O02ItKC7VjrRmJkZavIY0mrRfQ+vHct44UZ076A 2WsKAtNyK7bXb7R3DZBKxtlu3jvwJtA= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfX7o7jGGQy8Jgs cQTrQHa1xhHiC4ILWtUcTSiWa3bM8nRgpjVPpHO1YqLjiV8DbtDfqQBkOWiphkRCJJg8xyTGhUV O3WnIZzZVe8rn3RFChgnGukFjlflLnfiWBKWqwem3gSFsX5h+TP+/Kq3n2NJ/5raUW+yiBVXQrx myFcu7nZOeNp7KPttl+JALJ0l4rH7/Ks4HfhNioDh4OmELireZN59LbMuCVuQM+qz8uBd3i7DHW FUmEde57BDgdOWJOeVxteDZsSsM1JX7UsmudCnoAbJh05M2PH5DaFQW7VBhO0E7kh+hdqZp0TSs 3dQwIVd5vScuiwuwvNPrdmHDG4FClsFtKUTUxLc588g0rpgHppgqL1ykfTiN5Q0pO0MzlyNXHgK lc8+e4vEiOMhr10aEvK2TftJlq1CDHRarlz78rEZSJyeru5XBQrhFHusXDXtifZHfU1p3NSWq8e XI2MHx4Ih0mNFewpwEA== X-Proofpoint-GUID: tMQVnwqd_LzvWh-w6PuIYzIou_77C_gm X-Authority-Analysis: v=2.4 cv=GulyPE1C c=1 sm=1 tr=0 ts=6a4bb27f cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=PLEY+c9/kVlxBKEpvFYBUQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=oIGtIzObNEvw8K7fi1sA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 clxscore=1015 malwarescore=0 impostorscore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060141 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783345959727158501 Commit d5ee641cfc5 ("target/ppc: Implement watchpoint debug facility for v2.07S") also implemented TCGCPUOps::debug_check_watchpoint for PPC: make the comment generic. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson Message-ID: <20260705215729.62196-29-philmd@oss.qualcomm.com> --- include/accel/tcg/cpu-ops.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/include/accel/tcg/cpu-ops.h b/include/accel/tcg/cpu-ops.h index 710da12b828..3ff6e6810e0 100644 --- a/include/accel/tcg/cpu-ops.h +++ b/include/accel/tcg/cpu-ops.h @@ -250,14 +250,13 @@ struct TCGCPUOps { int mmu_idx, uintptr_t retaddr); =20 /** - * @adjust_watchpoint_address: hack for cpu_check_watchpoint used by A= RM + * @adjust_watchpoint_address: hack for cpu_check_watchpoint (used by = ARM) */ vaddr (*adjust_watchpoint_address)(CPUState *cpu, vaddr addr, int len); =20 /** * @debug_check_watchpoint: return true if the architectural - * watchpoint whose address has matched should really fire, used by ARM - * and RISC-V + * watchpoint whose address has matched should really fire. */ bool (*debug_check_watchpoint)(CPUState *cpu, CPUWatchpoint *wp); =20 --=20 2.53.0 From nobody Sun Jul 26 11:01:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783346014; cv=none; d=zohomail.com; s=zohoarc; b=QfscN/jUzVoeEBMjqOEtcvxhY3/2hp98RhrOn1AwGD3eS96hTEYeMsl6JvStpG0zF03FgjR6d5qLYH7gHJ2yLPQAEXQMH8Mb9KnaUYXLwzavQgvii3t+U6voAE6dErCiMoPSlZd+a1YYaMM4e6/Py7yMozdCYLO3AoQ86UIgf8w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783346014; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=zYdOdD4hbcBfRUXcyiGK2HCTv4qNg0oWG/XGXRvDlfs=; b=nV+oIx/vmnalnH+eBF+r7R/ojjcwXMMIkniqLGWAS2QWzVpbzcfDztPJWIcxSYFP29hLx+fEmPCeol33vlvALZZP8U3QtWrCMaNhRSTbknWeFzupD0Uld1JSbAAs0leduU8m07epFxQY7wWQ93e+6SrGIjIFLll6bebOccmtTEI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783346014688398.44049274113775; Mon, 6 Jul 2026 06:53:34 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgji7-0006q7-7o; Mon, 06 Jul 2026 09:50:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgji5-0006ll-2t for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:50:09 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgji2-0007Sw-UL for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:50:08 -0400 Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666Ax9DC391072 for ; Mon, 6 Jul 2026 13:50:05 GMT Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f89kgs1pu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 13:50:05 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e66f9e2baso299347185a.0 for ; Mon, 06 Jul 2026 06:50:05 -0700 (PDT) Received: from localhost.localdomain (1.171.88.92.rev.sfr.net. [92.88.171.1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493ccd9d607sm358984745e9.2.2026.07.06.06.49.57 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 06 Jul 2026 06:49:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zYdOdD4hbcBfRUXcyiGK2HCTv4qNg0oWG/XGXRvDlfs=; b=JTxFDAq/rjNHVo+H NNQ2bqCRabhZDb0MCz4p1CpaOQxMbbc6Nfy58Wes2hdXemY1gtlqvLUMyWyIao39 MzswYgkYJv36SRd1yzJVZTIRvwNrBt8ihOtwo+bL5jtOn7a9JhyJXy5o6okAzG6b 371Cy/fNav4VMu5nhP8aGnnKzRqKqTSL/AAf1Cv222mRSiCwjI4PE+6SZtjOssER fwl9GR9uIg51ImothirlJJjXNbXZX1uRVii5NLLtVpjjlF9P1C6OI5nrvwf0gcR0 oU+TaiH2gJGsfYkgunrjqiLkz0K47d8saM9I0z2On5GVyo/su4XVa80264HjkutZ CFFL2w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783345804; x=1783950604; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=zYdOdD4hbcBfRUXcyiGK2HCTv4qNg0oWG/XGXRvDlfs=; b=GSYUUy0K16DMlL0EFyvThQuSBRHKCzrC9MdcLj+Or6UZvC4Mg4TZD/GHqZx4RwDLfa UDpxlLOBYlzQVPjLB3eX1PtNnIzaRYvhYuRE2LkX+qyPqa3FmgVxsltmo7vrlo72gpku f9Zh3+e0gyEyXh+deyy5pKlZDZPDYWFVUQr0laPn36AcWQs3d6nlwsk5rGX2Iule+S8x zp4/3IKOmJYNSb2nswkxsTBxG/FD3YQecn7FczLkK/CxrRHvaItEMjqOpkZquC0V3lOt b9uqOCeB/gyTq45NhpuMyFu13+7r/j6rdSaA9w4VoZaEimJAnWQ9rLOk2E94+2/zUxlu v8oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783345804; x=1783950604; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=zYdOdD4hbcBfRUXcyiGK2HCTv4qNg0oWG/XGXRvDlfs=; b=X812KVxJ8GN3Swu+sZixM55eb9xDwvz4EqXCle/MdD5qCSn5mGuTzfCxmW6RYV3+1T 0DQSf5wFWnmvLzqU1Ta8AFfs3dQCVDrCWIktZt9W7DlYSu3AGWEzsjrN+5UZzuZOqxot nC/pvpNJlJTy9FChV9fZ2sZ/mkZ3uco7S0NDZh6kBZhMdbK3fbnSWMh4QQl90muavNK0 ftKZhg5uI3cfflhTGGRVRpPmObxIZdFb3M9qs3hT6OUjbv/Hr8HjmyfL9tBp5EA6TixJ Caw662EK+80sHA1Pk0Dgnw3X5iEVVZFCcj5R+bZccUZQOmUIckzOkvILfZIciMefIi3M 6HiQ== X-Gm-Message-State: AOJu0YwjJn6gGHrGj4Ivpwt/oY+DEBM1YqFsAD+jrfsKxFQxRVpZI+Es Uc8mxKajWUF9o11tADymWbg88eZrvE1XbaWAmGx+GELde3YhYC+dWhv9sKQN8XFSB+y3I6JxXOh MSUee3hoJ+2wQqw6l63rOmBFri2OO9mT85pzbj6FCwLjwAcGtXgUm+8eCNGV9ShGBgg== X-Gm-Gg: AfdE7cn8QxFJkRslx/M7o8Iue1+43gvVNJzjlWCOJsTeRZZ0JpTZzN7mlpPOazGNB3V zXqdYVtp3qAbs/IRzBLaZKHLIm/cdc/EtaJRKRyVOast4hFEWf+alLb1gpC5LhyZs2xaqdBfQnU SHV0tGKBi2K6xKVmwEh2a2xkZaCelpLF/A47PL71zGWEWDhE/pedJzCtnmGvCw8y57KulSgHc6m MPf4ZS087VuDSkSq71h70TlnYLp3CdE1MyxgDnZVhraAwwZ2N/ZEOFJUKOnWgdCJmuxfVUJFU5c tSfBIe0FUX78YmF6w+QHVL0O02dNXO1q/LJoQJPickSnHOzElDgKbbMQVT+W+zQzPbcKJaqVKnk RB/mtCu+3wmTroryIMfE4+ma8Xr1V7wa7pZrcJeF7izpWNa0odoZBrpCQlQ== X-Received: by 2002:a05:620a:2950:b0:915:6453:1ae with SMTP id af79cd13be357-92ebb4a82d6mr91395185a.14.1783345804403; Mon, 06 Jul 2026 06:50:04 -0700 (PDT) X-Received: by 2002:a05:620a:2950:b0:915:6453:1ae with SMTP id af79cd13be357-92ebb4a82d6mr91390685a.14.1783345803838; Mon, 06 Jul 2026 06:50:03 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 29/32] cpu: Better name cpu_single_step() trace event Date: Mon, 6 Jul 2026 15:45:24 +0200 Message-ID: <20260706134527.84808-30-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706134527.84808-1-philmd@oss.qualcomm.com> References: <20260706134527.84808-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: B54HaDQNUJ0RARnan65jwWOGUvdyZfbP X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfX/PwzD9kqGizi CZ5Be+1a6Fu5JUx3Q5aD6JqYqN5ceqom+QxG65AfrRKcqc85K0iPg3lQ1zGXdEYtkf0Hcg3VhN8 dBHRv3tUZUbBx0Skmj4R6nPvHyTDb6p0i9B+H9fiZthc0+5IHDi6u7SExSY9HBvogjgvKoKOkGm 0u2UUjfXj/9PuaSoYdJF9StLNou9ynZm0xZRBeGyrUpAFldAvVH3PVZB+vH3Y4RQjGaXMjW87r2 XIR+eBCLIaNFz3OZR17v6zJ9iVFJeQJFyBNCxqNQJKDdAdZzkhxT2pkIleXcgKiGMxfFOlOnsVc CLS0hOONe7pns27meUI7WgCw23n86BNH7cri81XwAOzi+vqE3P+uF7B78f9eE70A0XxiiuEzg28 tI3onSGj7r2+oc6LKRdaAliuAgliuI6th8Mj9HW9hFqkgqLgIG8/Yf6vKFSEVTul4Z7KyIL3W5t cuYYE4NHKkrxLOttMbg== X-Proofpoint-ORIG-GUID: B54HaDQNUJ0RARnan65jwWOGUvdyZfbP X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfX9EmfjOzVjGoL Iy2UVO4iT662wEidG4HPyG/0cnvm8YdnPU4VrK0ul7OoMWTmf+kvkELDmJsi75ZdEihgsOMlsQK +0j35TsZeDGSFgpbnqfkYr1gfHgBq7s= X-Authority-Analysis: v=2.4 cv=c6Sbhx9l c=1 sm=1 tr=0 ts=6a4bb28d cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=PLEY+c9/kVlxBKEpvFYBUQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=fWCg92Okmkq_k9tJrKMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 clxscore=1015 adultscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060141 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783346015976158501 cpu_single_step() is not related to breakpoints. Rename the trace event. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Message-ID: <20260705215729.62196-30-philmd@oss.qualcomm.com> --- cpu-target.c | 4 ++-- trace-events | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cpu-target.c b/cpu-target.c index f030e2c642e..019906b32eb 100644 --- a/cpu-target.c +++ b/cpu-target.c @@ -31,6 +31,8 @@ void cpu_single_step(CPUState *cpu, int enabled) { if (cpu->singlestep_enabled !=3D enabled) { + trace_cpu_change_singlestep_flags(cpu->cpu_index, + cpu->singlestep_enabled, enabled= ); cpu->singlestep_enabled =3D enabled; =20 #if !defined(CONFIG_USER_ONLY) @@ -39,8 +41,6 @@ void cpu_single_step(CPUState *cpu, int enabled) ops->update_guest_debug(cpu); } #endif - - trace_breakpoint_singlestep(cpu->cpu_index, enabled); } } =20 diff --git a/trace-events b/trace-events index faeba6242fa..ea1d2b11a22 100644 --- a/trace-events +++ b/trace-events @@ -28,7 +28,7 @@ # cpu.c breakpoint_insert(int cpu_index, uint64_t pc, int flags) "cpu=3D%d pc=3D0x= %" PRIx64 " flags=3D0x%x" breakpoint_remove(int cpu_index, uint64_t pc, int flags) "cpu=3D%d pc=3D0x= %" PRIx64 " flags=3D0x%x" -breakpoint_singlestep(int cpu_index, int enabled) "cpu=3D%d enable=3D%d" +cpu_change_singlestep_flags(int cpu_index, int old_flags, int new_flags) "= cpu=3D%d flags=3D0x%x -> 0x%x" cpu_exec_start(int cpu_index) "cpu=3D%d" cpu_exec_end(int cpu_index) "cpu=3D%d" =20 --=20 2.53.0 From nobody Sun Jul 26 11:01:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783345880; cv=none; d=zohomail.com; s=zohoarc; b=JyhjYc/pTNSZGjOcOXpZrGj3kk1UKFkRQJ6wFWG2RoBWwdjrZzT5s47HXcyPZbrEFYZgQzct0ZReS6i78jdtBLfeAcJMJ1FCMsaBnuBP0XsCQ9h4joWJOCMfwZ+C/0box5lZ2KSnILkp+kAOxAR2HJ77zuIgLo5LcuTcu+rVls0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783345880; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=QXJ+iKEc00iZKot2uTOwOulYp2cnZqhisjtrv59DNu4=; b=gbxBKuC53H0ZL1exJfwZIRkNwMTNIh2bb6DfEbj95n0jiACg4kP3U0acC55FdX7GHnC2e69TJhOoLQdVfUUQ7O1K+rUzAEMh3wSUnNLiPwEw7mBdhDUy0BzLoK6D843+Jk4Q7NMEw751nMn4ZZ56vf3hB0IJ1fqESgmbiFQBnSQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783345880523705.994488146841; Mon, 6 Jul 2026 06:51:20 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgjiJ-00075o-Qi; Mon, 06 Jul 2026 09:50:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjiG-0006z1-OB for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:50:21 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjiE-0007VJ-Gf for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:50:20 -0400 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666AxNvr395420 for ; Mon, 6 Jul 2026 13:50:16 GMT Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f89qph0se-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 13:50:16 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-91931144870so244410585a.1 for ; Mon, 06 Jul 2026 06:50:16 -0700 (PDT) Received: from localhost.localdomain (1.171.88.92.rev.sfr.net. [92.88.171.1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47a9de1d91bsm28880576f8f.4.2026.07.06.06.50.11 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 06 Jul 2026 06:50:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QXJ+iKEc00iZKot2uTOwOulYp2cnZqhisjtrv59DNu4=; b=OxiDGjTlD2gRvmtR Z9AY/YxOBx0vkKVAbMdBOlNV3c0b0DbUtN+RcKM1tj55fspYcGvVQ6Y79v7SMBVz UqoHfp2/wFe3aCu2Y7Vgv6IuKE8sqBm2aJjhfvUlYRi1XpOo4ldoueYWRBQ/jijf xmYt9Erx1EBmaCO4/gRtOWeyb4OPovArWPdn6197Lx0GoTD+yIrc/JPCmGym3+t/ M7CAvX8YL7ETBURxrHwwbXItbrl133UF52WOfHjcOr5z/RaICP11enfJLnWk1yt/ 0vBaSdKxwsoPk9oA4vuNJ7tCUx3tgF/p7VWgDkWdLFBc1ZLkTrp/BD71TmNx1HXW NclqQg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783345816; x=1783950616; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=QXJ+iKEc00iZKot2uTOwOulYp2cnZqhisjtrv59DNu4=; b=WzB/yaJsckBqtFyXEHKrGZf7IdF7eHap+sPJw54at7M/QRWEnGj3CSJ2SuxwJ+RNbP lq3punRsgP11jMtnrWqD0tfahrk/PWJxYndHohW1POOzuQPCTaAnhBtqluhhVSn0kWBW IEuW2DaJ8i2kjrGSj6kYi1Z7fnPwaVQ86CyRzX5hywwNffq2AsEJkUwnmb5STSZOsao0 q1biv88lWUxK3bJGBCIU36bWtwbUBhed3aOP8juWpZNHNxNiePoH9loasTfpzRVznySm DkRLKQl8DH0h2IX67+jOPhNxJTnKXlpGIXnaoDhcTc1eDtdLbwGYr+jN9S6WBMIBNbR7 bN8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783345816; x=1783950616; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=QXJ+iKEc00iZKot2uTOwOulYp2cnZqhisjtrv59DNu4=; b=lnI0OEQInDUoM5E7Eq7FY8A6BEdOpEK3jliDRJRFedNGGHDnHlCidAPXZbuTnYsz/V S1i3mWi+MxkvXU6XK3puXPY/bu0VZoN6hnnUrpWEFYoszF7SzDWbOGKEAzJbvgMQqUad gNFeLxWhbomrj+ACRX1Mk9q97FZT1TfUAZ7Vkn9+spX1bmUybuMUnYlQAfNoMrHyeBiJ iNujFQ+05S2g+WFxzuuIqi2gGA2Osa0eVwEl/C7YHvG7S1xJgQC5+ChHz3Dt/JrgJxT6 m/SxBug4X8nz1xYWqCX0QSim971HFZEPzaMHvlF9JQrR3mOYBU3xJ0wb6yeIB3gYC+wG v1AQ== X-Gm-Message-State: AOJu0Yz0fSpMxp7UPoq+rJVRObPgTxfCmfiQmIBMU3u8Y0Fm8MiXvJru pMqc6aj8u3+2pFtm0qhXAFSygINCzkOUBLouS7bNWspd0G0TKSWSbTrK9JhA1ZJ5WUzBHM/QQMP 9Rtw2mWtBI3OEqzZBxz4wBDQ6RPjGYo6tgvgdCdAxqNonyA8fLBdjhZ58b1Bgy1D/FA== X-Gm-Gg: AfdE7clncfcxlK7wgH7UXfff63D40MEHlySYWDkU8m+kgYjxY3OuXezCM0QDqCbUkQZ WjiUTfuUk3WY7T1dWG0Bbe9KJBK+IW11cJfcsDgQFxRu3QXvtofFXM7NDE0fngXkiPl5OVJkDxb HQbCQZtQPWuxe56YzvvMg7onRPY6A6qx7NhA3fGV279fm8F0B2f4tB4V0wmX8J/OPIAbmjQTRrV KGqC/mm1OqVTyH2A9M0R445sKiXJOICMWFkA1+U98If1rwYKfXPmWYtMGZOXXcy68zjW92YPt9K +uJsuJDfV1HlxlsxZO+KX+UE+KrW8HxPNxs9apKNiNGM9ftqkaQXbstEM0JMIQX6PmemNyIH/Dx ZRZh9eDpEMIFHa9n2KPr/dy3deWnMeRf4za6MiziEJ9Cn1YT0uM/JquImSA== X-Received: by 2002:a05:620a:1a0b:b0:92e:7ba3:740d with SMTP id af79cd13be357-92ebb5c0dbfmr80255685a.68.1783345815667; Mon, 06 Jul 2026 06:50:15 -0700 (PDT) X-Received: by 2002:a05:620a:1a0b:b0:92e:7ba3:740d with SMTP id af79cd13be357-92ebb5c0dbfmr80247085a.68.1783345814643; Mon, 06 Jul 2026 06:50:14 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 30/32] cpu: Introduce cpu_single_stepping() helper Date: Mon, 6 Jul 2026 15:45:25 +0200 Message-ID: <20260706134527.84808-31-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706134527.84808-1-philmd@oss.qualcomm.com> References: <20260706134527.84808-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=c6qbhx9l c=1 sm=1 tr=0 ts=6a4bb298 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=PLEY+c9/kVlxBKEpvFYBUQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=UzDBcLQVJa3M_3ASbYsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=O8hF6Hzn-FEA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: 1A_BGLb9A4diUqUEgKJZ1RG2-2mV7pMZ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfX9gSlwhG0gbPK u9Ba1r1O1DUXhsbClGkfyY43QRLWG8BttuNgA+ro58lYlLMHmthkoC6QmVYOddNt4E9Mrl5qnXQ cXKXOuYEODeYTsZzw5MPlQ3Axjio7bAnLbpdvz73HYhRsbLJwVV25j9KZSZd9wtetFTcqn8xcUZ 7PWt5yBVIQjJm8xNVLyogZG+26tSMRoeJqIIhvb5VO1BF9wkfNWVmelaY8SISp4Ke1o7aNlN6dZ Sm90+AFiEPKUhnPbze6a56PLLRKi3Eo0Mg2mgtEk99UlGR3+JMFFNssyAcoQ+6c3XrC5LbbM+6Z JxQxh5zxuLLhJZFV9Bpaoc5dBmftlIOq6d+lMYWd3vN+nCTvCkdH+rlRVjfYsk2dnXrG9j7LUTt 0Q3MUytyMlyXYGlsi35DZavWPIzf9m4o6OUYEUpX7rlxLks+Gn7iZFk1LwZrZeOZLyiZbcXnjyX BJFyFQK9k4N0uUHCI6w== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfX9PdkVJ8Ogp5F bu/IegclDSJD249BsksWlQtY+fAOLJiuK8TZ2tTgxJ0c/+0gwVbZOBjVbYpO9YmgU9dh6+7CfwW OQ7VKKlLHmMRG5EZz1jw0sY1GBrHamM= X-Proofpoint-GUID: 1A_BGLb9A4diUqUEgKJZ1RG2-2mV7pMZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 impostorscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 clxscore=1015 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060141 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783345881390158500 Access CPUState::@singlestep_enabled field with a helper. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-ID: <20260705215729.62196-31-philmd@oss.qualcomm.com> --- include/hw/core/cpu.h | 11 +++++++++++ accel/kvm/kvm-all.c | 2 +- accel/tcg/cpu-exec-common.c | 2 +- accel/tcg/cpu-exec.c | 8 ++++---- linux-user/riscv/cpu_loop.c | 2 +- linux-user/s390x/cpu_loop.c | 2 +- system/cpus.c | 2 +- target/arm/hvf/hvf.c | 8 ++++---- target/arm/kvm.c | 2 +- target/i386/kvm/kvm.c | 2 +- target/i386/whpx/whpx-all.c | 6 +++--- target/loongarch/kvm/kvm.c | 2 +- target/microblaze/translate.c | 2 +- target/ppc/kvm.c | 2 +- target/s390x/kvm/kvm.c | 2 +- 15 files changed, 33 insertions(+), 22 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index e5b68bced3d..00f6c5d5de7 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -1138,6 +1138,17 @@ void qemu_init_vcpu(CPUState *cpu); */ void cpu_single_step(CPUState *cpu, int enabled); =20 +/** + * cpu_single_stepping: + * @cpu: The vCPU to check + * + * Returns whether the vCPU has single-stepping enabled. + */ +static inline bool cpu_single_stepping(const CPUState *cpu) +{ + return cpu->singlestep_enabled; +} + int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, int flags, CPUBreakpoint **breakpoint); int cpu_breakpoint_remove(CPUState *cpu, vaddr pc, int flags); diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index feffca0d82d..963a4edd262 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -3812,7 +3812,7 @@ int kvm_update_guest_debug(CPUState *cpu, unsigned lo= ng reinject_trap) =20 data.dbg.control =3D reinject_trap; =20 - if (cpu->singlestep_enabled) { + if (cpu_single_stepping(cpu)) { data.dbg.control |=3D KVM_GUESTDBG_ENABLE | KVM_GUESTDBG_SINGLESTE= P; =20 if (cpu->singlestep_enabled & SSTEP_NOIRQ) { diff --git a/accel/tcg/cpu-exec-common.c b/accel/tcg/cpu-exec-common.c index e48ea31373f..44e84344f3b 100644 --- a/accel/tcg/cpu-exec-common.c +++ b/accel/tcg/cpu-exec-common.c @@ -47,7 +47,7 @@ uint32_t curr_cflags(CPUState *cpu) * For singlestep and -d nochain, suppress goto_tb so that * we can log -d cpu,exec after every TB. */ - if (unlikely(cpu->singlestep_enabled)) { + if (unlikely(cpu_single_stepping(cpu))) { cflags |=3D CF_NO_GOTO_TB | CF_NO_GOTO_PTR | CF_SINGLE_STEP | 1; } else if (qatomic_read(&one_insn_per_tb)) { cflags |=3D CF_NO_GOTO_TB | 1; diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index d7f91dce9db..0386ac49551 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -308,7 +308,7 @@ static bool check_for_breakpoints_slow(CPUState *cpu, v= addr pc, * so that one could (gdb) singlestep into the guest kernel's * architectural breakpoint handler. */ - if (cpu->singlestep_enabled) { + if (cpu_single_stepping(cpu)) { return false; } =20 @@ -485,7 +485,7 @@ cpu_tb_exec(CPUState *cpu, TranslationBlock *itb, int *= tb_exit) * raise a debug exception. Single-step with another exception * is handled in cpu_handle_exception. */ - if (unlikely(cpu->singlestep_enabled) && cpu->exception_index =3D=3D -= 1) { + if (unlikely(cpu_single_stepping(cpu)) && cpu->exception_index =3D=3D = -1) { cpu->exception_index =3D EXCP_DEBUG; cpu_loop_exit(cpu); } @@ -732,7 +732,7 @@ static inline bool cpu_handle_exception(CPUState *cpu, = int *ret) bql_unlock(); cpu->exception_index =3D -1; =20 - if (unlikely(cpu->singlestep_enabled)) { + if (unlikely(cpu_single_stepping(cpu))) { /* * After processing the exception, ensure an EXCP_DEBUG is * raised when single-stepping so that GDB doesn't miss the @@ -849,7 +849,7 @@ static inline bool cpu_handle_interrupt(CPUState *cpu, * raised when single-stepping so that GDB doesn't miss the * next instruction. */ - if (unlikely(cpu->singlestep_enabled)) { + if (unlikely(cpu_single_stepping(cpu))) { cpu->exception_index =3D EXCP_DEBUG; bql_unlock(); return true; diff --git a/linux-user/riscv/cpu_loop.c b/linux-user/riscv/cpu_loop.c index eecc8d15178..6f27a06da49 100644 --- a/linux-user/riscv/cpu_loop.c +++ b/linux-user/riscv/cpu_loop.c @@ -68,7 +68,7 @@ void cpu_loop(CPURISCVState *env) } else if (ret !=3D -QEMU_ESIGRETURN && ret !=3D -QEMU_ESETPC)= { env->gpr[xA0] =3D ret; } - if (cs->singlestep_enabled) { + if (cpu_single_stepping(cs)) { goto gdbstep; } break; diff --git a/linux-user/s390x/cpu_loop.c b/linux-user/s390x/cpu_loop.c index 67d2a803fbc..25f19f725e7 100644 --- a/linux-user/s390x/cpu_loop.c +++ b/linux-user/s390x/cpu_loop.c @@ -87,7 +87,7 @@ void cpu_loop(CPUS390XState *env) env->regs[2] =3D ret; } =20 - if (unlikely(cs->singlestep_enabled)) { + if (unlikely(cpu_single_stepping(cs))) { /* * cpu_tb_exec() did not raise EXCP_DEBUG, because it has = seen * that EXCP_SVC was already pending. diff --git a/system/cpus.c b/system/cpus.c index b31c825b464..97e5a5edee2 100644 --- a/system/cpus.c +++ b/system/cpus.c @@ -344,7 +344,7 @@ bool cpu_can_run(CPUState *cpu) void cpu_handle_guest_debug(CPUState *cpu) { if (replay_running_debug()) { - if (!cpu->singlestep_enabled) { + if (!cpu_single_stepping(cpu)) { /* * Report about the breakpoint and * make a single step to skip it diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index d5b1966a867..640ef665593 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -2340,7 +2340,7 @@ static int hvf_handle_exception(CPUState *cpu, hv_vcp= u_exit_exception_t *excp) case EC_SOFTWARESTEP: { ret =3D EXCP_DEBUG; =20 - if (!cpu->singlestep_enabled) { + if (!cpu_single_stepping(cpu)) { error_report("EC_SOFTWARESTEP but single-stepping not enabled"= ); } break; @@ -2549,7 +2549,7 @@ static int hvf_handle_exception(CPUState *cpu, hv_vcp= u_exit_exception_t *excp) assert_hvf_ok(r); =20 /* Handle single-stepping over instructions which trigger a VM exi= t */ - if (cpu->singlestep_enabled) { + if (cpu_single_stepping(cpu)) { ret =3D EXCP_DEBUG; } } @@ -2868,7 +2868,7 @@ void hvf_arch_update_guest_debug(CPUState *cpu) CPUARMState *env =3D &arm_cpu->env; =20 /* Check whether guest debugging is enabled */ - cpu->accel->guest_debug_enabled =3D cpu->singlestep_enabled || + cpu->accel->guest_debug_enabled =3D cpu_single_stepping(cpu) || hvf_sw_breakpoints_active(cpu) || hvf_arm_hw_debug_active(cpu); =20 @@ -2882,7 +2882,7 @@ void hvf_arch_update_guest_debug(CPUState *cpu) cpu_synchronize_state(cpu); =20 /* Enable/disable single-stepping */ - if (cpu->singlestep_enabled) { + if (cpu_single_stepping(cpu)) { env->cp15.mdscr_el1 =3D deposit64(env->cp15.mdscr_el1, MDSCR_EL1_SS_SHIFT, 1, 1); pstate_write(env, pstate_read(env) | PSTATE_SS); diff --git a/target/arm/kvm.c b/target/arm/kvm.c index 01f42f42538..d40a6a98591 100644 --- a/target/arm/kvm.c +++ b/target/arm/kvm.c @@ -1492,7 +1492,7 @@ static bool kvm_arm_handle_debug(ARMCPU *cpu, =20 switch (hsr_ec) { case EC_SOFTWARESTEP: - if (cs->singlestep_enabled) { + if (cpu_single_stepping(cs)) { return true; } else { /* diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c index 1e09155e92c..4272b6770c7 100644 --- a/target/i386/kvm/kvm.c +++ b/target/i386/kvm/kvm.c @@ -6250,7 +6250,7 @@ static int kvm_handle_debug(X86CPU *cpu, =20 if (arch_info->exception =3D=3D EXCP01_DB) { if (arch_info->dr6 & DR6_BS) { - if (cs->singlestep_enabled) { + if (cpu_single_stepping(cs)) { ret =3D EXCP_DEBUG; } } else { diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index 11b5d1fc607..634d5428219 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -2266,7 +2266,7 @@ int whpx_vcpu_run(CPUState *cpu) } } =20 - if (exclusive_step_mode !=3D WHPX_STEP_NONE || cpu->singlestep_ena= bled) { + if (exclusive_step_mode !=3D WHPX_STEP_NONE || cpu_single_stepping= (cpu)) { whpx_vcpu_configure_single_stepping(cpu, true, NULL); } =20 @@ -2283,7 +2283,7 @@ int whpx_vcpu_run(CPUState *cpu) break; } =20 - if (exclusive_step_mode !=3D WHPX_STEP_NONE || cpu->singlestep_ena= bled) { + if (exclusive_step_mode !=3D WHPX_STEP_NONE || cpu_single_stepping= (cpu)) { whpx_vcpu_configure_single_stepping(cpu, false, &vcpu->exit_ctx.VpContext.Rflags); @@ -2648,7 +2648,7 @@ int whpx_vcpu_run(CPUState *cpu) cpu->exception_index =3D EXCP_DEBUG; } else if ((vcpu->exit_ctx.VpException.ExceptionType =3D=3D WHvX64ExceptionTypeDebugTrapOrFault) && - !cpu->singlestep_enabled) { + !cpu_single_stepping(cpu)) { /* * Just finished stepping over a breakpoint, but the * gdb does not expect us to do single-stepping. diff --git a/target/loongarch/kvm/kvm.c b/target/loongarch/kvm/kvm.c index beda6965f8c..48cdb78a4ca 100644 --- a/target/loongarch/kvm/kvm.c +++ b/target/loongarch/kvm/kvm.c @@ -1440,7 +1440,7 @@ static bool kvm_loongarch_handle_debug(CPUState *cs, = struct kvm_run *run) CPULoongArchState *env =3D &cpu->env; =20 kvm_cpu_synchronize_state(cs); - if (cs->singlestep_enabled) { + if (cpu_single_stepping(cs)) { return true; } =20 diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index a93f14d6e09..8b219afb5dd 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -1772,7 +1772,7 @@ static void mb_tr_tb_stop(DisasContextBase *dcb, CPUS= tate *cs) } =20 /* Finish DISAS_EXIT_* */ - if (unlikely(cs->singlestep_enabled)) { + if (unlikely(cpu_single_stepping(cs))) { gen_raise_exception(dc, EXCP_DEBUG); } else { tcg_gen_exit_tb(NULL, 0); diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index 93ec0cf6a72..19d41c8e91a 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -1615,7 +1615,7 @@ static int kvm_handle_debug(PowerPCCPU *cpu, struct k= vm_run *run) CPUPPCState *env =3D &cpu->env; struct kvm_debug_exit_arch *arch_info =3D &run->debug.arch; =20 - if (cs->singlestep_enabled) { + if (cpu_single_stepping(cs)) { return kvm_handle_singlestep(); } =20 diff --git a/target/s390x/kvm/kvm.c b/target/s390x/kvm/kvm.c index 195e39df032..19ddf59e002 100644 --- a/target/s390x/kvm/kvm.c +++ b/target/s390x/kvm/kvm.c @@ -1874,7 +1874,7 @@ static int kvm_arch_handle_debug_exit(S390CPU *cpu) } break; case KVM_SINGLESTEP: - if (cs->singlestep_enabled) { + if (cpu_single_stepping(cs)) { ret =3D EXCP_DEBUG; } break; --=20 2.53.0 From nobody Sun Jul 26 11:01:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783345883; cv=none; d=zohomail.com; s=zohoarc; b=Qfi6ozFl2nf/+yhcB2GTnQbmq8Hl2u81hZSDNPRMLzAoFznwK0m/tZJZfL92xDmsRNgwPI5ZNku8RJ4345ui8N3+qR+apF6JZZ0rCHY9hpLGyzCT6fAlsS1Cvb9pRmcQ+FaMBLOVZLHwK1u8D0Smdeu0OZkCUyDECzvcdh+Jt2c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783345883; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=n18gPC503RK0pfaPq6yq6U0ElgmpWQclc/luG/elbEs=; b=NlEghjpZwacvXaPou3hjgnS3VtgSRtSRiV1C0+/XIYDWAgAu+E0jvLWiqi7A2mEDIrx1PbELYBl+xAuWhQVv0ZmES8ZwyCj8xy4HwpbnKjHvC78rOeJSKSz4BFohdD2BoQ1taVdVL59Tuxzb+LkzGOpIkbPkRTjtPJv7oM7WLkw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783345883271377.2870514878041; Mon, 6 Jul 2026 06:51:23 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgjid-0007Dx-Rn; Mon, 06 Jul 2026 09:50:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjiR-0007Bc-28 for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:50:31 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjiO-0007Vo-HW for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:50:30 -0400 Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666AxCMw238115 for ; Mon, 6 Jul 2026 13:50:27 GMT Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f88t8991n-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 13:50:27 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e55721a8cso312799485a.1 for ; Mon, 06 Jul 2026 06:50:27 -0700 (PDT) Received: from localhost.localdomain (1.171.88.92.rev.sfr.net. [92.88.171.1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493bef17c82sm289049935e9.1.2026.07.06.06.50.23 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 06 Jul 2026 06:50:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= n18gPC503RK0pfaPq6yq6U0ElgmpWQclc/luG/elbEs=; b=HkLV8azwOC+j7oMK XLimiNaKYjQqhxRFaWocVqrf5DtdDD7v0VHW5uC5Vm0j+tbVHhHDx9WD31eMIS9Y yL4FWUCF1+zBiaqha58oeu3UVUwEHvwnq8hz2WR17oY6wWfqaB9JJcoDmIBnWJtH ugXYcLvqrE+zpVuCkgSbOLq5TDeHLNi879G0tuvzmwp+BZM6vnwiVZ/EyMkpnGY0 s7T/gO3qWgov2fQIdDea6/0N/jNs/7p0Cy9kMSeA4Lx9WKtiAM2+keFWeNMKMpK1 OIPCd0PuPXBr9SR65nJKwwVw6Rh0tKQrUqGOan/xKUSHuKYRAclmdCavxFyrUIBI evzUMg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783345826; x=1783950626; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=n18gPC503RK0pfaPq6yq6U0ElgmpWQclc/luG/elbEs=; b=V9D8QDt9yZpH+fRqxfYzutZkYNG6w1R2ZqMFzuZpO86/kAdorqu2vKn8YRh2iqUEcu xjELe4mFEtAoQQBqwQJjdX3jDwO5nHERW3SFbS86ELj2qA88Idv5LZwQjzS5egZWFM7i VhjK5momwdr68T++mzBRs5O39JsVdCgFDHLP2n7yfEdDoN/+thKLJxLGb7rO8D1ls8ZZ eVM43t2JyXByLV3ysx8uHbQe0zpFrNq2iLpoYnm1fUp6s2vh7jCkOYbTZ/22dme3YMtj 9XXVE3s26/WnqhCYTgORhB6JM9iEHFFG9ZRuGBRJWfV+CgI17xmQT95DDW/ECQj30n/C sxBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783345826; x=1783950626; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=n18gPC503RK0pfaPq6yq6U0ElgmpWQclc/luG/elbEs=; b=neuIl4WzdjI6uITk01MwINF84agI7OWM2xvVZny3DPQAE8VoPM2Y+GC8A4N4IQTwvJ TNN0Zr0GzAVDXQ1CP22+C4Hq9485HJYie6Ab1qt4noVrWvzinlV5R9tK5oKP5TORyB1H Z9D/QjA3OZxFauA8X4LytI7FF0LCRK/NtLNUVR2MdAsMpSsfsWhLath9/y2upzVlEAq1 CN5wlLgXwNkDO8h0pzUWt9Vqbq/WoiFP1m8F3X7STJ77NTMksI+Lp35DMdpg+OXW7ZkA uTUaHL1G36491o+bd+L/bIpB2CZX4aAdzJyNaEObmEM+rtWwfNXT6aHlMnK2JPPspNMW wwJg== X-Gm-Message-State: AOJu0Yw6NhjNDJY+PACji+pvHGo3+oN01ypZxQ0YZM1QkeisawN+cLA9 XLiieMKGwBhnP0bqHepLyyDF2NST2l8bmz7E2ZSOqJJ6FtvJ/SXFz8ob8UCr7z2Cii0ZkqLSJwm m2VbvGwdyITUFahXjRe5idqui+lJT2sSWmIX4tTuL0tkRzVakWwIGUB3x9zC04AhUjA== X-Gm-Gg: AfdE7cnsX/gDDgHqMWbbmN/H7p0ohfQY7QokOuzfsYtCbi/+tJCXa9D8I1FB4Z43+V7 HN9Ed5Q3gR3V3HtX9EfiGuOiicHLWto6PGHvWhi7XqoZ9L3qLl6hnAPxh3niss7bka80IHuRc5x oxUBabZFIWJoX6Od9iySUg5EcMJFDY+cW2wlPzKoPx7pyd2cb1legHI5tkNyb4baA05rKlZ19o/ 1AEAmXzVq5Xx4rh3hoi5xf83TvPS9BHoOPja72u8oH/c0dcg4gLfSuhXb+/h+MTkLHgV0YiJyqU FIPsrXp9KU04SqLKd8rG8v5YEGSSi6oAmBp/R5pyTy35S4lx+SQPoftsPHTuGqi99UIqBDC/X3p mmbuvljbLednb4zAiaao2F1yss2s5Jx8bfIjJPtO0Vzx0xxU4rejFnoMemA== X-Received: by 2002:a05:620a:31aa:b0:915:40ff:4e10 with SMTP id af79cd13be357-92ebb4bf0a6mr94489985a.4.1783345826184; Mon, 06 Jul 2026 06:50:26 -0700 (PDT) X-Received: by 2002:a05:620a:31aa:b0:915:40ff:4e10 with SMTP id af79cd13be357-92ebb4bf0a6mr94485385a.4.1783345825547; Mon, 06 Jul 2026 06:50:25 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 31/32] cpu: Rename CPUState @singlestep_enabled -> @singlestep_flags Date: Mon, 6 Jul 2026 15:45:26 +0200 Message-ID: <20260706134527.84808-32-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706134527.84808-1-philmd@oss.qualcomm.com> References: <20260706134527.84808-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfX3ED1tcv9Apd5 2uhDEqPiAlB+Xbmwa84Waqb22TL2+8jmGFFQsNfqLxOh4dgozlPtK5ZFYOxo4G2OkXCF55IrZ20 wIjCzJsEy+79jKPQjnO1h3IQo25B1Sk= X-Proofpoint-GUID: sceULXLdYPXelG8MK82muVrrbirzPUEL X-Authority-Analysis: v=2.4 cv=C6zZDwP+ c=1 sm=1 tr=0 ts=6a4bb2a3 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=PLEY+c9/kVlxBKEpvFYBUQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=Psl2LI6oLFdwa_E3teoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=O8hF6Hzn-FEA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: sceULXLdYPXelG8MK82muVrrbirzPUEL X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfX59SCo/E4EKVn xSp/35M1CGJ/jwcFHzuk3uZsU0No/GZowfp9sWMOOQPpSrJ0wsANcEk12a/lgUZ6qIsXohGNWQm 9nzP5R8ZW0zXAlaxcpcMIObdWoFdJEFr9m8IfV1apK5VI0fX2DsnfmQXIJptbfiuhzISzAq7kCE 4yzICF4uNn8yzLD8gxqQK1FSca2LCmMknQt7K9nj2GXgz5B1v9KdCaunvdlJkxuiEbYwjH6mH2c BjyU03qO0HZGmzR7r2Govmh5oFeegbUdyeaIiUnS+NEwoo+ooHvPSaDYK/N9DnGqvPyQq774jp+ tCYFSxvvLNg9YsjvcgQRoqwuY3GJp4GDtX81JOYXzJzqe4QSToYNsw3Hase8f/zOTy0KsOhk/s0 13o0HOD8Blgk2HwUcpJwkthwJrs4EGj7ptStXYqMb/vJXJGPIYZU95iCeSes5FXTr6gkqIHeuG2 weAYL9P7KnLDyTyUJVA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 clxscore=1015 spamscore=0 adultscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060141 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783345885226158500 CPUState::singlestep_enabled contains multiple flags since commit 60897d369f1 ("Debugger single step without interrupts"). Use an unsigned type and rename the field to avoid mistakes. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-ID: <20260705215729.62196-32-philmd@oss.qualcomm.com> --- include/hw/core/cpu.h | 10 +++++----- accel/kvm/kvm-all.c | 2 +- accel/tcg/cpu-exec.c | 2 +- accel/tcg/tcg-accel-ops-rr.c | 2 +- cpu-target.c | 8 ++++---- target/arm/hvf/hvf.c | 2 +- target/ppc/translate.c | 16 ++++++++-------- 7 files changed, 21 insertions(+), 21 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 00f6c5d5de7..db4865bd63d 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -440,7 +440,7 @@ struct qemu_work_item; * @stopped: Indicates the CPU has been artificially stopped. * @unplug: Indicates a pending CPU unplug request. * @crash_occurred: Indicates the OS reported a crash (panic) for this CPU - * @singlestep_enabled: Flags for single-stepping. + * @singlestep_flags: Flags for single-stepping. * @icount_extra: Instructions until next timer event. * @cpu_ases: Pointer to array of CPUAddressSpaces (which define the * AddressSpaces this CPU has) @@ -505,7 +505,7 @@ struct CPUState { int exclusive_context_count; uint32_t cflags_next_tb; uint32_t interrupt_request; - int singlestep_enabled; + unsigned singlestep_flags; int64_t icount_budget; int64_t icount_extra; uint64_t random_seed; @@ -1132,11 +1132,11 @@ void qemu_init_vcpu(CPUState *cpu); /** * cpu_single_step: * @cpu: CPU to the flags for. - * @enabled: Flags to enable. + * @flags: Flags to enable. * * Enables or disables single-stepping for @cpu. */ -void cpu_single_step(CPUState *cpu, int enabled); +void cpu_single_step(CPUState *cpu, unsigned flags); =20 /** * cpu_single_stepping: @@ -1146,7 +1146,7 @@ void cpu_single_step(CPUState *cpu, int enabled); */ static inline bool cpu_single_stepping(const CPUState *cpu) { - return cpu->singlestep_enabled; + return cpu->singlestep_flags; } =20 int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, int flags, diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 963a4edd262..83cbd120a84 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -3815,7 +3815,7 @@ int kvm_update_guest_debug(CPUState *cpu, unsigned lo= ng reinject_trap) if (cpu_single_stepping(cpu)) { data.dbg.control |=3D KVM_GUESTDBG_ENABLE | KVM_GUESTDBG_SINGLESTE= P; =20 - if (cpu->singlestep_enabled & SSTEP_NOIRQ) { + if (cpu->singlestep_flags & SSTEP_NOIRQ) { data.dbg.control |=3D KVM_GUESTDBG_BLOCKIRQ; } } diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 0386ac49551..257211235db 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -828,7 +828,7 @@ static inline bool cpu_handle_interrupt(CPUState *cpu, return true; } =20 - if (unlikely(cpu->singlestep_enabled & SSTEP_NOIRQ)) { + if (unlikely(cpu->singlestep_flags & SSTEP_NOIRQ)) { /* Mask out external interrupts for this step. */ interrupt_request &=3D ~CPU_INTERRUPT_SSTEP_MASK; } diff --git a/accel/tcg/tcg-accel-ops-rr.c b/accel/tcg/tcg-accel-ops-rr.c index 5b132d3d5d8..cdaa3e11808 100644 --- a/accel/tcg/tcg-accel-ops-rr.c +++ b/accel/tcg/tcg-accel-ops-rr.c @@ -274,7 +274,7 @@ static void *rr_cpu_thread_fn(void *arg) current_cpu =3D cpu; =20 qemu_clock_enable(QEMU_CLOCK_VIRTUAL, - (cpu->singlestep_enabled & SSTEP_NOTIMER) = =3D=3D 0); + (cpu->singlestep_flags & SSTEP_NOTIMER) =3D= =3D 0); =20 if (cpu_can_run(cpu)) { int r; diff --git a/cpu-target.c b/cpu-target.c index 019906b32eb..4783845c9bf 100644 --- a/cpu-target.c +++ b/cpu-target.c @@ -28,12 +28,12 @@ =20 /* enable or disable single step mode. EXCP_DEBUG is returned by the CPU loop after each instruction */ -void cpu_single_step(CPUState *cpu, int enabled) +void cpu_single_step(CPUState *cpu, unsigned flags) { - if (cpu->singlestep_enabled !=3D enabled) { + if (cpu->singlestep_flags !=3D flags) { trace_cpu_change_singlestep_flags(cpu->cpu_index, - cpu->singlestep_enabled, enabled= ); - cpu->singlestep_enabled =3D enabled; + cpu->singlestep_flags, flags); + cpu->singlestep_flags =3D flags; =20 #if !defined(CONFIG_USER_ONLY) const AccelOpsClass *ops =3D cpus_get_accel(); diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index 640ef665593..f5dd7e8e029 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -2603,7 +2603,7 @@ int hvf_arch_vcpu_exec(CPUState *cpu) flush_cpu_state(cpu); =20 do { - if (!(cpu->singlestep_enabled & SSTEP_NOIRQ) && + if (!(cpu->singlestep_flags & SSTEP_NOIRQ) && hvf_inject_interrupts(cpu)) { return EXCP_INTERRUPT; } diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 3f6d326cef3..06ed2adf105 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -198,7 +198,7 @@ struct DisasContext { bool pmu_insn_cnt; bool bhrb_enable; ppc_spr_t *spr_cb; /* Needed to check rights for mfspr/mtspr */ - int singlestep_enabled; + int singlestep_flags; uint32_t flags; uint64_t insns_flags; uint64_t insns_flags2; @@ -367,7 +367,7 @@ static void gen_debug_exception(DisasContext *ctx, bool= rfi_type) #if !defined(CONFIG_USER_ONLY) if (ctx->flags & POWERPC_FLAG_DE) { target_ulong dbsr =3D 0; - if (ctx->singlestep_enabled & CPU_SINGLE_STEP) { + if (ctx->singlestep_flags & CPU_SINGLE_STEP) { dbsr =3D DBCR0_ICMP; } else { /* Must have been branch */ @@ -3645,7 +3645,7 @@ static void pmu_count_insns(DisasContext *ctx) =20 static inline bool use_goto_tb(DisasContext *ctx, target_ulong dest) { - if (unlikely(ctx->singlestep_enabled)) { + if (unlikely(ctx->singlestep_flags)) { return false; } return translator_use_goto_tb(&ctx->base, dest); @@ -3653,7 +3653,7 @@ static inline bool use_goto_tb(DisasContext *ctx, tar= get_ulong dest) =20 static void gen_lookup_and_goto_ptr(DisasContext *ctx) { - if (unlikely(ctx->singlestep_enabled)) { + if (unlikely(ctx->singlestep_flags)) { gen_debug_exception(ctx, false); } else { /* @@ -6559,13 +6559,13 @@ static void ppc_tr_init_disas_context(DisasContextB= ase *dcbase, CPUState *cs) ctx->pmu_insn_cnt =3D (hflags >> HFLAGS_INSN_CNT) & 1; ctx->bhrb_enable =3D (hflags >> HFLAGS_BHRB_ENABLE) & 1; =20 - ctx->singlestep_enabled =3D 0; + ctx->singlestep_flags =3D 0; if ((hflags >> HFLAGS_SE) & 1) { - ctx->singlestep_enabled |=3D CPU_SINGLE_STEP; + ctx->singlestep_flags |=3D CPU_SINGLE_STEP; ctx->base.max_insns =3D 1; } if ((hflags >> HFLAGS_BE) & 1) { - ctx->singlestep_enabled |=3D CPU_BRANCH_STEP; + ctx->singlestep_flags |=3D CPU_BRANCH_STEP; } } =20 @@ -6641,7 +6641,7 @@ static void ppc_tr_tb_stop(DisasContextBase *dcbase, = CPUState *cs) } =20 /* Honor single stepping. */ - if (unlikely(ctx->singlestep_enabled & CPU_SINGLE_STEP)) { + if (unlikely(ctx->singlestep_flags & CPU_SINGLE_STEP)) { bool rfi_type =3D false; =20 switch (is_jmp) { --=20 2.53.0 From nobody Sun Jul 26 11:01:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783345963; cv=none; d=zohomail.com; s=zohoarc; b=CZkRBUpC3RK6dIs7NCv7VG8jMnA7OY0sTd7O9iF6sCNIiEhCOmXT5OPzrLg5vtm64CW5LdOm4bdkgJeaQttIIO/75lQWmJPOkviK/7LAC/Z5d2wPg82Kd+RSrZ1I5DczEvVhROGxUKQosxATJn4wNg4h5k5xnZOzUNfO0rUgNFs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783345963; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=ZB3yWyI/qpOQePgEoG7SeKYB22ffziKgbfDdg+0wJBw=; b=cYycC5ZJSKc/0Qu62zKJcBtPxzcDcT28Hecr9l+A3eEH0lF08VB0zQzVBHuN7qHRjk/FDrq2fOsZNviMZP1vuiUjGRXDIkd3Ikn/lbU1rhyZMD7wCLxna6RbEVJ/ZK42PfZLrCtavGB19saejkkWdokB1hTR4NUeEdITaSMAcCI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783345963368964.4272787051596; Mon, 6 Jul 2026 06:52:43 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgjii-0007FU-NA; Mon, 06 Jul 2026 09:50:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjiY-0007Dw-RW for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:50:42 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgjiX-0007Xr-CH for qemu-devel@nongnu.org; Mon, 06 Jul 2026 09:50:38 -0400 Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 666AxO8i218524 for ; Mon, 6 Jul 2026 13:50:36 GMT Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f88hs9cqy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 06 Jul 2026 13:50:36 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-91ed0e140c5so550984185a.0 for ; Mon, 06 Jul 2026 06:50:36 -0700 (PDT) Received: from localhost.localdomain (1.171.88.92.rev.sfr.net. [92.88.171.1]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47a9e4d6e4csm23220534f8f.10.2026.07.06.06.50.33 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 06 Jul 2026 06:50:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ZB3yWyI/qpOQePgEoG7SeKYB22ffziKgbfDdg+0wJBw=; b=Xs4OinxBCQdEKbTm K7eB60H2z4SW6eFeLZFd9aOLWrOID6dFr+lFAkQ5OA2qRC8kybKHcuHEg8G6LiG6 Jlt5li9tOc+efhVYHPt9WEO4nrPpkNxx8U4ooyCU11K20WZ21Iq1gs4w4jE4R1K0 FSTZcXKxiQn9jbQlLQMG21bhAr1HPXnNwUhVFY5qeCBgWP2BvmEGNMtChybmCCee OhKCu73PefR9NY9lq1JtptdD8rxguyqale3XI+XeV9xmJUWOlMN2XE/1ZVcN8Ia9 J/hwpxXHbbQBYaoC/1HvrAD01hsSKqHRH1EtMpwwvSYqVypn4yh+orEq2z7HHKct 1xoy8A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783345835; x=1783950635; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=ZB3yWyI/qpOQePgEoG7SeKYB22ffziKgbfDdg+0wJBw=; b=O2cS9iFy7424K/hwBlcTbqsEWk+79IoQPe/R6WCxUjC4MrJpv68n1gZTDyEYF44T69 ofzmBr5GLyH5fMGSobNoNzJFvNXeP1N2g3ZKJODcOpQSh9aiSOm6vyyGQ1XOKHCMdh0t JEl9YC8bZlWaeQd/MlmSkd4tXZAzqC46+ZYyp6Bwc5AZQyxw811zllL2655GKFJ6qoCj d2WGED/jDWl6XG6UAOg+hWjIP32s7DkgfVt8zGWoD+Rl7SffQ4zWTBij5VOwjYxWNE/u TsVHK0taD6i7sDi+4+rkbVl4PoJpTA3ZX9pRWxgRKmRDSB7S8hJoI1XFxsk+MDznUnC0 b4wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783345835; x=1783950635; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=ZB3yWyI/qpOQePgEoG7SeKYB22ffziKgbfDdg+0wJBw=; b=sfGYFyIk2QDh0ugtxG2OLd1RlreaX5bAq1WwmMJvFPWpe2Zt+wJLO3ie/dhN7yfrQd g4A0xOHgkeXB1j11GtbuvdKdGGuKltTntcn2UreW2F/JHrKlum8REarNpjAocGyTpFxf wYaLwub/BeABZIiod0l+j+1Vy6uUDYN+HTR+PCVZig2y0hb8aM9WWblOLV6Riwlc/KjH Hz0iE8QojDU1nX/lvKrptAhj8SvWpdzZ2+lWoN1pv9PrxfNh0KpIQqeo3EiLtIu+4ImH GRxjmC3nYJJgAhRvYG0ofn+CyI3LRf9D5zNmfnlnvOfZBmfHQTc+/qsGmX119x6TZuWt GcqA== X-Gm-Message-State: AOJu0YwgICCStZQmJj+FcxfeYjJfaEnkH3wJnHD9l5UwvAR/KDFk+Sdt h/WraFycifm/8WINFC2r0PxiVNGAexZJewqdijiYPDmFYqB5VFy/zUXiVZLYveViux5Dmyizbi8 9s3lnUGmPFvx+o32fmpE+v8dBWt65cFwQqjrsD8KRiS3XYm8qbNhjSdmIdxv7ZQdSug== X-Gm-Gg: AfdE7cl4Q4aSdTqipGN3/HiY7v+PLAAHE5AhMVWIlPWFbeub0r1AgsCJnuyZnF03q44 yLgJaqyb5ill8Ob4fCzuFoIEcKK6jSfOaKvpe2X5UQMGpqSqOFDULj0CW2IiRnK74UDeZz5iM0r P7UHOpsEDQHkgJ8hapEbnFG8rpQM9e1JrDAz4ML60IzgRd4+vEa/aM5WPXmoSmgu1mjB5PALQP0 Kg2v0vOpcbwR/dGUyFV04n/cIQTn3zhlEx274LoqISV0qElV7SvPudmtOsT+z2cbCoOO2t24VtX xco+IckL+bf4ZJImSui/z2Gvs5flpOnFtTQLqOB6ep0MPYp8Imti79BtKsb3SfukPSMM4qBb7+J od5iws3aAutKH31sArI6ccQaaN+RcqDQPP4ysnbAGQt0br+dK3+vEUuBYww== X-Received: by 2002:a05:620a:4707:b0:92e:7d1f:d3a4 with SMTP id af79cd13be357-92ebb4e4225mr92231685a.26.1783345835394; Mon, 06 Jul 2026 06:50:35 -0700 (PDT) X-Received: by 2002:a05:620a:4707:b0:92e:7d1f:d3a4 with SMTP id af79cd13be357-92ebb4e4225mr92224885a.26.1783345834747; Mon, 06 Jul 2026 06:50:34 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 32/32] cpu: Only check SSTEP_ENABLE flag in cpu_single_stepping() Date: Mon, 6 Jul 2026 15:45:27 +0200 Message-ID: <20260706134527.84808-33-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260706134527.84808-1-philmd@oss.qualcomm.com> References: <20260706134527.84808-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: FygeOyeoJSY826rJyfg9C8hPsuPQIP2J X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfXwCGyUO8iRAnv qqgZecy7KgvyV20jwDm9gHX/cHC7DChB7Jq7a3yrFEkDc3rvu0DdyQuQxrL7HpLtAlQyul40gc7 akThxkiNgl5wsCH0bzZ9U7Dk917C63X1a738hUXN8bzqxHaOchY2cnb0pTlSFxpIvb8o40c1AAh LZAdZzVBTHuuTcmPkSuj/zO8WJnpW3V6fj8ZgPgaHDDDWXZh52CE/sbQD/BdZt+ZD+d3bWr2cfw +ApW+GXIBztPrDcyMRdvcabYt8aSFNe7psY7i9M1hIqY6zWqa8YRXSuloQYNYL1qeAWTqWbeRdU 9LKxNt4mjn70OegstFU+GSvTpQjl4qz/P/1/aE3Kcb+7u8p1k+Bjl7n3KX2q2KPf+z06yzI5fHd S/ES4GDnyB/zBGM75H79QePE0R/r70gm+HuXECzKfJWLRHy54ZwsZ1L9Wh6KgERIuHgv6t5l40P uxnBlpS6LD7BrqYnExQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA2MDE0MSBTYWx0ZWRfX1kP1lH4pAQb9 tRGgNQTab0rxfth8ZRyXRlWyUW0Zp18MxTv6xhz281nk+1PQi9V8t0xPAjsNFFG4OJZS/2v0k9v iNny8GkuwgsqhmHJWfm5CAFKRSZgWqU= X-Authority-Analysis: v=2.4 cv=XIwAjwhE c=1 sm=1 tr=0 ts=6a4bb2ac cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=PLEY+c9/kVlxBKEpvFYBUQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=c32rm7a_bKQHMAiu1xsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: FygeOyeoJSY826rJyfg9C8hPsuPQIP2J X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-06_01,2026-07-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 bulkscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607060141 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783345965755158500 Only the SSTEP_ENABLE bitmask means single-step is enabled. Fixes: 60897d369f1 ("Debugger single step without interrupts") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson Message-ID: <20260705215729.62196-33-philmd@oss.qualcomm.com> --- include/hw/core/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index db4865bd63d..b54035fb13b 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -1146,7 +1146,7 @@ void cpu_single_step(CPUState *cpu, unsigned flags); */ static inline bool cpu_single_stepping(const CPUState *cpu) { - return cpu->singlestep_flags; + return cpu->singlestep_flags & SSTEP_ENABLE; } =20 int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, int flags, --=20 2.53.0