From nobody Sun Jul 26 11:01:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783288672; cv=none; d=zohomail.com; s=zohoarc; b=QmzlMaanjGCphzi3EoJFBxuAWnJT6WKO83jqSwbmfCFRUHS0k6bhXHAIeLc/8nY0Ts72XSQZdJ1YtfzIkLoaE0C7nNViOUnx9lVKH0QxP/EzBn3amrY/8porUiKoeS3ViAotWPmRN3Na/36A5cMrvkxRZCHiSeHIqHkLv++RQ/s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783288672; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=iximc+qBDNz/RyZclQJYcYQjzkTl/bbNgS8+O8OxcBM=; b=XFUrANRfEaINfJ0mQPmzkej38wZ7UA4Tvxer9FHx97BwL03OGVuX71v0E0+nvo1FdilFI/Ye5sdQXgofx2ap/XNAhgnvjT28lw+3Vt2+WykmABfIAPvKf/lwx9u9hS/ZihhkM7ef7P9BRt6NPCQoHVICxg5fbN+g3r7UFRv6DAA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783288672411868.6584046318414; Sun, 5 Jul 2026 14:57:52 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgUqO-0003sw-H9; Sun, 05 Jul 2026 17:57:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUqM-0003sR-Ll for qemu-devel@nongnu.org; Sun, 05 Jul 2026 17:57:42 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUqL-0008Jx-3i for qemu-devel@nongnu.org; Sun, 05 Jul 2026 17:57:42 -0400 Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 665HiqDv2170459 for ; Sun, 5 Jul 2026 21:57:40 GMT Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6tj8kfcg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 05 Jul 2026 21:57:40 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-915f6ff639aso443641285a.1 for ; Sun, 05 Jul 2026 14:57:40 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47ad69519c2sm19480421f8f.37.2026.07.05.14.57.37 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 05 Jul 2026 14:57:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= iximc+qBDNz/RyZclQJYcYQjzkTl/bbNgS8+O8OxcBM=; b=dYQo4dV2VsE1ZKCC Cn4ppBrNOmiitq0B9C+sCxkxRG2q/yz4u0flbElEb91ob9k6pS1JKAsOo7ax/4PE FNhk9lY8V+2KpilTR8T9jIt8/8nBBpGYwMB+JRZ3SDapqzlsCTE7D5NVynwJglL2 A0y+a99l2bE3dCk9Yz/4iiTMGSt6pcQ0nvv7W2A97LJ0spQ+ZYK8YET2HP+qg3gu k21OoJGVrmg8CxFSokYShbrOoPzBxAT9rZRCICCQ/pUeA2BbPChotOXPnt6S7osU 9mzrmCmxgsaJrcxCw7L+NXUd8xAhRpyF1CIw3VSSt8KZQOzv3lqd2q3UnaeWrTDm qVC5lg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783288659; x=1783893459; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iximc+qBDNz/RyZclQJYcYQjzkTl/bbNgS8+O8OxcBM=; b=DFf2iKLckh69N/vvFSnp8XqwnLbQ7ixI0PbOUqNcxWws97Vfn4U3A1gfXK8z2HFauD 6DIWz0mx/Oavloq25eui/DTYl9h5uOYiHZt+h8BrLWkpghM+qRundCbHkxNCI7ZWBN5Q bf96IU9pPOJBRdvLKXbZbomicnB/3zCwzZSBC/xX5iTU3ARJ6UQY2vAwUofcWBtm/pnV iA9Zc5MODjGJiXJM3InqVNgKZyKXCH6zdzpBNYBwc1P0wHJQAI/8pOeqZJgzloYOhPnC 69lX08G1xsJksgPFpYfFuFdSNrLyETNjNxTOxCIgm/o+i5RwN/JzGgQBWzMgsEVtLiNr i9YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783288659; x=1783893459; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=iximc+qBDNz/RyZclQJYcYQjzkTl/bbNgS8+O8OxcBM=; b=cJqe89uTJOpeMogYodMk2be4+3XLpQdxRzRYSYmBcY6+vVGtXZtOdoMYUBPzZ8K3gb P+lXMbfS0L/7nFfTNytcuJEEr6GgqXIoMdSf7iaBrEahRIJxboAGHbvLxh3G143e4fx4 voNcBRxQITlOx/xTrVXf7+5Npi6KNtCstSWxMVQ2QlPL6A14of4b/nWfCKjuXFR7IlTw PDoSbnvdDUr1tXzfofZGL3rl1xld1FJZc4bbrVz4BG1y6GEPUKhbU+KKh8k9tT3SrDSY wIk5t7olvZwLkNS60zi0fVRQbjinhn9AOqttbpZERWVKu7TnRfM+jF9ZivbzK7B14cDi W0dw== X-Gm-Message-State: AOJu0YxmDZ6tUFeBmbBelBh0B6kkv2xvOKmZ15sGMeINSCFvx/gDbTnN wrOE/wCR13AeGHx+t2DmZMZ9+bH0H1/PJ2mPvZxBF8SbT0+EyBN9zaMSn63qcQkPs6jLA9AGA4/ 9W6MIB2VSEeOXdhR9KjULugdDKQbfPZ2OiT1pzWV60TMC/MSbEZ642tscLX+aCFy2hw== X-Gm-Gg: AfdE7ckAaeu0m54jo8/AiMWEdlkaYjQDc7XN0oXDCw1TxGTDkAOkF5/0uG0RUq6m0RO c2XYjB3BzzzsNjf6QOBOZtFt3yZLDM+54CXSyyuvRSqQdYyUECvXAaVN68jZw9QY0P6CvsDyx7S 2CTml1ZWo+Sjw1rQnNbsfqE30MWXYagpVwYSXx0LJ1J9evpGCfO8LEdnuo4rDuXvLNFgolCxQ6q K7Z8DR7noclH9qU74914xO6JFWBbt270XeBBMHN7W11FZKC7oFqSJ80insnOuMHDcKBfeGInhwK UyCsKaWOqdGxlS5q9XuYsaAPBWzS+r0ERe4nvap9LDZfJd3llZUtFTwUP6WosI+GzdjsJ0fZUmk JPItpvapmgNQ5Hd4tVZOt3T5qHjlp2tFweDj92KolfL10pEuFE2ObKg== X-Received: by 2002:a05:620a:4405:b0:92d:54f4:dfd1 with SMTP id af79cd13be357-92e9a47879fmr1057589085a.54.1783288659569; Sun, 05 Jul 2026 14:57:39 -0700 (PDT) X-Received: by 2002:a05:620a:4405:b0:92d:54f4:dfd1 with SMTP id af79cd13be357-92e9a47879fmr1057587685a.54.1783288659040; Sun, 05 Jul 2026 14:57:39 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , alex.bennee@linaro.org, qemu-s390x@nongnu.org, Magnus Kulke , Zhao Liu , qemu-ppc@nongnu.org, Paolo Bonzini , Xiaoyao Li , Richard Henderson , Mohamed Mediouni , Peter Maydell Subject: [PATCH v3 01/32] cpu: Constify CPUState::cc (cached CPUClass pointer) Date: Sun, 5 Jul 2026 23:56:57 +0200 Message-ID: <20260705215729.62196-2-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260705215729.62196-1-philmd@oss.qualcomm.com> References: <20260705215729.62196-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA1MDIzNyBTYWx0ZWRfX6/onaMMoQwd/ N/WCN7PMB7aBiOSi1Ox3oMPaxCdYvfHpNNeDg/KWan3hrw6Jl1G6ZKzW4rJlQAmImhld7bdXIMo LsMWlkjm223qn5bHWbLXkHU+2FiDZPMxGdZnwiNf4/3mXTLD4I/RTCYFsCyj9PjqLqGXiQrNL0W 38/WWLlyLqf9YatAdd8Eqv9apA0fL+nn62wnvqXg3c+O+G49LFgSBWuArDrGauMbZOUhTg6fnJQ tNzH4aGBNw/AIyCh+u1Na2QEP80pJ0mhw+rHgrzldiYfS9BcJ5FQgYCtrJF8nutv7NZ4oKLrCUu X0zLPYPzuoQIn0A94pknBILb2pEXdA2GyEUQoAKFxu2oFJ1iKznM3/9Iu4oR3tYtnee9Hq4LyF/ 7dnyJPaHD82jMas07CloaKKu9dW5hPhZH+6YGJ8V97PL1gdk6ox4xmy3s9NgrnlfRT+MT6yna+D a2Fh9YUgfJW6pgDQmBQ== X-Proofpoint-ORIG-GUID: 6mjWXSk9BTNs9gOAYxVrlGX7AzYHu0KB X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA1MDIzNyBTYWx0ZWRfX25+/PQroYCt+ 7RZO++tP5nVj1KS0RpcjLekSChowvI8qnruJSsg0laQglVMznbisNNJ6n8Idzih+bTB+cLs7/h7 dohtx9w78AsgoUs2duQN4f8J8ZPwhf0= X-Proofpoint-GUID: 6mjWXSk9BTNs9gOAYxVrlGX7AzYHu0KB X-Authority-Analysis: v=2.4 cv=H6TrBeYi c=1 sm=1 tr=0 ts=6a4ad354 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=pGLkceISAAAA:8 a=O_p9N0DIn41U_kaacwQA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=O8hF6Hzn-FEA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_01,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 suspectscore=0 bulkscore=0 impostorscore=0 adultscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607050237 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783288674131158500 Various CPUState can share the same CPUClass parent, and must not update its fields. Protect the CPUClass by marking the CPUState pointer const. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson Reviewed-by: Chao Liu --- include/hw/core/cpu.h | 2 +- accel/tcg/cpu-exec.c | 2 +- accel/tcg/translate-all.c | 3 +-- gdbstub/gdbstub.c | 2 +- 4 files changed, 4 insertions(+), 5 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 59d601465b4..60a23d6f38b 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -480,7 +480,7 @@ struct CPUState { /*< private >*/ DeviceState parent_obj; /* cache to avoid expensive CPU_GET_CLASS */ - CPUClass *cc; + const CPUClass *cc; /*< public >*/ =20 int nr_threads; diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 9c754b03656..d7f91dce9db 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -460,7 +460,7 @@ cpu_tb_exec(CPUState *cpu, TranslationBlock *itb, int *= tb_exit) * counter hit zero); we must restore the guest PC to the address * of the start of the TB. */ - CPUClass *cc =3D cpu->cc; + const CPUClass *cc =3D cpu->cc; const TCGCPUOps *tcg_ops =3D cc->tcg_ops; =20 if (tcg_ops->synchronize_from_tb) { diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index 3f1a3a28438..328d96aba30 100644 --- a/accel/tcg/translate-all.c +++ b/accel/tcg/translate-all.c @@ -575,7 +575,7 @@ void tb_check_watchpoint(CPUState *cpu, uintptr_t retad= dr) void cpu_io_recompile(CPUState *cpu, uintptr_t retaddr) { TranslationBlock *tb; - CPUClass *cc; + const CPUClass *cc =3D cpu->cc; uint32_t n; =20 tb =3D tcg_tb_lookup(retaddr); @@ -591,7 +591,6 @@ void cpu_io_recompile(CPUState *cpu, uintptr_t retaddr) * to account for the re-execution of the branch. */ n =3D 1; - cc =3D cpu->cc; if (cc->tcg_ops->io_recompile_replay_branch && cc->tcg_ops->io_recompile_replay_branch(cpu, tb)) { cpu->neg.icount_decr.u16.low++; diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index c3c944e965b..26366acb674 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -578,7 +578,7 @@ static void gdb_register_feature(CPUState *cpu, int bas= e_reg, =20 static const char *gdb_get_core_xml_file(CPUState *cpu) { - CPUClass *cc =3D cpu->cc; + const CPUClass *cc =3D cpu->cc; =20 /* * The CPU class can provide the XML filename via a method, --=20 2.53.0 From nobody Sun Jul 26 11:01:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783288698; cv=none; d=zohomail.com; s=zohoarc; b=i1PcCZJ2qQWnvIL8IvKUa/kv5r7/KViDrnwEeVi/kMJZkoD2MHUJSQM/UmciNW1zsfwrZr0CkdS6xRtcT+lsGeLLdR/jUgA1HUxMJGiJQJQKLVGoSnXrO5XogNhJWigDsd5EekDIL4386eT1Gl6AJncnOiBwO7g7DjYlclRxCPo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783288698; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=baUNmRqXOkPRQ+AyufyGcZ9igaejjEE6RFXBGnD67zY=; b=R0WyNSAAm7DC/iIUlXHfi6iqY3veYPJYkQH2MZu6vaMlMcTtP7U3zG0VMHxhCR5ZN4BMMTQ+kkKXThiyJVq8SsTGlPelAlC8+L5blQmnN6H7wRJ5rVyfm8ngJlfFl1R5r4wNEfW9N5uIkOPP0Aki+NnxXipD9Q9P7Ft6Jyz6QpY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783288698825912.9606168540148; Sun, 5 Jul 2026 14:58:18 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgUqW-0003z1-AE; Sun, 05 Jul 2026 17:57:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUqU-0003wU-NK for qemu-devel@nongnu.org; Sun, 05 Jul 2026 17:57:50 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUqT-0008La-Ai for qemu-devel@nongnu.org; Sun, 05 Jul 2026 17:57:50 -0400 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 665HiRSJ2348296 for ; Sun, 5 Jul 2026 21:57:48 GMT Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6s64kmjm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 05 Jul 2026 21:57:48 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e56b2b350so502375485a.3 for ; Sun, 05 Jul 2026 14:57:48 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa039afacsm17941176f8f.19.2026.07.05.14.57.45 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 05 Jul 2026 14:57:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= baUNmRqXOkPRQ+AyufyGcZ9igaejjEE6RFXBGnD67zY=; b=gec8EEm7XluLoRZk JgCIzS80IiWP2Nf9FrHXtdGS56NME0wHiHrCk3lgdmRG78ld0vgaPWrR9T7vsknw 1mCIrvTni2HgR/tlnQI+Psy77ySi0rRvg854YsRFFqOhok/FOKgY56m9b42fFkd+ MbguQVXupt6005A0sHoROqCcZm0Kl0P1FkDi7odmiDqmSg23DhdnreyAmkVaCdjP rF8uGBwSemUmFAGzwRxnC1UeatIwQw12vy0puvi/+M7pfirS+0n8H4TYDQDg8Toc zCNGlm5ukStH9oWpPxVgljfFx2Mlqd0tqwh6smtgg0ND5X2mlTGnwQSVAbwco/UD B9w3GA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783288668; x=1783893468; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=baUNmRqXOkPRQ+AyufyGcZ9igaejjEE6RFXBGnD67zY=; b=OXD7dbTMIka8f67HZkRopkC32R23vLzkubImcan/8u7nEQKyc6yxk5PF3KiDvLghl2 XByfx5znFZJ3m7n8bB7rbGpfGjkdNi+0HKT1Xc8xQbpXnLQ/x08SOxs0GhRlIvV14NYa 5HK334J8ozn60J9PP/D6IIHqFe7A036SEq5S3t7/8ogT4Pr2oc0CCWdTdTGSFdd2c02g JFf3AdTu9vg5emlVfFve7YLhxgrWp4YNZyE/+JI8eHD8kQtTxUgl5JZwd0aHsHKBcFOS cfkVhBzOPmZZYjjXX24Jdu/WIpfuKCRxmd2k2AdDoyVY8N1+WQNG6GeHIn8OScReEePO sQVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783288668; x=1783893468; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=baUNmRqXOkPRQ+AyufyGcZ9igaejjEE6RFXBGnD67zY=; b=V2YEX9fRVLXpAxAAasgSAnsS+vGfYvX6fsKd1NK4fERGb1uG0dtLg3q+tjrVfUN7MS udKr+rBF56g1i/nY5GRDVFfkxWIUj6XH70DsBCKvhu2SXxX060zCI+5MlxMs7WxQeVKh F6m5ifvU38GKb4Jngje2qHvSN0J5oxnrVgzNfZXq+RulFHXxx2baNmIz4yePZAWvpcTq GEE899XPeXc5db8Ek+i9GFIgNj89DyFwTz7v+uAfngmDk1ojd/6ksCAqkEskCdOH9zf5 qhMHl1zeWwnarH4ItFNYzItGnF3q3W+7seE0hRuxue86BbAL+Jc49ZeiMj8t+5ehXbrP lzPg== X-Gm-Message-State: AOJu0YzQXRGk5pJAdVtfxhTxm/PptDIPsNQ8MHPbsBS3nGk/pB+ab2dp 6/zZQNP6/uOnQO0E+3Y2aAcP2iUymtc3hBTyuGAAo5EGQx7NM2rPdOSDgEf6N3PG52vm5125zK2 i7wI73NBXMDl3sxZSpe+Tzt3ycHoO+p7TjxvWc3nfGR8EW6mn7Tji4WS3sop8K1o2Hw== X-Gm-Gg: AfdE7clVlZMA2Oy87FnNavRpLFNcjKjVp2pc9LiSOh8vRjW5gvEdSBA5YU0Z8AvoUZN weTsJ1zJ7PrtWblax0gYXLNcBDpUdZb5nemEBZUODkcrUwXZSkMhV1v5HODJeIQOXFVTG9+9LeM zB5/WRRiPwk6C5Cef5FCyTWDoq3TNCraqz7Z48Ziyp7ffW2L02iRqp17O71+O0hzjOw8Z5qrND+ J/oMQd5IfrXz0Mw1H+EuLpe+BzO/c7RzvhLMqYsix0EFbTymPkul5sZTpO/PQlwJ9ohMIMEZcDA pZsboieQvF+44J/C+9axWgJmBmBze/u8WIV2oetcVXEjAn92hwMI8qIO+xSFD3r306wtffBpJHu Xu5k/ofaCakZ21zMGqE/Fa2c6XbzlorpibglTVNb6uIoOCIsocmJW6A== X-Received: by 2002:a05:620a:1a19:b0:92e:4474:8fe0 with SMTP id af79cd13be357-92e9a364226mr1202775485a.29.1783288667645; Sun, 05 Jul 2026 14:57:47 -0700 (PDT) X-Received: by 2002:a05:620a:1a19:b0:92e:4474:8fe0 with SMTP id af79cd13be357-92e9a364226mr1202774285a.29.1783288667240; Sun, 05 Jul 2026 14:57:47 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , alex.bennee@linaro.org, qemu-s390x@nongnu.org, Magnus Kulke , Zhao Liu , qemu-ppc@nongnu.org, Paolo Bonzini , Xiaoyao Li , Richard Henderson , Mohamed Mediouni , Peter Maydell Subject: [PATCH v3 02/32] target/i386: Remove duplicate tlb_flush() call in cpu_post_load() Date: Sun, 5 Jul 2026 23:56:58 +0200 Message-ID: <20260705215729.62196-3-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260705215729.62196-1-philmd@oss.qualcomm.com> References: <20260705215729.62196-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA1MDIzNyBTYWx0ZWRfX73j+E8mEe6pF cmUzdVU5BN4XhhNp9myJkD8M6+WzunlKM/di74HQrBFc2MiPsEFMEirtTeGivchBFhqjIGiI9p1 dkbTy8f16JYsAMQo8FpV4qun4uPL4xbGFXoZA0Zyv0KH8dSHP1cQcvohLQRUNdhylt0eu8HwT0X pHLiQasrLHyqB0rCh/bLQxz+OdTDzw4FXwFmcgr30+kPNPLp88tQTUOpfGVMvM3lRx8TfOtII8f 5jF8EIxUvoJapQv+GdcBSraNE5aQ4Y1Tee5mxAq2Y/d5P0LIZE2IYRsQ2r2nA289aks5pbpBOiL w7BOBLvNcnNmBL4kTPRg2nEBymeRYnIlv48kONIcMaA5jlxSoEWKX98JtftvxWOmOhRbG5uSesp SiUdzLTOthAxAnEoRP90vr7B4BPnJBOcEo14T2+bn6myftCTT1uMxmBJvJDqpVpxlfzLTFGJwXj bNuqhkuIhCC9nCdN+jQ== X-Authority-Analysis: v=2.4 cv=VvITxe2n c=1 sm=1 tr=0 ts=6a4ad35c cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=pGLkceISAAAA:8 a=Cu_OB6cER5A0ZMY7a4UA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: F3MKtUfo_6d-edFJOhk0Jrdwo5fTuXX8 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA1MDIzNyBTYWx0ZWRfX/PAukS2FPSvQ iw8k9eysLme4sfgExlj4lAOTIrzU9exRo8bYYZt/XbwiWmcX7sGb1lq1lsIgeeX/LH+7AZPGPzb AZpRpFo6DM++M9Ni3K1vCTZ8Ssqd0Kk= X-Proofpoint-GUID: F3MKtUfo_6d-edFJOhk0Jrdwo5fTuXX8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_01,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 suspectscore=0 bulkscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 clxscore=1015 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607050237 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783288700159158500 Common vCPU cpu_common_post_load() handler calls tlb_flush() since commit 9656f324d25 ("Move interrupt_request and user_mode_only to common cpu state..."), no need to call it twice. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Chao Liu --- target/i386/machine.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/i386/machine.c b/target/i386/machine.c index 1f5c517e562..df0e0c178e4 100644 --- a/target/i386/machine.c +++ b/target/i386/machine.c @@ -401,7 +401,6 @@ static int cpu_post_load(void *opaque, int version_id) env->dr[7] =3D dr7 & ~(DR7_GLOBAL_BP_MASK | DR7_LOCAL_BP_MASK); cpu_x86_update_dr7(env, dr7); } - tlb_flush(cs); return 0; } =20 --=20 2.53.0 From nobody Sun Jul 26 11:01:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783288726; cv=none; d=zohomail.com; s=zohoarc; b=O0U682Bd62Uo8k9zEMd5m8cL2D6dkKdWhIhQOmDOsIwUiDzBpVlqOx9e3/ZPig+GPaHDmqg3sADM7Ipvru6Pe65fGFtsxCwyuJb8cNCRMPp8ay0h6EKETvClm6+bF0EFwPoSoBQcL856HoxKT78q9BHt+lDSDntmon+uBCf8eKA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783288726; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=risRiSv+UEPHcL2LbSldgAbZS/KE/1C0HcsdRJ7pmvw=; b=LdpYcK0th98XQi2NGGIndYXyZQJYUwfEa2JqHL0y1B5dBdK8+vlaXhqU7JzjgR024UuAhetoRYUR+RWQB0AyPwDxZOis/X05I2bqUtGn8NQeQUfizjF8HP4aSfbOI+FlqpLR5v/+kglzOpb+eihYtdtbSiPQ6NuqYXqZ+NdR5Q4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783288726167515.8856356793062; Sun, 5 Jul 2026 14:58:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgUqf-00043p-2p; Sun, 05 Jul 2026 17:58:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUqd-00041Z-BB for qemu-devel@nongnu.org; Sun, 05 Jul 2026 17:57:59 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUqb-0008MH-0X for qemu-devel@nongnu.org; Sun, 05 Jul 2026 17:57:59 -0400 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 665HiFiu2315313 for ; Sun, 5 Jul 2026 21:57:56 GMT Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6t8ukg54-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 05 Jul 2026 21:57:55 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-92e5e38fbc5so212608885a.2 for ; Sun, 05 Jul 2026 14:57:55 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c63bfba1sm364871875e9.15.2026.07.05.14.57.53 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 05 Jul 2026 14:57:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= risRiSv+UEPHcL2LbSldgAbZS/KE/1C0HcsdRJ7pmvw=; b=LUf3Xhd9VvVi9JCl fzA8d8W5V57g8jcfIbzhYe58EVednaA1HPhmVrAZAjOK902ehHIWQQeoH4XQrOth 1iUMFxJ5se0YlNDGOtHBeYB57jjBsUi4MfR6MpMfp+FIkAr22xLTm19jZJvSyXPF wJ76uosOvBkJ7gMe2AnTRh0BD34EMoEpmXxibIJz9IoOw3hGi6Ncmy2m1sGG7PCt nTfU/Nx8BtWf58L68WFU23cW7Qmkb1LIH5CDaoR28Z1ZcrmAfRGGXi0gp7xTgZ7Q v78/Gdb9SMOmfyGnnaWxMDQ2Gf+nADk4HVJvZtQ0JzhQolk1c3fqOg+ejec7/QNh 48EQCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783288675; x=1783893475; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=risRiSv+UEPHcL2LbSldgAbZS/KE/1C0HcsdRJ7pmvw=; b=GkigZ8LzeV0lzyVKO6J9NPEmbndoLrq7H+qrGyKXgvTg26/nWRPuodSpc0awymedq1 KWzr91bP85GvOpqDYs3G6rhQ8mJY4eIDYC25WFjiYRHct7Eym00WSw8TwYfcPcCs5ytu gg7T7AoJ0leftMVbFFtEpIpNWx0m+C4SPG8TfR3HC0o5pvGpDtXR8KvHrYM9bIvRc1FD PFyT2YwH7sjG/JhWG+Z5mgXW70PhHYy2qyua7qKhQa05COqRtQ2GSGS+srL1/R3mEvVY dkgtpcU8IOwKoKqcu1eNZWMsdn7acv9VSAlwtuxwW9pXnzumvKj7wp4pQBqRuDrVsC3H mm1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783288675; x=1783893475; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=risRiSv+UEPHcL2LbSldgAbZS/KE/1C0HcsdRJ7pmvw=; b=NSoxle4rUtL9OK3DYxsal8b+ewbWiu47BbGpAxeWp9WZYBSvU6+4Fm2s4AJZFyapjV MDpkcJromb7XHk9GFp2UMVcBeGIW+sUSU4YNaPBznUN056+TBjxcedMLYNJ2h4GOhkJb K3RVqtw3pO2D789GdNdkDDxnXSSfJVJoeCEq2JBgeCLvS/5471B7br7uqLLb13YjXUMh 8YZMfOVpytIDlYYitt5HNg5MqVC5j5kzy875rRO8qVwnYfy91ERZwNbjZ3W2zzdAJhH1 GPOddddBCOF1i4buMjn7ealnX/neR/woEy83YG6z7FH387TwUcxLVXGA5S7Y5x857Z0B RmCA== X-Gm-Message-State: AOJu0YzPB64/7wYA7ArrjYkvWN3KQ3sWFg08n2zCDJBX5th7JT1LW2dY Tjxq09EPbXPm/qikYtxWoN6vfnJFVFDqAzXlrkmEpCsLSMiP0ltdtfcdnbTfmcesb1QLThKy1W2 wsD9dNXoE1tDnlsM/HWd3EgicrNEbMQ49u9Z+idR43FfVf/NSZMWoks4ZmirJm0cdxQ== X-Gm-Gg: AfdE7cmROY+k/g81Z/qU36f35X/CgSUvBVdzXbewLPQ+6sgvuK85UAX1+K5aTpJEmfC 3CGVrnPmw5gqQ2jfgx5BSj4RSCaTtn1SFu2eyXZt6z0ywFc9edWZde+OfjAbge2tC6fF0gBK5F5 uEMsUEbMMM6BE+mTRu9j15IhzYNhFz3d9n6+l4fWNMHJqKok41cbK7r9kM+34J6bumZJnlmxLaK CzuEr18o/ggej7hNq8ogL6WRTFg0k6YHOhBHaReKckPrxeY914I88p2AoiomUDkIL/wB8C9vIxd nzyQsbyqXo+WacM+oRihzE+QjTAWgkjfcRVlEsQyolAJ4/4QTCVDoFeNsQyOEorKKNMfXMNrusB 9oc7TbY/1o1VqayU5d4yJHklwb/q6Ie+i4js7RnF6zROyEI5bzMQtjQ== X-Received: by 2002:a05:620a:4012:b0:92e:7b45:7690 with SMTP id af79cd13be357-92e9a51a4b4mr1168613785a.69.1783288675060; Sun, 05 Jul 2026 14:57:55 -0700 (PDT) X-Received: by 2002:a05:620a:4012:b0:92e:7b45:7690 with SMTP id af79cd13be357-92e9a51a4b4mr1168611385a.69.1783288674575; Sun, 05 Jul 2026 14:57:54 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , alex.bennee@linaro.org, qemu-s390x@nongnu.org, Magnus Kulke , Zhao Liu , qemu-ppc@nongnu.org, Paolo Bonzini , Xiaoyao Li , Richard Henderson , Mohamed Mediouni , Peter Maydell Subject: [PATCH v3 03/32] accel/tcg: Restrict tlb_protect/unprotect_code() to TCG Date: Sun, 5 Jul 2026 23:56:59 +0200 Message-ID: <20260705215729.62196-4-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260705215729.62196-1-philmd@oss.qualcomm.com> References: <20260705215729.62196-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: EMIZ9RfbCv8K8u4dST9U590GndzPjYHx X-Proofpoint-GUID: EMIZ9RfbCv8K8u4dST9U590GndzPjYHx X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA1MDIzNyBTYWx0ZWRfX1QDPpRFQztS3 Sr1EyInv1377xs7jsSkNlwdlhqv9tf2MHp2Il45uvL6C0OHoEEtdBP4et3HEitJK2ZzZV/dYdkh VUirEGROvLS/tXQTSoLroyWFE4Tl6b4= X-Authority-Analysis: v=2.4 cv=MZxcfZ/f c=1 sm=1 tr=0 ts=6a4ad363 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=pGLkceISAAAA:8 a=glojBnVPa3CR4aLdIrwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA1MDIzNyBTYWx0ZWRfX1jT6fQC26k5I kK2EeKL4UYqK8WY/FxUywvxNTDGqjtLSJvBsSlFfgBvMSj3ctfRp4+rAiwXXLMZ3SLqPd3yLWpw T3Ud/XiqmSF0apW503P1mnfOOES9wDjFjBWXuJ6JGv80pqI9zwFKeUAx2XgWrtUrkq//pwa11GA yKSQv932xh7xFtV+UiaRyJm+ghdVWqAbLJMldnQ2qY0NaEGbsbOmM2j+2BtST9gWhksM0R2m3Ph 6pDVBvqgktkaga+FgsARUqap0Js5E116XTeeL+4BViWCmI9Hp22fbFGDXNdu1mXm3QpCX8VUcRo xHp4yJv5Wmcvhb9jalmQcKtI7C1vZoAaOhC2mnLWB0M2MAMr9pJA6s0AEjz7bbS5j1mLeeGlPgL lp7MM4/k6LFMZKni+/ekPaXBbb/5JE8+swKfbss7w3m57M6z4X2kag7d/inIBYUipVUZMwCwZsi Zr6LHzNbeys7eGIg2Jw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_01,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 impostorscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 phishscore=0 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607050237 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783288728594158500 Both tlb_protect() and tlb_unprotect_code() are only used within accel/tcg/. Avoid exposing them to the whole code base, declare them in a new "system-page-protection.h" local header. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson Reviewed-by: Chao Liu --- accel/tcg/system-page-protection.h | 17 +++++++++++++++++ include/exec/cputlb.h | 8 ++------ accel/tcg/cputlb.c | 3 ++- accel/tcg/tb-maint.c | 1 + 4 files changed, 22 insertions(+), 7 deletions(-) create mode 100644 accel/tcg/system-page-protection.h diff --git a/accel/tcg/system-page-protection.h b/accel/tcg/system-page-pro= tection.h new file mode 100644 index 00000000000..52896c6d24a --- /dev/null +++ b/accel/tcg/system-page-protection.h @@ -0,0 +1,17 @@ +/* + * QEMU page protection (system emulation) + * + * Copyright (c) 2003 Fabrice Bellard + * + * SPDX-License-Identifier: LGPL-2.1-or-later + */ +#ifndef SYSTEM_PAGE_PROTECTION_H +#define SYSTEM_PAGE_PROTECTION_H + +#include "system/ram_addr.h" + +void tlb_protect_code(ram_addr_t ram_addr); +void tlb_unprotect_code(ram_addr_t ram_addr); + +#endif + diff --git a/include/exec/cputlb.h b/include/exec/cputlb.h index 3a9603a6965..f7f7020382d 100644 --- a/include/exec/cputlb.h +++ b/include/exec/cputlb.h @@ -24,14 +24,10 @@ #include "exec/hwaddr.h" #include "exec/memattrs.h" #include "exec/vaddr.h" -#include "system/ram_addr.h" - -#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY) -void tlb_protect_code(ram_addr_t ram_addr); -void tlb_unprotect_code(ram_addr_t ram_addr); -#endif =20 #ifndef CONFIG_USER_ONLY +#include "system/ram_addr.h" + void tlb_reset_dirty(CPUState *cpu, uintptr_t start, uintptr_t length); void tlb_reset_dirty_range_all(ram_addr_t start, ram_addr_t length); #endif diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c index 6e66f3c6e93..7f7c208ba12 100644 --- a/accel/tcg/cputlb.c +++ b/accel/tcg/cputlb.c @@ -1,5 +1,5 @@ /* - * Common CPU TLB handling + * Common CPU TLB handling (system emulation) * * Copyright (c) 2003 Fabrice Bellard * @@ -47,6 +47,7 @@ #include "tb-hash.h" #include "tlb-bounds.h" #include "internal-common.h" +#include "system-page-protection.h" #ifdef CONFIG_PLUGIN #include "qemu/plugin-memory.h" #endif diff --git a/accel/tcg/tb-maint.c b/accel/tcg/tb-maint.c index c33dbf65e7f..4313864d2c5 100644 --- a/accel/tcg/tb-maint.c +++ b/accel/tcg/tb-maint.c @@ -38,6 +38,7 @@ #include "user/page-protection.h" #define runstate_is_running() true #else +#include "system-page-protection.h" #include "system/runstate.h" #endif #include "trace.h" --=20 2.53.0 From nobody Sun Jul 26 11:01:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783288710; cv=none; d=zohomail.com; s=zohoarc; b=LRBOLMb07l6EIGbAlG44jK0u/vqiQQhNkVq+Hexc60Aoel/UI/YWOjQLGOKFzDC+N7AhGeeRqsa/wBQyYoNHzaLXXkiGBQQjU30Dr1XbxAGrItGbBMnoJ+7Vq017KbmR0R72QB+tBFx93Xdo/iaNnShawgW7vz/eH6Mt78CbKC4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783288710; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=YpvyPafEgMLcx7hXhSA7L2Lp32OYcohxo8F966bFstA=; b=AvbsoQROcm/cjhctPkC7GwaqjHniXgjGAb5q4ZTrX/sy41/Ril4CQrTlKgRsxtmt7nlR/FQlJf67+rMxxl2ClurNXqkftoVptApWo7kJrc70uR9nWZxlbZv3L+3Hy6bRenJI0yBVTCTRWb6X8Xo6+KtooEoL1RRWC8GSdyOVg5U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783288710526806.3804606231998; Sun, 5 Jul 2026 14:58:30 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgUqk-00046i-GI; Sun, 05 Jul 2026 17:58:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUqj-00044V-5n for qemu-devel@nongnu.org; Sun, 05 Jul 2026 17:58:05 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUqh-0008NX-SU for qemu-devel@nongnu.org; Sun, 05 Jul 2026 17:58:04 -0400 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 665HiqaM2344115 for ; Sun, 5 Jul 2026 21:58:03 GMT Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6srvkjde-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 05 Jul 2026 21:58:02 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e9a2b95b5so357666285a.2 for ; Sun, 05 Jul 2026 14:58:02 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa0960af0sm17718353f8f.30.2026.07.05.14.58.00 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 05 Jul 2026 14:58:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= YpvyPafEgMLcx7hXhSA7L2Lp32OYcohxo8F966bFstA=; b=DWFkCGj8MrbUqvQ7 W1P5Bu68XZYid2cdYmyGQGFUwLJMgomf/dorpnxJvcKms9Ov/HMSgcnv97p6uXE4 riEH9mLj5Ilu6U3eCAsb0wLpOaDtCIJqdsEe4CecMkB9giUPJasvnvG9ZlD9OKX4 ghj1pvPorkuEVdabQD3d10y/HEDA5Rz0L3y44b5v5QAR97U8PyimLcfUsn7rbjiq T1mszzUap+Q4w2xaLR3I1O3CV7W6rBuVIMlKF1K1fgGM/PIZY+8l3DuZcNV2+c0+ 0phxRQkuVKnUAc34Ex2pzGO8u8/QSDLmt6xmcwQUMB2CL+NheEXR8n8j661pq9Qt FxSldw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783288682; x=1783893482; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=YpvyPafEgMLcx7hXhSA7L2Lp32OYcohxo8F966bFstA=; b=d8FWnATkRsm0zHte/y/kNsUUBvuHfykmzmaU9NKQxSVC7agpThcLDgySMMe6XNzLEC V3pD6Xh3093YtyHaNL4Rm4KHnrDyW8WktPCZgHGWkk6mdztyPvyB+WQ3CjhSF3rJQfKT Ja5Slr6Hqjvk0nrAj8sRQrFnIblfpjlWD4mUXYXJJUX/GAgMJ4GrPBb98rbPGHPhFgTB 9K1dN41Kxmuku/EU1jNi98m0ucZPDkvcVW3ARJ3IxH7yk9ODiico+kF2iWHJRUBWHGyr g926kxASynxpIUcgvJ1iG5JANYeOyJJmmkXY2pWGLRVuLT6pAgpG3PYetCumDaa+I4My qgwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783288682; x=1783893482; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=YpvyPafEgMLcx7hXhSA7L2Lp32OYcohxo8F966bFstA=; b=A60lfsbTvET0rYq3gqGcjS43bCM6v1ypnnQ4SVtpB+MB5cD0qgDG5Y7HgSm3nSapla /GER/OPbgiSv+9ueHGjGNPt0//9PNQEUlzU6on1tUB/efh47RfhRWSYG3mSvfJ6fqAax s6sxohRuj6QrSxJ+xi7nPOuouaJGlK7mC//L3dsltvUy9uqdM4BFNzOMsCLjBL3Lp6Sz 2MtMttYkwJAKRjYAeWolEt4KnH6nxEUrMWGQUmz4jCNHv+btMtBTYMRa4nqoyYUlXzOD OuZ+idQqrR6HJ0UI5j6jo6ooLevRWYCGHTw+HGHJTDb4flyF0uIZKaJbbMMOC9U6bwxa DYdA== X-Gm-Message-State: AOJu0YxTVmD7UukEoHEkX467jWiVy6a1wOc9Maev8FyaNusqc2KIJFdf apD36CAUaJanUTrxYARJTl1fRB8e4zfCrEwEamjMGUQS+Eshg/xAVbPAB41lFIdTionetcMEkQZ gVIswQmUK6m86ZPCj/1odvj6Imr4+vCr1qYewDnPeuyPcWll1xZjmkJ6+JEh6nOd0mg== X-Gm-Gg: AfdE7cl1rT2gTCBUj441dPUr8DslsN8VYQabUdiHl0CvhtsSlgx/t/iXFIutSQNZIZe LNM/rAeukEUwpQB5xdy/iDUivhhAzXJyTgctEeNA90n/0PyhY3ASIw2xs3BIzxMyu+iOLFmNeBx zsLRWU96qD04/kBeO+3vpLEEHROsCdcN8HEPVCiwYsfzRpy8i/LNgQCv6QlWqBQRy3uRJtCm8kJ YurnSbs/Ba4L5MsaF/abuSzKrZIteBMlc4u+xrGgrw9s43ktJ6HgVmeHm8UMRZBRYThIzXL9aZj NWVKV0Yn9wVXS3uVBd9L6pWH+avsx24l6UF2c1aKjeP0mvfbmnW3mQ3yL+siDv9pZA6AV6MfqxT xxNUFuVeUCZqqjkGWVgxX92QtuBNldbGGeVApoxx0mT4XtcMmaJCvsar1HK39vAcmIbbw X-Received: by 2002:a05:620a:2a09:b0:92b:641f:ea5e with SMTP id af79cd13be357-92e9a1b965bmr1067066185a.0.1783288682377; Sun, 05 Jul 2026 14:58:02 -0700 (PDT) X-Received: by 2002:a05:620a:2a09:b0:92b:641f:ea5e with SMTP id af79cd13be357-92e9a1b965bmr1067063585a.0.1783288681953; Sun, 05 Jul 2026 14:58:01 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , alex.bennee@linaro.org, qemu-s390x@nongnu.org, Magnus Kulke , Zhao Liu , qemu-ppc@nongnu.org, Paolo Bonzini , Xiaoyao Li , Richard Henderson , Mohamed Mediouni , Peter Maydell Subject: [PATCH v3 04/32] accel/hvf: Remove left-over comment Date: Sun, 5 Jul 2026 23:57:00 +0200 Message-ID: <20260705215729.62196-5-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260705215729.62196-1-philmd@oss.qualcomm.com> References: <20260705215729.62196-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=TcamcxQh c=1 sm=1 tr=0 ts=6a4ad36b cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=nS8E-dRYisaDM6zJQEoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: YR4D2mM5xzZxOhM6trFMXzfDjv2DFjZm X-Proofpoint-GUID: YR4D2mM5xzZxOhM6trFMXzfDjv2DFjZm X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA1MDIzNyBTYWx0ZWRfXzdFNI5W7W2DD YKTyWGamH6N+Rqr+/lMBVm5sff/fftRLqTEuuIMLCLFl3xmniFZEuUVW1RVb3ZbIhcYv1CypzlJ 9xyB3Wbexy+q3r0GRDhAlYeG4TT7x4bg1vj9qJy9oJBNMr7DBMDeo+D6ICRQNM45wYgU0ei6cPl xlZBMBniFkgi0Xj09C2L1NOhAwd2T7HN/THUoSLur7+PCNWOLIo0j/x2Y9XzEAlRGqzzblhx352 mQphaXQMnaoAus9yiVVQ+kmaxto4M3Jz282GtYIvtQU6FVM1I6hz1VsaGymjlrI7IuiNEdIQMtC /TBrKb9/K34GdfutSLx3NsB4HqFw25DMhncU2kLrwlty4njjATmCUNzXgV/JdeDTpUL0TGvHJdc BYVjnwRlRb8NcMmB0MkaPLb6x3k/qCy16JTr1/y+pj4qkukGtDdKFtRV24wmc8KIxNMNvUWSTJJ tSHFexpUTE1ZkmcS89Q== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA1MDIzNyBTYWx0ZWRfX2Yvf/xfgs3Wz qrefHITV75Y6eEfRmZ0/kwYnJWZBogoAJ0UtYiDPjwuFO4jnXbZGQFHfIyy2GJVLV6rsrPt9J0T AYi4nWC0bZnOidSHRMJxL7TzSpQls3s= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_01,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 suspectscore=0 bulkscore=0 phishscore=0 impostorscore=0 adultscore=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607050237 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783288712172158500 Missed in commit 6bf331164c5 ("accel/hvf: Drop hvf_slot and hvf_find_overlap_slot"). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- accel/hvf/hvf-accel-ops.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-ops.c index b74a5779c3d..dd2b45b7cb5 100644 --- a/accel/hvf/hvf-accel-ops.c +++ b/accel/hvf/hvf-accel-ops.c @@ -62,8 +62,6 @@ =20 HVFState *hvf_state; =20 -/* Memory slots */ - static void do_hvf_cpu_synchronize_state(CPUState *cpu, run_on_cpu_data ar= g) { if (!cpu->vcpu_dirty) { --=20 2.53.0 From nobody Sun Jul 26 11:01:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783288753; cv=none; d=zohomail.com; s=zohoarc; b=BP1FLmcwk6J5mlCo8Q6jWPK6ex/1zbhEEzFyihabuh++mBTZHCmew5QLtxEWX7sfkrhsQrVhfXyV1CDkROJoh1fsgFHpleec+tC+3I2/j9BQ0BqVggxgUiJrKDitv7QsKMTd6vYvwSvb4xyvzginhJ2CJ210CNT+63/dxs4mzRM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783288753; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=VHVn6ka+QtlPwP926qTrHJauvq/1ZaQUcESPY4KgNsc=; b=isswnAam+Fs1EY47VSwLN6BBxmFgywrfwfZUUOxdUrvZiJII/or/toZs0AH1UiMRljN5tAQuQixm06giewomALn4P6qgdPC1CNSG+bp92TXCEaz/yfeXFkJqyRIZo1zAd9a2k/AN6yJHcJj0VAY5q2CCuAxx8UWEpX1tD4Wv0W8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783288753628490.32781566977565; Sun, 5 Jul 2026 14:59:13 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgUqv-0004Ds-AF; Sun, 05 Jul 2026 17:58:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUqr-0004Be-AU for qemu-devel@nongnu.org; Sun, 05 Jul 2026 17:58:13 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUqp-0008PD-KD for qemu-devel@nongnu.org; Sun, 05 Jul 2026 17:58:13 -0400 Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 665HiYZf2169693 for ; Sun, 5 Jul 2026 21:58:10 GMT Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6tj8kfde-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 05 Jul 2026 21:58:10 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8e934385db1so29575736d6.0 for ; Sun, 05 Jul 2026 14:58:10 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47a9e4d7801sm19629646f8f.16.2026.07.05.14.58.07 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 05 Jul 2026 14:58:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VHVn6ka+QtlPwP926qTrHJauvq/1ZaQUcESPY4KgNsc=; b=G2g4RPBRdRBHAQzr mKFjqssxPfBc2n2nbRlVFTPa9K0vWApzyUkE3moyud2BZ5eqkIof20RK31ppadKv /coUa13CnlPtZopdbGYM/yOpbkcmILmlOn0T5W3nH1fHj7puSFkg/AAMYr94ZprR EWR4Roe4gJgMP/DbW+vT0u+eN2SdbD/JM6NDUJrHtACWExL7li2kY9Xd3klMD9AM V1tf9FOQWsFX0X+jNLD1ReKFxf4J2n+6RuxWugl8nXP6l8ieZtapYB+fc7OYRKwL WA36r5JNIYy/2ZxAhVaitC7IP0XcJjrnGZ8DplVTnAkv1QMujRwqPvso1Hm/qMoZ jkX2Lg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783288690; x=1783893490; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VHVn6ka+QtlPwP926qTrHJauvq/1ZaQUcESPY4KgNsc=; b=S1hqEm63bdJniikHRTerlkEQEW69v0znfHIzJT4f1DTTfvcX6zc96B3SIduCYnGVLM 3ehOLR3SUsD2mG6m0+lu8S0swOEWKnuCzM4JPIgaW5p2GW/qSw3moG7Sk3mKU1mwGAEl cUxLtFVz7lLaonSWJC1lkj0hCYxZJPIxre/F0865FhTiJg12O5s0mn8lSS7X5I9OEcgp yu+1o1Tus5T+ukJx7ehGouLFWahOhXMqhJ5TZt+9+7UttbPV1k83s+qKeXJEDlACwXTr SeOaz2QPJRblqsv9feaTGuNa8J+PsjbcV6rdv5Gj4oc1W6obFZ2u02ChtrcCTcC/zLNj Oy/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783288690; x=1783893490; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VHVn6ka+QtlPwP926qTrHJauvq/1ZaQUcESPY4KgNsc=; b=ifnlhDuO6Kx5k4v/hAeYvgb1tpV8zuX3cCno7jjqx0qpQKODzYf0+6DqLgbn2/plcD QRrAtCJGLwlrTKkUewEYQu3PehgXzU2vyytgqTPqCFpzbizW4r0gAOTD9WFg8UVOzPdS xIcWJzN7ZzGPJHtCi6XFdESjvp5zDEwODVLAxp34ykJxC6tsKocYIOTokZ6jLJPz2Pkm Fsj7PIxBOAXjM7/efeaY+JSlDyjBdeC1BYkMuf8BCLO8PLNmJGsZV+OdrEyYRTaaCfTP zLXhZ2ghe/9M6bTLNALLwYpQgWjoCMKhCMuc+xRxvF7nl94EhPR04+5zghXPAlU0ju2L mBRQ== X-Gm-Message-State: AOJu0YzP+JWUxPq/EGkvhpC6mIlq+TyH8Fkrebx8542IDvh1QBjWHU44 Wf80WXBQJUd4l/U6nlHtA/m1LxkKuU7o32s0YfP3w9xKTOYRUmxDXBz21eC18xaPhKxMlbnf7mn Cv3mg1aLyHq4xcOFnE7Hd5Y5Lf6DvXBZLZ96AbiXgoqAbtS2Rn/AT9bpRhYz56VFZ0A== X-Gm-Gg: AfdE7cnVw94SC/+wbWOv4cDoZnvPT1rclRg1p/+2woPhQvBoMoEErwtTPAk2XNcl+Zt LS5RKqDb+N3HlJghfMjoZGMRrw3YiBGbw4+qjOszp2cVptr8F7zIX2MbTpFs2Dpts8FzkTzTKeg /pONtc0jQiva/snNInnkezs/kGmHJiT/JKRfUOlZs97PYZRY72pjQ9A57Erve0YlWdoz9/wjYNw NWIvOKKjHHLxryTbydCrTrEb9hL8iuN5OGarunLnIQRe+RK/nyh2dIG8QDv2jOxwdEjZgjEHEV0 JZpLhmB0nbAcA6LqdfmddegILjpUOmTV1NQUo70S0UmgKNShU1pF/FjNiZn8c+v00J6/R8hEIme O9uWypxNC8WG71PBgsLtXLkEoOu4c6/rTyLjCErPpAfCdDEnXYgd/MGXBPOdOoYw5nsgk X-Received: by 2002:a05:620a:3189:b0:92e:745c:6c5a with SMTP id af79cd13be357-92e9a312a1amr1169715785a.14.1783288689928; Sun, 05 Jul 2026 14:58:09 -0700 (PDT) X-Received: by 2002:a05:620a:3189:b0:92e:745c:6c5a with SMTP id af79cd13be357-92e9a312a1amr1169712385a.14.1783288689463; Sun, 05 Jul 2026 14:58:09 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , alex.bennee@linaro.org, qemu-s390x@nongnu.org, Magnus Kulke , Zhao Liu , qemu-ppc@nongnu.org, Paolo Bonzini , Xiaoyao Li , Richard Henderson , Mohamed Mediouni , Peter Maydell Subject: [PATCH v3 05/32] accel/mshv: Replace @dirty field by generic CPUState::vcpu_dirty field Date: Sun, 5 Jul 2026 23:57:01 +0200 Message-ID: <20260705215729.62196-6-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260705215729.62196-1-philmd@oss.qualcomm.com> References: <20260705215729.62196-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA1MDIzNyBTYWx0ZWRfX6sSlJu9iiuPH EPhpXSu2pIQLFl571Cv526cTzKsSke+ONFCwn0seN7KjeUXHwuyC90Kbi2Swr8nHklvb761Xcp3 3mwky1D76QdxzdFC2gJOYOKEp7+3W+ALnXZkvjQnpInShVT9HqPRUqEJ578MLXdJC0XCEEoG0lj xYH0D3SvbxhkTYhx+XojJKYBR92s4vk8vS5+ikPsrIHOopZjvmmhj4z+ABWP1K90JHaQKUptQqG fhzajr8GLXKgo8SvtwZFAWoH94lSFOc4gkL2A0uIwFMNxSx4cLNIfb/lOi3A2QIuOptj4p3Tt1y 0w4TldpvwOjURG/c03JxubKpcH5XcVxMiEUbfFx+XqZ5ph4058FR3l/fGcUy6oyMjdqy8CFyU+q zCVafNxxC6QIK7DZPtZOVmkXcg+PaI5n62DZyNe6uuAY0TjifHQPsKeSWfL7CT5O5mo4UizGa8E Yqmw9d2G5oszJg2AQVA== X-Proofpoint-ORIG-GUID: q8Kh0VEDOxLqlNnv-ebK4K99p6OiljiC X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA1MDIzNyBTYWx0ZWRfX5wRQPlVDktyi A4X7vB0bqWVMEmkMgPkNqh5qnTP0srPjxkXq2fPDr0TjMsBgLKMgwNFAhiFylwWlfb9oe5QSCns roUoFYcuGMHLljV/8ZtUebfk/vwKb6A= X-Proofpoint-GUID: q8Kh0VEDOxLqlNnv-ebK4K99p6OiljiC X-Authority-Analysis: v=2.4 cv=H6TrBeYi c=1 sm=1 tr=0 ts=6a4ad372 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=yMhMjlubAAAA:8 a=KKAkSRfTAAAA:8 a=lTdEn7Fablbk7hdpwAcA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=O8hF6Hzn-FEA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_01,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 suspectscore=0 bulkscore=0 impostorscore=0 adultscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607050237 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783288754329158501 No need for accel-specific @dirty field when we have a generic one in CPUState. (Other accelerators already did that in commits 6f13a0ada01..36ab216b81d). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Magnus Kulke Reviewed-by: Richard Henderson --- include/system/mshv_int.h | 1 - accel/mshv/mshv-all.c | 18 +++++++++--------- target/i386/mshv/mshv-cpu.c | 6 +++--- 3 files changed, 12 insertions(+), 13 deletions(-) diff --git a/include/system/mshv_int.h b/include/system/mshv_int.h index ba3073888ac..b91c4d661a3 100644 --- a/include/system/mshv_int.h +++ b/include/system/mshv_int.h @@ -43,7 +43,6 @@ typedef struct MshvHvCallArgs { =20 struct AccelCPUState { int cpufd; - bool dirty; MshvHvCallArgs hvcall_args; }; =20 diff --git a/accel/mshv/mshv-all.c b/accel/mshv/mshv-all.c index 9452504ac28..1959baf6672 100644 --- a/accel/mshv/mshv-all.c +++ b/accel/mshv/mshv-all.c @@ -531,7 +531,7 @@ static int mshv_init_vcpu(CPUState *cpu) } =20 mshv_arch_init_vcpu(cpu); - cpu->accel->dirty =3D true; + cpu->vcpu_dirty =3D true; =20 return 0; } @@ -617,7 +617,7 @@ static int mshv_cpu_exec(CPUState *cpu) cpu_exec_start(cpu); =20 do { - if (cpu->accel->dirty) { + if (cpu->vcpu_dirty) { ret =3D mshv_arch_store_vcpu_state(cpu); if (ret) { error_report("Failed to put registers after init: %s", @@ -625,7 +625,7 @@ static int mshv_cpu_exec(CPUState *cpu) ret =3D -1; break; } - cpu->accel->dirty =3D false; + cpu->vcpu_dirty =3D false; } =20 ret =3D mshv_run_vcpu(mshv_state->vm, cpu, &mshv_msg, &exit_reason= ); @@ -746,7 +746,7 @@ static void do_mshv_cpu_synchronize_post_init(CPUState = *cpu, abort(); } =20 - cpu->accel->dirty =3D false; + cpu->vcpu_dirty =3D false; } =20 static void mshv_cpu_synchronize_post_init(CPUState *cpu) @@ -763,13 +763,13 @@ static void mshv_cpu_synchronize_post_reset(CPUState = *cpu) cpu_dump_state(cpu, stderr, CPU_DUMP_CODE); vm_stop(RUN_STATE_INTERNAL_ERROR); } - cpu->accel->dirty =3D false; + cpu->vcpu_dirty =3D false; } =20 static void do_mshv_cpu_synchronize_pre_loadvm(CPUState *cpu, run_on_cpu_data arg) { - cpu->accel->dirty =3D true; + cpu->vcpu_dirty =3D true; } =20 static void mshv_cpu_synchronize_pre_loadvm(CPUState *cpu) @@ -779,7 +779,7 @@ static void mshv_cpu_synchronize_pre_loadvm(CPUState *c= pu) =20 static void do_mshv_cpu_synchronize(CPUState *cpu, run_on_cpu_data arg) { - if (!cpu->accel->dirty) { + if (!cpu->vcpu_dirty) { int ret =3D mshv_arch_load_vcpu_state(cpu); if (ret < 0) { error_report("Failed to load registers for vcpu %d", @@ -789,13 +789,13 @@ static void do_mshv_cpu_synchronize(CPUState *cpu, ru= n_on_cpu_data arg) vm_stop(RUN_STATE_INTERNAL_ERROR); } =20 - cpu->accel->dirty =3D true; + cpu->vcpu_dirty =3D true; } } =20 static void mshv_cpu_synchronize(CPUState *cpu) { - if (!cpu->accel->dirty) { + if (!cpu->vcpu_dirty) { run_on_cpu(cpu, do_mshv_cpu_synchronize, RUN_ON_CPU_NULL); } } diff --git a/target/i386/mshv/mshv-cpu.c b/target/i386/mshv/mshv-cpu.c index 126ca40b481..1c433c408c8 100644 --- a/target/i386/mshv/mshv-cpu.c +++ b/target/i386/mshv/mshv-cpu.c @@ -1692,7 +1692,7 @@ static int pio_write(uint64_t port, const uint8_t *da= ta, uintptr_t size, return ret; } =20 -static int handle_pio_non_str(const CPUState *cpu, +static int handle_pio_non_str(CPUState *cpu, hv_x64_io_port_intercept_message *info) { size_t len =3D info->access_info.access_size; @@ -1748,7 +1748,7 @@ static int handle_pio_non_str(const CPUState *cpu, return -1; } =20 - cpu->accel->dirty =3D false; + cpu->vcpu_dirty =3D false; =20 return 0; } @@ -1909,7 +1909,7 @@ static int handle_pio_str(CPUState *cpu, hv_x64_io_po= rt_intercept_message *info) return -1; } =20 - cpu->accel->dirty =3D false; + cpu->vcpu_dirty =3D false; =20 return 0; } --=20 2.53.0 From nobody Sun Jul 26 11:01:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783288755; cv=none; d=zohomail.com; s=zohoarc; b=Rhn6wpx0bIrv2ogte2YbTFbJZ/EcUrAt5AoZPRAE22LEdrOlaT/n+lhJR2E9HhXjbDYO71L25NpVwNi6kMPRoqBUeWJjgivTudqG0hf7cBaiCdptN8Cvt9uTuiKt20r4vMehZKIf3kl46aZ4WQ4lzeO00zEQIJ59AGUvkpYOcwU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783288755; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1x7QSxrq42ew5YZruERIhg8L4kv2+83eMIh0NOzptfw=; b=fW+Fw3qKBQkK0oHk1/r+yix03e/k7nzHFwv2+eJvQGn/8LlpAJqeGEwGdpxU2arTMl5jtzw1Mzex9Gooh8yV6qVE7bau0wwVln9wsMbNbEoEe5bKCUa9hDqFtHVcLv0uYIxoTguYNg1gOWBy/xFzMSRrV305fDbvPEIlHe5Vn4Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783288755404191.5437267614377; Sun, 5 Jul 2026 14:59:15 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgUrA-0004rE-VW; Sun, 05 Jul 2026 17:58:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUr8-0004md-Vn for qemu-devel@nongnu.org; Sun, 05 Jul 2026 17:58:30 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUr7-0008Pt-D2 for qemu-devel@nongnu.org; Sun, 05 Jul 2026 17:58:30 -0400 Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 665LSl8J2779466 for ; Sun, 5 Jul 2026 21:58:18 GMT Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6sgh3k6s-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 05 Jul 2026 21:58:18 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92ac0a54110so261536985a.2 for ; Sun, 05 Jul 2026 14:58:18 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493cfb6f199sm205985145e9.3.2026.07.05.14.58.15 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 05 Jul 2026 14:58:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1x7QSxrq42ew5YZruERIhg8L4kv2+83eMIh0NOzptfw=; b=ks5I3CwIs3W9lqlC mGOKtwIq1Y4KPr+zaPrn6NR4jwcH/gBi613pzrwOfpFAimE5ZOtLRrGRYlbDy+YE C3oiEpnPDRsP8EA8oscKz4pxqFchWmseByGUfXAraOBfwk0BoKmmufTkoiwYKgdt Tya4vZES2ZVZ5PNs/lIR+FUj6ItlVNiOAWpok7Xsq9Td15vkDVTZfSgU+KDE4msA ZfFBPqPceyVtbimmlDZQz6c9DyNv1ZvAS9oWViWCkZTzbPERBRHA0sS2hG2UAtEu aRkmDjIe4GLsrGHeGprL38RSnusF5Rh/DsC9gI7+cFUejvjFu0edqWQHqce1NK9a RfRa8w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783288698; x=1783893498; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1x7QSxrq42ew5YZruERIhg8L4kv2+83eMIh0NOzptfw=; b=EV22zYLf9eN22yln/kCT+d/xuWasqWu7PR3daO4aMb4K/evoMJDp4t6ollvcUl2Wja Nixw8j3ZGRlMNaeRz14IHwtrSKA3J0OHS5Uw9b7T7FPg6NNDuysVnwJHLUJsFGj0ESQm 0jDBmtTKhgFSUy4eqbQN/VGeqB5IalTBYlz3p3/uvdxAM6+F+RSKlnKliwJTVntIeAXK gOjuIahzN7fPLzH/D07SYID6rlGjjf+UtZE/a97dcW6o4oL4w/DjbWKti1qJ4uSuYKow 2kqe8u9fhXvVtt1sNreG1/8Kvs18+z1Bh9+voa2SnM0i4vdbi6sbFvfnruNjOA3wFnsE WJtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783288698; x=1783893498; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1x7QSxrq42ew5YZruERIhg8L4kv2+83eMIh0NOzptfw=; b=rdoYKl2ADJRXEpb2Q55ygGxd4lGY7f/6sJBZ3Q8W3+dRwBeXgwaS05qcw2qjKCtOR4 sjoc7/ucIuyL+d/u1f4C/LzQRcQcLJk3KL+gSsU0lt9uCzKs5Tl8BVWAnCeJyKXcKBGn /1bVGEXAjaNugJqth74f9Vq375eEPUOdWaJfBOcfYhQHTUkOs0HhmElasooCgQt04MyB OJHnZCpFca2qZm0fmnaZw0zKhWTYnlckJjyBrBxz42cWhRySBOy8lQ0BQ/KNpqCZZC0Y xRAk3ksoaVBpR7nUdsBCB3zZDBEvYm5vZay24aRsTBw1xQGHkmvrXji55uDMivUNR1Sb 1x9A== X-Gm-Message-State: AOJu0YytEEGf2k4DbzblgQMgUNB0pmGLFc55IyuRMUZSL6pGHy8/jo1C C2iH+M/nuP7V6FbIFtUvptJrDBhSzsPunVuNt9RJk/o3vqIpEgOA8HG8SuG9D3OGSwl7BByBd8M mXIhxciCjt2SO7nj4iEo3TgvYlgkw593K1zmu6mggypCYSDnwp7JmmfdX9odHlOFZFw== X-Gm-Gg: AfdE7ckn7PnU3ucwRWt3PW+XYSBRsOK/POwiOY7zVqfPE0b9rUALhdQrrD4tdgVH+sP uxua0Kh0n0kZAkQVXPKRLIKIIgfBYuChFDNHp50A4F5wCsdhOuUZBsGVv1W24dqfBnjbyoQFNgd zuY4EHKaZNhjNj1977Y8ttYRkIXUgTeiqnBLqQU4VxClWdnmDiOv3CehVZj+ljvw4VkH38yU6SX kKp8qW0YDzGXryT3ZNo+KWY6tG6cPy1aCrBMn8uSz+7yf6Bh8aPakx8Qvjku4e1baYNBy4dhubo iZEjUvPi3kfJZNLGP4rSEzczk6LAzAM212iCPkuCTnnD2K18i0TDlCj1M0D69XuV/wZoCR1j/qV ElKJWy7oCTNHcPQlvfT+cfbUT4dlykM6+5dJwZ2bxDBrEttGse8df3g== X-Received: by 2002:a05:620a:29d2:b0:914:e3dd:17ea with SMTP id af79cd13be357-92e9a35a422mr1067136685a.12.1783288697862; Sun, 05 Jul 2026 14:58:17 -0700 (PDT) X-Received: by 2002:a05:620a:29d2:b0:914:e3dd:17ea with SMTP id af79cd13be357-92e9a35a422mr1067135385a.12.1783288697456; Sun, 05 Jul 2026 14:58:17 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , alex.bennee@linaro.org, qemu-s390x@nongnu.org, Magnus Kulke , Zhao Liu , qemu-ppc@nongnu.org, Paolo Bonzini , Xiaoyao Li , Richard Henderson , Mohamed Mediouni , Peter Maydell Subject: [PATCH v3 06/32] gdbstub: Add trace event for STEP packet handler Date: Sun, 5 Jul 2026 23:57:02 +0200 Message-ID: <20260705215729.62196-7-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260705215729.62196-1-philmd@oss.qualcomm.com> References: <20260705215729.62196-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=bLkm5v+Z c=1 sm=1 tr=0 ts=6a4ad37a cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=nS8E-dRYisaDM6zJQEoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA1MDIzNyBTYWx0ZWRfX8U1tuLA/rV74 X0PHBNln1DDhdtwo9wPJFBWSosnZlpTDgRY8gw2jlU4VYNjClwV0156EYxV/4xXR/gYMM4SV+9D i2s/EIFhWjINQWEMTp0vTbkw5yJmiCRYoNRiq0yb62jqdxa3qP/SOOS3Agp9qKyEY4djd6azOgZ o7sUtsi/HoGepKRjORhRHGAmRXIm+A72cf6W4eJHCLthuwXIIEhWfHgBiXGsokZioGLk0hslc9X rLAj8UYCi2zdkNP0/4lETDNgsIwSuAQpa5Ywzo8DzxBQ1FmldjWYs//xUuzrvma6YbxsQmXUU1c f52VXqoFracVy9aYNYPbv54u9ae2+7jPBJ8g0pb3c+cKE6HYqnVElBVG2NQwjHXFd+CTNLINlRU K77f3nxQhMgRjJ/nlH5QB0lfC2KnwaPVyZTfL6UfbHelx7XzxBRbZX1h/vnGeGKFtoVoaGtls4H 7X/To/Z2H+q43I6niBQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA1MDIzNyBTYWx0ZWRfXzrQxW+VdBgIz lUDPXXnkTSnmQPDUAuHJ5NDPVr6LUVSoR5A2oOjNaqSIf3HH5gnNf9g04khXlOxq0QopO5iL0A5 8tAwsTBhjuGMc/Oj100m6pB0rtctJ/U= X-Proofpoint-ORIG-GUID: tCnKqK1r_9fs9TxpPs-ZyoJagBqXYDIK X-Proofpoint-GUID: tCnKqK1r_9fs9TxpPs-ZyoJagBqXYDIK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_01,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 impostorscore=0 spamscore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607050237 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783288756226158500 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Acked-by: Alex Benn=C3=A9e --- gdbstub/gdbstub.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 26366acb674..246e7746300 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -1369,6 +1369,7 @@ static void handle_step(GArray *params, void *user_ct= x) gdb_set_cpu_pc(gdb_get_cmd_param(params, 0)->val_ull); } =20 + trace_gdbstub_op_stepping(gdbserver_state.c_cpu->cpu_index); cpu_single_step(gdbserver_state.c_cpu, gdbserver_state.sstep_flags); gdb_continue(); } --=20 2.53.0 From nobody Sun Jul 26 11:01:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783288795; cv=none; d=zohomail.com; s=zohoarc; b=WTJS2G1KlWfC3gaqQQGMqFxkzsQc64vcWhu96XawQLp2/HnQ1GKvdygAP/2hezZpOhtoful8q4/3SGPXCLYGxhG+RGLp/16l8OQjeg2K6iB6bty64NKsaW9GYLZqWIGqBID/5q4ZZPASOnZHInpM00yyc7pGTz7pBWXuv1hAKrI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783288795; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=zlzfQXqCfD0fOdphKFvmR4aYcVqlSHJCNldgrmBSnBc=; b=JKzcUGHE2qrX9VwqcBLB6iKoVnAAk9NhdRfChrae+uu3HHJgia7NjOVZFwAYaVlql75T8D3UQhLr/9MpaDrTGQ62F2+zE9G67sTAPLMgryE9OUn8NgQ5OQBHxAFOVqDdkXoah0Mzy6O+UqwREORQ0QSDQge/EXZ388tablb/JW4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783288795923235.40265915241037; Sun, 5 Jul 2026 14:59:55 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgUrA-0004qU-HJ; Sun, 05 Jul 2026 17:58:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUr8-0004kM-H6 for qemu-devel@nongnu.org; Sun, 05 Jul 2026 17:58:30 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUr5-0008TV-Ox for qemu-devel@nongnu.org; Sun, 05 Jul 2026 17:58:30 -0400 Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 665Hhav82324471 for ; Sun, 5 Jul 2026 21:58:26 GMT Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6qvgutqn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 05 Jul 2026 21:58:26 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e82060977so249828185a.1 for ; Sun, 05 Jul 2026 14:58:26 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47a9de1d910sm18646363f8f.6.2026.07.05.14.58.23 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 05 Jul 2026 14:58:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zlzfQXqCfD0fOdphKFvmR4aYcVqlSHJCNldgrmBSnBc=; b=bNGT7SSs6inJsAt4 DjvYFWKeh4YwR7k7ibc0KQZmxHuuXkJVnlzJ1xr8o7awZbDrkJat9N1oAeaiANOB zc1yN2l9iUJcUozQgX5SMDh/L/iHoOrKSgR5n8OicdQN1m5f8HePi+Nv/boUVY5J V4TpJ6psEY3oWqCqjJtHvDRpIQV6KcaENI84I4RPF03uTzRpD1OORsqB0viLaFRv Pq6XXjvY+XDERICAUU2fETXexguHElpI440lw1y7HYWSMG5I56jtSEnySV/AbfxH US/i+q1SRn0l/eM65ZHyej2SVGcr12L204AOQeuoXAYfvil7+rjL+RRVf5PSKQc4 dGPBSQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783288705; x=1783893505; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zlzfQXqCfD0fOdphKFvmR4aYcVqlSHJCNldgrmBSnBc=; b=d8OMYyViQOmY7QeNk5pyL7hXJO18S4HQ9J0+EbkNFUYrWYt/D5WX9xCpiGaoTBZm/s C24BIgjxx2/Y/HBhC0j6P062x6j+14Mn0VBhFv1YJM85VUa2Ijz+sLVSgbPaEaQMtRoI s772jApPXFcestOY+gvPWUpsTxobHCkTD3b54TiS0ZpyjMfSro2F3VWCIGxA7aG3jHAR dumwjq2D/X4Ex0zr4E6Po7ipehC18YvK1TPvyUXHA5nyeFd+z1beG4ppzFY5ONUSROoz T5bGBPoi3N0AaIQMo9LxiUpopIFHbaSwxL3LiJX9j3gKkTIoANJg8IJCAdR1zAFVKY7c SUeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783288705; x=1783893505; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zlzfQXqCfD0fOdphKFvmR4aYcVqlSHJCNldgrmBSnBc=; b=Feq/KzQTYsR3sCWIpTN27mrBO/7n47f0TYLpHGpU8aS0e1XPa3V3tp59WedIWGs/nU l2gabL24fBSPD+d26cRkxztTJh35AgKFxAwL1olO03BnIjdCtXaPdolagWxMtvMm1MVf QsefsNm5TaHpyLwQ6TUStiw3EGqWZVu0asGbjW+kYnBLfUuzDPbPIJh7gnG8t47WuJfl AZiqqGYkLkypdGDMRkHnDSrAAAnsNfIfjNcHAYzMR2mLSfRRR0VKCGPhAgP2VHjpfDuE JHm5UJOZ40oCH8Hmj1a8DQnPnnc3Ip1A9j+mqRX1if9vTz2DLjgBCkWOQts0Pmt3Vvq3 wDyg== X-Gm-Message-State: AOJu0YzoAq68l6JOg/3RG537Fl8aScK36gCcM9VWiFJjIkgD2KKRRTx/ 7IbBSe6WyPBJ2ZILz+j2HhjYJj1tgJnKzDHbv1A83FTproNsBLiZXHvXIcsj8oQpdAnNgHWBHOO FZpX7ypTUjW/b5xyc154P+2qvqwzBsUdrXF+Ev/rsim98fP/GavhRYUgCJK6dIw06xQ== X-Gm-Gg: AfdE7clLmOb1VFG14vnJihSORHdO29V6N+yv1BLd6ygMsrh3x2NKoo8NtNmfFDzZ4Ww vm8OC2V0WjMnXtfSoB5t+V3nxO5caN7KECojgNmYgwy6OPBANiyihecX+P3N7CLt5mnag//XyZp 2eJVJ6ae0kP/Kfcq149RUgm0RMkj1rDsy87VUh1AMhbhYm2G1cCkT48E9u8cTXW2tFg7dpWLADB aaxUq1uHxzKbOEknFxj70FL/VwQbmq1mpR2Tres2vtTKsFixY7cRXMyFIlrKsBAW+iBYDpZt3Uh mAtZzTQPgWNb/g2+jzx4Mli10B3eeRZl2rPQsFv8hGwywWmPwSnNOu3XsF7OGuDKfBGBJnOm4jO oKYKWWu23kD68YKvlwZJjEVgtM40QPTL2cI5HBNo+pxT+ykUYezDp3w== X-Received: by 2002:a05:620a:468f:b0:92e:5232:91f8 with SMTP id af79cd13be357-92e8b5d2342mr1471778785a.43.1783288705347; Sun, 05 Jul 2026 14:58:25 -0700 (PDT) X-Received: by 2002:a05:620a:468f:b0:92e:5232:91f8 with SMTP id af79cd13be357-92e8b5d2342mr1471777485a.43.1783288704899; Sun, 05 Jul 2026 14:58:24 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , alex.bennee@linaro.org, qemu-s390x@nongnu.org, Magnus Kulke , Zhao Liu , qemu-ppc@nongnu.org, Paolo Bonzini , Xiaoyao Li , Richard Henderson , Mohamed Mediouni , Peter Maydell Subject: [PATCH v3 07/32] gdbstub: Only return E22 when reverse GDB is not supported Date: Sun, 5 Jul 2026 23:57:03 +0200 Message-ID: <20260705215729.62196-8-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260705215729.62196-1-philmd@oss.qualcomm.com> References: <20260705215729.62196-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=VvoTxe2n c=1 sm=1 tr=0 ts=6a4ad382 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=0n23ylXGgdPVI_k3iFEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: WaKtnMAuGHsGkRZRVZHFdx_d9DqAGUMn X-Proofpoint-GUID: WaKtnMAuGHsGkRZRVZHFdx_d9DqAGUMn X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA1MDIzNyBTYWx0ZWRfX0Br998YPj5OV eyyvonUQkvQ4VU8uOvlwOozkRWb9MEHojxpcgZ+K7pY9T8YcnpfqyAsPuLiqX5L7Oa/TFpPU3dP kWWKX7Klm4eqy8qbyP13esNYwHneF1Y= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA1MDIzNyBTYWx0ZWRfX2sPrPhi3DAut eDo0EqjS/LiXEIl/t5+NmchKN9Pao3j4bSfsG6nU7xbSwCl8hk6xc2HNwVb+tiVWplzLxPD+TPz n4JTB9swv0lV1/a5+3Ipqp8qTYiXQ4MmQGHPpCdlfTaeOx2Zd2meRY3kDoObOwRmcuFOlNyfZ4V Lp/j6P2jAvgRqFUxYe1QPjL3dTHshgxx2Ecw7mIunaUuyZa1WJKBph1ouOMuH09KX5bUUlyguwa 3sJmZyTlPWNspnPsn0Nb4jtfOSZUM2hYuS33HzwOANgpQwUJVL2UKG4DIXP6AhJgXSidZH3NXFl gDVDCG67K2Hu9eP2szzyHWI9e2Acoj2GGZ1248Cyx8umJ8Af40gEfi1d4GZP1cj+WlLzDQvNHk6 lnDGR/p7DSpki2Xx0NFBtwFKy+62TeRB6dQ+OGRgZfmUxa03QyyFgt0KmenmJyDN/EWmZvV5c8Y CVHdE9lMpyNtzUguhJw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_01,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 suspectscore=0 impostorscore=0 clxscore=1015 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607050237 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783288796320158500 No need to keep processing the arguments when we know reverse debugging is not available. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Alex Benn=C3=A9e --- gdbstub/gdbstub.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 246e7746300..f54415a9db7 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -1378,6 +1378,7 @@ static void handle_backward(GArray *params, void *use= r_ctx) { if (!gdb_can_reverse()) { gdb_put_packet("E22"); + return; } if (params->len =3D=3D 1) { switch (gdb_get_cmd_param(params, 0)->opcode) { --=20 2.53.0 From nobody Sun Jul 26 11:01:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783288743; cv=none; d=zohomail.com; s=zohoarc; b=bLn97N7zc1R3RCwiZ1/9xsSg6hnkASVzygbKQx5xfVlXRzx3R/ab7V2DJ1LUo+DCHiUw4GNgheMpFlp/jAI+H6waBCOMflEek179jOePSx5rTnwSNeZpbfVKjCHT4P72FlAsiYwwaS6frM/EO3ulWCZ84qsFwCV5iXeFmlMjRHs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783288743; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=J61D7vmFN/GCddU40nav9DK2OhgRp9ty5MKEmevp7T0=; b=ja3GhAoi8MI0sUeyL81nNtM/P2EaAWHA8lBji/7U/TSl8gAFvW+2mmn0zHIdeMk7DEoCjgNdkPEPlth8Roei02UjQNuG9si3WdYtKA7e1BQ8v0E1J2b8a1zmsIqkbcLepa0hW1pmtJbkPp7bBC0HZreV1YWkrSfRMOyJWGI3uTA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783288743114989.6918722802399; Sun, 5 Jul 2026 14:59:03 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgUrP-0005uy-Ay; Sun, 05 Jul 2026 17:58:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUrO-0005pc-0E for qemu-devel@nongnu.org; Sun, 05 Jul 2026 17:58:46 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUrM-00005b-Dt for qemu-devel@nongnu.org; Sun, 05 Jul 2026 17:58:45 -0400 Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 665HiV6h2273382 for ; Sun, 5 Jul 2026 21:58:33 GMT Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6qhnktws-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 05 Jul 2026 21:58:33 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-92e5fc4c7e9so240357985a.3 for ; Sun, 05 Jul 2026 14:58:33 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47ad69519c2sm19485857f8f.37.2026.07.05.14.58.30 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 05 Jul 2026 14:58:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= J61D7vmFN/GCddU40nav9DK2OhgRp9ty5MKEmevp7T0=; b=TPYFyW9gGpv8vKwW e2LvB2WZv6loFB/AN+maBLwZ9YElLQbFoP0Zce+8PGq0bAHy/uPZ0aEQpqX0xwQ+ Rk8cB0w9BnhdQUhlxpJBubewlv2VBzz3Q5884E9eGIz9xBQjvi7C8UvNS1LPSnzB /GPEu/GO441RJ/rJujd6I7ER21a3f8KJ22wPEliiCC5Am+yuACAlLCLzUut4Vi7y AUq3wQqy/jMUJ7HTtj/yX2QC89F7Femija9WJpdNF4iAc+PJUaJVqFrxNTsN3vqL 6RRZMRKB5JCgri7x4/MZ0jtlWBAhjg1AFTR2hhF3LZcR7oVw+VIcAiti3o+quqCK jHcKUw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783288713; x=1783893513; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=J61D7vmFN/GCddU40nav9DK2OhgRp9ty5MKEmevp7T0=; b=NWYdppV6K37Hnf4SiAu45EIOtbNRyhRNNRogXeYxQ6nuSp+SrKR6LULlYlZRPSbxJL HANJErTEAjY7DELZVE0/rOwkfTZ4KGRA8IXYntsTjHBNjEttqdqWLOP9ZezgC05UuDFJ 3yQuuYH+585quJC9G9F1MfJ3w4FWKo3uLiDKETU/IU6vQQ1Lkz0UL/XuwAi1eD3EA+va vHVAB0+CQwN1JeBvZLlv5p+ZKzZ4wQKnibhV+8SD+IwMn0/W+F0+gV4rnvZcVzkX1vQe 71CTyPAqhWW4ytzM5lmC5FlnsXkuOKBHdOjlcvb1/W+PPKItvJNshxjDDnEpcJAvnER/ 5PYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783288713; x=1783893513; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=J61D7vmFN/GCddU40nav9DK2OhgRp9ty5MKEmevp7T0=; b=oz9Rb5gvmt7uwclrH7GC4l8iSbgrBbE0FgupZ2AQnGnU/GfMntOkxYcAXwwYvacNsn MJG07mVtBqYs9gQFKCmagusMvqI8GzdT8iqsbLjZf+IDg/BoC4BvT+vStqRcvoFkP9T6 ZKuIa3gjxM+pOXZdr2pPfOD/d3HRK2LLdOuvJ8dX22/m1Lp6HHkCD2hufadzwZ2ijgzo vFRxe2ERfjaGNEjNQIjMlw3BNm+lf/qG4xv6/vGMrU+QYfoADH+W1agsf9nw74dvKyyg iTpFdBw6Zqg6kVk1p6Aowe0jbI5xftlakco1NnKJU8WH0rsZeAh7KPhH8gYqxQAbBoUf YrLQ== X-Gm-Message-State: AOJu0Yx46VnBwQq0om24OhIeyXDPiAg7xJKFGp4P76prp/49v+oYXC1f T3x41W/vCSRYlgiY+aOZdKc2ggPEssC7eur6yCwR5Bv3fWtYHhbLXNihKHxA/6ATRVijC2W7Qxo XdDE+LPCNbg7CF+i/KQqKFIXyYTPm17ZyeZJLMvSyc1mG7n/WlOeF3Y9iczK6Uu/ulA== X-Gm-Gg: AfdE7cltV73zqd9MB5c2putYkYQUisFW8d3rnzYKcEzTGxCRh5VOhhnSYYfpvcEiSrA mEPLfa8D3fF3v58ALZUscx9oPQh6AO+F6NLaHsn1KJBb87wKNsbdwsiasPHWLkVWnQThZ6Tb4SO 0I6K05uHCPNvbx4tWQ6CxsrnbxuiyzNo3OFcQmmZCfuMNMoKZ1mkRRmDkuA1etAx7/Bd/jBVckv EA5byEDG3pPjCALG+GJXR9WR+T9PPTC6XNLFLIZnHrhujB1YGD4+Xd70+NgUZgEJQ1LVyIUwdnO BdCZv9T+j+vSeB5Z69yfzSKPUj63htKRAH33J43Rn/E5Cv22TawfQt+cANu5+ZcfCI2EXo2pCbx UkFczYOSen06JFWFhI444x8lL1Xsezk67KwLFaJ2JAePQwHGVPPVWhxfKAsr+HmTBAjyj X-Received: by 2002:a05:620a:19a1:b0:92e:6430:3c79 with SMTP id af79cd13be357-92e9a3a4571mr1097554085a.24.1783288712820; Sun, 05 Jul 2026 14:58:32 -0700 (PDT) X-Received: by 2002:a05:620a:19a1:b0:92e:6430:3c79 with SMTP id af79cd13be357-92e9a3a4571mr1097551385a.24.1783288712380; Sun, 05 Jul 2026 14:58:32 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , alex.bennee@linaro.org, qemu-s390x@nongnu.org, Magnus Kulke , Zhao Liu , qemu-ppc@nongnu.org, Paolo Bonzini , Xiaoyao Li , Richard Henderson , Mohamed Mediouni , Peter Maydell Subject: [PATCH v3 08/32] accel/whpx: Implement missing AccelClass::gdbstub_supported_sstep_flags Date: Sun, 5 Jul 2026 23:57:04 +0200 Message-ID: <20260705215729.62196-9-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260705215729.62196-1-philmd@oss.qualcomm.com> References: <20260705215729.62196-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA1MDIzNyBTYWx0ZWRfX1djRKMUcdEaf Cl8cYkDfP9ckjC9YeodjyBCkfm/fxFxRCnt74b6hDkaAtTiyuLKImMv1bYhrf8tcy5YwaSA/Cn8 ufwihS6sw531lhYP/hoiLtklVgcCTFo= X-Proofpoint-ORIG-GUID: q3gD8Irzf90SPTT0J667cNYxPaYaGCMw X-Authority-Analysis: v=2.4 cv=J+yaKgnS c=1 sm=1 tr=0 ts=6a4ad389 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=glojBnVPa3CR4aLdIrwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA1MDIzNyBTYWx0ZWRfXzf2cGoJtQw7c by8DElYBSbh72bbm/wUi378f7kikaRvnPDEES/0DQGlIesw5XlLi0XucLJNa8ZBfpzZhcao0apu zMWGi5CiHOrBy1Y3kQaJ7ybkZSh6hMJwEK94PGiL6lCuPuNDLFXO4o1EOFkKn1UoAHEQK1gu1hc PbNnkm7vaVNqA+Ceuv8aEne/ZEvKyn8LtxXlS68dRQ7VX7ZnRgtfZrGlb1qt2AeVHN51mseVTWB k0eO83jwAo/+pMkRod/P4mjgHkez2qStIMr3YNG05QTiX9Tr6ea5FopiuDp+6azu2qC1BJOAvR1 ND5iMbP9/Y2fhbdBWVsbcjOq0tm7e+MGMnHLP+fO0ME3J5Nt+AjN/q0bBvFiCofe/fySVBshreu 0dVQjkQgEjKVl+lSw3cqCDtw0SpF+B2+LDt4sU2Yb18RiHzkPG/KW5DSWBT22IDMMyBcNsU5QUV CRZ1QEnvWS7RDB3q3vA== X-Proofpoint-GUID: q3gD8Irzf90SPTT0J667cNYxPaYaGCMw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_01,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 spamscore=0 priorityscore=1501 phishscore=0 impostorscore=0 adultscore=0 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607050237 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783288744189158500 Correct gdbstub support requires some gdbstub_supported_sstep_flags. Apparently missed in commit d7482ffe975 ("whpx: Added support for breakpoints and stepping"), even with the recent 19b48084f71 ("whpx: i386: re-enable guest debug support") fixes. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- include/system/whpx-all.h | 1 + accel/whpx/whpx-common.c | 1 + target/arm/whpx/whpx-all.c | 5 +++++ target/i386/whpx/whpx-all.c | 5 +++++ 4 files changed, 12 insertions(+) diff --git a/include/system/whpx-all.h b/include/system/whpx-all.h index 4022571ffff..0e2d333e919 100644 --- a/include/system/whpx-all.h +++ b/include/system/whpx-all.h @@ -23,6 +23,7 @@ void whpx_arch_destroy_vcpu(CPUState *cpu); void whpx_arch_accel_class_init(ObjectClass *oc); =20 /* called by whpx-accel-ops */ +int whpx_arch_gdbstub_sstep_flags(AccelState *as); bool whpx_arch_supports_guest_debug(void); =20 #endif diff --git a/accel/whpx/whpx-common.c b/accel/whpx/whpx-common.c index 247e12db812..e3f93efc61f 100644 --- a/accel/whpx/whpx-common.c +++ b/accel/whpx/whpx-common.c @@ -527,6 +527,7 @@ static void whpx_accel_class_init(ObjectClass *oc, cons= t void *data) ac->init_machine =3D whpx_accel_init; ac->pre_resume_vm =3D whpx_pre_resume_vm; ac->allowed =3D &whpx_allowed; + ac->gdbstub_supported_sstep_flags =3D whpx_arch_gdbstub_sstep_flags; =20 object_class_property_add(oc, "kernel-irqchip", "on|off|split", NULL, whpx_set_kernel_irqchip, diff --git a/target/arm/whpx/whpx-all.c b/target/arm/whpx/whpx-all.c index 3079c6293c8..5208d7e1dfe 100644 --- a/target/arm/whpx/whpx-all.c +++ b/target/arm/whpx/whpx-all.c @@ -295,6 +295,11 @@ void whpx_translate_cpu_breakpoints( /* Breakpoints aren=E2=80=99t supported on this platform */ } =20 +int whpx_arch_gdbstub_sstep_flags(AccelState *as) +{ + return 0; +} + bool whpx_arch_supports_guest_debug(void)=20 { return false; diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index e626acef2f0..f6e1636a4e0 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -1853,6 +1853,11 @@ void whpx_apply_breakpoints( } } =20 +int whpx_arch_gdbstub_sstep_flags(AccelState *as) +{ + return SSTEP_ENABLE; +} + bool whpx_arch_supports_guest_debug(void)=20 { return true; --=20 2.53.0 From nobody Sun Jul 26 11:01:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783288753; cv=none; d=zohomail.com; s=zohoarc; b=T9ScD92coLwPzI6wOIOc6BC0I8wYiMlXhHJTWIEvB/L5j1ApA24CL/3NajAU5A6IWtZh+XJ6KpCHAMiJnAAECY8GIzQ89wv1h+4H4HTYGtxzJ7vvApoQvp2xoqM7fClaohfqFQqMxvI0ZDRUtWUKGhQDHqk2ujOtSY351Z/AwJU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783288753; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=2GaQV/oxXfUYvhpcWlYYZ/rgvaJkV4F63rsqq0epSeo=; b=BhX5fGrug0c3k9HjUXBawapj/dDaUwa8PqIX4ou7s8TFJA0pIBDUSSGzWWO44V3CUobNRVzcaKZQ5X/FlW9ux4Uwq2ijNRp9PqkUC4EKJfiJ6sWCxamwBtpfqMgc/CQSamJ413dkCVfuC5gE29xYG31FI1ypPcY//Rs8HHlGElM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783288753497581.9250094400334; Sun, 5 Jul 2026 14:59:13 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgUrX-0006LM-3n; Sun, 05 Jul 2026 17:58:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUrV-0006HB-Ay for qemu-devel@nongnu.org; Sun, 05 Jul 2026 17:58:53 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUrT-00007i-Oo for qemu-devel@nongnu.org; Sun, 05 Jul 2026 17:58:53 -0400 Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 665IeDUn2386252 for ; Sun, 5 Jul 2026 21:58:41 GMT Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6qhnktx3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 05 Jul 2026 21:58:40 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92da6f3cc81so292133385a.2 for ; Sun, 05 Jul 2026 14:58:40 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47a9e4d8410sm18975192f8f.15.2026.07.05.14.58.38 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 05 Jul 2026 14:58:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2GaQV/oxXfUYvhpcWlYYZ/rgvaJkV4F63rsqq0epSeo=; b=fEfG/5W2+T989hVR irdD9YWA+rDMF2j/fX73lwTXMaKL23udxkEjTitwjN+nbg71gZYUHUX7WKH9ZBwE +mABVwOCd3iRAzWPA5IozJ5E/sWe/MyLEjWguuBgab/9UoCAfMB7Wl0BX93WO95u f2lo3BZoXcgWJRKexBBKNM32BScAueJg7YPnSKKI08BMBnBhi9TdUcIrJyHEp3yk lcRoIEZzaULIZY3TTA6N6RcRvY9inUcVyf6Z6KQye1kFJkQAFKLJkZ8RdtmwlLRL j8tPcMg5JrZSE2jo2L8fzSmdynpokrx4YtJNWuRO4gd2Q38iY++m+XtAL5T4olJf 64TbSg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783288720; x=1783893520; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=2GaQV/oxXfUYvhpcWlYYZ/rgvaJkV4F63rsqq0epSeo=; b=Bz0K04+0GtM+WI3LUewNHC6IXhjNWdg8Bf/RK/ossBiqknHjUi7ML03Fqme2FC6Ar1 3mQRYTdZtkak0yK5XZR/3UhiwP7i8qVnPqBYEniEex1Mvhn/XFK+9x8v2BY+MQEoykMx zbQ2yrKhe9/zZikQzIb7NNZQmnJdbVKfwZGZf0pk+hZJFaBvIEnuXOJB2ZyL1IiBjVa8 dJlWM7WoNbKVWAS+L854garZzJpXKSwXN7kIghHCyf7r0tMkbaIhJQMPEDffYXY2zSGA SzrTwPBotismveCPgkkEVMFrGyzkRPrUH1QJbOKNtsSJYixMYqENK3YmMhIzJ/GGwy1G d12w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783288720; x=1783893520; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=2GaQV/oxXfUYvhpcWlYYZ/rgvaJkV4F63rsqq0epSeo=; b=kJaf1rAoL2xquOP+sAMlQdCHCtZxxN7bbzXhlhC8YVFlPoj5SrDl0RoLbHhU6kG+8Z G3oW8rBUTp/VMYMvh+z1TVuU8xswnJmGqQUgaJwlwJ/WRZP4kHYY3VOXzFWg4echpFUV SYcv+3ZNY8SVk3hAPctjYYQr1FnuAbfaG8LvO3ANaNef+nzqEluWVu0GZ88X47js71mo XwILGpmXOqPNpR2ADBE340msrAXsixL7Mv5Lh8RHDg47tGybWpX/MyZ7MffgwwvK43Y1 BoxPcErMyAQqO734ZmrYXcClPkxaK65qC4YCbp5M93fpRVN59ln7YJXtp3yJN3iz860j tRCg== X-Gm-Message-State: AOJu0YwHG9tirqWR8U3pZxGLd7lvh+033e0g9Y5CwbeJOYJzzadwMPH6 gdX1E8JRQJ6jVS9IxswhCg/wDbCBPBLFvQzfK2UgrNWZX+K/14CoxVB7yZeOVAp2/2LWumLxVle D4bUi0O+Qd/g2P5azkHb7mIggeaij1OLDUvA5+2xXYFLoRRgOtuT6fjkkL7hMr/0hEg== X-Gm-Gg: AfdE7cnBFkj0zZ1s/4VA9+/ekw/fZlKStySRex5eoPU9VXb7ZBb0BEaIEe0pZL7q01C fQpiKQ2gEyrj2QMKRVNoBzKEY5a1r6+ZnVE2o737Ek+RWhI8XFga7NZpIdP4eVDG6HLEr9mbCD2 mMSsZ2wd3Qenl5Sc6u4dWSAkTxlkOtEHGnsEfUlWEvoRaSlENRDu0xleU/p4i9cIpFpXAx1REnj HU3bg8REE2VFksdBq5VUFeEyGvhYCeewq25b6tQwoaNccbJIf96fsjCH4yulfGk+XtQz+DxuVtM LDA0uws28Z/Tsci6K25MqmJjObrtOrCC1xw0i8N3wtKhpQlsYQZZBQAbR8UgR1+1skDxuoDZTnj X9R5RVZpNTVD5sTHcpFkFUzZbcCSwC3WiaIIfHk+LTHsYCDJV4vcn/A== X-Received: by 2002:a05:620a:3189:b0:90d:c28d:9666 with SMTP id af79cd13be357-92e9a3d8c5amr1003639085a.30.1783288720267; Sun, 05 Jul 2026 14:58:40 -0700 (PDT) X-Received: by 2002:a05:620a:3189:b0:90d:c28d:9666 with SMTP id af79cd13be357-92e9a3d8c5amr1003637385a.30.1783288719844; Sun, 05 Jul 2026 14:58:39 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , alex.bennee@linaro.org, qemu-s390x@nongnu.org, Magnus Kulke , Zhao Liu , qemu-ppc@nongnu.org, Paolo Bonzini , Xiaoyao Li , Richard Henderson , Mohamed Mediouni , Peter Maydell Subject: [PATCH v3 09/32] accel/kvm: Always define AccelOpsClass::supports_guest_debug Date: Sun, 5 Jul 2026 23:57:05 +0200 Message-ID: <20260705215729.62196-10-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260705215729.62196-1-philmd@oss.qualcomm.com> References: <20260705215729.62196-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA1MDIzNyBTYWx0ZWRfX+WTXrjTQyazt jFeBOz80xx6aWkBv+2YzyqAIfRaOrjQ0oO/OuVGeaa4jnJr6PEfMT80f9Sdt2IFumop43m9A8vY 7FLhPv9aktWQy4l8k2q8EfoC3yoE+w8= X-Proofpoint-ORIG-GUID: 8o121k7pKOkk3KCZpzDJSoo-aQAv8wuO X-Authority-Analysis: v=2.4 cv=J+yaKgnS c=1 sm=1 tr=0 ts=6a4ad390 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=j4hjfWolugK9Oy_fDxEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA1MDIzNyBTYWx0ZWRfX7DAyAl8TAltp OguC3VJZCa0j5mUOmReMDxthI4hciWrvxDR+1bMxIhWJ0qRZSTBwUnXHbhFLJXm9F2p48XDmHsa PmLICZLOZo+uwcFrNCbQw7PMGBSLhcbiHXqG+DNsWj/Jb7GGfUFC96zycEpNF270/7F39Oqvytk zkQSQ2fD73G7PuvHIowkcPUJVMH9QcHncmx5voUWMZ/MGIajA3yOggLY1GGptPMCI3UqCltWeyb m6sbpISdT+t5e5d2c5MCprdFLSXZ8e1uh43jU9eLRoM3Xl08z74I2J1F5MqF9QEzsu91B/8EpX4 j4Kvkehl9sQxsEjUKLXVlr29HVYJMwjd/tVfkO3Rx2pxTfgmiVdldTu4BFQcxCQtOatjO63yXKY k20woSCejw3FPVQftTvEq+89a4Q6x6wi9/yXmQC+31FVeynO62DwR2pkNmsEdv6SBHLNTEq2Cpn TS9/aLyowip8RatuLLg== X-Proofpoint-GUID: 8o121k7pKOkk3KCZpzDJSoo-aQAv8wuO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_01,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 spamscore=0 priorityscore=1501 phishscore=0 impostorscore=0 adultscore=0 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607050237 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783288754278158500 Whether TARGET_KVM_HAVE_GUEST_DEBUG is defined or not, kvm_supports_guest_debug() still exists and can be called. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- accel/kvm/kvm-accel-ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/kvm/kvm-accel-ops.c b/accel/kvm/kvm-accel-ops.c index 6d9140e549f..d7967bc922f 100644 --- a/accel/kvm/kvm-accel-ops.c +++ b/accel/kvm/kvm-accel-ops.c @@ -105,9 +105,9 @@ static void kvm_accel_ops_class_init(ObjectClass *oc, c= onst void *data) ops->synchronize_pre_loadvm =3D kvm_cpu_synchronize_pre_loadvm; ops->handle_interrupt =3D generic_handle_interrupt; =20 + ops->supports_guest_debug =3D kvm_supports_guest_debug; #ifdef TARGET_KVM_HAVE_GUEST_DEBUG ops->update_guest_debug =3D kvm_update_guest_debug_ops; - ops->supports_guest_debug =3D kvm_supports_guest_debug; ops->insert_breakpoint =3D kvm_insert_breakpoint; ops->remove_breakpoint =3D kvm_remove_breakpoint; ops->remove_all_breakpoints =3D kvm_remove_all_breakpoints; --=20 2.53.0 From nobody Sun Jul 26 11:01:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783288773; cv=none; d=zohomail.com; s=zohoarc; b=nfo5HNulgLq9s40yaaQBjpuzuXEOMTVLjFXDol+kFaGlTywU4dtl+1i4fiYgweGz4m0Tufo1u6AoXN7YIikVJKcXHyFUN0jAR2V/N00Hjj2u+eEmPJJ+j/XJg0mg+I92AN5bg7J4U3eM8z/CS+35/88udjnyk82XKyuxJeZcyq4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783288773; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=sCNdzsLH3Q0jMX4rCMKs72ytygkMCsUMvV9SlnS9aVI=; b=E+Dxy4NEP+0O5wpMANXDbsbda3WIg2Rj1TRUIk3EGP2/22Ikia775D19AcjYQR8gDZJEh3l7EjeC/O/PPBpbw95U27o2u2RK/RMxLNNLxv6JlUOa8uOfvFrKlfAXtAcZaLNMYXUWD+UeA6eBiVZOeS/Z9cUK+8grwKga2E3IlCE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783288773472642.2243224024486; Sun, 5 Jul 2026 14:59:33 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgUrV-0006Hb-FG; Sun, 05 Jul 2026 17:58:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUrT-0006BM-RS for qemu-devel@nongnu.org; Sun, 05 Jul 2026 17:58:51 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUrS-000098-2v for qemu-devel@nongnu.org; Sun, 05 Jul 2026 17:58:51 -0400 Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 665HigXs2326959 for ; Sun, 5 Jul 2026 21:58:48 GMT Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6qvgutrb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 05 Jul 2026 21:58:48 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-92ea24a2db9so123787185a.0 for ; Sun, 05 Jul 2026 14:58:48 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c63b6f28sm313048175e9.9.2026.07.05.14.58.45 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 05 Jul 2026 14:58:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sCNdzsLH3Q0jMX4rCMKs72ytygkMCsUMvV9SlnS9aVI=; b=jeOb0nJJnNPAl1/0 eCpBRvw9KHm7r1ZXBaIs9pm2XPmYG3oXmd7PRJvZzVSqp8LA46BlfP9N+TKQ4IlX HTgNL/qSV88ig3Wn3EFFcm7tMiJtE0Cd0VWOsfJeGLOtPlvNRo8NFjc6+z6Z1jmI 8D6oMr68tfVShOXNnB50ukc0g0RAdx2dBn9m9j3XBUulSssjH50Lwre1LlpPRPGG 0y52KqIiNsOunCpRK65C3oL6+YnAJJ+qYKEtz6sw7nZYTItBIl+bXQwRWM4ulvkQ Jf+/HxwIEgB4qlQLKiTsZJlmrnaQ8+7j2aZekPYyidCMUmQ8xhDUaq3tGfRSNyb/ TFuOlw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783288728; x=1783893528; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sCNdzsLH3Q0jMX4rCMKs72ytygkMCsUMvV9SlnS9aVI=; b=ALw0wuk7M37nzCAS4cVh7dIczs9guhqU9Tc3SIs9HHQged9DTLkFjbqLE8vwvTHboG 9SQLWidFGkh3v5Kjy2JX6SbhjJYtyI89FWvopzy25n7Pi27mojU2xgrM3tBPxomrZi+c xbcdDHgWS5KnR107u9cmQHVpE20XUA4Zl6MEntLGLQH25JGbIv5hTWotsdrbv51w/a5s 9vCMFgVoviX7z35rJ4OyUrMJmwL8bqqhrLviXYEnATeqfy3tm3j8st+xOG9cXRy+IRFR PqtdrIXtq4F7G3QRx2mWAPP9LSp8wn/YdLGaCZTOBAAo772AceDfisLzd+p+65yCLnQr AlIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783288728; x=1783893528; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=sCNdzsLH3Q0jMX4rCMKs72ytygkMCsUMvV9SlnS9aVI=; b=OJWzFKYbku3SKRIkXD2/r3VPmeZkrCFQDcb5k6+n2+LmM3ce8pk/Z1rsAvzbUmkwpJ tx6h2WsdrgAarRL+TizoN1ph5G9Kn7t1F+d7uueC6EO+VNauwePKIumRLuFt2lfTOsBW R3xNwaC59Q0X97KbFpZovTzF3WQ6zsxVFh9cvCPRJdsw4/70QNEYUc9MrQT7AXQGu9ms +dAcyMRtrnqVPYJLiCQxT2jC7I3RpMbvyYCJpg3vTJp9Tvgoa6IigWszVaJjXwAGY5Xh UVgnfm5rbZ/r09pLWHwR6nsHXevqaviZyMotrji3ZtmeS4dXseHE802JzFKckX5fLXzF f3Cg== X-Gm-Message-State: AOJu0YwMeKC7QE2nYIly6NMLK0zYfESV1OEQBP8FqNNDCUgTyYnvTf7v oIZE7+ftJntYpv46/pC5q4ieUt53yBBs/yVvjUBp8Rr2eiUVs6OHaFEas8spv0WRLsgenCQQoJ6 +0wofJ5/mmP+w5xPGRK7Z+EK2BgPL7kKrmiw4+8UB6PP/T52IXKpwJyOwLX2nNpZX9g== X-Gm-Gg: AfdE7cnyxlRI4S1BgsGzw4TME8YYb2R9QxLodw3Eop7VLHO7C/3gbHyo2xC5ckMbZKH J+u4UXbmdv+jWP+1tzJ3yymSugth3ZqhcBEpP3y6PxWcZl11PLmqG/dkeTq+kjLwcDy3sq6SgSV yjHju8r/YtYW0EKcwxLIrARrPK3MozPeD0AQaTrwa8QFBnzK8qpgjazQpT35M6nI5zG8PvEar8I lrpuXVtYQCgOF8Z0T4ay8cbrTeiZRtUvt0NZK3XdZAJHF8yXCde85xqMZoEI0hxxljqaQS3OejE bfLIYLIHbikIyM+lXXxorNpvqjr845DJqzTAkZJNatCJ/+ISm1u8VIGws5vIUk8CMLyidHN9pke unKsvmnNBKbCJhq1BZr2XItPtqrI0bYu9xtNQYzwmjRLAsFkOrLCq7w== X-Received: by 2002:a05:620a:700d:b0:92e:64af:3e59 with SMTP id af79cd13be357-92e9a512f0fmr1202597685a.67.1783288727635; Sun, 05 Jul 2026 14:58:47 -0700 (PDT) X-Received: by 2002:a05:620a:700d:b0:92e:64af:3e59 with SMTP id af79cd13be357-92e9a512f0fmr1202595285a.67.1783288727164; Sun, 05 Jul 2026 14:58:47 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , alex.bennee@linaro.org, qemu-s390x@nongnu.org, Magnus Kulke , Zhao Liu , qemu-ppc@nongnu.org, Paolo Bonzini , Xiaoyao Li , Richard Henderson , Mohamed Mediouni , Peter Maydell Subject: [PATCH v3 10/32] accel/kvm: Simplify kvm_init() w.r.t. TARGET_KVM_HAVE_GUEST_DEBUG Date: Sun, 5 Jul 2026 23:57:06 +0200 Message-ID: <20260705215729.62196-11-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260705215729.62196-1-philmd@oss.qualcomm.com> References: <20260705215729.62196-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=VvoTxe2n c=1 sm=1 tr=0 ts=6a4ad398 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=snbnvTbt-5-dSQZ-83gA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: 6V-ij_voEnMy1CCV-fGlT6ENNSCO57D4 X-Proofpoint-GUID: 6V-ij_voEnMy1CCV-fGlT6ENNSCO57D4 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA1MDIzNyBTYWx0ZWRfX7CO8U9QCz97j l/zernPGa+WqSLdqDH2SVJHZk7gWVx5TucpdcjBSSYfvzRJVCeZi38UCohQ0kzmjbp4JQ07GRr8 S5cDEXxPSJGtdWgbtFfjx6aoWHBclQE= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA1MDIzNyBTYWx0ZWRfX0MNYtLzLPfoi 6DcGcg6kuG11pue0E1gTbtm2IivbSNFiYMYII8V601f/9iW3TZ9spDH/jzDqEtCrzbOa5eufBr0 SeyUg7K7YVJziLo+KwxVBvbHObbLqozdv4bu05g3dYa9KW14bFk8f//Ng7RUCVtirQkd6/pCP9i 6hXscrUacPYp2w9kEATfH0RqRysEcipHZK1eS6YeXLqe67IY3ZPEl7DqJZbPAK7rgIAiy6cCKRF bv+XcMJPe8I9xUkiOKrV6c2j4MKu18z+S7N5uR31AOAUqaaI9b1TF1ygw6JDrJQBjeatxemK+0w e+dPU7DKz5uMxSPxZtZRLQCZUUTEFMq/SJOzRpGsukgfgpusHLTOWHct4cRlvDft4nutP1yQteP yqPk0yqWeZTBAiR28WGw9uTQCpw76SUzIxEL0vTnd/7zbaJn7hlIa3UUo0gVLmTRYwVa7Qf/kMg CjZiQMiC45+3T9QFYdA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_01,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 suspectscore=0 impostorscore=0 clxscore=1015 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607050237 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783288776373158500 Simplify #ifdef'ry using TARGET_KVM_HAVE_GUEST_DEBUG in kvm_init(). No need to zero-initialize kvm_sstep_flags again. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- accel/kvm/kvm-all.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 5d55cb45cf7..304467704ee 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -3040,21 +3040,18 @@ static int kvm_init(AccelState *as, MachineState *m= s) #ifdef TARGET_KVM_HAVE_GUEST_DEBUG kvm_has_guest_debug =3D (kvm_check_extension(s, KVM_CAP_SET_GUEST_DEBUG) > 0); -#endif =20 - kvm_sstep_flags =3D 0; if (kvm_has_guest_debug) { kvm_sstep_flags =3D SSTEP_ENABLE; =20 -#if defined TARGET_KVM_HAVE_GUEST_DEBUG int guest_debug_flags =3D kvm_check_extension(s, KVM_CAP_SET_GUEST_DEBUG2); =20 if (guest_debug_flags & KVM_GUESTDBG_BLOCKIRQ) { kvm_sstep_flags |=3D SSTEP_NOIRQ; } -#endif } +#endif =20 kvm_state =3D s; =20 --=20 2.53.0 From nobody Sun Jul 26 11:01:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783288767; cv=none; d=zohomail.com; s=zohoarc; b=fi2PrUc021v0ntsBV1aDeU896HOcvaynSHcsv8AcJwWOrqSXhvjH2cmlaSKNTDpqOXJnsNMcgbQuNyvAU3v+orxsjjL7h7WR6/12VeTItFAwEuhXjbhm+EmRfQ0Yq0Ba9WS3OPSwiGYLXGy+gwjYKhssuTXY8f2GlIYEMVThe48= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783288767; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=6WT95Gph8Xg6aTkiLQdrIw1hlxRErYZ/kEcLb8sMdPQ=; b=JhFjhj0cE1FBOIVzXDJyMR+tgnHkZsw1Cj8gO6NjI4LpIchQLEfV9PLdz4welwgrqlqeHWx1ZpX3E4a1zIKBbGUrrEcX8FWk6QKw4s1EQLXkelovp1VqCBYmcmIdaq+e9DNeG9l/uGtUFgFBnZuh1HzBDINJfLiS+FzUJyv+QxE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783288767826779.6217971811765; Sun, 5 Jul 2026 14:59:27 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgUrn-0007KK-SD; Sun, 05 Jul 2026 17:59:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUrm-0007DB-1x for qemu-devel@nongnu.org; Sun, 05 Jul 2026 17:59:10 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUrj-0000CC-DC for qemu-devel@nongnu.org; Sun, 05 Jul 2026 17:59:09 -0400 Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 665HhfbS2167952 for ; Sun, 5 Jul 2026 21:58:56 GMT Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6tj8kffp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 05 Jul 2026 21:58:56 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92e66f9e2baso228889785a.0 for ; Sun, 05 Jul 2026 14:58:56 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa039ae4fsm19721756f8f.18.2026.07.05.14.58.53 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 05 Jul 2026 14:58:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6WT95Gph8Xg6aTkiLQdrIw1hlxRErYZ/kEcLb8sMdPQ=; b=Gnu4mutSMOcKz6CD HdX6ItsLfG8VZvF/48Yd8B5SKIOlurGkb/vq8sFc+tVYiL+c/aGYTfu+G2fYiTy2 fLiKMSJfUms5br/GzmYnBllcew2GBYAuy1cuBYh+bjd6rnVFiPoom+3Ma45A5rD7 1QTn9wBpkSb46mhDFgx03mKmSdSvoXgzSEIA29SjnbPdNyxdcjIv8YxYLobu1QJC 2S/xvQYrwPkVUk1ma027e+/VsLGB1lEnh+lUSZW/++hm3xqzHMAMnU4OsUmnxmls Abyh4I70yjPXLiH2U8DOV79Nq/dxK8PLrtg01j7NHO52DmjTw/B/qmx2GA0jdPJA Wqc1VA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783288736; x=1783893536; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=6WT95Gph8Xg6aTkiLQdrIw1hlxRErYZ/kEcLb8sMdPQ=; b=iMkb8eMD41i8877iq3MO5MnBgv5wll7OdRrpgWPFAwzJTS4hX6QLedKg20w2k/Y/LN CL/MPIb1P1V8/LBUF7wM4lPC/qzoUxhCcmZrilMzsrk3JzXrfYa/onkU58JObqA7jUsJ o6PUZXEZMGaQVduqf2V0L+oDakwd99L5aIPIVspLNuKV1g2LXdkFHH4O+KG86au93pXL 77TvsYXvXrevJznWq66YXgKhbo+UHiXo791JsDYvPUxxn9PVMlYUS0zLJa+yHmHzUYUa XmDbJ3QVXSKo1wwime1Sob8MhhEtvOivC2fXj7rLcc3vecqf58PzfNOvbBXEOKppAFj4 oibg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783288736; x=1783893536; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6WT95Gph8Xg6aTkiLQdrIw1hlxRErYZ/kEcLb8sMdPQ=; b=Pqy88o7ViCiPA8nGbTfWnRIOGI0yUYxcefL09hztRRgR3XU0gBamUy1AHHwZk09NWf p5PjZ4QlB8ge2TpY2KhMstopyqCN0HrhmXp1Ji6UWPigr9UxFCD0T8ZKin5F5FeyAJsO /yc5eGEKAP3OAQa5qf6gHrSK8HaGE/lE1Y3aeyYBBKVq56LmDnI40PjTX21y3Rby4Agw ebTLPOVUuNeAdnRH3bNJ5zdZFA4Xxa2nktF3hCGfqx1BqwTQEaoVJL4Pp6WNoGiyuRS/ wm1HjAyUM/mnggsdt8nFldmq7VBt/PbSUcKCMPjubXIEOaLDo20FVCY79IemCxqjl7kJ KkAw== X-Gm-Message-State: AOJu0Yz4Mf5tHf0VTlTetL86ovCNFK/1Y56DnPrqu991J3FahjNuYorw IddDcTKKUqN8jPITR77IT1Astiz3DPUQYHErGXCV+JfK0Y8i7DwzcNlPr/jzmK38fbIKl0RTst8 fvCcJoSwe2sI9CslvFK65D8R5LPvE9zEK0bIW2wdZeObiEebiTzkK1Qm38lO45/dTyg== X-Gm-Gg: AfdE7cltGoyuQEhn0UBCEOeyhxStzm9GGK43Wn4GVrov/ATpqUf9nkN2BNHykX6eJC8 oUJKIz2kGZcATHbQaTIVuNNg8tX/Y4LaUeQABUCZ8xcfqnX3VpxNM42tzdGuCKnGig1ssjv511o Qy9Pm+EtmiDQUHU+t9T+1TfwmUpG7oppQJgro5aBFb+tcnZdwJmHeywvxcfHJU+ragzZsRG6QfV tCZcmwuRGUfqIzA49Fc1IqU20u7YR+PuAvwSHWohZarA4+hitEYAqmC64RU23ms05nqY9tgxJPp Q7tRSgACzvonEnvo3R5TL7IZQSUPD/IWkqce7cPk9E5O0TYukW0A4h1/9BHph8LN8EseFkWhtSq w4JcTxo4NoyHLofeTyEWJdv/sysVyaIOGb3xwgKBPBEq636m7ofWmNIATP0CUqhF9YuS0 X-Received: by 2002:a05:620a:6086:b0:929:b3a4:9bf4 with SMTP id af79cd13be357-92e9a3af13emr1129342485a.21.1783288735658; Sun, 05 Jul 2026 14:58:55 -0700 (PDT) X-Received: by 2002:a05:620a:6086:b0:929:b3a4:9bf4 with SMTP id af79cd13be357-92e9a3af13emr1129340585a.21.1783288735215; Sun, 05 Jul 2026 14:58:55 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , alex.bennee@linaro.org, qemu-s390x@nongnu.org, Magnus Kulke , Zhao Liu , qemu-ppc@nongnu.org, Paolo Bonzini , Xiaoyao Li , Richard Henderson , Mohamed Mediouni , Peter Maydell Subject: [PATCH v3 11/32] accel/kvm: Hold have_guest_debug in KVMState Date: Sun, 5 Jul 2026 23:57:07 +0200 Message-ID: <20260705215729.62196-12-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260705215729.62196-1-philmd@oss.qualcomm.com> References: <20260705215729.62196-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA1MDIzNyBTYWx0ZWRfX0m9R2gP7KQPt uBqqEZs6SJYwaq4jyiZ9l1fGJ5oY0fqFCboUOrwMSjoEcC5uHLOeVLbgs9rL7J2SoXoQirriOPU HLx+qxncGpJti7NJh3nBL87p7heaLlYNw6ivgbtl20sc+mCT1EgiSSIVPXXRmBzRpYWrFNWbxQS 5dBW/YfwvLIxosQ57Qt0dvy71s9eN8thAhXdUnqwcoqF8AgOnePitt/OS+pEs2dOIHYIYYuYl7B 0aDacvi/xTy5KhPWycMjTgN43ZTLT9JBXv9kkIQf2fBHCspXKZABNsF88ncmeXUnmHsU8BnO/t5 rOx8nGaXgx377S88kFtNUJ4mSuDRu54RGBbnLRScG9yWMAqc0FSwErr7Z9FXOVzYq9CKv2x4aV9 gwWaFx59R8s1brgSQzDAFLXyUUiWsM5nxRczWLYnqyDQxPaiubv9uE9ubKT8LoDPvxY+QeSGU3h wOHquRw7w0eOiTJqgGA== X-Proofpoint-ORIG-GUID: zG_dMH2E6oLi881tzsSgNvht_OFHpB6B X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA1MDIzNyBTYWx0ZWRfXzJSzlmpyDokT ApmaL2VL5trUOzAvg698GkM1+rfaMk5jzn+O9+89APmiZph8ee39OBdLKTb6V7iWE/yvm578A9a r82OB40JMS9LtF45Apbxd737ZXf8Q/c= X-Proofpoint-GUID: zG_dMH2E6oLi881tzsSgNvht_OFHpB6B X-Authority-Analysis: v=2.4 cv=H6TrBeYi c=1 sm=1 tr=0 ts=6a4ad3a0 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=O5kNlQXW-qQlE3Y8R88A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_01,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 suspectscore=0 bulkscore=0 impostorscore=0 adultscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607050237 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783288768246158500 Prefer to store per-accelerator variables in the per-accelerator state, rather than as static variables. This is a good practice to allow concurrent accelerators in the future. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- include/system/kvm_int.h | 1 + accel/kvm/kvm-all.c | 9 +++++---- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/include/system/kvm_int.h b/include/system/kvm_int.h index 0876aac938d..53bb0fcf180 100644 --- a/include/system/kvm_int.h +++ b/include/system/kvm_int.h @@ -118,6 +118,7 @@ struct KVMState #endif int max_nested_state_len; int kvm_shadow_mem; + bool have_guest_debug; bool kernel_irqchip_allowed; bool kernel_irqchip_required; OnOffAuto kernel_irqchip_split; diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 304467704ee..b6125125f82 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -104,7 +104,6 @@ bool kvm_readonly_mem_allowed; bool kvm_vm_attributes_allowed; bool kvm_msi_use_devid; bool kvm_pre_fault_memory_supported; -static bool kvm_has_guest_debug; static int kvm_sstep_flags; static bool kvm_immediate_exit; static uint64_t kvm_supported_memory_attributes; @@ -3038,10 +3037,10 @@ static int kvm_init(AccelState *as, MachineState *m= s) (kvm_check_extension(s, KVM_CAP_VM_ATTRIBUTES) > 0); =20 #ifdef TARGET_KVM_HAVE_GUEST_DEBUG - kvm_has_guest_debug =3D + s->have_guest_debug =3D (kvm_check_extension(s, KVM_CAP_SET_GUEST_DEBUG) > 0); =20 - if (kvm_has_guest_debug) { + if (s->have_guest_debug) { kvm_sstep_flags =3D SSTEP_ENABLE; =20 int guest_debug_flags =3D @@ -3833,8 +3832,10 @@ int kvm_update_guest_debug(CPUState *cpu, unsigned l= ong reinject_trap) =20 bool kvm_supports_guest_debug(void) { + KVMState *s =3D KVM_STATE(as); + /* probed during kvm_init() */ - return kvm_has_guest_debug; + return s->have_guest_debug; } =20 int kvm_insert_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len) --=20 2.53.0 From nobody Sun Jul 26 11:01:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783288810; cv=none; d=zohomail.com; s=zohoarc; b=mUM0ZBXrAdGlD6f/lgZ3VOsnfhQq1VOKZko7NU2pTeIMxjNrjrQvTwpYa4KiPBVCQlGVwf2++io3I82wVCxnbT5jVmQplbbTZ/m5LGLykauoanZx+3g9Ru9qkDh0vjQvyl85t+31duW06gtmXdu8YJadc6Egwr34+hXIis7+gJo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783288810; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=7po3aHpbm6lp9kLWdYsA4Vft5rv/zKl30ZI6OZDSLmk=; b=UtibvqHmlw+rzbEZmLqQxCuji1WFYBr294ObrgFaQHxzL0vIuY0J+D/vJ6xGZN/W8Vi+2FvozE4JCkbwYzPHLdo2bAH+3cnh1zbG/dMM8Vlf2C7FQTTa1roRPI7P8fNp43Ulu4JylOvEzzt4qW2U2rCiiGa3vgpi5SJyFKQhq8s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783288810440804.7694620802749; Sun, 5 Jul 2026 15:00:10 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgUrm-0007DR-6n; Sun, 05 Jul 2026 17:59:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUrk-0007Bw-RL for qemu-devel@nongnu.org; Sun, 05 Jul 2026 17:59:08 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUri-0000Dy-DE for qemu-devel@nongnu.org; Sun, 05 Jul 2026 17:59:08 -0400 Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 665Hhe272342195 for ; Sun, 5 Jul 2026 21:59:05 GMT Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6td3bgkp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 05 Jul 2026 21:59:04 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-92e538afe65so228419285a.3 for ; Sun, 05 Jul 2026 14:59:04 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa0a558easm19130659f8f.27.2026.07.05.14.59.01 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 05 Jul 2026 14:59:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7po3aHpbm6lp9kLWdYsA4Vft5rv/zKl30ZI6OZDSLmk=; b=gW6DNfywMno9gUwh UT8gPkggwBz6QnihPkLTH4NoxV1tW/JlYEltyqEN8OChrqK3rQFSBmaUbrI43s8K MYrnim17Mk1idilV3oRKDxMsu2wH/hwHFcprNw3iInE+P868zLCUHFWOZn9kRj3t 69IU8uwYjf0sYRsTjei2bqUYMRVC8SjpWOaVuSGkkNTtpvQDxTR3MSjpNNO+iiUt TqQNT20MkpC1zUHZr4830UOiA4GNp9X3/ktxSGO8wiYXNYOhu/0i0EHQw198Na/Y cg0epYJasYggD5XJ/YYcqAq9zBfy5feRjoo0MzkOo4Qg17vYrKUfmB8VphG7R2t4 8Nrp3A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783288744; x=1783893544; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7po3aHpbm6lp9kLWdYsA4Vft5rv/zKl30ZI6OZDSLmk=; b=E60mWKfWKEMMrayy0Fut6Ui5CjQUPE4k/6t4F+0l6dzv+UFgWfzJv0cB6PZ+kbBIeK u+3MmMmWs368vO5LozO1drNxAS8reOeMcwJVuF4yCmP4rDY0FGKzaqrdHG587mua2vdS TUBaJAU+hTYCi0npfiv4sq7ayJFWPrUdTUTA2HZQ6QjMYB05a1WmnUQArt4Om4KwcXmF 7KnkSXDadoVq7Oq6t3NxrWIm0lj0NkPWruDy1AbXKz6OfVz4ikGMW7CU8WNrMzfWkXWz xB9I+AW4untNIxe5fzkdkenv+1sRM9Zk2bB4kW77hQm3PHOR5FauxXETfKamQc52LxUV X/7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783288744; x=1783893544; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7po3aHpbm6lp9kLWdYsA4Vft5rv/zKl30ZI6OZDSLmk=; b=mFsmHfqH7p8j9mwLhmzotJeU/nMzSubh+sdxbe4C1qVdLwxJc7upMLgSWhfzD910ZT rqVo6P/4CdoK4QLpyCidmN8E1APhS1JOndhCoZJz5V0pssM6QKYXFieiSt2gQ98czGTq htmZqd7AZSB/uiMnpxKpjLX8NluJ+g0+BMB0b8uCBTs3Q4x7HqyNkZqS+CO3KPJRdBvR VEhO/gNFkbAIHfoCWPgj/1HlixuXlWK651rYiBc+Didf/+eTfk38klTlKrDSp1qFUfYi eYnVTgGGHOm02mAFupPCz2APcoEQzK6/uwMZHBx9qjoY31u7qvBOoqhV5iLYBO8cPyvo sH6Q== X-Gm-Message-State: AOJu0YydTiJNK2tZ+PQw4vMSagEkKYfgNsmoStGJYT8dPhZl3qeMv25i HqfN8BNBo5WsBauQH65yQdH3lnEF5VPtVVW9wTqwqOElViMgIBuOH1siHcOw/3ZU6WsaOr1BDbN qUZ1+Dm5tPfQI9IAu2DNuyATyZTzLJOmwesAV0+N2PRmS5dFPlQqxv+HVy8YSMmGw8Q== X-Gm-Gg: AfdE7clVhYB/hqq8xJQcivHUbqoyQy7qqkWtmHraYxG8OXBU7Dc08qH/j7t35j8v/pr 5S2JbyygWMzHjrmcIniJltKzTfAIYOMlOIqtxrYbqy+E3JtCb0kkGgbD80qliArbaP7e8j2E+HE 5/g8Kb7qxfUd9+iLYjc/UpbPocPyusn2Rl3g0wRJSpJf6qpNyNwmwycRBwgnnt5MC9IWqJqIMKC IZnQBjYxVUFFLiyhG9L5cpA7e3+TtsTBDz0EhW3RBoNWCMSA/1oAiY61B7u+ceD9YWTh6HLbjIZ JCtwl8iIAegaojm7Z2HCYEv8QwVvBfYMYFneVL/OvSCxdSpUQKjblTJtHRtFEi93wjQaMMW74/1 5e6wXjK8O1cIuGakXmx4S4j9sQBCWhbj98tPcGiUMrhOr71tcmFM355GJXNtVXgThc2dq X-Received: by 2002:a05:620a:1a27:b0:92e:73fc:154c with SMTP id af79cd13be357-92e9a3446e4mr1258430385a.7.1783288743728; Sun, 05 Jul 2026 14:59:03 -0700 (PDT) X-Received: by 2002:a05:620a:1a27:b0:92e:73fc:154c with SMTP id af79cd13be357-92e9a3446e4mr1258428285a.7.1783288743305; Sun, 05 Jul 2026 14:59:03 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , alex.bennee@linaro.org, qemu-s390x@nongnu.org, Magnus Kulke , Zhao Liu , qemu-ppc@nongnu.org, Paolo Bonzini , Xiaoyao Li , Richard Henderson , Mohamed Mediouni , Peter Maydell Subject: [PATCH v3 12/32] gdbstub: Reduce gdb_supports_guest_debug() scope Date: Sun, 5 Jul 2026 23:57:08 +0200 Message-ID: <20260705215729.62196-13-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260705215729.62196-1-philmd@oss.qualcomm.com> References: <20260705215729.62196-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfX9mGtTEbLC1cw e3y19Ma/W2GJBp9cxhcCGSzPiP9k4E7CB8kG8Ny8ctKow1jTmzSLHMgrC+Ar1aP4lJ9aiiA9ftP PkLdWuO3VhihseE1WoYYTUQQvDwPTrw= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfX7aLY12FzyKXV V0BHbEv2iqc8MxhKrQINOWFWpQflDdtWE2KIEW2jjbh1+BrGBFSnNU5RCVY38Yq87MUNGd5g3vT vOE8gl3FzeBK6VuUVw3B+hBWyU4qhFOYdLGOYXzBgqiMxx2ca5SSzmckP5VhAjoswfXFZorn6LH CKmjlrAoDpOX2rRx0zq5dNBnig8iuJnNfxhxGGa/PnIh+GcL0uuJ4+0eZQrNa4Z7F0sSekpKbmV DcHvbDKVmMP+LwKu61v678OKuPSae3yH98qChlxZCDb+9SMEQ9YYl0ZI3+ZuwzIOx7SRROQijEk JgNiEkPf8Z8nFqE+DcbNmwZiCM1FCj0z/lrhjmhOt7k7nTF/KMXyGhTB9MTtPqTRK1T+pEDwv4O K1/rvGSGFxySl3ME1r+7ofeQGaT42EfGCGSHD6FU4Fy/Lg8jwUiub6TDRaYYBL1T5pGCY70gY/L /vfUNBto/C0sUEUbzWw== X-Proofpoint-GUID: 3nWJI4Vf-h37MTFPUFfdytLEbhXKl9Ge X-Proofpoint-ORIG-GUID: 3nWJI4Vf-h37MTFPUFfdytLEbhXKl9Ge X-Authority-Analysis: v=2.4 cv=b9GCJNGx c=1 sm=1 tr=0 ts=6a4ad3a8 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=EGoLRYcDdwmvoyRlCl8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_01,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 malwarescore=0 adultscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607050238 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783288812587158500 gdb_supports_guest_debug() is only required for system emulation, reduce its scope by making it private; remove the user emulation variant. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- gdbstub/internals.h | 1 - gdbstub/system.c | 4 +++- gdbstub/user.c | 6 ------ 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/gdbstub/internals.h b/gdbstub/internals.h index 9b25bf58b8e..60ddc146661 100644 --- a/gdbstub/internals.h +++ b/gdbstub/internals.h @@ -217,7 +217,6 @@ void gdb_syscall_handling(const char *syscall_packet); * Break/Watch point support - there is an implementation for system * and user mode. */ -bool gdb_supports_guest_debug(void); int gdb_breakpoint_insert(CPUState *cs, int type, vaddr addr, vaddr len); int gdb_breakpoint_remove(CPUState *cs, int type, vaddr addr, vaddr len); void gdb_breakpoint_remove_all(CPUState *cs); diff --git a/gdbstub/system.c b/gdbstub/system.c index 2063b63b2f8..1179c82cb86 100644 --- a/gdbstub/system.c +++ b/gdbstub/system.c @@ -331,6 +331,8 @@ static void create_processes(GDBState *s) gdb_create_default_process(s); } =20 +static bool gdb_supports_guest_debug(void); + bool gdbserver_start(const char *device, Error **errp) { Chardev *chr =3D NULL; @@ -627,7 +629,7 @@ int gdb_signal_to_target(int sig) * Break/Watch point helpers */ =20 -bool gdb_supports_guest_debug(void) +static bool gdb_supports_guest_debug(void) { const AccelOpsClass *ops =3D cpus_get_accel(); if (ops->supports_guest_debug) { diff --git a/gdbstub/user.c b/gdbstub/user.c index 97eb13e796a..f7bc4e63dfd 100644 --- a/gdbstub/user.c +++ b/gdbstub/user.c @@ -796,12 +796,6 @@ bool gdb_can_reverse(void) * Break/Watch point helpers */ =20 -bool gdb_supports_guest_debug(void) -{ - /* user-mode =3D=3D TCG =3D=3D supported */ - return true; -} - int gdb_breakpoint_insert(CPUState *cs, int type, vaddr addr, vaddr len) { CPUState *cpu; --=20 2.53.0 From nobody Sun Jul 26 11:01:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783288799; cv=none; d=zohomail.com; s=zohoarc; b=D7dm0Yh7kjlhcKGVEeWH405AgQpLDTWeYgTizKDxOg2XxgedQXyNnkUXelpQOVrPFdUW/JhLPbqaE09VnRF5jNBpB4KBqAdyxKNr00XVFgAPtatEYU2oX9qknP0ssolJJ+uUb4t0UrhtdjRw90QIWfJ/6w+YWNNJUKaurdK9JTM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783288799; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=e9dI60VL+YjzzhVjIatuzq+x8DZHXeIawZtKVfZQSRU=; b=RVUHrjq6YLJFeEfO7IkM9pu+gEBEec4SU82OkTgysSVge99a95lzaTy+eW4J651Evkyy+/5pjiF/55UDgI3pC3Unk9bw//tys3lYNXvSu1gwSgZncCHCj3ynzmi9GH5Pv20fPks3tmOuBSDB1D1veywqh123Ug8NMrUJ9QhN5iQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783288799695439.64092862775806; Sun, 5 Jul 2026 14:59:59 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgUrv-0007ph-Bf; Sun, 05 Jul 2026 17:59:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUrt-0007mb-9y for qemu-devel@nongnu.org; Sun, 05 Jul 2026 17:59:17 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUrr-0000KG-KG for qemu-devel@nongnu.org; Sun, 05 Jul 2026 17:59:17 -0400 Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 665LxE4n2868067 for ; Sun, 5 Jul 2026 21:59:14 GMT Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6s4sum65-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 05 Jul 2026 21:59:13 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e538afe65so228423685a.3 for ; Sun, 05 Jul 2026 14:59:13 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa039afacsm17947977f8f.19.2026.07.05.14.59.09 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 05 Jul 2026 14:59:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= e9dI60VL+YjzzhVjIatuzq+x8DZHXeIawZtKVfZQSRU=; b=nfgvrMUT4coR8XiH oZDkTSqT9CNx95GuIRYLHM6TOc2gDpx0K23F/Pg4R9SCrgmrtIHdxbfbiKqt8EUu WBrP+t6lZR/pTqTPN1M5YQvPmf/qOi66F+JtYqU2w1XnoSoMwZCeljPB1EeH/hY1 kPMV8XO5E6Y7oejpLczalRrLY4uNf1K291QtyldLt7NdtEX09SYUtgfUCFSrXVGi jL1ChzHjkLTEKZq2kgq2HOX0pGKnbXTCNHOQtKamhp/FHDnVDmpkVFSccocP/YJH dpVSgLyfBuM5A8s0E7NfIDXYQSxpYiqR3qV2ZBDUhUVGFe3WB9Kxgh6uLAtxGq+q hWOsvg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783288752; x=1783893552; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=e9dI60VL+YjzzhVjIatuzq+x8DZHXeIawZtKVfZQSRU=; b=FGtqf46jjqYcKY6SNfRJufl1Xk12PkcXgp1D4zkGUnUnM7bosxekRxvqS2sI6sYQo4 SDOKuQZnAvh1T9HwJZFV8S91mgdciT9YLbaQeYcJ6eQSq8M3lpoxyDq7u31hSbjrx3j0 jN1eAw02G35BhQMOyU3PUBYtkh6uA6RC4cCuXgKs1zCwOi8LphZQir7rPcMErD7IOO36 5Vq1b7yLxuWrXfEcAQIg6N0WPAoLZ+Fc1wScVfslj+uelRAed+0TI12TCVMRAwAOUEI4 6dDLUN+QXoCd5M2zrokx4YAZqrS68rKPAwgexhqaouRyjVf4QXoqeyufH17qoBR/0P2Q GNkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783288752; x=1783893552; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=e9dI60VL+YjzzhVjIatuzq+x8DZHXeIawZtKVfZQSRU=; b=SWLuoNEyzAXkXXRKWTT9HCbQ2tjyTomf4MqE57fO1wzFvigu10gxcsxjk680tZfPfa yrcT9B1/mk7wNNZkkVFnuNVx0Rf6v5EUe80fibP7riQG1krc7WRo3PfWXd42n1jXJMYX 0HFbRzYTPWfDhQVEqFlVCZuIhk4tKLAR0Qf9QUfj8KcqXfEbFc4PWaIgvuu6w3sRRNde tfIlT8FPwb2SS43Iz+4LIzW7Xgin8Mfdf+IHRKCSVIBEwNIikLkLv8f6l2c3vtTsXgdU Sb+RRZMZC+bSVJwWgJAXkiS9qttDvg09dA8DRAGg/f7WfN6XijtU3ItBRika5LKvINPH NGYg== X-Gm-Message-State: AOJu0YwOhrrqIexA7E4jub6Qe3d1RBE2p3xXbbZKHif6tZRftgdQ5s79 hno3n51vBxoQqtr2W3gNYfVRjY/SdG+rWDmXfCpa7AOewCS6oCTEqprycU27VMFmj60Xqp3aEoO Z+NNRyGTWd3YRuqcDus2XjlTlqIcan+7TX3mjcfi7NOGVMn8jH/iLcpuIs38A7b1zDg== X-Gm-Gg: AfdE7cmHuBewKtnev4CO+CYQjQtkJg/JPgT8JtEPEKzuqa8RPHnZNL9R0xkvIQ6h4o7 v6csoh+q1D9GI/qaUDuNrABEgqDLqrM5bJkjIq91gFyCXpLU2CojFa18eFSrrUj1vQ+vUkJ73cL qxbB6zSrK8zOOCt7EpowA2y/+vYdedeeSPkuP6dupMTphBxH+TQ0NhJUtKQAW6u6mV4p4YQmhAp tTQiafmXZvsd9q6JcMl3gx6ASj/hF+XwESFLt13l4Cn5BWXWxBD29DAxT5QHPQcQ3SJv9IE959F urogS8X6yTr9Oqec6gV95iy6MVyPF+HlK63rrzEdP6AUNo+0DnSPePIqCNDYl4Ynwv/BKbwfq8E sjKOPfC3wM/P713ze4aEFEB5Uo2cwS/G4L/sPoQ01vnCWKy7VDh2DF2nm6iBKqcFo6XPX X-Received: by 2002:a05:620a:468d:b0:92e:8405:7ae8 with SMTP id af79cd13be357-92e9a343946mr1087960585a.4.1783288751181; Sun, 05 Jul 2026 14:59:11 -0700 (PDT) X-Received: by 2002:a05:620a:468d:b0:92e:8405:7ae8 with SMTP id af79cd13be357-92e9a343946mr1087957585a.4.1783288750736; Sun, 05 Jul 2026 14:59:10 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , alex.bennee@linaro.org, qemu-s390x@nongnu.org, Magnus Kulke , Zhao Liu , qemu-ppc@nongnu.org, Paolo Bonzini , Xiaoyao Li , Richard Henderson , Mohamed Mediouni , Peter Maydell Subject: [PATCH v3 13/32] gdbstub: Move supported_sstep_flags in AccelGdbConfig structure Date: Sun, 5 Jul 2026 23:57:09 +0200 Message-ID: <20260705215729.62196-14-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260705215729.62196-1-philmd@oss.qualcomm.com> References: <20260705215729.62196-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfX/mvoEoJMz3DL KgfSd5BHadgdowA2MIlZ/7ff6WhvqRt7VqhExayy+N+CO27uh6SZxWQ0xHZnCvO6z0caav48BMa iUMjv9vd+/r6SA1jI7m0z8cG/BcDq00= X-Proofpoint-ORIG-GUID: ceM6cqJ2oiacCtSi7UAKYq8LYQBZBVVo X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfXyr3Xq8kHjBLo n5169/d+kXQKBzl2Z9S4XCXe+0USVgAUApfJwHg0iXkuE6mPMOGWhZnOBRytV5JImnQRX3+xSDw Epgdvp0HFoz4/1gtEll/LrRMPwWQaemEnxaXBcdrPUgqkvcI0MQyE8fgHUNd3aUFMacc8K89mID y2Up5sTqRDzISOCAeBFUJ062fXJf5GqLd9Ax1iutyVjePm3fMyvxNzWTOsNMcm531XeJrWM1QAh BE0vJw15tU1fNMdXGxGQ6iKHVfHXywoSZN6587lRfP7LRf2CJOmLslUvnFqLyQJ7jLDE8KyX+d2 gqjoFRvTX7v/7aap0WLTTexSvpq8GspysYcUq1h57d/qiflmbGc0l5HGOmGhRVMWtQ6vRmTz/fM Qu5zepoRO7G6XaN3RpVCiNDXDl1cskyEan3b0szF9dyPEa3+4fR/1ikIIpFbA68dSJkpUld3CSh 6V8s5PgIqZSqdjw2aew== X-Proofpoint-GUID: ceM6cqJ2oiacCtSi7UAKYq8LYQBZBVVo X-Authority-Analysis: v=2.4 cv=ZfQt8MVA c=1 sm=1 tr=0 ts=6a4ad3b1 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=-SUpAgEnhvh4vktFIKIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_02,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 adultscore=0 phishscore=0 priorityscore=1501 clxscore=1015 suspectscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607050238 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783288800447158500 supported_sstep_flags are per-accelerators. Move them to a new AccelGdbConfig structure, still in GDBState. Suggested-by: Alex Benn=C3=A9e Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- gdbstub/internals.h | 3 ++- include/qemu/accel.h | 9 +++++++++ gdbstub/gdbstub.c | 10 +++++----- 3 files changed, 16 insertions(+), 6 deletions(-) diff --git a/gdbstub/internals.h b/gdbstub/internals.h index 60ddc146661..0444dee2246 100644 --- a/gdbstub/internals.h +++ b/gdbstub/internals.h @@ -9,6 +9,7 @@ #ifndef GDBSTUB_INTERNALS_H #define GDBSTUB_INTERNALS_H =20 +#include "qemu/accel.h" #include "exec/cpu-common.h" =20 /* @@ -83,8 +84,8 @@ typedef struct GDBState { int process_num; GString *str_buf; GByteArray *mem_buf; + AccelGdbConfig accel_config; int sstep_flags; - int supported_sstep_flags; /* * Whether we are allowed to send a stop reply packet at this moment. * Must be set off after sending the stop reply itself. diff --git a/include/qemu/accel.h b/include/qemu/accel.h index d3638c7bfda..052b4c59313 100644 --- a/include/qemu/accel.h +++ b/include/qemu/accel.h @@ -73,6 +73,15 @@ bool accel_cpu_common_realize(CPUState *cpu, Error **err= p); */ void accel_cpu_common_unrealize(CPUState *cpu); =20 +/** + * struct AccelGdbConfig - gdbstub configuration for an accelerator. + * + * @sstep_flags: Set SSTEP_* flags that accelerator supports for guest deb= ug. + */ +typedef struct AccelGdbConfig { + unsigned sstep_flags; +} AccelGdbConfig; + /** * accel_supported_gdbstub_sstep_flags: * diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index f54415a9db7..06b712562c5 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -72,9 +72,9 @@ void gdb_init_gdbserver_state(void) * By default try to use no IRQs and no timers while single * stepping so as to make single stepping like a typical ICE HW step. */ - gdbserver_state.supported_sstep_flags =3D accel_supported_gdbstub_sste= p_flags(); + gdbserver_state.accel_config.sstep_flags =3D accel_supported_gdbstub_s= step_flags(); gdbserver_state.sstep_flags =3D SSTEP_ENABLE | SSTEP_NOIRQ | SSTEP_NOT= IMER; - gdbserver_state.sstep_flags &=3D gdbserver_state.supported_sstep_flags; + gdbserver_state.sstep_flags &=3D gdbserver_state.accel_config.sstep_fl= ags; } =20 /* writes 2*len+1 bytes in buf */ @@ -1537,12 +1537,12 @@ static void handle_query_qemu_sstepbits(GArray *par= ams, void *user_ctx) { g_string_printf(gdbserver_state.str_buf, "ENABLE=3D%x", SSTEP_ENABLE); =20 - if (gdbserver_state.supported_sstep_flags & SSTEP_NOIRQ) { + if (gdbserver_state.accel_config.sstep_flags & SSTEP_NOIRQ) { g_string_append_printf(gdbserver_state.str_buf, ",NOIRQ=3D%x", SSTEP_NOIRQ); } =20 - if (gdbserver_state.supported_sstep_flags & SSTEP_NOTIMER) { + if (gdbserver_state.accel_config.sstep_flags & SSTEP_NOTIMER) { g_string_append_printf(gdbserver_state.str_buf, ",NOTIMER=3D%x", SSTEP_NOTIMER); } @@ -1560,7 +1560,7 @@ static void handle_set_qemu_sstep(GArray *params, voi= d *user_ctx) =20 new_sstep_flags =3D gdb_get_cmd_param(params, 0)->val_ul; =20 - if (new_sstep_flags & ~gdbserver_state.supported_sstep_flags) { + if (new_sstep_flags & ~gdbserver_state.accel_config.sstep_flags) { gdb_put_packet("E22"); return; } --=20 2.53.0 From nobody Sun Jul 26 11:01:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783288795; cv=none; d=zohomail.com; s=zohoarc; b=QtRv7zbNLlQhSOeurPfmUOX0PaR+NX271r/f280gi4LcsmZZviGe6VaeV3sbFcywsEcK32EE+TTGoTbxux+D40q4VJuexYjHWXsjD+EZbeA80a7wPPedfvks5uEniUrQt52eEwiL41J/ngr1NAvYDEO1pyg0GHl9OXqPJfs6FrI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783288795; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=bc1IU9CgmcY+0G7lSlsFtIectefxcgj07/d7AIAf3oM=; b=YyJ1qah8GGvDg+ibUIcm0pv2ltfaVHef4hXDH5wjhK0slCE4z/cn/o0eKRWIwoAtqzzeRBGb0IEJk8jY7IRBAHXPkhZxWIbZK5aCjh6gaRIcvbw0M3hCkGGqjam8fV3ayQhG1zI7T7vZCsksUg7VUpwURfMcgdfei1IDS5r6aFc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783288795700126.23066184935362; Sun, 5 Jul 2026 14:59:55 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgUsC-0000I2-3k; Sun, 05 Jul 2026 17:59:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUsA-0000FJ-Mb for qemu-devel@nongnu.org; Sun, 05 Jul 2026 17:59:34 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUs8-0000MJ-8x for qemu-devel@nongnu.org; Sun, 05 Jul 2026 17:59:34 -0400 Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 665LxKbu2839031 for ; Sun, 5 Jul 2026 21:59:20 GMT Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6qvgutsd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 05 Jul 2026 21:59:20 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e7ee64b25so416128585a.0 for ; Sun, 05 Jul 2026 14:59:20 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47a9de1e785sm18913925f8f.8.2026.07.05.14.59.16 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 05 Jul 2026 14:59:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= bc1IU9CgmcY+0G7lSlsFtIectefxcgj07/d7AIAf3oM=; b=oSTsYvl/iwJiqQ++ w405USHY8161JYAO2/p197rYMGVPyKghPTNapkTRp4vR3mrHfReXAdAmJAqN+o3V REvKOrff/GaHW6bV94q8cTC5WBR6FECVw5ZsPm8DS0Ho9cLnzkkBh6plUSmBFJbQ hyQya1PxBYjxCpkMbiFdMCHDTTGIBL2d0/GzcTWot+WdMoWYk2twbsJ3OQIj+qMs SKRPDPRirB9qW+ek95eMlKOELX4ZP+dnzNe6SRsOnK5qMqRsr9c3igP4BEypmjZy v8K8QEHlM1n3e4OwokmjUmsk49R/6UYsrSNiwprulp5VgCJ6F6XVNc20iRC0E6aR 1gOAfQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783288759; x=1783893559; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=bc1IU9CgmcY+0G7lSlsFtIectefxcgj07/d7AIAf3oM=; b=d9/hfntt8i7M7PPCvYtqs5xIBsafzUzgYc2ORJ3Uu4YrniAPWLiZghT041aYAjN2Zb gme3TbytNsb+kXLp8rQI5Jz3nhI1fIB5f52rkn6fBlu+m0bZn9kUYpIlRHS/1GNIjBTI vmQZSf3gnAg9snT4n/fzTo3tKbuVBL20ou1fwoz9PdaIIoF7NvRP9ofQ+Yke+lpBS0+9 wUZBV7yWTTgyTgTw0ovGwjk0+ac0Iwjh4tVCO233iSmQbI8dSaqoVQQUM3Z4qLCiG3J/ wz0VLzYQzT1dgyjKrMgcF0CtuS9smCocTYHV/fIZ2nSUdOgnOSLoePxSAXKCV4cBzXdV mwhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783288759; x=1783893559; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=bc1IU9CgmcY+0G7lSlsFtIectefxcgj07/d7AIAf3oM=; b=pmbbpMFoe3Piikf8X6GpNiV7o0I2stzVJLF+jb5qgUcbIA5QREeFt9LgJPO6dNHgud iR2Jjk/yicryp4p8HuisuYTjApb8XHVlerRZEsAPLMS/JbIu2xDKp+QY+pMYr5hrMqcy c/x6ebzY++VGPF35KfBFk/InAOJPkPDNGZ+MumNsqTbcl54Bz/VIZPkoaxQKiFQbNWfz JZVY9uLpcTR8hg6/qL1+KTfiu9xR86TCEfJFNrRyhdNuSHk6ScXqcIOuJN0jtaxIutoQ PJ35QCaGOeDBaIVXQb7a6DeZcynfAkAUik0YK6hT1wgi6Jm48xem74b3Q5SyowUa6sZN WEwA== X-Gm-Message-State: AOJu0Yz/VUN/KI/P9Lg+ZAIaiszaPxPsWQEsGJSkE2qJLf1nMNZj5CUG 7NdDRe8Y5oT6wbdvpVLPzS/JeDWWcKHS5MLANS8pgofmr8JWFLtsi67fvolgXCLPCEmYAjzwSEQ HQj1u4rlwby/dNnsSm0jf6zj4eGu0CcA5ryKyuXYlcf6BFkPiC7EZDZttjoMuNt6mUg== X-Gm-Gg: AfdE7cn/atq8GZp4jEMkXOhEUvW9+JeRE5eqDRkHytWqX+tA9OAwa7SbkOXhIcVKWxf qeSRlIgRGrcTWiybbaturD7Gn7LjtSpu1rFxOOxGXjeOnVEYDqb/7eGEkCfxb9QIJp7klKw/WGn i2vDwsTzMkhJ9mH7qplx+J7SkA8wbkyJ7FzfnexT696OSM2uYuwgAGKkTVzgq4dCbf+f0BQynEC c14aNNh7xMiQfR1sH1c6kBnttw6CVNtSE4yLZYdrff3OgcOAZu+p14CK1ARLZafbt61T861Lkwv T8q7kQv6uVW2aIAZcd996QbBg/0F6rVOu7OXm1Bqj+1jPCbovzz14Cqi2hLRurjj2PhKgeq397j nDH9gBc6UdfJlV3dtQPE6e/ovufElorPUVSY7Rbnc5SHGLhIpMvgxbA== X-Received: by 2002:a05:620a:44c2:b0:92e:5137:2830 with SMTP id af79cd13be357-92e9a4d281cmr1046091185a.72.1783288759423; Sun, 05 Jul 2026 14:59:19 -0700 (PDT) X-Received: by 2002:a05:620a:44c2:b0:92e:5137:2830 with SMTP id af79cd13be357-92e9a4d281cmr1046088685a.72.1783288758923; Sun, 05 Jul 2026 14:59:18 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , alex.bennee@linaro.org, qemu-s390x@nongnu.org, Magnus Kulke , Zhao Liu , qemu-ppc@nongnu.org, Paolo Bonzini , Xiaoyao Li , Richard Henderson , Mohamed Mediouni , Peter Maydell Subject: [PATCH v3 14/32] accel: Have each implementation return their AccelGdbConfig Date: Sun, 5 Jul 2026 23:57:10 +0200 Message-ID: <20260705215729.62196-15-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260705215729.62196-1-philmd@oss.qualcomm.com> References: <20260705215729.62196-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=VvoTxe2n c=1 sm=1 tr=0 ts=6a4ad3b8 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=GIYXWNLsZHjPOkf-ILAA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: VMyIl78Nn9bFYn5Hvhg6XrRF_KUf05K3 X-Proofpoint-GUID: VMyIl78Nn9bFYn5Hvhg6XrRF_KUf05K3 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfX3UYpVmlT2VIu pYcbvIlptZoD8eINf142+/yuV81oOqNjfEFxQ0065zVFi91QfP7omx8Ai5UUqrQUFXVMyNJ3wKv Bl66KTn/vXaJMLCM/Hl7za2ffPl63zI= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfX/xVoMN/ikWDJ RrxlZ9U8TTFvc9XUc/TR8n2wZ91R5cpia0bbyduloOI7DCUK9WsT6ctx/veWK+EAQ1uI/tqYUnx T+lwGFLdD47PI9R3UuH63xnT4JZARdPOIKZ3+3F4342ix1xmL3gf2HkjNr4EqppE3f0dFVS2Fon ytsEag5Ry7KYPW51GvnfIA7uqq2XyvKvBAIsniEnk5hmEAsbz8MO8ycLxBTGBDRdl80ZQOw3T8x S4OTxDOQjiJoS8nO1t++WYvw83d+Ary5N3rlrtZVJoJ8HJg/Df4TO8U6dqHCQQFmcLkIx7hsX8g y5+fs8fi6At8NSH34UWvJu6Po7+6FpLaWzEngxiD/V2XSvnpexEwn5D6BV9nX5jRJ1VRcbOZ0NH kWu/Iu65CXcL5ofeCqZML2x9/do746vi0QQ3dGfrpDMKz91yEzfRjP3C+qynOH9aHoUwEwhn+Lp bSr4qDHK1MjpoJfcbKg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_02,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 suspectscore=0 impostorscore=0 clxscore=1015 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607050238 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783288796484158500 Hold the per-accelerator AccelGdbConfig in AccelState, set its single @sstep_flags field in AccelClass::init_machine handlers. Remove the AccelClass::gdbstub_supported_sstep_flags() getter and inline the single accel_supported_gdbstub_sstep_flags() call in gdb_init_gdbserver_state(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- include/accel/accel-ops.h | 5 ++--- include/qemu/accel.h | 8 -------- include/system/whpx-all.h | 1 - accel/accel-common.c | 10 ---------- accel/hvf/hvf-all.c | 8 ++------ accel/kvm/kvm-all.c | 17 ++--------------- accel/tcg/tcg-all.c | 27 +++++++++++---------------- accel/whpx/whpx-common.c | 1 - gdbstub/gdbstub.c | 2 +- target/arm/whpx/whpx-all.c | 5 ----- target/i386/whpx/whpx-all.c | 7 ++----- 11 files changed, 20 insertions(+), 71 deletions(-) diff --git a/include/accel/accel-ops.h b/include/accel/accel-ops.h index f46492e3fe1..9f3f329c448 100644 --- a/include/accel/accel-ops.h +++ b/include/accel/accel-ops.h @@ -13,6 +13,8 @@ =20 struct AccelState { Object parent_obj; + + AccelGdbConfig gdbstub; }; =20 struct AccelClass { @@ -36,9 +38,6 @@ struct AccelClass { bool (*has_memory)(AccelState *accel, AddressSpace *as, hwaddr start_addr, hwaddr size); =20 - /* gdbstub related hooks */ - int (*gdbstub_supported_sstep_flags)(AccelState *as); - bool *allowed; /* * Array of global properties that would be applied when specific diff --git a/include/qemu/accel.h b/include/qemu/accel.h index 052b4c59313..3b01d55741b 100644 --- a/include/qemu/accel.h +++ b/include/qemu/accel.h @@ -82,12 +82,4 @@ typedef struct AccelGdbConfig { unsigned sstep_flags; } AccelGdbConfig; =20 -/** - * accel_supported_gdbstub_sstep_flags: - * - * Returns the supported single step modes for the configured - * accelerator. - */ -int accel_supported_gdbstub_sstep_flags(void); - #endif /* QEMU_ACCEL_H */ diff --git a/include/system/whpx-all.h b/include/system/whpx-all.h index 0e2d333e919..4022571ffff 100644 --- a/include/system/whpx-all.h +++ b/include/system/whpx-all.h @@ -23,7 +23,6 @@ void whpx_arch_destroy_vcpu(CPUState *cpu); void whpx_arch_accel_class_init(ObjectClass *oc); =20 /* called by whpx-accel-ops */ -int whpx_arch_gdbstub_sstep_flags(AccelState *as); bool whpx_arch_supports_guest_debug(void); =20 #endif diff --git a/accel/accel-common.c b/accel/accel-common.c index 62590a7d9a6..f31d68a9b78 100644 --- a/accel/accel-common.c +++ b/accel/accel-common.c @@ -113,16 +113,6 @@ void accel_cpu_common_unrealize(CPUState *cpu) } } =20 -int accel_supported_gdbstub_sstep_flags(void) -{ - AccelState *accel =3D current_accel(); - AccelClass *acc =3D ACCEL_GET_CLASS(accel); - if (acc->gdbstub_supported_sstep_flags) { - return acc->gdbstub_supported_sstep_flags(accel); - } - return 0; -} - static const TypeInfo accel_types[] =3D { { .name =3D TYPE_ACCEL, diff --git a/accel/hvf/hvf-all.c b/accel/hvf/hvf-all.c index 21b9b71a6df..8bd9154a50b 100644 --- a/accel/hvf/hvf-all.c +++ b/accel/hvf/hvf-all.c @@ -220,6 +220,8 @@ static int hvf_accel_init(AccelState *as, MachineState = *ms) } assert_hvf_ok(ret); =20 + as->gdbstub.sstep_flags =3D SSTEP_ENABLE | SSTEP_NOIRQ; + QTAILQ_INIT(&s->hvf_sw_breakpoints); =20 hvf_state =3D s; @@ -228,11 +230,6 @@ static int hvf_accel_init(AccelState *as, MachineState= *ms) return hvf_arch_init(); } =20 -static int hvf_gdbstub_sstep_flags(AccelState *as) -{ - return SSTEP_ENABLE | SSTEP_NOIRQ; -} - static void hvf_set_kernel_irqchip(Object *obj, Visitor *v, const char *name, void *opaque, Error **errp) @@ -278,7 +275,6 @@ static void hvf_accel_class_init(ObjectClass *oc, const= void *data) ac->name =3D "HVF"; ac->init_machine =3D hvf_accel_init; ac->allowed =3D &hvf_allowed; - ac->gdbstub_supported_sstep_flags =3D hvf_gdbstub_sstep_flags; hvf_kernel_irqchip_override =3D false; hvf_kernel_irqchip =3D false; object_class_property_add(oc, "kernel-irqchip", "on|off|split", diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index b6125125f82..ceb0b33abdd 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -104,7 +104,6 @@ bool kvm_readonly_mem_allowed; bool kvm_vm_attributes_allowed; bool kvm_msi_use_devid; bool kvm_pre_fault_memory_supported; -static int kvm_sstep_flags; static bool kvm_immediate_exit; static uint64_t kvm_supported_memory_attributes; static bool kvm_guest_memfd_supported; @@ -3041,13 +3040,13 @@ static int kvm_init(AccelState *as, MachineState *m= s) (kvm_check_extension(s, KVM_CAP_SET_GUEST_DEBUG) > 0); =20 if (s->have_guest_debug) { - kvm_sstep_flags =3D SSTEP_ENABLE; + as->gdbstub.sstep_flags =3D SSTEP_ENABLE; =20 int guest_debug_flags =3D kvm_check_extension(s, KVM_CAP_SET_GUEST_DEBUG2); =20 if (guest_debug_flags & KVM_GUESTDBG_BLOCKIRQ) { - kvm_sstep_flags |=3D SSTEP_NOIRQ; + as->gdbstub.sstep_flags |=3D SSTEP_NOIRQ; } } #endif @@ -4279,17 +4278,6 @@ static void kvm_accel_instance_init(Object *obj) s->honor_guest_pat =3D ON_OFF_AUTO_OFF; } =20 -/** - * kvm_gdbstub_sstep_flags(): - * - * Returns: SSTEP_* flags that KVM supports for guest debug. The - * support is probed during kvm_init() - */ -static int kvm_gdbstub_sstep_flags(AccelState *as) -{ - return kvm_sstep_flags; -} - static void kvm_accel_class_init(ObjectClass *oc, const void *data) { AccelClass *ac =3D ACCEL_CLASS(oc); @@ -4298,7 +4286,6 @@ static void kvm_accel_class_init(ObjectClass *oc, con= st void *data) ac->rebuild_guest =3D kvm_reset_vmfd; ac->has_memory =3D kvm_accel_has_memory; ac->allowed =3D &kvm_allowed; - ac->gdbstub_supported_sstep_flags =3D kvm_gdbstub_sstep_flags; =20 object_class_property_add(oc, "kernel-irqchip", "on|off|split", NULL, kvm_set_kernel_irqchip, diff --git a/accel/tcg/tcg-all.c b/accel/tcg/tcg-all.c index 8eb4a6b89e8..d30b53cd3b7 100644 --- a/accel/tcg/tcg-all.c +++ b/accel/tcg/tcg-all.c @@ -149,6 +149,17 @@ static int tcg_init_machine(AccelState *as, MachineSta= te *ms) =20 tcg_allowed =3D true; =20 + as->gdbstub.sstep_flags =3D SSTEP_ENABLE; + if (replay_mode =3D=3D REPLAY_MODE_NONE) { + /* + * In replay mode all events will come from the log and can't be + * suppressed otherwise we would break determinism. However as tho= se + * events are tied to the number of executed instructions we won't= see + * them occurring every time we single step. + */ + as->gdbstub.sstep_flags |=3D SSTEP_NOIRQ | SSTEP_NOTIMER; + } + page_init(); tb_htable_init(); tcg_init(s->tb_size * MiB, s->splitwx_enabled, max_threads); @@ -242,21 +253,6 @@ static void tcg_set_one_insn_per_tb(Object *obj, bool = value, Error **errp) qatomic_set(&one_insn_per_tb, value); } =20 -static int tcg_gdbstub_supported_sstep_flags(AccelState *as) -{ - /* - * In replay mode all events will come from the log and can't be - * suppressed otherwise we would break determinism. However as those - * events are tied to the number of executed instructions we won't see - * them occurring every time we single step. - */ - if (replay_mode !=3D REPLAY_MODE_NONE) { - return SSTEP_ENABLE; - } else { - return SSTEP_ENABLE | SSTEP_NOIRQ | SSTEP_NOTIMER; - } -} - static void tcg_accel_class_init(ObjectClass *oc, const void *data) { AccelClass *ac =3D ACCEL_CLASS(oc); @@ -266,7 +262,6 @@ static void tcg_accel_class_init(ObjectClass *oc, const= void *data) ac->cpu_common_unrealize =3D tcg_exec_unrealizefn; ac->get_stats =3D tcg_get_stats; ac->allowed =3D &tcg_allowed; - ac->gdbstub_supported_sstep_flags =3D tcg_gdbstub_supported_sstep_flag= s; =20 object_class_property_add_str(oc, "thread", tcg_get_thread, diff --git a/accel/whpx/whpx-common.c b/accel/whpx/whpx-common.c index e3f93efc61f..247e12db812 100644 --- a/accel/whpx/whpx-common.c +++ b/accel/whpx/whpx-common.c @@ -527,7 +527,6 @@ static void whpx_accel_class_init(ObjectClass *oc, cons= t void *data) ac->init_machine =3D whpx_accel_init; ac->pre_resume_vm =3D whpx_pre_resume_vm; ac->allowed =3D &whpx_allowed; - ac->gdbstub_supported_sstep_flags =3D whpx_arch_gdbstub_sstep_flags; =20 object_class_property_add(oc, "kernel-irqchip", "on|off|split", NULL, whpx_set_kernel_irqchip, diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 06b712562c5..6c4fa065638 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -72,7 +72,7 @@ void gdb_init_gdbserver_state(void) * By default try to use no IRQs and no timers while single * stepping so as to make single stepping like a typical ICE HW step. */ - gdbserver_state.accel_config.sstep_flags =3D accel_supported_gdbstub_s= step_flags(); + gdbserver_state.accel_config =3D current_accel()->gdbstub; gdbserver_state.sstep_flags =3D SSTEP_ENABLE | SSTEP_NOIRQ | SSTEP_NOT= IMER; gdbserver_state.sstep_flags &=3D gdbserver_state.accel_config.sstep_fl= ags; } diff --git a/target/arm/whpx/whpx-all.c b/target/arm/whpx/whpx-all.c index 5208d7e1dfe..3079c6293c8 100644 --- a/target/arm/whpx/whpx-all.c +++ b/target/arm/whpx/whpx-all.c @@ -295,11 +295,6 @@ void whpx_translate_cpu_breakpoints( /* Breakpoints aren=E2=80=99t supported on this platform */ } =20 -int whpx_arch_gdbstub_sstep_flags(AccelState *as) -{ - return 0; -} - bool whpx_arch_supports_guest_debug(void)=20 { return false; diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index f6e1636a4e0..467ac6bed45 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -1853,11 +1853,6 @@ void whpx_apply_breakpoints( } } =20 -int whpx_arch_gdbstub_sstep_flags(AccelState *as) -{ - return SSTEP_ENABLE; -} - bool whpx_arch_supports_guest_debug(void)=20 { return true; @@ -3348,6 +3343,8 @@ int whpx_accel_init(AccelState *as, MachineState *ms) whpx_memory_init(); whpx_init_emu(); =20 + as->gdbstub.sstep_flags =3D SSTEP_ENABLE; + return 0; =20 error: --=20 2.53.0 From nobody Sun Jul 26 11:01:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783288818; cv=none; d=zohomail.com; s=zohoarc; b=Vfo11JPTRPk5QsN54PtZ8Uy33/VYAT6ZpB/9YFN/UXnI+WnW4yCu75YIeL6+bZ3z6uZ2wofrBWhu9p/xycvLfi6C1JUg0/DSlroTdZThTMpEHaf4uWCa6i2pMjqcT4Kf3xHd9EefefcBCXOmRyOBaFjsuXOC+2LY01ZwA09UiVk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783288818; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=VdLq6Zfki+3ghFdFd7ctb3ThvHqHp9sVmMt32nHNdYM=; b=lyqNNJLaLbC48GTV+Bcl6WDeCFHKjs40FHC6ua9fhAxky4h1efi3aXbWjjc1zN8eQ3goRYJwxAC7DqVmi25OfGcfEGW9uXfBEh5/6+CJx9us98It14IOl9p/COu+E8ymVdO6MKovXyWVKjqMuVHAgt3EA6FYlwGSsYI238KU6ZQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783288818265889.2790574585702; Sun, 5 Jul 2026 15:00:18 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgUsl-0001EM-BM; Sun, 05 Jul 2026 18:00:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUsI-0000da-UP for qemu-devel@nongnu.org; Sun, 05 Jul 2026 17:59:43 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUsG-0000QD-6Y for qemu-devel@nongnu.org; Sun, 05 Jul 2026 17:59:42 -0400 Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 665LxHuG2858828 for ; Sun, 5 Jul 2026 21:59:29 GMT Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6td3bgmc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 05 Jul 2026 21:59:28 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-92e53b8a302so216664385a.1 for ; Sun, 05 Jul 2026 14:59:28 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa039b0cesm18580294f8f.22.2026.07.05.14.59.24 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 05 Jul 2026 14:59:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VdLq6Zfki+3ghFdFd7ctb3ThvHqHp9sVmMt32nHNdYM=; b=c/dS3s/7BLSYeImb wcy9ePil2ZrePKFOiouuJC5XmgaSiF/oi2febYIOKYUU97T5HS3fKYLAcxAWbc0a jLgJ2/D+gz9di4Q/w5LgcUF0xOpgExtMspYlbX/iCcIcZmD5wfN+0qOPSzR6CS6o sGL/V1JImQWRropU4vCSNXZqKpVm7NBu1jDPUTtlsMrN+NT+kRDtAvPG2zUqBBQd i28wA/FYOT+VeSSF6gzQNOwBb2q2pj31lVbN+EDX271kQwYUrAEw9QvWyUlxK5Q/ iXXUGzXYwhIQB6/eSzqDaIbi5aSHN3mH2vg0K6pgQV+oebomAmKSpC54TNcPCcfR hdhyjg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783288768; x=1783893568; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VdLq6Zfki+3ghFdFd7ctb3ThvHqHp9sVmMt32nHNdYM=; b=hXuL6dXn7ztjbqEDf0tuPYZMeeCViK6+tqcN86nbslb8XXBhwTD+Rz9OM42xhfP+KA QdC8Yz/k+Jbf55b0h+EXEVGIs2tY4SxYMoA4fWwttGtc5UTe9+vn3keh5NS7yAxBUfM7 jD2w5vRcionurqvP8TjFFPTryRFb065hL7Fh3SuUynr97wu+Z6n8ze/8PdAL1w6Hr/D2 fC5McDKBHqwkeE9yeDtUNhs5XD/QAm9jpLxQxnvIM36pcpl7utiT/WJg838XCmH4maY8 ltPvsC0JGoMA0p7JIDnNn9J911OxgILiEtwBlV2I2ch0Cumjuf70nEj6fy+Ue7otqXxn QO/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783288768; x=1783893568; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VdLq6Zfki+3ghFdFd7ctb3ThvHqHp9sVmMt32nHNdYM=; b=mYvgEy+jZcDcY5HUcd1HzPJNWKA1vl+Y6mPACH2Bmob1ue2ajzmq1OrqJYUDx252wK CDZ2jPOO5Uex4C5eEXJKO6GVZHBZBQcVqHR1PsE2eU/sZyYPE9UdfNjz2gcaXmtQDrG1 +uRq/U54/I7ht4EUZwlkTgJy0OPE/F2unvcY5gmt05m+G3IVUgPNySZJ57ZZ9ox+Zepb 17cbxbhfq8PSkq6xrhZBuQ8hV7zhff4/wS0LPsJHaRsX3hO+gZYhvZdfrsAj0Fyu0kQH 3xUpPGHoJ1PnpHMJxnwjEOYQxiX4eS1d3Pj2C95teeQ10GQBzibCLT0RSHaE8aEuNxdX wvtw== X-Gm-Message-State: AOJu0Yyx+GUGl+xwgyCenZFwp/rGzr4JGDXKJbSKlG6HaLcNDR8O8kPT 4422grWqk6ffIavWuOsvt+IzAbvYp5aMLBw88deF0qQAUw985FC3/qY+NL4+6CJsX5ZRNp3+c2+ Ilq7LQyuIKaOAWN338f6YCpfj0seL1mFbcwBkNnd2GmatSZHxPTNGinx6E64nJJP9EA== X-Gm-Gg: AfdE7cmRP1w2sfqJZ3xur+fNgaiJ6Fyj6yPpAl/ZCzrm/r9TmGtzhFUURPFFUGNNSNx WpfBd0+umWJzyzDfPJF+fL73JH9Za0gfk34e03hD3sHjj+KskAaCXOlplTJ8BPNRkNyoL78FBQ8 awCFWodbCRcWbexq1rq0l1fXYt8FS77CNKjkzoT+vz3eMYU52PvqsM1unh6Ja/mqSQ3RSmxO+qq TWexvi4YVycwie/tWsfKTTyAw9636TF8zt6AG1Cv2flKiWd66QddJ8BH2EaXVkJKHHgnFHuIBaL vUgK7JoRtZcmKKGnY/LHZzsmQ9Xn2IPXMeL13hiWVq3yGRFj2Ywt19HNqCDqyD5ptDZshrtptQO p+bN/m9YKW/VZoNqCU8ys7rSo/VblLK9dezn1jjpG4MiwuSVYjGOKFpg1T2PnS9q6GiVy X-Received: by 2002:a05:620a:6489:b0:92b:6805:eae4 with SMTP id af79cd13be357-92e9a50fa0bmr1124321485a.65.1783288767885; Sun, 05 Jul 2026 14:59:27 -0700 (PDT) X-Received: by 2002:a05:620a:6489:b0:92b:6805:eae4 with SMTP id af79cd13be357-92e9a50fa0bmr1124318985a.65.1783288767432; Sun, 05 Jul 2026 14:59:27 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , alex.bennee@linaro.org, qemu-s390x@nongnu.org, Magnus Kulke , Zhao Liu , qemu-ppc@nongnu.org, Paolo Bonzini , Xiaoyao Li , Richard Henderson , Mohamed Mediouni , Peter Maydell Subject: [PATCH v3 15/32] gdbstub: Make default replay_mode value explicit in stubs Date: Sun, 5 Jul 2026 23:57:11 +0200 Message-ID: <20260705215729.62196-16-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260705215729.62196-1-philmd@oss.qualcomm.com> References: <20260705215729.62196-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfXz1rTv+9YtS8u GG6bmGgxOYZHiTiAKnGBjXsxV+5E2mkj4vuCBEAvEYB4Iuwb3zXv75ml3LtryfxZc6dlUKolxva YAeFn3kK1XTWPv8oVNxJPL+qG5a1pvs= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfX+Ql0WD+MQRgn 0zKE77ftSCMQMxQmgtNKvntyw4uvXxJflJR3J+/cQzBHpvxXdRAJXya5+jSv4ObfFpGwjs9Tvb3 8TkQ+PRS7+XjkS+ID8oGAlMnJazXm9wCE1QEbvT7aCcp9DM+DPBfMTexl79/RyCp8LodV/c1IOI 61f0luPec4X2Ks11uwtdeHDK59qGsGNVlQsilloNa8TSUrE7LOFa+P599JMqF4HBXTjdNvwKxsk BVkdWLWHFgU1iPWa9UGAB9nQgNj6Zukdzwfn7VXsdBhcCQ0uR6qkKYrdU8YPFIGuf7BTQluNDJb tF/9yi4O+NK5MuZSRBONH4uDgCP30hKgvBQKC6Pl+5lOVag+GrVFnBb31c67ULx3vagvOBHLMuS VAlH5DWdDO+KlvSErFYr1FUpVYtqeIzF1VPhHa6uikwFkKgHUqHkuPAc5IE84ozIYE2RN2+z9t8 owJgCZy/E5SH//aSakA== X-Proofpoint-GUID: B44PcyiH7iejRUsi8Ll2guOVbR6G0cZl X-Proofpoint-ORIG-GUID: B44PcyiH7iejRUsi8Ll2guOVbR6G0cZl X-Authority-Analysis: v=2.4 cv=b9GCJNGx c=1 sm=1 tr=0 ts=6a4ad3c0 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=Cu_OB6cER5A0ZMY7a4UA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_02,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 malwarescore=0 adultscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607050238 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783288818534158500 Make explicit @replay_mode is stubbed as REPLAY_MODE_NONE. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- stubs/replay-mode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stubs/replay-mode.c b/stubs/replay-mode.c index 439d97e4a87..5bc8f7d6589 100644 --- a/stubs/replay-mode.c +++ b/stubs/replay-mode.c @@ -1,4 +1,4 @@ #include "qemu/osdep.h" #include "system/replay.h" =20 -ReplayMode replay_mode; +ReplayMode replay_mode =3D REPLAY_MODE_NONE; --=20 2.53.0 From nobody Sun Jul 26 11:01:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783288818; cv=none; d=zohomail.com; s=zohoarc; b=SdQRz+u1isHLIPtjJgEMZWD0XCqhXiA8SysxUQ5cEJr9uF6pqSnaTLLQR2k2X3BBEXnccTsI2uIxhK04bmo+J8x5qJH+NtB0Ge1pj28Xmvbilr4DYmDeKYtOX3Brioxgn2DLcD8/X2Lwoy9Wn4trvmNdwVNTrXbPXw8lm010CWM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783288818; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=2br9DW08n90+USIli43PezSjjKsqs8k745Ddne726yA=; b=GHFMuw/zSBOclIFXg9Vyu++i+GhdEI5FaJInlEv2gG4BFcXWt0YmYoxKlLYmm73FClz/0w5ZgfzoBjeRMdBQ5lFkmJmXHV8ZGMvYRKWvurdHMc3EaTP1khnnOoePGkpk2DQkpJpWP+ptdZn8tP7RIkTpDo8khqpAMutbziI7UQw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783288818260654.2857663916643; Sun, 5 Jul 2026 15:00:18 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgUsk-00019m-VP; Sun, 05 Jul 2026 18:00:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUsQ-0000ig-3c for qemu-devel@nongnu.org; Sun, 05 Jul 2026 17:59:50 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUsO-0000SB-Ei for qemu-devel@nongnu.org; Sun, 05 Jul 2026 17:59:49 -0400 Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 665LxaqK2716420 for ; Sun, 5 Jul 2026 21:59:36 GMT Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6txekdvv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 05 Jul 2026 21:59:36 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e59b0e0f4so167720285a.1 for ; Sun, 05 Jul 2026 14:59:36 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa09608d4sm19859692f8f.25.2026.07.05.14.59.33 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 05 Jul 2026 14:59:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2br9DW08n90+USIli43PezSjjKsqs8k745Ddne726yA=; b=X1JROeRG17l6eK5K W+bwvjmqccC6ZVncd3MWbExdwP5ZFqiHEOnWU5HVXp+2wbjJdCgxK0q7bGUYC1gx 4dEU0GaGIvswF3qSTU5ZLR9Ud/Qj60383cipj++i69rKuDtsoP4s8UE+EbqcrA6t 3uQlAfpUonUJ9FwZp0Y43+jZGrxBqG+Lvqog1KhL9NTYCjeuQnVTpd6pJgpJkHeM 6mouyJnWMJRo68toKWKvtchHtlfdheqtWpjFztSmUQ/B567kUHnpGHuxu6bYTNAc iX80e4NQ5Iv2ZjEPci/ZUKtsFulKBIUZ/U+GEzqCl6OzMoIb4snpBVFwKJsgdGXX WViYKA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783288775; x=1783893575; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2br9DW08n90+USIli43PezSjjKsqs8k745Ddne726yA=; b=cLiQs/xfT7Shw+qisnaZtIVi0qpBtEKnhLcAEWhjAtFMPYphbmE+TC5L2xnq9Oxgn4 kSs7NQwhUl1y9GoERP48IlOj2pF+SzLmFHlzKbYJ7Pni1c0g+UuCoidMGEHMYwSIsynO y3/04C02ncOOAHt1yDRIxbBBy4q8snBWfvv2IuP99HiUJEIS9fOGOeoA2Rrobl0SlOG8 GLB1g5G0A65L8HAcOwWXXTxEPqaEtuSCSem7M8HA+ZZEoNo1B2Gojr4v1T4FRfCKlXBx /trPY8sVq1wOowaTt0KzUYzH95Ls4IZPR2srnuD0+w5YVcvHSfvufMR2/LqAGld05wqL fwKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783288775; x=1783893575; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2br9DW08n90+USIli43PezSjjKsqs8k745Ddne726yA=; b=EC0l3A88yc4o/5mmG/Z0ombshEPC2VFayb0iSukmhbMkyLx3It86FRBxrVY5W7m6lh 86YOsM4rfIAYlwC5QkZs/dcHk8ZDG8XAT93H1vfenyKlUSJouzJ2SYCxCbtvB4OIrnMg 9g37r3hJZ3uUaWkC8Dhd06L8mSoymoX2dSVQVZwnTAJEojgx7FojT9drCsBL1QbR2c7U K8AqpfD2if/i/i84WiTcl6dcE3G0m9WUJHAcOcJ9GLWDjp2vYDpoWb0MDlxRSfjpwx+J hd92UhiNuAHzthwCLgyMBhs3YIgl4h76eaNFaNucJdEybdA8yAOtLijjM9GNnRTb05da xrHw== X-Gm-Message-State: AOJu0Yx0I5Vcs5Y52zOQT1EjiIhrmxDL/IB2eL/rm/tZ+LuUpZwFw41a amGdMMik/vTp2sICTMTN3h7GfXSJ2VD5QKR8IaYxEcftQJyPzJ/jJaFxjQBaf8yvCCx6XMTD767 lUh7xoDYc9uGYPC2YgGJpCOJpQXXMJK77Ov0Drvl7cm4n1+8eQPbXVWZOIYYfBf9kaQ== X-Gm-Gg: AfdE7cnnu1l5u6tB7Zg+5K6FFQWB7+AaMzyYAkfdTnkHLz17sedSkwdacym40ADKcY9 wRLEKzt9e1gWJXPXCUvkIbGYu05azSOke64n971TBU/byuw/HSkshtluTaejuI/ZtcPGtHUqbaf alyYqPQ0Vk8387pT2odj2FBp5AG9AnvHK933P9O5dsd8QMyG9L4ZBDwpIAOP8A0CtVUGUvUCl+5 Hv4L4+CRm/AXcr/AsLbN4+WQQcGvDTUpKyQGXzRedVFFYGQGaa+zw6J26Euv6lmYtEIjYVW0Ewx VdBC+PNGFHth43REQe6EdKp/YlFdlYR2y4h3xxYGlsuayjgKv/eTmGnZ2YHZz8o6IlGgMwvF+YN +KTdQykZG74RzikazzsIfP8SOOBM4nAD0zlSdU99qvrJBON38ofMQgw== X-Received: by 2002:a05:620a:4145:b0:92e:583d:245f with SMTP id af79cd13be357-92e9a346819mr1077593285a.9.1783288775381; Sun, 05 Jul 2026 14:59:35 -0700 (PDT) X-Received: by 2002:a05:620a:4145:b0:92e:583d:245f with SMTP id af79cd13be357-92e9a346819mr1077591485a.9.1783288774894; Sun, 05 Jul 2026 14:59:34 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , alex.bennee@linaro.org, qemu-s390x@nongnu.org, Magnus Kulke , Zhao Liu , qemu-ppc@nongnu.org, Paolo Bonzini , Xiaoyao Li , Richard Henderson , Mohamed Mediouni , Peter Maydell Subject: [PATCH v3 16/32] accel: Hold @can_reverse information in AccelGdbConfig Date: Sun, 5 Jul 2026 23:57:12 +0200 Message-ID: <20260705215729.62196-17-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260705215729.62196-1-philmd@oss.qualcomm.com> References: <20260705215729.62196-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfX+s+IFOsV4wgb kmj6Int/v561uvka/rGLOQjIkkZRXSkYzVVfrEAScBrzc1WvXVtjI4tY8pP3odvS/nslqgyxbGK syPegza3oBnSlRV58+ud4azish9oSfU= X-Proofpoint-GUID: QXxfRzUdbfQooqK1yHwSKXHhhU2iwFY2 X-Proofpoint-ORIG-GUID: QXxfRzUdbfQooqK1yHwSKXHhhU2iwFY2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfX0qsy0X2Girb8 lMddFHlB7J5ShId/MTood1AKLV9JSXrPm0yT5ymLZd9DhM/39IOGESSfG9xxFFuF1foEyv6GL+R RkUtsI12WGcz06nT3HGSeJ+2fRVJgmUChGnSfsRvKKAn3faKAdR6pmBdxn5mcU4qQKmlLPckGk1 QTLViPgSwOU+wOTgft9LzNh+6zVFKpihzLjL8maS9Rp3ghDNp4HHp3ayEUSvjr7G6ub7yJ2p7n+ 9nYAxCAvmnC9bZ3CJnVbx2b0NCY7i70vIiLBox2DCa6HQLau9vMGiyV/ocHQzOpsOATgkag/dfo It2fSA66Ye+5oUCC4dezvR61mhOH7WRfcXinBDBgFxw5NLfc5IHm6gko8fcPO56u5e4sK6pVilc sJL8zL3U46eCN7oL+AgnIR6oFYMtitDH/hoYwNSaNMINzPWveXmsz9cb5xGSmmXgdqiM4Jn+3U4 qF53FazYsuPHSOlNfzQ== X-Authority-Analysis: v=2.4 cv=HLLz0Itv c=1 sm=1 tr=0 ts=6a4ad3c8 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=SMEfN5HU43_l-HwGlA0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_02,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 clxscore=1015 suspectscore=0 impostorscore=0 phishscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607050238 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783288818589158501 Hold @can_reverse in AccelGdbConfig, set it when initializing AccelState in AccelClass::init_machine handlers (only TCG sets it). Remove gdb_can_reverse() as now unused. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Manos Pitsidianakis --- gdbstub/internals.h | 1 - include/qemu/accel.h | 2 ++ accel/tcg/tcg-all.c | 3 +++ gdbstub/gdbstub.c | 4 ++-- gdbstub/system.c | 5 ----- gdbstub/user.c | 6 ------ 6 files changed, 7 insertions(+), 14 deletions(-) diff --git a/gdbstub/internals.h b/gdbstub/internals.h index 0444dee2246..0b74ea4000f 100644 --- a/gdbstub/internals.h +++ b/gdbstub/internals.h @@ -154,7 +154,6 @@ CPUState *gdb_first_attached_cpu(void); void gdb_append_thread_id(CPUState *cpu, GString *buf); int gdb_get_cpu_index(CPUState *cpu); unsigned int gdb_get_max_cpus(void); /* both */ -bool gdb_can_reverse(void); /* system emulation, stub for user */ int gdb_target_sigtrap(void); /* user */ =20 void gdb_create_default_process(GDBState *s); diff --git a/include/qemu/accel.h b/include/qemu/accel.h index 3b01d55741b..8e0c3dfe088 100644 --- a/include/qemu/accel.h +++ b/include/qemu/accel.h @@ -77,9 +77,11 @@ void accel_cpu_common_unrealize(CPUState *cpu); * struct AccelGdbConfig - gdbstub configuration for an accelerator. * * @sstep_flags: Set SSTEP_* flags that accelerator supports for guest deb= ug. + * @can_reverse: Whether reverse mode is supported. */ typedef struct AccelGdbConfig { unsigned sstep_flags; + bool can_reverse; } AccelGdbConfig; =20 #endif /* QEMU_ACCEL_H */ diff --git a/accel/tcg/tcg-all.c b/accel/tcg/tcg-all.c index d30b53cd3b7..7186c10cf02 100644 --- a/accel/tcg/tcg-all.c +++ b/accel/tcg/tcg-all.c @@ -159,6 +159,9 @@ static int tcg_init_machine(AccelState *as, MachineStat= e *ms) */ as->gdbstub.sstep_flags |=3D SSTEP_NOIRQ | SSTEP_NOTIMER; } + if (replay_mode =3D=3D REPLAY_MODE_PLAY) { + as->gdbstub.can_reverse =3D true; + } =20 page_init(); tb_htable_init(); diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 6c4fa065638..0a328b0dd48 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -1376,7 +1376,7 @@ static void handle_step(GArray *params, void *user_ct= x) =20 static void handle_backward(GArray *params, void *user_ctx) { - if (!gdb_can_reverse()) { + if (!gdbserver_state.accel_config.can_reverse) { gdb_put_packet("E22"); return; } @@ -1684,7 +1684,7 @@ static void handle_query_supported(GArray *params, vo= id *user_ctx) g_string_append(gdbserver_state.str_buf, ";qXfer:features:read+"); } =20 - if (gdb_can_reverse()) { + if (gdbserver_state.accel_config.can_reverse) { g_string_append(gdbserver_state.str_buf, ";ReverseStep+;ReverseContinue+"); } diff --git a/gdbstub/system.c b/gdbstub/system.c index 1179c82cb86..2e8c457097b 100644 --- a/gdbstub/system.c +++ b/gdbstub/system.c @@ -479,11 +479,6 @@ unsigned int gdb_get_max_cpus(void) return ms->smp.max_cpus; } =20 -bool gdb_can_reverse(void) -{ - return replay_mode =3D=3D REPLAY_MODE_PLAY; -} - /* * Softmmu specific command helpers */ diff --git a/gdbstub/user.c b/gdbstub/user.c index f7bc4e63dfd..299388b9f71 100644 --- a/gdbstub/user.c +++ b/gdbstub/user.c @@ -786,12 +786,6 @@ unsigned int gdb_get_max_cpus(void) return max_cpus; } =20 -/* replay not supported for user-mode */ -bool gdb_can_reverse(void) -{ - return false; -} - /* * Break/Watch point helpers */ --=20 2.53.0 From nobody Sun Jul 26 11:01:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783288928; cv=none; d=zohomail.com; s=zohoarc; b=ZYQKXyjZ0ctieySlWaDWhdFzE6RloitdRDsNo6oysUUOXYry9XB6QJeK4bGYKtiA2Gu6kMyukNqRqEmYPXlw7WzDDQRkx5vbwjyMsOlCEO6HrXJjMyvWLUM/+jjgZHY79BgjDAhTiB9hUYkjaDGtOxCo+N+i/GBYHRloJd7F50I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783288928; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=dsM4AGzNzxhxuJWd2spi3ulCBBLyDu7+dJNjWKuJGg8=; b=FAnal/nAr0RadTs6++1HxCi5D4bCbjqLAL6B4WGYyLc/cXlOI6BZawn0EugyAW/HQsEoI1+WuQR+Gjo7yg2KLgLpGRiAyU8R6pHQaOY6KXvdhE2V3WwG9jZWzR6lNvC3sM5sauJbFQjC0s05muAaP74oirrmT3cGvsNQS63HNAE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783288928106302.38628631582276; Sun, 5 Jul 2026 15:02:08 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgUso-0001aB-Am; Sun, 05 Jul 2026 18:00:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUsY-0000uv-46 for qemu-devel@nongnu.org; Sun, 05 Jul 2026 17:59:58 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUsV-0000Uv-Dg for qemu-devel@nongnu.org; Sun, 05 Jul 2026 17:59:57 -0400 Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 665LxfNH2716513 for ; Sun, 5 Jul 2026 21:59:44 GMT Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6txekdw2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 05 Jul 2026 21:59:43 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-92e632390d2so452031385a.3 for ; Sun, 05 Jul 2026 14:59:43 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa039b0cesm18581787f8f.22.2026.07.05.14.59.41 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 05 Jul 2026 14:59:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= dsM4AGzNzxhxuJWd2spi3ulCBBLyDu7+dJNjWKuJGg8=; b=YkDOrgssVzmRpNit hk3jSIi3GHyhfJxn93tQOL7aGPo3xxYoNUj/cBcFhx9KVlhgwOBAiQSp204QatMo 9TTYqY/n9a8yDlObt1WbTXqfx2mGq8XIMa+pop4gZ3t3KDdqo35fqrkGstHmoVez s2KIUCjNOwtwFqR7pbiOiSLqRplnM/i1y1n5ngvDo8r84BxHPwDJTgxlC1JC4o6I DcpPttDLKhrsvEw+tZxc89wKsFBB5Z4ANca9rsdrzhfsU7tRVtzxQj9+PmesewiZ Zpm6e+9mqv9hLjStZa6Pr1R9JoaC8pDsht4DYPuiuSv9HQgU7pIBD3dBFhwAl99B ow6RmA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783288783; x=1783893583; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=dsM4AGzNzxhxuJWd2spi3ulCBBLyDu7+dJNjWKuJGg8=; b=TDCWdXniEK0W97wZ9KqTowURSVmT7n++z/VBKum3iCwr4HPrTG+MaiNGyrvfZ1q8wt XjliQAfWULD/KQMpEFSfiCNlOr5w/hTHuPRoXS4XgGjt8sIcgAF2CSwIQPOiuBFvZ/Ne xkPr9rFEX0/GlJFFb43luDv3iDHTF8xFvlYWqSehVBFD+3/aGqdSpZGXrlpDQtMNM22V DbKZr/lIorKQX7IF5x58LEC81nAZlRaP3s2LEjrcKTbx/Vro/HPFmxDSGU5P397mNY0f M9YKTIJ8DVzuVr90kvootCEvztYeeGWJc8G6GHrJwcLfsGyxd8BL93hsIyUe/HkwcQAj 2y2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783288783; x=1783893583; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=dsM4AGzNzxhxuJWd2spi3ulCBBLyDu7+dJNjWKuJGg8=; b=R6yev7T/mytdwhtTbn/SIDPMv980tLK+HFKl74g4dPC9q2TPwTLU2IzFSvGt0h7e73 jPSO12EkLaBV6uNHnAOtenw9J2JytcbMGass3XqYrm09NR0/HkucwjjiGt6HQxguusql 7u81KTFoqp5dIT1ilXtRV50P6G1M1M0i97S6vyhq2IheLubAVHU/SyTptbUQTKPVsv7B GPb3bMhludLGi3Wx/FsSlr0CFSROnqmeq3Ey5DNFNzXJfS7Au+ewSwpAAU6BC8Rgg7Ax hX0P4crBRG0GxmnltkeMkti+IM357p7+HJ8l0q8f8XAyJN3kjbjfLvR3etLoeWeqVpjx u9qw== X-Gm-Message-State: AOJu0Yzi7qDAetxaXjZVLgV6itXYlVXkQluYRhsqD8Kc+GxKg6dAcEmF K04UJDPSgzoqHRVcKcFC+7Gv1Vw51/8q6cJN5qrDhP3BiZL11vJhoTkR6vOmdbuB3oqgrmsJPx8 EoqYQYdFNgTf45EM3BoK59dHTddhQAFLGQpcx0+/KUyfiU4QCEIML7Iy+3xMP51UiAA== X-Gm-Gg: AfdE7cmMk0zoFkn5ab68B4zGYi5iJ1EmXo9DWMvMVkfy8RMkw+c9vdaw4SFnV6XwrnM tL87xYn0479O92C8lOman863OY1S68MwLzabd/H0zi+BvqiNA4b4MG/GBqCMxJ1usmqy8VLZA7v E2VJBIUb6KRomv9fBV29GtYjGFiPyiiZJbpP2jSIyOuCitdXr6uk9/12IxXkmPGWAVZQ7QzTtkP ybdfX/XFc05sCjvP38nq0I2Wi1hLbtLSLQuMnoc5XNaj4G2odQzfpBvx6BC1oi1CC0UOfndcuRb uJ5Q5GE23BCK3e0yWzF6X0Qq1eZslz49ez8AHxFccGhFO/5MRYCjiQbwOCelfwBwKGH77ReZ3Rc +n7El0CDRhVMfcO6vEjDHxgf76Y7rizuUz0o1NnNVtwv1vqkPOSi3Kw== X-Received: by 2002:ac8:5d05:0:b0:51c:11ba:c51e with SMTP id d75a77b69052e-51c4c2dd239mr108380071cf.56.1783288782836; Sun, 05 Jul 2026 14:59:42 -0700 (PDT) X-Received: by 2002:ac8:5d05:0:b0:51c:11ba:c51e with SMTP id d75a77b69052e-51c4c2dd239mr108379841cf.56.1783288782376; Sun, 05 Jul 2026 14:59:42 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , alex.bennee@linaro.org, qemu-s390x@nongnu.org, Magnus Kulke , Zhao Liu , qemu-ppc@nongnu.org, Paolo Bonzini , Xiaoyao Li , Richard Henderson , Mohamed Mediouni , Peter Maydell Subject: [PATCH v3 17/32] accel: Remove AccelOpsClass::supports_guest_debug Date: Sun, 5 Jul 2026 23:57:13 +0200 Message-ID: <20260705215729.62196-18-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260705215729.62196-1-philmd@oss.qualcomm.com> References: <20260705215729.62196-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfX1njHKQeTwwcS UTu10iNVq7MNMF8vq8QNwmUpfmRU2BM1IpkJrWv3VMhmyJdT/qwsb45eFj3yhRgmn5au4MSXfcU 0jp2uXBEE8mJYPSkljJwtm2Rnxdk8kA= X-Proofpoint-GUID: 5MdFsjmClivLUdAYUTZfctoLU3j_ImGY X-Proofpoint-ORIG-GUID: 5MdFsjmClivLUdAYUTZfctoLU3j_ImGY X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfX4dSGS6G/dcfN yn85aQSlbJ0d/f7e1FjOaVcWFrJOFM+cJ/GkDNGORQrQJlaxdo89wkQKxweEVMimNmO34Ixt9yL wPo4ow8Qv9SNfzPnivfwhg8/unndaw1PN5rbvRrwhkVV25Rg2mAQQpMOWENpHd91GbgNpHOVYUf oPAvV+kc7X1Wsi9jXRPM4qZO3AnxMc7Vd2zjEE+cu95O9FN9c4+sz5x+tJLenxZVHw1pbBEFDmm O5nPPBZ5bxWQhWkxd9oL5exs8EqqEVQDBvZhSjz/6LvhBAscc+8nlhR6VbAg/cr4WyX1LXBVOCu rAXaySxcvN49pFrwdhNcxfIPvEWn/10qak5TycbMA2XPclikW6y8cHLRSB+wsdj/CW7bUaQWDYo DsrGJvEIxsZM35sceMk3x4x4ichoz4F3WvGT2CMqxWUL0ZYXvUpxd10pZqlbr75yQMEDOAl7bKk 6IszJ9C0OkaZ/G6FkXw== X-Authority-Analysis: v=2.4 cv=HLLz0Itv c=1 sm=1 tr=0 ts=6a4ad3d0 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=u5zfA1t3EaNT3PtHZxEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_02,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 clxscore=1015 suspectscore=0 impostorscore=0 phishscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607050238 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783288929192158500 Now accelerators hold the 'guest debug supported' information in their state, accessible by the common code. No need to call a per-accelerator handler, simply check for the SSTEP_ENABLE in AccelGdbConfig::sstep_flags. Remove all AccelOpsClass::supports_guest_debug implementations, inline gdb_supports_guest_debug() and remove the now unnecessary KVMState::have_guest_debug field. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- docs/system/gdb.rst | 2 +- accel/kvm/kvm-cpus.h | 1 - include/accel/accel-cpu-ops.h | 1 - include/qemu/accel.h | 2 ++ include/system/hvf_int.h | 5 ----- include/system/kvm_int.h | 1 - include/system/whpx-all.h | 3 --- accel/accel-common.c | 5 +++++ accel/hvf/hvf-accel-ops.c | 1 - accel/kvm/kvm-accel-ops.c | 1 - accel/kvm/kvm-all.c | 13 +------------ accel/tcg/tcg-accel-ops.c | 6 ------ accel/whpx/whpx-accel-ops.c | 6 ------ gdbstub/system.c | 13 +------------ target/arm/hvf/hvf.c | 5 ----- target/arm/whpx/whpx-all.c | 5 ----- target/i386/hvf/hvf.c | 5 ----- target/i386/whpx/whpx-all.c | 5 ----- 18 files changed, 10 insertions(+), 70 deletions(-) diff --git a/docs/system/gdb.rst b/docs/system/gdb.rst index d50470b135e..b6d8f8e77da 100644 --- a/docs/system/gdb.rst +++ b/docs/system/gdb.rst @@ -54,7 +54,7 @@ While GDB can always fall back to inserting breakpoints i= nto memory accelerator. For TCG system emulation we advertise an infinite number of hardware assisted breakpoints and watchpoints. For other accelerators it will depend on if support has been added (see -supports_guest_debug and related hooks in AccelOpsClass). +the AccelGdbConfig structure). =20 As TCG cannot track all memory accesses in user-mode there is no support for watchpoints. diff --git a/accel/kvm/kvm-cpus.h b/accel/kvm/kvm-cpus.h index 688511151c8..3185659562d 100644 --- a/accel/kvm/kvm-cpus.h +++ b/accel/kvm/kvm-cpus.h @@ -16,7 +16,6 @@ void kvm_destroy_vcpu(CPUState *cpu); void kvm_cpu_synchronize_post_reset(CPUState *cpu); void kvm_cpu_synchronize_post_init(CPUState *cpu); void kvm_cpu_synchronize_pre_loadvm(CPUState *cpu); -bool kvm_supports_guest_debug(void); int kvm_insert_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len); int kvm_remove_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len); void kvm_remove_all_breakpoints(CPUState *cpu); diff --git a/include/accel/accel-cpu-ops.h b/include/accel/accel-cpu-ops.h index 9c07a903ea0..b23a0606c7e 100644 --- a/include/accel/accel-cpu-ops.h +++ b/include/accel/accel-cpu-ops.h @@ -84,7 +84,6 @@ struct AccelOpsClass { int64_t (*get_elapsed_ticks)(void); =20 /* gdbstub hooks */ - bool (*supports_guest_debug)(void); int (*update_guest_debug)(CPUState *cpu); int (*insert_breakpoint)(CPUState *cpu, int type, vaddr addr, vaddr le= n); int (*remove_breakpoint)(CPUState *cpu, int type, vaddr addr, vaddr le= n); diff --git a/include/qemu/accel.h b/include/qemu/accel.h index 8e0c3dfe088..6f65f1cb89a 100644 --- a/include/qemu/accel.h +++ b/include/qemu/accel.h @@ -84,4 +84,6 @@ typedef struct AccelGdbConfig { bool can_reverse; } AccelGdbConfig; =20 +bool accel_supports_guest_debug(AccelState *accel); + #endif /* QEMU_ACCEL_H */ diff --git a/include/system/hvf_int.h b/include/system/hvf_int.h index 58fb865ebae..d64f4942556 100644 --- a/include/system/hvf_int.h +++ b/include/system/hvf_int.h @@ -104,11 +104,6 @@ void hvf_arch_remove_all_hw_breakpoints(void); */ int hvf_update_guest_debug(CPUState *cpu); =20 -/* - * Return whether the guest supports debugging. - */ -bool hvf_arch_supports_guest_debug(void); - bool hvf_arch_cpu_realize(CPUState *cpu, Error **errp); uint32_t hvf_arch_get_default_ipa_bit_size(void); uint32_t hvf_arch_get_max_ipa_bit_size(void); diff --git a/include/system/kvm_int.h b/include/system/kvm_int.h index 53bb0fcf180..0876aac938d 100644 --- a/include/system/kvm_int.h +++ b/include/system/kvm_int.h @@ -118,7 +118,6 @@ struct KVMState #endif int max_nested_state_len; int kvm_shadow_mem; - bool have_guest_debug; bool kernel_irqchip_allowed; bool kernel_irqchip_required; OnOffAuto kernel_irqchip_split; diff --git a/include/system/whpx-all.h b/include/system/whpx-all.h index 4022571ffff..d018e67e4f7 100644 --- a/include/system/whpx-all.h +++ b/include/system/whpx-all.h @@ -22,7 +22,4 @@ void whpx_translate_cpu_breakpoints( void whpx_arch_destroy_vcpu(CPUState *cpu); void whpx_arch_accel_class_init(ObjectClass *oc); =20 -/* called by whpx-accel-ops */ -bool whpx_arch_supports_guest_debug(void); - #endif diff --git a/accel/accel-common.c b/accel/accel-common.c index f31d68a9b78..00a400243f0 100644 --- a/accel/accel-common.c +++ b/accel/accel-common.c @@ -70,6 +70,11 @@ void accel_init_interfaces(AccelClass *ac) accel_init_cpu_interfaces(ac); } =20 +bool accel_supports_guest_debug(AccelState *accel) +{ + return accel->gdbstub.sstep_flags & SSTEP_ENABLE; +} + void accel_cpu_instance_init(CPUState *cpu) { if (cpu->cc->accel_cpu && cpu->cc->accel_cpu->cpu_instance_init) { diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-ops.c index dd2b45b7cb5..ecc0cd1b558 100644 --- a/accel/hvf/hvf-accel-ops.c +++ b/accel/hvf/hvf-accel-ops.c @@ -369,7 +369,6 @@ static void hvf_accel_ops_class_init(ObjectClass *oc, c= onst void *data) ops->remove_breakpoint =3D hvf_remove_breakpoint; ops->remove_all_breakpoints =3D hvf_remove_all_breakpoints; ops->update_guest_debug =3D hvf_update_guest_debug; - ops->supports_guest_debug =3D hvf_arch_supports_guest_debug; =20 ops->get_vcpu_stats =3D hvf_get_vcpu_stats; }; diff --git a/accel/kvm/kvm-accel-ops.c b/accel/kvm/kvm-accel-ops.c index d7967bc922f..45330327909 100644 --- a/accel/kvm/kvm-accel-ops.c +++ b/accel/kvm/kvm-accel-ops.c @@ -105,7 +105,6 @@ static void kvm_accel_ops_class_init(ObjectClass *oc, c= onst void *data) ops->synchronize_pre_loadvm =3D kvm_cpu_synchronize_pre_loadvm; ops->handle_interrupt =3D generic_handle_interrupt; =20 - ops->supports_guest_debug =3D kvm_supports_guest_debug; #ifdef TARGET_KVM_HAVE_GUEST_DEBUG ops->update_guest_debug =3D kvm_update_guest_debug_ops; ops->insert_breakpoint =3D kvm_insert_breakpoint; diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index ceb0b33abdd..b03488ebac3 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -3036,10 +3036,7 @@ static int kvm_init(AccelState *as, MachineState *ms) (kvm_check_extension(s, KVM_CAP_VM_ATTRIBUTES) > 0); =20 #ifdef TARGET_KVM_HAVE_GUEST_DEBUG - s->have_guest_debug =3D - (kvm_check_extension(s, KVM_CAP_SET_GUEST_DEBUG) > 0); - - if (s->have_guest_debug) { + if (kvm_check_extension(s, KVM_CAP_SET_GUEST_DEBUG) > 0) { as->gdbstub.sstep_flags =3D SSTEP_ENABLE; =20 int guest_debug_flags =3D @@ -3829,14 +3826,6 @@ int kvm_update_guest_debug(CPUState *cpu, unsigned l= ong reinject_trap) return data.err; } =20 -bool kvm_supports_guest_debug(void) -{ - KVMState *s =3D KVM_STATE(as); - - /* probed during kvm_init() */ - return s->have_guest_debug; -} - int kvm_insert_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len) { struct kvm_sw_breakpoint *bp; diff --git a/accel/tcg/tcg-accel-ops.c b/accel/tcg/tcg-accel-ops.c index c179cd4adeb..927af6c1db0 100644 --- a/accel/tcg/tcg-accel-ops.c +++ b/accel/tcg/tcg-accel-ops.c @@ -109,11 +109,6 @@ void tcg_handle_interrupt(CPUState *cpu, int mask) } } =20 -static bool tcg_supports_guest_debug(void) -{ - return true; -} - /* Translate GDB watchpoint type to a flags value for cpu_watchpoint_* */ static inline int xlat_gdb_type(CPUState *cpu, int gdbtype) { @@ -221,7 +216,6 @@ static void tcg_accel_ops_init(AccelClass *ac) } =20 ops->cpu_reset_hold =3D tcg_cpu_reset_hold; - ops->supports_guest_debug =3D tcg_supports_guest_debug; ops->insert_breakpoint =3D tcg_insert_breakpoint; ops->remove_breakpoint =3D tcg_remove_breakpoint; ops->remove_all_breakpoints =3D tcg_remove_all_breakpoints; diff --git a/accel/whpx/whpx-accel-ops.c b/accel/whpx/whpx-accel-ops.c index b8f41544cbe..ca5a119521a 100644 --- a/accel/whpx/whpx-accel-ops.c +++ b/accel/whpx/whpx-accel-ops.c @@ -82,11 +82,6 @@ static bool whpx_vcpu_thread_is_idle(CPUState *cpu) return !whpx_irqchip_in_kernel(); } =20 -static bool whpx_supports_guest_debug(void) -{ - return whpx_arch_supports_guest_debug(); -} - =20 static void whpx_accel_ops_class_init(ObjectClass *oc, const void *data) { @@ -96,7 +91,6 @@ static void whpx_accel_ops_class_init(ObjectClass *oc, co= nst void *data) ops->kick_vcpu_thread =3D whpx_kick_vcpu_thread; ops->cpu_thread_is_idle =3D whpx_vcpu_thread_is_idle; ops->handle_interrupt =3D generic_handle_interrupt; - ops->supports_guest_debug =3D whpx_supports_guest_debug; =20 ops->synchronize_post_reset =3D whpx_cpu_synchronize_post_reset; ops->synchronize_post_init =3D whpx_cpu_synchronize_post_init; diff --git a/gdbstub/system.c b/gdbstub/system.c index 2e8c457097b..bf7aa1ac234 100644 --- a/gdbstub/system.c +++ b/gdbstub/system.c @@ -331,8 +331,6 @@ static void create_processes(GDBState *s) gdb_create_default_process(s); } =20 -static bool gdb_supports_guest_debug(void); - bool gdbserver_start(const char *device, Error **errp) { Chardev *chr =3D NULL; @@ -345,7 +343,7 @@ bool gdbserver_start(const char *device, Error **errp) return false; } =20 - if (!gdb_supports_guest_debug()) { + if (!accel_supports_guest_debug(current_accel())) { error_setg(errp, "gdbstub: current accelerator doesn't " "support guest debugging"); return false; @@ -624,15 +622,6 @@ int gdb_signal_to_target(int sig) * Break/Watch point helpers */ =20 -static bool gdb_supports_guest_debug(void) -{ - const AccelOpsClass *ops =3D cpus_get_accel(); - if (ops->supports_guest_debug) { - return ops->supports_guest_debug(); - } - return false; -} - int gdb_breakpoint_insert(CPUState *cs, int type, vaddr addr, vaddr len) { const AccelOpsClass *ops =3D cpus_get_accel(); diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index 8b902c68829..e16457c3cfb 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -2900,8 +2900,3 @@ void hvf_arch_update_guest_debug(CPUState *cpu) =20 hvf_arch_set_traps(cpu); } - -bool hvf_arch_supports_guest_debug(void) -{ - return true; -} diff --git a/target/arm/whpx/whpx-all.c b/target/arm/whpx/whpx-all.c index 3079c6293c8..00a5de8cdc1 100644 --- a/target/arm/whpx/whpx-all.c +++ b/target/arm/whpx/whpx-all.c @@ -295,11 +295,6 @@ void whpx_translate_cpu_breakpoints( /* Breakpoints aren=E2=80=99t supported on this platform */ } =20 -bool whpx_arch_supports_guest_debug(void)=20 -{ - return false; -} - void whpx_arch_destroy_vcpu(CPUState *cpu) { /* currently empty on Arm */ diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c index 2d1a943b96c..19ad64a1d93 100644 --- a/target/i386/hvf/hvf.c +++ b/target/i386/hvf/hvf.c @@ -1066,8 +1066,3 @@ void hvf_arch_remove_all_hw_breakpoints(void) void hvf_arch_update_guest_debug(CPUState *cpu) { } - -bool hvf_arch_supports_guest_debug(void) -{ - return false; -} diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index 467ac6bed45..11b5d1fc607 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -1853,11 +1853,6 @@ void whpx_apply_breakpoints( } } =20 -bool whpx_arch_supports_guest_debug(void)=20 -{ - return true; -} - void whpx_arch_destroy_vcpu(CPUState *cpu) { X86CPU *x86cpu =3D X86_CPU(cpu); --=20 2.53.0 From nobody Sun Jul 26 11:01:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783288825; cv=none; d=zohomail.com; s=zohoarc; b=mnbEnLuf+MgXbl+wv9OEhB0VLubOuwbLMcLvcJ6d76Q0jbYHGxXXXk99eUjNKjnonDMJ4oKRRCZEPba/vnLrHFuxzRVZzStSZhrdaypOCuJbUFLarpHYbz540xKTCB07Hf9eYSAoyCkd6Ku3IRrmZ4ZlwxzPWVJJARYxmBZtXOs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783288825; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=eygAFTCQW0B87uY1lVPXWDPzg3gZxNFs2eCC7PkFP/o=; b=hTH5/rpE0bYA/9TN/6xuk5g/yAKmbtqa6K5TUvbX/IzGiigvWCr5echE+U8nmG2FZLxvciCwcmZ+myAJQPn9KsrwC7aDP9mwLtwKGfiLPAzCBdjBYckXjwA/vPnlSY1gqfBm3nkWbDfISlXEIGvdSzjsvSXbyz7Zy0NODfJnjYc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783288825203289.50989233896007; Sun, 5 Jul 2026 15:00:25 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgUss-0001s8-3O; Sun, 05 Jul 2026 18:00:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUse-00010K-Sx for qemu-devel@nongnu.org; Sun, 05 Jul 2026 18:00:07 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUsd-0000Wp-2D for qemu-devel@nongnu.org; Sun, 05 Jul 2026 18:00:04 -0400 Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 665LxKTI2868130 for ; Sun, 5 Jul 2026 21:59:51 GMT Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6s4sum7a-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 05 Jul 2026 21:59:51 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e55f0613cso183697485a.3 for ; Sun, 05 Jul 2026 14:59:51 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c63bf7efsm323538915e9.14.2026.07.05.14.59.48 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 05 Jul 2026 14:59:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= eygAFTCQW0B87uY1lVPXWDPzg3gZxNFs2eCC7PkFP/o=; b=YPv6ISWyyUpQfl8a UHfdhRQYdAdyVFANjWsNZDDqRt2LO3sUI5A8ID+3UEq0Wg8/RsE9BZQbK3fNUlL7 09hXtapHpEAt6beXKKVjhIEQ6XTaLwv8A1/aRZwGHnqCuXQ3IRjfuRbmbf2WZH6X 2Bp+3/bIaVmPQ6FZOS8ZMe/FlttfMsDVehGgvk8gE/m/sKwJOv+StJ5Z+ocC6PGq Vgnt+3TdwuHf5T86yCO6y6T3wlcyOy+Fn9A/NSgGqax2Ptj+X5oRAlCbQ5WTnl5Y xz2vygun2bLcI3eIkwqiQE3pyQLecHTkKtR7iT/YAomPCiB4AdZY+6aIut0URXU4 lDGwJQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783288791; x=1783893591; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eygAFTCQW0B87uY1lVPXWDPzg3gZxNFs2eCC7PkFP/o=; b=XZEsdnbomPKWMCMp6BGX16+M4JbdLSFuPBUzJKx17TkMee/CrBAeSiFd3g6cePcnia zDhri3vwEhKnJm6HaLDlLTEzKV9ucAUx+Pg8LNsJEswVPXGIlWwXf1b3zytsUzI86OJQ SxV2jpR0B6jg2MsDNT7de6x+BsvSVmbA+OX7vQGKHdepCFJf0mGqgXKD4ua9PGBYUi4x mtdjtzyEQSzQZWIXKjDtMsTme5+HBgiFAsO0mXRZx8grhm6znG/WxuK3ROlOquHtm+5+ t+AjmF2QwaWUSsEUTkaAk8B1l032gjhoWfmS/E34j/aOlATzbCrViYUFNbh56ZtqBltj 1HmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783288791; x=1783893591; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=eygAFTCQW0B87uY1lVPXWDPzg3gZxNFs2eCC7PkFP/o=; b=l80Oy4lIKn5D9j0INIs1n5sXqzkODpnzchJVQbg1iAaCpkogaPpUccN0xSlH6x2kyu fqr7fOkDLZKgSNwG83VI1NJP45KEsLZGqfKrtkcbUhgrz8SVRdoNG5v+ICKk91Zb4McH tdKYmvhp2dtLDX3gqot0PGJ2e0YpkQKiYOKv7RKe9WDKmJ07Ntm/EKOoeQRnWRzJbhc3 mX7vUUbDE8YXg79u6RWq1GIBjyTeFy8hVHPRvE6uOEYVTvMupvddUn8M36vxglXSr8z2 8W0CfmLLi+7kkcrCa6QtAZ90Nl7zourgCYVBO9C7Xi3WrPh1PJWzBUXFC8kBMltWwvLM PBTw== X-Gm-Message-State: AOJu0YyTZQ5GruU9E81jaElIKDPZu0vNsY6gghNGCN5DE7W3h3Q+AU8C TzwMvhivlGevtVeO3FmJ2YFXG/6SplzwzXTs1Rnvj5RNoDuXGAdtqxv8maCB1G9Dw3DkUpG3G9o IpkZX2T/PjRasWHw6lxtYc9dLPaxaD5O0S8YnmZT7yWw8XLFC9fMonTpoMNvrI5Av+w== X-Gm-Gg: AfdE7cmz+LwNJ+uQIyPRlaL5KoFBwnIMRHshHezkFqkX8a5TIXrOSnITT2iXhyn05TT 2lQD+53t8wsI/RnlTogOM21tZOy/6BuD4/Ek7OPwl3OaUDwTt6eypAutQS98ywp/JJISXDozL90 zU8Sm8vXZfDtrOqpA8rgzxB6TwtETwFYvkcovZnNzPBURI3TjGEKmUY8JVnkzx5LfhjOSigSPRv EDHIwBpXsxAXRpbsYq4G+86Ou1yFXS7ghuOWzya5Dn2qVLmhEHAjQ6hBLm5Z+TqKUjtPRCXNkgg 9joKPCqsj7XkTSj40nYJPjANJJHA3XDv3g0+ZadiuskhZrCeGc8pYGOsx6inHFUQ7Cao3Cqt4fq a2RWyLIkjy2Drm4rw33wnG4zpMi0KEYc3vkp84X8q3l8JJRdiKeud1g== X-Received: by 2002:a05:620a:19a2:b0:92b:67e6:4b71 with SMTP id af79cd13be357-92e9a526e4dmr1129631185a.72.1783288790679; Sun, 05 Jul 2026 14:59:50 -0700 (PDT) X-Received: by 2002:a05:620a:19a2:b0:92b:67e6:4b71 with SMTP id af79cd13be357-92e9a526e4dmr1129628885a.72.1783288790272; Sun, 05 Jul 2026 14:59:50 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , alex.bennee@linaro.org, qemu-s390x@nongnu.org, Magnus Kulke , Zhao Liu , qemu-ppc@nongnu.org, Paolo Bonzini , Xiaoyao Li , Richard Henderson , Mohamed Mediouni , Peter Maydell Subject: [PATCH v3 18/32] cpu: Move cpu_breakpoint_test out of line Date: Sun, 5 Jul 2026 23:57:14 +0200 Message-ID: <20260705215729.62196-19-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260705215729.62196-1-philmd@oss.qualcomm.com> References: <20260705215729.62196-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfX3ebGV0g4sfSk 2Zv/4O326WLM+4+iLe8qk3Z72Llqjk8qtjdJ3EPWc65jeBAg59RFXf2JduBgPQTMz3YMmfA7caj vvkA+VA4pNwT/Zh7ft+VvBMY0glvylY= X-Proofpoint-ORIG-GUID: 2EUr2lUc2DjJSWhnvqPkFg-uO2Cr-Xjr X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfX36DC299PlZW5 EIavGCpC0NhDHFjouxs+NDoaxgb1fKf2vTNSU6vKTIA5/6HETSrdhjOXN72LYNCq2jVspFmy/pd wpUZD19JeTlryLJ38qhB/ujmxZbQJQbyIxbOnmOjh3xUHhBFN6j8mgTFmgml0AhgqBanAmCxZQ3 R3Oc5Oh5hmRTvtLbTeaLSfJlZBPxpU6WE4arXwCJOJlA0B4R2ctNyNQZ7bXGPPmif/up8qqerJr cFB1Kn0B3jzJuaWQqOqcqiiFZz2Lf5Y4ev+fhF329x81O+MLBT1/xZ+SiTUX+oNA3cs8j1SPPga 0PT9wPak5bzF6Hx6NvtDpHafcFRBfeOCR83gX7he6JNa+uWjbeQkX0ejBxe8sx0gFs4nKAPxTPh M9WmY5AOvI2MbQCvixrLtD1qpzNwZ5eDniBSvYMOETluEWFpg4omBRk8icdj47JJz16lDMXsbp8 GwraxUuAjrYKaOCr6Mw== X-Proofpoint-GUID: 2EUr2lUc2DjJSWhnvqPkFg-uO2Cr-Xjr X-Authority-Analysis: v=2.4 cv=ZfQt8MVA c=1 sm=1 tr=0 ts=6a4ad3d7 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=f0gnTpezwqI1Ju9rGxMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_02,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 adultscore=0 phishscore=0 priorityscore=1501 clxscore=1015 suspectscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607050238 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783288826669158500 From: Richard Henderson Move the function to cpu-common.c, with the other breakpoint functions. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/core/cpu.h | 16 +--------------- cpu-common.c | 15 +++++++++++++++ 2 files changed, 16 insertions(+), 15 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 60a23d6f38b..31753f331fb 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -1157,21 +1157,7 @@ int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, i= nt flags, int cpu_breakpoint_remove(CPUState *cpu, vaddr pc, int flags); void cpu_breakpoint_remove_by_ref(CPUState *cpu, CPUBreakpoint *breakpoint= ); void cpu_breakpoint_remove_all(CPUState *cpu, int mask); - -/* Return true if PC matches an installed breakpoint. */ -static inline bool cpu_breakpoint_test(CPUState *cpu, vaddr pc, int mask) -{ - CPUBreakpoint *bp; - - if (unlikely(!QTAILQ_EMPTY(&cpu->breakpoints))) { - QTAILQ_FOREACH(bp, &cpu->breakpoints, entry) { - if (bp->pc =3D=3D pc && (bp->flags & mask)) { - return true; - } - } - } - return false; -} +bool cpu_breakpoint_test(CPUState *cpu, vaddr pc, int mask); =20 /** * cpu_get_address_space: diff --git a/cpu-common.c b/cpu-common.c index 988d057d844..adb76b3a786 100644 --- a/cpu-common.c +++ b/cpu-common.c @@ -388,6 +388,21 @@ void process_queued_cpu_work(CPUState *cpu) qemu_cond_broadcast(&qemu_work_cond); } =20 +/* Return true if PC matches an installed breakpoint. */ +bool cpu_breakpoint_test(CPUState *cpu, vaddr pc, int mask) +{ + CPUBreakpoint *bp; + + if (unlikely(!QTAILQ_EMPTY(&cpu->breakpoints))) { + QTAILQ_FOREACH(bp, &cpu->breakpoints, entry) { + if (bp->pc =3D=3D pc && (bp->flags & mask)) { + return true; + } + } + } + return false; +} + /* Add a breakpoint. */ int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, int flags, CPUBreakpoint **breakpoint) --=20 2.53.0 From nobody Sun Jul 26 11:01:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783288921; cv=none; d=zohomail.com; s=zohoarc; b=ZYbZx3Ihnv3zrk93LWufMVNYoedjykfmhCCY6AWeqPOdHadjf6Xm4MAmF8RdStVzwKP62YVvqfoE1sJKEn2dcnHINxYC9N5tt7cAZ4yBUXuIkxshkfAbqTFwy7rlyh1xOigDLOjNNC21ZbnAHCYISNA+xsBQWahM1gxeXEvdCt4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783288921; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=7tIMKNTooY0mWH2w8clXt9i3UzLCWRfh1sTC8E6MetQ=; b=KIVtGWuj/HU4q7T7m+l8iVuTVzDk3oVYjbLSINlaUjLHs9Gmcfbw13RwUkKgrD8w4lxn/e3COmbfRNIxuyRfyA/jk1aX0usLhJs5E9mpqjcetL8zbnklaxgSDKM5XWS2WfJWLqMC59wG0//UfrSwB8ae4It9kf4xmiK3hd1UVkQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783288921017829.03246432987; Sun, 5 Jul 2026 15:02:01 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgUsu-00023e-Bb; Sun, 05 Jul 2026 18:00:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUsm-0001RW-NP for qemu-devel@nongnu.org; Sun, 05 Jul 2026 18:00:12 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUsk-0000Zl-Hh for qemu-devel@nongnu.org; Sun, 05 Jul 2026 18:00:12 -0400 Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 665LxdBZ2859781 for ; Sun, 5 Jul 2026 21:59:59 GMT Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6td3bgn2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 05 Jul 2026 21:59:59 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51c21c01cf3so56218301cf.2 for ; Sun, 05 Jul 2026 14:59:59 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa0f214d2sm18740971f8f.33.2026.07.05.14.59.56 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 05 Jul 2026 14:59:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7tIMKNTooY0mWH2w8clXt9i3UzLCWRfh1sTC8E6MetQ=; b=Q1Ujnq5FSORn2Sew svcJmVpOgWKceSNVN3d8+LffMklURs1WxhlyxnCZNxks807gXXyC/VPP8OoJvVv0 CX6SNJ6cJbKP4i680b1LfxBI0ME+4QmVnnbd4TeoHBJtc3ne/qaVdz5Z/4lacPQD JvG1o58pJlouQdTSwAyNVblVN+jI/MBO/CwX3wuJAWzDMUxOl8HhV35TbDoC2Vtr brHW1dQ1U2Z1xlJUQ5M7vZapbAIL7jgjyVj1mDa0MvPpp3kfXpN7ikYpkyUylxUZ tDwSvbEZDecagDLXUya06gv5eYpTb1dspHNgFukDb7LBieEFhnBcrKvnFAwjyRnW KdSV7A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783288798; x=1783893598; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=7tIMKNTooY0mWH2w8clXt9i3UzLCWRfh1sTC8E6MetQ=; b=LbxHU5HATaXIAlVZBqiKtr/FsPP9YRt7OoyJxRy+WYug4rxIXDa4y6cxtwv6CaVEdV ZceN+SC6Cz4Elgam6glB1//JyXf+V1ek1SzSd/8i2wdHydgAs8xNh9bTDHPRGAgkYVZC gORLC1dKl+W4WX41CGZ9ub6DjxYQ74ncKn3gnNG4tCXOMgmpk1rwtB5/Q2fGqPQg/Zzv WIDSeuhF14j084wlXMRCO5zMsNQGz4lYXgzcGm+H1MmeCh9qskke/V4p/tUGD4LarKZh 1XQojX7q26O0FirJkvP0LnxcHlgxfBfM6EPYDFwT5Jc8ztUjUS5e6hAcfic0m+9YjibA ssqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783288798; x=1783893598; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7tIMKNTooY0mWH2w8clXt9i3UzLCWRfh1sTC8E6MetQ=; b=DVGgdboNm3R4CJFD9mbBG2NJW9BjrreBWxF+y2SJD8I8g99AJy2BZfFWjNHIqvVxbT yO5EqBGHxQljjdUy7xNYrCF0Xf8BvliJtnIEqW5LbjefMYPIoOYs8DIdldrgztkeRJcT 20Z9cPeboQEqml78zJHt+Kz2TufCSuTFdUDVnDaWupOwXrvQMYwDCkfqNjKV7ZSA76LS H2T26rkWSNdEfC+utphKU3Lha3OgEA1uflbSCWFxK5jy3/gCw9Nf7Hb0A5v9PgIsgp+K bBviKZDF0IKwFU4VdOFICwgr1V2cfu1E0xWc3YSsGqXEq7m/TvvQwUfNhuN8exZeoIq5 10rg== X-Gm-Message-State: AOJu0YwTOkuelEohIlt0Pg26jeEeTQHv94weiWiaBzP76iocRG8W7Ny6 E0bnHO+d2kXOx7UxMXmk0HoJdPLIrEIrmR9Vzbxjei6H23g40exXI/rhFTQMPMQ+O6hEZEIn/UF dck8KYOTTFhr4syroPnq1ajr9MOX7xjNf1NtcWxETMM01OofzEonB/ZEqWJjr/cmwxw== X-Gm-Gg: AfdE7ckDCiZ/7mQCc5fk7nE2Ie15ktDgWhYZSRyODyKgZMDck9NSSenSOwyvFZ/BIj5 zgGbpjtLDSNx1NbOVA16ffUlEa/47e7pOw+Sbt9LPHD5KxLQUgC2Q/AzkHhY5cyRyynVLLtCpTT VWo7KdDImVLxnXtbzzyPh2Olzjd409+O7gA1RVy8heuXYq4gnLFR0a+oFzP+Ry1OPuVFFw4d0dN TUDlSuSC2LaT/mA/zSXJaIV5KdV5kTvPIA6ErOp6lfMz2fQtLebPMqGv+qYjdGaTMNJrWvu9bMd L+mhQ1cNhWuaaEfbS6LuySC2dfdZQBcFkeVgLIdwzLq7ptASfwK2Jk3ckLPhTzF7fqeVxCd/Eyt v5UMCPL5V9eTEeIAI761DPezcnCL5UjiyubCm/O1QLeh12iWV67Gllg== X-Received: by 2002:a05:622a:3:b0:517:5e3e:526f with SMTP id d75a77b69052e-51c4c2daac9mr114273261cf.52.1783288798236; Sun, 05 Jul 2026 14:59:58 -0700 (PDT) X-Received: by 2002:a05:622a:3:b0:517:5e3e:526f with SMTP id d75a77b69052e-51c4c2daac9mr114273071cf.52.1783288797864; Sun, 05 Jul 2026 14:59:57 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , alex.bennee@linaro.org, qemu-s390x@nongnu.org, Magnus Kulke , Zhao Liu , qemu-ppc@nongnu.org, Paolo Bonzini , Xiaoyao Li , Richard Henderson , Mohamed Mediouni , Peter Maydell Subject: [PATCH v3 19/32] cpu: Move BREAKPOINT definitions to 'exec/breakpoint.h' Date: Sun, 5 Jul 2026 23:57:15 +0200 Message-ID: <20260705215729.62196-20-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260705215729.62196-1-philmd@oss.qualcomm.com> References: <20260705215729.62196-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfX2mLmQYL4GCq4 Ii5c/kqyTjMtLGO8rC7ouD73ak30BkoxlTt+7hU6fAdMqP+sgjKiriWARGfilYkeh3F/dt+KVl2 2DcZwNSCdPpD5HBMPUKIDkZ+khEPOAM= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfX8nQTLixUo+Iq g4mDwc343FzEffGQ3V8uu/b+4jwJ790Kf//sW1rDaraPOT8IXMLhXsLCmRRupUQSoZ9O5QcisPP +BzKh6GH5aIAOlfC603XdEXYRXu3py1eIT5/CmI5Wp24lUmWSU9RHraS4AGXt6AWcVxFVbbE8Sx 5/i+Q60y0uoq4sk00oeI7jgdV5SI5rm6XGeNvcGvw5BAfuy81PVW4YXGKqb1oUTikw24hvPFjyK sXnnw3WnLy5nNp6HnWcb2ZAc0iE94BJ1MjPSR+Vcomo6x6NyrjgvW/p8urVyB2j7N85QCd7nQEH jRXMpV9v1JAzdJ3Rcf13f6NFv+n/Fqb7hyp2OpJ73q/Dv+BN/LB3fi03Tq9vG0MTqvHACso29xL iW6L58TgGC9oO5pNqx91gm7v1DNf/+kljNhxJRSOMCjOdB37Ltuy9nyDky5Rs2GqlGYqPcA82ya jXvkZy3jzT+ZOvrnbQQ== X-Proofpoint-GUID: cemb0za5ci7FoSHRmdHSgqFBWc6jW4u- X-Proofpoint-ORIG-GUID: cemb0za5ci7FoSHRmdHSgqFBWc6jW4u- X-Authority-Analysis: v=2.4 cv=b9GCJNGx c=1 sm=1 tr=0 ts=6a4ad3df cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=yZPQLu4l72ctXTxYlJYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_02,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 spamscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 malwarescore=0 adultscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607050238 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783288923048158500 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- include/exec/breakpoint.h | 14 ++++++++++++++ include/hw/core/cpu.h | 14 -------------- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/include/exec/breakpoint.h b/include/exec/breakpoint.h index 95f0482e6d0..cc6fedd09fe 100644 --- a/include/exec/breakpoint.h +++ b/include/exec/breakpoint.h @@ -12,6 +12,20 @@ #include "exec/vaddr.h" #include "exec/memattrs.h" =20 +/* Breakpoint/watchpoint flags */ +#define BP_MEM_READ 0x01 +#define BP_MEM_WRITE 0x02 +#define BP_MEM_ACCESS (BP_MEM_READ | BP_MEM_WRITE) +#define BP_STOP_BEFORE_ACCESS 0x04 +/* 0x08 currently unused */ +#define BP_GDB 0x10 +#define BP_CPU 0x20 +#define BP_ANY (BP_GDB | BP_CPU) +#define BP_HIT_SHIFT 6 +#define BP_WATCHPOINT_HIT_READ (BP_MEM_READ << BP_HIT_SHIFT) +#define BP_WATCHPOINT_HIT_WRITE (BP_MEM_WRITE << BP_HIT_SHIFT) +#define BP_WATCHPOINT_HIT (BP_MEM_ACCESS << BP_HIT_SHIFT) + typedef struct CPUBreakpoint { vaddr pc; int flags; /* BP_* */ diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 31753f331fb..e5b68bced3d 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -1138,20 +1138,6 @@ void qemu_init_vcpu(CPUState *cpu); */ void cpu_single_step(CPUState *cpu, int enabled); =20 -/* Breakpoint/watchpoint flags */ -#define BP_MEM_READ 0x01 -#define BP_MEM_WRITE 0x02 -#define BP_MEM_ACCESS (BP_MEM_READ | BP_MEM_WRITE) -#define BP_STOP_BEFORE_ACCESS 0x04 -/* 0x08 currently unused */ -#define BP_GDB 0x10 -#define BP_CPU 0x20 -#define BP_ANY (BP_GDB | BP_CPU) -#define BP_HIT_SHIFT 6 -#define BP_WATCHPOINT_HIT_READ (BP_MEM_READ << BP_HIT_SHIFT) -#define BP_WATCHPOINT_HIT_WRITE (BP_MEM_WRITE << BP_HIT_SHIFT) -#define BP_WATCHPOINT_HIT (BP_MEM_ACCESS << BP_HIT_SHIFT) - int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, int flags, CPUBreakpoint **breakpoint); int cpu_breakpoint_remove(CPUState *cpu, vaddr pc, int flags); --=20 2.53.0 From nobody Sun Jul 26 11:01:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783288840; cv=none; d=zohomail.com; s=zohoarc; b=eQ/e9+XLPGRJyM0bspCfkrGreY+oJKVZfI5wT7Q0WwwafsfCTEgSl1o2a4apep75ITSWYKgKo+kDuht2AW0RSlebtwbJcMlq1TYhf8ASfktcbVfISHmhtdO1AOzUTo/FjyM/gK8bniUoc+l0BV/LehGceiOWiT/BIYHCP9NXZ/A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783288840; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=9YGlg+mPK/G4Lup+1r6dhGmTDLQgqMwqglzQRkQrzaQ=; b=jh/4qiToJDCCE2dfJaaiuCSkN78C/KuXuUIvTXkAKk92Jl1X6g+s+B0SwMKRAqRLPlxGTrlWTckkqsifoz+Br/iabWoqYAv22sAsrb4F5lkLHONOugZMn7ENraGEYiGSwKAsxm/6xiao7FBJy6KirEtl5dSnNtENXs+1mX9IOvk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783288840885802.2504575421212; Sun, 5 Jul 2026 15:00:40 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgUsy-0002Qx-CH; Sun, 05 Jul 2026 18:00:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUsx-0002KR-0e for qemu-devel@nongnu.org; Sun, 05 Jul 2026 18:00:23 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUst-0000ne-7a for qemu-devel@nongnu.org; Sun, 05 Jul 2026 18:00:22 -0400 Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 665LxXrY2716361 for ; Sun, 5 Jul 2026 22:00:07 GMT Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6txekdwu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 05 Jul 2026 22:00:07 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92e538afe65so228442785a.3 for ; Sun, 05 Jul 2026 15:00:07 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47a9e4d6e4csm17623961f8f.10.2026.07.05.15.00.03 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 05 Jul 2026 15:00:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 9YGlg+mPK/G4Lup+1r6dhGmTDLQgqMwqglzQRkQrzaQ=; b=kywjaGvYD4ucWh8D uiTLWwUioHpkHJAUlbnoGqrsSb3saCxXuaBSahtT6ENBzzS0escR1IzkP6teeBk3 BXgZvAsV446/99zKA28jUpS/mYBj3DFzXl3t6S9yeRHncsOTCTj4Yw17iljYPjsl FC2pPkq7yzRasDMrzfOwenfp5TBkLSDeqkOy6wiRFTHC8em5p1X14XTy37yUAD4y exABJZ3pv+/XncqUEnwGOe7tStcfXRAfyRvjkU/Dg/YgM9S3MGKJ9yrq+lyie0NG aUmmIA5uImSzh0EEjEI0CTLNX9amxFw5ipC7fMMA1hqodJmhtXmmdFjH48krUvjo mkxFHA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783288806; x=1783893606; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9YGlg+mPK/G4Lup+1r6dhGmTDLQgqMwqglzQRkQrzaQ=; b=fdSrULbCgDK0cbZ92VIMkKK9MRUS1ltbRwm5Aa7T0kXSz0AWqSg0a2Wi1apG1ibQYH z0kQiO3fY2XhEBZFvDREdUiXTtbMpJqCUoulkxXstGGxeMQFd6pcz4sVbdUS9wqBdxwY Vtc9XmbLxAasy51J8PmBQQ+ccwKZ5v7KqEwtFgk9+ZKJGkUNkQpFLg0N8EQR6H3QvxpU A0MlkBZUocIq9++K20094I3H2a8/QhGdxBxdE7oXkpSaOKw3lp+730VTGPsS+XeT+vze 9sPaUfgXFBl3/x67T7jE83ESQWkAoYWOyvGAy9U9o3tHwHCeUiMn4bI6DF8V+xdPxnmN 0qUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783288806; x=1783893606; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=9YGlg+mPK/G4Lup+1r6dhGmTDLQgqMwqglzQRkQrzaQ=; b=I22Oj+lpPr7cI/1UbkMRFMPKF5mwfMdq2Rp/L7/+KQIIDa51xz3WV3PNkTXT+ffZTn nb7r5X67IX5KL0Gi4crJ6JaHXepZCAsRASqSx9FYjZ7vsE668vtG2NPrwtVtEjd2wRyx g7N4Vpo4K7fZ70Fykd31sCC55JzpvItOGg5Q2V6Kkzojq2OQEQdPFE2HqPWW++r+zwPl IIecmGdDThqguEC6MX0EDG57kbkiyxs60pM6p048u+nxki1DsK3JHVhxxv0OkhObgEPI AfUeErMMa4pEOTqxVkal/3/h85/0yuxJQKl+J/aCkDo9RAdhQF1dBjT/7BR8hLnOF4TF zClw== X-Gm-Message-State: AOJu0YyWQEYLk70j4mkZJZDzbiZZiqUAk42cmlLrVMmpAyoJIx2B0PTE PetkiwQdBLBlF8dZtzCP0o/kwVNLvfPXF0C5YWLaM+xC9tuKA3BVQ4bcG8ZTX8V8iSvgw7IDyDJ wWaRDM2/qRhNmAwmDRYluEYbM9lw3yV5sllFOXVrsEKGHSyiKfxPZPoOurSrEmW+W1Q== X-Gm-Gg: AfdE7clslHrvIwlPFKE5YZTWaDosNI/GVH8LhCg7hwvYImrikLxND+g5M8VLjU99FaS AKaujkQkSK1Mlvc1j3TJDKWfTRPUIwz2BIuCf8efgwDbSmdfDH11g7IUDa3eer2bjM2RiFsq9D5 KKdc+sfSsGizDkOLjGB7NEI/wIUutAwl5h0+3TDKnlhaHrEuRCZ70vhBFBdmu/JlwBqa2u5VHr0 JoosBN8+1pIsaaFaTCth6S4khu4hxqKK3TVC1hGjhsV7cwMGTRmayNEuF97CNvL8VMNFtRE3uj6 4OO7+4kAiIMay1OYot6/vg7FrdRma1zutjvHRITe7+Tq+iTRv3N5YozbHH45Ha1N4UiUlZVp9xX JfIaxk6DtcKj4SnSRpB472QMTqo/BpzWZqPordKGTKtS4I8X6r3LwFw== X-Received: by 2002:a05:620a:1791:b0:92e:6bbf:9686 with SMTP id af79cd13be357-92e9a3447f2mr1051438285a.3.1783288806035; Sun, 05 Jul 2026 15:00:06 -0700 (PDT) X-Received: by 2002:a05:620a:1791:b0:92e:6bbf:9686 with SMTP id af79cd13be357-92e9a3447f2mr1051430785a.3.1783288805293; Sun, 05 Jul 2026 15:00:05 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , alex.bennee@linaro.org, qemu-s390x@nongnu.org, Magnus Kulke , Zhao Liu , qemu-ppc@nongnu.org, Paolo Bonzini , Xiaoyao Li , Richard Henderson , Mohamed Mediouni , Peter Maydell Subject: [PATCH v3 20/32] cpu: Define BreakpointFlags type Date: Sun, 5 Jul 2026 23:57:16 +0200 Message-ID: <20260705215729.62196-21-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260705215729.62196-1-philmd@oss.qualcomm.com> References: <20260705215729.62196-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfXySYH0PwvwTSd jt79luKXa8VuA9qPRgZ97Y6ebOB1YzIO1gRkvzahFrGj42fEdHmOAougOcXYPzC6el1UmAYPp84 GIpQl1IL9NmgfaZUYy6c3UOLOA1BXNw= X-Proofpoint-GUID: NZ0_R9onHy9CletoCQxXlKBKa1voYpL5 X-Proofpoint-ORIG-GUID: NZ0_R9onHy9CletoCQxXlKBKa1voYpL5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfX2E/zKUHZbSw4 gK0mqGFbegkwdGYy8v2FZAqwX3eU8V5igdJPdod6h6m3pATAf/ZfppciBYq0qP3V1RoqzTJf9Ie nVn/vYoPmfFNIxVNZSsfUPmIH2JMxtYqWDpGOYmHExr/CfK8z9yOyxMnNlpkp6U44Z5jzuNAow/ QiVF+B1GEnlbi1dydmr3uxTxqiO0/ZqCPI22YwthY4A5xzpnPG6Fz6M8AByFPGe80RhPXJB5wUK yXMrrt/3S8eH/OcUKayX9s292v5EUkBiW24aqlDA72XBHNUgGjRw3BeDSVw11BN186BWBBCGWFr /0w7AXM+ivWr9IrcicypF+ccbzoGtEOBR5yibQg7uH9Ep3o7HF7eidWw7trosJ8wRae7E34UpP4 9ETWSqQbtwSPYfplGQ7fh1yfCCnju94tzOwtfBFTISvf4Uu9CNNcoWAFfGmBrupjVSORP32D4pg fn1QU2+teU9lBaV6ewQ== X-Authority-Analysis: v=2.4 cv=HLLz0Itv c=1 sm=1 tr=0 ts=6a4ad3e7 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=zN_aOwrYBTen-624FaYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_02,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 clxscore=1015 suspectscore=0 impostorscore=0 phishscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607050238 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783288842791158500 Use the BreakpointFlags typedef to better follow when we deal with breakpoint flags (BP_*). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- include/accel/tcg/cpu-ops.h | 6 ++++-- include/exec/breakpoint.h | 5 +++-- include/exec/watchpoint.h | 6 ++++-- include/hw/core/cpu.h | 4 ++-- accel/tcg/cputlb.c | 12 +++++++----- accel/tcg/tcg-accel-ops.c | 10 +++++----- accel/tcg/user-exec-stub.c | 9 +++++---- accel/tcg/watchpoint.c | 9 +++++---- cpu-common.c | 4 ++-- system/watchpoint.c | 4 ++-- target/arm/tcg/debug.c | 4 ++-- target/arm/tcg/mte_helper.c | 3 ++- target/ppc/cpu.c | 2 +- target/ppc/kvm.c | 5 +++-- target/riscv/cpu_helper.c | 2 +- target/riscv/debug.c | 12 +++++------- target/s390x/tcg/debug.c | 3 ++- target/xtensa/dbg_helper.c | 2 +- 18 files changed, 56 insertions(+), 46 deletions(-) diff --git a/include/accel/tcg/cpu-ops.h b/include/accel/tcg/cpu-ops.h index 710da12b828..f64d94b2b50 100644 --- a/include/accel/tcg/cpu-ops.h +++ b/include/accel/tcg/cpu-ops.h @@ -298,7 +298,8 @@ struct TCGCPUOps { * specified by @flags. Exit via exception with a hit. */ void cpu_check_watchpoint(CPUState *cpu, vaddr addr, vaddr len, - MemTxAttrs attrs, int flags, uintptr_t ra); + MemTxAttrs attrs, BreakpointFlags flags, + uintptr_t ra); =20 /** * cpu_watchpoint_address_matches: @@ -309,7 +310,8 @@ void cpu_check_watchpoint(CPUState *cpu, vaddr addr, va= ddr len, * Return the watchpoint flags that apply to [addr, addr+len). * If no watchpoint is registered for the range, the result is 0. */ -int cpu_watchpoint_address_matches(CPUState *cpu, vaddr addr, vaddr len); +BreakpointFlags cpu_watchpoint_address_matches(CPUState *cpu, + vaddr addr, vaddr len); =20 /* * Common pointer_wrap implementations. diff --git a/include/exec/breakpoint.h b/include/exec/breakpoint.h index cc6fedd09fe..8ea7147f8c5 100644 --- a/include/exec/breakpoint.h +++ b/include/exec/breakpoint.h @@ -12,6 +12,7 @@ #include "exec/vaddr.h" #include "exec/memattrs.h" =20 +typedef int BreakpointFlags; /* Breakpoint/watchpoint flags */ #define BP_MEM_READ 0x01 #define BP_MEM_WRITE 0x02 @@ -28,7 +29,7 @@ =20 typedef struct CPUBreakpoint { vaddr pc; - int flags; /* BP_* */ + BreakpointFlags flags; QTAILQ_ENTRY(CPUBreakpoint) entry; } CPUBreakpoint; =20 @@ -37,7 +38,7 @@ typedef struct CPUWatchpoint { vaddr len; vaddr hitaddr; MemTxAttrs hitattrs; - int flags; /* BP_* */ + BreakpointFlags flags; QTAILQ_ENTRY(CPUWatchpoint) entry; } CPUWatchpoint; =20 diff --git a/include/exec/watchpoint.h b/include/exec/watchpoint.h index c4d069425ba..47f2ad751a4 100644 --- a/include/exec/watchpoint.h +++ b/include/exec/watchpoint.h @@ -8,10 +8,12 @@ #ifndef EXEC_WATCHPOINT_H #define EXEC_WATCHPOINT_H =20 +#include "exec/breakpoint.h" + int cpu_watchpoint_insert(CPUState *cpu, vaddr addr, vaddr len, - int flags, CPUWatchpoint **watchpoint); + BreakpointFlags flags, CPUWatchpoint **watchpoin= t); int cpu_watchpoint_remove(CPUState *cpu, vaddr addr, - vaddr len, int flags); + vaddr len, BreakpointFlags flags); void cpu_watchpoint_remove_by_ref(CPUState *cpu, CPUWatchpoint *watchpoint= ); void cpu_watchpoint_remove_all(CPUState *cpu, int mask); =20 diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index e5b68bced3d..e70cd8239fb 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -1138,9 +1138,9 @@ void qemu_init_vcpu(CPUState *cpu); */ void cpu_single_step(CPUState *cpu, int enabled); =20 -int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, int flags, +int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, BreakpointFlags flags, CPUBreakpoint **breakpoint); -int cpu_breakpoint_remove(CPUState *cpu, vaddr pc, int flags); +int cpu_breakpoint_remove(CPUState *cpu, vaddr pc, BreakpointFlags flags); void cpu_breakpoint_remove_by_ref(CPUState *cpu, CPUBreakpoint *breakpoint= ); void cpu_breakpoint_remove_all(CPUState *cpu, int mask); bool cpu_breakpoint_test(CPUState *cpu, vaddr pc, int mask); diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c index 7f7c208ba12..e2911e3aac6 100644 --- a/accel/tcg/cputlb.c +++ b/accel/tcg/cputlb.c @@ -1033,7 +1033,8 @@ void tlb_set_page_full(CPUState *cpu, int mmu_idx, CPUTLBEntry *te, tn; hwaddr iotlb, xlat, sz, paddr_page; vaddr addr_page; - int asidx, wp_flags, prot; + int asidx, prot; + BreakpointFlags wp_flags; bool is_ram, is_romd; =20 assert_cpu_is_self(cpu); @@ -1499,8 +1500,8 @@ void *probe_access(CPUArchState *env, vaddr addr, int= size, if (unlikely(flags & (TLB_NOTDIRTY | TLB_WATCHPOINT))) { /* Handle watchpoints. */ if (flags & TLB_WATCHPOINT) { - int wp_access =3D (access_type =3D=3D MMU_DATA_STORE - ? BP_MEM_WRITE : BP_MEM_READ); + BreakpointFlags wp_access =3D (access_type =3D=3D MMU_DATA_STO= RE + ? BP_MEM_WRITE : BP_MEM_READ); cpu_check_watchpoint(env_cpu(env), addr, size, full->attrs, wp_access, retaddr); } @@ -1702,7 +1703,8 @@ static void mmu_watch_or_dirty(CPUState *cpu, MMULook= upPageData *data, =20 /* On watchpoint hit, this will longjmp out. */ if (flags & TLB_WATCHPOINT) { - int wp =3D access_type =3D=3D MMU_DATA_STORE ? BP_MEM_WRITE : BP_M= EM_READ; + BreakpointFlags wp =3D access_type =3D=3D MMU_DATA_STORE ? BP_MEM_= WRITE + : BP_MEM_READ; cpu_check_watchpoint(cpu, addr, size, full->attrs, wp, ra); flags &=3D ~TLB_WATCHPOINT; } @@ -1885,7 +1887,7 @@ static void *atomic_mmu_lookup(CPUState *cpu, vaddr a= ddr, MemOpIdx oi, } =20 if (unlikely(tlb_addr & TLB_WATCHPOINT)) { - int wp_flags =3D 0; + BreakpointFlags wp_flags =3D 0; =20 if (full->slow_flags[MMU_DATA_STORE] & TLB_WATCHPOINT) { wp_flags |=3D BP_MEM_WRITE; diff --git a/accel/tcg/tcg-accel-ops.c b/accel/tcg/tcg-accel-ops.c index 927af6c1db0..26d34c72d9a 100644 --- a/accel/tcg/tcg-accel-ops.c +++ b/accel/tcg/tcg-accel-ops.c @@ -110,20 +110,20 @@ void tcg_handle_interrupt(CPUState *cpu, int mask) } =20 /* Translate GDB watchpoint type to a flags value for cpu_watchpoint_* */ -static inline int xlat_gdb_type(CPUState *cpu, int gdbtype) +static inline BreakpointFlags xlat_gdb_type(CPUState *cpu, int gdbtype) { - static const int xlat[] =3D { + static const BreakpointFlags xlat[] =3D { [GDB_WATCHPOINT_WRITE] =3D BP_GDB | BP_MEM_WRITE, [GDB_WATCHPOINT_READ] =3D BP_GDB | BP_MEM_READ, [GDB_WATCHPOINT_ACCESS] =3D BP_GDB | BP_MEM_ACCESS, }; =20 - int cputype =3D xlat[gdbtype]; + BreakpointFlags cpuflags =3D xlat[gdbtype]; =20 if (cpu->cc->gdb_stop_before_watchpoint) { - cputype |=3D BP_STOP_BEFORE_ACCESS; + cpuflags |=3D BP_STOP_BEFORE_ACCESS; } - return cputype; + return cpuflags; } =20 static int tcg_insert_breakpoint(CPUState *cs, int type, vaddr addr, vaddr= len) diff --git a/accel/tcg/user-exec-stub.c b/accel/tcg/user-exec-stub.c index 28286e11a60..6cfb317ed0f 100644 --- a/accel/tcg/user-exec-stub.c +++ b/accel/tcg/user-exec-stub.c @@ -22,13 +22,13 @@ void cpu_exec_reset_hold(CPUState *cpu) } =20 int cpu_watchpoint_insert(CPUState *cpu, vaddr addr, vaddr len, - int flags, CPUWatchpoint **watchpoint) + BreakpointFlags flags, CPUWatchpoint **watchpoin= t) { return -ENOSYS; } =20 int cpu_watchpoint_remove(CPUState *cpu, vaddr addr, - vaddr len, int flags) + vaddr len, BreakpointFlags flags) { return -ENOSYS; } @@ -41,13 +41,14 @@ void cpu_watchpoint_remove_all(CPUState *cpu, int mask) { } =20 -int cpu_watchpoint_address_matches(CPUState *cpu, vaddr addr, vaddr len) +BreakpointFlags cpu_watchpoint_address_matches(CPUState *cpu, + vaddr addr, vaddr len) { return 0; } =20 void cpu_check_watchpoint(CPUState *cpu, vaddr addr, vaddr len, - MemTxAttrs atr, int fl, uintptr_t ra) + MemTxAttrs atr, BreakpointFlags flags, uintptr_t= ra) { } =20 diff --git a/accel/tcg/watchpoint.c b/accel/tcg/watchpoint.c index c75ed278459..5ea66e9763a 100644 --- a/accel/tcg/watchpoint.c +++ b/accel/tcg/watchpoint.c @@ -52,10 +52,11 @@ static inline bool watchpoint_address_matches(CPUWatchp= oint *wp, } =20 /* Return flags for watchpoints that match addr + prot. */ -int cpu_watchpoint_address_matches(CPUState *cpu, vaddr addr, vaddr len) +BreakpointFlags cpu_watchpoint_address_matches(CPUState *cpu, + vaddr addr, vaddr len) { CPUWatchpoint *wp; - int ret =3D 0; + BreakpointFlags ret =3D 0; =20 QTAILQ_FOREACH(wp, &cpu->watchpoints, entry) { if (watchpoint_address_matches(wp, addr, len)) { @@ -67,7 +68,7 @@ int cpu_watchpoint_address_matches(CPUState *cpu, vaddr a= ddr, vaddr len) =20 /* Generate a debug exception if a watchpoint has been hit. */ void cpu_check_watchpoint(CPUState *cpu, vaddr addr, vaddr len, - MemTxAttrs attrs, int flags, uintptr_t ra) + MemTxAttrs attrs, BreakpointFlags flags, uintptr= _t ra) { CPUWatchpoint *wp; =20 @@ -91,7 +92,7 @@ void cpu_check_watchpoint(CPUState *cpu, vaddr addr, vadd= r len, =20 assert((flags & ~BP_MEM_ACCESS) =3D=3D 0); QTAILQ_FOREACH(wp, &cpu->watchpoints, entry) { - int hit_flags =3D wp->flags & flags; + BreakpointFlags hit_flags =3D wp->flags & flags; =20 if (hit_flags && watchpoint_address_matches(wp, addr, len)) { if (replay_running_debug()) { diff --git a/cpu-common.c b/cpu-common.c index adb76b3a786..600cd56dd0e 100644 --- a/cpu-common.c +++ b/cpu-common.c @@ -404,7 +404,7 @@ bool cpu_breakpoint_test(CPUState *cpu, vaddr pc, int m= ask) } =20 /* Add a breakpoint. */ -int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, int flags, +int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, BreakpointFlags flags, CPUBreakpoint **breakpoint) { CPUBreakpoint *bp; @@ -434,7 +434,7 @@ int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, int = flags, } =20 /* Remove a specific breakpoint. */ -int cpu_breakpoint_remove(CPUState *cpu, vaddr pc, int flags) +int cpu_breakpoint_remove(CPUState *cpu, vaddr pc, BreakpointFlags flags) { CPUBreakpoint *bp; =20 diff --git a/system/watchpoint.c b/system/watchpoint.c index 21d0bb36cae..41d188d7cdd 100644 --- a/system/watchpoint.c +++ b/system/watchpoint.c @@ -26,7 +26,7 @@ =20 /* Add a watchpoint. */ int cpu_watchpoint_insert(CPUState *cpu, vaddr addr, vaddr len, - int flags, CPUWatchpoint **watchpoint) + BreakpointFlags flags, CPUWatchpoint **watchpoin= t) { CPUWatchpoint *wp; vaddr in_page; @@ -65,7 +65,7 @@ int cpu_watchpoint_insert(CPUState *cpu, vaddr addr, vadd= r len, =20 /* Remove a specific watchpoint. */ int cpu_watchpoint_remove(CPUState *cpu, vaddr addr, vaddr len, - int flags) + BreakpointFlags flags) { CPUWatchpoint *wp; =20 diff --git a/target/arm/tcg/debug.c b/target/arm/tcg/debug.c index 07a52643e71..11043ecd589 100644 --- a/target/arm/tcg/debug.c +++ b/target/arm/tcg/debug.c @@ -550,7 +550,7 @@ void hw_watchpoint_update(ARMCPU *cpu, int n) vaddr wvr =3D env->cp15.dbgwvr[n]; uint64_t wcr =3D env->cp15.dbgwcr[n]; int mask; - int flags =3D BP_CPU | BP_STOP_BEFORE_ACCESS; + BreakpointFlags flags =3D BP_CPU | BP_STOP_BEFORE_ACCESS; =20 if (env->cpu_watchpoint[n]) { cpu_watchpoint_remove_by_ref(CPU(cpu), env->cpu_watchpoint[n]); @@ -656,7 +656,7 @@ void hw_breakpoint_update(ARMCPU *cpu, int n) uint64_t bcr =3D env->cp15.dbgbcr[n]; vaddr addr; int bt; - int flags =3D BP_CPU; + BreakpointFlags flags =3D BP_CPU; =20 if (env->cpu_breakpoint[n]) { cpu_breakpoint_remove_by_ref(CPU(cpu), env->cpu_breakpoint[n]); diff --git a/target/arm/tcg/mte_helper.c b/target/arm/tcg/mte_helper.c index dca4ef5a942..17f920b3f35 100644 --- a/target/arm/tcg/mte_helper.c +++ b/target/arm/tcg/mte_helper.c @@ -190,7 +190,8 @@ uint8_t *allocation_tag_mem_probe(CPUARMState *env, int= ptr_mmu_idx, =20 /* Any debug exception has priority over a tag check exception. */ if (!probe && unlikely(flags & TLB_WATCHPOINT)) { - int wp =3D ptr_access =3D=3D MMU_DATA_LOAD ? BP_MEM_READ : BP_MEM_= WRITE; + BreakpointFlags wp =3D ptr_access =3D=3D MMU_DATA_LOAD ? BP_MEM_RE= AD + : BP_MEM_WRITE; assert(ra !=3D 0); cpu_check_watchpoint(env_cpu(env), ptr, ptr_size, attrs, wp, ra); } diff --git a/target/ppc/cpu.c b/target/ppc/cpu.c index 41edb18643d..913920d55b8 100644 --- a/target/ppc/cpu.c +++ b/target/ppc/cpu.c @@ -145,7 +145,7 @@ void ppc_update_daw(CPUPPCState *env, int rid) bool sv =3D extract32(dawrx, PPC_BIT_NR(62), 1); bool pr =3D extract32(dawrx, PPC_BIT_NR(62), 1); vaddr len; - int flags; + BreakpointFlags flags; =20 if (env->dawr_watchpoint[rid]) { cpu_watchpoint_remove_by_ref(cs, env->dawr_watchpoint[rid]); diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index b94c2997a07..2a3711fb1df 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -1429,7 +1429,7 @@ static int find_hw_breakpoint(target_ulong addr, int = type) return -1; } =20 -static int find_hw_watchpoint(target_ulong addr, int *flag) +static int find_hw_watchpoint(target_ulong addr, BreakpointFlags *flag) { int n; =20 @@ -1575,7 +1575,6 @@ static int kvm_handle_hw_breakpoint(CPUState *cs, { int handle =3D DEBUG_RETURN_GUEST; int n; - int flag =3D 0; =20 if (nb_hw_breakpoint + nb_hw_watchpoint > 0) { if (arch_info->status & KVMPPC_DEBUG_BREAKPOINT) { @@ -1585,6 +1584,8 @@ static int kvm_handle_hw_breakpoint(CPUState *cs, } } else if (arch_info->status & (KVMPPC_DEBUG_WATCH_READ | KVMPPC_DEBUG_WATCH_WRITE)) { + BreakpointFlags flag =3D 0; + n =3D find_hw_watchpoint(arch_info->address, &flag); if (n >=3D 0) { handle =3D DEBUG_RETURN_GDB; diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c index 2db07f5dfb6..c318dcd633c 100644 --- a/target/riscv/cpu_helper.c +++ b/target/riscv/cpu_helper.c @@ -2000,7 +2000,7 @@ bool riscv_cpu_tlb_fill(CPUState *cs, vaddr address, = int size, } else if (probe) { return false; } else { - int wp_access =3D 0; + BreakpointFlags wp_access =3D 0; =20 if (access_type =3D=3D MMU_DATA_LOAD) { wp_access |=3D BP_MEM_READ; diff --git a/target/riscv/debug.c b/target/riscv/debug.c index ba5bc6ae13d..082ced71bb7 100644 --- a/target/riscv/debug.c +++ b/target/riscv/debug.c @@ -480,7 +480,7 @@ static void type2_breakpoint_insert(CPURISCVState *env,= target_ulong index) target_ulong addr =3D env->tdata2[index]; bool enabled =3D type2_breakpoint_enabled(ctrl); CPUState *cs =3D env_cpu(env); - int flags =3D BP_CPU | BP_STOP_BEFORE_ACCESS; + BreakpointFlags flags =3D BP_CPU | BP_STOP_BEFORE_ACCESS; uint32_t size, def_size; =20 if (!enabled) { @@ -605,7 +605,7 @@ static void type6_breakpoint_insert(CPURISCVState *env,= target_ulong index) target_ulong addr =3D env->tdata2[index]; bool enabled =3D type6_breakpoint_enabled(ctrl); CPUState *cs =3D env_cpu(env); - int flags =3D BP_CPU | BP_STOP_BEFORE_ACCESS; + BreakpointFlags flags =3D BP_CPU | BP_STOP_BEFORE_ACCESS; uint32_t size; =20 if (!enabled) { @@ -993,12 +993,10 @@ bool riscv_cpu_debug_check_watchpoint(CPUState *cs, C= PUWatchpoint *wp) CPURISCVState *env =3D &cpu->env; target_ulong ctrl; target_ulong addr; - int trigger_type; - int flags; - int i; =20 - for (i =3D 0; i < env->num_triggers; i++) { - trigger_type =3D get_trigger_type(env, i); + for (int i =3D 0; i < env->num_triggers; i++) { + int trigger_type =3D get_trigger_type(env, i); + BreakpointFlags flags; =20 if (!trigger_common_match(env, trigger_type, i)) { continue; diff --git a/target/s390x/tcg/debug.c b/target/s390x/tcg/debug.c index 99140b1ac9a..d10e9ed8922 100644 --- a/target/s390x/tcg/debug.c +++ b/target/s390x/tcg/debug.c @@ -14,7 +14,8 @@ =20 void s390_cpu_recompute_watchpoints(CPUState *cs) { - const int wp_flags =3D BP_CPU | BP_MEM_WRITE | BP_STOP_BEFORE_ACCESS; + const BreakpointFlags wp_flags =3D BP_CPU | BP_MEM_WRITE + | BP_STOP_BEFORE_ACCESS; CPUS390XState *env =3D cpu_env(cs); =20 /* We are called when the watchpoints have changed. First diff --git a/target/xtensa/dbg_helper.c b/target/xtensa/dbg_helper.c index 3b91f7c38ac..990012f60e6 100644 --- a/target/xtensa/dbg_helper.c +++ b/target/xtensa/dbg_helper.c @@ -85,7 +85,7 @@ static void set_dbreak(CPUXtensaState *env, unsigned i, u= int32_t dbreaka, uint32_t dbreakc) { CPUState *cs =3D env_cpu(env); - int flags =3D BP_CPU | BP_STOP_BEFORE_ACCESS; + BreakpointFlags flags =3D BP_CPU | BP_STOP_BEFORE_ACCESS; uint32_t mask =3D dbreakc | ~DBREAKC_MASK; =20 if (env->cpu_watchpoint[i]) { --=20 2.53.0 From nobody Sun Jul 26 11:01:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783288920; cv=none; d=zohomail.com; s=zohoarc; b=aJ420MPEqzp+bCUzS0QeIMmsyN0sraUoUukrTL+SJtcsC95nDQ3EQPWyltRbURZbK8NHOthVV4NLUrpO8aqJW2O2h4K4EYOy0P7qpP3RV8SkhinCPDC8j4dLAo6IXoFRWjPTum/yKrDt6fHcpnmURKxnxuVsYd4DqZQxYRJrMAo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783288920; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Yi0iSVj4LIkP2DPM2Oyar3HIg3gxuDuywavv3adUmn4=; b=HNXa3RJd2yELlwbNl+6Ot41Co4bYAmyELhbdxyeqI/iIkWZkMFAhMyYv36iFvU4q9Rmj44cXVVOBvqm3N5mB+PgWR1chCPj4/jIc1YELERV5l9EwXqZLqgBJHR08GJvzVc7vRpCBUXEeeHqnwPUazp2N0l1NPx8c321rMlvKA7o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783288920940525.7916915191429; Sun, 5 Jul 2026 15:02:00 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgUt5-0002vu-FB; Sun, 05 Jul 2026 18:00:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUt4-0002si-3g for qemu-devel@nongnu.org; Sun, 05 Jul 2026 18:00:30 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUt0-0000rn-RO for qemu-devel@nongnu.org; Sun, 05 Jul 2026 18:00:29 -0400 Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 665LxKMA2839029 for ; Sun, 5 Jul 2026 22:00:15 GMT Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6qvgutuj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 05 Jul 2026 22:00:15 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-92e6ed4fe99so408528485a.0 for ; Sun, 05 Jul 2026 15:00:14 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493ccd9d607sm294368145e9.2.2026.07.05.15.00.11 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 05 Jul 2026 15:00:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Yi0iSVj4LIkP2DPM2Oyar3HIg3gxuDuywavv3adUmn4=; b=ABirK62iQJ38rkaz KWH461iCYmKzvuFqOv8X9WnamiIYbQv4/sWCHK17gqIQ5AA4iyyv54hS6tjaMg06 NJazBAUcCqCT6+nV+xfU5rQoSjLx5y4h2+IGEynpxKmxGMiQRB5nPxp99HpKzhsb DF9x25N5FagyqXmXDn0T8f3Xl6vmOYlay2RonfM2R4awQm58HKbGtUveQEfo/jNb zxy1Z42Lq3qaUIHCJltcTjHFyTJuYGlm2KK3XPeUtbDud7qLxDDrkgCHPnHxQQD5 ukqidGTEYEPmj47UGNNr6OBIR01bfDlSCejNux8rmYbqw6IOMrol3VWFDcZOKcGu TMo9ug== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783288814; x=1783893614; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Yi0iSVj4LIkP2DPM2Oyar3HIg3gxuDuywavv3adUmn4=; b=Oxj7xsDI1KF7WA+p8/biqUJNtPWMg1RjOqPSG9YJwqkyfGMkVPKfW9YVfBdotL+Kq9 9q8sFyP/LjQYMWZKoHTgj/Ih1LsYjb1VADJ/B0cQEmKmNUsp2dBd37vCA6IVQlY98jhL T1J3XA5IfDRXt6Dzw3PCnh6UBEEpc3XnnAx0WgRvbZjqfzWPpdq8Bq2zyUXEfG7qQz7z fJt42slMdnArdrym/FecwLJb8IxrEGzxYm2OJ6C/gUzCoTRGDUsMNBBvEyn7XW8PF8pE N9H1rGP9m9DxY5/YNvlR20X6lDpXOnEg76c9GFQh1xb8YBURkmPijfB91b0dzyAoQIzy bAsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783288814; x=1783893614; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Yi0iSVj4LIkP2DPM2Oyar3HIg3gxuDuywavv3adUmn4=; b=aFdO7859a0a6XDTXuxFFnzLveo7gRK4TOhzK8R+TfxM+dGwmuFVOtq62qtIfBXBm7l mPWlqrX//PjZEM8w8zqQG/lF1j1CMG9Ntbv9dTy/U471fjOkKMvWZ/XTXtFO6RRnXFHp A3E8SmokkhkSzM7WxyoWdaTNV954XflCVNtjiYG9zccgdgcmq9EFhZJcAhDnh7M1kd2G mweUXkPxchmMrMcRjkQi4qY1EgT6yY/KI6D5hat3R4sucywRLjDIBOJ/lYby5YsTKsc+ IwymqtZXTbr9KD5FYH2RvvuRwLqD6qmQrIxvJHjI+I6UW5IN9JdEKK8PFpzEs2T3DGnX nmPg== X-Gm-Message-State: AOJu0Yz+43VyP/GY71EwyIWUpHdFQPNYkAOX+gzAspl9TZQj89cEI4jj Pjhz4nLNoGFduR9a+8/oZouUfKIxUomrWiu1mRJp9iXk+Aggj1xQsUyDszSyLuIuE5diRXJZFNo tzJvHLxm8zUF9z26dxj6OmGtuhUc36/sKD5gjlojUu5/WQet+sd32vwS7KDgfWIWp/Q== X-Gm-Gg: AfdE7ckkQIXlojE5AIRLtcb7jp+TO4ZhDQVwPHFEYB3mJEOYPE835+7Leu1If6bFGZ2 m2mHox1QVWAdCRJ2F8ujHkF0nrvFpxXyBZkahi5yD/+VyuS82bQSCSlnElzF98IsXcJRdwKznNE hl2sjyrIccAeFqoFt3EG7nQpgaWsZ472No6v6+IJ5UY3ThdvajaCvbc4CQsCPfxeBc2xenRBu5z G8GP5qzyPOnS3PXvMbjF1WBRg49ZX1Tz1S5wLuPaitGg5wfqWFTaKdN6FwwfuYCyGnggXv97w/7 8OK1eXdzST+i3EF1VtMrgxxGej9gzwtByxVxtHzAgftS58JJu2xswrmZkFcbF1Awjk9oWrrb9sK fya3EAdOwXk6iuvW5lXsA/moRVn3cgCeWWArg1nJsb3d7+fgV8EyJmw== X-Received: by 2002:a05:620a:838d:b0:92a:e474:92eb with SMTP id af79cd13be357-92e9a475b7dmr1092064885a.55.1783288814132; Sun, 05 Jul 2026 15:00:14 -0700 (PDT) X-Received: by 2002:a05:620a:838d:b0:92a:e474:92eb with SMTP id af79cd13be357-92e9a475b7dmr1092056885a.55.1783288813481; Sun, 05 Jul 2026 15:00:13 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , alex.bennee@linaro.org, qemu-s390x@nongnu.org, Magnus Kulke , Zhao Liu , qemu-ppc@nongnu.org, Paolo Bonzini , Xiaoyao Li , Richard Henderson , Mohamed Mediouni , Peter Maydell Subject: [PATCH v3 21/32] accel: Remove unnecessary 'inline' qualifier in remove_all_breakpoints Date: Sun, 5 Jul 2026 23:57:17 +0200 Message-ID: <20260705215729.62196-22-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260705215729.62196-1-philmd@oss.qualcomm.com> References: <20260705215729.62196-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=VvoTxe2n c=1 sm=1 tr=0 ts=6a4ad3ef cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=Ucb4Co1tYGy3ov5cU_AA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: uTAgYTDPEEwC_09QgqR8jR3PTEtOLsyV X-Proofpoint-GUID: uTAgYTDPEEwC_09QgqR8jR3PTEtOLsyV X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfX8kCeXA26K5BN hZZ7Ou0KTBGigtK1fomgO2owggs6l6bFJWfW3kx7IPszqAvG2oGIa+WZa9kxxx94e0r1GszstEt TOIdeQ/yD3FRfEJ0+aD9WVINj5wnq6U= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfXy82UR+qjwsrn YREpbKekXExW2iSwVpiz7aGA2dh/7SaWkqzI9xMTK8vyBZAozlz0zHfc47+N9GBwQNmxkFDo/lF BmLqM3nFdKTxtfq4MKNkasax7fA+2AqLS7QXZkl3awflcUL+60yiV66Vzzftcl1kNDd3TDGCkiE XqSvisq+/+pFm4+Z3x73+XiUZ6DAMu1WADqfdeGUUQZwxAEnSSRWL8v2X7+3KzukvKNz1nR6sLc cZZSPOiTSoxu9xa2Ahr9XYiVSfoscrzdFw3QCrAMsOp6yjQOpvzn0rj9g1yT0eDQJz4nc/sS64p rUxXn7x8kkph/pufIdAEzVL/1mqH8uC7DoEciiVJD9WD9JyVmGklONzA+saAmffFBoFpsW8uD+c lLG2Jj7Bfel5ZWKP1+LUWD7gAcFasH6bWIENKgSAri688082t6hqmC325CCbPQzdp78Xym1uiD7 wFBiqCflQugYQ1JOIFg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_02,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 suspectscore=0 impostorscore=0 clxscore=1015 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607050238 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783288923020158500 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- accel/tcg/tcg-accel-ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/tcg/tcg-accel-ops.c b/accel/tcg/tcg-accel-ops.c index 26d34c72d9a..c54acc770e3 100644 --- a/accel/tcg/tcg-accel-ops.c +++ b/accel/tcg/tcg-accel-ops.c @@ -188,7 +188,7 @@ static int tcg_remove_breakpoint(CPUState *cs, int type= , vaddr addr, vaddr len) } } =20 -static inline void tcg_remove_all_breakpoints(CPUState *cpu) +static void tcg_remove_all_breakpoints(CPUState *cpu) { cpu_breakpoint_remove_all(cpu, BP_GDB); cpu_watchpoint_remove_all(cpu, BP_GDB); --=20 2.53.0 From nobody Sun Jul 26 11:01:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783288846; cv=none; d=zohomail.com; s=zohoarc; b=LA7bktfZ4aR0/gDfeF+Q69XEiFRp1kyLlJYVjkkEcGYUCHzQOLloOduE1/E0lBVxDWbeD4dJ0+DWamKDex4VbI51AxL2Od4KJjkRG5U8OYgLn3be4OKODBXzsMkHyfeO0BoTMSHV3FaYH+gAXVbmWVWtfnQYX4uSatLLHrBbtYA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783288846; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=gfohBGLaZbWwSsM8BLb51a9USAKrCnCAVyI6ZJxJiSc=; b=etc3VjwsZ+KRK/AWSBFXoIloJJeNPr26GD5M9jMD2Fgtc1HnI+ZQq6u2j65rXQK4qq0Cvtl7Rfx0rdrwvEjNdsAdgsrlQ6qyuhiCpMxGYa8stBlQTx/Q+WsNIJM5br5gcJszY0+c11MAcEhfFgtFK1YxDFuhsNbBoJTq+9yeE3k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178328884666987.08601395317805; Sun, 5 Jul 2026 15:00:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgUtC-0003Fy-Vi; Sun, 05 Jul 2026 18:00:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUtA-0003C6-U1 for qemu-devel@nongnu.org; Sun, 05 Jul 2026 18:00:36 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUt9-0000w0-80 for qemu-devel@nongnu.org; Sun, 05 Jul 2026 18:00:36 -0400 Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 665LxldS2716618 for ; Sun, 5 Jul 2026 22:00:23 GMT Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6txekdxb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 05 Jul 2026 22:00:23 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-92d1cae5740so261862685a.0 for ; Sun, 05 Jul 2026 15:00:23 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c636ec8asm265412075e9.1.2026.07.05.15.00.19 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 05 Jul 2026 15:00:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gfohBGLaZbWwSsM8BLb51a9USAKrCnCAVyI6ZJxJiSc=; b=Es9uNhK740CyD7QO 0vAR11NLavvL7oXzexZZiOXbbsnuRaNjL3nZJGXiPG/gTGPVPxCdkSWdlfal9LsZ hrDlEXkixNSC1PNR1MbwGmhhH1GyX9ZYLrVkbo6ECPyt3cDE50GEvpv1dEAoygdY yU43jFWoN8oe21SJU4FAWS7KIZynZt1Wy97l+wwCK/mXEdZL29ZwL7SoSwxUu9w1 mRUpCtbQ/u7zS5jaMrfJ7ux4tXngWEdARp2cMuay+2j0I+S1b1zjAQRIXCDUP3y7 TLZiM//G1wdNAUzqX2wffvNUqYcJ6KFXI3FTOsIS4Y7WZZ9qtVMY8M2cw9H9EPAf 7+Jhrw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783288822; x=1783893622; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=gfohBGLaZbWwSsM8BLb51a9USAKrCnCAVyI6ZJxJiSc=; b=d86MqNlEqui4nqrY0Lv2SkgFxeFcuf50yfEajGdO71k+rgvhy5Ve88VbgdJBPIS8PT pQWmxpAqGJkwLl10z86mdwBNHIUA+pMYKgBdP+SqLLS+MAKE64zGV10FqWVkhiPdX6lz iPKIRtBBRuSX/nM5CPAq9cacbgye6dLNVuCzWP7HdtMhZXXCQLn82z362TKAKKiZAQHJ 3Xk+9RiMHofQkgf1wVjIQCVBgJZ3tepAE5VkGYqsuAEFfKJNvk/YpT+Byz/V55u+1f7D fM3apmALiA6TZb8jW1rl4+KDmE1XvmGE/Z5yIoEvnfjKIpKIyRK602UHohBs2vcR98jc kB1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783288822; x=1783893622; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gfohBGLaZbWwSsM8BLb51a9USAKrCnCAVyI6ZJxJiSc=; b=r2uE5gIVWpmSyOZ2L4CeV7pt5qUV734SjExb48ZPTNJisyucboLsdOWLW55xcV/ZbJ IIS3/V+STZ2iI3XrFHSnTUJ31eiu8NjYmG3ocLDbh55uxst+me3kYCUpy2jaova07epn jgWyIfM9wimlhglzue6Tj3BjzDqAZnvuivILiJFudRkslOUgPse2/4oSrImX5+0Hv0UE 5WotwmRl3/HuM6mPmdKQnd2K1xpX6b1S0Q1S8bZ5kYmV8EvM1/RL/DfbPz48brdb+Z80 iiPpFdu6Tn+3Er4X4ZUdka63u3BNuHsgEnAapbZ17V+FQr4LvfWYROGVdHpx1dqczxvc 69Bw== X-Gm-Message-State: AOJu0YzrK72rTF6ys04u7v2fHjpyVuI/WQq0IqoqMgIbgzLjzJvCtgbj DJi6waKy0Q1xl+Pl0HRA/FVhW6CTWF86a/CsDw9vGTW0XFC4QBwptd0IEsRYvnnGmIN2R5XpM8E QiFB/zO44Wm+uRqEEcM3jFeK8alHfdCxo9vI3FsMP4ENLLMWYVFwbaOrl84EZm27xEw== X-Gm-Gg: AfdE7cm8Gux/Rd0lTXrp4gANzBciNu2Q9svPbqrwLLAla1Bfz+lMh2EgpvytDqaZ6RM +RsrGcElcUQqxLEqUD+wytsNd3phYGKBr9okytNzwYJioLJBTFfNMSjdbiWmzjRIXcQsbVCCp21 P4U1V6cUgB7Z8Q7C5+PLOdQdlGhw92Fe9EOvL73c+sdgeL2AoBB2hFloJjoCy9yRJXKlhIJbeen Z/wRAtu6b8wF3dEjjhEqsOoTgGyj/ggmiTq8lnauOE6Ge4JXiOUlngAGQuxAcEQG5FBS0v30PB9 h0RnrF8stmd7CB6jL+KXFJR+U4cBFM/Y6CKTFtsgBoOLVJTltGzRVQAs36W6IBT99KOoZsoTgfz vNCxnR9wuNrtlU7VuJkIxuZaGw/x9ou7xzc0TeGptEm65DhUt9oGMGgxbbF4Ho7Czvkyh X-Received: by 2002:a05:620a:19a3:b0:92e:60cd:9073 with SMTP id af79cd13be357-92e9a3a3b80mr1235621585a.23.1783288822271; Sun, 05 Jul 2026 15:00:22 -0700 (PDT) X-Received: by 2002:a05:620a:19a3:b0:92e:60cd:9073 with SMTP id af79cd13be357-92e9a3a3b80mr1235609185a.23.1783288821496; Sun, 05 Jul 2026 15:00:21 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , alex.bennee@linaro.org, qemu-s390x@nongnu.org, Magnus Kulke , Zhao Liu , qemu-ppc@nongnu.org, Paolo Bonzini , Xiaoyao Li , Richard Henderson , Mohamed Mediouni , Peter Maydell Subject: [PATCH v3 22/32] gdbstub/user: Directly call gdb_breakpoint_remove_all() in user mode Date: Sun, 5 Jul 2026 23:57:18 +0200 Message-ID: <20260705215729.62196-23-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260705215729.62196-1-philmd@oss.qualcomm.com> References: <20260705215729.62196-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfX1oayr0+iY66o hKXUcmcGwEMvkJz8HMIv4IwKd++BYfAch22A5TTIJp7R04/MrmhX9XUrzDKK6useopwA0mw2pxF dUqLanZiXIou3itgEshqLetPeQERd00= X-Proofpoint-GUID: O2yrqSpBruDBnNauXD3jkm9-PHFcNLuU X-Proofpoint-ORIG-GUID: O2yrqSpBruDBnNauXD3jkm9-PHFcNLuU X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfX7sOb8vtcTQJx 8zErBFwjKN1dMIsQQjVyz31NCZKbPic8AWy95Hz3dWzhuZVyeneZqMih++c/HaE0e/gwT3s9sOI FDaQCkUP3l65I0c7uSHwY18AhP8ag7fcoPHj0xU+IclkgcdTXX1HnEyU27IpqZcKZolTOG5xw86 PC0Q3VWGpQZr+bl2/vDA9WhTQi7+kQ7E+/xuSfF1OppbZbn9YqnFhw0HKdG/AJwrjP1d78Z5cp5 RXLB8J2lg4uuwpxJgFtRYuH4194Erazy6rCJFEhQb/2cbVOpEuRRuyDOMCazDFO0cd3d+cnOfJ6 ekqOX5mrqpwYrPkmPxpHm9OfBczgaDFQXGIHatTaxTWdsquu4GTqLFRNwCWquHxRURwRqIHWDx5 /F9nwbdWsrfDzahZYXIRg/+udtDXvP3/LMXygXLbcizeXYS4Eu4WydTYnoqEGtf/lnOxd2mPQio AHQA2Nenwspj1CZ5O5A== X-Authority-Analysis: v=2.4 cv=HLLz0Itv c=1 sm=1 tr=0 ts=6a4ad3f7 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=zxLOgqzoZ8asriTz2EMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_02,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 clxscore=1015 suspectscore=0 impostorscore=0 phishscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607050238 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783288848617158500 No need to deref external methods with unused argument to end up calling a method defined in the same unit file, call it directly. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- gdbstub/user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdbstub/user.c b/gdbstub/user.c index 299388b9f71..90d6ee49fb5 100644 --- a/gdbstub/user.c +++ b/gdbstub/user.c @@ -557,7 +557,7 @@ static void disable_gdbstub(CPUState *thread_cpu) close(gdbserver_user_state.fd); gdbserver_user_state.fd =3D -1; CPU_FOREACH(cpu) { - cpu_breakpoint_remove_all(cpu, BP_GDB); + gdb_breakpoint_remove_all(cpu); /* no cpu_watchpoint_remove_all for user-mode */ cpu_single_step(cpu, 0); } --=20 2.53.0 From nobody Sun Jul 26 11:01:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783288926; cv=none; d=zohomail.com; s=zohoarc; b=NRw8owC3WDCnq/go9DxZlmJGqfACxYgevV6YSWCP4CVmfRD4y+oH/9wMvGAmNGBODBvX1lHnO6eAgj57B9k4BxAgsrPxxVZC+5LXB23ehIvNQN5nRHZLyjSrIxA9qOzCcr5ySy8ORWmws6G9V6HfCDQoEp2+6NLVmpp9jBF5VSk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783288926; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=QV+aX9nOik2ueUL6+e2EZz4Xhxb9JObx3udYKE6I3oM=; b=jSmyUYY+WF9rkZrvPLshdT1w3JviUuz8U2rUnmV8ANdrfasYHb1BL8lguPIad+/9mLUz2tlZnkLQgF7gBi7jbXkMpMaRtfOFIblkQd5us8oiDghliB/EItCefKciOTzRb6pOAtLvRLSaTgaZtxXSMFY4Z8j0avFE1AJwt9LM5Jc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783288926728804.1155946826793; Sun, 5 Jul 2026 15:02:06 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgUtK-0003b1-Ah; Sun, 05 Jul 2026 18:00:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUtI-0003V5-1M for qemu-devel@nongnu.org; Sun, 05 Jul 2026 18:00:44 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUtG-0000xF-G1 for qemu-devel@nongnu.org; Sun, 05 Jul 2026 18:00:43 -0400 Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 665M0FWk2717895 for ; Sun, 5 Jul 2026 22:00:31 GMT Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6txekdxp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 05 Jul 2026 22:00:30 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e53b8a302so216704585a.1 for ; Sun, 05 Jul 2026 15:00:30 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47ad69519c2sm19497610f8f.37.2026.07.05.15.00.27 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 05 Jul 2026 15:00:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QV+aX9nOik2ueUL6+e2EZz4Xhxb9JObx3udYKE6I3oM=; b=TniCKdcl1NwcUACz s9GtwGOSQM2ez0MJ4PEZNoxLaz/6673uoYZY00Qf+Wop3ZWuHrJqECsQpDucU7iG OtW6f6mQ25lv2lPsEZkS/f8KqAGU0/FP5vrZrgYtH4c660t66BinET3VXAXq2Zpt UCC85gGU8UzQMOJ1jIvrykgclPMJ6bWxJZ5oNXjeYmqOX5GKNvnbDnQeyo8Q1qbG YxIThNNnfPfsCCvRe338m+G/eyvC/lK4g2ZdOqRYdrCvf+BrSatlGouCc+nZm3gE mHeyFALFxUGsY5v0YuGbzgpql20AY5U1LGjnl16IivpuUSXNJBznfVRJ2ojqjvQi OwVicw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783288830; x=1783893630; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QV+aX9nOik2ueUL6+e2EZz4Xhxb9JObx3udYKE6I3oM=; b=P/6+DgRp0ALB3T7uw3M4CXHNfaKqbJe7sVb6JpfKEq5L+oOtT6ZjM2TGIvCk2EKJsm zkOarZqFdM7vpmEUqrv5XtFYOfL/rkFjLnv8nkGv0Dofc6oGHIwgPx0K6YW0WVG81zg0 tnhBw8ry+5ufUT+dZ3jLwpEX9t63tbJHEuj3XJrqk//jDw2pRGxrmOxOHOPEgbeBkiPL 5bJT+0mlak5p/YtsqTKiEW8L42/QN6USMkUgIvWSs8/Fy78r3rDGMYSSnR//G6Iw5QbR 0lpbUXteSl0MU4aazuuoBZ4BpDniGtuRiBXPBoBeCPZVDXroesqvPzRdcI+L2UyrTpMi 9xZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783288830; x=1783893630; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=QV+aX9nOik2ueUL6+e2EZz4Xhxb9JObx3udYKE6I3oM=; b=dapWSH8qimJbvMy6gjQDrf1BwTVCG8+UbEZBs3E0ZrwU6FBx+PsojHnm2/dOKX8rYH U1duaId2zULJtrFe1ZtHZJBAGX/XjxMJfxIrmdT4k+9rar/nK0HcklwQSsFO6SWxZrHH Qfip7chZFhnfTK7rifIQDbWBAx2PitqYZLy6zGs3MgJIwHVsdGDM7hLX07Fs5T1EY/Gc zN2JuEdynoRLvdJ4Jlqe2HtItTC/f/lBpdOogswXmIwnxcoScPxC7vMZ9OaxnAtvRjhc eOYOLmeIH7MHlU08SKtlSwnlaQj90Jw7kXYhTZdMiemgyOqDsk4xpjW7555We806uwrz Vx2g== X-Gm-Message-State: AOJu0YyIBX/cmeudzZtRtNfOFPJlHN2qK7nnlrRmRVRJh6Z3Yr1Iq/Uv oFGcjNavM0C2CneKmzg/Xr6PiwS8gXSJn+T5Oxr44HGi1/010f3a4fosE2kNVHtkvhLz+bqofHV 9OR5OAsPu7WsEGXNnBQRaksQt2UEmuKUQuzbUXGPjqs+ZLZUGriTBLjclLAnn/8mwWQ== X-Gm-Gg: AfdE7clTYG1D61Rg97JifsGEC8s4b0w4W02qOg17MQ/Ui9QsC7Sl39wAWOZARVAMY4Q 5tPKf55Ejr7QB2YWyqdirWUHaKBh9XwHyIVBYGnhxZBRA+r9w7vAIAvJp2+ivYCbwn232R32s6L e6WYXdEsyshodUxDRDtEfebqb2RU8Neh+GGEr5oZXQI/1PWzKZcT8rLpuuvX/KPgH0UXiwX+F60 XKm16yjcr7zsxvsrPByydcFzFT/B5qC2V8AywL+j0oZSfIAaUWDi824q3CV/3w51pRdUUANZY/w bfNCBDxrP0CWjlPTXYwdx/LAyvUzjBBpvnTHZtfw4+U8aE9B64J+bZ3NHUp3HNHCDgQrGr7rY5t IzSZhd/0ahKqjNAHrS/1qIxuHb4eYGGWMnrM6VNHqjv9uSpW6jY6tzg== X-Received: by 2002:a05:620a:ac07:b0:92e:9c65:da7b with SMTP id af79cd13be357-92e9c65dd4amr796013185a.45.1783288829710; Sun, 05 Jul 2026 15:00:29 -0700 (PDT) X-Received: by 2002:a05:620a:ac07:b0:92e:9c65:da7b with SMTP id af79cd13be357-92e9c65dd4amr796004885a.45.1783288829113; Sun, 05 Jul 2026 15:00:29 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , alex.bennee@linaro.org, qemu-s390x@nongnu.org, Magnus Kulke , Zhao Liu , qemu-ppc@nongnu.org, Paolo Bonzini , Xiaoyao Li , Richard Henderson , Mohamed Mediouni , Peter Maydell Subject: [PATCH v3 23/32] gdbstub: Reduce @type variable scope Date: Sun, 5 Jul 2026 23:57:19 +0200 Message-ID: <20260705215729.62196-24-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260705215729.62196-1-philmd@oss.qualcomm.com> References: <20260705215729.62196-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfXwoB0Dvkp2OyI W565TW0m57y+Y53BYh/3HrrljbA382N/xU93L8hMi+oLtvkeHZh0Tq7Ef9YnaiCZ4eqAm7Ham/z Xbe0RC37M1SU59q+SJNx+8dhNFVMMcA= X-Proofpoint-GUID: 02zRL2wbLWr4Y_pQPnUlUAkhZ7XhItgH X-Proofpoint-ORIG-GUID: 02zRL2wbLWr4Y_pQPnUlUAkhZ7XhItgH X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfXx2h6aKPqwZXT wiyH1ItJecvHbziOdpklds+wF5/xfIFY13HrgvQIDqgp0e4n0B3MyP+BA7hkwCrGoQngTAeUUSh 1jv8ikcChf06r+J88FadMh7Wx3IR93uizSGMGiASxksqg34IqHnUoxXyxAWgirZq6QNhh6maS2O 15NnaM62gRmiUOZl0RM0BXpzVOh0rWCEbyTeyA6XH6pA4WDuGBy+Z2ZHBRczNafhren7+hAkMVw ckVla+OtgGPR/lgcIRo6Mly/6JrrD6hAjDqxrU1j99b6D1cBH8XSgl0vLnfOoJcF5zq6z+OJHON srZMYh2JvLNDXl71weagZ55OcFiA/ZLdRUZ6vlRC8asOF+j650iSlpkwFE0nOvhT+X0kC6W8xAU xwUs7pq9VnqzzC3tgkvXmGFga8Y271b3tK//pPY397WTnlKdoJUXDPthmkUKU6XZ/e/Y6QQ8OAb LkcknZmMW2PhGtUY7Zg== X-Authority-Analysis: v=2.4 cv=HLLz0Itv c=1 sm=1 tr=0 ts=6a4ad3fe cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=3yY2QiCzES6IJYuWj7AA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_02,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 clxscore=1015 suspectscore=0 impostorscore=0 phishscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607050238 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783288927022158500 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- gdbstub/system.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gdbstub/system.c b/gdbstub/system.c index bf7aa1ac234..9c4bd8ebcba 100644 --- a/gdbstub/system.c +++ b/gdbstub/system.c @@ -125,7 +125,6 @@ static void gdb_vm_state_change(void *opaque, bool runn= ing, RunState state) CPUState *cpu =3D gdbserver_state.c_cpu; g_autoptr(GString) buf =3D g_string_new(NULL); g_autoptr(GString) tid =3D g_string_new(NULL); - const char *type; int ret; =20 if (running || gdbserver_state.state =3D=3D RS_INACTIVE) { @@ -151,6 +150,8 @@ static void gdb_vm_state_change(void *opaque, bool runn= ing, RunState state) switch (state) { case RUN_STATE_DEBUG: if (cpu->watchpoint_hit) { + const char *type; + switch (cpu->watchpoint_hit->flags & BP_MEM_ACCESS) { case BP_MEM_READ: type =3D "r"; --=20 2.53.0 From nobody Sun Jul 26 11:01:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783288957; cv=none; d=zohomail.com; s=zohoarc; b=gYFBkGd+zypqOi0B+mM0F/6Y07CvmE0VvE5UEiBf1kQOVp4FWhVCK0uElBt/eZRsznE14uxwnAKQ57BlA4zGBZ2EKPITozMvwU+eCPFSEBnXTFuwHXrVmiqluDchakTgLoMKNxDxXfUyz4yyf0bjPpFTBqeEJh1bm2jNBHxafP4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783288957; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=MOmi6wrm0eC4tNd6GGXXYQxEoIV98ouYze/eblRNqP8=; b=Tyvq7v85lUx0LruN8FKYI4Y7drRRSdS97dWMDmFGfADoLzNqBSvOkr+1NnUjiThd9Iu3tLvKoU+OCq7yBlNUkaEqKV10EqX6TioTCc/Nz6Q7LGuKA0Y95/Wz/zhjZUhnOqC3FjZ1oRi5FVjcVmZWggZCXtGqLNbEj7/5g8Ozg/I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783288957525991.7780608537857; Sun, 5 Jul 2026 15:02:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgUtW-0003oO-1D; Sun, 05 Jul 2026 18:00:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUtU-0003lr-Mu for qemu-devel@nongnu.org; Sun, 05 Jul 2026 18:00:56 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUtN-00010Y-UK for qemu-devel@nongnu.org; Sun, 05 Jul 2026 18:00:56 -0400 Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 665M0FWl2717895 for ; Sun, 5 Jul 2026 22:00:38 GMT Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6txekdxv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 05 Jul 2026 22:00:38 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92e63df032bso281248585a.0 for ; Sun, 05 Jul 2026 15:00:38 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493ccb4cafesm220110595e9.0.2026.07.05.15.00.35 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 05 Jul 2026 15:00:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MOmi6wrm0eC4tNd6GGXXYQxEoIV98ouYze/eblRNqP8=; b=lx/frblejb/6+zY5 fGTYEqpiM2/PgrHLXMePNz7JAkqzm4k6gYgUhl33kM/27L7O3bvAYViMSz1mg7lD VuLitVzWftTR2DDqdSuJF7jOmjvrUqQnVBa88z/LYN4ZwYrmgtTpRaI60XR/NQcQ lXBz3/UCrXd2GMYSBo3H+8Byhr0r5HPAy9KbI9akANQ9Gb6Q+iIyN4K0TGhUqVLX IaSb3qEfbYdbTnqq0HrJK02QYpCP3/GTUORptlk/83CInRxjpRwaCg8jAideE0r2 J/JzfPZWrSpJpvhPU/NJOJxwoIsg5qrpV2vgx2Zca7gCADAezO74TDiTkOvYWHlf 38RupA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783288837; x=1783893637; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MOmi6wrm0eC4tNd6GGXXYQxEoIV98ouYze/eblRNqP8=; b=TwBOZ177R4WLHSeFqAkzQwI278MYe69pcxenGCUwqT1QvmjB8zVsKX1TRwYdwfGRQU JqGqw6qJG7ohiYc0DJPw8j56NIR58qR7b16cbt9lPeKrtZEWFmZ1P6EjkSy2vjALLScu TK9o9K6tBX6iWVcMX8XnDnTPFW3xdXcnaKFFu9Ez/n4lawVLgcuXdJPIYjUr9+iYecSE nRXorOvmduASzq4DHr/Yg1Hbz3+vGoyrNiQYRqJMBp7s+LFTFhNn9Om+MCvuKuMtsDUh jxCG6Aup1nvzguOmK44tyb1vrUbe44mk3FrTU1B/mKpOVqwFL7vnODg0ax4J8fomphml uF5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783288837; x=1783893637; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MOmi6wrm0eC4tNd6GGXXYQxEoIV98ouYze/eblRNqP8=; b=MJwtFnO02KV4H72fojFxLubA84suD/y8REeJyrbS778yVsMdCbTj+A2S9q6EI/BvMg MVP//GLCtl//uZwXmzqtPUoGMoLhEd6ow8mKM6CbLd3nxfV+GZH+7FHl9dW0Z9BliKde NJ0FK2baHTOr+0eF5kh0o+YAJONYevnFYnr2cXB/AIvCywhZ04s9hNYWQqGsCFyrTBgq oV4Fv5PmPsAANapusuInqnIQdEEEgY/DqMIIHNGkDsAb7vLfsDIE1wsr++cJu0UkTUVy 4Ik8mrRB/ZFrBueYnUcvtG/q5BhoBg+NvhXTXgO200nCfuvZOTVCdSMdbMIU2c+Z3cir LxTA== X-Gm-Message-State: AOJu0YyvwS3wpt7VE0kRAfokPIU+MNRgnlHwD0GwTe9C+ivkO6f2h/x/ RuPDyXdGVQMBRY9gs3h6ZdO9CYY1Vi7grWwqGI0WdUQZVrJugkT2U0e6PUZoITnL1QTgeXGwxmU N/lOr3dWmSV1q0K0Fb5Cw27VoATMy8OIgZe3OzR0orUIZNTga9b2xg81squjAQUBfag== X-Gm-Gg: AfdE7cmKtOLfHzT2LcN6eP9N85SdUMtooCgFfc8fro3hjqiB7i8NP6ybYAZaxSm7XGJ C42KL9nw/h2X1rAgQKZZldvJFmLMskEOdBoLutc6t7UJqEXmcaD6k7PCDB4PL9qgHDObl4JJmoH x6zW+SpR7r1mousOLSaayhLCtV5064nbJOa+xPVo8WEcNEigIwkWDWDsf+j7waELtBh7rS7siG7 hZtapNBv5ScNDjWnH7b/OQnYY5oZU5soNNoGMcp11DdGjNaBxSIzZh2UMry6/o7Nkoepc79/l55 2f87eDaz30xnzzi5nOn3LyMom6GAS0koHRNBLKmDspN+SEdTLiIXN5ElHD1ljAGA4fmiq9UJ6Yc S8nL/5N58LNnB/q63DqU3zz4/U7AuN3KHFJP87iMHowtfP+Eb14SaYpeZEBfu4crbYdnn X-Received: by 2002:a05:620a:258a:b0:92e:65d0:1cc7 with SMTP id af79cd13be357-92e8b5303a5mr1594205385a.28.1783288837086; Sun, 05 Jul 2026 15:00:37 -0700 (PDT) X-Received: by 2002:a05:620a:258a:b0:92e:65d0:1cc7 with SMTP id af79cd13be357-92e8b5303a5mr1594196185a.28.1783288836522; Sun, 05 Jul 2026 15:00:36 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , alex.bennee@linaro.org, qemu-s390x@nongnu.org, Magnus Kulke , Zhao Liu , qemu-ppc@nongnu.org, Paolo Bonzini , Xiaoyao Li , Richard Henderson , Mohamed Mediouni , Peter Maydell Subject: [PATCH v3 24/32] gdbstub: Introduce GdbBreakpointType enumerator Date: Sun, 5 Jul 2026 23:57:20 +0200 Message-ID: <20260705215729.62196-25-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260705215729.62196-1-philmd@oss.qualcomm.com> References: <20260705215729.62196-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfXzanjOtJBUb+g uL3Am5dyAr+ihZevZv6QRoOCpZgTB1tZ9CbUj4GAD/jI6FVzO4IJKdJtJHDxpvAfhwBIbc49VRM g43999DL6P7fUIuidHFJVJjoRi3w4xs= X-Proofpoint-GUID: aiwPDf2yPLvYU8yohPsOOvh2JJDHO5IP X-Proofpoint-ORIG-GUID: aiwPDf2yPLvYU8yohPsOOvh2JJDHO5IP X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfX9FbE3Rno9hn7 56i3NVU800XClWATMrTpHHHd4METnWajLAs3fKFk6KQcLnqmO/mELZO8wPonI58rYev6uGBuCEb JmRgV33ZPfRLVFh0T/s4T+sw7P0PepVGAtqZysdsgoAnm2rw2LlMnwXWXvq8S1R1FWKwepGHImm XteWamUp0f3FbAE3DMGr9759LDwmHeVMgZTlLot3qcNzgFK8tz9maIb6k76U40y04p641wcFm11 eZnKg/ctq42zRvpZ/7KG0xhAHz+uMw1esLGQxp2ZK7VfD6Cu0lx4QfmJQ6Lo2RtMS+qg6zQcwEc WZbNFH2hleF9CwQO6iEsZeUReGFoSP6IyjR9WvTz+8ERz4GF33leXuAbe2uMAqD5J+mB+h718a3 Cr+KWylhzWGoa7XXqBjbJKfdbrbWAw+5TXe/5z4NHTQhpGlcfMjhi62skjKA17uQ4vgLbh+nKMU rG+3e536q5IzeQHKJNg== X-Authority-Analysis: v=2.4 cv=HLLz0Itv c=1 sm=1 tr=0 ts=6a4ad406 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=z_0bWbdd-CfuK1dINPUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_02,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 clxscore=1015 suspectscore=0 impostorscore=0 phishscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607050238 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783288959207158500 Introduce the GdbBreakpointType enumerator to better follow code related to GDB protocol handling. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- gdbstub/internals.h | 7 +++++-- include/gdbstub/enums.h | 12 +++++++----- gdbstub/system.c | 6 ++++-- gdbstub/user.c | 6 ++++-- 4 files changed, 20 insertions(+), 11 deletions(-) diff --git a/gdbstub/internals.h b/gdbstub/internals.h index 0b74ea4000f..33f68672d1f 100644 --- a/gdbstub/internals.h +++ b/gdbstub/internals.h @@ -11,6 +11,7 @@ =20 #include "qemu/accel.h" #include "exec/cpu-common.h" +#include "gdbstub/enums.h" =20 /* * Most "large" transfers (e.g. memory reads, feature XML @@ -217,8 +218,10 @@ void gdb_syscall_handling(const char *syscall_packet); * Break/Watch point support - there is an implementation for system * and user mode. */ -int gdb_breakpoint_insert(CPUState *cs, int type, vaddr addr, vaddr len); -int gdb_breakpoint_remove(CPUState *cs, int type, vaddr addr, vaddr len); +int gdb_breakpoint_insert(CPUState *cs, GdbBreakpointType type, + vaddr addr, vaddr len); +int gdb_breakpoint_remove(CPUState *cs, GdbBreakpointType type, + vaddr addr, vaddr len); void gdb_breakpoint_remove_all(CPUState *cs); =20 /** diff --git a/include/gdbstub/enums.h b/include/gdbstub/enums.h index c4d54a1d083..e4e2043d92c 100644 --- a/include/gdbstub/enums.h +++ b/include/gdbstub/enums.h @@ -12,10 +12,12 @@ #define DEFAULT_GDBSTUB_PORT "1234" =20 /* GDB breakpoint/watchpoint types */ -#define GDB_BREAKPOINT_SW 0 -#define GDB_BREAKPOINT_HW 1 -#define GDB_WATCHPOINT_WRITE 2 -#define GDB_WATCHPOINT_READ 3 -#define GDB_WATCHPOINT_ACCESS 4 +typedef enum GdbBreakpointType { + GDB_BREAKPOINT_SW =3D 0, + GDB_BREAKPOINT_HW =3D 1, + GDB_WATCHPOINT_WRITE =3D 2, + GDB_WATCHPOINT_READ =3D 3, + GDB_WATCHPOINT_ACCESS =3D 4, +} GdbBreakpointType; =20 #endif /* GDBSTUB_ENUMS_H */ diff --git a/gdbstub/system.c b/gdbstub/system.c index 9c4bd8ebcba..6e2dbc823e3 100644 --- a/gdbstub/system.c +++ b/gdbstub/system.c @@ -623,7 +623,8 @@ int gdb_signal_to_target(int sig) * Break/Watch point helpers */ =20 -int gdb_breakpoint_insert(CPUState *cs, int type, vaddr addr, vaddr len) +int gdb_breakpoint_insert(CPUState *cs, GdbBreakpointType type, + vaddr addr, vaddr len) { const AccelOpsClass *ops =3D cpus_get_accel(); if (ops->insert_breakpoint) { @@ -632,7 +633,8 @@ int gdb_breakpoint_insert(CPUState *cs, int type, vaddr= addr, vaddr len) return -ENOSYS; } =20 -int gdb_breakpoint_remove(CPUState *cs, int type, vaddr addr, vaddr len) +int gdb_breakpoint_remove(CPUState *cs, GdbBreakpointType type, + vaddr addr, vaddr len) { const AccelOpsClass *ops =3D cpus_get_accel(); if (ops->remove_breakpoint) { diff --git a/gdbstub/user.c b/gdbstub/user.c index 90d6ee49fb5..9e6f9a6f376 100644 --- a/gdbstub/user.c +++ b/gdbstub/user.c @@ -790,7 +790,8 @@ unsigned int gdb_get_max_cpus(void) * Break/Watch point helpers */ =20 -int gdb_breakpoint_insert(CPUState *cs, int type, vaddr addr, vaddr len) +int gdb_breakpoint_insert(CPUState *cs, GdbBreakpointType type, + vaddr addr, vaddr len) { CPUState *cpu; int err =3D 0; @@ -811,7 +812,8 @@ int gdb_breakpoint_insert(CPUState *cs, int type, vaddr= addr, vaddr len) } } =20 -int gdb_breakpoint_remove(CPUState *cs, int type, vaddr addr, vaddr len) +int gdb_breakpoint_remove(CPUState *cs, GdbBreakpointType type, + vaddr addr, vaddr len) { CPUState *cpu; int err =3D 0; --=20 2.53.0 From nobody Sun Jul 26 11:01:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783288972; cv=none; d=zohomail.com; s=zohoarc; b=QRWxDSG+t6cHGSxpuNfn+j/y0xRJ+Sq77aLuZaFYhGO89v91+3ELVZ2NIJ3RLulvthcmoQns1s8cZ16rd9ajTDFSh37ueeL3U0aat2rfwQJSUrnTxjf2mvDT6o73Bz5qPJNhF15vKrCMrJzKRldjyXWHOHy8ZandyoJvx+Ag0Wk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783288972; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=WMuzKm4O8DnPBJteZs+7yYrCU+dLt8rT8REJEE7PWds=; b=PA3lt/HMdyLXfdj5Z5FloGTqwwoNB6scl1mZovmY75MR0FoAufIreWoPT6x5WgeoW5Z40gCJmmhjj3QkLBEgTYy77fip6THTm74l1oK39vh0VyhYtUtpbSLQFY+t8YAvpkXHpaxxGJkNAinWP3h0LFsnbiRTMLw2OXDs+/o4tAU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783288972675736.5046129777131; Sun, 5 Jul 2026 15:02:52 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgUtR-0003eY-D3; Sun, 05 Jul 2026 18:00:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUtP-0003dg-MI for qemu-devel@nongnu.org; Sun, 05 Jul 2026 18:00:51 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUtM-00012F-BA for qemu-devel@nongnu.org; Sun, 05 Jul 2026 18:00:51 -0400 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 665LxNVF2863625 for ; Sun, 5 Jul 2026 22:00:47 GMT Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6s64kmtn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 05 Jul 2026 22:00:47 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92e4f27f49bso180371885a.0 for ; Sun, 05 Jul 2026 15:00:47 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47a9e4d6e4csm17627422f8f.10.2026.07.05.15.00.42 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 05 Jul 2026 15:00:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WMuzKm4O8DnPBJteZs+7yYrCU+dLt8rT8REJEE7PWds=; b=CniAKIJTf+YTsN+M 3jfjBGcPob2fcfNCjcpfvhX2Ur8I9RmxYmkvd/F94SOhO5orhPwC//1zPoxQfyVB /PXBJXlCL6ecqwyINYc4Azy/OzSOqax8luGEJWO0paneA8eU2xp7ha/PZXz8dIkJ 2bHKQcKoH/KkIq3L9GEMxacRmbDKv2nf6N4O7IZ0VNnSvAOPvu/bE43FHNghZ4sB hxkCsvkdqu5u7sC0JBmQfYxzHycDWrTW+ClTSqUdAznKlk2uAoe+UxZc6sqCRkaz Nc8MqwwHL8DyFHYbKeGG+FgyLd30QGK3w+XUUjYHZ0yk5aWalcUWbQhUykcK763R mTNc3A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783288846; x=1783893646; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WMuzKm4O8DnPBJteZs+7yYrCU+dLt8rT8REJEE7PWds=; b=ZJCc5hHzRUJFkj8fvN/ksoGlG3O7UBoa72/eYxq5b1jh0AVrtd/S0pbiyo+vKrjzxT FsD4nOWKFqf7sDbvHxINKf/vsAtyA9ZfXagUP0T4XPmbnrFsKKgeOo5wSK0veJvc+cN7 yr8UlbTxnlQKu/9Ey8A/CXc7V93mOBA44skAlOZSV1dRyBQQYw8A+4maQQ3N8FodM6lu 5L+Wbd16l3yKA3Udg4ecClqljTh7W2X/XFkbio7kXwcSSmHnuLES5Cw3EOMYAcXbq5x4 VDbyKtmFhMFHdCKVpWMpbdD28HFzcSls2KtE8iQgk/z2V6Ygp6aXwJ7VT45q+aKygReT xmkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783288846; x=1783893646; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WMuzKm4O8DnPBJteZs+7yYrCU+dLt8rT8REJEE7PWds=; b=DxwKSjOdMqNJssIv3aCOCPnTlvMEaGcKPPACGZyqKA8/LhUyB8Ukfq6F1Cz1gMI3Iz EtSbWj1IS7pnuaKTUS5TaEFXSKGzmxGjVM7vuu9MeATvjxv/w7WoLFzh9uR82uip2qIV COp1/j63SIu/bHBVqdkMZUiZ4h5sEnTDRhMZVyPTYFHfJn3108ys8/9sBzrM9t0eHqhJ o3T3vZG3onnp0qWPE1310IVe3cODj2BU8aHW3WYrukLN7Mt8JctCVO2LCmYFAsBqGLwj NaKAUuPXEsnO8truK+E5pmbVi3fqKEVp3nh4wUoTjLsNae+B3xrOEHGRmeAtwhwk1c30 AMsw== X-Gm-Message-State: AOJu0YxFtbvG7eqS9RC51ca1bzclc0nzPag6w8Mj17GAFWQdlLQMTeHC I2nTpZqKJDx4IoeLxoHNchuKAcQCIgDvNe8nlGkc03xAa2Wea5NubH+9/vFJakz8xQZ7FTJOmd/ BIL7qnUNTNuJ+z3B/KcmCZA6GA49XmsfmL1oPdBuXSGkfnR6JXZcdSTHPz9e5jQxrIQ== X-Gm-Gg: AfdE7cnC5n9g1+T70jCuLRM5ACg8X9X5c4fu/IEnQj0Bz556FWFtH1BUYX7mtI1dp72 kKmzHYAYFbtcsAAMr9YPEtuGcaBVToTxLJFLixYLKTwGUAdWjzu8UGoBm3pRVazTbAPinghU0UM yztz43Q5wvI/s8hXRcaeLEL73owLBcpgsJF/iLBmW0A2bRwq+8xsMJfuN9E9jGg0qZ0z/d8L/qM QEm2BZlxAYY4i1RzHpEUTBv6if1qXIBAfhGAAUV8Ci4Bnr5TipoZE3Syvxmbm3X/FzD7gsHaTZB 9E7KKWTUn8ig9QK9a7XUXVi9lC4EMy9kv/D4TA5i7Bh/u00W/dJ5qZBNyNQJe6J5ic5/PiRONF5 7PVIIAFkFZwwF1hnOJyirbJOXlnqQ64lQqUEJYEexbkR2X/GbCUGpRUIErLhSOfxqPAAN X-Received: by 2002:a05:620a:6088:b0:92e:745c:6c49 with SMTP id af79cd13be357-92e9a313e9cmr1089052985a.15.1783288845683; Sun, 05 Jul 2026 15:00:45 -0700 (PDT) X-Received: by 2002:a05:620a:6088:b0:92e:745c:6c49 with SMTP id af79cd13be357-92e9a313e9cmr1089041085a.15.1783288844780; Sun, 05 Jul 2026 15:00:44 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , alex.bennee@linaro.org, qemu-s390x@nongnu.org, Magnus Kulke , Zhao Liu , qemu-ppc@nongnu.org, Paolo Bonzini , Xiaoyao Li , Richard Henderson , Mohamed Mediouni , Peter Maydell Subject: [PATCH v3 25/32] accel: Use GdbBreakpointType enum Date: Sun, 5 Jul 2026 23:57:21 +0200 Message-ID: <20260705215729.62196-26-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260705215729.62196-1-philmd@oss.qualcomm.com> References: <20260705215729.62196-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfXzK1Eos1NzRjP bjdpDuP7+EFm29e7NyYZdNonrDr7kj+xlQtmtkIWsP/GD3quwD1LcNpYPslc0AGQjGMPxRK0I5k WYR+OO/Odc5bEEj77603TpMMffcfuWqgdRvpGY9lrjgj71YkvamUCFkRBcpTvWFlvxnvw1sW8jc 3WCJFAmIQyXYYsxUlXZTKemxROMPO54phMZ0lsKCEhPt41WOAf6QetoUACA5cgnN0FIDERwovJi rAe1GV0b7NheZDAA2hxbZeF2P1i8ihGGm7e0sWPf3opWqUagbQUU4tw+UCTxEoW1Eqw3WF93B8a XNAdmD2hpJgSjkWjpWSmqiFleFLh54fyOawbkChEVR0hcOWNqnUEsc8i93hJ8wN1Er1xy0LQX24 DBJzejRBylL1KW/k9SCteBeVWL51TU93DaKxK7BZbahjQEsZMhP7EfVAZ1d0Dpa+r0WPNISdV95 oEzQkWHxmvsiTFiAGhw== X-Authority-Analysis: v=2.4 cv=VvITxe2n c=1 sm=1 tr=0 ts=6a4ad40f cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=j3PXfpA4_7De4rqNWBgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=O8hF6Hzn-FEA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: V3fXyomMixE-qa9V_eNvwa90bEecKYAc X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfX69upfUWDTC5W zRUO0YZ4bbqGk8m2yKofZWCs1hmsNewFwj0o+PHpWFGWTC8GDV4jLp5tjSOPfSAryEMQD8dHkmQ gvxdirLF+hov5FdNrzd0CEofaL8QlS4= X-Proofpoint-GUID: V3fXyomMixE-qa9V_eNvwa90bEecKYAc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_02,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 suspectscore=0 bulkscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 clxscore=1015 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607050238 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783288973398158500 Include '_gdbstub_' in the AccelOpsClass handlers to emphasize we are handling gdbstub-related requests. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- accel/kvm/kvm-cpus.h | 11 ++++++++--- include/accel/accel-cpu-ops.h | 9 ++++++--- include/system/hvf_int.h | 9 ++++++--- include/system/kvm.h | 9 ++++++--- target/arm/internals.h | 5 +++-- accel/hvf/hvf-accel-ops.c | 20 +++++++++++--------- accel/kvm/kvm-accel-ops.c | 6 +++--- accel/kvm/kvm-all.c | 14 ++++++++------ accel/tcg/tcg-accel-ops.c | 17 ++++++++++------- gdbstub/system.c | 12 ++++++------ target/arm/hvf/hvf.c | 12 +++++++----- target/arm/hyp_gdbstub.c | 8 ++++---- target/arm/kvm.c | 12 +++++++----- target/i386/hvf/hvf.c | 8 +++++--- target/i386/kvm/kvm.c | 12 +++++++----- target/loongarch/kvm/kvm.c | 8 +++++--- target/ppc/kvm.c | 12 +++++++----- target/riscv/kvm/kvm-cpu.c | 8 +++++--- target/s390x/kvm/kvm.c | 8 +++++--- 19 files changed, 119 insertions(+), 81 deletions(-) diff --git a/accel/kvm/kvm-cpus.h b/accel/kvm/kvm-cpus.h index 3185659562d..bc2dd82e68e 100644 --- a/accel/kvm/kvm-cpus.h +++ b/accel/kvm/kvm-cpus.h @@ -10,13 +10,18 @@ #ifndef KVM_CPUS_H #define KVM_CPUS_H =20 +#include "gdbstub/enums.h" + int kvm_init_vcpu(CPUState *cpu, Error **errp); int kvm_cpu_exec(CPUState *cpu); void kvm_destroy_vcpu(CPUState *cpu); void kvm_cpu_synchronize_post_reset(CPUState *cpu); void kvm_cpu_synchronize_post_init(CPUState *cpu); void kvm_cpu_synchronize_pre_loadvm(CPUState *cpu); -int kvm_insert_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len); -int kvm_remove_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len); -void kvm_remove_all_breakpoints(CPUState *cpu); +int kvm_insert_gdbstub_breakpoint(CPUState *cpu, GdbBreakpointType type, + vaddr addr, vaddr len); +int kvm_remove_gdbstub_breakpoint(CPUState *cpu, GdbBreakpointType type, + vaddr addr, vaddr len); +void kvm_remove_all_gdbstub_breakpoints(CPUState *cpu); + #endif /* KVM_CPUS_H */ diff --git a/include/accel/accel-cpu-ops.h b/include/accel/accel-cpu-ops.h index b23a0606c7e..f0c7ee7542c 100644 --- a/include/accel/accel-cpu-ops.h +++ b/include/accel/accel-cpu-ops.h @@ -13,6 +13,7 @@ #include "qemu/accel.h" #include "exec/vaddr.h" #include "qom/object.h" +#include "gdbstub/enums.h" =20 #define ACCEL_OPS_SUFFIX "-ops" #define TYPE_ACCEL_OPS "accel" ACCEL_OPS_SUFFIX @@ -85,9 +86,11 @@ struct AccelOpsClass { =20 /* gdbstub hooks */ int (*update_guest_debug)(CPUState *cpu); - int (*insert_breakpoint)(CPUState *cpu, int type, vaddr addr, vaddr le= n); - int (*remove_breakpoint)(CPUState *cpu, int type, vaddr addr, vaddr le= n); - void (*remove_all_breakpoints)(CPUState *cpu); + int (*insert_gdbstub_breakpoint)(CPUState *cpu, GdbBreakpointType type, + vaddr addr, vaddr len); + int (*remove_gdbstub_breakpoint)(CPUState *cpu, GdbBreakpointType type, + vaddr addr, vaddr len); + void (*remove_all_gdbstub_breakpoints)(CPUState *cpu); }; =20 void generic_handle_interrupt(CPUState *cpu, int mask); diff --git a/include/system/hvf_int.h b/include/system/hvf_int.h index d64f4942556..a01691ce172 100644 --- a/include/system/hvf_int.h +++ b/include/system/hvf_int.h @@ -13,6 +13,7 @@ =20 #include "qemu/queue.h" #include "exec/vaddr.h" +#include "gdbstub/enums.h" #include "qom/object.h" #include "accel/accel-ops.h" =20 @@ -91,9 +92,11 @@ int hvf_sw_breakpoints_active(CPUState *cpu); =20 int hvf_arch_insert_sw_breakpoint(CPUState *cpu, struct hvf_sw_breakpoint = *bp); int hvf_arch_remove_sw_breakpoint(CPUState *cpu, struct hvf_sw_breakpoint = *bp); -int hvf_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type); -int hvf_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type); -void hvf_arch_remove_all_hw_breakpoints(void); +int hvf_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type); +int hvf_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type); +void hvf_arch_remove_all_gdbstub_hw_breakpoints(void); =20 /* * hvf_update_guest_debug: diff --git a/include/system/kvm.h b/include/system/kvm.h index cdd1856ac5f..714b8c7b011 100644 --- a/include/system/kvm.h +++ b/include/system/kvm.h @@ -17,6 +17,7 @@ #define QEMU_KVM_H =20 #include "exec/memattrs.h" +#include "gdbstub/enums.h" #include "qemu/accel.h" #include "accel/accel-route.h" #include "qom/object.h" @@ -412,9 +413,11 @@ int kvm_arch_insert_sw_breakpoint(CPUState *cpu, struct kvm_sw_breakpoint *bp); int kvm_arch_remove_sw_breakpoint(CPUState *cpu, struct kvm_sw_breakpoint *bp); -int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type); -int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type); -void kvm_arch_remove_all_hw_breakpoints(void); +int kvm_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type); +int kvm_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type); +void kvm_arch_remove_all_gdbstub_hw_breakpoints(void); =20 void kvm_arch_update_guest_debug(CPUState *cpu, struct kvm_guest_debug *db= g); =20 diff --git a/target/arm/internals.h b/target/arm/internals.h index fcce3804f34..067c3f2b8bb 100644 --- a/target/arm/internals.h +++ b/target/arm/internals.h @@ -29,6 +29,7 @@ #include "exec/vaddr.h" #include "exec/breakpoint.h" #include "exec/memop.h" +#include "gdbstub/enums.h" #ifdef CONFIG_TCG #include "accel/tcg/tb-cpu-state.h" #include "tcg/tcg-gvec-desc.h" @@ -1968,8 +1969,8 @@ int delete_hw_breakpoint(vaddr pc); =20 bool check_watchpoint_in_range(int i, vaddr addr); CPUWatchpoint *find_hw_watchpoint(CPUState *cpu, vaddr addr); -int insert_hw_watchpoint(vaddr addr, vaddr len, int type); -int delete_hw_watchpoint(vaddr addr, vaddr len, int type); +int insert_gdbstub_hw_watchpoint(vaddr addr, vaddr len, GdbBreakpointType = type); +int delete_gdbstub_hw_watchpoint(vaddr addr, vaddr len, GdbBreakpointType = type); =20 /* Return the current value of the system counter in ticks */ uint64_t gt_get_countervalue(CPUARMState *env); diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-ops.c index ecc0cd1b558..d2276d8513e 100644 --- a/accel/hvf/hvf-accel-ops.c +++ b/accel/hvf/hvf-accel-ops.c @@ -233,7 +233,8 @@ int hvf_update_guest_debug(CPUState *cpu) return 0; } =20 -static int hvf_insert_breakpoint(CPUState *cpu, int type, vaddr addr, vadd= r len) +static int hvf_insert_gdbstub_breakpoint(CPUState *cpu, GdbBreakpointType = type, + vaddr addr, vaddr len) { struct hvf_sw_breakpoint *bp; int err; @@ -256,7 +257,7 @@ static int hvf_insert_breakpoint(CPUState *cpu, int typ= e, vaddr addr, vaddr len) =20 QTAILQ_INSERT_HEAD(&hvf_state->hvf_sw_breakpoints, bp, entry); } else { - err =3D hvf_arch_insert_hw_breakpoint(addr, len, type); + err =3D hvf_arch_insert_gdbstub_hw_breakpoint(addr, len, type); if (err) { return err; } @@ -271,7 +272,8 @@ static int hvf_insert_breakpoint(CPUState *cpu, int typ= e, vaddr addr, vaddr len) return 0; } =20 -static int hvf_remove_breakpoint(CPUState *cpu, int type, vaddr addr, vadd= r len) +static int hvf_remove_gdbstub_breakpoint(CPUState *cpu, GdbBreakpointType = type, + vaddr addr, vaddr len) { struct hvf_sw_breakpoint *bp; int err; @@ -295,7 +297,7 @@ static int hvf_remove_breakpoint(CPUState *cpu, int typ= e, vaddr addr, vaddr len) QTAILQ_REMOVE(&hvf_state->hvf_sw_breakpoints, bp, entry); g_free(bp); } else { - err =3D hvf_arch_remove_hw_breakpoint(addr, len, type); + err =3D hvf_arch_remove_gdbstub_hw_breakpoint(addr, len, type); if (err) { return err; } @@ -310,7 +312,7 @@ static int hvf_remove_breakpoint(CPUState *cpu, int typ= e, vaddr addr, vaddr len) return 0; } =20 -static void hvf_remove_all_breakpoints(CPUState *cpu) +static void hvf_remove_all_gdbstub_breakpoints(CPUState *cpu) { struct hvf_sw_breakpoint *bp, *next; CPUState *tmpcpu; @@ -328,7 +330,7 @@ static void hvf_remove_all_breakpoints(CPUState *cpu) QTAILQ_REMOVE(&hvf_state->hvf_sw_breakpoints, bp, entry); g_free(bp); } - hvf_arch_remove_all_hw_breakpoints(); + hvf_arch_remove_all_gdbstub_hw_breakpoints(); =20 CPU_FOREACH(cpu) { hvf_update_guest_debug(cpu); @@ -365,9 +367,9 @@ static void hvf_accel_ops_class_init(ObjectClass *oc, c= onst void *data) ops->synchronize_state =3D hvf_cpu_synchronize_state; ops->synchronize_pre_loadvm =3D hvf_cpu_synchronize_pre_loadvm; =20 - ops->insert_breakpoint =3D hvf_insert_breakpoint; - ops->remove_breakpoint =3D hvf_remove_breakpoint; - ops->remove_all_breakpoints =3D hvf_remove_all_breakpoints; + ops->insert_gdbstub_breakpoint =3D hvf_insert_gdbstub_breakpoint; + ops->remove_gdbstub_breakpoint =3D hvf_remove_gdbstub_breakpoint; + ops->remove_all_gdbstub_breakpoints =3D hvf_remove_all_gdbstub_breakpo= ints; ops->update_guest_debug =3D hvf_update_guest_debug; =20 ops->get_vcpu_stats =3D hvf_get_vcpu_stats; diff --git a/accel/kvm/kvm-accel-ops.c b/accel/kvm/kvm-accel-ops.c index 45330327909..c8e7aa38709 100644 --- a/accel/kvm/kvm-accel-ops.c +++ b/accel/kvm/kvm-accel-ops.c @@ -107,9 +107,9 @@ static void kvm_accel_ops_class_init(ObjectClass *oc, c= onst void *data) =20 #ifdef TARGET_KVM_HAVE_GUEST_DEBUG ops->update_guest_debug =3D kvm_update_guest_debug_ops; - ops->insert_breakpoint =3D kvm_insert_breakpoint; - ops->remove_breakpoint =3D kvm_remove_breakpoint; - ops->remove_all_breakpoints =3D kvm_remove_all_breakpoints; + ops->insert_gdbstub_breakpoint =3D kvm_insert_gdbstub_breakpoint; + ops->remove_gdbstub_breakpoint =3D kvm_remove_gdbstub_breakpoint; + ops->remove_all_gdbstub_breakpoints =3D kvm_remove_all_gdbstub_breakpo= ints; #endif } =20 diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index b03488ebac3..feffca0d82d 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -3826,7 +3826,8 @@ int kvm_update_guest_debug(CPUState *cpu, unsigned lo= ng reinject_trap) return data.err; } =20 -int kvm_insert_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len) +int kvm_insert_gdbstub_breakpoint(CPUState *cpu, GdbBreakpointType type, + vaddr addr, vaddr len) { struct kvm_sw_breakpoint *bp; int err; @@ -3849,7 +3850,7 @@ int kvm_insert_breakpoint(CPUState *cpu, int type, va= ddr addr, vaddr len) =20 QTAILQ_INSERT_HEAD(&cpu->kvm_state->kvm_sw_breakpoints, bp, entry); } else { - err =3D kvm_arch_insert_hw_breakpoint(addr, len, type); + err =3D kvm_arch_insert_gdbstub_hw_breakpoint(addr, len, type); if (err) { return err; } @@ -3864,7 +3865,8 @@ int kvm_insert_breakpoint(CPUState *cpu, int type, va= ddr addr, vaddr len) return 0; } =20 -int kvm_remove_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len) +int kvm_remove_gdbstub_breakpoint(CPUState *cpu, GdbBreakpointType type, + vaddr addr, vaddr len) { struct kvm_sw_breakpoint *bp; int err; @@ -3888,7 +3890,7 @@ int kvm_remove_breakpoint(CPUState *cpu, int type, va= ddr addr, vaddr len) QTAILQ_REMOVE(&cpu->kvm_state->kvm_sw_breakpoints, bp, entry); g_free(bp); } else { - err =3D kvm_arch_remove_hw_breakpoint(addr, len, type); + err =3D kvm_arch_remove_gdbstub_hw_breakpoint(addr, len, type); if (err) { return err; } @@ -3903,7 +3905,7 @@ int kvm_remove_breakpoint(CPUState *cpu, int type, va= ddr addr, vaddr len) return 0; } =20 -void kvm_remove_all_breakpoints(CPUState *cpu) +void kvm_remove_all_gdbstub_breakpoints(CPUState *cpu) { struct kvm_sw_breakpoint *bp, *next; KVMState *s =3D cpu->kvm_state; @@ -3921,7 +3923,7 @@ void kvm_remove_all_breakpoints(CPUState *cpu) QTAILQ_REMOVE(&s->kvm_sw_breakpoints, bp, entry); g_free(bp); } - kvm_arch_remove_all_hw_breakpoints(); + kvm_arch_remove_all_gdbstub_hw_breakpoints(); =20 CPU_FOREACH(cpu) { kvm_update_guest_debug(cpu, 0); diff --git a/accel/tcg/tcg-accel-ops.c b/accel/tcg/tcg-accel-ops.c index c54acc770e3..028265c2efd 100644 --- a/accel/tcg/tcg-accel-ops.c +++ b/accel/tcg/tcg-accel-ops.c @@ -110,7 +110,8 @@ void tcg_handle_interrupt(CPUState *cpu, int mask) } =20 /* Translate GDB watchpoint type to a flags value for cpu_watchpoint_* */ -static inline BreakpointFlags xlat_gdb_type(CPUState *cpu, int gdbtype) +static inline BreakpointFlags xlat_gdb_type(CPUState *cpu, + GdbBreakpointType gdbtype) { static const BreakpointFlags xlat[] =3D { [GDB_WATCHPOINT_WRITE] =3D BP_GDB | BP_MEM_WRITE, @@ -126,7 +127,8 @@ static inline BreakpointFlags xlat_gdb_type(CPUState *c= pu, int gdbtype) return cpuflags; } =20 -static int tcg_insert_breakpoint(CPUState *cs, int type, vaddr addr, vaddr= len) +static int tcg_insert_gdbstub_breakpoint(CPUState *cs, GdbBreakpointType t= ype, + vaddr addr, vaddr len) { CPUState *cpu; int err =3D 0; @@ -157,7 +159,8 @@ static int tcg_insert_breakpoint(CPUState *cs, int type= , vaddr addr, vaddr len) } } =20 -static int tcg_remove_breakpoint(CPUState *cs, int type, vaddr addr, vaddr= len) +static int tcg_remove_gdbstub_breakpoint(CPUState *cs, GdbBreakpointType t= ype, + vaddr addr, vaddr len) { CPUState *cpu; int err =3D 0; @@ -188,7 +191,7 @@ static int tcg_remove_breakpoint(CPUState *cs, int type= , vaddr addr, vaddr len) } } =20 -static void tcg_remove_all_breakpoints(CPUState *cpu) +static void tcg_remove_all_gdbstub_breakpoints(CPUState *cpu) { cpu_breakpoint_remove_all(cpu, BP_GDB); cpu_watchpoint_remove_all(cpu, BP_GDB); @@ -216,9 +219,9 @@ static void tcg_accel_ops_init(AccelClass *ac) } =20 ops->cpu_reset_hold =3D tcg_cpu_reset_hold; - ops->insert_breakpoint =3D tcg_insert_breakpoint; - ops->remove_breakpoint =3D tcg_remove_breakpoint; - ops->remove_all_breakpoints =3D tcg_remove_all_breakpoints; + ops->insert_gdbstub_breakpoint =3D tcg_insert_gdbstub_breakpoint; + ops->remove_gdbstub_breakpoint =3D tcg_remove_gdbstub_breakpoint; + ops->remove_all_gdbstub_breakpoints =3D tcg_remove_all_gdbstub_breakpo= ints; } =20 static void tcg_accel_ops_class_init(ObjectClass *oc, const void *data) diff --git a/gdbstub/system.c b/gdbstub/system.c index 6e2dbc823e3..3098fd55740 100644 --- a/gdbstub/system.c +++ b/gdbstub/system.c @@ -627,8 +627,8 @@ int gdb_breakpoint_insert(CPUState *cs, GdbBreakpointTy= pe type, vaddr addr, vaddr len) { const AccelOpsClass *ops =3D cpus_get_accel(); - if (ops->insert_breakpoint) { - return ops->insert_breakpoint(cs, type, addr, len); + if (ops->insert_gdbstub_breakpoint) { + return ops->insert_gdbstub_breakpoint(cs, type, addr, len); } return -ENOSYS; } @@ -637,8 +637,8 @@ int gdb_breakpoint_remove(CPUState *cs, GdbBreakpointTy= pe type, vaddr addr, vaddr len) { const AccelOpsClass *ops =3D cpus_get_accel(); - if (ops->remove_breakpoint) { - return ops->remove_breakpoint(cs, type, addr, len); + if (ops->remove_gdbstub_breakpoint) { + return ops->remove_gdbstub_breakpoint(cs, type, addr, len); } return -ENOSYS; } @@ -646,8 +646,8 @@ int gdb_breakpoint_remove(CPUState *cs, GdbBreakpointTy= pe type, void gdb_breakpoint_remove_all(CPUState *cs) { const AccelOpsClass *ops =3D cpus_get_accel(); - if (ops->remove_all_breakpoints) { - ops->remove_all_breakpoints(cs); + if (ops->remove_all_gdbstub_breakpoints) { + ops->remove_all_gdbstub_breakpoints(cs); } } =20 diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index e16457c3cfb..d5b1966a867 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -2726,7 +2726,8 @@ int hvf_arch_remove_sw_breakpoint(CPUState *cpu, stru= ct hvf_sw_breakpoint *bp) return 0; } =20 -int hvf_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type) +int hvf_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { switch (type) { case GDB_BREAKPOINT_HW: @@ -2734,13 +2735,14 @@ int hvf_arch_insert_hw_breakpoint(vaddr addr, vaddr= len, int type) case GDB_WATCHPOINT_READ: case GDB_WATCHPOINT_WRITE: case GDB_WATCHPOINT_ACCESS: - return insert_hw_watchpoint(addr, len, type); + return insert_gdbstub_hw_watchpoint(addr, len, type); default: return -ENOSYS; } } =20 -int hvf_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type) +int hvf_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { switch (type) { case GDB_BREAKPOINT_HW: @@ -2748,13 +2750,13 @@ int hvf_arch_remove_hw_breakpoint(vaddr addr, vaddr= len, int type) case GDB_WATCHPOINT_READ: case GDB_WATCHPOINT_WRITE: case GDB_WATCHPOINT_ACCESS: - return delete_hw_watchpoint(addr, len, type); + return delete_gdbstub_hw_watchpoint(addr, len, type); default: return -ENOSYS; } } =20 -void hvf_arch_remove_all_hw_breakpoints(void) +void hvf_arch_remove_all_gdbstub_hw_breakpoints(void) { if (cur_hw_wps > 0) { g_array_remove_range(hw_watchpoints, 0, cur_hw_wps); diff --git a/target/arm/hyp_gdbstub.c b/target/arm/hyp_gdbstub.c index bb5969720ce..dda6946ddaa 100644 --- a/target/arm/hyp_gdbstub.c +++ b/target/arm/hyp_gdbstub.c @@ -94,7 +94,7 @@ int delete_hw_breakpoint(vaddr pc) } =20 /** - * insert_hw_watchpoint() + * insert_gdbstub_hw_watchpoint() * @addr: address of watch point * @len: size of area * @type: type of watch point @@ -125,7 +125,7 @@ int delete_hw_breakpoint(vaddr pc) * need to ensure you mask the address as required and set BAS=3D0xff */ =20 -int insert_hw_watchpoint(vaddr addr, vaddr len, int type) +int insert_gdbstub_hw_watchpoint(vaddr addr, vaddr len, GdbBreakpointType = type) { HWWatchpoint wp =3D { .wcr =3D R_DBGWCR_E_MASK, /* E=3D1, enable */ @@ -208,13 +208,13 @@ bool check_watchpoint_in_range(int i, vaddr addr) } =20 /** - * delete_hw_watchpoint() + * delete_gdbstub_hw_watchpoint() * @addr: address of breakpoint * * Delete a breakpoint and shuffle any above down */ =20 -int delete_hw_watchpoint(vaddr addr, vaddr len, int type) +int delete_gdbstub_hw_watchpoint(vaddr addr, vaddr len, GdbBreakpointType = type) { int i; for (i =3D 0; i < cur_hw_wps; i++) { diff --git a/target/arm/kvm.c b/target/arm/kvm.c index a54ef51ec2a..01f42f42538 100644 --- a/target/arm/kvm.c +++ b/target/arm/kvm.c @@ -1784,7 +1784,8 @@ void kvm_arch_accel_class_init(ObjectClass *oc) "Eager Page Split chunk size for hugepages. (default: 0, disabled)= "); } =20 -int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { switch (type) { case GDB_BREAKPOINT_HW: @@ -1793,13 +1794,14 @@ int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr= len, int type) case GDB_WATCHPOINT_READ: case GDB_WATCHPOINT_WRITE: case GDB_WATCHPOINT_ACCESS: - return insert_hw_watchpoint(addr, len, type); + return insert_gdbstub_hw_watchpoint(addr, len, type); default: return -ENOSYS; } } =20 -int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { switch (type) { case GDB_BREAKPOINT_HW: @@ -1807,13 +1809,13 @@ int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr= len, int type) case GDB_WATCHPOINT_READ: case GDB_WATCHPOINT_WRITE: case GDB_WATCHPOINT_ACCESS: - return delete_hw_watchpoint(addr, len, type); + return delete_gdbstub_hw_watchpoint(addr, len, type); default: return -ENOSYS; } } =20 -void kvm_arch_remove_all_hw_breakpoints(void) +void kvm_arch_remove_all_gdbstub_hw_breakpoints(void) { if (cur_hw_wps > 0) { g_array_remove_range(hw_watchpoints, 0, cur_hw_wps); diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c index 19ad64a1d93..150598418e2 100644 --- a/target/i386/hvf/hvf.c +++ b/target/i386/hvf/hvf.c @@ -1049,17 +1049,19 @@ int hvf_arch_remove_sw_breakpoint(CPUState *cpu, st= ruct hvf_sw_breakpoint *bp) return -ENOSYS; } =20 -int hvf_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type) +int hvf_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { return -ENOSYS; } =20 -int hvf_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type) +int hvf_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { return -ENOSYS; } =20 -void hvf_arch_remove_all_hw_breakpoints(void) +void hvf_arch_remove_all_gdbstub_hw_breakpoints(void) { } =20 diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c index 64cc421abe6..1e09155e92c 100644 --- a/target/i386/kvm/kvm.c +++ b/target/i386/kvm/kvm.c @@ -6159,12 +6159,12 @@ int kvm_arch_remove_sw_breakpoint(CPUState *cs, str= uct kvm_sw_breakpoint *bp) static struct { target_ulong addr; int len; - int type; + GdbBreakpointType type; } hw_breakpoint[4]; =20 static int nb_hw_breakpoint; =20 -static int find_hw_breakpoint(target_ulong addr, int len, int type) +static int find_hw_breakpoint(target_ulong addr, int len, GdbBreakpointTyp= e type) { int n; =20 @@ -6177,7 +6177,8 @@ static int find_hw_breakpoint(target_ulong addr, int = len, int type) return -1; } =20 -int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { switch (type) { case GDB_BREAKPOINT_HW: @@ -6217,7 +6218,8 @@ int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr l= en, int type) return 0; } =20 -int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { int n; =20 @@ -6231,7 +6233,7 @@ int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr l= en, int type) return 0; } =20 -void kvm_arch_remove_all_hw_breakpoints(void) +void kvm_arch_remove_all_gdbstub_hw_breakpoints(void) { nb_hw_breakpoint =3D 0; } diff --git a/target/loongarch/kvm/kvm.c b/target/loongarch/kvm/kvm.c index d6539c12acd..beda6965f8c 100644 --- a/target/loongarch/kvm/kvm.c +++ b/target/loongarch/kvm/kvm.c @@ -1418,17 +1418,19 @@ int kvm_arch_remove_sw_breakpoint(CPUState *cs, str= uct kvm_sw_breakpoint *bp) return 0; } =20 -int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { return -ENOSYS; } =20 -int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { return -ENOSYS; } =20 -void kvm_arch_remove_all_hw_breakpoints(void) +void kvm_arch_remove_all_gdbstub_hw_breakpoints(void) { } =20 diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index 2a3711fb1df..6bdfbbd68d6 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -455,7 +455,7 @@ unsigned long kvm_arch_vcpu_id(CPUState *cpu) =20 static struct HWBreakpoint { target_ulong addr; - int type; + GdbBreakpointType type; } hw_debug_points[MAX_HW_BKPTS]; =20 static CPUWatchpoint hw_watchpoint; @@ -1412,7 +1412,7 @@ int kvm_arch_remove_sw_breakpoint(CPUState *cs, struc= t kvm_sw_breakpoint *bp) return 0; } =20 -static int find_hw_breakpoint(target_ulong addr, int type) +static int find_hw_breakpoint(target_ulong addr, GdbBreakpointType type) { int n; =20 @@ -1454,7 +1454,8 @@ static int find_hw_watchpoint(target_ulong addr, Brea= kpointFlags *flag) return -1; } =20 -int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { const unsigned breakpoint_index =3D nb_hw_breakpoint + nb_hw_watchpoin= t; if (breakpoint_index >=3D ARRAY_SIZE(hw_debug_points)) { @@ -1498,7 +1499,8 @@ int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr l= en, int type) return 0; } =20 -int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { int n; =20 @@ -1526,7 +1528,7 @@ int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr l= en, int type) return 0; } =20 -void kvm_arch_remove_all_hw_breakpoints(void) +void kvm_arch_remove_all_gdbstub_hw_breakpoints(void) { nb_hw_breakpoint =3D nb_hw_watchpoint =3D 0; } diff --git a/target/riscv/kvm/kvm-cpu.c b/target/riscv/kvm/kvm-cpu.c index 39d48a9db4d..2a5440d5846 100644 --- a/target/riscv/kvm/kvm-cpu.c +++ b/target/riscv/kvm/kvm-cpu.c @@ -2215,19 +2215,21 @@ int kvm_arch_remove_sw_breakpoint(CPUState *cs, str= uct kvm_sw_breakpoint *bp) return 0; } =20 -int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { /* TODO; To be implemented later. */ return -EINVAL; } =20 -int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { /* TODO; To be implemented later. */ return -EINVAL; } =20 -void kvm_arch_remove_all_hw_breakpoints(void) +void kvm_arch_remove_all_gdbstub_hw_breakpoints(void) { /* TODO; To be implemented later. */ } diff --git a/target/s390x/kvm/kvm.c b/target/s390x/kvm/kvm.c index fdef8f9e8ac..195e39df032 100644 --- a/target/s390x/kvm/kvm.c +++ b/target/s390x/kvm/kvm.c @@ -907,7 +907,8 @@ static int insert_hw_breakpoint(vaddr addr, int len, in= t type) return 0; } =20 -int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { switch (type) { case GDB_BREAKPOINT_HW: @@ -925,7 +926,8 @@ int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len= , int type) return insert_hw_breakpoint(addr, len, type); } =20 -int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { int size; struct kvm_hw_breakpoint *bp =3D find_hw_breakpoint(addr, len, type); @@ -954,7 +956,7 @@ int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len= , int type) return 0; } =20 -void kvm_arch_remove_all_hw_breakpoints(void) +void kvm_arch_remove_all_gdbstub_hw_breakpoints(void) { nb_hw_breakpoints =3D 0; g_free(hw_breakpoints); --=20 2.53.0 From nobody Sun Jul 26 11:01:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783288977; cv=none; d=zohomail.com; s=zohoarc; b=JHMJGCURk8PB2ymw7/efGoHNLqnWeMuLbsOTm7+jclYyc97in/UDF1WRCKmveOKxA7aYExGSvPJeFrqWauIphuMJn+n2wihBC674ZMi0II3I2wH4dWcj1KhM2UMY2sf61La1W4+MJ3N8KletIj7HJyRT4Kq7CuHMdVhKFXPydmo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783288977; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=0zxOegtK9/HXZJNp7+v9NFHsGRS7+LXc2HkX7d76Edg=; b=YGkNWlbzuRe9C2ie6JXWmZSP8CEtuH1XF4A2hGZq6w5aVCmc9q3lGUi5sTCYC7+0Ue2bQ4+atWNirZvyNkzDk+EVrwGqaQ5Blw6wZ3iadtJc0YNM4LdeOe1wur3BRKRcJ+dAIvvjOVqznHQY4RPcd30yD29xQ+rCAlem5HsVGPc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178328897785583.8103922325405; Sun, 5 Jul 2026 15:02:57 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgUtW-0003oG-16; Sun, 05 Jul 2026 18:00:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUtU-0003ld-KA for qemu-devel@nongnu.org; Sun, 05 Jul 2026 18:00:56 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUtS-000135-PQ for qemu-devel@nongnu.org; Sun, 05 Jul 2026 18:00:56 -0400 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 665LxNVG2863625 for ; Sun, 5 Jul 2026 22:00:53 GMT Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6s64kmtv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 05 Jul 2026 22:00:53 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-92d1cae5740so261918285a.0 for ; Sun, 05 Jul 2026 15:00:53 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c636ea60sm284187235e9.3.2026.07.05.15.00.50 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 05 Jul 2026 15:00:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0zxOegtK9/HXZJNp7+v9NFHsGRS7+LXc2HkX7d76Edg=; b=DAe3SJjGw2MamgZR bHp3lNh10V+0NBVQ3HCWUDNT1YtOp+kh/iGdlpMkWhi0qyDenZx2mUfNWH74dqvS pONulk9Zm0pnaq4msef4MB/5IiB1glOR8OvcA92KsPEYEmXUVqW26iTwIFVCsHii ZRnBug8HJJLfo53xtdGRYWAFdSXd8pHsaxT0VK3jUmlE8CTW1pPUvY/Wr21DN7PY Qz3aE21nRng3Mi770WdOGqk+Yc0p0nwC5x2lzuyanK/0t8JewlHnUNmg+YxSx4Vr WG28k+3UFgstDNi4hY6cO3k0xaV3Z73ErOIpojfoeDOe0P5vfMJoPiCDAA9ikXkj MREVaw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783288853; x=1783893653; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=0zxOegtK9/HXZJNp7+v9NFHsGRS7+LXc2HkX7d76Edg=; b=W66fGG5sTe5Y21tmPClwnWUWb5zuH8ZVQCByEUphIGTiqOjd/3IJwMEr3Dp/Bg8hkm 0fHCzuxcCq5kqnL7aFTOTLDBYcBUZ1Xuyux5O/eHCVhucdXXf0O+qm+7UEux8D71vjy+ BhBcVLk5LlrGAP+TJu4wSVJJSaGBQ+SOTOpzvrBE0lKQezhmWC9BM5BrpV273sZeMkCv 631Q0lCPf1wKO5TYDs4xjVI80nS1KMcE5DdUpaG+osJQtesp7eT0z64DL0dnXbCTGOzn ProjbyAB8frJZrai04W8J9A2/S/sPxPIYY2ieDEEEPATyQobJm/ytsIeGVjTxD97Fh8S I2Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783288853; x=1783893653; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=0zxOegtK9/HXZJNp7+v9NFHsGRS7+LXc2HkX7d76Edg=; b=EsA+Hsql2ue6mZ6/rQMJCh29AOlv8OEJ9YRZ06PjyngtVJyTp1deuYhIO0YuJ46i+9 ZKoos1N5zdrO4YVqncJhBazhJ+CqJONHJiJI42zofUtWev6PlU2gCQli6uPw/wXQ3PAL PV9aSnraiwzSzUrjHwT+0eEdbUs6dh+8Kzllbt3b2AjpePUTSrOAR2znrLKsgCiclvlx iXsVctIF6EPeXbqT55XWFsYT5iZvMAd+WOhBaO2mAYQPk86sy08uj91vM70Kb6A5BbPV jaeeRwVFQwRLxjO/YyFzvDtEAGDrGLudvOrX8zMbAYJmHrLxWfBth0ZXH69nSAa7YEjo z0JA== X-Gm-Message-State: AOJu0YyNzSxTqIhvkODnDS2S6aZsvSS+tLjBk8uHztgOhScRW9d+m10Y aUg9tWmO6cjfOb3Yi+p1VmU4AUe1BdDq5pl4qOY9KygTL77fnBedtW5ndUNxDgQMEnzVHPFBDE2 heXfCrrLxmrIL1zqQZubfN73Ca2z/R48/AICLJVKORxjhzx+Uusf7hQMCUq607GpQ1Q== X-Gm-Gg: AfdE7cljJAp58vqOOrJLV4WYl2h0vSxVK6bRbAGYCzHVDnsT4Ok5e8wYtjhe1eTxL56 l6+A46WJEe2hLQFPwBtrx3QtlXECKsBmXqYcklepZ6TCqjfCqLY8Iu/rqIVTrhu1uWSh96CWjLQ E6Bv7oIgLS41dI3SJtEVq4IGywdJu1iTfD99rUr/QrALRdsyHCRcsvEXay6HyR8u2cw+EJQBFlq /lOiznjgJF0YwDB9n19kGm/YN5fxi9OYMCkcCi5uU1LDEdXA0akRneyN2PtQeizQx1iz/sUJ8h/ s8dWlt2F0M+Tg1664lnY4gQeOJwZ2Bq85Vp1eCmd1E/J3uyUkA/Pm23zyQiRyElKj0JgQhCb2CC KHkimuPYjbrmFBsCcjtdYhBUB52Wzxm+ZrHm5U0OC5dA53L4Ot95lqE4IpeSumVD46KAH X-Received: by 2002:a05:620a:4110:b0:92e:6430:3c73 with SMTP id af79cd13be357-92e9a385325mr1203158885a.21.1783288852999; Sun, 05 Jul 2026 15:00:52 -0700 (PDT) X-Received: by 2002:a05:620a:4110:b0:92e:6430:3c73 with SMTP id af79cd13be357-92e9a385325mr1203146685a.21.1783288852171; Sun, 05 Jul 2026 15:00:52 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , alex.bennee@linaro.org, qemu-s390x@nongnu.org, Magnus Kulke , Zhao Liu , qemu-ppc@nongnu.org, Paolo Bonzini , Xiaoyao Li , Richard Henderson , Mohamed Mediouni , Peter Maydell Subject: [PATCH v3 26/32] target/arm: Inline check_watchpoints() in arm_debug_check_watchpoint() Date: Sun, 5 Jul 2026 23:57:22 +0200 Message-ID: <20260705215729.62196-27-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260705215729.62196-1-philmd@oss.qualcomm.com> References: <20260705215729.62196-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfX7b+IYrzeEvWt 3ptHNNeXHKQJIx1xYVbiixjlpHiQ7dU+LXLxRvEmxmhZoWs4lRh9CTvqM6z732bk1DbQGw58l7N 9Yt/LCBPmKRbm6qBqYvGJWAvsBDUcBz/fPiEidOQoJHhwC0Bk1eMPN9sQwPSB0y0JK9WErp2l1q AwbcFmYYaYB5nHfi5+oQ5X6KuxQLJgLY6Sn09elODIu4Wd5eYpx72JkXzAG/mnahKk80tTydnq4 Ebcz66ShH7HiTaPaGntGh30JFbuiWhOYgIohnqdYp9EziWRUreqczC6bEQK46T/nlR5EJVG/RHc rOORfX8WX+JBB4k+8C8dBiuPGMaUsox36/oqQRAA2yhUDgsDa0aw80QNEJOi8GwdgAVWDBT2Uai 2FwbVqqE9/qzJXxTSyoKKt/4XsCP9oV2x2CBe5vHJ9wOKZSOiWZG0MBIWhArhqq3UdLnuUurYw7 O270H/vERjWRbsr6EZw== X-Authority-Analysis: v=2.4 cv=VvITxe2n c=1 sm=1 tr=0 ts=6a4ad415 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=FSafjcPV3XuXVNEPM0UA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: vJXQKP2of8585jT9F1nCvJZ6xXDoIpRr X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfXxaIzYzi5KE/Z +ri3Jgyi69z5mfwU0Wf+ZFuz+77zYid6/cVm1kgigUP4L5NX9oYSOvZZ2RKlqzUXzFBUmaOVBYl kF5GF+uM5p2vzEU3dL/zWjFtWAXmX4o= X-Proofpoint-GUID: vJXQKP2of8585jT9F1nCvJZ6xXDoIpRr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_02,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 suspectscore=0 bulkscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 clxscore=1015 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607050238 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783288979241158500 check_watchpoints() is called once, by arm_debug_check_watchpoint(), which doesn't do more than this call. Merge both. No logical change intended. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/tcg/debug.c | 40 +++++++++++++++++----------------------- 1 file changed, 17 insertions(+), 23 deletions(-) diff --git a/target/arm/tcg/debug.c b/target/arm/tcg/debug.c index 11043ecd589..7171501d400 100644 --- a/target/arm/tcg/debug.c +++ b/target/arm/tcg/debug.c @@ -351,28 +351,6 @@ static bool bp_wp_matches(ARMCPU *cpu, int n, bool is_= wp) return true; } =20 -static bool check_watchpoints(ARMCPU *cpu) -{ - CPUARMState *env =3D &cpu->env; - int n; - - /* - * If watchpoints are disabled globally or we can't take debug - * exceptions here then watchpoint firings are ignored. - */ - if (extract32(env->cp15.mdscr_el1, 15, 1) =3D=3D 0 - || !arm_generate_debug_exceptions(env)) { - return false; - } - - for (n =3D 0; n < ARRAY_SIZE(env->cpu_watchpoint); n++) { - if (bp_wp_matches(cpu, n, true)) { - return true; - } - } - return false; -} - bool arm_debug_check_breakpoint(CPUState *cs) { ARMCPU *cpu =3D ARM_CPU(cs); @@ -426,8 +404,24 @@ bool arm_debug_check_watchpoint(CPUState *cs, CPUWatch= point *wp) * is also an architectural watchpoint match. */ ARMCPU *cpu =3D ARM_CPU(cs); + CPUARMState *env =3D &cpu->env; + int n; =20 - return check_watchpoints(cpu); + /* + * If watchpoints are disabled globally or we can't take debug + * exceptions here then watchpoint firings are ignored. + */ + if (extract32(env->cp15.mdscr_el1, 15, 1) =3D=3D 0 + || !arm_generate_debug_exceptions(env)) { + return false; + } + + for (n =3D 0; n < ARRAY_SIZE(env->cpu_watchpoint); n++) { + if (bp_wp_matches(cpu, n, true)) { + return true; + } + } + return false; } =20 /* --=20 2.53.0 From nobody Sun Jul 26 11:01:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783288930; cv=none; d=zohomail.com; s=zohoarc; b=XbtSh4jzsFtDieEleeQd0Qs4Y37zDhTKqbk9t5I5L+KJ86UmsgpFSrRD9iDrvtAGM1qFSuDvAzVOXPb3IBq8Cf5OD9QjA6RiSON1sbgWBK3L++4X87ErQioia4e2hZGYQZd7why6kE2WsyQOkxNWB6jJGGdGgGf8HozHXwlNins= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783288930; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=nKWbeV6dy1QzTcg2r2krTsk35PC3Q8z5Zx1L07HjdlQ=; b=nSvbFWjozbtwMo04wyfzw6ZDNDH8MwC6sGcFhspX77DwhUVlK6HhVD3l8ECbPJNLS3IZoVAuFoQtb+xa11kuvDFQYDOOx5DdHPqUMWSJoR3Kx16eUDDyBh8jA5QIBQXLquCF1/shvB9H9iGFBIm40WHMdOjMcb/tTQ/b8tBfVTE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17832889299973.1946796807784494; Sun, 5 Jul 2026 15:02:09 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgUuH-00048G-Oj; Sun, 05 Jul 2026 18:01:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUtn-0003y5-RO for qemu-devel@nongnu.org; Sun, 05 Jul 2026 18:01:26 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUtl-00014c-8c for qemu-devel@nongnu.org; Sun, 05 Jul 2026 18:01:15 -0400 Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 665LxU7a2786998 for ; Sun, 5 Jul 2026 22:01:02 GMT Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6qhnku2u-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 05 Jul 2026 22:01:02 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e59b0e0f4so167827885a.1 for ; Sun, 05 Jul 2026 15:01:02 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa0960af0sm17731708f8f.30.2026.07.05.15.00.58 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 05 Jul 2026 15:00:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nKWbeV6dy1QzTcg2r2krTsk35PC3Q8z5Zx1L07HjdlQ=; b=V+5NbQqexvTy+QZz tkTDVHQUWFI3gNoM7fv0Sll1+XNc6+8X/jQiVo2MwTiJBHx98JXPF8CFHoGmd/Qp srisZHHHhdLyZnFeAhFMKi93lkB0nb2x9Y6vq0yf2z8uxh7E1dKy3jBcLlQBX572 SHGbvPvB/PUK1kayIpsE/0Vk64LITM5PlfrXSWojqKEtYVClNPa82aciDGCWdtiw lbeSIh0rRXBInLS9p4qr5HCJVy0VtPsk9BSpAtNuM0EFNioI7dSf80TsaVaMbaPM /zF3Y4Pn+TRjdoofjtxV1fqa+uZeNttLDBzCmG8VD6hcBQJG563no2h30X8K7cIS c+dm2g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783288862; x=1783893662; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=nKWbeV6dy1QzTcg2r2krTsk35PC3Q8z5Zx1L07HjdlQ=; b=Dr9yLh05E6WYuPV1iSTT6sgf82MVgD9X2Q3D30UzA+G+fOLF8gk37NAC4uNCn6xbAt PxVIqs9yFi75VQwTMBa282/r4j40dUqi5DOwR9BNTlAFlLeO8KUPGP8jv17oaQBXpMmR w4mQMSBDNs6vb+fCcwA0Ge0x4YAZaTbCVmcDwXfRLTUhLETg64keslSm56aZC5sg1ffm LegIhdzbxFkm6yBM3qUMu75LcVyNhWcpWQh3CtSeVryH7VTJzmaOBoc1HQwSGnAUFYFQ ko4rl0GA4pp0g+Jf/2R0Gm6xXzV2GMvz48s9yT9xmh7w6vd1ySq8KVeSHgf1y5T6QdjT qwtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783288862; x=1783893662; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=nKWbeV6dy1QzTcg2r2krTsk35PC3Q8z5Zx1L07HjdlQ=; b=TlKRzdH/69F0MUH9ln2YN7uMHXAVG9xxpconhzJdZ+jaKzKnpIWa0vCqnua6jAt0lT Fz5H4BNTG4J16PR3akGSzlg2wBoIPme1Xfry1O1Lo4ErRXsEp4m3ed1XdmkcDC1DOOeX qCv24o8rgUPCEWZVKvNLQAEle9pU0Kz1rkZKUrZAcy4Mgym0HdQb98iU5b07kDgJbKpM 5DRzeVEkb/qZYPyQv0+AqvMyCmVTnlWn4M5gQWvVPkm+ddVZb6J6JBiAWHlRnbevojpc kBuDBrQWT6oy8s8W4JJt7PR3pUGjR9J4FCDLKYhiZrGOU1gAJpu+kj8VrDTcgbKtI8O9 Z41Q== X-Gm-Message-State: AOJu0YzbcBKsq51Ll1Q0J/9lQo8bFM7AB7Z/3fVrWj0B6lnYFsj3Ww+9 TpF2V25LuEl8orbOwu/+jwlGjW//TSIHk0GWsY0UHG+vsDwMGIJeL723bPEDEf8YtoIrV1BQ2pa GKFiijNob46x9nX8xh/s5RAuepCXBB3nS5OhowBW847n0sIWdJ11qKP3oxDDNSakx9g== X-Gm-Gg: AfdE7clERtt8EzXNPe/QO6sou4j6y3BbDv4bhEwFI5Sie2dxT1H/Q6YZ4G6SoG0wdPG 03tOIJ8Ppr6cBANmPq/SqRBseMrWDHnj67tlKQ++tJIE2fW9Reb719rCMK8fd1Wwl+zt8LwT2Dp Z9r6Eznh+6UiwgRy6uixtdqeBLNuBbTFHhM2Zs8J95KQsGtGuTv1NKOeCVmX76W6xpsnkXbAmvA 3C3hR4e/lC4Sp9+8Df7KGud0gXdYMpxWUu0Hy6ezwiltb8b9LYjzwMj5WSaPwSE95zd5a+DVp59 sGcFD6sr1OLwg84tisB+jIz+bHbIDEF+elVW1ptevTubvhC8YOM0qeHa2fckBzHMlvtGVtWHb/+ 4PrPXBwUnYoThXwpzkfBWCL8rvRusdoG732WWiDjQAKJrYiueK1grvA== X-Received: by 2002:a05:620a:701c:b0:92e:5259:1154 with SMTP id af79cd13be357-92e9a48ff9dmr1053791285a.39.1783288861435; Sun, 05 Jul 2026 15:01:01 -0700 (PDT) X-Received: by 2002:a05:620a:701c:b0:92e:5259:1154 with SMTP id af79cd13be357-92e9a48ff9dmr1053775085a.39.1783288860320; Sun, 05 Jul 2026 15:01:00 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , alex.bennee@linaro.org, qemu-s390x@nongnu.org, Magnus Kulke , Zhao Liu , qemu-ppc@nongnu.org, Paolo Bonzini , Xiaoyao Li , Richard Henderson , Mohamed Mediouni , Peter Maydell Subject: [PATCH v3 27/32] target/ppc: Ensure TCG is used in ppc_update_daw() Date: Sun, 5 Jul 2026 23:57:23 +0200 Message-ID: <20260705215729.62196-28-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260705215729.62196-1-philmd@oss.qualcomm.com> References: <20260705215729.62196-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfX5WM5LXTZoi2e qpK/9JgBYl6/ZdnNcvUa30l4PkuDj6NJSFvLlTwu+M1C+d7zzKYjb6jyhiVepU3uY1ZEd6AmtaH k3Y1V+d/mR4a/4wvpxWjwP8NgM9FTFQ= X-Proofpoint-ORIG-GUID: ck1x0H-PqHCC16CySwUWcn2ONm51eLow X-Authority-Analysis: v=2.4 cv=J+yaKgnS c=1 sm=1 tr=0 ts=6a4ad41e cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=nS8E-dRYisaDM6zJQEoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfX18/v3ssknxwm ipjlionqH4BVQwaR4mxjTmQ06GtkhseFwa/bUAr5Wpv7jU97HuPblY/jmzuY+exQgSyZCwMZhON HDepsGaCstStlml220S3zUVHRt9jnr9DSAc+e/q6XEkeldAcKYFKM6rNoRLJulf6QLcZxoEQl6o IUBKmqXitEtGHW7dipg1VsxaM2t8ku3PBOn/LX3fHeOjODPRYKGwQ8UTBS/B5NuTuWpiT5Igw1H 9aHwUjdFRPBqMieTCVB0cFvuodzMNTblloRE5uZDiT1z/3nQ7sy9znukNb2xyF8YhSluLvE067o rkwOcdUK3YJGi0BoeBWO8TNWpwjClQaZTuTQSCw+ssLidvQkcE351p2WmhqX9kP+CU0EHtO4PJE DLMTU3zwFdkMt3TO8oYoO6swnz4fZuESm/d8GBO9fI/kTSmtgHfLH/iFenW3y+tbAAhCsgeNZeO IG40JTHPkahyKWs5bhA== X-Proofpoint-GUID: ck1x0H-PqHCC16CySwUWcn2ONm51eLow X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_02,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 spamscore=0 priorityscore=1501 phishscore=0 impostorscore=0 adultscore=0 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607050238 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783288933035158500 Per commit d5ee641cfc5 ("target/ppc: Implement watchpoint debug facility for v2.07S"), only TCG is implemented: ISA v2.07S introduced the watchpoint facility based on the DAWR0 and DAWRX0 SPRs. Implement this in TCG. ^^^^^^^^^^^^^^^^^^^^^ Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza --- target/ppc/cpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/ppc/cpu.c b/target/ppc/cpu.c index 913920d55b8..36e1209119d 100644 --- a/target/ppc/cpu.c +++ b/target/ppc/cpu.c @@ -147,6 +147,8 @@ void ppc_update_daw(CPUPPCState *env, int rid) vaddr len; BreakpointFlags flags; =20 + assert(tcg_enabled()); + if (env->dawr_watchpoint[rid]) { cpu_watchpoint_remove_by_ref(cs, env->dawr_watchpoint[rid]); env->dawr_watchpoint[rid] =3D NULL; --=20 2.53.0 From nobody Sun Jul 26 11:01:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783288966; cv=none; d=zohomail.com; s=zohoarc; b=OL1ciP3u3/HhszCEB4e9zTUeu1qr1ElpGYZbskFhWNkJtukc5TPFCHo4//Jijto5cVFgC3wg+FZ7z8C2dxBOyUQZKRsJ01ke0iYd1fpP8Rzm8REttq0l3ogpfLxwc2PNB/bzWT5r5Th6EMx/Cb5/9gy5hPyWTiFyG1TwzeA9T1Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783288966; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=OJfYBFEk6cqjY+BSEvPVamiQUgD1yf8uocYVw14otOc=; b=Xmm1+d8saXdxO4DrPoR/0fb3nQESwdr57PROQA1lV91Vv2LpIGAK+SQ+i411dkCrbJN1VoWwOROKPDcOdvmc8vqVfEIrO/y92H0UbbDF44atWO4STGD4Ui1B+yoEIO0DBFGYrDbLI7W8f0z86YXJuxwJRiuRZsrSaVVQkeI7vHw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783288966824908.7833117676587; Sun, 5 Jul 2026 15:02:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgUui-0005Cu-7b; Sun, 05 Jul 2026 18:02:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUtx-0003yd-QL for qemu-devel@nongnu.org; Sun, 05 Jul 2026 18:01:30 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUtu-00016F-Rt for qemu-devel@nongnu.org; Sun, 05 Jul 2026 18:01:25 -0400 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 665M0Gx12831793 for ; Sun, 5 Jul 2026 22:01:11 GMT Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6t8ukgc9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 05 Jul 2026 22:01:11 +0000 (GMT) Received: by mail-vk1-f197.google.com with SMTP id 71dfb90a1353d-5bdaa7039d7so3323799e0c.1 for ; Sun, 05 Jul 2026 15:01:11 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47a9de1d91bsm22561547f8f.4.2026.07.05.15.01.06 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 05 Jul 2026 15:01:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OJfYBFEk6cqjY+BSEvPVamiQUgD1yf8uocYVw14otOc=; b=HHfyc/bg+3/l3mYf dXgP0h2dXj3w/qujNr/Acaw6CgrlYKhR/6ONfGR3HBe8wx27JRchoO8Erq9ZZHNI PTwkyPEsg6LTmvoLCjX0AC2xk5IcdnUBVxWej8Sc4bMIHPlitF+EUf5dys3FMLTM 5UBQ/egfJnupYmgrsBFesJ2xxu2AoIF6+D3bLnarWRajks2Is7KOlmB83PWNFxcl Tgly339/YNrZ+w1qfdG2wKWso8KjoUFnDdylGGq53F+jzzt+HjKS1RFwtbekARF/ 7APBHC+XN6NN4Ahx5fgTQq0OwZuTTD9wXfp8eJm9q990TGeyo4zKf8OE5yeHYeBf JsDMkA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783288871; x=1783893671; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=OJfYBFEk6cqjY+BSEvPVamiQUgD1yf8uocYVw14otOc=; b=eAJX8CXz2lViHKS8u1aCCAJVqNWRlcBu2M0gV0wBTFByani4Y+SOGLrdXp9NHB0HML tSQz98gsVAXanMQv2VIN5ZHfcmmm5ykmBTHdCvD3SGya1kFTyTFDNw4mgL6duIO0lH5D UrHG6k5VpedVB7Y1Fyxvx1i7fk5CVt9gonMhUbfNyz5V9QpNp0PfJ1N2xNJMQ8qn58vE OvPmPCq7f29bKXDzfapqD5el1j9I3ypfJu0Ime3gUMeJADnY6V/EYUzJ10pMgyftXZfK xr+ZmOIzpptosCsVyah4LBjUpDkzmNqGT6quAwLJkZ0mjb6Ff/n3fNAqrFD9W0zqMs43 A2pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783288871; x=1783893671; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=OJfYBFEk6cqjY+BSEvPVamiQUgD1yf8uocYVw14otOc=; b=qR9vyg9l8uPG2nnoueh09BPJTOD5fr4pf6ut+M7UWTZKRueruGCZY20iEOpD92kUTV 8AijOVTlxtf+P5oCuzgfltLrUm7lFboUqblMEKjKRnX4RD+FSdqwcuCEBnS3dXrfQmRv B9hrHENK/U7G8ytcZeyUWfZkyfrWoLk1tWQl2NBWCQPEKWFwsbwyNGC3rsvh3qzPQJT9 tH+hUKlKI4YWOXbjPP8jD8GJhONihekEFN+FqzeuE0Z1ri7kWljCARtKHxwHzUV4wzsR fcP4HavrrO39oKJs33yCVBoyLb7rTr1hZAAE4U7J1KfNB/khK3SLcijcz7SJeFdyQoLO cl5Q== X-Gm-Message-State: AOJu0Yz8AZwyY5ospf3oza+21fQK0eoepWSUcL2h4MddLOEm1G4TD3ax 9lnMchxEpmcAeBPfj2aS8vYzPOD8kFuimuRDcmKVDqwtS/Dpo0PVwjY3uIzewJmGFbtM59du6Nn Pr4rpNOo2IQhzr5fRmygXI+rUvvePIFaKLwRMKEhBsFad3ltkZXemzpHu5Q6sNhH+HA== X-Gm-Gg: AfdE7clHh3iUq5c312ivv+6qnXll3IxOLtdQCVwQUy7LTPbU9YhWy905rYO47QBvCEk SAXbJTiXw0oacXucf+TPTCpt5cV4tE0TqGzai7cIzdVDF2KudRCbUfit2pmndhjy6cgdvaDMDPf PMLcGzThI5IYq/wn3+mmvPSw+z9CcmtIuLYo7bSeJtA94DOZtgu9TzntWfSEb8hBvxsy6soMarT +WwGZ6LkiZQf3LrVeGVnPRRywLgZt901bld3AEECodaOCcSmJKXhgH5RgHyey/ym2qs8Srfhv6z 8HePf6803LJjg+WR03yovpGcpZ2P1mF5KevpD/qasGUpcd4U+yY9QEnt2AKK7RfIq8JUjHkjY+u NRRMibV/8wcF0vF51qCdUPRE1p4h7i3pj1hBGjMsUx5p5JdPGNL5EBHXyEjoX1I5pq857 X-Received: by 2002:a05:6122:4890:b0:5bc:58d:ce4 with SMTP id 71dfb90a1353d-5be0fed311cmr3078181e0c.0.1783288868601; Sun, 05 Jul 2026 15:01:08 -0700 (PDT) X-Received: by 2002:a05:6122:4890:b0:5bc:58d:ce4 with SMTP id 71dfb90a1353d-5be0fed311cmr3078110e0c.0.1783288868029; Sun, 05 Jul 2026 15:01:08 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , alex.bennee@linaro.org, qemu-s390x@nongnu.org, Magnus Kulke , Zhao Liu , qemu-ppc@nongnu.org, Paolo Bonzini , Xiaoyao Li , Richard Henderson , Mohamed Mediouni , Peter Maydell Subject: [PATCH v3 28/32] accel/tcg: Improve docstrings around TCGCPUOps::*watchpoint* handlers Date: Sun, 5 Jul 2026 23:57:24 +0200 Message-ID: <20260705215729.62196-29-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260705215729.62196-1-philmd@oss.qualcomm.com> References: <20260705215729.62196-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: juGxcfV1beW4JLyoK9uVdzFsSxNZcmMm X-Proofpoint-GUID: juGxcfV1beW4JLyoK9uVdzFsSxNZcmMm X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfXxjjJa4m4CDev 2uWoeQRx7orFHwZsJzX5zbeX/UIdyMzeXhMQb8hRdgp18bHFL7GtSzidwCPRmTNf305G4WlIm91 VWJB3J/gUi10g9ckj3Q2Mp2MZnDU/+E= X-Authority-Analysis: v=2.4 cv=MZxcfZ/f c=1 sm=1 tr=0 ts=6a4ad427 cx=c_pps a=JIY1xp/sjQ9K5JH4t62bdg==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=oIGtIzObNEvw8K7fi1sA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=tNoRWFLymzeba-QzToBc:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfXxm2+Uf1lrpDL +3Iq4JtgqAM394Bsi4XEVV7CPjQ13/1pTR/Ct0MpzPAq3XmSpEZTUWkmMzAzr/I5/tUDqe/yGON az62AB1cq6UhDzR3m/e/WJN8Wh0sLGyq1Vd1tBCj4nhDEIrOF6Kdd/dN9d2g4V7ITBw3+ipydEL sWt/xzVpXKCHYpxNqySUF8vb/zE8996H9rJ9v3ks4Dkr8yY3FxA274kfDNReU5qEirkkpEQBwdW nqj45zIc5TzgfdttT0GpKtdy8iB3NCEarQHbdKsWCEkl0O4R6YnZL2zo/AZyp9EHN0YkCFTJslz 7HXeysubVm5Y+OoAwXwbx56Ai45/5RseJbAPa+ICrv8EWObZPnxRw/08h7iG2BMn/Ol7dO9SCzX hbuEAI3F/MLdWOkg2iRhR7WYDYjn1BpbgPRaEePGqw4XkkW3CK26SrudTuE2YSi/RMIyv+geyGr BB3mC4GrO1nZItdntow== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_02,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 impostorscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 phishscore=0 spamscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607050238 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783288967175158500 Commit d5ee641cfc5 ("target/ppc: Implement watchpoint debug facility for v2.07S") also implemented TCGCPUOps::debug_check_watchpoint for PPC: make the comment generic. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- include/accel/tcg/cpu-ops.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/include/accel/tcg/cpu-ops.h b/include/accel/tcg/cpu-ops.h index f64d94b2b50..568d82cdd32 100644 --- a/include/accel/tcg/cpu-ops.h +++ b/include/accel/tcg/cpu-ops.h @@ -250,14 +250,13 @@ struct TCGCPUOps { int mmu_idx, uintptr_t retaddr); =20 /** - * @adjust_watchpoint_address: hack for cpu_check_watchpoint used by A= RM + * @adjust_watchpoint_address: hack for cpu_check_watchpoint (used by = ARM) */ vaddr (*adjust_watchpoint_address)(CPUState *cpu, vaddr addr, int len); =20 /** * @debug_check_watchpoint: return true if the architectural - * watchpoint whose address has matched should really fire, used by ARM - * and RISC-V + * watchpoint whose address has matched should really fire. */ bool (*debug_check_watchpoint)(CPUState *cpu, CPUWatchpoint *wp); =20 --=20 2.53.0 From nobody Sun Jul 26 11:01:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783288981; cv=none; d=zohomail.com; s=zohoarc; b=PAltMbIgiqH2AXAIwdtN87bYbOw3BmTKhKVRTFEcOCMDdabOEm3aG2gGOKBZLSRiwBC3FwYOtI63a1aug2/JrL1PXbK8P5jtd2qOJmZRFqPf424oT3rF8OC3mRdq2yATLfnJNRkzKa3CmChnfEusIBQ8VSoR11pssyaUhy31NXo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783288981; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=euJn44qDWZ2TcdTti8/aLCTKwbg3pgDFPtWDEjD8jME=; b=af7o0TYDu8OdvjUv47HneKibAsA2hCjGpYfqyQ6YSwppQyxLOxG7cceHhxvqQxQUu7WZNw+psfjbGX1kyCJU7sjAZ12q48IIBw3NEEuxLlGVy0iQBqSdTTtcybCKf3sb4aTJ/InaYnGVfc5QOYOlNrc0wgkPeMyJjNeQkDeRlF4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783288981843853.5901817640133; Sun, 5 Jul 2026 15:03:01 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgUuc-0004ki-PT; Sun, 05 Jul 2026 18:02:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUu5-00042F-Ni for qemu-devel@nongnu.org; Sun, 05 Jul 2026 18:01:37 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUu2-00016u-56 for qemu-devel@nongnu.org; Sun, 05 Jul 2026 18:01:32 -0400 Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 665LxM4k2646580 for ; Sun, 5 Jul 2026 22:01:19 GMT Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6ubgkc6p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 05 Jul 2026 22:01:17 +0000 (GMT) Received: by mail-vk1-f199.google.com with SMTP id 71dfb90a1353d-5be1c53e800so1762183e0c.1 for ; Sun, 05 Jul 2026 15:01:17 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47a9e4d843csm18354071f8f.14.2026.07.05.15.01.13 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 05 Jul 2026 15:01:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= euJn44qDWZ2TcdTti8/aLCTKwbg3pgDFPtWDEjD8jME=; b=mHpW7np3oGRmql4u Fw5zl63H6dXrBLR2iq4c5dtYcRZ1h+TPlrW1ps1YFmph0GlT9VpK8RCoMfaDliho Nl8U2ZcF/F+lejFeKNnoZofWDkDI2z3PLpWru+hjpCXoRZDyPDv5vPDRlI8nsAZO uaJ4t1L7u/Uy0916hXoTkC5ZuC7dqgezNNm9B7UsDYTx/tXYFLzRdBS7K6rWHkpe Z1ZXgkrg2dzOfzsHjz8WzoPrWPCLVKVDOUkFZ3v6d/qe2i8SHXhgpeSZkdC9Y2BS CEKNSQhFp+bzGi7DhuRKIV20Umf9LAeuY34YIWQPkA1JS2fU63RL7RBa1RUdnF9Z Ogm1PQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783288876; x=1783893676; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=euJn44qDWZ2TcdTti8/aLCTKwbg3pgDFPtWDEjD8jME=; b=XzCUxCU9/5D7FTRyHzaUh6sAvOoMHripFmp4Eb38rP3Cx01ZIK1m8rNx36K1jPU518 729tjCel/FLFEQAsS+VKg2nn0S6Bk6FkuMVAcgljnHC376XiXYPyn+EszQ2L8AwCY0lK GTtwetMhQVUo9A+5He56MqKuuy00hv1DyeD2udEwDvvihon+3FrWsI6e6XSVuE/9nkpc zppJlzeJ0u3ZZTi3vyEhvSeK2SvyEAKcU6u3UUPIwgYMNnB7RqCN2dx2TwjG/fN93koo 3Oy1PbI1nbEmmazm2F3By2KgfUvxEu0tTq6tjJjz9X2ziCX6g3sFhFxVsk1l8upLEkpF xAFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783288876; x=1783893676; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=euJn44qDWZ2TcdTti8/aLCTKwbg3pgDFPtWDEjD8jME=; b=tNWMhOTr20f0yeaqp5WSEzqfkypiCoqZ/aYLvr0WzdSxm4zZI52h/9aj3x9ce/0Hlo r/pq33b/3E2kUAt27Cn1NupwewTJk/uU1n4r9zjq5YR4ZZC0OPlE2SWbqKNlmqYlFDnU 3XCbjlOdAX0reeADsQlgPaWYHgnQT8q55X4G4UPBQh1cwGmhKBro2KEQk8WBPAxG9l+d pgUOC9q+UabO8CJTsstnj/cHGusJ0DWaH8zqBcsfWZ5EzMEwrfc4SbES589vQY1Gv4Y2 P4ofPpd0Y6Y4v4rW2cXuJoecNzeb85cRDQYYZqDnupd0VYlAqJ3Z5Jcbfs1fBRLJoXQ0 QGug== X-Gm-Message-State: AOJu0YzAOCuMjNbTbHb3QQD9RAbTdqpdUWjpBB2x9nwOc5kd5ykbhPqF TnHIzObLPKFD4mtCBq1VWIVWbteI0xEdjQipx26bgG3aONxDH+7VFIde1BhhN4OndNES6k1T7dy TJ3Dq2xd+NyLL7fEJR1FPpMLwmqM3HEsB8Fi3hGIezx3Nza30iBoc8r69kh0GJeCxGg== X-Gm-Gg: AfdE7cltYuznsBho73eykySokm5s8Ln0Kl+w1ckqn3IxI8obRCZ3llNNiCx2W/n5p/6 YBfdDtsTE/uYFNDjhBFyLGNMU1kbRa0mvpfE593L/0UPFuH+/53klsclLxTY9aaBiN4MEGQ3Yqx 7ztIB5LczSes58+9UVWRCc425nLclaeHy3VF3WbhtLicF3S9o7B5yeQJt4NKeHw10b1GTYkQykV 9ufw2RXBdFE3fxuC93xkUC1Q7GfbtLcddY3JxlWQvXQB2Bsq1LFUpHiBE9tcL51d3OQ5nLFxOpn jAaG06HSa+JFeDO0JWsecikuUPtwxSXEr70FBzA2b3U/FzuN13skjzwwAFP9bmnzISrAvHJO/EE mDkbtL8qVZr44fu+rU1BCLsigLvdHENFawwNV0tOAgOIQfhhdE1zbW4WtASoXAtLOdLoM X-Received: by 2002:a05:6122:e267:b0:56d:451b:e4dd with SMTP id 71dfb90a1353d-5be10381c7dmr2612930e0c.12.1783288876575; Sun, 05 Jul 2026 15:01:16 -0700 (PDT) X-Received: by 2002:a05:6122:e267:b0:56d:451b:e4dd with SMTP id 71dfb90a1353d-5be10381c7dmr2612883e0c.12.1783288876158; Sun, 05 Jul 2026 15:01:16 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , alex.bennee@linaro.org, qemu-s390x@nongnu.org, Magnus Kulke , Zhao Liu , qemu-ppc@nongnu.org, Paolo Bonzini , Xiaoyao Li , Richard Henderson , Mohamed Mediouni , Peter Maydell Subject: [PATCH v3 29/32] cpu: Better name cpu_single_step() trace event Date: Sun, 5 Jul 2026 23:57:25 +0200 Message-ID: <20260705215729.62196-30-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260705215729.62196-1-philmd@oss.qualcomm.com> References: <20260705215729.62196-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfX2QJD2ZwG4H4g Lf4ebr5DhG2CAIwPnoLRjO+QyKTrE30rZjCK+rRt2S7pLd+fh3VJO1+C1iTGPB8I4B9Rl+l+QN/ Yb7iMsbvPRUwp9RRQ03/2jwoMFttZ7E= X-Proofpoint-ORIG-GUID: I2bWXMdAsVwX-11-uaV_ctls0nllsBD4 X-Proofpoint-GUID: I2bWXMdAsVwX-11-uaV_ctls0nllsBD4 X-Authority-Analysis: v=2.4 cv=FJwrAeos c=1 sm=1 tr=0 ts=6a4ad42d cx=c_pps a=+D9SDfe9YZWTjADjLiQY5g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=fWCg92Okmkq_k9tJrKMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=vmgOmaN-Xu0dpDh8OwbV:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfX5XTJL4Ecj7UJ uUdTZRU9Pmp++7UJ5MfQUCwVSl34qywcljzmskCmA+uiF15ygp6Y/bM2bdePpOOycTaC7Id+9FL KJcbkjawSNQoqfv4Y8voNP3pFhyDkoTVLe+OaRQ3OxF+9srrxEjBkrxcvRHGq44r1Ya7AvOJlwy TNzE/z9N3SuMCgB32n5k5DLAba9IArGiBaYrAJFm+1mEVT86xKuxoFuHv1xQ3OiEDZiJMirwHxW Z/5gi2x9YyXsCltiwsS2lOc09I0ZFe1wzmHtzitornGL9LDQdjD5lycbAsyF9a6tCW0kDYhvAs9 NRlvv5GgEseR9wbNKTCzBV5htVhwX9wfBczT3Xz41aEAFCHewThJ7rxmvbQw3Vtnc4KhbpsiOjs YW44VRyUvYLhSV0HcAFt+X4WIzGoUYKUfWa0f5iL8uXh/zdCmKF6Pe57r4X70ahKEb8m5DuLQSH lFXHjS4r6+Rjtpmm9ow== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_02,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 priorityscore=1501 bulkscore=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607050238 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783288983233158500 cpu_single_step() is not related to breakpoints. Rename the trace event. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza --- cpu-target.c | 4 ++-- trace-events | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cpu-target.c b/cpu-target.c index f030e2c642e..019906b32eb 100644 --- a/cpu-target.c +++ b/cpu-target.c @@ -31,6 +31,8 @@ void cpu_single_step(CPUState *cpu, int enabled) { if (cpu->singlestep_enabled !=3D enabled) { + trace_cpu_change_singlestep_flags(cpu->cpu_index, + cpu->singlestep_enabled, enabled= ); cpu->singlestep_enabled =3D enabled; =20 #if !defined(CONFIG_USER_ONLY) @@ -39,8 +41,6 @@ void cpu_single_step(CPUState *cpu, int enabled) ops->update_guest_debug(cpu); } #endif - - trace_breakpoint_singlestep(cpu->cpu_index, enabled); } } =20 diff --git a/trace-events b/trace-events index faeba6242fa..ea1d2b11a22 100644 --- a/trace-events +++ b/trace-events @@ -28,7 +28,7 @@ # cpu.c breakpoint_insert(int cpu_index, uint64_t pc, int flags) "cpu=3D%d pc=3D0x= %" PRIx64 " flags=3D0x%x" breakpoint_remove(int cpu_index, uint64_t pc, int flags) "cpu=3D%d pc=3D0x= %" PRIx64 " flags=3D0x%x" -breakpoint_singlestep(int cpu_index, int enabled) "cpu=3D%d enable=3D%d" +cpu_change_singlestep_flags(int cpu_index, int old_flags, int new_flags) "= cpu=3D%d flags=3D0x%x -> 0x%x" cpu_exec_start(int cpu_index) "cpu=3D%d" cpu_exec_end(int cpu_index) "cpu=3D%d" =20 --=20 2.53.0 From nobody Sun Jul 26 11:01:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783288971; cv=none; d=zohomail.com; s=zohoarc; b=D77cqcc1gX2pHVVYvTVXmIzUSA2iA7S3Y4VDmeE8DWoKZzuihlb8VIndx/yb5MjgbuCMClIZxQuS+px50PvnRk6Xore59gE54jl59OY+SahsWbcvtO/onHJ7vstkPlT1PMsNLOJr3PQi6+wQkjuYmj54WeKO0g/QMU7nG2JE/Gk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783288971; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=0pnJFY92vkiBpIgSkxERSxVszNDdJxKv8ZacUkDM7sM=; b=BxRSYSOP1XNTp61oVC2pCoko0W/6XVe7g8KCBENBM/JjHveRvaQcl0pn1Ep46IoLZOlYsefEgZ9hwOqvtn3luyHMYAN/S8s1miVI5mkEW/URXoWCxmDmCxmBavbnKLOk2c8qiSAsbBjUTZGGpWLhNCDilCR+FI6NAxbigRyDrDc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783288971227243.8917479433568; Sun, 5 Jul 2026 15:02:51 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgUuV-0004Lk-34; Sun, 05 Jul 2026 18:02:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUuB-00047X-TV for qemu-devel@nongnu.org; Sun, 05 Jul 2026 18:01:42 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUu8-00019a-Uo for qemu-devel@nongnu.org; Sun, 05 Jul 2026 18:01:39 -0400 Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 665LxUc92684051 for ; Sun, 5 Jul 2026 22:01:26 GMT Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6tj8kfmt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 05 Jul 2026 22:01:25 +0000 (GMT) Received: by mail-vk1-f199.google.com with SMTP id 71dfb90a1353d-5ab036818efso615960e0c.2 for ; Sun, 05 Jul 2026 15:01:25 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493ccd9d607sm294448175e9.2.2026.07.05.15.01.22 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 05 Jul 2026 15:01:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0pnJFY92vkiBpIgSkxERSxVszNDdJxKv8ZacUkDM7sM=; b=laFuuHw5RoLrjD6b BpGt0kM6800hfz2aMBJ8wbS7kaW54jwZIauIx77ZZlIF10gOOhAchHyh7WZ0w0dP +BYtAOQQy8SM34G/3GRWsnR8kDA6soL4mv2GBO6KvB8gcvrWX2O1oZM8fABCCmRN CzBd14zGK83Vfbchbp6UQVjexnovmAOPmObk7M6zp47ybDplLvS3IaK+r5KvBSi3 zgi0Jckd+YaUPHfgBlY/J5sz5mz2IOSSPOPo6Gy2Q2mlrdYESzSPj3z4myf4E+s9 cEuWWXdnlrK6pSx2WWnImIB7zilC4VfV0wXPOSjPEo84f4XABL3fBOEmZ8+WtVNH c96H2A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783288885; x=1783893685; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0pnJFY92vkiBpIgSkxERSxVszNDdJxKv8ZacUkDM7sM=; b=BBdMk0HwCpnijy2BILJIS3bkpQzBFzErXLLiO6wRdJn3vIh9mGwuAYGtjXWQcY94qE lZ3LtbeZOR+EW2G9HNRvVHdnQFhjAZ8AfRw5cwfFQa0mqU4Lp0851SF4dqmtqsY4kM81 YfskUT5U/TWHMLDo7dJJK0gFC4/OML1pcilFMW1QOKsP+vh5XTwypVXbJ916yKgpfoa2 k4LBCZxPMebPOmGdgZb+U/IrCfbcixKU6jDRWVIiqBGD9POnYBMiStT2mUcZkEErJxbK GOcm54EI0J3pXZhj1S/sdZbFhXdB2XqWEGOJ4ztj4nREZYpIF6mWOw9RGzGxV8gCcbIO Z1Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783288885; x=1783893685; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0pnJFY92vkiBpIgSkxERSxVszNDdJxKv8ZacUkDM7sM=; b=CX8DVcU1plgioUPTrAsLRoXU4pf8S5QaEHb47iOmRv6IZxUWmOVnF9BTuMXSHG3WuR kf2ig9FC6RYSiCQ2kEQyg8zaodqA2nduauaOmmhe1JCQKH+dj7lbMdmDvNF+LR1gD2KZ RVFcSK+/kU3LPoY0cYZ8Ui1/+DShKlDCPasbZVTjJkdhRTHW7JN+v6hvTXi+cOYfgXJW yLti6IYm41rdYH+tbWSjjgTBde/uBWRteEJuqmqWrMmeQZ2uGLKMu/QYzcsZu5znV6SM i/QthXdpZ7a1Dqo2DpWuAko3gcuhgbP8uSjB7NSjuhlcxPp7oUYLO9Y2kzBu27vVjuO5 JZPA== X-Gm-Message-State: AOJu0YzYLGzxwPJBD42qPubBO3FJXvZR53vImXSA4b3h68Xex38kV4I5 OT5F6GUBDju5HDSwU0+TQPEsD0GpStrIDhT/G3FvALlKJXbsNeye5qsdFM3ytQ/D1t2QamhRisU lT1uL9scZlfnuJoMWUDHP4KZ9yAfr98el7Vtqb4cI2OqNvgT34y5x8mkz1v7HTyEd5Q== X-Gm-Gg: AfdE7ckcdyY9VqUkNlLep5ZwpXQx47TLOnv/7SguLqkeqJxXB9HfMZtmh3UyywCO/kA Nd5nDRMr3221/WqqeYAN8VFB4mAnzQVu4ulJA6si4ANUrCc7UmtJfHVViHf1s8O4oSy/pdKUcqc sa1SxYh6NcJXiR+cWHbcEi3AoQ/NcAjCZ7wv+GdUZqhhoMbHAKj73jos8/C7AHRwcczL5Zs3wJy mxAnopHDCwD1c33UPbIFz85sFPrmjEvGUjaaEPVAQ7CoG0R2IHqXU0NBFUoX+LmaJm2sDToA7Am FgcM8VpkeZVegAIZHwG0sKWIwRbTcho4QJmzHVMwPQ6xa4wBv7brb1Bj1sdL/h/u7vwyTmAcwAG ltrl0txJgkBlaAMulnMIOVP7DRjXDCstWUxebQQdhzuzCrhG/RGqmQmff1ecz2kIP7Nk/ X-Received: by 2002:a05:6123:2e2:b0:5bd:9d5f:d568 with SMTP id 71dfb90a1353d-5be1035a483mr2226045e0c.13.1783288884555; Sun, 05 Jul 2026 15:01:24 -0700 (PDT) X-Received: by 2002:a05:6123:2e2:b0:5bd:9d5f:d568 with SMTP id 71dfb90a1353d-5be1035a483mr2225949e0c.13.1783288883804; Sun, 05 Jul 2026 15:01:23 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , alex.bennee@linaro.org, qemu-s390x@nongnu.org, Magnus Kulke , Zhao Liu , qemu-ppc@nongnu.org, Paolo Bonzini , Xiaoyao Li , Richard Henderson , Mohamed Mediouni , Peter Maydell Subject: [PATCH v3 30/32] cpu: Introduce cpu_single_stepping() helper Date: Sun, 5 Jul 2026 23:57:26 +0200 Message-ID: <20260705215729.62196-31-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260705215729.62196-1-philmd@oss.qualcomm.com> References: <20260705215729.62196-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfX6qduQXzb8RgV yUA19Ucc/dXdYbHGTAzLfrAMeTUxcRC2vUuIfuE6avGNf/1D6OUbVwJNC+OZ9NpXpBNWuSiqsDU BeOQ96aha53hmaiPelV34RP1QdhiLd0Te3lQeQKRNFUs1HkyIEYPVZrB9eWcncYg8cx7VghlC6J PUJZTT/wmBP5R61xpstHTfr/43YH4QfaGaabFukJBWp8/bcKhtNCzEnQOJ30w68IvA1o02YuY4R rG/J6N7IDwjAylTPyyc5yf9Tnd/MHm8JUwUXbxwoxO70IPmkaUz7XgcLrdfkKbTRG9a0XhE2sSN Q1Ojiu3n4PUMDQjBuS7aeV5RNU3A53Yl/xLEo1XRwkST71MWpPHRsEuqImAZOGAZuc4fD5uuGLE WCWzen34pdUJxIUU5WkbTE/LDoQVJeURP8oLdW3hJ3eNb4ciP7EEGmjdNs+zHt7z6Lq5bf+cPjT MB+usEL7hXerZqCSdtA== X-Proofpoint-ORIG-GUID: O7VqmvKoZS56SN9WBHTbWvGjrtazq-CN X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfX/fWPyBhqLu8b enGrS1XggK/05BIVMokxN23m2Msz5YUfTrXVG/p2OqbbraY089i3TUvTAtSCiQAX1UvouJauqFu AqjzDcBA+NILXuNl/fi8K5zOcVivpdo= X-Proofpoint-GUID: O7VqmvKoZS56SN9WBHTbWvGjrtazq-CN X-Authority-Analysis: v=2.4 cv=H6TrBeYi c=1 sm=1 tr=0 ts=6a4ad435 cx=c_pps a=+D9SDfe9YZWTjADjLiQY5g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=UzDBcLQVJa3M_3ASbYsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=O8hF6Hzn-FEA:10 a=vmgOmaN-Xu0dpDh8OwbV:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_02,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 suspectscore=0 bulkscore=0 impostorscore=0 adultscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607050238 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783288973351158500 Access CPUState::@singlestep_enabled field with a helper. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- include/hw/core/cpu.h | 11 +++++++++++ accel/kvm/kvm-all.c | 2 +- accel/tcg/cpu-exec-common.c | 2 +- accel/tcg/cpu-exec.c | 8 ++++---- linux-user/riscv/cpu_loop.c | 2 +- linux-user/s390x/cpu_loop.c | 2 +- system/cpus.c | 2 +- target/arm/hvf/hvf.c | 8 ++++---- target/arm/kvm.c | 2 +- target/i386/kvm/kvm.c | 2 +- target/i386/whpx/whpx-all.c | 6 +++--- target/loongarch/kvm/kvm.c | 2 +- target/microblaze/translate.c | 2 +- target/ppc/kvm.c | 2 +- target/s390x/kvm/kvm.c | 2 +- 15 files changed, 33 insertions(+), 22 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index e70cd8239fb..e53e90ddc76 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -1138,6 +1138,17 @@ void qemu_init_vcpu(CPUState *cpu); */ void cpu_single_step(CPUState *cpu, int enabled); =20 +/** + * cpu_single_stepping: + * @cpu: The vCPU to check + * + * Returns whether the vCPU has single-stepping enabled. + */ +static inline bool cpu_single_stepping(const CPUState *cpu) +{ + return cpu->singlestep_enabled; +} + int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, BreakpointFlags flags, CPUBreakpoint **breakpoint); int cpu_breakpoint_remove(CPUState *cpu, vaddr pc, BreakpointFlags flags); diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index feffca0d82d..963a4edd262 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -3812,7 +3812,7 @@ int kvm_update_guest_debug(CPUState *cpu, unsigned lo= ng reinject_trap) =20 data.dbg.control =3D reinject_trap; =20 - if (cpu->singlestep_enabled) { + if (cpu_single_stepping(cpu)) { data.dbg.control |=3D KVM_GUESTDBG_ENABLE | KVM_GUESTDBG_SINGLESTE= P; =20 if (cpu->singlestep_enabled & SSTEP_NOIRQ) { diff --git a/accel/tcg/cpu-exec-common.c b/accel/tcg/cpu-exec-common.c index e48ea31373f..44e84344f3b 100644 --- a/accel/tcg/cpu-exec-common.c +++ b/accel/tcg/cpu-exec-common.c @@ -47,7 +47,7 @@ uint32_t curr_cflags(CPUState *cpu) * For singlestep and -d nochain, suppress goto_tb so that * we can log -d cpu,exec after every TB. */ - if (unlikely(cpu->singlestep_enabled)) { + if (unlikely(cpu_single_stepping(cpu))) { cflags |=3D CF_NO_GOTO_TB | CF_NO_GOTO_PTR | CF_SINGLE_STEP | 1; } else if (qatomic_read(&one_insn_per_tb)) { cflags |=3D CF_NO_GOTO_TB | 1; diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index d7f91dce9db..0386ac49551 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -308,7 +308,7 @@ static bool check_for_breakpoints_slow(CPUState *cpu, v= addr pc, * so that one could (gdb) singlestep into the guest kernel's * architectural breakpoint handler. */ - if (cpu->singlestep_enabled) { + if (cpu_single_stepping(cpu)) { return false; } =20 @@ -485,7 +485,7 @@ cpu_tb_exec(CPUState *cpu, TranslationBlock *itb, int *= tb_exit) * raise a debug exception. Single-step with another exception * is handled in cpu_handle_exception. */ - if (unlikely(cpu->singlestep_enabled) && cpu->exception_index =3D=3D -= 1) { + if (unlikely(cpu_single_stepping(cpu)) && cpu->exception_index =3D=3D = -1) { cpu->exception_index =3D EXCP_DEBUG; cpu_loop_exit(cpu); } @@ -732,7 +732,7 @@ static inline bool cpu_handle_exception(CPUState *cpu, = int *ret) bql_unlock(); cpu->exception_index =3D -1; =20 - if (unlikely(cpu->singlestep_enabled)) { + if (unlikely(cpu_single_stepping(cpu))) { /* * After processing the exception, ensure an EXCP_DEBUG is * raised when single-stepping so that GDB doesn't miss the @@ -849,7 +849,7 @@ static inline bool cpu_handle_interrupt(CPUState *cpu, * raised when single-stepping so that GDB doesn't miss the * next instruction. */ - if (unlikely(cpu->singlestep_enabled)) { + if (unlikely(cpu_single_stepping(cpu))) { cpu->exception_index =3D EXCP_DEBUG; bql_unlock(); return true; diff --git a/linux-user/riscv/cpu_loop.c b/linux-user/riscv/cpu_loop.c index eecc8d15178..6f27a06da49 100644 --- a/linux-user/riscv/cpu_loop.c +++ b/linux-user/riscv/cpu_loop.c @@ -68,7 +68,7 @@ void cpu_loop(CPURISCVState *env) } else if (ret !=3D -QEMU_ESIGRETURN && ret !=3D -QEMU_ESETPC)= { env->gpr[xA0] =3D ret; } - if (cs->singlestep_enabled) { + if (cpu_single_stepping(cs)) { goto gdbstep; } break; diff --git a/linux-user/s390x/cpu_loop.c b/linux-user/s390x/cpu_loop.c index 67d2a803fbc..25f19f725e7 100644 --- a/linux-user/s390x/cpu_loop.c +++ b/linux-user/s390x/cpu_loop.c @@ -87,7 +87,7 @@ void cpu_loop(CPUS390XState *env) env->regs[2] =3D ret; } =20 - if (unlikely(cs->singlestep_enabled)) { + if (unlikely(cpu_single_stepping(cs))) { /* * cpu_tb_exec() did not raise EXCP_DEBUG, because it has = seen * that EXCP_SVC was already pending. diff --git a/system/cpus.c b/system/cpus.c index b31c825b464..97e5a5edee2 100644 --- a/system/cpus.c +++ b/system/cpus.c @@ -344,7 +344,7 @@ bool cpu_can_run(CPUState *cpu) void cpu_handle_guest_debug(CPUState *cpu) { if (replay_running_debug()) { - if (!cpu->singlestep_enabled) { + if (!cpu_single_stepping(cpu)) { /* * Report about the breakpoint and * make a single step to skip it diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index d5b1966a867..640ef665593 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -2340,7 +2340,7 @@ static int hvf_handle_exception(CPUState *cpu, hv_vcp= u_exit_exception_t *excp) case EC_SOFTWARESTEP: { ret =3D EXCP_DEBUG; =20 - if (!cpu->singlestep_enabled) { + if (!cpu_single_stepping(cpu)) { error_report("EC_SOFTWARESTEP but single-stepping not enabled"= ); } break; @@ -2549,7 +2549,7 @@ static int hvf_handle_exception(CPUState *cpu, hv_vcp= u_exit_exception_t *excp) assert_hvf_ok(r); =20 /* Handle single-stepping over instructions which trigger a VM exi= t */ - if (cpu->singlestep_enabled) { + if (cpu_single_stepping(cpu)) { ret =3D EXCP_DEBUG; } } @@ -2868,7 +2868,7 @@ void hvf_arch_update_guest_debug(CPUState *cpu) CPUARMState *env =3D &arm_cpu->env; =20 /* Check whether guest debugging is enabled */ - cpu->accel->guest_debug_enabled =3D cpu->singlestep_enabled || + cpu->accel->guest_debug_enabled =3D cpu_single_stepping(cpu) || hvf_sw_breakpoints_active(cpu) || hvf_arm_hw_debug_active(cpu); =20 @@ -2882,7 +2882,7 @@ void hvf_arch_update_guest_debug(CPUState *cpu) cpu_synchronize_state(cpu); =20 /* Enable/disable single-stepping */ - if (cpu->singlestep_enabled) { + if (cpu_single_stepping(cpu)) { env->cp15.mdscr_el1 =3D deposit64(env->cp15.mdscr_el1, MDSCR_EL1_SS_SHIFT, 1, 1); pstate_write(env, pstate_read(env) | PSTATE_SS); diff --git a/target/arm/kvm.c b/target/arm/kvm.c index 01f42f42538..d40a6a98591 100644 --- a/target/arm/kvm.c +++ b/target/arm/kvm.c @@ -1492,7 +1492,7 @@ static bool kvm_arm_handle_debug(ARMCPU *cpu, =20 switch (hsr_ec) { case EC_SOFTWARESTEP: - if (cs->singlestep_enabled) { + if (cpu_single_stepping(cs)) { return true; } else { /* diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c index 1e09155e92c..4272b6770c7 100644 --- a/target/i386/kvm/kvm.c +++ b/target/i386/kvm/kvm.c @@ -6250,7 +6250,7 @@ static int kvm_handle_debug(X86CPU *cpu, =20 if (arch_info->exception =3D=3D EXCP01_DB) { if (arch_info->dr6 & DR6_BS) { - if (cs->singlestep_enabled) { + if (cpu_single_stepping(cs)) { ret =3D EXCP_DEBUG; } } else { diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index 11b5d1fc607..634d5428219 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -2266,7 +2266,7 @@ int whpx_vcpu_run(CPUState *cpu) } } =20 - if (exclusive_step_mode !=3D WHPX_STEP_NONE || cpu->singlestep_ena= bled) { + if (exclusive_step_mode !=3D WHPX_STEP_NONE || cpu_single_stepping= (cpu)) { whpx_vcpu_configure_single_stepping(cpu, true, NULL); } =20 @@ -2283,7 +2283,7 @@ int whpx_vcpu_run(CPUState *cpu) break; } =20 - if (exclusive_step_mode !=3D WHPX_STEP_NONE || cpu->singlestep_ena= bled) { + if (exclusive_step_mode !=3D WHPX_STEP_NONE || cpu_single_stepping= (cpu)) { whpx_vcpu_configure_single_stepping(cpu, false, &vcpu->exit_ctx.VpContext.Rflags); @@ -2648,7 +2648,7 @@ int whpx_vcpu_run(CPUState *cpu) cpu->exception_index =3D EXCP_DEBUG; } else if ((vcpu->exit_ctx.VpException.ExceptionType =3D=3D WHvX64ExceptionTypeDebugTrapOrFault) && - !cpu->singlestep_enabled) { + !cpu_single_stepping(cpu)) { /* * Just finished stepping over a breakpoint, but the * gdb does not expect us to do single-stepping. diff --git a/target/loongarch/kvm/kvm.c b/target/loongarch/kvm/kvm.c index beda6965f8c..48cdb78a4ca 100644 --- a/target/loongarch/kvm/kvm.c +++ b/target/loongarch/kvm/kvm.c @@ -1440,7 +1440,7 @@ static bool kvm_loongarch_handle_debug(CPUState *cs, = struct kvm_run *run) CPULoongArchState *env =3D &cpu->env; =20 kvm_cpu_synchronize_state(cs); - if (cs->singlestep_enabled) { + if (cpu_single_stepping(cs)) { return true; } =20 diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index a93f14d6e09..8b219afb5dd 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -1772,7 +1772,7 @@ static void mb_tr_tb_stop(DisasContextBase *dcb, CPUS= tate *cs) } =20 /* Finish DISAS_EXIT_* */ - if (unlikely(cs->singlestep_enabled)) { + if (unlikely(cpu_single_stepping(cs))) { gen_raise_exception(dc, EXCP_DEBUG); } else { tcg_gen_exit_tb(NULL, 0); diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index 6bdfbbd68d6..860fb101e50 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -1616,7 +1616,7 @@ static int kvm_handle_debug(PowerPCCPU *cpu, struct k= vm_run *run) CPUPPCState *env =3D &cpu->env; struct kvm_debug_exit_arch *arch_info =3D &run->debug.arch; =20 - if (cs->singlestep_enabled) { + if (cpu_single_stepping(cs)) { return kvm_handle_singlestep(); } =20 diff --git a/target/s390x/kvm/kvm.c b/target/s390x/kvm/kvm.c index 195e39df032..19ddf59e002 100644 --- a/target/s390x/kvm/kvm.c +++ b/target/s390x/kvm/kvm.c @@ -1874,7 +1874,7 @@ static int kvm_arch_handle_debug_exit(S390CPU *cpu) } break; case KVM_SINGLESTEP: - if (cs->singlestep_enabled) { + if (cpu_single_stepping(cs)) { ret =3D EXCP_DEBUG; } break; --=20 2.53.0 From nobody Sun Jul 26 11:01:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783288950; cv=none; d=zohomail.com; s=zohoarc; b=L7jJ71qDrwPNrpJg73wSAIsX8dU6GAjrJ2sDRjTV0loW/7BZzXwifLZHxk0Dt71oO0cZ0kfnDL1FWtC8p7ex1mwjOKiuH0CCi76NLkyf7WdnDHHU86EVxCuW1KDN7VSUhttRi5jeuhjWwRhPU6P7zWCuD4wFXla5kWpQiwVLG9A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783288950; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=A98+kNoKiQmJ3J78jzxhhEi7R/pYLCHQmvT66NHP/Xc=; b=gefVf900GDtO8h1i/LKFr/612NcN/hbxzT7KFIuGvur1vw742KmwtXnzskUTAD7us4if2WW+Hhp0EZYOHTCWF4GNPA6ORBLS98KveUNVl4tsQ+jdaNiD1rqEde8xR1ZR+uaXxfJpegd2TjJRccytdDz0kfmCDeYQD0BC5bI55ks= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783288950455890.693545789557; Sun, 5 Jul 2026 15:02:30 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgUuf-0004xd-PK; Sun, 05 Jul 2026 18:02:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUuK-0004E1-3n for qemu-devel@nongnu.org; Sun, 05 Jul 2026 18:01:53 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUuG-0001C1-OV for qemu-devel@nongnu.org; Sun, 05 Jul 2026 18:01:47 -0400 Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 665LxKTR2868130 for ; Sun, 5 Jul 2026 22:01:33 GMT Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6s4sumbp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 05 Jul 2026 22:01:33 +0000 (GMT) Received: by mail-vk1-f200.google.com with SMTP id 71dfb90a1353d-5a83b662fb8so3654756e0c.0 for ; Sun, 05 Jul 2026 15:01:33 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47ad69519c2sm19507548f8f.37.2026.07.05.15.01.29 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 05 Jul 2026 15:01:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= A98+kNoKiQmJ3J78jzxhhEi7R/pYLCHQmvT66NHP/Xc=; b=W5jYPr5EoSIWDMGP VKXUsD3ZdF0mw2zrusgXXQRl4UCvw56xLoOO/sjcwzvZbB9kuTC9NW1fUuvdnn3n yC3fT5EQpE+yE1/GCa+95K2V005WmDxJcNTT1vlYh8+FCTX/Fvg7s1X0cHxe/TGB Ycw/dxlH4+mSdXuxkA5JWalUVn/yQ8yrgxxn3bJOPED6+AfLHAPnTMt/PLfp58BX hwlsP1fgDWzfl02k+c9FZUjzbYWCXCKS8XbhW47jLKt452GsZoxY/f6LxH7cPS1W Cjrm8wRGJdwqXDmlogKGOOpyA/KG5f1iCKSKRtuhmoHxvg9g33uueRA60qcI5Q2A SZlPdw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783288892; x=1783893692; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=A98+kNoKiQmJ3J78jzxhhEi7R/pYLCHQmvT66NHP/Xc=; b=Te3X5JBFEniDpqI9/zcN/j18YHQ8FmNbUg7YIRexQGgvT0lJ9VDyOLjT4tv5R3x0KN /FJ6678CbaXE5Xh7XLh5d3uGmASmHF9EXNsbDWAluIVi6yFfy1zIcbkVIxLyr7ywIiTl TBRXF9/89c0/HI4RGieX33vD/0yLm7zeZXaB2IleR/I6VAB0Hl3We+/ORuCRA21a+OV4 M76OhSiCWtYJH5tmaA44YJgFTUvHLNdhdmSUMPdnX9oH5SwaE/BjoFIVps3hE+wUERfo ddyrUIh625nf4kdd9u1Zu/8y9R2oSigy7zEx5vzcmbMLEgrbSyCIma0zCYQ/erFGwO0V 0Yzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783288892; x=1783893692; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=A98+kNoKiQmJ3J78jzxhhEi7R/pYLCHQmvT66NHP/Xc=; b=l2LlsJ+dcPXiqTyRs3iMv4vLXAi/05uYXpW6gj7YZd98PtQGiHTv1/fsMN7547Dj6c 1uXp4+Q9LKk2E0F/sHoeD3Gu7WYcfPciF7gfIjYxRQN4QyT2f1z0IXMrSJ6sOFW9tsz0 /d62QHkEkzumunvRRU+lMxiQ1lwG/2hjZcnsMt5wz/Gf5rEcC/0Vv3kr/rj++icOq0s1 7VAzD2mKA7/Dk5hGDGBjpPuwkmUs90UFsw3COgDA9L1qkbfDpcM4uQgxEvTLPKSGDHUq /GKa7BbTwt7CNZanrRd5cGwi/ejetkxyJaQKgaZko8cKDCYLYKvWTPkpLQCz0hphPeqe pYYg== X-Gm-Message-State: AOJu0YyCGkOU64vy/uMKBTUSlJ08pFCUMKj6tfXzYxw2fCnTcxhLQiAQ Z3YQ4W88+70tDRSZ/iDbrJRgS4GVUm57vknZXm8KTz8WQZLBuxLg+8uaba4ywYnoRUJT4xkQtZU UfzJQqxkZ+ZCRowi8y4i2YWK8z9qUUGXAk0FK0ec8leHbVw3flotDhJDv/wW8al/VYQ== X-Gm-Gg: AfdE7cmnO10/qbUE+L0i7/ai8WqRwXWHCpSng024LStPzTeIeydWzQ1aE6cEZqcl6m0 LNi9VohLBU3NmLioKW/PAw9B2r9BCyFlTJm+AyT6UjYz4D0da/f4geAt+4VEIcqB9MDZg7mSBlQ LRfvm8gCoNbw/vFqX6+6vfDuLpyAeDTca3LubIcNjEsU2it7HTg8V7usDEs6tSmPjadqTC6Dda9 h8d04CFoa8y184HTx7V4NEXjoD/y3KFBnTaI8llYd5ZeDhhpgrjZjwnwkz8ecJqo7p5+Fzw1Fex KLy7uklbPgu2mKE3lOncJ6E8De5TlEbhGRh4s/3uc33LoGQVFVOd7/l1h5QUlY4qwhE4tL+iMQW 0cTG1pp4cdvnnc/ASYxdRnLBSZkvsw+C/c5jdjQ0HOHYVlJc7Q60KnHEWSaQE/9VxS7cI X-Received: by 2002:a05:6122:8291:b0:5bd:bcb1:453b with SMTP id 71dfb90a1353d-5be102a3204mr2978120e0c.10.1783288892067; Sun, 05 Jul 2026 15:01:32 -0700 (PDT) X-Received: by 2002:a05:6122:8291:b0:5bd:bcb1:453b with SMTP id 71dfb90a1353d-5be102a3204mr2978034e0c.10.1783288891395; Sun, 05 Jul 2026 15:01:31 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , alex.bennee@linaro.org, qemu-s390x@nongnu.org, Magnus Kulke , Zhao Liu , qemu-ppc@nongnu.org, Paolo Bonzini , Xiaoyao Li , Richard Henderson , Mohamed Mediouni , Peter Maydell Subject: [PATCH v3 31/32] cpu: Rename CPUState @singlestep_enabled -> @singlestep_flags Date: Sun, 5 Jul 2026 23:57:27 +0200 Message-ID: <20260705215729.62196-32-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260705215729.62196-1-philmd@oss.qualcomm.com> References: <20260705215729.62196-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfXxz9phlI+t0oD uhF4diS3pid1eEaZ0V64xPZnyx0uJnTP2exKP8rc32zDl30SzKOPNfSW6kMvmW87Ct8X9ChF3Sz kgZjDOBTTyRci6UpbRwN5MxkvbJbSPk= X-Proofpoint-ORIG-GUID: g8BWLjFHsrRSuMcxFj1zO2kMzcFPk_Ki X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfXwDWi4cnH7dav ZttHF24ZnFI36TR8B06HOZOw9LxHlbkUmrBE8tEiqZKKTBUH+ld8W9DBvy00N71S8X9X190Dq4z /nHwT8e6/mkQM9l4wZAlolwJ33NWszAQC4KyY289n6/OZtYGNthzCY4ihFgzzqZimH6pl7ttEm1 /NefRB9icb/i7Lrj1bLH0YllSnd2IR7qEkOh7/xqomApfoBQwMwDMoouBTG47y4fvHWO2QW2OHr ygC4YUr7m0sLz9yN9tM8SxwJfi4ZZYJXr2VBzsOkHqWujk76vMmE99CphXyQiXop8F/G1il+MzV 1Yy9oTHCXmFwEaVKNipV5GT3cQZP16ai1dCOwmGGhC355WqkRe8BjUZTPSd6+23jduAeeshBZ/y EQ8rn5V2t5mrr1xg0dEecb0byv3GAcTrRMumOwmjRruJnngD+4WwTFoBN6ydogSUR6krZr6afJb yniXha6U6K+gbths5sg== X-Proofpoint-GUID: g8BWLjFHsrRSuMcxFj1zO2kMzcFPk_Ki X-Authority-Analysis: v=2.4 cv=ZfQt8MVA c=1 sm=1 tr=0 ts=6a4ad43d cx=c_pps a=wuOIiItHwq1biOnFUQQHKA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=Psl2LI6oLFdwa_E3teoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=O8hF6Hzn-FEA:10 a=XD7yVLdPMpWraOa8Un9W:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_02,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 adultscore=0 phishscore=0 priorityscore=1501 clxscore=1015 suspectscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607050238 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783288951193158500 CPUState::singlestep_enabled contains multiple flags since commit 60897d369f1 ("Debugger single step without interrupts"). Use an unsigned type and rename the field to avoid mistakes. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- include/hw/core/cpu.h | 10 +++++----- accel/kvm/kvm-all.c | 2 +- accel/tcg/cpu-exec.c | 2 +- accel/tcg/tcg-accel-ops-rr.c | 2 +- cpu-target.c | 8 ++++---- target/arm/hvf/hvf.c | 2 +- target/ppc/translate.c | 16 ++++++++-------- 7 files changed, 21 insertions(+), 21 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index e53e90ddc76..a841dd4dd96 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -440,7 +440,7 @@ struct qemu_work_item; * @stopped: Indicates the CPU has been artificially stopped. * @unplug: Indicates a pending CPU unplug request. * @crash_occurred: Indicates the OS reported a crash (panic) for this CPU - * @singlestep_enabled: Flags for single-stepping. + * @singlestep_flags: Flags for single-stepping. * @icount_extra: Instructions until next timer event. * @cpu_ases: Pointer to array of CPUAddressSpaces (which define the * AddressSpaces this CPU has) @@ -505,7 +505,7 @@ struct CPUState { int exclusive_context_count; uint32_t cflags_next_tb; uint32_t interrupt_request; - int singlestep_enabled; + unsigned singlestep_flags; int64_t icount_budget; int64_t icount_extra; uint64_t random_seed; @@ -1132,11 +1132,11 @@ void qemu_init_vcpu(CPUState *cpu); /** * cpu_single_step: * @cpu: CPU to the flags for. - * @enabled: Flags to enable. + * @flags: Flags to enable. * * Enables or disables single-stepping for @cpu. */ -void cpu_single_step(CPUState *cpu, int enabled); +void cpu_single_step(CPUState *cpu, unsigned flags); =20 /** * cpu_single_stepping: @@ -1146,7 +1146,7 @@ void cpu_single_step(CPUState *cpu, int enabled); */ static inline bool cpu_single_stepping(const CPUState *cpu) { - return cpu->singlestep_enabled; + return cpu->singlestep_flags; } =20 int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, BreakpointFlags flags, diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 963a4edd262..83cbd120a84 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -3815,7 +3815,7 @@ int kvm_update_guest_debug(CPUState *cpu, unsigned lo= ng reinject_trap) if (cpu_single_stepping(cpu)) { data.dbg.control |=3D KVM_GUESTDBG_ENABLE | KVM_GUESTDBG_SINGLESTE= P; =20 - if (cpu->singlestep_enabled & SSTEP_NOIRQ) { + if (cpu->singlestep_flags & SSTEP_NOIRQ) { data.dbg.control |=3D KVM_GUESTDBG_BLOCKIRQ; } } diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 0386ac49551..257211235db 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -828,7 +828,7 @@ static inline bool cpu_handle_interrupt(CPUState *cpu, return true; } =20 - if (unlikely(cpu->singlestep_enabled & SSTEP_NOIRQ)) { + if (unlikely(cpu->singlestep_flags & SSTEP_NOIRQ)) { /* Mask out external interrupts for this step. */ interrupt_request &=3D ~CPU_INTERRUPT_SSTEP_MASK; } diff --git a/accel/tcg/tcg-accel-ops-rr.c b/accel/tcg/tcg-accel-ops-rr.c index 5b132d3d5d8..cdaa3e11808 100644 --- a/accel/tcg/tcg-accel-ops-rr.c +++ b/accel/tcg/tcg-accel-ops-rr.c @@ -274,7 +274,7 @@ static void *rr_cpu_thread_fn(void *arg) current_cpu =3D cpu; =20 qemu_clock_enable(QEMU_CLOCK_VIRTUAL, - (cpu->singlestep_enabled & SSTEP_NOTIMER) = =3D=3D 0); + (cpu->singlestep_flags & SSTEP_NOTIMER) =3D= =3D 0); =20 if (cpu_can_run(cpu)) { int r; diff --git a/cpu-target.c b/cpu-target.c index 019906b32eb..4783845c9bf 100644 --- a/cpu-target.c +++ b/cpu-target.c @@ -28,12 +28,12 @@ =20 /* enable or disable single step mode. EXCP_DEBUG is returned by the CPU loop after each instruction */ -void cpu_single_step(CPUState *cpu, int enabled) +void cpu_single_step(CPUState *cpu, unsigned flags) { - if (cpu->singlestep_enabled !=3D enabled) { + if (cpu->singlestep_flags !=3D flags) { trace_cpu_change_singlestep_flags(cpu->cpu_index, - cpu->singlestep_enabled, enabled= ); - cpu->singlestep_enabled =3D enabled; + cpu->singlestep_flags, flags); + cpu->singlestep_flags =3D flags; =20 #if !defined(CONFIG_USER_ONLY) const AccelOpsClass *ops =3D cpus_get_accel(); diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index 640ef665593..f5dd7e8e029 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -2603,7 +2603,7 @@ int hvf_arch_vcpu_exec(CPUState *cpu) flush_cpu_state(cpu); =20 do { - if (!(cpu->singlestep_enabled & SSTEP_NOIRQ) && + if (!(cpu->singlestep_flags & SSTEP_NOIRQ) && hvf_inject_interrupts(cpu)) { return EXCP_INTERRUPT; } diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 3f6d326cef3..06ed2adf105 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -198,7 +198,7 @@ struct DisasContext { bool pmu_insn_cnt; bool bhrb_enable; ppc_spr_t *spr_cb; /* Needed to check rights for mfspr/mtspr */ - int singlestep_enabled; + int singlestep_flags; uint32_t flags; uint64_t insns_flags; uint64_t insns_flags2; @@ -367,7 +367,7 @@ static void gen_debug_exception(DisasContext *ctx, bool= rfi_type) #if !defined(CONFIG_USER_ONLY) if (ctx->flags & POWERPC_FLAG_DE) { target_ulong dbsr =3D 0; - if (ctx->singlestep_enabled & CPU_SINGLE_STEP) { + if (ctx->singlestep_flags & CPU_SINGLE_STEP) { dbsr =3D DBCR0_ICMP; } else { /* Must have been branch */ @@ -3645,7 +3645,7 @@ static void pmu_count_insns(DisasContext *ctx) =20 static inline bool use_goto_tb(DisasContext *ctx, target_ulong dest) { - if (unlikely(ctx->singlestep_enabled)) { + if (unlikely(ctx->singlestep_flags)) { return false; } return translator_use_goto_tb(&ctx->base, dest); @@ -3653,7 +3653,7 @@ static inline bool use_goto_tb(DisasContext *ctx, tar= get_ulong dest) =20 static void gen_lookup_and_goto_ptr(DisasContext *ctx) { - if (unlikely(ctx->singlestep_enabled)) { + if (unlikely(ctx->singlestep_flags)) { gen_debug_exception(ctx, false); } else { /* @@ -6559,13 +6559,13 @@ static void ppc_tr_init_disas_context(DisasContextB= ase *dcbase, CPUState *cs) ctx->pmu_insn_cnt =3D (hflags >> HFLAGS_INSN_CNT) & 1; ctx->bhrb_enable =3D (hflags >> HFLAGS_BHRB_ENABLE) & 1; =20 - ctx->singlestep_enabled =3D 0; + ctx->singlestep_flags =3D 0; if ((hflags >> HFLAGS_SE) & 1) { - ctx->singlestep_enabled |=3D CPU_SINGLE_STEP; + ctx->singlestep_flags |=3D CPU_SINGLE_STEP; ctx->base.max_insns =3D 1; } if ((hflags >> HFLAGS_BE) & 1) { - ctx->singlestep_enabled |=3D CPU_BRANCH_STEP; + ctx->singlestep_flags |=3D CPU_BRANCH_STEP; } } =20 @@ -6641,7 +6641,7 @@ static void ppc_tr_tb_stop(DisasContextBase *dcbase, = CPUState *cs) } =20 /* Honor single stepping. */ - if (unlikely(ctx->singlestep_enabled & CPU_SINGLE_STEP)) { + if (unlikely(ctx->singlestep_flags & CPU_SINGLE_STEP)) { bool rfi_type =3D false; =20 switch (is_jmp) { --=20 2.53.0 From nobody Sun Jul 26 11:01:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783288959; cv=none; d=zohomail.com; s=zohoarc; b=VgVE2M/0xgfBbgeGrv9ofsnu8RqhkQq8x6+xPF7SE1i/FJe/2vtP/qn/MR4r6424T1w0RQ0K2S4ct5NngfKbZsXGJBaJomYrA3gwU3faMznofzKTXN+OAnaMaPEzaKoTy9bu7Z6ZtgRLkkUuM1nErWpM0EMPiTfhbpAzTmBBbFE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783288959; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=M3dp04bWiFG6HBjS185iJv16BHEJYGmT/8ByI5DYFTs=; b=PJfZWDmfeYIZHwPzvtNvklu9vKzNmNygEM2DN012b6Qg3+hUpH4BSInjnIa0162SG1zWt/hkNZnc7SZurRRWVBgNC3r3EfaJBG4QdqARed+8I4wBBuSrX/uhVEzgpmQ+oBXlTpOQaYGeEend7K/4V78v+Yee3qkopa3WXRPeag0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783288959581121.4811419907652; Sun, 5 Jul 2026 15:02:39 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wgUuh-00055F-96; Sun, 05 Jul 2026 18:02:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUuR-0004J1-8e for qemu-devel@nongnu.org; Sun, 05 Jul 2026 18:01:56 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wgUuN-0001E7-Vu for qemu-devel@nongnu.org; Sun, 05 Jul 2026 18:01:53 -0400 Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 665LxJfq2839014 for ; Sun, 5 Jul 2026 22:01:40 GMT Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6qvguty3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 05 Jul 2026 22:01:40 +0000 (GMT) Received: by mail-vk1-f200.google.com with SMTP id 71dfb90a1353d-5bde4e69013so1046654e0c.1 for ; Sun, 05 Jul 2026 15:01:40 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493ccb4cafesm220154275e9.0.2026.07.05.15.01.37 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 05 Jul 2026 15:01:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= M3dp04bWiFG6HBjS185iJv16BHEJYGmT/8ByI5DYFTs=; b=l571H5Vam4aNBhJx eMRpcXsNyupLcydu42O7Ip1SMivZxvxiMPPoRLuw8ULmsVfrxVeeXxztlbmD9Nrt //RQBZtqBSkTINuxiL2vfbc9szKxwnTnE0oOWZ4W+P17TFrT3GWzSGHUX9c4s1b8 BWopqCnsRqwu9Ux+BAHS7gOerQJHamq/QKU2lR9FiuC5U3m9gkpWzFqoHCadIcse oG4U4VB1Ta7gITnJME3jMskuPJXEJbJrlteU0V2HzNMvj4+5LsejDO6tZ6vzYDUy 1v4l3dn6dUiEbIkKwBi7MKIOwQkDOehB5QOj507rgAD4I+DxBJdWYDJmvF6rlhuw 3P63aw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783288900; x=1783893700; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=M3dp04bWiFG6HBjS185iJv16BHEJYGmT/8ByI5DYFTs=; b=D/V0ZpTWcUUblgjKuTZCSn2wVQmWa1j19EFUuPskNa6g5f4NhnKosc6vtP6tmobF5e ujt++HqXpz6b/Ibxj0tgRlHh8dLh8ymOjPuInp5pUzj3ziwDldDbviD9FlXZ5ux59oUR 45vg3ezMH8uQXrp9dpkJyPcUMduM+gW9JEmwa79o/Va9isRw4p40BNi3lwPXqYZaZhyQ BRiAvE6th+BS6QMdoi/sU7L7rkd+ft1WlfV7Iu3bVvbmhcrCONdso3IVpR/MhSbCSCrm V4S8J6ahnCifN7PBLb+DUxGR3450UBKPtGYHnzrOgBMTtcGNCy/lRyTuDxA9IoSg+BPH LF4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783288900; x=1783893700; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=M3dp04bWiFG6HBjS185iJv16BHEJYGmT/8ByI5DYFTs=; b=FhSRy4eaDTK93sb0p+r2SUs1cEUwlv4HhdCPNE24qeWrC+OOE3lUK4SU6cfzKereNO Vo8y4F5ayNJ1K5SoAtbxQyLoD5YcRMpcGc4zCO2SUsCRGGD3yaqxLslwhI3I07VxjX2j hCw7xJAqV9xeIIhV6Tqk7QrPs971vvOYuWMDoA9bGFf0n5AoVKa6jHjg8CjpqxhgOmRg /qFxd2AIMOjz+VGl7lLMNEG35RErc6AM3iyZn9V4ZyTmXj427DZhcukyV/L2IWZwKidF bVdPWzJfu+kSrzv8I5DvGIzZ3cLDHkfwmbsRhA9YodhCGFg9P9rlwV+ZYDu7SvrtYWlG X38g== X-Gm-Message-State: AOJu0YxB8KDk+Ub5r8TW3QtgnXVx2DG1YQps8xim9PZHJCMkDY/i3k1k XQswOd3IwKXwzHwv6iyTesTUG55YTeFfCEdUSyFGwBAnb8qJpKaDnjUEHU/JkrJlJDu0PdFaerF W2fodi4PLbiGjB0SCwzWATRFDEs/Z6zf2g10cL8wGn02IwrBSnINCtTqcMi7bWnQBYw== X-Gm-Gg: AfdE7clD6gK+HTSVbOKcCIBCi/qHp8mQ6zrmdxnubvAw4YdQHlH5fGail9zHSJGay8D UojeDZls9l1wgbO8/gLLtVY81JABhde6aJnFvBGhiC6RTJgCybXIU+wHFl5i2srWehUb5qNvcWO altW2AFkHc3Al/D5klAyn/H9fQi1N38zKKFRJVm7UKn2Dzh7NpSktXCZtSDcniGRvYsphG+0j/R MRcflzGzXyQNUXfMyi3P34u8uQ3/9DMYSPKurdwhvzd4AmurSLTlZbaMFCvaWJ1wlj6I4+EVQtO QjJjpdAidnTV5+zY8DZx6D8HCb1MWn5x30EBW1BA79/2nFV3afm9sH3Jd98d9EHFNe1fIdhyKdl p5eo9y8zK/n4w5kH/VCPa/o2rzNPSAPsR7bZZiZdxI9KVQHmZVWdUllIVdz3U7BKp+iIs X-Received: by 2002:a05:6122:e149:b0:5a2:5669:d6d7 with SMTP id 71dfb90a1353d-5be102da71emr2511219e0c.9.1783288899643; Sun, 05 Jul 2026 15:01:39 -0700 (PDT) X-Received: by 2002:a05:6122:e149:b0:5a2:5669:d6d7 with SMTP id 71dfb90a1353d-5be102da71emr2511136e0c.9.1783288899042; Sun, 05 Jul 2026 15:01:39 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , alex.bennee@linaro.org, qemu-s390x@nongnu.org, Magnus Kulke , Zhao Liu , qemu-ppc@nongnu.org, Paolo Bonzini , Xiaoyao Li , Richard Henderson , Mohamed Mediouni , Peter Maydell Subject: [PATCH v3 32/32] cpu: Only check SSTEP_ENABLE flag in cpu_single_stepping() Date: Sun, 5 Jul 2026 23:57:28 +0200 Message-ID: <20260705215729.62196-33-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260705215729.62196-1-philmd@oss.qualcomm.com> References: <20260705215729.62196-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=VvoTxe2n c=1 sm=1 tr=0 ts=6a4ad444 cx=c_pps a=wuOIiItHwq1biOnFUQQHKA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=67IpyjWKbRJXbWkAkIEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=XD7yVLdPMpWraOa8Un9W:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: 0pZrnw9_duGj-rrX1iOW-oFCXoFBAJF2 X-Proofpoint-GUID: 0pZrnw9_duGj-rrX1iOW-oFCXoFBAJF2 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfX+vsgGoZpcfLd HRmbIirPeTOzyrvlV42JsAh15OM4wvFBV3lJO7a8nfsa5fpCGJGawBsaJyvfBKSEJeKDHUopWBp IszfkQgDXnpah6N7S3ELqyN9mD6IXL8= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA1MDIzOCBTYWx0ZWRfXygiU5jJXCjkf V9LVSDBoo1XRWHNRlCPx2YLs6P9FsKDMEOEEwLOycc6eewYPgH5HFJjYUoWj3zzfMIrEFiO4I4J bo5BQ1jlvdmtByuAomvXWvzif+WfQx907Q4rBBng67CVvRANwiowXyqlEHLovbpmurOw8yvdW83 kXrAtNDwgbyk4Hkx0TMMzlKc9yg6OwC5FBJm2wryTTgy6v+Ryxk9zQ4zWBBS0ikka6fJ/OVDZxK CBEU6dKSN3oJCM7mQLenU5PlpF84iYT9X8NeM5wun1RiZtKXpUEcS3UUldjJs2gyZyrqdBSYU2h /X3pGy1YA0olkA3hOA1xVOiSfY3dKfzWFDKE+HQifbrsLhXnA4JCOGo8H9j6RpghE+q2muISZYT ZDNfm4KbTtsHjJ49iqDrhwJ6+UvXNM28vk2nVLfDvt4oukqGJPXAA424d28yjToUrUsFdcGupHL 6dJBzoArc82rc9c3PlQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-05_02,2026-07-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 suspectscore=0 impostorscore=0 clxscore=1015 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607050238 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783288961154158500 Only the SSTEP_ENABLE bitmask means single-step is enabled. Fixes: 60897d369f1 ("Debugger single step without interrupts") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- include/hw/core/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index a841dd4dd96..fef4a17c965 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -1146,7 +1146,7 @@ void cpu_single_step(CPUState *cpu, unsigned flags); */ static inline bool cpu_single_stepping(const CPUState *cpu) { - return cpu->singlestep_flags; + return cpu->singlestep_flags & SSTEP_ENABLE; } =20 int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, BreakpointFlags flags, --=20 2.53.0