From nobody Sun Jul 26 11:01:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783096756; cv=none; d=zohomail.com; s=zohoarc; b=U8Ngpvi9eMA7Fz5WThri/PS//Eg0hUbzDnpWYZbrZy7FLbmHsGi/kp2efoWZn0QY8hP3urQZ65xjGE01YmQW+tLCNVQa0G2qEY0sEeL0krX3SnUnvkFnlbk5pYlKFSkBxTj4ldfaTEr6xgKQFUgNI9PT37t2Dcc1DaaT8lcwHis= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783096756; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=iximc+qBDNz/RyZclQJYcYQjzkTl/bbNgS8+O8OxcBM=; b=lR+xEv2OmhxvAAqu6GSpTfdknrMuGHwJD8cd+T448fPmdedbZMfPwyh3rPkxyC0iYKHZ4vIkjXqzbKzvavOAvundr5f/xXuOxv0FhnpQRYLai0ZT3pyGJEqAnVahpg6+7SjLuRS+WoQjPmKWlIMmqf/6UEJ+WDZCre9nu+K45Vg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783096756632877.0723548862181; Fri, 3 Jul 2026 09:39:16 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wfgu7-0004nF-SU; Fri, 03 Jul 2026 12:38:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgu6-0004lh-1L for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:38:14 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgu2-0007cw-MW for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:38:13 -0400 Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663GIa4W511014 for ; Fri, 3 Jul 2026 16:38:09 GMT Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6a849k0u-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 16:38:08 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e4f27f49bso58739185a.0 for ; Fri, 03 Jul 2026 09:38:08 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa0f21328sm529133f8f.32.2026.07.03.09.38.06 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 03 Jul 2026 09:38:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= iximc+qBDNz/RyZclQJYcYQjzkTl/bbNgS8+O8OxcBM=; b=EOLUzR0nMLsSEQ6K H/fCPZl+piERbYUX/NqTX21+SPlk2r51uH2C/gQExAZ/FyHcqqgUQ2JHsJz5I+FQ v1/gGTbzjpEnaShCvqL/V4cQpEpC/uOdMoFraUIEXbyCUTbyw2k+wcfewkOovdHM W+eOdzQ7aEsgWtVNddKoY84x42/BAfWCAgxY2heqoNi2tp6K6N0svtSNi/65zCco 106KVKeuGRdGeawhL1dRagxVm89fonBPs/gI3Aqg1FzHcyol4kUx9uAciL4+6LFr B47uI2q3YLmTpI50khmsDZGd6ixjHngpFthtI8ZrpUhuwV4YVc+ddQggT1/I8l+P AIaxfQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783096688; x=1783701488; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iximc+qBDNz/RyZclQJYcYQjzkTl/bbNgS8+O8OxcBM=; b=TDh8wfUYBnqFmI6htWJ6ldfXKxA2jH2pm1v33JwsMkCFWbh8UdJw6324GDBYkIJdnv bPOPNw7M3EDwsc2gUJsxywaBgDlUtS1tkVYx9WNKA/Ljgta25urhw2Ll3TuVg8IDx7XZ /zHRlvWgNFm93WimyJPwSDPv+Mld9+t60ai5yRjIEklN3SY3MBjmVDILcYQSanF+N+hy lhP6xTGAxuFfucHmEWLX+0qG0kPOnlBceCrrCurAXlQHA7zSUFANLoxYoqAgF5tHyK7P qNccFmsCE3Zal+WyovELZ72eoIonaiqUCLl1bJRwKqx0yD857qSpGunc7ZsdKna5BKBE Tg8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783096688; x=1783701488; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=iximc+qBDNz/RyZclQJYcYQjzkTl/bbNgS8+O8OxcBM=; b=GxLNUbgRqOdrCPlKf9uapLhKawKW6U5XhjC8Y4QGgZlS0xTWg6c9FF1ow5V1GGCGat EUioVHzi1uX8ydq7w7mX5Pj8+gkUUdlapMeQX6koS6u9uGSwqcAWJfoWQIAX5aIMbqBO A35x+7f/uDTlJ3yisEsFRzmwayLZc5yUnbl4VNCGhsxzJIzeh8ARAYRpAeNjuNsvrvQ+ NPdwxAPuAtN+HsKvHObXxzVS6d2FB7Cb9I8od03U9ezNv6XKSl7hOwx6mqI5bk5kPHKo QbgcY4OyDjZiKe6W9pKymEDCboRkOQBQNMHgqpbC9Sec7f1cA7aMafCazfFgr5PpmVMm fw3w== X-Gm-Message-State: AOJu0YywoM1iE8ojVemavTqoxmV6G340rKY6bL0GquUHjcfZgxrcDhrO uzFV17eu+FDs5JqB73dx1k5IxudFreJWW7GS/K9CqsxvGwJDSVSm0q8lywhPVufisUZJVCePCJ4 q8OUU05zTR4lldff/T//Uk8nMYBim3rVcqcYWB+2BYHbtBlIu3RrpOfXwR6BRNbPcZg== X-Gm-Gg: AfdE7cmHOpb2dAAdUarwS5jBZ9thSDW2/8JZZKcVdWrrcjhNIeKDw2wdt+dxAQ0KYZU iRqQt2K9jNATQH6Bf7azzRqOYfan94i3AObzLhcoJrjVdWg0r2hIVMt3B6azPwGsqTKu/UwTofb d6bU0CQDyGA7Y9UIwXIehRbFz24uDCaXonyeg8kNzmtTpNE4aOMkAdDtlCMVLHy6xW9ncW16N31 OqJXApSASZaLf4+zaC1ls+IM/00qqiYWDZbVs2fKmHqdO4emeqXR0Q3z2CtBTHXv8i1BLE19iUj YtZ23YZsQVZ7jynZSRwmnVteRnek/FrC+BfBaA6dlZtCyI1nrYTrog6nO+emKeAIUm+aGt1/Krh a3fCeKkDOC1Jd8tZfJJnG52h7JSlXvJZTikDdg5O0XIAJo55zqyfP4qt5t6cSwNGuQx4O X-Received: by 2002:a05:620a:4087:b0:920:bc4a:6d9f with SMTP id af79cd13be357-92e9a3755b8mr29393285a.25.1783096687789; Fri, 03 Jul 2026 09:38:07 -0700 (PDT) X-Received: by 2002:a05:620a:4087:b0:920:bc4a:6d9f with SMTP id af79cd13be357-92e9a3755b8mr29387585a.25.1783096687284; Fri, 03 Jul 2026 09:38:07 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , Richard Henderson , qemu-s390x@nongnu.org, Xiaoyao Li , Zhao Liu , alex.bennee@linaro.org, Magnus Kulke , Peter Maydell , qemu-ppc@nongnu.org, Mohamed Mediouni , Paolo Bonzini Subject: [PATCH v2 01/33] cpu: Constify CPUState::cc (cached CPUClass pointer) Date: Fri, 3 Jul 2026 18:37:24 +0200 Message-ID: <20260703163757.55500-2-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260703163757.55500-1-philmd@oss.qualcomm.com> References: <20260703163757.55500-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: aC0_c4xd2IJt69LOz276lA924IMmXsr2 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX7q0oEA2DGnRo jh2pgrwt7gonvcmcKSuYckE5h36D995ioGz8Inlr9p+fGmoWPwX0aoUlbpU8cWpjKZUcRbHX/lH noRz+sM4j0ZHT5vxfeT9PHrNqsDHzFA= X-Authority-Analysis: v=2.4 cv=a6QAM0SF c=1 sm=1 tr=0 ts=6a47e570 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=pGLkceISAAAA:8 a=O_p9N0DIn41U_kaacwQA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=O8hF6Hzn-FEA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfXzMtlK2Nsj8cJ SbrG7W7riZPaA7MjjiqxF2LlmYN53JWNKtCU+d1lBcaTfGI5PhaC6NCMFRtxz4IpqrP8Livnu1S R1w8tXH9YgAAIIMZL2Kd7c4AkUyEyiOtjF4MYbxh4NFPP+oJwL6qsvKNR2vdgbIUeHm6gfOehv+ aZU98JRgU4Shav8PHhR3BCsMwnFcyFgnS0i/qi83MiixzPliyZng8go/figlrZnmC+fWiklF3fS BSJDsM6Jg8biZp15+U99HIQOzPvG/MziylKzPHqd0P64z2blFIGDgQ0lS1qb9/CFh27QKp3dTUL 7zZZAIkEskMbfOXyeT5/1TSW5pAsB3OdtYvMqzvnSkgix0FWEkM0Rp+HfzZvFnuZkHobuNdw9DY LWGPeXWryrYpwhtT6Qy7wn07amS88EeEMvOmxy5+Jy5ZfKZZE7nlV0edpcrkC6Mq8pdtfXxd9v+ YGu1MJRcQfXGrawv/AA== X-Proofpoint-ORIG-GUID: aC0_c4xd2IJt69LOz276lA924IMmXsr2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 bulkscore=0 impostorscore=0 phishscore=0 spamscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030164 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783096759115158500 Various CPUState can share the same CPUClass parent, and must not update its fields. Protect the CPUClass by marking the CPUState pointer const. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson Reviewed-by: Chao Liu --- include/hw/core/cpu.h | 2 +- accel/tcg/cpu-exec.c | 2 +- accel/tcg/translate-all.c | 3 +-- gdbstub/gdbstub.c | 2 +- 4 files changed, 4 insertions(+), 5 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 59d601465b4..60a23d6f38b 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -480,7 +480,7 @@ struct CPUState { /*< private >*/ DeviceState parent_obj; /* cache to avoid expensive CPU_GET_CLASS */ - CPUClass *cc; + const CPUClass *cc; /*< public >*/ =20 int nr_threads; diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 9c754b03656..d7f91dce9db 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -460,7 +460,7 @@ cpu_tb_exec(CPUState *cpu, TranslationBlock *itb, int *= tb_exit) * counter hit zero); we must restore the guest PC to the address * of the start of the TB. */ - CPUClass *cc =3D cpu->cc; + const CPUClass *cc =3D cpu->cc; const TCGCPUOps *tcg_ops =3D cc->tcg_ops; =20 if (tcg_ops->synchronize_from_tb) { diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index 3f1a3a28438..328d96aba30 100644 --- a/accel/tcg/translate-all.c +++ b/accel/tcg/translate-all.c @@ -575,7 +575,7 @@ void tb_check_watchpoint(CPUState *cpu, uintptr_t retad= dr) void cpu_io_recompile(CPUState *cpu, uintptr_t retaddr) { TranslationBlock *tb; - CPUClass *cc; + const CPUClass *cc =3D cpu->cc; uint32_t n; =20 tb =3D tcg_tb_lookup(retaddr); @@ -591,7 +591,6 @@ void cpu_io_recompile(CPUState *cpu, uintptr_t retaddr) * to account for the re-execution of the branch. */ n =3D 1; - cc =3D cpu->cc; if (cc->tcg_ops->io_recompile_replay_branch && cc->tcg_ops->io_recompile_replay_branch(cpu, tb)) { cpu->neg.icount_decr.u16.low++; diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index c3c944e965b..26366acb674 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -578,7 +578,7 @@ static void gdb_register_feature(CPUState *cpu, int bas= e_reg, =20 static const char *gdb_get_core_xml_file(CPUState *cpu) { - CPUClass *cc =3D cpu->cc; + const CPUClass *cc =3D cpu->cc; =20 /* * The CPU class can provide the XML filename via a method, --=20 2.53.0 From nobody Sun Jul 26 11:01:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783096759; cv=none; d=zohomail.com; s=zohoarc; b=LY+Bwol3yu7mBXhy07HHNEfGUgC1Fkev9u1i8kC9riEdmcifnf1JkY6Q+SyLY1ZX633SvfJKK4oo+8aQYKnknJ37tkpfnCYv1/rkwnlErTcfSfiXH2KPgcbqvCGbSJusCXzi2UAttKRuEyj/OvkDO4dBKdtCRwaQnJ6zTWRARJo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783096759; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=baUNmRqXOkPRQ+AyufyGcZ9igaejjEE6RFXBGnD67zY=; b=RJnKZ+1/G3OtiWfrXgS+YtzfWMP6tYly+2VJxzVFNZ025YMkYWOG/2Wdd84taitzxknZ2H5/I3AVsExbEC8AkODtHBvZlzW59x9C/fACttEuYbRa5LCajywWnnb7tgFtRR/VKHbBaBoitebiFGYWt3yDbw5XfYYOO19OxgJ/WiQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17830967596021021.3115051010371; Fri, 3 Jul 2026 09:39:19 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wfguC-0004oK-I9; Fri, 03 Jul 2026 12:38:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfguB-0004o0-2W for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:38:19 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgu9-0007gx-Jq for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:38:18 -0400 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663GIUvD488825 for ; Fri, 3 Jul 2026 16:38:16 GMT Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6ckj0ymr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 16:38:16 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92e5e38fbc5so63456185a.2 for ; Fri, 03 Jul 2026 09:38:16 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c63ba971sm223584525e9.13.2026.07.03.09.38.13 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 03 Jul 2026 09:38:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= baUNmRqXOkPRQ+AyufyGcZ9igaejjEE6RFXBGnD67zY=; b=XluDBY3JqiIj3Mp4 N1Z+pzbkd7KLdhZERM5L6Fk1rfUx6oPZ2yBEQAmhEo+YWTzQjO/v5jDOMW5LPkJ9 mfSCbjOXGAOItrCe/ilaAhKY4F9MX/0JIrqj9VCEICxQ8krRop86H9f0MefWmoJG Sn6ZV4b0/XOqRBeXLSlTaEsHCS73W+pqrKcYj3fQRny854jMTilwb9LyZ2J2blTF SnXOQcyISyhaJ5Rbe//q0DuFXoEvIPTJf7uZy7qEFR7BAr91gztCRkPvdrl+lIvy 0qTcDFS9Alrfv/iiADsymdME8WtdnKKEYgJhbsTFivqXBxqUic48rImyy1WmNZpE NBAaQg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783096696; x=1783701496; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=baUNmRqXOkPRQ+AyufyGcZ9igaejjEE6RFXBGnD67zY=; b=J4g5lm42yKWz415r4z2S78pN2+n1J/f3c14ab0xyTpPUefUxGdu33puPshhOw1+E9G oPkPt51s1FnleHuicoyeWr+sJYi9VHtMaf6yygcF2n5B1+yhsPgjv1ifJ9S20tzpd6kN NIi5KEKS87Js6emNro/zowDzOCijBv2VjvENa5At7mfinlIXhzjlE9sLHtkMNkhZ9o1D kJpocfbMVMsWDOaKoitIKKB54h4SzRahUQzgl8c8vfhXlZgZiwVu/oDGfk8mIrXmFIaB u8icsH/4SWFh89R9tiO28YziY6zUjtIB0wEm6dHyjfz7ar1vb86pJ1ggS5P933cI65Rk wT0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783096696; x=1783701496; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=baUNmRqXOkPRQ+AyufyGcZ9igaejjEE6RFXBGnD67zY=; b=tO1Vz29ZFoTy1iKFgTbcC+DRPWqD+w/sXr6AAi3D10F3YF6/TKZt1Q605RhBhB8n6M kn2b8VYWqe7jL2wl7SQnVMwz4VlDaf/K89YTzSNeoV/p2tQVe71t3dQWtmXnV49b2iG7 ZB2Yd0W0zh9WhDDu06MyQDOirmcVK68PzTcY60gPfHuYkmYwUAGYFw1nItDSR20MtEQ/ lWHCRnAu4lH8nTIGMX8v5UVcubBn0wUinyksl00areVbHH9biCn5a1I3hosxCdm28uNG 0Ub/nRrThnxa89pbfiodCCCyW2evVh8xyKg8YmVBEygAL4/wKLIxUZ32hn3OK4fIOdjJ jr8g== X-Gm-Message-State: AOJu0YxR1bEWdJWGsKOSS8LL6/lyS55KlvVUMB/+MU5k+sQNW7lUVcRG xCeB3DFePgbLHcIUYoBshnLcHtkvoIwWlfyVR69GquYhQq6WdQ+8kRGW9zL4DKTHWehHdMb4MyQ rTOGl7Z3ZkNDD0SC7PAAd0LT54uFPQaIqn8ABjTwcqHAtzoVnbhzhkWrW1elQJH1nIA== X-Gm-Gg: AfdE7cm29qRy77c6nROge+/8TOOqjdUa72ozrm0BAHTh4n77bUbEUPFturTh+rOBaag iguqjEg4qk91aKzeefO0m3WTEAzdOU+GTcpyhdzg42/+8U3jh57EmGLWC21wvVtQuYNKE956Vik pE38zNszJvX4FPFyropK4Av2Mj8U2NGyzohxTeynXJz+JrBoa3SDJYlLjYs+LSu6BkEshmbSo35 D4pSlezi7VOkww/pBaIraqoAuNZTs+8yW3kahJ26pwCskr2jiaRINfXfoNa/bgyZHo0HpG9t8ln VA0ob+2Fsb7SEcj3Yl/zbnBAe2Uyu635DYkjTGkJxyaLxnhOj8EoxUogzSMdP7RnM4T3GN2+ozn hVzS7azdFPP35hi9VThHAfojgUCEUDnXmdyHmWvdG5HPYJWOVgWrhZjHBF5bY7gNVSeBM X-Received: by 2002:a05:620a:404b:b0:92e:54b3:3f86 with SMTP id af79cd13be357-92e9a3e68d8mr28214485a.29.1783096695927; Fri, 03 Jul 2026 09:38:15 -0700 (PDT) X-Received: by 2002:a05:620a:404b:b0:92e:54b3:3f86 with SMTP id af79cd13be357-92e9a3e68d8mr28209785a.29.1783096695351; Fri, 03 Jul 2026 09:38:15 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , Richard Henderson , qemu-s390x@nongnu.org, Xiaoyao Li , Zhao Liu , alex.bennee@linaro.org, Magnus Kulke , Peter Maydell , qemu-ppc@nongnu.org, Mohamed Mediouni , Paolo Bonzini Subject: [PATCH v2 02/33] target/i386: Remove duplicate tlb_flush() call in cpu_post_load() Date: Fri, 3 Jul 2026 18:37:25 +0200 Message-ID: <20260703163757.55500-3-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260703163757.55500-1-philmd@oss.qualcomm.com> References: <20260703163757.55500-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX1Ud4q3wGs+xJ jUDG1O3iHo9BVwC9LeWtKM89FPXX3oauSjOCSMLIwwd9cO+Sew5Rktf2az00BwrNHLCARVxMfPd KL5Z/lWns19B7h67Ypb2UmQC7ql/tTE= X-Authority-Analysis: v=2.4 cv=E8v9Y6dl c=1 sm=1 tr=0 ts=6a47e578 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=pGLkceISAAAA:8 a=Cu_OB6cER5A0ZMY7a4UA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: 3EoSZDcWmHu0mB6Y37Ojw7YFs-nGvpSx X-Proofpoint-GUID: 3EoSZDcWmHu0mB6Y37Ojw7YFs-nGvpSx X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfXwEUWUMXYJYYy JaCl5Vlt2+trUhyqSHGqZSMiNWfJzXMz1ExqKjf8+gkImsVS1yPZ4gMCKqqcTPeRCZhQ8bPP7dT MF7IjoQM9u6AD84KZm083SKXfoFiBKfmWw1AQADK23zvUs9dJgeBB0J5n/GYoZpEmZ/iZcBtxif 21QnRkRUzSadDAFaOzbf+zOlAM76FDMK7+5lPu/JQfEqPWmhL6h7vPUtwUpv04UCG0h3jHnC8uG 1koqHTRgx9av64TQ9wzOfK2M9FWBorlHpVWTGpfY+thqCUE/m47ZLUTiCfMEilhJgNQzls7wF0F Pi+OwQfVr5Ncv5NrpGR9quSlKJ4COjtJLNgQHrciYoNQx5vqoBD3L+Gg7q7T9u0fIfVoZHDDkZF bdZC+gUwLT/lV1vkVKayiNJLO7iKyD3mCtO8k9YuudABj/fIeCzju2hyfINLqfVAqLouNjsqTmw 4ClpuqObBKjIk3VeMrg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 phishscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 suspectscore=0 adultscore=0 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030164 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783096760986158500 Common vCPU cpu_common_post_load() handler calls tlb_flush() since commit 9656f324d25 ("Move interrupt_request and user_mode_only to common cpu state..."), no need to call it twice. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Chao Liu --- target/i386/machine.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/i386/machine.c b/target/i386/machine.c index 1f5c517e562..df0e0c178e4 100644 --- a/target/i386/machine.c +++ b/target/i386/machine.c @@ -401,7 +401,6 @@ static int cpu_post_load(void *opaque, int version_id) env->dr[7] =3D dr7 & ~(DR7_GLOBAL_BP_MASK | DR7_LOCAL_BP_MASK); cpu_x86_update_dr7(env, dr7); } - tlb_flush(cs); return 0; } =20 --=20 2.53.0 From nobody Sun Jul 26 11:01:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783096759; cv=none; d=zohomail.com; s=zohoarc; b=AmlD8AkYPGuUY6vdpoIozm3huVXkE1eYrgRZUrlnglQkZ68euBh+SOy0wTPWS0KOvsOQFcEpOQpv5IVxaUDt0+Z1NKYeK6XulDwUwIpcwC7kJ5EEq3PUCe15BSMbYWTyoXJHl/R23gp0jVLJxNf9nWnhla5UgoaAKKR1JCKLvrE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783096759; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=risRiSv+UEPHcL2LbSldgAbZS/KE/1C0HcsdRJ7pmvw=; b=TENJU406TzxHtral6qnM4cMF2wdWgKyrHhMIHDvQX2d0kYi0zipK33lMD6BviQJGtKqbfT5+Xw6q7QhSMIn0E4eXGpuYIQA7Ep55SpTLlw7TjsfQ1COlq5pHj75wR7Uwt6ziz8NRzL1UKkz5MpZCdP//h208swiZxZKdO3lonIs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783096759726112.32901563119287; Fri, 3 Jul 2026 09:39:19 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wfguL-0004sJ-JX; Fri, 03 Jul 2026 12:38:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfguJ-0004qc-LX for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:38:27 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfguG-0007jP-OX for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:38:27 -0400 Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663GIY55446274 for ; Fri, 3 Jul 2026 16:38:23 GMT Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6b039eer-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 16:38:23 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-915f6ff639aso130128285a.1 for ; Fri, 03 Jul 2026 09:38:23 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493cfb6f199sm35906175e9.3.2026.07.03.09.38.21 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 03 Jul 2026 09:38:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= risRiSv+UEPHcL2LbSldgAbZS/KE/1C0HcsdRJ7pmvw=; b=iYt6ErQIrXdi5tPE sCHhgbphy8rn83Y9MGjZlqiYPb3b47l5asHLvP5LKtjgsFldMX5vQ8Oa9mnJJEX8 B9NNSxrWa/HE74EdKDEmimroP6DvMonse9qSj3SuzX5ZBoft8jepY5FqRuA0Iyx6 kWM9VlosA0etVgqE9ZDjP3srPnJUZ5uxzmJrejKze//Hk/D4bgpFw2rs+jtZxuLR cc8VnoqYpdDHAijmRDCp9TZvwM+wdy2+kS7nu1ZucR0+AJc4D4GRPA1atSMtKbvH cL/TlNDZ1XXZEKd5Qye903AsxNOWxeybqE67C3c4/jNh3PDGkBRBRkq7KRj7w6ZT s1cGcg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783096703; x=1783701503; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=risRiSv+UEPHcL2LbSldgAbZS/KE/1C0HcsdRJ7pmvw=; b=A2cPsnyYrnImvfmK5rm7tLFKB3ykwEzn3ZyUl0WcTaF5TdfxzFnKUxfC4erSVCXqkH /2BpRcClMmL+k5KjHCPzO4DHbLCqO6B5uiZWEIUFYXQZ04zfvs1FChTrLLBC+1GO8qTP 9gJwJsnU8jw0/N0KrDowkeCN4AFqKQRa5DdnOYQOqdQzxqo28HP631cYVHa0uPj/ac6I syiSz0Gj73D/lk3Us0MmmLuS1J8H0V5HhZHypk6v5VrVxv++6iKt1eyUiOFUGTMC2uSN VLD9D+dkDSw+D3ty8tlomgHIdXXBvgb43ygJFqpmV3O4qgyQuNltzotHstL4COr5W0mP t2Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783096703; x=1783701503; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=risRiSv+UEPHcL2LbSldgAbZS/KE/1C0HcsdRJ7pmvw=; b=AADainbaz7hbS8bSphs4sHjIyQpujoIp9S7OqbBWb9GKaEKkYTV7ki3J2uVacvqQ3S uD7rP8Vu8fbxnVNv6l6CDkPYw5c0TzDktq3Vy1XPGrWfldw+go5TgsVXVpXrx0Ui13S2 AJhSKsZP55QaK1ytkJK9xaDpeJHAxeq52z4CXQZq3Jz2DZljMHWI856aA2BWaxd0gyj8 60zcHc9Uy9OUsOB3MSNpo/VN5TzGLVdji2F7HntpvXF7fkzoaGXyqthZzIzHCxArGUiw y9uWMA0C01AUB+5/QayTjfyKgf7E6Y7RkF5PJXvKMlSyf1+KbgT0rw9u0nKgZmPvyCEB 8X2w== X-Gm-Message-State: AOJu0YwHllNCbeOetL72UXVannJnZ8BErQQFjF9y15fXSI1NwHQAvOPg ZkwfpDZyLxllYqcqw0YshrABDTDMTgzlbwmDVDZFVcJAMSly2+VQkH+nKCQiI/keAwrYSXD4xls ZTHKnay9+j8J1+oOzzHUjbP9BaWRi9/SOKoeGOu4wJtBNe3nUVsLUyLyfx463YxiH8Q== X-Gm-Gg: AfdE7ckqrZyT3qctIGY+E26+42w6j5V1TGZ0I6pMDOY+6idEV5FkhpmAMcJiYmA//t0 zf7NhvP5S+qNWvn3JSZY2kk4+7vO1Fa18WSlHmzhQPt03RlZOkyaOOKSeIeI7/ohA5fAgTvFZQm 1TferUaxWZqdPFP1frWthnGxx5v7eqByI8OJSxcFp47+1TuS7+YlVXtQa7x2LdeyrMmk64FS5Jb /BmkaDTvlq9GlUYIKiNvOGt7j+q8I2t/qUheYlZ4ElclqBL9aslJnclLc2K1VHsnxNkamJaM8ox ThPcdCIjE6HOej2GmBB1LKPVpwIyx1lWR5h5b0Tj6wPQ772SVuHxJLLayQB+svdniNMwKPCVJA8 OcpCA7fRlerFqU8bzwj9VUDXpVmFz6TMMYhzI4fnY8cdzxTKqCKR2R4l6pJmowi3Wyuk5 X-Received: by 2002:a05:620a:43a8:b0:92e:7f13:1489 with SMTP id af79cd13be357-92e9a2f76eemr29525085a.10.1783096702986; Fri, 03 Jul 2026 09:38:22 -0700 (PDT) X-Received: by 2002:a05:620a:43a8:b0:92e:7f13:1489 with SMTP id af79cd13be357-92e9a2f76eemr29520885a.10.1783096702606; Fri, 03 Jul 2026 09:38:22 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , Richard Henderson , qemu-s390x@nongnu.org, Xiaoyao Li , Zhao Liu , alex.bennee@linaro.org, Magnus Kulke , Peter Maydell , qemu-ppc@nongnu.org, Mohamed Mediouni , Paolo Bonzini Subject: [PATCH v2 03/33] accel/tcg: Restrict tlb_protect/unprotect_code() to TCG Date: Fri, 3 Jul 2026 18:37:26 +0200 Message-ID: <20260703163757.55500-4-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260703163757.55500-1-philmd@oss.qualcomm.com> References: <20260703163757.55500-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfXwx+Mrw0U2UJC NcCPGYFLYpGyPTLrK605CAcAD3yt8AyUJPo4qK4MV4xtBhWCPZrycRH0CzeLLf0ImnMN1y/yl0d 5i1tYlovR5oE/WuqSiKE8Z2Rn9ti9xs= X-Proofpoint-GUID: RRCMYex8IORMBToj2-RgA7Y87ZAIZNcD X-Authority-Analysis: v=2.4 cv=FoY1OWrq c=1 sm=1 tr=0 ts=6a47e57f cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=pGLkceISAAAA:8 a=glojBnVPa3CR4aLdIrwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX1MHyy+ADiZFT W8Cr6+oaX2f010Zm7WGM3f2n3GroM83EA2ZWkbROv8+1d1KvmoAsUZdsru7B7YyKCgIZdlgY99x OUTJzOxQmtfhpMqydl57M5rJ3PeskceuvMLU5vxAhdc1lKCDIsqh90jXlwjRrNDTkypIRyjA0B4 oSgXfX2LY3OwqJ//8+Z7vs9H3rxaHEda21U2GmmTCuAvnIaUuraPuJ5PGb8P7/ILfMq2jv76Eix 8X7WtqEC4kSPK/UwL9MkqaGpMeWeZAeRNVlhbVwnTfKb3bm9UEAD5+P/6fvAdgJ5m7Shn4kE6wd v05sS9Iw1l5uDpABr/Mx4zoBrgE/kyWS7n/gLQY6j7hEBMeGjMQ3CChurhVU4Zg23xaFR0YWJqs H84BNkscEb8VejXeHEbBZ+MgWlbKQn2eZKy28QmAWSz8Qn+Jjbwdxji278Pz4BMpdiD9p1xNOxv sESrU5oGpgH+cF6WXfQ== X-Proofpoint-ORIG-GUID: RRCMYex8IORMBToj2-RgA7Y87ZAIZNcD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 clxscore=1015 malwarescore=0 adultscore=0 suspectscore=0 spamscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030164 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783096761022158500 Both tlb_protect() and tlb_unprotect_code() are only used within accel/tcg/. Avoid exposing them to the whole code base, declare them in a new "system-page-protection.h" local header. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson Reviewed-by: Chao Liu --- accel/tcg/system-page-protection.h | 17 +++++++++++++++++ include/exec/cputlb.h | 8 ++------ accel/tcg/cputlb.c | 3 ++- accel/tcg/tb-maint.c | 1 + 4 files changed, 22 insertions(+), 7 deletions(-) create mode 100644 accel/tcg/system-page-protection.h diff --git a/accel/tcg/system-page-protection.h b/accel/tcg/system-page-pro= tection.h new file mode 100644 index 00000000000..52896c6d24a --- /dev/null +++ b/accel/tcg/system-page-protection.h @@ -0,0 +1,17 @@ +/* + * QEMU page protection (system emulation) + * + * Copyright (c) 2003 Fabrice Bellard + * + * SPDX-License-Identifier: LGPL-2.1-or-later + */ +#ifndef SYSTEM_PAGE_PROTECTION_H +#define SYSTEM_PAGE_PROTECTION_H + +#include "system/ram_addr.h" + +void tlb_protect_code(ram_addr_t ram_addr); +void tlb_unprotect_code(ram_addr_t ram_addr); + +#endif + diff --git a/include/exec/cputlb.h b/include/exec/cputlb.h index 3a9603a6965..f7f7020382d 100644 --- a/include/exec/cputlb.h +++ b/include/exec/cputlb.h @@ -24,14 +24,10 @@ #include "exec/hwaddr.h" #include "exec/memattrs.h" #include "exec/vaddr.h" -#include "system/ram_addr.h" - -#if defined(CONFIG_TCG) && !defined(CONFIG_USER_ONLY) -void tlb_protect_code(ram_addr_t ram_addr); -void tlb_unprotect_code(ram_addr_t ram_addr); -#endif =20 #ifndef CONFIG_USER_ONLY +#include "system/ram_addr.h" + void tlb_reset_dirty(CPUState *cpu, uintptr_t start, uintptr_t length); void tlb_reset_dirty_range_all(ram_addr_t start, ram_addr_t length); #endif diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c index 6e66f3c6e93..7f7c208ba12 100644 --- a/accel/tcg/cputlb.c +++ b/accel/tcg/cputlb.c @@ -1,5 +1,5 @@ /* - * Common CPU TLB handling + * Common CPU TLB handling (system emulation) * * Copyright (c) 2003 Fabrice Bellard * @@ -47,6 +47,7 @@ #include "tb-hash.h" #include "tlb-bounds.h" #include "internal-common.h" +#include "system-page-protection.h" #ifdef CONFIG_PLUGIN #include "qemu/plugin-memory.h" #endif diff --git a/accel/tcg/tb-maint.c b/accel/tcg/tb-maint.c index c33dbf65e7f..4313864d2c5 100644 --- a/accel/tcg/tb-maint.c +++ b/accel/tcg/tb-maint.c @@ -38,6 +38,7 @@ #include "user/page-protection.h" #define runstate_is_running() true #else +#include "system-page-protection.h" #include "system/runstate.h" #endif #include "trace.h" --=20 2.53.0 From nobody Sun Jul 26 11:01:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783096774; cv=none; d=zohomail.com; s=zohoarc; b=X73nr/zKkXqS7DRNbRRQTqzJIch+mnYjjhBW6TM7LMKFxLZpVn0Cc2a/lOFzpepuHhnBZ3hy1Me1V7sxWa63Ux+P/qN0pCaZ6f915FjA5IYceJk2xCcJF349Hzk0rCw3s74/uZjORnUXORmU74jgDaVA2SGPknWznZjoXqDLLVw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783096774; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=YpvyPafEgMLcx7hXhSA7L2Lp32OYcohxo8F966bFstA=; b=IisdlvvxbAclHdB5u+rCdpJhwMxxgzk3BCfcdNfs4MCE3uUVFNbRU8a0mho/AF/AiHAXZ+WRRsMH+4pDyePRPh/XtY6iLCRrWRh6/NRTC+9VvbCcWa9Sf0IF/YyljIAJ+Rgi7S75QnKcTkBTEjJ8ZlZ4z1YhhNAXzqsu3Us1OtQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783096774251247.52958110830673; Fri, 3 Jul 2026 09:39:34 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wfguV-0004vA-P2; Fri, 03 Jul 2026 12:38:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfguR-0004t0-92 for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:38:36 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfguO-0007mH-Rd for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:38:35 -0400 Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663GIspo364972 for ; Fri, 3 Jul 2026 16:38:31 GMT Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f67j02abt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 16:38:31 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92e9a2b95b5so8441685a.2 for ; Fri, 03 Jul 2026 09:38:31 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493be493c24sm178703075e9.0.2026.07.03.09.38.28 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 03 Jul 2026 09:38:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= YpvyPafEgMLcx7hXhSA7L2Lp32OYcohxo8F966bFstA=; b=hi1M9d0c61tQ+hDi Sqv2US5XDYmfaIpNlMmDkvTuC/KogiGbyOS9f/N3UKN0iR3qJZM9uc6sO2Uck/cr hpapNXx1dUhWND2GR4YJE6bQT8WhK8ARQDALGtO+txQSTTaireFjEHnhbM4f50M8 Klv2jOlhBYD+G+LJ7fL9cSjEstJtUeEMqD3JryuK1esekSOTe0lryxVP2q8wgjpn Dw65rIIfAa/cGjHCeUef9JxG6yWXde+me9UrQ8AGHsHkentzjtxTXVo/35opTcE3 +ixckPECVMD2KF8RYsCyHuGzpmSwfjVfuixMndQ6lxfi2yI+eS5ox+K93Z55CA4H nh8HnA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783096710; x=1783701510; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=YpvyPafEgMLcx7hXhSA7L2Lp32OYcohxo8F966bFstA=; b=QbYzTgMlrwTTJRIdDu1G/yB8Rioyho0uf4MWUJeVYT9t/tBat/EpYQYN6bhUJEIvq6 0dJQJ0+SY3K2S3AIXYZkWkqvBT/Ov7JBaMF6h5JVEsqjx5pzj7CYQzFu1ORHBNqINILl MSLUgCwzR8mqmbFaM0Dqom8MuUJAI6rDq27Iat9OAohv8caCskf4at+2+89gex9h6Rg4 wRbM7wbck7BKfAutQ+zwSE4ki9nCPUchfg3h34P1yLCU/++IiPUSTYLosHoeXybfwcUA czH7TVuq6URPLNw4xjka/lquwaxv/Gcx0kRCSKSfc0TPHL4cgY/mXYuxwNa3Zwc7ZMZP 7Jyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783096710; x=1783701510; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=YpvyPafEgMLcx7hXhSA7L2Lp32OYcohxo8F966bFstA=; b=jtKaVKeaiXvulpIuMXco4DitrhPOFOatBSOTEZsXjzJ2v50el95WbwYxBOgv4uch12 mwXVjEItj+wsvnXpa7/BC5nbLFYx1eIWZBrJ9GoHwQfoGwDj01Aj/xpc0W1Rn3lYEgkn QYg6NxmpBLpWMWrzSYcev1Qpyu+a6xe4GY4dTlExpQhRSadKBU1GFNzvaVbGTSisTQRb FoNbtu0xA6v0ZZxRJXdnTLTOmc5jggxs9KTJs5OAZ3S7UT9EUcdCiCWHTmMfATWvam+7 7Oo3LnzglD0VuBB1aSusHOXcofPtlwBzR5p8hjiiAJA9ro7q3chLKfKP3kjalrOrN8Fr XxLw== X-Gm-Message-State: AOJu0Ywwc72lI5J7p9/Da0tMnoBkWRjRfOsF4zlKQkfAEG+t7Ija3pvJ pxAJAo9izELxvp4NfXeNOhIccsg/ZaRWvoz7LuHfzViMK9rVB959fODxYmHWe3kexahaHrJRxqT 5rFv6nq7ssH/kOOMqU2ho6ATwmdewDi2oE6ZKBAGk7vE9BJNBHHsmiKwLd5l/jtMWbg== X-Gm-Gg: AfdE7cklDxJFZ9HKmaSpaRk680dFFGZKKpp7EpzA35Qq+GVBf0KDmvVWercyCpOLBfF eVLj4eQwR7nZ9V1uSiPzgZ2LYIUInuydXsoQEb5ovTilL99CzCBtnwOMJW4Bz3dVlgZsf1yxaIU MF09vnPpng4MISK0p3ohwSY2+fVHDd955hT4zp8/eFyLJUGGfUE0erP9zb8L9SRsPC+ZkliXzH7 5Tg/dNi7bdYxH8HVZRwFKG3bG+3RqOHmyQE6lmin3HSYPl58BQplp5ck4xCLpUJ4+vapbhipYcK jRNQaBP9I9UD9W9OoVyWr2oPEUE5+ZoRH6U6g3Kz0lsjHKU5zJYrCWi4s84ee4hbZUrmKljAAK4 GcBiBY/6EMAsETxcbYiRT2YyRyRFHOF24zh3fBIQDf1/TwFdfdfQjzlHMQl0N6VNqnoOy X-Received: by 2002:a05:620a:4624:b0:92e:68be:1c5 with SMTP id af79cd13be357-92e9a34e907mr29642585a.21.1783096710353; Fri, 03 Jul 2026 09:38:30 -0700 (PDT) X-Received: by 2002:a05:620a:4624:b0:92e:68be:1c5 with SMTP id af79cd13be357-92e9a34e907mr29639085a.21.1783096709952; Fri, 03 Jul 2026 09:38:29 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , Richard Henderson , qemu-s390x@nongnu.org, Xiaoyao Li , Zhao Liu , alex.bennee@linaro.org, Magnus Kulke , Peter Maydell , qemu-ppc@nongnu.org, Mohamed Mediouni , Paolo Bonzini Subject: [PATCH v2 04/33] accel/hvf: Remove left-over comment Date: Fri, 3 Jul 2026 18:37:27 +0200 Message-ID: <20260703163757.55500-5-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260703163757.55500-1-philmd@oss.qualcomm.com> References: <20260703163757.55500-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: e2FTjXDMgGMF5CzYSY3LSo4rJnowyz8U X-Proofpoint-ORIG-GUID: e2FTjXDMgGMF5CzYSY3LSo4rJnowyz8U X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfXyrHzO8EmKHRe ULxgesn8/0YilYfstsO7oTgyZjbnQyGLedRFREP1pr5nwiWXrrujdZBgoAwIIKds7PZmDWBVtCh 8QJR2rAejyHAQXlbDclsOu9x4g9HSQU= X-Authority-Analysis: v=2.4 cv=Yuc/gYYX c=1 sm=1 tr=0 ts=6a47e587 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=nS8E-dRYisaDM6zJQEoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX+hHN66f1Mp+j zpiXtXCbO70A5epz/uZdhr39D43JyZcRiUe5x+Wt6AsqF7bMvdqtoYz+d6/iHuIB8F1KW96px4u sQjdUBWsgeU0FccK8jaumZX36lSQzsnKSYYp/E79T/NNIOO5VdIToZc6oUlU0PWfZdwN8frFWiB W7gwDAhS9pxTAKZp/9cEZ/RCZOkduX+BVkY6FnGa2DfJyVLL7AQfMimVWTN98jiLkg0+aWUONrD b6hk+EwX1Z3qK/+oLRd2PKCucu4KFF7dsjARZWfcfGKuQj07ldGyY2ou9MB8X+loDSvsdP2eBZ0 Fuhw0A4tMHl9r0C2mCI8EgUifdsKSXvSZp/dCNKL/FfNOlJ62d1gKWNROA5x2sSm2xIlTa1f7wG Ebxl7m5SnFxIdnXqWH/w3M3YlS+CclJCJdrIlPfsjZdinrIj3LedECSvzWbX13GSFZDMPbGCXrI yGhQR9OVXCWkxcWC3YA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 impostorscore=0 suspectscore=0 phishscore=0 bulkscore=0 clxscore=1015 adultscore=0 priorityscore=1501 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030164 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783096775096158500 Missed in commit 6bf331164c5 ("accel/hvf: Drop hvf_slot and hvf_find_overlap_slot"). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- accel/hvf/hvf-accel-ops.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-ops.c index b74a5779c3d..dd2b45b7cb5 100644 --- a/accel/hvf/hvf-accel-ops.c +++ b/accel/hvf/hvf-accel-ops.c @@ -62,8 +62,6 @@ =20 HVFState *hvf_state; =20 -/* Memory slots */ - static void do_hvf_cpu_synchronize_state(CPUState *cpu, run_on_cpu_data ar= g) { if (!cpu->vcpu_dirty) { --=20 2.53.0 From nobody Sun Jul 26 11:01:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783096798; cv=none; d=zohomail.com; s=zohoarc; b=WST6DcMcyHwwzk0h8yrx9RMXOAg9YBL/eRdV8JjELkig4hnb+EBpynbkjWIGZgtGG39ZJ1FNQpvzVXBTuDKttwY7BgCh7KcVrbfR2sjHLoEy1CFL/F5279rKKhhSquKinhUfknn5PFMQizvx8pFYiCdvYzfhAULFcgK1cEY0izM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783096798; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=VHVn6ka+QtlPwP926qTrHJauvq/1ZaQUcESPY4KgNsc=; b=SFKgZ0xPijNohhO4sa1gnzOMdT+YdGS7CxCmTtSddNBREYPqeuARGq7HpXGy5on0vT98EVQPevOmwT+Z3+BzX5x3qH/YtcitVuGd8mR/49KZmI9bXvK0aOdJQpAsdZ2pOH0+AVkYWNnehULlqNEhVGLX7/XQJb7kCJTqel9MXgU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783096798889219.93485510621008; Fri, 3 Jul 2026 09:39:58 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wfguZ-0004wV-Nh; Fri, 03 Jul 2026 12:38:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfguY-0004vk-8z for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:38:42 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfguW-0007nW-ED for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:38:41 -0400 Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663GIdRS364518 for ; Fri, 3 Jul 2026 16:38:39 GMT Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f67j02ac1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 16:38:38 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92e663c29f2so84021985a.0 for ; Fri, 03 Jul 2026 09:38:38 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47a9e4d83bdsm567118f8f.13.2026.07.03.09.38.35 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 03 Jul 2026 09:38:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VHVn6ka+QtlPwP926qTrHJauvq/1ZaQUcESPY4KgNsc=; b=LiauA0YqWc5zbo9X k/F3BT9btgvutc5gD318xmjCxRBlmNDPvAx5yqIs9lmUQL6syDX+pdDn8JGKmNAT Gy2BX73j303YqUcopXVuzEd56qckeZxtsFVUjl5Qpa+peDR9l2edIT5TynCpnKJZ CtKgJq3o9/vCjns7+6t2IdVCnjheJIMgh4kcTgA6CrQhX4duPRgEaCMuhSrqqXs2 cvPXA8zCoo1q03wvRsa40mZu1y0/CtcecCJ0CDyyIzBvPeI+mB2WWwRhkD7b93Sf hyDcDbxqMG4ZJ3nDIAMFeZHRLMsPbjXB2ssn9PbZExjWGfGyFV7j4If8AfQ5bl0H z+g0IQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783096718; x=1783701518; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VHVn6ka+QtlPwP926qTrHJauvq/1ZaQUcESPY4KgNsc=; b=GRH6iJ3ObzW312CpNb4ejqhtm6zg+Vxub0uIgqZ0wikbndmoTiuYCWSxKLuSkSEytY KAQP+wEce7F5kt/+nmIt3ucT3G8l/wp86maW+FCYOLkYE7svTJS0l0uwNCEj/Rgtaj/C BivCROMgfS64OJLvnfJCETZ1EyDnxm+YUSBPuPX5qWmD8r9AI/StxxYh126h0+1xgKFE 3cOGGEpn0SZlowFEhqTpPHoC8OBqfRPTZCjCO4zBV7SPtc3oLAWq9dcmPUQaJ0L0PiQu AVhinPOB064adgiwNa3XvMLlWDmFGc5o9NemrcKF3sYRBijczBgXFiA77X4XzXC4v/bi qqQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783096718; x=1783701518; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VHVn6ka+QtlPwP926qTrHJauvq/1ZaQUcESPY4KgNsc=; b=mYmmTuCOS/lT6+2E6NmqjyZH4tTUXK3KtBU8WJXKOmpV6jmU5txMoXMl9POW8OGKRO UOpwB2rtbm71DSJ3YAVliXL6lGWQZmtYNBAN4bhjiyIt43QOVNFaOHNmzMvuPTkPq0xD d3iw9EjlN4HmisF6lcD98XOtMpMoH/6o+p1XNjWM/4azQ91P6aErfp5D8B1oc4dTqhV2 4V/iEWaDyG3T4pz6gB9B0ok1OxhtXn7E/E8p4cZiDiynN4U3jIWDkNHpfh8/jLU1bRBR srtEpZ10ZFErmufArshaHagM6JO4VxgAXPyviwtQ78rMEwWGRSGgfOVHTGUn241QdX74 0dgw== X-Gm-Message-State: AOJu0YxsRgKSq7cND/wXYBGZd1P4xeb2wzt7ScMZlkPPLpQNfK+S8tGW eOjznUPGt8cyko3qsv0r4qUP5TAlr+tTPC8vmDekZQGEXvx3w5X3KMvOQOz35LO87ymDoPCdlEp ABD6Z3K3vwA4A0K5ktmmv8HSzXgh3/B49+ZHvpuvzEo4m76hhlaHuUSOdHwmi+a0/xA== X-Gm-Gg: AfdE7clDCHtV4Hp/A1n4bDtSn7lwPxihzwf4a3uTuk2dmV4BYRz2O5V1QkuSJWxhgAl oT+vcPGnP0dJ5Zy329C1Yl5/VqKvkqN6Lecmw6MfhzLSw5qgfLrBaVaselW/bKywl6sjrTJBWqp rt4pA7hnTr4FvzhrI3Hc4tkQq1KQPcQTteyOmVF0TJ8bX/UQXy3f7/rBTtpBYRNUDx+Y3YZUmne SSnUuhNMfH99BuZJSrs+cOGWOjWBsrvG3GmcU427/neHAFjp8wHW4BNBTuBNZhM5doNZZ3JvCBf zr3V73JYpYoKBHvuLUtn8lOs9UbCseyYQ9hvLyoVtV9plxY7PjARbYjAQC8/C+/ta7CCsaHeG+u G1QgOj0+6w7Ndi6QgRD/2VORC3s55Xt+N40+TVWjyhzeFfIXJk8T/ocIthCX9GYom0EFp X-Received: by 2002:a05:620a:1a0f:b0:915:8e2b:e5de with SMTP id af79cd13be357-92e8b25e83dmr565244485a.7.1783096717795; Fri, 03 Jul 2026 09:38:37 -0700 (PDT) X-Received: by 2002:a05:620a:1a0f:b0:915:8e2b:e5de with SMTP id af79cd13be357-92e8b25e83dmr565239885a.7.1783096717238; Fri, 03 Jul 2026 09:38:37 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , Richard Henderson , qemu-s390x@nongnu.org, Xiaoyao Li , Zhao Liu , alex.bennee@linaro.org, Magnus Kulke , Peter Maydell , qemu-ppc@nongnu.org, Mohamed Mediouni , Paolo Bonzini Subject: [PATCH v2 05/33] accel/mshv: Replace @dirty field by generic CPUState::vcpu_dirty field Date: Fri, 3 Jul 2026 18:37:28 +0200 Message-ID: <20260703163757.55500-6-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260703163757.55500-1-philmd@oss.qualcomm.com> References: <20260703163757.55500-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: u4DMNTCkIKaq5MfW9LRFn_JCcnAifmMa X-Proofpoint-ORIG-GUID: u4DMNTCkIKaq5MfW9LRFn_JCcnAifmMa X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfXzOWzXiNH5wOc zOEHrESbDvBg+CPhiDlXT9apYE5KGSnAbEfeDo4MoLs6B3aZJFvjGaLcTKCEZ8FfoG43pm/0jFD GNAW0PGS3zbYESNNkNnZr7RYqxuiJ/w= X-Authority-Analysis: v=2.4 cv=Yuc/gYYX c=1 sm=1 tr=0 ts=6a47e58e cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=yMhMjlubAAAA:8 a=KKAkSRfTAAAA:8 a=lTdEn7Fablbk7hdpwAcA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=O8hF6Hzn-FEA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX3GDrOiNtzBxx qdogSekViSDoLPFc5hndHiLJwL+tQufwEFRxhQ3+3qDlb4ry4m8BpXcvmD2ipnbe1VaLfnds9el kOwlfif3cc5uanI2/gg6/gtq4ZeI9KJU6BSYZUxQ/Mzw0Al6edNpXgWpQ9+ErFAV3fdMgz1acDd Wh9x9/tHLqPhu97aVmeYgf9gHen/ywCPCxrXHvJyeFpf+Lg1xKz7GWQh61vRZ4mWcALUYpwCMGc x0iO99I7Ui21jUMmrBFxGTUQ3vRM2gAQfpXcby4FUEyyRoiJ3aJbEdjbxYRSVQ4zYghvk1GCRAA uoRmq+jjGTyvyct2l7tWLs1fadBCaxCdbl/o/6TobGrCdgjrX7QZwMnUIy2xae2x1hSQk86OId3 zttQvAUY7kOamEMCg6spWMnK2QtXehHktglmgp68WZ8ICP16RiQEZ8JxlaD6KK3bsPlURc7GcEV TlhaBeLidWY+wEwzm9w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 impostorscore=0 suspectscore=0 phishscore=0 bulkscore=0 clxscore=1015 adultscore=0 priorityscore=1501 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030164 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783096799275158500 No need for accel-specific @dirty field when we have a generic one in CPUState. (Other accelerators already did that in commits 6f13a0ada01..36ab216b81d). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Magnus Kulke Reviewed-by: Richard Henderson --- include/system/mshv_int.h | 1 - accel/mshv/mshv-all.c | 18 +++++++++--------- target/i386/mshv/mshv-cpu.c | 6 +++--- 3 files changed, 12 insertions(+), 13 deletions(-) diff --git a/include/system/mshv_int.h b/include/system/mshv_int.h index ba3073888ac..b91c4d661a3 100644 --- a/include/system/mshv_int.h +++ b/include/system/mshv_int.h @@ -43,7 +43,6 @@ typedef struct MshvHvCallArgs { =20 struct AccelCPUState { int cpufd; - bool dirty; MshvHvCallArgs hvcall_args; }; =20 diff --git a/accel/mshv/mshv-all.c b/accel/mshv/mshv-all.c index 9452504ac28..1959baf6672 100644 --- a/accel/mshv/mshv-all.c +++ b/accel/mshv/mshv-all.c @@ -531,7 +531,7 @@ static int mshv_init_vcpu(CPUState *cpu) } =20 mshv_arch_init_vcpu(cpu); - cpu->accel->dirty =3D true; + cpu->vcpu_dirty =3D true; =20 return 0; } @@ -617,7 +617,7 @@ static int mshv_cpu_exec(CPUState *cpu) cpu_exec_start(cpu); =20 do { - if (cpu->accel->dirty) { + if (cpu->vcpu_dirty) { ret =3D mshv_arch_store_vcpu_state(cpu); if (ret) { error_report("Failed to put registers after init: %s", @@ -625,7 +625,7 @@ static int mshv_cpu_exec(CPUState *cpu) ret =3D -1; break; } - cpu->accel->dirty =3D false; + cpu->vcpu_dirty =3D false; } =20 ret =3D mshv_run_vcpu(mshv_state->vm, cpu, &mshv_msg, &exit_reason= ); @@ -746,7 +746,7 @@ static void do_mshv_cpu_synchronize_post_init(CPUState = *cpu, abort(); } =20 - cpu->accel->dirty =3D false; + cpu->vcpu_dirty =3D false; } =20 static void mshv_cpu_synchronize_post_init(CPUState *cpu) @@ -763,13 +763,13 @@ static void mshv_cpu_synchronize_post_reset(CPUState = *cpu) cpu_dump_state(cpu, stderr, CPU_DUMP_CODE); vm_stop(RUN_STATE_INTERNAL_ERROR); } - cpu->accel->dirty =3D false; + cpu->vcpu_dirty =3D false; } =20 static void do_mshv_cpu_synchronize_pre_loadvm(CPUState *cpu, run_on_cpu_data arg) { - cpu->accel->dirty =3D true; + cpu->vcpu_dirty =3D true; } =20 static void mshv_cpu_synchronize_pre_loadvm(CPUState *cpu) @@ -779,7 +779,7 @@ static void mshv_cpu_synchronize_pre_loadvm(CPUState *c= pu) =20 static void do_mshv_cpu_synchronize(CPUState *cpu, run_on_cpu_data arg) { - if (!cpu->accel->dirty) { + if (!cpu->vcpu_dirty) { int ret =3D mshv_arch_load_vcpu_state(cpu); if (ret < 0) { error_report("Failed to load registers for vcpu %d", @@ -789,13 +789,13 @@ static void do_mshv_cpu_synchronize(CPUState *cpu, ru= n_on_cpu_data arg) vm_stop(RUN_STATE_INTERNAL_ERROR); } =20 - cpu->accel->dirty =3D true; + cpu->vcpu_dirty =3D true; } } =20 static void mshv_cpu_synchronize(CPUState *cpu) { - if (!cpu->accel->dirty) { + if (!cpu->vcpu_dirty) { run_on_cpu(cpu, do_mshv_cpu_synchronize, RUN_ON_CPU_NULL); } } diff --git a/target/i386/mshv/mshv-cpu.c b/target/i386/mshv/mshv-cpu.c index 126ca40b481..1c433c408c8 100644 --- a/target/i386/mshv/mshv-cpu.c +++ b/target/i386/mshv/mshv-cpu.c @@ -1692,7 +1692,7 @@ static int pio_write(uint64_t port, const uint8_t *da= ta, uintptr_t size, return ret; } =20 -static int handle_pio_non_str(const CPUState *cpu, +static int handle_pio_non_str(CPUState *cpu, hv_x64_io_port_intercept_message *info) { size_t len =3D info->access_info.access_size; @@ -1748,7 +1748,7 @@ static int handle_pio_non_str(const CPUState *cpu, return -1; } =20 - cpu->accel->dirty =3D false; + cpu->vcpu_dirty =3D false; =20 return 0; } @@ -1909,7 +1909,7 @@ static int handle_pio_str(CPUState *cpu, hv_x64_io_po= rt_intercept_message *info) return -1; } =20 - cpu->accel->dirty =3D false; + cpu->vcpu_dirty =3D false; =20 return 0; } --=20 2.53.0 From nobody Sun Jul 26 11:01:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783096796; cv=none; d=zohomail.com; s=zohoarc; b=A0SZURoTjZVndLXUyBYud5c4pJ3EDYsdg5Q4takdCsiBelCHaG8fIllAIcg5ZZdeprhCq+KQsPaMSUB1e91bkh8IKQm70Ub20r5SGM0/Wtc8sdxtwB5khwrKCwqj0YnyJd7XhrTyNSKNrUyYWWkQGBr8x/X48LU4ysYVmSTb+Wc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783096796; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1x7QSxrq42ew5YZruERIhg8L4kv2+83eMIh0NOzptfw=; b=fVUAoU75zNT3p6NoabHCSk1Ha3hz734FOpBOo9NOJ3gnPSR8alwgDEEJCfnwlw7vUYO0W/Usc9gxwtY4LtHEwAO4jrqOi+aQzf0u6+YYzGiyFW7L6DdVWzAAfiuvAzm1UroiWG1UTvrgeKAaw/2zYWzqOqeELjfEIH6xsVZxfkY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783096796699675.5171529994482; Fri, 3 Jul 2026 09:39:56 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wfguf-00058F-UA; Fri, 03 Jul 2026 12:38:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgud-00050L-U2 for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:38:48 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfguc-0007pQ-Gm for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:38:47 -0400 Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663GInU5348221 for ; Fri, 3 Jul 2026 16:38:45 GMT Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f648n387w-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 16:38:45 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-91ed0e140c5so130729185a.0 for ; Fri, 03 Jul 2026 09:38:45 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47a9e4d6e4csm536590f8f.10.2026.07.03.09.38.43 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 03 Jul 2026 09:38:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1x7QSxrq42ew5YZruERIhg8L4kv2+83eMIh0NOzptfw=; b=P8g21Ib/TmSGAS3Z KhTdUhvB4AniMWPCgvQLTbib2uBcqamaZtIZuIZHEX5eC8CqzmjLLsDnGLRRG4it H30G13fQiD8JMTtnDdupZi3ELLFDYAhp7PfilL54S5Hum5KsieDUlKs96MDDFzrX lz0MidQG4s70fg6JRmmbijXYki4ur2sbU6cWoiY/caNPlq9vR3hz+pb1IEjSUmDN m1vALhiZ5eGK8DwrRI31BDpftqGc7TXwBtnxUszIovyXx6mjItvWPHwkmJ4cP+JN SkCJANd3MAkdRH+t7rih3++uLFZEWPlFZl1ItIbK87H+8HlhUPkIsNLx3Beu5VYT FkZ0xA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783096725; x=1783701525; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1x7QSxrq42ew5YZruERIhg8L4kv2+83eMIh0NOzptfw=; b=QFwv3IzRRgBSFR/iPXuiOrIS5KpVUISJoEBj3Wy6GFo3MteUpA2kIy1OGIY+P4Tbk1 5nmEXMU67kEdfdhsp5tcbWLlBYrqnpmSjde5e822cqrLoP8uw7k7wJYOTb90tY65IWTm NMToA1DGMpKff2cFpfSXHyAZSKYcNOEx1lzFdAX43NKzwsiRKfxwNvt+NtuJ1QXILLFy 3W8RtzH6MXQmw3iSeSJp6IdbybJILQICMiO+TsfahJeFUhIbJlFquBvAACniEP0OzGtU yYpvO718bHzHsdDfRIvL0kSl8DmpCy1lS20TTEcW4wwmmfQavI17R7i6wHmRvSsUuh7F QIQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783096725; x=1783701525; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1x7QSxrq42ew5YZruERIhg8L4kv2+83eMIh0NOzptfw=; b=WuD1ZX9v7fMIkwuVFr0htkbXAtiJaN/vYpFUDM02C0EVUak5NWWhuTG31w8NZyP7jc Df7A9A2hmUP17PVqCx+qX+oM4deDSM+vCFs4xIbqnhEBJK8SZVgQUJaOKhzmOWpHEFb0 JfOtVUXLAhgr1P/HGZWARtiPFo5dsJwJYdATqpdS+5d8T13Mir8Y2F3+oZJoIFd6eE2z qbQVl0SrAshGEaZhkj3mBloBsHp0ibFNXMeopHcIvsnNpNs3+794t/mWF/+rR1Epxphr /vKwWGLf4JA0mWZwvxvmT1nK1Gg4V1UVLprCdHlUACZFGYn+dWb00bwmzY4Z2vAT+bkW mF1w== X-Gm-Message-State: AOJu0YzZNoKnBJ7/DZvZx0tnaX8wOgNUmtggm3QEGMSjA01sRgoeEG7Q QIaIXolMsw/tDvSfSyCBqpoLUouXy0lnewM/uItc/QPM+sToj5u40xrSNY5co9khzD08ybGyOJ9 dYFCln0kRt34rlcxUl3olZ4ejMvcR7ORYlOPLMbjnvo/+l1syjObeZ1lW5v1J44Ximw== X-Gm-Gg: AfdE7cmNz6Nmc5S6nrMC6nyQoC5fjYADxQbqBf0pImXHhvJct2ouwxZhFB6GJWEtyJA 81rUpPXW/q5AMgaM/UB0R4zxG7DtnTnZ3q0bZUVNF99IDQuOtzB+SLx44o9qxEu9zf9SnvoiNWw SrVe1G3kpw+L2XIGN8m57Xba8vrj0fzLrW5bMoB+ixbvjkgou7AjlRnm2eTf31Si2bDiS/Kcbjl A2Oq5mOEdNTHFY/kJSlEoYLq3JhW8qkYLrUj4yTmXiPi3T/lITeT3f6HawfMU72p2+oxo3RsTqq I7lqau//4kyjOhT5q3YQEKfO8UeQ3ZHvUJurpcy70UrOLnmtW5MYvMgyDdNU8s5PgZaKhWccMR+ x6wy1WBgN8BT8spvy5rt2xW+05jIIKx7v99Cj73jR07bW3aJ9CRb0rExw2BuxOSN2GS7K X-Received: by 2002:a05:620a:3710:b0:92e:541e:632b with SMTP id af79cd13be357-92e9a3621f2mr29396685a.2.1783096725068; Fri, 03 Jul 2026 09:38:45 -0700 (PDT) X-Received: by 2002:a05:620a:3710:b0:92e:541e:632b with SMTP id af79cd13be357-92e9a3621f2mr29390985a.2.1783096724531; Fri, 03 Jul 2026 09:38:44 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , Richard Henderson , qemu-s390x@nongnu.org, Xiaoyao Li , Zhao Liu , alex.bennee@linaro.org, Magnus Kulke , Peter Maydell , qemu-ppc@nongnu.org, Mohamed Mediouni , Paolo Bonzini Subject: [PATCH v2 06/33] gdbstub: Add trace event for STEP packet handler Date: Fri, 3 Jul 2026 18:37:29 +0200 Message-ID: <20260703163757.55500-7-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260703163757.55500-1-philmd@oss.qualcomm.com> References: <20260703163757.55500-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX/yMgtntJC73G COKo/kYsQWk19vx6/PhikDUnxrP88sY19pbjcdiN48J2GMtb+tQErPRvmR3LOAm2Cg9KzlJ6yIx xJjm0N3WQORqf+ZKQYYolN5FSWPgkVM= X-Proofpoint-ORIG-GUID: _dEBDxBjO8Wdg2Qx27DvEL-m9BYLNEEJ X-Authority-Analysis: v=2.4 cv=O4wJeh9W c=1 sm=1 tr=0 ts=6a47e595 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=nS8E-dRYisaDM6zJQEoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: _dEBDxBjO8Wdg2Qx27DvEL-m9BYLNEEJ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX7hWldXtOvuxJ gsTmRtZOAHp+Z2hIFvA8ERMarfdr1IwGPBqNhRG8+0+d9bk2j15xUJ1Sf+5KvNhVVfzEj0rXle9 rZizdcW2buA6gjjxsjEW8zSajTkxiK59u6HtWoB05b5TP4AbYjxP60qhcLuUHwh8pREJA612lXd bKLSmJuziu/N/6m5HHBAiKlXOPGo3O6dTQ9OV26hfevVxK7faoyUKfQCabTbQMsOIMFlvPmuWhK muL0yQLWt1TvsEj0wzkU4lh9kd5Y6OGsLAyuriTF8E5pt4SoVhFn1M4+DF8V210CCxqT+ofIXtL CxHnmhtJeG/Z9b3wdFV31L+IKFRdEBI0sW7oeAWGv/55/i4xKpN6FioUe1BeVW8EOpNWwMBsQtd BlZk9Bk0+7ndus/1lqY/t2Ub8WW8sQK2jUFt6m2HgjXaGo86LKZFRocVRSUtLFYD0vxVPo/Y4Yc tTQwREFkj4I+bC84YCA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 phishscore=0 suspectscore=0 malwarescore=0 spamscore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030164 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783096797411158500 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Acked-by: Alex Benn=C3=A9e --- gdbstub/gdbstub.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 26366acb674..246e7746300 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -1369,6 +1369,7 @@ static void handle_step(GArray *params, void *user_ct= x) gdb_set_cpu_pc(gdb_get_cmd_param(params, 0)->val_ull); } =20 + trace_gdbstub_op_stepping(gdbserver_state.c_cpu->cpu_index); cpu_single_step(gdbserver_state.c_cpu, gdbserver_state.sstep_flags); gdb_continue(); } --=20 2.53.0 From nobody Sun Jul 26 11:01:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783096759; cv=none; d=zohomail.com; s=zohoarc; b=nWamjKXWbiCHoapMIocW5KRp2LhWdQoMR1nwQh12jehvFlNveMk+EuMdspGT4uHW6fu8Amn48LC/yC6vpDX3wEqQ3Ox+IRRyt+clvAUYmEf7RMSlxoCEDId9dLN2BqTGIpjpFk6u1K5KZ5aAN9PznBs8WT4E/8WkkROYaAKOMAc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783096759; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=zlzfQXqCfD0fOdphKFvmR4aYcVqlSHJCNldgrmBSnBc=; b=nY9lF6/1NvFCDRwg6l0g9CJWiB8BeU4YuVL3x60vH/uXXPlN+ZMCzEbUO+oTzzC5fuAPP21g5m6016B9g7gUvR874ksALHX2Kzj82fCOj3VnZJ/v1TKl0iCVFY7Fw2vhMxCVEOaYfkh5f+wKGB18TBe6SYPRLSiPKCYOgdeu2iQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783096759714798.4542677137913; Fri, 3 Jul 2026 09:39:19 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wfguo-0005kQ-WC; Fri, 03 Jul 2026 12:38:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgum-0005hk-OU for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:38:56 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgul-0007qn-8Z for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:38:56 -0400 Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663GJ1HY493904 for ; Fri, 3 Jul 2026 16:38:54 GMT Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f68u320a5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 16:38:53 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-92e4f946461so69665685a.2 for ; Fri, 03 Jul 2026 09:38:53 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c637568dsm157926725e9.4.2026.07.03.09.38.50 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 03 Jul 2026 09:38:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= zlzfQXqCfD0fOdphKFvmR4aYcVqlSHJCNldgrmBSnBc=; b=S/bI287rs3JJHLpG EHXawCVZGzMlPXPytVpYHLF3iyULJQqIMVgIvQDf3rWsD+qmrKkKd6dO+V2fC7qg cacEx9LyvV5bZoWF+7etKKEL0cPPGhx1qSW5YfopJuHStOyi+x9tPyTugUBSMFHz xxGRQ3OKQYUZoCsn6LV6CQcsKiuEwzQXLasrRiH3ySZ5AdQuw//auQSJcu5F8b5H 6fis18ALiClJqJQBK8zHiW/9oa/M+n6q4J2Ntz4eE2VvVjy3rh8mn9wVn/cUqxxy wktD4UteeZjkWgY3BYzQG7Fa4VDVPbF+rvAHctPaoMu/Dqk3D97QorQ/J6Ck1RE8 U4bZZg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783096733; x=1783701533; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zlzfQXqCfD0fOdphKFvmR4aYcVqlSHJCNldgrmBSnBc=; b=eh/l1zJqVTGlPrKaF9Hsnq40d69JazMXb+K0CjWDK+oTzE2K/M0f5xDf6VZwyXejTD Fj6oUVdmyGdtzo3BKczih0Q7za7vOYkaZ6ad8k82LgtG/1HvzTkUeULbp1P3vjErCo7q phebgThBEsS1eB1UptPclkWDGbIZ0gvz+0MnfrmmgY/ZKiVdgXuxKB3I3GPJiFFBwZfw DBD3DXSxE9Rwv+pAnxrSjjV35h/cLwEJsRscvbCQEW+qWSPpktp7g6vIXvrROCTT2YAF XnmY90fOloyHWg8owOUgBYuwvaOz+SYkPP1vxqk8yJom0rVndLVzN6GIc6bTOp7BmUzn vc7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783096733; x=1783701533; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zlzfQXqCfD0fOdphKFvmR4aYcVqlSHJCNldgrmBSnBc=; b=CmcernjWQmSl5S2dqwlFTMORu3igkrshAJp7sX4mVPkucG2KtTCMZ6nxpuWjNwIbrj mgtjOULAR4258j+iG/E1K81NyYk5sd3Hw8aSKbqo9c7i8NvVDBJagg5Z5T63u5xRCo7U wS4QvsKA5fFmykD1VnJ9pc57jSvJLSPdD/VIDVa2roOZaleW0tzLg0JA/0TecoEhb4BR IFwLzd1qkOlui5PkWvNS6pahssX7ogCD4n2f/0Kx70H9AIAnkNKzg55Fm0zG5tWqyKIO hPq1DJkrNoSEMMYWkW7eMheRjVbRoUHlyQrzR8hbb9G5SuqqLP1ELUPGiHagULKWCYUT 5O4Q== X-Gm-Message-State: AOJu0Yzo+dTM0TbHh9bNSmB9O6KPUzyvJZMljjlGSbDapAJ0jbu/IEpM 8mEhLiKY//Y8tLZi9l+yG6fGLQliZFxmavR8JIppUx4T7ZimTwEQQGjSwK+4LQ93TFEl402do40 ubpilNGTAsNS49Uo/DeFeT8sOxG2Q/j+2IyWXza+MK2kCN+x5gcqaLvPUBtcSsGO5vw== X-Gm-Gg: AfdE7clafiL3KUasWWdS8nsD0lYxuSw0v2ileBVzYfBPtJGD+j6Ys8k9FqHmUDaFpVR AD7D6gIvqcZLwi03ej0IM4t+GSlaPIQqdd/bNqFW6q9jb842lnn8z9HEqV2kumZDC+6TQuox7hq WjyJaM/ufmvkl636aOOT/VXwSzYXm7IylXZiCKaOwBZv8DDAWnlCD8AE71UWTDOuw3CaX6RpdWp HgQgqNknH0SCSqQkV89eCfqbkrrFB1MdaVPUoqRIvP+IY4fLsOG3njDgfLEG1w8FKVicoGSvFeW qAAjxe3yWLAkvC9seSWGRpeNH5f9+nEcuN5TkCSeqBHApk2kDx4bRlLI30Oz6kc2n05NrANyJuM VPBThWufTBhEPDyVZcuOsxZjetnEUqVpLC1AtaCnSeqXP1Q9aAJjr7lo8OZJ16/2y2hqO X-Received: by 2002:a05:620a:46a7:b0:915:9fba:8795 with SMTP id af79cd13be357-92e9a31392bmr30019685a.1.1783096732926; Fri, 03 Jul 2026 09:38:52 -0700 (PDT) X-Received: by 2002:a05:620a:46a7:b0:915:9fba:8795 with SMTP id af79cd13be357-92e9a31392bmr30016985a.1.1783096732484; Fri, 03 Jul 2026 09:38:52 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , Richard Henderson , qemu-s390x@nongnu.org, Xiaoyao Li , Zhao Liu , alex.bennee@linaro.org, Magnus Kulke , Peter Maydell , qemu-ppc@nongnu.org, Mohamed Mediouni , Paolo Bonzini Subject: [PATCH v2 07/33] gdbstub: Only return E22 when reverse GDB is not supported Date: Fri, 3 Jul 2026 18:37:30 +0200 Message-ID: <20260703163757.55500-8-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260703163757.55500-1-philmd@oss.qualcomm.com> References: <20260703163757.55500-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: 9ZbhIKR37dSloC6RD64wi0Ct9xNaARhe X-Proofpoint-ORIG-GUID: 9ZbhIKR37dSloC6RD64wi0Ct9xNaARhe X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfXw2jnP+Jt7M5R IvC4TGNfURA5lgP5maeAjIaBRxU92tqVFlQtUvWVyVWyNfabQsrNkCvyBiJ3xN8aOmgFfiFPfTx cQB9VojD0gwCmZKVVa7cNfwNzm47dG4= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX7wUMAekcZ4xG RikksC7KzvzY8GcoVHIC16byXA4wss15oD06ycwgd0IuQQfzd2l8jwWr+wTLsbgccr6T5U1iPa3 dfWjJwSDyTmGv+diktK0AF+mG0qG3oRbUX5zr79UbYCXtWNF1o+Ubc1TGWi58cbdA8mOAhKHQEu jNNAwucgpt7r2uYDUt2x5EaZ6XX6oKkCn9Uu7Sgiy+5ffqN3zvInV09iWpebSw89eQYz3MMr+UU pbur2KUe4fZ7exLdrMUKVTNu2rb6w3EwjiYMnBeYeLk8uOAbYu8NPzVwRIG64XjxoCXR5XFXWZ/ r21RC1CnLtfWGrbVGM5jhQvAu8M+Jg1mhCpKS/kTUOw6fmF0fyQgP12JNFcyl2MCx6aIypUSqAQ Ay4PaeaiAgiVwapWfhk6ZfcWu2TuJZ7ytbGrv3w5T27umpqWfH2kmeom8b1OGMtkLgM3H15lfZb 5pEHvyyQ6RrL/nG3mzw== X-Authority-Analysis: v=2.4 cv=OaKoyBTY c=1 sm=1 tr=0 ts=6a47e59d cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=0n23ylXGgdPVI_k3iFEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 spamscore=0 phishscore=0 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030164 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783096760977158500 No need to keep processing the arguments when we know reverse debugging is not available. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Alex Benn=C3=A9e --- gdbstub/gdbstub.c | 1 + 1 file changed, 1 insertion(+) diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 246e7746300..f54415a9db7 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -1378,6 +1378,7 @@ static void handle_backward(GArray *params, void *use= r_ctx) { if (!gdb_can_reverse()) { gdb_put_packet("E22"); + return; } if (params->len =3D=3D 1) { switch (gdb_get_cmd_param(params, 0)->opcode) { --=20 2.53.0 From nobody Sun Jul 26 11:01:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783096751; cv=none; d=zohomail.com; s=zohoarc; b=FOawSzkB4G3EjpvC8DH+bB0+9zChjW4vIwo3bIkT+fYLZXbMSj56yioDUy6twWYdIzhS2neEwO/eDFQpED2DdyXMLM/4dXnO7TN1ncI+OJ2ENARzPn5D/mGprFERRBF/lAeDdzhhZtoBs/dQkwzNGuOUObugu9iblXi06EzxEyw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783096751; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=J61D7vmFN/GCddU40nav9DK2OhgRp9ty5MKEmevp7T0=; b=cx8IqhLvdmKbpQ33n49Tgrs00bOE5qAUOVbVaS/wKZDvXLnyHe/NqGWzUXd9TbaPJiSztfuBtwxY5qiUJeQOD7kuK2PQDtBH1YTjnUodAYt+UkIPWocu6odnEM9RnCzYfJJZOYIB40WCjLH8KYzCEJJwViV9XD2HTN/1th8uuhE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783096751830348.2590364469828; Fri, 3 Jul 2026 09:39:11 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wfguw-0005og-9g; Fri, 03 Jul 2026 12:39:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfguu-0005nc-T2 for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:39:04 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgus-0007wx-9d for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:39:04 -0400 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663GIZex489308 for ; Fri, 3 Jul 2026 16:39:01 GMT Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6ckj0yqn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 16:39:01 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92ac0a54110so82002585a.2 for ; Fri, 03 Jul 2026 09:39:01 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa039bcdasm562551f8f.21.2026.07.03.09.38.58 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 03 Jul 2026 09:38:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= J61D7vmFN/GCddU40nav9DK2OhgRp9ty5MKEmevp7T0=; b=I6cyRXlLwzbxEvBv ONv2WTod0wL5gPOl1RUa8yw2FF9E51Ok9a9UZ/jjA2iO2vFFVD81m3dNSt2BZf5Y 4wORhI7fmxO6x+WP0ipYyYTTBnnEUpVST+aC3U7H9EUTWM9PoYatYl/oxCJilmnZ qMgRrnYFhrmqcSzAFaJa4u37u6f3536mVjyEhJDwOFe8iD607tgcwSi/zBHTPxNF G7nrTSNcI1oM7tVFMdqoPAkFjoAc3AeZTfFn6Nc/wSrjfIVZQH/zhvDKxGm4qVEn /b4zM20tY/uNlO8OqSqjQmR8tM311FE96O1+7vjx/7LDeKMx/kXulRvplbZ6rFqQ yO8PCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783096741; x=1783701541; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=J61D7vmFN/GCddU40nav9DK2OhgRp9ty5MKEmevp7T0=; b=dPAiv/5CG4F55mZ59FnMPNOIEjPnuxywBRCSsV1g1E/FJGZ/qIzLMuri1DwpvJeOqO yjh+N6S7zTTzUcYD8+tHyJAMY5D5UfrcQUPtBr5159GewhLsQGizF1YKXfbvTQB/0/Kc tYMiOI3y/ogXnZwfnck+6hCx6uDYy3CW8SDmnD3npO/Fv+1FlRZQDytUy8snCtrb+a9p 5evjZ0WTfcK+jgx+ToG8hRmzOGKUFGxC1vzJ/Yb7tV9o2mFUkBF8MBH/9F2cAlZSlt4j 7Ark1jznaFGTCKNizd2by8F3cMXI1FKgjPi0gcKImPtfF3s8KqfD5AEpJbGUv8AVWpHM HRhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783096741; x=1783701541; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=J61D7vmFN/GCddU40nav9DK2OhgRp9ty5MKEmevp7T0=; b=OvWc/UmrGDC0qraYmyTG8IujyTKB2w3WeC3tJCJqFRGA7DQljWindcW4EDpb6vWnCl YKPEOqBAQy02Tc12wegjb1DR0UxAdLFQScrWiObJPRId2Drjf0Yl832Gf3KeuXFITxlS 9P8RC8ZXwVsQWnbrwegOENtfUJUkFWwnbeTkYAXXJNobimfSLpYUUc8ytWj+HEKpKZj/ hIjbBaMsXWXuCdKpjpEWASSrezHpx2A+GGfVPHdOCvCn6/hCiv+hev4vpbwawGGTXhuS dlvtkLH37s+cRIs1dIiEUspZxEZaCZileYpWNM/EHe7m+d20uLAN0yAlbiHgzkyD2uU3 tVEg== X-Gm-Message-State: AOJu0Yy+U8WspCJf16KbUHhbWmk8nu5zJ4qlINw/MGL0VipFpK3JfhS7 tgiWfbQEdRW0efrh7/KrrdboTcmfx7VyqoSQnw88b9Q8xgUs0qoTYSrqMultJDJIpGLvYK0b/A0 telFc3tneTZ8uzIqv9k1zIYH79Tc4Yka52f67yoZTcczgg5QCzIhA0BHoy+2rdcfrxA== X-Gm-Gg: AfdE7cnQePl+rkfDzj9Ln4XZk0kUP1lkjfSxyz/JA4zC83OAWzSAbr07ifzSj5+0zRc T8PhDWYpbWARkAFbWVWrioamgegiqfd11jsSGFwBsZp9UOGbtFkggqr+TnUM7QIlWwCI5HwP1og xukGOZqdtXhLgrjEsUS/AymKSOsZqwkjiMlJgB14MEGbanGQO31HNUFGcX5TRw7LdCd1VLj5kzL XZkJ8SE+aHZUtbwo/7C7tHExK0u0dVkYXQq+EfVAogHnW410XeyEU45Kx2t/0iwF24Ct8Gh7DYM LmcPil2Eie95a+wP6vvjAcaleyQgqe3WBGzL4cpJ9+p0AcmA0mkqETiBWxVoJ4FOUCpIXjRO9sg fkyYNeXZCCsMlca91i8Q6MoKlXyVRomlnv10GJQnmbDuPP6mZNyQeYjr1UlnFDzvXJ83l X-Received: by 2002:a05:620a:44c2:b0:915:9a39:1d68 with SMTP id af79cd13be357-92e9a35b22dmr27526685a.5.1783096740456; Fri, 03 Jul 2026 09:39:00 -0700 (PDT) X-Received: by 2002:a05:620a:44c2:b0:915:9a39:1d68 with SMTP id af79cd13be357-92e9a35b22dmr27522985a.5.1783096739856; Fri, 03 Jul 2026 09:38:59 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , Richard Henderson , qemu-s390x@nongnu.org, Xiaoyao Li , Zhao Liu , alex.bennee@linaro.org, Magnus Kulke , Peter Maydell , qemu-ppc@nongnu.org, Mohamed Mediouni , Paolo Bonzini Subject: [PATCH v2 08/33] accel/whpx: Implement missing AccelClass::gdbstub_supported_sstep_flags Date: Fri, 3 Jul 2026 18:37:31 +0200 Message-ID: <20260703163757.55500-9-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260703163757.55500-1-philmd@oss.qualcomm.com> References: <20260703163757.55500-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX2xqTN7iY6m9c JagdMXTptZ8pIPhlSbnaZwvBz1iot21Yzr+s0qE0B7f7vbh6oingbIVBPlxO/I7O7lhSjZmhvJB xOGZAWMITrySUoLw904nhYwBpk7PdxQ= X-Authority-Analysis: v=2.4 cv=E8v9Y6dl c=1 sm=1 tr=0 ts=6a47e5a5 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=glojBnVPa3CR4aLdIrwA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: HksTlOpZuUkcOf6iv9JAVj1e_hN0vmj3 X-Proofpoint-GUID: HksTlOpZuUkcOf6iv9JAVj1e_hN0vmj3 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX/P1wS69PhK1G LDc3w9O8yaspsrtRu4TkwY3Tx5c9aEFDLGsyPiWFiBR2KqPmycbokz7wb1I5OGpOstb6g/3KhTj BatMnEJUZyy0K575RooVxFLaRNvkCRP8uptYYZjN36FZeJH5sa1o0I7CH6FDAJAOJm/YQIYLiEW UKFz5qjEUkKZ/qSPhrNZJ6EztvsJN5G5o15CtHHZaHS10c06k16MxjVlJTyRCyvYlzGmRxwHj+M IwFX1gJ6XxYIWIpiNjBj7V7DUrPzx58Na8RF41TL3P6TaJhOEuB43l9KXec0rEVtFjKjTU8xdIK OY9OEr4+6a3RLf8jx0EElxCzSQ85vrknZ6ZnBfuX0p1zF6Lw9k35H98kn/UGLclo2dDHNS/UlCP V1ISUzSz5IYLRGwuo/UoBjnHon06oa4tODichQrJp4TbAHdFNMOSH8+XgMKtEdp/iMtUnmqMv3R ldjXXyWqNdFwnSZGndg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 phishscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 suspectscore=0 adultscore=0 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030164 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783096753185158500 Correct gdbstub support requires some gdbstub_supported_sstep_flags. Apparently missed in commit d7482ffe975 ("whpx: Added support for breakpoints and stepping"), even with the recent 19b48084f71 ("whpx: i386: re-enable guest debug support") fixes. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- include/system/whpx-all.h | 1 + accel/whpx/whpx-common.c | 1 + target/arm/whpx/whpx-all.c | 5 +++++ target/i386/whpx/whpx-all.c | 5 +++++ 4 files changed, 12 insertions(+) diff --git a/include/system/whpx-all.h b/include/system/whpx-all.h index 4022571ffff..0e2d333e919 100644 --- a/include/system/whpx-all.h +++ b/include/system/whpx-all.h @@ -23,6 +23,7 @@ void whpx_arch_destroy_vcpu(CPUState *cpu); void whpx_arch_accel_class_init(ObjectClass *oc); =20 /* called by whpx-accel-ops */ +int whpx_arch_gdbstub_sstep_flags(AccelState *as); bool whpx_arch_supports_guest_debug(void); =20 #endif diff --git a/accel/whpx/whpx-common.c b/accel/whpx/whpx-common.c index 247e12db812..e3f93efc61f 100644 --- a/accel/whpx/whpx-common.c +++ b/accel/whpx/whpx-common.c @@ -527,6 +527,7 @@ static void whpx_accel_class_init(ObjectClass *oc, cons= t void *data) ac->init_machine =3D whpx_accel_init; ac->pre_resume_vm =3D whpx_pre_resume_vm; ac->allowed =3D &whpx_allowed; + ac->gdbstub_supported_sstep_flags =3D whpx_arch_gdbstub_sstep_flags; =20 object_class_property_add(oc, "kernel-irqchip", "on|off|split", NULL, whpx_set_kernel_irqchip, diff --git a/target/arm/whpx/whpx-all.c b/target/arm/whpx/whpx-all.c index 3079c6293c8..5208d7e1dfe 100644 --- a/target/arm/whpx/whpx-all.c +++ b/target/arm/whpx/whpx-all.c @@ -295,6 +295,11 @@ void whpx_translate_cpu_breakpoints( /* Breakpoints aren=E2=80=99t supported on this platform */ } =20 +int whpx_arch_gdbstub_sstep_flags(AccelState *as) +{ + return 0; +} + bool whpx_arch_supports_guest_debug(void)=20 { return false; diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index e626acef2f0..f6e1636a4e0 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -1853,6 +1853,11 @@ void whpx_apply_breakpoints( } } =20 +int whpx_arch_gdbstub_sstep_flags(AccelState *as) +{ + return SSTEP_ENABLE; +} + bool whpx_arch_supports_guest_debug(void)=20 { return true; --=20 2.53.0 From nobody Sun Jul 26 11:01:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783096809; cv=none; d=zohomail.com; s=zohoarc; b=JPI/bQLz5L8G42I3tMky9nkVT1xqNG+4ZRgraMKTFnjG4/UoysGSDjEio/tTf9YkFGk7PXgudXAuLiP9HAsJDeEGaDJkpvRcCvEt/yYH3lqG3dHknYBxfHy+1uZ0o1zp8JJ00VFT18LbrxoDnrEXyXeQpjZVSRQOsOsfybYidzE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783096809; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=2GaQV/oxXfUYvhpcWlYYZ/rgvaJkV4F63rsqq0epSeo=; b=TfktKYyoUHHapOo9Jl5m6XSej0Wy36ePwtUZyYOZdrdvyaxFjtL2h8sKAmh5u8WrpWeJSNb9gZ3fpX5HJvpWT3BuNgtxvRhpPBv1io646ShTA0mmiHBbgRA4w1kxhcYukjZOSizFrCiO6X3HgNzrXMvp4eITWmfsif8S+FQwJhg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783096809594157.21829542047237; Fri, 3 Jul 2026 09:40:09 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wfgv2-0006C9-V0; Fri, 03 Jul 2026 12:39:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgv0-00062z-VM for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:39:11 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfguz-0007zi-4z for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:39:10 -0400 Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663GJY8Y493256 for ; Fri, 3 Jul 2026 16:39:08 GMT Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6dkkgqmy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 16:39:08 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92e9a2b95b5so8553785a.2 for ; Fri, 03 Jul 2026 09:39:08 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493cce12c40sm101302635e9.13.2026.07.03.09.39.05 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 03 Jul 2026 09:39:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2GaQV/oxXfUYvhpcWlYYZ/rgvaJkV4F63rsqq0epSeo=; b=gXTlmUA2kzvyaKak rY44H4nFN+As1N1e/UZMZsUOofG0wT2AmbuJB44JfB3R15VnByMjv3WcuHnMw2Zz E1SnPJa/dfQvCvCylJjUaTlQ1jK2EXrpNVJBrIWKYWiWk8yVvg8pa96uy0BvEa0Y 1Bn7T5aJRyDaXBM7d0cK0xIs3zLCN+KB1Zmm+I6fqCpGjsjT2e1o5zEgtLRV9ydE gHQJtuZfUWJQwgbcwsWUCuOj190PUBKqEPrbnM3fMDLKQekekWjB7I2EnuF4lWj/ VmmBJtzSpPFTU99ieirjZ59hd8vrdQWrXu+gAkdONFmgKbQrcJTDVUlI+WercEiQ dWzICA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783096747; x=1783701547; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=2GaQV/oxXfUYvhpcWlYYZ/rgvaJkV4F63rsqq0epSeo=; b=gxsVDOcaLPgg3f0dqR1ZkHUiYLFtSJuOQJe+A2+yzksyX9BakQ/Vgcy5vs+9Q8jswl k/szEEp18XQTDhlf8suu+/cSWiwcJ47a/VoOODSyxwwplN3gNhEVX/77U4DjwRTmXs3v oqbEemVRsCeamB+o36YkXJyRoIVP6sLt1PoZ3dQ5mqGV70kxW1OOqCHl6hDITPXotadm eK1ynEMktAb2hJ8e5MVOGSz5DsX+RZqi2Ykr8oYVJO/n9VTtedqbWRwXoam1eGWPlj4N 2PlYuuVHWFHgPFWrAA+tCD+dy2QU4wQcxioM+XCwTxDFsbz6MlcKB2WdEu+Svls+dQtW 1iYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783096747; x=1783701547; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=2GaQV/oxXfUYvhpcWlYYZ/rgvaJkV4F63rsqq0epSeo=; b=reivHc5XQHdztdoiyN/hVshiRFxGPLGpo0FNZsMe8nxaye626C3CPxWZquj9Q80Xp5 7POXYyKYxQ9pFr+Pz9clYLPyQ3xcUEQBslukFHhxtNuhF3MyFYfEjHTIID9qUiB4hk/s NjoWl77IIg1ZFPisgQFams10JsQZqEc3TTITxvdDSKmjScyFBBneyyUBGJHtjvsaWnhu 0UW6U83Pobp5an9/rl9QRj63kdsPVY7lqZ8fXXJ/CCUs0iRtInsNraXoB2AoHHZaGnM2 A0xmhkax+aGSG5lqkMUxq8mdruCvhHpjbrkNhvFpRtH5jJnjboREsPhPOUI3AJiG0L9X vcXg== X-Gm-Message-State: AOJu0YwHK/Ole4azQCELvX+cTwe5XWffkdElGb8x2JXrTWR8WiQrFOJz 7MQy6xnKgQKh3LcDNmXtN96vcQa68165saPzYObOQWIBqdH4mlJr8mIK2Hss97gFFjSdgzlW93e llPZqMeAEJ5d+WAr8Okmbse4ORJiNe+6fJktIOaMHwuRsQT0ZiY+T58h96//KxGtr9A== X-Gm-Gg: AfdE7cmJyG+o9zPW5pSRDSUtzDZmgDlqfHk8LKVPSoWJyhVX8mTyOa0cCWHT4xUrhiK dnk0fhn0kK/hX4LCANNak+aAsV7USYW3dTIggWvwRCBVbiF4ctn/RnqVvkLWvmaO9P7vXpBcnr2 Ju2iSvFP3BxnX6T/Yf8GCiEODMinqM9c+YBbX3FzltGU57osv9qrpWxJk1Ytihct//1cFrN+uus AVw4qexFET1ej9wKe0/TZpTRGZczG1E+B4HnpuYD3zNOksRhXqiLYkKbIceM8nA8J0gys3h3FDn W/3mTkogk+0ub1kD+L1tf49iw3WbmWcRJeiDME1awcO/tsNQJoQcs4tFBhzLxIKWANsXusaEVNX S+u0kf5ZEKjcdF0UQQVEF3MzlFZ2IsTx2BkN8uEfxgcSQW77tmz5rDBizHVZCSR664jWK X-Received: by 2002:a05:620a:1999:b0:916:1806:302d with SMTP id af79cd13be357-92e9a47bb71mr21743985a.58.1783096747562; Fri, 03 Jul 2026 09:39:07 -0700 (PDT) X-Received: by 2002:a05:620a:1999:b0:916:1806:302d with SMTP id af79cd13be357-92e9a47bb71mr21740885a.58.1783096747181; Fri, 03 Jul 2026 09:39:07 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , Richard Henderson , qemu-s390x@nongnu.org, Xiaoyao Li , Zhao Liu , alex.bennee@linaro.org, Magnus Kulke , Peter Maydell , qemu-ppc@nongnu.org, Mohamed Mediouni , Paolo Bonzini Subject: [PATCH v2 09/33] accel/kvm: Always define AccelOpsClass::supports_guest_debug Date: Fri, 3 Jul 2026 18:37:32 +0200 Message-ID: <20260703163757.55500-10-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260703163757.55500-1-philmd@oss.qualcomm.com> References: <20260703163757.55500-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX084cYDAxPkgE vkem+NkIKTcNtRU+SuyP3mI9P9aFyOursEwmyzZ7DJPE+NrB19qMn9bNBc+oVHgj/09k7BUadSx mpa0DuXY60YcY6OTRDkT0x3j7mE6Aq+9nZ83Vpa3fENIVs3Qkgr3+S6WwmQlj1wJa8cNjNQXzZF 74wMr/x3A0iRXi9pT2RqMMQhFjS6a942IEwds3aDepDpZwITPFOxvXxZWxD72ywZaNHow7JBEtN rGn/DFVVIAtEo3oHZyJW9Q6xjbeLgcvi29rcJAnBFR37WfoM/1W9phlB5UE5RMkyotLCukv9gPP lGHJXFgzeq07mDDN39TJiryZzY8tuBIG9dxwjvHVDuM8esj7WOV2fVZ+KeTZ86D4ZWkpCpJnTkZ x/kgd8zDR8zE6BUgIsjTT8/AK0W8287RbdDu2/sb8Trtcw9b9QQ+A2wsxZVpz08vxXh16y+NWrX RweP5FcWG2/chtQpn7w== X-Authority-Analysis: v=2.4 cv=LeUMLDfi c=1 sm=1 tr=0 ts=6a47e5ac cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=j4hjfWolugK9Oy_fDxEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: kfWZQqJ2YcOSyeUBdUzzmTHif93pptw8 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX3T5ul93+ltWw a7TpTeoV3D68FdxBrNtCCMwQWS2wreo7bfK6KLyf3IDrmCwRuFRH7DTUcFVBMMbQNzS8mVp8687 Sjnl/n4ht9eFCGuGio8ClN6OgBEQVcY= X-Proofpoint-GUID: kfWZQqJ2YcOSyeUBdUzzmTHif93pptw8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 suspectscore=0 bulkscore=0 impostorscore=0 priorityscore=1501 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030164 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783096811297158500 Whether TARGET_KVM_HAVE_GUEST_DEBUG is defined or not, kvm_supports_guest_debug() still exists and can be called. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- accel/kvm/kvm-accel-ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/kvm/kvm-accel-ops.c b/accel/kvm/kvm-accel-ops.c index 6d9140e549f..d7967bc922f 100644 --- a/accel/kvm/kvm-accel-ops.c +++ b/accel/kvm/kvm-accel-ops.c @@ -105,9 +105,9 @@ static void kvm_accel_ops_class_init(ObjectClass *oc, c= onst void *data) ops->synchronize_pre_loadvm =3D kvm_cpu_synchronize_pre_loadvm; ops->handle_interrupt =3D generic_handle_interrupt; =20 + ops->supports_guest_debug =3D kvm_supports_guest_debug; #ifdef TARGET_KVM_HAVE_GUEST_DEBUG ops->update_guest_debug =3D kvm_update_guest_debug_ops; - ops->supports_guest_debug =3D kvm_supports_guest_debug; ops->insert_breakpoint =3D kvm_insert_breakpoint; ops->remove_breakpoint =3D kvm_remove_breakpoint; ops->remove_all_breakpoints =3D kvm_remove_all_breakpoints; --=20 2.53.0 From nobody Sun Jul 26 11:01:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783096786; cv=none; d=zohomail.com; s=zohoarc; b=e2d3SRTeDs+8KJIsOxhHWnnAtNupfwQU5x/D75AL1L7JQrFFZjjFRnRskkRe0LCI8cM1Jksn7BMAFqoE945L7g/j9OpK5onmslYbEXDX43DFtF4PyzzOHvY7m/bEk+LYoBy01QaC/usnGtSs/R2/ejTB61pcZmvNLnnqfx4FFO4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783096786; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=sCNdzsLH3Q0jMX4rCMKs72ytygkMCsUMvV9SlnS9aVI=; b=nRpkdSZGG0fqkWeT8zX95Gf/Zsan8xyck9MocJdjoB4/hbklOGMRztOct2Bcx4IQJjhf3Qj0lZ/4TsTd63o0645PZ8cfeFgZNP3UqBVN4WQ2sLxcT+FaX0NnX36NR8g85Yt96tGRFShkg/pAyPXBiEy6+0GXlpMfJp5riB3SVdo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783096786304635.2622004669025; Fri, 3 Jul 2026 09:39:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wfgvA-0006dn-Us; Fri, 03 Jul 2026 12:39:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgv9-0006V3-0k for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:39:19 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgv7-00084u-02 for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:39:18 -0400 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663GIo3n498273 for ; Fri, 3 Jul 2026 16:39:16 GMT Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f65qcjwvf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 16:39:15 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92e52306621so54293985a.1 for ; Fri, 03 Jul 2026 09:39:15 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493ccdb62d3sm71133865e9.8.2026.07.03.09.39.13 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 03 Jul 2026 09:39:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sCNdzsLH3Q0jMX4rCMKs72ytygkMCsUMvV9SlnS9aVI=; b=K9NQM+T9W9wO2sTq JvFsWfjFIVzTIqH4GGB4mhJytkKDZFJgi0m/cJKzv1hbCiiFcngOkH2j4jaaRslA TXLLPCNdTpb4YtLJ/QYnU3uot2Ih6aZKS9V6ImAqkUhbBLb6Laxdt4xhJQPA8U1m ZRAqA3DwAsz7bO4FImjR7sxwnVZRWQxvtIw3dEaCpcegmFOf5QemxHvPYVjbYx3D hxrSMrxrjYw3Tze88fKSkzlqzlY2sT4teZw3lxc3LSR6s8INc20uPvI/MuzW6fIB RvSdrynrqHhucgGeXoCwxYPTIemlJ36WJDNLYT/q3/XMQ7VS4yTLzdTOuBEN28bA SGPG2A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783096755; x=1783701555; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sCNdzsLH3Q0jMX4rCMKs72ytygkMCsUMvV9SlnS9aVI=; b=DzUVRcf4j6xyBOYEhZS3vu7EG6W3uR9cpf27Nl9NV2Zbq3dh31CbARXaX846qjKndj FkusOFSY5G04Xny8Vi6ifbI3xMduRY9CvMw1XR0wK58AabwlwH/h3Jclpb3+m+MLqV58 q9szCm2kD7Py28Ybrn0kjHEo4Qg/1mFmlL9d6bWbo+VztrrUg0vGQZ/L4/+NadW0YjX3 /BQ0J6d4t84V5090dxT6MBiIRr0tMuIycRsTG2uD/pOhJGSbiRGv3AotRFSkMgrVOPiv XrL3l1DR0kbC1F2+ii6Xph6d2PrnMUCCKG2JD+fZ7aG2TFRd9nmaH8iAFKSe27tDfkDE XzHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783096755; x=1783701555; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=sCNdzsLH3Q0jMX4rCMKs72ytygkMCsUMvV9SlnS9aVI=; b=PxOqEk6ZxBm0lFmLdKbYmvFEwmSBfmWOi9jyQtBCO7g0nXVpQ/WIG1QfoD2bpTyDQm HppZ3A+BSRoRsfGCOtbAj01qLwxMXqYQCaF9aO0qxLVYL/j+6UOFU+ciqRz9uLNVObza rmjiUVvp6WZhu0asgZh2N8IAl07SlRXZbnNYmYslY0tcG1oyL1hRXyr6DfvGGxwBx6Fb GfvdMn+ghPvvRWFW0WhnsyB67xnF70D1MK9vhFOTUz2GaSSBZkvIOV/71p8/+1PvNVrN fX8qs5SIsy81ilUXsXsg5Hlj+/a79gD0xld92s6RFZawBI/aHiHWHfz3Q4Vrs8c+bmXe O4Ww== X-Gm-Message-State: AOJu0YwFcVXyHxY8lHHIxq79YcmQKmrU2DD9cCGKxBO10TfhKenXlTKi LCDyrfsAF0U7i48r+lvSiDUOvFAQX9Xj2epVrHNYQ4PjQJsixmmIC1sD1QXl0wlTrmk2RgTP9EC ScszORX67xNAbbGLByj7aBTOybY0+XtYUYtTB/wZCAO1ZpULeioao3TevUeAAgL7QGg== X-Gm-Gg: AfdE7ckGsAlfPbcIZFH+YuK/QmjUl/+lGE0QGvXC3LOE7nB1PH3pn64W8nAkFvTCZYZ yuNBZpqS+JTjma6eT71rpKnuINeFut3fnrI1BkR+0AzpAagDpOjhA07BHblinyB+Hf9TNRh98Pf hTYipGCtYgHsLzvDcYxCAjsP95hYU7x0FEJ7LhcGGMzghZYgzeyHPWzeJeaQjaEE3l2ezZP1MvR iZVKyNQQBsgdfeP1KjO8KkC2A4ztE7WCb+M6jjafQvgbenQy7Kpp+P8401BhyFzUdfCJE7js5Bd 7Y2RXNyTWdRJetzkhIzLYv8iUxCSpfHUnNMNN9ukkJ6maInItY3GzZh8HZCG+p4xrnl80RFiJXz y07F1fmCeVrVLa455HiIcuUvD0gklvUIc2P96CNiNJRD0A5qEMYpeOACwLTqUkkt1tDEH X-Received: by 2002:a05:620a:7006:b0:927:59bf:46ca with SMTP id af79cd13be357-92e9a491863mr28185085a.40.1783096755071; Fri, 03 Jul 2026 09:39:15 -0700 (PDT) X-Received: by 2002:a05:620a:7006:b0:927:59bf:46ca with SMTP id af79cd13be357-92e9a491863mr28179485a.40.1783096754458; Fri, 03 Jul 2026 09:39:14 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , Richard Henderson , qemu-s390x@nongnu.org, Xiaoyao Li , Zhao Liu , alex.bennee@linaro.org, Magnus Kulke , Peter Maydell , qemu-ppc@nongnu.org, Mohamed Mediouni , Paolo Bonzini Subject: [PATCH v2 10/33] accel/kvm: Simplify kvm_init() w.r.t. TARGET_KVM_HAVE_GUEST_DEBUG Date: Fri, 3 Jul 2026 18:37:33 +0200 Message-ID: <20260703163757.55500-11-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260703163757.55500-1-philmd@oss.qualcomm.com> References: <20260703163757.55500-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: CaEGlZH84Jobk5mepOSeWYKdEGVzx2cA X-Authority-Analysis: v=2.4 cv=Bb7oFLt2 c=1 sm=1 tr=0 ts=6a47e5b3 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=snbnvTbt-5-dSQZ-83gA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: CaEGlZH84Jobk5mepOSeWYKdEGVzx2cA X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfXz+c7KUke/USn y8DHWDaQWr/n4bSoxYELfcK6jKSRv+GZkNdTPfh+GkI1SC5NRvMqfhrqm4t5N0+lhLJ9D/HQ1yC rhhuoyKIGDYRb8ELqP1VT+lJdVfA/OYQ0AL1E0G8+vuLIZ4Ab9TADXRu0nYHjqTtRR68q8s02Dv O2L1MpjUQGceVRSp+PfSQVA236K6i6WI3mzfjwFVDzMX+yAXfoFlPn6IgBWtJk30RAzDIoxyyfr MCzeRo0u6upKqjFS68YpCHq6GZcu0krgBrZ+rZP8F2bcNYwHIuT9Wd7LCHtUI32pApyAY2eRnRw rcaCU4hsrEJTmXPHyMEUYrPiU6jc8HqDFyCHyG9yrzMnwcs29AqcSow8F56oj/+AIdF2KUhVzdA FeTwYCesVJwLljRlqqv/zcaeLACkPoVcov2MpjXnp906fi3dVFmkAPMrdVaSyJvy2/sPegEVZCo Rsstg33ggWo2FAohi/g== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfXx/CNB+eUzUtf ref/E29ov4fS2ChUp8N5WzyXYPldeokMKBAHsbL4J0TNeEIiRro6JwYOcWEpe9Ppnnx0wwGeup7 K221rqGw8MZlsYrECCymHu/98L87A+s= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 clxscore=1015 impostorscore=0 suspectscore=0 phishscore=0 adultscore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030164 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783096787181158500 Simplify #ifdef'ry using TARGET_KVM_HAVE_GUEST_DEBUG in kvm_init(). No need to zero-initialize kvm_sstep_flags again. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- accel/kvm/kvm-all.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 5d55cb45cf7..304467704ee 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -3040,21 +3040,18 @@ static int kvm_init(AccelState *as, MachineState *m= s) #ifdef TARGET_KVM_HAVE_GUEST_DEBUG kvm_has_guest_debug =3D (kvm_check_extension(s, KVM_CAP_SET_GUEST_DEBUG) > 0); -#endif =20 - kvm_sstep_flags =3D 0; if (kvm_has_guest_debug) { kvm_sstep_flags =3D SSTEP_ENABLE; =20 -#if defined TARGET_KVM_HAVE_GUEST_DEBUG int guest_debug_flags =3D kvm_check_extension(s, KVM_CAP_SET_GUEST_DEBUG2); =20 if (guest_debug_flags & KVM_GUESTDBG_BLOCKIRQ) { kvm_sstep_flags |=3D SSTEP_NOIRQ; } -#endif } +#endif =20 kvm_state =3D s; =20 --=20 2.53.0 From nobody Sun Jul 26 11:01:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783096821; cv=none; d=zohomail.com; s=zohoarc; b=cgfCpI6FFaTYbIeCmKBXpNcSAFI+aY2PVglMfVnMCI1GFYYeabEhOOyK5whyU78h3QkFf2BMrUvTbEIteeOyMQa52eVsEsPeq4g9hN5XlMicwcsXPPnD5+rvSmvBtGwnJ5DKCANhzkvLWjHhiC5ZV/Qgok5Q48o3FArBwHCrpgA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783096821; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=6WT95Gph8Xg6aTkiLQdrIw1hlxRErYZ/kEcLb8sMdPQ=; b=LldFq+nrOSzW/XidWVLBpNAoIb9adVCLGr3T/xNKu3tHibyq49tp35Hlh4fV8iMU4KeQpB3omUl+zR+4ISrpBQFjX+ItWUL18gj5ld9/Vn3cZSAj99abpIWBCAw/EQ1U6HwaK/UvMPij72pkMRjUJAuky/DXS+WCWlNUgbRYEX0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783096821279357.46140981336146; Fri, 3 Jul 2026 09:40:21 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wfgvp-0008TT-8c; Fri, 03 Jul 2026 12:40:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgvW-0007w3-S9 for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:39:45 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgvP-0008Dx-1n for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:39:41 -0400 Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663GIQTb446196 for ; Fri, 3 Jul 2026 16:39:23 GMT Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6b039ej3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 16:39:23 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-92e9a2b95b5so8600585a.2 for ; Fri, 03 Jul 2026 09:39:22 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c636ec8asm122240605e9.1.2026.07.03.09.39.20 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 03 Jul 2026 09:39:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6WT95Gph8Xg6aTkiLQdrIw1hlxRErYZ/kEcLb8sMdPQ=; b=W6GzltneyaqutTSF i+UcKHj/6/qspt5vFTQDS0Xn80nNuVxNFj0LrcptVuGDDoOby1GAqqzMM7JMr2LV o0/D4RwhLOyRjQ+8rHazNbJRSvb4T94K7QeB4MXJLQPV7QSKcwWCfmHRdTHLFY+E JRUNGbMguvuNGlqsp8TXnzQZBjVVPEcimC3dH+ObS/bZyFInGYa8j1R8nWwubG4Y Rh/yC23nEg1Bs5wiGk8TkO5JTQ8+appeTgrqQ0f46QhD16L5vBAemXCsH6Hz552D 8CE4e7250jjHMqid1hrjaAhS/357UDNh75puXL98ghORjjswB9OIzexRI3L4P2qB zryP6Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783096762; x=1783701562; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=6WT95Gph8Xg6aTkiLQdrIw1hlxRErYZ/kEcLb8sMdPQ=; b=aH8jrxy5FwY0hVpl2w/cFbIPf5RY3gKiZbRUOgi9DVydFpvxkC2icYfg8yb0U5AulS 7Yt0M0jfijvxzdJgcMwDpGEjHi9n8CbitkqWnM3yB4aEwdFjJIbbVogZS9jt/MBPAnaY WVR4iCPRM508pG0oqeTP9hVrZ6p+7jufGVRRQ1bkJ5r3U8k13w/rfuSlvnAs1zC/KWtv MjmQrE8xfWDl7mJUCoEogbspJANgKn99l8GHq3Yy91hnx1UU0to6vnqoM4UgHhyY9AAL H0SEdytR2XX5ivWdtIYvI5jNYlmt/pTwbk2qfM/xo5mJjSisHQBWgGY5AVxuJ0MP9Z7J mReg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783096762; x=1783701562; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6WT95Gph8Xg6aTkiLQdrIw1hlxRErYZ/kEcLb8sMdPQ=; b=QYTmSC6yAIqs9u9zG7ckuVxBA2kfwQea/xNgu4MgvG/L++lIPtC+JXi2GOVgb94gMJ 4Y2AJwvIFXr22gILxAQaor6Ywm2k/9BdmtulmwN72wzaicTgaOce5dmvb+kv0lMoZ3gR lm+0m1aytYmq7EUBriqsbL63DrxCABUHwu7g6nJnzGhfUkIlWccq7Ik+iVxkkke6FOF2 jFK303hJ5aFMVXZLhgxbbz/sgjiA8w8pPah/Nz0E4bJw70JGHLwtWit6c7DPV9q/+fre BZiwhON0z4uonjwjY+DIo0LNBp5msFnPzLvERmkea2NsKzoa5zc4NEMvucATVDqwTeXS ZZXA== X-Gm-Message-State: AOJu0Yzd6y+opdv5ARdyxf8ft0GSMszWdeICOglje942mkHvrBZsUro0 2eXaeZplLwwqPUF6kdV/vnrS1yoPgHoR5xJZK35VG3uYu27EThE3MC9svGP0fyghqm0GYcBsSIj ZbXtiUuGJ929pMCCTW5TQEwMp106HJw33GRAgd2cWJrwQbhtQah/ux/5G+/E6ThW1Lw== X-Gm-Gg: AfdE7clPysD3eayyXYJi2imih9atoMrOTqpIxAfC1jNldYLxU4f9HjBlFPMZpgwYEdE vCn14XuQymUSO20Xqg4lskA3pqXXeYeu4jeyL6bA1V5Op8CXk1K1BCf769vGtK11wIsAv5bPOfa qFLO3rnZ0zlmdQNHJ39YeQDB7e6LC8TITnifid6LcyiHBUbloXspMP208JrpRYv9i3wdIw67UTH /9elrP1hUyzgZtCJYgG1bgFcmu2I04POWyV6Cc28aFz3WDn4q+whusPWNjtrv3HWUTbmBFGE3MY s0mUpFR/4JBGiMHqtg+Lma7GiLpWI4WcwNgJtnulYqi5+d7VMWAxxvGz5M2m5BxAN4NMdgh+ByE M4YFGg+8AO0pBS0qtz6uchybxmY41Y1sW9FsCH9mYPAQjuBjL8XIvLQbkrtOrfvPmDg2D X-Received: by 2002:a05:620a:29c1:b0:914:afc1:c66d with SMTP id af79cd13be357-92e9a2f76e3mr32468985a.11.1783096762419; Fri, 03 Jul 2026 09:39:22 -0700 (PDT) X-Received: by 2002:a05:620a:29c1:b0:914:afc1:c66d with SMTP id af79cd13be357-92e9a2f76e3mr32463585a.11.1783096761900; Fri, 03 Jul 2026 09:39:21 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , Richard Henderson , qemu-s390x@nongnu.org, Xiaoyao Li , Zhao Liu , alex.bennee@linaro.org, Magnus Kulke , Peter Maydell , qemu-ppc@nongnu.org, Mohamed Mediouni , Paolo Bonzini Subject: [PATCH v2 11/33] accel/kvm: Hold have_guest_debug in KVMState Date: Fri, 3 Jul 2026 18:37:34 +0200 Message-ID: <20260703163757.55500-12-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260703163757.55500-1-philmd@oss.qualcomm.com> References: <20260703163757.55500-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX1R4E1AHUNVwz PoVqiNCH/9BVOc95XNmk1ujedW8uuOtNh6R16enwBjI78lDqmqFO7m9Rk+OYim3NFKswnRZ0Gom WTumI/zPCKZVbLzeJwtGXYXbhcd1CN8= X-Proofpoint-GUID: lYnXfhJTWOlhSBSJvoMLzjVDpiWl43h1 X-Authority-Analysis: v=2.4 cv=FoY1OWrq c=1 sm=1 tr=0 ts=6a47e5bb cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=O5kNlQXW-qQlE3Y8R88A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX92TUmg+a3xFk jFAFwddmpJT5bo4Q7zlXrOZP02ehYDi1fJGDuSMw6aU+DmtatMT9g8bfAxSmgICYHs2RNKNZfCc 1WsDO64NNcEEEOInBuzDUb0SpH+5mUh6Zs3F0lVkXLBa/6R1EQNk5whxFhrvjt/R2h5Jx3IAkW8 FAyOevB9mlAXMtD3DYX5CfKvmVQJP8FrbkGL4B7XNFNJdeaISddxq6TyAJy8dt8vwId4GZx+/Xb hL5B3gVUE9at5vdTLAKtKmz9VrW9oUfsCljrf+3wLwY8iRuh05mbq1NYsHDitTyJUrsRty6A/8k RvWyYOE1xtyHqBzcywJI8tTwsAg1q+yQXv56NnXiKxP0TPc5Vl5GPTrZU3XyM1yPq9S8MCwvmzH mkW8loZ9oU6zGKCMkAP3eWF6XUTBUISrg2pMFh9tycOZFpKUd/oLuFiPvCeTmmbB77yl0CBve3n e2uabMuLIKWQUEOn64Q== X-Proofpoint-ORIG-GUID: lYnXfhJTWOlhSBSJvoMLzjVDpiWl43h1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 clxscore=1015 malwarescore=0 adultscore=0 suspectscore=0 spamscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030164 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783096823396158500 Prefer to store per-accelerator variables in the per-accelerator state, rather than as static variables. This is a good practice to allow concurrent accelerators in the future. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- include/system/kvm_int.h | 1 + accel/kvm/kvm-all.c | 9 +++++---- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/include/system/kvm_int.h b/include/system/kvm_int.h index 0876aac938d..53bb0fcf180 100644 --- a/include/system/kvm_int.h +++ b/include/system/kvm_int.h @@ -118,6 +118,7 @@ struct KVMState #endif int max_nested_state_len; int kvm_shadow_mem; + bool have_guest_debug; bool kernel_irqchip_allowed; bool kernel_irqchip_required; OnOffAuto kernel_irqchip_split; diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 304467704ee..b6125125f82 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -104,7 +104,6 @@ bool kvm_readonly_mem_allowed; bool kvm_vm_attributes_allowed; bool kvm_msi_use_devid; bool kvm_pre_fault_memory_supported; -static bool kvm_has_guest_debug; static int kvm_sstep_flags; static bool kvm_immediate_exit; static uint64_t kvm_supported_memory_attributes; @@ -3038,10 +3037,10 @@ static int kvm_init(AccelState *as, MachineState *m= s) (kvm_check_extension(s, KVM_CAP_VM_ATTRIBUTES) > 0); =20 #ifdef TARGET_KVM_HAVE_GUEST_DEBUG - kvm_has_guest_debug =3D + s->have_guest_debug =3D (kvm_check_extension(s, KVM_CAP_SET_GUEST_DEBUG) > 0); =20 - if (kvm_has_guest_debug) { + if (s->have_guest_debug) { kvm_sstep_flags =3D SSTEP_ENABLE; =20 int guest_debug_flags =3D @@ -3833,8 +3832,10 @@ int kvm_update_guest_debug(CPUState *cpu, unsigned l= ong reinject_trap) =20 bool kvm_supports_guest_debug(void) { + KVMState *s =3D KVM_STATE(as); + /* probed during kvm_init() */ - return kvm_has_guest_debug; + return s->have_guest_debug; } =20 int kvm_insert_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len) --=20 2.53.0 From nobody Sun Jul 26 11:01:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783096820; cv=none; d=zohomail.com; s=zohoarc; b=hM2uvd9RjipbvH+8/JBG6/lcc0mT0hjgzND5c9Lo/LSWTgskyJObugtUhQgMSoBjh+ILFFDvjzzUAu36FLuzlAv1WFxaIPwD7jCXEZ1+xE6kKxsQrW8y6zWEcOoJ7Kirv9Oj7gxXkX0BhGEJIHV2LV8ujJoHaNreqTOcYQpajnY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783096820; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=YHmzSZVVsEvaI3vjx81RTf9QjIwrBBvLQ07wtGKj7d8=; b=iqrApyB7buJH/cd0C8pNjthZfBKr2v5mZdGy7QdteBJmtyHiYNizaL2D7Y3B3XjWw6mBOhdugGtEXwIUdzxcKx1UDnicQ+jURScAjJVt7/BwAjm9DjlJ1lSS7IShTtI7xGKd3Kpv5Y3lNhsErPRHCdlthxWtCk2/1B/h6x8Gj3c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783096820519274.288794551346; Fri, 3 Jul 2026 09:40:20 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wfgvr-0000DZ-BQ; Fri, 03 Jul 2026 12:40:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgve-00081L-9G for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:39:53 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgvW-0008KP-KI for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:39:48 -0400 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663GJOxk477914 for ; Fri, 3 Jul 2026 16:39:30 GMT Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f60eybx2n-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 16:39:30 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e55721a8cso67762685a.1 for ; Fri, 03 Jul 2026 09:39:30 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa0960af0sm520025f8f.30.2026.07.03.09.39.28 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 03 Jul 2026 09:39:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= YHmzSZVVsEvaI3vjx81RTf9QjIwrBBvLQ07wtGKj7d8=; b=FhwZ8krQbLMSh3Tk pWKUYJc8KXBcIBP8TB2ZTc27pK63NIr9G45KftBPxPRZTyk0g6Ab6M5nMQylPCH7 sLF2fy1vU8P8G81HYJ98YVclPya84QafjsiVOi30weqlY5UpkhYUKlOOpd/peflg 55nGjeUXgwCNrfpYJb1myBS1OKvVRgcL6c7AmJQ2LQpM0wkCoL7XxMWTPFm8mfIr igyo24E4bbtbguCz8x8UzeXAy7AOc6CjtSF64IaJR667skWhIelCgPHgMUX04azs onIKxjOHzjR3sNT0PmClXsBxKssna56BaUmVpWvRarYhnUgqy1M+GAIc480DyMtJ NApetg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783096770; x=1783701570; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YHmzSZVVsEvaI3vjx81RTf9QjIwrBBvLQ07wtGKj7d8=; b=Puk0ARrSwFoHMbIIo/3pVv0Dq/Z+kUMAOCkitkGIJcjsPA4tE2v40WIgmDQYU0PO6L ipavBm4Wfp81bN9vYS1s4EaUPWe1gnkTbtdCyvUNlesuon5ir9StRXroJKZavoLSytmq oFq5BxDTYjjOwendrRB/3AnQ5ZBLu6Pjvy5ihVEyhUaEUJHl9V3XRQmHITDC4BKqvv8b Oelg7eopUr4gJSEdO2OLShN2EC6ftssGUu4DBh6gygWrAO7iuLm2rr5zOgEmQQ1/nEWv c2FOqft/JV5AbRcxGDjB8Qd7uc0YLgeB/fl5E5pFk7az7TbuaH45KGMW9Yl4gY+dVX2K MNNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783096770; x=1783701570; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YHmzSZVVsEvaI3vjx81RTf9QjIwrBBvLQ07wtGKj7d8=; b=pJRxewxRUdpPRRafJMIvDWZ3oD9HQnNtYVuu8FQZREH+sXa66UZ3/HbQ1mxhQvGDpT N6fLZnLqimkahBcac8C6YMgVoM/q1Nnc/sWVvNdyLVGPSP8wSioX0Bxu3vUmVsWl7moI EQsiRdegQOHV9BzNRWTEBfzbTa9ot/SIxiWd0RrTJVucSpf96uYbN+S6syms0qWoNGE9 FvMjppfyQywrJkt3HRLGedyfbQWVVZtTzJvdnWM0cmZ9qKIeGeGIDG+3fNPcpuIHsGR7 uUq0qDzWXVtlcQfWdnLnX6sur7iiG8/jxYHjLqoyTx9fSLEEXKu0+HRJyUrB8QlkU4Sg 1MPQ== X-Gm-Message-State: AOJu0Yw14vuundgEfxLDtY6Daon1p+VSXpNnhoHFqqAgI0akg778noBi VqzcKonfEgIgEY1LLsvbmPhH9odc0y1ZWThDyJcbqIR1Fa5AptnYh6xOm+L7a0LIg302mAXvrJG x6+ItWwm2D05DMVnGZJrdHZGgd3biuMa0qCFPHC7r+kv/rM2pBIr+cSNh/GVatSXlZg== X-Gm-Gg: AfdE7cnf/YsHcQj5JYeJtMqKggzfWpA+qdoNik3BVQwb0/Dl7rA9HzAD6XlIXMBRKYw xeyw9BvW6J2FqCeuxdMDF+Ur4CbLrPB7IRcW4Ndjvk5pEfSyOMJEFvjs3x/h71LgVVn98/jO0Ne lHIlz6Qns5N4a8ADQgPNzi2hzaGKdbp+359VPv/0oUzjC6jT0hvsNtW0GKdDo1P4EMWJ3YhGyG1 TXbXDjRVf33hAbN18yDpZnXR+xqEM85mlSyOWtKQonTjwa3fn/pY/7n0KssKjO/Ko03rWeKXXvd xaRgQ5ug+QymctXlXoe3aE2y+etQb3suVDgaeEFcl/0XHGDFWyeoPfhaifeILZN1Q/lfqE8g4dA ke+60vGYsEYRj90TSZh/odyW2InuMuWoN58vrzc4snk5Bf7a5pAI26V4GgLaSzAkM5DUp X-Received: by 2002:a05:620a:8399:b0:915:afa5:754 with SMTP id af79cd13be357-92e9a3133c3mr33826485a.2.1783096769817; Fri, 03 Jul 2026 09:39:29 -0700 (PDT) X-Received: by 2002:a05:620a:8399:b0:915:afa5:754 with SMTP id af79cd13be357-92e9a3133c3mr33821985a.2.1783096769364; Fri, 03 Jul 2026 09:39:29 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , Richard Henderson , qemu-s390x@nongnu.org, Xiaoyao Li , Zhao Liu , alex.bennee@linaro.org, Magnus Kulke , Peter Maydell , qemu-ppc@nongnu.org, Mohamed Mediouni , Paolo Bonzini Subject: [PATCH v2 12/33] gdbstub: Inline gdb_supports_guest_debug() Date: Fri, 3 Jul 2026 18:37:35 +0200 Message-ID: <20260703163757.55500-13-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260703163757.55500-1-philmd@oss.qualcomm.com> References: <20260703163757.55500-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfXwKDHh6YRBY+l PV63M4X+jhuFLIsbkPwcfIbqDNKUHiOx0j24hb2/EuBCI/PIIVewrWFXK6duAij31n/v5A2pRYu iwITkcpSqds1XX/jMHNNNeK3wDzU6JnbndXROeLgQu8u2Laa4RksFrLAL58iUbEGGjFXHa8lYQu DSsV9WF9thWpUK4qFbIEp50bCWvcp3TwkB2USJgNgYm62Jz6hSx1KCiTisceBGuj/d2zmeK3hvb VRilrZk0FQoP4bfmwMm+BeJKA0GCQF0kIiPiyh5tkQiLTqRDCDOwfcZeGyRQSJ7EYaaRwTm2A6F 2NhYYm+quqdPQ10C3c39GaAKUTvyily531Iy3+0mmgjmyketGUDZW99J8nmBwW2HsT25gLePqdX a5Or56temy9eREXfHqWXAm9A4qsGeq9EIsT5EjJQBSMqCFHSDoXRo6upqw5iIpYqoZd/yf7Sj3s w2YN3iEmdjdTVlfM/fw== X-Proofpoint-GUID: aA_ah61wr5Ob7uGoP9XMtledgc_t1_rt X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX1OkjN7AejTbJ KdBc5Tx/W+49XtBBPghUq9XJZxqGgtJlhiF/Oo8Qedk+UZUEeIHHxgccA3NB+XBCeAyuCuNOD7l UOSHHWgs9OUFJVrRnQh0+5UIBMjOHNE= X-Authority-Analysis: v=2.4 cv=SPRykuvH c=1 sm=1 tr=0 ts=6a47e5c2 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=mZCV-s_RuDa5I9ykUf4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-ORIG-GUID: aA_ah61wr5Ob7uGoP9XMtledgc_t1_rt X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 spamscore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030164 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783096821700158501 gdb_supports_guest_debug() is only required for system emulation, inline it there and remove the user emulation variant. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- gdbstub/internals.h | 1 - gdbstub/system.c | 4 +++- gdbstub/user.c | 6 ------ 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/gdbstub/internals.h b/gdbstub/internals.h index 9b25bf58b8e..60ddc146661 100644 --- a/gdbstub/internals.h +++ b/gdbstub/internals.h @@ -217,7 +217,6 @@ void gdb_syscall_handling(const char *syscall_packet); * Break/Watch point support - there is an implementation for system * and user mode. */ -bool gdb_supports_guest_debug(void); int gdb_breakpoint_insert(CPUState *cs, int type, vaddr addr, vaddr len); int gdb_breakpoint_remove(CPUState *cs, int type, vaddr addr, vaddr len); void gdb_breakpoint_remove_all(CPUState *cs); diff --git a/gdbstub/system.c b/gdbstub/system.c index 2063b63b2f8..1179c82cb86 100644 --- a/gdbstub/system.c +++ b/gdbstub/system.c @@ -331,6 +331,8 @@ static void create_processes(GDBState *s) gdb_create_default_process(s); } =20 +static bool gdb_supports_guest_debug(void); + bool gdbserver_start(const char *device, Error **errp) { Chardev *chr =3D NULL; @@ -627,7 +629,7 @@ int gdb_signal_to_target(int sig) * Break/Watch point helpers */ =20 -bool gdb_supports_guest_debug(void) +static bool gdb_supports_guest_debug(void) { const AccelOpsClass *ops =3D cpus_get_accel(); if (ops->supports_guest_debug) { diff --git a/gdbstub/user.c b/gdbstub/user.c index 97eb13e796a..f7bc4e63dfd 100644 --- a/gdbstub/user.c +++ b/gdbstub/user.c @@ -796,12 +796,6 @@ bool gdb_can_reverse(void) * Break/Watch point helpers */ =20 -bool gdb_supports_guest_debug(void) -{ - /* user-mode =3D=3D TCG =3D=3D supported */ - return true; -} - int gdb_breakpoint_insert(CPUState *cs, int type, vaddr addr, vaddr len) { CPUState *cpu; --=20 2.53.0 From nobody Sun Jul 26 11:01:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783096819; cv=none; d=zohomail.com; s=zohoarc; b=ZUSnoodeAbiXKLWJ//RC31KUpg68DNE1ONoTl/pPdDyHF90SjnUZ5fYUle6xKiNTF41PrCCqkjHqm2XfUP+vaJCYJHqhsD7BLRm2K5J33KHVC1/rgdbnKFW9C0YOjVScIQJsJ9rSqVO/IFu2HH4VGPhX5UAPcTpDnhRZciJtXjw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783096819; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=DX7N5baSLNWo28XL7Yla9xA9xJlKE33supZnlBMANrY=; b=PTtnJZkxjSAlbdOwHhIOunbK5IKAUCYXqiB75MDw+2xAfl60tQf3Fkt+dvKFSdEVfI3hNEV6GKzrgrBrFiNHq/rkvvYm8wO8dlCnRRnnhKev+t/EvywQTfgKsxTVb4bGCzm9tVHwHGtFWEOZGS30xhIA6glV/hVChgVGmeLQOBQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783096819266416.53212740749905; Fri, 3 Jul 2026 09:40:19 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wfgvn-0008PZ-EQ; Fri, 03 Jul 2026 12:39:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgvj-0008A7-Jz for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:39:55 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgvb-0008Qj-FL for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:39:53 -0400 Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663GIjMI499331 for ; Fri, 3 Jul 2026 16:39:39 GMT Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f64b5b6ug-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 16:39:38 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-92e53b8a302so70602785a.1 for ; Fri, 03 Jul 2026 09:39:38 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493bef23feasm177457575e9.2.2026.07.03.09.39.35 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 03 Jul 2026 09:39:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= DX7N5baSLNWo28XL7Yla9xA9xJlKE33supZnlBMANrY=; b=aepKGwXx4qlZ960Q JffurNyRFxv0as0qsitf+mqShsPuVBK+VuR6ihP+oe4M9HjCV37iqV6MMqykjhYX EXCLJk33f4C+ZsOdaGmOmfPyMLK7AofUR6m34sdXrrgx1sCgSULRL47pxG1VlRhC /UpN9No6tJwItG+oGzBOTmVOE20pAGM74sxj1fY8MTiNb7xjueJKVoCpe9TxJxDc Owct3oOyZybdgEn4BCIwGtdkW08g95ms3YdoyRVlf3WDYKR32JXP/zn83wfXYrz7 ihRrCHKagY/Gl/G/G1XhD0VzV+6hXUU6f6tug2JZp2lPndl0xkteQbrWHPPEH/vY xRhdeg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783096778; x=1783701578; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DX7N5baSLNWo28XL7Yla9xA9xJlKE33supZnlBMANrY=; b=B6Aea4QpCM/bkQr491ola5IIPKAzzqfHUXeZlkZgZR9EHKWC4N30aRHEY/vAg4jFRY /zRZCsVBuenWZXzbYSSSIzg0PFPOIQlNDiikU7UbZDe/9I+PN0V25E5jQhBMKzkOZp3P 7w3JfkuUe23ih/srALw4NVUah4X/mFfYR+xVp9oKculDU36fSHuaV2NyvgiYuWlCjWWl eqmBHO7gfetVgmes1MArhWC5v2Tt6UQrvq4OHondEbiPiB9Ey1x0AWt2c97aLwunApPO 8IX0FPbyOQfxbp+h9BtssP70RM2WwlxJDk/ZjjM1zSPWa47k+UAufjyXh4wnE5trtL6e S7Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783096778; x=1783701578; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=DX7N5baSLNWo28XL7Yla9xA9xJlKE33supZnlBMANrY=; b=dxu6FsQK6C1lszZTheQSXd/1s3Ic3iO55+Y/J51MrW90UF5InJReiTQr7m45JFiV1j CKsR21C8buhS7X6NQJcp28tiwQxN1/6+xTPswh20MdgPehpvHpmQVxO5eJ98qb9O2Lv6 JiH8IN6T18xqS1aJNcSeiix8vWhkz9rZaEckMwfThb8tafRUbA9amvSSPoBFXr9CtALe c6aO/xlNeeMkw+/33xKiPeRIraU5GLDybeyJGvQ8FY/8/xopVoF+wkqpiWXNY4R17N3N nwCMtX9LlC9qNTQJW945JedX6cVgSAbc21DNYuApZn3biGMJRH0dMKxk/Wsl7QJG8hun 05Rw== X-Gm-Message-State: AOJu0YxM9Ji445mpvC8qF6KqZFu+M/UW4T0M9iA1WphjC5gmo6N4smG6 Skni+X8v/GOVevyEZXXWN38DmHzvV+knGzr01P+S5UQB9hq4o75FdXiR80EiMryRVGTlxvi7Xhv lB912/FiROY0KDpZk/Aj6tPlana/iy728iPPiCRZj7ZcvUA2HCQgmTIWKuF0Q04qRvA== X-Gm-Gg: AfdE7clkHMbw/2TJ1TtKzoO3WZq1zy672dQULF3M6LVnj3o2cMU9vLj1eTg/elu90K6 4tv7gqGZMDLhDq9ZjRb5k+8+kyMrwrnAUMrWzjouSvwBrSVfo63wQHlSkNtE88fRQWsCrOrHh2K sttqapoe155nwBOmQdXbTXumAmhOwjAA+MhWXXpYDQw7/pwVdRYjvYV19qnlNzbeehmWoU2nqvj vkNHfQDi89Re4KUQ+6WmtM0VPzy3XLonaxXqKcZjg8yHBLGUCKPB9yZJUf6AeKrbNatMdmPJQlB rxtKjs6/R2yIPJWJafOb2uXPmrbYtz1+1SG5ED+E3kF8xBE665Vh4yzEwDZx1+bWcRvHA8pkN4I os7zKxxhsMlAFCaw0wy65YU3e4fLAjT27h1Ds+PbsE83jWSFiyQ4VtT8A7qS2H11Nxgjv X-Received: by 2002:a05:620a:890f:b0:92e:8734:b721 with SMTP id af79cd13be357-92e9a3b8a72mr29558685a.29.1783096777728; Fri, 03 Jul 2026 09:39:37 -0700 (PDT) X-Received: by 2002:a05:620a:890f:b0:92e:8734:b721 with SMTP id af79cd13be357-92e9a3b8a72mr29553285a.29.1783096777096; Fri, 03 Jul 2026 09:39:37 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , Richard Henderson , qemu-s390x@nongnu.org, Xiaoyao Li , Zhao Liu , alex.bennee@linaro.org, Magnus Kulke , Peter Maydell , qemu-ppc@nongnu.org, Mohamed Mediouni , Paolo Bonzini Subject: [PATCH v2 13/33] gdbstub: Move supported_sstep_flags in AccelGdbConfig structure Date: Fri, 3 Jul 2026 18:37:36 +0200 Message-ID: <20260703163757.55500-14-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260703163757.55500-1-philmd@oss.qualcomm.com> References: <20260703163757.55500-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfXwqxcNHYa1g7u IFulPSjqMOX9RU/i55HMYLh5KzVWJ1PnaHuncyRgO31MzDGu2z+LZqnFDsxQOF/OjYdoyh6bRPG lxDBAdROxVTozGtR4XOxjfb0cIivd5w= X-Authority-Analysis: v=2.4 cv=FOQrAeos c=1 sm=1 tr=0 ts=6a47e5ca cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=2uWoCNkfsxSLpB2ydr4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: U3OjT4eJuY0j7QedQtgAzXmsGlBdnx3g X-Proofpoint-GUID: U3OjT4eJuY0j7QedQtgAzXmsGlBdnx3g X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfXzZ5Yp43EMUCy 5WGLwIrDZF4p801XF3sYszThfUoggO0wKlOx36qEtoOikkJx9Jk6R8+z0sLjmA8NXWOwADaDKEq 9UoTXTKgLG7yTa7ZQts2On65v0nnt4RHzfw8YEUqaExrHOrdC+XvwGBRmxMpGBPSoapTTSP37gy AkIiGPLK53QsvYNW3UYsq676uXLu4QLe0bldGEWiXzIPwueS0Lqf8G+wrJw4oSqjRAF6RAIC6vo IOcGYrJgS5ycIRKzPKy25eWlu5UCdamBEnrB6EXo6XyCuOHPuQhi58+EfxpBagu2nKwHREO8C4c ytHFcgjOPcpXwyi0kxGG2aTZVreXNiRVrMV3c1ftiuhy9R/gFcl3GKDKEdIDyUBgW7rDk1hXH8Q GcgtG3Kh5SJ06/qncbBLcYhmcMzHItiCRxYE2anLyXD9D6RyZSyVNKAcllwzROf86xNN02ZofMS 25AAHJgg2mrhXVAGHHA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 adultscore=0 clxscore=1015 malwarescore=0 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030164 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783096821715158500 supported_sstep_flags are per-accelerators. Move them to a new AccelGdbConfig structure, still in GDBState. Suggested-by: Alex Benn=C3=A9e Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- gdbstub/internals.h | 3 ++- include/qemu/accel.h | 9 +++++++++ gdbstub/gdbstub.c | 10 +++++----- 3 files changed, 16 insertions(+), 6 deletions(-) diff --git a/gdbstub/internals.h b/gdbstub/internals.h index 60ddc146661..0444dee2246 100644 --- a/gdbstub/internals.h +++ b/gdbstub/internals.h @@ -9,6 +9,7 @@ #ifndef GDBSTUB_INTERNALS_H #define GDBSTUB_INTERNALS_H =20 +#include "qemu/accel.h" #include "exec/cpu-common.h" =20 /* @@ -83,8 +84,8 @@ typedef struct GDBState { int process_num; GString *str_buf; GByteArray *mem_buf; + AccelGdbConfig accel_config; int sstep_flags; - int supported_sstep_flags; /* * Whether we are allowed to send a stop reply packet at this moment. * Must be set off after sending the stop reply itself. diff --git a/include/qemu/accel.h b/include/qemu/accel.h index d3638c7bfda..052b4c59313 100644 --- a/include/qemu/accel.h +++ b/include/qemu/accel.h @@ -73,6 +73,15 @@ bool accel_cpu_common_realize(CPUState *cpu, Error **err= p); */ void accel_cpu_common_unrealize(CPUState *cpu); =20 +/** + * struct AccelGdbConfig - gdbstub configuration for an accelerator. + * + * @sstep_flags: Set SSTEP_* flags that accelerator supports for guest deb= ug. + */ +typedef struct AccelGdbConfig { + unsigned sstep_flags; +} AccelGdbConfig; + /** * accel_supported_gdbstub_sstep_flags: * diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index f54415a9db7..31eb0ca6a5d 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -72,9 +72,9 @@ void gdb_init_gdbserver_state(void) * By default try to use no IRQs and no timers while single * stepping so as to make single stepping like a typical ICE HW step. */ - gdbserver_state.supported_sstep_flags =3D accel_supported_gdbstub_sste= p_flags(); + gdbserver_state.accel_config.sstep_flags =3D accel_supported_gdbstub_s= step_flags(); gdbserver_state.sstep_flags =3D SSTEP_ENABLE | SSTEP_NOIRQ | SSTEP_NOT= IMER; - gdbserver_state.sstep_flags &=3D gdbserver_state.supported_sstep_flags; + gdbserver_state.sstep_flags &=3D gdbserver_state.accel_config.sstep_fl= ags; } =20 /* writes 2*len+1 bytes in buf */ @@ -1537,12 +1537,12 @@ static void handle_query_qemu_sstepbits(GArray *par= ams, void *user_ctx) { g_string_printf(gdbserver_state.str_buf, "ENABLE=3D%x", SSTEP_ENABLE); =20 - if (gdbserver_state.supported_sstep_flags & SSTEP_NOIRQ) { + if (gdbserver_state.accel_config.sstep_flags & SSTEP_NOIRQ) { g_string_append_printf(gdbserver_state.str_buf, ",NOIRQ=3D%x", SSTEP_NOIRQ); } =20 - if (gdbserver_state.supported_sstep_flags & SSTEP_NOTIMER) { + if (gdbserver_state.accel_config.sstep_flags & SSTEP_NOTIMER) { g_string_append_printf(gdbserver_state.str_buf, ",NOTIMER=3D%x", SSTEP_NOTIMER); } @@ -1560,7 +1560,7 @@ static void handle_set_qemu_sstep(GArray *params, voi= d *user_ctx) =20 new_sstep_flags =3D gdb_get_cmd_param(params, 0)->val_ul; =20 - if (new_sstep_flags & ~gdbserver_state.supported_sstep_flags) { + if (new_sstep_flags & ~gdbserver_state.accel_config.sstep_flags) { gdb_put_packet("E22"); return; } --=20 2.53.0 From nobody Sun Jul 26 11:01:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783096846; cv=none; d=zohomail.com; s=zohoarc; b=jfk1Ia4zKO53kK1T9qJOwa+8tNjvDICloCL3qHgqreLh/tGwzzkq6t7X/XKd3ihi9bKO5kVknCEeEw993ctnac6HEyssQDVK6nQCQKHmesuVNQDqoSoqDQsPjtOFIXpiV3Tc1LGjf+ekcjtbh3RuWyvDL6IYGInHPiHimrDcTjE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783096846; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=xElOALWefO9RHith08ytAYtAwWPa8il6Q7X6T2pFNzM=; b=LVqW3vWXgNaxuMhNnCw6o5dyzK8+iPq56xYlXgq2sQYgtJsAVumBBv0FYzOIVXNnAYrZfuSL2Eaa9393TAf+LzCCRDk1eb8Erf17xUuEyl4EggxhDA2BoBI3TsQMeSAfG8mun0TFXNkwC6+W3UxW7NqolNVKNOvSInMzfLrCdCI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783096846822602.3272220808755; Fri, 3 Jul 2026 09:40:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wfgvx-0000aV-0V; Fri, 03 Jul 2026 12:40:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgvt-0000LY-H7 for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:40:06 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgvp-0008U9-DG for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:40:04 -0400 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663GIbFl489322 for ; Fri, 3 Jul 2026 16:39:46 GMT Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6ckj0ytj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 16:39:46 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-92e623b0e95so64366885a.3 for ; Fri, 03 Jul 2026 09:39:45 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493ccdab3a8sm66538215e9.6.2026.07.03.09.39.43 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 03 Jul 2026 09:39:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= xElOALWefO9RHith08ytAYtAwWPa8il6Q7X6T2pFNzM=; b=i23E22M4ew7Xebcf AnxrtzX0/8yj/JlYWarOJ0pbRU5irkLtdmGABpZZ6a0C14vGN6c9QsrBLwk6dMZt PbaLNl+Cfyv8fgIN2nE2Hs0NIVQHz9r+Aaqq4RuNT0VTTx/Py0RQTbAXThCzn4PE NJedgv8pwl63GXvjkrrSuDo33ogqsF8e0svdaQuQFoWHOffm7/zQMnVkBI1jYK1l NKnRSio5QYKTh5xLXUwmY9WPBlabDyngM1rIGzW4vBGA8V1nyS8M9N0zBka6BMcR Z2+paQfyyvZgxF6jfwEbxMCcV9vajuJ6FZQr57f35DDhZf0oFqUFgnAnDXeB9Sjp j+FzoQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783096785; x=1783701585; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xElOALWefO9RHith08ytAYtAwWPa8il6Q7X6T2pFNzM=; b=IZ61aByJ4mHdRkfh4miTHEU4STW08AcnZqc1aj8549mPFIADQfIkoNbB5rbtHcLkXD hi8ZsAfSdqYYdFGO3NnYl7lOZ3Z8TmM5JgwfVc1YnjYjq0Cbj4noJCl9h31inunQDXC8 65JelsNMXkl53TUrD80iud4uzCl3qa1C7juwJLB1ujqGTBalJSdMwTh6W28nAxk+moyn eC6uJF4sY98xCR5zrLPiBjVz93kIJ04PaqwgYGTTPT9uHCspjZW66qSsUgjI71jW7dA2 Od94DQSh8XO23mrk3EBNjzEsLgNeHhfj3Lceu74zUVHVsbizlodG52HigR9qUdS7wQ4T b5wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783096785; x=1783701585; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xElOALWefO9RHith08ytAYtAwWPa8il6Q7X6T2pFNzM=; b=Cnu8ufEgGazH/LjJROrI3OKmf6nkUd71ddRtpdrppfoVhJLaX5LF8nbDXORSEhEbCz SdOK00eJrbKf0IQzekpNm1LIr/9tHrwmlAB8QXQHB4VQjsz3BZMfbqMeE1/KlPwjLGjZ 3Uw8sHlD13vJoFLOxz0W8Nez4gNzU6ZWsqt4eRlUwyG93oSkP/wxI08Yr/hjJxuX+4Yk 6gtKoIYPmXpm5MWjkHEtJr9i89tTdQ0pXa7YmaDuSQpjorAmmijIBo3geVQ5HIF4N/Eu 18J1XIHr2p6MVAb2O76mOELwo8dzexrxjodKQ86jxWrFIUNj27t1+qTkrST5VKI39wWD wRLg== X-Gm-Message-State: AOJu0Yw2hc7cVTW0ynl4Jal/aqHiI0/syWL8MUpSwIf7y0LgXyf2mWvz S+0JMssqoBdeVBnjtd2DN6erh5Y/Fprud1dJWzKToersWUVTh7GRZVUUS+I5EaazZXIJJrmErCw 27oG3h7HdlTsCEnNpSfM4dtRg52u18y7+BKPEB1LcpYsjZwdRGxRWaRB2AW/uCdPYAw== X-Gm-Gg: AfdE7clDYC5jz2odf5uXbu9esxOwsMKpiGCbi8k5+vKsSq8KaJ101aa5yIOsTW6s7NG Kh3MIK+hiWKjJI2COd1hi+7FCJu8xRhEyBNfYywL6nnujb/bETY7HddpO2Pl9QWRN1aXPTBDQ2q /WGIP8oMiXw0t9igjlWODY1XBHZhIlBeBEz08PkgH4LfLBzrnUVZi4hYd/cuyQ1+qYHBzH68xT/ NizibpA1fDxH6l7ElzM5YBfJd738DyldQ6acgn9MsBnzkNb1QU66cUeU0M/ZRaLe+LKpK5sn4TQ yCWCFjP25JK1JJNA/t0oSB/W3aSaGA9WcEA8/0VGvHniI22TCYvdqDZuVdA0mzLH0vuLhguIE/d 5Kx1AGCCbR4ATay0I/lgYIlUBSxpSnrbU4sE+Z9YyUGu4wC+Okv5h/YQbC6MnXSJHu0ku X-Received: by 2002:a05:620a:44c3:b0:92e:4a4a:4478 with SMTP id af79cd13be357-92e9a3c1e5emr30657585a.31.1783096785317; Fri, 03 Jul 2026 09:39:45 -0700 (PDT) X-Received: by 2002:a05:620a:44c3:b0:92e:4a4a:4478 with SMTP id af79cd13be357-92e9a3c1e5emr30654185a.31.1783096784799; Fri, 03 Jul 2026 09:39:44 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , Richard Henderson , qemu-s390x@nongnu.org, Xiaoyao Li , Zhao Liu , alex.bennee@linaro.org, Magnus Kulke , Peter Maydell , qemu-ppc@nongnu.org, Mohamed Mediouni , Paolo Bonzini Subject: [PATCH v2 14/33] accel: Have each implementation return their AccelGdbConfig Date: Fri, 3 Jul 2026 18:37:37 +0200 Message-ID: <20260703163757.55500-15-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260703163757.55500-1-philmd@oss.qualcomm.com> References: <20260703163757.55500-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX6yvy7HrwIEma iQifVHKeXPc1hYKCFq91GjK2H84TGTnepTYPx2UtjJmSeALSk0eDQdzF1ygUh6S9ySuwawbpWnt l1AZtyjUptDbDh9I8BDiAPkzGQX4G/o= X-Authority-Analysis: v=2.4 cv=E8v9Y6dl c=1 sm=1 tr=0 ts=6a47e5d2 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=ft8xR6t4uCTsT4XH6kQA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: tl2VJu2eHIKaZRt9wLJKvw5najgCeDKR X-Proofpoint-GUID: tl2VJu2eHIKaZRt9wLJKvw5najgCeDKR X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX5Kv95s7a4O+A ZIqQLUgLOE7pYWgHTlCM1vaaqg5zrBQengpB2EbrLgNqP6h+gNq7HidjdZ2it3p5tn3xKrzhYT9 9Km5UXGRp/3IPdvrlAXxCMH93/9ODwA3vhnaTKiW+3y1et/rhEO39IJv51lgWNf8oXHa1ei13lf QKhVdAgpLAVe0c+QpDZryrZuAOdMvsPni+dE5hiu3gPgYRUFnv3+YZvSmeaMWy7GVD1c8EMqurQ Hvf6kIATkWC4fvfzn+PB3FUj4Dt4VP64gttwOtXYJHnrFGC6fnmzYdMNpqJHas8Yrwum3tlC2Pa jaoT+2aYfvU4hOkb4fm/jXb5fGO2AT7hdMwErgN/nwOkc3YT8gVvlZobzQv52Vi3ysZ5tk4jUZ7 ocMFMY1uTX8CHezQBZk75NNHYEzveK6ckE8wZVrTKcxrlM2RBrs6KaNALwBNbldtO4If8u/sNDZ QLC+FJC+ANesk234HSA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 phishscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 suspectscore=0 adultscore=0 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030164 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783096847685158500 Hold the per-accelerator AccelGdbConfig in AccelState, set its single @sstep_flags field in AccelClass::init_machine handlers. Remove the AccelClass::gdbstub_supported_sstep_flags() getter and inline the single accel_supported_gdbstub_sstep_flags() call in gdb_init_gdbserver_state(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- include/accel/accel-ops.h | 5 ++--- include/qemu/accel.h | 8 -------- include/system/whpx-all.h | 1 - accel/accel-common.c | 10 ---------- accel/hvf/hvf-all.c | 8 ++------ accel/kvm/kvm-all.c | 17 ++--------------- accel/tcg/tcg-all.c | 27 +++++++++++---------------- accel/whpx/whpx-common.c | 1 - gdbstub/gdbstub.c | 2 +- target/arm/whpx/whpx-all.c | 5 ----- target/i386/whpx/whpx-all.c | 7 ++----- 11 files changed, 20 insertions(+), 71 deletions(-) diff --git a/include/accel/accel-ops.h b/include/accel/accel-ops.h index f46492e3fe1..9f3f329c448 100644 --- a/include/accel/accel-ops.h +++ b/include/accel/accel-ops.h @@ -13,6 +13,8 @@ =20 struct AccelState { Object parent_obj; + + AccelGdbConfig gdbstub; }; =20 struct AccelClass { @@ -36,9 +38,6 @@ struct AccelClass { bool (*has_memory)(AccelState *accel, AddressSpace *as, hwaddr start_addr, hwaddr size); =20 - /* gdbstub related hooks */ - int (*gdbstub_supported_sstep_flags)(AccelState *as); - bool *allowed; /* * Array of global properties that would be applied when specific diff --git a/include/qemu/accel.h b/include/qemu/accel.h index 052b4c59313..3b01d55741b 100644 --- a/include/qemu/accel.h +++ b/include/qemu/accel.h @@ -82,12 +82,4 @@ typedef struct AccelGdbConfig { unsigned sstep_flags; } AccelGdbConfig; =20 -/** - * accel_supported_gdbstub_sstep_flags: - * - * Returns the supported single step modes for the configured - * accelerator. - */ -int accel_supported_gdbstub_sstep_flags(void); - #endif /* QEMU_ACCEL_H */ diff --git a/include/system/whpx-all.h b/include/system/whpx-all.h index 0e2d333e919..4022571ffff 100644 --- a/include/system/whpx-all.h +++ b/include/system/whpx-all.h @@ -23,7 +23,6 @@ void whpx_arch_destroy_vcpu(CPUState *cpu); void whpx_arch_accel_class_init(ObjectClass *oc); =20 /* called by whpx-accel-ops */ -int whpx_arch_gdbstub_sstep_flags(AccelState *as); bool whpx_arch_supports_guest_debug(void); =20 #endif diff --git a/accel/accel-common.c b/accel/accel-common.c index 62590a7d9a6..f31d68a9b78 100644 --- a/accel/accel-common.c +++ b/accel/accel-common.c @@ -113,16 +113,6 @@ void accel_cpu_common_unrealize(CPUState *cpu) } } =20 -int accel_supported_gdbstub_sstep_flags(void) -{ - AccelState *accel =3D current_accel(); - AccelClass *acc =3D ACCEL_GET_CLASS(accel); - if (acc->gdbstub_supported_sstep_flags) { - return acc->gdbstub_supported_sstep_flags(accel); - } - return 0; -} - static const TypeInfo accel_types[] =3D { { .name =3D TYPE_ACCEL, diff --git a/accel/hvf/hvf-all.c b/accel/hvf/hvf-all.c index 21b9b71a6df..8bd9154a50b 100644 --- a/accel/hvf/hvf-all.c +++ b/accel/hvf/hvf-all.c @@ -220,6 +220,8 @@ static int hvf_accel_init(AccelState *as, MachineState = *ms) } assert_hvf_ok(ret); =20 + as->gdbstub.sstep_flags =3D SSTEP_ENABLE | SSTEP_NOIRQ; + QTAILQ_INIT(&s->hvf_sw_breakpoints); =20 hvf_state =3D s; @@ -228,11 +230,6 @@ static int hvf_accel_init(AccelState *as, MachineState= *ms) return hvf_arch_init(); } =20 -static int hvf_gdbstub_sstep_flags(AccelState *as) -{ - return SSTEP_ENABLE | SSTEP_NOIRQ; -} - static void hvf_set_kernel_irqchip(Object *obj, Visitor *v, const char *name, void *opaque, Error **errp) @@ -278,7 +275,6 @@ static void hvf_accel_class_init(ObjectClass *oc, const= void *data) ac->name =3D "HVF"; ac->init_machine =3D hvf_accel_init; ac->allowed =3D &hvf_allowed; - ac->gdbstub_supported_sstep_flags =3D hvf_gdbstub_sstep_flags; hvf_kernel_irqchip_override =3D false; hvf_kernel_irqchip =3D false; object_class_property_add(oc, "kernel-irqchip", "on|off|split", diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index b6125125f82..ceb0b33abdd 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -104,7 +104,6 @@ bool kvm_readonly_mem_allowed; bool kvm_vm_attributes_allowed; bool kvm_msi_use_devid; bool kvm_pre_fault_memory_supported; -static int kvm_sstep_flags; static bool kvm_immediate_exit; static uint64_t kvm_supported_memory_attributes; static bool kvm_guest_memfd_supported; @@ -3041,13 +3040,13 @@ static int kvm_init(AccelState *as, MachineState *m= s) (kvm_check_extension(s, KVM_CAP_SET_GUEST_DEBUG) > 0); =20 if (s->have_guest_debug) { - kvm_sstep_flags =3D SSTEP_ENABLE; + as->gdbstub.sstep_flags =3D SSTEP_ENABLE; =20 int guest_debug_flags =3D kvm_check_extension(s, KVM_CAP_SET_GUEST_DEBUG2); =20 if (guest_debug_flags & KVM_GUESTDBG_BLOCKIRQ) { - kvm_sstep_flags |=3D SSTEP_NOIRQ; + as->gdbstub.sstep_flags |=3D SSTEP_NOIRQ; } } #endif @@ -4279,17 +4278,6 @@ static void kvm_accel_instance_init(Object *obj) s->honor_guest_pat =3D ON_OFF_AUTO_OFF; } =20 -/** - * kvm_gdbstub_sstep_flags(): - * - * Returns: SSTEP_* flags that KVM supports for guest debug. The - * support is probed during kvm_init() - */ -static int kvm_gdbstub_sstep_flags(AccelState *as) -{ - return kvm_sstep_flags; -} - static void kvm_accel_class_init(ObjectClass *oc, const void *data) { AccelClass *ac =3D ACCEL_CLASS(oc); @@ -4298,7 +4286,6 @@ static void kvm_accel_class_init(ObjectClass *oc, con= st void *data) ac->rebuild_guest =3D kvm_reset_vmfd; ac->has_memory =3D kvm_accel_has_memory; ac->allowed =3D &kvm_allowed; - ac->gdbstub_supported_sstep_flags =3D kvm_gdbstub_sstep_flags; =20 object_class_property_add(oc, "kernel-irqchip", "on|off|split", NULL, kvm_set_kernel_irqchip, diff --git a/accel/tcg/tcg-all.c b/accel/tcg/tcg-all.c index 8eb4a6b89e8..d30b53cd3b7 100644 --- a/accel/tcg/tcg-all.c +++ b/accel/tcg/tcg-all.c @@ -149,6 +149,17 @@ static int tcg_init_machine(AccelState *as, MachineSta= te *ms) =20 tcg_allowed =3D true; =20 + as->gdbstub.sstep_flags =3D SSTEP_ENABLE; + if (replay_mode =3D=3D REPLAY_MODE_NONE) { + /* + * In replay mode all events will come from the log and can't be + * suppressed otherwise we would break determinism. However as tho= se + * events are tied to the number of executed instructions we won't= see + * them occurring every time we single step. + */ + as->gdbstub.sstep_flags |=3D SSTEP_NOIRQ | SSTEP_NOTIMER; + } + page_init(); tb_htable_init(); tcg_init(s->tb_size * MiB, s->splitwx_enabled, max_threads); @@ -242,21 +253,6 @@ static void tcg_set_one_insn_per_tb(Object *obj, bool = value, Error **errp) qatomic_set(&one_insn_per_tb, value); } =20 -static int tcg_gdbstub_supported_sstep_flags(AccelState *as) -{ - /* - * In replay mode all events will come from the log and can't be - * suppressed otherwise we would break determinism. However as those - * events are tied to the number of executed instructions we won't see - * them occurring every time we single step. - */ - if (replay_mode !=3D REPLAY_MODE_NONE) { - return SSTEP_ENABLE; - } else { - return SSTEP_ENABLE | SSTEP_NOIRQ | SSTEP_NOTIMER; - } -} - static void tcg_accel_class_init(ObjectClass *oc, const void *data) { AccelClass *ac =3D ACCEL_CLASS(oc); @@ -266,7 +262,6 @@ static void tcg_accel_class_init(ObjectClass *oc, const= void *data) ac->cpu_common_unrealize =3D tcg_exec_unrealizefn; ac->get_stats =3D tcg_get_stats; ac->allowed =3D &tcg_allowed; - ac->gdbstub_supported_sstep_flags =3D tcg_gdbstub_supported_sstep_flag= s; =20 object_class_property_add_str(oc, "thread", tcg_get_thread, diff --git a/accel/whpx/whpx-common.c b/accel/whpx/whpx-common.c index e3f93efc61f..247e12db812 100644 --- a/accel/whpx/whpx-common.c +++ b/accel/whpx/whpx-common.c @@ -527,7 +527,6 @@ static void whpx_accel_class_init(ObjectClass *oc, cons= t void *data) ac->init_machine =3D whpx_accel_init; ac->pre_resume_vm =3D whpx_pre_resume_vm; ac->allowed =3D &whpx_allowed; - ac->gdbstub_supported_sstep_flags =3D whpx_arch_gdbstub_sstep_flags; =20 object_class_property_add(oc, "kernel-irqchip", "on|off|split", NULL, whpx_set_kernel_irqchip, diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 31eb0ca6a5d..6533d78b1ca 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -72,7 +72,7 @@ void gdb_init_gdbserver_state(void) * By default try to use no IRQs and no timers while single * stepping so as to make single stepping like a typical ICE HW step. */ - gdbserver_state.accel_config.sstep_flags =3D accel_supported_gdbstub_s= step_flags(); + gdbserver_state.accel_config =3D current_accel()->gdbstub; gdbserver_state.sstep_flags =3D SSTEP_ENABLE | SSTEP_NOIRQ | SSTEP_NOT= IMER; gdbserver_state.sstep_flags &=3D gdbserver_state.accel_config.sstep_fl= ags; } diff --git a/target/arm/whpx/whpx-all.c b/target/arm/whpx/whpx-all.c index 5208d7e1dfe..3079c6293c8 100644 --- a/target/arm/whpx/whpx-all.c +++ b/target/arm/whpx/whpx-all.c @@ -295,11 +295,6 @@ void whpx_translate_cpu_breakpoints( /* Breakpoints aren=E2=80=99t supported on this platform */ } =20 -int whpx_arch_gdbstub_sstep_flags(AccelState *as) -{ - return 0; -} - bool whpx_arch_supports_guest_debug(void)=20 { return false; diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index f6e1636a4e0..467ac6bed45 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -1853,11 +1853,6 @@ void whpx_apply_breakpoints( } } =20 -int whpx_arch_gdbstub_sstep_flags(AccelState *as) -{ - return SSTEP_ENABLE; -} - bool whpx_arch_supports_guest_debug(void)=20 { return true; @@ -3348,6 +3343,8 @@ int whpx_accel_init(AccelState *as, MachineState *ms) whpx_memory_init(); whpx_init_emu(); =20 + as->gdbstub.sstep_flags =3D SSTEP_ENABLE; + return 0; =20 error: --=20 2.53.0 From nobody Sun Jul 26 11:01:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783096818; cv=none; d=zohomail.com; s=zohoarc; b=T6P/W0KGBR7kNyIeK0idntOp8ROkgP43PCBlnbzzm2SNUMycZWiF7Co1dtSLArnDtx0cWL+8mqjvXB1ImIFOUQ0IpXDESnaDaJhyE67FrVURfgw7qvv6vYJ4B5zbBedr1uzshVxdOM742hzviwIo1tnPu5eybOimLhKilsa63b0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783096818; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=VdLq6Zfki+3ghFdFd7ctb3ThvHqHp9sVmMt32nHNdYM=; b=dkQQ1eEhTPg4rlOzRdvOM70PJ7Rrkdx/4dJrwb8TXm+oF94WG746Qsqbo8ngag6meImGfRWGWNQyOYwGQTh/9V6NBMK/HrL2jG1iBjYDV9BodyrW5++S10Qnk4kWatG7XZdjkbGNrN1r/4egXZHaNELiATgFql6hHLV/Of6tMho= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783096818332440.60410860890033; Fri, 3 Jul 2026 09:40:18 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wfgvy-0000mR-Sz; Fri, 03 Jul 2026 12:40:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgvx-0000aw-08 for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:40:09 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgvt-00006z-6Y for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:40:08 -0400 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663GInxE476556 for ; Fri, 3 Jul 2026 16:39:53 GMT Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f60eybx3v-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 16:39:53 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e62e3459fso63894885a.0 for ; Fri, 03 Jul 2026 09:39:52 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47a9de1d8f1sm633056f8f.3.2026.07.03.09.39.50 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 03 Jul 2026 09:39:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VdLq6Zfki+3ghFdFd7ctb3ThvHqHp9sVmMt32nHNdYM=; b=egl5KS/4kQ2BE3Rp 7Rzj6NZMrxZNpMWIQ3sBiwZ+R1RFd4ydu5HZvvAGh+5D/tbS1nEgxS6gnDSy8nkc lcspHYjL6oJs7JQplWuAzgNWUuLaaKR+uTlLStTQMe961GXQLMjMgUEjQiLqGgTK mUWP++Va/3qQ1dma5cEUKn0eeay+y7T67Z9dz/AyJNMGuTQYqIVsYS/gnLvqvpCX RQqQD6ZcVQhbldYo/j3aV0CyDfufPIMJ+KSKNWZIFqr5XCExc+K46neXN2KKUUuY LlPW0/oSxeMGxJ8hRG1fpfWgjl8eQrLXqH7abfR8ZWhznpEwZSIDP1QmG3x3lwxT wAT/CA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783096792; x=1783701592; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VdLq6Zfki+3ghFdFd7ctb3ThvHqHp9sVmMt32nHNdYM=; b=bkq0WCImfSqSNehPKLUniUUWZqrn/PJcCeJe+DDrkd5YUYW+MrTC79bvERtEEnelt6 sIJukNqSdHLDOCHf59D9sPQqyBQHGJciB6aTgHbbyvsjqtjv9SPaqUEWoTtnHRem3pc+ kLIG9SlTRYZHULi5K8OoDQylBM5vQ+EPkcFvn4wKhnwZNLTOpVViLS0nQ8YPDbOh39a+ VERtVdTUd8Wo3ykuh3s5/WoMiJMhG5nSKZUwLzhgcTinmSq9FDYzE9djtHxU782d41G1 9RvYlu2DRI/G4VnftyEszdNKTU7mH9MGRcT1zG6gZT6GVY+y00arcEYo3jN0csfbmB/K SFgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783096792; x=1783701592; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VdLq6Zfki+3ghFdFd7ctb3ThvHqHp9sVmMt32nHNdYM=; b=dF2fC9MiP64k8q0ti+AjYSHbco/2U/J9yQqvkbV46bk2j/jj22c4xxLXMcZmP2GbCa DtaKmPONYCinZeq4T5EhfD0HzOJMeX/biEAkkNuuRzf5nLcjpRjzley0SWA614raYkPB R7kChQKLYNt9N7i4LNh7Cm6zOhSkS/mPpDr+IykjBZ6BN7BbF7AT6B7j1/hYSom3yWSE Ka4YrLDFfWQ5PWAewDp2TNFYhdIepOlBPPrTMYNX7+Zmb8/j0E9mxF5hvdCGL0HrEUFw eF8N/evXe4Jo6P21WEW0ULXDCsz/lHVfJZxUpepzBp7g07NZ0wplgDnS7tfvwZYeyO6H AXUA== X-Gm-Message-State: AOJu0YxlHL14CYLiuen0wzauZlHDl9dwwC/YHz+OAh5lMBPvv1OoPYIs S2K0Fw9rJLCYAoE5EfYhsMf26n4diWUDf69MWW1C2yNiqt2R364M/xSPk4y98cAz3/x7Td1CBzn whTYUxZg84qjqWCIt8rd/R37uXn03Wn7SmZerwtjC3dg56JzOYt+vylkKWWISDbkBgA== X-Gm-Gg: AfdE7cmbXIkBHrsnsMV/JPO9MKqlTERwqjwA2NgIiAK3A/Paula+EN+e2kM009yt5i9 wetYQUxViLG3984R1fQHrd0yFPDWQ8C215sMwDYMCGndZyIj8tnDBtnlhobdZwisM533oHtBsVj jqcKrE7oaWZ0gpoxSeuKeJ6ipDN0cFyYAnYQe0to14+KmDdzEj0F7hR+RKzTeqDMIm+cjwFKU7C IjuOULLfAMUfIzDxlLQ26clL3QJeOdLg6YueAfwY2f0eF4x+4DI4Y8Uf5FSA2Q/sR5O+ldMEuU6 KNNx/YWpDMP4wpy1fnvKBU6wuEqe2pMEPZwKvczbMvkcqVxTxHzaF8KD/Lo/ZcIJQmfw94kYdL7 gy7ib/Dcm5cZkAvKChcTEjhf5gP2hc6x3PMu4eo1RBn618t2JpKGWNqioiXAl1gWN6a2q X-Received: by 2002:a05:620a:44c2:b0:915:9a39:1d68 with SMTP id af79cd13be357-92e9a35b22dmr27878685a.5.1783096792469; Fri, 03 Jul 2026 09:39:52 -0700 (PDT) X-Received: by 2002:a05:620a:44c2:b0:915:9a39:1d68 with SMTP id af79cd13be357-92e9a35b22dmr27876185a.5.1783096792066; Fri, 03 Jul 2026 09:39:52 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , Richard Henderson , qemu-s390x@nongnu.org, Xiaoyao Li , Zhao Liu , alex.bennee@linaro.org, Magnus Kulke , Peter Maydell , qemu-ppc@nongnu.org, Mohamed Mediouni , Paolo Bonzini Subject: [PATCH v2 15/33] gdbstub: Make default replay_mode value explicit in stubs Date: Fri, 3 Jul 2026 18:37:38 +0200 Message-ID: <20260703163757.55500-16-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260703163757.55500-1-philmd@oss.qualcomm.com> References: <20260703163757.55500-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfXxOEArcFnJ2NV 7CZAlvdJL+0BkrkLKCb6DLlBO5q3a58KC5H8FoVNq7I/DPPvxJErwViLmkAsAk5bZG7rJTgSmbf yDTXTa5BDjp8P+SnazU1pq34OdIhl3QoIGQ7Xh1Xg2gXu3LxZalSB6BjL6S0ztiBhXgeMp9rucG 1zTWzdEdk5cnP/XBKB28JhFl2+naggpdfTB8uYB+ng6IQFRo3VTZ6fuUB21A7xx50ALNDgXPWB/ nSXf6EWI844OUZAw/RyKDegfzo8yLrfs6XF1FjvAOMBL7iE35VV6LmQLhyGAtI9gDpheAN1RSs3 H4qF3LDzJRfS3n50jIEby7aaGLlXtmWTOrnxw2hLDSAu0AU+JQyq+CIpS1mxQTG/NG2D34YyN7C DffRGwpvFwMc08jskvDoEC8HlX2UObwNvBWdOiIV9tr2Kt08kz+5Z4/N3r5mRO94/vax008bpEt 8Gv9YwmbdP2+Sa+b3gQ== X-Proofpoint-GUID: pyOntazEjkz1Sq4pOGrVEXkst7CEkx4c X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfXycrfTLpog2b+ CXcBlQwtY/HJc68dlKmtA9YGGjIskeJbQ1BMBurz0LLyUvTVgdX8gHbGVOBIBNAPcBThSwwvlKN jzaJEEzfBe0jC1RDUoITDIpWu3VaTyk= X-Authority-Analysis: v=2.4 cv=SPRykuvH c=1 sm=1 tr=0 ts=6a47e5d9 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=Cu_OB6cER5A0ZMY7a4UA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: pyOntazEjkz1Sq4pOGrVEXkst7CEkx4c X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 spamscore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030164 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783096819357158500 Make explicit @replay_mode is stubbed as REPLAY_MODE_NONE. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- stubs/replay-mode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stubs/replay-mode.c b/stubs/replay-mode.c index 439d97e4a87..5bc8f7d6589 100644 --- a/stubs/replay-mode.c +++ b/stubs/replay-mode.c @@ -1,4 +1,4 @@ #include "qemu/osdep.h" #include "system/replay.h" =20 -ReplayMode replay_mode; +ReplayMode replay_mode =3D REPLAY_MODE_NONE; --=20 2.53.0 From nobody Sun Jul 26 11:01:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783096825; cv=none; d=zohomail.com; s=zohoarc; b=j3PqgD4rVeSBZICNnmPLvATFF9uchfsvsDzW4cqQK4wr393ALYvY21kg5kQEdNxrijcI3v3h2bmdZWV2jXKM2Gw4ahSX+V2tIZgdM07VLqowAj6drwFArMi816PXQtqYZoV8gJsNgqBM2jP45jYWdnb4JRK+1M+l9BI5COcEpBA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783096825; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=2JSb3GKs+UbA4ySm8lGmjxcRTMIXk9HC933K4tfDCDo=; b=O/nTFlz+c6bUKBjqECseV1TWmITxxEbtWQLq5/rIuOEOrhRwmx8zr5eoWrioi1hs/f6XHxMH1JYvRbO2O1Q/fT113Y7XK8xiGykZCSpL76JmcUDbTT/j1MqmtEaRoiqQo5N04rE+Kck/txky4joFBYGksiWAQJuX8emlRsC+Ang= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783096825657310.87332843132185; Fri, 3 Jul 2026 09:40:25 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wfgwC-0001ok-15; Fri, 03 Jul 2026 12:40:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgwA-0001kE-TK for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:40:22 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgw3-0000E4-7d for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:40:22 -0400 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663GIo3s498273 for ; Fri, 3 Jul 2026 16:40:01 GMT Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f65qcjwxu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 16:40:01 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-915c364ae3bso65451585a.0 for ; Fri, 03 Jul 2026 09:40:01 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c637bc21sm233534045e9.7.2026.07.03.09.39.58 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 03 Jul 2026 09:39:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2JSb3GKs+UbA4ySm8lGmjxcRTMIXk9HC933K4tfDCDo=; b=kSbFZubdpU56xiTf VOxb8jVn7+PfIZ8Zd4P4yG+LBv5FbwBVik/jvDQ1gKlKE+S6COcoBEqcuzrlOLjC JOpwZLwNEFkXGyfXq2C5nrgJCAMbTEimpmTOtah4vMROa+N6OZY26uxJM/Yif4a1 zLBndBM1HGdYpsNx9vVgTDHPJ2axiNOjjYTEe8/YNWYaPGYZzOVVrZld63bzKXjC cCXKrjAZg7iw5DsuTJsR2YKEVYwgxQM+GIDuBjvbfAi+n49ZHVk9qJLGoQiiBJv0 cG8ja1/Gm+tOivs5qcl+xckqTRd+g3z2M7Pv+HArjmZuX2KmikLzeh/JkCjPZjqA qyCJTQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783096801; x=1783701601; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2JSb3GKs+UbA4ySm8lGmjxcRTMIXk9HC933K4tfDCDo=; b=YG92/6mix8UcHkOoWtC2CKCyfE0m4Le57qfD/ReYZGagzReQQ5ikKYxqmEc1latvWv P/TBqwJ27/1tEjb1BdDJr3l6u3KXubIjADwKP3yE5DqpJimoUW17MxSHjnvhHqtzeWTy fPX94YkXvZBrY3kgVBlY+aftFrkXgJ5g2WYpzqtx5P6bHckqpRq3W85Buiz7aZVWXR1D HQo2soS2rEjn+cM3/+7E5vwSHh0z7Zlulwtt6bwDlpPvMumn76s5CG7xuCH7wJpLSPQZ +HdaVNkUPOiXDBZrIuu/5TDFTGzHfYxM2h66f0MxJi+KcDt0bv+kaIgclaLPzYtiNPDx F2XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783096801; x=1783701601; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2JSb3GKs+UbA4ySm8lGmjxcRTMIXk9HC933K4tfDCDo=; b=hjePQdzB6Ftt4aoPVua1dlY//+dMSJrf9sOMY2I2SuVbwvbxd8Igq+LL5vtEJbqTlj koPicft+VK6ss3U0F6EdDVtrpxkzZRHiS6lHg1yRW2KUv1eAzOrSVwfBcK+AgiDkMDTs FR4f+P3lvSRuyadsk5fjTP+v6Hju7tkVDZ4dIfY89M0khoOU0wCgJce4otBDelbLrk0J CiA1BR9nkFlgFVLZzFpJr/ZezihRsL3/MRM9RWAFO0kvbbS9D5T3uEOMj71W5oEqHwnU sN+7s44AtJTVSOyp5sloYhKNEp40s4DDdHQe+X5vghoCBG0eOk4zzRfYpifgXZ008ZTN 5ZFg== X-Gm-Message-State: AOJu0YzrgjVBd7H9YIyD5pRN8uPm7tRLUbo1Yk/XzPUQKNMgxW2aPJbI ZwtAfn9cNTDnjNIZSTzQLeC+47W4ndrtG2RHTQ9ufaiCRYDsoauZ25kBrBTWjsM50YhYm0cfAg5 Nm8m+9CSTSaignRbUksnmN7+pli07EQfNM+RnYjRUkqk+Gatew3+/chfKKx6lRGJ2Zw== X-Gm-Gg: AfdE7cln+R4sk/iXyHvcmmoKzOm1s78gFSLikQIjEYITg6c745zaXPDBac22n6rP7GM MK+u3dOHp0kQ0dMGcXIGbyaaa/4hgjFRc8K7d5BWAWvMxV1nsr21e7w4+GFwf1XiAYkeWFW4rG3 LafbdS4LcRGZYAf5HTtkkTUBHc2PYS9oBYBMwovEASIejYFz1b1WPSryAOTIqe+4mxnhzGtzx4L 7eB8fJyc96zIigYo0FKI9ghUHEjHZlMAJoYoVL81wUTZhv4pibCWYrs8pFq/PDh0AQqE0F8O8B7 je7qEL2PZ4dLWZtUgflXNZsad42OEwMvtuAR2c2F9+629oFAkofTvHgM9sAQmRNajMdX2fQ+H5w mjieCnbfu1DrbVfDURbqpdmbzgX8DQqcI/UKqAq88w8Ph8s5WRpe584UWtUNnHqAOeGY3 X-Received: by 2002:a05:620a:2982:b0:92e:4773:5a00 with SMTP id af79cd13be357-92e9a4c57demr26624085a.48.1783096800682; Fri, 03 Jul 2026 09:40:00 -0700 (PDT) X-Received: by 2002:a05:620a:2982:b0:92e:4773:5a00 with SMTP id af79cd13be357-92e9a4c57demr26618185a.48.1783096800096; Fri, 03 Jul 2026 09:40:00 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , Richard Henderson , qemu-s390x@nongnu.org, Xiaoyao Li , Zhao Liu , alex.bennee@linaro.org, Magnus Kulke , Peter Maydell , qemu-ppc@nongnu.org, Mohamed Mediouni , Paolo Bonzini Subject: [PATCH v2 16/33] accel: Hold @can_reverse information in AccelGdbConfig Date: Fri, 3 Jul 2026 18:37:39 +0200 Message-ID: <20260703163757.55500-17-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260703163757.55500-1-philmd@oss.qualcomm.com> References: <20260703163757.55500-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: mYknMUw2WU_3x2nXWEm7jk25nsONxI1i X-Authority-Analysis: v=2.4 cv=Bb7oFLt2 c=1 sm=1 tr=0 ts=6a47e5e1 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=SMEfN5HU43_l-HwGlA0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: mYknMUw2WU_3x2nXWEm7jk25nsONxI1i X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfXwXl3pneQYlx5 XSxTWKrrDM0WBMHLN/bmtX8Srg1ed622LmVIF6GJHUD9ihYTlBISIfTKZBixpi1fnyumMF3e79b LRc5wqFbAslFJ7KemuBSb1dwD6vhp1zrtY2oxaZsDA9yWRK+07+rH1hpUaM3V5kG/xM5uqOw3pa 0Z8gQDkkhDG3Wkx+hgmR02AHY7PHlFzYo1oqlh/xS8N2lT9uqvVOKqvPksELgTvGvLS2MWuOVpJ 6WODdqoN12huhdPvltAWWKSYfbmC4u3+yTVaYwiaTVGduUpn8L63LPZKwyWfaZpCopqqE1HNej8 NG+8imDytOMANuTLdIQlzgBNlpRD/8U9P7Zk10P2eHEkCs6We1B5W4CjC6fBttrJu8four9tyri BjVZxRc3RIgjFftkjQ7tAMXQB9vOSIhJdOapPtorGx4GnxB5IzUcR3023gKmv5YVWXhJL3Lpsii NuPWoJsxKZLe//Iaf0Q== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX/Pa97hjhlLei bfHK78Pr5MOF4POFHOqGBeqEE/9guxQ9UbRpsLFWyL5Ox6f1nX4fsqkXL4Q5DRQMEqgXeVPY6V1 ijpNCSY20mnJRFdZz/CaOAra2KEn3CQ= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 clxscore=1015 impostorscore=0 suspectscore=0 phishscore=0 adultscore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030164 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783096827498158500 Hold @can_reverse in AccelGdbConfig, set it when initializing AccelState in AccelClass::init_machine handlers (only TCG sets it). Remove gdb_can_reverse() as now unused. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- gdbstub/internals.h | 1 - include/qemu/accel.h | 2 ++ accel/tcg/tcg-all.c | 1 + gdbstub/gdbstub.c | 4 ++-- gdbstub/system.c | 5 ----- gdbstub/user.c | 6 ------ 6 files changed, 5 insertions(+), 14 deletions(-) diff --git a/gdbstub/internals.h b/gdbstub/internals.h index 0444dee2246..0b74ea4000f 100644 --- a/gdbstub/internals.h +++ b/gdbstub/internals.h @@ -154,7 +154,6 @@ CPUState *gdb_first_attached_cpu(void); void gdb_append_thread_id(CPUState *cpu, GString *buf); int gdb_get_cpu_index(CPUState *cpu); unsigned int gdb_get_max_cpus(void); /* both */ -bool gdb_can_reverse(void); /* system emulation, stub for user */ int gdb_target_sigtrap(void); /* user */ =20 void gdb_create_default_process(GDBState *s); diff --git a/include/qemu/accel.h b/include/qemu/accel.h index 3b01d55741b..8e0c3dfe088 100644 --- a/include/qemu/accel.h +++ b/include/qemu/accel.h @@ -77,9 +77,11 @@ void accel_cpu_common_unrealize(CPUState *cpu); * struct AccelGdbConfig - gdbstub configuration for an accelerator. * * @sstep_flags: Set SSTEP_* flags that accelerator supports for guest deb= ug. + * @can_reverse: Whether reverse mode is supported. */ typedef struct AccelGdbConfig { unsigned sstep_flags; + bool can_reverse; } AccelGdbConfig; =20 #endif /* QEMU_ACCEL_H */ diff --git a/accel/tcg/tcg-all.c b/accel/tcg/tcg-all.c index d30b53cd3b7..79a8a08c768 100644 --- a/accel/tcg/tcg-all.c +++ b/accel/tcg/tcg-all.c @@ -158,6 +158,7 @@ static int tcg_init_machine(AccelState *as, MachineStat= e *ms) * them occurring every time we single step. */ as->gdbstub.sstep_flags |=3D SSTEP_NOIRQ | SSTEP_NOTIMER; + as->gdbstub.can_reverse =3D true; } =20 page_init(); diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c index 6533d78b1ca..6aa7d8677f4 100644 --- a/gdbstub/gdbstub.c +++ b/gdbstub/gdbstub.c @@ -1376,7 +1376,7 @@ static void handle_step(GArray *params, void *user_ct= x) =20 static void handle_backward(GArray *params, void *user_ctx) { - if (!gdb_can_reverse()) { + if (!gdbserver_state.accel_config.can_reverse) { gdb_put_packet("E22"); return; } @@ -1684,7 +1684,7 @@ static void handle_query_supported(GArray *params, vo= id *user_ctx) g_string_append(gdbserver_state.str_buf, ";qXfer:features:read+"); } =20 - if (gdb_can_reverse()) { + if (gdbserver_state.accel_config.can_reverse) { g_string_append(gdbserver_state.str_buf, ";ReverseStep+;ReverseContinue+"); } diff --git a/gdbstub/system.c b/gdbstub/system.c index 1179c82cb86..2e8c457097b 100644 --- a/gdbstub/system.c +++ b/gdbstub/system.c @@ -479,11 +479,6 @@ unsigned int gdb_get_max_cpus(void) return ms->smp.max_cpus; } =20 -bool gdb_can_reverse(void) -{ - return replay_mode =3D=3D REPLAY_MODE_PLAY; -} - /* * Softmmu specific command helpers */ diff --git a/gdbstub/user.c b/gdbstub/user.c index f7bc4e63dfd..299388b9f71 100644 --- a/gdbstub/user.c +++ b/gdbstub/user.c @@ -786,12 +786,6 @@ unsigned int gdb_get_max_cpus(void) return max_cpus; } =20 -/* replay not supported for user-mode */ -bool gdb_can_reverse(void) -{ - return false; -} - /* * Break/Watch point helpers */ --=20 2.53.0 From nobody Sun Jul 26 11:01:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783096842; cv=none; d=zohomail.com; s=zohoarc; b=Evf6jKOaVcrlqweAfRWF55zPJTnZ/R45XPZUfxuOSiSrQ3mHqSYCV1nCi3sy4gY3KagdhbnYylnLJTJfdosJ3oR2EBl/s7lxf+IN55o5RFmEh1rGfjnpIZrsskArTTsxEdFbCW7pU/12e0Eck1Ovo38ujzt+mrGKrCT0aTj1dc8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783096842; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Vl143n2Efcc1cvNmnaWGElQ+fuvmLhHAw55vZ/sV884=; b=dOZc8a+4IkZIezDCIoi1hpf4ENbbm5JSyiH2i4HyPMaf1L69yeutNGKU5ScD4dwejq0gBdMM8EGw+SfWF76/oeLcjZcfH2eGAxOSzoAihzpZDIWJwbbQyN4nv6HNh70GSUJd6flHlQO2LL36EzvHBXTg9Nm03G0td5xOtm1l/RU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783096842153328.1565016058187; Fri, 3 Jul 2026 09:40:42 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wfgwK-0002KL-Hi; Fri, 03 Jul 2026 12:40:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgwJ-0002H1-54 for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:40:31 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgw8-0000X6-Tt for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:40:30 -0400 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663GIoLj498256 for ; Fri, 3 Jul 2026 16:40:09 GMT Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f65qcjwy8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 16:40:09 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-91ed0e140c5so130906685a.0 for ; Fri, 03 Jul 2026 09:40:08 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa0f21543sm471743f8f.35.2026.07.03.09.40.06 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 03 Jul 2026 09:40:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Vl143n2Efcc1cvNmnaWGElQ+fuvmLhHAw55vZ/sV884=; b=JHT5hdFSsiHZlTKB rFh84QgrunEPNe49b0g/sJ5yo4HTNHvnFijlRUY5qI7i1bF7XhtCqmILb6kiiuWx rKfftaqDcYYWpBnUV2Q/yMaslWF5cooEoZG+YaBs9dvquj9r5kRbGVd9Cod5O7MW pGT7YYTaiQX6Zj8chCFt5E8DWNxM6vWhiYPC5hCmcb9GEqFQ6WuYRGw7IuuTxH4l 87nC7Fa5TBLJ1dqEAWxNP5g9gviqU6/+uFggBf7TlD7g2qGljFJmij9WCCfuBom0 u7djsPhYRHz0slZY9tRrpQ89mUJhWJEaFFPOom1+mDfMskbjex/LMg2B7jVL1Fke kp3B4A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783096808; x=1783701608; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Vl143n2Efcc1cvNmnaWGElQ+fuvmLhHAw55vZ/sV884=; b=a/4idZQyyveRkUA/XOuiFAE5EBK3Qo93UmGffMs0X+fcdOHb4786LhS+/hAbyz9LAe x4DArP94HA9ZHUvN79NiAoRmRWC7wBB9ZXzzxasJOfnO5xeO07jBFks6xL3Guy+EBUgb pw3LYTh4nZ8joMsOjmjlecqBJ0XWwFQdsDcqGOqQXzKW0EAr5ShQZrzCFJ5Y89AnDZaD l042Im7yhEp0KLqBiP7p2pzOaFXkSucGuJH7/WxkfvOHi1ebFUaj1ByiPHENEEgv4Geb 7GQCAQ0TYGn9uXkKlLi7D+8UHxOOr3aTl+2AH0aDFHcn89nulBvVXWXfUQO6IXw7ana2 Fquw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783096808; x=1783701608; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Vl143n2Efcc1cvNmnaWGElQ+fuvmLhHAw55vZ/sV884=; b=Sp1QMkbSD50NngEH+qqUcxU3+fCAcmHXygu9aVoKXskw8HQH+QgCi+JpIY+n3BU6lY JW+xURxeWP0E7VrDnWCnlAcVaaBfid18nNUf645oO1Q43xTOqHzWbfvpIx4oMjOxHAND dw7h4BejQXohIyszbV0TChZKPzRBgQsDlFWVsY5QS/mDqnq5Xei6inzCrMKYmctAcDKP CCbuu37/lrxSIT2QcXkoOqrq4ddvrfkbuqGOhwnt/3zz1OGyTaZhgKBj6EN51NW15JCl dwQxeDeH9G/kqzEFJ5rQ6BZCdwMBICntmOffaqA7MroMen4AiVq6JLdWOAemKvUIXdP7 IXfQ== X-Gm-Message-State: AOJu0YxC3AEHgS5SY3lPRnG0k9paVwBTSiP48FJ1RkSOnAhhv9OMK9Mh iKJncupDjgJLMkGvr50OGfRP3qutmyevYqEuKYuL8jHtAirKaAfGf6Z/2Pe3m65QJOFWD8JIlNQ swa0/SqdpFMC+C3hwJVzi1d9KL+Ax00ofs+xVjM8TY4Eo4Vj3cD+NVKFJw9Bc75ykBA== X-Gm-Gg: AfdE7cm8zGFl4uukANnHY16E8MhUnoRnWiWcfpdF3yOFieVEuN95V1Vo5coSeUriz6s HP17fx3p5QOtWPCGPrJmg7tOWtK5GlEv/1F8sES1Th8kXelVuRCc7e3rayU8VErQnrO1TfFx1mO egtU1ScnrZsPwggJx913b59dWRkw/L5SB/2yFHispc+FiBeCzHciaYz7mhMBbq4zL3W+OZEDBTv q65zlvQNos4/LIr/rK4ee/nLmZDbdnjzWOa6GolllouQu8FqJqGnZPJd20Qkt98na0PByxIl6wn 4wlovWWXH0rN0ieFlKC2Hx1TYLt9H7xzIpUZwV54q0Wpz6rXZPHrM0sMRVNxjK644PbS2syG1Xk CYIdRD+afTcT9vvYEtbcd2bZqjBbS3P6fNqvCt2ufEKErtHZxneHPtDpi2Az8uL64Al/q X-Received: by 2002:a05:620a:4403:b0:921:ea36:2ee1 with SMTP id af79cd13be357-92e9a3ae60bmr27367785a.21.1783096808196; Fri, 03 Jul 2026 09:40:08 -0700 (PDT) X-Received: by 2002:a05:620a:4403:b0:921:ea36:2ee1 with SMTP id af79cd13be357-92e9a3ae60bmr27360285a.21.1783096807539; Fri, 03 Jul 2026 09:40:07 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , Richard Henderson , qemu-s390x@nongnu.org, Xiaoyao Li , Zhao Liu , alex.bennee@linaro.org, Magnus Kulke , Peter Maydell , qemu-ppc@nongnu.org, Mohamed Mediouni , Paolo Bonzini Subject: [PATCH v2 17/33] accel: Remove AccelOpsClass::supports_guest_debug Date: Fri, 3 Jul 2026 18:37:40 +0200 Message-ID: <20260703163757.55500-18-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260703163757.55500-1-philmd@oss.qualcomm.com> References: <20260703163757.55500-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: rJ2yusz__GtEBGORKzNzWB2jdGw2OXqp X-Authority-Analysis: v=2.4 cv=Bb7oFLt2 c=1 sm=1 tr=0 ts=6a47e5e9 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=u5zfA1t3EaNT3PtHZxEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: rJ2yusz__GtEBGORKzNzWB2jdGw2OXqp X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX8OTyXP2G+ayO 2FdmTGkpyE0lYScrMv5pDynP0K84/8QYxh57c+EZb2pQSnXfH6cWl+s7Qg96ORivqNHePGCRRsY mlm9l21zs57vJzMf1ca6haje+BsRUIkxlbopfpWnzKteuWUoQmlbsski0BUk/QA57asTVlzcwo0 dXdMANgUADlSPxopNZGVq8ApmYiqAj2+UQIzeqd/pnI6lCBKaMUjmXcrXJkyYqLU7fKkQFefCuo p/seuyee63ctmYH7iNsDSfcW40s54blsO+T7rvbQm2CMSEM8qmpO3qpqmKAV2SXVH+OME72TnhJ t2wocg1OyefCmnIqaigsu51JauYJCRln6E2D5hUXrj1vh4ySamUu4hKe5aME4EkiQkbNrbqEpN4 EknG/d7e+L9ZcZ3Ws9ozN3Lf+e1HmI+6gNziJBNHTmxxk+1K1YRFVIUTdjV5onKB64WDIV7QAad ABDVSgeiJl8w1OgDwXg== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfXyt4Dn5IJWuln QfTa25JCVys11SkZ5ja91uoSx0TkB5kd3xjCw80jtWNepBd7VGeH2lQ5UgehE5lmvXUxapu9JQy JBrZebZjlQjtiyTvoHEdNTID47DlI5Q= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 clxscore=1015 impostorscore=0 suspectscore=0 phishscore=0 adultscore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030164 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783096843998158500 Now accelerators hold the 'guest debug supported' information in their state, accessible by the common code. No need to call a per-accelerator handler, simply check for the SSTEP_ENABLE in AccelGdbConfig::sstep_flags. Remove all AccelOpsClass::supports_guest_debug implementations, inline gdb_supports_guest_debug() and remove the now unnecessary KVMState::have_guest_debug field. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- docs/system/gdb.rst | 2 +- accel/kvm/kvm-cpus.h | 1 - include/accel/accel-cpu-ops.h | 1 - include/qemu/accel.h | 2 ++ include/system/hvf_int.h | 5 ----- include/system/kvm_int.h | 1 - include/system/whpx-all.h | 3 --- accel/accel-common.c | 5 +++++ accel/hvf/hvf-accel-ops.c | 1 - accel/kvm/kvm-accel-ops.c | 1 - accel/kvm/kvm-all.c | 13 +------------ accel/tcg/tcg-accel-ops.c | 6 ------ accel/whpx/whpx-accel-ops.c | 6 ------ gdbstub/system.c | 13 +------------ target/arm/hvf/hvf.c | 5 ----- target/arm/whpx/whpx-all.c | 5 ----- target/i386/hvf/hvf.c | 5 ----- target/i386/whpx/whpx-all.c | 5 ----- 18 files changed, 10 insertions(+), 70 deletions(-) diff --git a/docs/system/gdb.rst b/docs/system/gdb.rst index d50470b135e..b6d8f8e77da 100644 --- a/docs/system/gdb.rst +++ b/docs/system/gdb.rst @@ -54,7 +54,7 @@ While GDB can always fall back to inserting breakpoints i= nto memory accelerator. For TCG system emulation we advertise an infinite number of hardware assisted breakpoints and watchpoints. For other accelerators it will depend on if support has been added (see -supports_guest_debug and related hooks in AccelOpsClass). +the AccelGdbConfig structure). =20 As TCG cannot track all memory accesses in user-mode there is no support for watchpoints. diff --git a/accel/kvm/kvm-cpus.h b/accel/kvm/kvm-cpus.h index 688511151c8..3185659562d 100644 --- a/accel/kvm/kvm-cpus.h +++ b/accel/kvm/kvm-cpus.h @@ -16,7 +16,6 @@ void kvm_destroy_vcpu(CPUState *cpu); void kvm_cpu_synchronize_post_reset(CPUState *cpu); void kvm_cpu_synchronize_post_init(CPUState *cpu); void kvm_cpu_synchronize_pre_loadvm(CPUState *cpu); -bool kvm_supports_guest_debug(void); int kvm_insert_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len); int kvm_remove_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len); void kvm_remove_all_breakpoints(CPUState *cpu); diff --git a/include/accel/accel-cpu-ops.h b/include/accel/accel-cpu-ops.h index 9c07a903ea0..b23a0606c7e 100644 --- a/include/accel/accel-cpu-ops.h +++ b/include/accel/accel-cpu-ops.h @@ -84,7 +84,6 @@ struct AccelOpsClass { int64_t (*get_elapsed_ticks)(void); =20 /* gdbstub hooks */ - bool (*supports_guest_debug)(void); int (*update_guest_debug)(CPUState *cpu); int (*insert_breakpoint)(CPUState *cpu, int type, vaddr addr, vaddr le= n); int (*remove_breakpoint)(CPUState *cpu, int type, vaddr addr, vaddr le= n); diff --git a/include/qemu/accel.h b/include/qemu/accel.h index 8e0c3dfe088..6f65f1cb89a 100644 --- a/include/qemu/accel.h +++ b/include/qemu/accel.h @@ -84,4 +84,6 @@ typedef struct AccelGdbConfig { bool can_reverse; } AccelGdbConfig; =20 +bool accel_supports_guest_debug(AccelState *accel); + #endif /* QEMU_ACCEL_H */ diff --git a/include/system/hvf_int.h b/include/system/hvf_int.h index 58fb865ebae..d64f4942556 100644 --- a/include/system/hvf_int.h +++ b/include/system/hvf_int.h @@ -104,11 +104,6 @@ void hvf_arch_remove_all_hw_breakpoints(void); */ int hvf_update_guest_debug(CPUState *cpu); =20 -/* - * Return whether the guest supports debugging. - */ -bool hvf_arch_supports_guest_debug(void); - bool hvf_arch_cpu_realize(CPUState *cpu, Error **errp); uint32_t hvf_arch_get_default_ipa_bit_size(void); uint32_t hvf_arch_get_max_ipa_bit_size(void); diff --git a/include/system/kvm_int.h b/include/system/kvm_int.h index 53bb0fcf180..0876aac938d 100644 --- a/include/system/kvm_int.h +++ b/include/system/kvm_int.h @@ -118,7 +118,6 @@ struct KVMState #endif int max_nested_state_len; int kvm_shadow_mem; - bool have_guest_debug; bool kernel_irqchip_allowed; bool kernel_irqchip_required; OnOffAuto kernel_irqchip_split; diff --git a/include/system/whpx-all.h b/include/system/whpx-all.h index 4022571ffff..d018e67e4f7 100644 --- a/include/system/whpx-all.h +++ b/include/system/whpx-all.h @@ -22,7 +22,4 @@ void whpx_translate_cpu_breakpoints( void whpx_arch_destroy_vcpu(CPUState *cpu); void whpx_arch_accel_class_init(ObjectClass *oc); =20 -/* called by whpx-accel-ops */ -bool whpx_arch_supports_guest_debug(void); - #endif diff --git a/accel/accel-common.c b/accel/accel-common.c index f31d68a9b78..00a400243f0 100644 --- a/accel/accel-common.c +++ b/accel/accel-common.c @@ -70,6 +70,11 @@ void accel_init_interfaces(AccelClass *ac) accel_init_cpu_interfaces(ac); } =20 +bool accel_supports_guest_debug(AccelState *accel) +{ + return accel->gdbstub.sstep_flags & SSTEP_ENABLE; +} + void accel_cpu_instance_init(CPUState *cpu) { if (cpu->cc->accel_cpu && cpu->cc->accel_cpu->cpu_instance_init) { diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-ops.c index dd2b45b7cb5..ecc0cd1b558 100644 --- a/accel/hvf/hvf-accel-ops.c +++ b/accel/hvf/hvf-accel-ops.c @@ -369,7 +369,6 @@ static void hvf_accel_ops_class_init(ObjectClass *oc, c= onst void *data) ops->remove_breakpoint =3D hvf_remove_breakpoint; ops->remove_all_breakpoints =3D hvf_remove_all_breakpoints; ops->update_guest_debug =3D hvf_update_guest_debug; - ops->supports_guest_debug =3D hvf_arch_supports_guest_debug; =20 ops->get_vcpu_stats =3D hvf_get_vcpu_stats; }; diff --git a/accel/kvm/kvm-accel-ops.c b/accel/kvm/kvm-accel-ops.c index d7967bc922f..45330327909 100644 --- a/accel/kvm/kvm-accel-ops.c +++ b/accel/kvm/kvm-accel-ops.c @@ -105,7 +105,6 @@ static void kvm_accel_ops_class_init(ObjectClass *oc, c= onst void *data) ops->synchronize_pre_loadvm =3D kvm_cpu_synchronize_pre_loadvm; ops->handle_interrupt =3D generic_handle_interrupt; =20 - ops->supports_guest_debug =3D kvm_supports_guest_debug; #ifdef TARGET_KVM_HAVE_GUEST_DEBUG ops->update_guest_debug =3D kvm_update_guest_debug_ops; ops->insert_breakpoint =3D kvm_insert_breakpoint; diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index ceb0b33abdd..b03488ebac3 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -3036,10 +3036,7 @@ static int kvm_init(AccelState *as, MachineState *ms) (kvm_check_extension(s, KVM_CAP_VM_ATTRIBUTES) > 0); =20 #ifdef TARGET_KVM_HAVE_GUEST_DEBUG - s->have_guest_debug =3D - (kvm_check_extension(s, KVM_CAP_SET_GUEST_DEBUG) > 0); - - if (s->have_guest_debug) { + if (kvm_check_extension(s, KVM_CAP_SET_GUEST_DEBUG) > 0) { as->gdbstub.sstep_flags =3D SSTEP_ENABLE; =20 int guest_debug_flags =3D @@ -3829,14 +3826,6 @@ int kvm_update_guest_debug(CPUState *cpu, unsigned l= ong reinject_trap) return data.err; } =20 -bool kvm_supports_guest_debug(void) -{ - KVMState *s =3D KVM_STATE(as); - - /* probed during kvm_init() */ - return s->have_guest_debug; -} - int kvm_insert_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len) { struct kvm_sw_breakpoint *bp; diff --git a/accel/tcg/tcg-accel-ops.c b/accel/tcg/tcg-accel-ops.c index c179cd4adeb..927af6c1db0 100644 --- a/accel/tcg/tcg-accel-ops.c +++ b/accel/tcg/tcg-accel-ops.c @@ -109,11 +109,6 @@ void tcg_handle_interrupt(CPUState *cpu, int mask) } } =20 -static bool tcg_supports_guest_debug(void) -{ - return true; -} - /* Translate GDB watchpoint type to a flags value for cpu_watchpoint_* */ static inline int xlat_gdb_type(CPUState *cpu, int gdbtype) { @@ -221,7 +216,6 @@ static void tcg_accel_ops_init(AccelClass *ac) } =20 ops->cpu_reset_hold =3D tcg_cpu_reset_hold; - ops->supports_guest_debug =3D tcg_supports_guest_debug; ops->insert_breakpoint =3D tcg_insert_breakpoint; ops->remove_breakpoint =3D tcg_remove_breakpoint; ops->remove_all_breakpoints =3D tcg_remove_all_breakpoints; diff --git a/accel/whpx/whpx-accel-ops.c b/accel/whpx/whpx-accel-ops.c index b8f41544cbe..ca5a119521a 100644 --- a/accel/whpx/whpx-accel-ops.c +++ b/accel/whpx/whpx-accel-ops.c @@ -82,11 +82,6 @@ static bool whpx_vcpu_thread_is_idle(CPUState *cpu) return !whpx_irqchip_in_kernel(); } =20 -static bool whpx_supports_guest_debug(void) -{ - return whpx_arch_supports_guest_debug(); -} - =20 static void whpx_accel_ops_class_init(ObjectClass *oc, const void *data) { @@ -96,7 +91,6 @@ static void whpx_accel_ops_class_init(ObjectClass *oc, co= nst void *data) ops->kick_vcpu_thread =3D whpx_kick_vcpu_thread; ops->cpu_thread_is_idle =3D whpx_vcpu_thread_is_idle; ops->handle_interrupt =3D generic_handle_interrupt; - ops->supports_guest_debug =3D whpx_supports_guest_debug; =20 ops->synchronize_post_reset =3D whpx_cpu_synchronize_post_reset; ops->synchronize_post_init =3D whpx_cpu_synchronize_post_init; diff --git a/gdbstub/system.c b/gdbstub/system.c index 2e8c457097b..bf7aa1ac234 100644 --- a/gdbstub/system.c +++ b/gdbstub/system.c @@ -331,8 +331,6 @@ static void create_processes(GDBState *s) gdb_create_default_process(s); } =20 -static bool gdb_supports_guest_debug(void); - bool gdbserver_start(const char *device, Error **errp) { Chardev *chr =3D NULL; @@ -345,7 +343,7 @@ bool gdbserver_start(const char *device, Error **errp) return false; } =20 - if (!gdb_supports_guest_debug()) { + if (!accel_supports_guest_debug(current_accel())) { error_setg(errp, "gdbstub: current accelerator doesn't " "support guest debugging"); return false; @@ -624,15 +622,6 @@ int gdb_signal_to_target(int sig) * Break/Watch point helpers */ =20 -static bool gdb_supports_guest_debug(void) -{ - const AccelOpsClass *ops =3D cpus_get_accel(); - if (ops->supports_guest_debug) { - return ops->supports_guest_debug(); - } - return false; -} - int gdb_breakpoint_insert(CPUState *cs, int type, vaddr addr, vaddr len) { const AccelOpsClass *ops =3D cpus_get_accel(); diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index 8b902c68829..e16457c3cfb 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -2900,8 +2900,3 @@ void hvf_arch_update_guest_debug(CPUState *cpu) =20 hvf_arch_set_traps(cpu); } - -bool hvf_arch_supports_guest_debug(void) -{ - return true; -} diff --git a/target/arm/whpx/whpx-all.c b/target/arm/whpx/whpx-all.c index 3079c6293c8..00a5de8cdc1 100644 --- a/target/arm/whpx/whpx-all.c +++ b/target/arm/whpx/whpx-all.c @@ -295,11 +295,6 @@ void whpx_translate_cpu_breakpoints( /* Breakpoints aren=E2=80=99t supported on this platform */ } =20 -bool whpx_arch_supports_guest_debug(void)=20 -{ - return false; -} - void whpx_arch_destroy_vcpu(CPUState *cpu) { /* currently empty on Arm */ diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c index 2d1a943b96c..19ad64a1d93 100644 --- a/target/i386/hvf/hvf.c +++ b/target/i386/hvf/hvf.c @@ -1066,8 +1066,3 @@ void hvf_arch_remove_all_hw_breakpoints(void) void hvf_arch_update_guest_debug(CPUState *cpu) { } - -bool hvf_arch_supports_guest_debug(void) -{ - return false; -} diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index 467ac6bed45..11b5d1fc607 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -1853,11 +1853,6 @@ void whpx_apply_breakpoints( } } =20 -bool whpx_arch_supports_guest_debug(void)=20 -{ - return true; -} - void whpx_arch_destroy_vcpu(CPUState *cpu) { X86CPU *x86cpu =3D X86_CPU(cpu); --=20 2.53.0 From nobody Sun Jul 26 11:01:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783096911; cv=none; d=zohomail.com; s=zohoarc; b=NwZEYsT6YHRIUeIQstZqaHoJY8J8NXPUxyenfR50fwJr6G9YyVoUU/A1Q0v4joHrq5t94WduP/hKEnMFkiHYqr1cYAtG7qKJFpHpizds7gLbyOkQWH3AotQg9kjAdgTlM3bDVETCwMog/HYXk0R33D3ADibfn4sVPi3WHFA6sIg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783096911; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=eygAFTCQW0B87uY1lVPXWDPzg3gZxNFs2eCC7PkFP/o=; b=WkKdM8ulaTl0b8OwcJ2Lv9Xoo/pae9G927CStFA2OUir2BK3uTLk7EJ2upjLseca51G/RmqZ1LJtr5jUVUZ8OGuNH+4uwn3rqzSKyH+ndBVUvBpXklpu2Uf/jI7ubSs3roEPCK/tXAyOEBFZ8mKPJSmuhjc2+2erfzTy4ccKErc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783096911948940.2228167789615; Fri, 3 Jul 2026 09:41:51 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wfgwT-0003Db-6Q; Fri, 03 Jul 2026 12:40:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgwR-00032l-0f for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:40:39 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgwF-0000en-Cl for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:40:38 -0400 Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663GIoun348246 for ; Fri, 3 Jul 2026 16:40:16 GMT Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f648n38dj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 16:40:16 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-915d3261c5cso70220585a.3 for ; Fri, 03 Jul 2026 09:40:16 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47a9de1e6ccsm598453f8f.5.2026.07.03.09.40.13 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 03 Jul 2026 09:40:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= eygAFTCQW0B87uY1lVPXWDPzg3gZxNFs2eCC7PkFP/o=; b=JxC7fkAgRgeItd1C FPqRLJWdzTFTqaludgl7+U7D03Zb6tg7r3jbHk73WZYBNzulHijjliofwf5V+Ei/ 7oo7MRCBc7wfhkjzoAg+1LTsPGpGtk6nuok7HxK088djOkM+baMErG1daXYdG2fR NMBrwNJN2AWOwH3nkmns/GjjxYKwuBbUD9CbmwoNxq8a9ydF6x3Ie8QdWdpRCERe N5i3+mJJN6fvDY/iVaniBvG1p59ZGGz2gVqAfXMYrQCi2dPOsgJoFrSBkm5EME2V DWki9QMg+Tv5Wt35eVTR0pis2qPg46HBIDS3mcP4Dnji00MQ1+6t9dagLCR3BrjF IFL7/w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783096815; x=1783701615; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=eygAFTCQW0B87uY1lVPXWDPzg3gZxNFs2eCC7PkFP/o=; b=cId3NbDq3uZVr4YD/zSau+MIwa6R/I+QAyc8ME7Znl2hM/QjgRBIEBpirsPd05m8UW e5Nj/BRafqnZHDKiMjnsULVr9Kbn8QW0WoTmO79WlJCkMLohhyUI0CSeo+MSyNXJz4lx Ea4WOIJkZfH2bxyWK0qbZnUsRjjBGKVMot+U02WIhXw3ngwlXnyE8SiAitUk/ujXMe0S xRUpEEtWCj0SVtSEXbW3I7xjTwkN2TZOnIADjPg4mXbywslxWKeW2aYuJGhbjAm4IXu9 AA/M+Hg0uLAImeOEhHJ3IKtwT07PAAJK834PHxcW/wUDfsikVKX5udgmLdLcUwDsIpDk qDaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783096815; x=1783701615; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=eygAFTCQW0B87uY1lVPXWDPzg3gZxNFs2eCC7PkFP/o=; b=Qm/uUG9MyyZhfhGrP3qBQ7/wsHzF7v6VU6ABUesn9mkWKbscY4qPLZemFZBEQa1Sn/ qsEWrtkNekZFcybHdeS06BHA2znH8wqmFqqw3uEMzqraa/4bM4a+e2QLaeph2ukcj6Oq uDr49JSbZx4xjVlaUSOdR8ZUHIjnHnHnwaqyTGzbvsjh3vNBOIDzX0dsSLQPFKGKf4nF qjPF1smpLTIcu3jHQNGN/gsrfmlOFXafzRSv/QJDoadN7NHJJdvnjNXP/QoGc2H713iY l6UATdRBm1nUO07Bfzk0EPereC3nkdm1zhH3GtxH3MGSHpHrV5M8RT2fIsaKlwmOjley O3vA== X-Gm-Message-State: AOJu0YwlFhZJScMjMz/YHgiRneehCJSIrNdhOOb80IUtI1eTY076ts+5 0IObIBiEDz8nRYCYvRW2jx4g/SQdUxyqZk9uPyXH0LhPX7LhymIFgkyIcwdIdDAb8i+58X9RDzA Ddxm3f4cCqCZYc/Ah0aReD7QnT9rNm7c5hDyFM+6avoiW4Rr/ZFm6Vwe4CqIMQEGW+g== X-Gm-Gg: AfdE7cmNsF3AVnLsK83+7J5m92HrQt0YAhCzF05ENKVwdAFlG0ZT29cl03hV9ynKU7a ynYEXYrbS5o/5o7WUr588RVlgcCQons+IO6RKU+08jWj8yGSQ1NI7mDMtDof3WuAfF2TiV/KfLJ r9pBgujcWavBYg7hGuQhAR+GDnw0By9lwmVagksnOfZD7I63aMY1jF5wlVm0K+R7kFLoCYkYi5Z gWgs993D1T8RXPoItax7peZw5R4jjVxxyqeWzYomQs2Omm8yYdX5EmMqvOvauyCAVbw4JqN9bwB pzL8jNUkPJKuBm6E4euzfwz3293KZ+2Im4OHIOM8QyXXBIMH/HdRATtZKXAu5GaW4cM6zuOKpx7 PFT+SVMEUQEumQjq4lWBZO48nKmyOurBBPE7Y2wLdgx1fkAHxPXumEJGY1hH3r07OcTSa X-Received: by 2002:a05:620a:1a18:b0:915:efa6:d70b with SMTP id af79cd13be357-92e9a4a12dbmr26042185a.43.1783096815481; Fri, 03 Jul 2026 09:40:15 -0700 (PDT) X-Received: by 2002:a05:620a:1a18:b0:915:efa6:d70b with SMTP id af79cd13be357-92e9a4a12dbmr26035985a.43.1783096814817; Fri, 03 Jul 2026 09:40:14 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , Richard Henderson , qemu-s390x@nongnu.org, Xiaoyao Li , Zhao Liu , alex.bennee@linaro.org, Magnus Kulke , Peter Maydell , qemu-ppc@nongnu.org, Mohamed Mediouni , Paolo Bonzini Subject: [PATCH v2 18/33] cpu: Move cpu_breakpoint_test out of line Date: Fri, 3 Jul 2026 18:37:41 +0200 Message-ID: <20260703163757.55500-19-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260703163757.55500-1-philmd@oss.qualcomm.com> References: <20260703163757.55500-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfXzMRdFMTqTZVC pUldFrqRspnLHqPhoggj3GfXUIgbfPHyZs+NLQYIW2cfqBTfoRqUkNNb12ZgkEfstvC0qEGIoTu elHgF/hlUvB9mTN6iB3WkT0Cxxgs+Pg= X-Proofpoint-ORIG-GUID: uAZKdOeEwAoQIgi17kugA0B8kVUDKUut X-Authority-Analysis: v=2.4 cv=O4wJeh9W c=1 sm=1 tr=0 ts=6a47e5f0 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=f0gnTpezwqI1Ju9rGxMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: uAZKdOeEwAoQIgi17kugA0B8kVUDKUut X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX4eoY/tCuDK4Y yGMZ0N2S7tgQA7cUetwPJL19hITKFedCi5CVy2edDg3ZG5QDM6kamCXGLxgaMdKHX/Yy7Ok+URp 1rygSWYL7rZmgCxczffa4o/q5WvadYd32UeTWquCfF4w/0wsBETqC88zAu6ifzF15wHYphTxi1W S4E5qRpPsLn8jTKJj/30A4hUxsJrjMb0e4xzQulXHV8Z2wn1vk9d8wJDDu2UZbupgkx1Xf6uTID Xixrhoa3/obD4qm1N6KFNDi2noI8RvZTWjuvJk2T/DIN/UB3g8Hhcy9R19ptQqXjN3nIr2VZBSn 0hA8kcmDxoyX9Ub+z1IELff5a9dgj0Q72VQEDWdsSg06rxDvd1pDAyCSkhP6jjW2Th12Cbovzkb hH8Jx/wjJvyUeSJMNCugHlE/QMX9PLukmZCMlkWmpBQQeGjrg3HK2o/nhSMJxiFSyhEpuZQzdUl o4P0wRYX6sF5NWwcdMQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 phishscore=0 suspectscore=0 malwarescore=0 spamscore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030164 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783096913933158501 From: Richard Henderson Move the function to cpu-common.c, with the other breakpoint functions. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/core/cpu.h | 16 +--------------- cpu-common.c | 15 +++++++++++++++ 2 files changed, 16 insertions(+), 15 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 60a23d6f38b..31753f331fb 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -1157,21 +1157,7 @@ int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, i= nt flags, int cpu_breakpoint_remove(CPUState *cpu, vaddr pc, int flags); void cpu_breakpoint_remove_by_ref(CPUState *cpu, CPUBreakpoint *breakpoint= ); void cpu_breakpoint_remove_all(CPUState *cpu, int mask); - -/* Return true if PC matches an installed breakpoint. */ -static inline bool cpu_breakpoint_test(CPUState *cpu, vaddr pc, int mask) -{ - CPUBreakpoint *bp; - - if (unlikely(!QTAILQ_EMPTY(&cpu->breakpoints))) { - QTAILQ_FOREACH(bp, &cpu->breakpoints, entry) { - if (bp->pc =3D=3D pc && (bp->flags & mask)) { - return true; - } - } - } - return false; -} +bool cpu_breakpoint_test(CPUState *cpu, vaddr pc, int mask); =20 /** * cpu_get_address_space: diff --git a/cpu-common.c b/cpu-common.c index 988d057d844..adb76b3a786 100644 --- a/cpu-common.c +++ b/cpu-common.c @@ -388,6 +388,21 @@ void process_queued_cpu_work(CPUState *cpu) qemu_cond_broadcast(&qemu_work_cond); } =20 +/* Return true if PC matches an installed breakpoint. */ +bool cpu_breakpoint_test(CPUState *cpu, vaddr pc, int mask) +{ + CPUBreakpoint *bp; + + if (unlikely(!QTAILQ_EMPTY(&cpu->breakpoints))) { + QTAILQ_FOREACH(bp, &cpu->breakpoints, entry) { + if (bp->pc =3D=3D pc && (bp->flags & mask)) { + return true; + } + } + } + return false; +} + /* Add a breakpoint. */ int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, int flags, CPUBreakpoint **breakpoint) --=20 2.53.0 From nobody Sun Jul 26 11:01:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783096860; cv=none; d=zohomail.com; s=zohoarc; b=by/nNHiJXYgklFuFSJzXDSegus71CQimdYk8HS4FwBdYCi72yQwbBqRKK9BlBi8HQT0DEcahnjJ0ZBqYbWtY1NhgwsaaTGPi38jRXLv8m5cctweLKIEyU7g10WfrUauoUH6MuFrDvcdSojt/R+/UZtJbsvWkJjq496ubHXq5GN4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783096860; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=7tIMKNTooY0mWH2w8clXt9i3UzLCWRfh1sTC8E6MetQ=; b=Ql6/8Mi5jm4GYJ3KlcPae3gi4648znb4UiTSsV8kJga7ZESTtlqFkhKhXc1ZNSPcc0PClZ/qQeDpxxzbWxGq6JMEQlps860YrGLJ/Ktxvn7SH2jb9JKouMNItteXhGem1bhyeukKq+pyP+VIH2MXxarlegzxuuqIT1o9+batlLY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783096860569251.9392556248248; Fri, 3 Jul 2026 09:41:00 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wfgwd-0003mp-1C; Fri, 03 Jul 2026 12:40:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgwa-0003je-VV for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:40:48 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgwM-0000mc-Pd for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:40:48 -0400 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663GIoou498252 for ; Fri, 3 Jul 2026 16:40:23 GMT Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f65qcjwyu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 16:40:23 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e52306621so54366285a.1 for ; Fri, 03 Jul 2026 09:40:23 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493cce1947bsm63472415e9.14.2026.07.03.09.40.20 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 03 Jul 2026 09:40:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7tIMKNTooY0mWH2w8clXt9i3UzLCWRfh1sTC8E6MetQ=; b=EQsW0JlPoRwqo44h 0hoOOlBSE9IBb589iXWPZA9oNEtASk0iM7fYmIMlH/w9xSe3Hw5ib6jLExVFfGnz OVDPBnLNIpQWhoa/CBZTKQgZiME1kRq8RJcYAKjb4KuxP6ctaR63Y0O3Cd02Ux0j +mKdIL6ZLm+WhbuIqOh58UwiJTPlQnGMFqjx/9R1SUYyAd0GVI23bnfZpGiD8Qro 3d6xwuMASEjq77d/prxrSjCZSkteveGwYsWRY2V+qN9qMnRGsqztEWZGEtd1izT7 4trzBMwyDTqtk+0P5uIytL562/x0dJ8nfMuLzBP0t+plK1rgTEihaGVXyR0yJlCl P6Nrsw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783096823; x=1783701623; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7tIMKNTooY0mWH2w8clXt9i3UzLCWRfh1sTC8E6MetQ=; b=cQQWnH7cLlgfDQwptN13BF0kjGHiWTJdYasFvPd0EMRfrpwKZJnrGhhnK8BrP63m2Q znMVcJvm8YizofPCsgcOFAoyQ2ARxObTPwpJKTaGSTpTLNNlOQ5gUXLxgjmbIBLK9s9u UJTSxN1Jyi3X2U6cN2KSrMImyabwpIJrnqjI8IqHdnHPrNJelG3nL7B+YM/pV4yhfVWh Jj7f5PiR1Jqu2+8DhX+SieS94Vc2ilHh2rTC+GYKybRnIXbQGMViT18xVVe/XuKW6+lD HRyTWoiUtzOlRnPj2dovLibdTuZ0FbzYFJSUlmuwGygCdC8C2Cu+BnwlVMSopDqSaChG /RCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783096823; x=1783701623; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7tIMKNTooY0mWH2w8clXt9i3UzLCWRfh1sTC8E6MetQ=; b=AwiAsc7WDlHN5WgnOatB5un5wC5krnjeXZeTQB3wtJpNpL6NiNR0eLBP2dexyIlD/a TBGyt6QCLcG1OdADWWEBYEhY3YpEZzfgNfJE9tVLpEa5dhByuttAmnVoF4qCPwBSImvb fmy662h7t64IBFqKPcfELlphMsTh0TGFWNFsTRnKOqLZqLwmeY7UiG70U6GMiGy0V7jE Hd2cdcoMNK05t2XU6HdtpmXTuy+hih2RCyA3gmoPuu4lAgmEAtaBmvHaTiYmxnk++T0h 6U0jxC26MYKn01yDWqmaKy0atO47il06uy5cQo0FIHDq1azPUoZ06s7d17dXylHUqfwp RRyA== X-Gm-Message-State: AOJu0YwaaZUdaaB8ptd+LDbUcDPaM3vVqop/S9DGXOPC17xDouxQX1FQ I8Zy4YtHN32pyMJD3P5dOw7iZhoSOkphCiBv7RWD2L0j6S89YQpxUeu61YWxg65yCLDhKPOvC6w yjZ3xOuOxZxfvBfbV6QVPBWw1CxVY+6xTxii1KnnOpwH5EQUDy9jCXjgFij+/YH2d7Q== X-Gm-Gg: AfdE7cn/+H39ygznfBIY5VhzNdVr6Xj7uea8V6RYTh4bW7ForJG70ZvuL4f00MhqlTx C2aA49WpDufkkOG+d4+ySSRv84qCdcu6ZT0K7TgKIxDZttIYgZPVJm8Wa1BpcIkGhuUYioYaXcn JbkvrDAKPlWgBXr49uCxKNGiO/PI35Yin/o7kEP8rzGNXeaNPyIs105068j8tbL3akjQuOKlLrR eiuhlzzNUYljWvjkxWmPH0okUIUFPf6nddkm8fKmJo//FqvGcj+LOWnC4y4C97iyDEWFYV7fKno W0st6FIxJJbaVzGNYKCowIU8jDuLWyY5zXfRfRBmli6LvXoh9uZm+sqD/bdRXRtoGayEnbyZOyO 1j9aGwQluTtM53dEX6ofOoHjQBNtw2h5E+1RGDqc2NSaZyo2ILsihV3foj4f8uzHFRYqC X-Received: by 2002:a05:620a:28c8:b0:92e:8734:b833 with SMTP id af79cd13be357-92e9a4e735emr24593885a.59.1783096822796; Fri, 03 Jul 2026 09:40:22 -0700 (PDT) X-Received: by 2002:a05:620a:28c8:b0:92e:8734:b833 with SMTP id af79cd13be357-92e9a4e735emr24588085a.59.1783096822260; Fri, 03 Jul 2026 09:40:22 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , Richard Henderson , qemu-s390x@nongnu.org, Xiaoyao Li , Zhao Liu , alex.bennee@linaro.org, Magnus Kulke , Peter Maydell , qemu-ppc@nongnu.org, Mohamed Mediouni , Paolo Bonzini Subject: [PATCH v2 19/33] cpu: Move BREAKPOINT definitions to 'exec/breakpoint.h' Date: Fri, 3 Jul 2026 18:37:42 +0200 Message-ID: <20260703163757.55500-20-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260703163757.55500-1-philmd@oss.qualcomm.com> References: <20260703163757.55500-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: lKeT7ajh3bWCnx1w9FAxEWtSnJft5KV7 X-Authority-Analysis: v=2.4 cv=Bb7oFLt2 c=1 sm=1 tr=0 ts=6a47e5f7 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=yZPQLu4l72ctXTxYlJYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: lKeT7ajh3bWCnx1w9FAxEWtSnJft5KV7 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX7pY8Ui6cVUmG XMCgM0bT62Khf7mkK9RS6KVebi18tRn7MaRNqFLEnPE9NT8tXgyGt+1sKcoRxSAvGUxrDmpBZ3i YIk8IHBW+bMhWPrqtxGZyq9P80dy4Gn6V1Z3JAQJAPkLs0CXKBSE0piIMtZ8w1ywMLEm2Y4vXvR f94vABwqWyC1zi2ET0y4ClukepAaXRdMVZQ+z0LF3o/qdPrWUCsQpHkLQoSE/tH2zGSSUT+m+Yg k7rQExJp/8ZwY+WlsYNDKdpZIemY1HO+J04f8TaA7iml8AGZ7zjPZ4t50KrEDk/Gu/bvc5UL7Zu JvCBj2PzouoSIZwCbs3VOk/P437HY49xLhjHJ3vp8PCPC6xRVycp4ifu2LtySHW5kagIAi7BXfk 08zLbHk3QzDl2pN2cwlwRFc+UsGVTGa+mqdbfJCf8QNmJ4+HTrNQsA/vqyaRp9UiXUocOrUa/xv 5C5iCqncxgKugI6vxAg== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfXzrORDPjXDyxA u8+qEChtlw9IK4ksMr6k0YUfYZEPlOaVQIzfG0YKVNYTm8sUb98NmhubnmOCd3zuNdASgYJBLNv HNi3qRbj+wz13u2Y4c+/RDcs5PJ1FI0= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 clxscore=1015 impostorscore=0 suspectscore=0 phishscore=0 adultscore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030164 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783096861631158500 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- include/exec/breakpoint.h | 14 ++++++++++++++ include/hw/core/cpu.h | 14 -------------- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/include/exec/breakpoint.h b/include/exec/breakpoint.h index 95f0482e6d0..cc6fedd09fe 100644 --- a/include/exec/breakpoint.h +++ b/include/exec/breakpoint.h @@ -12,6 +12,20 @@ #include "exec/vaddr.h" #include "exec/memattrs.h" =20 +/* Breakpoint/watchpoint flags */ +#define BP_MEM_READ 0x01 +#define BP_MEM_WRITE 0x02 +#define BP_MEM_ACCESS (BP_MEM_READ | BP_MEM_WRITE) +#define BP_STOP_BEFORE_ACCESS 0x04 +/* 0x08 currently unused */ +#define BP_GDB 0x10 +#define BP_CPU 0x20 +#define BP_ANY (BP_GDB | BP_CPU) +#define BP_HIT_SHIFT 6 +#define BP_WATCHPOINT_HIT_READ (BP_MEM_READ << BP_HIT_SHIFT) +#define BP_WATCHPOINT_HIT_WRITE (BP_MEM_WRITE << BP_HIT_SHIFT) +#define BP_WATCHPOINT_HIT (BP_MEM_ACCESS << BP_HIT_SHIFT) + typedef struct CPUBreakpoint { vaddr pc; int flags; /* BP_* */ diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 31753f331fb..e5b68bced3d 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -1138,20 +1138,6 @@ void qemu_init_vcpu(CPUState *cpu); */ void cpu_single_step(CPUState *cpu, int enabled); =20 -/* Breakpoint/watchpoint flags */ -#define BP_MEM_READ 0x01 -#define BP_MEM_WRITE 0x02 -#define BP_MEM_ACCESS (BP_MEM_READ | BP_MEM_WRITE) -#define BP_STOP_BEFORE_ACCESS 0x04 -/* 0x08 currently unused */ -#define BP_GDB 0x10 -#define BP_CPU 0x20 -#define BP_ANY (BP_GDB | BP_CPU) -#define BP_HIT_SHIFT 6 -#define BP_WATCHPOINT_HIT_READ (BP_MEM_READ << BP_HIT_SHIFT) -#define BP_WATCHPOINT_HIT_WRITE (BP_MEM_WRITE << BP_HIT_SHIFT) -#define BP_WATCHPOINT_HIT (BP_MEM_ACCESS << BP_HIT_SHIFT) - int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, int flags, CPUBreakpoint **breakpoint); int cpu_breakpoint_remove(CPUState *cpu, vaddr pc, int flags); --=20 2.53.0 From nobody Sun Jul 26 11:01:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783096854; cv=none; d=zohomail.com; s=zohoarc; b=WJxB+7CPW71ZDWEbkrV9yuS/agIBP4JEMAwWisAqkGm6vyxvya2lNJN6f59HlMXnZoQovsy9lEXtJ29aD8x+OOeqoOKU5R9UfKNLMLrkRcV55sTqKbjFg9G/gmDOrucaup+fdcuk53Cd6jThAMKElh2+4ExMoXxj0lXeOd6hB8A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783096854; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=N1PBqMH+hLMejvI1ptL3ZXYqZI8VHjW54Lgdz3rihtM=; b=a9HYKWOjQitXKY+IHt0OkG7d81uPuZSD080iyo1Z7QJNjyh895rKo/mYoB4V/Sat+qZy+5aSdSUHoYi68dcXeoO9xSaiJ0Vu0fB5frkfindNbYh2Jz+K4dY49+wkK9qyu1Ej2ViGGZWiLEt6ZoT2OLLOGbR/1N8AYdXFIbgVAJ4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17830968548161019.8174419746139; Fri, 3 Jul 2026 09:40:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wfgwb-0003kJ-IJ; Fri, 03 Jul 2026 12:40:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgwZ-0003gJ-ST for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:40:47 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgwL-0000tF-A7 for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:40:47 -0400 Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663GIkLA511251 for ; Fri, 3 Jul 2026 16:40:31 GMT Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6a849k8n-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 16:40:31 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-8eac2620cb0so9554406d6.3 for ; Fri, 03 Jul 2026 09:40:31 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493bef23feasm177494755e9.2.2026.07.03.09.40.28 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 03 Jul 2026 09:40:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= N1PBqMH+hLMejvI1ptL3ZXYqZI8VHjW54Lgdz3rihtM=; b=QoFiyv9KqGwJdmuf BjzXi5Z7wBmp8UcqrrJvzplUKi1nJcOTSkWyomNOLFc5g0vn0E/A7llcJKNtbH7R xETGFkOF59a4r7dxoSLFMXj48d+CZlB/bbrr1ijl/OVtV+7uohGuWMWJKLU1CxTw d5o6gxe1hOrKosnER/QkwxhTLt/cbcUTXnmJbl2ySQCarNxPoAgMrEm5xR7TdZUD e9CRYNX1W5dWC0P0MYHXB+tyANIEjif8BryfUnnbNj0LHELTXH13dESWkhCaS/Bb T+BzWnlOIHiVWHthimNTaH0yu57HFqh9ARoD8AKx4CbbYc6+prk/cOMMe3jHdFIm 3O7WEg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783096831; x=1783701631; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=N1PBqMH+hLMejvI1ptL3ZXYqZI8VHjW54Lgdz3rihtM=; b=kueoiU78+ahrfFgexWQf4+b8OdzwGgojMQA1XxbKlwfx+h/Mo1zg5xpGCaZHiQpOBd xS7BC2ev9uL94D9QE/cfiks1PQjtpqtka19foBZC93aQREW34OKM9ST0SIrPBvyg+n6s NOPCim2xTex7JKWscLde64nZU60sMucql79O2k6G5jY2huvXdhloHYXQ4zkXBWB+gkcq /VhyDnKIZcM4SzJzk44b3KmC4NwcoosWxAZas2HZ3UUzlvHyOoUDMRug2bE0RbfEM7FH 8ytYkkl3h5Y8RHInhkC7hZYvSC6XgQIrM4tZFjBIQC25yTLjeuUwyfIGYvvGUfxQzjnJ Q1mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783096831; x=1783701631; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=N1PBqMH+hLMejvI1ptL3ZXYqZI8VHjW54Lgdz3rihtM=; b=hGcl8E8katST6aWREAsqEnAoIMtbGEFRpGf+QetT8WV6SuAq7KxD+5SNhyH3urBldo Rbd1337us1zDq7A1Xuw+68sm7JZ7l7QHxgohmvZZVbAUHR0JlQbPGNp2mSttC9NOaEZO hzZlbn9OnNIoIQel3wXaMVOabt4Fl71sp+JovKcrpkEFz0yU6VK9rTv+a+2xwG84Wtgu 9eJFE4FVOAYI5ZCHgK6zNKCMObYW+VwMBwr+RKE+S7RIA2D4ruhQew3UoqBEDBPaALUE h7lAqWhlqTc42LTiGTnh0udQiE0YFWkTS9tVnYELPHsY1Ueyc3rkOb2dX3szhB0l62+n gp6g== X-Gm-Message-State: AOJu0YwcDNdzMgcp3c/p1VbY4mEJAQJL485G9MDsaueiAbS1yw0KfFmZ gPjANserPKhfMxLd0BGIC+19yt4aYKJ/GKz28qoQMpM3SzY6b7Te3nXX3gZktDfvgs6Wax5RH0+ CPqUTJ2Z2W7mYnXKNsp3HS3X75TW6sK6LIgU4D7ECrg6vFfxHhwBS6TVvnR0TFsrFTg== X-Gm-Gg: AfdE7cm77rBv6RgR4lxqQZqHk93aT7vM4jrq0Nbr8LNdTdhtdSpNmpb2ZUWoC6xIiaQ 95h/aZ9cH/6rIZ3xkn1h7ryOh4a8Ls2O76VEfC7AkyXW/F34Oe5MH14ZvtuULPSFtp6gyXwoQVr Xf8KJ9TGW5B0ABeMF+Zd1UN8kJDK3yqbYX+J5O+f/uowP9zH48cD4lr2A/B+UApVlH+NDSsz2mF 3QGChiCcHDJzRPzKPl5JjNrSNzuKbKLE12uwm3LCZSRbKmiZkbNGu+M/iz+/WZ4Ys46zSqIU/tu 7+rwhdtf7zJoXycZftusrgIyp6SHS/cQ+F6H7I+99AMt+PUlN0TFu4Yt+6BJqDln24zmA3AIQcl rRMNFe0rpk/UuPH2H/hz8uxY4yS5ZpDggjYkaGwYYsBy8qXJ9q/fsZ+fQRkK4C1KjNInk X-Received: by 2002:a05:620a:4441:b0:92e:779a:fec6 with SMTP id af79cd13be357-92e9a4d1e4bmr25083085a.52.1783096830385; Fri, 03 Jul 2026 09:40:30 -0700 (PDT) X-Received: by 2002:a05:620a:4441:b0:92e:779a:fec6 with SMTP id af79cd13be357-92e9a4d1e4bmr25076385a.52.1783096829671; Fri, 03 Jul 2026 09:40:29 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , Richard Henderson , qemu-s390x@nongnu.org, Xiaoyao Li , Zhao Liu , alex.bennee@linaro.org, Magnus Kulke , Peter Maydell , qemu-ppc@nongnu.org, Mohamed Mediouni , Paolo Bonzini Subject: [PATCH v2 20/33] cpu: Define BreakpointFlags type Date: Fri, 3 Jul 2026 18:37:43 +0200 Message-ID: <20260703163757.55500-21-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260703163757.55500-1-philmd@oss.qualcomm.com> References: <20260703163757.55500-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: 7x7lAsny2AWwix1D4i3cmvazh-FDJrNF X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX55Oc2MwKrlcV aeUjWV/038dBeacWWSsisddo140hAjuDdqZyPm0XrJggHKrbPwqkbhx8F17J10byIJvBSlaxUfR AXlbW35qzGcYQtKw+GgX10TdNvSCMaM= X-Authority-Analysis: v=2.4 cv=a6QAM0SF c=1 sm=1 tr=0 ts=6a47e5ff cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=9jKa8Ys6bur2UUCdWgEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX24QieQsUpUlX IISatDF5NQgcPrCGq0+xcNgMv2h1eB1JLZ9unexLvv8o+gr0tsl0zacAZ3PTZEuoHJG+Q6IBJB8 /ekcCjKFfaQMvaxrg+0bYG0XWj5sWJSgepT2/nvjj78whyHcreetQTg6EfFefpGwlZp79hWuA1q EGA25VYupUsMWEBX76/vF4tiVeOe3Q+/M/d4Hyx2B/ufKwngdA/xPsymm8QVUkvS+tdUjPmV+/E 8mlnbL1LoSMZVSNme9M9Opn1hP+ObPNYI+BA08FBnzl0knFrj4xkAwQP66Y83knBiKIMx6x3bg0 BMkonsZZ4Migrr0Fpr8GP20U5+O8ZywELSu7yEsCJo3onprBzGJ9WONHPftZlOzRXKCjdvBuYSQ nmI+7ogFZmqEeMDMsGTYaj4aJOQAfc4u2O+AB5aq13vuETPkNpv96fz6d0gF86fhfqrWz/W4oOY xSZzluW3IH6jKpQI58g== X-Proofpoint-ORIG-GUID: 7x7lAsny2AWwix1D4i3cmvazh-FDJrNF X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 bulkscore=0 impostorscore=0 phishscore=0 spamscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030164 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783096855699158500 Use the BreakpointFlags typedef to better follow when we deal with breakpoint flags (BP_*). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- include/accel/tcg/cpu-ops.h | 6 ++++-- include/exec/breakpoint.h | 3 ++- include/exec/watchpoint.h | 8 +++++--- include/hw/core/cpu.h | 8 ++++---- accel/tcg/cputlb.c | 12 +++++++----- accel/tcg/tcg-accel-ops.c | 10 +++++----- accel/tcg/user-exec-stub.c | 11 ++++++----- accel/tcg/watchpoint.c | 9 +++++---- cpu-common.c | 12 ++++++------ system/watchpoint.c | 8 ++++---- target/arm/tcg/debug.c | 4 ++-- target/arm/tcg/mte_helper.c | 3 ++- target/ppc/cpu.c | 2 +- target/ppc/kvm.c | 5 +++-- target/riscv/cpu_helper.c | 2 +- target/riscv/debug.c | 12 +++++------- target/s390x/tcg/debug.c | 3 ++- target/xtensa/dbg_helper.c | 2 +- 18 files changed, 65 insertions(+), 55 deletions(-) diff --git a/include/accel/tcg/cpu-ops.h b/include/accel/tcg/cpu-ops.h index 710da12b828..f64d94b2b50 100644 --- a/include/accel/tcg/cpu-ops.h +++ b/include/accel/tcg/cpu-ops.h @@ -298,7 +298,8 @@ struct TCGCPUOps { * specified by @flags. Exit via exception with a hit. */ void cpu_check_watchpoint(CPUState *cpu, vaddr addr, vaddr len, - MemTxAttrs attrs, int flags, uintptr_t ra); + MemTxAttrs attrs, BreakpointFlags flags, + uintptr_t ra); =20 /** * cpu_watchpoint_address_matches: @@ -309,7 +310,8 @@ void cpu_check_watchpoint(CPUState *cpu, vaddr addr, va= ddr len, * Return the watchpoint flags that apply to [addr, addr+len). * If no watchpoint is registered for the range, the result is 0. */ -int cpu_watchpoint_address_matches(CPUState *cpu, vaddr addr, vaddr len); +BreakpointFlags cpu_watchpoint_address_matches(CPUState *cpu, + vaddr addr, vaddr len); =20 /* * Common pointer_wrap implementations. diff --git a/include/exec/breakpoint.h b/include/exec/breakpoint.h index cc6fedd09fe..0c3cc0c8ff3 100644 --- a/include/exec/breakpoint.h +++ b/include/exec/breakpoint.h @@ -12,6 +12,7 @@ #include "exec/vaddr.h" #include "exec/memattrs.h" =20 +typedef int BreakpointFlags; /* Breakpoint/watchpoint flags */ #define BP_MEM_READ 0x01 #define BP_MEM_WRITE 0x02 @@ -28,7 +29,7 @@ =20 typedef struct CPUBreakpoint { vaddr pc; - int flags; /* BP_* */ + BreakpointFlags flags; QTAILQ_ENTRY(CPUBreakpoint) entry; } CPUBreakpoint; =20 diff --git a/include/exec/watchpoint.h b/include/exec/watchpoint.h index c4d069425ba..ba148eff3d1 100644 --- a/include/exec/watchpoint.h +++ b/include/exec/watchpoint.h @@ -8,11 +8,13 @@ #ifndef EXEC_WATCHPOINT_H #define EXEC_WATCHPOINT_H =20 +#include "exec/breakpoint.h" + int cpu_watchpoint_insert(CPUState *cpu, vaddr addr, vaddr len, - int flags, CPUWatchpoint **watchpoint); + BreakpointFlags flags, CPUWatchpoint **watchpoin= t); int cpu_watchpoint_remove(CPUState *cpu, vaddr addr, - vaddr len, int flags); + vaddr len, BreakpointFlags flags); void cpu_watchpoint_remove_by_ref(CPUState *cpu, CPUWatchpoint *watchpoint= ); -void cpu_watchpoint_remove_all(CPUState *cpu, int mask); +void cpu_watchpoint_remove_all(CPUState *cpu, BreakpointFlags flags); =20 #endif /* EXEC_WATCHPOINT_H */ diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index e5b68bced3d..77884b827aa 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -1138,12 +1138,12 @@ void qemu_init_vcpu(CPUState *cpu); */ void cpu_single_step(CPUState *cpu, int enabled); =20 -int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, int flags, +int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, BreakpointFlags flags, CPUBreakpoint **breakpoint); -int cpu_breakpoint_remove(CPUState *cpu, vaddr pc, int flags); +int cpu_breakpoint_remove(CPUState *cpu, vaddr pc, BreakpointFlags flags); void cpu_breakpoint_remove_by_ref(CPUState *cpu, CPUBreakpoint *breakpoint= ); -void cpu_breakpoint_remove_all(CPUState *cpu, int mask); -bool cpu_breakpoint_test(CPUState *cpu, vaddr pc, int mask); +void cpu_breakpoint_remove_all(CPUState *cpu, BreakpointFlags flags); +bool cpu_breakpoint_test(CPUState *cpu, vaddr pc, BreakpointFlags flags); =20 /** * cpu_get_address_space: diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c index 7f7c208ba12..e2911e3aac6 100644 --- a/accel/tcg/cputlb.c +++ b/accel/tcg/cputlb.c @@ -1033,7 +1033,8 @@ void tlb_set_page_full(CPUState *cpu, int mmu_idx, CPUTLBEntry *te, tn; hwaddr iotlb, xlat, sz, paddr_page; vaddr addr_page; - int asidx, wp_flags, prot; + int asidx, prot; + BreakpointFlags wp_flags; bool is_ram, is_romd; =20 assert_cpu_is_self(cpu); @@ -1499,8 +1500,8 @@ void *probe_access(CPUArchState *env, vaddr addr, int= size, if (unlikely(flags & (TLB_NOTDIRTY | TLB_WATCHPOINT))) { /* Handle watchpoints. */ if (flags & TLB_WATCHPOINT) { - int wp_access =3D (access_type =3D=3D MMU_DATA_STORE - ? BP_MEM_WRITE : BP_MEM_READ); + BreakpointFlags wp_access =3D (access_type =3D=3D MMU_DATA_STO= RE + ? BP_MEM_WRITE : BP_MEM_READ); cpu_check_watchpoint(env_cpu(env), addr, size, full->attrs, wp_access, retaddr); } @@ -1702,7 +1703,8 @@ static void mmu_watch_or_dirty(CPUState *cpu, MMULook= upPageData *data, =20 /* On watchpoint hit, this will longjmp out. */ if (flags & TLB_WATCHPOINT) { - int wp =3D access_type =3D=3D MMU_DATA_STORE ? BP_MEM_WRITE : BP_M= EM_READ; + BreakpointFlags wp =3D access_type =3D=3D MMU_DATA_STORE ? BP_MEM_= WRITE + : BP_MEM_READ; cpu_check_watchpoint(cpu, addr, size, full->attrs, wp, ra); flags &=3D ~TLB_WATCHPOINT; } @@ -1885,7 +1887,7 @@ static void *atomic_mmu_lookup(CPUState *cpu, vaddr a= ddr, MemOpIdx oi, } =20 if (unlikely(tlb_addr & TLB_WATCHPOINT)) { - int wp_flags =3D 0; + BreakpointFlags wp_flags =3D 0; =20 if (full->slow_flags[MMU_DATA_STORE] & TLB_WATCHPOINT) { wp_flags |=3D BP_MEM_WRITE; diff --git a/accel/tcg/tcg-accel-ops.c b/accel/tcg/tcg-accel-ops.c index 927af6c1db0..26d34c72d9a 100644 --- a/accel/tcg/tcg-accel-ops.c +++ b/accel/tcg/tcg-accel-ops.c @@ -110,20 +110,20 @@ void tcg_handle_interrupt(CPUState *cpu, int mask) } =20 /* Translate GDB watchpoint type to a flags value for cpu_watchpoint_* */ -static inline int xlat_gdb_type(CPUState *cpu, int gdbtype) +static inline BreakpointFlags xlat_gdb_type(CPUState *cpu, int gdbtype) { - static const int xlat[] =3D { + static const BreakpointFlags xlat[] =3D { [GDB_WATCHPOINT_WRITE] =3D BP_GDB | BP_MEM_WRITE, [GDB_WATCHPOINT_READ] =3D BP_GDB | BP_MEM_READ, [GDB_WATCHPOINT_ACCESS] =3D BP_GDB | BP_MEM_ACCESS, }; =20 - int cputype =3D xlat[gdbtype]; + BreakpointFlags cpuflags =3D xlat[gdbtype]; =20 if (cpu->cc->gdb_stop_before_watchpoint) { - cputype |=3D BP_STOP_BEFORE_ACCESS; + cpuflags |=3D BP_STOP_BEFORE_ACCESS; } - return cputype; + return cpuflags; } =20 static int tcg_insert_breakpoint(CPUState *cs, int type, vaddr addr, vaddr= len) diff --git a/accel/tcg/user-exec-stub.c b/accel/tcg/user-exec-stub.c index 28286e11a60..7b6c25c4738 100644 --- a/accel/tcg/user-exec-stub.c +++ b/accel/tcg/user-exec-stub.c @@ -22,13 +22,13 @@ void cpu_exec_reset_hold(CPUState *cpu) } =20 int cpu_watchpoint_insert(CPUState *cpu, vaddr addr, vaddr len, - int flags, CPUWatchpoint **watchpoint) + BreakpointFlags flags, CPUWatchpoint **watchpoin= t) { return -ENOSYS; } =20 int cpu_watchpoint_remove(CPUState *cpu, vaddr addr, - vaddr len, int flags) + vaddr len, BreakpointFlags flags) { return -ENOSYS; } @@ -37,17 +37,18 @@ void cpu_watchpoint_remove_by_ref(CPUState *cpu, CPUWat= chpoint *wp) { } =20 -void cpu_watchpoint_remove_all(CPUState *cpu, int mask) +void cpu_watchpoint_remove_all(CPUState *cpu, BreakpointFlags flags) { } =20 -int cpu_watchpoint_address_matches(CPUState *cpu, vaddr addr, vaddr len) +BreakpointFlags cpu_watchpoint_address_matches(CPUState *cpu, + vaddr addr, vaddr len) { return 0; } =20 void cpu_check_watchpoint(CPUState *cpu, vaddr addr, vaddr len, - MemTxAttrs atr, int fl, uintptr_t ra) + MemTxAttrs atr, BreakpointFlags flags, uintptr_t= ra) { } =20 diff --git a/accel/tcg/watchpoint.c b/accel/tcg/watchpoint.c index c75ed278459..5ea66e9763a 100644 --- a/accel/tcg/watchpoint.c +++ b/accel/tcg/watchpoint.c @@ -52,10 +52,11 @@ static inline bool watchpoint_address_matches(CPUWatchp= oint *wp, } =20 /* Return flags for watchpoints that match addr + prot. */ -int cpu_watchpoint_address_matches(CPUState *cpu, vaddr addr, vaddr len) +BreakpointFlags cpu_watchpoint_address_matches(CPUState *cpu, + vaddr addr, vaddr len) { CPUWatchpoint *wp; - int ret =3D 0; + BreakpointFlags ret =3D 0; =20 QTAILQ_FOREACH(wp, &cpu->watchpoints, entry) { if (watchpoint_address_matches(wp, addr, len)) { @@ -67,7 +68,7 @@ int cpu_watchpoint_address_matches(CPUState *cpu, vaddr a= ddr, vaddr len) =20 /* Generate a debug exception if a watchpoint has been hit. */ void cpu_check_watchpoint(CPUState *cpu, vaddr addr, vaddr len, - MemTxAttrs attrs, int flags, uintptr_t ra) + MemTxAttrs attrs, BreakpointFlags flags, uintptr= _t ra) { CPUWatchpoint *wp; =20 @@ -91,7 +92,7 @@ void cpu_check_watchpoint(CPUState *cpu, vaddr addr, vadd= r len, =20 assert((flags & ~BP_MEM_ACCESS) =3D=3D 0); QTAILQ_FOREACH(wp, &cpu->watchpoints, entry) { - int hit_flags =3D wp->flags & flags; + BreakpointFlags hit_flags =3D wp->flags & flags; =20 if (hit_flags && watchpoint_address_matches(wp, addr, len)) { if (replay_running_debug()) { diff --git a/cpu-common.c b/cpu-common.c index adb76b3a786..69ddf15b46a 100644 --- a/cpu-common.c +++ b/cpu-common.c @@ -389,13 +389,13 @@ void process_queued_cpu_work(CPUState *cpu) } =20 /* Return true if PC matches an installed breakpoint. */ -bool cpu_breakpoint_test(CPUState *cpu, vaddr pc, int mask) +bool cpu_breakpoint_test(CPUState *cpu, vaddr pc, BreakpointFlags flags) { CPUBreakpoint *bp; =20 if (unlikely(!QTAILQ_EMPTY(&cpu->breakpoints))) { QTAILQ_FOREACH(bp, &cpu->breakpoints, entry) { - if (bp->pc =3D=3D pc && (bp->flags & mask)) { + if (bp->pc =3D=3D pc && (bp->flags & flags)) { return true; } } @@ -404,7 +404,7 @@ bool cpu_breakpoint_test(CPUState *cpu, vaddr pc, int m= ask) } =20 /* Add a breakpoint. */ -int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, int flags, +int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, BreakpointFlags flags, CPUBreakpoint **breakpoint) { CPUBreakpoint *bp; @@ -434,7 +434,7 @@ int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, int = flags, } =20 /* Remove a specific breakpoint. */ -int cpu_breakpoint_remove(CPUState *cpu, vaddr pc, int flags) +int cpu_breakpoint_remove(CPUState *cpu, vaddr pc, BreakpointFlags flags) { CPUBreakpoint *bp; =20 @@ -461,12 +461,12 @@ void cpu_breakpoint_remove_by_ref(CPUState *cpu, CPUB= reakpoint *bp) } =20 /* Remove all matching breakpoints. */ -void cpu_breakpoint_remove_all(CPUState *cpu, int mask) +void cpu_breakpoint_remove_all(CPUState *cpu, BreakpointFlags flags) { CPUBreakpoint *bp, *next; =20 QTAILQ_FOREACH_SAFE(bp, &cpu->breakpoints, entry, next) { - if (bp->flags & mask) { + if (bp->flags & flags) { cpu_breakpoint_remove_by_ref(cpu, bp); } } diff --git a/system/watchpoint.c b/system/watchpoint.c index 21d0bb36cae..f96aa24210f 100644 --- a/system/watchpoint.c +++ b/system/watchpoint.c @@ -26,7 +26,7 @@ =20 /* Add a watchpoint. */ int cpu_watchpoint_insert(CPUState *cpu, vaddr addr, vaddr len, - int flags, CPUWatchpoint **watchpoint) + BreakpointFlags flags, CPUWatchpoint **watchpoin= t) { CPUWatchpoint *wp; vaddr in_page; @@ -65,7 +65,7 @@ int cpu_watchpoint_insert(CPUState *cpu, vaddr addr, vadd= r len, =20 /* Remove a specific watchpoint. */ int cpu_watchpoint_remove(CPUState *cpu, vaddr addr, vaddr len, - int flags) + BreakpointFlags flags) { CPUWatchpoint *wp; =20 @@ -90,12 +90,12 @@ void cpu_watchpoint_remove_by_ref(CPUState *cpu, CPUWat= chpoint *watchpoint) } =20 /* Remove all matching watchpoints. */ -void cpu_watchpoint_remove_all(CPUState *cpu, int mask) +void cpu_watchpoint_remove_all(CPUState *cpu, BreakpointFlags flags) { CPUWatchpoint *wp, *next; =20 QTAILQ_FOREACH_SAFE(wp, &cpu->watchpoints, entry, next) { - if (wp->flags & mask) { + if (wp->flags & flags) { cpu_watchpoint_remove_by_ref(cpu, wp); } } diff --git a/target/arm/tcg/debug.c b/target/arm/tcg/debug.c index 07a52643e71..11043ecd589 100644 --- a/target/arm/tcg/debug.c +++ b/target/arm/tcg/debug.c @@ -550,7 +550,7 @@ void hw_watchpoint_update(ARMCPU *cpu, int n) vaddr wvr =3D env->cp15.dbgwvr[n]; uint64_t wcr =3D env->cp15.dbgwcr[n]; int mask; - int flags =3D BP_CPU | BP_STOP_BEFORE_ACCESS; + BreakpointFlags flags =3D BP_CPU | BP_STOP_BEFORE_ACCESS; =20 if (env->cpu_watchpoint[n]) { cpu_watchpoint_remove_by_ref(CPU(cpu), env->cpu_watchpoint[n]); @@ -656,7 +656,7 @@ void hw_breakpoint_update(ARMCPU *cpu, int n) uint64_t bcr =3D env->cp15.dbgbcr[n]; vaddr addr; int bt; - int flags =3D BP_CPU; + BreakpointFlags flags =3D BP_CPU; =20 if (env->cpu_breakpoint[n]) { cpu_breakpoint_remove_by_ref(CPU(cpu), env->cpu_breakpoint[n]); diff --git a/target/arm/tcg/mte_helper.c b/target/arm/tcg/mte_helper.c index dca4ef5a942..17f920b3f35 100644 --- a/target/arm/tcg/mte_helper.c +++ b/target/arm/tcg/mte_helper.c @@ -190,7 +190,8 @@ uint8_t *allocation_tag_mem_probe(CPUARMState *env, int= ptr_mmu_idx, =20 /* Any debug exception has priority over a tag check exception. */ if (!probe && unlikely(flags & TLB_WATCHPOINT)) { - int wp =3D ptr_access =3D=3D MMU_DATA_LOAD ? BP_MEM_READ : BP_MEM_= WRITE; + BreakpointFlags wp =3D ptr_access =3D=3D MMU_DATA_LOAD ? BP_MEM_RE= AD + : BP_MEM_WRITE; assert(ra !=3D 0); cpu_check_watchpoint(env_cpu(env), ptr, ptr_size, attrs, wp, ra); } diff --git a/target/ppc/cpu.c b/target/ppc/cpu.c index 41edb18643d..913920d55b8 100644 --- a/target/ppc/cpu.c +++ b/target/ppc/cpu.c @@ -145,7 +145,7 @@ void ppc_update_daw(CPUPPCState *env, int rid) bool sv =3D extract32(dawrx, PPC_BIT_NR(62), 1); bool pr =3D extract32(dawrx, PPC_BIT_NR(62), 1); vaddr len; - int flags; + BreakpointFlags flags; =20 if (env->dawr_watchpoint[rid]) { cpu_watchpoint_remove_by_ref(cs, env->dawr_watchpoint[rid]); diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index b94c2997a07..2a3711fb1df 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -1429,7 +1429,7 @@ static int find_hw_breakpoint(target_ulong addr, int = type) return -1; } =20 -static int find_hw_watchpoint(target_ulong addr, int *flag) +static int find_hw_watchpoint(target_ulong addr, BreakpointFlags *flag) { int n; =20 @@ -1575,7 +1575,6 @@ static int kvm_handle_hw_breakpoint(CPUState *cs, { int handle =3D DEBUG_RETURN_GUEST; int n; - int flag =3D 0; =20 if (nb_hw_breakpoint + nb_hw_watchpoint > 0) { if (arch_info->status & KVMPPC_DEBUG_BREAKPOINT) { @@ -1585,6 +1584,8 @@ static int kvm_handle_hw_breakpoint(CPUState *cs, } } else if (arch_info->status & (KVMPPC_DEBUG_WATCH_READ | KVMPPC_DEBUG_WATCH_WRITE)) { + BreakpointFlags flag =3D 0; + n =3D find_hw_watchpoint(arch_info->address, &flag); if (n >=3D 0) { handle =3D DEBUG_RETURN_GDB; diff --git a/target/riscv/cpu_helper.c b/target/riscv/cpu_helper.c index 2db07f5dfb6..c318dcd633c 100644 --- a/target/riscv/cpu_helper.c +++ b/target/riscv/cpu_helper.c @@ -2000,7 +2000,7 @@ bool riscv_cpu_tlb_fill(CPUState *cs, vaddr address, = int size, } else if (probe) { return false; } else { - int wp_access =3D 0; + BreakpointFlags wp_access =3D 0; =20 if (access_type =3D=3D MMU_DATA_LOAD) { wp_access |=3D BP_MEM_READ; diff --git a/target/riscv/debug.c b/target/riscv/debug.c index ba5bc6ae13d..082ced71bb7 100644 --- a/target/riscv/debug.c +++ b/target/riscv/debug.c @@ -480,7 +480,7 @@ static void type2_breakpoint_insert(CPURISCVState *env,= target_ulong index) target_ulong addr =3D env->tdata2[index]; bool enabled =3D type2_breakpoint_enabled(ctrl); CPUState *cs =3D env_cpu(env); - int flags =3D BP_CPU | BP_STOP_BEFORE_ACCESS; + BreakpointFlags flags =3D BP_CPU | BP_STOP_BEFORE_ACCESS; uint32_t size, def_size; =20 if (!enabled) { @@ -605,7 +605,7 @@ static void type6_breakpoint_insert(CPURISCVState *env,= target_ulong index) target_ulong addr =3D env->tdata2[index]; bool enabled =3D type6_breakpoint_enabled(ctrl); CPUState *cs =3D env_cpu(env); - int flags =3D BP_CPU | BP_STOP_BEFORE_ACCESS; + BreakpointFlags flags =3D BP_CPU | BP_STOP_BEFORE_ACCESS; uint32_t size; =20 if (!enabled) { @@ -993,12 +993,10 @@ bool riscv_cpu_debug_check_watchpoint(CPUState *cs, C= PUWatchpoint *wp) CPURISCVState *env =3D &cpu->env; target_ulong ctrl; target_ulong addr; - int trigger_type; - int flags; - int i; =20 - for (i =3D 0; i < env->num_triggers; i++) { - trigger_type =3D get_trigger_type(env, i); + for (int i =3D 0; i < env->num_triggers; i++) { + int trigger_type =3D get_trigger_type(env, i); + BreakpointFlags flags; =20 if (!trigger_common_match(env, trigger_type, i)) { continue; diff --git a/target/s390x/tcg/debug.c b/target/s390x/tcg/debug.c index 99140b1ac9a..d10e9ed8922 100644 --- a/target/s390x/tcg/debug.c +++ b/target/s390x/tcg/debug.c @@ -14,7 +14,8 @@ =20 void s390_cpu_recompute_watchpoints(CPUState *cs) { - const int wp_flags =3D BP_CPU | BP_MEM_WRITE | BP_STOP_BEFORE_ACCESS; + const BreakpointFlags wp_flags =3D BP_CPU | BP_MEM_WRITE + | BP_STOP_BEFORE_ACCESS; CPUS390XState *env =3D cpu_env(cs); =20 /* We are called when the watchpoints have changed. First diff --git a/target/xtensa/dbg_helper.c b/target/xtensa/dbg_helper.c index 3b91f7c38ac..990012f60e6 100644 --- a/target/xtensa/dbg_helper.c +++ b/target/xtensa/dbg_helper.c @@ -85,7 +85,7 @@ static void set_dbreak(CPUXtensaState *env, unsigned i, u= int32_t dbreaka, uint32_t dbreakc) { CPUState *cs =3D env_cpu(env); - int flags =3D BP_CPU | BP_STOP_BEFORE_ACCESS; + BreakpointFlags flags =3D BP_CPU | BP_STOP_BEFORE_ACCESS; uint32_t mask =3D dbreakc | ~DBREAKC_MASK; =20 if (env->cpu_watchpoint[i]) { --=20 2.53.0 From nobody Sun Jul 26 11:01:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783096991; cv=none; d=zohomail.com; s=zohoarc; b=gStWW1J11lh+dCvvCAldnD9ZKR+5escl4ocCHwvAxVpZZZSYfUefi2cC19McppgwdYomZy3XC0dMqm1q6D84i9T501PF/SovdR+/h0xPccwtAu9laSOllt37bZTF29cuEZi9KtGq3xbP5ydUvNBHOeP9PaFoPFj6NMfSl7PVGSs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783096991; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Yi0iSVj4LIkP2DPM2Oyar3HIg3gxuDuywavv3adUmn4=; b=b537xKpY6kQk5QQ/BAAgDOQbA9beuggg3+skBVd19kt4jdKBUt0n0azXlcmoSfNxvbSXjA76lcNzreHCORU6CIWunl6Fc+ofuAk6IUB3DZ8AfOGCsT3r1XTebnjtQgrDCSQfaRBm0D2H9VQeN3i8c36kaioneZOzEbyv+v0w+RE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783096991617791.8779026027561; Fri, 3 Jul 2026 09:43:11 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wfgwh-00045f-Ud; Fri, 03 Jul 2026 12:40:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgwg-0003zo-2x for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:40:54 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgwS-0000zR-MM for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:40:53 -0400 Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663GJ49d363357 for ; Fri, 3 Jul 2026 16:40:39 GMT Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f682bt65c-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 16:40:38 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-8e934385db1so9129036d6.0 for ; Fri, 03 Jul 2026 09:40:38 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa09608d4sm610491f8f.25.2026.07.03.09.40.35 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 03 Jul 2026 09:40:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Yi0iSVj4LIkP2DPM2Oyar3HIg3gxuDuywavv3adUmn4=; b=fVxJANe1j6+71nbf ovt6sr3VkvYZZ82SBp3vqUyk7MbzSH9C/YFrFWbao7OYWtxrCWPwX/zBR6SfCNkJ B8C43+FjuXYt/UPFx6sCWxHpy3t1E+/C6aL7usBWafjTLoUxgDCJDwqG9O7QGv2m y5kL/QTExufLJr7nXCwrSTpPQ006W7sVSsmMmny/1ek9aVIq0HqKxGd5qNbTt4SG jYMSStspbz2ixwpSgLWqibw+eQ5Avaz/fGhJ2UgWnjvdKOU4JGljNfXPNhWtL8WN +Xo5POSHHpZvqJT+QJMjxKV5fvVWpg/1ihHFN958zWxvYM9EVTSLd9LR3ppvajtw 2tad/A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783096838; x=1783701638; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Yi0iSVj4LIkP2DPM2Oyar3HIg3gxuDuywavv3adUmn4=; b=XfgvkEU74ZbOKgx0WyX3aksmJ5DsoOK6SWzCUPD5CK1qbyhT6gmFGf+ku0QEZGOuh8 IYyXpwXxReNr49pqMCHvcP6AtCSa6RW/dxoAGeH2tEnNHXMIKeaZGA8dix3jr6UAoKqU 6hbz02VBrSjQrTQ0+AFWlOTSy55QQOf1TFHgzwAFqLeFik8aMSQe13NXEtzOMWjS0KzN wSeCkEe1qjXfBzu/Z6gOaeSQhhs6C0nwvJHfeAMEviG7aJq78cDl5qBB7Ok4lB7mGiec WWK/Ly44CBXuGAljSawvd6xjGeZKma1MXupz0nJCz2we8XNthfQh3liW99HlYYK8374P Y5dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783096838; x=1783701638; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Yi0iSVj4LIkP2DPM2Oyar3HIg3gxuDuywavv3adUmn4=; b=oppdfRGTtI/8KkK/SnqohNcH8L7+ri6cvAUvgD6xp5PlMRqomhbIa0np4IkANrwrsY ZBvOi3vWD5LkEzrGt21lsdSnQqwE5Wp6JD2WT01w0qeOzLMXKfiEs44pwf22cyyt5oaY vbKicM7qcOlMnozWtQnrq+ELtxlfGbFc7gC2VBUmBDBdUzYS++zMMV8Uf89JaXu7jpHa PYAnoAEsEaPa0bRan3pkB26coxSVYmDTWCGX8A8xlEwIG3G6HKGxaQEvIvWmKTuOkDCz jSQahoh0f93YavdKLipGRcqvbpHy0BZoEsNN0FxKdwbbjgF63kT0obn8QBRyCgUMHDTZ h/0Q== X-Gm-Message-State: AOJu0YxPJibyeF+mqm2CInHZnhjkZvbeJu8qNv1rZB+laXvxe6WvBZDo jcdBfw0974eWJoAfxstDyQwyiyBG3UWE33RjnKycLi9Aok0oFhzQtfkjRSkE35JMtpZcWGxFny9 yGz0kR/2vTfO9UPYDLrASVnYDXu+ScpB0qf75Rk73KnmHTda728QKQAm5jIpddckLQw== X-Gm-Gg: AfdE7cl6XrDm3vksVkIrzTUe0BNfjuKeFMdjrOTNgn3XqLFygC9nPvqFrF97SCrbG2F prwaMjRN+WZnjo5aw16kFTAn4jger/9UW0M7IIZj2E+NgtHvLbS5n3Ar8jFcfaAko04ejK5ezpJ /xPqJvdtbPQXaymvszKCcyxf5tQeTeJEvaf0J5aKVSFJJntC79/aoOvEW6k78CvPVJfehVjebew mpqpf4KQTKL/3B2RGCFj/xoO4u9Dyst2MRY+d+/SO0Z/TO1ZsF/4F4Ewb9gWW29Vhb/NbBWSTpZ yMxOO3oipRsa4SwE/0ZVcjX1smYgA740tbgUh0vAmQsHtIHc+v4EBqoSFwUaCCrEbNELt8nPz4Q XkvFBjE/Ov3INrlSQJHokGpmCQPAozBWfn3cYG4Zarz9Oz9ESXPq0/+eQFCisSrbuFhQA X-Received: by 2002:a05:620a:6088:b0:92e:745c:6c49 with SMTP id af79cd13be357-92e9a313e9cmr31850885a.15.1783096837576; Fri, 03 Jul 2026 09:40:37 -0700 (PDT) X-Received: by 2002:a05:620a:6088:b0:92e:745c:6c49 with SMTP id af79cd13be357-92e9a313e9cmr31845285a.15.1783096836955; Fri, 03 Jul 2026 09:40:36 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , Richard Henderson , qemu-s390x@nongnu.org, Xiaoyao Li , Zhao Liu , alex.bennee@linaro.org, Magnus Kulke , Peter Maydell , qemu-ppc@nongnu.org, Mohamed Mediouni , Paolo Bonzini Subject: [PATCH v2 21/33] accel: Remove unnecessary 'inline' qualifier in remove_all_breakpoints Date: Fri, 3 Jul 2026 18:37:44 +0200 Message-ID: <20260703163757.55500-22-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260703163757.55500-1-philmd@oss.qualcomm.com> References: <20260703163757.55500-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfXzwK1+H2zqT81 M2OrnVRDU7XfdT9w43hZMSfvoB0QHeV8vSaniOl12EbhqfVblFsSnpmwXoowJ5DRW1w8dWZFagI byNboGBL/SQJTGDu8GqQaFFlhnubr/x3rfl/RdjMJKAHVnJhWtE1Cv5fAAEzH61Y0Uh3u2XaYeD F713SQypi4XcXEDf0tGMGAFWFS3zSsuVvBl4svHiQkodMYISxK9MidkXSZ5ugsssW/TFbZAxnbU ZoPZ800CQ2Qg4PMMbrwJMNwn3q3pkSbpOyfykZ8+D1ObyU5VHqZaSfXieO3AlQa2si1E7+cKQXP ecWHFCBMoJytdVeLOq2BDJTwoGzBtUWJy4tXmS8t4qN359Qb6Om8oUNI0616iF3OHeI7LxWATuV PQzN1ELzvu/Suvccq/OqPRiSWBY6ukAJ7IrRNRMrel+uGm4CNSDUTdJGuW42hvZAarzSUeMw46+ QjqATo9PLyn/MFOFZCA== X-Proofpoint-ORIG-GUID: CQiEdn8YgNA5MquTSveC4bHIlOlMgCUn X-Authority-Analysis: v=2.4 cv=cc3iaHDM c=1 sm=1 tr=0 ts=6a47e606 cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=Ucb4Co1tYGy3ov5cU_AA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX80Ht2DPcRs6p fsjLRdWhfHs1niKT+/w5jtAd2OSVWI5fBbd6doKhhJqnybIGdqda1Pblye48YiuyYAbXctlv1xA eUq57hGoMKtKW9CTsZxpXsCscb0quBc= X-Proofpoint-GUID: CQiEdn8YgNA5MquTSveC4bHIlOlMgCUn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 adultscore=0 bulkscore=0 priorityscore=1501 phishscore=0 spamscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030164 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783096992415158500 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- accel/tcg/tcg-accel-ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/tcg/tcg-accel-ops.c b/accel/tcg/tcg-accel-ops.c index 26d34c72d9a..c54acc770e3 100644 --- a/accel/tcg/tcg-accel-ops.c +++ b/accel/tcg/tcg-accel-ops.c @@ -188,7 +188,7 @@ static int tcg_remove_breakpoint(CPUState *cs, int type= , vaddr addr, vaddr len) } } =20 -static inline void tcg_remove_all_breakpoints(CPUState *cpu) +static void tcg_remove_all_breakpoints(CPUState *cpu) { cpu_breakpoint_remove_all(cpu, BP_GDB); cpu_watchpoint_remove_all(cpu, BP_GDB); --=20 2.53.0 From nobody Sun Jul 26 11:01:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783097017; cv=none; d=zohomail.com; s=zohoarc; b=EF5CswOzNPqaM/VNchdhCwCtXrYzQmB1dF9CkRFDz8uWomsmsw/c5TNpiVsKSRJSbZWl2pbjNY73hJ6yJopPEKWvKL/9HdC7CDnH/hV9bQo9UvyIWbVXNO82AQAAd+in5RFcmYUfvVmPqh53fK842PDMmQjbLLfGGHrd4bP+jPU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783097017; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=gfohBGLaZbWwSsM8BLb51a9USAKrCnCAVyI6ZJxJiSc=; b=h+odpfPn5Q9PvfPEeW28jKHwkBuHPTjQhBjZivrAX3bVhWTIv117CV071hBNu3ueDQt9zRDwgpP4NXcI+Ty7RuUHCG8CHHorVWVn4TIHofNw07CqHhGSyuzTOwqu0dzJjevK2Rorb07t+GzxewDmbiCPhvHBMS7UXBlHSkFjNoU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783097017024705.4190585321796; Fri, 3 Jul 2026 09:43:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wfgwp-0004f1-Et; Fri, 03 Jul 2026 12:41:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgwn-0004d8-J9 for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:41:01 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgwi-00017c-Sa for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:41:01 -0400 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663GInft498246 for ; Fri, 3 Jul 2026 16:40:45 GMT Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f65qcjx12-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 16:40:45 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-92e52306621so54390685a.1 for ; Fri, 03 Jul 2026 09:40:45 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47a9b4d850dsm754264f8f.0.2026.07.03.09.40.42 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 03 Jul 2026 09:40:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gfohBGLaZbWwSsM8BLb51a9USAKrCnCAVyI6ZJxJiSc=; b=Oer6grjYf+qYDap2 tm3ZHsY2rELicf475RKbnyf47gaPjbWFrr64K3N1G8xbqH1u7MT5fZiIrES18bmN BQoL9lugbDjHmrEpZ5C7n4+xz8ZWc1R4taIYMaKFanikp2ql+HmiUOdq52qWL/wk gDm13HjDx4HOdoVnwOldaF29NZpMTDXK1h61X3EtRtzXmIRrRJ2gZ9rsjn2nFlH4 jwKSj4VhRzI/SzU+jRRBaBg62dH4t9BgzBrQipiI1aSb4m5XQr6IfpnXM/s0VRoa Ki06L85BQO31mjp2Cj8FistMaxetD/JEbSk1Z/SAu4ynmxvN00zpA139nN+Pfm+y 2Lam4Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783096845; x=1783701645; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gfohBGLaZbWwSsM8BLb51a9USAKrCnCAVyI6ZJxJiSc=; b=V1O1bT0rUAWaQ7wLopl74IM/YKkCC4z4EModnBPQsiLBJ938FtUU8jhx7oHyNXkgOo +PIuw6afGAEoyl+YPgCGgAKTYWY90ZOonaf2Ea7nzIL+BLcwF8rB15ULcvRzAMyYp8S4 qKfo4hsRrgME6LE5ScrIt8NhMYg30E4CK0fkv+DvEcagxnUP3Dz2/57Y16RRRyii/NHd P8RzpXFM0qNjnzlA+7izWMVDN/hiKoGRrZImqarlH/9JggibtWSW9ZpSMEuItWRxRzG0 0vFWK/nYga1Yw6i277QdWOqS+Vtf2BiVoCFfmLQL72sJObl2Kyjzu22xN4T7WmKg+kJG 5N8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783096845; x=1783701645; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gfohBGLaZbWwSsM8BLb51a9USAKrCnCAVyI6ZJxJiSc=; b=ncwkhYoCCo7S5jktYfj0uRz6r473y9LOZxjwtaF9uaYOzQy2GAzZXMCJL5ciBWk1eM WeiZvQiMs36NWPaojQZ7yZBnMOxmQvl8+5Dmb+9J9F1B/0q97jwzST0ComnnPJ8N1RhL l3nm0n5Z7RaMpDhBbJjpaw9ukwFj/RP349uCCj5pjbTAbSvvwsktu40ZQydK1cSMWYSZ v9xHlzQoYTVQNgv2oZMG47hSBSbOpCTesGTa/7m+TH7lxrntym02Y7hAIvtDCBlyPGhP VX0iNw8vzVuMXpS14lrx3E82saDU6kRhP+CjAMhvXx1cueQs8IXA0Csl4g6khcJiBpF2 jPiw== X-Gm-Message-State: AOJu0Yyx5zXDEbfOr1GkEEieJxSPmxtVOfXfU6Aji5+VYgTO3Xxrt4AB mIwa4UfFRctIi52mCfAHWJuGnyYdAdEATTxdfnL4In1ATEhN7+YbLk+/6peGibHmUQumH5qPaoo bd3hShFQiYGzJSpnifU1b3ZMsggz7vGVLujWnShFaT4faQJzVca2AYlnckD8ZY+KFfg== X-Gm-Gg: AfdE7clXUYkoTQ4qX8cQ2G03fw3Lm9xHwQPSH4dRwPXfyJpVXwpsdj4m3Bdak+9173Y dNfqZgBq0dIWghsukDjbojkWw/n7CFvXL8yPnrw17D1+NDXddedZObItcbImWVkglTyDNT/Oijm xPIYt28/Cny7OSpF+XK2+fYiy3TyEiOnTyTUnEgJJ2zR0+l+nBEnK9QwrGjRAS2beoGimBJKleG Lz9HrfcR6dJqI48UpQ8Fme30pOsRpyzJENr626PDGcLw2e0BqvsHSNEhDbb09HFOpsIEuik9OZ8 rhIFF2xMIN5kyNXBr9H6Zvs8x1XYjyUTi9U+ARbjk0zovm15UKJO6Qpzd+tjhkCJt1YmtSjF6iV gt8c5fKE1l+R7t6Zq40pjuAvhGv+KOocMPVr9rMWtLV7E4gvtUFe0lqs7jXm4OJkEG8eR X-Received: by 2002:a05:620a:46a7:b0:92b:67e6:4b73 with SMTP id af79cd13be357-92e9a52b304mr19063085a.74.1783096844925; Fri, 03 Jul 2026 09:40:44 -0700 (PDT) X-Received: by 2002:a05:620a:46a7:b0:92b:67e6:4b73 with SMTP id af79cd13be357-92e9a52b304mr19056485a.74.1783096844253; Fri, 03 Jul 2026 09:40:44 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , Richard Henderson , qemu-s390x@nongnu.org, Xiaoyao Li , Zhao Liu , alex.bennee@linaro.org, Magnus Kulke , Peter Maydell , qemu-ppc@nongnu.org, Mohamed Mediouni , Paolo Bonzini Subject: [PATCH v2 22/33] gdbstub/user: Directly call gdb_breakpoint_remove_all() in user mode Date: Fri, 3 Jul 2026 18:37:45 +0200 Message-ID: <20260703163757.55500-23-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260703163757.55500-1-philmd@oss.qualcomm.com> References: <20260703163757.55500-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: 8XbYSee3XAYatSMgBtfYDK9QkO2OJvnD X-Authority-Analysis: v=2.4 cv=Bb7oFLt2 c=1 sm=1 tr=0 ts=6a47e60d cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=zxLOgqzoZ8asriTz2EMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: 8XbYSee3XAYatSMgBtfYDK9QkO2OJvnD X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX4vn+PP+kjk8t Qir/LdjrtvuUWRQXRG+q7b8qzJVV9xv8lP5mp6USRFMgIbANaudKvVa3py9gisJct0LywL5wQiP A9WH1HjBqY2oK7hsqQBqIQD2O5EL4MDVu7wr3niY2lU1gT2wKuAW1WfO82yQKyZltkkF9Q9A5y0 +NzmIyh+H8hqvQzLyZMPxZ9446bGJyp6DjvuHuu6/GZmHVaVNkwfJaTnFWqtiqGHplgEhlJyc4H 5CpmKJmsFLyVqNapgNDMbJlv9w2YenwIORrCHmHfEiCrnCz46U39flFhWCkGJqCIWIzJ5cmyKlP +O7dJP3F5fxRSVAvlhjKblel2NRGz37Azb4jaI/jbB1Nrg9xkj4gxeE8me4+C8pB+RGqomwVRCu CC6I6Jt9cBnqJ0tmAKgnUyCL+UMTXY8mFxASxaIqJDNhdPh8oJisDc7AL3mnPTtTJ53p2o+Z9tu raAkYzKw44yKQpEZEJQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX66oqNquyn8uq P0w/4hzRHIPUucQ7tsPzy0WH/AEUokiV6BBLE1r016nXx68a7dnN+1/u6KqmUy8NJCBs+wxLlau YID/yIbFXaDtZCWEAY4s3AVMCZ9e4jA= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 clxscore=1015 impostorscore=0 suspectscore=0 phishscore=0 adultscore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030164 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783097018477158500 No need to deref external methods with unused argument to end up calling a method defined in the same unit file, call it directly. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- gdbstub/user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdbstub/user.c b/gdbstub/user.c index 299388b9f71..90d6ee49fb5 100644 --- a/gdbstub/user.c +++ b/gdbstub/user.c @@ -557,7 +557,7 @@ static void disable_gdbstub(CPUState *thread_cpu) close(gdbserver_user_state.fd); gdbserver_user_state.fd =3D -1; CPU_FOREACH(cpu) { - cpu_breakpoint_remove_all(cpu, BP_GDB); + gdb_breakpoint_remove_all(cpu); /* no cpu_watchpoint_remove_all for user-mode */ cpu_single_step(cpu, 0); } --=20 2.53.0 From nobody Sun Jul 26 11:01:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783097000; cv=none; d=zohomail.com; s=zohoarc; b=bMpy0B47HjRO1ZxhyqikWIjmkiAKvt/P3M1zU4beTe2VtJvJkQx53GHWkUjOoLofhCZ2SEWOGbqLzhmJJsbjIGZOAcNT5K2p+0H4LadPSt0j/o0gWjURw9UQh2GqgaExI/jc3hXyUwCeRULiaNBWS9bNkaBPjryvFgTW6C5WTas= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783097000; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=QV+aX9nOik2ueUL6+e2EZz4Xhxb9JObx3udYKE6I3oM=; b=cECJiPCiQb9/h7bgUoV22aOCD05EF38kLnPSk3z1F5jXiRvFxjfsq0/RUhXuC5JEOyCOhAI47eRnZQbHF0+mf5i7eXknFRyY23UOJT94o8OasMjVfIkMXJfrBNp5Gq6qVZbE6uwtnXA5TdngOKtJWaeNuNdEqvc+9XAA2k/vCQ4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783097000838342.64381488302; Fri, 3 Jul 2026 09:43:20 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wfgwt-0004n3-Gu; Fri, 03 Jul 2026 12:41:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgws-0004lr-Fn for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:41:06 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgwp-0001Dw-Q2 for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:41:06 -0400 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663GIsCd498335 for ; Fri, 3 Jul 2026 16:40:52 GMT Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f65qcjx1h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 16:40:52 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e61b38eddso131617085a.2 for ; Fri, 03 Jul 2026 09:40:52 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493ccb4cafesm60809585e9.0.2026.07.03.09.40.50 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 03 Jul 2026 09:40:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QV+aX9nOik2ueUL6+e2EZz4Xhxb9JObx3udYKE6I3oM=; b=Bygy/DMCnWK3TGVv UISvUMpl+UmEvj9CrcNQlXM1Xpg/bmVCWsis7gLJ8F/Q2a3O76/ejGp0ypmoqUbi 9ZfO3fCSKw6CUuSucQaUB1VH4D4z1g50YfvuDBdwXhfI3XWKMAu/5IBq1d60JKuJ 1jj+UmFSv/6gqOILtbl1eUGxafQPLEnwxntHWL36huwK4KOllDefeXzqn33x1lO1 d6SjcAJAOTAyGhz8zywMtCoQsTsG0KGH8QOqNffPKaWGhgxgEmRaVdlU6sRZiDi5 lwoRbuKHj9U982OzDQfvrG+PS7Cpb3r2ZXUY+Fqgb/kPpYleI0wmM5LIrIkhD8O2 IxQzvw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783096852; x=1783701652; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QV+aX9nOik2ueUL6+e2EZz4Xhxb9JObx3udYKE6I3oM=; b=GxNDRuCMJBqylJBZ6T/eXyPreWhS8YYQYwvEVtX8a1AG8EIxMsx2emOeJ+QZBzM45x y+rBB+OBzlxNiaAl+ic6beTOrClWQg4SqPhlWfUq9KJIDBBHM70ub9tc75Jpv+9rGmwO 0tMD3weWKXFjy3PHyanrViXLdxIJjKNCEVIx+7AQdSWpW3M6aeb13WcSzXVV2wLDXI4Z 21chOblfkAf3nHkSWv55dbYHhjwkFPx+ZE3kQ3GhGreNhxLnrEi5vIod29gAY774SuMN xv/vWrTwhB70pj23yWAStdyDkwbiaMy1E5yKUBFuKtLnQOIwSUmamNL+AWsZn13aWF/c F1Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783096852; x=1783701652; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=QV+aX9nOik2ueUL6+e2EZz4Xhxb9JObx3udYKE6I3oM=; b=epl8k/Rdhz7VGNzkGDCkvKoGYXJs6UjD6oLy7es7h8E8WxXhE2f3NRh7E3B9LZRg8d 3uGFtVL/EW7/LgDAxxxXoQJnbd5Bs6iZ8mkRJK+su0QPATvMPm/43QAUY7iA9yBDEev5 exIcwzkqSJ6PcwaSHeUCkMytqqTm77irzQcQdZNCIjmCXbBM7RmUbt0hWRYmD2Ze7TDs C+d/Doo2xxsTDJeib46pc1QyOWs9i07FnE+UopRWCjPiOzcumQocNN6O5/BcNm20F0mt CZ1qk5p/aRqSmgsuPiGPwRFQNJU4Y+BUsp+WnNszNuz4PDIjeYLNhYlHStE0uRJioHaZ 4Ysg== X-Gm-Message-State: AOJu0YzjKxGlwNs3w9OyfSq2772pwMkYyGwrrM1bBfKDZ6+9yDtsdier MojZtTJxJILezTO6hmEZBa4Jk7wrbf/u1mEn7xGN8khzUVeTOkWV8BmHaoJkrmR/xbPxz4oa8Qf y4/EVDh76w9/jUM6WLqnnBE5SpIGQS05GtOOx+uopGQodrdGm+ODNUZ09sTN8LFz0pQ== X-Gm-Gg: AfdE7cmF7g3hhB6aNZPOVELYA90Yy2g3faaZDU9gvxSGOaRZWeUYUDDJDKLIEgLU1L3 Lu2fjRjCmUCZQnzowhvNS/TPYllqpTgAPDxpMdCVAZyP7TEFNUgv7nYw0TO/V3tRqndO5xVBZc+ vY5fwEQSEMyQoFPcTsVapMaXn+c5UvcVN6mlY9CAH0bff8NE4MxSkKl5sfB1Hzv8OcPvXS4QcbZ BFyCYtSkoGEW4S0ZiktWTOyRMNZyhCG2RZ6EWK3cMa+8bQe81nvSjiD0fLaqYi2xCsysc/Pmzhj sFpDuabY38iMo1Klj1kvBm9GNOSk/Ow410uLXese8LP1I6jEzW5v/xLVP26XMB2QHnI9M99/4SF HBcbjarK/0mkIY3rad0t+63dOrFu8PPO/pZciA8BBcUGdp18MPSuCWAh81hIvYYmvdtuX X-Received: by 2002:a05:620a:1a18:b0:921:1572:ea9d with SMTP id af79cd13be357-92e9a3e0dbcmr27342985a.32.1783096852071; Fri, 03 Jul 2026 09:40:52 -0700 (PDT) X-Received: by 2002:a05:620a:1a18:b0:921:1572:ea9d with SMTP id af79cd13be357-92e9a3e0dbcmr27337985a.32.1783096851671; Fri, 03 Jul 2026 09:40:51 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , Richard Henderson , qemu-s390x@nongnu.org, Xiaoyao Li , Zhao Liu , alex.bennee@linaro.org, Magnus Kulke , Peter Maydell , qemu-ppc@nongnu.org, Mohamed Mediouni , Paolo Bonzini Subject: [PATCH v2 23/33] gdbstub: Reduce @type variable scope Date: Fri, 3 Jul 2026 18:37:46 +0200 Message-ID: <20260703163757.55500-24-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260703163757.55500-1-philmd@oss.qualcomm.com> References: <20260703163757.55500-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: QRBUKMvA2BvMmAN_axruDx3RQnIGLKnY X-Authority-Analysis: v=2.4 cv=Bb7oFLt2 c=1 sm=1 tr=0 ts=6a47e614 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=3yY2QiCzES6IJYuWj7AA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: QRBUKMvA2BvMmAN_axruDx3RQnIGLKnY X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX9VMppu1kpTQU J3Z8lqrjNH+3QMeDaEUNCpPaGvZTaiHZxnkOM+rN/griOB4WUqG2NvGnggmEr9BEWN7kBOXJRrB rhnuiWN7/Va+bQ1m85bqxsp66v20TFrcQwfeQHnZVNACYtlI8YKqao8D/239hsNv09OSnJ0ntUW ECQ3AO64sh4fkJhBD1MIxGP9kEqRUxvNVfi2+tV8kvnorXDQ7lqpik7V/Jm80yF34MK/2VYEzBX HrZnm0lVzzT3qt6AWomN+tfTzglbAuepJ/3rZxQrclFVqrJiABDKnEFPwb9YWQn/LjcyDXbgDSM RLBwwKtWGXSWg1Xlc3jJ8jRtnhja5WI1Ajap9dKW7Bu/eoOCmG/vSaxGskS6eoC8AqpEh0FwbB3 q2lC3xuY3DxJ5TXNIvJsfGIiNVQKVcG5cWVRbw2Tf88F5wAZftiZ7/uQin/YOkQ4Tu82fA5Mq6O w7dP2iiTQLSfUS9wbDQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX8c6/kgw8vM9G RgYaTkN3gdZ/uGCr0oNwkf5w61Hp5NlAPyGqwsH5eBOgby3egb/mbAIuCqely7ZIZe2y1Muwo0z dOpRIl3Tk0i/ZfJj26IedQ5aUihydoI= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 clxscore=1015 impostorscore=0 suspectscore=0 phishscore=0 adultscore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030164 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783097002450158501 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- gdbstub/system.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gdbstub/system.c b/gdbstub/system.c index bf7aa1ac234..9c4bd8ebcba 100644 --- a/gdbstub/system.c +++ b/gdbstub/system.c @@ -125,7 +125,6 @@ static void gdb_vm_state_change(void *opaque, bool runn= ing, RunState state) CPUState *cpu =3D gdbserver_state.c_cpu; g_autoptr(GString) buf =3D g_string_new(NULL); g_autoptr(GString) tid =3D g_string_new(NULL); - const char *type; int ret; =20 if (running || gdbserver_state.state =3D=3D RS_INACTIVE) { @@ -151,6 +150,8 @@ static void gdb_vm_state_change(void *opaque, bool runn= ing, RunState state) switch (state) { case RUN_STATE_DEBUG: if (cpu->watchpoint_hit) { + const char *type; + switch (cpu->watchpoint_hit->flags & BP_MEM_ACCESS) { case BP_MEM_READ: type =3D "r"; --=20 2.53.0 From nobody Sun Jul 26 11:01:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783096925; cv=none; d=zohomail.com; s=zohoarc; b=QKrWmvpd+KEduiHvxs3FBJFDCRVXzjdH6GWsjDjkUSKHAPJRJECLb4aYiWE4s4ku+5OCT6yo0B1/z9I4+WLSNoScZIqXjTndlH4Yj/scoTgOF+R7nMdCj/wzKcUeyc09b//mgVMTWLPXYXsEVVUJL3YaboN8+URu+vTLPc5tAOI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783096925; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=MOmi6wrm0eC4tNd6GGXXYQxEoIV98ouYze/eblRNqP8=; b=ZejS+wGunsBza/bP393Xfo0Tj7yUsZU4b6hjIIvlk+RI4Sjm9niC8OhhsMmuIDfqeTkRkA7eswTvfra/O69JIolCqY5v9KgLfFvIg+8tRPiZVuqWD9shbGJyXG3Izn4uh1CmE4WgVPVbjRjweeTy6G6EsIv9scbSR3c22LiQtvQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178309692534961.94337540105289; Fri, 3 Jul 2026 09:42:05 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wfgx5-00050E-7i; Fri, 03 Jul 2026 12:41:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgx0-0004wj-Q2 for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:41:14 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgwx-0001PS-Et for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:41:14 -0400 Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663GJHxo492638 for ; Fri, 3 Jul 2026 16:41:00 GMT Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6dkkgquq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 16:41:00 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e56b2b350so146758185a.3 for ; Fri, 03 Jul 2026 09:41:00 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa0960b06sm588857f8f.28.2026.07.03.09.40.57 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 03 Jul 2026 09:40:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MOmi6wrm0eC4tNd6GGXXYQxEoIV98ouYze/eblRNqP8=; b=Eh81VJe0Xv//dgZh 2QfaAswc4yuYk2POI923C0WVNymbQRBVlgmJi+MmNbbnDryquD3p+czufKBpwmqW aPCmuto6LKNNiYGmudA4DN28TQtUDIG33bdBNBFRF80aZ2kIOeClFNLz7y5AVSd4 Agz/j3vURnWzuKI3OFoL+GDFa5lKhThXjYNjbbmpOXme8ndykqkvpKYmhFI0tpIL zSAUVcje1JsGSd3YNtpKd2lAXwzXuZPh/ApBjRDbhsAkMDel5ogyRPzsDiy/Vl9v DPen+gIQ/yGLoUOZJ7FsnG9boMZaa+CpN0PqFjtwxfwZQR0/H1nZCWntDxpOn8YC mnWOnw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783096860; x=1783701660; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MOmi6wrm0eC4tNd6GGXXYQxEoIV98ouYze/eblRNqP8=; b=KgXP6/8rF9nX6Ij3L7aEeTlqP3W4wF8Z0DTsV+KIJAeJIttCwpyHlrBvKHixfQq+Cd GYxaY2KINu+h22vmz1qECIdlIfQHhmCJ+B9HW9PKXbJnEPdKL+jWAhyi0hz+YCZzkZoJ Ntmsn2bKspx4wtOL24mC7oEh6wjMgZCbY9ZDMDP+6o/lMTt7nYXEPTkfR0wqRZWwr9vx MOmJbW4yMKq1wVOwqGGw0oaQ102UsoueHNe7Bn3SvuYgiPY3okfPH7OBzKTg34iCeo7z FzDanUb07BGNZQApYWyNiyDmEs1zJb+CUqDS0DvjlJmm0LmSM4dBDrmg+k3Zyye4fgHl yntg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783096860; x=1783701660; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MOmi6wrm0eC4tNd6GGXXYQxEoIV98ouYze/eblRNqP8=; b=Iu2TI7hxooPmc5qXHT6rkh//apVeowyAT9Ey/WSdTMoVSVcKeGSlhEn0VE8SG8YjWU FYS1YyQAc5t87Z3uLRr4/EKb6jn3P7ENXYN/g7k9+ReJ1+CWV9vmN0e2RLnp5qJdk4ZS iiT54MFoCfXI7iNcFDwEqck0cQ3GLDO8/f7uIDVc1KsuYYe2d+sELozJZB8ek520qKpa teySgg46+ePmzLXuCwfeQXhUGhKeFeS9g4yQVnKt0P4+ETDlZS+In+Ic5ydpdBvX7yrH eS7x9XP5S1it4ZstLuP2rFD+8pQuZQYLmWwvdM0ObLIZYc1824UTI74ieKmNdLIh0Fn+ A3Vw== X-Gm-Message-State: AOJu0Yy9jW6dpDzRMgQqsA7RZT3iz+e1kvA/yzzv7oyyFRum6Pu0WcdX eC/pFuFDoTkT54omcFfPFkNmjEiCYoQkB/2CiatImVAdj8S6yQDYP+3cwHPiigkaLukzHd9OlAu Ka7Dj3kWAJmjNKY8gXWlYcmop/tcNVPil48rdb9OLOXCzUHDrwMY9GJaRepSvADB7jQ== X-Gm-Gg: AfdE7clSJYL0225aPVMZ7wfiYWCSKTehTgRmis45RfyaRuVXVSsnoxuCjFzI2kS8m1w IA5LBZgwWmP1ipH0sGr+lTn9nijATrNGbcwcNn/pvfSAF3E1bfAVPniORYGqAaO+Vd0zeCXZZyj CO75yFsBeiWrb0MtMpgKGmPYHsz5/uUNuCxXsB2YmJrz2xcWNBWa9llIPW+82iZYZnWJh+icB+g Tp+Hm7B1cYlSzV47FwzFDOTlSIMkDOtGn4f4TbU9M5ixtF8nnhyPZ9jbIXj4zlXlds1IWKDjO6X Cco5SXeVqmmaugfGUvrwE1io+3KYwT/dlwCq1fEuNHx20bHqYcIkFjTM3vb3/hAbRuJgahMYjjM YCVVvbyhgPhETlkWVQgNVAWySwvedKgdYsAySJ8bo6u9OK8bQJrG/sCKsPX4aeDI0juDH X-Received: by 2002:a05:620a:400b:b0:92e:4eca:6fb7 with SMTP id af79cd13be357-92e9a2f76d8mr34411985a.2.1783096859764; Fri, 03 Jul 2026 09:40:59 -0700 (PDT) X-Received: by 2002:a05:620a:400b:b0:92e:4eca:6fb7 with SMTP id af79cd13be357-92e9a2f76d8mr34406885a.2.1783096859108; Fri, 03 Jul 2026 09:40:59 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , Richard Henderson , qemu-s390x@nongnu.org, Xiaoyao Li , Zhao Liu , alex.bennee@linaro.org, Magnus Kulke , Peter Maydell , qemu-ppc@nongnu.org, Mohamed Mediouni , Paolo Bonzini Subject: [PATCH v2 24/33] gdbstub: Introduce GdbBreakpointType enumerator Date: Fri, 3 Jul 2026 18:37:47 +0200 Message-ID: <20260703163757.55500-25-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260703163757.55500-1-philmd@oss.qualcomm.com> References: <20260703163757.55500-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX7nmlv2DSMTdX ucfQYec4Dvmry9xwTRSmSxa2qYkK9S4ipa1pZRsonoj5bNtkkyosbhbXi1efLR2S16OZOsPFFji H71vtw5Wp0ifh3CGHNvKiEoozvqLE8fZ9hNVNowV9ybL9UoOH+L63V31CuFsvTnAuyv707RUqSj L6skdNFFMNw6RXNhy1FcV/NN9z7dgVlcp/Admw9uPdKFKixhEi0xhwdxNaCHQh9i2Oc2WFbhGgJ x+T+cCGp6ufd3eyp+bH2SKVzeJxCddLuxUnykKFotQT+99Zb25pKax/rxwZAs5FqmwDce8YNIWZ TOZE1p/7+I/L/EngkAi6B8mvLaxJHrf5WGG55BkeTXVAUyHTykGOhxFLvr7xW3hmrFnDGKq7FRQ KIzTBIbcDEz+beU4iMckfJmvRZj/XFt1jX0kOYBaOIOkiPZxsmhx00QK9M0dmMEAHRcXE8v3aa/ 9e13m3Zqz/fxdZxsDHQ== X-Authority-Analysis: v=2.4 cv=LeUMLDfi c=1 sm=1 tr=0 ts=6a47e61c cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=z_0bWbdd-CfuK1dINPUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: 8skOEh7gUSdHn5ZHGwmtkJol8gWW19sI X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX3F/f+KjEWSto RorzOYdlue8mOX7J+RpLpL12u5G7RzDOqBokjgygk56cKD6KmhiHgVSfSiyOEWHUxD7anavFJcy UrqAjPo9WhNpoNlqkWrnxJ+5LEOzIak= X-Proofpoint-GUID: 8skOEh7gUSdHn5ZHGwmtkJol8gWW19sI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 suspectscore=0 bulkscore=0 impostorscore=0 priorityscore=1501 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030164 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783096926200158500 Introduce the GdbBreakpointType enumerator to better follow code related to GDB protocol handling. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- gdbstub/internals.h | 7 +++++-- include/gdbstub/enums.h | 12 +++++++----- gdbstub/system.c | 6 ++++-- gdbstub/user.c | 6 ++++-- 4 files changed, 20 insertions(+), 11 deletions(-) diff --git a/gdbstub/internals.h b/gdbstub/internals.h index 0b74ea4000f..33f68672d1f 100644 --- a/gdbstub/internals.h +++ b/gdbstub/internals.h @@ -11,6 +11,7 @@ =20 #include "qemu/accel.h" #include "exec/cpu-common.h" +#include "gdbstub/enums.h" =20 /* * Most "large" transfers (e.g. memory reads, feature XML @@ -217,8 +218,10 @@ void gdb_syscall_handling(const char *syscall_packet); * Break/Watch point support - there is an implementation for system * and user mode. */ -int gdb_breakpoint_insert(CPUState *cs, int type, vaddr addr, vaddr len); -int gdb_breakpoint_remove(CPUState *cs, int type, vaddr addr, vaddr len); +int gdb_breakpoint_insert(CPUState *cs, GdbBreakpointType type, + vaddr addr, vaddr len); +int gdb_breakpoint_remove(CPUState *cs, GdbBreakpointType type, + vaddr addr, vaddr len); void gdb_breakpoint_remove_all(CPUState *cs); =20 /** diff --git a/include/gdbstub/enums.h b/include/gdbstub/enums.h index c4d54a1d083..e4e2043d92c 100644 --- a/include/gdbstub/enums.h +++ b/include/gdbstub/enums.h @@ -12,10 +12,12 @@ #define DEFAULT_GDBSTUB_PORT "1234" =20 /* GDB breakpoint/watchpoint types */ -#define GDB_BREAKPOINT_SW 0 -#define GDB_BREAKPOINT_HW 1 -#define GDB_WATCHPOINT_WRITE 2 -#define GDB_WATCHPOINT_READ 3 -#define GDB_WATCHPOINT_ACCESS 4 +typedef enum GdbBreakpointType { + GDB_BREAKPOINT_SW =3D 0, + GDB_BREAKPOINT_HW =3D 1, + GDB_WATCHPOINT_WRITE =3D 2, + GDB_WATCHPOINT_READ =3D 3, + GDB_WATCHPOINT_ACCESS =3D 4, +} GdbBreakpointType; =20 #endif /* GDBSTUB_ENUMS_H */ diff --git a/gdbstub/system.c b/gdbstub/system.c index 9c4bd8ebcba..6e2dbc823e3 100644 --- a/gdbstub/system.c +++ b/gdbstub/system.c @@ -623,7 +623,8 @@ int gdb_signal_to_target(int sig) * Break/Watch point helpers */ =20 -int gdb_breakpoint_insert(CPUState *cs, int type, vaddr addr, vaddr len) +int gdb_breakpoint_insert(CPUState *cs, GdbBreakpointType type, + vaddr addr, vaddr len) { const AccelOpsClass *ops =3D cpus_get_accel(); if (ops->insert_breakpoint) { @@ -632,7 +633,8 @@ int gdb_breakpoint_insert(CPUState *cs, int type, vaddr= addr, vaddr len) return -ENOSYS; } =20 -int gdb_breakpoint_remove(CPUState *cs, int type, vaddr addr, vaddr len) +int gdb_breakpoint_remove(CPUState *cs, GdbBreakpointType type, + vaddr addr, vaddr len) { const AccelOpsClass *ops =3D cpus_get_accel(); if (ops->remove_breakpoint) { diff --git a/gdbstub/user.c b/gdbstub/user.c index 90d6ee49fb5..9e6f9a6f376 100644 --- a/gdbstub/user.c +++ b/gdbstub/user.c @@ -790,7 +790,8 @@ unsigned int gdb_get_max_cpus(void) * Break/Watch point helpers */ =20 -int gdb_breakpoint_insert(CPUState *cs, int type, vaddr addr, vaddr len) +int gdb_breakpoint_insert(CPUState *cs, GdbBreakpointType type, + vaddr addr, vaddr len) { CPUState *cpu; int err =3D 0; @@ -811,7 +812,8 @@ int gdb_breakpoint_insert(CPUState *cs, int type, vaddr= addr, vaddr len) } } =20 -int gdb_breakpoint_remove(CPUState *cs, int type, vaddr addr, vaddr len) +int gdb_breakpoint_remove(CPUState *cs, GdbBreakpointType type, + vaddr addr, vaddr len) { CPUState *cpu; int err =3D 0; --=20 2.53.0 From nobody Sun Jul 26 11:01:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783096965; cv=none; d=zohomail.com; s=zohoarc; b=SgHhbN6QVSIyJ6A2Dz+C1i6wewRPBDV7vuzGU1qGcNQEAIJS/SO5jx0PZoFBc3IOkkxa8vfb/TqduRSsxfyR5zqdO1+x/mMhA8TU9ONnOdThg7z9VC/CQyBR+axhPWY6lJtp19xowEI8dAb3Ifg/Amizc9KGTaZlLnx2TvIi8ec= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783096965; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=WMuzKm4O8DnPBJteZs+7yYrCU+dLt8rT8REJEE7PWds=; b=ShsQC+c2u/ylwA3mFDfTQOS5NoeTrud+26j19JiJrpIu9QLI1zGeDfZJHzmyPdX1bpHYWQGXMB+7psj33+vd0+ePXaEU/E6w4CfaKspiV6p8D6hPuk7/sKMxRHX86XavA6l+6h10eNDOkxWEWHDUOWOanNYz+8ILmWXV98m7esU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783096965388161.70893925346434; Fri, 3 Jul 2026 09:42:45 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wfgx9-00053L-5I; Fri, 03 Jul 2026 12:41:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgx3-000509-5d for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:41:17 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgwv-0001VM-Vy for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:41:15 -0400 Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663GJ49g363357 for ; Fri, 3 Jul 2026 16:41:08 GMT Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f682bt67g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 16:41:08 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92da6f3cc81so89797385a.2 for ; Fri, 03 Jul 2026 09:41:08 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47a9de1e736sm678672f8f.7.2026.07.03.09.41.05 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 03 Jul 2026 09:41:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= WMuzKm4O8DnPBJteZs+7yYrCU+dLt8rT8REJEE7PWds=; b=A/nVMjJqW+aC+88K d4+nI0dWz8N2xG7i0cMrb/KOZYwGnU+lAuS4ebTP+3zU08kOjdrK9a7qTvYuoHy4 hdDKv4Zd6bG7NkHx+XV2bmW+U4TLwsKDRa+52mForJPcu275g7VUGllKYgGbyhk0 XJMvH4HYakk+qOtgTFLnDHsfvbcF8wTHoatXDXKjBej4v/qdIJrFn6fgu/LhCW+j vFyKChNpCCNCClop4LYaEz95HRPxzOs5PEVX42mxWX/15N4QZo90W6QDEOyTUlmU ddxVFqmPSOZCgz3guLRK1JElLhKXwpB4TTol+Le2uNw/YUKCNnRDBG6evQPhZQ/c Wx9cGQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783096867; x=1783701667; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=WMuzKm4O8DnPBJteZs+7yYrCU+dLt8rT8REJEE7PWds=; b=A/Lw52eDhT2Psi+A6iutcyd+2e9zTNxc6VAoOYtZgGsXJavtEPa8PJJPfw2Lqxru2g fu2HlbqKIqg1aHiGF/4eq6dAtP+8FTkAgPlbt7RNCatL1ovoxNbQH1RIpWE4SnQBJRD6 DUmHWwf5jIDATCt+cDJ53JKk2x20uTYugbRgGTciON0CVRCB0wpXRrLqO4Kt0Sg9wAxH kj+3yOhUbR/dqgk7+bPcvEozC2qYiOPQCcoEo7ZPoPTtwfrUuiSst6IUgFvnE2bsh4Hw zG/K4qnTGrLtdDcCI5InFFA0hGRqJWquwzEs28MJtjHYkZIx5/xHUJoenF3w7SCr2GmC N8rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783096867; x=1783701667; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=WMuzKm4O8DnPBJteZs+7yYrCU+dLt8rT8REJEE7PWds=; b=G75pX7/hy/UVQWlWZv3HOfks0JE05RtOSseWPf+lcCP2ZXy0joDQlI8xx7BqlllLkw 8Djc4/w2n1YzaMiGNdWS3f+x7XLZMghUfZOLfiSYAhAfqgOur0QapSbngrsOGiDRdMTP zD7YDlaLMBMzTAnHaFiuXQVx6hIdrSEm/Amett6pUuWrTR0S4L6YN9fPvs7ZYdqI229L XX1LF+yfC3V2TgYli++quy/ScQjlKL+V16WMYfvx7vf6pg/TGgJ+UjeqMfTLRCiapJoX E1pp9iJJ0fyZCyy3NnlwJdmJFNyldFRuYtmPpFD1sEg+JPe7aWbf/68LXG313GcyNWyh fo9g== X-Gm-Message-State: AOJu0YxnuA/efH7Y9MHKcswhfwmcmkod1Mza4E2TUusvc9dnr+Tqo0iF keRGN0vKKM2gKIr9f45A1CH4God853mHOf761s6hz4zGfs6xR+4CjXJYytqZkcgLvDCu30akHpX 5ue++ImEbWHt4oL9ZgDoxRc0zuYvlOYDzSIaARTmQRm6uKYNkbQjhDXqIj1WuJnZy7Q== X-Gm-Gg: AfdE7cmt+HHulS6u4bcImmoyODRALe6GJMu8sMwKaYwXRrTe26QsvehJjIP1yH+LRbC LMtRODXfFdtVcTZndGtQT1HSaM4e/WNd/ywQzg9mGklvPUBGh5KvkmhYbccZRI2EG4JF5jJUWHz iOd7nSyDdbEHEN39tga8zWhIOvA8Fvid92UluNdWgaBIEvgFkVDZHAMM/TTmCgyEJ939HwN9iDt nt2QimI4IgkaacrG83PfmM2GZnqtD5de5zRrGhDv5iR2gmw2pyazE6bqZQQCq/ctophnH0U+Q4H Kv/eEV1l5zwGFrGO0Fzn5P69R59xGyIZwRTLkA2tMAR5lV2KfNUwsenohI9X8soxqS6zm0fl42Y sxC1QAYrWJ5e/j3TwIKNrPT2jieMGWaRsyzKUQVToHetHOvuWy+vLzX5X5Vzflgi9N+2t X-Received: by 2002:a05:620a:27c1:b0:925:4655:a89b with SMTP id af79cd13be357-92e9a3af2e2mr27876785a.27.1783096867106; Fri, 03 Jul 2026 09:41:07 -0700 (PDT) X-Received: by 2002:a05:620a:27c1:b0:925:4655:a89b with SMTP id af79cd13be357-92e9a3af2e2mr27870985a.27.1783096866495; Fri, 03 Jul 2026 09:41:06 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , Richard Henderson , qemu-s390x@nongnu.org, Xiaoyao Li , Zhao Liu , alex.bennee@linaro.org, Magnus Kulke , Peter Maydell , qemu-ppc@nongnu.org, Mohamed Mediouni , Paolo Bonzini Subject: [PATCH v2 25/33] accel: Use GdbBreakpointType enum Date: Fri, 3 Jul 2026 18:37:48 +0200 Message-ID: <20260703163757.55500-26-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260703163757.55500-1-philmd@oss.qualcomm.com> References: <20260703163757.55500-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX1NmwyaDzQqtF 2kzcaUUKFM9XiJxOh1puTBpSwe7VNDuhwOvzEqHEUxGPEU2H1muKSIYd++eYTuZIOXC4zcbFnyW o52J8Xm77ofTWgX+WeI+jlqHEC9hHnJNHC0Whz7OjwVmL4Z5sYFoi7aVEd4gvvXjp4VsbRRcEGu y9z/upSThSqMdCbHaSTw78eSXtg1twxNbWa0T9FQ87fPsNKHSdwRoWIc20HWVerwRmpKFyXdzGI vxcnDX1msmnclD2Md7QCpNUN4XrPNnK8ISFJ04KC9I3xT5oGQ1BNkymOE1+cxti5Pq+rOe35CrP un9z4nUK7fbcpGPNlK7N91/0sgTETfc/UreFI3cTyPFIHsbhQIOV1QwZXj1q/l9XUNNsZ0D2Nqy EslDFS2WDOfIvTKFfmCV+iBl4yRB8bbkN4hd0NYMTZnxHh4EGsA6RkVLp4EhAEtOrI2hL1GdKb1 0ZIZvPWL52Om8cs3AOQ== X-Proofpoint-ORIG-GUID: xQAG_7oetUKo609VGo4F4GIX_xJEcOeK X-Authority-Analysis: v=2.4 cv=cc3iaHDM c=1 sm=1 tr=0 ts=6a47e624 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=j3PXfpA4_7De4rqNWBgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=O8hF6Hzn-FEA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX3gzJPKzQRerT xISjzGfrxEgCgxJJKdPzOztQZaoZXeUVjtGmbmd6jq7aGHIC8k7JECS5UqETYhiShI1cD5gDE0K XxHib0JuQr/No73oENTkHBNj99fjbA8= X-Proofpoint-GUID: xQAG_7oetUKo609VGo4F4GIX_xJEcOeK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 adultscore=0 bulkscore=0 priorityscore=1501 phishscore=0 spamscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030164 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783096966392158500 Include '_gdbstub_' in the AccelOpsClass handlers to emphasize we are handling gdbstub-related requests. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- accel/kvm/kvm-cpus.h | 11 ++++++++--- include/accel/accel-cpu-ops.h | 9 ++++++--- include/system/hvf_int.h | 9 ++++++--- include/system/kvm.h | 9 ++++++--- target/arm/internals.h | 5 +++-- accel/hvf/hvf-accel-ops.c | 20 +++++++++++--------- accel/kvm/kvm-accel-ops.c | 6 +++--- accel/kvm/kvm-all.c | 14 ++++++++------ accel/tcg/tcg-accel-ops.c | 17 ++++++++++------- gdbstub/system.c | 12 ++++++------ target/arm/hvf/hvf.c | 12 +++++++----- target/arm/hyp_gdbstub.c | 8 ++++---- target/arm/kvm.c | 12 +++++++----- target/i386/hvf/hvf.c | 8 +++++--- target/i386/kvm/kvm.c | 12 +++++++----- target/loongarch/kvm/kvm.c | 8 +++++--- target/ppc/kvm.c | 12 +++++++----- target/riscv/kvm/kvm-cpu.c | 8 +++++--- target/s390x/kvm/kvm.c | 8 +++++--- 19 files changed, 119 insertions(+), 81 deletions(-) diff --git a/accel/kvm/kvm-cpus.h b/accel/kvm/kvm-cpus.h index 3185659562d..bc2dd82e68e 100644 --- a/accel/kvm/kvm-cpus.h +++ b/accel/kvm/kvm-cpus.h @@ -10,13 +10,18 @@ #ifndef KVM_CPUS_H #define KVM_CPUS_H =20 +#include "gdbstub/enums.h" + int kvm_init_vcpu(CPUState *cpu, Error **errp); int kvm_cpu_exec(CPUState *cpu); void kvm_destroy_vcpu(CPUState *cpu); void kvm_cpu_synchronize_post_reset(CPUState *cpu); void kvm_cpu_synchronize_post_init(CPUState *cpu); void kvm_cpu_synchronize_pre_loadvm(CPUState *cpu); -int kvm_insert_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len); -int kvm_remove_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len); -void kvm_remove_all_breakpoints(CPUState *cpu); +int kvm_insert_gdbstub_breakpoint(CPUState *cpu, GdbBreakpointType type, + vaddr addr, vaddr len); +int kvm_remove_gdbstub_breakpoint(CPUState *cpu, GdbBreakpointType type, + vaddr addr, vaddr len); +void kvm_remove_all_gdbstub_breakpoints(CPUState *cpu); + #endif /* KVM_CPUS_H */ diff --git a/include/accel/accel-cpu-ops.h b/include/accel/accel-cpu-ops.h index b23a0606c7e..f0c7ee7542c 100644 --- a/include/accel/accel-cpu-ops.h +++ b/include/accel/accel-cpu-ops.h @@ -13,6 +13,7 @@ #include "qemu/accel.h" #include "exec/vaddr.h" #include "qom/object.h" +#include "gdbstub/enums.h" =20 #define ACCEL_OPS_SUFFIX "-ops" #define TYPE_ACCEL_OPS "accel" ACCEL_OPS_SUFFIX @@ -85,9 +86,11 @@ struct AccelOpsClass { =20 /* gdbstub hooks */ int (*update_guest_debug)(CPUState *cpu); - int (*insert_breakpoint)(CPUState *cpu, int type, vaddr addr, vaddr le= n); - int (*remove_breakpoint)(CPUState *cpu, int type, vaddr addr, vaddr le= n); - void (*remove_all_breakpoints)(CPUState *cpu); + int (*insert_gdbstub_breakpoint)(CPUState *cpu, GdbBreakpointType type, + vaddr addr, vaddr len); + int (*remove_gdbstub_breakpoint)(CPUState *cpu, GdbBreakpointType type, + vaddr addr, vaddr len); + void (*remove_all_gdbstub_breakpoints)(CPUState *cpu); }; =20 void generic_handle_interrupt(CPUState *cpu, int mask); diff --git a/include/system/hvf_int.h b/include/system/hvf_int.h index d64f4942556..a01691ce172 100644 --- a/include/system/hvf_int.h +++ b/include/system/hvf_int.h @@ -13,6 +13,7 @@ =20 #include "qemu/queue.h" #include "exec/vaddr.h" +#include "gdbstub/enums.h" #include "qom/object.h" #include "accel/accel-ops.h" =20 @@ -91,9 +92,11 @@ int hvf_sw_breakpoints_active(CPUState *cpu); =20 int hvf_arch_insert_sw_breakpoint(CPUState *cpu, struct hvf_sw_breakpoint = *bp); int hvf_arch_remove_sw_breakpoint(CPUState *cpu, struct hvf_sw_breakpoint = *bp); -int hvf_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type); -int hvf_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type); -void hvf_arch_remove_all_hw_breakpoints(void); +int hvf_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type); +int hvf_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type); +void hvf_arch_remove_all_gdbstub_hw_breakpoints(void); =20 /* * hvf_update_guest_debug: diff --git a/include/system/kvm.h b/include/system/kvm.h index cdd1856ac5f..714b8c7b011 100644 --- a/include/system/kvm.h +++ b/include/system/kvm.h @@ -17,6 +17,7 @@ #define QEMU_KVM_H =20 #include "exec/memattrs.h" +#include "gdbstub/enums.h" #include "qemu/accel.h" #include "accel/accel-route.h" #include "qom/object.h" @@ -412,9 +413,11 @@ int kvm_arch_insert_sw_breakpoint(CPUState *cpu, struct kvm_sw_breakpoint *bp); int kvm_arch_remove_sw_breakpoint(CPUState *cpu, struct kvm_sw_breakpoint *bp); -int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type); -int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type); -void kvm_arch_remove_all_hw_breakpoints(void); +int kvm_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type); +int kvm_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type); +void kvm_arch_remove_all_gdbstub_hw_breakpoints(void); =20 void kvm_arch_update_guest_debug(CPUState *cpu, struct kvm_guest_debug *db= g); =20 diff --git a/target/arm/internals.h b/target/arm/internals.h index fcce3804f34..067c3f2b8bb 100644 --- a/target/arm/internals.h +++ b/target/arm/internals.h @@ -29,6 +29,7 @@ #include "exec/vaddr.h" #include "exec/breakpoint.h" #include "exec/memop.h" +#include "gdbstub/enums.h" #ifdef CONFIG_TCG #include "accel/tcg/tb-cpu-state.h" #include "tcg/tcg-gvec-desc.h" @@ -1968,8 +1969,8 @@ int delete_hw_breakpoint(vaddr pc); =20 bool check_watchpoint_in_range(int i, vaddr addr); CPUWatchpoint *find_hw_watchpoint(CPUState *cpu, vaddr addr); -int insert_hw_watchpoint(vaddr addr, vaddr len, int type); -int delete_hw_watchpoint(vaddr addr, vaddr len, int type); +int insert_gdbstub_hw_watchpoint(vaddr addr, vaddr len, GdbBreakpointType = type); +int delete_gdbstub_hw_watchpoint(vaddr addr, vaddr len, GdbBreakpointType = type); =20 /* Return the current value of the system counter in ticks */ uint64_t gt_get_countervalue(CPUARMState *env); diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-ops.c index ecc0cd1b558..d2276d8513e 100644 --- a/accel/hvf/hvf-accel-ops.c +++ b/accel/hvf/hvf-accel-ops.c @@ -233,7 +233,8 @@ int hvf_update_guest_debug(CPUState *cpu) return 0; } =20 -static int hvf_insert_breakpoint(CPUState *cpu, int type, vaddr addr, vadd= r len) +static int hvf_insert_gdbstub_breakpoint(CPUState *cpu, GdbBreakpointType = type, + vaddr addr, vaddr len) { struct hvf_sw_breakpoint *bp; int err; @@ -256,7 +257,7 @@ static int hvf_insert_breakpoint(CPUState *cpu, int typ= e, vaddr addr, vaddr len) =20 QTAILQ_INSERT_HEAD(&hvf_state->hvf_sw_breakpoints, bp, entry); } else { - err =3D hvf_arch_insert_hw_breakpoint(addr, len, type); + err =3D hvf_arch_insert_gdbstub_hw_breakpoint(addr, len, type); if (err) { return err; } @@ -271,7 +272,8 @@ static int hvf_insert_breakpoint(CPUState *cpu, int typ= e, vaddr addr, vaddr len) return 0; } =20 -static int hvf_remove_breakpoint(CPUState *cpu, int type, vaddr addr, vadd= r len) +static int hvf_remove_gdbstub_breakpoint(CPUState *cpu, GdbBreakpointType = type, + vaddr addr, vaddr len) { struct hvf_sw_breakpoint *bp; int err; @@ -295,7 +297,7 @@ static int hvf_remove_breakpoint(CPUState *cpu, int typ= e, vaddr addr, vaddr len) QTAILQ_REMOVE(&hvf_state->hvf_sw_breakpoints, bp, entry); g_free(bp); } else { - err =3D hvf_arch_remove_hw_breakpoint(addr, len, type); + err =3D hvf_arch_remove_gdbstub_hw_breakpoint(addr, len, type); if (err) { return err; } @@ -310,7 +312,7 @@ static int hvf_remove_breakpoint(CPUState *cpu, int typ= e, vaddr addr, vaddr len) return 0; } =20 -static void hvf_remove_all_breakpoints(CPUState *cpu) +static void hvf_remove_all_gdbstub_breakpoints(CPUState *cpu) { struct hvf_sw_breakpoint *bp, *next; CPUState *tmpcpu; @@ -328,7 +330,7 @@ static void hvf_remove_all_breakpoints(CPUState *cpu) QTAILQ_REMOVE(&hvf_state->hvf_sw_breakpoints, bp, entry); g_free(bp); } - hvf_arch_remove_all_hw_breakpoints(); + hvf_arch_remove_all_gdbstub_hw_breakpoints(); =20 CPU_FOREACH(cpu) { hvf_update_guest_debug(cpu); @@ -365,9 +367,9 @@ static void hvf_accel_ops_class_init(ObjectClass *oc, c= onst void *data) ops->synchronize_state =3D hvf_cpu_synchronize_state; ops->synchronize_pre_loadvm =3D hvf_cpu_synchronize_pre_loadvm; =20 - ops->insert_breakpoint =3D hvf_insert_breakpoint; - ops->remove_breakpoint =3D hvf_remove_breakpoint; - ops->remove_all_breakpoints =3D hvf_remove_all_breakpoints; + ops->insert_gdbstub_breakpoint =3D hvf_insert_gdbstub_breakpoint; + ops->remove_gdbstub_breakpoint =3D hvf_remove_gdbstub_breakpoint; + ops->remove_all_gdbstub_breakpoints =3D hvf_remove_all_gdbstub_breakpo= ints; ops->update_guest_debug =3D hvf_update_guest_debug; =20 ops->get_vcpu_stats =3D hvf_get_vcpu_stats; diff --git a/accel/kvm/kvm-accel-ops.c b/accel/kvm/kvm-accel-ops.c index 45330327909..c8e7aa38709 100644 --- a/accel/kvm/kvm-accel-ops.c +++ b/accel/kvm/kvm-accel-ops.c @@ -107,9 +107,9 @@ static void kvm_accel_ops_class_init(ObjectClass *oc, c= onst void *data) =20 #ifdef TARGET_KVM_HAVE_GUEST_DEBUG ops->update_guest_debug =3D kvm_update_guest_debug_ops; - ops->insert_breakpoint =3D kvm_insert_breakpoint; - ops->remove_breakpoint =3D kvm_remove_breakpoint; - ops->remove_all_breakpoints =3D kvm_remove_all_breakpoints; + ops->insert_gdbstub_breakpoint =3D kvm_insert_gdbstub_breakpoint; + ops->remove_gdbstub_breakpoint =3D kvm_remove_gdbstub_breakpoint; + ops->remove_all_gdbstub_breakpoints =3D kvm_remove_all_gdbstub_breakpo= ints; #endif } =20 diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index b03488ebac3..feffca0d82d 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -3826,7 +3826,8 @@ int kvm_update_guest_debug(CPUState *cpu, unsigned lo= ng reinject_trap) return data.err; } =20 -int kvm_insert_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len) +int kvm_insert_gdbstub_breakpoint(CPUState *cpu, GdbBreakpointType type, + vaddr addr, vaddr len) { struct kvm_sw_breakpoint *bp; int err; @@ -3849,7 +3850,7 @@ int kvm_insert_breakpoint(CPUState *cpu, int type, va= ddr addr, vaddr len) =20 QTAILQ_INSERT_HEAD(&cpu->kvm_state->kvm_sw_breakpoints, bp, entry); } else { - err =3D kvm_arch_insert_hw_breakpoint(addr, len, type); + err =3D kvm_arch_insert_gdbstub_hw_breakpoint(addr, len, type); if (err) { return err; } @@ -3864,7 +3865,8 @@ int kvm_insert_breakpoint(CPUState *cpu, int type, va= ddr addr, vaddr len) return 0; } =20 -int kvm_remove_breakpoint(CPUState *cpu, int type, vaddr addr, vaddr len) +int kvm_remove_gdbstub_breakpoint(CPUState *cpu, GdbBreakpointType type, + vaddr addr, vaddr len) { struct kvm_sw_breakpoint *bp; int err; @@ -3888,7 +3890,7 @@ int kvm_remove_breakpoint(CPUState *cpu, int type, va= ddr addr, vaddr len) QTAILQ_REMOVE(&cpu->kvm_state->kvm_sw_breakpoints, bp, entry); g_free(bp); } else { - err =3D kvm_arch_remove_hw_breakpoint(addr, len, type); + err =3D kvm_arch_remove_gdbstub_hw_breakpoint(addr, len, type); if (err) { return err; } @@ -3903,7 +3905,7 @@ int kvm_remove_breakpoint(CPUState *cpu, int type, va= ddr addr, vaddr len) return 0; } =20 -void kvm_remove_all_breakpoints(CPUState *cpu) +void kvm_remove_all_gdbstub_breakpoints(CPUState *cpu) { struct kvm_sw_breakpoint *bp, *next; KVMState *s =3D cpu->kvm_state; @@ -3921,7 +3923,7 @@ void kvm_remove_all_breakpoints(CPUState *cpu) QTAILQ_REMOVE(&s->kvm_sw_breakpoints, bp, entry); g_free(bp); } - kvm_arch_remove_all_hw_breakpoints(); + kvm_arch_remove_all_gdbstub_hw_breakpoints(); =20 CPU_FOREACH(cpu) { kvm_update_guest_debug(cpu, 0); diff --git a/accel/tcg/tcg-accel-ops.c b/accel/tcg/tcg-accel-ops.c index c54acc770e3..028265c2efd 100644 --- a/accel/tcg/tcg-accel-ops.c +++ b/accel/tcg/tcg-accel-ops.c @@ -110,7 +110,8 @@ void tcg_handle_interrupt(CPUState *cpu, int mask) } =20 /* Translate GDB watchpoint type to a flags value for cpu_watchpoint_* */ -static inline BreakpointFlags xlat_gdb_type(CPUState *cpu, int gdbtype) +static inline BreakpointFlags xlat_gdb_type(CPUState *cpu, + GdbBreakpointType gdbtype) { static const BreakpointFlags xlat[] =3D { [GDB_WATCHPOINT_WRITE] =3D BP_GDB | BP_MEM_WRITE, @@ -126,7 +127,8 @@ static inline BreakpointFlags xlat_gdb_type(CPUState *c= pu, int gdbtype) return cpuflags; } =20 -static int tcg_insert_breakpoint(CPUState *cs, int type, vaddr addr, vaddr= len) +static int tcg_insert_gdbstub_breakpoint(CPUState *cs, GdbBreakpointType t= ype, + vaddr addr, vaddr len) { CPUState *cpu; int err =3D 0; @@ -157,7 +159,8 @@ static int tcg_insert_breakpoint(CPUState *cs, int type= , vaddr addr, vaddr len) } } =20 -static int tcg_remove_breakpoint(CPUState *cs, int type, vaddr addr, vaddr= len) +static int tcg_remove_gdbstub_breakpoint(CPUState *cs, GdbBreakpointType t= ype, + vaddr addr, vaddr len) { CPUState *cpu; int err =3D 0; @@ -188,7 +191,7 @@ static int tcg_remove_breakpoint(CPUState *cs, int type= , vaddr addr, vaddr len) } } =20 -static void tcg_remove_all_breakpoints(CPUState *cpu) +static void tcg_remove_all_gdbstub_breakpoints(CPUState *cpu) { cpu_breakpoint_remove_all(cpu, BP_GDB); cpu_watchpoint_remove_all(cpu, BP_GDB); @@ -216,9 +219,9 @@ static void tcg_accel_ops_init(AccelClass *ac) } =20 ops->cpu_reset_hold =3D tcg_cpu_reset_hold; - ops->insert_breakpoint =3D tcg_insert_breakpoint; - ops->remove_breakpoint =3D tcg_remove_breakpoint; - ops->remove_all_breakpoints =3D tcg_remove_all_breakpoints; + ops->insert_gdbstub_breakpoint =3D tcg_insert_gdbstub_breakpoint; + ops->remove_gdbstub_breakpoint =3D tcg_remove_gdbstub_breakpoint; + ops->remove_all_gdbstub_breakpoints =3D tcg_remove_all_gdbstub_breakpo= ints; } =20 static void tcg_accel_ops_class_init(ObjectClass *oc, const void *data) diff --git a/gdbstub/system.c b/gdbstub/system.c index 6e2dbc823e3..3098fd55740 100644 --- a/gdbstub/system.c +++ b/gdbstub/system.c @@ -627,8 +627,8 @@ int gdb_breakpoint_insert(CPUState *cs, GdbBreakpointTy= pe type, vaddr addr, vaddr len) { const AccelOpsClass *ops =3D cpus_get_accel(); - if (ops->insert_breakpoint) { - return ops->insert_breakpoint(cs, type, addr, len); + if (ops->insert_gdbstub_breakpoint) { + return ops->insert_gdbstub_breakpoint(cs, type, addr, len); } return -ENOSYS; } @@ -637,8 +637,8 @@ int gdb_breakpoint_remove(CPUState *cs, GdbBreakpointTy= pe type, vaddr addr, vaddr len) { const AccelOpsClass *ops =3D cpus_get_accel(); - if (ops->remove_breakpoint) { - return ops->remove_breakpoint(cs, type, addr, len); + if (ops->remove_gdbstub_breakpoint) { + return ops->remove_gdbstub_breakpoint(cs, type, addr, len); } return -ENOSYS; } @@ -646,8 +646,8 @@ int gdb_breakpoint_remove(CPUState *cs, GdbBreakpointTy= pe type, void gdb_breakpoint_remove_all(CPUState *cs) { const AccelOpsClass *ops =3D cpus_get_accel(); - if (ops->remove_all_breakpoints) { - ops->remove_all_breakpoints(cs); + if (ops->remove_all_gdbstub_breakpoints) { + ops->remove_all_gdbstub_breakpoints(cs); } } =20 diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index e16457c3cfb..d5b1966a867 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -2726,7 +2726,8 @@ int hvf_arch_remove_sw_breakpoint(CPUState *cpu, stru= ct hvf_sw_breakpoint *bp) return 0; } =20 -int hvf_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type) +int hvf_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { switch (type) { case GDB_BREAKPOINT_HW: @@ -2734,13 +2735,14 @@ int hvf_arch_insert_hw_breakpoint(vaddr addr, vaddr= len, int type) case GDB_WATCHPOINT_READ: case GDB_WATCHPOINT_WRITE: case GDB_WATCHPOINT_ACCESS: - return insert_hw_watchpoint(addr, len, type); + return insert_gdbstub_hw_watchpoint(addr, len, type); default: return -ENOSYS; } } =20 -int hvf_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type) +int hvf_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { switch (type) { case GDB_BREAKPOINT_HW: @@ -2748,13 +2750,13 @@ int hvf_arch_remove_hw_breakpoint(vaddr addr, vaddr= len, int type) case GDB_WATCHPOINT_READ: case GDB_WATCHPOINT_WRITE: case GDB_WATCHPOINT_ACCESS: - return delete_hw_watchpoint(addr, len, type); + return delete_gdbstub_hw_watchpoint(addr, len, type); default: return -ENOSYS; } } =20 -void hvf_arch_remove_all_hw_breakpoints(void) +void hvf_arch_remove_all_gdbstub_hw_breakpoints(void) { if (cur_hw_wps > 0) { g_array_remove_range(hw_watchpoints, 0, cur_hw_wps); diff --git a/target/arm/hyp_gdbstub.c b/target/arm/hyp_gdbstub.c index bb5969720ce..dda6946ddaa 100644 --- a/target/arm/hyp_gdbstub.c +++ b/target/arm/hyp_gdbstub.c @@ -94,7 +94,7 @@ int delete_hw_breakpoint(vaddr pc) } =20 /** - * insert_hw_watchpoint() + * insert_gdbstub_hw_watchpoint() * @addr: address of watch point * @len: size of area * @type: type of watch point @@ -125,7 +125,7 @@ int delete_hw_breakpoint(vaddr pc) * need to ensure you mask the address as required and set BAS=3D0xff */ =20 -int insert_hw_watchpoint(vaddr addr, vaddr len, int type) +int insert_gdbstub_hw_watchpoint(vaddr addr, vaddr len, GdbBreakpointType = type) { HWWatchpoint wp =3D { .wcr =3D R_DBGWCR_E_MASK, /* E=3D1, enable */ @@ -208,13 +208,13 @@ bool check_watchpoint_in_range(int i, vaddr addr) } =20 /** - * delete_hw_watchpoint() + * delete_gdbstub_hw_watchpoint() * @addr: address of breakpoint * * Delete a breakpoint and shuffle any above down */ =20 -int delete_hw_watchpoint(vaddr addr, vaddr len, int type) +int delete_gdbstub_hw_watchpoint(vaddr addr, vaddr len, GdbBreakpointType = type) { int i; for (i =3D 0; i < cur_hw_wps; i++) { diff --git a/target/arm/kvm.c b/target/arm/kvm.c index a54ef51ec2a..01f42f42538 100644 --- a/target/arm/kvm.c +++ b/target/arm/kvm.c @@ -1784,7 +1784,8 @@ void kvm_arch_accel_class_init(ObjectClass *oc) "Eager Page Split chunk size for hugepages. (default: 0, disabled)= "); } =20 -int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { switch (type) { case GDB_BREAKPOINT_HW: @@ -1793,13 +1794,14 @@ int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr= len, int type) case GDB_WATCHPOINT_READ: case GDB_WATCHPOINT_WRITE: case GDB_WATCHPOINT_ACCESS: - return insert_hw_watchpoint(addr, len, type); + return insert_gdbstub_hw_watchpoint(addr, len, type); default: return -ENOSYS; } } =20 -int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { switch (type) { case GDB_BREAKPOINT_HW: @@ -1807,13 +1809,13 @@ int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr= len, int type) case GDB_WATCHPOINT_READ: case GDB_WATCHPOINT_WRITE: case GDB_WATCHPOINT_ACCESS: - return delete_hw_watchpoint(addr, len, type); + return delete_gdbstub_hw_watchpoint(addr, len, type); default: return -ENOSYS; } } =20 -void kvm_arch_remove_all_hw_breakpoints(void) +void kvm_arch_remove_all_gdbstub_hw_breakpoints(void) { if (cur_hw_wps > 0) { g_array_remove_range(hw_watchpoints, 0, cur_hw_wps); diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c index 19ad64a1d93..150598418e2 100644 --- a/target/i386/hvf/hvf.c +++ b/target/i386/hvf/hvf.c @@ -1049,17 +1049,19 @@ int hvf_arch_remove_sw_breakpoint(CPUState *cpu, st= ruct hvf_sw_breakpoint *bp) return -ENOSYS; } =20 -int hvf_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type) +int hvf_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { return -ENOSYS; } =20 -int hvf_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type) +int hvf_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { return -ENOSYS; } =20 -void hvf_arch_remove_all_hw_breakpoints(void) +void hvf_arch_remove_all_gdbstub_hw_breakpoints(void) { } =20 diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c index 64cc421abe6..1e09155e92c 100644 --- a/target/i386/kvm/kvm.c +++ b/target/i386/kvm/kvm.c @@ -6159,12 +6159,12 @@ int kvm_arch_remove_sw_breakpoint(CPUState *cs, str= uct kvm_sw_breakpoint *bp) static struct { target_ulong addr; int len; - int type; + GdbBreakpointType type; } hw_breakpoint[4]; =20 static int nb_hw_breakpoint; =20 -static int find_hw_breakpoint(target_ulong addr, int len, int type) +static int find_hw_breakpoint(target_ulong addr, int len, GdbBreakpointTyp= e type) { int n; =20 @@ -6177,7 +6177,8 @@ static int find_hw_breakpoint(target_ulong addr, int = len, int type) return -1; } =20 -int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { switch (type) { case GDB_BREAKPOINT_HW: @@ -6217,7 +6218,8 @@ int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr l= en, int type) return 0; } =20 -int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { int n; =20 @@ -6231,7 +6233,7 @@ int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr l= en, int type) return 0; } =20 -void kvm_arch_remove_all_hw_breakpoints(void) +void kvm_arch_remove_all_gdbstub_hw_breakpoints(void) { nb_hw_breakpoint =3D 0; } diff --git a/target/loongarch/kvm/kvm.c b/target/loongarch/kvm/kvm.c index d6539c12acd..beda6965f8c 100644 --- a/target/loongarch/kvm/kvm.c +++ b/target/loongarch/kvm/kvm.c @@ -1418,17 +1418,19 @@ int kvm_arch_remove_sw_breakpoint(CPUState *cs, str= uct kvm_sw_breakpoint *bp) return 0; } =20 -int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { return -ENOSYS; } =20 -int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { return -ENOSYS; } =20 -void kvm_arch_remove_all_hw_breakpoints(void) +void kvm_arch_remove_all_gdbstub_hw_breakpoints(void) { } =20 diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index 2a3711fb1df..6bdfbbd68d6 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -455,7 +455,7 @@ unsigned long kvm_arch_vcpu_id(CPUState *cpu) =20 static struct HWBreakpoint { target_ulong addr; - int type; + GdbBreakpointType type; } hw_debug_points[MAX_HW_BKPTS]; =20 static CPUWatchpoint hw_watchpoint; @@ -1412,7 +1412,7 @@ int kvm_arch_remove_sw_breakpoint(CPUState *cs, struc= t kvm_sw_breakpoint *bp) return 0; } =20 -static int find_hw_breakpoint(target_ulong addr, int type) +static int find_hw_breakpoint(target_ulong addr, GdbBreakpointType type) { int n; =20 @@ -1454,7 +1454,8 @@ static int find_hw_watchpoint(target_ulong addr, Brea= kpointFlags *flag) return -1; } =20 -int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { const unsigned breakpoint_index =3D nb_hw_breakpoint + nb_hw_watchpoin= t; if (breakpoint_index >=3D ARRAY_SIZE(hw_debug_points)) { @@ -1498,7 +1499,8 @@ int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr l= en, int type) return 0; } =20 -int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { int n; =20 @@ -1526,7 +1528,7 @@ int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr l= en, int type) return 0; } =20 -void kvm_arch_remove_all_hw_breakpoints(void) +void kvm_arch_remove_all_gdbstub_hw_breakpoints(void) { nb_hw_breakpoint =3D nb_hw_watchpoint =3D 0; } diff --git a/target/riscv/kvm/kvm-cpu.c b/target/riscv/kvm/kvm-cpu.c index 39d48a9db4d..2a5440d5846 100644 --- a/target/riscv/kvm/kvm-cpu.c +++ b/target/riscv/kvm/kvm-cpu.c @@ -2215,19 +2215,21 @@ int kvm_arch_remove_sw_breakpoint(CPUState *cs, str= uct kvm_sw_breakpoint *bp) return 0; } =20 -int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { /* TODO; To be implemented later. */ return -EINVAL; } =20 -int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { /* TODO; To be implemented later. */ return -EINVAL; } =20 -void kvm_arch_remove_all_hw_breakpoints(void) +void kvm_arch_remove_all_gdbstub_hw_breakpoints(void) { /* TODO; To be implemented later. */ } diff --git a/target/s390x/kvm/kvm.c b/target/s390x/kvm/kvm.c index fdef8f9e8ac..195e39df032 100644 --- a/target/s390x/kvm/kvm.c +++ b/target/s390x/kvm/kvm.c @@ -907,7 +907,8 @@ static int insert_hw_breakpoint(vaddr addr, int len, in= t type) return 0; } =20 -int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_insert_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { switch (type) { case GDB_BREAKPOINT_HW: @@ -925,7 +926,8 @@ int kvm_arch_insert_hw_breakpoint(vaddr addr, vaddr len= , int type) return insert_hw_breakpoint(addr, len, type); } =20 -int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type) +int kvm_arch_remove_gdbstub_hw_breakpoint(vaddr addr, vaddr len, + GdbBreakpointType type) { int size; struct kvm_hw_breakpoint *bp =3D find_hw_breakpoint(addr, len, type); @@ -954,7 +956,7 @@ int kvm_arch_remove_hw_breakpoint(vaddr addr, vaddr len= , int type) return 0; } =20 -void kvm_arch_remove_all_hw_breakpoints(void) +void kvm_arch_remove_all_gdbstub_hw_breakpoints(void) { nb_hw_breakpoints =3D 0; g_free(hw_breakpoints); --=20 2.53.0 From nobody Sun Jul 26 11:01:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783096976; cv=none; d=zohomail.com; s=zohoarc; b=loVNdJBa9rh/3hreZwBFIsh6j02p/XE1SGblaIF3e48ig7A30egdPBmn3vzMhxFhjfiwgFVRb3pjZrKRmnXNtJUFRNZJ/RYTtAEHoH8AxU6g9EfWR8ET8IrE2fSP2z+/o+qjub/iDTnVefB79muBZtkNZa8zx/TpH+RrIDHaFko= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783096976; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=0zxOegtK9/HXZJNp7+v9NFHsGRS7+LXc2HkX7d76Edg=; b=HCF8351LDd8m1EYuDlGjJKfPSdvss/mWgiGKMSAVK7cKS/jTwT8ZPkFCCiuVUoks2cRvaSKA7DuPunWczODwKtT4Go5EZROgYPnRWvSZ8WpyPk1Yyrabua1vcu6W0zvQ1JjSqlrZV/9y43wp+ygndFiUV0ItgbknNaCQxcsWuLQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783096976621433.03811551929437; Fri, 3 Jul 2026 09:42:56 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wfgx9-00054c-L4; Fri, 03 Jul 2026 12:41:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgx7-00051x-4w for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:41:21 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgx3-0001Ye-Aq for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:41:20 -0400 Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663GIhrf364553 for ; Fri, 3 Jul 2026 16:41:15 GMT Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f67j02akk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 16:41:15 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-92e66f9e2baso74316285a.0 for ; Fri, 03 Jul 2026 09:41:15 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa0a558easm584500f8f.27.2026.07.03.09.41.12 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 03 Jul 2026 09:41:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0zxOegtK9/HXZJNp7+v9NFHsGRS7+LXc2HkX7d76Edg=; b=WZVCgSud7j3Cj98c FFWXaF1igXjqooF17+6p7IsvjlodiN8fuATRe7mgMnY3XraJfSA30kklsSceOmzn 4uZzV/iV04g/pDdpfZittNMnRXx2r8roeucRSF3SdX6MA/MN7yaObAn1MOyZKoM4 jjFjXfNce6etY+INxyIm/1tlv7cGI3bFXndx3aYcZoVzmw4pJk+j98/dbr+/FWfQ cWKDXg1KJJDp7jQq4QKOcYimoKvd8t+BhA8TERqL4PRB1OgtbSSL8PeRz5vXc4hf 2G0vLZR5/wJDSNRacSTEFRdPaqXoPe0nZNtosDQ4kHUAZGHT4TjEmXWJ3KB4CDll oXXDAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783096874; x=1783701674; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=0zxOegtK9/HXZJNp7+v9NFHsGRS7+LXc2HkX7d76Edg=; b=DenaLCbavgtch1UOy9Z7OqzJ8LpbJCHIIp20xaZyvuLLj2AnCKCRIKWRt98R42mvOz zi0mophVP6rkw7ju/H9PeWTsbCjVqXrwAUpOkH2wRdJKfkX0IrAPb42MZvACbYmrYOvU VXHy1b0StUllNggi03S4BWpwB9YUCWWV1rCAWcrOaXAzqqNpXuZNslF9gsdURI6TdcsA OiyXMvhg7jn9eYRmT1X9SRBM2VURfyjxIy1YSydcnNiqnQTqHHwyrFF3uLO+kao2DqKE /CzgcrAPVJXOfEVv0yNnRKhPSc2TzwncnKZ4JFZZz7KndXCbR+CTmCG97RfVNDHFrl8t IJYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783096874; x=1783701674; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=0zxOegtK9/HXZJNp7+v9NFHsGRS7+LXc2HkX7d76Edg=; b=eBFJlpyzo2CmNlxisK1wHVFOpRTXLDt8qp4dQCPA5u4yjYvtgacD+0QiDSKrKApL4b la9GnDz/fs0tjHdLHlHc/sAXCy/v2qsRDrWMe7g+IbDmu4t4E4R+N3409RaVHr67ff1m 2jxgH15yhOhLf9uktJForcY3h4I0IITco1X0uWJiI2du7N2m6QHhhbVEiSud5/qs1MG1 faKuM28YY4Hp2Nmtr7z1BRhx+JN2aSAdz3rQb/Cb2tXogb/UAXQcfXZSeDOlH97x1upO U5J+7fKsPUlQ8lCycHytiHulmdj4ZJY8gVlg72R0rFWXClbfo3ht9YQ6HPZcdOPmAnZV OpGQ== X-Gm-Message-State: AOJu0YxjeL6IlPdZpBZ0eq4RTj5Jwc/n1XqTL7yI8NkQpXOYVAhLZqcD UxD4wuXnH5ix5t6YPlGhP6a2g83BhWryQkBLRsUGOZLw7Xrh+AorjtoHrEuEYbaEHe4rwMP642v 9toWC62TPufm7yS3is+XuW93pOfkuMsJAG7ax3nvfUID87HUhda5SO8msYyFNkmA/0w== X-Gm-Gg: AfdE7clA45ewrsRNFZy+af7Ylb3SZqvpnlOU0F7bg5ile2IBxECaizMkpAlwZ71UhgG kMEePf6Fe3HtvwiWnP/uTmVzSwGhKn2B0Vyy2YcRx9SlmwYIcuIo/woD5+yCT3IoKq20ykJCivY uIbcSBp1TGFjOgPSnbDYMJjd72iLAXPUGjyO8kyRI9CvCbzfgEdDvTcYxY+DhssF4tM37B/lV3C OgdTeNe78TWVLl43ynL4uSr51gHkWLXYZXI0G8q4X8VObou2L7X74yGFhBBSELABZA/HihUL/mR ehnTIpSWZ1slLvm68/f36Cl2JRbTLOeQHQwGQ5I8XnOpk9Pxh6mp6dn0oOJQAO7lw8IldTa+SIn r0w2im+RANk4zHsD0mJHjhDO3q5ToHExCSFI021LJkIxNB9rXa1eqh+RbinAguEbVxSsj X-Received: by 2002:a05:620a:4041:b0:916:10f6:77c3 with SMTP id af79cd13be357-92e9a3af101mr27092985a.28.1783096874384; Fri, 03 Jul 2026 09:41:14 -0700 (PDT) X-Received: by 2002:a05:620a:4041:b0:916:10f6:77c3 with SMTP id af79cd13be357-92e9a3af101mr27088685a.28.1783096873917; Fri, 03 Jul 2026 09:41:13 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , Richard Henderson , qemu-s390x@nongnu.org, Xiaoyao Li , Zhao Liu , alex.bennee@linaro.org, Magnus Kulke , Peter Maydell , qemu-ppc@nongnu.org, Mohamed Mediouni , Paolo Bonzini Subject: [PATCH v2 26/33] target/arm: Inline check_watchpoints() in arm_debug_check_watchpoint() Date: Fri, 3 Jul 2026 18:37:49 +0200 Message-ID: <20260703163757.55500-27-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260703163757.55500-1-philmd@oss.qualcomm.com> References: <20260703163757.55500-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: -6EIFDt6rvikqZ7xHNhg0jhIEOAOAkRD X-Proofpoint-ORIG-GUID: -6EIFDt6rvikqZ7xHNhg0jhIEOAOAkRD X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX0gXAoim0Kwn1 Jzs0m7/dxVHHieqi+J97PTZoObyGQBBcaVjE9euPUNKA5S7wzozaZcyjMJsU11OOKWHyoytqlsG XIHaFylIKXeeuBkoUKnSNcESEePio6Y= X-Authority-Analysis: v=2.4 cv=Yuc/gYYX c=1 sm=1 tr=0 ts=6a47e62b cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=FSafjcPV3XuXVNEPM0UA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX8LrqkGoQqkSO /SSci5vZzpL+VQlBSfM/1NZeIBBBzsnHJKQRQzJhl66PwSsSJ/0oVAUIBrh1FTtDsFWEOkPDWrf MevgSkvMrAD0lGSKPcTeQ1fl9Bb7Vo/qblFsy68oJ7sqyuZbRyrC4wCg4zmc/sxI/hzsdJP9cAG dfT26AlLz3jIWCYqXjHYXzGaRD5BQHR7Sth67t2KxzSSG6MT9SfawTTDHFTg2SjXmOoYTo3iqZ6 0UAt9H8c9nt/5g2tfpU+vxo3rBwLc+gvixuDvhJDs053G/LPqINgcNt5vtUSFryUsp+x1bBU3tP XKvK3pSTRwnWl1+nhUI/CGEnJfsG+HVc5BBU9Oale6EsSUjSWux7i1am9isnk7FpSoZ3637WfmW 99Uv47fpaDmOAC5oeiFS0sbpxPzlymqwFbYqVNHUSnKecChMiagm6m41JewZdrSURi40qH8eMQU 2n25gi3pJfy4paXgLZA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 impostorscore=0 suspectscore=0 phishscore=0 bulkscore=0 clxscore=1015 adultscore=0 priorityscore=1501 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030164 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783096978265158501 check_watchpoints() is called once, by arm_debug_check_watchpoint(), which doesn't do more than this call. Merge both. No logical change intended. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/tcg/debug.c | 40 +++++++++++++++++----------------------- 1 file changed, 17 insertions(+), 23 deletions(-) diff --git a/target/arm/tcg/debug.c b/target/arm/tcg/debug.c index 11043ecd589..7171501d400 100644 --- a/target/arm/tcg/debug.c +++ b/target/arm/tcg/debug.c @@ -351,28 +351,6 @@ static bool bp_wp_matches(ARMCPU *cpu, int n, bool is_= wp) return true; } =20 -static bool check_watchpoints(ARMCPU *cpu) -{ - CPUARMState *env =3D &cpu->env; - int n; - - /* - * If watchpoints are disabled globally or we can't take debug - * exceptions here then watchpoint firings are ignored. - */ - if (extract32(env->cp15.mdscr_el1, 15, 1) =3D=3D 0 - || !arm_generate_debug_exceptions(env)) { - return false; - } - - for (n =3D 0; n < ARRAY_SIZE(env->cpu_watchpoint); n++) { - if (bp_wp_matches(cpu, n, true)) { - return true; - } - } - return false; -} - bool arm_debug_check_breakpoint(CPUState *cs) { ARMCPU *cpu =3D ARM_CPU(cs); @@ -426,8 +404,24 @@ bool arm_debug_check_watchpoint(CPUState *cs, CPUWatch= point *wp) * is also an architectural watchpoint match. */ ARMCPU *cpu =3D ARM_CPU(cs); + CPUARMState *env =3D &cpu->env; + int n; =20 - return check_watchpoints(cpu); + /* + * If watchpoints are disabled globally or we can't take debug + * exceptions here then watchpoint firings are ignored. + */ + if (extract32(env->cp15.mdscr_el1, 15, 1) =3D=3D 0 + || !arm_generate_debug_exceptions(env)) { + return false; + } + + for (n =3D 0; n < ARRAY_SIZE(env->cpu_watchpoint); n++) { + if (bp_wp_matches(cpu, n, true)) { + return true; + } + } + return false; } =20 /* --=20 2.53.0 From nobody Sun Jul 26 11:01:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783096928; cv=none; d=zohomail.com; s=zohoarc; b=VmIWqvmiMjFGVT+9IDzXmXT2foiFsObZ5M4QBOfn+diUyu+u2HtRP+P81lc94aXjnmZ0+x4RA2aJ3nGmTOVwN88loDfMR9pZVh2f55c0+/T7ym5I0QcfaHI7AJiy3uPDgcpVJbYGcRgFmjNJlR1FohlCNZpZB76ApeiiyzhR2+0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783096928; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=nKWbeV6dy1QzTcg2r2krTsk35PC3Q8z5Zx1L07HjdlQ=; b=KR+yEl1/mlD4SgGmYsHthrtFVOLuyg+J8Qk8Kbxj6DsZpuNfhtXMjWOAvAFwvLEYs8pzXN9kMj85dmyDMdNom4jMF6jzUkT1x1FRG6VwrKWcP1jfZwWyaVHvbCMSqOGBqh4QuM+8gBPVbmROjzeFCamkuq3jcBWnTpCcglYx4bQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783096928216406.2703269179342; Fri, 3 Jul 2026 09:42:08 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wfgxO-0005Da-VH; Fri, 03 Jul 2026 12:41:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgxN-0005B6-6Y for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:41:37 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgxK-0001gZ-NR for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:41:36 -0400 Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663GIe6s493435 for ; Fri, 3 Jul 2026 16:41:22 GMT Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f68u320k8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 16:41:22 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e538afe65so74197085a.3 for ; Fri, 03 Jul 2026 09:41:22 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa0f21543sm479637f8f.35.2026.07.03.09.41.19 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 03 Jul 2026 09:41:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= nKWbeV6dy1QzTcg2r2krTsk35PC3Q8z5Zx1L07HjdlQ=; b=Xt0+zM6rd/z86fTx pD5BI31ktDWQTGKGTsF9jXYsJkGi2oB5CgqZoYkUKEaxBcDGzmw25RonK72I5BSV A+8vUlbqkCtu1g2C2b6JytDM3jkJagYV+IXLcxJUVlxZdGyZ4aIzKZA9x9cDkQGR kjyZGIzrTbxyLoPyV1fADhRmDzSCE7uiFpyHKDBSX92CCQP2VGfXvYiruYJXXBSd 9/8vKVeqmdMfTmBG4yccGaeaVKxSrj0ZxoA28yEMPd5By0bZ7qnGIJpRda/Jea0S zykNApze6MRsQi3MGoxgIlegf7sVFjmIWL6izK4bVHWsZ4ryWpSzMqcSGFACLCMH ZVay5A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783096882; x=1783701682; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nKWbeV6dy1QzTcg2r2krTsk35PC3Q8z5Zx1L07HjdlQ=; b=Hx5Mn9hhRCyhcdjo3Q1oOZsnr8z7PPtBPLRBd/ZCxAs48nTUMqrSql9Dd1T2PcXWde cxXDHOi2s8bwGOwgOtVAhzdDntNPTaRR7RJxz6zTooZfDpTT8EBfFEumnmYv74XoEHZD nECm87ecb+dKEmXXVCfYFHqJYC6LSmyK4xOCC7ipesd/xWxO1/Gte7fwYaUZDZLjwRNl ARRBluaC4OVCmKkxI8dD5V0AxqFyBTXbIXL3r93pQ3MYyFI8aF+SKLtA2FX02GyT4wR5 chLoi0GaGqPuOsOU10aYcRxOejTUTaGIgioVgNKLtYWyjWHSrt1n8oUYE3Vbjys3Gx0K j0bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783096882; x=1783701682; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=nKWbeV6dy1QzTcg2r2krTsk35PC3Q8z5Zx1L07HjdlQ=; b=sO4ZpSvGCbZ03v7tlWI++VZGX7FqnKVUZW9Q4Yk0nI+DKRFzM5IzCPW2r1NCJimRJz Ub8k3kxaAYMXE3mBTwGypPU4GfLsKjzSyyWOgq19XsVhEz/fipnzvFL/MJQlqx7x9/kz TarYKmfL8rcY4uopr8UmNfiOfQhDqa9UlcPRjtOOTwA76kWvn4F2veJ0aBBCRiTHComS H3EmCvtpSOQiprZEPyyj8zSomuK/cPOvz3A+NqZmaxleRS0BCV7FxsHMjd+a93R5Kfsq 6J7CrgMW22w/wdWHnhm0gBHZfT6jwXuUULgqTbhMoU/bmUQep8KPWVX0asmhsjjuPyhW b9Ow== X-Gm-Message-State: AOJu0YwL2WXqAeKkZ/AdgCHq92T+/3+e4EAmlKYs0mXBTWlTetkzbHX9 TbW1iF75GznUvqO8uJ18HS9lTd1kE7+J8yPDnQfFhwotUljjxWgvkuLYKeGz4R0wc5YC93cArll 3RexmBCayJsh2cVfZZz1HnkqrEry8anIQiDD/zrMVhXHDFU179YgmCTF6jp0++g1wpA== X-Gm-Gg: AfdE7cmq7pknl46MrPoanc2KOpFbceYMf08vzQ23Cuf/X72OBDHKe3GGIOtWjZEhalv j8AGRRw6dE/X67q+HBebYMqW1veMS9iW4YysKIb2ucSUeXjOJ3pn1JPcAoCEgPoYSK2Xt5KPsTX saGZFUT3IF5Ux+pIYzDVHe3lVvEarxoC9fv0gKXT7Yfs82mLJ2YUCgvHQmPWPDiE+Utd/5awiab YnNMZC+ym8TI5yQsslN8UABo1uBhCwK8QUxmW84RRLtPlemDoGzhvcd1udjv5xO27RJpcsAxytQ jnM3yQdJg/7sYzRs6Gscq27WWrNIyPcp5/MAiWXu4Od/UflQ8BB1/U05nPesLowA9D4AQZaA+NC 6NY22oXouaMIyX1c6T5Ye7ShW8OhoMMDq6CwtPGNSkF+V7O299X2KIQwnlebrQrUiyYJc X-Received: by 2002:a05:620a:2725:b0:92b:67e6:8ac0 with SMTP id af79cd13be357-92e9a55d8b0mr21734785a.74.1783096881522; Fri, 03 Jul 2026 09:41:21 -0700 (PDT) X-Received: by 2002:a05:620a:2725:b0:92b:67e6:8ac0 with SMTP id af79cd13be357-92e9a55d8b0mr21731285a.74.1783096881108; Fri, 03 Jul 2026 09:41:21 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , Richard Henderson , qemu-s390x@nongnu.org, Xiaoyao Li , Zhao Liu , alex.bennee@linaro.org, Magnus Kulke , Peter Maydell , qemu-ppc@nongnu.org, Mohamed Mediouni , Paolo Bonzini Subject: [PATCH v2 27/33] target/ppc: Ensure TCG is used in ppc_update_daw() Date: Fri, 3 Jul 2026 18:37:50 +0200 Message-ID: <20260703163757.55500-28-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260703163757.55500-1-philmd@oss.qualcomm.com> References: <20260703163757.55500-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: 7Wq1JZGjyal_CQf9GienCsJYiODstNK6 X-Proofpoint-ORIG-GUID: 7Wq1JZGjyal_CQf9GienCsJYiODstNK6 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfXycARF3tFFuao sQnyLrAZSnGxnTBCM3dvdGabHQxmfhPOKyxqdH5W5tq6/3BgtOuaPjKUpx89YsYYZ+9IW/8ugH5 MxGHiEA/MBOjKZVnB775c41/Ga0Dbo4= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX9i5/5d6+AJsG iF1tMWpKI9leTAdTjHs416ry3XKDU/z5D/2WsJxhnQSQ8RViCW2j5/cFOQd6K8C1zf60w1V1o2J 8xfjNm+dx6/gjWDAMqSN3WgbB+RuNilltTWUQ+J7tfIU+BQe5fD4RDXx35rzEYpsm02q/iLeQlA gBCQLPAEbvW/7FXuuiy21LPKcYqySahGYdbgX10sGIllDIhdsVmFG9MLPCzQ14RCNBEIzkum0yf UxLqfMowEiYZc4PYJXU3kZIMoTZVRGW5dEjlWbu8TNEs6Q9rt4hXYl+J4X7O1qhyAm+rtaz0ayg +gOqZ/hsbc96b4yS0Ko7U0F6PzXeM4HbmhUVIPSDXWbWWzdFcPlZ+UxK41jUld0sbVhrIhBxSfw yL25lJeYk4oq//vTdmRdeV5zrZfRId71YvxNVt7LVentbA/phqedsD+ihmnBUoH2H9ELW30+//3 xrDWNspo5yQ1l8RzjGg== X-Authority-Analysis: v=2.4 cv=OaKoyBTY c=1 sm=1 tr=0 ts=6a47e632 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=nS8E-dRYisaDM6zJQEoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 spamscore=0 phishscore=0 malwarescore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030164 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783096930179158500 Per commit d5ee641cfc5 ("target/ppc: Implement watchpoint debug facility for v2.07S"), only TCG is implemented: ISA v2.07S introduced the watchpoint facility based on the DAWR0 and DAWRX0 SPRs. Implement this in TCG. ^^^^^^^^^^^^^^^^^^^^^ Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza --- target/ppc/cpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/ppc/cpu.c b/target/ppc/cpu.c index 913920d55b8..36e1209119d 100644 --- a/target/ppc/cpu.c +++ b/target/ppc/cpu.c @@ -147,6 +147,8 @@ void ppc_update_daw(CPUPPCState *env, int rid) vaddr len; BreakpointFlags flags; =20 + assert(tcg_enabled()); + if (env->dawr_watchpoint[rid]) { cpu_watchpoint_remove_by_ref(cs, env->dawr_watchpoint[rid]); env->dawr_watchpoint[rid] =3D NULL; --=20 2.53.0 From nobody Sun Jul 26 11:01:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783096938; cv=none; d=zohomail.com; s=zohoarc; b=J2hTBz71EWKCD0gOhjoByUz2ue1xaCnwNe5Mbr1gqhlv/rgiOUg535C5v+ZWDCrq0eof9e0vm5gjLbT22CskEBKteQKKI3n8C/iSakQike1TCOf6crh4MGkFPBPXs0IdVcWS7G1c7d9aR/taDzRWQeYuP4yPwhOBjKfSbJpIPuA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783096938; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=OJfYBFEk6cqjY+BSEvPVamiQUgD1yf8uocYVw14otOc=; b=mealIeOrK7Yuq5QuZkbmmwbFXjY4exHEFJrECKWmSpf9f2qUu7BdX/L0zT/SCEjID2xy1FBCTSTfSypfwYgSkdyZprz+2kTdUozt1NOQZf+6bk8bjs2tPxk59m2pNMLLoV3fWzm+6L2wuD1+9GxZoOuw8KaYJ+PQSxw4Wk1dYCU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783096938787321.0505754073862; Fri, 3 Jul 2026 09:42:18 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wfgxe-0005kR-5n; Fri, 03 Jul 2026 12:41:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgxc-0005ds-B5 for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:41:52 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgxS-0001kc-AT for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:41:52 -0400 Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663GIa4m511014 for ; Fri, 3 Jul 2026 16:41:30 GMT Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6a849kbp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 16:41:30 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-92e56b2b350so146823785a.3 for ; Fri, 03 Jul 2026 09:41:29 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c63172fesm250059535e9.0.2026.07.03.09.41.27 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 03 Jul 2026 09:41:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OJfYBFEk6cqjY+BSEvPVamiQUgD1yf8uocYVw14otOc=; b=ACPpdOzQzbCywrhE j/mWfybD0eyizLWOLXYF0/2fFy9+u9w7cAI+764A4j6lpH0aAsmRSay8eauNGzrW 8Imk7cgA4x91bE8vy8r0cDWRNazGL6NCUd4Usy3nspKcD4dH/j0qPNnD38YN+Xyp LpDiHXVWnAAiDVe58J1tvh+gt3f47rpfvYdpADwX5ve0BtQoJT7jYg+YShAi/31/ cawS65VFonBrm2FZjmy+E1HUF8JCPAJzuznV72/ghBmmnnGPj5Q17iBembcfJPnN K1iTc+vC5zcZ6QdktXImkjd5AIKCL5TqNLTfjGmITobLDLUSCKE3+fcana1kOQ3D 2HcCAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783096889; x=1783701689; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=OJfYBFEk6cqjY+BSEvPVamiQUgD1yf8uocYVw14otOc=; b=Gj3G2Cg+XkVx84w+ijHDW6LQsuAwrPzQYVQj4pbwAUvw1UmGQS3u9YvfsNF/jZOm7l RuVotE35q2pppe5KjduDwLZVS7Se0Df7hcjrdhieCvVTvPsCvYLy0JuFcPfEfE5gkjqR RxlTNPa+U32Xzhfyg560nhPDok4GweVBbHTC+3JRmQFVTiVPT9xjL5ERmm3jK+BF8QlA SfnAi3QH5KJxEXD2CNVihFADu0NAWJNHrYQI5XogZYhWMFSVzumPEptRfFeaOcMTrU2N E3ilrYk8f03bZpomqoHH47MXYrpVSDiqKzeiBHoFeEQhupUSrPvG5ACTPgY+vVTci32p 9rGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783096889; x=1783701689; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=OJfYBFEk6cqjY+BSEvPVamiQUgD1yf8uocYVw14otOc=; b=R0bJEhZ8rLKBoBteei5qPcfs4xX3oymSuXAk5Dg5V0lyikBrT0h5wUyCnf2ejOyIUm ZdE8WjVA/np6QsXchHq+7xNBomwWi9BtQKXG+IBcM0SgKvlv6zADxgoRXnFFf0Q3nP0o V2VfMCVWY82uNqNKE+Ch6Jd4jfeM/NTDLIwULiH3L3b0yy/gkN/aJuYPFXR6FKhpDUOb TgnsnB4HXMxN6VQJtXDIrTZaPCM7yycApDGixjtc8TuOrXT2IbcQnLtjRoPiRERUzvRn u1Eg+NCootvIwqeMpKiGZTyvzxszvsWC7oLPck9nO8kgoOWGxGFR6xuFU6T+FPP02QSF BufA== X-Gm-Message-State: AOJu0Yytcu9P2O2I7D3GN2jLKoG+zt+lr2YhD4rQTkBs1UUqXZxidHHA LZHTUFIC8eqjmQzDz864uP8C4G7neseHeCvxifUW9uJLOGrsYojO+/dzdpDJ0jiq2hmKEL8aEHt meOW98f4zNgGCwcjmwms6fbyp+0Yx0HuI/pmhDWjhuEjQol2xki2SnSD4SOqxKJZGow== X-Gm-Gg: AfdE7cku3jn2ucHlMW6ntN8Csh1qoNpClS+JzUCvjEciynwE6qAya3Fg163a9tHLXCh X0WG6mSSsX1p0n3kP3lnQSa9GCxQilS+vxd02pSbiSPT5IuvdZscGDhbD+iPRGPNQHo/AWNYSgM /ecwAXGS6VrN4c1uMZSM6wXDHlCq1pBkJYc3HXnpkOjQFjy/7JHbRzF2vjqFMT51SWmTcfouaDT K6XsaS0WlvQzELAkB/wFEyjKD1OvJzF6zuCXYZhiaibiwIQBFAk6p27RoMaZTxgNjVHeab9xWQk 3ii7b4rA/70SdpXw0pRCDH0fVvMDz+rFZrl7xydjQ9kbKtkdeOEJJf03/h1tWe28RddSfszCifE 3FeLVhAIlZiGBPXy7plbm8EaogATlhyhsxm2wgCueLGZ12OHtb7vnyVQpSBl5NEzzC0FP X-Received: by 2002:a05:620a:4544:b0:92e:78cd:13f with SMTP id af79cd13be357-92e9a3addf4mr29241685a.33.1783096889024; Fri, 03 Jul 2026 09:41:29 -0700 (PDT) X-Received: by 2002:a05:620a:4544:b0:92e:78cd:13f with SMTP id af79cd13be357-92e9a3addf4mr29235085a.33.1783096888453; Fri, 03 Jul 2026 09:41:28 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , Richard Henderson , qemu-s390x@nongnu.org, Xiaoyao Li , Zhao Liu , alex.bennee@linaro.org, Magnus Kulke , Peter Maydell , qemu-ppc@nongnu.org, Mohamed Mediouni , Paolo Bonzini Subject: [PATCH v2 28/33] accel/tcg: Improve docstrings around TCGCPUOps::*watchpoint* handlers Date: Fri, 3 Jul 2026 18:37:51 +0200 Message-ID: <20260703163757.55500-29-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260703163757.55500-1-philmd@oss.qualcomm.com> References: <20260703163757.55500-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: 6d3nipZgUoRCXE6XeG8U_UjhIX6VDh_j X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX9QIjRvOWhNe+ TRRPLIyGzTShT8PkKVIy2HhHQzXO1GpNF49zWGgz7TXhtBpDUYGuwE1EgpmVcOrmhcHFkhy84lL PPB2CDUhNJcKD/O/8oGBxZblZgY05lw= X-Authority-Analysis: v=2.4 cv=a6QAM0SF c=1 sm=1 tr=0 ts=6a47e63a cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=oIGtIzObNEvw8K7fi1sA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX9T8bGnycEiFm bor02uZxy+BqIolPEueibd8GelNoa4AgLRs/zc9ZGu7gXPyV4ZcyR0uBwAMsKcx1ue9HJBPNFOb EhlMhFIw8P2oJZP4bxBklf7i1sD2gjlYAAEA3Wb08fQ5n791iX9qrO6SzFGEmbvFlOY9fMEAZtw 4yiRxrVecmKr8/pUcDWlBTG9EGenTdnBt04UpYGdvsfgk3beFpggwaucovrrfhm6QQrKjc5rCmc QQUpcFEkyRzDpcw4Hkuq9D41hCrdcp6x95Rx5eku88+OOAL6Y83eBdFh4hxQIBIPBc9VXIM1Km8 3DIvqINJuJ9RScFJiYoFxs6HrETuKupt9X4XslT9C+NVMlulN8n1+PTjFp/JsFy+YsSUqq43vK5 D9eRZVbXqXoEyUx9kvAmns9nXA4A95iA0yZkbA38e4zcEnj019ZYWzr2zzrqletHfUAHBCN1oeh 6BpQTq45x4F1Wyj/PhA== X-Proofpoint-ORIG-GUID: 6d3nipZgUoRCXE6XeG8U_UjhIX6VDh_j X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 bulkscore=0 impostorscore=0 phishscore=0 spamscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030164 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783096940073158500 Commit d5ee641cfc5 ("target/ppc: Implement watchpoint debug facility for v2.07S") also implemented TCGCPUOps::debug_check_watchpoint for PPC: make the comment generic. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- include/accel/tcg/cpu-ops.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/include/accel/tcg/cpu-ops.h b/include/accel/tcg/cpu-ops.h index f64d94b2b50..568d82cdd32 100644 --- a/include/accel/tcg/cpu-ops.h +++ b/include/accel/tcg/cpu-ops.h @@ -250,14 +250,13 @@ struct TCGCPUOps { int mmu_idx, uintptr_t retaddr); =20 /** - * @adjust_watchpoint_address: hack for cpu_check_watchpoint used by A= RM + * @adjust_watchpoint_address: hack for cpu_check_watchpoint (used by = ARM) */ vaddr (*adjust_watchpoint_address)(CPUState *cpu, vaddr addr, int len); =20 /** * @debug_check_watchpoint: return true if the architectural - * watchpoint whose address has matched should really fire, used by ARM - * and RISC-V + * watchpoint whose address has matched should really fire. */ bool (*debug_check_watchpoint)(CPUState *cpu, CPUWatchpoint *wp); =20 --=20 2.53.0 From nobody Sun Jul 26 11:01:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783097015; cv=none; d=zohomail.com; s=zohoarc; b=C3cQi0BzrOBe7kZ8saXAWT6TOHfbVqZGP0vAGPOtBkFEwwTBNa9gQVcTaP/fAWqRO9nQWMcOtNkHB749gqH2w1zXIj3iPkqKTcf3GjgaOf91dwybfQUbHBZvVkOoQjucWlEZ69An3V2st9yFSe2EoFr8vFwhD3uC8YaZw/b9y8E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783097015; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=KMpp3aFM26Lyv0xLn4OgpzmL3P0zEDD0URj6gVEr5cM=; b=Gr5kyjBvZ5A5IfpaW/LlcIQbRkMu+m0H4JSz2U7wqatPY4laKlcR16w7zFEP3KFgMEc6PFSONIKmUzqY9WXr+eKaaSJwdWW8ftGFd0VMEBNfhLqYtrxA5Da6zvy115CcAsNdrLwceUv1AxvB4oEh/Yd7QSH8ioxoep73NwXLLfs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783097015508798.7733632956634; Fri, 3 Jul 2026 09:43:35 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wfgxf-0005nS-ID; Fri, 03 Jul 2026 12:41:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgxd-0005k2-Uh for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:41:53 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgxY-0001mY-NG for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:41:53 -0400 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663GIn3M476543 for ; Fri, 3 Jul 2026 16:41:37 GMT Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f60eybx9n-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 16:41:37 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-92e820609d9so49773985a.2 for ; Fri, 03 Jul 2026 09:41:37 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493c63b6f1bsm132300565e9.10.2026.07.03.09.41.34 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 03 Jul 2026 09:41:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= KMpp3aFM26Lyv0xLn4OgpzmL3P0zEDD0URj6gVEr5cM=; b=LGBm2DRLezU9GW2k 0mcTE/uKbayts3h7JW/63D668/hU+h4Bwl4mVjcHXnfshtSy2C98LIU7VuIxfbyo Ntun9poucSmX0HVTna32014fk9Xu2yhJezJKUG83yUzmM+Kb4L9zxCbdQRCXvkju mVgjaI2xEFHXsWhHUKrL+qpUPCDlx6O6JgRycLXvaF71mKucMgR4GsCdM4GqkO69 6ewNQJpncRHi1iUQ9gz25Nd88Yocd5U1C87tBovWXuDa+MylS0qfIRIyTcOds9ct aoJ9A4BpCoHK5RLY5KL1DGROahULd300YqlkCK0/JwST3P0H3AbyHcEKGXePbOT2 PRMrpA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783096897; x=1783701697; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KMpp3aFM26Lyv0xLn4OgpzmL3P0zEDD0URj6gVEr5cM=; b=iwMZJt+0OtTPYe0DCmYpfbyVBrJiRJgbybK7z+IQhpfYLBtRnGifjtFznnlH/w1CRf EQBFdre8s+iYDiyxsZ13MaKMAbCOyeGaC879yvIVfj2MejmTvpQ2HF+0xfc0i8aKPqVn oL8wEHQa7y74cTbtmMXlCSHCt/n9Cy6TU9UONzTW4h6A3p1gymulxn1EOsyAy4OaF+2O 3YJZY5qpxcFGjkPHsW3viWlX7j6ubaTUe+aFS6IPw6whMgTjMQpllKrfNEVZMMYVtbJ6 9sMSilP3soWXoJpUVHtEODJGUH1At/PTcUNA7m5vcpqK4CStIsMQr+fpZz/He9aEWViA /1Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783096897; x=1783701697; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=KMpp3aFM26Lyv0xLn4OgpzmL3P0zEDD0URj6gVEr5cM=; b=XfIsgihzGBpQJvoY9BpSvR9fBR3kuJXeIFZN/hea9LZhcs2Y2kOh9jDUd3cOgTBQnQ 3sOZ9pI/gXQWzgHhDQxivDnpk+UZxufmhLVjA2cD5XcBwaFH9wo3l7QiKnMnV8879TV2 Ppu1yJR3HA+UF9a7Ppo9RvM7+AowxpYUEsm3M8BMZUVcdDVxjxbzWW9Bu1zA4mtTLHT4 dMcoWbhCIVWe0XmxBJr6299WhBGoZhihBk+JJGlCHvJcNxvJgWSe6QgX0KbHn+YAhReN H/YvpakIDVZ5G6qv9L+1oimOKW3TzU9weO0wY0QJCQiHdLzt63UW1EEaO7Vptyze/4bD RWZQ== X-Gm-Message-State: AOJu0Yw2DaZq+aRLeGGirQfpR0c6ijOTlrTQxggjOf+O4RKVpcLrnlho iJwKEWeijVvabvw8P4E/eric0TIqOTyL3PcMgU+DIQgew/ZzSP7YbW6Sg9cRSlnbdNvYMmVvF48 rBDaMp6Q1D3E5IbIyMfaNbeOopsSo3ZNFJULqB9MhG5bXnB9pgMKBGrqUFhp+A9SFFw== X-Gm-Gg: AfdE7cnhIMSV39hY6875v9haIpUEqqH9V59dblaImRoyNX2yRe7qUvaRcG6aU5VDyeU GxY3rfkpI52PbjJVnwy2S1eV2RoV+ZPO4b7Ts6YELE2v9fKmnkVZfltoYT6+Q69Br1u7VRJA6pN Ql0h3GrdiIhqbJiripYJYw/T46/ze4pvuYqrglhPDQyzxaxtYBn/ZNtDhvDsJwu5FOeGczGJVp3 C9FXkPFx9va0R517KxL3Ue3/vH1UGDn5AN1RduXYxpbdpDRXNJAAaW6ap2d3DBr0brUmt8Z07rM V+04bh2B2CfB8LXFHivNQcp6sCXzhPfNNgjLww450s/TU4p50N6nzHF+AffhEDVOlVz/QCBJmlz 5X/WpCRZVnoefTlZ0Foj76QkKS16qU5fBZfxwhHM/JB05gpTUP3puHIurWtmcWaPYIeW1 X-Received: by 2002:a05:620a:640e:b0:92a:dc07:2665 with SMTP id af79cd13be357-92e9a4ee486mr25798785a.54.1783096896991; Fri, 03 Jul 2026 09:41:36 -0700 (PDT) X-Received: by 2002:a05:620a:640e:b0:92a:dc07:2665 with SMTP id af79cd13be357-92e9a4ee486mr25794385a.54.1783096896543; Fri, 03 Jul 2026 09:41:36 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , Richard Henderson , qemu-s390x@nongnu.org, Xiaoyao Li , Zhao Liu , alex.bennee@linaro.org, Magnus Kulke , Peter Maydell , qemu-ppc@nongnu.org, Mohamed Mediouni , Paolo Bonzini Subject: [PATCH v2 29/33] cpu: Move CPUWatchpoint definition to 'exec/watchpoint.h' Date: Fri, 3 Jul 2026 18:37:52 +0200 Message-ID: <20260703163757.55500-30-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260703163757.55500-1-philmd@oss.qualcomm.com> References: <20260703163757.55500-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX8XyVr8hL4TfV Roq/HOKZzO+Ir9lASL1ji+XhTqUQzjII4Q2ZAnRo4N0H08RUCoL+linkG1MA7Ia7hzV1WCfrX5T HozKwkv9KOx1ZxMTflbwmMJlNenSiW97wvgugGwBF7Fdt2q8G+lUcXLV8N2XPXmytNUWn6Jt8Cm g5dBIhMzubJkw8dXvAnzDy7DP9s3HobZfEbKr5cAbPmU6F+Q9VzRT6pJYPgk8vvH2IEG5EyzXNx 8Yt+SIvyFNmC6FfT+e3L0487LJG3SD5h+UHIjojUR6EWjx+Pz5XA1OXIhKIGLB16wVzOFNhnAJX PfcAUpBREJAAh+uHvmmPypuKdz/asEDY+8D0+B0jAhwqFJ8Zb4M25kIDrN2x84dUK1gl5UDDnKb 6mBm+D78MpQbytI09D+OjqQ+nGmVg1ey/TqYvHjhAg0HVbvgz47Rn7ozEiIksHXOdd9s5W3R/FS W3ul+ptgjxaXqFcCVYw== X-Proofpoint-GUID: WhRdqdMZdEIMKq17MC2K4UYLqnvkSBxj X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX4zXhTXZGmAj7 mpI21czXnln3n2jJu7VuAOBtB534+upuXZhDjF027QTVyN/T+jUUustBerlFUBFhbbRJD4ni2Vk GZG9BDkwzd6Ki4VhiGySkH/M+rqw5H0= X-Authority-Analysis: v=2.4 cv=SPRykuvH c=1 sm=1 tr=0 ts=6a47e641 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=HjWuKgUHFhC_F9lk5HkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: WhRdqdMZdEIMKq17MC2K4UYLqnvkSBxj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 spamscore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030164 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783097016567158500 Define CPUWatchpoint in "exec/watchpoint.h", including this header where appropriate. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- include/accel/tcg/cpu-ops.h | 1 + include/exec/breakpoint.h | 9 --------- include/exec/watchpoint.h | 12 ++++++++++++ target/arm/internals.h | 1 + gdbstub/system.c | 1 + target/arm/hyp_gdbstub.c | 1 + target/i386/kvm/kvm.c | 1 + target/ppc/kvm.c | 1 + target/s390x/kvm/kvm.c | 1 + target/xtensa/helper.c | 1 + 10 files changed, 20 insertions(+), 9 deletions(-) diff --git a/include/accel/tcg/cpu-ops.h b/include/accel/tcg/cpu-ops.h index 568d82cdd32..d5994781c39 100644 --- a/include/accel/tcg/cpu-ops.h +++ b/include/accel/tcg/cpu-ops.h @@ -20,6 +20,7 @@ #include "exec/memop.h" #include "exec/mmu-access-type.h" #include "exec/vaddr.h" +#include "exec/watchpoint.h" #include "accel/tcg/tb-cpu-state.h" #include "tcg/tcg-mo.h" =20 diff --git a/include/exec/breakpoint.h b/include/exec/breakpoint.h index 0c3cc0c8ff3..9d0dd89e7c9 100644 --- a/include/exec/breakpoint.h +++ b/include/exec/breakpoint.h @@ -33,13 +33,4 @@ typedef struct CPUBreakpoint { QTAILQ_ENTRY(CPUBreakpoint) entry; } CPUBreakpoint; =20 -typedef struct CPUWatchpoint { - vaddr vaddr; - vaddr len; - vaddr hitaddr; - MemTxAttrs hitattrs; - int flags; /* BP_* */ - QTAILQ_ENTRY(CPUWatchpoint) entry; -} CPUWatchpoint; - #endif diff --git a/include/exec/watchpoint.h b/include/exec/watchpoint.h index ba148eff3d1..7b72de35aa5 100644 --- a/include/exec/watchpoint.h +++ b/include/exec/watchpoint.h @@ -8,7 +8,19 @@ #ifndef EXEC_WATCHPOINT_H #define EXEC_WATCHPOINT_H =20 +#include "qemu/queue.h" #include "exec/breakpoint.h" +#include "exec/memattrs.h" +#include "exec/vaddr.h" + +typedef struct CPUWatchpoint { + vaddr vaddr; + vaddr len; + vaddr hitaddr; + MemTxAttrs hitattrs; + BreakpointFlags flags; + QTAILQ_ENTRY(CPUWatchpoint) entry; +} CPUWatchpoint; =20 int cpu_watchpoint_insert(CPUState *cpu, vaddr addr, vaddr len, BreakpointFlags flags, CPUWatchpoint **watchpoin= t); diff --git a/target/arm/internals.h b/target/arm/internals.h index 067c3f2b8bb..72ef3a2bf9c 100644 --- a/target/arm/internals.h +++ b/target/arm/internals.h @@ -29,6 +29,7 @@ #include "exec/vaddr.h" #include "exec/breakpoint.h" #include "exec/memop.h" +#include "exec/watchpoint.h" #include "gdbstub/enums.h" #ifdef CONFIG_TCG #include "accel/tcg/tb-cpu-state.h" diff --git a/gdbstub/system.c b/gdbstub/system.c index 3098fd55740..1ce05989715 100644 --- a/gdbstub/system.c +++ b/gdbstub/system.c @@ -18,6 +18,7 @@ #include "gdbstub/syscalls.h" #include "gdbstub/commands.h" #include "exec/hwaddr.h" +#include "exec/watchpoint.h" #include "accel/accel-ops.h" #include "accel/accel-cpu-ops.h" #include "system/address-spaces.h" diff --git a/target/arm/hyp_gdbstub.c b/target/arm/hyp_gdbstub.c index dda6946ddaa..62dd91169dd 100644 --- a/target/arm/hyp_gdbstub.c +++ b/target/arm/hyp_gdbstub.c @@ -10,6 +10,7 @@ */ =20 #include "qemu/osdep.h" +#include "exec/watchpoint.h" #include "cpu.h" #include "internals.h" #include "gdbstub/enums.h" diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c index 1e09155e92c..372781ae715 100644 --- a/target/i386/kvm/kvm.c +++ b/target/i386/kvm/kvm.c @@ -70,6 +70,7 @@ #include "migration/blocker.h" #include "exec/memattrs.h" #include "exec/target_page.h" +#include "exec/watchpoint.h" #include "trace.h" =20 #include CONFIG_DEVICES diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index 6bdfbbd68d6..85b15602396 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -41,6 +41,7 @@ #include "trace.h" #include "gdbstub/enums.h" #include "exec/memattrs.h" +#include "exec/watchpoint.h" #include "system/ramblock.h" #include "system/hostmem.h" #include "qemu/cutils.h" diff --git a/target/s390x/kvm/kvm.c b/target/s390x/kvm/kvm.c index 195e39df032..bb329883c97 100644 --- a/target/s390x/kvm/kvm.c +++ b/target/s390x/kvm/kvm.c @@ -49,6 +49,7 @@ #include "hw/s390x/ipl.h" #include "hw/s390x/ebcdic.h" #include "exec/memattrs.h" +#include "exec/watchpoint.h" #include "hw/s390x/s390-virtio-ccw.h" #include "hw/s390x/s390-hypercall.h" #include "target/s390x/kvm/pv.h" diff --git a/target/xtensa/helper.c b/target/xtensa/helper.c index 5a0e8655146..ac722f6782a 100644 --- a/target/xtensa/helper.c +++ b/target/xtensa/helper.c @@ -30,6 +30,7 @@ #include "cpu.h" #include "exec/cputlb.h" #include "exec/target_page.h" +#include "exec/watchpoint.h" #include "gdbstub/helpers.h" #include "exec/helper-proto.h" #include "accel/tcg/cpu-loop.h" --=20 2.53.0 From nobody Sun Jul 26 11:01:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783097003; cv=none; d=zohomail.com; s=zohoarc; b=L1liwxrpIHsznkhO1i066bH5t5zGSRentUB/4qlCrDoLOLLYIpO6Yx7jQOB5xe8NrFou66YQ0IaTKyyNjInSrWsN41edkVC65/1yk4Tmg6cCD9ID4mmmuTNVCqjGN9Tll9w0P4kA0fDUo6u6UnSBg4z3bbAi8vwDqz2kHZZtUSA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783097003; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=euJn44qDWZ2TcdTti8/aLCTKwbg3pgDFPtWDEjD8jME=; b=d1J23sAVAFIkBV5lT9DqNUdQK9H5hvy48D0KZewSrngExTezFgQpHI9Z9b6ECIAbQBAu3WnQlgn1TSTQfprTOWnz16ubf7wyMnHyPLcS/I0kgJvuUlyM3c/AdagfTHnNyt8gtNenI9edwSwLC+iG9fMR+UjnZcWSMosCOdGSdoU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783097003694467.6932962592107; Fri, 3 Jul 2026 09:43:23 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wfgxo-0005vs-5w; Fri, 03 Jul 2026 12:42:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgxm-0005uy-Gx for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:42:02 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgxl-0001rU-2Z for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:42:02 -0400 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663GInAU498238 for ; Fri, 3 Jul 2026 16:41:44 GMT Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f65qcjx45-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 16:41:44 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92e7ee64b25so124589885a.0 for ; Fri, 03 Jul 2026 09:41:44 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493cce1a844sm59579755e9.15.2026.07.03.09.41.42 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 03 Jul 2026 09:41:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= euJn44qDWZ2TcdTti8/aLCTKwbg3pgDFPtWDEjD8jME=; b=B/xCTxpwXLVicH5P IrEa1/FkWlfDOjzs4pqXYmkC2gLCNxEjEmII/hhNPezS9sYmeaAYarjCEVA7Mjj2 cM91wtz6dRROlZrbVJoC+bSMZq0Ma4PspTTjEN9S8ntyRAB96NmofMQIuQU6ocf5 ipSg8QlTk8pZB/ga+NdK4e/EcO18T/D61LYfQGkQiitQmCAhMlULCA7wyuleTH0J fBnbijQof3Ajhw1FYSgK1P7Z2ECa5z79oOIY1Smix7LrgjRuZ6OcdDp7eUmmaJYt fHiJ3f0o8WAQku4b/VOem5S2cFazuYcaES8poLbffZzoHuBl3wUDRWBcbzJWFbsW sgQ8+w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783096904; x=1783701704; darn=nongnu.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=euJn44qDWZ2TcdTti8/aLCTKwbg3pgDFPtWDEjD8jME=; b=NkYHBvlqT5WK44uZ6vU0133ghK43OwZlav62XZ7LEt2m/hc4XUFUrYbalyjKs1MN+n H6MAeQ1k+6VvpthvkZWQIrXBXjU33K+GqPsmFz/Ad+rfzZ0vO7ivC/MpYFqW9ypimDwN OoKYDtMhY+trb0HiRaMizkbqS1cjqaWmekxZvNYtOyja85JOmyzZnzWIbG1MizMNJjXg bL3kkGyEp1SgMVwx2cP/ci0w6INrIi9gHMPjqVIJ5f81CwBJQI3jjtBbHCMJVR033afj Cr8vh0d1nU38oIs97TlhiOjMVG0w557E3HPfo3/Bpp9il6j99JQDxd/R7z8cMqmGJfSC BTaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783096904; x=1783701704; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=euJn44qDWZ2TcdTti8/aLCTKwbg3pgDFPtWDEjD8jME=; b=OIRyrnhQ/LB4vBCMVtEyYJH0ApipbeF2gAnNwGstMF5yCwllvNKV6pDhao9lkkTf53 4RZ8gMCLyQAU4F0b4cDC7yJHNkWDlmRrqsIfLo4kWiRMRUEsfdFA9J2xbI3eP7GxKTVY Wt4/SSHXAXpzj/77TwRFGpRh9SFtNuR5bHmMq5Lp/taHWyYfkidcVcXT1BSmWgt6TXXy EoM1m6ab34oKdGCeOD87zFNRS2edxmP85T1w/PpZLiVyyYhqAuMTWi1VxRwAHtFZ+DKK 8VeuwhEtvaV9c5n5wqx3MjONsogDPYWdKIcdLkErBY1sxHSKRb4hf9tFHUebBG4/gKZN 8J0A== X-Gm-Message-State: AOJu0Yws+r3uMk4XjmHggkGbAcFT1El2VqDjvgwkWUJo+lX8yVBTLBSj Nfxzft6oNQEyPQrG3EtiM1CCqIejOQmuFE75b07sfi6wu6j0si+ke84aJZw1MPyoi21hFswRezh xMPu1vc/Ff3W0doEhKr2matcbrppiZilm7JMeGqS5xvBRvFIUsE3sCHimXBlfx2+m2g== X-Gm-Gg: AfdE7cmvqjihsOiLyqAO3ho6M/w+yB4mRzNhTWXwcQomBb7WHNDsnmRRMoSLGMfPdHq ON/QiO54S9A9JXGZIZecpggY50iFmlWpse1G4jS+zk366jaxLrLG8YnxT1xcyYDxRY1PhaN/+ee Nt9acnB24TetkjqXa7g2ojfGHIYz0RDASUbxR/7teSbcntYo/Hlk1j/wkwYlp1LeBh1Fgaw9yVF AnNvv9oYYTUWgbXHBCSg3zQGly41kJhxLK90Poe8Dwu84D3RSbgcoAA8O6o5DMwgts/9Mkqn7uf 9AM69yLPspD34Zh+fGdrgrgKhG2OAQ+rGTNQ+eXLwsKZDDNdfFlUYLDi/POeCoVZdbQswoUGcdv 7lY8HyemmjXPvwFBu+uwBskRnGZLZEt5yCQ4+hz7zIN7m7hiOy6jfkxi2mpbApH6ZxFB/ X-Received: by 2002:a05:620a:261f:b0:92e:6d2a:7772 with SMTP id af79cd13be357-92e9a41d90fmr26793485a.41.1783096904160; Fri, 03 Jul 2026 09:41:44 -0700 (PDT) X-Received: by 2002:a05:620a:261f:b0:92e:6d2a:7772 with SMTP id af79cd13be357-92e9a41d90fmr26789685a.41.1783096903779; Fri, 03 Jul 2026 09:41:43 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , Richard Henderson , qemu-s390x@nongnu.org, Xiaoyao Li , Zhao Liu , alex.bennee@linaro.org, Magnus Kulke , Peter Maydell , qemu-ppc@nongnu.org, Mohamed Mediouni , Paolo Bonzini Subject: [PATCH v2 30/33] cpu: Better name cpu_single_step() trace event Date: Fri, 3 Jul 2026 18:37:53 +0200 Message-ID: <20260703163757.55500-31-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260703163757.55500-1-philmd@oss.qualcomm.com> References: <20260703163757.55500-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: QzL3h9bpX69y89RxDJZBawwPxliAt9kj X-Authority-Analysis: v=2.4 cv=Bb7oFLt2 c=1 sm=1 tr=0 ts=6a47e648 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=fWCg92Okmkq_k9tJrKMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-ORIG-GUID: QzL3h9bpX69y89RxDJZBawwPxliAt9kj X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX39xWYz1ry4gL 9LtnwpsyfgMdjIwSLW1BmYfGSDpr8/NAeQG41IEQ9ZruWIAALM7jXDGGFD79eQtPIJeJUFnpgU3 4egQvWaQwcToYXifEAH0PtWkq7BW7s6qDjuvkF/far3LB2KZXMtPaqr0s59yKixPjStZbCcqQSU MVgjhk8UWrzzuVPFN3oA9iRsjnmpfXSOmIkL5oq3BqlNWkrRQRNGvlPYBXjsWrvP6byv25DSvfl 8iJBQfbrjUDPka/F4UMN2gMjakk8Ne1/Yt2rHMI7d/fuS+twz8vbnrnH4vHWfKqC0XcZ5DBchX9 fof9ROy8GRm8oYNu0defJKYbATqFfLAV6dOaLWJgUDrya2gUcuWuKq1N5NWuk6bmgc4zcslFbO2 WmIStRsthXxB3iJZSAVDW0lSbbwiuyJNJa9asgEeBG/cNivMDSF/2uzWvXGUrwIOhrmqYdu/hY/ CAvzBscjMVtiFr/Qc8g== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX57qBNQR+n4eS Hl7hTx4vS/Aa0TiBiF0iguZaIxMOrdwDpuhiDuuUeJoZLqtnRrmg/Hg4IQS+sz0cn93uh8G1amf n3xd+/HcQbAM1n7aiN3JP+NSO4nR3y4= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 clxscore=1015 impostorscore=0 suspectscore=0 phishscore=0 adultscore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030164 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783097004386158500 cpu_single_step() is not related to breakpoints. Rename the trace event. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza --- cpu-target.c | 4 ++-- trace-events | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cpu-target.c b/cpu-target.c index f030e2c642e..019906b32eb 100644 --- a/cpu-target.c +++ b/cpu-target.c @@ -31,6 +31,8 @@ void cpu_single_step(CPUState *cpu, int enabled) { if (cpu->singlestep_enabled !=3D enabled) { + trace_cpu_change_singlestep_flags(cpu->cpu_index, + cpu->singlestep_enabled, enabled= ); cpu->singlestep_enabled =3D enabled; =20 #if !defined(CONFIG_USER_ONLY) @@ -39,8 +41,6 @@ void cpu_single_step(CPUState *cpu, int enabled) ops->update_guest_debug(cpu); } #endif - - trace_breakpoint_singlestep(cpu->cpu_index, enabled); } } =20 diff --git a/trace-events b/trace-events index faeba6242fa..ea1d2b11a22 100644 --- a/trace-events +++ b/trace-events @@ -28,7 +28,7 @@ # cpu.c breakpoint_insert(int cpu_index, uint64_t pc, int flags) "cpu=3D%d pc=3D0x= %" PRIx64 " flags=3D0x%x" breakpoint_remove(int cpu_index, uint64_t pc, int flags) "cpu=3D%d pc=3D0x= %" PRIx64 " flags=3D0x%x" -breakpoint_singlestep(int cpu_index, int enabled) "cpu=3D%d enable=3D%d" +cpu_change_singlestep_flags(int cpu_index, int old_flags, int new_flags) "= cpu=3D%d flags=3D0x%x -> 0x%x" cpu_exec_start(int cpu_index) "cpu=3D%d" cpu_exec_end(int cpu_index) "cpu=3D%d" =20 --=20 2.53.0 From nobody Sun Jul 26 11:01:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783096997; cv=none; d=zohomail.com; s=zohoarc; b=E2T1LtnvDnAKqPif29voDUmtU590AYp3Dh+zP06I9xoi3+eKI7Ah1bcGlJovJ/GY7CHty4L/CoRlxgeyqZJXpeeWKO4FVNOq0tH2CPUJD8TSrkPGusYFWO6OmCL2WOKQ0qIg/vMOG+3YtfHF75u3yS726TLgt8ScZun83vc6Opk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783096997; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=mzmsO7JiXjHm5ztXYmS9Sqi5Qiq4YANCLL9fM38eAL8=; b=fpxxSfHoRy6QurKd297LtZWRvA2q8rYOleSXCJE4qqqFfEO8ZdDIhSt7/hN5Uhm3D4aYss2CrGpokwLBI1y2nM/7vuDWPXW5zpc7xRqVs8W4ZXAlizTBuIteVV8AAR0Ky6f5pya3ncHqFHva3QjgMnlncHomfrKdumeTd88v2Hc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783096997817814.0821876987607; Fri, 3 Jul 2026 09:43:17 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wfgxr-000635-OL; Fri, 03 Jul 2026 12:42:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgxp-0005zC-P4 for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:42:05 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgxn-0001tV-IR for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:42:05 -0400 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663GIpmG498312 for ; Fri, 3 Jul 2026 16:41:52 GMT Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f65qcjx4p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 16:41:52 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92ac0a54110so82263785a.2 for ; Fri, 03 Jul 2026 09:41:52 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47aa039bcdasm582623f8f.21.2026.07.03.09.41.49 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 03 Jul 2026 09:41:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mzmsO7JiXjHm5ztXYmS9Sqi5Qiq4YANCLL9fM38eAL8=; b=ITOLgYnjyfUKvkVY eolkXReOeqgiPgFCM06RtwLhxLgASVq4Lm8+0Ua1/RUc1Tv+2L7MIEf3Wpg8LWIF 0/8WqeNepjFL4xu/ng7MBP09ERfFf7CwXDfEmL9Ez/JrQCekMfJI/raOvUT28CHl l388wk4V7XqJgSqIDGnhgmm8Q2uBOYa9+ztYkQElpbBXQeCOVlldlivusaSRSwir /zEHyTyMRWl8MoYPWEkLSk89/z4zY4fTA1icFtJwfc7xZLmqBJr3tWkOnyHQ4cEj MXkxruI3+N/c7wX1xXylqMvToXnaUMcyrBLvUGqgnnAc6zywEpuu5X6XVlBqN0Kd wxJ7VA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783096912; x=1783701712; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mzmsO7JiXjHm5ztXYmS9Sqi5Qiq4YANCLL9fM38eAL8=; b=A0Fjbvx3h392qKlrU9sYtXQ5mSyVLSysuq5esy5npTrPLFrY02ek1y1XeRccfyrfc5 qW0QAqWiLSmz4BxXxIzEF5+K1rGfR8cXh6ZXd/LQdAIikhFdmOqof6e5tjv2YcXnT4JV Pb7GeqpVHlCNOirbHpiCic6llwRSqLvAkhun5Q71g7wKwIjMrZW6O+xJ6ys69bX+7q5L xu+BOSdJ0RXxdv2Jv43eok4Av6leVN4+e996dAHOOD1EfX+nisqDAoAn4eam5YRujgzP NiXpVy+GTZ7jpe6Y69zfMlUajaSUokIzXMB3/PXObCd3m0b6OOCFCAkQPHPTx/2GGHjl 9btg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783096912; x=1783701712; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=mzmsO7JiXjHm5ztXYmS9Sqi5Qiq4YANCLL9fM38eAL8=; b=fpXx33VFVY/pZWszXXxaMxDRQqSPxpv7ceBVTny8diyK03Mg90peqV/JEvMbAEOPrj iS7X1pAX7gQbj9Np1E/rly+feTysJONUIMKPZJ9Z3plNQjo3jiREcvGLdF1F1sy7d4r2 g4wI70wOtVQnaxW8FiKuJ0tO/h4srBZQSURA824RgQR2Y9j0AO1EOm6T8MjX3lGPbela neb63tyceLcsbjCQVMfpDaYtkV714iXIBe5TMFX9VvIYchA45zwo7L6XxSh9y/5Gs2PG pacKXqRqhQ4gcifdcNdTJLUythOkTF9vGS7WOejbibHEq36kS31JvlG7divImIITJANV KwZA== X-Gm-Message-State: AOJu0Yz8bl87VqXW1/9q/R+Q8ILFT8dEqILCcGiEI/VUpEK1mcs2Hrbx 8hSr/1M2O3X03+jI8LVkYqp/kL6/uPOjcjo1i2JdrCUsYZGthviU0rA2/IZxs4Q1EBMlRTwIXd3 Iagcofz+rkuMwxMiWPCgaQcMap0P+WBi9BZWf8zdPTr1f+3Oeh9JIQDxWXBrjPMtJ4w== X-Gm-Gg: AfdE7clALleO5oFpBO0r/gCW9gZXFOy6Qg3I8KRW0EDwSh2+X7T/iE7nI6QROWZg829 D1L7yes/MtWRlQSKO6umfGeSF/Jns4mZDJsXl7bF52GMcN4++B8k0AJMrOFjfrxQ4PdnvRL6ZnA HbEtYsTnzpTH7g9dTruQAkTfN/EG49QLGu5SQuKdRhryJfu8JJvVRcMerGz7ca67NiL13B5Ovg4 uP94PuqVrWXaKn1/3EgCOubE4ktvU0w4x2OleGZ1FYnlPF674f3mWkflhQDUpF2rs2Nznnv2Y4Y SGMNqNzTRYB+JiNLvL7rl7At9Lq8fDglNOZHDfv5+b63C4WKUlhaqAGC4m838x8uW3CQ7umk6H/ tDXZ4reMfzqXTTt+xYfE/gLDjNvbb6Xoym0ChCMCy7IrmHAGMQo3V7eMuD5nrAVK167y0 X-Received: by 2002:a05:620a:372a:b0:915:9125:e652 with SMTP id af79cd13be357-92e9a481185mr25490985a.48.1783096911663; Fri, 03 Jul 2026 09:41:51 -0700 (PDT) X-Received: by 2002:a05:620a:372a:b0:915:9125:e652 with SMTP id af79cd13be357-92e9a481185mr25487185a.48.1783096911143; Fri, 03 Jul 2026 09:41:51 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , Richard Henderson , qemu-s390x@nongnu.org, Xiaoyao Li , Zhao Liu , alex.bennee@linaro.org, Magnus Kulke , Peter Maydell , qemu-ppc@nongnu.org, Mohamed Mediouni , Paolo Bonzini Subject: [PATCH v2 31/33] cpu: Introduce cpu_single_stepping() helper Date: Fri, 3 Jul 2026 18:37:54 +0200 Message-ID: <20260703163757.55500-32-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260703163757.55500-1-philmd@oss.qualcomm.com> References: <20260703163757.55500-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: nEfHu10GUVQ7BypA2CmAIUEsMMsQIVuB X-Authority-Analysis: v=2.4 cv=Bb7oFLt2 c=1 sm=1 tr=0 ts=6a47e650 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=UzDBcLQVJa3M_3ASbYsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=O8hF6Hzn-FEA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: nEfHu10GUVQ7BypA2CmAIUEsMMsQIVuB X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfXzQhNpmGajA3f zdNwrLGOWuWe4Lbpa/9o62Qho+Cc3PScY11R5DB/dE/KkO0TNn5yDBXkU+BvR12ybfytVB/HntL t/ypOYFwOsMiaCIPNeecVFMpxTKNEYQBbQsh2Gq51MSbo+5CA+IM5kHQqLaO0TR2GN0wu6fHYLw s7aMj7tjwMmpeUl5y0/wOxx0SD+7iAuy/wQxH3Y+pimrDsboTUv8xYo+E7iW4zdvtn8KVmmRQlj PmvEtplhwA4+hwFFEOlHuvnzCZzXJ2Cwg98Vbtsw9ZHLFiEvdZLoZ/QQvSzhY4dpTxKzNy6Sp4x XcABYaxzxza4jpA88mQPCUpnn1RDBSz5rO4PKh5x/6kOmi9+I10eb5/Mz3aJyt9GgTTEq+dX2bR XGAay+RvCWGXZB996jnEOCeH7pfwXUNLXQtphcc4OzG0Cti3z3I3iG9IAtyM0hrbvkIlu75JzcD YtvQAmbd6UVvcuikKGw== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX2g1Hp3GVxydw rvmvai6tA6DE1WzJnL36ZJ1c7T4b+58IJASlzmGJFPtHxHxS9giKafUbdlwH0hZuTP21ipVmqqe u0kWf3kewIxO+4+IvnkMiie9Of15yds= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 clxscore=1015 impostorscore=0 suspectscore=0 phishscore=0 adultscore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030164 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783096998380158500 Access CPUState::@singlestep_enabled field with a helper. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- include/hw/core/cpu.h | 11 +++++++++++ accel/kvm/kvm-all.c | 2 +- accel/tcg/cpu-exec-common.c | 2 +- accel/tcg/cpu-exec.c | 8 ++++---- linux-user/riscv/cpu_loop.c | 2 +- linux-user/s390x/cpu_loop.c | 2 +- system/cpus.c | 2 +- target/arm/hvf/hvf.c | 8 ++++---- target/arm/kvm.c | 2 +- target/i386/kvm/kvm.c | 2 +- target/i386/whpx/whpx-all.c | 6 +++--- target/loongarch/kvm/kvm.c | 2 +- target/microblaze/translate.c | 2 +- target/ppc/kvm.c | 2 +- target/s390x/kvm/kvm.c | 2 +- 15 files changed, 33 insertions(+), 22 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 77884b827aa..b8384639141 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -1138,6 +1138,17 @@ void qemu_init_vcpu(CPUState *cpu); */ void cpu_single_step(CPUState *cpu, int enabled); =20 +/** + * cpu_single_stepping: + * @cpu: The vCPU to check + * + * Returns whether the vCPU has single-stepping enabled. + */ +static inline bool cpu_single_stepping(const CPUState *cpu) +{ + return cpu->singlestep_enabled; +} + int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, BreakpointFlags flags, CPUBreakpoint **breakpoint); int cpu_breakpoint_remove(CPUState *cpu, vaddr pc, BreakpointFlags flags); diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index feffca0d82d..963a4edd262 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -3812,7 +3812,7 @@ int kvm_update_guest_debug(CPUState *cpu, unsigned lo= ng reinject_trap) =20 data.dbg.control =3D reinject_trap; =20 - if (cpu->singlestep_enabled) { + if (cpu_single_stepping(cpu)) { data.dbg.control |=3D KVM_GUESTDBG_ENABLE | KVM_GUESTDBG_SINGLESTE= P; =20 if (cpu->singlestep_enabled & SSTEP_NOIRQ) { diff --git a/accel/tcg/cpu-exec-common.c b/accel/tcg/cpu-exec-common.c index e48ea31373f..44e84344f3b 100644 --- a/accel/tcg/cpu-exec-common.c +++ b/accel/tcg/cpu-exec-common.c @@ -47,7 +47,7 @@ uint32_t curr_cflags(CPUState *cpu) * For singlestep and -d nochain, suppress goto_tb so that * we can log -d cpu,exec after every TB. */ - if (unlikely(cpu->singlestep_enabled)) { + if (unlikely(cpu_single_stepping(cpu))) { cflags |=3D CF_NO_GOTO_TB | CF_NO_GOTO_PTR | CF_SINGLE_STEP | 1; } else if (qatomic_read(&one_insn_per_tb)) { cflags |=3D CF_NO_GOTO_TB | 1; diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index d7f91dce9db..0386ac49551 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -308,7 +308,7 @@ static bool check_for_breakpoints_slow(CPUState *cpu, v= addr pc, * so that one could (gdb) singlestep into the guest kernel's * architectural breakpoint handler. */ - if (cpu->singlestep_enabled) { + if (cpu_single_stepping(cpu)) { return false; } =20 @@ -485,7 +485,7 @@ cpu_tb_exec(CPUState *cpu, TranslationBlock *itb, int *= tb_exit) * raise a debug exception. Single-step with another exception * is handled in cpu_handle_exception. */ - if (unlikely(cpu->singlestep_enabled) && cpu->exception_index =3D=3D -= 1) { + if (unlikely(cpu_single_stepping(cpu)) && cpu->exception_index =3D=3D = -1) { cpu->exception_index =3D EXCP_DEBUG; cpu_loop_exit(cpu); } @@ -732,7 +732,7 @@ static inline bool cpu_handle_exception(CPUState *cpu, = int *ret) bql_unlock(); cpu->exception_index =3D -1; =20 - if (unlikely(cpu->singlestep_enabled)) { + if (unlikely(cpu_single_stepping(cpu))) { /* * After processing the exception, ensure an EXCP_DEBUG is * raised when single-stepping so that GDB doesn't miss the @@ -849,7 +849,7 @@ static inline bool cpu_handle_interrupt(CPUState *cpu, * raised when single-stepping so that GDB doesn't miss the * next instruction. */ - if (unlikely(cpu->singlestep_enabled)) { + if (unlikely(cpu_single_stepping(cpu))) { cpu->exception_index =3D EXCP_DEBUG; bql_unlock(); return true; diff --git a/linux-user/riscv/cpu_loop.c b/linux-user/riscv/cpu_loop.c index eecc8d15178..6f27a06da49 100644 --- a/linux-user/riscv/cpu_loop.c +++ b/linux-user/riscv/cpu_loop.c @@ -68,7 +68,7 @@ void cpu_loop(CPURISCVState *env) } else if (ret !=3D -QEMU_ESIGRETURN && ret !=3D -QEMU_ESETPC)= { env->gpr[xA0] =3D ret; } - if (cs->singlestep_enabled) { + if (cpu_single_stepping(cs)) { goto gdbstep; } break; diff --git a/linux-user/s390x/cpu_loop.c b/linux-user/s390x/cpu_loop.c index 67d2a803fbc..25f19f725e7 100644 --- a/linux-user/s390x/cpu_loop.c +++ b/linux-user/s390x/cpu_loop.c @@ -87,7 +87,7 @@ void cpu_loop(CPUS390XState *env) env->regs[2] =3D ret; } =20 - if (unlikely(cs->singlestep_enabled)) { + if (unlikely(cpu_single_stepping(cs))) { /* * cpu_tb_exec() did not raise EXCP_DEBUG, because it has = seen * that EXCP_SVC was already pending. diff --git a/system/cpus.c b/system/cpus.c index b31c825b464..97e5a5edee2 100644 --- a/system/cpus.c +++ b/system/cpus.c @@ -344,7 +344,7 @@ bool cpu_can_run(CPUState *cpu) void cpu_handle_guest_debug(CPUState *cpu) { if (replay_running_debug()) { - if (!cpu->singlestep_enabled) { + if (!cpu_single_stepping(cpu)) { /* * Report about the breakpoint and * make a single step to skip it diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index d5b1966a867..640ef665593 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -2340,7 +2340,7 @@ static int hvf_handle_exception(CPUState *cpu, hv_vcp= u_exit_exception_t *excp) case EC_SOFTWARESTEP: { ret =3D EXCP_DEBUG; =20 - if (!cpu->singlestep_enabled) { + if (!cpu_single_stepping(cpu)) { error_report("EC_SOFTWARESTEP but single-stepping not enabled"= ); } break; @@ -2549,7 +2549,7 @@ static int hvf_handle_exception(CPUState *cpu, hv_vcp= u_exit_exception_t *excp) assert_hvf_ok(r); =20 /* Handle single-stepping over instructions which trigger a VM exi= t */ - if (cpu->singlestep_enabled) { + if (cpu_single_stepping(cpu)) { ret =3D EXCP_DEBUG; } } @@ -2868,7 +2868,7 @@ void hvf_arch_update_guest_debug(CPUState *cpu) CPUARMState *env =3D &arm_cpu->env; =20 /* Check whether guest debugging is enabled */ - cpu->accel->guest_debug_enabled =3D cpu->singlestep_enabled || + cpu->accel->guest_debug_enabled =3D cpu_single_stepping(cpu) || hvf_sw_breakpoints_active(cpu) || hvf_arm_hw_debug_active(cpu); =20 @@ -2882,7 +2882,7 @@ void hvf_arch_update_guest_debug(CPUState *cpu) cpu_synchronize_state(cpu); =20 /* Enable/disable single-stepping */ - if (cpu->singlestep_enabled) { + if (cpu_single_stepping(cpu)) { env->cp15.mdscr_el1 =3D deposit64(env->cp15.mdscr_el1, MDSCR_EL1_SS_SHIFT, 1, 1); pstate_write(env, pstate_read(env) | PSTATE_SS); diff --git a/target/arm/kvm.c b/target/arm/kvm.c index 01f42f42538..d40a6a98591 100644 --- a/target/arm/kvm.c +++ b/target/arm/kvm.c @@ -1492,7 +1492,7 @@ static bool kvm_arm_handle_debug(ARMCPU *cpu, =20 switch (hsr_ec) { case EC_SOFTWARESTEP: - if (cs->singlestep_enabled) { + if (cpu_single_stepping(cs)) { return true; } else { /* diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c index 372781ae715..aef981f023f 100644 --- a/target/i386/kvm/kvm.c +++ b/target/i386/kvm/kvm.c @@ -6251,7 +6251,7 @@ static int kvm_handle_debug(X86CPU *cpu, =20 if (arch_info->exception =3D=3D EXCP01_DB) { if (arch_info->dr6 & DR6_BS) { - if (cs->singlestep_enabled) { + if (cpu_single_stepping(cs)) { ret =3D EXCP_DEBUG; } } else { diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index 11b5d1fc607..634d5428219 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -2266,7 +2266,7 @@ int whpx_vcpu_run(CPUState *cpu) } } =20 - if (exclusive_step_mode !=3D WHPX_STEP_NONE || cpu->singlestep_ena= bled) { + if (exclusive_step_mode !=3D WHPX_STEP_NONE || cpu_single_stepping= (cpu)) { whpx_vcpu_configure_single_stepping(cpu, true, NULL); } =20 @@ -2283,7 +2283,7 @@ int whpx_vcpu_run(CPUState *cpu) break; } =20 - if (exclusive_step_mode !=3D WHPX_STEP_NONE || cpu->singlestep_ena= bled) { + if (exclusive_step_mode !=3D WHPX_STEP_NONE || cpu_single_stepping= (cpu)) { whpx_vcpu_configure_single_stepping(cpu, false, &vcpu->exit_ctx.VpContext.Rflags); @@ -2648,7 +2648,7 @@ int whpx_vcpu_run(CPUState *cpu) cpu->exception_index =3D EXCP_DEBUG; } else if ((vcpu->exit_ctx.VpException.ExceptionType =3D=3D WHvX64ExceptionTypeDebugTrapOrFault) && - !cpu->singlestep_enabled) { + !cpu_single_stepping(cpu)) { /* * Just finished stepping over a breakpoint, but the * gdb does not expect us to do single-stepping. diff --git a/target/loongarch/kvm/kvm.c b/target/loongarch/kvm/kvm.c index beda6965f8c..48cdb78a4ca 100644 --- a/target/loongarch/kvm/kvm.c +++ b/target/loongarch/kvm/kvm.c @@ -1440,7 +1440,7 @@ static bool kvm_loongarch_handle_debug(CPUState *cs, = struct kvm_run *run) CPULoongArchState *env =3D &cpu->env; =20 kvm_cpu_synchronize_state(cs); - if (cs->singlestep_enabled) { + if (cpu_single_stepping(cs)) { return true; } =20 diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index a93f14d6e09..8b219afb5dd 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -1772,7 +1772,7 @@ static void mb_tr_tb_stop(DisasContextBase *dcb, CPUS= tate *cs) } =20 /* Finish DISAS_EXIT_* */ - if (unlikely(cs->singlestep_enabled)) { + if (unlikely(cpu_single_stepping(cs))) { gen_raise_exception(dc, EXCP_DEBUG); } else { tcg_gen_exit_tb(NULL, 0); diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index 85b15602396..b0c446eea7f 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -1617,7 +1617,7 @@ static int kvm_handle_debug(PowerPCCPU *cpu, struct k= vm_run *run) CPUPPCState *env =3D &cpu->env; struct kvm_debug_exit_arch *arch_info =3D &run->debug.arch; =20 - if (cs->singlestep_enabled) { + if (cpu_single_stepping(cs)) { return kvm_handle_singlestep(); } =20 diff --git a/target/s390x/kvm/kvm.c b/target/s390x/kvm/kvm.c index bb329883c97..70f450c71ab 100644 --- a/target/s390x/kvm/kvm.c +++ b/target/s390x/kvm/kvm.c @@ -1875,7 +1875,7 @@ static int kvm_arch_handle_debug_exit(S390CPU *cpu) } break; case KVM_SINGLESTEP: - if (cs->singlestep_enabled) { + if (cpu_single_stepping(cs)) { ret =3D EXCP_DEBUG; } break; --=20 2.53.0 From nobody Sun Jul 26 11:01:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783097017; cv=none; d=zohomail.com; s=zohoarc; b=T0CiFZaWXq7ndG8+oQLpyV6Ckr78dVPJY+6tSirgIPkYQOVEbL+QNjZOy0TUg+24skCOuJxyJjrAdmtV/sCS4TsOLiVnPaMT9n2QEfixu2jrttRAAQAxZUGsmThI6YSC1aYTIgizlvrWRCxfAt5FmKcF6BbXa7UqIq2VWDiLHgc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783097017; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Qw4cCSv0OfNGNoPPLFfy1LxGtAqB0K1HAPyDpQ8GAco=; b=GtHNAgxuUtMILWuARvbCCs/vM6+cddM37+8R9xpRZX8GVSzH75Q2RSEKhjAzeWTXPLtpEjYisEdX5OucAm6zatJHMqTFxUuzJG3UIAmUeSAr/XId/qVfAtPUeymbYfohpPYNcLcz78PvH2t1wMVhol8ltNYC42A/qjNoUfw6tfE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783097017171522.8230169594525; Fri, 3 Jul 2026 09:43:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wfgxz-0006Kp-VA; Fri, 03 Jul 2026 12:42:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgxw-0006It-Ry for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:42:12 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgxu-0001wH-Mu for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:42:12 -0400 Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663GIZFL489304 for ; Fri, 3 Jul 2026 16:41:59 GMT Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f6ckj101s-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 16:41:59 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-92158791d14so64952785a.2 for ; Fri, 03 Jul 2026 09:41:59 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47a9b4d850dsm764306f8f.0.2026.07.03.09.41.57 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 03 Jul 2026 09:41:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Qw4cCSv0OfNGNoPPLFfy1LxGtAqB0K1HAPyDpQ8GAco=; b=dXqT2CTiU8EETd2O QkkeAAJ67NritPQ9nJvjVWYGw7EKqz0oPh14oEWoD2J+wYfQuAORQWjL8ypZHNgv ssvy1QJFAidv3WZv4JEWF5YCDmbC4d2TIdy0qk0y8+GxQCzdNc+0S63TD4+gSecZ jcSBt1D2PQ9zfORlYlKpRLzA0nank3SqcdEKFVMPGoNns2MYnobMDAGzOH5qtIwQ P3GaQi4YaAD6fKBK7b/ie18EN2VNfz3nTztoFiGKgCfgUmk7+gV6P0RArNJz7pdv LyCmg/NoBAAaIya9UNs4sEh/waS9NnWQimB1pXuhaDBbCxAe1HQbMrn3pAh7Vv9f 3jbeJQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783096919; x=1783701719; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Qw4cCSv0OfNGNoPPLFfy1LxGtAqB0K1HAPyDpQ8GAco=; b=MVzxHNshWS5je7xzk68JdpNDXCj4L+tUT5zqWVI7B+rVrKop1v3GllScnpKFci48Li HWRD8L+JfX+Miwev+CYQrsWqoqSmbSsivp/+ALi8lK7+q5BIGQBOKyKvIhmisVyCBZEH afbxGfr64D5HvMlOnmqHseCLao9zleu6hr4pxzE/12mswmdieyxZ+CFn4K4Ekye0fRrS Sxmp/Dioe2SfScLvP4WKWj/5eDxtMkIojQrXTYT7TksxIsGE4gXbgo8ftZxW2ddTpZ1b TxhbzQYK8IOqdppg0iVxrr/4C2PQOViFhMX2UIO9XBEQGEP+nVOzXDlzKtD2Sch8bkXT DUDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783096919; x=1783701719; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Qw4cCSv0OfNGNoPPLFfy1LxGtAqB0K1HAPyDpQ8GAco=; b=gcdBKHD9zn2LTflvTR6WLTnEbAdx6UHX3JBpNqxroy7cLvm7XmP6yGUAlpDAEEhBOe N2JHNof/cPbI2cdh5Cnu87V9NILGscPkxLG/xGAmFz5c3DFNEEscKXfGWQ8LkgHeNFQs G5VujDsTcx4LZgiDUOq+XvrRcfSIB/veg62lGw6/lVirTO7pLOYzDr8JAHDuf+/38P20 Bl2FyYrghxMjMWPd/VzkNCvbZI4BbbBi7dTC4FRygMmPN4ziuL7eqopeykFAQ06ejX3B VV3Fj58M4SrJ+RqQ4P73qN4wdlJIhLm2yQnxdYKUDDAtkFOvATIBUuRA1piL1gDtppZ8 NxXQ== X-Gm-Message-State: AOJu0YzXSxAF41KqO40sqyXJ4XSK8GLRnZa+ZA+TUO0HIn9bJxtjJIWs em58P6tMa0mzJvRq0cLVUULfYHp3CBp6ZD3ocFHh1gbyZlsy6BsDXZeJaDQFx7Ju7WOOcPmEjIC B/4KwPcoeqI4zSHsCMY4vNt2qLX+Ttx9wnIjDlYXFwZDaTGb1y2mJaF7bPmg85VXPhw== X-Gm-Gg: AfdE7cnSXr6ac7VD9bUUoMBDKEEK31IcFYZOGvdZERfRTB0lQKAwpltuDA2uuH+cUwX E3mRxpzeWKcJR64lN5udNYr/f84vish5dS5QtfGz3DCC8b5ob2sAD7xgh7i49AHir19I39Ar4lh DcFrCdRCV1aMNn0gLL95CjomuxYMxqgNRbMo2GHJD+izCPoMBOOt+Ytn/8cUNCNjYDJIxAQNXET SeqdSfqbyyJyYKRA8F29iPq3jc/sO1VUw4iqVkDg2PusO8XTeJrR6dPXwHaJhrI4fzacs7yNXiB +f4EitBDOYaTFgl3XQICH9QYhjX4osxLW5b1cKD3yGw/s8/qg64DxCTy8QpOfdJYwC/mLpnqzMV 6iowJzMtoAcxEdgZGIo/VyglbgQpbzWy+Z4py/kHBIQFtsRYiCcTkrzXpsRWBcL8T7xOo X-Received: by 2002:a05:620a:6847:b0:92b:67e6:8acc with SMTP id af79cd13be357-92e9a535a8bmr20662085a.70.1783096918949; Fri, 03 Jul 2026 09:41:58 -0700 (PDT) X-Received: by 2002:a05:620a:6847:b0:92b:67e6:8acc with SMTP id af79cd13be357-92e9a535a8bmr20658485a.70.1783096918412; Fri, 03 Jul 2026 09:41:58 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , Richard Henderson , qemu-s390x@nongnu.org, Xiaoyao Li , Zhao Liu , alex.bennee@linaro.org, Magnus Kulke , Peter Maydell , qemu-ppc@nongnu.org, Mohamed Mediouni , Paolo Bonzini Subject: [PATCH v2 32/33] cpu: Rename CPUState @singlestep_enabled -> @singlestep_flags Date: Fri, 3 Jul 2026 18:37:55 +0200 Message-ID: <20260703163757.55500-33-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260703163757.55500-1-philmd@oss.qualcomm.com> References: <20260703163757.55500-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfXyZ5rk4IJNvFz 6febD/tFwSqdLcN/V1e4qnvHNoYQGCVbLs699LJHL1nHw+Lxj3Yd7dsvtuQMW+5DLff4565+mJD Tsxo3JIWqb0w4to5BY0ds+N0j2Uurcs= X-Authority-Analysis: v=2.4 cv=E8v9Y6dl c=1 sm=1 tr=0 ts=6a47e657 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=Psl2LI6oLFdwa_E3teoA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=O8hF6Hzn-FEA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: Mgz6nrBEtkMhRpMQ2E9PH-kKgzaT8AyM X-Proofpoint-GUID: Mgz6nrBEtkMhRpMQ2E9PH-kKgzaT8AyM X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX+6vteSt3TgTl aZEcQq2q0EuyWABy9jratvroiI1SN23GfVyTHcclgcSVmjSbHA/66MQVk+OxsfI5iV3AeBYLv4x VMDoTXZ5iLsvyKuJh+Vu0A0dFkQScYrlLUqDiBgVfVUlU+kQYdsSK3HXsDZpZDdcpNm9dVNr+Gv TGfD1LEu4iVLhuSesxfIXSauGWdON8UrZsGxg2BK1OJNLlS6hLtf1DYp74weNw/Yq20eNtYimOA eFg699nrSCldRXLSMtiC8+pZ7G1VuUFRgGNcjXEbdOSb3BiVKR46mFTmqENU6J4yk0gPK2cDMMI zPoAh5akc/o0QSaFsgCJYv9tgZOJXMdTSrz9ziB6XJngKrs80wNj2zxqUsF+w1bRn0N2m9wv5Ma 6pQo+QeDUIsP/Fy3kKj+u04mj4ClEa4ViA+vBIn6KF60cVNduXIvRvfi05qfx76Zo3xsTBzxi8B Y6shDSNXB9NP03zpR3A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 phishscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 suspectscore=0 adultscore=0 malwarescore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030164 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783097018590158500 CPUState::singlestep_enabled contains multiple flags since commit 60897d369f1 ("Debugger single step without interrupts"). Use an unsigned type and rename the field to avoid mistakes. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- include/hw/core/cpu.h | 10 +++++----- accel/kvm/kvm-all.c | 2 +- accel/tcg/cpu-exec.c | 2 +- accel/tcg/tcg-accel-ops-rr.c | 2 +- cpu-target.c | 8 ++++---- target/arm/hvf/hvf.c | 2 +- target/ppc/translate.c | 16 ++++++++-------- 7 files changed, 21 insertions(+), 21 deletions(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index b8384639141..31f1d787352 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -440,7 +440,7 @@ struct qemu_work_item; * @stopped: Indicates the CPU has been artificially stopped. * @unplug: Indicates a pending CPU unplug request. * @crash_occurred: Indicates the OS reported a crash (panic) for this CPU - * @singlestep_enabled: Flags for single-stepping. + * @singlestep_flags: Flags for single-stepping. * @icount_extra: Instructions until next timer event. * @cpu_ases: Pointer to array of CPUAddressSpaces (which define the * AddressSpaces this CPU has) @@ -505,7 +505,7 @@ struct CPUState { int exclusive_context_count; uint32_t cflags_next_tb; uint32_t interrupt_request; - int singlestep_enabled; + unsigned singlestep_flags; int64_t icount_budget; int64_t icount_extra; uint64_t random_seed; @@ -1132,11 +1132,11 @@ void qemu_init_vcpu(CPUState *cpu); /** * cpu_single_step: * @cpu: CPU to the flags for. - * @enabled: Flags to enable. + * @flags: Flags to enable. * * Enables or disables single-stepping for @cpu. */ -void cpu_single_step(CPUState *cpu, int enabled); +void cpu_single_step(CPUState *cpu, unsigned flags); =20 /** * cpu_single_stepping: @@ -1146,7 +1146,7 @@ void cpu_single_step(CPUState *cpu, int enabled); */ static inline bool cpu_single_stepping(const CPUState *cpu) { - return cpu->singlestep_enabled; + return cpu->singlestep_flags; } =20 int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, BreakpointFlags flags, diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 963a4edd262..83cbd120a84 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -3815,7 +3815,7 @@ int kvm_update_guest_debug(CPUState *cpu, unsigned lo= ng reinject_trap) if (cpu_single_stepping(cpu)) { data.dbg.control |=3D KVM_GUESTDBG_ENABLE | KVM_GUESTDBG_SINGLESTE= P; =20 - if (cpu->singlestep_enabled & SSTEP_NOIRQ) { + if (cpu->singlestep_flags & SSTEP_NOIRQ) { data.dbg.control |=3D KVM_GUESTDBG_BLOCKIRQ; } } diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 0386ac49551..257211235db 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -828,7 +828,7 @@ static inline bool cpu_handle_interrupt(CPUState *cpu, return true; } =20 - if (unlikely(cpu->singlestep_enabled & SSTEP_NOIRQ)) { + if (unlikely(cpu->singlestep_flags & SSTEP_NOIRQ)) { /* Mask out external interrupts for this step. */ interrupt_request &=3D ~CPU_INTERRUPT_SSTEP_MASK; } diff --git a/accel/tcg/tcg-accel-ops-rr.c b/accel/tcg/tcg-accel-ops-rr.c index 5b132d3d5d8..cdaa3e11808 100644 --- a/accel/tcg/tcg-accel-ops-rr.c +++ b/accel/tcg/tcg-accel-ops-rr.c @@ -274,7 +274,7 @@ static void *rr_cpu_thread_fn(void *arg) current_cpu =3D cpu; =20 qemu_clock_enable(QEMU_CLOCK_VIRTUAL, - (cpu->singlestep_enabled & SSTEP_NOTIMER) = =3D=3D 0); + (cpu->singlestep_flags & SSTEP_NOTIMER) =3D= =3D 0); =20 if (cpu_can_run(cpu)) { int r; diff --git a/cpu-target.c b/cpu-target.c index 019906b32eb..4783845c9bf 100644 --- a/cpu-target.c +++ b/cpu-target.c @@ -28,12 +28,12 @@ =20 /* enable or disable single step mode. EXCP_DEBUG is returned by the CPU loop after each instruction */ -void cpu_single_step(CPUState *cpu, int enabled) +void cpu_single_step(CPUState *cpu, unsigned flags) { - if (cpu->singlestep_enabled !=3D enabled) { + if (cpu->singlestep_flags !=3D flags) { trace_cpu_change_singlestep_flags(cpu->cpu_index, - cpu->singlestep_enabled, enabled= ); - cpu->singlestep_enabled =3D enabled; + cpu->singlestep_flags, flags); + cpu->singlestep_flags =3D flags; =20 #if !defined(CONFIG_USER_ONLY) const AccelOpsClass *ops =3D cpus_get_accel(); diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index 640ef665593..f5dd7e8e029 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -2603,7 +2603,7 @@ int hvf_arch_vcpu_exec(CPUState *cpu) flush_cpu_state(cpu); =20 do { - if (!(cpu->singlestep_enabled & SSTEP_NOIRQ) && + if (!(cpu->singlestep_flags & SSTEP_NOIRQ) && hvf_inject_interrupts(cpu)) { return EXCP_INTERRUPT; } diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 3f6d326cef3..06ed2adf105 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -198,7 +198,7 @@ struct DisasContext { bool pmu_insn_cnt; bool bhrb_enable; ppc_spr_t *spr_cb; /* Needed to check rights for mfspr/mtspr */ - int singlestep_enabled; + int singlestep_flags; uint32_t flags; uint64_t insns_flags; uint64_t insns_flags2; @@ -367,7 +367,7 @@ static void gen_debug_exception(DisasContext *ctx, bool= rfi_type) #if !defined(CONFIG_USER_ONLY) if (ctx->flags & POWERPC_FLAG_DE) { target_ulong dbsr =3D 0; - if (ctx->singlestep_enabled & CPU_SINGLE_STEP) { + if (ctx->singlestep_flags & CPU_SINGLE_STEP) { dbsr =3D DBCR0_ICMP; } else { /* Must have been branch */ @@ -3645,7 +3645,7 @@ static void pmu_count_insns(DisasContext *ctx) =20 static inline bool use_goto_tb(DisasContext *ctx, target_ulong dest) { - if (unlikely(ctx->singlestep_enabled)) { + if (unlikely(ctx->singlestep_flags)) { return false; } return translator_use_goto_tb(&ctx->base, dest); @@ -3653,7 +3653,7 @@ static inline bool use_goto_tb(DisasContext *ctx, tar= get_ulong dest) =20 static void gen_lookup_and_goto_ptr(DisasContext *ctx) { - if (unlikely(ctx->singlestep_enabled)) { + if (unlikely(ctx->singlestep_flags)) { gen_debug_exception(ctx, false); } else { /* @@ -6559,13 +6559,13 @@ static void ppc_tr_init_disas_context(DisasContextB= ase *dcbase, CPUState *cs) ctx->pmu_insn_cnt =3D (hflags >> HFLAGS_INSN_CNT) & 1; ctx->bhrb_enable =3D (hflags >> HFLAGS_BHRB_ENABLE) & 1; =20 - ctx->singlestep_enabled =3D 0; + ctx->singlestep_flags =3D 0; if ((hflags >> HFLAGS_SE) & 1) { - ctx->singlestep_enabled |=3D CPU_SINGLE_STEP; + ctx->singlestep_flags |=3D CPU_SINGLE_STEP; ctx->base.max_insns =3D 1; } if ((hflags >> HFLAGS_BE) & 1) { - ctx->singlestep_enabled |=3D CPU_BRANCH_STEP; + ctx->singlestep_flags |=3D CPU_BRANCH_STEP; } } =20 @@ -6641,7 +6641,7 @@ static void ppc_tr_tb_stop(DisasContextBase *dcbase, = CPUState *cs) } =20 /* Honor single stepping. */ - if (unlikely(ctx->singlestep_enabled & CPU_SINGLE_STEP)) { + if (unlikely(ctx->singlestep_flags & CPU_SINGLE_STEP)) { bool rfi_type =3D false; =20 switch (is_jmp) { --=20 2.53.0 From nobody Sun Jul 26 11:01:48 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1783097015; cv=none; d=zohomail.com; s=zohoarc; b=Avk1L0MeVkxfFrspui5PJdSCza8Ybd07gsP6g36qToYvAZku+m29l38mL3uqXXT45eVTMGgBkFNTMP5AJ3iepKaYEV9DVZZIadfa5jYVsJ5wgJkA6vcx1mLlHWYUusZBbm4Z1DIroWgAtsXHUvbq3NxEGjXFrpv+J0URN4B41lQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783097015; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Uj95z83/1sCENjH/Xd8wZ3dfLnySSTwmBS0AlA6qk1w=; b=EXN6Uiczy2S9f3KBCB6191CE0zc3EEFwh7YL2bhmcBOyZMvGkIKzYvk1AsH4tyG79oMYHIjPC5n7Vtrukbqryzo+iVsHS2z0YbDkhlYcpwOyHn0C+7p2GdiELAsrqpS1ZAUSQB8h6dDb3ymMCgD9xn63v9THbx3uV7tKKoTdbdY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1783097015232189.24507883751016; Fri, 3 Jul 2026 09:43:35 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wfgyC-0006Ze-BO; Fri, 03 Jul 2026 12:42:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgy6-0006YA-KR for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:42:22 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wfgy1-0001zx-OS for qemu-devel@nongnu.org; Fri, 03 Jul 2026 12:42:21 -0400 Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 663GIx70348410 for ; Fri, 3 Jul 2026 16:42:06 GMT Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f648n38mm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 03 Jul 2026 16:42:06 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-92da6f3cc81so89855285a.2 for ; Fri, 03 Jul 2026 09:42:06 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47a9de1d8f1sm646199f8f.3.2026.07.03.09.42.04 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 03 Jul 2026 09:42:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Uj95z83/1sCENjH/Xd8wZ3dfLnySSTwmBS0AlA6qk1w=; b=IA9dqBZ5yivJIbfp tmgI83yN4jzWpxnI3BnhvWHOcAa73ga56SQmcIVsxUNVOH8NmynbdHW/WtGE+bnp 44OOAk4VSnRUc8PdniGRD/1f2w/iKJsxkLhz+r0dJ5iKH4CtiJPglyUZqcfRdIWR tGrJkomCoi2CzMZQxtsi4YbUk8ASMmDY1hM42Ed0czTGfktpkA1viE/zwbCDk5UT erIggHBRW4wDWLjir4RIrnFy0wj5nyFGmOtXuDMAtLYqiZ5BbpxyD3SjW3Ht/bK6 tGDusJYGDdbbe35ZyRyRzr4rGqcvc33WiC6kpFiOyeBlXYvIK+qafzpB3eq1tb9y TDTQRA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783096926; x=1783701726; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Uj95z83/1sCENjH/Xd8wZ3dfLnySSTwmBS0AlA6qk1w=; b=Jk8CrKTSBLgOJUoNpA/Jy0/SQlDvdYvKj91HlWmF0xh8w9cJ+yWglbnuvwPQKXUmz7 F6ayl8sdzPfxI0bNlMgpfQVy8OuxCHBPUnuWF4JpVJpvpKgf5DZ/Ajv3k+0FHlM6CizF AbomDLpavUq3DbQkvpnPUqBdTFifizqxVwQ6SJvVQ9RGFw9WNUJHMbpcw7SoKt1bbksI 8lRCpX860eMat9tyunFg5lFHi+aTUtUdJCDHoEAW3lPpfMfJSR36r2Dr0D34gM7KD5o+ tTcv3Y38w8xDa40oww3qIKICPF5YDGhfPsg7PDJ/oyqErcO+qKCP6P9ibyos3WBag1lR SSAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783096926; x=1783701726; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Uj95z83/1sCENjH/Xd8wZ3dfLnySSTwmBS0AlA6qk1w=; b=F2hAWGfQ4uMKbQ8HwO5FRs6hTUIRkypwjcspP8CqmhTTSMUvA/Pja2vDFRFIIMi9TW nCQXtPimY8RBnbQK8OZCwH2a0DNkAWY1bgW5z3olo9/jM5nSt/k+4rAHJlrpUIckTjg5 CaPDCL4KH0IOIjU+RAyVu4YFOD0eE41vXvbwSIfJKBBz+DlkjTF7RzE86jDSgy7IE7Sw RFr/uXm0vvzMfIy97a6grxiLOOxFR9rsrF38UoLCafrpMi2Y08bu2kyuaFWyJOnNholI smVlwBUE+xcAl++yJHpUk7/CVwKJ/e+04q/DjHo/dABN0z/kAyQdq4k7z/MPwuqELOdk bqCQ== X-Gm-Message-State: AOJu0YxsYV1mbjZc1la4atGoQ+Jb67xDqo68XIFIZ2XGLDaMf9bQjhcY jwv1l7iuAHxDCyEp55t5OktR2Bd2bIA7ZrQnDtq9yMshfhT/biP8xPaRtgSPOluvMHdP2g0xKM/ x0z8WHqtBBW/Jggh/3+6yjUdgt269Nc2xq0YIqVzBdgf+TABygE0jS4FZ/TvRoWsNVA== X-Gm-Gg: AfdE7cmL2nUXHXrxO+BRwPNTW6kRH/7fBK6xYNzUYpdU+OgwCT/m8H+8hSZzdpHuaE8 tK1khlFVwXbxpKaVf8axDyb7z2QHpnwN3bvR7ooqhi5sx4YTWvvJrupR3EUOBYoY0hCeoYtBUix 8eFW7c8LQs19Bs0Ii5c9iMQgbAXkNAK8ZJvLPeBBFdMLa8AxtALTZIFMNMjE5JxUxdSP9HPFRf5 pCyEe70Pe3n7c4vfPgaUZjNFf8FwvYoEp8+2jNW036WsBULNAthYKKD+s3+qEcyOgQEq8PeJp3c uXpczD+P7RnqKvqX/XikzuTO1mKT39c8oUi0gn/v+pcT7BkMBuuK9JjL6uL091hVsE5CM1MTrZz qFzzd4HubcWT8JDLrAk0b9qTlB84+cHA9aiORPSlhyakH8oHiwKEAb5FdtE0d1LvPfaGu X-Received: by 2002:a05:620a:27c1:b0:92e:745c:6c48 with SMTP id af79cd13be357-92e9a4a1518mr24362685a.34.1783096926206; Fri, 03 Jul 2026 09:42:06 -0700 (PDT) X-Received: by 2002:a05:620a:27c1:b0:92e:745c:6c48 with SMTP id af79cd13be357-92e9a4a1518mr24359185a.34.1783096925675; Fri, 03 Jul 2026 09:42:05 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Chao Liu , Richard Henderson , qemu-s390x@nongnu.org, Xiaoyao Li , Zhao Liu , alex.bennee@linaro.org, Magnus Kulke , Peter Maydell , qemu-ppc@nongnu.org, Mohamed Mediouni , Paolo Bonzini Subject: [PATCH v2 33/33] cpu: Only check SSTEP_ENABLE flag in cpu_single_stepping() Date: Fri, 3 Jul 2026 18:37:56 +0200 Message-ID: <20260703163757.55500-34-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260703163757.55500-1-philmd@oss.qualcomm.com> References: <20260703163757.55500-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX/VT6ay9qO8LS XcgMrMrMGCwovQ2knVEKqegiHr07283hU017I3raMsU9RKCamRXi/ha2oa6YVOV/YLMSx8opWrG T7WbHSmpSyigSxVK9tcg2GWQZG79gjo= X-Proofpoint-ORIG-GUID: duDqyRwls9rYCU45v8GI6-DNKyh7-leB X-Authority-Analysis: v=2.4 cv=O4wJeh9W c=1 sm=1 tr=0 ts=6a47e65e cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=67IpyjWKbRJXbWkAkIEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: duDqyRwls9rYCU45v8GI6-DNKyh7-leB X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAzMDE2NCBTYWx0ZWRfX2oRRV17h/E4g qYUDS2+7OgKQWM7eLxo+pdsZgYQ0pBVOfp4TBtEaT0Vt/kTlSt8i8xzhnctEx6dGmh+hvUuFxTA 0P0F7suJ/wryDA8XHpb2AEz8Np3Ax2HZ//V1kA5TYxa1FyCU/wdNshpO6nxneaeOieBaZQxKFkw ZYtCllr5qOqXO8loHCQS7Ogd6RuRUzbLctytIShXbvp7qyK6OoyhGhZhC39+Xm8dxzLCMHPybM/ rE6jbulrdsw9QMP0HCGyndv3JR6Q1byjihasQSrwxLUv3Qn+gdP4j9bbiKtHji3vp1D+WyLxMut ztMXf1lMfyRFa9N+MjQFOAfG4mIz5GX4JerxoiISyUZo1JCgpk+wnmrycLMae896rebTdROaUES ee7RZKB9jMK8XtWw26/XHbF3FelcV0EJHFHM/BuIwmKSAfa1pi3xsNRj5oQ5k5GMuA6m1ckZNqc WJETZMTD3b9ab+bL8+Q== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-03_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 phishscore=0 suspectscore=0 malwarescore=0 spamscore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607030164 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1783097016488158500 Only the SSTEP_ENABLE bitmask means single-step is enabled. Fixes: 60897d369f1 ("Debugger single step without interrupts") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel Henrique Barboza Reviewed-by: Richard Henderson --- include/hw/core/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 31f1d787352..0d14ba49782 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -1146,7 +1146,7 @@ void cpu_single_step(CPUState *cpu, unsigned flags); */ static inline bool cpu_single_stepping(const CPUState *cpu) { - return cpu->singlestep_flags; + return cpu->singlestep_flags & SSTEP_ENABLE; } =20 int cpu_breakpoint_insert(CPUState *cpu, vaddr pc, BreakpointFlags flags, --=20 2.53.0