From nobody Sun Jul 26 11:08:51 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=swemel.ru ARC-Seal: i=1; a=rsa-sha256; t=1782903947; cv=none; d=zohomail.com; s=zohoarc; b=eOcu9QczqysJQUnUOmzo36xc3I5a4gkIZ4acFwqqPWcZR8ZLN2rgm/gPQ1lBH0GWHlTbpCzkWy+KO8BOOqojOJpunngcK6w0JkApZdoLUUtQw6/NN3ySvZvEMyrWcNxEbGyABQuAENyCaEfEGOBufFqB+ovPRtGG66nOsFILbWI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782903947; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=BDEB7d4RS2J/OdI+LujNzf+f37NhDwFNn9l3zwEvxlQ=; b=VRwCxf3WfMPuuO/e2jSrrGxxrc5Po4uqiGrZ/X5wjPf6oC8NICZY6iCAlZc/+FTpdDuTb447uLyVFtiVQou2Ee8gaQKtjLDaTcol/iBVwA3xwBgC7Bld0kZqM+h94Pu/GL5L0Y8t/yJO336tF0KKdk8oMi2tSD2WGuzh9Dr4rVk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782903946251458.95853624496124; Wed, 1 Jul 2026 04:05:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1weskb-0004j3-2B; Wed, 01 Jul 2026 07:05:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1weskZ-0004iH-99 for qemu-devel@nongnu.org; Wed, 01 Jul 2026 07:05:03 -0400 Received: from mx.swemel.ru ([95.143.211.150]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1weskX-0005WD-1K for qemu-devel@nongnu.org; Wed, 01 Jul 2026 07:05:03 -0400 From: Dmitry Frolov DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=swemel.ru; s=mail; t=1782903895; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=BDEB7d4RS2J/OdI+LujNzf+f37NhDwFNn9l3zwEvxlQ=; b=QNkqg0LCQTpSosE57cPwbY5YVCdIMIlqBwJ+mpcuTzcTAoiI9/iqNmtB4IYeT15nMyYWQC 4NlQKosVvJ4uCDQDfipK9vpuxZKmIAtfxslZYI3vq0UGhSsh0JH5MATvWTlRsyPhCN53G6 2NdfM6ft+oIOstZwdtVJqb1kCC0PfEo= To: pbonzini@redhat.com Cc: sdl.qemu@linuxtesting.org, qemu-devel@nongnu.org, Dmitry Frolov Subject: [PATCH] hw/scsi/megasas: fix-heap-buffer-overflow Date: Wed, 1 Jul 2026 14:03:54 +0300 Message-Id: <20260701110353.1426847-1-frolov@swemel.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=95.143.211.150; envelope-from=frolov@swemel.ru; helo=mx.swemel.ru X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @swemel.ru) X-ZM-MESSAGEID: 1782903953988158500 Content-Type: text/plain; charset="utf-8" The type of cmd->frame is mfi_frame. So it should be able to hold the whole mfi_io_frame, including union mfi_sgl sgl. But only frame_size bytes are allocated, which is enough to store union mfi_sgl sgl only. Signed-off-by: Dmitry Frolov --- hw/scsi/megasas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c index 9e712721f8..0ddd11ccda 100644 --- a/hw/scsi/megasas.c +++ b/hw/scsi/megasas.c @@ -488,7 +488,7 @@ static MegasasCmd *megasas_enqueue_frame(MegasasState *= s, { PCIDevice *pcid =3D PCI_DEVICE(s); MegasasCmd *cmd =3D NULL; - int frame_size =3D MEGASAS_MAX_SGE * sizeof(union mfi_sgl); + int frame_size =3D MEGASAS_MAX_SGE * sizeof(union mfi_sgl) + MFI_FRAME= _SIZE; hwaddr frame_size_p =3D frame_size; unsigned long index; =20 --=20 2.34.1