From nobody Sun Jul 26 11:08:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=free.fr ARC-Seal: i=1; a=rsa-sha256; t=1782936647; cv=none; d=zohomail.com; s=zohoarc; b=iJyg72uyM5CT0tIqlHE9o9Rs1VSzFkoC1IXJ8/vzIIk8XqZwgV9Ui70DuCbaDSLMLk1Mjq4mDZUzYsqVcDyK7dLS2U5jmSJR141+KXvFA/kurM4lJYaOWnVw3BhJ0+Ru6XoY4L3ytySipTKM6Xnj06PouCLbRkze2zLh51oBNkk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782936647; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=0Yc+EjFJqivyoeL90RnumSxv+8xy0eOigdSGNH4Tw9I=; b=efYyBoV/0onwIdQekp/05/iaA2LEdD0vYRp/Ua1EdaY42TKnQkooWvGtCby6jLrF2UQ4xxLhGX+muvSDxKE5I+MVCa6/3vNfH1uRjbW4R1yLu+YO/L6kdWmSB3VjfUzEMqI+s98RVkclkMf3uBJbaCm5I4NvSc15Q6dcGvsGLfk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782936646833978.9458767639701; Wed, 1 Jul 2026 13:10:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wf1F5-0001sB-Qr; Wed, 01 Jul 2026 16:09:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1weykZ-0007vK-9T; Wed, 01 Jul 2026 13:29:27 -0400 Received: from smtp2-g21.free.fr ([2a01:e0c:1:1599::11]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1weykW-0006H8-5e; Wed, 01 Jul 2026 13:29:27 -0400 Received: from localhost (unknown [89.92.102.124]) (Authenticated sender: emmanuel.blot@free.fr) by smtp2-g21.free.fr (Postfix) with ESMTPSA id 1C4D02003CE; Wed, 1 Jul 2026 19:29:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1782926962; bh=Pc07m1439h4/qkGJL56iMfnHS7u7mdmhSclvURwFZlg=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=dcqoie82Gy3mtgeqc8qCE+WND30AqZT994pxspya8T2eMhZPb3gRQR9trHpBeDcJU h6wYM9QyN68DEyeR/KmYluX1GrK7Pm5Oq6z/Z33RXaKuDz6mG+2S6EdGF8ZcnzRg/y 147StTa1Qv5kYdHKvHcpPoeqvptmd4m4v6UbCdyUDtkSk+ePQh2zIkCJbzdDJgU/tk 2GRkfEJtHfmumHU1DspThplszLq0ZCSDhzu9/nVIwh4QCfGkcs1QyNWvZ2ofJytTXF Vk2FAToFFhuS6Mhlhtt3dzGlL0q0AAG3Q+qMOdawB8ySdtBuv6a1EsP98w7hZi29IA Mnqe/PmKwpJzQ== From: Emmanuel Blot Date: Wed, 01 Jul 2026 19:28:31 +0200 Subject: [PATCH v5 1/8] hw/sensor: adc128d818: add 12-bit 8-channel ADC device MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260701-i2c-adc128d818-anacapa-v5-1-fe8292d86b38@free.fr> References: <20260701-i2c-adc128d818-anacapa-v5-0-fe8292d86b38@free.fr> In-Reply-To: <20260701-i2c-adc128d818-anacapa-v5-0-fe8292d86b38@free.fr> To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Fabiano Rosas , Laurent Vivier , Peter Maydell , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Steven Lee , Troy Lee , Jamin Lin , Kane Chen , Andrew Jeffery , Joel Stanley , Alexander Hansen , William de Abreu Pinho , Emmanuel Blot , qemu-arm@nongnu.org, Emmanuel Blot , Corey Minyard X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1782926919; l=24844; i=emmanuel.blot@free.fr; s=20260602; h=from:subject:message-id; bh=Pc07m1439h4/qkGJL56iMfnHS7u7mdmhSclvURwFZlg=; b=PYKvgpl+EgSZUT2qaUe9lLtl9VymarrlXfENpChl5yg86G+TquHcZSLaDDqLJemg4cvNyio05 5T+LkxSZdjFBv7RIzkiNGPSqmqcM1pup+GHmHVgKiBaqwagV1DDrPtc X-Developer-Key: i=emmanuel.blot@free.fr; a=ed25519; pk=0qFrZ21FAAN8OfVsSoVcCFTk/NMYOWzxJz4paSAVm0g= Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:e0c:1:1599::11; envelope-from=emmanuel.blot@free.fr; helo=smtp2-g21.free.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 01 Jul 2026 16:09:06 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @free.fr) X-ZM-MESSAGEID: 1782936650617158500 The ADC128D818 is a TI 12-bit, 8-channel I2C ADC used on several OpenBMC platforms for voltage and temperature monitoring. Implement the device with: - four operating modes - 12-bit voltage conversion from QOM inputs - 9-bit temperature conversion from milli-degree Celsius QOM inputs - switchable internal or external voltage reference - per-channel high/low limit registers - interrupt support - software reset - one-shot conversion support in shutdown mode Reviewed-by: Alexander Hansen Tested-by: Alexander Hansen Signed-off-by: Emmanuel Blot --- hw/sensor/Kconfig | 4 + hw/sensor/adc128d818.c | 696 +++++++++++++++++++++++++++++++++++++= ++++ hw/sensor/meson.build | 1 + hw/sensor/trace-events | 8 + include/hw/sensor/adc128d818.h | 14 + 5 files changed, 723 insertions(+) diff --git a/hw/sensor/Kconfig b/hw/sensor/Kconfig index bc6331b4ab..b459ac2240 100644 --- a/hw/sensor/Kconfig +++ b/hw/sensor/Kconfig @@ -1,3 +1,7 @@ +config ADC128D818 + bool + depends on I2C + config TMP105 bool depends on I2C diff --git a/hw/sensor/adc128d818.c b/hw/sensor/adc128d818.c new file mode 100644 index 0000000000..c65508cba1 --- /dev/null +++ b/hw/sensor/adc128d818.c @@ -0,0 +1,696 @@ +/* + * Texas Instruments ADC128D818 12-bit 8-channel ADC with I2C interface + * + * Copyright (c) 2026 Meta Platforms, Inc. and affiliates. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include "qemu/osdep.h" +#include "qemu/log.h" +#include "qapi/error.h" +#include "qapi/visitor.h" +#include "qom/object.h" +#include "hw/sensor/adc128d818.h" +#include "hw/core/irq.h" +#include "hw/core/qdev-properties.h" +#include "hw/i2c/i2c.h" +#include "migration/vmstate.h" +#include "trace.h" + + +/* Register addresses */ +#define REG_CONFIG 0x00 +#define REG_INT_STATUS 0x01 +#define REG_INT_MASK 0x03 +#define REG_CONV_RATE 0x07 +#define REG_CH_DISABLE 0x08 +#define REG_ONE_SHOT 0x09 +#define REG_DEEP_SHUTDOWN 0x0a +#define REG_ADV_CONFIG 0x0b +#define REG_BUSY_STATUS 0x0c + +/* Channel Reading Registers (16-bit, read-only) */ +#define REG_CH_READING_BASE 0x20 +#define REG_CH_READING_LAST 0x27 + +/* Limit Registers (8-bit, read/write) */ +#define REG_LIMIT_BASE 0x2a +#define REG_LIMIT_LAST 0x39 + +/* ID Registers (read-only) */ +#define REG_MANUFACTURER_ID 0x3e +#define REG_REVISION_ID 0x3f + +/* Configuration Register (0x00) bitfields */ +#define CONFIG_START BIT(0) +#define CONFIG_INT_ENABLE BIT(1) +#define CONFIG_INT_CLEAR BIT(3) +#define CONFIG_INITIALIZATION BIT(7) +#define CONFIG_WR_MASK \ + (CONFIG_START | CONFIG_INT_ENABLE | CONFIG_INT_CLEAR) + +/* Advanced Configuration Register (0x0B) bitfields */ +#define ADV_CONFIG_EXT_REF_EN BIT(0) +#define ADV_CONFIG_MODE_SHIFT 1 +#define ADV_CONFIG_MODE_MASK (0x3 << ADV_CONFIG_MODE_SHIFT) +#define ADV_CONFIG_WR_MASK \ + (ADV_CONFIG_EXT_REF_EN | ADV_CONFIG_MODE_MASK) + +/* Busy Status Register (0x0C) bitfields */ +#define BUSY_STATUS_NOT_READY BIT(1) + +/* Conversion Rate Register (0x07) bitfields */ +#define CONV_RATE_MASK 0x01 + +/* Deep Shutdown Register (0x0A) bitfields */ +#define DEEP_SHUTDOWN_EN 0x01 + +/* Device constants */ +#define ADC128D818_NUM_CHANNELS 8 +#define ADC128D818_NUM_REGS 0x40 + +#define ADC128D818_INTERNAL_VREF_MV 2560 +#define ADC128D818_MAX_VDD_MV 5500 +#define ADC128D818_MANUFACTURER_ID_VAL 0x01 +#define ADC128D818_REVISION_ID_VAL 0x09 + +/* ADC resolution */ +#define ADC128D818_ADC_RESOLUTION 4096 +#define ADC128D818_ADC_MAX 4095 + +/* Temperature: 0.5 deg C per LSb =3D 500 milli-degrees per LSb */ +#define ADC128D818_TEMP_LSB_MC 500 +#define ADC128D818_TEMP_RAW_MIN (-256) +#define ADC128D818_TEMP_RAW_MAX 255 + + +OBJECT_DECLARE_SIMPLE_TYPE(ADC128D818State, ADC128D818) + +struct ADC128D818State { + I2CSlave parent_obj; + + qemu_irq irq; + + uint8_t len; + uint8_t pointer; + uint8_t rx_byte; + + uint8_t regs[ADC128D818_NUM_REGS]; + uint16_t channel[ADC128D818_NUM_CHANNELS]; + + int16_t ain[ADC128D818_NUM_CHANNELS]; /* mV */ + int32_t temperature; /* milli-degrees Celsius */ + uint16_t ext_vref; /* mV, 0 means not connected */ + bool temp_alarm; /* temperature high-limit alarm latched */ + + char *description; +}; + +static uint16_t adc128d818_get_vref(const ADC128D818State *s) +{ + if (s->regs[REG_ADV_CONFIG] & ADV_CONFIG_EXT_REF_EN) { + if (s->ext_vref > 0u) { + return s->ext_vref; + } + qemu_log_mask(LOG_GUEST_ERROR, + "%s: %s: external VREF selected but not" + " connected, falling back to internal\n", + __func__, s->description); + } + + return ADC128D818_INTERNAL_VREF_MV; +} + +static uint8_t adc128d818_get_mode(const ADC128D818State *s) +{ + return (s->regs[REG_ADV_CONFIG] & ADV_CONFIG_MODE_MASK) >> + ADV_CONFIG_MODE_SHIFT; +} + +static bool adc128d818_is_temp_channel(const ADC128D818State *s, unsigned = ch) +{ + if (ch !=3D 7u) { + return false; + } + + return adc128d818_get_mode(s) !=3D 1u; +} + +static bool adc128d818_is_reserved_channel(const ADC128D818State *s, + unsigned ch) +{ + switch (adc128d818_get_mode(s)) { + case 2u: + return ch >=3D 4u && ch <=3D 6u; + case 3u: + return ch =3D=3D 6u; + default: + return false; + } +} + +static int16_t adc128d818_channel_voltage(const ADC128D818State *s, unsign= ed ch) +{ + switch (adc128d818_get_mode(s)) { + case 2u: + switch (ch) { + case 0u: + return (int16_t)(s->ain[0] - s->ain[1]); + case 1u: + return (int16_t)(s->ain[3] - s->ain[2]); + case 2u: + return (int16_t)(s->ain[4] - s->ain[5]); + case 3u: + return (int16_t)(s->ain[7] - s->ain[6]); + default: + return 0; + } + case 3u: + switch (ch) { + case 4u: + return (int16_t)(s->ain[4] - s->ain[5]); + case 5u: + return (int16_t)(s->ain[7] - s->ain[6]); + default: + return s->ain[ch]; + } + default: + return s->ain[ch]; + } +} + +static void adc128d818_update_irq(ADC128D818State *s) +{ + uint8_t cfg =3D s->regs[REG_CONFIG]; + uint8_t active; + bool level; + + active =3D s->regs[REG_INT_STATUS] & ~s->regs[REG_INT_MASK]; + + /* INT pin is active-low */ + level =3D !((cfg & CONFIG_INT_ENABLE) && !(cfg & CONFIG_INT_CLEAR) && + (active !=3D 0u)); + + trace_adc128d818_irq(s->description, level); + qemu_set_irq(s->irq, level); +} + +static bool adc128d818_monitoring_active(const ADC128D818State *s) +{ + if (s->regs[REG_DEEP_SHUTDOWN] & DEEP_SHUTDOWN_EN) { + return false; + } + if (!(s->regs[REG_CONFIG] & CONFIG_START)) { + return false; + } + if (s->regs[REG_CONFIG] & CONFIG_INT_CLEAR) { + return false; + } + + return true; +} + +static void adc128d818_check_limits(ADC128D818State *s) +{ + uint8_t disabled =3D s->regs[REG_CH_DISABLE]; + uint8_t int_status =3D 0u; + + for (unsigned ch =3D 0u; ch < ADC128D818_NUM_CHANNELS; ch++) { + if ((disabled & (1u << ch)) || + adc128d818_is_reserved_channel(s, ch)) { + continue; + } + + if (adc128d818_is_temp_channel(s, ch)) { + int raw =3D s->temperature / ADC128D818_TEMP_LSB_MC; + int thot; + int thyst; + + raw =3D MAX(ADC128D818_TEMP_RAW_MIN, + MIN(ADC128D818_TEMP_RAW_MAX, raw)); + thot =3D (int)(int8_t)s->regs[REG_LIMIT_BASE + ch * 2u] * 2; + thyst =3D (int)(int8_t)s->regs[REG_LIMIT_BASE + ch * 2u + 1u] = * 2; + + if (raw > thot) { + s->temp_alarm =3D true; + } else if (raw <=3D thyst) { + s->temp_alarm =3D false; + } + if (s->temp_alarm) { + int_status |=3D (1u << ch); + } + } else { + uint8_t msb =3D (uint8_t)(s->channel[ch] >> 8u); + uint8_t high_lim =3D s->regs[REG_LIMIT_BASE + ch * 2u]; + uint8_t low_lim =3D s->regs[REG_LIMIT_BASE + ch * 2u + 1u]; + + if (msb > high_lim || msb <=3D low_lim) { + int_status |=3D (1u << ch); + } + } + } + + s->regs[REG_INT_STATUS] =3D int_status; + adc128d818_update_irq(s); +} + +static void adc128d818_convert(ADC128D818State *s) +{ + uint8_t disabled; + uint16_t vref; + + disabled =3D s->regs[REG_CH_DISABLE]; + vref =3D adc128d818_get_vref(s); + + for (unsigned ch =3D 0u; ch < ADC128D818_NUM_CHANNELS; ch++) { + if ((disabled & (1u << ch)) || + adc128d818_is_reserved_channel(s, ch)) { + continue; + } + + if (adc128d818_is_temp_channel(s, ch)) { + int32_t raw =3D s->temperature / ADC128D818_TEMP_LSB_MC; + + raw =3D + MAX(ADC128D818_TEMP_RAW_MIN, MIN(ADC128D818_TEMP_RAW_MAX, = raw)); + s->channel[ch] =3D (uint16_t)(((unsigned)raw & 0x1FFu) << 7u); + } else { + int16_t vin =3D adc128d818_channel_voltage(s, ch); + int32_t dout; + + dout =3D vin * (int32_t)ADC128D818_ADC_RESOLUTION / vref; + dout =3D MAX(0, MIN((int32_t)ADC128D818_ADC_MAX, dout)); + s->channel[ch] =3D (uint16_t)(dout << 4u); + } + + trace_adc128d818_convert(s->description, ch, s->channel[ch]); + } + + s->regs[REG_BUSY_STATUS] &=3D ~BUSY_STATUS_NOT_READY; + + adc128d818_check_limits(s); +} + +static uint8_t adc128d818_read_channel(ADC128D818State *s, unsigned ch) +{ + uint8_t val; + + if (s->rx_byte =3D=3D 0u) { + val =3D (uint8_t)(s->channel[ch] >> 8u); + trace_adc128d818_read_channel(s->description, ch, s->channel[ch]); + } else { + val =3D (uint8_t)(s->channel[ch] & 0xFFu); + } + s->rx_byte ^=3D 1u; + + return val; +} + +static uint8_t adc128d818_read_reg(ADC128D818State *s, uint8_t reg) +{ + uint8_t val; + + switch (reg) { + case REG_INT_STATUS: + val =3D s->regs[REG_INT_STATUS]; + s->regs[REG_INT_STATUS] =3D 0x00u; + if (adc128d818_monitoring_active(s)) { + adc128d818_check_limits(s); + } else { + adc128d818_update_irq(s); + } + trace_adc128d818_read(s->description, reg, val); + return val; + case REG_CONFIG: + case REG_INT_MASK: + case REG_CONV_RATE: + case REG_CH_DISABLE: + case REG_ONE_SHOT: + case REG_DEEP_SHUTDOWN: + case REG_ADV_CONFIG: + case REG_BUSY_STATUS: + case REG_LIMIT_BASE ... REG_LIMIT_LAST: + case REG_MANUFACTURER_ID: + case REG_REVISION_ID: + trace_adc128d818_read(s->description, reg, s->regs[reg]); + return s->regs[reg]; + case REG_CH_READING_BASE ... REG_CH_READING_LAST: + return adc128d818_read_channel(s, reg - REG_CH_READING_BASE); + default: + qemu_log_mask(LOG_GUEST_ERROR, + "%s: %s: read from undefined register 0x%02x\n", + __func__, s->description, reg); + return 0x00u; + } +} + +static void adc128d818_write_reg(ADC128D818State *s, uint8_t reg, uint8_t = val); + +static void adc128d818_reset_regs(ADC128D818State *s) +{ + memset(s->regs, 0, sizeof(s->regs)); + memset(s->channel, 0, sizeof(s->channel)); + s->temp_alarm =3D false; + + s->regs[REG_CONFIG] =3D 0x08u; + s->regs[REG_BUSY_STATUS] =3D 0x02u; + s->regs[REG_MANUFACTURER_ID] =3D ADC128D818_MANUFACTURER_ID_VAL; + s->regs[REG_REVISION_ID] =3D ADC128D818_REVISION_ID_VAL; + + for (unsigned ch =3D 0u; ch < ADC128D818_NUM_CHANNELS; ch++) { + s->regs[REG_LIMIT_BASE + ch * 2u] =3D 0xFFu; + } + + s->pointer =3D 0x00u; + s->len =3D 0u; + s->rx_byte =3D 0u; + + adc128d818_update_irq(s); +} + +static void adc128d818_write_reg(ADC128D818State *s, uint8_t reg, uint8_t = val) +{ + trace_adc128d818_write(s->description, reg, val); + + switch (reg) { + case REG_CONFIG: + if (val & CONFIG_INITIALIZATION) { + trace_adc128d818_reset(s->description, "reg"); + adc128d818_reset_regs(s); + break; + } + s->regs[REG_CONFIG] =3D val & CONFIG_WR_MASK; + if ((val & CONFIG_START) && !(val & CONFIG_INT_CLEAR) && + !(s->regs[REG_DEEP_SHUTDOWN] & DEEP_SHUTDOWN_EN)) { + adc128d818_convert(s); + } + adc128d818_update_irq(s); + break; + case REG_INT_MASK: + s->regs[REG_INT_MASK] =3D val; + adc128d818_update_irq(s); + break; + case REG_CONV_RATE: + if (s->regs[REG_CONFIG] & CONFIG_START) { + qemu_log_mask(LOG_GUEST_ERROR, + "%s: %s: CONV_RATE written while running\n", + __func__, s->description); + break; + } + s->regs[REG_CONV_RATE] =3D val & CONV_RATE_MASK; + break; + case REG_CH_DISABLE: + if (s->regs[REG_CONFIG] & CONFIG_START) { + qemu_log_mask(LOG_GUEST_ERROR, + "%s: %s: CH_DISABLE written while running\n", + __func__, s->description); + break; + } + s->regs[REG_CH_DISABLE] =3D val; + memset(s->channel, 0, sizeof(s->channel)); + s->regs[REG_INT_STATUS] =3D 0x00u; + s->temp_alarm =3D false; + adc128d818_update_irq(s); + break; + case REG_ONE_SHOT: + if (!(s->regs[REG_CONFIG] & CONFIG_START)) { + adc128d818_convert(s); + } + break; + case REG_DEEP_SHUTDOWN: + if ((val & DEEP_SHUTDOWN_EN) && (s->regs[REG_CONFIG] & CONFIG_STAR= T)) { + qemu_log_mask(LOG_GUEST_ERROR, + "%s: %s: DEEP_SHUTDOWN set while running\n", + __func__, s->description); + break; + } + s->regs[REG_DEEP_SHUTDOWN] =3D val & DEEP_SHUTDOWN_EN; + break; + case REG_ADV_CONFIG: + if (s->regs[REG_CONFIG] & CONFIG_START) { + qemu_log_mask(LOG_GUEST_ERROR, + "%s: %s: ADV_CONFIG written while running\n", + __func__, s->description); + break; + } + s->regs[REG_ADV_CONFIG] =3D val & ADV_CONFIG_WR_MASK; + memset(s->channel, 0, sizeof(s->channel)); + s->regs[REG_INT_STATUS] =3D 0x00u; + s->temp_alarm =3D false; + adc128d818_update_irq(s); + break; + case REG_LIMIT_BASE ... REG_LIMIT_LAST: + s->regs[reg] =3D val; + break; + case REG_INT_STATUS: + case REG_BUSY_STATUS: + case REG_MANUFACTURER_ID: + case REG_REVISION_ID: + case REG_CH_READING_BASE ... REG_CH_READING_LAST: + qemu_log_mask(LOG_GUEST_ERROR, + "%s: %s: write to read-only register 0x%02x\n", + __func__, s->description, reg); + break; + default: + qemu_log_mask(LOG_GUEST_ERROR, + "%s: %s: write to undefined register 0x%02x\n", + __func__, s->description, reg); + break; + } +} + +static uint8_t adc128d818_recv(I2CSlave *i2c) +{ + ADC128D818State *s =3D ADC128D818(i2c); + + return adc128d818_read_reg(s, s->pointer); +} + +static int adc128d818_send(I2CSlave *i2c, uint8_t data) +{ + ADC128D818State *s =3D ADC128D818(i2c); + + if (s->len =3D=3D 0u) { + s->pointer =3D data; + s->len++; + } else { + adc128d818_write_reg(s, s->pointer, data); + } + + return 0; +} + +static int adc128d818_event(I2CSlave *i2c, enum i2c_event event) +{ + ADC128D818State *s =3D ADC128D818(i2c); + + s->len =3D 0u; + s->rx_byte =3D 0u; + + return 0; +} + +static void adc128d818_get_ain(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) +{ + ADC128D818State *s =3D ADC128D818(obj); + int64_t value; + int ch_num; + int rc; + + rc =3D sscanf(name, "ain%d", &ch_num); + if (rc !=3D 1 || ch_num < 0 || ch_num >=3D (int)ADC128D818_NUM_CHANNEL= S) { + error_setg(errp, "%s: %s: invalid channel '%s'", __func__, + s->description, name); + return; + } + + value =3D s->ain[ch_num]; + visit_type_int(v, name, &value, errp); +} + +static void adc128d818_set_ain(Object *obj, Visitor *v, const char *name, + void *opaque, Error **errp) +{ + ADC128D818State *s =3D ADC128D818(obj); + int64_t value; + int ch_num; + int rc; + + if (!visit_type_int(v, name, &value, errp)) { + return; + } + + rc =3D sscanf(name, "ain%d", &ch_num); + if (rc !=3D 1 || ch_num < 0 || ch_num >=3D (int)ADC128D818_NUM_CHANNEL= S) { + error_setg(errp, "%s: %s: invalid channel '%s'", __func__, + s->description, name); + return; + } + + if (value < INT16_MIN || value > INT16_MAX) { + error_setg(errp, "%s: %s: value %" PRId64 " out of range for '%s'", + __func__, s->description, value, name); + return; + } + + s->ain[ch_num] =3D (int16_t)value; + + if (adc128d818_monitoring_active(s)) { + adc128d818_convert(s); + } +} + +static void adc128d818_get_temperature( + Object *obj, Visitor *v, const char *name, void *opaque, Error **errp) +{ + ADC128D818State *s =3D ADC128D818(obj); + int64_t value =3D s->temperature; + + visit_type_int(v, name, &value, errp); +} + +static void adc128d818_set_temperature( + Object *obj, Visitor *v, const char *name, void *opaque, Error **errp) +{ + ADC128D818State *s =3D ADC128D818(obj); + int64_t value; + + if (!visit_type_int(v, name, &value, errp)) { + return; + } + + if (value < INT32_MIN || value > INT32_MAX) { + error_setg(errp, "%s: %s: value %" PRId64 " out of range", __func_= _, + s->description, value); + return; + } + + s->temperature =3D (int32_t)value; + + if (adc128d818_monitoring_active(s)) { + adc128d818_convert(s); + } +} + +static const VMStateDescription adc128d818_vmstate =3D { + .name =3D "ADC128D818", + .version_id =3D 0, + .minimum_version_id =3D 0, + .fields =3D (VMStateField[]) { + VMSTATE_UINT8(len, ADC128D818State), + VMSTATE_UINT8(pointer, ADC128D818State), + VMSTATE_UINT8(rx_byte, ADC128D818State), + VMSTATE_UINT8_ARRAY(regs, ADC128D818State, + ADC128D818_NUM_REGS), + VMSTATE_UINT16_ARRAY(channel, ADC128D818State, + ADC128D818_NUM_CHANNELS), + VMSTATE_INT16_ARRAY(ain, ADC128D818State, + ADC128D818_NUM_CHANNELS), + VMSTATE_INT32(temperature, ADC128D818State), + VMSTATE_UINT16(ext_vref, ADC128D818State), + VMSTATE_BOOL(temp_alarm, ADC128D818State), + VMSTATE_I2C_SLAVE(parent_obj, ADC128D818State), + VMSTATE_END_OF_LIST() + } +}; + +static void adc128d818_reset_hold(Object *obj, ResetType type) +{ + ADC128D818State *s =3D ADC128D818(obj); + + trace_adc128d818_reset(s->description, "hw"); + adc128d818_reset_regs(s); +} + +static void adc128d818_get_ext_vref( + Object *obj, Visitor *v, const char *name, void *opaque, Error **errp) +{ + ADC128D818State *s =3D ADC128D818(obj); + int64_t value =3D (int64_t)s->ext_vref; + + visit_type_int(v, name, &value, errp); +} + +static void adc128d818_set_ext_vref( + Object *obj, Visitor *v, const char *name, void *opaque, Error **errp) +{ + ADC128D818State *s =3D ADC128D818(obj); + int64_t value; + + if (!visit_type_int(v, name, &value, errp)) { + return; + } + + if (value < 0 || value > ADC128D818_MAX_VDD_MV) { + error_setg(errp, + "%s: %s: ext-vref-mv %" PRId64 " out of range (0..%u mV= )", + __func__, s->description, value, ADC128D818_MAX_VDD_MV); + return; + } + + s->ext_vref =3D (uint16_t)value; + + if (adc128d818_monitoring_active(s)) { + adc128d818_convert(s); + } +} + +static void adc128d818_initfn(Object *obj) +{ + for (unsigned ch =3D 0u; ch < ADC128D818_NUM_CHANNELS; ch++) { + char *name =3D g_strdup_printf("ain%u", ch); + + object_property_add(obj, name, "int", adc128d818_get_ain, + adc128d818_set_ain, NULL, NULL); + g_free(name); + } + + object_property_add(obj, "temperature", "int", adc128d818_get_temperat= ure, + adc128d818_set_temperature, NULL, NULL); + object_property_add(obj, "ext-vref-mv", "int", adc128d818_get_ext_vref, + adc128d818_set_ext_vref, NULL, NULL); +} + +static void adc128d818_realize(DeviceState *dev, Error **errp) +{ + ADC128D818State *s =3D ADC128D818(dev); + + if (!s->description) { + s->description =3D g_strdup(object_get_typename(OBJECT(dev))); + } + + qdev_init_gpio_out(dev, &s->irq, 1u); +} + +static const Property adc128d818_properties[] =3D { + DEFINE_PROP_STRING("description", ADC128D818State, description), +}; + +static void adc128d818_class_init(ObjectClass *klass, const void *data) +{ + DeviceClass *dc =3D DEVICE_CLASS(klass); + I2CSlaveClass *ic =3D I2C_SLAVE_CLASS(klass); + ResettableClass *rc =3D RESETTABLE_CLASS(klass); + + ic->event =3D adc128d818_event; + ic->recv =3D adc128d818_recv; + ic->send =3D adc128d818_send; + dc->realize =3D adc128d818_realize; + rc->phases.hold =3D adc128d818_reset_hold; + dc->vmsd =3D &adc128d818_vmstate; + device_class_set_props(dc, adc128d818_properties); +} + +static const TypeInfo adc128d818_types[] =3D { + { + .name =3D TYPE_ADC128D818, + .parent =3D TYPE_I2C_SLAVE, + .instance_init =3D adc128d818_initfn, + .instance_size =3D sizeof(ADC128D818State), + .class_init =3D adc128d818_class_init, + }, +}; + +DEFINE_TYPES(adc128d818_types) diff --git a/hw/sensor/meson.build b/hw/sensor/meson.build index 420fdc3359..fe36c9ef91 100644 --- a/hw/sensor/meson.build +++ b/hw/sensor/meson.build @@ -1,3 +1,4 @@ +system_ss.add(when: 'CONFIG_ADC128D818', if_true: files('adc128d818.c')) system_ss.add(when: 'CONFIG_TMP105', if_true: files('tmp105.c')) system_ss.add(when: 'CONFIG_TMP421', if_true: files('tmp421.c')) system_ss.add(when: 'CONFIG_DPS310', if_true: files('dps310.c')) diff --git a/hw/sensor/trace-events b/hw/sensor/trace-events index a3fe54fa6d..5a3630f7bb 100644 --- a/hw/sensor/trace-events +++ b/hw/sensor/trace-events @@ -1,5 +1,13 @@ # See docs/devel/tracing.rst for syntax documentation. =20 +# adc128d818.c +adc128d818_read(const char *id, uint8_t reg, uint8_t value) "%s reg 0x%02x= val 0x%02x" +adc128d818_read_channel(const char *id, uint8_t channel, uint16_t value) "= %s ch %u val 0x%04x" +adc128d818_write(const char *id, uint8_t reg, uint8_t value) "%s reg 0x%02= x val 0x%02x" +adc128d818_convert(const char *id, uint8_t channel, uint16_t value) "%s ch= %u val 0x%04x" +adc128d818_irq(const char *id, bool level) "%s level %u" +adc128d818_reset(const char *id, const char *source) "%s %s" + # tmp105.c tmp105_read(uint8_t dev, uint8_t addr) "device: 0x%02x, addr: 0x%02x" tmp105_write(uint8_t dev, uint8_t addr) "device: 0x%02x, addr 0x%02x" diff --git a/include/hw/sensor/adc128d818.h b/include/hw/sensor/adc128d818.h new file mode 100644 index 0000000000..10c34b9646 --- /dev/null +++ b/include/hw/sensor/adc128d818.h @@ -0,0 +1,14 @@ +/* + * Texas Instruments ADC128D818 12-bit 8-channel ADC with I2C interface + * + * Copyright (c) 2026 Meta Platforms, Inc. and affiliates. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#ifndef HW_SENSOR_ADC128D818_H +#define HW_SENSOR_ADC128D818_H + +#define TYPE_ADC128D818 "adc128d818" + +#endif --=20 2.50.1 From nobody Sun Jul 26 11:08:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=free.fr ARC-Seal: i=1; a=rsa-sha256; t=1782936601; cv=none; d=zohomail.com; s=zohoarc; b=V5akuKz//KaohrKbloc/Un8kUi7g0vnuZ/fMKuk+EIjP7oL/J+oGk42DiAO6o5WCh++fhnZ8qRbH2mZOe/MfJ8lXtMHyPkDcYSjLvk7ANDqtG/yszirent9Lxb/CVXCFIMGe6j7774GQKCM15KxYQe8gyEzurO2OGrD+Ia0rxLs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782936601; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=xGIvEQEA/dM33iCwQVNLF+Er9v7bg8aXMNlNbnUzu08=; b=b3AIh/NRS5Odu3TYhh9QgLitWjeMiPEC9Ho5ObwLMDUDzgfh9OVfyukbwf950KeFnlby1XOpBUfBp+uCIwJJZN/lHTCDwV+6SAyVPvm8vHGdDXedpgeuNsJqZ66cdUt03kmqkw+OM5kxBrHIlJNEHv54T6HDv2N3P7Z5CteAVx0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782936600876117.97187770648088; Wed, 1 Jul 2026 13:10:00 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wf1F6-0001tV-FV; Wed, 01 Jul 2026 16:09:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1weyks-00080K-TO; Wed, 01 Jul 2026 13:29:46 -0400 Received: from smtp2-g21.free.fr ([212.27.42.2]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1weykq-0006O6-Qg; Wed, 01 Jul 2026 13:29:46 -0400 Received: from localhost (unknown [89.92.102.124]) (Authenticated sender: emmanuel.blot@free.fr) by smtp2-g21.free.fr (Postfix) with ESMTPSA id 36B7220039E; Wed, 1 Jul 2026 19:29:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1782926982; bh=Ouee2Ps/oTe0Wc/KxKCavPPjCwx8Kr2JVkVu0ezh1R4=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=G8iKTdq67gYU94fGQuhuEixzaRFbQdn5eEU5/5UUiV0eIeIf0oXw+Rrp8v39riBLo ROO8/FFnyHsDf87oDbaN9dL1XMj3q1LjMtSVfLHNISvcrelrgHYktHQBfhq9TZp0ET 6LATsFI7IYbvCgzqADfwJWwC46twBGlAhfqN6+0NdP7SCFnsn3LdE2hG9BL1No19fo 6bYFpJoWTnyPrAInc++LTbke4DBTcgtSK9K6US/GNoag3KsQQcJGChika00x45qJpE /0sn1FYAh2A/V0DK+pnMQl+tllwejQ9tUHh0pySCtsYi98W4tEfevB6JCDmb5xnP8G z5cLmSTmtcY3Q== From: Emmanuel Blot Date: Wed, 01 Jul 2026 19:28:32 +0200 Subject: [PATCH v5 2/8] tests/qtest: adc128d818: add test harness and register access MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260701-i2c-adc128d818-anacapa-v5-2-fe8292d86b38@free.fr> References: <20260701-i2c-adc128d818-anacapa-v5-0-fe8292d86b38@free.fr> In-Reply-To: <20260701-i2c-adc128d818-anacapa-v5-0-fe8292d86b38@free.fr> To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Fabiano Rosas , Laurent Vivier , Peter Maydell , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Steven Lee , Troy Lee , Jamin Lin , Kane Chen , Andrew Jeffery , Joel Stanley , Alexander Hansen , William de Abreu Pinho , Emmanuel Blot , qemu-arm@nongnu.org, Emmanuel Blot , Corey Minyard X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1782926919; l=6947; i=emmanuel.blot@free.fr; s=20260602; h=from:subject:message-id; bh=Ouee2Ps/oTe0Wc/KxKCavPPjCwx8Kr2JVkVu0ezh1R4=; b=fL3qxsFOENd5XFnepIyQSn1772ZC//9IqWkLNVv5vlttZL6fIvOcsAGSDgB9Vgz76/2P7NRwR wGCJQe66d+nC0vrHLZqtkx5kwe0CWeAHVFbhoUlm6dSuGszibcxfPON X-Developer-Key: i=emmanuel.blot@free.fr; a=ed25519; pk=0qFrZ21FAAN8OfVsSoVcCFTk/NMYOWzxJz4paSAVm0g= Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=212.27.42.2; envelope-from=emmanuel.blot@free.fr; helo=smtp2-g21.free.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 01 Jul 2026 16:09:06 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @free.fr) X-ZM-MESSAGEID: 1782936603211158500 Introduce the QOS test node and QMP property helpers for the ADC128D818, and cover basic register access: manufacturer and revision IDs, power-on-reset defaults, software reset, and the ain and temperature property readback. Signed-off-by: Emmanuel Blot --- tests/qtest/adc128d818-test.c | 169 ++++++++++++++++++++++++++++++++++++++= ++++ tests/qtest/meson.build | 1 + 2 files changed, 170 insertions(+) diff --git a/tests/qtest/adc128d818-test.c b/tests/qtest/adc128d818-test.c new file mode 100644 index 0000000000..9a8811256f --- /dev/null +++ b/tests/qtest/adc128d818-test.c @@ -0,0 +1,169 @@ +/* + * QTest testcase for the ADC128D818 ADC + * + * Copyright (c) 2026 Meta Platforms, Inc. and affiliates. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include "qemu/osdep.h" +#include "qemu/bitops.h" +#include "libqos/i2c.h" +#include "libqos/qgraph.h" +#include "libqtest-single.h" +#include "qobject/qdict.h" + +#define ADC128D818_TEST_ID "adc128d818-test" +#define ADC128D818_TEST_ADDR 0x1f + +/* Register addresses */ +#define REG_CONFIG 0x00 +#define REG_INT_STATUS 0x01 +#define REG_INT_MASK 0x03 +#define REG_CONV_RATE 0x07 +#define REG_CH_DISABLE 0x08 +#define REG_ONE_SHOT 0x09 +#define REG_DEEP_SHUTDOWN 0x0a +#define REG_ADV_CONFIG 0x0b +#define REG_BUSY_STATUS 0x0c + +/* Channel Reading Registers (16-bit, read-only) */ +#define REG_CH_READING_BASE 0x20 + +/* Limit Registers (8-bit, read/write) */ +#define REG_LIMIT_BASE 0x2a + +/* ID Registers (read-only) */ +#define REG_MANUFACTURER_ID 0x3e +#define REG_REVISION_ID 0x3f + +/* Configuration Register (0x00) bitfields */ +#define CONFIG_START BIT(0) +#define CONFIG_INT_ENABLE BIT(1) +#define CONFIG_INT_CLEAR BIT(3) +#define CONFIG_INITIALIZATION BIT(7) + +/* Advanced Configuration Register (0x0b) bitfields */ +#define ADV_CONFIG_EXT_REF_EN BIT(0) +#define ADV_CONFIG_MODE_1 (1 << 1) +#define ADV_CONFIG_MODE_2 (2 << 1) +#define ADV_CONFIG_MODE_3 (3 << 1) + +/* Number of channels */ +#define NUM_CHANNELS 8 + +/* Internal VREF in mV */ +#define INTERNAL_VREF_MV 2560 + +/* QMP helpers for setting device properties */ + +static void qmp_adc128d818_set(const char *property, int value) +{ + QDict *resp; + + resp =3D qmp("{ 'execute': 'qom-set', 'arguments':" + " { 'path': %s, 'property': %s, 'value': %d } }", + ADC128D818_TEST_ID, property, value); + g_assert(qdict_haskey(resp, "return")); + qobject_unref(resp); +} + +static int qmp_adc128d818_get(const char *property) +{ + QDict *resp; + int ret; + + resp =3D qmp("{ 'execute': 'qom-get', 'arguments':" + " { 'path': %s, 'property': %s } }", + ADC128D818_TEST_ID, property); + g_assert(qdict_haskey(resp, "return")); + ret =3D qdict_get_int(resp, "return"); + qobject_unref(resp); + return ret; +} + +/* Manufacturer and Revision ID registers */ +static void test_id_registers(void *obj, void *data, QGuestAllocator *allo= c) +{ + QI2CDevice *dev =3D (QI2CDevice *)obj; + + g_assert_cmphex(i2c_get8(dev, REG_MANUFACTURER_ID), =3D=3D, 0x01); + g_assert_cmphex(i2c_get8(dev, REG_REVISION_ID), =3D=3D, 0x09); +} + +/* Power-on-reset default values */ +static void test_defaults(void *obj, void *data, QGuestAllocator *alloc) +{ + QI2CDevice *dev =3D (QI2CDevice *)obj; + unsigned ch; + + g_assert_cmphex(i2c_get8(dev, REG_CONFIG), =3D=3D, 0x08); + g_assert_cmphex(i2c_get8(dev, REG_INT_STATUS), =3D=3D, 0x00); + g_assert_cmphex(i2c_get8(dev, REG_INT_MASK), =3D=3D, 0x00); + g_assert_cmphex(i2c_get8(dev, REG_CONV_RATE), =3D=3D, 0x00); + g_assert_cmphex(i2c_get8(dev, REG_CH_DISABLE), =3D=3D, 0x00); + g_assert_cmphex(i2c_get8(dev, REG_DEEP_SHUTDOWN), =3D=3D, 0x00); + g_assert_cmphex(i2c_get8(dev, REG_ADV_CONFIG), =3D=3D, 0x00); + g_assert_cmphex(i2c_get8(dev, REG_BUSY_STATUS), =3D=3D, 0x02); + + for (ch =3D 0u; ch < NUM_CHANNELS; ch++) { + g_assert_cmphex(i2c_get8(dev, REG_LIMIT_BASE + ch * 2u), =3D=3D, 0= xFF); + g_assert_cmphex(i2c_get8(dev, REG_LIMIT_BASE + ch * 2u + 1u), =3D= =3D, 0x00); + } +} + +/* Software reset via INITIALIZATION bit */ +static void test_soft_reset(void *obj, void *data, QGuestAllocator *alloc) +{ + QI2CDevice *dev =3D (QI2CDevice *)obj; + + i2c_set8(dev, REG_INT_MASK, 0xAA); + i2c_set8(dev, REG_CH_DISABLE, 0x55); + i2c_set8(dev, REG_LIMIT_BASE, 0x42); + + g_assert_cmphex(i2c_get8(dev, REG_INT_MASK), =3D=3D, 0xAA); + g_assert_cmphex(i2c_get8(dev, REG_CH_DISABLE), =3D=3D, 0x55); + g_assert_cmphex(i2c_get8(dev, REG_LIMIT_BASE), =3D=3D, 0x42); + + i2c_set8(dev, REG_CONFIG, CONFIG_INITIALIZATION); + + g_assert_cmphex(i2c_get8(dev, REG_CONFIG), =3D=3D, 0x08); + g_assert_cmphex(i2c_get8(dev, REG_INT_MASK), =3D=3D, 0x00); + g_assert_cmphex(i2c_get8(dev, REG_CH_DISABLE), =3D=3D, 0x00); + g_assert_cmphex(i2c_get8(dev, REG_LIMIT_BASE), =3D=3D, 0xFF); + g_assert_cmphex(i2c_get8(dev, REG_BUSY_STATUS), =3D=3D, 0x02); +} + +/* Verify ain property readback via QMP */ +static void test_ain_property(void *obj, void *data, QGuestAllocator *allo= c) +{ + int value; + + qmp_adc128d818_set("ain3", 1500); + value =3D qmp_adc128d818_get("ain3"); + g_test_message("Set ain3 =3D 1500 mV, readback =3D %d mV", value); + g_assert_cmpint(value, =3D=3D, 1500); + + qmp_adc128d818_set("temperature", 37500); + value =3D qmp_adc128d818_get("temperature"); + g_test_message("Set temperature =3D 37500 mC, readback =3D %d mC", val= ue); + g_assert_cmpint(value, =3D=3D, 37500); +} + +static void adc128d818_register_nodes(void) +{ + QOSGraphEdgeOptions opts =3D { + .extra_device_opts =3D "id=3D" ADC128D818_TEST_ID + ",address=3D0x1f" + }; + add_qi2c_address(&opts, &(QI2CAddress) { ADC128D818_TEST_ADDR }); + + qos_node_create_driver("adc128d818", i2c_device_create); + qos_node_consumes("adc128d818", "i2c-bus", &opts); + + qos_add_test("id-registers", "adc128d818", test_id_registers, NULL); + qos_add_test("defaults", "adc128d818", test_defaults, NULL); + qos_add_test("soft-reset", "adc128d818", test_soft_reset, NULL); + qos_add_test("ain-property", "adc128d818", test_ain_property, NULL); +} +libqos_init(adc128d818_register_nodes); diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build index 45ea497fa5..defa0d9941 100644 --- a/tests/qtest/meson.build +++ b/tests/qtest/meson.build @@ -296,6 +296,7 @@ qtests_riscv64 =3D ['riscv-csr-test'] + \ qos_test_ss =3D ss.source_set() qos_test_ss.add( 'ac97-test.c', + 'adc128d818-test.c', 'adm1272-test.c', 'adm1266-test.c', 'ds1338-test.c', --=20 2.50.1 From nobody Sun Jul 26 11:08:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=free.fr ARC-Seal: i=1; a=rsa-sha256; t=1782936641; cv=none; d=zohomail.com; s=zohoarc; b=ZhzjRxyVn7XqpB53TJQLQrNx8/Dbj84XIDh+T/VeZ1uArXtnCC4en1ZUW/+UiJ4w/J9q6XW0zY4ymV9+NiSZSHv3Euns7NvECgSmaUebkPQdgorZNAMmmuT4/zIySnYGdnalVczVk9vIX7KsGW7iWaIQv3jmR/5kcT5TlXNMg8g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782936641; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=f8E+H8KvMqFdtF97hTXKfBcRV3GMYYRqafkdexozTEQ=; b=CB0Nn68ttmGrkS6febuquTu0XwVqwnyqxB98ghzskvqw6KOVFzev3HuS+m7ofZJgSBZFRJN3g1mNkwTH7Koc2C0pG2qWYY21wDYIZ0cWQVLOb8xDpysbnLtLRARGRJn1E+/RxHi6bspkTntcLLvVRFInydz7HfNAHp8mqXu5MZI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178293664157829.853620933771595; Wed, 1 Jul 2026 13:10:41 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wf1F6-0001u6-R8; Wed, 01 Jul 2026 16:09:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1weylC-0008AW-Fm; Wed, 01 Jul 2026 13:30:06 -0400 Received: from smtp2-g21.free.fr ([2a01:e0c:1:1599::11]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1weylA-0006Zo-EJ; Wed, 01 Jul 2026 13:30:06 -0400 Received: from localhost (unknown [89.92.102.124]) (Authenticated sender: emmanuel.blot@free.fr) by smtp2-g21.free.fr (Postfix) with ESMTPSA id 590232003DD; Wed, 1 Jul 2026 19:29:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1782927002; bh=DEtgkVQYX15nwF8ayNXYbS7A97DKm065aENMYX/g1hI=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=j8KEJczT+JrYOeZakxRqaxxbe5PphIqkZgHev23faeB4aSIUn06mjjL9jZjwJAyIr NcI9/+T48T9qiRAVvpb9fSvIwv6hz54UhQ0cZGpJpmimfYz8586dVTBNldySMgf62o mrtvWY4kiyiaTccsZFa3m0k78bGNyl/khFRZvhH25XGl0e472nXHW7mea6JqiugOVR m6E+Q9mzB1fcggDdfO2SCq+INymu+ItyRxU7BjCiNcMiDbH8IdpO331v1NPpUwhUNV WPeBQHkWTpRrZaWcOKdiC96v8NkzDcau0aLAFjVxc3lDuPmw6wke0ADtDdgdOUUYWG mo2qqqG+WshCg== From: Emmanuel Blot Date: Wed, 01 Jul 2026 19:28:33 +0200 Subject: [PATCH v5 3/8] tests/qtest: adc128d818: test voltage and temperature conversion MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260701-i2c-adc128d818-anacapa-v5-3-fe8292d86b38@free.fr> References: <20260701-i2c-adc128d818-anacapa-v5-0-fe8292d86b38@free.fr> In-Reply-To: <20260701-i2c-adc128d818-anacapa-v5-0-fe8292d86b38@free.fr> To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Fabiano Rosas , Laurent Vivier , Peter Maydell , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Steven Lee , Troy Lee , Jamin Lin , Kane Chen , Andrew Jeffery , Joel Stanley , Alexander Hansen , William de Abreu Pinho , Emmanuel Blot , qemu-arm@nongnu.org, Emmanuel Blot , Corey Minyard X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1782926919; l=8524; i=emmanuel.blot@free.fr; s=20260602; h=from:subject:message-id; bh=DEtgkVQYX15nwF8ayNXYbS7A97DKm065aENMYX/g1hI=; b=4H9ZovkzzRjBgq3zm6YYp2D/pyrVu4QNZ1wcGhEfW5J/L10qdwEnKvhcwXwPxab9kMshWR61u PYU0UJJqYwfB5aGXQuEjUzz+qzls28a2f9DqlmI9EcI+rkzb6ScIviL X-Developer-Key: i=emmanuel.blot@free.fr; a=ed25519; pk=0qFrZ21FAAN8OfVsSoVcCFTk/NMYOWzxJz4paSAVm0g= Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:e0c:1:1599::11; envelope-from=emmanuel.blot@free.fr; helo=smtp2-g21.free.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 01 Jul 2026 16:09:06 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @free.fr) X-ZM-MESSAGEID: 1782936642710158500 Cover single-ended voltage conversion across all channels, voltage and temperature boundary and clamping cases, and scaling against an external voltage reference. Signed-off-by: Emmanuel Blot --- tests/qtest/adc128d818-test.c | 189 ++++++++++++++++++++++++++++++++++++++= ++++ 1 file changed, 189 insertions(+) diff --git a/tests/qtest/adc128d818-test.c b/tests/qtest/adc128d818-test.c index 9a8811256f..891189f0bd 100644 --- a/tests/qtest/adc128d818-test.c +++ b/tests/qtest/adc128d818-test.c @@ -150,6 +150,186 @@ static void test_ain_property(void *obj, void *data, = QGuestAllocator *alloc) g_assert_cmpint(value, =3D=3D, 37500); } =20 +/* Voltage conversion */ +static void test_voltage_conversion(void *obj, void *data, + QGuestAllocator *alloc) +{ + QI2CDevice *dev =3D (QI2CDevice *)obj; + uint16_t reading; + + qmp_adc128d818_set("ain0", 1280); + g_test_message("Injected ain0 =3D 1280 mV"); + i2c_set8(dev, REG_CONFIG, CONFIG_START); + + reading =3D i2c_get16(dev, REG_CH_READING_BASE); + g_test_message("Read ch0: raw 0x%04x -> %u mV", reading, + (reading >> 4u) * INTERNAL_VREF_MV / 4096u); + g_assert_cmphex(reading, =3D=3D, 0x8000); + + qmp_adc128d818_set("ain1", 2560); + g_test_message("Injected ain1 =3D 2560 mV"); + reading =3D i2c_get16(dev, REG_CH_READING_BASE + 1u); + g_test_message("Read ch1: raw 0x%04x -> %u mV", reading, + (reading >> 4u) * INTERNAL_VREF_MV / 4096u); + g_assert_cmphex(reading, =3D=3D, 0xFFF0); + + qmp_adc128d818_set("ain2", 0); + g_test_message("Injected ain2 =3D 0 mV"); + reading =3D i2c_get16(dev, REG_CH_READING_BASE + 2u); + g_test_message("Read ch2: raw 0x%04x -> %u mV", reading, + (reading >> 4u) * INTERNAL_VREF_MV / 4096u); + g_assert_cmphex(reading, =3D=3D, 0x0000); +} + +/* Temperature conversion (mode 0, channel 7 =3D temperature) */ +static void +test_temperature_conversion(void *obj, void *data, QGuestAllocator *alloc) +{ + QI2CDevice *dev =3D (QI2CDevice *)obj; + uint16_t reading; + + qmp_adc128d818_set("temperature", 25000); + g_test_message("Injected temperature =3D 25000 mC (25.0 deg C)"); + i2c_set8(dev, REG_CONFIG, CONFIG_START); + + reading =3D i2c_get16(dev, REG_CH_READING_BASE + 7u); + g_test_message("Read ch7: raw 0x%04x -> %d mC", reading, + (int16_t)(reading & 0xFF80u) * 500 / 128); + g_assert_cmphex(reading, =3D=3D, 0x1900); +} + +/* Channels with distinct voltages */ +static void test_all_channels(void *obj, void *data, QGuestAllocator *allo= c) +{ + QI2CDevice *dev =3D (QI2CDevice *)obj; + static const uint16_t ain_mv[NUM_CHANNELS] =3D { + 0, 320, 640, 960, 1280, 1920, 2240, 2560 + }; + static const uint16_t expect[NUM_CHANNELS] =3D { + 0x0000, 0x2000, 0x4000, 0x6000, 0x8000, 0xC000, 0xE000, 0xFFF0 + }; + uint16_t reading; + unsigned ch; + + i2c_set8(dev, REG_CONFIG, CONFIG_INITIALIZATION); + i2c_set8(dev, REG_ADV_CONFIG, ADV_CONFIG_MODE_1); + + for (ch =3D 0u; ch < NUM_CHANNELS; ch++) { + char name[8]; + snprintf(name, sizeof(name), "ain%u", ch); + qmp_adc128d818_set(name, ain_mv[ch]); + } + + i2c_set8(dev, REG_CONFIG, CONFIG_START); + + for (ch =3D 0u; ch < NUM_CHANNELS; ch++) { + reading =3D i2c_get16(dev, REG_CH_READING_BASE + ch); + g_test_message("ch%u: ain %u mV -> raw 0x%04x (expect 0x%04x)", + ch, ain_mv[ch], reading, expect[ch]); + g_assert_cmphex(reading, =3D=3D, expect[ch]); + } +} + +/* Voltage conversion edge cases */ +static void test_voltage_edges(void *obj, void *data, QGuestAllocator *all= oc) +{ + QI2CDevice *dev =3D (QI2CDevice *)obj; + uint16_t reading; + + i2c_set8(dev, REG_CONFIG, CONFIG_INITIALIZATION); + i2c_set8(dev, REG_ADV_CONFIG, ADV_CONFIG_MODE_1); + + qmp_adc128d818_set("ain0", 3000); + i2c_set8(dev, REG_CONFIG, CONFIG_START); + + reading =3D i2c_get16(dev, REG_CH_READING_BASE); + g_test_message("Over-range 3000 mV: raw 0x%04x (expect 0xFFF0)", readi= ng); + g_assert_cmphex(reading, =3D=3D, 0xFFF0); + + qmp_adc128d818_set("ain1", 1); + reading =3D i2c_get16(dev, REG_CH_READING_BASE + 1u); + g_test_message("1 mV: raw 0x%04x (expect 0x0010)", reading); + g_assert_cmphex(reading, =3D=3D, 0x0010); + + qmp_adc128d818_set("ain2", 640); + reading =3D i2c_get16(dev, REG_CH_READING_BASE + 2u); + g_test_message("640 mV (quarter): raw 0x%04x (expect 0x4000)", reading= ); + g_assert_cmphex(reading, =3D=3D, 0x4000); + + qmp_adc128d818_set("ain3", 1920); + reading =3D i2c_get16(dev, REG_CH_READING_BASE + 3u); + g_test_message("1920 mV (3/4): raw 0x%04x (expect 0xC000)", reading); + g_assert_cmphex(reading, =3D=3D, 0xC000); +} + +/* Temperature conversion edge cases */ +static void test_temperature_edges(void *obj, void *data, + QGuestAllocator *alloc) +{ + QI2CDevice *dev =3D (QI2CDevice *)obj; + uint16_t reading; + + i2c_set8(dev, REG_CONFIG, CONFIG_INITIALIZATION); + + qmp_adc128d818_set("temperature", 0); + i2c_set8(dev, REG_CONFIG, CONFIG_START); + reading =3D i2c_get16(dev, REG_CH_READING_BASE + 7u); + g_test_message("0 C: raw 0x%04x (expect 0x0000)", reading); + g_assert_cmphex(reading, =3D=3D, 0x0000); + + qmp_adc128d818_set("temperature", -25000); + reading =3D i2c_get16(dev, REG_CH_READING_BASE + 7u); + g_test_message("-25 C: raw 0x%04x (expect 0xE700)", reading); + g_assert_cmphex(reading, =3D=3D, 0xE700); + + qmp_adc128d818_set("temperature", 127500); + reading =3D i2c_get16(dev, REG_CH_READING_BASE + 7u); + g_test_message("+127.5 C: raw 0x%04x (expect 0x7F80)", reading); + g_assert_cmphex(reading, =3D=3D, 0x7F80); + + qmp_adc128d818_set("temperature", -128000); + reading =3D i2c_get16(dev, REG_CH_READING_BASE + 7u); + g_test_message("-128 C: raw 0x%04x (expect 0x8000)", reading); + g_assert_cmphex(reading, =3D=3D, 0x8000); + + qmp_adc128d818_set("temperature", 200000); + reading =3D i2c_get16(dev, REG_CH_READING_BASE + 7u); + g_test_message("200 C (clamped): raw 0x%04x (expect 0x7F80)", reading); + g_assert_cmphex(reading, =3D=3D, 0x7F80); + + qmp_adc128d818_set("temperature", -200000); + reading =3D i2c_get16(dev, REG_CH_READING_BASE + 7u); + g_test_message("-200 C (clamped): raw 0x%04x (expect 0x8000)", reading= ); + g_assert_cmphex(reading, =3D=3D, 0x8000); +} + +/* External voltage reference */ +static void test_ext_vref(void *obj, void *data, QGuestAllocator *alloc) +{ + QI2CDevice *dev =3D (QI2CDevice *)obj; + uint16_t reading; + + i2c_set8(dev, REG_CONFIG, CONFIG_INITIALIZATION); + i2c_set8(dev, REG_ADV_CONFIG, ADV_CONFIG_MODE_1); + + qmp_adc128d818_set("ext-vref-mv", 4096); + i2c_set8(dev, REG_ADV_CONFIG, ADV_CONFIG_EXT_REF_EN | ADV_CONFIG_MODE_= 1); + + qmp_adc128d818_set("ain0", 1000); + i2c_set8(dev, REG_CONFIG, CONFIG_START); + + reading =3D i2c_get16(dev, REG_CH_READING_BASE); + g_test_message("1000 mV / 4096 mV VREF: raw 0x%04x (expect 0x3E80)", + reading); + g_assert_cmphex(reading, =3D=3D, 0x3E80); + + qmp_adc128d818_set("ain1", 2048); + reading =3D i2c_get16(dev, REG_CH_READING_BASE + 1u); + g_test_message("2048 mV / 4096 mV VREF: raw 0x%04x (expect 0x8000)", + reading); + g_assert_cmphex(reading, =3D=3D, 0x8000); +} + static void adc128d818_register_nodes(void) { QOSGraphEdgeOptions opts =3D { @@ -165,5 +345,14 @@ static void adc128d818_register_nodes(void) qos_add_test("defaults", "adc128d818", test_defaults, NULL); qos_add_test("soft-reset", "adc128d818", test_soft_reset, NULL); qos_add_test("ain-property", "adc128d818", test_ain_property, NULL); + qos_add_test("voltage-conversion", "adc128d818", test_voltage_conversi= on, + NULL); + qos_add_test("temperature-conversion", "adc128d818", + test_temperature_conversion, NULL); + qos_add_test("all-channels", "adc128d818", test_all_channels, NULL); + qos_add_test("voltage-edges", "adc128d818", test_voltage_edges, NULL); + qos_add_test("temperature-edges", "adc128d818", test_temperature_edges, + NULL); + qos_add_test("ext-vref", "adc128d818", test_ext_vref, NULL); } libqos_init(adc128d818_register_nodes); --=20 2.50.1 From nobody Sun Jul 26 11:08:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=free.fr ARC-Seal: i=1; a=rsa-sha256; t=1782936683; cv=none; d=zohomail.com; s=zohoarc; b=UFQJSWtDPaGA07v2DqbbZVXqbiEcLTK8Kh4wMbtpNmTSZcdT4zx4X6PvQ8rzIERniYSd003ECVTTYEzi5s8nni3rJaoCk7r5SL5zFLFgRebgTSc/mzVyg3kK1KWh3vvwG9aktsgOQwL0W+NMIB0B4sjdjPBwS3fJporinUNQVxA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782936683; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=zK9j0S/W27zDtiKJ7+F9HXdGl5IN/7U+EwlA7dT5nHs=; b=Mz4n5BrQoWDAD45461xuiHjPXmGKgBYwHG5IUWYhiOGO2AiFaMfdf4H7UgMxw/Aebzm1M8PCncHJU3qg1sKkkMs7eIlr1gN8i3t9qdY9STt5tr66OU/QpqNcJ72AmGUTXUy8tlbhj9mrKq379LdCm8w+ex8dsk65nUA5/r6g9e4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782936683583679.4211314325357; Wed, 1 Jul 2026 13:11:23 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wf1F6-0001ts-Ni; Wed, 01 Jul 2026 16:09:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1weylX-0008Kj-Q2; Wed, 01 Jul 2026 13:30:29 -0400 Received: from smtp2-g21.free.fr ([212.27.42.2]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1weylW-0006wb-2m; Wed, 01 Jul 2026 13:30:27 -0400 Received: from localhost (unknown [89.92.102.124]) (Authenticated sender: emmanuel.blot@free.fr) by smtp2-g21.free.fr (Postfix) with ESMTPSA id 60B662003CA; Wed, 1 Jul 2026 19:30:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1782927023; bh=rtgoa2ZXcKYJ0bC3r8HA9NmSZpy9z/77OldWyHbsVvE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=ZQumOsZax7vdWPvRJ32hhSg0xDG9QXmhY1S2eKemUOxuZN42JfEGA060eoDhKiB7N G4BvMli+FqC6dK6rFUlNYQZi1Jp6FqFz6DGjOXrFqHk6slUICI1PcqeOT2LHvwREJS 2J0o1IpT1AYDAsY5QlvcZ4YUjlpIh2uQM0aZWK6IBYfuHNUjZJRVL26tyQ5SEyO7AF Tf7JbdMWva2FxnSwn9ySwynamVf1A1teWucRzzmHOtfRx+HKvAwH1pA/juFAGBPuJI 6FoJGJ3W2YHG2t+QcUSYINucgjzAhRwB0Fuvnu2xq8Lj5gHfe78/u1TOzJH0mRG1fx HENQKhShMqzYA== From: Emmanuel Blot Date: Wed, 01 Jul 2026 19:28:34 +0200 Subject: [PATCH v5 4/8] tests/qtest: adc128d818: test limit interrupts MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260701-i2c-adc128d818-anacapa-v5-4-fe8292d86b38@free.fr> References: <20260701-i2c-adc128d818-anacapa-v5-0-fe8292d86b38@free.fr> In-Reply-To: <20260701-i2c-adc128d818-anacapa-v5-0-fe8292d86b38@free.fr> To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Fabiano Rosas , Laurent Vivier , Peter Maydell , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Steven Lee , Troy Lee , Jamin Lin , Kane Chen , Andrew Jeffery , Joel Stanley , Alexander Hansen , William de Abreu Pinho , Emmanuel Blot , qemu-arm@nongnu.org, Emmanuel Blot , Corey Minyard X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1782926919; l=5773; i=emmanuel.blot@free.fr; s=20260602; h=from:subject:message-id; bh=rtgoa2ZXcKYJ0bC3r8HA9NmSZpy9z/77OldWyHbsVvE=; b=bY6T7JWadDl4YiQ/uUPuGHUY6ebWgYtN8SLw3fy3YctIltLEFO9o1CtmmHsjwjiMEa67fiNjv ecpKxoF9Nj7AZKiaNoSq0RaYXtycGHvaFa5JrJmpHL+Sf6ineaSvvai X-Developer-Key: i=emmanuel.blot@free.fr; a=ed25519; pk=0qFrZ21FAAN8OfVsSoVcCFTk/NMYOWzxJz4paSAVm0g= Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=212.27.42.2; envelope-from=emmanuel.blot@free.fr; helo=smtp2-g21.free.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 01 Jul 2026 16:09:06 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @free.fr) X-ZM-MESSAGEID: 1782936684540158500 Cover per-channel high- and low-limit interrupt status, the INT_CLEAR bit gating the monitoring loop, and the temperature high-limit alarm with hysteresis. Signed-off-by: Emmanuel Blot --- tests/qtest/adc128d818-test.c | 121 ++++++++++++++++++++++++++++++++++++++= ++++ 1 file changed, 121 insertions(+) diff --git a/tests/qtest/adc128d818-test.c b/tests/qtest/adc128d818-test.c index 891189f0bd..3e3fabb8d9 100644 --- a/tests/qtest/adc128d818-test.c +++ b/tests/qtest/adc128d818-test.c @@ -330,6 +330,123 @@ static void test_ext_vref(void *obj, void *data, QGue= stAllocator *alloc) g_assert_cmphex(reading, =3D=3D, 0x8000); } =20 +/* Interrupt status set on limit violation; persists while fault remains */ +static void test_interrupt_status(void *obj, void *data, QGuestAllocator *= alloc) +{ + QI2CDevice *dev =3D (QI2CDevice *)obj; + uint8_t status; + + i2c_set8(dev, REG_LIMIT_BASE, 0x10); + g_test_message("Set ch0 high limit =3D 0x10"); + + qmp_adc128d818_set("ain0", 2560); + g_test_message("Injected ain0 =3D 2560 mV (exceeds limit)"); + + i2c_set8(dev, REG_CONFIG, CONFIG_START | CONFIG_INT_ENABLE); + + status =3D i2c_get8(dev, REG_INT_STATUS); + g_test_message("INT_STATUS =3D 0x%02x (expect bit 0 set)", status); + g_assert_cmphex(status & 0x01u, =3D=3D, 0x01); + + status =3D i2c_get8(dev, REG_INT_STATUS); + g_test_message("INT_STATUS after re-read =3D 0x%02x (expect bit 0 stil= l set)", + status); + g_assert_cmphex(status & 0x01u, =3D=3D, 0x01); + + qmp_adc128d818_set("ain0", 80); + g_test_message("Injected ain0 =3D 80 mV (within limit)"); + status =3D i2c_get8(dev, REG_INT_STATUS); + g_test_message("INT_STATUS after fault cleared =3D 0x%02x " + "(expect bit 0 clear)", status); + g_assert_cmphex(status & 0x01u, =3D=3D, 0x00); +} + +/* INT_CLEAR stops the round-robin monitoring loop */ +static void test_int_clear(void *obj, void *data, QGuestAllocator *alloc) +{ + QI2CDevice *dev =3D (QI2CDevice *)obj; + uint8_t status; + + i2c_set8(dev, REG_LIMIT_BASE, 0x10); + qmp_adc128d818_set("ain0", 2560); + + i2c_set8(dev, REG_CONFIG, + CONFIG_START | CONFIG_INT_ENABLE | CONFIG_INT_CLEAR); + status =3D i2c_get8(dev, REG_INT_STATUS); + g_test_message("INT_STATUS with INT_CLEAR set =3D 0x%02x (expect 0x00)= ", + status); + g_assert_cmphex(status, =3D=3D, 0x00); + + i2c_set8(dev, REG_CONFIG, CONFIG_START | CONFIG_INT_ENABLE); + status =3D i2c_get8(dev, REG_INT_STATUS); + g_test_message("INT_STATUS after INT_CLEAR cleared =3D 0x%02x (expect = bit 0)", + status); + g_assert_cmphex(status & 0x01u, =3D=3D, 0x01); +} + +/* Low-limit interrupt triggers correctly */ +static void test_low_limit(void *obj, void *data, QGuestAllocator *alloc) +{ + QI2CDevice *dev =3D (QI2CDevice *)obj; + uint8_t status; + + i2c_set8(dev, REG_CONFIG, CONFIG_INITIALIZATION); + + i2c_set8(dev, REG_LIMIT_BASE + 3u, 0x80); + g_test_message("Set ch1 low limit =3D 0x80"); + + i2c_set8(dev, REG_LIMIT_BASE + 5u, 0x80); + g_test_message("Set ch2 low limit =3D 0x80"); + + qmp_adc128d818_set("ain1", 640); + qmp_adc128d818_set("ain2", 1280); + qmp_adc128d818_set("ain0", 1280); + i2c_set8(dev, REG_CONFIG, CONFIG_START | CONFIG_INT_ENABLE); + + status =3D i2c_get8(dev, REG_INT_STATUS); + g_test_message("INT_STATUS =3D 0x%02x (expect bits 1 and 2 set)", stat= us); + g_assert_cmphex(status & 0x02u, =3D=3D, 0x02); + g_assert_cmphex(status & 0x04u, =3D=3D, 0x04); + + g_assert_cmphex(status & 0x01u, =3D=3D, 0x00); +} + +/* Temperature high-limit interrupt with hysteresis */ +static void test_temp_hysteresis(void *obj, void *data, + QGuestAllocator *alloc) +{ + QI2CDevice *dev =3D (QI2CDevice *)obj; + uint8_t status; + + i2c_set8(dev, REG_CONFIG, CONFIG_INITIALIZATION); + + i2c_set8(dev, REG_LIMIT_BASE + 7u * 2u, 0x32); + i2c_set8(dev, REG_LIMIT_BASE + 7u * 2u + 1u, 0x28); + + qmp_adc128d818_set("temperature", 25000); + i2c_set8(dev, REG_CONFIG, CONFIG_START); + + status =3D i2c_get8(dev, REG_INT_STATUS); + g_test_message("25 C: INT_STATUS =3D 0x%02x (temp bit expect clear)", = status); + g_assert_cmphex(status & 0x80u, =3D=3D, 0x00); + + qmp_adc128d818_set("temperature", 55000); + status =3D i2c_get8(dev, REG_INT_STATUS); + g_test_message("55 C: INT_STATUS =3D 0x%02x (temp bit expect set)", st= atus); + g_assert_cmphex(status & 0x80u, =3D=3D, 0x80); + + qmp_adc128d818_set("temperature", 45000); + status =3D i2c_get8(dev, REG_INT_STATUS); + g_test_message("45 C (hysteresis): INT_STATUS =3D 0x%02x " + "(temp bit expect set)", status); + g_assert_cmphex(status & 0x80u, =3D=3D, 0x80); + + qmp_adc128d818_set("temperature", 35000); + status =3D i2c_get8(dev, REG_INT_STATUS); + g_test_message("35 C: INT_STATUS =3D 0x%02x (temp bit expect clear)", = status); + g_assert_cmphex(status & 0x80u, =3D=3D, 0x00); +} + static void adc128d818_register_nodes(void) { QOSGraphEdgeOptions opts =3D { @@ -354,5 +471,9 @@ static void adc128d818_register_nodes(void) qos_add_test("temperature-edges", "adc128d818", test_temperature_edges, NULL); qos_add_test("ext-vref", "adc128d818", test_ext_vref, NULL); + qos_add_test("interrupt-status", "adc128d818", test_interrupt_status, = NULL); + qos_add_test("int-clear", "adc128d818", test_int_clear, NULL); + qos_add_test("low-limit", "adc128d818", test_low_limit, NULL); + qos_add_test("temp-hysteresis", "adc128d818", test_temp_hysteresis, NU= LL); } libqos_init(adc128d818_register_nodes); --=20 2.50.1 From nobody Sun Jul 26 11:08:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=free.fr ARC-Seal: i=1; a=rsa-sha256; t=1782936666; cv=none; d=zohomail.com; s=zohoarc; b=Hopjg4w/SEnKb7T6b2TYTCYFSPPDj+5Zi4Rq81KFKvK/7st0G7A1mJFqKaXhOUKrd0T/MinZh58eQIYZUxwqo/MnsBbJmzyCajkkQELf0EaBzUxk4yPvYJGoghpgxo/19kDoixmIdK/b4Vnl/yCs6bHvi/Hf+oudo3d2jzETu5Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782936666; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=iLsBlNiekYSxmJyPvBYnFdo1QjPdE+yzJPlSv30zsfs=; b=CoeRWLLvmvBZHtY3AoDwVUk9G38qTwJzRSVp0VvbMrRRqJyCgzL3ikv1o0NmDIGmHt2WcqQbP/aNNpESbdKCDHFI7DjCT5Ojxvmuq+y1DPnClM1EdgYGExN3JhtezjHXgkJJ9qu7O5mKmiuqEU5L0NIk3ATiBk3p+unOxbuwMvE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782936666718988.2350219256408; Wed, 1 Jul 2026 13:11:06 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wf1F7-0001uZ-8H; Wed, 01 Jul 2026 16:09:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1weylt-0008NX-TD; Wed, 01 Jul 2026 13:30:51 -0400 Received: from smtp2-g21.free.fr ([2a01:e0c:1:1599::11]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1weylq-000720-CI; Wed, 01 Jul 2026 13:30:48 -0400 Received: from localhost (unknown [89.92.102.124]) (Authenticated sender: emmanuel.blot@free.fr) by smtp2-g21.free.fr (Postfix) with ESMTPSA id 41DBE2003EF; Wed, 1 Jul 2026 19:30:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1782927043; bh=Ci92DM7ubxGnZO6XcCqK3dFshWaDGonAq2VBzBGHx8Y=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=lH8LitDqkQPiFh07Rfwpcv2QtkW/6cdRPAIek7hM6CGso7DGbspJiDRlYmdJrqugc 0Bg8Sumrlisl0VMXyf9vAElzQpaovtt9hUgORvabcpPDuFcMnf/YviinF3faQDuH5Q wUxs2pUzly2mjbgcoUckvVjRRvBsN7czsu19vgbTegdvB6a6xOA2k/rX/HU1NAfaFf u40HbsZm5+DBRXdGC/G5zcn3PbGlNgDzYWOw1OE5D7nLHIIpsEEw2AuCkczOc+FvNL A6MJk/rSXY2pXg+tRQOCBV1Ed8E1jbgAa3J2DGC14lhWWJHgvjTsYDVpGdrE+onNQr APYbYIdbtDXdA== From: Emmanuel Blot Date: Wed, 01 Jul 2026 19:28:35 +0200 Subject: [PATCH v5 5/8] tests/qtest: adc128d818: test operating modes and power control MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260701-i2c-adc128d818-anacapa-v5-5-fe8292d86b38@free.fr> References: <20260701-i2c-adc128d818-anacapa-v5-0-fe8292d86b38@free.fr> In-Reply-To: <20260701-i2c-adc128d818-anacapa-v5-0-fe8292d86b38@free.fr> To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Fabiano Rosas , Laurent Vivier , Peter Maydell , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Steven Lee , Troy Lee , Jamin Lin , Kane Chen , Andrew Jeffery , Joel Stanley , Alexander Hansen , William de Abreu Pinho , Emmanuel Blot , qemu-arm@nongnu.org, Emmanuel Blot , Corey Minyard X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1782926919; l=15955; i=emmanuel.blot@free.fr; s=20260602; h=from:subject:message-id; bh=Ci92DM7ubxGnZO6XcCqK3dFshWaDGonAq2VBzBGHx8Y=; b=Dal5e7oLvnek+TvQqSa/9RzHrCQ2HEXhEMu5ZOzzHQ0PQ7l0xdZt8NaUtUEbmv5MKS/zyciJ7 fPp44QPoRnrBWT1c+xq266OSue+TgPUDJ8A8M5P4CbdqVOEFhnE1Ooe X-Developer-Key: i=emmanuel.blot@free.fr; a=ed25519; pk=0qFrZ21FAAN8OfVsSoVcCFTk/NMYOWzxJz4paSAVm0g= Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:e0c:1:1599::11; envelope-from=emmanuel.blot@free.fr; helo=smtp2-g21.free.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 01 Jul 2026 16:09:06 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @free.fr) X-ZM-MESSAGEID: 1782936668262158500 Cover advanced-configuration mode selection (single-ended, pseudo-differential pairs, and mixed) and the reset of readings on reconfiguration, plus channel disable, one-shot conversion, deep shutdown, BUSY_STATUS lifecycle, and conversion-rate gating. Signed-off-by: Emmanuel Blot --- tests/qtest/adc128d818-test.c | 377 ++++++++++++++++++++++++++++++++++++++= ++++ 1 file changed, 377 insertions(+) diff --git a/tests/qtest/adc128d818-test.c b/tests/qtest/adc128d818-test.c index 3e3fabb8d9..c3ed2c53b6 100644 --- a/tests/qtest/adc128d818-test.c +++ b/tests/qtest/adc128d818-test.c @@ -447,6 +447,368 @@ static void test_temp_hysteresis(void *obj, void *dat= a, g_assert_cmphex(status & 0x80u, =3D=3D, 0x00); } =20 +/* Channel disable prevents conversion */ +static void test_channel_disable(void *obj, void *data, QGuestAllocator *a= lloc) +{ + QI2CDevice *dev =3D (QI2CDevice *)obj; + uint16_t reading; + + i2c_set8(dev, REG_CH_DISABLE, 0x01); + g_test_message("Disabled channel 0"); + + qmp_adc128d818_set("ain0", 1280); + g_test_message("Injected ain0 =3D 1280 mV (disabled)"); + i2c_set8(dev, REG_CONFIG, CONFIG_START); + + reading =3D i2c_get16(dev, REG_CH_READING_BASE); + g_test_message("Read ch0 (disabled): raw 0x%04x", reading); + g_assert_cmphex(reading, =3D=3D, 0x0000); + + qmp_adc128d818_set("ain1", 1280); + g_test_message("Injected ain1 =3D 1280 mV (enabled)"); + reading =3D i2c_get16(dev, REG_CH_READING_BASE + 1u); + g_test_message("Read ch1 (enabled): raw 0x%04x -> %u mV", reading, + (reading >> 4u) * INTERNAL_VREF_MV / 4096u); + g_assert_cmphex(reading, =3D=3D, 0x8000); +} + +/* One-shot conversion in shutdown mode */ +static void test_one_shot(void *obj, void *data, QGuestAllocator *alloc) +{ + QI2CDevice *dev =3D (QI2CDevice *)obj; + uint16_t reading; + + qmp_adc128d818_set("ain0", 1280); + g_test_message("Injected ain0 =3D 1280 mV (device stopped)"); + + reading =3D i2c_get16(dev, REG_CH_READING_BASE); + g_test_message("Read ch0 before one-shot: raw 0x%04x", reading); + g_assert_cmphex(reading, =3D=3D, 0x0000); + + g_assert_cmphex(i2c_get8(dev, REG_ONE_SHOT), =3D=3D, 0x00); + + i2c_set8(dev, REG_ONE_SHOT, 0x00); + g_test_message("Triggered one-shot conversion with value 0x00"); + + reading =3D i2c_get16(dev, REG_CH_READING_BASE); + g_test_message("Read ch0 after one-shot: raw 0x%04x -> %u mV", reading, + (reading >> 4u) * INTERNAL_VREF_MV / 4096u); + g_assert_cmphex(reading, =3D=3D, 0x8000); +} + +/* Mode 1 makes channel 7 a voltage input instead of temperature */ +static void test_mode_selection(void *obj, void *data, QGuestAllocator *al= loc) +{ + QI2CDevice *dev =3D (QI2CDevice *)obj; + uint16_t reading; + + i2c_set8(dev, REG_ADV_CONFIG, ADV_CONFIG_MODE_1); + g_test_message("Set mode 1 (all voltage channels)"); + + qmp_adc128d818_set("ain7", 1280); + qmp_adc128d818_set("temperature", 50000); + g_test_message("Injected ain7 =3D 1280 mV, temperature =3D 50000 mC"); + + i2c_set8(dev, REG_CONFIG, CONFIG_START); + + reading =3D i2c_get16(dev, REG_CH_READING_BASE + 7u); + g_test_message("Read ch7 (mode 1): raw 0x%04x -> %u mV", reading, + (reading >> 4u) * INTERNAL_VREF_MV / 4096u); + g_assert_cmphex(reading, =3D=3D, 0x8000); +} + +/* Mode 2 =E2=80=94 4 pseudo-differential pairs */ +static void test_mode2_diff(void *obj, void *data, QGuestAllocator *alloc) +{ + QI2CDevice *dev =3D (QI2CDevice *)obj; + uint16_t reading; + + i2c_set8(dev, REG_ADV_CONFIG, ADV_CONFIG_MODE_2); + g_test_message("Set mode 2 (4 pseudo-differential pairs)"); + + qmp_adc128d818_set("ain0", 2000); + qmp_adc128d818_set("ain1", 720); + i2c_set8(dev, REG_CONFIG, CONFIG_START); + + reading =3D i2c_get16(dev, REG_CH_READING_BASE); + g_test_message("Pair 0 (IN0-IN1): raw 0x%04x (expect 0x8000)", reading= ); + g_assert_cmphex(reading, =3D=3D, 0x8000); + + qmp_adc128d818_set("ain3", 1920); + qmp_adc128d818_set("ain2", 640); + + reading =3D i2c_get16(dev, REG_CH_READING_BASE + 1u); + g_test_message("Pair 1 (IN3-IN2): raw 0x%04x (expect 0x8000)", reading= ); + g_assert_cmphex(reading, =3D=3D, 0x8000); + + qmp_adc128d818_set("ain4", 1500); + qmp_adc128d818_set("ain5", 220); + + reading =3D i2c_get16(dev, REG_CH_READING_BASE + 2u); + g_test_message("Pair 2 (IN4-IN5): raw 0x%04x (expect 0x8000)", reading= ); + g_assert_cmphex(reading, =3D=3D, 0x8000); + + qmp_adc128d818_set("ain7", 2560); + qmp_adc128d818_set("ain6", 1280); + + reading =3D i2c_get16(dev, REG_CH_READING_BASE + 3u); + g_test_message("Pair 3 (IN7-IN6): raw 0x%04x (expect 0x8000)", reading= ); + g_assert_cmphex(reading, =3D=3D, 0x8000); + + reading =3D i2c_get16(dev, REG_CH_READING_BASE + 4u); + g_test_message("Reserved ch4: raw 0x%04x (expect 0x0000)", reading); + g_assert_cmphex(reading, =3D=3D, 0x0000); + + qmp_adc128d818_set("ain0", 500); + qmp_adc128d818_set("ain1", 1000); + + reading =3D i2c_get16(dev, REG_CH_READING_BASE); + g_test_message("Pair 0 negative =CE=94V: raw 0x%04x (expect 0x0000)", = reading); + g_assert_cmphex(reading, =3D=3D, 0x0000); +} + +/* Mode 3 =E2=80=94 4 single-ended + 2 pseudo-differential pairs */ +static void test_mode3_mixed(void *obj, void *data, QGuestAllocator *alloc) +{ + QI2CDevice *dev =3D (QI2CDevice *)obj; + uint16_t reading; + + i2c_set8(dev, REG_ADV_CONFIG, ADV_CONFIG_MODE_3); + g_test_message("Set mode 3 (4 single-ended + 2 differential)"); + + qmp_adc128d818_set("ain0", 1280); + i2c_set8(dev, REG_CONFIG, CONFIG_START); + + reading =3D i2c_get16(dev, REG_CH_READING_BASE); + g_test_message("Ch0 single-ended: raw 0x%04x (expect 0x8000)", reading= ); + g_assert_cmphex(reading, =3D=3D, 0x8000); + + qmp_adc128d818_set("ain4", 1500); + qmp_adc128d818_set("ain5", 220); + + reading =3D i2c_get16(dev, REG_CH_READING_BASE + 4u); + g_test_message("Ch4 diff (IN4-IN5): raw 0x%04x (expect 0x8000)", readi= ng); + g_assert_cmphex(reading, =3D=3D, 0x8000); + + qmp_adc128d818_set("ain7", 2560); + qmp_adc128d818_set("ain6", 1280); + + reading =3D i2c_get16(dev, REG_CH_READING_BASE + 5u); + g_test_message("Ch5 diff (IN7-IN6): raw 0x%04x (expect 0x8000)", readi= ng); + g_assert_cmphex(reading, =3D=3D, 0x8000); + + reading =3D i2c_get16(dev, REG_CH_READING_BASE + 6u); + g_test_message("Reserved ch6: raw 0x%04x (expect 0x0000)", reading); + g_assert_cmphex(reading, =3D=3D, 0x0000); + + qmp_adc128d818_set("temperature", 25000); + + reading =3D i2c_get16(dev, REG_CH_READING_BASE + 7u); + g_test_message("Ch7 temperature: raw 0x%04x (expect 0x1900)", reading); + g_assert_cmphex(reading, =3D=3D, 0x1900); +} + +/* Mode change resets channel readings and interrupt status */ +static void test_mode_change_reset(void *obj, void *data, + QGuestAllocator *alloc) +{ + QI2CDevice *dev =3D (QI2CDevice *)obj; + uint16_t reading; + uint8_t status; + + qmp_adc128d818_set("ain0", 1280); + i2c_set8(dev, REG_CONFIG, CONFIG_START); + + reading =3D i2c_get16(dev, REG_CH_READING_BASE); + g_test_message("Before mode change, ch0: raw 0x%04x", reading); + g_assert_cmphex(reading, !=3D, 0x0000); + + i2c_set8(dev, REG_CONFIG, 0x00); + i2c_set8(dev, REG_LIMIT_BASE, 0x10); + qmp_adc128d818_set("ain0", 2560); + i2c_set8(dev, REG_CONFIG, CONFIG_START); + + i2c_set8(dev, REG_CONFIG, 0x00); + i2c_set8(dev, REG_ADV_CONFIG, ADV_CONFIG_MODE_2); + + reading =3D i2c_get16(dev, REG_CH_READING_BASE); + g_test_message("After mode change, ch0: raw 0x%04x (expect 0x0000)", + reading); + g_assert_cmphex(reading, =3D=3D, 0x0000); + + status =3D i2c_get8(dev, REG_INT_STATUS); + g_test_message("After mode change, INT_STATUS: 0x%02x (expect 0x00)", + status); + g_assert_cmphex(status, =3D=3D, 0x00); + + g_assert_cmphex(i2c_get8(dev, REG_LIMIT_BASE), =3D=3D, 0x10); + g_test_message("Limit register preserved after mode change"); +} + +/* QOM property changes trigger correct differential conversion */ +static void test_diff_qom_trigger(void *obj, void *data, + QGuestAllocator *alloc) +{ + QI2CDevice *dev =3D (QI2CDevice *)obj; + uint16_t reading; + + i2c_set8(dev, REG_CONFIG, CONFIG_INITIALIZATION); + i2c_set8(dev, REG_ADV_CONFIG, ADV_CONFIG_MODE_2); + + qmp_adc128d818_set("ain0", 0); + qmp_adc128d818_set("ain1", 0); + qmp_adc128d818_set("ain2", 0); + qmp_adc128d818_set("ain3", 0); + i2c_set8(dev, REG_CONFIG, CONFIG_START); + + qmp_adc128d818_set("ain0", 2000); + reading =3D i2c_get16(dev, REG_CH_READING_BASE); + g_test_message("After ain0=3D2000, ain1=3D0: pair0 =3D 0x%04x (expect = 0xC800)", + reading); + g_assert_cmphex(reading, =3D=3D, 0xC800); + + qmp_adc128d818_set("ain1", 720); + reading =3D i2c_get16(dev, REG_CH_READING_BASE); + g_test_message("After ain1=3D720: pair0 =3D 0x%04x (expect 0x8000)", r= eading); + g_assert_cmphex(reading, =3D=3D, 0x8000); + + qmp_adc128d818_set("ain3", 1920); + qmp_adc128d818_set("ain2", 640); + reading =3D i2c_get16(dev, REG_CH_READING_BASE + 1u); + g_test_message("Pair 1 (IN3-IN2) via QOM: 0x%04x (expect 0x8000)", rea= ding); + g_assert_cmphex(reading, =3D=3D, 0x8000); +} + +/* One-shot conversion works in deep shutdown */ +static void test_deep_shutdown(void *obj, void *data, QGuestAllocator *all= oc) +{ + QI2CDevice *dev =3D (QI2CDevice *)obj; + uint16_t reading; + + i2c_set8(dev, REG_CONFIG, CONFIG_INITIALIZATION); + + qmp_adc128d818_set("ain0", 1280); + i2c_set8(dev, REG_CONFIG, CONFIG_START); + reading =3D i2c_get16(dev, REG_CH_READING_BASE); + g_assert_cmphex(reading, =3D=3D, 0x8000); + + i2c_set8(dev, REG_DEEP_SHUTDOWN, 0x01); + g_test_message("DEEP_SHUTDOWN write while running rejected"); + g_assert_cmphex(i2c_get8(dev, REG_DEEP_SHUTDOWN), =3D=3D, 0x00); + + i2c_set8(dev, REG_CONFIG, 0x00); + i2c_set8(dev, REG_DEEP_SHUTDOWN, 0x01); + qmp_adc128d818_set("ain0", 0); + + reading =3D i2c_get16(dev, REG_CH_READING_BASE); + g_test_message("Deep shutdown, no one-shot: raw 0x%04x (expect 0x8000)= ", + reading); + g_assert_cmphex(reading, =3D=3D, 0x8000); + + i2c_set8(dev, REG_ONE_SHOT, 0x01); + reading =3D i2c_get16(dev, REG_CH_READING_BASE); + g_test_message("Deep shutdown one-shot: raw 0x%04x (expect 0x0000)", + reading); + g_assert_cmphex(reading, =3D=3D, 0x0000); + + g_assert_cmphex(i2c_get8(dev, REG_DEEP_SHUTDOWN), =3D=3D, 0x01); + + i2c_set8(dev, REG_DEEP_SHUTDOWN, 0x00); + qmp_adc128d818_set("ain0", 1280); + i2c_set8(dev, REG_ONE_SHOT, 0x01); + reading =3D i2c_get16(dev, REG_CH_READING_BASE); + g_test_message("After exit shutdown: raw 0x%04x (expect 0x8000)", read= ing); + g_assert_cmphex(reading, =3D=3D, 0x8000); +} + +/* BUSY_STATUS NOT_READY clears after first conversion */ +static void test_busy_status(void *obj, void *data, QGuestAllocator *alloc) +{ + QI2CDevice *dev =3D (QI2CDevice *)obj; + + i2c_set8(dev, REG_CONFIG, CONFIG_INITIALIZATION); + + g_assert_cmphex(i2c_get8(dev, REG_BUSY_STATUS) & 0x02, =3D=3D, 0x02); + g_test_message("After reset: BUSY_STATUS =3D 0x%02x (NOT_READY set)", + i2c_get8(dev, REG_BUSY_STATUS)); + + qmp_adc128d818_set("ain0", 0); + i2c_set8(dev, REG_CONFIG, CONFIG_START); + + g_assert_cmphex(i2c_get8(dev, REG_BUSY_STATUS) & 0x02, =3D=3D, 0x00); + g_test_message("After conversion: BUSY_STATUS =3D 0x%02x (NOT_READY cl= eared)", + i2c_get8(dev, REG_BUSY_STATUS)); +} + +/* Programming Channel Disable resets channel readings */ +static void test_chan_disable_clears(void *obj, void *data, + QGuestAllocator *alloc) +{ + QI2CDevice *dev =3D (QI2CDevice *)obj; + uint16_t reading; + + i2c_set8(dev, REG_CONFIG, CONFIG_INITIALIZATION); + + qmp_adc128d818_set("ain0", 1280); + i2c_set8(dev, REG_CONFIG, CONFIG_START); + g_assert_cmphex(i2c_get16(dev, REG_CH_READING_BASE), =3D=3D, 0x8000); + + i2c_set8(dev, REG_CONFIG, 0x00); + i2c_set8(dev, REG_CH_DISABLE, 0x02); + reading =3D i2c_get16(dev, REG_CH_READING_BASE); + g_test_message("After CH_DISABLE write: ch0 raw 0x%04x (expect 0x0000)= ", + reading); + g_assert_cmphex(reading, =3D=3D, 0x0000); +} + +/* Programming Advanced Configuration always resets channel readings */ +static void test_adv_config_clears(void *obj, void *data, + QGuestAllocator *alloc) +{ + QI2CDevice *dev =3D (QI2CDevice *)obj; + uint16_t reading; + + i2c_set8(dev, REG_CONFIG, CONFIG_INITIALIZATION); + + qmp_adc128d818_set("ain0", 1280); + i2c_set8(dev, REG_CONFIG, CONFIG_START); + g_assert_cmphex(i2c_get16(dev, REG_CH_READING_BASE), =3D=3D, 0x8000); + + i2c_set8(dev, REG_CONFIG, 0x00); + i2c_set8(dev, REG_ADV_CONFIG, 0x00); + reading =3D i2c_get16(dev, REG_CH_READING_BASE); + g_test_message("After same-mode ADV_CONFIG: ch0 0x%04x (expect 0x0000)= ", + reading); + g_assert_cmphex(reading, =3D=3D, 0x0000); + + i2c_set8(dev, REG_CONFIG, CONFIG_START); + g_assert_cmphex(i2c_get16(dev, REG_CH_READING_BASE), =3D=3D, 0x8000); + i2c_set8(dev, REG_CONFIG, 0x00); + qmp_adc128d818_set("ext-vref-mv", 4096); + i2c_set8(dev, REG_ADV_CONFIG, ADV_CONFIG_EXT_REF_EN); + reading =3D i2c_get16(dev, REG_CH_READING_BASE); + g_test_message("After ext-vref toggle: ch0 0x%04x (expect 0x0000)", + reading); + g_assert_cmphex(reading, =3D=3D, 0x0000); +} + +/* Conversion Rate register may only be programmed while in shutdown */ +static void test_conv_rate(void *obj, void *data, QGuestAllocator *alloc) +{ + QI2CDevice *dev =3D (QI2CDevice *)obj; + + i2c_set8(dev, REG_CONFIG, CONFIG_INITIALIZATION); + + i2c_set8(dev, REG_CONV_RATE, 0x01); + g_assert_cmphex(i2c_get8(dev, REG_CONV_RATE), =3D=3D, 0x01); + + i2c_set8(dev, REG_CONFIG, CONFIG_START); + i2c_set8(dev, REG_CONV_RATE, 0x00); + g_test_message("CONV_RATE while running: 0x%02x (expect unchanged 0x01= )", + i2c_get8(dev, REG_CONV_RATE)); + g_assert_cmphex(i2c_get8(dev, REG_CONV_RATE), =3D=3D, 0x01); +} + static void adc128d818_register_nodes(void) { QOSGraphEdgeOptions opts =3D { @@ -475,5 +837,20 @@ static void adc128d818_register_nodes(void) qos_add_test("int-clear", "adc128d818", test_int_clear, NULL); qos_add_test("low-limit", "adc128d818", test_low_limit, NULL); qos_add_test("temp-hysteresis", "adc128d818", test_temp_hysteresis, NU= LL); + qos_add_test("channel-disable", "adc128d818", test_channel_disable, NU= LL); + qos_add_test("one-shot", "adc128d818", test_one_shot, NULL); + qos_add_test("mode-selection", "adc128d818", test_mode_selection, NULL= ); + qos_add_test("mode2-diff", "adc128d818", test_mode2_diff, NULL); + qos_add_test("mode3-mixed", "adc128d818", test_mode3_mixed, NULL); + qos_add_test("mode-change-reset", "adc128d818", test_mode_change_reset, + NULL); + qos_add_test("diff-qom-trigger", "adc128d818", test_diff_qom_trigger, = NULL); + qos_add_test("deep-shutdown", "adc128d818", test_deep_shutdown, NULL); + qos_add_test("busy-status", "adc128d818", test_busy_status, NULL); + qos_add_test("chan-disable-clears", "adc128d818", test_chan_disable_cl= ears, + NULL); + qos_add_test("adv-config-clears", "adc128d818", test_adv_config_clears, + NULL); + qos_add_test("conv-rate", "adc128d818", test_conv_rate, NULL); } libqos_init(adc128d818_register_nodes); --=20 2.50.1 From nobody Sun Jul 26 11:08:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=free.fr ARC-Seal: i=1; a=rsa-sha256; t=1782936663; cv=none; d=zohomail.com; s=zohoarc; b=Gu4d8rXXzkcgzRZw5Pk8vegEBK7SUnKMGVULDqDKvSQlNZjWn+vGoHu1Eb9cEbbDjclkYm1broDX9GZ9aIoI4Ma2isGW39k2xJONvMUTmIIs8UwqhcJp+QSHfXB3MCYiXy4vZjfEfSnYn9qoENUKIA6gdWQHJ9Fx69e0HOy0/3M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782936663; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=3ns+xayhOlBUKeMQXRl6DIvX/GHVH/t6jbJ8qD/hwjM=; b=Gx1dbFzrUTzhaXU6uwceq/DxYxrMRvnu7FabyVWaTCxiSewzQ9wi9rMxSor4ksi7mVP3DHUrfi5biuvKc5aw8B5FWeDi5SXdeTImaegrN5XsIZbwtQFHPh4qxBI/dWG/H+RSWFdLy5XZF+vSMowFAGjharwOJrn5us74VAIsVoU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782936663334581.393961148785; Wed, 1 Jul 2026 13:11:03 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wf1F6-0001tK-6O; Wed, 01 Jul 2026 16:09:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1weymB-0008Rz-Pa; Wed, 01 Jul 2026 13:31:10 -0400 Received: from smtp2-g21.free.fr ([212.27.42.2]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1weym9-00076Q-8H; Wed, 01 Jul 2026 13:31:06 -0400 Received: from localhost (unknown [89.92.102.124]) (Authenticated sender: emmanuel.blot@free.fr) by smtp2-g21.free.fr (Postfix) with ESMTPSA id 5411320039C; Wed, 1 Jul 2026 19:30:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1782927063; bh=5RR/JV4/2/FiMsKYyKL8/JRzz1BaLNPiNpMJ8H3UqBM=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=ksn5bADQb9BFxg05L2HjDppEv7dPSs/8mGGxlYqjxnFkCZMXjLPVm87u+88D5/oOu 0zkJobJ6H40zzdrEOgYHSE9wW7e8G6FQPQTPh8o9esEkcSjEHay/qek1A+O9UDPWms CcxelwIkvOxDu1DISxp2Fhkj//P/ox73jxkVbK5OP6W7/6A+7+3X6ED4vzQSOtqPff gbLuookCH28F2lay/KaFvlMeMd8zbCbackdO3neS/ekt4DIVtWBRGwViUt5Yws2Ard SvR58m4E1pEq0w7yQg9a1RTPzXqzdiomUuUJKk5QMhBSx20muQ1cLVjCpWwx8g7bBX GVIiH8pOKSShQ== From: Emmanuel Blot Date: Wed, 01 Jul 2026 19:28:36 +0200 Subject: [PATCH v5 6/8] hw/i2c: parent slaves created with i2c_slave_create_simple MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260701-i2c-adc128d818-anacapa-v5-6-fe8292d86b38@free.fr> References: <20260701-i2c-adc128d818-anacapa-v5-0-fe8292d86b38@free.fr> In-Reply-To: <20260701-i2c-adc128d818-anacapa-v5-0-fe8292d86b38@free.fr> To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Fabiano Rosas , Laurent Vivier , Peter Maydell , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Steven Lee , Troy Lee , Jamin Lin , Kane Chen , Andrew Jeffery , Joel Stanley , Alexander Hansen , William de Abreu Pinho , Emmanuel Blot , qemu-arm@nongnu.org, Emmanuel Blot , Corey Minyard X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1782926919; l=1888; i=emmanuel.blot@free.fr; s=20260602; h=from:subject:message-id; bh=5RR/JV4/2/FiMsKYyKL8/JRzz1BaLNPiNpMJ8H3UqBM=; b=wk36rM89w9hkKGmfSsZGHq9Va3iTLoNv29/zrr8+VS31mKq8NtINsT8GZSje/wnqtqrm8XR6P Mxi29/PkTSICrB4LFrk0n4WRBnFTcBzKoL3humYzpPx8T7MVKsHb0xv X-Developer-Key: i=emmanuel.blot@free.fr; a=ed25519; pk=0qFrZ21FAAN8OfVsSoVcCFTk/NMYOWzxJz4paSAVm0g= Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=212.27.42.2; envelope-from=emmanuel.blot@free.fr; helo=smtp2-g21.free.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 01 Jul 2026 16:09:06 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @free.fr) X-ZM-MESSAGEID: 1782936666554158500 Slaves created with i2c_slave_create_simple() were left unparented and showed up under /machine/unattached with no stable QOM path. Add each slave as a QOM child of its bus, named after its I2C address, so it has a deterministic and addressable QOM path. Signed-off-by: Emmanuel Blot Reviewed-by: C=C3=A9dric Le Goater --- hw/i2c/core.c | 3 +++ include/hw/i2c/i2c.h | 7 +++++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/i2c/core.c b/hw/i2c/core.c index 54f6bdca88..0bbce45d48 100644 --- a/hw/i2c/core.c +++ b/hw/i2c/core.c @@ -382,6 +382,9 @@ I2CSlave *i2c_slave_create_simple(I2CBus *bus, const ch= ar *name, uint8_t addr) { I2CSlave *dev =3D i2c_slave_new(name, addr); =20 + g_autofree char *childname =3D g_strdup_printf("0x%02x", addr); + object_property_add_child(OBJECT(bus), childname, OBJECT(dev)); + i2c_slave_realize_and_unref(dev, bus, &error_abort); =20 return dev; diff --git a/include/hw/i2c/i2c.h b/include/hw/i2c/i2c.h index dd5930f4b5..dc557bbf3f 100644 --- a/include/hw/i2c/i2c.h +++ b/include/hw/i2c/i2c.h @@ -166,13 +166,16 @@ bool i2c_scan_bus(I2CBus *bus, uint8_t address, bool = broadcast, I2CSlave *i2c_slave_new(const char *name, uint8_t addr); =20 /** - * Create and realize an I2C slave device on the heap. + * Create and realize an I2C slave device on the heap, add the device as a + * child of its parent bus. + * * @bus: I2C bus to put it on * @name: I2C slave device type name * @addr: I2C address of the slave when put on a bus * * Create the device state structure, initialize it, put it on the - * specified @bus, and drop the reference to it (the device is realized). + * specified @bus, parent it, and drop the reference to it (the device is + * realized). */ I2CSlave *i2c_slave_create_simple(I2CBus *bus, const char *name, uint8_t a= ddr); =20 --=20 2.50.1 From nobody Sun Jul 26 11:08:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=free.fr ARC-Seal: i=1; a=rsa-sha256; t=1782936668; cv=none; d=zohomail.com; s=zohoarc; b=R5nJaF683DWRTTE3xNH4sv/43oacPSia98OCmAzaIZ1vN0MBI0651DePyYDu7NYdP/f/082R9JZ5NwtF4swc1KHQoW0gAE4a10GqBc4eaV/nFeb7lbL8qvJQQj/HErXr7mgf5NUVRTUdIurnsbwHOldaZ4PIkjO/ZL+cE+8ZDJo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782936668; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=tU/cDWBiA9dZaaWw3ud2aL9/ipZtgaba/PCTkyEt8Q8=; b=hnBOCwdBJhguWlO3Au90WrOg4qTQ6tf8U3RvhvN9qxNBTooqscUbtpj6LNuCe73S2I5znc6lDheX7AkeqbfYQ5cdj5szCcLpCPKoO+4Iy1vMh0rjfM/ydqPgeljZIEIhU2FjTsbqAh4pitOqoXDsXG+qAPKZuAUoxZn5tIfXWS8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782936668628676.0633150056493; Wed, 1 Jul 2026 13:11:08 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wf1F7-0001ua-8s; Wed, 01 Jul 2026 16:09:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1weyma-0008WJ-8y; Wed, 01 Jul 2026 13:31:32 -0400 Received: from smtp2-g21.free.fr ([2a01:e0c:1:1599::11]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1weymW-00079t-4R; Wed, 01 Jul 2026 13:31:30 -0400 Received: from localhost (unknown [89.92.102.124]) (Authenticated sender: emmanuel.blot@free.fr) by smtp2-g21.free.fr (Postfix) with ESMTPSA id 5F4FD2003EF; Wed, 1 Jul 2026 19:31:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1782927085; bh=d2xU5ugaq0WYvWO+htoe62DpMagP1np2F5de6Z3kIPE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=jgtMba+BGQzvNbdokQlvOv43yndpDuD9hMraeqs4CK9nvBINyPnKSL7WjewFBKhXJ t7HZW2jYi8mL8P10Jol5zxWASqSdGX8cqbZxOiFvS53JMBQ0fbTPRUkFlq00Rt+j2a iBSTTnahOANj+rQ5z5y1sERF5MXOzxdbn1G7u6qBP6Cuce0Sw0Tr7QbsUyH2MaLJhx IQQIjSysmopnAj4R3VhsJpaPXh11q9CypO+iYtwRbunXGEbqMXtcPtwddk/+gSfNso /fJESRNq+hEbJbNrIzvP+aA1H6CltAyDFokpel0+6RdVXf3PpWiTI2M2Q1EAk67tRT jkcM2GJFeHgqg== From: Emmanuel Blot Date: Wed, 01 Jul 2026 19:28:37 +0200 Subject: [PATCH v5 7/8] hw/arm: anacapa: add ADC128D818 devices MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260701-i2c-adc128d818-anacapa-v5-7-fe8292d86b38@free.fr> References: <20260701-i2c-adc128d818-anacapa-v5-0-fe8292d86b38@free.fr> In-Reply-To: <20260701-i2c-adc128d818-anacapa-v5-0-fe8292d86b38@free.fr> To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Fabiano Rosas , Laurent Vivier , Peter Maydell , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Steven Lee , Troy Lee , Jamin Lin , Kane Chen , Andrew Jeffery , Joel Stanley , Alexander Hansen , William de Abreu Pinho , Emmanuel Blot , qemu-arm@nongnu.org, Emmanuel Blot , Corey Minyard , =?utf-8?q?C=C3=A9dric_Le_Goater?= X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1782926919; l=3268; i=emmanuel.blot@free.fr; s=20260602; h=from:subject:message-id; bh=d2xU5ugaq0WYvWO+htoe62DpMagP1np2F5de6Z3kIPE=; b=G2f9UbP78E3/mm4inv3n5CAYgd2cWd0wg5TGMKQkpapZb2fSs+Fx0xh4uiV4TT3HMp49mwKj1 3k6r3XSVIBLCYDIlryOSewDARS8guROYNXgmkaK9ywYLVoCgiZwxCcz X-Developer-Key: i=emmanuel.blot@free.fr; a=ed25519; pk=0qFrZ21FAAN8OfVsSoVcCFTk/NMYOWzxJz4paSAVm0g= Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:e0c:1:1599::11; envelope-from=emmanuel.blot@free.fr; helo=smtp2-g21.free.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 01 Jul 2026 16:09:06 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @free.fr) X-ZM-MESSAGEID: 1782936670291158500 Wire up the two ADC128D818 instances that appear in the Anacapa DTS: one on i2c8 mux channel 0 and one on i2c13 mux channel 3. Reviewed-by: C=C3=A9dric Le Goater Signed-off-by: Emmanuel Blot --- hw/arm/Kconfig | 1 + hw/arm/aspeed_ast2600_anacapa.c | 21 +++++++++++++++++---- 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index fb798ccbee..04ecf5d473 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -553,6 +553,7 @@ config ASPEED_SOC select LED select PMBUS select MAX31785 + select ADC128D818 select FSI_APB2OPB_ASPEED select AT24C select PCI_EXPRESS diff --git a/hw/arm/aspeed_ast2600_anacapa.c b/hw/arm/aspeed_ast2600_anacap= a.c index a1c8111a93..18f759f5f8 100644 --- a/hw/arm/aspeed_ast2600_anacapa.c +++ b/hw/arm/aspeed_ast2600_anacapa.c @@ -1,13 +1,14 @@ /* * Facebook Anacapa * - * Copyright (c) Meta Platforms, Inc. and affiliates. + * Copyright (c) 2026 Meta Platforms, Inc. and affiliates. * * SPDX-License-Identifier: GPL-2.0-or-later */ =20 #include "qemu/osdep.h" #include "qapi/error.h" +#include "hw/sensor/adc128d818.h" #include "hw/arm/machines-qom.h" #include "hw/arm/aspeed.h" #include "hw/arm/aspeed_soc.h" @@ -15,7 +16,6 @@ #include "hw/gpio/pca9552.h" #include "hw/nvram/eeprom_at24c.h" =20 -/* Anacapa hardware value */ #define ANACAPA_BMC_HW_STRAP1 0x00002002 #define ANACAPA_BMC_HW_STRAP2 0x00000000 #define ANACAPA_BMC_RAM_SIZE ASPEED_RAM_SIZE(2 * GiB) @@ -221,6 +221,17 @@ static const uint8_t hpm_brd_id_eeprom[] =3D { }; static const size_t hpm_brd_id_eeprom_len =3D sizeof(hpm_brd_id_eeprom); =20 +static void anacapa_add_adc128d818(I2CBus *bus, uint8_t addr, + const char *description) +{ + DeviceState *dev =3D DEVICE(i2c_slave_new(TYPE_ADC128D818, addr)); + g_autofree char *childname =3D g_strdup_printf("0x%02x", addr); + + qdev_prop_set_string(dev, "description", description); + object_property_add_child(OBJECT(bus), childname, OBJECT(dev)); + i2c_slave_realize_and_unref(I2C_SLAVE(dev), bus, &error_fatal); +} + static void anacapa_bmc_i2c_init(AspeedMachineState *bmc) { /* Reference: aspeed-bmc-facebook-anacapa.dts */ @@ -259,7 +270,8 @@ static void anacapa_bmc_i2c_init(AspeedMachineState *bm= c) i2c_mux =3D i2c_slave_create_simple(i2c[8], TYPE_PCA9546, 0x72); =20 /* i2c8mux ch0 */ - /* adc128d818@1f =E2=80=94 no model */ + /* adc128d818@1f =E2=80=94 R-PDB ADC (mode 1: 8 voltage channels) */ + anacapa_add_adc128d818(pca954x_i2c_get_bus(i2c_mux, 0), 0x1f, "i2c8:0:= 1f"); /* pca9555@22 */ i2c_slave_create_simple(pca954x_i2c_get_bus(i2c_mux, 0), TYPE_PCA9552, 0x22); @@ -320,7 +332,8 @@ static void anacapa_bmc_i2c_init(AspeedMachineState *bm= c) i2c_mux =3D i2c_slave_create_simple(i2c[13], TYPE_PCA9548, 0x70); =20 /* i2c13mux ch3 */ - /* adc128d818@1f - no model */ + /* adc128d818@1f =E2=80=94 MB ADC (mode 1: 8 voltage channels) */ + anacapa_add_adc128d818(pca954x_i2c_get_bus(i2c_mux, 3), 0x1f, "i2c13:3= :1f"); =20 /* i2c13mux ch4 */ /* eeprom@51 */ --=20 2.50.1 From nobody Sun Jul 26 11:08:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=free.fr ARC-Seal: i=1; a=rsa-sha256; t=1782936675; cv=none; d=zohomail.com; s=zohoarc; b=fvF238kScrCC2pXDqmQhMPR4aah7RtO1Zon7jDXNlIN9a2r+zi/kXJ1Ipq/2zqBNK85LTVsWaFpOoE3Cs5xMgUIsk/UTdxgTy6dt1uR5N3VJoVUKnUZsNOTQbAwh3ZhtSTP0iuREGnDWC+7Moej+ww1S9lamtqM6M5HZsuFYZvE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782936675; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=gXgLVgw9Em6JPehKIkln257KUwQP/5QxlO4P6SoSVdE=; b=eL02/abgm1V972Td4Vg166zvRZEwv2BDLAC1yzf2q1cY2HLjfSZNQurBdGIkcT0Vi+3GJj9LGeQkV4szq306xDYBG8xCSrjlgHLXrBCk0HEND5bqVsmfAA4fe7XaK7Yb6hfVruoC3NCKMzypAACM4kpH44lRxRX+IlTAL6071XI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782936675840447.7445789304568; Wed, 1 Jul 2026 13:11:15 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wf1F6-0001tQ-9B; Wed, 01 Jul 2026 16:09:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1weymr-00009S-Al; Wed, 01 Jul 2026 13:31:56 -0400 Received: from smtp2-g21.free.fr ([2a01:e0c:1:1599::11]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1weymp-0007N2-75; Wed, 01 Jul 2026 13:31:48 -0400 Received: from localhost (unknown [89.92.102.124]) (Authenticated sender: emmanuel.blot@free.fr) by smtp2-g21.free.fr (Postfix) with ESMTPSA id 9C5262003C6; Wed, 1 Jul 2026 19:31:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1782927105; bh=WvcsUh32DCWpKfKABADNif+d9+Y8576yIkWIMEnm4os=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=JwpvvXrYMCc3wsf50cV+EVbgDy7YC/c1LILC/NPsUXmnSElFjR0yt7LaFbV4cHlTW WVVM5RL7yge6e40aA7gYBGC1rBSZ8d89GYSn9zmeftViGCgTfV4os282j5NQL1p1V6 yYguq/e+9spWdG75V4rd2K8WRFxBjsQCJKm6YTZp7TgmfCxBhZg9sNXrvBUAIN64IV 4yaJlGNMM8cHcnC2888avNixiGFVemWarb87mC1rgKm/gQZXn/XlRpmuOkLLNBl3qv DZt4WMrZ0mBq59EC0x7K5IrI1uI71A8tkQt0pgD99mRem4i6+Nh9PT3o1S8910APRG dTDwVP1ux7Tdw== From: Emmanuel Blot Date: Wed, 01 Jul 2026 19:28:38 +0200 Subject: [PATCH v5 8/8] test/functional: anacapa: test ADC128D818 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260701-i2c-adc128d818-anacapa-v5-8-fe8292d86b38@free.fr> References: <20260701-i2c-adc128d818-anacapa-v5-0-fe8292d86b38@free.fr> In-Reply-To: <20260701-i2c-adc128d818-anacapa-v5-0-fe8292d86b38@free.fr> To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Fabiano Rosas , Laurent Vivier , Peter Maydell , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Steven Lee , Troy Lee , Jamin Lin , Kane Chen , Andrew Jeffery , Joel Stanley , Alexander Hansen , William de Abreu Pinho , Emmanuel Blot , qemu-arm@nongnu.org, Emmanuel Blot , Corey Minyard X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1782926919; l=4381; i=emmanuel.blot@free.fr; s=20260602; h=from:subject:message-id; bh=WvcsUh32DCWpKfKABADNif+d9+Y8576yIkWIMEnm4os=; b=37rA/MpbaXR9yDxdbj6j8SQbKtD3sdw4PXcHboyyoNqeZG/tlVN7Swevu1+p92UWcQZCskyO/ R5RHi7Cjm2lCaWOG3unoPxvjhj/H0+tCVlI2btI+8FBmCcMtvTsPT7P X-Developer-Key: i=emmanuel.blot@free.fr; a=ed25519; pk=0qFrZ21FAAN8OfVsSoVcCFTk/NMYOWzxJz4paSAVm0g= Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a01:e0c:1:1599::11; envelope-from=emmanuel.blot@free.fr; helo=smtp2-g21.free.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 01 Jul 2026 16:09:06 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @free.fr) X-ZM-MESSAGEID: 1782936678317158500 Verify the ADC128D818 on the Anacapa R-PDB (i2c8 mux channel 0): two channels are driven with distinct voltages and each is checked to be reported back independently through the kernel hwmon interface, and the channel 0 limit registers are validated. Signed-off-by: Emmanuel Blot --- tests/functional/arm/test_aspeed_anacapa.py | 69 +++++++++++++++++++++++++= +--- 1 file changed, 63 insertions(+), 6 deletions(-) diff --git a/tests/functional/arm/test_aspeed_anacapa.py b/tests/functional= /arm/test_aspeed_anacapa.py index 2b72e46b0e..49fab7ad09 100644 --- a/tests/functional/arm/test_aspeed_anacapa.py +++ b/tests/functional/arm/test_aspeed_anacapa.py @@ -2,24 +2,81 @@ # # Functional test that boots the ASPEED machines # +# Copyright (c) 2026 Meta Platforms, Inc. and affiliates. +# # SPDX-License-Identifier: GPL-2.0-or-later =20 +import re +import time + from qemu_test import Asset +from qemu_test import exec_command_and_wait_for_pattern from aspeed import FacebookAspeedTest =20 =20 class AnacapaMachine(FacebookAspeedTest): =20 ASSET_ANACAPA_FLASH =3D Asset( - 'https://github.com/legoater/qemu-aspeed-boot/raw/c5f585f9f57843c0= dc95e3865a57d92ec39cbb0b/images/anacapa-bmc/openbmc-20260616025349/obmc-pho= sphor-image-anacapa-20260616025349.static.mtd.xz', - 'de3841fb6ed3085aec6424358ee6efc4b8ee85688361e5aa1987fd1acb7d3fb4') + "https://github.com/legoater/qemu-aspeed-boot/raw/c5f585f9f57843c0= dc95e3865a57d92ec39cbb0b/images/anacapa-bmc/openbmc-20260616025349/obmc-pho= sphor-image-anacapa-20260616025349.static.mtd.xz", + "de3841fb6ed3085aec6424358ee6efc4b8ee85688361e5aa1987fd1acb7d3fb4", + ) + + ADC128D818_QOM_PATH =3D \ + "/machine/soc/i2c/bus[8]/aspeed.i2c.bus.8/0x72/i2c.0/0x1f" + ADC128D818_MUX_CHANNEL =3D "/sys/bus/i2c/devices/8-0072/channel-0" + PROMPT =3D "root@anacapa:~#" =20 def test_arm_ast2600_anacapa_openbmc(self): image_path =3D self.uncompress(self.ASSET_ANACAPA_FLASH) =20 - self.do_test_arm_aspeed_openbmc('anacapa-bmc', image=3Dimage_path, - uboot=3D'2019.04', cpu_id=3D'0xf00= ', - soc=3D'AST2600 rev A3') + self.do_test_arm_aspeed_openbmc( + "anacapa-bmc", + image=3Dimage_path, + uboot=3D"2019.04", + cpu_id=3D"0xf00", + soc=3D"AST2600 rev A3", + ) =20 -if __name__ =3D=3D '__main__': + exec_command_and_wait_for_pattern(self, "root", "Password:") + exec_command_and_wait_for_pattern(self, "0penBmc", "#") + + self.adc_hwmon =3D self.resolve_adc128d818_hwmon() + self.assertIn(b"adc128d818", self.read_adc128d818("name")) + + adc =3D self.ADC128D818_QOM_PATH + for ch0_mv, ch1_mv in ((108, 2000), (1280, 500)): + self.vm.cmd("qom-set", path=3Dadc, property=3D"ain0", value=3D= ch0_mv) + self.vm.cmd("qom-set", path=3Dadc, property=3D"ain1", value=3D= ch1_mv) + self.wait_adc128d818_value("in0_input", ch0_mv) + self.wait_adc128d818_value("in1_input", ch1_mv) + + self.assertIn(b"2551", self.read_adc128d818("in0_max")) + self.assertRegex(self.read_adc128d818("in0_min"), rb"(?m)^0\r*$") + + def resolve_adc128d818_hwmon(self): + out =3D self.read_adc128d818_console( + f"basename $(readlink {self.ADC128D818_MUX_CHANNEL})" + ) + match =3D re.search(rb"i2c-(\d+)", out) + self.assertIsNotNone(match, "could not resolve ADC128D818 i2c bus") + bus =3D int(match.group(1)) + return f"/sys/bus/i2c/devices/{bus}-001f/hwmon/hwmon*" + + def read_adc128d818_console(self, command): + return exec_command_and_wait_for_pattern(self, command, self.PROMP= T) + + def read_adc128d818(self, attr): + return self.read_adc128d818_console(f"cat {self.adc_hwmon}/{attr}") + + def wait_adc128d818_value(self, attr, expected, timeout=3D20): + needle =3D str(expected).encode() + deadline =3D time.monotonic() + timeout + while time.monotonic() < deadline: + if needle in self.read_adc128d818(attr): + return + time.sleep(2) + self.fail(f"{attr} did not reach {expected}") + + +if __name__ =3D=3D "__main__": FacebookAspeedTest.main() --=20 2.50.1