From nobody Sun Jul 26 11:54:36 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1782403371; cv=none; d=zohomail.com; s=zohoarc; b=iFVlPNcDab7zVfahujlmoVHwEWHmhq0KaZ862iehK4FbQZWXS0huBT8Axwee9iGqe8xZi0u4pNeO8pCdEKy8IC+NqbFwvtsAcRb3Uy8mlo0Nwlpq5NxpIqcl6bUYp6LLRPkQ/lN/nR9WHahKui/LZ/ZZkzuSSxM65dbgNfEFDFM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782403371; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=PDhXOI1Vjxfmo7Q3X1FJCZ1/5NbFYlpsfWgi5kj/YBk=; b=jy7kng+PIet4uT55azjyrb387OvpkSPec/HEfmHYCyNLoJ6a7WxtoxyTH0ZsEBRVGhH5VH82NY2H/LJOvCTv6FvKB1kMdNJlAYdu8f+U/bQgiDRep0LWuK3n8j/rJZgqay6JBNGu1Xoz7fLk8BrTRRubeg+1mTt+o1zM9dfHHI4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from=<163wangjack@gmail.com> (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782403371247666.3155068564338; Thu, 25 Jun 2026 09:02:51 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wcmWr-0007Rk-Bh; Thu, 25 Jun 2026 12:02:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <163wangjack@gmail.com>) id 1wcmWo-0007LC-Ol for qemu-devel@nongnu.org; Thu, 25 Jun 2026 12:02:10 -0400 Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <163wangjack@gmail.com>) id 1wcmWn-0006YA-0r for qemu-devel@nongnu.org; Thu, 25 Jun 2026 12:02:10 -0400 Received: by mail-pg1-x530.google.com with SMTP id 41be03b00d2f7-c85b73ffb52so11322a12.3 for ; Thu, 25 Jun 2026 09:02:07 -0700 (PDT) Received: from localhost.localdomain ([212.135.211.99]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c92bcb9c14asm1924522a12.24.2026.06.25.09.02.04 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 25 Jun 2026 09:02:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782403327; x=1783008127; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PDhXOI1Vjxfmo7Q3X1FJCZ1/5NbFYlpsfWgi5kj/YBk=; b=RelxD403XNqJO1BdahJAWVqHUEsCrmcjiDX1cOFy5aMY6xCqCeK1x31gKI144Wjo7i xpH7rak5fVZMLxRGKRqjqMNbEp35V1gQlav3lWxGxuiLDtvwTo+W/YivYeDjHikH991p vn50hdHtSJUWn7netd8+eDVh6knKygYwmJNZ5I77ETuDLhhfm93Ip1udgFf84GazP0Gr jaMKtJERwbKScI6/c8lF2F3OnONEEB46OKQXE2HVcWvpY2y68u/2dsg5kE50cKs0txhp 02Zk6AfYsQBvHfB/niUDNES8qE4iqzRRbtN7AehyeAOPxF1NuUyRTvzQzSxKjOujVdgK Xbwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782403327; x=1783008127; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PDhXOI1Vjxfmo7Q3X1FJCZ1/5NbFYlpsfWgi5kj/YBk=; b=kwPHx/EflDX+Yh0B3n1Xpv3wtrow3IvmtBMdN2347gGzLKX9DyvaRyXp3fw7cEjdqB 53RCna1P4IUHEP/h/Kr4aQgRngsAZWWeYonSUHhZFIveIf+Rrv4LSuUZC/0eImC+0P9o Hg0zB8+4V8p9AUytZikHqb9yj5/NMZbWG9EVHIe6N0EUD20TCgU+cO1yzIQ2ZejvywoT qnWSdtNhjChDziCFqExQr8fc3iCpQoPT8IjO7EpMJlznNd6x8DqY45pL1vD6JD//nJ4W BLKfyVeJ25mS3yAqmCqcB30Qy+MR/f+eqOHVO6GtsH9OBdrdtlV37DFVFJV+pfs/Mjx4 Lxmw== X-Gm-Message-State: AOJu0Yyv3STygw3IAwJpgz276pSMbtZavgXVjE0l5z9i7K12dMNDVGS3 x8TcipmtCKHu62FSFc/KZMbIvHNxnUxUJkvwRgXnq5cb1yA+BY5Vb+ntw6j1hnxaOsM= X-Gm-Gg: AfdE7cn+4lxJTZeGcOBMQ5+QJNKvyq53yf3Y/cw/4KJ7/Yz/yImjtk+NeF2RVQVX8zt 2Z4ikFIl9Kh7LxTQkyMsKfAjQ4IXkgSztdw3RP4hiXy/kKYdvjwHoqDInwhFBpYdO16F+jEiaRr 5bYmMfj8NCXoieJHI4Sa7DuajhnbZMu0g/HBQchhynROHa9SttLu4PUxXR+/JJAEU1aofQVdR21 0qrzVVq0Xg/UPypi6c7zn1tA5dnqToXvD9NsRKxzfwIPla0Juqe/eJRzTVB5aem9BHOxxbDyFhG OlTRAejDnLab35ZemrmxfwE+kHWDQ8SKKE0EiL8QvCmaDXMe4+2nyR9iD4sRhvMxDASr1HvFFou JDDr6Z5ElCS13QWzrERdUPRrjweZuZXEBJ7ZTd+PB8gFfcsCf9W2nqLBCs5jXPabmeEupIT4VCM d7RvQ7+YzuvlALdQ3OV/RIrIJ1hww= X-Received: by 2002:a05:6a20:e613:b0:3b4:b276:c5dc with SMTP id adf61e73a8af0-3bd4ac817e3mr3980706637.3.1782403326602; Thu, 25 Jun 2026 09:02:06 -0700 (PDT) From: jack wang <163wangjack@gmail.com> To: qemu-devel@nongnu.org Cc: jack wang <163wangjack@gmail.com>, Peter Maydell , qemu-arm@nongnu.org (open list:i.MX31 (kzm)) Subject: [PATCH v2 1/3] hw/misc/imx_ccm: Replace DPRINTF with trace events Date: Fri, 26 Jun 2026 00:01:42 +0800 Message-ID: <20260625160144.94565-2-163wangjack@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260625160144.94565-1-163wangjack@gmail.com> References: <20260625160144.94565-1-163wangjack@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::530; envelope-from=163wangjack@gmail.com; helo=mail-pg1-x530.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FROM_STARTS_WITH_NUMS=0.738, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1782403373414158500 Content-Type: text/plain; charset="utf-8" Signed-off-by: jack wang <163wangjack@gmail.com> Reviewed-by tags... --- hw/misc/imx_ccm.c | 18 +++--------------- hw/misc/trace-events | 4 ++++ 2 files changed, 7 insertions(+), 15 deletions(-) diff --git a/hw/misc/imx_ccm.c b/hw/misc/imx_ccm.c index 9403c5daa3..b77e9561bb 100644 --- a/hw/misc/imx_ccm.c +++ b/hw/misc/imx_ccm.c @@ -14,18 +14,7 @@ #include "qemu/osdep.h" #include "hw/misc/imx_ccm.h" #include "qemu/module.h" - -#ifndef DEBUG_IMX_CCM -#define DEBUG_IMX_CCM 0 -#endif - -#define DPRINTF(fmt, args...) \ - do { \ - if (DEBUG_IMX_CCM) { \ - fprintf(stderr, "[%s]%s: " fmt , TYPE_IMX_CCM, \ - __func__, ##args); \ - } \ - } while (0) +#include "hw/misc/trace.h" =20 =20 uint32_t imx_ccm_get_clock_frequency(IMXCCMState *dev, IMXClk clock) @@ -37,7 +26,7 @@ uint32_t imx_ccm_get_clock_frequency(IMXCCMState *dev, IM= XClk clock) freq =3D klass->get_clock_frequency(dev, clock); } =20 - DPRINTF("(clock =3D %d) =3D %u\n", clock, freq); + trace_imx_ccm_get_clock_frequency(clock, freq); =20 return freq; } @@ -64,8 +53,7 @@ uint32_t imx_ccm_calc_pll(uint32_t pllreg, uint32_t base_= freq) freq =3D ((2 * (base_freq >> 10) * (mfi * mfd + mfn)) / (mfd * pd)) << 10; =20 - DPRINTF("(pllreg =3D 0x%08x, base_freq =3D %u) =3D %d\n", pllreg, base= _freq, - freq); + trace_imx_ccm_calc_pll(pllreg, base_freq, freq); =20 return freq; } diff --git a/hw/misc/trace-events b/hw/misc/trace-events index b88accc437..fdb4844045 100644 --- a/hw/misc/trace-events +++ b/hw/misc/trace-events @@ -237,6 +237,10 @@ iotkit_secctl_s_write(uint32_t offset, uint64_t data, = unsigned size) "IoTKit Sec iotkit_secctl_ns_read(uint32_t offset, uint64_t data, unsigned size) "IoTK= it SecCtl NS regs read: offset 0x%x data 0x%" PRIx64 " size %u" iotkit_secctl_ns_write(uint32_t offset, uint64_t data, unsigned size) "IoT= Kit SecCtl NS regs write: offset 0x%x data 0x%" PRIx64 " size %u" =20 +# imx_ccm.c +imx_ccm_get_clock_frequency(uint32_t clock, uint32_t freq) "(clock =3D %u)= =3D %u" +imx_ccm_calc_pll(uint32_t pllreq, uint32_t base_freq, uint32_t freq) "(pll= reg =3D 0x%08x, base_freq =3D %u) =3D %u" + # imx6_ccm.c imx6_analog_get_periph_clk(uint32_t freq) "freq =3D %u Hz" imx6_analog_get_pll2_clk(uint32_t freq) "freq =3D %u Hz" --=20 2.53.0 From nobody Sun Jul 26 11:54:36 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1782403370; cv=none; d=zohomail.com; s=zohoarc; b=ecyBp3k2sVtCFhbbS0nyhxl8gOeFHM4tAaTvxjb0UfiqYNPxcGigxwmZpiQpkoj6wGY1y1BeLGHfsoi/vKLnfVGFFdog+Cv0fqvx/PN1C4+VQ4xSv6iYBT4anSVQWaCmP2/DYF7saPtOIuiZ8lp++GpUZ21E1RhT6Up+b2H9NeQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782403370; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=MYqeGOOKD55RKQc/1pd1ELcCZGaTrj86Fmjnba5w4Eo=; b=eLqysXDT3Dui8xg5cRc6xMLHFwZE2oj+W0RIUlYWsdy6zuSg19vc/N8uyqZrcvsLKWYorgC2jAlYDU6DuOYU7WNXtI9whC2MoerlCy4yZhsQP9BiYoUrfm0nXIX9r8Urf0viNz7E/Cu6TLAMvcRmUe/4AJ5vvfQCltoLbfrKntU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from=<163wangjack@gmail.com> (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782403370280696.0510117717417; Thu, 25 Jun 2026 09:02:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wcmWu-0007Xu-6N; Thu, 25 Jun 2026 12:02:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <163wangjack@gmail.com>) id 1wcmWs-0007T3-5H for qemu-devel@nongnu.org; Thu, 25 Jun 2026 12:02:14 -0400 Received: from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <163wangjack@gmail.com>) id 1wcmWq-0006Yr-2s for qemu-devel@nongnu.org; Thu, 25 Jun 2026 12:02:13 -0400 Received: by mail-pg1-x52c.google.com with SMTP id 41be03b00d2f7-c88e3e82d81so12951a12.2 for ; Thu, 25 Jun 2026 09:02:11 -0700 (PDT) Received: from localhost.localdomain ([212.135.211.99]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c92bcb9c14asm1924522a12.24.2026.06.25.09.02.07 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 25 Jun 2026 09:02:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782403331; x=1783008131; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MYqeGOOKD55RKQc/1pd1ELcCZGaTrj86Fmjnba5w4Eo=; b=nf7zWj4AHH9VVnewtzO0LnSnFD5wunpOqolNw6JQwlaujJ3WpT3XsT72sgTLfZlciR hY/t3DZWKg5BbDVE+7j+Ej61ArM9PC22qnUm2D0vt3VPt93Up5kSiEjn1PVqqZeGHO86 yzD9Z+jUqfhm90Xmw0DvFqD3inDCmpW9+tOiAqV3zb9wA9pO7EzPG18Jk5eKJhuKdbzK t+GN7/7wHW9c4zeYquwjTnY0oJWHfcrc714fdHTPNm3KUccGpPneHOsjHskpoub3OSqA Akl30QQaCdzK6z+Gz1d1eyb9XYLffgNglqyo0ku+La1ELcBuPnR1iDvQmDTW0hg/28BH 0QGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782403331; x=1783008131; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MYqeGOOKD55RKQc/1pd1ELcCZGaTrj86Fmjnba5w4Eo=; b=Fg3DXiciS5hCJ9hajalncey/Kvy176GWSTKTg/HcjeIBpZA48ihHmTlgHmP4h+Pz82 NxICCmNTbeXgiqm4V56gyIKX0hXWH/li5udfEtWXuIRVl/NDjX4XEFCVA2/N2kqKkoxQ q5nL1KTEBtJaFMhfymcCaIJJp2DylX8/JeMVBC3z56IhJ/AKcdpt7l7sRV5yH1HGmHB3 tar/xRGRCOXP/uIQXMQE7OFRcxWl7Bxq3gW/BimoiExBAaUjxhlbn2Xj8uezRngUdQv9 AnMtmD2YfPsfMM7dX76QMy43heghYUnUK68GIQgwE91HiUlv/Lj/zskUDGCGzvQX8cbd L90w== X-Gm-Message-State: AOJu0YwoCz4BTV6CU8QAQDzbx3NC0ZNt7OPBdDAoMXAd64y4VQg9gJMC uzqev5+fFSf5ZgqbfZmda3XB2DaSBqpqW+Br8AB9+rXIOfi3ht0fsbaoCU6WM+HCTWs= X-Gm-Gg: AfdE7cn0xuvxpMG1/OCyLu+VwEB9dnd0XQi2RHoPiP1ZzpeoOtOQ5IRwyxyxNEH4WmF Lpb3BwdiId5uB5uznh/mhMuqj9gcFIDptn1vgYNjtGqq61TouBAubhpCezhz5j60+51sbfo2hLO 54ChspUhouTOD/0BpgWltIAkq8cZ7IAGeZAUgyJNbjHvG3VsW09x5AmRWPyhf9RICfOEFhGn6EO 8t58gWmOm4TVDljRH+KE7OWrTqlg10posJVSLLwHkVxvAayERvINhARTPd0J/vIK9aL9wruU/do QtbP+gVz2P6aNzwXo0AM/oS+qoDhCLSsLbOhogZ9Bn4UpQ/YuPVPNb/Mk07I1nFecmEoW6a9nkG LKyzxCj/5HwDC+R9/sIiDgCUU254rEPHr2IQi+ALLtZXSB5LyL1mmzkXRA134mzEz+DpdT+a0u0 8ZZMX22sMThXcYjGFEHLTKlA0bSxI= X-Received: by 2002:a05:6a20:734c:b0:3b4:65ac:e2e6 with SMTP id adf61e73a8af0-3bd4b239a52mr3736512637.36.1782403330185; Thu, 25 Jun 2026 09:02:10 -0700 (PDT) From: jack wang <163wangjack@gmail.com> To: qemu-devel@nongnu.org Cc: jack wang <163wangjack@gmail.com>, Peter Maydell , Jean-Christophe Dubois , qemu-arm@nongnu.org (open list:i.MX25 PDK) Subject: [PATCH v2 2/3] hw/misc/imx25_ccm: Replace DPRINTF with trace events Date: Fri, 26 Jun 2026 00:01:43 +0800 Message-ID: <20260625160144.94565-3-163wangjack@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260625160144.94565-1-163wangjack@gmail.com> References: <20260625160144.94565-1-163wangjack@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::52c; envelope-from=163wangjack@gmail.com; helo=mail-pg1-x52c.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FROM_STARTS_WITH_NUMS=0.738, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1782403372007158500 Content-Type: text/plain; charset="utf-8" Signed-off-by: jack wang <163wangjack@gmail.com> Reviewed-by tags... --- hw/misc/imx25_ccm.c | 34 ++++++++++------------------------ hw/misc/trace-events | 9 +++++++++ 2 files changed, 19 insertions(+), 24 deletions(-) diff --git a/hw/misc/imx25_ccm.c b/hw/misc/imx25_ccm.c index a6665d5535..d051e8a2d1 100644 --- a/hw/misc/imx25_ccm.c +++ b/hw/misc/imx25_ccm.c @@ -16,18 +16,8 @@ #include "migration/vmstate.h" #include "qemu/log.h" #include "qemu/module.h" +#include "hw/misc/trace.h" =20 -#ifndef DEBUG_IMX25_CCM -#define DEBUG_IMX25_CCM 0 -#endif - -#define DPRINTF(fmt, args...) \ - do { \ - if (DEBUG_IMX25_CCM) { \ - fprintf(stderr, "[%s]%s: " fmt , TYPE_IMX25_CCM, \ - __func__, ##args); \ - } \ - } while (0) =20 static const char *imx25_ccm_reg_name(uint32_t reg) { @@ -118,12 +108,12 @@ static uint32_t imx25_ccm_get_mpll_clk(IMXCCMState *d= ev) freq =3D imx_ccm_calc_pll(s->reg[IMX25_CCM_MPCTL_REG], CKIH_FREQ); } =20 - DPRINTF("freq =3D %u\n", freq); + trace_imx25_ccm_get_mpll_clk(freq); =20 return freq; } =20 -static uint32_t imx25_ccm_get_mcu_clk(IMXCCMState *dev) +static uint32_t imx25_ccm_get_mcu_clk(IMX25CCMState *dev) { uint32_t freq; IMX25CCMState *s =3D IMX25_CCM(dev); @@ -136,7 +126,7 @@ static uint32_t imx25_ccm_get_mcu_clk(IMXCCMState *dev) =20 freq =3D freq / (1 + EXTRACT(s->reg[IMX25_CCM_CCTL_REG], ARM_CLK_DIV)); =20 - DPRINTF("freq =3D %u\n", freq); + trace_imx25_ccm_get_mcu_clk(freq); =20 return freq; } @@ -149,7 +139,7 @@ static uint32_t imx25_ccm_get_ahb_clk(IMXCCMState *dev) freq =3D imx25_ccm_get_mcu_clk(dev) / (1 + EXTRACT(s->reg[IMX25_CCM_CCTL_REG], AHB_CLK_DIV)); =20 - DPRINTF("freq =3D %u\n", freq); + trace_imx25_ccm_get_ahb_clk(freq); =20 return freq; } @@ -160,7 +150,7 @@ static uint32_t imx25_ccm_get_ipg_clk(IMXCCMState *dev) =20 freq =3D imx25_ccm_get_ahb_clk(dev) / 2; =20 - DPRINTF("freq =3D %u\n", freq); + trace_imx25_ccm_get_ipg_clk(freq); =20 return freq; } @@ -168,7 +158,7 @@ static uint32_t imx25_ccm_get_ipg_clk(IMXCCMState *dev) static uint32_t imx25_ccm_get_clock_frequency(IMXCCMState *dev, IMXClk clo= ck) { uint32_t freq =3D 0; - DPRINTF("Clock =3D %d)\n", clock); + trace_imx25_ccm_get_clock_frequency(clock, freq); =20 switch (clock) { case CLK_NONE: @@ -186,7 +176,7 @@ static uint32_t imx25_ccm_get_clock_frequency(IMXCCMSta= te *dev, IMXClk clock) break; } =20 - DPRINTF("Clock =3D %d) =3D %u\n", clock, freq); + trace_imx25_ccm_get_clock_frequency(clock, freq); =20 return freq; } @@ -195,8 +185,6 @@ static void imx25_ccm_reset(DeviceState *dev) { IMX25CCMState *s =3D IMX25_CCM(dev); =20 - DPRINTF("\n"); - memset(s->reg, 0, IMX25_CCM_MAX_REG * sizeof(uint32_t)); s->reg[IMX25_CCM_MPCTL_REG] =3D 0x800b2c01; s->reg[IMX25_CCM_UPCTL_REG] =3D 0x84042800; @@ -238,8 +226,7 @@ static uint64_t imx25_ccm_read(void *opaque, hwaddr off= set, unsigned size) HWADDR_PRIx "\n", TYPE_IMX25_CCM, __func__, offset); } =20 - DPRINTF("reg[%s] =3D> 0x%" PRIx32 "\n", imx25_ccm_reg_name(offset >> 2= ), - value); + trace_imx25_ccm_read(imx25_ccm_reg_name(offset >> 2), value); =20 return value; } @@ -249,8 +236,7 @@ static void imx25_ccm_write(void *opaque, hwaddr offset= , uint64_t value, { IMX25CCMState *s =3D (IMX25CCMState *)opaque; =20 - DPRINTF("reg[%s] <=3D 0x%" PRIx32 "\n", imx25_ccm_reg_name(offset >> 2= ), - (uint32_t)value); + trace_imx25_ccm_write(imx25_ccm_reg_name(offset >> 2), value); =20 if (offset < 0x70) { /* diff --git a/hw/misc/trace-events b/hw/misc/trace-events index fdb4844045..ebe9b4fb22 100644 --- a/hw/misc/trace-events +++ b/hw/misc/trace-events @@ -273,6 +273,15 @@ imx6_src_reset(void) "" imx7_src_read(const char *reg_name, uint32_t value) "reg[%s] =3D> 0x%" PRI= x32 imx7_src_write(const char *reg_name, uint32_t value) "reg[%s] <=3D 0x%" PR= Ix32 =20 +# imx25_ccm.c +imx25_ccm_get_mpll_clk(uint32_t freq) "freq =3D %u" +imx25_ccm_get_mcu_clk(uint32_t freq) "freq =3D %u" +imx25_ccm_get_ahb_clk(uint32_t freq) "freq =3D %u" +imx25_ccm_get_ipg_clk(uint32_t freq) "freq =3D %u" +imx25_ccm_get_clock_frequency(unsigned clock, uint32_t freq) "(clock =3D %= d) =3D %u" +imx25_ccm_read(const char *reg, uint32_t value) "reg[%s] =3D> 0x%" PRIx32 +imx25_ccm_write(const char *reg, uint32_t value) "reg[%s] <=3D 0x%" PRIx32 + # iotkit-sysinfo.c iotkit_sysinfo_read(uint64_t offset, uint64_t data, unsigned size) "IoTKit= SysInfo read: offset 0x%" PRIx64 " data 0x%" PRIx64 " size %u" iotkit_sysinfo_write(uint64_t offset, uint64_t data, unsigned size) "IoTKi= t SysInfo write: offset 0x%" PRIx64 " data 0x%" PRIx64 " size %u" --=20 2.53.0 From nobody Sun Jul 26 11:54:36 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1782403370; cv=none; d=zohomail.com; s=zohoarc; b=OFyo/Wix563VQt6UN3dMIeS3tr8LNq5JSDw/x2/9RWGYqElA+uW1InNzFZ4srEE9xrd71Yb4DY+hHOhZW02i4uFcG3fAapuWIi8MtT8AZf7YPhAeD8+l2zg7lX4JRbd2I6uz2++dVhERHH11oyePaVvFrgJs+DCEEo9tJ+gwP78= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782403370; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=GqaVVqTmkp/8EUEqbNbsHQkfMzS6zhGuIkW9Rs9oFcs=; b=jy24fbpP9/seBfjBk7uRixoSCLZBQZeVnZ1ZX/15XbPFBB1j7cmUrLieob5iFJnOUSoD+Y1Uh3yvEIDt1BnWsJs9ZK+xvUjlSYtaYt03p1SpWMbGzwjZ99bZ64ixvXQJaeEAg0Lo4QJcL+q1Lx8hAw99RvsZ1HK/a8zGrICwQss= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from=<163wangjack@gmail.com> (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782403370438264.5487779525089; Thu, 25 Jun 2026 09:02:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wcmWw-0007dB-CM; Thu, 25 Jun 2026 12:02:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <163wangjack@gmail.com>) id 1wcmWu-0007aT-Px for qemu-devel@nongnu.org; Thu, 25 Jun 2026 12:02:16 -0400 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <163wangjack@gmail.com>) id 1wcmWs-0006Z7-SZ for qemu-devel@nongnu.org; Thu, 25 Jun 2026 12:02:16 -0400 Received: by mail-pg1-x536.google.com with SMTP id 41be03b00d2f7-c86307c4e6bso24096a12.0 for ; Thu, 25 Jun 2026 09:02:14 -0700 (PDT) Received: from localhost.localdomain ([212.135.211.99]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c92bcb9c14asm1924522a12.24.2026.06.25.09.02.10 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 25 Jun 2026 09:02:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782403333; x=1783008133; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GqaVVqTmkp/8EUEqbNbsHQkfMzS6zhGuIkW9Rs9oFcs=; b=l1obKsaHgwqq0qYsLqVj/GFP08/xTSTRNVE98ov+VujXRmUB52s3xjhICfT+iNnsDs LFvDj76zRF2z/R3JNJtVO4HHnqImlpvWGNHWTlpILk/uc1cv0AK6pGM5ePiiswk/+i/6 HX8WBJAw52n6MG+8ObPXjhgJTmbnTG1SkbkiD5qMwt8M9f4tmuhldXbauc/fh4mX2vV0 WIxYUEswDvJfx0iTKxWbGn82oWnwYEgYgJl+eBFHswt+JiZ6lveQakHJK2I8iyEp78X+ C5WiKk4XJGNZ2HAwFk8mZ3CsS35AIB22Ir450gJV1ucDp7aL+o4IT68tND4SP5M6s7Fz SvbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782403333; x=1783008133; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=GqaVVqTmkp/8EUEqbNbsHQkfMzS6zhGuIkW9Rs9oFcs=; b=j2iMguL/z+8RveuSZ6wI36mOd3625VmMh7aAdHK9PmOMVt+b+wiesZhuNV0zVER8lJ l5GrJ6H2bp8IeH8P/jIPD+kL/cM+kmvgKpOIdsMFzdwmb3S3Sjj6ZJ8mRboPmH5uyH8u mlE93gQuqkh4vXqpBI2F6FDdcMqHCBgPgV9ODbeEbdzR/8+TVwgGKnaPeF4zV1+49/gu o8svtn7/uym2xZUzktWAwLyKh+SMmBDWz0ZDNrlrM1rv0yXvdQNoYqS1R0zffQhAF/tt bJnMwUP59z7npraBS7RGhteqS2kMe2V/cyyYnZfEMYzoW+Esg8FDoghB8ulnQuxdcLMH kZRQ== X-Gm-Message-State: AOJu0Yx7XYiKRq0AbfWuct7BHPs8rtZAIgbIrFhPKXHCXntE1/g/OzSY 8y1ZeQPyPM+yUAr3mQ2pL38zOrbtNi4jkhYafHUU0G3EZRdx7m1JJjI0Z562ikqtzVA= X-Gm-Gg: AfdE7cmoo9KlyxvM31pGFQ3F1bA3fKuJFUlnovrlIDWlWMVK32HRu4TG2mWT+BFJ+b4 +wuoyalNg0hORQCk5W92Y9JRqgr4NMzhKtNyiN3T4yfeOUyw9f2WgOb/7bUdvV7XvkOxAt0cLe4 mV4GpRyjbkvhnkSBuNpA8xn70v0GOtOyoBE0lFNTorHwHyd+6O1pTrXN8l6uRL/Jt+A7WUEQkyj DEgMpAccWm/n1BzR/bG2NjfoR+7dsrjEycIQhdnHNOoDP5ibzm5SO8dC92MtLEUtkUvaC55/pQx nVi6N/qFthkQhoXpCF+gMXcNcsohw9EXNOgWH9zIgYcXh9JkXGXBe2fHE3tZrdNU6ZFwPgWJs69 K29Iik4AEMHh0UBjFrawiuK0IiqN/4E4xLvRehT8IE7TlZCen6k0WcV6GCglJyA0WQfotMY1Gld mq6k/w/mEew4tq+WCrgQkB/Wuu3A4= X-Received: by 2002:a05:6a20:2324:b0:3b4:8f2c:6805 with SMTP id adf61e73a8af0-3bd4b01a2admr3745697637.42.1782403333122; Thu, 25 Jun 2026 09:02:13 -0700 (PDT) From: jack wang <163wangjack@gmail.com> To: qemu-devel@nongnu.org Cc: jack wang <163wangjack@gmail.com>, Peter Maydell , Jean-Christophe Dubois , qemu-arm@nongnu.org (open list:i.MX25 PDK) Subject: [PATCH v2 3/3] hw/misc/imx31_ccm: Replace DPRINTF with trace events Date: Fri, 26 Jun 2026 00:01:44 +0800 Message-ID: <20260625160144.94565-4-163wangjack@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260625160144.94565-1-163wangjack@gmail.com> References: <20260625160144.94565-1-163wangjack@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::536; envelope-from=163wangjack@gmail.com; helo=mail-pg1-x536.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FROM_STARTS_WITH_NUMS=0.738, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1782403372001158500 Content-Type: text/plain; charset="utf-8" Signed-off-by: jack wang <163wangjack@gmail.com> Reviewed-by tags... --- hw/misc/imx25_ccm.c | 2 +- hw/misc/imx31_ccm.c | 33 ++++++++++----------------------- hw/misc/trace-events | 10 ++++++++++ 3 files changed, 21 insertions(+), 24 deletions(-) diff --git a/hw/misc/imx25_ccm.c b/hw/misc/imx25_ccm.c index d051e8a2d1..4ca4cb6672 100644 --- a/hw/misc/imx25_ccm.c +++ b/hw/misc/imx25_ccm.c @@ -102,7 +102,7 @@ static uint32_t imx25_ccm_get_mpll_clk(IMXCCMState *dev) uint32_t freq; IMX25CCMState *s =3D IMX25_CCM(dev); =20 - if (EXTRACT(s->reg[IMX25_CCM_CCTL_REG], MPLL_BYPASS)) { + if (EXTRACT(s->reg[IMX25_CCM_CCTL_REG], MPLL_BYPASS))=20 freq =3D CKIH_FREQ; } else { freq =3D imx_ccm_calc_pll(s->reg[IMX25_CCM_MPCTL_REG], CKIH_FREQ); diff --git a/hw/misc/imx31_ccm.c b/hw/misc/imx31_ccm.c index 339458e859..e3edd6df8f 100644 --- a/hw/misc/imx31_ccm.c +++ b/hw/misc/imx31_ccm.c @@ -16,21 +16,10 @@ #include "migration/vmstate.h" #include "qemu/log.h" #include "qemu/module.h" +#include "hw/misc/trace.h" =20 #define CKIH_FREQ 26000000 /* 26MHz crystal input */ =20 -#ifndef DEBUG_IMX31_CCM -#define DEBUG_IMX31_CCM 0 -#endif - -#define DPRINTF(fmt, args...) \ - do { \ - if (DEBUG_IMX31_CCM) { \ - fprintf(stderr, "[%s]%s: " fmt , TYPE_IMX31_CCM, \ - __func__, ##args); \ - } \ - } while (0) - static const char *imx31_ccm_reg_name(uint32_t reg) { static char unknown[20]; @@ -120,7 +109,7 @@ static uint32_t imx31_ccm_get_pll_ref_clk(IMXCCMState *= dev) freq =3D CKIH_FREQ; } =20 - DPRINTF("freq =3D %u\n", freq); + trace_imx31_ccm_get_pll_ref_clk(freq); =20 return freq; } @@ -133,7 +122,7 @@ static uint32_t imx31_ccm_get_mpll_clk(IMXCCMState *dev) freq =3D imx_ccm_calc_pll(s->reg[IMX31_CCM_MPCTL_REG], imx31_ccm_get_pll_ref_clk(dev)); =20 - DPRINTF("freq =3D %u\n", freq); + trace_imx31_ccm_get_mpll_clk(freq); =20 return freq; } @@ -150,7 +139,7 @@ static uint32_t imx31_ccm_get_mcu_main_clk(IMXCCMState = *dev) freq =3D imx31_ccm_get_mpll_clk(dev); } =20 - DPRINTF("freq =3D %u\n", freq); + trace_imx31_ccm_get_mcu_main_clk(freq); =20 return freq; } @@ -163,7 +152,7 @@ static uint32_t imx31_ccm_get_hclk_clk(IMXCCMState *dev) freq =3D imx31_ccm_get_mcu_main_clk(dev) / (1 + EXTRACT(s->reg[IMX31_CCM_PDR0_REG], MAX)); =20 - DPRINTF("freq =3D %u\n", freq); + trace_imx31_ccm_get_hclk_clk(freq); =20 return freq; } @@ -176,7 +165,7 @@ static uint32_t imx31_ccm_get_ipg_clk(IMXCCMState *dev) freq =3D imx31_ccm_get_hclk_clk(dev) / (1 + EXTRACT(s->reg[IMX31_CCM_PDR0_REG], IPG)); =20 - DPRINTF("freq =3D %u\n", freq); + trace_imx31_ccm_get_ipg_clk(freq); =20 return freq; } @@ -201,7 +190,7 @@ static uint32_t imx31_ccm_get_clock_frequency(IMXCCMSta= te *dev, IMXClk clock) break; } =20 - DPRINTF("Clock =3D %d) =3D %u\n", clock, freq); + trace_imx31_ccm_get_clock_frequency(clock, freq); =20 return freq; } @@ -210,7 +199,7 @@ static void imx31_ccm_reset(DeviceState *dev) { IMX31CCMState *s =3D IMX31_CCM(dev); =20 - DPRINTF("()\n"); + =20 memset(s->reg, 0, sizeof(uint32_t) * IMX31_CCM_MAX_REG); =20 @@ -244,8 +233,7 @@ static uint64_t imx31_ccm_read(void *opaque, hwaddr off= set, unsigned size) HWADDR_PRIx "\n", TYPE_IMX31_CCM, __func__, offset); } =20 - DPRINTF("reg[%s] =3D> 0x%" PRIx32 "\n", imx31_ccm_reg_name(offset >> 2= ), - value); + trace_imx31_ccm_read(imx31_ccm_reg_name(offset >> 2), value); =20 return (uint64_t)value; } @@ -255,8 +243,7 @@ static void imx31_ccm_write(void *opaque, hwaddr offset= , uint64_t value, { IMX31CCMState *s =3D (IMX31CCMState *)opaque; =20 - DPRINTF("reg[%s] <=3D 0x%" PRIx32 "\n", imx31_ccm_reg_name(offset >> 2= ), - (uint32_t)value); + trace_imx31_ccm_write(imx31_ccm_reg_name(offset >> 2), value); =20 switch (offset >> 2) { case IMX31_CCM_CCMR_REG: diff --git a/hw/misc/trace-events b/hw/misc/trace-events index ebe9b4fb22..0c2565ddb8 100644 --- a/hw/misc/trace-events +++ b/hw/misc/trace-events @@ -282,6 +282,16 @@ imx25_ccm_get_clock_frequency(unsigned clock, uint32_t= freq) "(clock =3D %d) =3D %u" imx25_ccm_read(const char *reg, uint32_t value) "reg[%s] =3D> 0x%" PRIx32 imx25_ccm_write(const char *reg, uint32_t value) "reg[%s] <=3D 0x%" PRIx32 =20 +# imx31_ccm.c +imx31_ccm_get_mpll_clk(uint32_t freq) "freq =3D %u" +imx31_ccm_get_pll_ref_clk(uint32_t freq) "freq =3D %u" +imx31_ccm_get_mcu_main_clk(uint32_t freq) "freq =3D %u" +imx31_ccm_get_hclk_clk(uint32_t freq) "freq =3D %u" +imx31_ccm_get_ipg_clk(uint32_t freq) "freq =3D %u" +imx31_ccm_get_clock_frequency(unsigned clock, uint32_t freq) "(clock =3D %= u) =3D %u" +imx31_ccm_read(const char *reg, uint32_t value) "reg[%s] =3D> 0x%" PRIx32 +imx31_ccm_write(const char *reg, uint32_t value) "reg[%s] <=3D 0x%" PRIx32 + # iotkit-sysinfo.c iotkit_sysinfo_read(uint64_t offset, uint64_t data, unsigned size) "IoTKit= SysInfo read: offset 0x%" PRIx64 " data 0x%" PRIx64 " size %u" iotkit_sysinfo_write(uint64_t offset, uint64_t data, unsigned size) "IoTKi= t SysInfo write: offset 0x%" PRIx64 " data 0x%" PRIx64 " size %u" --=20 2.53.0