From nobody Sun Jul 26 11:52:32 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1782297846; cv=none; d=zohomail.com; s=zohoarc; b=iPoSqWfCGxcmKcGRzmF8X3gyYc8Ng8qQ06PChV5X5LFy19UwaMAtPllrAVoYjrZEaRhNxQoBCu1fvNoiRZquiK/ZliRRsI9K9Z0D+NjZN/Oj4NX0Kk69pQXd223wr0kG6yePUrGG6z7OcE+ToSot5SrpSYM8wr5cGjXoKEk3vWc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782297846; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=5tXIF/GV0t/2RnrPbIWP2/VoC8uu7YlKxmnrwl8DK5U=; b=lrB5qXf2eX4NSKcNJ2eV7zJRcFVhuhyPFbkBvMraCnXKKs3H3bi+HeGLUKuBhc/5qByvVcxYdZByzpc2+pM7RtQFXlRh1wFq9IOvDql5CDdVA7M5QqSIggitU50Ol8B+E9S4y3gHIOKaTLMO7wGY6zMywtDvUHBQJzIYeyIcIXQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782297846300434.65003884355906; Wed, 24 Jun 2026 03:44:06 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wcL4t-0002W3-JQ; Wed, 24 Jun 2026 06:43:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wcL4s-0002Vg-4j; Wed, 24 Jun 2026 06:43:30 -0400 Received: from hades.hosts.managarm.org ([195.201.36.94]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wcL4q-0001Ge-NK; Wed, 24 Jun 2026 06:43:29 -0400 Received: from white.localdomain (pd9f9de93.dip0.t-ipconnect.de [217.249.222.147]) by hades.hosts.managarm.org (Postfix) with ESMTPSA id 6782540E3A; Wed, 24 Jun 2026 10:43:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=managarm.org; s=2021; t=1782297804; bh=EKygb7sxhBWYjwFoisqXQzwHZzhtOT1lv8pDE1sIlf0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OU+maVe9KX6FiYlbZlFppygiNYEJu2lPk07K1y+7rgYQm5Ckm7vl40Zr2jtooQyc6 DRSyiOcww68N39f3Wp0qKahIN/NR94GnC9Dq64mDmacN4oHkctuR7cOMvtoPQUoocb r+LWuTEQRPCLZp9XeZxdn1lzdIAbRlKcYldgSi2TjSdIgA2kWd7eDZNCAeixpjfvmc M4wf5h1B+Fnrvy5t2pina4l75H+FjTdGRDjCMVJRN7EVxJx3uqzD/1iXRDsE5SoOMK 8M6N/uPpfAmJOvT2k1IxeF9CM5Q1vu/2t/sC7840sk4GXzIOcM/GWp2+ibqdpUcVy3 3AaOd4w1x/ehQ== To: clement.mathieu--drif@bull.com Cc: jasowang@redhat.com, leo@managarm.org, mst@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, qemu-stable@nongnu.org, qemu-trivial@nongnu.org, richard.henderson@linaro.org, yi.l.liu@intel.com Subject: [PATCH v3] intel_iommu: Correctly set pt bit in extended capability register Date: Wed, 24 Jun 2026 12:39:35 +0200 Message-ID: <20260624103933.1793586-3-leo@managarm.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <0e37033a142f1831c1007825bf497c8c56e80b57.camel@bull.com> References: <0e37033a142f1831c1007825bf497c8c56e80b57.camel@bull.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=195.201.36.94; envelope-from=leo@managarm.org; helo=hades.hosts.managarm.org X-Spam_score_int: 4 X-Spam_score: 0.4 X-Spam_bar: / X-Spam_report: (0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SORTED_RECIPS=2.499, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: no92 From: no92 via qemu development Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1782297849486158500 Content-Type: text/plain; charset="utf-8" With the changes in c7b2e22bd957, the `pt` bit was set in the (wrong) capability register, instead of the (correct) extended capability register. Fixes: c7b2e22bd957 ("hw/i386/x86-iommu: Remove X86IOMMUState::pt_supported= field") Signed-off-by: no92 Reviewed-by: Clement Mathieu--Drif Reviewed-by: Yi Liu --- The only changes to v1 are in the commit message phrasing, as well as adding the Reviewed-by lines. Apologies for the confusion, I'm not that well-versed in the mailing list workflow. hw/i386/intel_iommu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 744cdfd2e6..d1af7a3135 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -4988,7 +4988,7 @@ static void vtd_cap_init(IntelIOMMUState *s) { X86IOMMUState *x86_iommu =3D X86_IOMMU_DEVICE(s); - s->cap =3D VTD_CAP_FRO | VTD_CAP_NFR | VTD_CAP_ND | VTD_ECAP_PT | + s->cap =3D VTD_CAP_FRO | VTD_CAP_NFR | VTD_CAP_ND | VTD_CAP_MAMV | VTD_CAP_PSI | VTD_CAP_SSLPS | VTD_CAP_DRAIN | VTD_CAP_ESRTPS | VTD_CAP_MGAW(s->aw_bits); if (x86_iommu->dma_translation) { @@ -4999,7 +4999,7 @@ static void vtd_cap_init(IntelIOMMUState *s) s->cap |=3D VTD_CAP_SAGAW_48bit; } } - s->ecap =3D VTD_ECAP_QI | VTD_ECAP_IRO; + s->ecap =3D VTD_ECAP_QI | VTD_ECAP_IRO | VTD_ECAP_PT; if (x86_iommu_ir_supported(x86_iommu)) { s->ecap |=3D VTD_ECAP_IR | VTD_ECAP_MHMV; -- 2.54.0