From nobody Sun Jul 26 12:38:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1782234337; cv=none; d=zohomail.com; s=zohoarc; b=J2zOpzxMzlrbFmA/tQaRC6lEXpQ4qKlcvgnibtp81vZV+htJqoAWVRd/CTBUcJiCbaI4WEs8EcjUQ+43gZxJiqWR+LJBOK9pa2E1I2ddlWyYy1RI4xV+eAtVL/ZJjGBS5MoTpmDT7Vw+d68oIP6Hh7JiU5l4PU9W4G4X5fYs+eA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782234337; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=IlzIbVxcAOU5tPVL2zqrsVyT/51HE3VKobCPOsDkikU=; b=nW7b46ETFIhb6rH6bufw8SSEZ1iJhDQkhNlxhKHgzyZmYQcDL1pihYnL7JDymee0EU+4Nhnq016WFS+TqbFhC4Q2fPAZ1qiyenH6atNclNeQm9UPgLOD+a9xA90pMd3gt9v/wW+EkuOd1zCsraH9mAlY+/YueDrYrUkOsPOgZmY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from=<163wangjack@gmail.com> (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782234337087407.9353583074608; Tue, 23 Jun 2026 10:05:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wc4Y4-0002Dz-SZ; Tue, 23 Jun 2026 13:04:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <163wangjack@gmail.com>) id 1wc4Y0-0002AU-FE for qemu-devel@nongnu.org; Tue, 23 Jun 2026 13:04:30 -0400 Received: from mail-pj1-x102e.google.com ([2607:f8b0:4864:20::102e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <163wangjack@gmail.com>) id 1wc4Xy-0003KD-UW for qemu-devel@nongnu.org; Tue, 23 Jun 2026 13:04:28 -0400 Received: by mail-pj1-x102e.google.com with SMTP id 98e67ed59e1d1-37d826e9811so118981a91.1 for ; Tue, 23 Jun 2026 10:04:26 -0700 (PDT) Received: from localhost.localdomain ([212.135.211.99]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37d4f225870sm10242924a91.8.2026.06.23.10.04.21 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 23 Jun 2026 10:04:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782234265; x=1782839065; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IlzIbVxcAOU5tPVL2zqrsVyT/51HE3VKobCPOsDkikU=; b=dRRI3ttVcPLEDAChBUC+S2bvL0TzGnda35V321hl9j20pjeMeVC4+hgEAKse8C1EUN InzaXoutrOeNYarf3+mdmLiwWisfatQuC8mQ0nqwsrbLNuSj3aJGHyMB+MDBWPtxQkNM P4WuCOp3xo4jub+UVH+uTpMid9ZsZO6R4CkxzejRCULIpBvbUxEOpIJkujCgeCVfLSNM +WAU5V9casYI+K7TiU0NWQknbFSljdZ0mV4WYopLjKPoOdY4VJWrZlpSK6Pum+QLri4G 2sXAZBExkqprjaXy0VcWqEn+5Xo51mRtpvHIyGpb7vHR3WTuDSB990k5j+HYOkF9uVIL aiww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782234265; x=1782839065; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=IlzIbVxcAOU5tPVL2zqrsVyT/51HE3VKobCPOsDkikU=; b=DHN2DTiXTeHwW9h4DB3L/AugtfcpxkcXMCjtdDELPP2WovmkeNzrvwwsnBbfriEA5i esgogtqWjWMGae0mFlOObo40s2v4w7tmBP9wKKTW4o3vt9snERfTpWNA2AAo4ytBE2Ut 0axwJUdudFhFmQ8O/Z7Xz/gSZmzEO/x45ppohlW5UJMjffXKqfh5ofw/bVoduPv1Yjv/ KyUNT+ben/oIcig5YnCLbo2ktGK0KQ+x2jtM5rWkFOwjTRhOEtm6Kmz/QzaPiTCa2Mx1 tcypMbH47uc1RaoVXakbCM66VHOf5rxCwAbVoho+Qa8HCC81SzLsZxTkYUCD9y7GJ3AS Kl+w== X-Gm-Message-State: AOJu0YxrfsRpeKoLMcYHLgVshgsYu4vBVe383WLAjcvHg40/us5PTSzw 3Ss3C5+5xfFcA9YAjRD4hztDG3OJxLpvdgdU6JQHasVm5NRYbDSgo5CWvsL/QQQR X-Gm-Gg: AfdE7cnuagW86OXg1uHdt5CrfTws87uJfVqLc6aNiDQlOuANvRS9wGJCx+7kkSmOeFU 9Z57EB/mUYpZtq6Zp32cUuMut9fduDZ+iFHi9a0wSUnyEAhvcisLfhiXj8TtWAVIFwmzEwjX6MI or0Bqc1PUPiiG7BPwSd/AKJNPxQUBgxFUUZkFUMLI8m/36OVRUBrqcxEtVra068mvijQ6Nspmin Hij/btF+BCRTh2S/vk2KtmSnJrHqt7eVU3K2HidGLtESveBLfAVOp5JYyUY8h/uXmUJGMWGwX2+ VBwrcevgIVN/7/ke9IoBLHQUXNvH+VekZ9tzL1BaplmjknMBy54mOnA56X9ZnNASV/wWBJ9oLSl T3JN0aFNTX2SWUhLCNl6UCxxPjeOE/CuWeEZZPwNgsNHmFHXrhYwwetoicCUKJXRdE8WETaJXct ijwskmwtdjMd5gV+eV9poR2I4MBwM= X-Received: by 2002:a17:90a:d887:b0:367:bc89:546e with SMTP id 98e67ed59e1d1-37dd173bc9dmr3605844a91.12.1782234265373; Tue, 23 Jun 2026 10:04:25 -0700 (PDT) From: jack wang <163wangjack@gmail.com> To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, jack wang <163wangjack@gmail.com>, Peter Maydell , qemu-arm@nongnu.org (open list:i.MX31 (kzm)) Subject: [PATCH 1/3] hw/misc/imx_ccm: Replace DPRINTF with trace events Date: Wed, 24 Jun 2026 01:03:52 +0800 Message-ID: <20260623170354.43981-2-163wangjack@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260623170354.43981-1-163wangjack@gmail.com> References: <20260623170354.43981-1-163wangjack@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::102e; envelope-from=163wangjack@gmail.com; helo=mail-pj1-x102e.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FROM_STARTS_WITH_NUMS=0.738, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1782234338852158500 Content-Type: text/plain; charset="utf-8" Reviewed-by: Peter Maydell --- hw/misc/imx_ccm.c | 18 +++--------------- hw/misc/trace-events | 4 ++++ 2 files changed, 7 insertions(+), 15 deletions(-) diff --git a/hw/misc/imx_ccm.c b/hw/misc/imx_ccm.c index 9403c5daa3..30b8aaab8e 100644 --- a/hw/misc/imx_ccm.c +++ b/hw/misc/imx_ccm.c @@ -14,18 +14,7 @@ #include "qemu/osdep.h" #include "hw/misc/imx_ccm.h" #include "qemu/module.h" - -#ifndef DEBUG_IMX_CCM -#define DEBUG_IMX_CCM 0 -#endif - -#define DPRINTF(fmt, args...) \ - do { \ - if (DEBUG_IMX_CCM) { \ - fprintf(stderr, "[%s]%s: " fmt , TYPE_IMX_CCM, \ - __func__, ##args); \ - } \ - } while (0) +#include "hw/misc/trace.h" =20 =20 uint32_t imx_ccm_get_clock_frequency(IMXCCMState *dev, IMXClk clock) @@ -37,7 +26,7 @@ uint32_t imx_ccm_get_clock_frequency(IMXCCMState *dev, IM= XClk clock) freq =3D klass->get_clock_frequency(dev, clock); } =20 - DPRINTF("(clock =3D %d) =3D %u\n", clock, freq); + trace_imx_ccm_get_clock_frequency(clock,freq); =20 return freq; } @@ -64,8 +53,7 @@ uint32_t imx_ccm_calc_pll(uint32_t pllreg, uint32_t base_= freq) freq =3D ((2 * (base_freq >> 10) * (mfi * mfd + mfn)) / (mfd * pd)) << 10; =20 - DPRINTF("(pllreg =3D 0x%08x, base_freq =3D %u) =3D %d\n", pllreg, base= _freq, - freq); + trace_imx_ccm_calc_pll(pllreg, base_freq, freq); =20 return freq; } diff --git a/hw/misc/trace-events b/hw/misc/trace-events index b88accc437..fdb4844045 100644 --- a/hw/misc/trace-events +++ b/hw/misc/trace-events @@ -237,6 +237,10 @@ iotkit_secctl_s_write(uint32_t offset, uint64_t data, = unsigned size) "IoTKit Sec iotkit_secctl_ns_read(uint32_t offset, uint64_t data, unsigned size) "IoTK= it SecCtl NS regs read: offset 0x%x data 0x%" PRIx64 " size %u" iotkit_secctl_ns_write(uint32_t offset, uint64_t data, unsigned size) "IoT= Kit SecCtl NS regs write: offset 0x%x data 0x%" PRIx64 " size %u" =20 +# imx_ccm.c +imx_ccm_get_clock_frequency(uint32_t clock, uint32_t freq) "(clock =3D %u)= =3D %u" +imx_ccm_calc_pll(uint32_t pllreq, uint32_t base_freq, uint32_t freq) "(pll= reg =3D 0x%08x, base_freq =3D %u) =3D %u" + # imx6_ccm.c imx6_analog_get_periph_clk(uint32_t freq) "freq =3D %u Hz" imx6_analog_get_pll2_clk(uint32_t freq) "freq =3D %u Hz" --=20 2.53.0 From nobody Sun Jul 26 12:38:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1782234344; cv=none; d=zohomail.com; s=zohoarc; b=Q8L7osaBTp7n4MBe3PPr0/3s5Tj/xqLThiiD0oOr/+rLhbf+HPbSxiUN3nDe62/CYWaowxpo86URdRGmCkRXelhcLdFpb3Jr2ltZLmIrJQK1I4P+zbq45cCd6eHzYXZ0p9pp3kLN97rHClAeXQNRMO3z8kE4/XAhohekdsGwWYA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782234344; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=oSaOMXjVoFPTW5HopszMbWR5/OiDDQVduHsnOIO0DKc=; b=QqZT4KgbgBJlKfOiYtdK/p+A163dPnr36677v1TvTO+5XepeT48qTwiZvtnHFPO2H3hya9olrDzMGgl7hhawAMYoB5upPr+E297+xH3T3QQnhYqi4o/8nNYuZILW64re2K9bvKHupDwqcyWQNhLgOR6zbYD4JuV0vd8y4jF9dOQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from=<163wangjack@gmail.com> (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782234344271506.40735736738964; Tue, 23 Jun 2026 10:05:44 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wc4YN-0002My-P9; Tue, 23 Jun 2026 13:04:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <163wangjack@gmail.com>) id 1wc4YB-0002G2-Ol for qemu-devel@nongnu.org; Tue, 23 Jun 2026 13:04:39 -0400 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <163wangjack@gmail.com>) id 1wc4Y9-0003Lf-Ul for qemu-devel@nongnu.org; Tue, 23 Jun 2026 13:04:39 -0400 Received: by mail-pj1-x102d.google.com with SMTP id 98e67ed59e1d1-37c6cd1ac98so173260a91.0 for ; Tue, 23 Jun 2026 10:04:37 -0700 (PDT) Received: from localhost.localdomain ([212.135.211.99]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37d4f225870sm10242924a91.8.2026.06.23.10.04.33 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 23 Jun 2026 10:04:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782234276; x=1782839076; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oSaOMXjVoFPTW5HopszMbWR5/OiDDQVduHsnOIO0DKc=; b=cJZweZRLH2xm+A7vN8IFbqIjkU58oXe2PjNK5M0nCQl87aBuHerO6piKNjPMjAik7w pW05JyCffr1flwm1kQvt6Y/J1k1ooKuz2FaTCDxmfiypbLZIE+FEjITXKndBs1cDrmav TJeckgKBu4MJbVVKrk8usrUFv9+PNEQUxcffaknVUkOuFDnMCSWC+C3UqoSUSwkAd6m1 Nk/l1oBjA6MtXlm8qyj6RAlKOTCZO0DvKeAXUy5uHWomGBHAQqWuPhBnjeguueU/O/VF 8mxYQGSE8/tiL7BVmXs7bcug9AVbKsRLkzbegWOTg3c4AHzzVuSPssiAQAMmf9BWVsU8 qaeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782234276; x=1782839076; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=oSaOMXjVoFPTW5HopszMbWR5/OiDDQVduHsnOIO0DKc=; b=KyVCuSuiNjLZ1QH/2YZXzkd+CCmSptwau4IzGBI2OTVbQ0ELgW+H2cMWoHZPYYczqA Bv4jXueA9A2YxmolPGtyIvr7eE/lLn7K8pTvE6OszoHeb5cXdrK7oxHCmsvlGMyOukg8 g4vHQOVZkeIN/p7ulQfSWzY5Jn5j2Me/QZfTxnizUrCQccqA1tKQcD0h8V8XXhaxMUGZ m2TjEEyHrIAv+MNfkijldLvvVrj4wkyvnQvgwae8dH09Lp86dlLxKgL3BOlz7439vHLi NFuVugyXrVCYd1MquDxisqxhIJlyqsxweJm+9YnZy0ZAZa2yMcGJ5b/gfQCTyFmRaKRc vUJg== X-Gm-Message-State: AOJu0YyB/IoruJYR2sDSy+iPKmxyEVkB1ilQWrEVy5beFf5SP6INVfSG vKykXwD3iF7p0yZFDUeRe6KS9NBB6lD+B+GxBBQin9xWq1cIpQVk84TmpGMjfa2n X-Gm-Gg: AfdE7ckS1DSEJ9CwKxigZwCTbcZ9Q42bOv/FmqLDsf2PDLKghzkkLIRr0cjuJqRk+KB NoL/Cllg/rmTGBGCBFieAfko9mPe/bU7DUHp5DWPODwKKtWEWv7nlFV/63sPmOpCpAoVbdQAjWI FBthegMNzMuNRzDZdMHlUurgvqc3aA8pxxTrQ6g2zBqlKO1Qzpbj8LXvoudLagLLQ7nfp3cLQKU oAwJdBY1E446QcZVdPm7Wae3V+fH1rzG7p+dNetPOirMQSC5q7VcTfVjQvvlx1IGCriKCRieYqY 67lfPl4JRogq0AZGEMLsoHcUtYDEDOiLppPzHVI6M/9YK5lYLMxl143icvnRixjGHrfRnJu4oK+ W1I7k1VxEvP9C/TdXeBqrXt/00HpXWCRJn62A8eB1WgVUG8cx0ga8eY3hYfDe5FsYpDRGv7HRYA SS3wb1njiiM3qWc/6aed714XUX/K6rM8L/6wxsOw== X-Received: by 2002:a17:90b:5405:b0:36b:3ecd:88d2 with SMTP id 98e67ed59e1d1-37dd0d0d8d1mr4442368a91.3.1782234276101; Tue, 23 Jun 2026 10:04:36 -0700 (PDT) From: jack wang <163wangjack@gmail.com> To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, jack wang <163wangjack@gmail.com>, Peter Maydell , Jean-Christophe Dubois , qemu-arm@nongnu.org (open list:i.MX25 PDK) Subject: [PATCH 2/3] hw/misc/imx25_ccm: Replace DPRINTF with trace events Date: Wed, 24 Jun 2026 01:03:53 +0800 Message-ID: <20260623170354.43981-3-163wangjack@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260623170354.43981-1-163wangjack@gmail.com> References: <20260623170354.43981-1-163wangjack@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::102d; envelope-from=163wangjack@gmail.com; helo=mail-pj1-x102d.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FROM_STARTS_WITH_NUMS=0.738, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1782234347002158500 Content-Type: text/plain; charset="utf-8" Reviewed-by: Peter Maydell --- hw/misc/imx25_ccm.c | 34 ++++++++++------------------------ hw/misc/trace-events | 9 +++++++++ 2 files changed, 19 insertions(+), 24 deletions(-) diff --git a/hw/misc/imx25_ccm.c b/hw/misc/imx25_ccm.c index a6665d5535..1ee652a117 100644 --- a/hw/misc/imx25_ccm.c +++ b/hw/misc/imx25_ccm.c @@ -16,18 +16,8 @@ #include "migration/vmstate.h" #include "qemu/log.h" #include "qemu/module.h" +#include "hw/misc/trace.h" =20 -#ifndef DEBUG_IMX25_CCM -#define DEBUG_IMX25_CCM 0 -#endif - -#define DPRINTF(fmt, args...) \ - do { \ - if (DEBUG_IMX25_CCM) { \ - fprintf(stderr, "[%s]%s: " fmt , TYPE_IMX25_CCM, \ - __func__, ##args); \ - } \ - } while (0) =20 static const char *imx25_ccm_reg_name(uint32_t reg) { @@ -118,12 +108,12 @@ static uint32_t imx25_ccm_get_mpll_clk(IMXCCMState *d= ev) freq =3D imx_ccm_calc_pll(s->reg[IMX25_CCM_MPCTL_REG], CKIH_FREQ); } =20 - DPRINTF("freq =3D %u\n", freq); + trace_imx25_ccm_get_mpll_clk(freq); =20 return freq; } =20 -static uint32_t imx25_ccm_get_mcu_clk(IMXCCMState *dev) +static uint32_t imx25_ccm_get_mcu_clk(IMX25CCMState *dev) { uint32_t freq; IMX25CCMState *s =3D IMX25_CCM(dev); @@ -136,7 +126,7 @@ static uint32_t imx25_ccm_get_mcu_clk(IMXCCMState *dev) =20 freq =3D freq / (1 + EXTRACT(s->reg[IMX25_CCM_CCTL_REG], ARM_CLK_DIV)); =20 - DPRINTF("freq =3D %u\n", freq); + trace_imx25_ccm_get_mcu_clk(freq); =20 return freq; } @@ -149,7 +139,7 @@ static uint32_t imx25_ccm_get_ahb_clk(IMXCCMState *dev) freq =3D imx25_ccm_get_mcu_clk(dev) / (1 + EXTRACT(s->reg[IMX25_CCM_CCTL_REG], AHB_CLK_DIV)); =20 - DPRINTF("freq =3D %u\n", freq); + trace_imx25_ccm_get_ahb_clk(freq); =20 return freq; } @@ -160,7 +150,7 @@ static uint32_t imx25_ccm_get_ipg_clk(IMXCCMState *dev) =20 freq =3D imx25_ccm_get_ahb_clk(dev) / 2; =20 - DPRINTF("freq =3D %u\n", freq); + trace_imx25_ccm_get_ipg_clk(freq); =20 return freq; } @@ -168,7 +158,7 @@ static uint32_t imx25_ccm_get_ipg_clk(IMXCCMState *dev) static uint32_t imx25_ccm_get_clock_frequency(IMXCCMState *dev, IMXClk clo= ck) { uint32_t freq =3D 0; - DPRINTF("Clock =3D %d)\n", clock); + trace_imx25_ccm_get_clock_frequency(clock, freq); =20 switch (clock) { case CLK_NONE: @@ -186,7 +176,7 @@ static uint32_t imx25_ccm_get_clock_frequency(IMXCCMSta= te *dev, IMXClk clock) break; } =20 - DPRINTF("Clock =3D %d) =3D %u\n", clock, freq); + trace_imx25_ccm_get_clock_frequency(clock, freq); =20 return freq; } @@ -195,8 +185,6 @@ static void imx25_ccm_reset(DeviceState *dev) { IMX25CCMState *s =3D IMX25_CCM(dev); =20 - DPRINTF("\n"); - memset(s->reg, 0, IMX25_CCM_MAX_REG * sizeof(uint32_t)); s->reg[IMX25_CCM_MPCTL_REG] =3D 0x800b2c01; s->reg[IMX25_CCM_UPCTL_REG] =3D 0x84042800; @@ -238,8 +226,7 @@ static uint64_t imx25_ccm_read(void *opaque, hwaddr off= set, unsigned size) HWADDR_PRIx "\n", TYPE_IMX25_CCM, __func__, offset); } =20 - DPRINTF("reg[%s] =3D> 0x%" PRIx32 "\n", imx25_ccm_reg_name(offset >> 2= ), - value); + trace_imx25_ccm_read(imx25_ccm_reg_name(offset >> 2), value); =20 return value; } @@ -249,8 +236,7 @@ static void imx25_ccm_write(void *opaque, hwaddr offset= , uint64_t value, { IMX25CCMState *s =3D (IMX25CCMState *)opaque; =20 - DPRINTF("reg[%s] <=3D 0x%" PRIx32 "\n", imx25_ccm_reg_name(offset >> 2= ), - (uint32_t)value); + trace_imx25_ccm_write(imx25_ccm_reg_name(offset >> 2), (uint32_t)value= ); =20 if (offset < 0x70) { /* diff --git a/hw/misc/trace-events b/hw/misc/trace-events index fdb4844045..ebe9b4fb22 100644 --- a/hw/misc/trace-events +++ b/hw/misc/trace-events @@ -273,6 +273,15 @@ imx6_src_reset(void) "" imx7_src_read(const char *reg_name, uint32_t value) "reg[%s] =3D> 0x%" PRI= x32 imx7_src_write(const char *reg_name, uint32_t value) "reg[%s] <=3D 0x%" PR= Ix32 =20 +# imx25_ccm.c +imx25_ccm_get_mpll_clk(uint32_t freq) "freq =3D %u" +imx25_ccm_get_mcu_clk(uint32_t freq) "freq =3D %u" +imx25_ccm_get_ahb_clk(uint32_t freq) "freq =3D %u" +imx25_ccm_get_ipg_clk(uint32_t freq) "freq =3D %u" +imx25_ccm_get_clock_frequency(unsigned clock, uint32_t freq) "(clock =3D %= d) =3D %u" +imx25_ccm_read(const char *reg, uint32_t value) "reg[%s] =3D> 0x%" PRIx32 +imx25_ccm_write(const char *reg, uint32_t value) "reg[%s] <=3D 0x%" PRIx32 + # iotkit-sysinfo.c iotkit_sysinfo_read(uint64_t offset, uint64_t data, unsigned size) "IoTKit= SysInfo read: offset 0x%" PRIx64 " data 0x%" PRIx64 " size %u" iotkit_sysinfo_write(uint64_t offset, uint64_t data, unsigned size) "IoTKi= t SysInfo write: offset 0x%" PRIx64 " data 0x%" PRIx64 " size %u" --=20 2.53.0 From nobody Sun Jul 26 12:38:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1782234331; cv=none; d=zohomail.com; s=zohoarc; b=AqNl3v0rHuRYboyjXHTzoA+XDUg2dKaDC7zun503HldqIi2beniRCEY+yRmULyXccGkus17kT4aoXX+2+E0p639pKSQuDxxuWKNwMdBsij9oGHZd6Hru0HjLK2QDCRph2evsNnEw1ZF80UgousvGBT1P/FJSu4JC37Lv+K/6osQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782234331; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=frkdTRN5r5z/ocMDErKcvjYJyZm6QlD/OaSOCwTrYFM=; b=V0O6rlgUviLNhXaTnBnAPYvr/oJ67WCpTegJBfBe6RWO/qK+QX/UxzB5+NZP18p6YrtB4UsyGthQB7wMHXt5+7qyj6+EqAHxVm9BxZ2cqsLIaKeAMO5v7R1R9OMjpLRrwkjQdERhiLmVkK2i3aedPFo/0dg+lsbE9crdy4vqw7c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from=<163wangjack@gmail.com> (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782234331100723.0201466351072; Tue, 23 Jun 2026 10:05:31 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wc4YW-0002Y6-1E; Tue, 23 Jun 2026 13:05:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <163wangjack@gmail.com>) id 1wc4YK-0002N6-MF for qemu-devel@nongnu.org; Tue, 23 Jun 2026 13:04:51 -0400 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <163wangjack@gmail.com>) id 1wc4YI-0003QY-Uk for qemu-devel@nongnu.org; Tue, 23 Jun 2026 13:04:48 -0400 Received: by mail-pj1-x1035.google.com with SMTP id 98e67ed59e1d1-36d5fd50d20so125169a91.1 for ; Tue, 23 Jun 2026 10:04:45 -0700 (PDT) Received: from localhost.localdomain ([212.135.211.99]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37d4f225870sm10242924a91.8.2026.06.23.10.04.40 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 23 Jun 2026 10:04:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782234284; x=1782839084; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=frkdTRN5r5z/ocMDErKcvjYJyZm6QlD/OaSOCwTrYFM=; b=cmYPRbo4UDfF33nHaZiCa0+wXyd9DEYBIS/rVufgOTe+4zYPoOqysS14ggWMksbh+a It+5N9QRGiESffc7gYg21k9ez/fpIfe7ohrTxy3qNI/hirJck1MR5gsJs24VRNZPNurM SGC5VgchS1kUzceBDtb6uT+PChmHBSDV34pDRt/b5HmFmQ5HCLUTMKjU/kfWYvtELVVP avL1HBkq2K2EEOSsOB5qfYEVA9aqczC58rXQqAoFMMOGFayqYYrn4yQC4YAoeFz/+SEq Qs9t20TF2r9/ODM4fUueKBUWdgUnu1bEKBpWYtsEDzavBh/Jt+Rrd9ABjwjk3Cz1SHhf eHMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782234284; x=1782839084; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=frkdTRN5r5z/ocMDErKcvjYJyZm6QlD/OaSOCwTrYFM=; b=SGGUnY5Izs3OJZS4usSoOZw/wqIZqyilzbYRWq/3yc090jKQigYaNFYCpPU056mRZl 7FGzHOxXv/A4c6YLE92DKsOMn+XRF/aMC8vzx/QQX/iFtUMwuqZ2zJT5bcOa6ElY/JDk 0TbZGzYlQFI08rfA5sS5vchH+ISSreJBO+2gnezjycuC6Ztdhk2Bd5HxfSuGnuYgyZeu loL5BuIQfoNHWtz7ie9xz61iP/CTLaiB37CREuovAjeCyygr520oLw3Qdby+Rpuc2u6i hWU1VYDWLkjymQYYugy4KYVlAV5cG3vtcFd/XeXNfsWNJ/Q6awMXSHLQMSWxLlZ+yjFW xn3Q== X-Gm-Message-State: AOJu0YysnHDDH7geOTOGrXtPZ3Zrd75ohl0WjpwnoKq9GWsC5ZyFlJLj 3VNU3js6IHtKf1X2onaO5wY1py2I1kend1X7zuRY91ZTgH4JH13o5bRwFLKF3jD3 X-Gm-Gg: AfdE7cnOaAKSv0pK19B6+cvMU/jJowpM3mskONwciuQKvJsE3nzbF68Zso6FHNiNe5a 0jiFgnFoexxbD1SrTX124bvqhGMK23Q8tOsuKcA4hNruLJWPLFWxHYHJyvNEV+RQwoBhWQXH5Zz rwrxm6aRo7ltY97o4SZmAw5wdcUJOmvsl/DlIXJKA4n30cYTw9LnqyiGyNg7H6zyKwVchFfa5el UsDKMy6fsumGpiGqEm1VdJlchFUYopEVKbMGuEOpkDpQByu5qc9tYHISq68PqAf851IsW6RG+cC w1AeemBD2gZs97xdAQhJTNtKnG5ohF08JsE3DATN6aYJkua9a3jRwMfnjYJVqM/fAhghWxejZF2 8nRX6JPBAZD1H2pDs8ZldcwO2gOJFtFIhiivs8EzO/pIBvnZYeUndY8ptsWV4RACCRxydh7OHfI zvHPetROyNxPbKdZzxazYsiRW0l+e7qhWkRakgrg== X-Received: by 2002:a17:90b:584b:b0:37c:18e0:90ed with SMTP id 98e67ed59e1d1-37dd0d0d820mr4056523a91.4.1782234283832; Tue, 23 Jun 2026 10:04:43 -0700 (PDT) From: jack wang <163wangjack@gmail.com> To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, jack wang <163wangjack@gmail.com>, Peter Maydell , qemu-arm@nongnu.org (open list:i.MX31 (kzm)) Subject: [PATCH 3/3] hw/misc/imx31_ccm: Replace DPRINTF with trace events Date: Wed, 24 Jun 2026 01:03:54 +0800 Message-ID: <20260623170354.43981-4-163wangjack@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260623170354.43981-1-163wangjack@gmail.com> References: <20260623170354.43981-1-163wangjack@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1035; envelope-from=163wangjack@gmail.com; helo=mail-pj1-x1035.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, FROM_STARTS_WITH_NUMS=0.738, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1782234333029158500 Content-Type: text/plain; charset="utf-8" Reviewed-by: Peter Maydell --- hw/misc/imx31_ccm.c | 33 ++++++++++----------------------- hw/misc/trace-events | 10 ++++++++++ 2 files changed, 20 insertions(+), 23 deletions(-) diff --git a/hw/misc/imx31_ccm.c b/hw/misc/imx31_ccm.c index 339458e859..e3edd6df8f 100644 --- a/hw/misc/imx31_ccm.c +++ b/hw/misc/imx31_ccm.c @@ -16,21 +16,10 @@ #include "migration/vmstate.h" #include "qemu/log.h" #include "qemu/module.h" +#include "hw/misc/trace.h" =20 #define CKIH_FREQ 26000000 /* 26MHz crystal input */ =20 -#ifndef DEBUG_IMX31_CCM -#define DEBUG_IMX31_CCM 0 -#endif - -#define DPRINTF(fmt, args...) \ - do { \ - if (DEBUG_IMX31_CCM) { \ - fprintf(stderr, "[%s]%s: " fmt , TYPE_IMX31_CCM, \ - __func__, ##args); \ - } \ - } while (0) - static const char *imx31_ccm_reg_name(uint32_t reg) { static char unknown[20]; @@ -120,7 +109,7 @@ static uint32_t imx31_ccm_get_pll_ref_clk(IMXCCMState *= dev) freq =3D CKIH_FREQ; } =20 - DPRINTF("freq =3D %u\n", freq); + trace_imx31_ccm_get_pll_ref_clk(freq); =20 return freq; } @@ -133,7 +122,7 @@ static uint32_t imx31_ccm_get_mpll_clk(IMXCCMState *dev) freq =3D imx_ccm_calc_pll(s->reg[IMX31_CCM_MPCTL_REG], imx31_ccm_get_pll_ref_clk(dev)); =20 - DPRINTF("freq =3D %u\n", freq); + trace_imx31_ccm_get_mpll_clk(freq); =20 return freq; } @@ -150,7 +139,7 @@ static uint32_t imx31_ccm_get_mcu_main_clk(IMXCCMState = *dev) freq =3D imx31_ccm_get_mpll_clk(dev); } =20 - DPRINTF("freq =3D %u\n", freq); + trace_imx31_ccm_get_mcu_main_clk(freq); =20 return freq; } @@ -163,7 +152,7 @@ static uint32_t imx31_ccm_get_hclk_clk(IMXCCMState *dev) freq =3D imx31_ccm_get_mcu_main_clk(dev) / (1 + EXTRACT(s->reg[IMX31_CCM_PDR0_REG], MAX)); =20 - DPRINTF("freq =3D %u\n", freq); + trace_imx31_ccm_get_hclk_clk(freq); =20 return freq; } @@ -176,7 +165,7 @@ static uint32_t imx31_ccm_get_ipg_clk(IMXCCMState *dev) freq =3D imx31_ccm_get_hclk_clk(dev) / (1 + EXTRACT(s->reg[IMX31_CCM_PDR0_REG], IPG)); =20 - DPRINTF("freq =3D %u\n", freq); + trace_imx31_ccm_get_ipg_clk(freq); =20 return freq; } @@ -201,7 +190,7 @@ static uint32_t imx31_ccm_get_clock_frequency(IMXCCMSta= te *dev, IMXClk clock) break; } =20 - DPRINTF("Clock =3D %d) =3D %u\n", clock, freq); + trace_imx31_ccm_get_clock_frequency(clock, freq); =20 return freq; } @@ -210,7 +199,7 @@ static void imx31_ccm_reset(DeviceState *dev) { IMX31CCMState *s =3D IMX31_CCM(dev); =20 - DPRINTF("()\n"); + =20 memset(s->reg, 0, sizeof(uint32_t) * IMX31_CCM_MAX_REG); =20 @@ -244,8 +233,7 @@ static uint64_t imx31_ccm_read(void *opaque, hwaddr off= set, unsigned size) HWADDR_PRIx "\n", TYPE_IMX31_CCM, __func__, offset); } =20 - DPRINTF("reg[%s] =3D> 0x%" PRIx32 "\n", imx31_ccm_reg_name(offset >> 2= ), - value); + trace_imx31_ccm_read(imx31_ccm_reg_name(offset >> 2), value); =20 return (uint64_t)value; } @@ -255,8 +243,7 @@ static void imx31_ccm_write(void *opaque, hwaddr offset= , uint64_t value, { IMX31CCMState *s =3D (IMX31CCMState *)opaque; =20 - DPRINTF("reg[%s] <=3D 0x%" PRIx32 "\n", imx31_ccm_reg_name(offset >> 2= ), - (uint32_t)value); + trace_imx31_ccm_write(imx31_ccm_reg_name(offset >> 2), value); =20 switch (offset >> 2) { case IMX31_CCM_CCMR_REG: diff --git a/hw/misc/trace-events b/hw/misc/trace-events index ebe9b4fb22..0c2565ddb8 100644 --- a/hw/misc/trace-events +++ b/hw/misc/trace-events @@ -282,6 +282,16 @@ imx25_ccm_get_clock_frequency(unsigned clock, uint32_t= freq) "(clock =3D %d) =3D %u" imx25_ccm_read(const char *reg, uint32_t value) "reg[%s] =3D> 0x%" PRIx32 imx25_ccm_write(const char *reg, uint32_t value) "reg[%s] <=3D 0x%" PRIx32 =20 +# imx31_ccm.c +imx31_ccm_get_mpll_clk(uint32_t freq) "freq =3D %u" +imx31_ccm_get_pll_ref_clk(uint32_t freq) "freq =3D %u" +imx31_ccm_get_mcu_main_clk(uint32_t freq) "freq =3D %u" +imx31_ccm_get_hclk_clk(uint32_t freq) "freq =3D %u" +imx31_ccm_get_ipg_clk(uint32_t freq) "freq =3D %u" +imx31_ccm_get_clock_frequency(unsigned clock, uint32_t freq) "(clock =3D %= u) =3D %u" +imx31_ccm_read(const char *reg, uint32_t value) "reg[%s] =3D> 0x%" PRIx32 +imx31_ccm_write(const char *reg, uint32_t value) "reg[%s] <=3D 0x%" PRIx32 + # iotkit-sysinfo.c iotkit_sysinfo_read(uint64_t offset, uint64_t data, unsigned size) "IoTKit= SysInfo read: offset 0x%" PRIx64 " data 0x%" PRIx64 " size %u" iotkit_sysinfo_write(uint64_t offset, uint64_t data, unsigned size) "IoTKi= t SysInfo write: offset 0x%" PRIx64 " data 0x%" PRIx64 " size %u" --=20 2.53.0