From nobody Sun Jul 26 12:38:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1782212619; cv=none; d=zohomail.com; s=zohoarc; b=L0a3rYsga0T6x4Vr4qZ6aOzYhB6MoWpyVWEJrbFwQ6ysgo8LBEb2rrcx1EO/rFW4fK8rFb8gAhFuCv7DNeMHjz24phQ52InNPhyPaYpsHYWG5J4V40JTL1OJDANct76kadWPgmLH5AKvyfJlJX7H3R3FQdiC6Ldi2gy1jwL/aW8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782212619; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=e7ujTj25beCliYcHaN6vgRmeikjh8fOvjTThSDgD3Oo=; b=nHmRTMWJxgyfG7mc5sswbprj6Yg7UGipoDfTPVOXSnWAYgS0P6teYusR9gI+qU78X+RiyG63RvtIWYT21hWIXwrcLlsL+Vxwfm/vuFqwLwVYpNRo54qLjbDdg3Zq818zMXbYcy1ZxhWc+cpbbCt0UXYNhmywN6cT3iZZ6Lgm8wE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782212619546685.4134448241656; Tue, 23 Jun 2026 04:03:39 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wbyu0-0006mm-Tz; Tue, 23 Jun 2026 07:02:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wbyth-0006eP-KW for qemu-devel@nongnu.org; Tue, 23 Jun 2026 07:02:30 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wbyte-00067E-Lx for qemu-devel@nongnu.org; Tue, 23 Jun 2026 07:02:29 -0400 Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65NAsDJ73578601 for ; Tue, 23 Jun 2026 11:02:25 GMT Received: from mail-oi1-f197.google.com (mail-oi1-f197.google.com [209.85.167.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eyppygn4t-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 11:02:25 +0000 (GMT) Received: by mail-oi1-f197.google.com with SMTP id 5614622812f47-48e2ce64834so1787705b6e.3 for ; Tue, 23 Jun 2026 04:02:25 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4923fd1f886sm344100705e9.4.2026.06.23.04.02.21 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 23 Jun 2026 04:02:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= e7ujTj25beCliYcHaN6vgRmeikjh8fOvjTThSDgD3Oo=; b=T6XdZVd3Cle+j51j fEehUceP4dVQ+gWSB/2E5H9I5r0VOWG7Qs1Faa5SZP5Ski0vcY7UekiIbtyjyMPZ 6xYixoI999MRwv2Opldx2AaYtAlwQhNjC3s4clQvwFsAtJdd05pDG1mVlg+kmOD3 9MZL8eqTd5ecc1iVoiChSARgPLsMb3VqBRo/nPQWmQbZ294BOxzEBNUO6FjP7jak yuAn1CwZWRe6AG6bZbiB1cPBpTdNs7KmqCMVhRCIat2oaGeu7IxsfvR9bIDidpP6 L+1R+tqRJ8XGgVvzkkWtIIcVpCfzuDuNuL9iUAazxRdZARbHsrTiH+0jFBKqbhC0 fYCVjg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782212544; x=1782817344; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=e7ujTj25beCliYcHaN6vgRmeikjh8fOvjTThSDgD3Oo=; b=ZtG5Mfn05GDMiv9NgXoq1g+UuscKp6TXnQMpak8NY4ui60578tPp+KoD8fcQsxu9Q0 qx+gmEj6xu/bGwN89+3BZ2sPRbZ02OPScQOlc2rSMc7HjJiHgLiwH0LLxvMGjejU9Msi ckbBbva9yKvfa70Zx9D2bke7MbSJSkEBaYiGcFaj7hmu8gLDbKK1Ki9HpDZPgHFIpTM8 l41IOWuPPXeOWZbh5yV0y0sigHrZMOhjeToD020i64m2yGkPTpSgNpFlL/4F9mcusPW1 rjsT81Cil9iHXKvhrQwnsXwZO16SgATy0qXUcmrYGSwrWh+4lCA10FbOKZxc2md5eZdY 9C+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782212544; x=1782817344; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=e7ujTj25beCliYcHaN6vgRmeikjh8fOvjTThSDgD3Oo=; b=LJGkhFErBa4IXopyA0O7M0HSH9MAXcys7nxAHDxJTmcwFzIbcvSxY6spU+RnePtQaI D+UO/arNdGnwN6bDToqeYp8YQE95eVAMF1hrcztEczEZdhDzvOca6Zp8PgDOkUaeCtNV QJ7mEOGmPpzOUFlAdPpzo0YMdqK1PNPbJHjGX9avYbnHfMjt5/1Wk/BNL12LS9rJ6neX I19DgpKVsAm+Xw+5C+WT14+Ngurl9xFC3WO4ICP9eb12Iu7J7kZiRybFXIUi3j1HuQ1W y4/C7vbyInWzHKuypYEirgvb/cn6PyxnDE5vilNHVxIO0dzWWMwxn4lochwG96CLND6F Jxmg== X-Gm-Message-State: AOJu0YzK+F3gsf5spuS964SgpnEYzF6yFSDgtj99bv4FRkJbRaTQ1FLu 1bhz2Y3xv8/zQTx2nNRMbrnJeYs6hgUnV0V6g1HVR3LOnZgvHuneeaMDI3jh0j95ShDqyuLGVfQ GJa9vuGdegIxTAv/ask8rtKsxDgolLsKsQUPeMZ2D66lgqXKZOpmMDvROMaZ+jQRvnXQ8 X-Gm-Gg: AfdE7ck2dU/rbZiYMIeHSe7TU91yFtEZkYCZ2bcecPCRZmz6ngJ8qy4TbIiEgxMyu32 NwuD2VWBisn/g30F0V8VVk17O5NKbOC8Y2DLrLeqvFiLAGJxTmSzSMiBZvC1ct31PQ2Ljq62Qrz vGNYiXtHYiYMoSig3JidKc7yxfG5WPU2dbK4orD3SimmoI5wWTpZul3OkWxUwulrG2bQduGJxEl kn0j7iBWQaCj018teDoXAA86nsAJdTCUhh7n1t5ZP09dZHB66jcjgiPsxwJi9WViWGeuB2uSEPH z3iVtQ2pmXgVTiHPB1r4JPlhWNVduxBUFMu7BMbQaSmv85F12oW+WUVbRfIuAFgDbbE59spnu6q azkvvNYdEI+1uv6R53yc/9Pigy3zkwWv1o5WT5IbXm30vjEwRAl3Nl70N0sEP1rAaVd7g X-Received: by 2002:a05:6808:4f25:b0:489:6c24:9d26 with SMTP id 5614622812f47-48f6210a3b3mr1058403b6e.27.1782212543983; Tue, 23 Jun 2026 04:02:23 -0700 (PDT) X-Received: by 2002:a05:6808:4f25:b0:489:6c24:9d26 with SMTP id 5614622812f47-48f6210a3b3mr1058344b6e.27.1782212543522; Tue, 23 Jun 2026 04:02:23 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-riscv@nongnu.org, qemu-ppc@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Brian Cain , Pierrick Bouvier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Song Gao , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Jiaxun Yang , Aleksandar Rikalo Subject: [RFC PATCH v2 1/4] target/tcg: Rename bitswap() helpers Date: Tue, 23 Jun 2026 13:02:05 +0200 Message-ID: <20260623110209.26861-2-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260623110209.26861-1-philmd@oss.qualcomm.com> References: <20260623110209.26861-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDA4OSBTYWx0ZWRfX2BzRnCeiOxpj Ux4ugALOfU83lxw27ltVwGZzPgVJC1Y3iobirV2EpXILckqP53aG5XgTrlHzJ4e2NFcfouXLMc6 SnZXAVyCuWKDvyBSmVE9ynClrPv8j5dyPawRLRA4zh6dMFTQukUo4/xfsLEWmyssy23oqXajiwI O3mpNVqB5FU6up/cU7ccJTQoJ3DDu1QyiWZsayfZ9a1s1rm6AADQYoeeH3QpXOpdfWkSJBLu2+r 8LUiyLjJLgO+5tNTVEPEwsbGUJ+pqyCkd4esgEaejndR4mTAKhtp/XEtDCMyhkUlEXR8Pa3pmSh 7Wk7+WMnyDDHKHi0szPYAYL96zk/o7HEXwmZFZGmdx3QHDgNfcSholpvJWRA8BRYgZ9bGnTqmDS gJ71hSyUluW9ueq/DEcthfAb5JrPcBuq3VLOhkaAbb+5TznGpHgMjeOtWPuYTQsfEr7czEHHdxE bGNrwuyY/AKLRj8KNZA== X-Proofpoint-GUID: BH-789Tfnm9bpsnqRucGRG0DWZrXg6kn X-Authority-Analysis: v=2.4 cv=dvfrzVg4 c=1 sm=1 tr=0 ts=6a3a67c1 cx=c_pps a=WJcna6AvsNCxL/DJwPP1KA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=Vq8-Eo_8D2-Y-oFXv_MA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=_Y9Zt4tPzoBS9L09Snn2:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDA4OSBTYWx0ZWRfXxAMgtSvT9c5l h8B5c6rZrQsVLSKkMd2OrrowarZO3cCf2+gNcq9Uant+3WBujt8ptooTqKwGl17CKvQd68PHius DjaQZUMyBzqqJJzc9jZCcyPuDPZzGI8= X-Proofpoint-ORIG-GUID: BH-789Tfnm9bpsnqRucGRG0DWZrXg6kn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_02,2026-06-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 spamscore=0 adultscore=0 clxscore=1015 suspectscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230089 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1782212620989158500 From: Philippe Mathieu-Daud=C3=A9 In order to avoid symbol name clash when building a single binary, rename TCG helpers prefixing with the target name. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Brian Cain Reviewed-by: Pierrick Bouvier Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/loongarch/tcg/helper.h | 2 +- target/mips/helper.h | 2 +- target/loongarch/tcg/op_helper.c | 2 +- target/mips/tcg/op_helper.c | 2 +- target/mips/tcg/translate.c | 2 +- target/loongarch/tcg/insn_trans/trans_bit.c.inc | 4 ++-- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a/target/loongarch/tcg/helper.h b/target/loongarch/tcg/helper.h index 8a6c62f1161..e36dd2f5de3 100644 --- a/target/loongarch/tcg/helper.h +++ b/target/loongarch/tcg/helper.h @@ -7,7 +7,7 @@ DEF_HELPER_2(raise_exception, noreturn, env, i32) =20 DEF_HELPER_FLAGS_1(bitrev_w, TCG_CALL_NO_RWG_SE, tl, tl) DEF_HELPER_FLAGS_1(bitrev_d, TCG_CALL_NO_RWG_SE, tl, tl) -DEF_HELPER_FLAGS_1(bitswap, TCG_CALL_NO_RWG_SE, tl, tl) +DEF_HELPER_FLAGS_1(loongarch_bitswap, TCG_CALL_NO_RWG_SE, tl, tl) =20 DEF_HELPER_FLAGS_3(asrtle_d, TCG_CALL_NO_WG, void, env, tl, tl) DEF_HELPER_FLAGS_3(asrtgt_d, TCG_CALL_NO_WG, void, env, tl, tl) diff --git a/target/mips/helper.h b/target/mips/helper.h index e2b83a1d19d..f3d459982cf 100644 --- a/target/mips/helper.h +++ b/target/mips/helper.h @@ -16,7 +16,7 @@ DEF_HELPER_3(lld, tl, env, tl, i32) #endif #endif =20 -DEF_HELPER_FLAGS_1(bitswap, TCG_CALL_NO_RWG_SE, tl, tl) +DEF_HELPER_FLAGS_1(mips_bitswap, TCG_CALL_NO_RWG_SE, tl, tl) #ifdef TARGET_MIPS64 DEF_HELPER_FLAGS_1(dbitswap, TCG_CALL_NO_RWG_SE, tl, tl) #endif diff --git a/target/loongarch/tcg/op_helper.c b/target/loongarch/tcg/op_hel= per.c index e63ac66daae..35f331ca52c 100644 --- a/target/loongarch/tcg/op_helper.c +++ b/target/loongarch/tcg/op_helper.c @@ -32,7 +32,7 @@ target_ulong helper_bitrev_d(target_ulong rj) return revbit64(rj); } =20 -target_ulong helper_bitswap(target_ulong v) +target_ulong helper_loongarch_bitswap(target_ulong v) { v =3D ((v >> 1) & (target_ulong)0x5555555555555555ULL) | ((v & (target_ulong)0x5555555555555555ULL) << 1); diff --git a/target/mips/tcg/op_helper.c b/target/mips/tcg/op_helper.c index 4502ae2b5be..83c340e38e0 100644 --- a/target/mips/tcg/op_helper.c +++ b/target/mips/tcg/op_helper.c @@ -45,7 +45,7 @@ target_ulong helper_dbitswap(target_ulong rt) } #endif =20 -target_ulong helper_bitswap(target_ulong rt) +target_ulong helper_mips_bitswap(target_ulong rt) { return (int32_t)bitswap(rt); } diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c index 123d2c89c3d..811492364a3 100644 --- a/target/mips/tcg/translate.c +++ b/target/mips/tcg/translate.c @@ -4842,7 +4842,7 @@ static void gen_bitswap(DisasContext *ctx, int opc, i= nt rd, int rt) gen_load_gpr(t0, rt); switch (opc) { case OPC_BITSWAP: - gen_helper_bitswap(cpu_gpr[rd], t0); + gen_helper_mips_bitswap(cpu_gpr[rd], t0); break; #if defined(TARGET_MIPS64) case OPC_DBITSWAP: diff --git a/target/loongarch/tcg/insn_trans/trans_bit.c.inc b/target/loong= arch/tcg/insn_trans/trans_bit.c.inc index ee5fa003ce0..76d6ba742d5 100644 --- a/target/loongarch/tcg/insn_trans/trans_bit.c.inc +++ b/target/loongarch/tcg/insn_trans/trans_bit.c.inc @@ -194,8 +194,8 @@ TRANS(revb_2w, 64, gen_rr, EXT_NONE, EXT_NONE, gen_revb= _2w) TRANS(revb_d, 64, gen_rr, EXT_NONE, EXT_NONE, tcg_gen_bswap64_i64) TRANS(revh_2w, 64, gen_rr, EXT_NONE, EXT_NONE, gen_revh_2w) TRANS(revh_d, 64, gen_rr, EXT_NONE, EXT_NONE, gen_revh_d) -TRANS(bitrev_4b, ALL, gen_rr, EXT_ZERO, EXT_SIGN, gen_helper_bitswap) -TRANS(bitrev_8b, 64, gen_rr, EXT_NONE, EXT_NONE, gen_helper_bitswap) +TRANS(bitrev_4b, ALL, gen_rr, EXT_ZERO, EXT_SIGN, gen_helper_loongarch_bit= swap) +TRANS(bitrev_8b, 64, gen_rr, EXT_NONE, EXT_NONE, gen_helper_loongarch_bits= wap) TRANS(bitrev_w, ALL, gen_rr, EXT_NONE, EXT_SIGN, gen_helper_bitrev_w) TRANS(bitrev_d, 64, gen_rr, EXT_NONE, EXT_NONE, gen_helper_bitrev_d) TRANS(maskeqz, ALL, gen_rrr, EXT_NONE, EXT_NONE, EXT_NONE, gen_maskeqz) --=20 2.53.0 From nobody Sun Jul 26 12:38:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1782212627; cv=none; d=zohomail.com; s=zohoarc; b=O5JB7/XMSo5EQjxJ3i5SyhoFP7B+QEPuW91IK8yPvN61tHV1UAwdHVvAz2KnOuMVIJJmOMd6U9voS69vSsrlASuLL8Vfdy5eEx/jYQRPmUiUcHnxho+m89KsWIKRPQT68FksY8FNERPodrlNfXK2iv+KafyYW4islcX3En1DOiw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782212627; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=+sHlKQTvJbCdqK1s8ESlP25D81ue73E/lJ5TJI/qsm0=; b=SQkHtVj1ZTGOXMadVoQntQMwMB35j9Gyfy9rzhizNgfY2IA+KQBIQ2eoYRIepP5so2cGim1BeTWLg2WWFArr555aBOk1yzT3Zd8IopvB9twooahKOmYJUD3Wz8Vqw38i9iJ4bhm4310jd/fxMfI7hk/GTMx5yRiTfoxWEZ47f00= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782212627254910.6509919632415; Tue, 23 Jun 2026 04:03:47 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wbyuh-0006xf-To; Tue, 23 Jun 2026 07:03:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wbytq-0006hy-GS for qemu-devel@nongnu.org; Tue, 23 Jun 2026 07:02:40 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wbytm-00068S-5J for qemu-devel@nongnu.org; Tue, 23 Jun 2026 07:02:36 -0400 Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65NAsMU1042156 for ; Tue, 23 Jun 2026 11:02:33 GMT Received: from mail-ot1-f71.google.com (mail-ot1-f71.google.com [209.85.210.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eyr32078m-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 11:02:33 +0000 (GMT) Received: by mail-ot1-f71.google.com with SMTP id 46e09a7af769-7e948e3248eso3244591a34.1 for ; Tue, 23 Jun 2026 04:02:33 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4666712ce9asm34715389f8f.37.2026.06.23.04.02.29 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 23 Jun 2026 04:02:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +sHlKQTvJbCdqK1s8ESlP25D81ue73E/lJ5TJI/qsm0=; b=aWEwQnR05yEaHUN/ X6RQ9srj/fl7fSLp0HVIWb3lkMN9tAIpjHFKuO5JnF74jHoQgRKMMFzQBpYCHNse /OxiG+qByrtJVVzNGtP+72kBRovVTgxK0V8BxJbcz+eoRJ4HYb4RhJ9oqzneS2sh HeMYyFa4xXYgbU8xZfoDh+z+ASbGKcUIUiEvdDKY6dim4If05F2pO3xpwFgueYhY htjcVzla+AxgG8Tl1GhdD+oqOkFhsQZ9rpdLGF9pkm5q6CHJJnxFAElESfeedYDg rsjPd3FZUvePwzjYi2rACo//jz6gQg75Fu3H9saiOUjNMwPxfwz8c0i+aEdInCVh 7C35dg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782212552; x=1782817352; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+sHlKQTvJbCdqK1s8ESlP25D81ue73E/lJ5TJI/qsm0=; b=Qf1hwfKK/33qxLgVwAufKfBck2abZ9jkV4h6TDlpys2IU3Z5pa0MsSrG0ZzpkrN1A6 y/IVWj5MKJ9KAA+dg8ptw/bCj7OlGxkE247qH9bR6SxVCKsRjibiApLZOfRB9FVUY1E/ CgHwBEPz354dVn+/R8kuW1i9xPMkTOCL2Yv7k2F9leuQPCox0EZDfo9kKkd3QihAIhOs X1ZVCBf7cJtVVaOKSHqNZUhqrjWHWLDJnKVSkSddzWELUPX13UFNP72/x52BHDMEjGRU juXjTDasKdAepu5nRWlRIuOI+gUhUctyjKcEGfG6NACmF7QGQLsjElpnv4hn2UolBXT6 cfGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782212552; x=1782817352; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+sHlKQTvJbCdqK1s8ESlP25D81ue73E/lJ5TJI/qsm0=; b=h1Grt/zRy+1XEgYJ9cg04xUCIzEn1av/k1wdJ0RQyJa3i4tKIpWZ6GdxmGmI/tmsCW GXdB2izh/p7FvE2AxQKLETQoGQ5wGpgK2yfI3ywFoSN2Y43ZCD5Yhkg5UnHsJnPBY1xA zqG53EazanBSXm9YYkCb9NhnCLLsuhZqp8kew95gZEJJItOcZy2/sIr1y0pX54ZYMulO vfKtaEmuTwvVsDkzSIhRi4cYDLmJb9iqvDu8InCeosNnf7XtJDQgnVFix+iI98S15fmk 1yPWSO9sONPcCk7ByFY823Lwcmao+RhNPECR2EEeouneRwYU90KynO37Fpa7BYU3N78x SyBQ== X-Gm-Message-State: AOJu0Yx+RV6qR2NnhnY2C8i72cgrFqURILMcMiJHbdn4FEwXEJXL8BWJ X5hTMX0b2icMjP/zBByFlda2ojj04Q3wEexuNEXN5G0dYtII1D7cnmm5unZrz4nSj2ggRJF/VwI DcV391kTzbe2WCLY3j4tKCGijLJXxRt/vjjv03FmRpFWv00Mikymvtc4FUoD2junDkGI5 X-Gm-Gg: AfdE7cmXczQTmfD4c8ragmEAmJojixKu2sI7/D/no9txa2PWlG3qOUxkL+HDIio6+rU zneGZvrdO5UzRe3on+1QU+uAxg+b9KJ/VFHk0iKLfUbv1zEVI3D1zF10EjgTpDyGeXH+7E5Bc7g +PK6T3ogPCCvIOxNACRjHetUIqNF8NpoHAt35UTm4SRu7aqBI1xz0O06kbw+2BFs1dyfbhSpbFO O5s6UHFsVXGKjMqiGG7JnQOeE7CeEfbPgZtfGW+Oe9mebRQg7P0Su1Z2+p35j+vB4qBkX6urgOa gXUnuEdq7VuxS5JENjr4TC76hAqlB/+UtiM2pPd2DS3haZxKgC1U6odIoSUCXWdfetsMwhLgrlQ Fb73E6Q+g3c1nvcGKIc2YosElE6IzkS5Wn5ZvMK0WtvlQivhO5Swz0UdeqT6XT+4Fojn7 X-Received: by 2002:a05:6830:6110:b0:7dc:dd58:50b8 with SMTP id 46e09a7af769-7e979474907mr1373636a34.13.1782212552355; Tue, 23 Jun 2026 04:02:32 -0700 (PDT) X-Received: by 2002:a05:6830:6110:b0:7dc:dd58:50b8 with SMTP id 46e09a7af769-7e979474907mr1373578a34.13.1782212551805; Tue, 23 Jun 2026 04:02:31 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-riscv@nongnu.org, qemu-ppc@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Brian Cain , Pierrick Bouvier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Peter Maydell , Paolo Bonzini , Zhao Liu , Richard Henderson , Song Gao , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Jiaxun Yang , Aleksandar Rikalo Subject: [RFC PATCH v2 2/4] target/tcg: Rename crc32*() helpers Date: Tue, 23 Jun 2026 13:02:06 +0200 Message-ID: <20260623110209.26861-3-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260623110209.26861-1-philmd@oss.qualcomm.com> References: <20260623110209.26861-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDA4OSBTYWx0ZWRfXw5VPAFrB68UC BDWDACqcCRCBn41FwP5l6QQ0kqDqmmWrkmWp8U6wW4iO56AzRmgpKw/RoCe+LXlWgZiGfHYQbE7 3Zp0jiZAwdF9VNkmkuNzh56HUM3vRaM= X-Proofpoint-ORIG-GUID: eP31vnOLhYaaiR5KRbXmqeO2rxlOrf0M X-Authority-Analysis: v=2.4 cv=HrxG3UTS c=1 sm=1 tr=0 ts=6a3a67c9 cx=c_pps a=OI0sxtj7PyCX9F1bxD/puw==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=xjhSHqqUzGq1U0fGcn4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=Z1Yy7GAxqfX1iEi80vsk:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDA4OSBTYWx0ZWRfX+GWFMu4t8gv1 a/qBkKx59wAcvzFFak3qDGew2c6EBCXw3lLn+F+pocLhFP8RsFXRQoZAg+r34s7mYZoGj7Dfi5Z v87iXix2Km2NrWH1oSWCEVmqulMHBx8+tffBwU+vfl5CeOG9hnAMRt4Upd/vsFSsKWSKGEtdr8m Wk1EIotruWU0tyljw5wKmRqUTY9lzqGapY/jJJ5hyztAtWdLvwgJXKufIKBvgAMjZQCAK9Yak+F Nc0FLq3DZVCXNuZl2Oaj+tfDbeL3MHNz8M2uQSW1tOOXwcpCv1ZSH5eXJoORdNGmkfGF9ExhALf Zdp93Vvxy6j5cMy1+h5/Qxmt0/8cvTyLHKNtCAFTFIirkxGyj9oUA0RG+spaCgLBgA6jbUvWhRs jGX2PwCq+xKKzP6YKH1YDfy7TLf+IpP9gkVTNSe+OoDf/0dU49C8t4GMCYRarUZSgJZVr2DT2xQ 57J1sbL88H81a9CuNgQ== X-Proofpoint-GUID: eP31vnOLhYaaiR5KRbXmqeO2rxlOrf0M X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_02,2026-06-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 phishscore=0 priorityscore=1501 malwarescore=0 adultscore=0 bulkscore=0 impostorscore=0 clxscore=1015 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230089 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1782212629413158500 From: Philippe Mathieu-Daud=C3=A9 In order to avoid symbol name clash when building a single binary, rename TCG helpers prefixing with the target name. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Brian Cain Reviewed-by: Pierrick Bouvier Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/arm/tcg/helper-defs.h | 4 ++-- target/i386/ops_sse.h | 2 +- target/loongarch/tcg/helper.h | 4 ++-- target/mips/helper.h | 4 ++-- target/i386/tcg/ops_sse_header.h.inc | 2 +- target/arm/tcg/arith_helper.c | 4 ++-- target/arm/tcg/translate.c | 4 ++-- target/loongarch/tcg/op_helper.c | 4 ++-- target/mips/tcg/op_helper.c | 4 ++-- target/mips/tcg/translate.c | 4 ++-- target/i386/tcg/emit.c.inc | 2 +- .../loongarch/tcg/insn_trans/trans_extra.c.inc | 16 ++++++++-------- 12 files changed, 27 insertions(+), 27 deletions(-) diff --git a/target/arm/tcg/helper-defs.h b/target/arm/tcg/helper-defs.h index 8ec6c163195..4d113ee0690 100644 --- a/target/arm/tcg/helper-defs.h +++ b/target/arm/tcg/helper-defs.h @@ -493,8 +493,8 @@ DEF_HELPER_FLAGS_4(crypto_sm4ekey, TCG_CALL_NO_RWG, voi= d, ptr, ptr, ptr, i32) =20 DEF_HELPER_FLAGS_4(crypto_rax1, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) =20 -DEF_HELPER_FLAGS_3(crc32, TCG_CALL_NO_RWG_SE, i32, i32, i32, i32) -DEF_HELPER_FLAGS_3(crc32c, TCG_CALL_NO_RWG_SE, i32, i32, i32, i32) +DEF_HELPER_FLAGS_3(arm_crc32, TCG_CALL_NO_RWG_SE, i32, i32, i32, i32) +DEF_HELPER_FLAGS_3(arm_crc32c, TCG_CALL_NO_RWG_SE, i32, i32, i32, i32) =20 DEF_HELPER_FLAGS_5(gvec_qrdmlah_s16, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, ptr, i32) diff --git a/target/i386/ops_sse.h b/target/i386/ops_sse.h index 5176a9f9e35..c54c8e460ce 100644 --- a/target/i386/ops_sse.h +++ b/target/i386/ops_sse.h @@ -2111,7 +2111,7 @@ void glue(helper_pcmpistrm, SUFFIX)(CPUX86State *env,= Reg *d, Reg *s, =20 #define CRCPOLY 0x1edc6f41 #define CRCPOLY_BITREV 0x82f63b78 -target_ulong helper_crc32(uint32_t crc1, target_ulong msg, uint32_t len) +target_ulong helper_x86_crc32(uint32_t crc1, target_ulong msg, uint32_t le= n) { target_ulong crc =3D (msg & ((target_ulong) -1 >> (TARGET_LONG_BITS - len))) ^ crc1; diff --git a/target/loongarch/tcg/helper.h b/target/loongarch/tcg/helper.h index e36dd2f5de3..35b055eb3bc 100644 --- a/target/loongarch/tcg/helper.h +++ b/target/loongarch/tcg/helper.h @@ -12,8 +12,8 @@ DEF_HELPER_FLAGS_1(loongarch_bitswap, TCG_CALL_NO_RWG_SE,= tl, tl) DEF_HELPER_FLAGS_3(asrtle_d, TCG_CALL_NO_WG, void, env, tl, tl) DEF_HELPER_FLAGS_3(asrtgt_d, TCG_CALL_NO_WG, void, env, tl, tl) =20 -DEF_HELPER_FLAGS_3(crc32, TCG_CALL_NO_RWG_SE, tl, tl, tl, tl) -DEF_HELPER_FLAGS_3(crc32c, TCG_CALL_NO_RWG_SE, tl, tl, tl, tl) +DEF_HELPER_FLAGS_3(loongarch_crc32, TCG_CALL_NO_RWG_SE, tl, tl, tl, tl) +DEF_HELPER_FLAGS_3(loongarch_crc32c, TCG_CALL_NO_RWG_SE, tl, tl, tl, tl) DEF_HELPER_FLAGS_2(cpucfg, TCG_CALL_NO_RWG_SE, tl, env, tl) =20 /* Floating-point helper */ diff --git a/target/mips/helper.h b/target/mips/helper.h index f3d459982cf..10c6470514d 100644 --- a/target/mips/helper.h +++ b/target/mips/helper.h @@ -21,8 +21,8 @@ DEF_HELPER_FLAGS_1(mips_bitswap, TCG_CALL_NO_RWG_SE, tl, = tl) DEF_HELPER_FLAGS_1(dbitswap, TCG_CALL_NO_RWG_SE, tl, tl) #endif =20 -DEF_HELPER_3(crc32, tl, tl, tl, i32) -DEF_HELPER_3(crc32c, tl, tl, tl, i32) +DEF_HELPER_3(mips_crc32, tl, tl, tl, i32) +DEF_HELPER_3(mips_crc32c, tl, tl, tl, i32) DEF_HELPER_FLAGS_4(rotx, TCG_CALL_NO_RWG_SE, tl, tl, i32, i32, i32) =20 /* microMIPS functions */ diff --git a/target/i386/tcg/ops_sse_header.h.inc b/target/i386/tcg/ops_sse= _header.h.inc index bbeb7301c33..8569f9935e3 100644 --- a/target/i386/tcg/ops_sse_header.h.inc +++ b/target/i386/tcg/ops_sse_header.h.inc @@ -337,7 +337,7 @@ DEF_HELPER_4(glue(pcmpestri, SUFFIX), void, env, Reg, R= eg, i32) DEF_HELPER_4(glue(pcmpestrm, SUFFIX), void, env, Reg, Reg, i32) DEF_HELPER_4(glue(pcmpistri, SUFFIX), void, env, Reg, Reg, i32) DEF_HELPER_4(glue(pcmpistrm, SUFFIX), void, env, Reg, Reg, i32) -DEF_HELPER_3(crc32, tl, i32, tl, i32) +DEF_HELPER_3(x86_crc32, tl, i32, tl, i32) #endif =20 /* AES-NI op helpers */ diff --git a/target/arm/tcg/arith_helper.c b/target/arm/tcg/arith_helper.c index cc081c8f966..3a5cb41c7a9 100644 --- a/target/arm/tcg/arith_helper.c +++ b/target/arm/tcg/arith_helper.c @@ -275,7 +275,7 @@ uint32_t HELPER(sel_flags)(uint32_t flags, uint32_t a, = uint32_t b) * The upper bytes of val (above the number specified by 'bytes') must have * been zeroed out by the caller. */ -uint32_t HELPER(crc32)(uint32_t acc, uint32_t val, uint32_t bytes) +uint32_t HELPER(arm_crc32)(uint32_t acc, uint32_t val, uint32_t bytes) { uint8_t buf[4]; =20 @@ -285,7 +285,7 @@ uint32_t HELPER(crc32)(uint32_t acc, uint32_t val, uint= 32_t bytes) return crc32(acc ^ 0xffffffff, buf, bytes) ^ 0xffffffff; } =20 -uint32_t HELPER(crc32c)(uint32_t acc, uint32_t val, uint32_t bytes) +uint32_t HELPER(arm_crc32c)(uint32_t acc, uint32_t val, uint32_t bytes) { uint8_t buf[4]; =20 diff --git a/target/arm/tcg/translate.c b/target/arm/tcg/translate.c index c744b163453..e4e2b6be646 100644 --- a/target/arm/tcg/translate.c +++ b/target/arm/tcg/translate.c @@ -3350,9 +3350,9 @@ static bool op_crc32(DisasContext *s, arg_rrr *a, boo= l c, MemOp sz) } t3 =3D tcg_constant_i32(1 << sz); if (c) { - gen_helper_crc32c(t1, t1, t2, t3); + gen_helper_arm_crc32c(t1, t1, t2, t3); } else { - gen_helper_crc32(t1, t1, t2, t3); + gen_helper_arm_crc32(t1, t1, t2, t3); } store_reg(s, a->rd, t1); return true; diff --git a/target/loongarch/tcg/op_helper.c b/target/loongarch/tcg/op_hel= per.c index 35f331ca52c..ffd8d6d2bd9 100644 --- a/target/loongarch/tcg/op_helper.c +++ b/target/loongarch/tcg/op_helper.c @@ -64,7 +64,7 @@ void helper_asrtgt_d(CPULoongArchState *env, target_ulong= rj, target_ulong rk) } } =20 -target_ulong helper_crc32(target_ulong val, target_ulong m, uint64_t sz) +target_ulong helper_loongarch_crc32(target_ulong val, target_ulong m, uint= 64_t sz) { uint8_t buf[8]; target_ulong mask =3D ((sz * 8) =3D=3D 64) ? -1ULL : ((1ULL << (sz * 8= )) - 1); @@ -74,7 +74,7 @@ target_ulong helper_crc32(target_ulong val, target_ulong = m, uint64_t sz) return (int32_t) (crc32(val ^ 0xffffffff, buf, sz) ^ 0xffffffff); } =20 -target_ulong helper_crc32c(target_ulong val, target_ulong m, uint64_t sz) +target_ulong helper_loongarch_crc32c(target_ulong val, target_ulong m, uin= t64_t sz) { uint8_t buf[8]; target_ulong mask =3D ((sz * 8) =3D=3D 64) ? -1ULL : ((1ULL << (sz * 8= )) - 1); diff --git a/target/mips/tcg/op_helper.c b/target/mips/tcg/op_helper.c index 83c340e38e0..723253da59d 100644 --- a/target/mips/tcg/op_helper.c +++ b/target/mips/tcg/op_helper.c @@ -145,7 +145,7 @@ target_ulong helper_rotx(target_ulong rs, uint32_t shif= t, uint32_t shiftx, } =20 /* these crc32 functions are based on target/loongarch/tcg/op_helper.c */ -target_ulong helper_crc32(target_ulong val, target_ulong m, uint32_t sz) +target_ulong helper_mips_crc32(target_ulong val, target_ulong m, uint32_t = sz) { uint8_t buf[8]; target_ulong mask =3D ((sz * 8) =3D=3D 64) ? @@ -157,7 +157,7 @@ target_ulong helper_crc32(target_ulong val, target_ulon= g m, uint32_t sz) return (int32_t) (crc32(val ^ 0xffffffff, buf, sz) ^ 0xffffffff); } =20 -target_ulong helper_crc32c(target_ulong val, target_ulong m, uint32_t sz) +target_ulong helper_mips_crc32c(target_ulong val, target_ulong m, uint32_t= sz) { uint8_t buf[8]; target_ulong mask =3D ((sz * 8) =3D=3D 64) ? diff --git a/target/mips/tcg/translate.c b/target/mips/tcg/translate.c index 811492364a3..304d7ccaf28 100644 --- a/target/mips/tcg/translate.c +++ b/target/mips/tcg/translate.c @@ -13445,9 +13445,9 @@ void gen_crc32(DisasContext *ctx, int rd, int rs, i= nt rt, int sz, gen_load_gpr(t1, rs); =20 if (crc32c) { - gen_helper_crc32c(cpu_gpr[rd], t0, t1, tsz); + gen_helper_mips_crc32c(cpu_gpr[rd], t0, t1, tsz); } else { - gen_helper_crc32(cpu_gpr[rd], t0, t1, tsz); + gen_helper_mips_crc32(cpu_gpr[rd], t0, t1, tsz); } } =20 diff --git a/target/i386/tcg/emit.c.inc b/target/i386/tcg/emit.c.inc index 83c889cc3b2..386ca5348d3 100644 --- a/target/i386/tcg/emit.c.inc +++ b/target/i386/tcg/emit.c.inc @@ -1916,7 +1916,7 @@ static void gen_CRC32(DisasContext *s, X86DecodedInsn= *decode) TCGv_i32 tmp =3D tcg_temp_new_i32(); =20 tcg_gen_trunc_tl_i32(tmp, s->T0); - gen_helper_crc32(s->T0, tmp, s->T1, tcg_constant_i32(8 << ot)); + gen_helper_x86_crc32(s->T0, tmp, s->T1, tcg_constant_i32(8 << ot)); } =20 static void gen_CVTPI2Px(DisasContext *s, X86DecodedInsn *decode) diff --git a/target/loongarch/tcg/insn_trans/trans_extra.c.inc b/target/loo= ngarch/tcg/insn_trans/trans_extra.c.inc index 655dce329e8..63548eeb567 100644 --- a/target/loongarch/tcg/insn_trans/trans_extra.c.inc +++ b/target/loongarch/tcg/insn_trans/trans_extra.c.inc @@ -105,11 +105,11 @@ static bool gen_crc(DisasContext *ctx, arg_rrr *a, return true; } =20 -TRANS(crc_w_b_w, CRC, gen_crc, gen_helper_crc32, tcg_constant_tl(1)) -TRANS(crc_w_h_w, CRC, gen_crc, gen_helper_crc32, tcg_constant_tl(2)) -TRANS(crc_w_w_w, CRC, gen_crc, gen_helper_crc32, tcg_constant_tl(4)) -TRANS64(crc_w_d_w, CRC, gen_crc, gen_helper_crc32, tcg_constant_tl(8)) -TRANS(crcc_w_b_w, CRC, gen_crc, gen_helper_crc32c, tcg_constant_tl(1)) -TRANS(crcc_w_h_w, CRC, gen_crc, gen_helper_crc32c, tcg_constant_tl(2)) -TRANS(crcc_w_w_w, CRC, gen_crc, gen_helper_crc32c, tcg_constant_tl(4)) -TRANS64(crcc_w_d_w, CRC, gen_crc, gen_helper_crc32c, tcg_constant_tl(8)) +TRANS(crc_w_b_w, CRC, gen_crc, gen_helper_loongarch_crc32, tcg_constant_tl= (1)) +TRANS(crc_w_h_w, CRC, gen_crc, gen_helper_loongarch_crc32, tcg_constant_tl= (2)) +TRANS(crc_w_w_w, CRC, gen_crc, gen_helper_loongarch_crc32, tcg_constant_tl= (4)) +TRANS64(crc_w_d_w, CRC, gen_crc, gen_helper_loongarch_crc32, tcg_constant_= tl(8)) +TRANS(crcc_w_b_w, CRC, gen_crc, gen_helper_loongarch_crc32c, tcg_constant_= tl(1)) +TRANS(crcc_w_h_w, CRC, gen_crc, gen_helper_loongarch_crc32c, tcg_constant_= tl(2)) +TRANS(crcc_w_w_w, CRC, gen_crc, gen_helper_loongarch_crc32c, tcg_constant_= tl(4)) +TRANS64(crcc_w_d_w, CRC, gen_crc, gen_helper_loongarch_crc32c, tcg_constan= t_tl(8)) --=20 2.53.0 From nobody Sun Jul 26 12:38:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1782212676; cv=none; d=zohomail.com; s=zohoarc; b=nAmRzM6tp5A5evjhxBRvmc1lH3Vut0AVqxC2QNxrB2deHeL2mzctdcDPQu9Mro4i/Ym8aH8FHWfsfYa0JnanP8x4yk54XYliw6vklQVw5zTyrDMlCIOc+jXmcgnG6uf7XtP28FMqrqkdL05yxwE166C+WtBl6HHH7L8C9Snaeog= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782212676; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=iH/zQRgQ5VQcthLR36rPR/2Y88jfz5AKDFzZwmWwNX8=; b=dBwvPu8+JVxoGxNEzPsFE/ORj5SgHccit6wScw1IUF7FS9zrARVcYvHYVW8gor8lLJoEqSVJoNp430cbZnunAsMOmDzrtBFduNkwA9msfrUrCWgfHMBTrVzn4PNW++XCO2/tIBPhnHKfESDOEcwON6LEFOn4sVF6xXfhGNwKrvQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782212676875915.2532651386102; Tue, 23 Jun 2026 04:04:36 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wbyut-0007M9-Eh; Tue, 23 Jun 2026 07:03:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wbyu1-0006oc-WA for qemu-devel@nongnu.org; Tue, 23 Jun 2026 07:02:54 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wbytv-00069x-US for qemu-devel@nongnu.org; Tue, 23 Jun 2026 07:02:49 -0400 Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65NAsd0L3664083 for ; Tue, 23 Jun 2026 11:02:42 GMT Received: from mail-ot1-f70.google.com (mail-ot1-f70.google.com [209.85.210.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eyp29gt71-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 11:02:41 +0000 (GMT) Received: by mail-ot1-f70.google.com with SMTP id 46e09a7af769-7e93b1cc222so7272343a34.0 for ; Tue, 23 Jun 2026 04:02:41 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-466643f4ee6sm33497167f8f.5.2026.06.23.04.02.38 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 23 Jun 2026 04:02:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= iH/zQRgQ5VQcthLR36rPR/2Y88jfz5AKDFzZwmWwNX8=; b=NNRV13Co8rs7WB+A P0VIg0/YEzbgNdedvJ0AceTIiOfGBIpZYzO8P0TKXU8O+yVDuCnlTjwZTYNA8Ahe XHPUSXxkN2bTCubO+iNFpa5OOFLMWS1UtL5wQrBWzIr5XHmar/Y2IuCF/cDNgLDL mKu6QqBTclRKNOuqYVBVJaFNlom++NC/QprviR6ZBJknixNVUDJ9zoGRDDEXhak6 mc0oIgGJvO+xRgXrjaUf97JVADrVXA2KEADQK536fGyHNC5QEkM9aGzEw5WZqys9 YK8l2TJpQBZmovA+3eWdjWgEJ/Fj2XvjWybz8jzbMUPV0ESDRVdXQhuLe79XujEE wvI1JQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782212561; x=1782817361; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iH/zQRgQ5VQcthLR36rPR/2Y88jfz5AKDFzZwmWwNX8=; b=RxP2o0AYxltwaC8WafBGoogsnaSkWnRbnICuB5FgnJ3zF1F+jhxfwYWPda1Er05e17 GwJJKsCf278M4I1d+1AnR9DmtYJ+GyocC+5dQJq3R07dY4qhg+XY2HwluPpMvBVhS60c rJwfWY+dlJSdj7TsFxmErJiMWUq90H5QaTcq4uiIB2MXkO2v2JSYph10Dgw1BxQ21zQx G8Mgp2E9dEgdqat1jadnvQV8eBwukgxA2WYXuRX2vZ27PDWdyInbIUz/JL9sx0aLf1co S4vLELr/+Ptid/49yhaGA8mcXipBo8dOS6dWc6UkNunH7p0XIrBZ8LecMA36cOFBifWn bbDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782212561; x=1782817361; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=iH/zQRgQ5VQcthLR36rPR/2Y88jfz5AKDFzZwmWwNX8=; b=njTu7v7gdJc8vlCrtvQZ5vIctVdYJm1TpSihPvYADn8NM8ZF+h5NJH2kdWeLHSQwob MbCSknsqunxKGWlS9s0DO0zyQtUKs4gGKHzZ3Elm+toq6oSdL/yoip3aYQcxy9GAMxPi qq5CJKrFKNiyNSCtY9dlTgj4kZRxpHxDBG+RF/yBflK9EFvIGo/6l0evR+ykzbkFugQ1 /KCh+Kus9UHxluI1IVXmipFMrfoRTmLcSEVEAm5beIDH/ATP5Mm+NLdEI7zCcOle8Io0 qZXHLkaGsOJLpEFiM8ZMX9Z31tVtb0xyq0Zb8S3MJzI1ABtGd4wu/WJp3lMwFGvN6VQR h5Nw== X-Gm-Message-State: AOJu0YyRvja1PJ31z+nLmGEO6bHSYvrzgBrh+YI7pdFQh9PqrFlR/YOG 7cLW0R6KhhTeE3PuAl0CP3zATt7BqUOq3Ao50SiHdBRuvHrrGbQqMltFR402aMJgyG3GSsYCApJ p6aC1s0Vy1taBoXPfjoBwOo1ixYwiNOvX98Bn8mqt0Oy1YLD949bpQCcAT0o+tpynr781 X-Gm-Gg: AfdE7cmsk/Wzw+hOINnQQQq8EUkc9jqmZLP4Fo3Cok9vPXW2P6ySfS6vsKrJ+Iq1gVG X2INyVsvXTb+nq2Pg06I3CXNSlXde3GSo94H5xoT6jCQdPsLXKfUf821fKpABAtSmAFtAYNEyMQ lbDWFVLvNQEDfuOzEieMoXS29icvtiaCyJ3TWs6dFK5fqnvvVvrAms34/jMLUaoXs+45HjXOpQs woQ8ARfYzpYgUl6DrGO2npsChVVOPXm0FKg+E7pfTGHFm7W5onfBLnd6BO9T7dZFSKB6jMx5fc9 19QVV6T5j81Hc9kKwwxEASP0WFI75U0r5NhMFDM865y8d29XNdcTtSsyGVeFEmvXCHKFiLrTc/Z 9SlIVxTnXAsS6bemu047lncNPjr2z6GqWEmesdERYDvGaYYn68fD6PdDS+PAge9Uj7rnn X-Received: by 2002:a05:6830:6388:b0:7e6:dc7a:f459 with SMTP id 46e09a7af769-7e92d97798amr14812052a34.11.1782212560739; Tue, 23 Jun 2026 04:02:40 -0700 (PDT) X-Received: by 2002:a05:6830:6388:b0:7e6:dc7a:f459 with SMTP id 46e09a7af769-7e92d97798amr14811975a34.11.1782212560233; Tue, 23 Jun 2026 04:02:40 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-riscv@nongnu.org, qemu-ppc@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Brian Cain , Pierrick Bouvier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Paolo Bonzini , Zhao Liu , Richard Henderson , Laurent Vivier , "Edgar E. Iglesias" , Nicholas Piggin , Chinmay Rath , Glenn Miles , Harsh Prateek Bora , Mark Cave-Ayland , Artyom Tarasenko Subject: [RFC PATCH v2 3/4] target/tcg: Rename raise_exception() helpers Date: Tue, 23 Jun 2026 13:02:07 +0200 Message-ID: <20260623110209.26861-4-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260623110209.26861-1-philmd@oss.qualcomm.com> References: <20260623110209.26861-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=LdAMLDfi c=1 sm=1 tr=0 ts=6a3a67d1 cx=c_pps a=7uPEO8VhqeOX8vTJ3z8K6Q==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=OkN9J5DZ8G-Ze5HU9b4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=EXS-LbY8YePsIyqnH6vw:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: GmScvfF11d-Vh756WpNSTirfnhZyUMJH X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDA4OSBTYWx0ZWRfX0mbDr/ziGR6w MPJ2nDM61S/JACpQWRzG/MsrFR/SFP8JO0dQ/cRUMcqodTZ06LVdy4Ei2oFTHb8mjQTeVtfhiqk dJwP1Du0xGggmqnMoqNZCJnEVb1pCl0= X-Proofpoint-ORIG-GUID: GmScvfF11d-Vh756WpNSTirfnhZyUMJH X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDA4OSBTYWx0ZWRfX/Nsd7o7os70q hlAhZFuiC1W5FwtVxeBKsVX+iN2kAG86ScyivdGdRwN8de7qxEendifFocPa9cJJ6kyUcVSLk9H GGHCLMLbGBep9Sc78rGd5Ynn3ZBhvdUxwPkxEDa6QK72kJVcvKedUv6M4VuObzwib5FC2IH16vw +Nx8f6OycMrKfK2ubQQYeVQxikRPmZFMtKXf3ZCQEQiM/YU0Y/TMig5SxqGVMTncKhT3Gfp0pmW QMWRAsT+bkC2YfN5LYMgGZ6AtaXQKxcXZheDRskiA/m/Nf9RVCqX3KGM0iWAuesn7CuRJUaC9SF e0euVFWMpGjFeQKOG5dIPraEfWMMtJYldnuFNQZtACrbM7U7gy1jhQ4VmxIHdkfyDaCzhJMcrRX Uw14QjC3phSLzU+izQcc3xUk7sgrmA8mHik8JUPYh58i1H4yIFa/6a3xRqgWp++FLjnxqqKtgCR 5GqS8PJriGr5Ldonqtw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_02,2026-06-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 clxscore=1015 spamscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230089 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1782212678721158500 From: Philippe Mathieu-Daud=C3=A9 In order to avoid symbol name clash when building a single binary, rename TCG helpers prefixing with the target name. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Brian Cain Reviewed-by: Pierrick Bouvier Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/hexagon/gen_tcg.h | 2 +- target/hexagon/helper.h | 2 +- target/i386/helper.h | 2 +- target/m68k/helper.h | 2 +- target/microblaze/helper.h | 2 +- target/ppc/helper.h | 2 +- target/sparc/helper.h | 2 +- target/hexagon/op_helper.c | 2 +- target/hexagon/translate.c | 2 +- target/i386/tcg/excp_helper.c | 2 +- target/i386/tcg/translate.c | 2 +- target/m68k/op_helper.c | 2 +- target/m68k/translate.c | 2 +- target/microblaze/op_helper.c | 2 +- target/microblaze/translate.c | 2 +- target/ppc/tcg-excp_helper.c | 2 +- target/ppc/translate.c | 6 +++--- target/sparc/helper.c | 2 +- target/sparc/translate.c | 6 +++--- 19 files changed, 23 insertions(+), 23 deletions(-) diff --git a/target/hexagon/gen_tcg.h b/target/hexagon/gen_tcg.h index 0159e5c2d5f..e9d3aece85d 100644 --- a/target/hexagon/gen_tcg.h +++ b/target/hexagon/gen_tcg.h @@ -1345,7 +1345,7 @@ uiV =3D uiV; \ tcg_gen_movi_tl(hex_gpr[HEX_REG_PC], ctx->pkt.pc); \ TCGv excp =3D tcg_constant_tl(HEX_EVENT_TRAP0); \ - gen_helper_raise_exception(tcg_env, excp); \ + gen_helper_hexagon_raise_exception(tcg_env, excp); \ } while (0) #endif =20 diff --git a/target/hexagon/helper.h b/target/hexagon/helper.h index 64456822bc1..021f9364ad8 100644 --- a/target/hexagon/helper.h +++ b/target/hexagon/helper.h @@ -18,7 +18,7 @@ #include "internal.h" #include "helper_protos_generated.h.inc" =20 -DEF_HELPER_FLAGS_2(raise_exception, TCG_CALL_NO_RETURN, noreturn, env, i32) +DEF_HELPER_FLAGS_2(hexagon_raise_exception, TCG_CALL_NO_RETURN, noreturn, = env, i32) DEF_HELPER_2(commit_store, void, env, int) DEF_HELPER_3(gather_store, void, env, i32, int) DEF_HELPER_1(commit_hvx_stores, void, env) diff --git a/target/i386/helper.h b/target/i386/helper.h index 3f67098f11f..8099c40cc90 100644 --- a/target/i386/helper.h +++ b/target/i386/helper.h @@ -56,7 +56,7 @@ DEF_HELPER_2(syscall, void, env, int) DEF_HELPER_2(sysret, void, env, int) DEF_HELPER_FLAGS_1(pause, TCG_CALL_NO_WG, noreturn, env) DEF_HELPER_FLAGS_3(raise_interrupt, TCG_CALL_NO_WG, noreturn, env, int, in= t) -DEF_HELPER_FLAGS_2(raise_exception, TCG_CALL_NO_WG, noreturn, env, int) +DEF_HELPER_FLAGS_2(x86_raise_exception, TCG_CALL_NO_WG, noreturn, env, int) DEF_HELPER_FLAGS_1(icebp, TCG_CALL_NO_WG, noreturn, env) DEF_HELPER_3(boundw, void, env, tl, int) DEF_HELPER_3(boundl, void, env, tl, int) diff --git a/target/m68k/helper.h b/target/m68k/helper.h index 0bda8f8152d..a76d455cde1 100644 --- a/target/m68k/helper.h +++ b/target/m68k/helper.h @@ -111,7 +111,7 @@ DEF_HELPER_3(set_mac_extu, void, env, i32, i32) DEF_HELPER_2(flush_flags, void, env, i32) DEF_HELPER_2(set_ccr, void, env, i32) DEF_HELPER_FLAGS_1(get_ccr, TCG_CALL_NO_WG_SE, i32, env) -DEF_HELPER_2(raise_exception, noreturn, env, i32) +DEF_HELPER_2(m68k_raise_exception, noreturn, env, i32) =20 DEF_HELPER_FLAGS_3(bfffo_reg, TCG_CALL_NO_RWG_SE, i32, i32, i32, i32) =20 diff --git a/target/microblaze/helper.h b/target/microblaze/helper.h index 1429c1727ef..e589a8422f0 100644 --- a/target/microblaze/helper.h +++ b/target/microblaze/helper.h @@ -1,4 +1,4 @@ -DEF_HELPER_FLAGS_2(raise_exception, TCG_CALL_NO_WG, noreturn, env, i32) +DEF_HELPER_FLAGS_2(microblaze_raise_exception, TCG_CALL_NO_WG, noreturn, e= nv, i32) =20 DEF_HELPER_FLAGS_3(divs, TCG_CALL_NO_WG, i32, env, i32, i32) DEF_HELPER_FLAGS_3(divu, TCG_CALL_NO_WG, i32, env, i32, i32) diff --git a/target/ppc/helper.h b/target/ppc/helper.h index e99c8c824b4..3548af5f1c0 100644 --- a/target/ppc/helper.h +++ b/target/ppc/helper.h @@ -1,5 +1,5 @@ DEF_HELPER_FLAGS_3(raise_exception_err, TCG_CALL_NO_WG, noreturn, env, i32= , i32) -DEF_HELPER_FLAGS_2(raise_exception, TCG_CALL_NO_WG, noreturn, env, i32) +DEF_HELPER_FLAGS_2(ppc_raise_exception, TCG_CALL_NO_WG, noreturn, env, i32) DEF_HELPER_FLAGS_4(TW, TCG_CALL_NO_WG, void, env, tl, tl, i32) #if defined(TARGET_PPC64) DEF_HELPER_FLAGS_4(TD, TCG_CALL_NO_WG, void, env, tl, tl, i32) diff --git a/target/sparc/helper.h b/target/sparc/helper.h index 3a7f7dc1296..6de773445fe 100644 --- a/target/sparc/helper.h +++ b/target/sparc/helper.h @@ -53,7 +53,7 @@ DEF_HELPER_FLAGS_3(fcmpq, TCG_CALL_NO_WG, i32, env, i128,= i128) DEF_HELPER_FLAGS_3(fcmpeq, TCG_CALL_NO_WG, i32, env, i128, i128) DEF_HELPER_FLAGS_3(flcmps, TCG_CALL_NO_RWG_SE, i32, env, f32, f32) DEF_HELPER_FLAGS_3(flcmpd, TCG_CALL_NO_RWG_SE, i32, env, f64, f64) -DEF_HELPER_2(raise_exception, noreturn, env, int) +DEF_HELPER_2(sparc_raise_exception, noreturn, env, int) =20 DEF_HELPER_FLAGS_3(faddd, TCG_CALL_NO_WG, f64, env, f64, f64) DEF_HELPER_FLAGS_3(fsubd, TCG_CALL_NO_WG, f64, env, f64, f64) diff --git a/target/hexagon/op_helper.c b/target/hexagon/op_helper.c index 0a946433644..12656259cc4 100644 --- a/target/hexagon/op_helper.c +++ b/target/hexagon/op_helper.c @@ -47,7 +47,7 @@ G_NORETURN void hexagon_raise_exception_err(CPUHexagonSta= te *env, cpu_loop_exit_restore(cs, pc); } =20 -G_NORETURN void HELPER(raise_exception)(CPUHexagonState *env, uint32_t exc= p) +G_NORETURN void HELPER(hexagon_raise_exception)(CPUHexagonState *env, uint= 32_t excp) { hexagon_raise_exception_err(env, excp, 0); } diff --git a/target/hexagon/translate.c b/target/hexagon/translate.c index 0b9337d9120..5f584accb05 100644 --- a/target/hexagon/translate.c +++ b/target/hexagon/translate.c @@ -119,7 +119,7 @@ intptr_t ctx_tmp_vreg_off(DisasContext *ctx, int regnum, =20 static void gen_exception_raw(int excp) { - gen_helper_raise_exception(tcg_env, tcg_constant_i32(excp)); + gen_helper_hexagon_raise_exception(tcg_env, tcg_constant_i32(excp)); } =20 static void gen_exec_counters(DisasContext *ctx) diff --git a/target/i386/tcg/excp_helper.c b/target/i386/tcg/excp_helper.c index 1eaa602c91d..a603770084a 100644 --- a/target/i386/tcg/excp_helper.c +++ b/target/i386/tcg/excp_helper.c @@ -32,7 +32,7 @@ G_NORETURN void helper_raise_interrupt(CPUX86State *env, = int intno, raise_interrupt(env, intno, next_eip_addend); } =20 -G_NORETURN void helper_raise_exception(CPUX86State *env, int exception_ind= ex) +G_NORETURN void helper_x86_raise_exception(CPUX86State *env, int exception= _index) { raise_exception(env, exception_index); } diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index 2115c5cd24b..e15a284ab60 100644 --- a/target/i386/tcg/translate.c +++ b/target/i386/tcg/translate.c @@ -1515,7 +1515,7 @@ static void gen_exception(DisasContext *s, int trapno) { gen_update_cc_op(s); gen_update_eip_cur(s); - gen_helper_raise_exception(tcg_env, tcg_constant_i32(trapno)); + gen_helper_x86_raise_exception(tcg_env, tcg_constant_i32(trapno)); s->base.is_jmp =3D DISAS_NORETURN; } =20 diff --git a/target/m68k/op_helper.c b/target/m68k/op_helper.c index 38f7a689814..7e36aed0cb6 100644 --- a/target/m68k/op_helper.c +++ b/target/m68k/op_helper.c @@ -553,7 +553,7 @@ G_NORETURN static void raise_exception(CPUM68KState *en= v, int tt) raise_exception_ra(env, tt, 0); } =20 -void HELPER(raise_exception)(CPUM68KState *env, uint32_t tt) +void HELPER(m68k_raise_exception)(CPUM68KState *env, uint32_t tt) { raise_exception(env, tt); } diff --git a/target/m68k/translate.c b/target/m68k/translate.c index 138c89d3e53..67946c2c20b 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -252,7 +252,7 @@ static void gen_jmp(DisasContext *s, TCGv dest) =20 static void gen_raise_exception(int nr) { - gen_helper_raise_exception(tcg_env, tcg_constant_i32(nr)); + gen_helper_m68k_raise_exception(tcg_env, tcg_constant_i32(nr)); } =20 static void gen_raise_exception_format2(DisasContext *s, int nr, diff --git a/target/microblaze/op_helper.c b/target/microblaze/op_helper.c index 3da0c68da39..488f95de468 100644 --- a/target/microblaze/op_helper.c +++ b/target/microblaze/op_helper.c @@ -62,7 +62,7 @@ uint32_t helper_get(uint32_t id, uint32_t ctrl) return 0xdead0000 | id; } =20 -void helper_raise_exception(CPUMBState *env, uint32_t index) +void helper_microblaze_raise_exception(CPUMBState *env, uint32_t index) { CPUState *cs =3D env_cpu(env); =20 diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index a93f14d6e09..d767217a869 100644 --- a/target/microblaze/translate.c +++ b/target/microblaze/translate.c @@ -100,7 +100,7 @@ static void t_sync_flags(DisasContext *dc) =20 static void gen_raise_exception(DisasContext *dc, uint32_t index) { - gen_helper_raise_exception(tcg_env, tcg_constant_i32(index)); + gen_helper_microblaze_raise_exception(tcg_env, tcg_constant_i32(index)= ); dc->base.is_jmp =3D DISAS_NORETURN; } =20 diff --git a/target/ppc/tcg-excp_helper.c b/target/ppc/tcg-excp_helper.c index b04f07a6377..d71132f0a1f 100644 --- a/target/ppc/tcg-excp_helper.c +++ b/target/ppc/tcg-excp_helper.c @@ -50,7 +50,7 @@ void helper_raise_exception_err(CPUPPCState *env, uint32_= t exception, raise_exception_err_ra(env, exception, error_code, 0); } =20 -void helper_raise_exception(CPUPPCState *env, uint32_t exception) +void helper_ppc_raise_exception(CPUPPCState *env, uint32_t exception) { raise_exception_err_ra(env, exception, 0, 0); } diff --git a/target/ppc/translate.c b/target/ppc/translate.c index 3f6d326cef3..d302112840d 100644 --- a/target/ppc/translate.c +++ b/target/ppc/translate.c @@ -334,7 +334,7 @@ static void gen_exception_nip(DisasContext *ctx, uint32= _t excp, =20 gen_update_nip(ctx, nip); t0 =3D tcg_constant_i32(excp); - gen_helper_raise_exception(tcg_env, t0); + gen_helper_ppc_raise_exception(tcg_env, t0); ctx->base.is_jmp =3D DISAS_NORETURN; } =20 @@ -377,8 +377,8 @@ static void gen_debug_exception(DisasContext *ctx, bool= rfi_type) gen_load_spr(t0, SPR_BOOKE_DBSR); tcg_gen_ori_tl(t0, t0, dbsr); gen_store_spr(SPR_BOOKE_DBSR, t0); - gen_helper_raise_exception(tcg_env, - tcg_constant_i32(POWERPC_EXCP_DEBUG)); + gen_helper_ppc_raise_exception(tcg_env, + tcg_constant_i32(POWERPC_EXCP_DEBUG= )); ctx->base.is_jmp =3D DISAS_NORETURN; } else { if (!rfi_type) { /* BookS does not single step rfi type instructio= ns */ diff --git a/target/sparc/helper.c b/target/sparc/helper.c index 8de261b0e30..8667f97a63d 100644 --- a/target/sparc/helper.c +++ b/target/sparc/helper.c @@ -33,7 +33,7 @@ void cpu_raise_exception_ra(CPUSPARCState *env, int tt, u= intptr_t ra) cpu_loop_exit_restore(cs, ra); } =20 -void helper_raise_exception(CPUSPARCState *env, int tt) +void helper_sparc_raise_exception(CPUSPARCState *env, int tt) { CPUState *cs =3D env_cpu(env); =20 diff --git a/target/sparc/translate.c b/target/sparc/translate.c index 3156be6a94c..b47c79e8894 100644 --- a/target/sparc/translate.c +++ b/target/sparc/translate.c @@ -1048,7 +1048,7 @@ static void gen_exception(DisasContext *dc, int which) { finishing_insn(dc); save_state(dc); - gen_helper_raise_exception(tcg_env, tcg_constant_i32(which)); + gen_helper_sparc_raise_exception(tcg_env, tcg_constant_i32(which)); dc->base.is_jmp =3D DISAS_NORETURN; } =20 @@ -2811,7 +2811,7 @@ static bool do_tcc(DisasContext *dc, int cond, int cc, /* Trap always. */ if (cond =3D=3D 8) { save_state(dc); - gen_helper_raise_exception(tcg_env, trap); + gen_helper_sparc_raise_exception(tcg_env, trap); dc->base.is_jmp =3D DISAS_NORETURN; return true; } @@ -5833,7 +5833,7 @@ static void sparc_tr_tb_stop(DisasContextBase *dcbase= , CPUState *cs) if (e->npc % 4 =3D=3D 0) { tcg_gen_movi_tl(cpu_npc, e->npc); } - gen_helper_raise_exception(tcg_env, e->excp); + gen_helper_sparc_raise_exception(tcg_env, e->excp); =20 e_next =3D e->next; g_free(e); --=20 2.53.0 From nobody Sun Jul 26 12:38:41 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1782212675; cv=none; d=zohomail.com; s=zohoarc; b=Yw1y682MZs9P0uyJPn/vwQpYfB/OrJ4TJu9OZAmXiDt/xVNtbVChhfFu57iouhrdjTGmOhoNf28rxBJ09qgp5Ejz9/uLHs+J9tuhS80ayHskIBfbSd5eUtpwNj/I6GMtY9cMGyrflugsVUAnfMfOOPeCCAufmUkPYbxsbNVqMZ0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782212675; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=mt9hRNNgJk3i3fz5G9OTtCem7Hb8V5YHSbytsOw4E2c=; b=G97FWdqKsfIQneRDlEdNmGsVkIYo7eWWRbRZqlyuQ9fgwY22L0id/73IkpnpBzxcpN5qEbQKhENTeTtQuWfN4ARKnKjD1kfdSISpvSMeyQx4lkwJI88dc0ru+Ociz2Bg5mMjYhH4UPJid8fBwvy4axQEje7zwwbO0VyVJ4E9DVE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782212675166199.15104455336518; Tue, 23 Jun 2026 04:04:35 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wbyut-0007Lk-Bu; Tue, 23 Jun 2026 07:03:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wbyu7-0006r9-7p for qemu-devel@nongnu.org; Tue, 23 Jun 2026 07:02:56 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wbyu3-0006BA-39 for qemu-devel@nongnu.org; Tue, 23 Jun 2026 07:02:54 -0400 Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65NAsEQ23655471 for ; Tue, 23 Jun 2026 11:02:49 GMT Received: from mail-oi1-f197.google.com (mail-oi1-f197.google.com [209.85.167.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eypx38kum-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 11:02:49 +0000 (GMT) Received: by mail-oi1-f197.google.com with SMTP id 5614622812f47-48e77e6a63bso1577947b6e.0 for ; Tue, 23 Jun 2026 04:02:49 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49245a69f81sm345689225e9.1.2026.06.23.04.02.46 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 23 Jun 2026 04:02:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mt9hRNNgJk3i3fz5G9OTtCem7Hb8V5YHSbytsOw4E2c=; b=llxsYowWciF6bg1p 0isXQgKIXHdev3o+jsELTOgXbOWEE/LEHy+gf3AEB1n/9O2INAVPgXcrwc4ceIav QEsS3K4mTzMK6LaxH1zrQXUGq4KhR5Eb5u/2WfoRZzQEGYxR1f2pcunQ4J+tamy6 V/7qzJrB+Lm8bqHQ4MdexXLomwkvo4HEgmFcw83AHdq80LOEBD/9H8fG9VHoky/5 ai8SMIEyPJo5ffTenIZTVd3wWL5TGYhHnoys9egTD0s+HdR+n9tMAOuhn55UmdtI Bst0XUK4hhLg8ebJ6gRPJ+AMmIr1FTx0ZlZcZSJuUtvH6gYnAF/MRdm5HnV1ta0m lsYnKw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782212568; x=1782817368; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mt9hRNNgJk3i3fz5G9OTtCem7Hb8V5YHSbytsOw4E2c=; b=VTcRHL9Vxd7JobhuUID2DVLo2gAiu6WNMftPN73p4H0Q59BcrD7MRgtScSEEy9jl/F TLF4Dxu+u9yKTw/8g4YdHwKSxW4zI9Uz4bLwGlfs3rquc2gfn3cJFETA+E26LxnovuL3 BgCBYR0VWPMBBtUFGzUmOun5bmcpCRAzYCjOeKQKcEFXKH9YkkfCWC0KtHnau10jc6Bc Dol+ENDUSifCisBNdOGGQUh6gbQDoeDprfV1wRQlrPZ3GMDmE5ptn91gV2B5FOH3ZlNM w4H9Xq5/L0Mu1nfQkoDevNh+JygaRixEcd5EgJhMaLuBucWtJaO2yyR5gmcbaKXrlC1S OVJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782212568; x=1782817368; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=mt9hRNNgJk3i3fz5G9OTtCem7Hb8V5YHSbytsOw4E2c=; b=iSB763wUdOBpJJhV/xh4kUsQek76WACddfsjnUZTOn5fqcPx4qDp4CYQQMrYQDl9Z2 aUNxbQnlhczLpdHrTDMcetHoz5+FLpB21fQwxy8Vy+c4TkuGrtMKVkVnslGTnXytpsr1 c1PXL4c6znfWVDZJgZdVeCnP4PzRcXVQbjmEuTeEG32JbcrGiPmd1zEDbZluy719HHVV qXYfgSJUnRrcQ6MZYVN2Pyfd2QE04LPFIvotzA4ktmCA6lRURLJ7/PNphjnBqL5CnjWe Co1AAsV9qPFBqBLc5xNb67rVuoQjsCHnsbj88t9IIiIimNx2yVgPGmBLbe4d5d5mF5eX lwxw== X-Gm-Message-State: AOJu0Yx06tf9bm9ill54njprivjkAQfX2pwh+aO5Mxi/7tMlnOGKANBa X3hm4xSvdOublUuCBkkl4Ztvm+qL1+52GKCN0xFUM03Fwy847bDUp8dQL80D0fJcaf/M+TGgJSo YcWMmVsKkTEEh6ZOrv2o42kGAZqKES76MS+H3jlALR8j2rkPHwGqwwQ76H35H2ccljmpb X-Gm-Gg: AfdE7cna864L/z4Mjb5FzZ8shtN3/FWrwx1KfzgoRIZBY6yM7R8ifSwG1i/fv88fCJA 4eMu1vgeJmd6Fe2mnVvof92uWTZwU+ucMPThK+BO8qkbnA6p3xyEC6rKG8l/6D2gNUFR8azo3A5 Dfs3lMTykIDE8P51pc5bSITR4gNiE5a+TsQL4JvXe4JvziDMBRFXJZxEueXOLVmLR/+TMdJIOh+ 3k+Z9R4rJpLP1k9Er8GQPNbNKpHGToNV8w7eYV9K4yw/XNeJtJ+okGLpQ+p0mOmr4u8E5MhiKgu WZDyh+ONGVfjLnXiKUTUZroLLkwnz9QU+eZdEkBYh/cHr3Lothr7rl6Hw6NoMa2zzxPdJRusQ7d kLuCCeHTvDmCDjgCmNW/BcLlTAdfijCvXp5z7MnQZKQuXfMyrCKCB/P6AtnrTJgt/WY93 X-Received: by 2002:a05:6808:318a:b0:485:50e:5899 with SMTP id 5614622812f47-48ee2d407fdmr1892580b6e.2.1782212568464; Tue, 23 Jun 2026 04:02:48 -0700 (PDT) X-Received: by 2002:a05:6808:318a:b0:485:50e:5899 with SMTP id 5614622812f47-48ee2d407fdmr1892556b6e.2.1782212568019; Tue, 23 Jun 2026 04:02:48 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, qemu-riscv@nongnu.org, qemu-ppc@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Brian Cain , Pierrick Bouvier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Song Gao , Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Chao Liu Subject: [RFC PATCH v2 4/4] target/tcg: Rename set_rounding_mode() helpers Date: Tue, 23 Jun 2026 13:02:08 +0200 Message-ID: <20260623110209.26861-5-philmd@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260623110209.26861-1-philmd@oss.qualcomm.com> References: <20260623110209.26861-1-philmd@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=EsfiaycA c=1 sm=1 tr=0 ts=6a3a67d9 cx=c_pps a=WJcna6AvsNCxL/DJwPP1KA==:117 a=4s3hRJSeHn4rkQlkrse1kQ==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=M51BFTxLslgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=wXBZP43g33z9UTFG2cIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=_Y9Zt4tPzoBS9L09Snn2:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: zGw07QRDVnChnhgS9C55hdhZ72ktm7pO X-Proofpoint-GUID: zGw07QRDVnChnhgS9C55hdhZ72ktm7pO X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDA4OSBTYWx0ZWRfX3NLP45+BvpZL WtNBZzbx+2Fm8Q0HvPLhxSuY1udFh9pepMGAqNaXKlp7aFSLE1PgNWEnRdAm3kPF/x4y4Og88ce OKDd2Yq9o7bx2vDtl7z6/EHLAbSGiWw= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDA4OSBTYWx0ZWRfXzHMJHVfcVewK DV/w+jDbUt1Hm557ZcxoArMYalw5usLZLFWVM1a1X9gkLXhGwfDjfEQWJLpO6EMXeLTfrj5pYFl uW/1QJA5KuiXtLyY/OjcRkV2UXxxUDL8MSp9SLXJSO7GM16eht/GekRcJk0JEUNGNd86pOYMtM+ Nk0GtCbForepcHbW1cJkz1/HFYqe8fN/IxipHbzW3+2gjk5DPRgzbYQWkJne24/6hY4YEaJrJ7d Jj0FSAx9/0kF4QjCUiNmJBC98pLvVHPdr2c1DUB7C6nDsWn67B/xRg7mFOVYSnQyHulvKox/KoH czpkDgIkqCuQsFU3IO7dgEJe3XA3Df/wBzaehrxbhxN8wMyeloY7sn60G/RNCa9drXqr8i7fnZl Tx6GucZhZrurSK2pq3j8E3fVs4BKzITVguec5m2LNj+T30hSMSgh/Z16uKPMbaDMh+jLGd2Wqqv jRv3pnT7xd38DVGVmVQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_02,2026-06-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 spamscore=0 adultscore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230089 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=philmd@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1782212676729158500 From: Philippe Mathieu-Daud=C3=A9 In order to avoid symbol name clash when building a single binary, rename TCG helpers prefixing with the target name. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Brian Cain Reviewed-by: Pierrick Bouvier Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis Reviewed-by: Daniel Henrique Barboza --- target/loongarch/tcg/helper.h | 2 +- target/riscv/helper.h | 2 +- target/loongarch/tcg/fpu_helper.c | 2 +- target/riscv/fpu_helper.c | 2 +- target/riscv/translate.c | 2 +- target/loongarch/tcg/insn_trans/trans_fmov.c.inc | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/target/loongarch/tcg/helper.h b/target/loongarch/tcg/helper.h index 35b055eb3bc..154e70c0191 100644 --- a/target/loongarch/tcg/helper.h +++ b/target/loongarch/tcg/helper.h @@ -91,7 +91,7 @@ DEF_HELPER_2(ftint_w_d, i64, env, i64) DEF_HELPER_2(frint_s, i64, env, i64) DEF_HELPER_2(frint_d, i64, env, i64) =20 -DEF_HELPER_FLAGS_1(set_rounding_mode, TCG_CALL_NO_RWG, void, env) +DEF_HELPER_FLAGS_1(loongarch_set_rounding_mode, TCG_CALL_NO_RWG, void, env) =20 DEF_HELPER_1(rdtime_d, i64, env) =20 diff --git a/target/riscv/helper.h b/target/riscv/helper.h index 542b7c264fc..6f46e0d91d4 100644 --- a/target/riscv/helper.h +++ b/target/riscv/helper.h @@ -2,7 +2,7 @@ DEF_HELPER_2(raise_exception, noreturn, env, i32) =20 /* Floating Point - rounding mode */ -DEF_HELPER_FLAGS_2(set_rounding_mode, TCG_CALL_NO_WG, void, env, i32) +DEF_HELPER_FLAGS_2(riscv_set_rounding_mode, TCG_CALL_NO_WG, void, env, i32) DEF_HELPER_FLAGS_2(set_rounding_mode_chkfrm, TCG_CALL_NO_WG, void, env, i3= 2) =20 /* Floating Point - fused */ diff --git a/target/loongarch/tcg/fpu_helper.c b/target/loongarch/tcg/fpu_h= elper.c index fc9c64c20a8..265f608cddd 100644 --- a/target/loongarch/tcg/fpu_helper.c +++ b/target/loongarch/tcg/fpu_helper.c @@ -878,7 +878,7 @@ uint64_t helper_ftint_w_d(CPULoongArchState *env, uint6= 4_t fj) return fd; } =20 -void helper_set_rounding_mode(CPULoongArchState *env) +void helper_loongarch_set_rounding_mode(CPULoongArchState *env) { set_float_rounding_mode(ieee_rm[(env->fcsr0 >> FCSR0_RM) & 0x3], &env->fp_status); diff --git a/target/riscv/fpu_helper.c b/target/riscv/fpu_helper.c index db1475271b6..88261b223cc 100644 --- a/target/riscv/fpu_helper.c +++ b/target/riscv/fpu_helper.c @@ -66,7 +66,7 @@ void riscv_cpu_check_fflags(CPURISCVState *env, FloatExceptionFlags pre_fflag) {} #endif =20 -void helper_set_rounding_mode(CPURISCVState *env, uint32_t rm) +void helper_riscv_set_rounding_mode(CPURISCVState *env, uint32_t rm) { FloatRoundMode softrm; =20 diff --git a/target/riscv/translate.c b/target/riscv/translate.c index 9684dbe7528..d5c3366fd94 100644 --- a/target/riscv/translate.c +++ b/target/riscv/translate.c @@ -759,7 +759,7 @@ static void gen_set_rm(DisasContext *ctx, uint8_t rm) =20 /* The helper may raise ILLEGAL_INSN -- record binv for unwind. */ decode_save_opc(ctx, 0); - gen_helper_set_rounding_mode(tcg_env, tcg_constant_i32(rm)); + gen_helper_riscv_set_rounding_mode(tcg_env, tcg_constant_i32(rm)); } =20 static void gen_set_rm_chkfrm(DisasContext *ctx, uint8_t rm) diff --git a/target/loongarch/tcg/insn_trans/trans_fmov.c.inc b/target/loon= garch/tcg/insn_trans/trans_fmov.c.inc index 5cbd9d3f347..c4c4c2000f7 100644 --- a/target/loongarch/tcg/insn_trans/trans_fmov.c.inc +++ b/target/loongarch/tcg/insn_trans/trans_fmov.c.inc @@ -112,7 +112,7 @@ static bool trans_movgr2fcsr(DisasContext *ctx, arg_mov= gr2fcsr *a) * Note that FCSR3 is exactly the rounding mode field. */ if (mask & FCSR0_M3) { - gen_helper_set_rounding_mode(tcg_env); + gen_helper_loongarch_set_rounding_mode(tcg_env); } return true; } --=20 2.53.0