From nobody Sun Jul 26 12:31:36 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oracle.com ARC-Seal: i=1; a=rsa-sha256; t=1782176335; cv=none; d=zohomail.com; s=zohoarc; b=DfF/6KfjeXN7hG8j7Pjat9F36E0g1KYVriEZiK5So+xw9QIkktQbdZEMZTcUS8m8K/8IIU1yGkfZHeU9FF20TTC7+dZKvMDoW2mEyWVK6GcvLbvCe1dLGQqujHHLWE83V/F+QnasKNOngSbZh0Si6iZnvsF5i3ZhU+vP5icLTA0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782176335; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ecBaROlmlbeci3rICs6iQcT5eWieO19NCqj+PXf6JM0=; b=niskLMrbhLk5452LX0LR2OW7k4HJ48Ef335UyyGVko33zntz06MpNKbrfZOlXLB7lIK1kkL5zlOD3pwjOvcKsuyGuHtAYaTNimCzSaoOX5eeGDbxyWNgj24Ic9uU6yBOE6eVKL9OlppYbvGLODbx+G2T0IpYwNfO22c8mxRNJ8k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782176335882555.0610874577317; Mon, 22 Jun 2026 17:58:55 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wbpT6-000733-Hr; Mon, 22 Jun 2026 20:58:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wbpT4-00072m-RL for qemu-devel@nongnu.org; Mon, 22 Jun 2026 20:58:22 -0400 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wbpT2-0000Fv-Vr for qemu-devel@nongnu.org; Mon, 22 Jun 2026 20:58:22 -0400 Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65MNcMBR2914087; Tue, 23 Jun 2026 00:58:17 GMT Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4ewjwcaux6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 23 Jun 2026 00:58:17 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.7/8.18.1.7) with ESMTP id 65N0w8Th019650; Tue, 23 Jun 2026 00:58:15 GMT Received: from pps.reinject (localhost [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 4ewhabf3tf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 23 Jun 2026 00:58:15 +0000 (GMT) Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.1.12) with ESMTP id 65N0wE2f020136; Tue, 23 Jun 2026 00:58:15 GMT Received: from alaljime-e5-test-20240903-1847.osdevelopmeniad.oraclevcn.com (alaljime-e5-test-20240903-1847.allregionaliads.osdevelopmeniad.oraclevcn.com [100.100.250.206]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 4ewhabf3sw-2; Tue, 23 Jun 2026 00:58:15 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=ecBaR Olmlbeci3rICs6iQcT5eWieO19NCqj+PXf6JM0=; b=TWZg5RfHiZOZZuhWhJf53 yZiMVJBTClYXhEIHtQUcZHd6QQ8gqADBztvquGDrEMwa0FS3tRCf5pdrNlOVN9Fj 8FEN/edsacLic2nMKKql1USVDFU1EsPHb1cMvACrVZ9gyNFb9Dsvos4wMD2zNDq4 MyJYLP4NdBaiZ1z4KWx2wnFsu1pae6SIIVeimZZ0RNAYcdsAStuK62YE2+dgwy3I 1VYu19LjSSEdLvci9uTdvtspQipA3o7E+8M1nKknFW3hNtdGbP1NXNn7DBSQFdY3 suaNYM0nVMoPf+Qbda/h4OrzSXVViRVLEFrcPECgwrYBV/szEZ7XQK+Ioc4v+X1Y Q== From: Alejandro Jimenez To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, mst@redhat.com, sarunkod@amd.com, pbonzini@redhat.com, richard.henderson@linaro.org, alejandro.j.jimenez@oracle.com Subject: [PATCH 1/2] amd_iommu: Return int from page walk status helpers Date: Tue, 23 Jun 2026 00:58:12 +0000 Message-ID: <20260623005813.984238-2-alejandro.j.jimenez@oracle.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260623005813.984238-1-alejandro.j.jimenez@oracle.com> References: <20260623005813.984238-1-alejandro.j.jimenez@oracle.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_01,2026-06-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 malwarescore=0 mlxlogscore=999 adultscore=0 lowpriorityscore=0 suspectscore=0 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2606160000 definitions=main-2606230005 X-Authority-Analysis: v=2.4 cv=eJAjSnp1 c=1 sm=1 tr=0 ts=6a39da29 cx=c_pps a=XiAAW1AwiKB2Y8Wsi+sD2Q==:117 a=XiAAW1AwiKB2Y8Wsi+sD2Q==:17 a=FelO9ux0wxsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=jiCTI4zE5U7BLdzWsZGv:22 a=BqU2WV_vvsyTyxaotp0D:22 a=KKAkSRfTAAAA:8 a=yPCof4ZbAAAA:8 a=CPMDAz_8QbydQVlharwA:9 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: ZbjR4IphGysyOE-i6nxsWlxQQbiemu7D X-Proofpoint-GUID: ZbjR4IphGysyOE-i6nxsWlxQQbiemu7D X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDAwNSBTYWx0ZWRfX45DtrS7ZJsnn ckck9KugenhRlLBs8hjGn6HwUOalsbmvm9hM4WaUzP253OyLemAQaTMbX0ZWH9U8+Q64NyqOiPw 5IijVFcCnKkkwfwTJMBavu33v4E+vDUKdBRA2Esk11n1UZbemWiN1gDDc1+IINIHdf0QXAxBFpA Xw8//s1HgIz+7OFlPXGeOF50fPjkVf7oEM3ccEJR4jMGj9zg9PaoezPiVyQHVT6dcTjS+/e6sR6 ayfuINpPuShTIlat3lnyLQ8QShFSxTOecP9zJ7SW4IoGjxV91aApaJAjADie0ENqCYx2jCp7wKt wpQIF1m+51rGfa7Wck0auU+EByUrC1/vLGdHADUD++sMPhp+r+CEKuGnFEKZwzAZrf6kcBExu6p 6kkOneZ9YuU/NBvGIePHRckvtGxWHOz5x0mi9qjzegG09NrqJBd9g0k6H+pG6AfHzkVdXXCwOd2 FN0hMzqZPzNbD9C+J5w== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDAwNSBTYWx0ZWRfXx9NefimD1llM 7VVpYgE/196RyhYkKff+OTxtkMOduFaJjH/TzGDemBWR8rrMqvBrWJTQ+xNOp0UprrqXKbeBLui 8LbW+Id+DjadCu0d8TmdA+k+5LLVMmLw3DYvcKkDiQcHKKowXBym Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.177.32; envelope-from=alejandro.j.jimenez@oracle.com; helo=mx0b-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @oracle.com) X-ZM-MESSAGEID: 1782176337968158500 Content-Type: text/plain; charset="utf-8" fetch_pte() returns a status code 0 on success, and (small) negative values on failure. The PTE value itself is returned via an output parameter. amdvi_get_top_pt_level_and_perms() follows the same return convention. Both functions currently return uint64_t, which means any negative error values are returned as unsigned and then converted back to int by the callers. This does not cause any issues in the current implementation, but Coverity flags the type mismatch and potential overflow. Make both helpers return int, so the type matches what the return variable is (0 on success, small negative value on failure), and also the type used by all callers to store their return values. No functional changes are intended. Fixes: a1c97c395729 ("amd_iommu: Sync shadow page tables on page invalidati= on") Fixes: 786550e2d38a ("amd_iommu: Follow root pointer before page walk and u= se 1-based levels") Reported-by: Peter Maydell Suggested-by: Peter Maydell Signed-off-by: Alejandro Jimenez Reviewed-by: Peter Maydell --- hw/i386/amd_iommu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c index 79216fb305..0d273fd33d 100644 --- a/hw/i386/amd_iommu.c +++ b/hw/i386/amd_iommu.c @@ -659,7 +659,7 @@ static uint64_t large_pte_page_size(uint64_t pte) * - IOVA exceeds the address width supported by DTE[Mode] * In all such cases a page walk must be aborted. */ -static uint64_t amdvi_get_top_pt_level_and_perms(hwaddr address, uint64_t = dte, +static int amdvi_get_top_pt_level_and_perms(hwaddr address, uint64_t dte, uint8_t *top_level, IOMMUAccessFlags *dte_per= ms) { @@ -702,7 +702,7 @@ static uint64_t amdvi_get_top_pt_level_and_perms(hwaddr= address, uint64_t dte, * page table walk. This means that the DTE has valid data, but one o= f the * lower level entries in the Page Table could not be read. */ -static uint64_t fetch_pte(AMDVIAddressSpace *as, hwaddr address, uint64_t = dte, +static int fetch_pte(AMDVIAddressSpace *as, hwaddr address, uint64_t dte, uint64_t *pte, hwaddr *page_size) { uint64_t pte_addr; --=20 2.47.3 From nobody Sun Jul 26 12:31:36 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oracle.com ARC-Seal: i=1; a=rsa-sha256; t=1782176335; cv=none; d=zohomail.com; s=zohoarc; b=mvzuh8CDPosuH0nqB06dvdV9uWtJjVb91vuaKz5dmpVruRvprzcbU4DjZloOjqwIZlpc5wPlV7eC81BcndhUZNOEqwAmUxUuFoHE3OQYMZyZ4nh2u0TBNqtjWktUcYNZnSc06t8Magv9UYsPXfYSGngUNcfZIInRcW+JuIXZqH4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782176335; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=XdyZL9InpYfdWUQvoJHCmXG8ywa9eHGT1ACC3mVVO/U=; b=ZDqEkIlBjCs75sb6M/DzwUQ0T7x8YuVqiGj0bCzMVNytkRSA6JjHlLHOYqas1PQ267Fn1QxB9v1Ah+DfXszpLT2Rc9uRMJfHuLDv3dGR3aonqrw874NnbOpYYAW+fb+BqGitBrV6popVbYdVY+vNTCbHNAg9j4ne956dyeQOcOk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782176335562737.9016324621922; Mon, 22 Jun 2026 17:58:55 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wbpT7-00073W-7g; Mon, 22 Jun 2026 20:58:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wbpT5-00072t-5j for qemu-devel@nongnu.org; Mon, 22 Jun 2026 20:58:23 -0400 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wbpT3-0000G9-Do for qemu-devel@nongnu.org; Mon, 22 Jun 2026 20:58:22 -0400 Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65MEJwit1818489; Tue, 23 Jun 2026 00:58:18 GMT Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4ewjfuauav-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 23 Jun 2026 00:58:17 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.7/8.18.1.7) with ESMTP id 65N0w85k019632; Tue, 23 Jun 2026 00:58:16 GMT Received: from pps.reinject (localhost [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 4ewhabf3ts-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 23 Jun 2026 00:58:16 +0000 (GMT) Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.1.12) with ESMTP id 65N0wE2h020136; Tue, 23 Jun 2026 00:58:16 GMT Received: from alaljime-e5-test-20240903-1847.osdevelopmeniad.oraclevcn.com (alaljime-e5-test-20240903-1847.allregionaliads.osdevelopmeniad.oraclevcn.com [100.100.250.206]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTP id 4ewhabf3sw-3; Tue, 23 Jun 2026 00:58:16 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=corp-2025-04-25; bh=XdyZL 9InpYfdWUQvoJHCmXG8ywa9eHGT1ACC3mVVO/U=; b=aa2SNSIDcHEvcrvnQxeNL 3Yq9tBr+xthc2UHLn9rk+DPxy1DZpgI4tfN+lvvDc7F12eApIMSSo+oFptIQUr8F ZCcr/JiFKlMaaj94JbS5iZoyOeQ8V+QiGvOGhOI9yEwTg81vyrU70qngna7HEX89 GEuoTqGqAdYstXz6vXKZ5NCec356ZogouGc/s0lexm9nISHGOW0YI3mjFQ7O53Te rTQQozq80avIDmVjZpaMWqxhU0Q9SSd+n24fpvQxwnT+/qEnJ03A+4KnxjT8cKRP wwL7ZDmW700BTAIPlxpuAvZY+gKxx/1/TBeAI7Ikk3+S4isAjBycSG0CZoc/RkuP g== From: Alejandro Jimenez To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, mst@redhat.com, sarunkod@amd.com, pbonzini@redhat.com, richard.henderson@linaro.org, alejandro.j.jimenez@oracle.com Subject: [PATCH 2/2] amd_iommu: Fully initialize XT interrupt message state Date: Tue, 23 Jun 2026 00:58:13 +0000 Message-ID: <20260623005813.984238-3-alejandro.j.jimenez@oracle.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260623005813.984238-1-alejandro.j.jimenez@oracle.com> References: <20260623005813.984238-1-alejandro.j.jimenez@oracle.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_01,2026-06-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 malwarescore=0 mlxlogscore=999 adultscore=0 lowpriorityscore=0 suspectscore=0 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2606160000 definitions=main-2606230005 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDAwNSBTYWx0ZWRfX9TB7Or9CSNoD 6d9JExfpF2AW/4cqG687qQZQnMRsHfnA+rGgQgDf4DgDmQItgATii1Plepxot3p6EIzN37RgfR0 yf+dOdARewyenF+17jGnoMKnkGTOPEd6u49cXGQfCLJhl7rW0c7x X-Authority-Analysis: v=2.4 cv=FtI1OWrq c=1 sm=1 tr=0 ts=6a39da29 cx=c_pps a=XiAAW1AwiKB2Y8Wsi+sD2Q==:117 a=XiAAW1AwiKB2Y8Wsi+sD2Q==:17 a=FelO9ux0wxsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=jiCTI4zE5U7BLdzWsZGv:22 a=3I1J8UUJPc9JN9BFgKH3:22 a=KKAkSRfTAAAA:8 a=yPCof4ZbAAAA:8 a=ip2sIQfbet0upOwJyiYA:9 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: H73TUC9U6JgLAR9w0s0LzpyNHkWZEH19 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDAwNSBTYWx0ZWRfX4V+SLNlYgfjC ApEPmT3O2Ed73tteZN0WhCnvhV561XpTtZrIjiSzrikkDlhLTgOx9Vkpfgdgbm5eUplPtERlkzH 2Mp1+0H3SSpR305VnU+WE2K1FL9E1NCyEoiCk16KYNrB2r2tNyThqQZkP+5vu66G1qmWGEw3JXU FTrT7DXS7e3nGPDf6ynJ2cOXyJYT4yXh4g6rvj+gRtV4pLII++2SOS6rS037MQBaQWejbBZcP1s srKgTVdsGgB5fI3KKKOaY+y4BsY4e3yI5lnnqIHvoVmrpPLVr0tUli5HSPhapyfzKBklgKGhnd3 sDTc2iCbcaCuAu5yC47P/9s2wmLV88l+2JFFALmBOQB4vmL+eIoxy7MZ2jxyLFB6ShOWDHdJz9y N8Z0VBfsuQiXgiWujcxw97FXzl+1ypYwonGwi6XGixTqw7sFgrHoXGtTLUf+XErYtmBOBR7C9/Y 5WtWEBa252mWbd1Rvug== X-Proofpoint-GUID: H73TUC9U6JgLAR9w0s0LzpyNHkWZEH19 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.177.32; envelope-from=alejandro.j.jimenez@oracle.com; helo=mx0b-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @oracle.com) X-ZM-MESSAGEID: 1782176337964158500 Content-Type: text/plain; charset="utf-8" When IOMMU x2APIC interrupts generation (IntCapXTEn) is enabled, amdvi_build_xt_msi_msg() builds an MSI message using the relevant values in the XT IOMMU General Interrupt Control Register. Initialize the local X86IOMMUIrq structure with zero for all fields. This ensures that X86IOMMUIrq fields not set in the XT register (e.g. msi_addr_last_bits) are initialized before x86_iommu_irq_to_msi_message() consumes them. Remove the redundant 'struct' keyword in X86IOMMUIrq irq declaration. CID: 1660056 Fixes: cf0210df65aa ("amd_iommu: Generate XT interrupts when xt support is = enabled") Reported-by: Peter Maydell Suggested-by: Peter Maydell Signed-off-by: Alejandro Jimenez Reviewed-by: Peter Maydell --- hw/i386/amd_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/amd_iommu.c b/hw/i386/amd_iommu.c index 0d273fd33d..9005dc7aab 100644 --- a/hw/i386/amd_iommu.c +++ b/hw/i386/amd_iommu.c @@ -195,7 +195,7 @@ static void amdvi_assign_andq(AMDVIState *s, hwaddr add= r, uint64_t val) static void amdvi_build_xt_msi_msg(AMDVIState *s, MSIMessage *msg) { union mmio_xt_intr xt_reg; - struct X86IOMMUIrq irq; + X86IOMMUIrq irq =3D { 0 }; =20 xt_reg.val =3D amdvi_readq(s, AMDVI_MMIO_XT_GEN_INTR); =20 --=20 2.47.3