From nobody Sun Jul 26 12:32:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1782147140; cv=none; d=zohomail.com; s=zohoarc; b=gCoJNgJUFFI5b+tsMJtvutBT0sxHn5WjtRwl9bQBVX1iy0rqisBfKfh4ZSAO1NeTiQaMd81NLSE5wtHPStKDO9Gf8ftzjRTjNvHVw6zt3V0y1GxnbmK9QKLX+Pvk6hKfu4fyfkDnFNhD5UkbHokGi6asfU9QqVQjK3rio81/mRM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782147140; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Sender:Subject:Subject:To:To:Message-Id; bh=vvGh1Fi8yuiwE9WweaeNP29HhcXZ3nO6ZN3T/xstPFw=; b=JJFwmg08o+tWsuCcV/krSyamAX5pwAVbeLJ+dCwuN0XY2+GDWnp1VvRZ/kOvkZF9UlyxI1Ue8I741g787UGD9DQfbvja82p3QCSkR27co/RhVa+wwywlYjBbxXDpOBwv8dYIwqcPn37R4UFSjMp1+fVFLcbVHK9nmNPT1gq6Yow= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782147140146612.219036098525; Mon, 22 Jun 2026 09:52:20 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wbhrt-0004aa-Q4; Mon, 22 Jun 2026 12:51:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wbhQe-00064G-Vs; Mon, 22 Jun 2026 12:23:21 -0400 Received: from hades.hosts.managarm.org ([195.201.36.94]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wbhQd-0005Zr-DP; Mon, 22 Jun 2026 12:23:20 -0400 Received: from white.localdomain (pd9f9de93.dip0.t-ipconnect.de [217.249.222.147]) by hades.hosts.managarm.org (Postfix) with ESMTPSA id 6F9493EE10; Mon, 22 Jun 2026 16:23:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=managarm.org; s=2021; t=1782145395; bh=vb3PPKd8GLEVktpJWW33N1oTIWMJIZxE8aXOWrtXRAA=; h=From:To:Cc:Subject:Date:From; b=s6eV/1D6QzLga4kt6VT8elOrMvAAjXsshP/8/nYKq8k8uwiFjcbqE+wNDkIVPoy2g fDawpsVIApGaRCJjBKLfw7heV4U2FKeSe3NGtbfrbQ8WE9sPxujDcoAwcYDwPWG9V3 61xJkmJ9sqByg4muzn9++lZTCbW/Sa8O8RTnQ4JaW8Ycf8GKFJolLtFdJBMm4ggRkO pfP8uRrDJbOoJTL+JfL/2vkqXJnHI4VT5jHALqMWXECYOmPUf53dVjPVbTl3RiCvV9 dqsp/9wejb1KlbxKnjpxUvVfRtbsVrHM3t5Y6LyQu+E+DLoAojJoeozcuebXAtQ4jP l5409OAL3cZ8w== To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, qemu-stable@nongnu.org, no92 , "Michael S. Tsirkin" , Jason Wang , Yi Liu , =?UTF-8?q?Cl=C3=A9ment=20Mathieu--Drif?= , Paolo Bonzini , Richard Henderson Subject: [PATCH] hw/i386/x86-iommu: Correctly set pt bit in extended capability register Date: Mon, 22 Jun 2026 18:21:37 +0200 Message-ID: <20260622162138.1045170-1-leo@managarm.org> X-Mailer: git-send-email 2.54.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=195.201.36.94; envelope-from=leo@managarm.org; helo=hades.hosts.managarm.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 22 Jun 2026 12:51:06 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: no92 From: no92 via qemu development Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1782147141985158500 Content-Type: text/plain; charset="utf-8" With the changes in c7b2e22bd957, the `pt` bit was set in the (wrong) capability register, instead of the (correct) extended capability register. Fixes: c7b2e22bd95710e404c393e9f563cfe7404220c1 ("hw/i386/x86-iommu: Remove= X86IOMMUState::pt_supported field") Signed-off-by: no92 Reviewed-by: Clement Mathieu--Drif Reviewed-by: Yi Liu --- hw/i386/intel_iommu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c index 744cdfd2e6..d1af7a3135 100644 --- a/hw/i386/intel_iommu.c +++ b/hw/i386/intel_iommu.c @@ -4988,7 +4988,7 @@ static void vtd_cap_init(IntelIOMMUState *s) { X86IOMMUState *x86_iommu =3D X86_IOMMU_DEVICE(s); =20 - s->cap =3D VTD_CAP_FRO | VTD_CAP_NFR | VTD_CAP_ND | VTD_ECAP_PT | + s->cap =3D VTD_CAP_FRO | VTD_CAP_NFR | VTD_CAP_ND | VTD_CAP_MAMV | VTD_CAP_PSI | VTD_CAP_SSLPS | VTD_CAP_DRAIN | VTD_CAP_ESRTPS | VTD_CAP_MGAW(s->aw_bits); if (x86_iommu->dma_translation) { @@ -4999,7 +4999,7 @@ static void vtd_cap_init(IntelIOMMUState *s) s->cap |=3D VTD_CAP_SAGAW_48bit; } } - s->ecap =3D VTD_ECAP_QI | VTD_ECAP_IRO; + s->ecap =3D VTD_ECAP_QI | VTD_ECAP_IRO | VTD_ECAP_PT; =20 if (x86_iommu_ir_supported(x86_iommu)) { s->ecap |=3D VTD_ECAP_IR | VTD_ECAP_MHMV; --=20 2.54.0