From nobody Tue Jun 30 07:34:11 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1782127571; cv=pass; d=zohomail.com; s=zohoarc; b=Q6JQRJnegGZMtFhZyveFjPRW41HTYtwxk4NzAwqJ+jvneBLjap8Jlz+4lzyZ6/sk1PPVK+WgdggEdSqeSxvCPycgpLI3vlKCUA3TVtS8xxpGrL2jQ1JJoBJaD4nputCyobKKob5gs6+SBiLo6T9VK+wvLGI2jWfbu2Q598+pLzk= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782127571; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=dR3+N2aw9U9kf+VthbZifqsWgG2Xp8bM7rKKEjNgm3c=; b=KgOD5FmvKmeEG3Rqv6c/rLWjeO3GJDSpqZsl2HhY611emKAV64e6WCVMDaX651enO+a42NT4R4G3MAciiDaKkc/uk/OfOnvP9gLCFOckhPIHbgW35X/8+IcQSLgFgNCZM8rwC9IkNXVPbs0tJarj5Ru3lsOAfzUoAc//3iTu1ig= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782127571437232.05963369793392; Mon, 22 Jun 2026 04:26:11 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wbclz-0004RL-Pv; Mon, 22 Jun 2026 07:25:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wbclj-0004J1-Mi; Mon, 22 Jun 2026 07:24:48 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wbclP-0001RB-4Z; Mon, 22 Jun 2026 07:24:44 -0400 Received: from pps.filterd (m0127841.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65MAoYHt023037; Mon, 22 Jun 2026 04:24:12 -0700 Received: from bl2pr02cu003.outbound.protection.outlook.com (mail-eastusazon11021112.outbound.protection.outlook.com [52.101.52.112]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 4ewrd8ujb7-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 22 Jun 2026 04:24:12 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by DS0PR02MB10661.namprd02.prod.outlook.com (2603:10b6:8:1f8::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.139.20; Mon, 22 Jun 2026 11:24:11 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%3]) with mapi id 15.21.0139.009; Mon, 22 Jun 2026 11:24:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=dR3+N2aw9U9kf+VthbZifqsWgG2Xp8bM7rKKEjNgm 3c=; b=UPHl0mv0zA6C/s/4buT0V8W1y7seoQ12vea3uh991MYTIyU95Mr0vlb4/ 6QQMLgl7YV1NnCYKpn+UYMDu199GbBV+ZNJrDAjQndnLUwPfv7v1nwjMJTLlB/ZS V/OstkYGwH5Zg563SI0NPZV0j14U0XJHCRq/+McYWUat2C40878v4xSWKC1TWtqh RvTQatrdUG5paxNTIwZyCy8rN03roPNFv21pUHytFSyH8fG2pYxCVXPWGtwHcz+c BoXfZEqi5E+Flb1iMoSzkiKSGzG0OFqWdDZ7gdkAql3AV5gJeCAyFi17ab6zfna9 x8upVeQAqyx0/srdLIWXcy4FwvH3g== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rHOvJRCAxrogCGgk6DtItS45XZ5j+bMnA6GwxMyI6wiR43nDWwEsCeHyMAvAFzot9d+JZyx2KW9oAhyVgiJpzCMx7xMz80uE+0I1POJZLTLiY2rHt+i9wU1c7yyIqVodUtHi2AOTHIiZoFKE4qn18udf8FITk+m2LD4WW08QL3e+Q1dirV7xU9wBk4bgJyFy/DVDbXjJUUV2nrHl1EAs9MJAN1nU2+kVA/Mj3Um+8mxjdNpg9s8zcJFQ8cr4gsVgBxGCSrgJG47IHiLy2iSomGXP6XC8UhJOJslUKk+6hdt/WCmB2mW/hetRLMDHAymdnV1Yp6OVIt9EPW4/7dGV2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dR3+N2aw9U9kf+VthbZifqsWgG2Xp8bM7rKKEjNgm3c=; b=qevNYJI0tCbkjQfxz+RArcWY4at/7Q9smVSXfxOeYqxXdAZ7mmAt6lSXxnvoYoClH+QfRyOeUHKL2jeYflSYf45zXtjgsTi9OPHAjqTL96jV3MCx6CByjF4h1Zmqv7VgjplFORLxNq9DIZ5cO9CyaIEpWLsgdkXaezNN+/OGBLThtgc75EocZEc7THmK6fQPJ+4zkar1YBKO+aC6b8pJD578a02MUiiXSF6MzuekgoQgge2LUn1JFTq4WlrDLzXOZzfkueccjmmfEHrtD9ajalm/p6HGSnHd9+LhTKDgtY0Cww/jDGDFACIj0dtZFFv+xeNuHT23zK34Q4oOV+jAHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dR3+N2aw9U9kf+VthbZifqsWgG2Xp8bM7rKKEjNgm3c=; b=cWpyan/xEC9n8h00rgkEIhhhy6b1EnNBe9yr7wzL2CeVK7TQD8CDWYye/anSv2OG8KudkUaTEXyBvVaPcfF4Tfzvzo4F87kEyiUF6bdINIvWqNuKG0ikLrW0GWT2WQKM9XcVWZQqPZQRJjZHtivGNUcIXyGbvcwoqdidhSAFKjPpGc7mX9BS/c00c/eVCkgtRkAkEETYmRDLZJgfr7prPsDJB+R6iXoYk4/opNm2wjigiyAAEmBlQMQSFJ5e/wB57wLetuHH8ByRszH9A3fssa5+gYy3+R3kiHFmxLCzAacxlINN4Vph4FULZW1By1ap9Ic5Fi0eqAdZTCA0bLn3Sg== From: Mark Cave-Ayland To: mst@redhat.com, imammedo@redhat.com, anisinha@redhat.com, philmd@mailo.com, aurelien@aurel32.net, peter.maydell@linaro.org, pbonzini@redhat.com, richard.henderson@linaro.org, qemu-devel@nongnu.org, qemu-arm@nongnu.org Subject: [PATCH 1/7] hw/acpi/ich9.c: move initial property values into ich9_reset_properties() Date: Mon, 22 Jun 2026 12:22:33 +0100 Message-ID: <20260622112403.928954-2-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260622112403.928954-1-mark.caveayland@nutanix.com> References: <20260622112403.928954-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: CY8P222CA0014.NAMP222.PROD.OUTLOOK.COM (2603:10b6:930:6b::16) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|DS0PR02MB10661:EE_ X-MS-Office365-Filtering-Correlation-Id: a2fa342e-f881-4c49-2892-08ded050c81a x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|7416014|376014|23010399003|1800799024|22082099003|18002099003|56012099006|921020; X-Microsoft-Antispam-Message-Info: vVoZ+xUacH7gEjEgFTXXlYbn/8y4bHjJrImj5p1XuRVFlOBnPERRPry2nHG8yHX341Q+kxsh4eTT+Cjs1sbEtHQ8MIARXtXS2MvvgpcrmgEYGrJwKCaUH8PZLJ9LAknbmo/5/C6ycwGlHh+q2frNR6HGwvDm1UzmgseJEAWMZpwu1e/ayU42hsX7bb3qGsR0VX0uTrW5VSnFjGal4Xx44n0qHTK6YS0f+YAFbuNuWly5JJi3m9PJohkEwz9oATy7ADGl3PuuedBydwZSTxt5ykoNNmqTM1OO4L3OoJ6pQKfbQMQhJwLBzoMZw0bjXCq+/njK8jrOFyWd9DmoTP1cgQl9QdNWV10c5PXG/VJUtuMkPlwzDDztobTqCN/TwB0iI9PHJgnUdclOIe4lCwxUd880t2/H32s2MD0Eg5lE86073yNaksNzUWhU3NlP4nbLQTqeJWkoAdTf3UpZtuyRDs7BNLsChYIGfLH17J1r7KQcANmUHD3FG9TNgXQLfsaE7l/Brb3YhHuh4xM8Y18XLGk+2xlAtBMUqdWYUDVpidJVCjj2XCe2KQpI/byRJvVVido0gZfhrMufaEsQRZw/60AgoWhO25M1v3AlGw3G/Vg+D9FZ4mfD9nDW8Wto/2Iv1hm0EKSMi45YKjqFo9lbnnpq0fALS4rN+W7SModNR54zcuIV5AC0mD6FObIjvuJyDdyLGIneVElEpwuUXo4AQw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(7416014)(376014)(23010399003)(1800799024)(22082099003)(18002099003)(56012099006)(921020); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?w4MZvQuTNoRO4J2PtqUectbC19HUBAflXtZ+lw6VwIjVAOuFUi83yqHVQs56?= =?us-ascii?Q?vkv/bq6fE7llpy6zWTzXjGH4RzbAJR02osNdE2iv391YQEKg9Pew5Cu1rfgW?= =?us-ascii?Q?baWTrQdsxfX86H8Pmu+3DK58fGNTzrAhjUN4Ldd8Yq0+5A4+OUqlrboALcx3?= =?us-ascii?Q?tocz9c80ffVW/TwIgvZ1FtcBZQngVFFfyeBE2DAgW2RRaiIBfueNlY6bQYE1?= =?us-ascii?Q?lYK7ikvHbz7WBXpMF82Lq4O7MakODjyeQjVAQkNPQsYTL4WTJ7sbaAUKPV3p?= =?us-ascii?Q?oYtPQI/Pk1dDbhppHrodIsjwP18Y+VPOAqrJOaeUy8VN1IL6hnOPJAQtFY26?= =?us-ascii?Q?G2bgDtA6iYV9YXaBguktXdxHkoJYJMrzbhcuFBCfj+eO8VG8ZNopI24ymyy0?= =?us-ascii?Q?8Rx7eM8D8QCt5/nKPp6ptlwBug9/69QGWZGbjjEuHx8aTxqT6am6h94viQTT?= =?us-ascii?Q?Mous0bq6qVBn8DiFxT6M/QDv/GpTkn/wVxXLNrfzsvaHxq0cztuoA+ZAnLAQ?= =?us-ascii?Q?qIhG2gn6NiHdEhnwhPw//7zDcQ9nZuyweQd+GMCrfiAvmhvfMPO/MBWjEx9S?= =?us-ascii?Q?Vu2c3UTDlx1KME2H9kkz5M59zHEDZG1S6mgmhRwOiyXKIxTUvqhOzVdMb8Ry?= =?us-ascii?Q?6pARHfAqEV2hodNZQzZo245iPCV+v0gYW8B/ugb9pGdArKBGtf5Tqbo4OqEJ?= =?us-ascii?Q?ZnbZF5Evf+CDCGK+RItEewjy2HyDJKZRik7xIfDsDdM5HpXj65/uYq8j8vOS?= =?us-ascii?Q?ShKK6kHRtoA2Ux9YsXaUMWRkS8AFgwzcmYjlaYLMoEAeTVccKtfzekbZKyxr?= =?us-ascii?Q?HGdlAGQoRwxcXwl/1CB35ubOurDbtzKp2VHktWa32kolgq3r+whJ1i7t/wec?= =?us-ascii?Q?E5T1szRFay8uwFZLRoxnYF9wLeJpUT1T9w6jsFWkdtxbXb727kML7l5nAE3t?= =?us-ascii?Q?OOXzQemCbopS3uQi+S52NtVLr4oU9LS3HuwRmkAEuTzBaNt3kMzArxf7lPXK?= =?us-ascii?Q?F8fqSezR/jFY4uVwaWNQV4SzDmDpyMyrbJioVsFde7CyBR95JBJlPvmZufSZ?= =?us-ascii?Q?y+PJlKD55P8C4Yr/tODGfuWo26/uelHvrCXgJW0ZCmCaK/IBIc9xZ1j51V2y?= =?us-ascii?Q?8bmk5tQF3ueUCkukcjJeZz6Jlkumbw4qe/urupID2DsO7hOujgxGhuU54tSp?= =?us-ascii?Q?fn5ckuEh2wRpahLod3fjz6U/qvjjre8GINDA1rUOj+ycDpVAs0jkZR/Wp+p6?= =?us-ascii?Q?4ry+aX3oYiHGLBxxwzRjbLlgdnHY9uSsIGAPja21RkZ5NjSwaOBuosY1hKxc?= =?us-ascii?Q?sZh5oNvVtpQk9SYwbFKpJFSJ9F/7qmIVIdv1WLN1nQOHZB3WMdF6GioW2ioc?= =?us-ascii?Q?lcqdBpfR1e0HXDK1SFvG4gFKxWAufaW7mUsuXlGoJmJVylKeIfeaA7KT2H72?= =?us-ascii?Q?Tmm06BiWYex3bZRA1Uw4w0Yj/AigytM1X7HGxi7JbumS40OPDKXlRtNpIrPe?= =?us-ascii?Q?EPUrQius2FQN3le3AXPEMaqX3sNUSy8pN3A3VMgteDZhi/pPtTfe90cAVuUM?= =?us-ascii?Q?+W+grzYO2sbTq+1COsLbpMP8zDXlqPcB5u2fCMSf+sNgoDKipo6LU6s6Odev?= =?us-ascii?Q?ilUHgI++XFw50VHIG1zwKJA0JuFa0V7ictd/zXE33xXGSqfo2RjNIisN+PxR?= =?us-ascii?Q?nJu7xLuydQVLspjkR6ThD6xMY0oIk46j+lCWks6i8aJY5OYHRrrtafbcucPA?= =?us-ascii?Q?dWbdrDg+qHw08ywnsAdiX9buV1/rM/Q=3D?= X-Exchange-RoutingPolicyChecked: KQLyRQGr7Qcd+hDAtuRXHxZfDBKrG6iWouZNH2yUxnNdGFcXvz4yh1dENWTPR6NEmE5KxtI4TU/cEVP2t6QLn5UfLNdL6MUf/PWmT6WWagMyWlnCbq/h9flpjAGpXC0/XrWwBjDZL2pXykisfUmherwkeaWuOaEPStbGbp/l1Kc6sa/ct8WoW6R+a1FVX8AWZ6HVzBUFNTMahdY5te+zWCr6+/I6TAkTIgkXh6fJXEMcpMvbFQ45fnSf+UYkB3tY++af+0JibhsLv7IhZlhP8BC61ROu8sfbBH9YTkTfSR4+70qbx4DCt5OXJQZ1fa99Croi/oa8mOlV1b0zhUNkOQ== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: a2fa342e-f881-4c49-2892-08ded050c81a X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2026 11:24:10.9877 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PlGlVJUrwqYOjBWjc/LhyrkwLKoMVvLUGaF1atxqd+g55asMHXlxjokwf5+0SQjhz06cxsgw8fiWX/Ck98TD7x12DkKn2NLP6KAzQp7ybqM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR02MB10661 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIyMDExMiBTYWx0ZWRfX91IjRNaE5rhe s5yI53mURXLUPy2+7Ug7/7KLyD8R6ctSCNDgSGEPn7eABho/UgtxzBI9UqTeBHuzwj51NQKrR1A GfcmVvZ7wU5UawQuni0cyc4JEdyVstg= X-Proofpoint-GUID: y_z0hbCVQW_YUIe8pjk5lpxaAFRg8sP- X-Authority-Analysis: v=2.4 cv=X+Ni7mTe c=1 sm=1 tr=0 ts=6a391b5c cx=c_pps a=mSR/hpqHDdeL9wXJcf1Q7Q==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=FelO9ux0wxsA:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=jxMXjlTPpCISP5mWtjnE:22 a=64Cc0HZtAAAA:8 a=cyJIeLrgMFebCcwQBtwA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIyMDExMiBTYWx0ZWRfX9uqlIzug/I5l dK2hMfR+JqfKXCEt3dl6jjlTU0+q3yaEyFb6EqlBLJ4w10btnZORfK6PtC9LZ41hEqROY8UaQZn 9t8Jc/F6oPxxEzADk+y3r0lTOptSaQc5IYOaAFN6sDcP0RAEIiWnHrXYOVzuryFkmdzF1S4xEZD OoDmYTlivCMQnCoT2QCuk2T8mUwEOuwd103aoEqEYQh4T10UAq8Poz4dwWZajpMIqYkn5RffEjF GGh3ISwX6Xzr/Bj/PRQ7yXBuZA4h8ODhgbcfRfwQW9qbRacIuKFWdNGRIdVbimwQa8wNWBgL5QQ IhazGLmXGxMNcIWtvxdL5gKVnnjMo7JyDRYFx1IvWV8qH4v3gIFD8A9K67/5G3c2C21km8Mgyvg f/1WtrN9xowbf9synz4eAdExWpu4A/yZ5d72SheKi0XcXwamm+ZmC4U0Ntv07Mu/LnQwNNJKKeP nNobqrOlRqdm2nDHZMQ== X-Proofpoint-ORIG-GUID: y_z0hbCVQW_YUIe8pjk5lpxaAFRg8sP- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-22_02,2026-06-18_03,2025-10-01_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1782127572990158501 Content-Type: text/plain; charset="utf-8" Signed-off-by: Mark Cave-Ayland Reviewed-by: Daniel P. Berrang=C3=A9 --- include/hw/acpi/ich9.h | 2 ++ hw/acpi/ich9.c | 8 ++++++-- hw/isa/lpc_ich9.c | 1 + 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/include/hw/acpi/ich9.h b/include/hw/acpi/ich9.h index 019f0915c1..30990fcef5 100644 --- a/include/hw/acpi/ich9.h +++ b/include/hw/acpi/ich9.h @@ -81,6 +81,8 @@ void ich9_pm_init(PCIDevice *lpc_pci, ICH9LPCPMRegs *pm, = qemu_irq sci_irq); void ich9_pm_iospace_update(ICH9LPCPMRegs *pm, uint32_t pm_io_base); extern const VMStateDescription vmstate_ich9_pm; =20 +void ich9_pm_reset_properties(ICH9LPCPMRegs *pm); + void ich9_pm_add_properties(Object *obj, ICH9LPCPMRegs *pm); =20 void ich9_pm_device_pre_plug_cb(HotplugHandler *hotplug_dev, DeviceState *= dev, diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index 5c7dfb2c69..5e8f8a7eaf 100644 --- a/hw/acpi/ich9.c +++ b/hw/acpi/ich9.c @@ -388,9 +388,8 @@ static void ich9_pm_set_keep_pci_slot_hpc(Object *obj, = bool value, Error **errp) s->pm.keep_pci_slot_hpc =3D value; } =20 -void ich9_pm_add_properties(Object *obj, ICH9LPCPMRegs *pm) +void ich9_pm_reset_properties(ICH9LPCPMRegs *pm) { - static const uint32_t gpe0_len =3D ICH9_PMIO_GPE0_LEN; pm->acpi_memory_hotplug.is_enabled =3D true; pm->disable_s3 =3D 0; pm->disable_s4 =3D 0; @@ -398,6 +397,11 @@ void ich9_pm_add_properties(Object *obj, ICH9LPCPMRegs= *pm) pm->acpi_pci_hotplug.use_acpi_hotplug_bridge =3D true; pm->keep_pci_slot_hpc =3D true; pm->enable_tco =3D true; +} + +void ich9_pm_add_properties(Object *obj, ICH9LPCPMRegs *pm) +{ + static const uint32_t gpe0_len =3D ICH9_PMIO_GPE0_LEN; =20 object_property_add_uint32_ptr(obj, ACPI_PM_PROP_PM_IO_BASE, &pm->pm_io_base, OBJ_PROP_FLAG_READ); diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c index 9cec18a378..edf9783ec8 100644 --- a/hw/isa/lpc_ich9.c +++ b/hw/isa/lpc_ich9.c @@ -701,6 +701,7 @@ static void ich9_lpc_initfn(Object *obj) &lpc->smi_negotiated_features, OBJ_PROP_FLAG_READ); =20 + ich9_pm_reset_properties(&lpc->pm); ich9_pm_add_properties(obj, &lpc->pm); } =20 --=20 2.43.0 From nobody Tue Jun 30 07:34:11 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1782127513; cv=pass; d=zohomail.com; s=zohoarc; b=nisUOHJAMcYzVKEggiwdrmXsfO/kgPAy5MdqSCc/ec/3qH2FoSlE/FjEkYLHPqkTLgWP2098tiGZi3tmhm+LrtZ4ae1DVI/VGilAVNNAYsTsABQNkSWySV01UF+FFEn5AudQl9Hj8lHGbw+vvTah+Mk6Qkgk1r9WBielh6fCxyI= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782127513; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=uSQDPBrTTZj8Yb13NZCcgb0ZWJkLymTvIEAP5u/Wmbw=; b=M+kgss/0TL8kpEUqB/FmGUQtm+/Gl/RjC8CU2Fh8JEmyhPNLmjpmeZ1GMpSXsi7SvvrebfGz7FcYMEdyxrCFfx0ePpB0hXo/1rTmD3kCD5BWbkiQpkvAfhryfKk5S0taTbTZ5cFJFdu+FPa65/Uy8seZRMVvvEOu5fdbIw1D7JY= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782127513660277.49109734141143; Mon, 22 Jun 2026 04:25:13 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wbclu-0004PO-CL; Mon, 22 Jun 2026 07:24:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wbclh-0004Ii-RC; Mon, 22 Jun 2026 07:24:46 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wbclO-0001R5-FT; Mon, 22 Jun 2026 07:24:28 -0400 Received: from pps.filterd (m0127842.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65MAoDqo810657; Mon, 22 Jun 2026 04:24:15 -0700 Received: from bl2pr02cu003.outbound.protection.outlook.com (mail-eastusazon11021106.outbound.protection.outlook.com [52.101.52.106]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 4ewt6d3fhf-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 22 Jun 2026 04:24:15 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by DS0PR02MB10661.namprd02.prod.outlook.com (2603:10b6:8:1f8::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.139.20; Mon, 22 Jun 2026 11:24:14 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%3]) with mapi id 15.21.0139.009; Mon, 22 Jun 2026 11:24:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=uSQDPBrTTZj8Yb13NZCcgb0ZWJkLymTvIEAP5u/Wm bw=; b=0rx2wokBSE47YV4pCIjQORXSFfTMEjJ5p3F4SnltGa9uSORpGAnRabA4i pslE2tU+M5ZodkLi+H47HC6OBts2r4VdD3EfLUHMYNMkl1F4mnHjRWyWhSXpTqic FN3WeFrU+PFoPfWqJkRm9a3MR/BHl/AiiEOkgRElKeI9QH+umwdq7HPKhOupkBxE 2l15haGQS6L69t2E1JWeh/DaFS6ZIACqiFHJKzE8cWjH0S/OugMQYZtxRF1+zoCI Q7e1BxgOKu6nuaAegmuVSCyOeZUqtNENlFRZFC4csbHAWi7JF9xoagsBoQ/zkWH3 RNUykYamIlvwB5gt/YPyIPcKCkI0A== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Q3FAVrCIiN2WRByJrw0s38GjmwhXnEDhUEZpsOu1xrwE31XNpxw0Up98ekiSMKp0H1g2l3bBsizcxLNTT9pwulQ1T4zk/+/WAr6jXs3mw8o10Bjw8/JdVvd/jYz4Zn1P2OT024ZHGyujrrgqv/uDoCv8lJFGft6DYGQnL1Mh3MNZjefOXArq1kGDcR2jViX24LSANYpqZFFpaMY2ImrmK7h7Ki2xsTJwFI2UnxTSQ00gfLQLgtUn5eqcNJLikOZyNIrZEkC07wmCRHxltWeVpCUGYpZ1goAynx1qnGRiBk/WIkNDCsGXgdHJ5oPC6PnbIQry+BHZNa2sprqzi/wIzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uSQDPBrTTZj8Yb13NZCcgb0ZWJkLymTvIEAP5u/Wmbw=; b=XhCU8uk2Fxm3N9W2WqecKjFo7TaNgzlQm1kahwzsH38tT9AtdZ8TqzOh/tWP2Zy67kBf+ydKhw8BpiSToplb4/JYjYJlYThALcmgisafkVmFOVhMYLNdUOfuC5WRidQTHrWN1/Vwsvy4YUyfw1nIKYVQR6EsC1ta9hvyjCe77IhEjxGRFQGuP5/ho7qnSiBmJKMo0SGR8zJD7d/3s/bmJ9JVWyrRzmIG/0AjpuvNOJNyyfmFa4xZn9ZFC2GwIF7eCAlfAH2PU/Lxlxe5/woMSEmoSEbWQpaHtsRR9468FLPKJU5XH/R1onCnmXReWytUPBqcs9amYkoWfVkrIR8HFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uSQDPBrTTZj8Yb13NZCcgb0ZWJkLymTvIEAP5u/Wmbw=; b=bBvwSn7eG1ldJK7SxlRdYg1aZl17Fu3/85d+/A1vaWaTVFKbHn68SwZMb8nGqMDi4esPeyAgc4qEQYRRX9VqEtnsnXhAeUpfch8GGYjan7G1KT5cYHhGOUT/c1tqVbGZSiQPATEvPgWysja+E819uNg8hvMBY3++VzHnDIVYvTNB/m16lqx5R2i08zYiDeE8YOPtKsnAh0xQV0vyFyURZni60VpSLxycwmykmyEu6FHx3KbDTZOvocno2ZtNoLWBI8KNcNn+np0x6P4xPmTG+zBZCZIwn7EAogB1mhOyq5+f9meHNboj7b4rxGboo6lUcKHw0Y3ijYRO5Qnh0XCMWA== From: Mark Cave-Ayland To: mst@redhat.com, imammedo@redhat.com, anisinha@redhat.com, philmd@mailo.com, aurelien@aurel32.net, peter.maydell@linaro.org, pbonzini@redhat.com, richard.henderson@linaro.org, qemu-devel@nongnu.org, qemu-arm@nongnu.org Subject: [PATCH 2/7] hw/isa/lpc_ich9.c: convert ich9_lpc_initfn() object props to class props Date: Mon, 22 Jun 2026 12:22:34 +0100 Message-ID: <20260622112403.928954-3-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260622112403.928954-1-mark.caveayland@nutanix.com> References: <20260622112403.928954-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: CYZPR14CA0024.namprd14.prod.outlook.com (2603:10b6:930:8f::14) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|DS0PR02MB10661:EE_ X-MS-Office365-Filtering-Correlation-Id: 144c1b85-bb1c-4295-7893-08ded050ca1c x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|7416014|376014|23010399003|1800799024|22082099003|18002099003|56012099006|921020; X-Microsoft-Antispam-Message-Info: Q9SgPFP+xq1B2rNa+o80PYDrc87A+XEBx4tY5Eb1DivFqGjmcoA+WE1wFiLxpZrsadlgsUzfrelpXPpBEIzhIlT6rJMbpSM43IHX+4KWxH2SZEmBS6DIKRC17g2/yxlTwdD+U+AsN1VCsXOPklrEmn+KBxNwhtqW3Mp97wtyXbF0U2CeiJmJ1riOaKDS/xDr03FTyLu7K+W1MoGIbAt+3BcLaerlX0bQPqL5/r3MpV7isZtwgKZEDDawc8g8QNrXbElaaq5UzxCyHM2NFecCPA2u+DLRReXfK0X0K3DNRXBbRlko2OHgX3RROYQ9q/LsiCjN204sS+A9oLhPpAIZ4IQVm7B19rQ/xXI09KrW2WQBOm7NnXDrYh8KrM3uPKiJ1GRK+sMXnUt8nDyVjqW0Y7nNG3BzZnnc4GrIw6cP13De4xEK7I5VJy3pdSTEZF83xOGAqFT8DJxqOMjmKIduDMygkX7B9pm7h/e7gHK0OpqUbteuK2qUsi3F+U3Cf6vo0hWEjzYXNicWbvv+Ifo9FYvjTsYULB7I63xWoDYNRXYM7JaOGRkvRrY7rdKy53QV5jARRUgv2JXk9+kSgbLB2tYbzhf7H4HYJ+I8FeBafco7t3pi2LnQUz/vOBPbtxj50iq/jxzlFgGK8tmbbNlAEyTx/MaoZh1dY8jYA7MUrdp0JcV72gZYPBRqgJu71F1bPC2mDrFPaQX9fS0SAVXQJA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(7416014)(376014)(23010399003)(1800799024)(22082099003)(18002099003)(56012099006)(921020); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9i9phkaNKJXstDGcqxlNoLdmkw6UxiMuIlUuj0FjmgLDJ+Gy01aWJTHAQf3O?= =?us-ascii?Q?KDy49GtXhgkGLddT/4qJPr4mEWH7IYY6sjkISWaST5R3X4giqtnQIHNYlpQt?= =?us-ascii?Q?9/+cemLu3jkVFGzw7vieiEa/Be5yI4X5FDGhz3ViPREfaT06jX+8tWkmX7ky?= =?us-ascii?Q?5jEp1iYoStMDKPR1lNFIEWCgxhASG+bITGyGfJY4tnM2sY10iSv9JrvxaSzB?= =?us-ascii?Q?PkmaP7yBYdstqTEG63I5Pmk5Q1Cdr5tiv3bxOHWBb2mmDwhF0XNNATTcWRbB?= =?us-ascii?Q?XvCCwLww033j5eGM+0I5kquswsrTVOMokOAqG2GEcsFDtfP2Y8Yknn4zIMfz?= =?us-ascii?Q?8U1TCoIXf4dOj/hZRn4dIp8Q0JZ6NPiG9hf0s5DwgjLQIQ7G25nlaqxP0qwb?= =?us-ascii?Q?BV4hhotpZJ4QLUEtah60/p7HlCdIDsM1JtXsajlZ7SUjILW8SwhNxmE7YtdN?= =?us-ascii?Q?M/rvu4YSZ/7rtAGu8BVanaADVE5omVrXkvMm+WhmbqX4Ek7mz5s1xSJksY5b?= =?us-ascii?Q?xhFH3xGnK1+2Fpiiy1AwU5CEb2xgpECge1VXR+4Odk9LqAXF6JQK5MMX+7mL?= =?us-ascii?Q?VPhXzv9pgTTHChY4c7gEroLK8e/AJ/3/8flHgXiCSon6bS2QEONDTd7STlte?= =?us-ascii?Q?OtevPJKNdP5QvLz9XfxRnrQhyPscSFdLEEUzT6+C3PCJk69XK5G0rkmcAuN9?= =?us-ascii?Q?IsGRpDKIp8m7PfKgwKWtJ1JY+340iX9T17OhXT1L1EoDqVECxAgKVq5p3FA0?= =?us-ascii?Q?kGrfkAFaE5IWrkO+yAptoT2e4ICCvEmbHAuMdUClS9y5KHblcHcEmKdKxnqU?= =?us-ascii?Q?JBZLrcQ+3zWo4de5O9IHUgASIWiz/hdhs9ys2gSWwNR1g6s05DdspnfFr9oj?= =?us-ascii?Q?2kdVAmpY+q+HfiTaOMjeNiU14sY1BiPqLQ0wEhDb7ZoErpEZaI89vwZTmD5W?= =?us-ascii?Q?ZMtKYNxRM94wJHXluq3C9ZO9Ah3+wSdH5RJSfC8l/whwqqbnLUDtZeOAHJOc?= =?us-ascii?Q?nL6N6Rf+WzwWdC9xwl4T++1fkL+B3qgYcJohZK/zuL0DkbWc0xt0WOprd6JD?= =?us-ascii?Q?2+9OV0sI4Kkwc9MKxoWnq2GuhZwKspjW9Rp2fqZvin+yyl194UZWFIV7oN4R?= =?us-ascii?Q?gmkp/qsRcBILnw5AvbqxxVS4w3yqseRly6omrrEoaptA/W9IT/UuhXtndmhM?= =?us-ascii?Q?1WxfpJ36S77gtPib0150E/ONr8QA54UkHAs3agfpJ+Gp1AD5+Fxx11p8qVSx?= =?us-ascii?Q?v9P/zaGOGzrWMxIyG4jdp4yT5hqcu7wH55ZE5/PXAevR9/9El8meQp+TZUgb?= =?us-ascii?Q?YsnQd7zwimGgq4WmPi7+KjiBq9wT57mWJGUYddoGhThmvwrXMW4e3tFC6Dzc?= =?us-ascii?Q?QMBQhWSR746yujC+19X0leSwoKfew7cteeuorVDrAXoRIKuXWqoAdzofAfko?= =?us-ascii?Q?18Rbogli7Ljj2WgIwv66arFymluEEBlxS8WkBvmJ2ko9dFpYxtrpwczSj1bO?= =?us-ascii?Q?QbBgV+xj6sdTHg1yTUXApQUES0L4CG9Q2gyCFeVNhppctm8ffKDaobL80PoU?= =?us-ascii?Q?JwmOLlO2za5V7MTQ/42bFD02vOy7mdYQLssEY73/J3iAj3kgcKkRwnHCIxPW?= =?us-ascii?Q?eLKS9tCnvymd/4snqx51KBqS9DPFUbhUINbNcyvLmMQiTH/g4QVwuzthOm4c?= =?us-ascii?Q?+fYJCd7RPY/pehXB+wRBzpn/gRz+me2LRVL2/AjJRelewrmy3gy6wpeyTBEp?= =?us-ascii?Q?/uibgM0D0CVHggcPuIZalFX+F8CFvxU=3D?= X-Exchange-RoutingPolicyChecked: OLXL7TAxhy+orXHoKGe6VnflJKjIzxUbWvghiTwZMnxjakRC+8n52kr6rZ2tX1NVLt8rilywXSNBMUVYdwz7fix33Jbo4BB1npANeEOP9RjAGkmDDvBMd/Mbsh8h94Yxnf+HFpQoMrdZ1FSZNzdEu2mkKMf1OC4ceTWJl/D60zpknQT6YB/yO0BuvNueoG22B1gzTnkrQdwWNQ7tKw7aMJqjCN7iXWOJtotgNhkauuhyMKbuvUHxrc6LtGReAqLqDqXBRqarqjuAmUVXJ4OjXxXNsr+7EsULybK2CKfUOFBlrFDs2gG9Fl70izOJDQWM4LcKVgbg/x3ygRvMnpdOtQ== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 144c1b85-bb1c-4295-7893-08ded050ca1c X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2026 11:24:14.4166 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: I0uV1lavPHXcOmHsq7A0HzIaL8D3psAi5DzfKaTX4BI+yFeRv5yZ7Y67DIZQp1HUd5IrUd+FpHvHDANOfQYqPuFaOd6VXx9n4DlqlQr6WRM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR02MB10661 X-Authority-Analysis: v=2.4 cv=T/S8ifKQ c=1 sm=1 tr=0 ts=6a391b5f cx=c_pps a=8AR2Or5FcovIRbB7TUUKGA==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=FelO9ux0wxsA:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=VUi8bpU7OL1Oj2-RSIOF:22 a=64Cc0HZtAAAA:8 a=1677IaiEuyO47b-9faYA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIyMDExMiBTYWx0ZWRfX876b1rceoc0l qdPAuIClA9U7wMRjHV/4nyn13X4wqoIxgd7NUnfH0EQ1UafG53lRfPisbopPeXCibLtNKY6VgdP 8dYVNk6L14MgqB8TGXEBGEe9GfcA7yR4GR8gwyTpVCuhTeXNwgbwH+rdm7my/pxanqsxbXpwFLq gi5p1N60AMsfOmNrevFmy6Jdins/XJi2ycYMP/S/gJPTi2ikNJnHQRq+Mmazs5GbnSqFDgPbDyl 33d3QvHTtxwtw1svKc1vlH6t+bjUD9dwsPbkhy9mYZLFk9L7unzdpaXs5aS2gPtQcvoEciJ58TZ FHerL1F9bSAk50tLgQG5nFhx9jeZxuh3DJFx+2cV4iXbT1lU9ODrpb0RyljvajK8dIq+4rJ1BQn nFy2PCdwLP2SU0Icul4K//96Mt4TuNWbmkyqHc1pFFx5Y4EVx0wvqvd+tLMurYeDcICO0cNsosY 2AAzya1QX2T3oshvr7g== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIyMDExMiBTYWx0ZWRfX6vySq6SMwtXv Iy5EApp5ufIcnoxULWLLNT2VI+oTuML2OowjYbYNEP/Y6T001nKPrvKiilwT91SV2IPL5Cv1A9T p1dnw8sSOJhoZb9Qm475euKxQbpMKqk= X-Proofpoint-ORIG-GUID: 6_xKJarlTzRfRL5cuLeIOBUeaKb60QES X-Proofpoint-GUID: 6_xKJarlTzRfRL5cuLeIOBUeaKb60QES X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-22_02,2026-06-18_03,2025-10-01_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1782127516696158500 Content-Type: text/plain; charset="utf-8" Signed-off-by: Mark Cave-Ayland Reviewed-by: Daniel P. Berrang=C3=A9 --- hw/isa/lpc_ich9.c | 64 +++++++++++++++++++++++++++++++++++++---------- 1 file changed, 51 insertions(+), 13 deletions(-) diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c index edf9783ec8..c6d31a3957 100644 --- a/hw/isa/lpc_ich9.c +++ b/hw/isa/lpc_ich9.c @@ -683,24 +683,11 @@ static void ich9_lpc_initfn(Object *obj) { ICH9LPCState *lpc =3D ICH9_LPC_DEVICE(obj); =20 - static const uint8_t acpi_enable_cmd =3D ICH9_APM_ACPI_ENABLE; - static const uint8_t acpi_disable_cmd =3D ICH9_APM_ACPI_DISABLE; - object_initialize_child(obj, "rtc", &lpc->rtc, TYPE_MC146818_RTC); =20 qdev_init_gpio_out_named(DEVICE(lpc), lpc->gsi, ICH9_GPIO_GSI, IOAPIC_NUM_PINS); =20 - object_property_add_uint8_ptr(obj, ACPI_PM_PROP_SCI_INT, - &lpc->sci_gsi, OBJ_PROP_FLAG_READ); - object_property_add_uint8_ptr(OBJECT(lpc), ACPI_PM_PROP_ACPI_ENABLE_CM= D, - &acpi_enable_cmd, OBJ_PROP_FLAG_READ); - object_property_add_uint8_ptr(OBJECT(lpc), ACPI_PM_PROP_ACPI_DISABLE_C= MD, - &acpi_disable_cmd, OBJ_PROP_FLAG_READ); - object_property_add_uint64_ptr(obj, ICH9_LPC_SMI_NEGOTIATED_FEAT_PROP, - &lpc->smi_negotiated_features, - OBJ_PROP_FLAG_READ); - ich9_pm_reset_properties(&lpc->pm); ich9_pm_add_properties(obj, &lpc->pm); } @@ -880,6 +867,40 @@ static void build_ich9_isa_aml(AcpiDevAmlIf *adev, Aml= *scope) qbus_build_aml(bus, scope); } =20 +static void ich9_lpc_get_sci_int(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) +{ + ICH9LPCState *lpc =3D ICH9_LPC_DEVICE(obj); + uint8_t sci_gsi =3D lpc->sci_gsi; + + visit_type_uint8(v, name, &sci_gsi, errp); +} + +static void ich9_lpc_get_smi_negotiated_feat(Object *obj, Visitor *v, + const char *name, void *opaqu= e, + Error **errp) +{ + ICH9LPCState *lpc =3D ICH9_LPC_DEVICE(obj); + uint64_t smi_negotiated_features =3D lpc->smi_negotiated_features; + + visit_type_uint64(v, name, &smi_negotiated_features, errp); +} + +static void ich9_lpc_set_smi_negotiated_feat(Object *obj, Visitor *v, + const char *name, void *opaqu= e, + Error **errp) +{ + ICH9LPCState *lpc =3D ICH9_LPC_DEVICE(obj); + uint64_t smi_negotiated_features =3D lpc->smi_negotiated_features; + + if (!visit_type_uint64(v, name, &smi_negotiated_features, errp)) { + return; + } + + lpc->smi_negotiated_features =3D smi_negotiated_features; +} + static void ich9_lpc_class_init(ObjectClass *klass, const void *data) { DeviceClass *dc =3D DEVICE_CLASS(klass); @@ -888,6 +909,9 @@ static void ich9_lpc_class_init(ObjectClass *klass, con= st void *data) AcpiDeviceIfClass *adevc =3D ACPI_DEVICE_IF_CLASS(klass); AcpiDevAmlIfClass *amldevc =3D ACPI_DEV_AML_IF_CLASS(klass); =20 + static const uint8_t acpi_enable_cmd =3D ICH9_APM_ACPI_ENABLE; + static const uint8_t acpi_disable_cmd =3D ICH9_APM_ACPI_DISABLE; + set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); device_class_set_legacy_reset(dc, ich9_lpc_reset); k->realize =3D ich9_lpc_realize; @@ -912,6 +936,20 @@ static void ich9_lpc_class_init(ObjectClass *klass, co= nst void *data) adevc->ospm_status =3D ich9_pm_ospm_status; adevc->send_event =3D ich9_send_gpe; amldevc->build_dev_aml =3D build_ich9_isa_aml; + + object_class_property_add(klass, ACPI_PM_PROP_SCI_INT, "uint8", + ich9_lpc_get_sci_int, + NULL, + NULL, NULL); + object_class_property_add_uint8_ptr(klass, ACPI_PM_PROP_ACPI_ENABLE_CM= D, + &acpi_enable_cmd, OBJ_PROP_FLAG_RE= AD); + object_class_property_add_uint8_ptr(klass, ACPI_PM_PROP_ACPI_DISABLE_C= MD, + &acpi_disable_cmd, OBJ_PROP_FLAG_R= EAD); + object_class_property_add(klass, ICH9_LPC_SMI_NEGOTIATED_FEAT_PROP, + "uint64", + ich9_lpc_get_smi_negotiated_feat, + ich9_lpc_set_smi_negotiated_feat, + NULL, NULL); } =20 static const TypeInfo ich9_lpc_info =3D { --=20 2.43.0 From nobody Tue Jun 30 07:34:11 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1782127567; cv=pass; d=zohomail.com; s=zohoarc; b=MvYetlCDWxrYx/syjX63V28KtAaWcQA+Xst1ZkPBgpil+bSwLFhjSnD4KTmruPE0vTK32uYq8D9NRkAexiqPXZErxZKcaaRO9qFk7sKhzq5UxtvxUsxSrltTHZBrLt06fv3p85gZ+DeiACbJAg+eC9L053XRhms06CLxZQc7ww8= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782127567; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=8IeTnYu8rXZJ7ishxjf2udAN+ikb7eE9xhtyF8G7wbM=; b=XAOmeUDteVIubdah/Z0sJJ96Q8iJsXCm/lLL1ms0/oW3Cn0vxii9ryEFklog+vXlrU5XKg/vGYmjGKHfcj6n2msYWpd7dyXrPf0Eo610YXLRiQ8We2RASxlN5IlaRepU0zNZde/sDnBA0/0g51Qsc86aN6ilg8XPgBMna4DnSoc= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782127567797404.9092634735259; Mon, 22 Jun 2026 04:26:07 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wbclz-0004RS-Sm; Mon, 22 Jun 2026 07:25:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wbcll-0004JE-0N; Mon, 22 Jun 2026 07:24:49 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wbclZ-0001RM-Uz; Mon, 22 Jun 2026 07:24:48 -0400 Received: from pps.filterd (m0127843.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65MAoUOJ012736; Mon, 22 Jun 2026 04:24:20 -0700 Received: from cy7pr03cu001.outbound.protection.outlook.com (mail-westcentralusazon11020104.outbound.protection.outlook.com [40.93.198.104]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 4ewryh3hm6-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 22 Jun 2026 04:24:19 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by DS0PR02MB10661.namprd02.prod.outlook.com (2603:10b6:8:1f8::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.139.20; Mon, 22 Jun 2026 11:24:18 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%3]) with mapi id 15.21.0139.009; Mon, 22 Jun 2026 11:24:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=8IeTnYu8rXZJ7ishxjf2udAN+ikb7eE9xhtyF8G7w bM=; b=jbcNFga5CgjWkD9C+t+EIWC1RCZ4yeb8rj1VB4gWfrMgexhZvRAk5FGSD JmBOSIoDl8c+YJQJTt/sI8zq+u7MdZzZ20u/i2ikI9R7/uQqfJagimOL67Z4EF7C GDf3Csl3nh2KwQc9f4KvvvBB1stn3qMPMC1Y5wI1PdPPfkh0TCmM3kGeEK4tHuzO ZX5o+CsXP09hH83WzozVJh9zydB/i0JL2j+jJtSjRkMEp9r+OZ5ROzONO2lvdcV6 ok4hxYhGHNj1HBRDcJWGj0wwuDh/ZFqb1FECM8YY5xZ3cNtLAO83owS0UE1zigE5 5TjDy8gZXkXXoFEbNb5HghZAAaxxg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=auls8eMCH1/DobxcSiANkjPzSRp6kUEkG9gL89Pqaj77c+PqkEva3qAsyLV8IHwDVzS0lSLBL3Ty7CU9XEa9C7fcCgLA0wXMwN5QbRtN9QPogx5aP/kATfvy45jyyfzuULfMtUG8k4oRBZFiI9wGUlePGmGqTA+eIoHl+umhSz3+yjhd8l1+Qi2KjK8Bc5ZW1yyOiYI+9vKo26QojZBJMCFczCfCN0Viy/8Kna3PNzGRvX0iN1UB3Pl9cSeH7S6rQVOCl071mjLI8RH1xoUj+gEaKgphrFxlIehoCDuQCFN6f1eCH7lAhToHHyzCKfwpa9/RDpxbzTQnpT88LbhKuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8IeTnYu8rXZJ7ishxjf2udAN+ikb7eE9xhtyF8G7wbM=; b=LjgKfAyOzApwSnJDs6qZDE37TFb1pLzyDxgM9XbiWY0N9MexOr2gaNpRCZDzlhp0oCdjKbhU8cOYhIaThb08hvdmxgt3ZNE87MBYSUGyVvJtoqKZm3gRbKwKK17dUOXwmMEXCuZREHudKPaETxTFJikefEh9XqTFcsX077mn6StIffkvwD4yiE3nCKpytV5Ca+Hbt0ouEOOACWv+HZzRRPx0FW8c/AqQ2eB//W7XlUJReEodd3o97Zzq28YT1STsONi3njK2dikAiWmXNY3Dzml3MxEioI/FhmmKDhPwyA+lnG/Gftc8lN56iS2d8sh7PTnhhEDXkFe1j13RRKa3UQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8IeTnYu8rXZJ7ishxjf2udAN+ikb7eE9xhtyF8G7wbM=; b=lcgQJjgQYgHr0TdBLsz68SWteFvxpWvOVcNtqNR0J4WVTAFXw+3j+0hy3huppCouJdgJ84zBCvmrXh/XwnKMlUV6Z9K7B0BJSSoJgINhwC4y11Zpl1jkGjuhpUt7MNOh/MTWlpRr/DLL142I+GD4G9+1BaFtBP4hF+spbSahDZN36czQOHYE5Xu4HnYC09tf1BCFw4nlfmawME4/JFldUniKb4/Ag4Za5hIHgON6tM/WiuzE3QEkJStNgzyoNxXx6YGBZe66P3jiZUVjyZnTi8oPxd0DdkbOW5xGfMBJeEwW8UmEF0Fg+4qILlY0ogpgfry7It3k/6sxbs/0zpldbQ== From: Mark Cave-Ayland To: mst@redhat.com, imammedo@redhat.com, anisinha@redhat.com, philmd@mailo.com, aurelien@aurel32.net, peter.maydell@linaro.org, pbonzini@redhat.com, richard.henderson@linaro.org, qemu-devel@nongnu.org, qemu-arm@nongnu.org Subject: [PATCH 3/7] hw/acpi/ich9.c: don't pass ICH9LPCPMRegs via opaque for ACPI_PM_PROP_GPE0_BLK prop Date: Mon, 22 Jun 2026 12:22:35 +0100 Message-ID: <20260622112403.928954-4-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260622112403.928954-1-mark.caveayland@nutanix.com> References: <20260622112403.928954-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: CY8PR22CA0005.namprd22.prod.outlook.com (2603:10b6:930:45::9) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|DS0PR02MB10661:EE_ X-MS-Office365-Filtering-Correlation-Id: 980bcd1d-2597-4cd4-9a54-08ded050ccc0 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|7416014|376014|23010399003|1800799024|22082099003|18002099003|56012099006|921020; X-Microsoft-Antispam-Message-Info: oj9VU+UYxgedJEX1oGGFwYXM2ftjpbt++dyQuQhDyVD5f6Ou/OdIjEfGa+3r1l/aQtkf0ixfq5LgEDElDAsTj6gTr5uviZPul9I/rPcQ6WUeM6RJ5gmbHmpmCC2XefkvszdrEKFSiKa3gMDZWt1UT1Z7BppFPudjDs2HJwk8KSqWW6saMGAUVJ1BY20p0U/KYMSgPjNRrOzz+dhC1x5lzUfK7LzdONrTL6k4fjRUY7OpKCBHENBx1x+ioPteSPzPAyBLZ3g+rR4y7nergEkjlLIXmFwP/1+e3daEwFC1BiqFkfSifajs8C4NdOgnWh17e9zv8LblYJsv4zRHZROnBitPXQ/xkB7Th0VqqFH6aG+FtznRjwrcd5WS0Y59LkJVirXaIfgKa9WDTC2mMFgUyRGxjNzg3uTqvoB4qc4IIRprrU3OTpAyyaCtjKBgsk26LsuN+4Z7IlUXpHA+mh51jQxXmFgIHTQ9eoxJHHLq2Mc1MJpud/VehiSkLn6wijZsKuZjxemJycQR1pnn+5wZUXV51z6Ud1/zgAY8esEFg8mSq9bWu0KSMNeEdaCFMXAdH7SYJ1NQcyarR/rVcbOHKQ7qnkmrvnGHqlyHa8hIoCJEq2sLU67zQjVSI7VGOIwRtG0DS0ufveeqnM0bxp9XOYSRXLVlZPTRhiH5TOKbMioTbSeUveNYCU01rzJpvwrc4GIyyp5l9E/y+ONrsPgSog== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(7416014)(376014)(23010399003)(1800799024)(22082099003)(18002099003)(56012099006)(921020); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?T0Ut484NwSK0kp8m7/HBTfzrZShFwHCC2GJxyUKk4FTcoIw4dvOQflgtf0Jy?= =?us-ascii?Q?o/In9eiZqzj3r7AHrfOsydujAi6jA5aL5Skz06ptsTPk7IFoVktXEywALsUf?= =?us-ascii?Q?f2EKDTgVtWUcuqDrCBK0PGgchvghLbCePOAzMfSUmp61IUc7LV9QGnvJqW2p?= =?us-ascii?Q?OiK3VVCR3bBmdODmdDiXMOTRzKfXVD3A1BC/6sr3eC++c+5HTkrrVpcXFGtS?= =?us-ascii?Q?Kt1nDPllZHJHFK2zQQaA+jWVEltmAf2AVtRQqUSUQIhFAZb6VA5siQjwhU3y?= =?us-ascii?Q?LY1hQP0lYO4nbyJLvHldXEz/2dX38NLwBUZBYhgmndFqwCOEYGqiF0mM04h4?= =?us-ascii?Q?dLW8TbwjDgCrR8idwjgXymIE7/+jI3/yxXLD/UZfhV/aUhAMA9V+xLEZw60K?= =?us-ascii?Q?iEkeb/vQt3+9FF1XspgSYwUiFacdOMWvsfAFPKzOh93EM21HxMar9pmfnEuE?= =?us-ascii?Q?o5oGr3Y5pdnKYa1JZpuRXo/PyFk/9S7l2GGKR2bAESU5Kh5SlmuDpz/1n+vX?= =?us-ascii?Q?Wbrc/pSGmkr8+XjspQSxCLyhqIB4VGL/ZJ5Iqglf40N4YzVmf+LEQCeGxF5B?= =?us-ascii?Q?RZi9nAVViu7SnfBR7WUlL7CRwhhjKCvK3KKSIcKvZA3moiyWTYjxKC34tBAt?= =?us-ascii?Q?twg5N81I4talXG5F0Dj3V/ThYqEzmOJWODal4fd0rrfL8F0FV93wkJbKqTJT?= =?us-ascii?Q?lL9rHyeyd1bddHCgL4+GxMKTDbFnltsCnsMj87OUBfWBGg4vSsyGwM0sGmnr?= =?us-ascii?Q?zDCDHyJA1r2xcCOMTPv0vzLxKni+IF98mgC9XHDp1/JGpMjmy7/kmGYeeFYS?= =?us-ascii?Q?L5n6TYjLobV2hMY9gFxS8qeiHrypM9uzH0XmzRy5JiK+AG/yfnx4F85ztUYu?= =?us-ascii?Q?IJPXll8elfWIQjfzAXf2uQufqP8gA6OQdOtWXL3dHIB/Iz5ZK2NNs7FW3hLQ?= =?us-ascii?Q?+nqn9nev0BYMA4BfScKpeOPNGCre0lT5Ja3iLuiA7bXz9JfOnT/0MdX/IIL9?= =?us-ascii?Q?aUAQfTKe7SLk+X0lpq4/Gb0UkRviigTcAZQ1t9NesXMN/M/egPlZj/yH2jKf?= =?us-ascii?Q?xjoJBORHr3UehDitzdt4oZcJP/nE3/SQo2fmHWBqlbF7W2kXMdJblDr874fa?= =?us-ascii?Q?vlmVDxsYjaE9O47D6kC63PV1iokrfxFAsHkJVnUSIoO1bHcwH/MWrfZdOq3k?= =?us-ascii?Q?8ZC4p4yq9M3OvQF0rUO3JHpQxH/SGc2A9dosq8dOOMRyGfnuNePIPlqHb7N2?= =?us-ascii?Q?3hUwrR2KKK5bGatoUpKXvfLFg3kQffNKYq1Fl7kgQ3yf5UalGh9oGX4K/cLu?= =?us-ascii?Q?0JGv/G0FaVXCthoACRuQxQQVkqKc6ArkMXR+KZxqPbnKYS5CAVxbB7CUF83T?= =?us-ascii?Q?ZyJgbt8pshQpI3AEjmAwptnTT5PfUzDkqfKHub/w/OE0Grs49BlAyUVF+dYl?= =?us-ascii?Q?eKN2HWrPP2et1LcUywQK+Sdpv9Z/FwnB0KUaG18oeY1rAgIZsymZDZgeZaQe?= =?us-ascii?Q?m+QmNPoz5z+u0ZCIIH5ijKDFr103QOaXM5BI7VngKFUzufqQYQ2cFpO8HmeC?= =?us-ascii?Q?9noDVbXlNZwq1E8/Bet8sdEatODuC1rPDLtmHZIYbYZHIiIzwOi07zCs7hsr?= =?us-ascii?Q?R27uDYzzkMIxSen8fDYx1YfsIVatnXECLHB/DNQjgQPxRAtSvkHVR7jSvk0I?= =?us-ascii?Q?4i2CtXQY9ymEUpK4X9ZuIztxCyNLaynxawqHsN7bbma6b/goh5coCtgO/kgO?= =?us-ascii?Q?2HTL/83Yvh06u3H1LEGhS8rNWqffMUI=3D?= X-Exchange-RoutingPolicyChecked: a5y3IzpV/5Pq8kWI4P83fc3Bi9TzSRA8nzeRM3JBKAMEi19Y+0pAAW4KGQOkP5/SeLug15WvGyVqv5j9nbGLyXRx4Ngz+xlsIoaIv1UBIeP9zCXCaAOiB3GJu+mazuc3Y4f6Qtht+4AOjt//raGIJBsDHiNALZ2iXf7LH0gAcwreeSw4DtnB28Be38dB104aLvnsr8z1bxqStjEXX+462GDauVipE3Hyy2twcwe5/TpZhrSAUTaK7HkPbY01MktyOS/4x0hIqdIktTgJbUO4XdSEJIuOGvfZqiU3P/co8vnt8HJSnVz4rq2BgN41KN6ColfHxLtkyR3zGLSjjOCGWg== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 980bcd1d-2597-4cd4-9a54-08ded050ccc0 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2026 11:24:18.5160 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EHibUtF+jr97xxUY28Q1IyWX745XVOUvOp3eq4QIn79Eq2pWJGFl4EzTLtym1wBkygpbNtlYM0oYumwErQXtlAWhgp45T0r0PsXv6TDbpF0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR02MB10661 X-Proofpoint-GUID: sfdfXPUbMrzkIVbWFkh9cvz6NND8lYb- X-Proofpoint-ORIG-GUID: sfdfXPUbMrzkIVbWFkh9cvz6NND8lYb- X-Authority-Analysis: v=2.4 cv=M6p97Sws c=1 sm=1 tr=0 ts=6a391b64 cx=c_pps a=/l2LzaSN5HZ5zNViGO9i2Q==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=FelO9ux0wxsA:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=dEe9Ve2bX-KnNSUMM2s9:22 a=64Cc0HZtAAAA:8 a=Y-s1kumoAnAeZpE8ypgA:9 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIyMDExMiBTYWx0ZWRfXz59g5TiiotA9 9ER4i2kNORZpLn3wzi2GN89kIWVSCkNk7InEi62YiFxKPqCAqIXkFW/dMth87V47nPnmk10ZoEc B9ngfc0uUpPnBOR/kaeLEDVWPBYTk6k= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIyMDExMiBTYWx0ZWRfX72g/oUMOmOET wxLojOdUnJGkoQFIpawmLfAjOiD2YdrOhg07oJ2HoppDhEPMxIDETqmdpc7tPRzo6bTJMMGgolK 0Clzp/QApkpSU+SBSjY5TeyEImp/GbNmOMoMFbz6nVjT6mF1LszUtacQPv6ryBW1Js+CnQ+mxoL /qGSQBS4e4bsBTqqBwS5AkCX/GiQcWag7y2VVDpPpqa8LKkOowEdFAa+KAEIhvWIqQ2Za1etnhX D/ZxLiW/zTEI4d4uqJ6Q6xVzezD/Ce2scjEnXErC2HvCBXRRuXdA9XWhjVMIAhHs+C8kjQwuGvr DNPNpTcl0rcI0unJ7oCwp9KtTeNw/6ICDOoXKT7zD3jb1MHHv5yTFSXypRDvvQqFNcn6zCKYGak Fw6w55DHKT4PHM+89rDMW/APPHx39XLIfiTt6i9PO6FdqkIazGwiveTibyv0GSjy6HNFFjBpYBJ pGk8v1UPCAR1CXtm5ZQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-22_02,2026-06-18_03,2025-10-01_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1782127568812158500 Content-Type: text/plain; charset="utf-8" In order to convert to a class property, the ICH9LPCPMRegs instance must be resolved by the getter/setter instead of being passed directly as an opaque. Signed-off-by: Mark Cave-Ayland --- hw/acpi/ich9.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index 5e8f8a7eaf..ac3f452dc3 100644 --- a/hw/acpi/ich9.c +++ b/hw/acpi/ich9.c @@ -342,7 +342,8 @@ void ich9_pm_init(PCIDevice *lpc_pci, ICH9LPCPMRegs *pm= , qemu_irq sci_irq) static void ich9_pm_get_gpe0_blk(Object *obj, Visitor *v, const char *name, void *opaque, Error **errp) { - ICH9LPCPMRegs *pm =3D opaque; + ICH9LPCState *s =3D ICH9_LPC_DEVICE(obj); + ICH9LPCPMRegs *pm =3D &s->pm; uint32_t value =3D pm->pm_io_base + ICH9_PMIO_GPE0_STS; =20 visit_type_uint32(v, name, &value, errp); @@ -411,7 +412,7 @@ void ich9_pm_add_properties(Object *obj, ICH9LPCPMRegs = *pm) OBJ_PROP_LINK_STRONG); object_property_add(obj, ACPI_PM_PROP_GPE0_BLK, "uint32", ich9_pm_get_gpe0_blk, - NULL, NULL, pm); + NULL, NULL, NULL); object_property_add_uint32_ptr(obj, ACPI_PM_PROP_GPE0_BLK_LEN, &gpe0_len, OBJ_PROP_FLAG_READ); object_property_add_uint8_ptr(obj, ACPI_PM_PROP_S3_DISABLED, --=20 2.43.0 From nobody Tue Jun 30 07:34:11 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1782127599; cv=pass; d=zohomail.com; s=zohoarc; b=Zb/zaJxHNt+wyFfpHexypKK5rQ7VpHlaggi2d3L10eyDFKXMaa8Lh5425mZVjO9EIZyYYlhMcQ558zBaq37EsRDZVfJxIyvvvROPEvBQtlli13kW/wDsrsQR082Yt48bwfHVEkr1R8RxvFFkqFVl99wTTK1Rl6vF8h66xPrZvUw= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782127599; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=7eO9NRZpgXZJ9FKLqmE3dkSPaBlNOLafRB/+U27h9fM=; b=YZmRt0E5kZ86xSbYv5Df0bKKwyAVEv7QHu04yZzxUd2vykppyrXXlQCKTfid4halklMIoVplNmOKRnz5KqaTJKd+SWK47NZkxdc6KLh6LTU31KUG69O6T8tFxWhrowcw8IbNChviRvMTK2mYxLcHsxyh2r4yW3vP3TX/cBltLBU= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782127598975249.56839546511458; Mon, 22 Jun 2026 04:26:38 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wbcm0-0004SB-Tg; Mon, 22 Jun 2026 07:25:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wbclm-0004JQ-P3; Mon, 22 Jun 2026 07:24:50 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wbcli-0001RV-Pj; Mon, 22 Jun 2026 07:24:50 -0400 Received: from pps.filterd (m0127839.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65MApoB04141291; Mon, 22 Jun 2026 04:24:24 -0700 Received: from dm5pr21cu001.outbound.protection.outlook.com (mail-centralusazon11021130.outbound.protection.outlook.com [52.101.62.130]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 4ewsxd3f9r-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 22 Jun 2026 04:24:23 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by DS0PR02MB10661.namprd02.prod.outlook.com (2603:10b6:8:1f8::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.139.20; Mon, 22 Jun 2026 11:24:22 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%3]) with mapi id 15.21.0139.009; Mon, 22 Jun 2026 11:24:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=7eO9NRZpgXZJ9FKLqmE3dkSPaBlNOLafRB/+U27h9 fM=; b=HA5uyS/ERXUSv1m25CAOrIbDVh8Z2gfLm2J1r4rkOvwV6q7zMHVEXHPCm 4vLlReaO2SBfgtd8QPaQgKFLNcRlioT2qjnaoBPkPD433p3XB8qm7RKIEZrSQFmD QdBT/4ZV8I+emizUKga3/8gge3mQDlSWr6nyx/ykqXSQVfWqv2wIIhGv89aVHtHL gRujEK5ZdzZw6x1YNEJyiZ6iheWifOo9S/DDPAgsh4ffDglk7KDrWrhgQn4dhhXv YCi7MCYQ/x4m8LawYDFP0yum94w83a7MGUQlT4aq7lyi1PUl43jEbuDblSS58efv ZX4RETWCy/4tZFT/XGu/CVq149D5w== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sbxOvFZuS1eP8zfayAILIaKGfO/Rdc8hMSDNcXB408G9p/cwupfAW1dA3SUN887po73PghsCifAS2nG3LBFq1fbC0fRc789+1Z4NaVnABvtgLa2d84riggKvs/XnF7+ZOzW5iumEq/Fl0ZQ9Io0pl+AwxdvibJg41xhiEjxR/L6zjeBPHjxVtIZuv6UdR3DNlHuOrMDGyaqbUAwzh0+7lbK6a615Az4LwoQaO7nLFs+bheyd6EihaNfrn07barntqLkPVxK7jXPil0J2mXTwW5hCKwPj0L73ZNLiVPMLCSOwCYThyEb5/Lf9mkCvGQBbI+pgzYdMLuQrQJ4Mo4hKOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7eO9NRZpgXZJ9FKLqmE3dkSPaBlNOLafRB/+U27h9fM=; b=W8ZcvmTuAfF2Mo3UqJp22XddwmlQyWgjDvF+k57PE3MSQOmJmy8IW1kqWuy8sE6NNjTN18rYPSvxpMwB1nEQpm7vctqKor+JcfAF0CdhlbZfgaMDd6F5Y7WVagFokuVHL+/K0GB3Ts0sEMOKR9tCkQi525Vgp+G8JI88Uf6nc1A+CZgG+iYNZYRri8XRAjQ82IrmqRc3u98o7v7ji7CLf0RsDMAJh92RIujKOZXT3gx+lkKD1B+ElINuF3bLVxlD0DcdDSvekrAIrwxcb+5PuYdabHsKyzY7OqQ2WOhd/nSUOu+rvZUA7q5k9KeL5gZ8soEotEcQmKUDCFLLSsppQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7eO9NRZpgXZJ9FKLqmE3dkSPaBlNOLafRB/+U27h9fM=; b=BQjJt8Wfzu2kczD0LCCK3KKll3JNFfLj1Vn8ug7pyuFcemhhmhxTA9BicVsr44DaalXmgSBv99pHNSlb/7GY/9GqJULSOb7jlJwrGxnpPdBsUvEmKcMXwsA3ppxaRkxsWrPW8Lor8+7nOZsyX/IJv40cIBUqcJyiLeaKY1mOmPmvyRlAFj5ufAegGTtzkYp/RMPzcJYSA/sxUDn25wPx6l9i0KOEduf2RSrgInFQseY2pegLEzGXPTIlEDAGDznrKa46XOZCfkqw1j4zPbCCEwWqEJx5PEmCCQUAedxtyYSYvdSv2xkZjFLa58PfcLAiwnMKDvamuecth4rZiDHYjg== From: Mark Cave-Ayland To: mst@redhat.com, imammedo@redhat.com, anisinha@redhat.com, philmd@mailo.com, aurelien@aurel32.net, peter.maydell@linaro.org, pbonzini@redhat.com, richard.henderson@linaro.org, qemu-devel@nongnu.org, qemu-arm@nongnu.org Subject: [PATCH 4/7] hw/acpi/ich9.c: convert object props in ICH9_LPC_DEVICE to class props Date: Mon, 22 Jun 2026 12:22:36 +0100 Message-ID: <20260622112403.928954-5-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260622112403.928954-1-mark.caveayland@nutanix.com> References: <20260622112403.928954-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: CY5P221CA0125.NAMP221.PROD.OUTLOOK.COM (2603:10b6:930:1f::31) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|DS0PR02MB10661:EE_ X-MS-Office365-Filtering-Correlation-Id: efaba6f3-0f15-44e9-bf61-08ded050cf04 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|7416014|376014|23010399003|1800799024|22082099003|18002099003|56012099006|921020; X-Microsoft-Antispam-Message-Info: e+/lZwfWg02HYojOxlfmIoUA6QV9vCttwvdYPNBUfSVNzfRM/DBnOWe4qpoROJQ1dZA0cN8PKqpH4/7XagIKTak1ol5W8wxbDKGpxi66D+oKB2QUZLhvrjQAdh9ciMsnFdTo/HGCQakNtO6iW4SQm5899F5hvper2+wtBp09NouBv1gkPBEIpONvnqDBFyyUDy0sMOvUlVGtMeSKtZqnNwQdyPMcV1/nLKaW2a3VtAvZEPcbyp/hCVoAJrLAbcu6D/IOh+co3Kr5x+FILtJ+fOFyIW3EBpJxznIC9kxqFCVZMpwMiYbmfdv8mj+POmQrZmEEfPgWWP8n2f9TWTM4Oao0vLQiAujVvUxDYSHsCPvJV3uI9MLihaPgXcso/yRvMySUAQNiu6XOP0NyLwoZSP9NYB6xVKZRFIOIGKHpFsvBnbvr2LyqpYXfHAmPXW4g+yokGTiQ4Lz/QcQJk++7OvYyJh+WdQxBtlBvD0oNU5FPZDFsQlsU6AtkXSHDwjfDomFhLanfBkekLEYAYgzlu9+LldkX3J/6+TO7xqRv/HROklC4aoJd3TFMbfzqqQ/ubGXyXlrBg42s0knwpS3Wn6CpIX+EpLSofutViE7z6AfaZyp3yKBTkInTQeTmZbvZbDXsDKMc2jY/pKzVuktnmMgf6+JusJIbHRMXhfF9xiST28bdt4CSaLfTFkz7NhXUuhRMXL+4jyPRUTU0T+jHFg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(7416014)(376014)(23010399003)(1800799024)(22082099003)(18002099003)(56012099006)(921020); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?zBVPskE1EtCs/LfsRwxeHSOKV/t8E4iNkZ8NGAbg9qezSUrX7T9mWBc3AAyx?= =?us-ascii?Q?g3sQ2mLCXksPxnsi37s5brbry9pUiQna9K4C6QmbpwC8rexnHEuUbJZjJkrA?= =?us-ascii?Q?lV0y5+bBixfEst1FLvsKRlIIFKCAc/90vNdJjaSIABhdXSK+F9/J9d/xfRKJ?= =?us-ascii?Q?li2VFyoQS4JzggaPB13B12/ey+IzWLyWkJfCgnAsnEdlMZiB3jjBYijlpG/n?= =?us-ascii?Q?bstMYpxPLOsqugEU0oit1Pt5mrqMKG2YuxAtNGBeizSjUBB18W5RAymg6r8k?= =?us-ascii?Q?SNM5vnmrP5Aamx3yfkxKMzHlcRtP42dh99dMMEJKghgtlIbaQrYVubfwlcw8?= =?us-ascii?Q?Dhzb5C3ECMqNlT0K1nIYsofKMNTYYpScceeEwlCyJw8DHk80zTzs7NZsFi/L?= =?us-ascii?Q?sHsyWU3r+QWWmVaou/RMcBWz0wG4N13xdXSPPfHw1TIu4rHUFfWZRJkQdkrD?= =?us-ascii?Q?70gU7dy0+6z7GrUxEwVI/xPMlwhCOVLFQh1FXTe/enDm+2pWm+SsrFhbfrEJ?= =?us-ascii?Q?IpM4E1Fb9UIDk+UnfySUFRTb62UHIbqJGPeZzT6sGNb+bGTMIqLT+i1gtAGr?= =?us-ascii?Q?Ik/U70+X4E+9nVszzN6+fTFU9td+z3Ng6zQtvUN8R8Rp7XjSxMvolJQgIm0o?= =?us-ascii?Q?fcx4MzHea3WOUdN3UpYmjkFUs74wm5WmCTo97hZtumJuENFnlLIp3cZNsleO?= =?us-ascii?Q?Vdv3lpWSgk/+5eLmnKjcJYO+xWZlfkL1KV92Gd835AHE0irNfdnhbQ/eimPk?= =?us-ascii?Q?eN5iWjV8kywDBIIUO2avKvQsEOnHv7E5F7061fXXW4FCWcP7naHSbx3NugFU?= =?us-ascii?Q?V/GhAX6LV2ItQK0lTrhPwAii6/FXrgrqHeP2JOYAqS4MWt9TDpjXi4xL4S9k?= =?us-ascii?Q?MqHfIraHmVz7BsLBSq6ve8RY+A2JR9p8li6pVcBDI7S/M+262ysBVTIryumV?= =?us-ascii?Q?o6YdvwJoh3K2t8h/v48BDVw00ZINXtt026cago+VpA4lTj3/F7O5V00Fn2Rn?= =?us-ascii?Q?mWlEfbMqL0hk42ZGhNI7i1ZM/8ocMs0XMzO/U+Ou3h8VzbyX9FMjYdM/a9iz?= =?us-ascii?Q?xPsyKBiEv5eh4izwZLU0zU30LqiXQNUU3+0okqBVd8nLYluf3ZfDW0/FKOeB?= =?us-ascii?Q?VXtO8+mDdkayyYl4e/JjOXgrFfu9uzN1q2kTJ84H4G0WUzTm7b0Jeg+jRcNx?= =?us-ascii?Q?e4ELIoTM9tjPglBKnHwlUNKfW9eWPaRgBIiUws/rYaKxberkfvf0isGscAZj?= =?us-ascii?Q?kho3cZMRRnBOb0WcHAgUP2Xv25D1GOZ6o97H+euPOPlfR0mFSZB23Kv9/WTh?= =?us-ascii?Q?ysT/6H6CyNH/pL9/BRv7FboaDOoYkgPCo7oXhzTRu0iCk+0dbj7/MK54OHix?= =?us-ascii?Q?/S8x5h7oIzpd0R2U/CPUp0/HdS/gcwfLX9ixgzBuHwfhE19ltxJ6nWvspLxs?= =?us-ascii?Q?kZz0CcfY8wYKJkWUj/gIiEyGDozC4+PLn+8qCfaKZg3X9lIxbtGRNp04UwUw?= =?us-ascii?Q?tY7YTKHEdCmjgtRhptp+3zDjkOuVXgHJTYpSYbQyXwKNG+a+UkdQiObRXjp0?= =?us-ascii?Q?a3e5qDP/hCyS1tU3ok4FvdRJ+53bdlgEi0EFWD+Ix7h0KsuTw4ycQ/BpmdRH?= =?us-ascii?Q?Rc/DmkZxMt8GVAqdHXBJlM4ONSIac7HZ9GjQSXEp02+UKzhp2Pf+AkCs8wup?= =?us-ascii?Q?8CnnGt6qtBuRWcZU66VinIew0L1uDao71OiOVsgraL2jaJtXjhLQaeGzN4oz?= =?us-ascii?Q?zbZoRLMQ1UzrXgoJHIK2hLykhyEtLPM=3D?= X-Exchange-RoutingPolicyChecked: NMAmkpRg7atPkbRWoYsvKI6tnb+db9bC9ZuXCZ6qKrlHGxKLkkHIgT0+YhvnbN68WbNzc6+iwT13KxJc9tMQe1RcilTGoZjKTnL93Pn21/mZNlyt/WS6LMQYK4U+CDY+WSfG1SFFs8jzvPVyRlweR9mPs+3qjAQJ1yLc+ZUt7gPuhSmjKVYcEe3DN+AbywDLfnGAa+1H9aTqlvo08Ret228ZHGoUQDR9F8gF3tfeXDWhbn1P1IjbYa3ed7bNE7EWvzDpRAAWrOlvNB7RUBsJl7m8Mpz/Bg6oYat0U1nNPwtTaug/nxvxxUa+QR87Cp4g158a1BWgB0NGDjfjrUzj0A== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: efaba6f3-0f15-44e9-bf61-08ded050cf04 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2026 11:24:22.4504 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: A1zI7+bflOnrx2/7HaXEtlphozkGq5mfWRDEc/cRe/PhEI3zDwbMXah2e8Src6KGvle6GET3yTQxlLKzvpg5HJ8pwZIM9UFZV32IL6+Ix2o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR02MB10661 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIyMDExMiBTYWx0ZWRfX0LfTk1C1vEgr 0pkASxb1KNRlsU4PaM9D9Ah4tdZ86Ej3QujHWa9Jh0hZqe1Pwc5/7+AlYNP1KHEkfZ94+1xlhTD +k2c3YSwdVPdCBZ7XNm8bkiz/DUDUV3kXHeHtPy4vC4moTHSOG6h5s2Zy+Nm3J/FApUbyWQg9s7 tXKsVBIcPxN/vXQExsIlaxEkemuxoLpBtkw+d40vOrxjfhBH67Nmro4/351+jcuKFpybyXs8LnU mxwVpfAEi2JQR7XP3p5BBLJCOXHvy75RKFhaH/5RetbThy2OEUNoNkiug7XVj/pDDvkS2u2qBoe TrfF7maHYwSIQPpRmZmQG6SQiBnE9vGJZ0SDGOxZFAHBYzD+B5h6sz6bEc86ZnhUjq0UHQwsSQ/ 76ysMeGNsn2rEKn81LinGToKML8Us19nt/TR6cZJviNg9eRKMP51w2iCQrKJnvjfeqyb/LgT3EF YDOqQCHY4lFtJyrgd2Q== X-Authority-Analysis: v=2.4 cv=WYg8rUhX c=1 sm=1 tr=0 ts=6a391b67 cx=c_pps a=7kgNGXaSmB15KJ6u7rEBag==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=FelO9ux0wxsA:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=y4UcunY2MAxhM4LwGdWI:22 a=64Cc0HZtAAAA:8 a=WrwsNJpTap34L7CCBUEA:9 X-Proofpoint-ORIG-GUID: mU724pmACKguf9AyTGtcoByTgDTfGZOM X-Proofpoint-GUID: mU724pmACKguf9AyTGtcoByTgDTfGZOM X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIyMDExMiBTYWx0ZWRfXxOZkgKRcrfoV CTRruHA7SaL3NGIl65+FhFOmZW7UyYvE3nykuhBGh8d56CfGfvSc3ltx+1Uj3bcsZ3UMBUyBYLG H+mvIIm8AKPbiORK4cehcztXkW1hghc= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-22_02,2026-06-18_03,2025-10-01_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1782127601138158500 Content-Type: text/plain; charset="utf-8" Signed-off-by: Mark Cave-Ayland Reviewed-by: Daniel P. Berrang=C3=A9 --- include/hw/acpi/ich9.h | 2 +- hw/acpi/ich9.c | 153 +++++++++++++++++++++++++++++++++-------- hw/isa/lpc_ich9.c | 3 +- 3 files changed, 129 insertions(+), 29 deletions(-) diff --git a/include/hw/acpi/ich9.h b/include/hw/acpi/ich9.h index 30990fcef5..3180e98c93 100644 --- a/include/hw/acpi/ich9.h +++ b/include/hw/acpi/ich9.h @@ -83,7 +83,7 @@ extern const VMStateDescription vmstate_ich9_pm; =20 void ich9_pm_reset_properties(ICH9LPCPMRegs *pm); =20 -void ich9_pm_add_properties(Object *obj, ICH9LPCPMRegs *pm); +void ich9_pm_add_class_properties(ObjectClass *oc); =20 void ich9_pm_device_pre_plug_cb(HotplugHandler *hotplug_dev, DeviceState *= dev, Error **errp); diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index ac3f452dc3..723a87e6f3 100644 --- a/hw/acpi/ich9.c +++ b/hw/acpi/ich9.c @@ -339,6 +339,16 @@ void ich9_pm_init(PCIDevice *lpc_pci, ICH9LPCPMRegs *p= m, qemu_irq sci_irq) ACPI_MEMORY_HOTPLUG_BASE); } =20 +static void ich9_pm_get_io_base(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) +{ + ICH9LPCState *lpc =3D ICH9_LPC_DEVICE(obj); + uint32_t pm_io_base =3D lpc->pm.pm_io_base; + + visit_type_uint32(v, name, &pm_io_base, errp); +} + static void ich9_pm_get_gpe0_blk(Object *obj, Visitor *v, const char *name, void *opaque, Error **errp) { @@ -349,6 +359,84 @@ static void ich9_pm_get_gpe0_blk(Object *obj, Visitor = *v, const char *name, visit_type_uint32(v, name, &value, errp); } =20 +static void ich9_pm_get_s3_disabled(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) +{ + ICH9LPCState *s =3D ICH9_LPC_DEVICE(obj); + ICH9LPCPMRegs *pm =3D &s->pm; + uint8_t s3_disabled =3D pm->disable_s3; + + visit_type_uint8(v, name, &s3_disabled, errp); +} + +static void ich9_pm_set_s3_disabled(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) +{ + ICH9LPCState *s =3D ICH9_LPC_DEVICE(obj); + ICH9LPCPMRegs *pm =3D &s->pm; + uint8_t s3_disabled =3D pm->disable_s3; + + if (!visit_type_uint8(v, name, &s3_disabled, errp)) { + return; + } + + pm->disable_s3 =3D s3_disabled; +} + +static void ich9_pm_get_s4_disabled(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) +{ + ICH9LPCState *s =3D ICH9_LPC_DEVICE(obj); + ICH9LPCPMRegs *pm =3D &s->pm; + uint8_t s4_disabled =3D pm->disable_s4; + + visit_type_uint8(v, name, &s4_disabled, errp); +} + +static void ich9_pm_set_s4_disabled(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) +{ + ICH9LPCState *s =3D ICH9_LPC_DEVICE(obj); + ICH9LPCPMRegs *pm =3D &s->pm; + uint8_t s4_disabled =3D pm->disable_s4; + + if (!visit_type_uint8(v, name, &s4_disabled, errp)) { + return; + } + + pm->disable_s4 =3D s4_disabled; +} + +static void ich9_pm_get_s4_val(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) +{ + ICH9LPCState *s =3D ICH9_LPC_DEVICE(obj); + ICH9LPCPMRegs *pm =3D &s->pm; + uint8_t s4_val =3D pm->s4_val; + + visit_type_uint8(v, name, &s4_val, errp); +} + +static void ich9_pm_set_s4_val(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) +{ + ICH9LPCState *s =3D ICH9_LPC_DEVICE(obj); + ICH9LPCPMRegs *pm =3D &s->pm; + uint8_t s4_val =3D pm->s4_val; + + if (!visit_type_uint8(v, name, &s4_val, errp)) { + return; + } + + pm->s4_val =3D s4_val; +} + static bool ich9_pm_get_enable_tco(Object *obj, Error **errp) { ICH9LPCState *s =3D ICH9_LPC_DEVICE(obj); @@ -400,36 +488,47 @@ void ich9_pm_reset_properties(ICH9LPCPMRegs *pm) pm->enable_tco =3D true; } =20 -void ich9_pm_add_properties(Object *obj, ICH9LPCPMRegs *pm) +void ich9_pm_add_class_properties(ObjectClass *oc) { static const uint32_t gpe0_len =3D ICH9_PMIO_GPE0_LEN; =20 - object_property_add_uint32_ptr(obj, ACPI_PM_PROP_PM_IO_BASE, - &pm->pm_io_base, OBJ_PROP_FLAG_READ); - object_property_add_link(obj, "bus", TYPE_PCI_BUS, - (Object **)&pm->acpi_pci_hotplug.root, - object_property_allow_set_link, - OBJ_PROP_LINK_STRONG); - object_property_add(obj, ACPI_PM_PROP_GPE0_BLK, "uint32", - ich9_pm_get_gpe0_blk, - NULL, NULL, NULL); - object_property_add_uint32_ptr(obj, ACPI_PM_PROP_GPE0_BLK_LEN, - &gpe0_len, OBJ_PROP_FLAG_READ); - object_property_add_uint8_ptr(obj, ACPI_PM_PROP_S3_DISABLED, - &pm->disable_s3, OBJ_PROP_FLAG_READWRITE= ); - object_property_add_uint8_ptr(obj, ACPI_PM_PROP_S4_DISABLED, - &pm->disable_s4, OBJ_PROP_FLAG_READWRITE= ); - object_property_add_uint8_ptr(obj, ACPI_PM_PROP_S4_VAL, - &pm->s4_val, OBJ_PROP_FLAG_READWRITE); - object_property_add_bool(obj, ACPI_PM_PROP_TCO_ENABLED, - ich9_pm_get_enable_tco, - ich9_pm_set_enable_tco); - object_property_add_bool(obj, ACPI_PM_PROP_ACPI_PCIHP_BRIDGE, - ich9_pm_get_acpi_pci_hotplug, - ich9_pm_set_acpi_pci_hotplug); - object_property_add_bool(obj, "x-keep-pci-slot-hpc", - ich9_pm_get_keep_pci_slot_hpc, - ich9_pm_set_keep_pci_slot_hpc); + object_class_property_add(oc, ACPI_PM_PROP_PM_IO_BASE, "uint32", + ich9_pm_get_io_base, + NULL, + NULL, NULL); + object_class_property_add_link(oc, "bus", + TYPE_PCI_BUS, + offsetof(ICH9LPCState, + pm.acpi_pci_hotplug.root), + object_property_allow_set_link, + OBJ_PROP_LINK_STRONG); + object_class_property_add(oc, ACPI_PM_PROP_GPE0_BLK, "uint32", + ich9_pm_get_gpe0_blk, + NULL, + NULL, NULL); + object_class_property_add_uint32_ptr(oc, ACPI_PM_PROP_GPE0_BLK_LEN, + &gpe0_len, OBJ_PROP_FLAG_READ); + object_class_property_add(oc, ACPI_PM_PROP_S3_DISABLED, "uint8", + ich9_pm_get_s3_disabled, + ich9_pm_set_s3_disabled, + NULL, NULL); + object_class_property_add(oc, ACPI_PM_PROP_S4_DISABLED, "uint8", + ich9_pm_get_s4_disabled, + ich9_pm_set_s4_disabled, + NULL, NULL); + object_class_property_add(oc, ACPI_PM_PROP_S4_VAL, "uint8", + ich9_pm_get_s4_val, + ich9_pm_set_s4_val, + NULL, NULL); + object_class_property_add_bool(oc, ACPI_PM_PROP_TCO_ENABLED, + ich9_pm_get_enable_tco, + ich9_pm_set_enable_tco); + object_class_property_add_bool(oc, ACPI_PM_PROP_ACPI_PCIHP_BRIDGE, + ich9_pm_get_acpi_pci_hotplug, + ich9_pm_set_acpi_pci_hotplug); + object_class_property_add_bool(oc, "x-keep-pci-slot-hpc", + ich9_pm_get_keep_pci_slot_hpc, + ich9_pm_set_keep_pci_slot_hpc); } =20 void ich9_pm_device_pre_plug_cb(HotplugHandler *hotplug_dev, DeviceState *= dev, diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c index c6d31a3957..13aa05b221 100644 --- a/hw/isa/lpc_ich9.c +++ b/hw/isa/lpc_ich9.c @@ -689,7 +689,6 @@ static void ich9_lpc_initfn(Object *obj) IOAPIC_NUM_PINS); =20 ich9_pm_reset_properties(&lpc->pm); - ich9_pm_add_properties(obj, &lpc->pm); } =20 static void ich9_lpc_realize(PCIDevice *d, Error **errp) @@ -950,6 +949,8 @@ static void ich9_lpc_class_init(ObjectClass *klass, con= st void *data) ich9_lpc_get_smi_negotiated_feat, ich9_lpc_set_smi_negotiated_feat, NULL, NULL); + + ich9_pm_add_class_properties(klass); } =20 static const TypeInfo ich9_lpc_info =3D { --=20 2.43.0 From nobody Tue Jun 30 07:34:11 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1782127601; cv=pass; d=zohomail.com; s=zohoarc; b=mh9GhJ5v8mojZWJ0hSBiQNLCLYuwWeMQ+f4vSmfTt5PMV5mM7XSLr3KpDPO49V2ZrHxOAeCGSmcKJ/x7g8S3PTT+htLDwZaNcarYGVSiO+L2R4S2moqDstue0bdGaYNi3QtIIE6VYOtyjCqWQUmfprRnF8Um03/vIy6XOD3XSys= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782127601; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=+Lu2SXO9UuDdhfIkmsloi4TsiyWy621OrD3f1EcI7ME=; b=SXxMY1lNOiI340AAnBFDO1bzqRDrbD/TsRF7B6iymoS4iqsU3akcnRGv6e+OukySRdXOn/0MrUERDOIxIWsRSWf6XHwRmkjDbGpeCJf/MbLzcTIWp9Ee/JtGwUwB0ZPgKe3Llkw8lNfT0iMX4qz7/2rZbWIxgmuj3AtPB3Um1Cc= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782127601086253.87407788050825; Mon, 22 Jun 2026 04:26:41 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wbclv-0004QA-F7; Mon, 22 Jun 2026 07:24:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wbclm-0004JR-PK; Mon, 22 Jun 2026 07:24:51 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wbclj-0001Rb-TE; Mon, 22 Jun 2026 07:24:50 -0400 Received: from pps.filterd (m0127838.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65MAp1Sk4151181; Mon, 22 Jun 2026 04:24:28 -0700 Received: from sn4pr0501cu005.outbound.protection.outlook.com (mail-southcentralusazon11021078.outbound.protection.outlook.com [40.93.194.78]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 4ewtdukeg3-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 22 Jun 2026 04:24:28 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by DS0PR02MB10661.namprd02.prod.outlook.com (2603:10b6:8:1f8::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.139.20; Mon, 22 Jun 2026 11:24:26 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%3]) with mapi id 15.21.0139.009; Mon, 22 Jun 2026 11:24:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=+Lu2SXO9UuDdhfIkmsloi4TsiyWy621OrD3f1EcI7 ME=; b=Cw3se2L6RnOA7SAXcHizCUj8SdZvtyVRzaYRgD6UwWmIGylyyNW5C+++9 hjLmDJRTeRTSn287SS81jT9jmGKSNeLQ1R1QGHiqw3mWuzSIRINN2GKQjSUPUG8s hX+d4+zJKaTTyp6lcSX9Pu7jhCzq6yAJu6er4dh94wBDGrYWBs7HhWjQCQUgnN2r y1q79SeOVIQJ0apQfKQmsZrr3WV+hEL3/eJLaGC3/moiugL20p9zNQwwdewa1T// vbp2PA6jEEgPoj1EPilGkVLMPOn5UQJ4lmEgvELgIvBiN6s4/Yf9nWNrOJs3KLfw 42CvuXjDTbQqAt9U5bg0sM4ZF692A== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Nb+EEQ8jfSduK0jnxw/SoaaIedYEObfNGFIOmKs4Wg0Q+31LefZoxB4NhsDzuBsiu9YlcHchH/UcDk6pRk8fvp57HXcBoh3YJfR/zwESP+5hsIsCHCdn1NUloaWohmh9LqG30r+udzsPaBHkqbkFAup3U7Qm52A4hbnoTm6UMnClGhaFlv8SVuZftsxSEIfw2ATwsYnkUhqRIn5lGNqrBCFb4kRNKOCE72tSbGS1Mc/tnlj0HlBucHdwwQtkz3cH51zC5vTCtw+j8scfHZAf2ND9UQ5CazOXVi29eKt/+V4pxnv459L9AHHkvMn7LqmFsMrQVtpJ1n806LM8NpPOpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+Lu2SXO9UuDdhfIkmsloi4TsiyWy621OrD3f1EcI7ME=; b=fpa6u2vGz1Wbk5It7X3VOl13sPUkGEvau6dOQAu6faXriFtBg326GSMVUYqGDFbIaDmA5vKq+qk8r6uKLxM3pw/yV1hJftzX1c2h+MzQnoR1ATt2kFxD7z1enR8sRWLm//ZvC71dkCHHe35Bt6G515uoYG/wvY+4vHCfi9F1mrJQRemyycyc6DTqmQEXnYBlTrWsp2hKIFA5WXXbb9JcRDu6OfhBT8v+50gyNa7bHJX1HO0unrFm54qNVmIi0w81XwGlQjq4gxwQXsOksoZ5CLTdxW11K1QObTO8K5CwGRTpm1B/+S3a2L49dv3odlk6FsAKP8y7XQ6gtciYkKYbRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+Lu2SXO9UuDdhfIkmsloi4TsiyWy621OrD3f1EcI7ME=; b=Clc882ixV9+sPLaodQjeweWi+lbuWstn64pK/HgKPgD8Erh8OFW6frLABJUeKpFS0ADxC+4SYWfBaIim9RzPYyQy+BI7UhBH8B+L1nofhDUvrU7XS+ehoZ5HZ2wf1SC2FjPmP7j4TfaJAxhKTGoITnizOAFAPiUZN0EN8x9ZRLe+p/ZddApnQQOcpfunOXtQ0W9K5/YCOHMeLsBtxAi2O/m6h1mjPfSL1/8tvreg8EHrGULPLQC0Cfe9Go8ja9CTZS/dEkw4hh9FoXtH8BLksw3jwdFekfGzjgI32VW3Vr2K4QTZQa926OrHDrGGE6uAYYjETqlnlXSF2W8r+anzPg== From: Mark Cave-Ayland To: mst@redhat.com, imammedo@redhat.com, anisinha@redhat.com, philmd@mailo.com, aurelien@aurel32.net, peter.maydell@linaro.org, pbonzini@redhat.com, richard.henderson@linaro.org, qemu-devel@nongnu.org, qemu-arm@nongnu.org Subject: [PATCH 5/7] hw/acpi/pcihp.c: convert ACPI_PCIHP_IO_BASE_PROP and ACPI_PCIHP_IO_BASE_PROP to class props Date: Mon, 22 Jun 2026 12:22:37 +0100 Message-ID: <20260622112403.928954-6-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260622112403.928954-1-mark.caveayland@nutanix.com> References: <20260622112403.928954-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: CYZPR14CA0017.namprd14.prod.outlook.com (2603:10b6:930:8f::27) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|DS0PR02MB10661:EE_ X-MS-Office365-Filtering-Correlation-Id: ff35078a-7dc5-4f45-2818-08ded050d15e x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|7416014|376014|23010399003|1800799024|22082099003|18002099003|56012099006|921020; X-Microsoft-Antispam-Message-Info: /NQu3r6CZzRy15+HlSnX6C1DExkcn7ednyx0mQgS4ksEYAi/fY9i7VXAAUwg5qBZam4GdEgPzp7bUj+KTHtuX5B5oKm/wRAeFiJB0+rptr69gvHbxgh7JFB6G+Z0RVdL1Fy5tBrq51TBfD7PuDB82Zjo63B/6BBlZfutCO+CJjesG517IsSepAxZvTkRzbHtV+6+s+tobnz6onM6HrVvGoMV3OZklyRJNBhb9icB75gOaj2PRFRijXp59J/P2A+VAzW3X7cpvyMEXaR9FezFBd1lxtMQ2v+iAjtitbv1/6I3gvm/9WKBOsg8G+0U1NjSJKY1kuaZRRc3w+LgO9Ad43kmGrikA6sZo5HRBcqv8lL6ZceYmGE4/VO+XLH9R/0oWkYb1rsAt8zZtrgpsPzM6WEyoagu3VOkXGIrIMamGoTHEGzU7BR1MtUE6w+7/XEL97MARAXpTtEivW44DeYA2XqjhOYmsj9T++OUmWygsZbvsh6DLnNoqEEJmLk5iCKkiD4vZXDU55/EaKvGZvGavZUrDjOZ2SCUS4cXozbieeV6OeXIex0qPq4nsZl8ziYAQghikyjVPzxhRhAf01xKazJRHnaxJD+cnn3vdniNcpGauZ24oVkrz+6etn6MS716CIvCgi7/pN3Wvafd8AFs1QhbWd2+EjsIyCDYzqNMFeyoanUYY90RxKSSn4VDX4SjF8BJx4evDCSPn+rINGndpQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(7416014)(376014)(23010399003)(1800799024)(22082099003)(18002099003)(56012099006)(921020); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?luvGpgtxg+b6KtI3MthC9VEh1sI4OuZijWudoSWGnXdbVZ5fmJxq3V7h5l91?= =?us-ascii?Q?M1IjHE4cdSfMM5NTT1iePMS3WtuE5fgl3zo4iJXLaF833N5EQXaGnGB3TrYD?= =?us-ascii?Q?th+xlHu8EGgPVadDyGDra+NF8hBYr99bxgf/Fk0QQRBkRyC/raUYwjkbavbw?= =?us-ascii?Q?cjjsV1IapBbM5L1m1dOVRwY2GVbWtSEmsuAq8/e1wTzO3Mx9ibwof0rZXG0q?= =?us-ascii?Q?4CezDKxElQGd89Fmh+KZvH0Kl4yNOrJEme+D3r1FbqnZxWdDwZt9q6IALwDU?= =?us-ascii?Q?agdFU2hutlvTRw0/RMgtdSSUcCzGr1STatMTt5+l9OJqMt/CNT7p58LH4H10?= =?us-ascii?Q?fmPHgA2bK+kZb1o53KuvSR7WqayRBxKS7d9YfTcvslrafj1mBg3nLVUIAJU2?= =?us-ascii?Q?jNfGrMntLvwWOC8wvjnug2/mzi7QdkH5HdJ0JKOiImrEaD1tMzsfudJJvOZ/?= =?us-ascii?Q?0R3z8D3n2/NO71GNDawQjvyU3rtvKXCiSDnQgBr/2v9xv2AbK2Y7lEmSjzjV?= =?us-ascii?Q?KPNpVL8hCUPRsxrHPTBMqauGOesi0BAFW6qGFlD+f9RCUtsfr7l0FefAPOwl?= =?us-ascii?Q?Wa6+b1P3Fc+CgoxM5sUEVTdfFDLhh5LS92jPAk+uUP++6tt6wahhrImdT8CF?= =?us-ascii?Q?kYD7gmNDc0E2c6Lh0wfkQqzc+H+6UP/vw/i3ed977/7jJWXF8Pd5GyZd46LU?= =?us-ascii?Q?bwQIpir06zbz4Bqvw4MT0OEW0cLbYdNIZB5eYlnXM2jIp7mRwOalH3AO5Bpf?= =?us-ascii?Q?ucwHoLx6FBrCQ3CbquCXunYrhwkGjTIq+s1olK+AEYot9tI7sMJ/szS6VFCY?= =?us-ascii?Q?nQF7rewFyHI/Ryt8Xi0KWozMZpxvF3Uo5zm9PdSs57zuKcAZFdulXliiGudG?= =?us-ascii?Q?UoY96SsOm4+4aan1TBN6nIBZeYoI1K0fVO8NvXPNsgwuCjjs2bQjLHp3HYTK?= =?us-ascii?Q?D+fx+Peao2c6Bcf2+pzARNEW/Zg+q85EP7iE/UewaObalyxk3JYC3qnHLSaj?= =?us-ascii?Q?ewUA9YTnr1rW4ohQqFCHErIVn0YhLNeltgxDUzminpIfzrxKmFLffSQjvuRC?= =?us-ascii?Q?KyzKq4W9x9k1PSGl9L2tMiaaYkKFpPJYwWle85o3y3QvX3i3mGkfNOIajw0I?= =?us-ascii?Q?qowoquSOwtAGZSHy1OiaZRT9RjeG/Qvz8hokZNxT+IIEpmW1A6cTqlNZ+cnH?= =?us-ascii?Q?37BzBKSk0hHpISvEq3F/44Fdfv8xrHEM/TBczvRX9/o5WD974IJB5f4NxpQy?= =?us-ascii?Q?XScZLATwI0U4Cq7IfCLbpstPpSGlaGlF6dd+Rkt1RB752v99O77I3f3dklCJ?= =?us-ascii?Q?uzBuwmOTjoFSTO/RfxM77ztE0Px9RnElYr9ja/9DB98Jp+afxXSywIL+SVRa?= =?us-ascii?Q?Nuw6NbOPp3JXjpu2Oy9U8Sm7xEcJQpZoThbCYGEppBReISAKMICPjbiSwEu6?= =?us-ascii?Q?f8TzjVYTw/xphi7MXmIl3ouLZH7nu89EHlvSQ2T41C2/SCFuLWCJetmKH6tK?= =?us-ascii?Q?ybeaD9xbpp9Yi4I0f3e34wFF7Kkhb09kULCBRhwj5U5wR+I4YWzoSaXeK2gZ?= =?us-ascii?Q?V2Sq5JQXTBx20ZB80CXrJwofCmASu6TcZCiwaVgS3KcvUwsQq6NT/daelWKF?= =?us-ascii?Q?JO1zwDkomrqH9agc4Fi21tsXgnETDqj0SF+pc6xPx2AYTBJs4DgMu0XjOSWh?= =?us-ascii?Q?tG6Gk6JoxonCFRtdUfaKedEIyn7X9Ks/PrVUkgoqZfvHuLvCEY8sncUDBxXD?= =?us-ascii?Q?DNCpFEiM0tPMxjb+RFoL6Bx0cClnVUw=3D?= X-Exchange-RoutingPolicyChecked: RjyeEN6E2LcgdPRsitJwooU05xix12ju1QM/+ETtftDVetNDiI8fTHD1Gq0sU70bceO1yPnISwU3RjDanUztJ90C1q6+SxwvLPmNb03+JXjway4nwHFXNMSy++gzReBhSV/56TU/cx8l5TxqkMWghYdOAK1S4uUtnW/zJhoQ2yF+9scMX0RfuYCWjZ7VwT3vqADS046LtPWxGabwKLd+LdVt8VozRHc88UPu7ln2ZBKuP7mWZCwcE4fkd1w6V9f6ZQvUHJCJ+4CBeUzYiZ8wnh7/w6YYp48I8qrowba+3dSVA7/P+y8CqLHMfj0xFy1LiEGNEanWfWYLSBHdkRWfvQ== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: ff35078a-7dc5-4f45-2818-08ded050d15e X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2026 11:24:26.5014 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SK5a4TmHIqRJyneiV4+lACmW0pjXuGuLQzdj/E3bXc7jWY8vMChjpyj8hy2KlBIDCLmJuhHsbS7jkpL1bYVsxzH0d4chOYnzjNzCjlnhuHw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR02MB10661 X-Proofpoint-GUID: FFeqwErc_ux_eRtzZgSonFi8eTw9EwBO X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIyMDExMiBTYWx0ZWRfX3EVEpk9kkpVj 7mNcKX+pgl24tNgOVquWtVFU5Acrk2S02nZALjsodvAmFWNo3Bg9rywd08Tf1nUPS55tznlamsL 8HPe+NaJndcEotyRQHa5Kp74CtqZU04= X-Proofpoint-ORIG-GUID: FFeqwErc_ux_eRtzZgSonFi8eTw9EwBO X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIyMDExMiBTYWx0ZWRfXww1gsbmhV0Yn rww/+zbuOdBahEcCKRKzi5/if1HYKbCaOf/A5KBFWXx0JBgTYLz5OQeSjIJYXt6kx/hbBOfm26I Ps0p6DcmpNG7H5erDL3AtL30qa3LklFaWcxBSKH2Q1x43Aco7Ra7aWnzXcyBZdlQWSR11/EZ5cV OhF4lBBoAz2X2DlFLs0BXVgEvvGDnBq0d6fUgM/4FlW0DnLaITSuZHZdFaanuGPPm65rtsD7FVl V3GwZVAbKGFyaaXtFAi7FYoN1bW2W/FFXFO8CutFNHAbQLtC90xy88w0IZfUwrXUuT+UU+JhDyl bJkuAbZuWMy5HqFhNY+lc7IPr6MxmTnocv8O5J2+eRnt8oPGmMaq/+fGf9ot5q89WXDJhr7bTmR Cexg24ZankAa+oBETRI3uYq/Qv2mx0ni2amsU21BLnP18GgzgyHwmA4ip52biGmE7CxWb5Lc89k WNK7+OcZhQck1Ci2l9w== X-Authority-Analysis: v=2.4 cv=VpITxe2n c=1 sm=1 tr=0 ts=6a391b6c cx=c_pps a=XqXlOjMxTw5Mth5+b1Cu5Q==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=FelO9ux0wxsA:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=1L6crL_YRTbalZ11mEUO:22 a=64Cc0HZtAAAA:8 a=JIIPeFsblN8ZPbdJE3EA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-22_02,2026-06-18_03,2025-10-01_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1782127603130158501 Content-Type: text/plain; charset="utf-8" Since the objects referenced by acpi_pcihp_init() do not inherit from a com= mon class, add ACPI_PCIHP_IO_BASE_PROP and ACPI_PCIHP_IO_BASE_PROP class proper= ties to each referenced object and remove the object properties manually added in acpi_pcihp_init(). Signed-off-by: Mark Cave-Ayland Reviewed-by: Daniel P. Berrang=C3=A9 --- hw/acpi/generic_event_device.c | 30 ++++++++++++++++++++++++++++++ hw/acpi/ich9.c | 30 ++++++++++++++++++++++++++++++ hw/acpi/pcihp.c | 5 ----- hw/acpi/piix4.c | 30 ++++++++++++++++++++++++++++++ 4 files changed, 90 insertions(+), 5 deletions(-) diff --git a/hw/acpi/generic_event_device.c b/hw/acpi/generic_event_device.c index 9e9416d406..1fc2798d53 100644 --- a/hw/acpi/generic_event_device.c +++ b/hw/acpi/generic_event_device.c @@ -11,6 +11,7 @@ =20 #include "qemu/osdep.h" #include "qapi/error.h" +#include "qapi/visitor.h" #include "hw/acpi/acpi.h" #include "hw/acpi/pcihp.h" #include "hw/acpi/cpu.h" @@ -357,6 +358,26 @@ static void acpi_ged_send_event(AcpiDeviceIf *adev, Ac= piEventStatusBits ev) qemu_irq_pulse(s->irq); } =20 +static void acpi_ged_get_pcihp_io_base(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) +{ + AcpiGedState *s =3D ACPI_GED(obj); + uint16_t io_base =3D s->pcihp_state.io_base; + + visit_type_uint16(v, name, &io_base, errp); +} + +static void acpi_ged_get_pcihp_io_len(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) +{ + AcpiGedState *s =3D ACPI_GED(obj); + uint16_t io_len =3D s->pcihp_state.io_len; + + visit_type_uint16(v, name, &io_len, errp); +} + static const Property acpi_ged_properties[] =3D { DEFINE_PROP_UINT32("ged-event", AcpiGedState, ged_event_bitmap, 0), DEFINE_PROP_BOOL(ACPI_PM_PROP_ACPI_PCIHP_BRIDGE, AcpiGedState, @@ -608,6 +629,15 @@ static void acpi_ged_class_init(ObjectClass *class, co= nst void *data) =20 adevc->ospm_status =3D acpi_ged_ospm_status; adevc->send_event =3D acpi_ged_send_event; + + object_class_property_add(class, ACPI_PCIHP_IO_BASE_PROP, "uint16", + acpi_ged_get_pcihp_io_base, + NULL, + NULL, NULL); + object_class_property_add(class, ACPI_PCIHP_IO_LEN_PROP, "uint16", + acpi_ged_get_pcihp_io_len, + NULL, + NULL, NULL); } =20 static const TypeInfo acpi_ged_info =3D { diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index 723a87e6f3..71c3735eec 100644 --- a/hw/acpi/ich9.c +++ b/hw/acpi/ich9.c @@ -477,6 +477,28 @@ static void ich9_pm_set_keep_pci_slot_hpc(Object *obj,= bool value, Error **errp) s->pm.keep_pci_slot_hpc =3D value; } =20 +static void ich9_pm_get_pcihp_io_base(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) +{ + ICH9LPCState *s =3D ICH9_LPC_DEVICE(obj); + ICH9LPCPMRegs *pm =3D &s->pm; + uint16_t io_base =3D pm->acpi_pci_hotplug.io_base; + + visit_type_uint16(v, name, &io_base, errp); +} + +static void ich9_pm_get_pcihp_io_len(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) +{ + ICH9LPCState *s =3D ICH9_LPC_DEVICE(obj); + ICH9LPCPMRegs *pm =3D &s->pm; + uint16_t io_len =3D pm->acpi_pci_hotplug.io_len; + + visit_type_uint16(v, name, &io_len, errp); +} + void ich9_pm_reset_properties(ICH9LPCPMRegs *pm) { pm->acpi_memory_hotplug.is_enabled =3D true; @@ -529,6 +551,14 @@ void ich9_pm_add_class_properties(ObjectClass *oc) object_class_property_add_bool(oc, "x-keep-pci-slot-hpc", ich9_pm_get_keep_pci_slot_hpc, ich9_pm_set_keep_pci_slot_hpc); + object_class_property_add(oc, ACPI_PCIHP_IO_BASE_PROP, "uint16", + ich9_pm_get_pcihp_io_base, + NULL, + NULL, NULL); + object_class_property_add(oc, ACPI_PCIHP_IO_LEN_PROP, "uint16", + ich9_pm_get_pcihp_io_len, + NULL, + NULL, NULL); } =20 void ich9_pm_device_pre_plug_cb(HotplugHandler *hotplug_dev, DeviceState *= dev, diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c index 87162ff2c0..a91f523c93 100644 --- a/hw/acpi/pcihp.c +++ b/hw/acpi/pcihp.c @@ -502,11 +502,6 @@ void acpi_pcihp_init(Object *owner, AcpiPciHpState *s, memory_region_init_io(&s->io, owner, &acpi_pcihp_io_ops, s, "acpi-pci-hotplug", s->io_len); memory_region_add_subregion(io, s->io_base, &s->io); - - object_property_add_uint16_ptr(owner, ACPI_PCIHP_IO_BASE_PROP, &s->io_= base, - OBJ_PROP_FLAG_READ); - object_property_add_uint16_ptr(owner, ACPI_PCIHP_IO_LEN_PROP, &s->io_l= en, - OBJ_PROP_FLAG_READ); } =20 void build_append_pci_dsm_func0_common(Aml *ctx, Aml *retvar) diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c index 9b7f50c7af..4bfe3caa0d 100644 --- a/hw/acpi/piix4.c +++ b/hw/acpi/piix4.c @@ -32,6 +32,7 @@ #include "system/system.h" #include "system/xen.h" #include "qapi/error.h" +#include "qapi/visitor.h" #include "qemu/range.h" #include "hw/acpi/cpu.h" #include "hw/core/hotplug.h" @@ -405,6 +406,26 @@ static void piix4_pm_machine_ready(Notifier *n, void *= opaque) (memory_region_present(io_as, 0x2f8) ? 0x90 : 0); } =20 +static void piix4_pm_get_pcihp_io_base(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) +{ + PIIX4PMState *s =3D PIIX4_PM(obj); + uint16_t io_base =3D s->acpi_pci_hotplug.io_base; + + visit_type_uint16(v, name, &io_base, errp); +} + +static void piix4_pm_get_pcihp_io_len(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) +{ + PIIX4PMState *s =3D PIIX4_PM(obj); + uint16_t io_len =3D s->acpi_pci_hotplug.io_len; + + visit_type_uint16(v, name, &io_len, errp); +} + static void piix4_pm_add_properties(PIIX4PMState *s) { static const uint8_t acpi_enable_cmd =3D ACPI_ENABLE; @@ -607,6 +628,15 @@ static void piix4_pm_class_init(ObjectClass *klass, co= nst void *data) hc->is_hotpluggable_bus =3D piix4_is_hotpluggable_bus; adevc->ospm_status =3D piix4_ospm_status; adevc->send_event =3D piix4_send_gpe; + + object_class_property_add(klass, ACPI_PCIHP_IO_BASE_PROP, "uint16", + piix4_pm_get_pcihp_io_base, + NULL, + NULL, NULL); + object_class_property_add(klass, ACPI_PCIHP_IO_LEN_PROP, "uint16", + piix4_pm_get_pcihp_io_len, + NULL, + NULL, NULL); } =20 static const TypeInfo piix4_pm_info =3D { --=20 2.43.0 From nobody Tue Jun 30 07:34:11 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1782127594; cv=pass; d=zohomail.com; s=zohoarc; b=EHMWYGOfui1ywV4cvv26MfkD2mI4jmhraDqi54D/N0fj1gzROxVzybh+ixQW+STNG6e38sT6TMvLcmhOyWpTROrb270MSg8PSchxig8uaLGLTK33So7TNze5TL1oRPue7eviiqcVm+qXSt+br+XkTLJ46JXqn+K3+YY7k3DuBV8= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782127594; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=0zhSjSSxs+i/zAV56gvprgI1Lwa0jdNlpo3l3gmA1cg=; b=TwSL+SxXU88kKwMh3k97+ThI6hcFfc3ZHefJtcUZiBQmE2UE3TlGmoVaUVgmWyeGnbgz3oNx5GsmA4Lw6cvWUx6DoCwjSWLOOcAoyMcJijl85FNBafKgJ5TGcS3KNqMuko+tg6JroeQawhHJy5ZQPFhcjzi9/9FW0Wg5dZ0qUWs= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17821275946721014.6513953590737; Mon, 22 Jun 2026 04:26:34 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wbclv-0004QC-KT; Mon, 22 Jun 2026 07:25:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wbclm-0004JS-Uj; Mon, 22 Jun 2026 07:24:51 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wbclj-0001Ri-Rq; Mon, 22 Jun 2026 07:24:50 -0400 Received: from pps.filterd (m0127839.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65MAq4r14141595; Mon, 22 Jun 2026 04:24:32 -0700 Received: from sn4pr0501cu005.outbound.protection.outlook.com (mail-southcentralusazon11021109.outbound.protection.outlook.com [40.93.194.109]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 4ewsxd3fa3-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 22 Jun 2026 04:24:32 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by DS0PR02MB10661.namprd02.prod.outlook.com (2603:10b6:8:1f8::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.139.20; Mon, 22 Jun 2026 11:24:30 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%3]) with mapi id 15.21.0139.009; Mon, 22 Jun 2026 11:24:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=0zhSjSSxs+i/zAV56gvprgI1Lwa0jdNlpo3l3gmA1 cg=; b=fULywHYw7yr5GG0j08v12eqnPwIa3+tvIiGAmGdFXFlu9OAfN4seoHL1l F3ytZWurPY1yzCbtW/er0ZiolKFTlC1exVFKm7HzvX1Iwtdrosz2lD3UmagTyNzG 70UTYyOSZggLMC8VxcBuJdx76goJWhbjfOBw78LQ8wf4w5uuOayrOhiFuGuSkGEZ yaVq6eqYLMpJtyWOh1MJgBzBAmYfDQ2LMqsA2axgtqjwwpZ9yzLp2eYfBvpckRJj /xQhRMAeDQcBwbMZnxsl8gfbFLqG7Mrm0sHh+N0NrlVasrff8qcK6kdZMufVgFGR 81p+lh3GOvhFaCHITnrZmXl5VyPxQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=i4jyfYw2n2oAy/ujHKE1rRJjEuMfpeIikVlfF/CbMD/4IGNq9r/qefhfAy0vo1Chl3rY7BCoCTqOVevaSi4FLWqNlZgHz7E2evPKS5jISvamI4RejItdPMR6q6WciYYL2qD0TYrzQatwPVdPQ/bvxVKStaaU3ZWtowCM9uv3iVvKOmmKIBPd8So2qUCvKgaJ/u0aS9dbe1MOH1I5EH1NV/no8tNMNve+1OADbOPCkD+ujQqMU6Ga/PJHy+3Q1cibnO6d/FepyuRvMQF1FElGliLahJu9Q/gbVchUnPPoemF7I1o3t4B/MXcejAXBAn4JPynPBY6z1DwxcESMQbpmvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0zhSjSSxs+i/zAV56gvprgI1Lwa0jdNlpo3l3gmA1cg=; b=GAh7xb2ZC/lcFzotIzigU1FBKSvrzlb3c/6yiRMEbC0X8RVQAGDZWucnTih2emLMaN+XK1BMhhFv8Sq6mZbU6cVfZb2vBQfiEXTPIe3IaPtMk0/exqAI8dcEhALh3hP6bgaGXI64K+/7YCJY7INB2CjdMfpJkvb1WFI+G/oWhZZ1DfaV7dghSQcQWN/0rVwt8vUVP/3KmnTyQVABZerNwgu/0U3DMScP8XmTXeReSaB7spm8WtQw46eYXHYA58IHyRp+WGfy00mHUz8/s5bYKN6AMRIgdWeivvelsJUiMpFYMC3XG7H7eU4vJM5UpWuZXb7i3H8SJXXtfzPMzODvOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0zhSjSSxs+i/zAV56gvprgI1Lwa0jdNlpo3l3gmA1cg=; b=aP9LRkKygYb9XWuTauuuqTvgT1GR6JrOzgGs7u6/HZ/u9ugpvapOo7TJR/wF2yqRYBI44hSV03bDOL+tZ/EdefbiEeQU+lwdvG6ILSAscuQHcy82kGHUKL3QpseIRx/AvJ1jnRkYkwClTPDMxuCRW4/TBSsAH9hUDb7BFkAV+Tt48szliUzGsHXhrrB8yjmXcEH28p1/VpNBOwtP9+K+rWfSc4KIC/Jn+KA5/AvELTOm06SUl8Q6vmKCIaQBGqiXeKb/V5CjL+5F2tsug48dFQrJJ4Svxk1QGnyDq0ru+mlZyVN4vFwuNJM9uJk8LYY3tXeR66NfavhQuFtbdvikGA== From: Mark Cave-Ayland To: mst@redhat.com, imammedo@redhat.com, anisinha@redhat.com, philmd@mailo.com, aurelien@aurel32.net, peter.maydell@linaro.org, pbonzini@redhat.com, richard.henderson@linaro.org, qemu-devel@nongnu.org, qemu-arm@nongnu.org Subject: [PATCH 6/7] hw/acpi/pcihp.c: convert ACPI_PCIHP_PROP_BSEL from object prop to class prop Date: Mon, 22 Jun 2026 12:22:38 +0100 Message-ID: <20260622112403.928954-7-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260622112403.928954-1-mark.caveayland@nutanix.com> References: <20260622112403.928954-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: CY5PR19CA0090.namprd19.prod.outlook.com (2603:10b6:930:83::13) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|DS0PR02MB10661:EE_ X-MS-Office365-Filtering-Correlation-Id: e2aa828d-7cb1-43a7-bb52-08ded050d3dd x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|7416014|376014|23010399003|1800799024|22082099003|18002099003|56012099006|921020; X-Microsoft-Antispam-Message-Info: C0i7tRj0QNfZetrmvm2JOuoFBjuwTjW1eau/S2JJPPR1n9Yj98rJI/YOOsgVdoIUpdA/DNe5FXfUflXZl9ZGcCj3LhnXNmiGs0CR8oZQIC22OdoLbP6wGzv0B4+6UwJQo2R2geb6lFOyEtlQy6enEFkD8nhwcWsNXJ6nKNs8ixd8P+B590v6p1pK2VFmcct2IIFuEpSdmUPI4kHEP0FjM/ZhuZ3A1qObQcIvYs+BbxVmBqLE/kRhE4IG2EUEwDP+3GYo04jSTnniJepXUeKuzOsR3pb6DAxGuLb0mjyHXApx43JFcamPtzQMEgZSelAJaLN57ogiXM0WHMgxBT9VzgRglKKKQjGFS1TM8SG9A+hMSv7IY5DZKNEQffPLCyFzyMnyQmmf9VAZWC2N6v+EQ+9igmHa+x3yMN9/S6ind6b4ThiNjcI1gG7zyY8C/cqofgDxC2DMcRVJjaIKFQI6TxZsWvnN1TDjNXrn5GbMuu7XgULEJFVaDumAC8hK2vclCXgmJAdR/hO58R8svO2v783rxGdL17Dc38bDW78NtnNUb08QMlKrRE5yPoflWupgEbobYX+ZOj01XSSZ90cGbWkXUayDtLMmmIt2UKL4DWfVplSPQqELRbomcoUH7j0ZLRWFXE0DcEbsLrR0CJ4CSvUkHR4tP6h/UHjRratQTF3zDBOiS2ABBGeLGnvSav7O9SgECniGIrfRT0wDSMOROQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(7416014)(376014)(23010399003)(1800799024)(22082099003)(18002099003)(56012099006)(921020); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yBIXp2gEuV01K1YRtjqOJOF9T6jCKsgSS7fZGdb/zrNILFxpKEsJSwPTYFOL?= =?us-ascii?Q?0mrZcIFiAhbU51MN3qgyIk4pLaZWYWeYuj7mJ31GbCvFZdJ6Sr1qg/a53sAQ?= =?us-ascii?Q?8suWm5v3z3KZFtVoVCQ+ul0n37Uf/SV6PcE82W9T04y4FKuWpkE2iTHapOV8?= =?us-ascii?Q?k9XcRKE4CjSIKe1jfg8zVNDVZQ1NwdBZzpeR4UEAOjNp3Km1vmmegKxjESlc?= =?us-ascii?Q?TOf+Gy1A/xarhXP8ZZkb3fegAn551Gw2IHm5dk3KoglRsrmv/BQaufqzH8ai?= =?us-ascii?Q?sNzWsRHf2axUoMRbb4WJ5vFWug32ohFqNhVXqobASlJ67QO+wH1q3TZiiagz?= =?us-ascii?Q?MH36S23bs1jo9vYs7ncH6ryitQds9hUuLrLrNwYZ3D3BFKlo/qRLrt+wQkya?= =?us-ascii?Q?qkkpTKJxPvlhnDZ4HXpMg+e86KeRXM2zYpIMAEmIUAs/PnygedRuUTBtamyb?= =?us-ascii?Q?W4K6lmRVzGwwBoxHvaE6hissfOGanpWMB4wgsTiC386SwZAdgy3oUgPny4Vg?= =?us-ascii?Q?y7n0mfp10ZJdxz1FF49BoKXGbHglzsK5mlqxQlMRG2q7lkcY3TeYo3gd6gYa?= =?us-ascii?Q?tKKk+56HKShy05sdqdOkK8MVUbwt3V/G3/1fWIZnvhug8ptkMQTKAYFUC+b7?= =?us-ascii?Q?IXY8mKk6LX7gUvwuox/OXgyI+GpRZuXUHGOKE+o5afRegA7n/cPBrSUWzJkz?= =?us-ascii?Q?Oxw5F46qGfvCOMio7qkbVXsf756b9tNuwMMo7BacGOvE1oheNmtFATXO8WA1?= =?us-ascii?Q?jYAcet1f83se2UKczQj1cro+nfGShqHNvpjsehnIZ08y8ZqZSyS/7qMjRhxp?= =?us-ascii?Q?UAW6aKKUwOJwYnDMq/1YfohemtrAUIFJ38CezyACqLzekMii6KHidxO6ZXmw?= =?us-ascii?Q?inOyp3sDsWkJb+nocsVNPRbA8mVC2w2Y39HSejxIgQN+88w8zhdJxEyRQ4wU?= =?us-ascii?Q?+JxXeizsbfKspZJjkQujUtdq/NsKDicKvuqOFC9YvQY6XEH34QjmTzBSE6QI?= =?us-ascii?Q?sfG6yAo1osbCRxjeRMAyKgUNMZjlK3ieBWco3oP+vAZOO1TjgUu4aNX1U5Pw?= =?us-ascii?Q?aDQoGbNlh1zCFx8aPpGbjWihZZTL+XQAL59+TTo2bu0/fqpaRj5+rYKf/xNW?= =?us-ascii?Q?jpyOLUsy1doFPD0ryyG72D2eq5lSwfUmUcLWCN6Uuu8W+B7biu2Mc2dlRbHK?= =?us-ascii?Q?usjji+YaJJLkMPH5ocXK1DFxAjOSB21hww1bYYCQnc4+X0eelT5MuH92crcj?= =?us-ascii?Q?NmQfZ4iMc95K4xKDHOHESyejLXlO/c8bzLHlQr3L+8cI+RK0hCd0A19VFh7x?= =?us-ascii?Q?RhqygsxCvOxwsRJJ2veYmllQwrDUcHWH6VdiTlpqC0Dr759Ob3GH2KzMgnGS?= =?us-ascii?Q?8A8a0t7iarV120SPGQILQCrwzin2EDdqKJfGhpxIa3Gf7Rfmw/M8ZV4Eu4M5?= =?us-ascii?Q?jkuR8yH8t3FrFRwDR0hOKMW6kREoXN3wK/KAJQKnMo/2PoBbUo0UF18NXKs6?= =?us-ascii?Q?g1S+YdU7H8zi2y+hSIubNDr5dJLnA5M5FC8xpHegyAJXSkF2wSf3AZ9uHTPU?= =?us-ascii?Q?RA12O3Nd8608i6vAjCOIVeeoGa8y0Ev4xyY9hFDk+spS+jtXIXvMeX96ngol?= =?us-ascii?Q?gptSJlcPC8BsGPjbjgsjo+Bh7DxR3wcXAEvG+LRdR/AJvy3zfAWMSb/+IVq4?= =?us-ascii?Q?h/4tHKIXIoDHhOaCpcqYhTw9jZnfUhYksWDmqIEmmOvbIQJKUTtmsk/9QZv1?= =?us-ascii?Q?Hf3LQhn4njldiQbUBNdfz/G6GJDRO7o=3D?= X-Exchange-RoutingPolicyChecked: NPDw8PAE3SIMU3mbwqiBq2/7R7vm+7C/XyRgO1QvT33AV8901wAEk5Covv18CAZ/iBYaBsiJN9BvnH7zitAmz09fze7wsb3xc8qB63kQFVVUOaQ19ujvvuPJhkNOlX0OzDHnoq6JEL9ZJygmUcb5e1FEFukX3nPSoioOnMHeiRrB2lgGysLiW/4LUngREh+l/b2TFhxkrrAeug9VH0jRAbZoDP5JSskQrwONj7A2zpVQDV8AyeNX/XVAj1tOrrKYYwWTGvIeDhbJegYuRs61n3oBbWTKVUuFuGxutYnwDX5MwcQgDF71Ndo8un9IWJA/yhZh9RTCe72q0YWg2D0sFA== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: e2aa828d-7cb1-43a7-bb52-08ded050d3dd X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2026 11:24:30.6322 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qVqHMTndgEexb9kLNVhtQleDlPKfHS960udvZXgAR5z/O6/DQBvZct1ERX7NThMX5lR1fiWxaB88QRZmGA3Boz9qQx936hCSn40UfLKbNZQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR02MB10661 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIyMDExMiBTYWx0ZWRfX2sud1TfVZzMM 38l0G+Y1dp5P5tfO2SpJiu2R4RxKu7w3ADBl0d4ChjReZVHeZYjADiTIcufRGTveSAklCXS61tE G7sJxsgR6grqZeOB1nzojPkKjpp+f/sdQKOvXoOXIqgcej6U74p5hFZXobrwYVVjHDcnPZ6vA29 PXsr/ZzQ7sjwszttkFkj4mLgttkvcuiblPnEmXpKzUaxc+edysGLumlwHrula4EI8rDSH1b5bz2 v62n+KnuPhbQN7MpDNPKCwCPha0D1ZmvhvB4CFDOLHp/YJij4PGz0H2CMS7RfWNo+PiGR6v3HzS TRb4ILRzq1j+Z5UAE0U7eLs6CWh+PLrBIc0y/uBXqoBNP0rosGrPbpRQ31g9aNqwFwuoHa63SgP slunZDjpHEEDPgKBqutzSuw2SKqmQA8o6V3VC1Q4VRnJm1dW1v15jfRaYF2n8ZBBIsWTMrIgpS3 YQQHeQa9UuESqOMnadw== X-Authority-Analysis: v=2.4 cv=WYg8rUhX c=1 sm=1 tr=0 ts=6a391b70 cx=c_pps a=mU+v3NmKB8T18PSzrq+lTA==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=FelO9ux0wxsA:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=y4UcunY2MAxhM4LwGdWI:22 a=64Cc0HZtAAAA:8 a=P6pLB9acsiBn3nJIo08A:9 X-Proofpoint-ORIG-GUID: wHwZ2JW4sJxaP1oNa-v5oeMPjSjHmvI9 X-Proofpoint-GUID: wHwZ2JW4sJxaP1oNa-v5oeMPjSjHmvI9 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIyMDExMiBTYWx0ZWRfX7f4WeWb6v5az WiSzSgKK8Ioz1htIeyObFwOh1RlnypjuTNZPr0AZMGIvYACAdSf/tbbkg93iW55Bd3pWWTrPa0C FpZPPgrbuA10Hq5Wem0TvIBktL6E328= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-22_02,2026-06-18_03,2025-10-01_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1782127595440158500 Content-Type: text/plain; charset="utf-8" Move the ACPI_PCIHP_PROP_BSEL property to the PCIBus object and update all callers accordingly. Since the existing logic checks for the existence of the ACPI_PCIHP_PROP_BS= EL property to enable the relevant ACPI changes, set the type of the underlying variable to int32_t with a default value of -1 indicating that the property has not been set. Signed-off-by: Mark Cave-Ayland Reviewed-by: Daniel P. Berrang=C3=A9 --- include/hw/pci/pci_bus.h | 2 ++ hw/acpi/pci-bridge.c | 9 ++++++++- hw/acpi/pcihp.c | 32 +++++++++++++++----------------- hw/arm/virt-acpi-build.c | 7 ++++++- hw/i386/acpi-build.c | 7 ++++++- hw/pci/pci.c | 32 ++++++++++++++++++++++++++++++++ 6 files changed, 69 insertions(+), 20 deletions(-) diff --git a/include/hw/pci/pci_bus.h b/include/hw/pci/pci_bus.h index c738446788..186a157dbc 100644 --- a/include/hw/pci/pci_bus.h +++ b/include/hw/pci/pci_bus.h @@ -56,6 +56,8 @@ struct PCIBus { int *irq_count; =20 Notifier machine_done; + + int32_t acpi_pcihp_bsel_val; }; =20 static inline bool pci_bus_is_cxl(PCIBus *bus) diff --git a/hw/acpi/pci-bridge.c b/hw/acpi/pci-bridge.c index 394a919479..9af939363c 100644 --- a/hw/acpi/pci-bridge.c +++ b/hw/acpi/pci-bridge.c @@ -23,6 +23,8 @@ void build_pci_bridge_aml(AcpiDevAmlIf *adev, Aml *scope) =20 if (!DEVICE(br)->hotplugged) { PCIBus *sec_bus =3D pci_bridge_get_sec_bus(br); + Error *local_err =3D NULL; + int32_t bsel; =20 build_append_pci_bus_devices(scope, sec_bus); =20 @@ -30,9 +32,14 @@ void build_pci_bridge_aml(AcpiDevAmlIf *adev, Aml *scope) * generate hotplug slots descriptors if * bridge has ACPI PCI hotplug attached, */ - if (object_property_find(OBJECT(sec_bus), ACPI_PCIHP_PROP_BSEL)) { + bsel =3D object_property_get_int(OBJECT(sec_bus), ACPI_PCIHP_PROP_= BSEL, + &local_err); + + if (local_err =3D=3D NULL && bsel >=3D 0) { build_append_pcihp_slots(scope, sec_bus); } + + error_free(local_err); } } =20 diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c index a91f523c93..31822f6310 100644 --- a/hw/acpi/pcihp.c +++ b/hw/acpi/pcihp.c @@ -58,8 +58,8 @@ typedef struct AcpiPciHpFind { static int acpi_pcihp_get_bsel(PCIBus *bus) { Error *local_err =3D NULL; - uint64_t bsel =3D object_property_get_uint(OBJECT(bus), ACPI_PCIHP_PRO= P_BSEL, - &local_err); + int32_t bsel =3D object_property_get_int(OBJECT(bus), ACPI_PCIHP_PROP_= BSEL, + &local_err); =20 if (local_err || bsel >=3D ACPI_PCIHP_MAX_HOTPLUG_BUS) { error_free(local_err); @@ -78,18 +78,14 @@ typedef struct { static void *acpi_set_bsel(PCIBus *bus, void *opaque) { BSELInfo *info =3D opaque; - unsigned *bus_bsel; DeviceState *br =3D bus->qbus.parent; bool is_bridge =3D IS_PCI_BRIDGE(br); =20 /* hotplugged bridges can't be described in ACPI ignore them */ if (qbus_is_hotpluggable(BUS(bus))) { if (!is_bridge || (!br->hotplugged && info->has_bridge_hotplug)) { - bus_bsel =3D g_malloc(sizeof *bus_bsel); - - *bus_bsel =3D info->bsel_alloc++; - object_property_add_uint32_ptr(OBJECT(bus), ACPI_PCIHP_PROP_BS= EL, - bus_bsel, OBJ_PROP_FLAG_READ); + object_property_set_int(OBJECT(bus), ACPI_PCIHP_PROP_BSEL, + info->bsel_alloc++, NULL); } } =20 @@ -730,14 +726,16 @@ bool build_append_notification_callback(Aml *parent_s= cope, const PCIBus *bus) /* If bus supports hotplug select it and notify about local events */ bsel =3D object_property_get_qobject(OBJECT(bus), ACPI_PCIHP_PROP_BSEL= , NULL); if (bsel) { - uint64_t bsel_val =3D qnum_get_uint(qobject_to(QNum, bsel)); - - aml_append(method, aml_store(aml_int(bsel_val), aml_name("BNUM"))); - aml_append(method, aml_call2("DVNT", aml_name("PCIU"), - aml_int(1))); /* Device Check */ - aml_append(method, aml_call2("DVNT", aml_name("PCID"), - aml_int(3))); /* Eject Request */ - nr_notifiers++; + int32_t bsel_val =3D qnum_get_int(qobject_to(QNum, bsel)); + + if (bsel_val >=3D 0) { + aml_append(method, aml_store(aml_int(bsel_val), aml_name("BNUM= "))); + aml_append(method, aml_call2("DVNT", aml_name("PCIU"), + aml_int(1))); /* Device Check */ + aml_append(method, aml_call2("DVNT", aml_name("PCID"), + aml_int(3))); /* Eject Request */ + nr_notifiers++; + } } =20 /* Notify about child bus events in any case */ @@ -848,7 +846,7 @@ void build_append_pcihp_slots(Aml *parent_scope, PCIBus= *bus) Aml *dev, *notify_method =3D NULL, *method; QObject *bsel =3D object_property_get_qobject(OBJECT(bus), ACPI_PCIHP_PROP_BSEL, NULL); - uint64_t bsel_val =3D qnum_get_uint(qobject_to(QNum, bsel)); + int32_t bsel_val =3D qnum_get_int(qobject_to(QNum, bsel)); qobject_unref(bsel); =20 aml_append(parent_scope, aml_name_decl("BSEL", aml_int(bsel_val))); diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index 3f285ff6c7..926c21324a 100644 --- a/hw/arm/virt-acpi-build.c +++ b/hw/arm/virt-acpi-build.c @@ -1138,6 +1138,8 @@ build_dsdt(GArray *table_data, BIOSLinker *linker, Vi= rtMachineState *vms) AcpiTable table =3D { .sig =3D "DSDT", .rev =3D 2, .oem_id =3D vms->oe= m_id, .oem_table_id =3D vms->oem_table_id }; Aml *pci0_scope; + Error *local_err =3D NULL; + int32_t bsel; =20 acpi_table_begin(&table, table_data); dsdt =3D init_aml_allocator(); @@ -1196,9 +1198,12 @@ build_dsdt(GArray *table_data, BIOSLinker *linker, V= irtMachineState *vms) =20 aml_append(pci0_scope, build_pci_bridge_edsm()); build_append_pci_bus_devices(pci0_scope, vms->bus); - if (object_property_find(OBJECT(vms->bus), ACPI_PCIHP_PROP_BSEL)) { + bsel =3D object_property_get_int(OBJECT(vms->bus), ACPI_PCIHP_PROP_BSE= L, + &local_err); + if (local_err =3D=3D NULL && bsel >=3D 0) { build_append_pcihp_slots(pci0_scope, vms->bus); } + error_free(local_err); =20 if (vms->acpi_dev) { bool acpi_pcihp; diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 2ee061558c..de196f2f4a 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -1197,15 +1197,20 @@ build_dsdt(GArray *table_data, BIOSLinker *linker, sb_scope =3D aml_scope("\\_SB"); { Object *pci_host =3D acpi_get_i386_pci_host(); + Error *local_err =3D NULL; + int32_t bsel; =20 if (pci_host) { PCIBus *pbus =3D PCI_HOST_BRIDGE(pci_host)->bus; Aml *ascope =3D aml_scope("PCI0"); /* Scan all PCI buses. Generate tables to support hotplug. */ build_append_pci_bus_devices(ascope, pbus); - if (object_property_find(OBJECT(pbus), ACPI_PCIHP_PROP_BSEL)) { + bsel =3D object_property_get_int(OBJECT(pbus), ACPI_PCIHP_PROP= _BSEL, + &local_err); + if (local_err =3D=3D NULL && bsel >=3D 0) { build_append_pcihp_slots(ascope, pbus); } + error_free(local_err); aml_append(sb_scope, ascope); } } diff --git a/hw/pci/pci.c b/hw/pci/pci.c index cec065d108..db42b5296a 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -25,6 +25,7 @@ #include "qemu/osdep.h" #include "qemu/datadir.h" #include "qemu/units.h" +#include "hw/acpi/pcihp.h" #include "hw/core/irq.h" #include "hw/pci/pci.h" #include "hw/pci/pci_bridge.h" @@ -187,6 +188,8 @@ static void pci_bus_realize(BusState *qbus, Error **err= p) bus->machine_done.notify =3D pcibus_machine_done; qemu_add_machine_init_done_notifier(&bus->machine_done); =20 + bus->acpi_pcihp_bsel_val =3D -1; + vmstate_register_any(NULL, &vmstate_pcibus, bus); } =20 @@ -283,6 +286,30 @@ static GByteArray *pci_bus_fw_cfg_gen_data(Object *obj= , Error **errp) return byte_array; } =20 +static void pci_bus_get_acpi_pcihp_bsel_val(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) +{ + PCIBus *bus =3D PCI_BUS(obj); + int32_t bsel_val =3D bus->acpi_pcihp_bsel_val; + + visit_type_int32(v, name, &bsel_val, errp); +} + +static void pci_bus_set_acpi_pcihp_bsel_val(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) +{ + PCIBus *bus =3D PCI_BUS(obj); + int32_t bsel_val =3D bus->acpi_pcihp_bsel_val; + + if (!visit_type_int32(v, name, &bsel_val, errp)) { + return; + } + + bus->acpi_pcihp_bsel_val =3D bsel_val; +} + static void pci_bus_class_init(ObjectClass *klass, const void *data) { BusClass *k =3D BUS_CLASS(klass); @@ -302,6 +329,11 @@ static void pci_bus_class_init(ObjectClass *klass, con= st void *data) pbc->numa_node =3D pcibus_numa_node; =20 fwgc->get_data =3D pci_bus_fw_cfg_gen_data; + + object_class_property_add(klass, ACPI_PCIHP_PROP_BSEL, "int32", + pci_bus_get_acpi_pcihp_bsel_val, + pci_bus_set_acpi_pcihp_bsel_val, + NULL, NULL); } =20 static const TypeInfo pci_bus_info =3D { --=20 2.43.0 From nobody Tue Jun 30 07:34:11 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1782127596; cv=pass; d=zohomail.com; s=zohoarc; b=eGwS6daTfMfhDbZfCmw0O6oGiB+e0dzo5qLdMU2FS2KDJXpTB8dAByM0aVKWAxYRGw3SxEN2UxHTIqcCMgZAgQAzbZPUYNV4gSH7zdwDWJHHY+SMXHwV95pp2CAl8XCa8HMzzG0AdMsXyOVPPpJNITNIqAsiwLS6bCqRemFfhww= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782127596; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=/Lq0rMm7d1mzzQvxh3Xp+0T8a1hDDqjFGSZvYDn7CRk=; b=btmUY15MBQ8P00BMf+h52/d2r1CuFBnKTMkUoEeFTYbuilu6ib6SBsOXNnVwLnOnQRWwsG1zjYsZcdDAHtJG6jasatiaGTnb5+JZESDs5UAmOU+K/ZGnuVrFsnyBKiL9eU9J9ejulP51FrPoTK33I4cJbLCH7V9oDWNkV0pwXWw= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782127596454747.9297924728663; Mon, 22 Jun 2026 04:26:36 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wbcm0-0004RX-E6; Mon, 22 Jun 2026 07:25:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wbclm-0004JP-Fy; Mon, 22 Jun 2026 07:24:50 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wbclk-0001S0-Cs; Mon, 22 Jun 2026 07:24:50 -0400 Received: from pps.filterd (m0127839.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65MApovc4141281; Mon, 22 Jun 2026 04:24:36 -0700 Received: from sn4pr0501cu005.outbound.protection.outlook.com (mail-southcentralusazon11021113.outbound.protection.outlook.com [40.93.194.113]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 4ewsxd3fa6-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 22 Jun 2026 04:24:35 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by DS0PR02MB10661.namprd02.prod.outlook.com (2603:10b6:8:1f8::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.139.20; Mon, 22 Jun 2026 11:24:34 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::8e97:bc32:822c:b250%3]) with mapi id 15.21.0139.009; Mon, 22 Jun 2026 11:24:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=/Lq0rMm7d1mzzQvxh3Xp+0T8a1hDDqjFGSZvYDn7C Rk=; b=hDZqcGkOx49aJy6z6aulusOS4TmuOCzZosqu2k9x6WJwPLumQOxgRtjsa u0/dfw7BNI8TQ+63dETK2b6bupfDS3D5aSpmF9UxyZdmWifNWjOrPwrQVOHjxlyI boJWy3oJD6yAorA1QbFSxYmxK/IwL6bHNjEgs3dsDx21+tT0VC5ALutUUsiQf/Z+ IHagO2pTR9SQEP8NIhtjqlHo3kYFetdeMI8bwOdj4zqNK/ht807Ihfza60fb/Uh3 tMEl7myPZViB/TOytFE4M6E0ldVSkXNtMupAzTc+b6B5+8vV0igydLOJOlzvJ40N b+9jjzqyXoyC3NNaoIWZrQNodGH4Q== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=i712m5icxJ/vSnBnYbCZKZzlbYeSxDexIwG2jjGTmspqJMk5hukFgJI+oTqfLioa32+vF2abHo0MP9JH00++ofuduboMCuhizDO6ThOCqObU6EgoXnalqVYhgkSNXqK1reDfu2xiHXO4QEzRAZdq8v5m0vIvtUW09KTPQbZAUDBVw/v61pn/77V5pUzfKO04eSt+us5FsIDShrRj2ek86VTJXHyxnnRkFCLBkeXKJSUzHx6hHb/gETo4aZSx6TsEDopNSte17ijkEsV1jC9wuK8Lxr4Gf6H0KrasIZ76WjYOq1Zn9JU+BrDGj/ddeqIMx0dxnboKIN01vvei+DiZOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/Lq0rMm7d1mzzQvxh3Xp+0T8a1hDDqjFGSZvYDn7CRk=; b=VEaObNQVxtjSdItFeqvnGcHqvNZJ1nW5a3TXArn/QQNmLVr8J5Jd2xQGvcrCg+rimfjIy5+0shA5asPgeOi6PNv8iZnp96kE4+v4Rj2ucplSSk1K3INwTSIpOa53jzrE0FE7sVjZG7dALrkjyNOzbmY7pY/DKwUEMD4qDf3MJDhx52nhA1DJMiieUMJFII1hh/4Q2JuDNGhmzjfXPhbFFbMb4KFMVH2bWAInt0oRPjE96Q+tqWODv4Fycfbn6Y/6+Zhe2elPhbg1TabsaBj3jv1dDs+KVUoUH1Nc8JtY/VnRy8ImZS8/a7RnN9MDFGXzlU1CAazzY+dwkhZyhHYiIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/Lq0rMm7d1mzzQvxh3Xp+0T8a1hDDqjFGSZvYDn7CRk=; b=Hs9SSegtuvictvKKPDzdD8t6+PGdjZYgPYs9+3q4aYePxVtV3ccOkuw2DNrio4s7x0cfT9OB9DKhGE/WRX4+sgYr3xR42X7aNrKsa9dhE8kcCngNt5XilhlPEBwZZllwjIVTCeC858AjlUAHcnyJA1kxUN2gJ1z23EESCj9pxYZQ4CjWA6CHXskmRs/Mh+ke2FfUCb5l40YmZjwim3m1RSp/TivvYVTOEhCmnfeiBu8JcfdEEJKXNNIkuyq/VoeeJbZzdJUutxViPL0ZhlSVI6f340oxn4iqYQqM9qF5YBlwQf9tr1VxZb5ynpC7o/XnrWWzOsul73zxl5A6II4x2g== From: Mark Cave-Ayland To: mst@redhat.com, imammedo@redhat.com, anisinha@redhat.com, philmd@mailo.com, aurelien@aurel32.net, peter.maydell@linaro.org, pbonzini@redhat.com, richard.henderson@linaro.org, qemu-devel@nongnu.org, qemu-arm@nongnu.org Subject: [PATCH 7/7] hw/acpi/piix4.c: convert object props in PIIX4_PM to class props Date: Mon, 22 Jun 2026 12:22:39 +0100 Message-ID: <20260622112403.928954-8-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260622112403.928954-1-mark.caveayland@nutanix.com> References: <20260622112403.928954-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: CY5PR19CA0098.namprd19.prod.outlook.com (2603:10b6:930:83::15) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|DS0PR02MB10661:EE_ X-MS-Office365-Filtering-Correlation-Id: 68402c39-57f3-476f-db0a-08ded050d624 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|7416014|376014|23010399003|1800799024|22082099003|18002099003|56012099006|921020; X-Microsoft-Antispam-Message-Info: 4Km02XQemb/R7HQLrvRw+J0vi4jq/EeGVGhNnI8w+NX+0l8CpzZWdxGgTgZLpCb1e0RO9TL0LeoCOrnbG7tOaGWDIQXs5GeyaV22l4HIeNXRYM1iJFty3wxL1nTYzJ3eHBlLrhET+7nVBRFT4SQqmWkxd9BD1AcCfgmr9ALZV84qS2UO9mYZI/WSmxDdygTC9Czh8EjGGq2jXKgNegREafRv/JgL85HHyMUp/I7Yw33ksqlslezCsWuhqDUIY/SwYQC8U4DObKZxQZGAggiUSmR/IebJpMqyBE/3QcUTxLrK592mRGtrU6MErdwc8pZ612nYZuZfOpFUu/G3gmi81Vem/m0V1lRMwDyPSJ+xDjnyI/FpfiunVmL3gYaujHjPek2zkjb/QWLgYkUX//yfFt7f7025nbEi4WJVnyGcXWAf6O8WiVBdFnUdfaoQC4oP8oYLXHseoM4aDvy5sh3fOeTqEls2NAFzHb8jk1VVAyyBMDVIATPI5YLC88w/gkTzcCLGKVcoWaTAsOASClOp2rO6ZB9F3S+zX2nDXJLK5XJGGT5pVN8ubhv8Z0hbg0nYF9mlgpFbH8n4jFhAe13eV+FOefwZJPQXMsTmWl0XczpBYreVKqOj/k7LOXxd/BSSNjYZExhzWST5noP+W5tK7HyyMflqmcN7B2cBoXVQuZ8IjAXBTzVn0+uIPG690L9NRouCHyj4MvPfvunmV4Fc4Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(7416014)(376014)(23010399003)(1800799024)(22082099003)(18002099003)(56012099006)(921020); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?InT0NeyOW7cr+t4VD1N5B5OBj+cRkhv4wm9R3i33pFEC4oOuPIfSLl3vu72d?= =?us-ascii?Q?OxApxNndgges/FaHIRl5Vl8+YCIvPqFnPL8ubmQNXd82Mrzf0w01FPuv2/4q?= =?us-ascii?Q?PAPYP0mKJxe8JhtLyNUfswMwEN881iHedggiBbY1bQqFdotB+i6thcxpcV7Q?= =?us-ascii?Q?oTg8KtIF9v6tdBjWBpTZ2WYgwwahcEuXHevhJ5jpH4sE0z3Yuqpm3s7VXV/X?= =?us-ascii?Q?XUFLJ26SuxZ8Ws02BIH1aVuJlTebkIK371CVLAlNvfX75l66gdxzSG8B30OS?= =?us-ascii?Q?VpGVtzsi4Grk6bLufyjilOGOx0H/7T+G5I9/ri259lMmlaO2SWL7fxbDmY9M?= =?us-ascii?Q?wkaJc4opAiln6co+LcavbDkB/cQ7vXk+UkhdtWbUbJprVtLJLG/JSM1b1TYf?= =?us-ascii?Q?pEeVo1X15t+s6TYK3b4pGL/lTCO0Fa6DtceJbP2RmqMRnsx64xrNZYZvfw5k?= =?us-ascii?Q?kDoagI8/1ybcmUWcPegnALh4WfCpqrZEo6KLFfmHyBT3sIRh1Msm6rmrcx9o?= =?us-ascii?Q?Zg//0iIJsp8krBCRPLUWkMXMk8NUbQpT2QuRrGNIpM/2B9115FYYPNy0PQrx?= =?us-ascii?Q?whO4h3S6P1iZVWjbGXmFTNTRJHjJyloLS4+4E9i06YwHFaYX5b1WKBkGoRTB?= =?us-ascii?Q?aFE2LRY5EYkAT1a+KpUIHukmaiW05KUaJXFojjjLyEqLszSNwzUgBBEINxLQ?= =?us-ascii?Q?ux/Jks/o4yCG/CGbicvkBY2AFfy8wekNaXoS0kzOSK7i6uQZmjaHACHtHGCD?= =?us-ascii?Q?6cJspZ6KgDS6wCcAjODzd2GwQq2eWkf3IR8Oh9csRR4Mb04VvnTEbzpDAW98?= =?us-ascii?Q?EF6NiyaUOp7hXE45Uhsp6mw/UGkx0C+u9lfhkW/FFiNDw+spZ40eS72+5p8m?= =?us-ascii?Q?Flnp0Igum7JkepqgjpHXANauh3JysjZNOyvZjS17A4nqGZAk0TMHPeRwE6GU?= =?us-ascii?Q?n1ifdtEs2hwvWXmB7p83W86xGgADRIx4cDxwCe5w9rObn/lXBhzf8PvhG8GD?= =?us-ascii?Q?1RPQAdYb9mnv/pZwZVx07aowK3/jxKt4FbJRWg4nVdEJQKHcWhfv7enttpks?= =?us-ascii?Q?36naHdCa/MjYk7xfxg5Io6vDYpc2NxlRxOVv/CBLhUaUn3atmKPDAa/nOM1f?= =?us-ascii?Q?wT8pUoe5SZ71K5diuz98YLoJsr5urxLN0L5TKGcI9FfVTj/uyeAt354mGvDA?= =?us-ascii?Q?NeEEQ4qo5rtR/Zd8Qb/krvh25prnhc7VhwWUi6tQpHZzQoSSjNq5uaWOW92t?= =?us-ascii?Q?yrSK/BBQks2leFLDgbtCGHFlTZ7nHcmWrALt4q6UvH/3vgljYg7yOBuwhF55?= =?us-ascii?Q?xyf6lE0y3WfQNfg0m0K4kROHYG+BQVKCxmeOGmJZvjjkwj5K5xEvSaaoXpGq?= =?us-ascii?Q?nAbxVNa+7U8mKbSpt9m0xPZNCJgF5FhI2mSDXPFy4Hd+WeSwHB3HeW/U1qpi?= =?us-ascii?Q?F17eKxS2CGHbXoUUFFlNYM21/5cq21a4XuddiywprU+R1Ro60oBGIoQhhQzK?= =?us-ascii?Q?Mgmy6ImAT8mAxcDGyg2I0anf0nHgat0JXKRTFJfX/eER8IPD6xoBEBqrD81z?= =?us-ascii?Q?dAKuA9cwYxwp6FEXDIhhID4I7b1vJPaTnCpM7qgpN2fzKwuRGBuB2ESJ6vel?= =?us-ascii?Q?x4AFF8Rt3EOCEiWUEP8IHjmwllaruVhEixR9xbq8VNqmjdSVwHCqiknD/Vx9?= =?us-ascii?Q?JhuEBEq1z03SDJdCvAgHg5SvKlOpGHDdB+2GA8aUyXEav9pYvos7OjTSsJvV?= =?us-ascii?Q?RNaU90Oy+hdCb8Bs3YK6NTtMjjnQPoo=3D?= X-Exchange-RoutingPolicyChecked: DGgD0+zqDg4bARTKdDE9IHAxVBCCUkBR11SMWR4Gb8FCizlIP/T7JLFZ9guJHKrjNftKLJ9Wbk6Y1tb8JHs0vImLMpcfj103yLrPIHyzw26B5SXLP57+WOcwDUWVleyUiSdY6nft1NwqE0vYF7Yu5r6DwxgoEFt3vIUvbJccBwX5rUMaKuQyAGNgq9QhhScp5lcNgY2sO9QjwDPDP76HYKYGQ9N7MBJ8QzSf438lMK0ML3rFhd8/W+9CtOKqkcMZJ0p2F/pIVS8/nfUzUByZB2/QbMsI4T/1Rg/b9ZBvp4UbsV0GU4oO5MPBGHdaybunaU/7yA4U3paMy2welhLXlA== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 68402c39-57f3-476f-db0a-08ded050d624 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2026 11:24:34.3883 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HBnpe4yVDGJiJhk+FNl99/fDkBKYgK7E0v4/3r1AjZ6q327jQlKQp6ymhEKvFcqhdgDz693b4A/FPyI9ej+Sy//4q66oMbWHV0P6kxQpRVw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR02MB10661 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIyMDExMiBTYWx0ZWRfX82Vezg5CAco8 qaTmG0/LrBOwzYzssk5+YqkZtlWYggZrMdqQMVG/cQVL1Vh8iqkHKLi+2qI+eGOisNbhM2QqoXP +/TVCfinQEMWieiER7pD/KEUIG+pCsW/9bbCYD9X6ubfoYR57DJs10QP2+yoiPbYNBd4j5pkYCD a8nvuUN/5/vcfyBQLjCYrC27NzAdNYcTA6T2+bpBS3IEXK6ph8m7ZoTJVyys76tjjIQkdNJYOdA 0gDbeFsk6T3Yj/lwyGcobKG/r8fs1gCHWfd17hb2INXmLwFhYoLCL8AMvyjATuubs3QTgSoB8wC iwEm/T1/SBeEETTmcXAKD/VZGgiJ/thdN4jgAmfHgjCzZp9AvflJRGDKcA1viaTu9MHFWfwNwit zLH1gzoChvfb+4Hdoz553RQuZTSBDmhusto8GvA24Wmkf4Ct2khS/ckLxOKjgDfDTVb/CBreQo8 0HFizBaoiju2UKDuBOA== X-Authority-Analysis: v=2.4 cv=WYg8rUhX c=1 sm=1 tr=0 ts=6a391b73 cx=c_pps a=+jjOclGHkOGhuepu6R0Llw==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=FelO9ux0wxsA:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=y4UcunY2MAxhM4LwGdWI:22 a=64Cc0HZtAAAA:8 a=BSwvxqYPP3kZS5870RIA:9 X-Proofpoint-ORIG-GUID: IdXpOiJ4T9Ux0BZHZmDqoC4A4T-mD74p X-Proofpoint-GUID: IdXpOiJ4T9Ux0BZHZmDqoC4A4T-mD74p X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIyMDExMiBTYWx0ZWRfX1I2G/pBeufAw zSK26yiiECQXeZreSFsymozJoG52YsFrfNuJePmLlKfgj+QF52Dv24WjeNLAP/P6qq+Cf1GnM8z KstzPeoxaoaFM35rUFx/8FE/qH+6m2w= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-22_02,2026-06-18_03,2025-10-01_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1782127596966158500 Content-Type: text/plain; charset="utf-8" Signed-off-by: Mark Cave-Ayland Reviewed-by: Daniel P. Berrang=C3=A9 --- hw/acpi/piix4.c | 42 +++++++++++++++++++++++++++--------------- 1 file changed, 27 insertions(+), 15 deletions(-) diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c index 4bfe3caa0d..1aaf53e438 100644 --- a/hw/acpi/piix4.c +++ b/hw/acpi/piix4.c @@ -406,6 +406,16 @@ static void piix4_pm_machine_ready(Notifier *n, void *= opaque) (memory_region_present(io_as, 0x2f8) ? 0x90 : 0); } =20 +static void piix4_pm_get_io_base(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) +{ + PIIX4PMState *s =3D PIIX4_PM(obj); + uint32_t io_base =3D s->io_base; + + visit_type_uint32(v, name, &io_base, errp); +} + static void piix4_pm_get_pcihp_io_base(Object *obj, Visitor *v, const char *name, void *opaque, Error **errp) @@ -426,7 +436,7 @@ static void piix4_pm_get_pcihp_io_len(Object *obj, Visi= tor *v, visit_type_uint16(v, name, &io_len, errp); } =20 -static void piix4_pm_add_properties(PIIX4PMState *s) +static void piix4_pm_add_class_properties(ObjectClass *oc) { static const uint8_t acpi_enable_cmd =3D ACPI_ENABLE; static const uint8_t acpi_disable_cmd =3D ACPI_DISABLE; @@ -434,18 +444,20 @@ static void piix4_pm_add_properties(PIIX4PMState *s) static const uint32_t gpe0_blk_len =3D GPE_LEN; static const uint16_t sci_int =3D 9; =20 - object_property_add_uint8_ptr(OBJECT(s), ACPI_PM_PROP_ACPI_ENABLE_CMD, - &acpi_enable_cmd, OBJ_PROP_FLAG_READ); - object_property_add_uint8_ptr(OBJECT(s), ACPI_PM_PROP_ACPI_DISABLE_CMD, - &acpi_disable_cmd, OBJ_PROP_FLAG_READ); - object_property_add_uint32_ptr(OBJECT(s), ACPI_PM_PROP_GPE0_BLK, - &gpe0_blk, OBJ_PROP_FLAG_READ); - object_property_add_uint32_ptr(OBJECT(s), ACPI_PM_PROP_GPE0_BLK_LEN, - &gpe0_blk_len, OBJ_PROP_FLAG_READ); - object_property_add_uint16_ptr(OBJECT(s), ACPI_PM_PROP_SCI_INT, - &sci_int, OBJ_PROP_FLAG_READ); - object_property_add_uint32_ptr(OBJECT(s), ACPI_PM_PROP_PM_IO_BASE, - &s->io_base, OBJ_PROP_FLAG_READ); + object_class_property_add_uint8_ptr(oc, ACPI_PM_PROP_ACPI_ENABLE_CMD, + &acpi_enable_cmd, OBJ_PROP_FLAG_RE= AD); + object_class_property_add_uint8_ptr(oc, ACPI_PM_PROP_ACPI_DISABLE_CMD, + &acpi_disable_cmd, OBJ_PROP_FLAG_R= EAD); + object_class_property_add_uint32_ptr(oc, ACPI_PM_PROP_GPE0_BLK, + &gpe0_blk, OBJ_PROP_FLAG_READ); + object_class_property_add_uint32_ptr(oc, ACPI_PM_PROP_GPE0_BLK_LEN, + &gpe0_blk_len, OBJ_PROP_FLAG_READ= ); + object_class_property_add_uint16_ptr(oc, ACPI_PM_PROP_SCI_INT, + &sci_int, OBJ_PROP_FLAG_READ); + object_class_property_add(oc, ACPI_PM_PROP_PM_IO_BASE, "uint32", + piix4_pm_get_io_base, + NULL, + NULL, NULL); } =20 static void piix4_pm_realize(PCIDevice *dev, Error **errp) @@ -501,8 +513,6 @@ static void piix4_pm_realize(PCIDevice *dev, Error **er= rp) =20 piix4_acpi_system_hot_add_init(pci_address_space_io(dev), pci_get_bus(dev), s); - - piix4_pm_add_properties(s); } =20 static void piix4_pm_init(Object *obj) @@ -637,6 +647,8 @@ static void piix4_pm_class_init(ObjectClass *klass, con= st void *data) piix4_pm_get_pcihp_io_len, NULL, NULL, NULL); + + piix4_pm_add_class_properties(klass); } =20 static const TypeInfo piix4_pm_info =3D { --=20 2.43.0