From nobody Sun Jul 26 12:29:01 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=baidu.com ARC-Seal: i=1; a=rsa-sha256; t=1782122590; cv=none; d=zohomail.com; s=zohoarc; b=m3b6U//DLjHVzfI/IOKBHguDDA9TjkV0SodzhpIU0aQPCIyobgxMXaVBa1wqQLm+Mkv+bHu9BdHqRyk84l2wo4CcdmZttcp/LyPGwgovw2vLiPHANqtQrETXUTP/wOA+bxki08qDKtYEWzjDX2piJRMd7P2IEpVonwU+3yFk6pw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782122590; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=crwQ1DMzva9qW+D1ZNuZR9rfJakIT7qqCBbUd0xzbCI=; b=SWr+RfnDKChcqtkjHWi7Rlv30pntaYmputDw/Sq7fOPHsqOdVe1lYNVp3StXVa5AUrcJY1o2PXMoWLLJ6Qc5YvDCo8zemBCcj4thudYxyOOBJFgAKWSJ6NJgVL192GWpqq5p9BLWZQ5I6oWgC771DxnEiGweMvNBUxeBW5VMG+o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1782122589739507.88772094944477; Mon, 22 Jun 2026 03:03:09 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wbbUB-0001vc-Pg; Mon, 22 Jun 2026 06:02:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wbbTt-0001uo-B5; Mon, 22 Jun 2026 06:02:19 -0400 Received: from mx21.baidu.com ([220.181.3.85] helo=outbound.baidu.com) by eggs.gnu.org with smtp (Exim 4.90_1) (envelope-from ) id 1wbbTo-0003PL-Tp; Mon, 22 Jun 2026 06:02:16 -0400 X-MD-Sfrom: lizhaoxin04@baidu.com X-MD-SrcIP: 172.31.4.16 From: Li Zhaoxin To: "Michael S . Tsirkin" , CC: , Paolo Bonzini , =?UTF-8?q?Eugenio=20P=C3=A9rez?= , Longpeng , miaokezhan , lizhaoxin04 Subject: [PATCH] vdpa: fix use-after-free of vqs in vhost_vdpa_device_unrealize Date: Mon, 22 Jun 2026 18:01:45 +0800 Message-ID: <20260622100145.18924-1-lizhaoxin04@baidu.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [172.31.63.8] X-ClientProxiedBy: bjkjy-exc8.internal.baidu.com (172.31.50.52) To bjhj-exc18.internal.baidu.com (172.31.4.16) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baidu.com; s=selector1; t=1782122522; bh=crwQ1DMzva9qW+D1ZNuZR9rfJakIT7qqCBbUd0xzbCI=; h=From:To:CC:Subject:Date:Message-ID:Content-Type; b=F8dDeFvgdyVN8gNohOf8C9U4RAnnqqATEpz1Knq4lRJ03sXdjuLyYOfT/yRar0Mx+ sI/gEoYll5Hya0pkYfTVVE4JDlvPWdFsQGMabauAgJlnm5YTCIsoV/27h2wBKYNWMq E2sZK7Eub5jpsgvG0iPd4C/ewkmv4PccGVDQqkbKmdSitL/2HMUUSl0pOSI2aMQ0Kw Fn6gc+msDCKMA/MGJjB6duDSnuiDXkeNAh0pnWVoZSEhtHCBEZ/4lZ5sHQ6nGhFq7B G2wn/eShKKyTyvNb1q1gJ5JNx5560Db5956bA3ovtwr7UAjc9j8EkPMSisIqcambc1 i7gT///Cny0Ig== Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=220.181.3.85; envelope-from=prvs=md16272BC2AF=lizhaoxin04@baidu.com; helo=outbound.baidu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @baidu.com) X-ZM-MESSAGEID: 1782122595733158500 Content-Type: text/plain; charset="utf-8" From: lizhaoxin04 vhost_vdpa_device_unrealize() frees s->dev.vqs before vhost_dev_cleanup(), but vhost_dev_cleanup() still accesses hdev->vqs while tearing down virtqueues. This leads to a use-after-free and may crash QEMU with SIGSEGV during vDPA hot-unplug. Save the vqs pointer in a local variable, call vhost_dev_cleanup(), and free it afterward. This matches the cleanup pattern used by vhost-scsi. Fixes: b430a2bd23 ("vdpa: add vdpa-dev support") Co-developed-by: Miao Kezhan Signed-off-by: Li Zhaoxin --- hw/virtio/vdpa-dev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/virtio/vdpa-dev.c b/hw/virtio/vdpa-dev.c index 94188d37bb..089a77f4d0 100644 --- a/hw/virtio/vdpa-dev.c +++ b/hw/virtio/vdpa-dev.c @@ -172,6 +172,7 @@ static void vhost_vdpa_device_unrealize(DeviceState *de= v) { VirtIODevice *vdev =3D VIRTIO_DEVICE(dev); VhostVdpaDevice *s =3D VHOST_VDPA_DEVICE(vdev); + struct vhost_virtqueue *vqs =3D s->dev.vqs; int i; =20 virtio_set_status(vdev, 0); @@ -183,8 +184,8 @@ static void vhost_vdpa_device_unrealize(DeviceState *de= v) virtio_cleanup(vdev); =20 g_free(s->config); - g_free(s->dev.vqs); vhost_dev_cleanup(&s->dev); + g_free(vqs); g_free(s->vdpa.shared); qemu_close(s->vhostfd); s->vhostfd =3D -1; --=20 2.17.1