From nobody Sun Jul 26 13:29:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1781654422; cv=none; d=zohomail.com; s=zohoarc; b=Nqx5Ps9a2Ia/UQTXTkpSYzYt/4OMOSgcM11lJ8kSEFQPQQk2OEnonFlet4SdG4cVNEzGpTupfOWoZPqiB4yCfrwz+hl8bCKc6zl7UPR+e0ma+YAoeBD+SvKY+rJmQ13Rq1TTU0/eCKykUxUCsWE8sb04flU115ZJnZMWhSwWUvo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1781654422; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=FINgkC03CpXHsjEzGruDQiIM72ZDqLif+q+uMuG+YvE=; b=Y5KJBi3QpYgt15IyQkw2sOQz94vbZw/lG226yvM+/D93vEZMBnWdOpTNBQJb1V0w5kOhfMl3ol3O+LzI2BS8LK9WqZ8GfzqBC3imjNAmUfYvpYSf4JmYnf85bXxcN9ERlpiwKYjH+qzd4y/BLqkPtCBuLGLWATGuCf0cb21lyE8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1781654422898814.2864810075912; Tue, 16 Jun 2026 17:00:22 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wZdhB-00020O-CS; Tue, 16 Jun 2026 19:59:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wZdhA-0001zc-DO for qemu-devel@nongnu.org; Tue, 16 Jun 2026 19:59:52 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wZdh8-00082X-Tw for qemu-devel@nongnu.org; Tue, 16 Jun 2026 19:59:52 -0400 Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65GLVuIw1816039 for ; Tue, 16 Jun 2026 23:59:48 GMT Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4euefbre90-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 16 Jun 2026 23:59:48 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8ce9e6cf3aeso95055566d6.0 for ; Tue, 16 Jun 2026 16:59:48 -0700 (PDT) Received: from QCOM-UWl2o8bcGT.qualcomm.com ([177.170.117.62]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8d9f132178csm50191986d6.7.2026.06.16.16.59.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 16:59:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=FINgkC03CpX HsjEzGruDQiIM72ZDqLif+q+uMuG+YvE=; b=g+ldN1E3iw6pCtQxYiNoBjhsfXq hEAsdnN1ZM49st4G+oatsxvx5CPbTYOJy0v97MxuBKKOLBTBaZ/0LOqUpCCup281 tZFzVJyjtg4Iwejoh/ua95mUQx8MjSQvFDAfZ5WCkQ6rwXyjl3d8IT9iTz8qeko9 G4WciuTe31fZ91TOcbGw9cTmkJRez5Iu77yhuFcNKSWh+8tCrd/lCiFtePd1MBqd PZ/6++TfS4tQgfEd45kPOEk+1iAnYYFL3xo5svXJ2aMC0Qk2rOauXCcPV0485Gzu 2ulC5LVLaP10nLmSWGTewootOOw1Ou5DSs8h6zpG+xbdSeDzA2sVYvN8oEw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781654388; x=1782259188; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FINgkC03CpXHsjEzGruDQiIM72ZDqLif+q+uMuG+YvE=; b=DoWel17vqZ/jt5VsoIFHFA9TIGsC5J6qQTqNv+8uX2tiCQXZpnf2Sg9MQykgqGrkLH ue8Kzjsrwejub2lUOicDJ8iYmgOPGibKks9pmPcbVqB1qGEqsSJi+iqu7NQK6qpLHtHi 1l7Ta5NNx9zyveN3xAXf2P8d/VXjK1jouBBMjQQyModc+tDb7VIShntqwic99Os+YYAP 9SIT4YAluMVDTPnZey08ETgYtHDUZOdKQTKcHOtpQ6SZP80/UGndgcYheBZqQF06KHj/ EbDUX4oZn3HBadKsEyLCCXOr6N9onyUp4NwBHkK/lAr7FRPTwhZpITJ/zEQc8IxHSFNr 96PQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781654388; x=1782259188; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FINgkC03CpXHsjEzGruDQiIM72ZDqLif+q+uMuG+YvE=; b=tHuTwZZBeu2toLuRtmQ0q4ZU3rmlVDQr1idIrowXgRRLDkivU/NllISEBne57Ew9ow QuLCjj1nYR5G0LGRlP5pOxZU9etXXlw4xmkbTn1KMQM9GnNcd2l08pfLL+1xzoJkRAls dvCsm8ocyhHCm92K+mMJEd7VQ4ttNnpV7kPJECuWuC+SdiVMXG8n/R2WTLNhgrT05sO/ u88QFxghuvddJAFYSWjFHLUzNfc9OF57Epbxo+vgGPAdcol/KeeZp7VbGxJoFnLKwQMv DqC9aMViI31MlIPLunl4P0Bg7QhCPlapF/2FC6+2WG14xgyR90YtyE8aU1k9UR22kAtt jbDQ== X-Gm-Message-State: AOJu0Yy4aBEEoUUjgrH3mQ9/JnLsV6BaiQRQskeXEMq84MbDJqCxbupP TK3qz96PNVY2plBfbblCHOxVxqdwxE2j16c1iAONN/gzEgJuD0qm44UPh0pO8dkWQK9DDAGwWs0 9jpokMRnGuL0XUbel68YzhyOrOjtrtQ6SWCFQcsTR2nXnOACmblvoY1gOa5rJrCimow== X-Gm-Gg: AfdE7ckG3+g+KkgikHJxq0C84rsmTe4avf/eFK1xYovk82Y0Y8EX3DJMayO2vrgXhjE 4kL1+Bs+vyW9TVTYQuNddOEKQNAVZ+6PmIJ8pcqGBhLV651G1m+SI8UqELtAKg5mT/muBs6vwEx bMQmH/Veicg+N+Tlw+x90560D9Ox3HljqZqQqGpU8Pa0lq2wNDQ6bntlRi5379LOXewJeKLTXbU agfS8nSpLESZ5mGCLxMJKg3gbxtijH06mQ8RLIAb7DtOB4LcO+yBTNMjv57PB6/gW1z87XW6KU6 lEor3z2VNUWEQMTCp0PLvPc9ZIybMxp3UnqvxJqZxHACnK9CgjS5UXKsv3UxzvRQ2KLWe294pw+ YabVCqxMz4R4q7qvUpM/Hdvu/8nF7RtCuFx9k31hFn0bVsoDhOAs56cdkupQ= X-Received: by 2002:a05:6214:55c4:b0:8be:7779:d1b1 with SMTP id 6a1803df08f44-8db5e14e78dmr31824336d6.30.1781654387539; Tue, 16 Jun 2026 16:59:47 -0700 (PDT) X-Received: by 2002:a05:6214:55c4:b0:8be:7779:d1b1 with SMTP id 6a1803df08f44-8db5e14e78dmr31823906d6.30.1781654387133; Tue, 16 Jun 2026 16:59:47 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, alistair.francis@wdc.com, liwei1518@gmail.com, zhiwei_liu@linux.alibaba.com, chao.liu.zevorn@gmail.com, Daniel Henrique Barboza , Alistair Francis , Palmer Dabbelt Subject: [PATCH 1/5] hw/riscv/sifive_u.c: remove unneeded qemu_fdt_get_phandle() call Date: Tue, 16 Jun 2026 20:59:35 -0300 Message-ID: <20260616235939.1358663-2-daniel.barboza@oss.qualcomm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260616235939.1358663-1-daniel.barboza@oss.qualcomm.com> References: <20260616235939.1358663-1-daniel.barboza@oss.qualcomm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: 5RY4Zrhqw1DDMaohbBRk_JN-bnDmfWLf X-Authority-Analysis: v=2.4 cv=IeC3n2qa c=1 sm=1 tr=0 ts=6a31e374 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=gdiugJE53z4H+vvYeRBHqw==:17 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=fewmvhpFTRUHsk0HV0MA:9 a=+jEqtf1s3R9VXZ0wqowq2kgwd+I=:19 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE2MDI0MiBTYWx0ZWRfX1EvStLcgYlPQ yAOCArvxFwxjbsfIY/YUWjcpIcCkMq/6RgBeFT52G8zqQXOwXoIdpfA+tHtZj7jELz4J6PY/zFz sQDj9ACZWcGjfkRJih5P04v6q5lnELg= X-Proofpoint-ORIG-GUID: 5RY4Zrhqw1DDMaohbBRk_JN-bnDmfWLf X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE2MDI0MiBTYWx0ZWRfX2rwc4CoICxsh kR5Zzl5kmV5ORno5VZtvDsK1neoD2Ed/a544UPJN6d8K/uNoRtbXzc8X8vtTG+Q/YpbzHPtLTyq 51S+SHDQwoUk58cQZ0KIb8aWQ+fm+vRevbjy8P57bueKQwAGgOPD01jPaO4ZUq2wjGA94K+MYdB rwMLFT98fyKN2HccRzH4FWPM60IP+2bzbKbVAlCLnv3zdeFTtY4S+E1cRq8n9Tf79fVGCauSWct JfaJuda1Y/MkUWEa9YYcGPaQTMRG0ECKYl9l+SK7BDIe6oo5OtaEzUk3R6be6NTs9OclXsn3XaM Juv3LVk/jHUg1SdFPXHMwx1j5mNkM3xMWdK98PDrw4Wwe36SzAsiwGLfmgVZYx27ocqm1rXSljd w62CrNeqijFBUoZpUVxqwUwED+Ehg348OQvYaOWK0TZsY1A5uqWJdBwFu8NcI4O494KOuLXlKI2 En8t4Hw41swAAlW1J+A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-16_05,2026-06-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 adultscore=0 malwarescore=0 spamscore=0 clxscore=1015 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606160242 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=daniel.barboza@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1781654424611158500 Content-Type: text/plain; charset="utf-8" create_fdt() has the following code sequence: plic_phandle =3D phandle++; (...) qemu_fdt_setprop_cell(fdt, nodename, "phandle", plic_phandle); plic_phandle =3D qemu_fdt_get_phandle(fdt, nodename); What this is doing is assigning a value to plic_phandle, then use that as phandle of "nodename", and then fetching the phandle of "nodename" again in the same variable that already had the right phandle val. Here's how it looks like in gdb: Thread 1 "qemu-system-ris" hit Breakpoint 1, create_fdt (s=3D0xaaaaac162a30, memmap=3D0xaaaaab8f70c8 , is_32_bit=3Dfalse) at ../hw/riscv/sifive_u.c:199 199 plic_phandle =3D phandle++; (gdb) n 200 cells =3D g_new0(uint32_t, ms->smp.cpus * 4 - 2); (gdb) p plic_phandle $3 =3D 12 (gdb) c Continuing. Thread 1 "qemu-system-ris" hit Breakpoint 2, create_fdt (s=3D0xaaaaac162a30, memmap=3D0xaaaaab8f70c8 , is_32_bit=3Dfalse) at ../hw/riscv/sifive_u.c:232 232 plic_phandle =3D qemu_fdt_get_phandle(fdt, nodename); (gdb) n 233 g_free(cells); (gdb) p plic_phandle $4 =3D 12 (gdb) Remove the extra qemu_fdt_get_phandle() call. Signed-off-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis Reviewed-by: Chao Liu --- hw/riscv/sifive_u.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c index 0c6e4204cb..fda9a09f06 100644 --- a/hw/riscv/sifive_u.c +++ b/hw/riscv/sifive_u.c @@ -229,7 +229,6 @@ static void create_fdt(SiFiveUState *s, const MemMapEnt= ry *memmap, qemu_fdt_setprop_cell(fdt, nodename, "riscv,ndev", SIFIVE_U_PLIC_NUM_SOURCES - 1); qemu_fdt_setprop_cell(fdt, nodename, "phandle", plic_phandle); - plic_phandle =3D qemu_fdt_get_phandle(fdt, nodename); g_free(cells); g_free(nodename); =20 --=20 2.43.0 From nobody Sun Jul 26 13:29:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1781654474; cv=none; d=zohomail.com; s=zohoarc; b=RNBBaDD8s7YNmY/IerpIomfFlDZs+Gof7J4RIVEmwiErk8AEfhyA9pW3AIUcjILMFZGg/nj5ozzU4cKCbeTTuW22ft4B5aQS8UYXNXesWCLknEuJaidDBonpFvZ8nuaJeUuv9qYveRjbb35qRc3iXtgCOkHw1epMXFmOc1DXnqk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1781654474; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=wpDFQqe/i30A1HqdCZQ6BGqOps2hFYSOdsjhnuUvPq4=; b=QqUYgEYJnWuLW/Qr3xh/ORuX++qk6gQNFYHqmvPrexBUnUh9wWm6V0uMbesUdRWdcdD+3Fvs8gOCBASKT3QQfD3kdpjPycc/yVwyTc6octgqcceLXr+qHHNHBmTBDNqFP2RNBY+Shp513CY/QA9plwVR5Y66I62cOGBwKAwiFrk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1781654474853545.9097256827442; Tue, 16 Jun 2026 17:01:14 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wZdhI-00021W-4n; Tue, 16 Jun 2026 20:00:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wZdhC-00020k-7N for qemu-devel@nongnu.org; Tue, 16 Jun 2026 19:59:54 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wZdhA-00083g-Ev for qemu-devel@nongnu.org; Tue, 16 Jun 2026 19:59:53 -0400 Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65GLSwUi274624 for ; Tue, 16 Jun 2026 23:59:51 GMT Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eueemgdmf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 16 Jun 2026 23:59:51 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-517dadd84f8so92741651cf.0 for ; Tue, 16 Jun 2026 16:59:50 -0700 (PDT) Received: from QCOM-UWl2o8bcGT.qualcomm.com ([177.170.117.62]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8d9f132178csm50191986d6.7.2026.06.16.16.59.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 16:59:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=wpDFQqe/i30 A1HqdCZQ6BGqOps2hFYSOdsjhnuUvPq4=; b=gI4fictdbNkXBRMEj3098hToJOa arptZY5ww+zTyLc60zY4P5JTKohXa+RNl7bTMJle+TMoib4mFhiGFu1VbzvNXbq+ O7mNcwC9V2E/0moVpZewMQwmlHL/bLT8fNSblBjQtpBgsYCl1IK7Fvj3imjjTa1J mUwshHzuWPDr+eqzTPRYOax0+4S/RDWhUa9lyfR+UNDLJyz9TDhoU4wlLQhiXMTa CqJdW3FuBVE+V9cLDI92TYe0FJzuPpQGFqQ3md9d/M3nL6nj98Uhxd9qJ9mj2Pla IYYZ+krqJ8qI4UczIxvFiaCGeh6KpzuhYfUEaq0EhD9W9FhT2ayDSB6GX8g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781654390; x=1782259190; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wpDFQqe/i30A1HqdCZQ6BGqOps2hFYSOdsjhnuUvPq4=; b=IdVFGJVI1S9IpoiihtW/FyVce2HRTGlsVbW9Fv7ODwan4oDURnxIHDjaxqgXnH/lXn 0NtBTyHRLdLMxT/C5ALzgxd9OWzPOKXTTI/ikiqTHs9VN6mGRme17hailJYSb72gF1HI QzdsBrIWD7VJc984cSl0y8Ckv8AxQN2UDGtdORFfKagys13+qiVaxgMp8Pyp7Dpy3Tsm Ux1pcmuI70QPy98AgupEKcziGwnrGARKGBzTVrp6UIzi5HwIgbkYiIFXGIoUEB9+KAVG sHr68TNyZFVXHxQiSJSxCfw/ivlqznwds8DfGU5fa+2s9OXcLmObrifTIHzI040GenBf TKrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781654390; x=1782259190; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wpDFQqe/i30A1HqdCZQ6BGqOps2hFYSOdsjhnuUvPq4=; b=btJGh6afFka8DRqyGl0Y4jj2efdRBknGfjVaN7HbR6EBHFlXn6r6F0UgWnqoTgZscw qyESOgEfkOF7ieg1leoWJSxAiTa9LrJoDEr4CAEU8dMuJID+f/wPSW61dhM4bQOr/2PQ Cg+9wdIzCnlZ/bRJn5mUN7sNxhLh0/xEyWsygwMEGb+vaj2B4LhQgS8eJxHZ/Q7ZflV2 Gdtgqg76BX80yS6VlbMnk1BlB5leqQTipMi9bx4JmIYfVpi7/SVYxHDkzq9t7wlz/EGM /bwP/ncXdjYWxrn2rXHKUXuuCCqi/fozthvvzMADdD0c1A+DHjBK45dmXn+EyWqsnw7h cDLw== X-Gm-Message-State: AOJu0YyDeuscJr2k4rTfJX7j4DHm/zb7F2wEkKkLwuzGxLZlMAuoDCxn o6/sFTINuw5hCYDe4/Y4GcP0zVb6DLO9D5oABziutJapg6VOufmrY0mJZ7iLKh17+xSmoQrGAt8 Nat40ZmJGL85rmAvXgm42zN5Kva93KA57O1Y8wy4n+NL6hj0Kt6D4aoyH9NNramplMA== X-Gm-Gg: Acq92OGJftddMUvFSZHd2QK2sz1EfLx3WOYKBB2Ybhei7gBZw6nI0k1KtrxrqnntKhX ichrJfQFppos+8Rz80jxfIAJxMhpswyiQWD2XCBi4Mz/AEoVzVTV2+aXjiEYemwQkOhW8ASSmke 9aNK4JRLVOM5JIUmR3I7vC4hCF/FyKlz8CChCTNT+2cD9mKeINKrG6dCKViY/unSgATaVHfpCvQ FMMrMoJd4K4QzsvPbcBScKO+GFYlZxIYiazwv4QU5fGa1z9QXeSO80NEJWg3aWqDFuM2ATYxNe/ jWjnIqD9Tdp/J/tJiTZ2GkyrwqXYgphPZRqR1iAUmbgB6ovHqybhsRZHfkOnQ0E/xWVUSIGei8I Dov3isH9JSBmkfQKo2oR5sHS+E6N8HHCQExvfOXSWNcN2ZfHuvOs4ZE48SwE= X-Received: by 2002:a05:622a:243:b0:517:8d40:7c7d with SMTP id d75a77b69052e-519a8e5ba58mr25966451cf.29.1781654390101; Tue, 16 Jun 2026 16:59:50 -0700 (PDT) X-Received: by 2002:a05:622a:243:b0:517:8d40:7c7d with SMTP id d75a77b69052e-519a8e5ba58mr25966191cf.29.1781654389667; Tue, 16 Jun 2026 16:59:49 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, alistair.francis@wdc.com, liwei1518@gmail.com, zhiwei_liu@linux.alibaba.com, chao.liu.zevorn@gmail.com, Daniel Henrique Barboza , Alistair Francis , Palmer Dabbelt Subject: [PATCH 2/5] hw/riscv/sifive_u.c: use intc_phandle in plic creation Date: Tue, 16 Jun 2026 20:59:36 -0300 Message-ID: <20260616235939.1358663-3-daniel.barboza@oss.qualcomm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260616235939.1358663-1-daniel.barboza@oss.qualcomm.com> References: <20260616235939.1358663-1-daniel.barboza@oss.qualcomm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE2MDI0MiBTYWx0ZWRfX9VNaH2hkDEfz oVE1vJlIToAUC44QECm0JFME1QR/10AO8i1/rvwKIBdhLaXFlEHs/WDfh1NUPlHqMc4UOpyhZFk R96lTdPU5EcZ4hm4QydedvCYnsEf44E= X-Authority-Analysis: v=2.4 cv=D4d37PRj c=1 sm=1 tr=0 ts=6a31e377 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=gdiugJE53z4H+vvYeRBHqw==:17 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=rRz0n67az6SdDS5ShVgA:9 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-GUID: zo_cPmQ39jnx9njNVP1-20KTG-ISz_NR X-Proofpoint-ORIG-GUID: zo_cPmQ39jnx9njNVP1-20KTG-ISz_NR X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE2MDI0MiBTYWx0ZWRfX9dfxyy55pT5q 803pTYcpk0p36PI/HZc560LjT5j8BwzyWgBCx4et08pxT9jsMqY67c+/xqqDihon//v5Ll5l8h5 9lGZ7OWsezZUbkLFGbocqebSj80ETHH35yS9tMji6QTr0NRNxRDCdtzUw4J/7us9j4KbJnruq4j 6ACcoGOjmMQFBxNgbeCyLdDi6dFbL45Pa+DgRcb8UwYju6xLNlqwpJu1fuMceUB+0g3yQeeaRDR KvbCims8ZjptCrFMfHca9Cgg2mME3yYy1vmCCoJFXTedl3niqPRalRG2ZYlrf88I5kDUn1Gduap iAADa2fsOmrAhfFfcLnLONt2hOSoeqTMeFCC/c+n/T+nlAAhirnJ/pL8olYSwiLlNaHatEd8wrk Yktgmy/WJPlRCTygpd7YogtyCXTVN+yFm2rfztXXLCLxtt79CUqT07Tjmr9bTrPsFI3ml+6eCIt JKS9bqMoqXtDms7ymmg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-16_05,2026-06-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 spamscore=0 adultscore=0 clxscore=1015 impostorscore=0 malwarescore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606160242 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=daniel.barboza@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1781654476556158500 Content-Type: text/plain; charset="utf-8" The info about intc_phandles for each CPU is already stored in the intc_phandles array. We don't need to fetch them again using qemu_fdt_get_phandle(). Signed-off-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis Reviewed-by: Chao Liu --- hw/riscv/sifive_u.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c index fda9a09f06..b3468254f5 100644 --- a/hw/riscv/sifive_u.c +++ b/hw/riscv/sifive_u.c @@ -199,20 +199,16 @@ static void create_fdt(SiFiveUState *s, const MemMapE= ntry *memmap, plic_phandle =3D phandle++; cells =3D g_new0(uint32_t, ms->smp.cpus * 4 - 2); for (cpu =3D 0; cpu < ms->smp.cpus; cpu++) { - nodename =3D - g_strdup_printf("/cpus/cpu@%d/interrupt-controller", cpu); - uint32_t intc_phandle =3D qemu_fdt_get_phandle(fdt, nodename); /* cpu 0 is the management hart that does not have S-mode */ if (cpu =3D=3D 0) { - cells[0] =3D cpu_to_be32(intc_phandle); + cells[0] =3D cpu_to_be32(intc_phandles[cpu]); cells[1] =3D cpu_to_be32(IRQ_M_EXT); } else { - cells[cpu * 4 - 2] =3D cpu_to_be32(intc_phandle); + cells[cpu * 4 - 2] =3D cpu_to_be32(intc_phandles[cpu]); cells[cpu * 4 - 1] =3D cpu_to_be32(IRQ_M_EXT); - cells[cpu * 4 + 0] =3D cpu_to_be32(intc_phandle); + cells[cpu * 4 + 0] =3D cpu_to_be32(intc_phandles[cpu]); cells[cpu * 4 + 1] =3D cpu_to_be32(IRQ_S_EXT); } - g_free(nodename); } nodename =3D g_strdup_printf("/soc/interrupt-controller@%lx", (long)memmap[SIFIVE_U_DEV_PLIC].base); --=20 2.43.0 From nobody Sun Jul 26 13:29:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1781654461; cv=none; d=zohomail.com; s=zohoarc; b=eTBrlbkgq4qx8XMGrBnVwtzQlRwMF5IPfQtSsJ2ZQH2u36SDrpzLxa4LTDR97JwRegk0UUwKWqrjSJ9Dn7kjHLrYYv4iy4vhvcG+nxsBCtdeCxFL18ws3N2tV8t1zVDx3merslyR29zjdwdowyNUE2Sq4ZXzXt86ZRKFbl6VZt4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1781654461; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=WqDMeKheitMgA2PlOARFdVAHfl6rsSJccdZUs0l87dc=; b=aWm/ay9kKAl379y0QBF6SZzv5iZDxYc7jTkavZzCPilFw/yLxsMbY3J49v1eoeGhruU+8j3YHfvt7wuMIbS6PUQg2B0Z/WS/9cxWBLHdyi8Fb3LfiPkDdsPypE4OmbLne887LrpHo1szNi3DX5YM5OefmoqcCUXkJdA5XVjl1JM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1781654461455539.7302048044476; Tue, 16 Jun 2026 17:01:01 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wZdhX-00024C-1b; Tue, 16 Jun 2026 20:00:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wZdhI-00021i-AU for qemu-devel@nongnu.org; Tue, 16 Jun 2026 20:00:01 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wZdhF-00084m-3z for qemu-devel@nongnu.org; Tue, 16 Jun 2026 19:59:59 -0400 Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65GLTHTU198289 for ; Tue, 16 Jun 2026 23:59:53 GMT Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eueer0dxy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 16 Jun 2026 23:59:53 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8ccd3213beaso99973306d6.0 for ; Tue, 16 Jun 2026 16:59:53 -0700 (PDT) Received: from QCOM-UWl2o8bcGT.qualcomm.com ([177.170.117.62]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8d9f132178csm50191986d6.7.2026.06.16.16.59.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 16:59:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=WqDMeKheitM gA2PlOARFdVAHfl6rsSJccdZUs0l87dc=; b=HMxJMvgitO7dcr+ZIPKNGv5vjYZ CxIL/sX9xNl9YjR7ZHEi+eZn2d70lZT/bN28gaSIcazfYlXdhu0G2tAXlRI9vDJX Tp236QJ0pBW+F2zFcsH8k4MzcCpusur4SYzB2s0kP34hOj4LBiH5ffwhBCN/CKLS f5ryTTVP9vkn9Qgm7VJGCmdR82i0zpMRzYGfZ+vtCSe1tx0dxOkbKkUN4TxVWzFW HgWFgu0kLreTymL6lJhElgrDwmCDHhyT/Rzs2PD2lNi3YeoDwemQHXU3WB3Zy4p3 lErDF6NbbLwSlY5Rr08bxQYqATrKk75Cl4Rbo+g6OhAM63RcNbKfyJjWwsA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781654392; x=1782259192; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WqDMeKheitMgA2PlOARFdVAHfl6rsSJccdZUs0l87dc=; b=eohT6R7DR7rMCUp6QmVTgMJUVgSsFz5So4X5Wh86RQBEFz6WCEIziEwbRR+I/Fkbsb LdY5R3+DNiWy3INukGJ572ebeI/ynRMD6IXbSrbxvy6JKKIOqLB4rOD8OxVSLVi1ET3V kqFx1l/u2k9yJ827l6KHQj1oBnahLzd8I0EGi76nTFnSUeFbgUX1FNaYmD8xQApqWk/F 594FBDPOiHuhHYny+4vr8dr+N08lc5d+OuaZsrhUQJPOuh9aOaGJbxYSUuYbWpz4S7nC OPtLdEjY5JyK25F3qgfm5/s2PBf0nnrWadJUYY43sITYzRYdMBOCJlXfvKqdKqlon5C3 Jbqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781654392; x=1782259192; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WqDMeKheitMgA2PlOARFdVAHfl6rsSJccdZUs0l87dc=; b=fIRYy3m6o4VG3AOe8wx3NZ7xh3qOIPUg9O0oQjQiNTAV/r2BqjCaA6ApebbPm+i9hl CU3HB9VtVg3KtsNrg4+E9E5cGpR4N65NgPnonA/enK/7WyX1Dh7rovwVX/oiI8Edonf3 lQSIbzlTI9QgQq0dTATfwkTL5NdHCPBX1yAtqtpjitlVhk5my8KuCXrMPsPevapcHLDD XcAuyfZP8D59So4GBz8ZSSyB+8p4o3Svi4G8Ncy6YFPtLcT4jQkDvxVJsY4IVHnbCd4m VNPwk+e931RjCVtcXClD7QzyiHECfGq+tJCysosdSFlZCE//xSZNk2DWK/fE0fdl/B1U fsMQ== X-Gm-Message-State: AOJu0YwrXtFX9Qkypx4UePlub//cKVJpV2qtFoAEi4aM+VtIgz+V1e/G CzMsJD+8iwgp7KtWQ9EqCrfk7qVUvnPY84drEWNAw04VdQrnArwQIWM0eORJ+wQVVT+Z1BQ/0WT CHlzDDsBDO3goVmzksFYFs9nTOnuqteVx7+h5mGjE09VXITtAAGyh+i85jgRUbbi1tA== X-Gm-Gg: AfdE7cnPhixCuwBD8b63NBXJfW5AIW50av5LTprJW1rvA5MUUdi4+aw5uzeSN9oJhyG hhfIL6+LYi5EDakuK+hIwUwgLCsxnE2e1zGwL2MWD5+yq2+HlfFTOdZ4SePEV20/S+t11YT61mv x1KoX8rv622NFSP3pTYZuyZ3nXpXIiW3Vh0Rl8Dm9oKbdqAlsXThFgJpnzobE2LKFYiZeFQlO6F wIRgCZ9PRixtMKiJ8sYOT9GFHki6CUmeHaRK4cFFo0mWsB7dsHlI12pdypYJ183dpwtUX7+q95C n0Wdh+CW7eswzYGdf40p98exjPl2+cH5fgeUXRvxBYOj3TnRmtdkMIxT4UUV0qRMT3q7lOdDhtq h0svruzn0g7BV3Yi/0CSbTsy5KCn6WFPk4Hs+GFPIUxm/AXWv1xfES0TNFPU= X-Received: by 2002:a05:6214:258d:b0:8ce:e409:22d8 with SMTP id 6a1803df08f44-8db83519ca5mr23749946d6.28.1781654392569; Tue, 16 Jun 2026 16:59:52 -0700 (PDT) X-Received: by 2002:a05:6214:258d:b0:8ce:e409:22d8 with SMTP id 6a1803df08f44-8db83519ca5mr23749636d6.28.1781654392126; Tue, 16 Jun 2026 16:59:52 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, alistair.francis@wdc.com, liwei1518@gmail.com, zhiwei_liu@linux.alibaba.com, chao.liu.zevorn@gmail.com, Daniel Henrique Barboza , Alistair Francis , Palmer Dabbelt Subject: [PATCH 3/5] hw/riscv/sifive_u: add #address-cells in PLIC FDT Date: Tue, 16 Jun 2026 20:59:37 -0300 Message-ID: <20260616235939.1358663-4-daniel.barboza@oss.qualcomm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260616235939.1358663-1-daniel.barboza@oss.qualcomm.com> References: <20260616235939.1358663-1-daniel.barboza@oss.qualcomm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: 5vUOwyHfZUcRVkZPxlTKZA_AlNpShv69 X-Authority-Analysis: v=2.4 cv=Mr1iLWae c=1 sm=1 tr=0 ts=6a31e379 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=gdiugJE53z4H+vvYeRBHqw==:17 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=XZ4Qgz962IF3wEqZkZEA:9 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-GUID: 5vUOwyHfZUcRVkZPxlTKZA_AlNpShv69 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE2MDI0MiBTYWx0ZWRfX1aMgFJQFMd/n TmixEfbP/B73XjLi2Ml0/AEmgfsktd9LoI/4crprMp7DIUr5/KigB7L5aF3cxPxgNeCMB8UbpyY Xsj1wU3bimHzSF7e0j9bjLy0uLheILg= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE2MDI0MiBTYWx0ZWRfX+oUz6/JxTOnk 7z1irz8v1/O5wo0D1bBsg1Yn/wdmJ6UnFzNSByHWh683yv0bh5nEO4J6olYVsfgnC31EJyKxamw lbHGxLuPEIAFwysveW57JM9psJv7xkE3flOsvAE0k67C+LCF2zBtVC84kv+xF2SvRqDZBox6Dpt DKzFUYEE5iLUjmjlK7xL1w1+N72MhB6D0038y7GR/1u0re+7YcXHEcgXmqhtT51cp5rGnDmL9Vz XGNyBTR54XknoinR1RWxF5qKGTQVSaP9/t3Vd33RLVevRRUewTCp8GX5Qc1+JrvFKrFVQaVBX0/ ne763SfO4PerMGyVk7XfbHpiNDyi1q9dTJ+/SvILXD9t+gRgXmaeKPgdg41zQzI5tggV3tqFB22 AA6wFQFWWg5PJyEjXyI9SbMkx+djCQiwdTfbDR6QLsjFjHHsflzt2z9E97TuF9vo7EW9dZnulXZ xPNdaEEWGBALzKAZ1+w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-16_05,2026-06-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 phishscore=0 bulkscore=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 adultscore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606160242 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=daniel.barboza@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1781654462458158500 Content-Type: text/plain; charset="utf-8" By Linux FDT docs in [1] the "address-cells" property is mandatory. Set it to zero. While we're at it let's also put this new value and the interrupt-cells value in macros, like the 'virt' board is doing. [1] https://www.kernel.org/doc/Documentation/devicetree/bindings/interrupt-= controller/sifive%2Cplic-1.0.0.txt Signed-off-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis Reviewed-by: Chao Liu --- hw/riscv/sifive_u.c | 5 ++++- include/hw/riscv/sifive_u.h | 2 ++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c index b3468254f5..7dfc18d3ec 100644 --- a/hw/riscv/sifive_u.c +++ b/hw/riscv/sifive_u.c @@ -213,7 +213,10 @@ static void create_fdt(SiFiveUState *s, const MemMapEn= try *memmap, nodename =3D g_strdup_printf("/soc/interrupt-controller@%lx", (long)memmap[SIFIVE_U_DEV_PLIC].base); qemu_fdt_add_subnode(fdt, nodename); - qemu_fdt_setprop_cell(fdt, nodename, "#interrupt-cells", 1); + qemu_fdt_setprop_cell(fdt, nodename, "#interrupt-cells", + SIFIVE_U_PLIC_INT_CELLS); + qemu_fdt_setprop_cell(fdt, nodename, "#address-cells", + SIFIVE_U_PLIC_ADDR_CELLS); qemu_fdt_setprop_string_array(fdt, nodename, "compatible", (char **)&plic_compat, ARRAY_SIZE(plic_compat)); qemu_fdt_setprop(fdt, nodename, "interrupt-controller", NULL, 0); diff --git a/include/hw/riscv/sifive_u.h b/include/hw/riscv/sifive_u.h index e4c9860d50..aed966a62d 100644 --- a/include/hw/riscv/sifive_u.h +++ b/include/hw/riscv/sifive_u.h @@ -156,6 +156,8 @@ enum { #define SIFIVE_U_MANAGEMENT_CPU_COUNT 1 #define SIFIVE_U_COMPUTE_CPU_COUNT 4 =20 +#define SIFIVE_U_PLIC_ADDR_CELLS 0 +#define SIFIVE_U_PLIC_INT_CELLS 1 #define SIFIVE_U_PLIC_NUM_SOURCES 54 #define SIFIVE_U_PLIC_NUM_PRIORITIES 7 #define SIFIVE_U_PLIC_PRIORITY_BASE 0x00 --=20 2.43.0 From nobody Sun Jul 26 13:29:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1781654445; cv=none; d=zohomail.com; s=zohoarc; b=LnMV3xkgEaYRWShTjc43hi441zWlejEicj4KksSYs/aQP4BK0lUqXRPaQJOO+F63fPMYc4WQgMLbeuP3yyMhJOzGRP6fAgSxQGw+RpwaV3qlqZU7S3auTUhJ8ZIOOjMhvE/7o9e1wWX33VUvQbQ2a83jOQlpCq3XDt+iC2hwPpQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1781654445; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=OQFU1HE/RsfwQU6jI7sPub53aSy2639W49+DYPI7GX4=; b=c/X91U4J/1cNnrcDaUFZtpdZJMXBoM6AN0NC0yiJZf143MZ8XrLIVB1sc0lHWFhbCE/v/NcF6kLFFW8P4WClHgj4CilLopzHYkzlztcookydFpc26sc1X2E35vZd7St8CC6EkV9+JfgjrA4xK2LBaHX/WokzAUwUWUzimHzZSdE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1781654445171913.3690199753918; Tue, 16 Jun 2026 17:00:45 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wZdhc-00026G-Om; Tue, 16 Jun 2026 20:00:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wZdhJ-00021m-Aj for qemu-devel@nongnu.org; Tue, 16 Jun 2026 20:00:01 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wZdhG-00085J-AB for qemu-devel@nongnu.org; Tue, 16 Jun 2026 20:00:01 -0400 Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65GLSune274532 for ; Tue, 16 Jun 2026 23:59:56 GMT Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eueemgdmu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 16 Jun 2026 23:59:56 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-8cceb0317b3so78759056d6.2 for ; Tue, 16 Jun 2026 16:59:55 -0700 (PDT) Received: from QCOM-UWl2o8bcGT.qualcomm.com ([177.170.117.62]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8d9f132178csm50191986d6.7.2026.06.16.16.59.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 16:59:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=OQFU1HE/Rsf wQU6jI7sPub53aSy2639W49+DYPI7GX4=; b=OUi4D+yICeet5SWqNMpfqWK+kXE 5m04kuuaYEKqrigImojdzUd5naGTdNQ/yXsIBcQ+YOrBTFIeqlkmmA8uO3TDiNzI hc4LxWHOfe/RhmmgqEAzwOES+UfHCZd7ssveHA3nSuP1tKmWqgivoGOaOxD6B0Z6 vdhVeGCKncEfhDvOK9NbxG7HSMEsLiI0/b++jnAnde+ms1WQ1Eo1XMW/LESCB4NF e1x1UHSgUrByrEDmHE7P4w4yAakO0IO4EY2fiH38QowxUOBWYcN7JQr5hfSV0pxO FW8RX9PWnRr8acWxeIg6rSGahjXsd4ktPX8VxWj/mtP0ZU2BDDvPC8BgO6A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781654395; x=1782259195; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OQFU1HE/RsfwQU6jI7sPub53aSy2639W49+DYPI7GX4=; b=MdDtXDsyrOArFq4qJbRc1nQ5pR1M55G5j1ouGaLZa+gUiD9vCzzVCgugOSYeo8IrT9 ApeWvLt9S9XwwF0krWFCY50NEUsa4GqIqAfrdKHYJEM5igrS3zQWtuB+5TMExuLktFf6 eAj6zbQXYa4pq8rmXCy/calFWxHU8MTvfsle7ITQo+ABPS6WT/eIT6s+g83dICFT6PFM zC03soy9hJ3P4frVTU5YT+U3IL1hQ8yqVpVVYhDuke98AiUoF0bhQ3UKASHychnByz46 Vnof+B/NIELrRnikQ+02Y0IPuzxboy2wMKvXw9LFV+Yral5WMa15nTZgE58xcH3OM/Vs 8nJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781654395; x=1782259195; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=OQFU1HE/RsfwQU6jI7sPub53aSy2639W49+DYPI7GX4=; b=Mmj/uFYgzlf9j+T9XFeHoKy2C4CZWP0zBHgiaWrow0ISrqLkzaIKe9/4+zcF3TXLhv J65Qm1f45GJIVukJx42n9ywM+eF1vxQ1vYwgFyCboNd5349nzmmcOs4FSp68BkNRmp99 jDncOlaxy0sZ0myKS0XgHu5dWX/C7bw9nsc0b6ki4axeKW+fSopzGXRXQ4WGSLOtn3MB 8o9gSGQtBnOlXKrO9yjX3qqWDVGdrZw02C+7DEVsEcGcZFdWAXfJ3R1OJRdmwvsLN8EJ Js56WFNPy3pkjYSWvpKGSc1IhkSUE2ixe1gbdyDVE1CKMNw6UAquFNffY4kMhSYA+Icv OvNA== X-Gm-Message-State: AOJu0YyIp57Ddj8jvG0yTE8mIdnJqn13N62zT8o4eTc+lwLqjkcTxrqx BosripgDa+T5PWw8LOuhT0u/Qp4B+S5V3FDkvkwZfcYg4/jETVpVtZLZdhB820/SG0kqvIXzt3o 13kTiktBvCRBDWndFdOpsvlGBPHYv4K9bG9R6HGNy7iQutik0VsoSa/utf3ZfuV4Q+g== X-Gm-Gg: AfdE7cmiQjTC2R3Ke8y7Q8jKHndiFiHVNt5aIGWm2piiv87s2OM+/vITuqcsGKqJ/fE sYii9y44fo77lMYTCog8ag6Gh1lUV+46+AN9vSyZ0fH3UOL+qI6wJs5pjxJPTgAObPlNGD3XE48 8YNzPcCHA1avk2iyyHQ/ybpMCtVgKktNpjjr+5tbElrXUf3aivqrQyl/OmSQCbfXI9fDThIt7kP HX1yLT5zVsTJ8X5nzZvpGpv8R/I49+XbVw6SLT0GCJJ1/8bIw5p9grrSaiVOa7Err8FexegHfd2 eIuVIQtTplcvGjtP5kQnKyDy7SXm4sCDIoCOaNtE5OERANtuwJm7gE8UwYOe3ZnA8Or4HQo6AS/ jP8fCbtDyeraA3tSkfupB6QtEApXiqtxruvv47xDMkRRP+hHhYssB9RLI6Ao= X-Received: by 2002:a05:6214:3314:b0:8ce:ba1c:eb74 with SMTP id 6a1803df08f44-8db5ab0e921mr27890876d6.14.1781654395054; Tue, 16 Jun 2026 16:59:55 -0700 (PDT) X-Received: by 2002:a05:6214:3314:b0:8ce:ba1c:eb74 with SMTP id 6a1803df08f44-8db5ab0e921mr27890646d6.14.1781654394678; Tue, 16 Jun 2026 16:59:54 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, alistair.francis@wdc.com, liwei1518@gmail.com, zhiwei_liu@linux.alibaba.com, chao.liu.zevorn@gmail.com, Daniel Henrique Barboza , Palmer Dabbelt Subject: [PATCH 4/5] hw/riscv/virt.c: change 'plic' nodename to 'interrupt-controller' Date: Tue, 16 Jun 2026 20:59:38 -0300 Message-ID: <20260616235939.1358663-5-daniel.barboza@oss.qualcomm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260616235939.1358663-1-daniel.barboza@oss.qualcomm.com> References: <20260616235939.1358663-1-daniel.barboza@oss.qualcomm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE2MDI0MiBTYWx0ZWRfX7w2Z9RKZ0umI ajWqe+fvBH4/Y7uwCdtlIxtnq9LIf823UUe17aIg6rwbSHH6G7W0MYhagALuhrUPKb15fbrjgB1 NAw6hkLeXF4vJwrYTNfp4qfnU4HbjMI= X-Authority-Analysis: v=2.4 cv=D4d37PRj c=1 sm=1 tr=0 ts=6a31e37c cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=gdiugJE53z4H+vvYeRBHqw==:17 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=ccoGwOx6eHDXAKTbG8QA:9 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-GUID: 6BwQpTnyP_ZnhLSZHEQfiXQrCRp-WHLh X-Proofpoint-ORIG-GUID: 6BwQpTnyP_ZnhLSZHEQfiXQrCRp-WHLh X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE2MDI0MiBTYWx0ZWRfX0osfTtmcNoeM S+eYZsLf/THG99vUTdTHdD3PJ2kDejtO+dHfKjX98v2sRI5amf011dBLq4Yd2LmMT96OpOr4PUE aLir7kq3QKpDuw9698AmQ7fi/3+Mx3G5svPH6AbxbtHORV9TNdVuXP5yIiyFm+hOF4oY+QvanSq 2aEKvTl4TgYnzPWsYSNwqIYyo3jI8vO/LNIJWrY/7ak2pnuhkrHRDhq/uq9bW1Lm1iNV+VMbOCf Ddq8ZwAml+bFTufruuizO8jx4scx0y9fz77GjNzfM04jQWs3kclhauMlWL88C+aWpwtc4gtMkAv BzjDLAaE83FIXNz/Mwn7AJidJwc3LHH755ruyLKyDW9aue6irKScTkI1XP4lvDvEO5mWySPOrF4 EzV6aP+rnWHit/ZrPr6eEcPFp9mpDFm9rxKYjqF4wgYUCR7DZ1im5UYdewN5uRMu01Im66xHkuu ll+LZeBc4UE9sUs3iKA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-16_05,2026-06-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 spamscore=0 adultscore=0 clxscore=1015 impostorscore=0 malwarescore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606160242 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=daniel.barboza@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1781654446576158500 Content-Type: text/plain; charset="utf-8" We're still using "/soc/plic@..." as FDT nodename in virt.c. This is not the right nodename per the DT docs: https://www.kernel.org/doc/Documentation/devicetree/bindings/interrupt-cont= roller/sifive%2Cplic-1.0.0.txt The nodename must be 'interrupt-controller@...' since the node inherits the 'interrupt-controller' type. In fact, ever since at least the 2020 Linux kernel commit c825a081c169cc7f ("dt-bindings: riscv: convert plic bindings to json-schema") the correct nodename has been 'interrupt-controller' for the sifive PLIC controller. There's no deprecation needed for bug fixes so we're just fixing the name. This was the policy we dud when fixing the aplic [1] and the imsic [2] nodenames to 'interrupt-controller@...' as well. The sifive_u PLIC FDT already uses the correct nodename for PLIC, so it is safe to assume that available SW is already aware of the correct nodename and this change won't affect well-behaved SW. [1] commit 29390fd ("hw/riscv/virt.c: rename aplic nodename to 'interrupt-c= ontroller'") [2] commit e8ad581 ("hw/riscv/virt.c: change imsic nodename to 'interrupt-c= ontroller'") Signed-off-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis Reviewed-by: Chao Liu --- hw/riscv/virt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index 33775a61fd..fa464e644f 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -335,7 +335,7 @@ static void create_fdt_socket_plic(RISCVVirtState *s, plic_phandles[socket] =3D (*phandle)++; plic_addr =3D s->memmap[VIRT_PLIC].base + (s->memmap[VIRT_PLIC].size * socket); - plic_name =3D g_strdup_printf("/soc/plic@%lx", plic_addr); + plic_name =3D g_strdup_printf("/soc/interrupt-controller@%lx", plic_ad= dr); qemu_fdt_add_subnode(ms->fdt, plic_name); qemu_fdt_setprop_cell(ms->fdt, plic_name, "#interrupt-cells", FDT_PLIC_INT_CELLS); --=20 2.43.0 From nobody Sun Jul 26 13:29:19 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1781654458; cv=none; d=zohomail.com; s=zohoarc; b=AeVl076jDs7J0tdxe7RKNp7f/imuj//7bYTgIDb6zfNhiik5wWyUVSHLdROJQZIqQgAGaIYRfWRo9g8T9JczxAjrpU3Ail//49S5eEoFwj0FzuaYqAgOxP0WJbUnhPU8UIuWL+5D/hK5RvXJD9n1PGmzO1L1xwGtnDmUcMkwmW4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1781654458; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=unO92+lnNGmVO9KZxwtq4wi6H407p3XqwnUKjG/RMR8=; b=Sr+iTdA483t1tZTg4V49ETeSO1OHmOrpw0k6vkBSJN3P1xZDEqBMhpe2NU4+/fEp5/XpBBD2vFHbbDhZWkkVnieP0b7NHgaqZ219vl0DEawc+8Hzc22kwI/V1wBdolhWjABkZrbkY8X3C+3bSl63OvRRYJkpFoSyX3tRFABt9QU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178165445867269.07117873037157; Tue, 16 Jun 2026 17:00:58 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wZdhb-00025z-Fi; Tue, 16 Jun 2026 20:00:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wZdhK-00022n-I6 for qemu-devel@nongnu.org; Tue, 16 Jun 2026 20:00:10 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wZdhI-000863-Ag for qemu-devel@nongnu.org; Tue, 16 Jun 2026 20:00:02 -0400 Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65GLUYTx252999 for ; Tue, 16 Jun 2026 23:59:59 GMT Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eueet0dy9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 16 Jun 2026 23:59:58 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-915767b341eso501245885a.3 for ; Tue, 16 Jun 2026 16:59:58 -0700 (PDT) Received: from QCOM-UWl2o8bcGT.qualcomm.com ([177.170.117.62]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8d9f132178csm50191986d6.7.2026.06.16.16.59.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2026 16:59:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=unO92+lnNGm VO9KZxwtq4wi6H407p3XqwnUKjG/RMR8=; b=YYZrCHMxwCMy5uw91T6Yoo6cjSn bdhvDzt0IhYXDzVpneSb/B7uOTwPfwewrMw8B3VR/+DYo3gYByEuDjLFFhU3Ry2L 0ZswVY2CC/Y3cTN4lRDCEOiqRUc65gnQgaIFpY6HfH789xm8sLSUA15/e/a4CQq/ Tase+E31ezmevtLOZGhg/g2Ur5j6dw359d+NoiOBdkTBT0XiBNaNCcFZcWCLmEhk omXsQsFWDiFeug6fcH0qUXCSUB+JboiVIbktOSrCA8O9fgxiXpT1fceSx2odfF3/ rVlsNg0WEfng8oF6v+DbJqNDvpDQgGs6VrAmbmPndYzMStsBzDQyrSM2aew== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781654398; x=1782259198; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=unO92+lnNGmVO9KZxwtq4wi6H407p3XqwnUKjG/RMR8=; b=VfqRx9gGGGVdniQQLA1WXTaQv0ykPPDHNWof8RpdPSDnblCupQ5/sAu4AnoHH7KkFw 4JBF4cVUtqTc5v374a/t8o/S91GK/mrkkpH49gGpW+3SPagjJ35mUb+ZyskIRk7fw8UH X+CGvM0/xeCbMU53WKaFcBtQ/WYgDcjnePIWk1aFm937eqnO3WnTvoDFiJAuf/39r9fK iyng6F0Kb71qjlA+7KaAMh1mKpfOzhj6MT1f5p25nDsUm9bN3VuqGfmMi4Wp8iVkU7lO ZWW2J5rmoHKP3LH4iwLtHR6xpm3kBnlDXGwWd154S4H2/HVnoutZUHxe6dxrk83q75yv aLwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781654398; x=1782259198; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=unO92+lnNGmVO9KZxwtq4wi6H407p3XqwnUKjG/RMR8=; b=cO+mj5LkWCVXFXVMdxKZ0VoRxCoWbQwCrGUUG0ScjWSraRPv/HpPd6hXHtDYOhCrlC ckPWdL1cgte3o9RzTQQBLEjNknJYgAV+bbnIbgaQ3Pdsi4pihmqTYCXjZRZCkDMyNw2u cbSmE7QXeUQl+0ZYAPbsrmgBo2jY1AHHys/pZe3eS8bp4M56flAfhjZ9eQVZs4ET02um ST0NxffTErfAVI2szYbAulfs/jCQcLug9F7z6LQJFjDM12BsbSQf/Sx1rGfXiMW/V2nW tC2/wMlw1V8kOVFv7Hhdk3eULB526vPDdVEWAPcq3wRIl8Dtg/FaAr0CdF0ix11/ccyt 35GQ== X-Gm-Message-State: AOJu0YxUlJtdTMvx7G3TU7Z3GLzH/E8GpQ3c9HHHOKpy8SDFNC2ZjMI+ nYiRgwYFQ31Y6cbFpPUINXeNaXzA1QE6w14PVSvIjHCXsL9RidIDbP+WglBK+Psp09RtRbYbmMr IjdVtfodLF2cjjcLiYubZQ6nl9JM4kWEvrTSJadoZmUApHHYZLOC2z/Z9udJzpGU2Bg== X-Gm-Gg: Acq92OHenVkJ7YgdXSr7/nWvji494nB6zF2aQ8658lYoIp2UB8yv4pNU+3tpNfuEUrw nj+fUx4F7JJ5zQs1XsOpBcV+xkNp+onGrjfD1k5A3ZcpiqDbtrTvW+tUphXzW0QfwzXfSrdkmp5 TjjckpFCZ4BgFz1LJusrSLPw68d9UwVMj6qTDnYii4H/UU0BoxC2cuJbKIxpJeDoYfGLCC6+mc8 TExV8QxyO8EXxNjmNS5yET8orL/Dj5i1aJSMv2WmaFwOzQj3BHTzFV8hM/rn+5VDaDUvdNVWnF6 CyihniuVXJqqDlJ72LrDPcBbyL1qHhfJfP9jyaeNN5OqrOAlFYjrSGV2gqkH7ycaWVGUeAbaMhR 30VKf3nJeE2fLGXHPN6F67CirgDyA384W6x4t3wEU4POGwTM14qq51RCH1DQ= X-Received: by 2002:a05:620a:19a5:b0:915:f360:e974 with SMTP id af79cd13be357-91d8afca51bmr340813285a.13.1781654397752; Tue, 16 Jun 2026 16:59:57 -0700 (PDT) X-Received: by 2002:a05:620a:19a5:b0:915:f360:e974 with SMTP id af79cd13be357-91d8afca51bmr340810085a.13.1781654397279; Tue, 16 Jun 2026 16:59:57 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, alistair.francis@wdc.com, liwei1518@gmail.com, zhiwei_liu@linux.alibaba.com, chao.liu.zevorn@gmail.com, Daniel Henrique Barboza , Palmer Dabbelt Subject: [PATCH 5/5] hw/riscv: add create_fdt_plic() helper Date: Tue, 16 Jun 2026 20:59:39 -0300 Message-ID: <20260616235939.1358663-6-daniel.barboza@oss.qualcomm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260616235939.1358663-1-daniel.barboza@oss.qualcomm.com> References: <20260616235939.1358663-1-daniel.barboza@oss.qualcomm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-GUID: uSurWv8n4m51PYMi8ik-AiDQeZtwMgee X-Authority-Analysis: v=2.4 cv=JufBas4C c=1 sm=1 tr=0 ts=6a31e37e cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=gdiugJE53z4H+vvYeRBHqw==:17 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=1RCqQv7lTB3P1bPT2QYA:9 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-ORIG-GUID: uSurWv8n4m51PYMi8ik-AiDQeZtwMgee X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE2MDI0MiBTYWx0ZWRfXzhHZOqFgDU4w SwpHiIfLkWxsROo2DoS/SsUEkHaEkHpieBP0AMncXCF1MUUcv3e1biPffB71/Z9qt6EuIegMmd+ xBOxlRgKNoD3jLkCmMrRE/BXFlaOBy2x9e5fwK+Tmc9mzK2WWY2K50PEbv/ch9Uq46gp72fk3an wUOmnhK/QqEkS44PuqASE9jHVa1f1MphlGaOyqiAWlmhd81S0BTamc9oEgR8EpbvDuWvQbxTx2n pyzmZYrsvL5L8tgGX/ESHLvDVB8LQH9xpX9SupPLtSCHn9a/NOLH68Xgk2ihZVI4nUfMkpg2s6R Vv2IY1Tc08uicwm/j8ytvb2RjH0YOtQWAOu6DlsP7C8PF8IsgK3puEPEI0jgvpkS4ms7rMLnni7 jXyiOGg4g7TNUctipBangwgxuYpjYi6YJR5r/w0LVnQV4D2OHymzjCcJVmoo9ihFphRat46drgL GQwvTqXFPwqPI1XFrLw== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE2MDI0MiBTYWx0ZWRfX2YbYtr5yoeiV mLaaWRpkey3ZT7YFYZwSTXV4/XkNtyuUtLeGPlEAZmfPXlkSWWkO6rMIH7imB71IsHuxc5p1l3d ErSo4MdymjCFVBd+5wX+hCuaNHUmUWQ= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-16_05,2026-06-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 adultscore=0 priorityscore=1501 impostorscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606160242 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=daniel.barboza@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1781654460806158500 Content-Type: text/plain; charset="utf-8" Consolidate the common plic FDT code between 'virt' and sifive_u boards into a single place. Signed-off-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis Reviewed-by: Chao Liu --- hw/riscv/fdt-common.c | 30 +++++++++++++++++++++ hw/riscv/sifive_u.c | 34 +++++++----------------- hw/riscv/virt.c | 49 ++++++++++++----------------------- include/hw/riscv/fdt-common.h | 5 ++++ 4 files changed, 61 insertions(+), 57 deletions(-) diff --git a/hw/riscv/fdt-common.c b/hw/riscv/fdt-common.c index b27ff13bca..e0e31af09b 100644 --- a/hw/riscv/fdt-common.c +++ b/hw/riscv/fdt-common.c @@ -200,3 +200,33 @@ create_fdt_socket_cpu_sifive(void *fdt, char *clust_na= me, socket_id, socket_hartid_base, phandle, intc_phandles, false, false); } + +void create_fdt_plic(void *fdt, hwaddr addr, uint64_t size, + uint32_t plic_phandle, uint32_t int_cells, + uint32_t addr_cells, uint32_t *plic_cells, + uint32_t cells_size, uint32_t ndev_sources, + bool numa_enabled, int socket_id) +{ + g_autofree char *nodename =3D NULL; + static const char * const plic_compat[2] =3D { + "sifive,plic-1.0.0", "riscv,plic0" + }; + + nodename =3D g_strdup_printf("/soc/interrupt-controller@%"HWADDR_PRIx,= addr); + + qemu_fdt_add_subnode(fdt, nodename); + qemu_fdt_setprop_cell(fdt, nodename, "#interrupt-cells", int_cells); + qemu_fdt_setprop_cell(fdt, nodename, "#address-cells", addr_cells); + qemu_fdt_setprop_string_array(fdt, nodename, "compatible", + (char **)&plic_compat, ARRAY_SIZE(plic_compat)); + qemu_fdt_setprop(fdt, nodename, "interrupt-controller", NULL, 0); + qemu_fdt_setprop(fdt, nodename, "interrupts-extended", + plic_cells, cells_size); + qemu_fdt_setprop_sized_cells(fdt, nodename, "reg", + 2, addr, 2, size); + qemu_fdt_setprop_cell(fdt, nodename, "riscv,ndev", ndev_sources); + if (numa_enabled) { + qemu_fdt_setprop_cell(fdt, nodename, "numa-node-id", socket_id); + } + qemu_fdt_setprop_cell(fdt, nodename, "phandle", plic_phandle); +} diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c index 7dfc18d3ec..d923f041e0 100644 --- a/hw/riscv/sifive_u.c +++ b/hw/riscv/sifive_u.c @@ -100,14 +100,11 @@ static void create_fdt(SiFiveUState *s, const MemMapE= ntry *memmap, MachineState *ms =3D MACHINE(s); void *fdt; int cpu; - uint32_t *cells; + uint32_t *cells, cells_length; char *nodename; uint32_t plic_phandle, prci_phandle, gpio_phandle, phandle =3D 1; uint32_t hfclk_phandle, rtcclk_phandle, phy_phandle; static const char * const ethclk_names[2] =3D { "pclk", "hclk" }; - static const char * const plic_compat[2] =3D { - "sifive,plic-1.0.0", "riscv,plic0" - }; g_autofree uint32_t *intc_phandles =3D g_new0(uint32_t, ms->smp.cpus); g_autofree char *clust_name =3D NULL; =20 @@ -197,7 +194,8 @@ static void create_fdt(SiFiveUState *s, const MemMapEnt= ry *memmap, g_free(nodename); =20 plic_phandle =3D phandle++; - cells =3D g_new0(uint32_t, ms->smp.cpus * 4 - 2); + cells_length =3D ms->smp.cpus * 4 - 2; + cells =3D g_new0(uint32_t, cells_length); for (cpu =3D 0; cpu < ms->smp.cpus; cpu++) { /* cpu 0 is the management hart that does not have S-mode */ if (cpu =3D=3D 0) { @@ -210,26 +208,14 @@ static void create_fdt(SiFiveUState *s, const MemMapE= ntry *memmap, cells[cpu * 4 + 1] =3D cpu_to_be32(IRQ_S_EXT); } } - nodename =3D g_strdup_printf("/soc/interrupt-controller@%lx", - (long)memmap[SIFIVE_U_DEV_PLIC].base); - qemu_fdt_add_subnode(fdt, nodename); - qemu_fdt_setprop_cell(fdt, nodename, "#interrupt-cells", - SIFIVE_U_PLIC_INT_CELLS); - qemu_fdt_setprop_cell(fdt, nodename, "#address-cells", - SIFIVE_U_PLIC_ADDR_CELLS); - qemu_fdt_setprop_string_array(fdt, nodename, "compatible", - (char **)&plic_compat, ARRAY_SIZE(plic_compat)); - qemu_fdt_setprop(fdt, nodename, "interrupt-controller", NULL, 0); - qemu_fdt_setprop(fdt, nodename, "interrupts-extended", - cells, (ms->smp.cpus * 4 - 2) * sizeof(uint32_t)); - qemu_fdt_setprop_cells(fdt, nodename, "reg", - 0x0, memmap[SIFIVE_U_DEV_PLIC].base, - 0x0, memmap[SIFIVE_U_DEV_PLIC].size); - qemu_fdt_setprop_cell(fdt, nodename, "riscv,ndev", - SIFIVE_U_PLIC_NUM_SOURCES - 1); - qemu_fdt_setprop_cell(fdt, nodename, "phandle", plic_phandle); + + create_fdt_plic(fdt, memmap[SIFIVE_U_DEV_PLIC].base, + memmap[SIFIVE_U_DEV_PLIC].size, + plic_phandle, SIFIVE_U_PLIC_INT_CELLS, + SIFIVE_U_PLIC_ADDR_CELLS, cells, + cells_length * sizeof(uint32_t), + SIFIVE_U_PLIC_NUM_SOURCES - 1, false, 0); g_free(cells); - g_free(nodename); =20 gpio_phandle =3D phandle++; nodename =3D g_strdup_printf("/soc/gpio@%lx", diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index fa464e644f..92c30a6f4c 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -326,39 +326,25 @@ static void create_fdt_socket_plic(RISCVVirtState *s, int cpu; g_autofree char *plic_name =3D NULL; g_autofree uint32_t *plic_cells; - unsigned long plic_addr; MachineState *ms =3D MACHINE(s); - static const char * const plic_compat[2] =3D { - "sifive,plic-1.0.0", "riscv,plic0" - }; + unsigned long plic_addr =3D s->memmap[VIRT_PLIC].base + + (s->memmap[VIRT_PLIC].size * socket); + bool numa_enabled =3D riscv_numa_enabled(MACHINE(s)); + uint32_t cells_length; =20 - plic_phandles[socket] =3D (*phandle)++; - plic_addr =3D s->memmap[VIRT_PLIC].base + - (s->memmap[VIRT_PLIC].size * socket); plic_name =3D g_strdup_printf("/soc/interrupt-controller@%lx", plic_ad= dr); - qemu_fdt_add_subnode(ms->fdt, plic_name); - qemu_fdt_setprop_cell(ms->fdt, plic_name, - "#interrupt-cells", FDT_PLIC_INT_CELLS); - qemu_fdt_setprop_cell(ms->fdt, plic_name, - "#address-cells", FDT_PLIC_ADDR_CELLS); - qemu_fdt_setprop_string_array(ms->fdt, plic_name, "compatible", - (char **)&plic_compat, - ARRAY_SIZE(plic_compat)); - qemu_fdt_setprop(ms->fdt, plic_name, "interrupt-controller", NULL, 0); =20 if (kvm_enabled()) { - plic_cells =3D g_new0(uint32_t, s->soc[socket].num_harts * 2); + cells_length =3D s->soc[socket].num_harts * 2; + plic_cells =3D g_new0(uint32_t, cells_length); =20 for (cpu =3D 0; cpu < s->soc[socket].num_harts; cpu++) { plic_cells[cpu * 2 + 0] =3D cpu_to_be32(intc_phandles[cpu]); plic_cells[cpu * 2 + 1] =3D cpu_to_be32(IRQ_S_EXT); } - - qemu_fdt_setprop(ms->fdt, plic_name, "interrupts-extended", - plic_cells, - s->soc[socket].num_harts * sizeof(uint32_t) * 2); } else { - plic_cells =3D g_new0(uint32_t, s->soc[socket].num_harts * 4); + cells_length =3D s->soc[socket].num_harts * 4; + plic_cells =3D g_new0(uint32_t, cells_length); =20 for (cpu =3D 0; cpu < s->soc[socket].num_harts; cpu++) { plic_cells[cpu * 4 + 0] =3D cpu_to_be32(intc_phandles[cpu]); @@ -366,19 +352,16 @@ static void create_fdt_socket_plic(RISCVVirtState *s, plic_cells[cpu * 4 + 2] =3D cpu_to_be32(intc_phandles[cpu]); plic_cells[cpu * 4 + 3] =3D cpu_to_be32(IRQ_S_EXT); } - - qemu_fdt_setprop(ms->fdt, plic_name, "interrupts-extended", - plic_cells, - s->soc[socket].num_harts * sizeof(uint32_t) * 4); } =20 - qemu_fdt_setprop_sized_cells(ms->fdt, plic_name, "reg", - 2, plic_addr, 2, s->memmap[VIRT_PLIC].siz= e); - qemu_fdt_setprop_cell(ms->fdt, plic_name, "riscv,ndev", - VIRT_IRQCHIP_NUM_SOURCES - 1); - riscv_socket_fdt_write_id(ms, plic_name, socket); - qemu_fdt_setprop_cell(ms->fdt, plic_name, "phandle", - plic_phandles[socket]); + plic_phandles[socket] =3D (*phandle)++; + + create_fdt_plic(ms->fdt, plic_addr, s->memmap[VIRT_PLIC].size, + plic_phandles[socket], FDT_PLIC_INT_CELLS, + FDT_PLIC_ADDR_CELLS, plic_cells, + cells_length * sizeof(uint32_t), + VIRT_IRQCHIP_NUM_SOURCES - 1, + numa_enabled, socket); =20 if (!socket) { platform_bus_add_all_fdt_nodes(ms->fdt, plic_name, diff --git a/include/hw/riscv/fdt-common.h b/include/hw/riscv/fdt-common.h index 2d6b9a5d03..017278b611 100644 --- a/include/hw/riscv/fdt-common.h +++ b/include/hw/riscv/fdt-common.h @@ -30,4 +30,9 @@ void create_fdt_socket_cpu_sifive(void *fdt, char *clust_= name, int cpu_id, int socket_id, int socket_hartid_base, uint32_t *phandl= e, uint32_t *intc_phandles); +void create_fdt_plic(void *fdt, hwaddr addr, uint64_t size, + uint32_t plic_phandle, uint32_t int_cells, + uint32_t addr_cells, uint32_t *plic_cells, + uint32_t cells_size, uint32_t ndev_sources, + bool numa_enabled, int socket); #endif --=20 2.43.0