From nobody Sun Jul 26 13:29:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1781156320; cv=none; d=zohomail.com; s=zohoarc; b=L29hB/lxn/hyyqmBwRGD9fR4IP/1ry7Avc94P0ocFfCpHMQpW4cGNa4NL8Las1+RHdZLWla9LS8RYkHtYjle1tBA2J/Pvh4OTTWam1/ZpNTWFBJSDhMuWNELxuaeTrlahIcjX5ncrmITeEL9HPQFfZ2Xp0Y+hdZPTTG67bHcaco= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1781156320; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=DwmtLwNQ586yD7zGJVwVTp7uqi8JKqPltGIMKxadn6Y=; b=CTrwB4ufiTg2dV4C3qzkO4e7qK1Vmd/p5K5L/GUrMR5NauiaG9JDJDmi1s5dJIDrBi0jCt1AnsDjA9La6OehlnLlcHSKtuEPCfljPsNdLV7iUF8K5PTIPAps+7TuUyvTtqxt2NM7L97LnGpiPo4QMJ3Y2LgJU3bCierWJnuULlM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1781156320373156.01664194764794; Wed, 10 Jun 2026 22:38:40 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wXY3V-0002eQ-3b; Thu, 11 Jun 2026 01:34:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wXY2y-0001jU-Or for qemu-devel@nongnu.org; Thu, 11 Jun 2026 01:33:46 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wXY2v-0002hv-Es for qemu-devel@nongnu.org; Thu, 11 Jun 2026 01:33:43 -0400 Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65B5GLi23724994 for ; Thu, 11 Jun 2026 05:33:26 GMT Received: from mail-dy1-f200.google.com (mail-dy1-f200.google.com [74.125.82.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eqe6v9qu6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 11 Jun 2026 05:33:26 +0000 (GMT) Received: by mail-dy1-f200.google.com with SMTP id 5a478bee46e88-307fe856724so1885592eec.1 for ; Wed, 10 Jun 2026 22:33:26 -0700 (PDT) Received: from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30806ee207asm720800eec.29.2026.06.10.22.33.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 22:33:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= DwmtLwNQ586yD7zGJVwVTp7uqi8JKqPltGIMKxadn6Y=; b=maoZ57IV4RQb7qoU qdpyNeeDy1qCgLpsPf9y7Xvf1W4T50t46EqehcPq8aFczaddZQxtvwlDNvXNYScz S5QP8Pz2hp1VH4oPBIWIdl0oqc4vtPWSDJMvqx+Qvxsvcku43K/c2ScR64IjScW+ piO7ERCBBuqJ6BisPkCNoCW42eOaATGB6gFCG0DdBp763iNDPsVhiXkztF0mane8 QzSNumd2/8RUBbFU7GkPL4/mz+mLtkUy45aUcJye767NH8ZM30+xconobH9PXbjr XZ0bNCxkOmHfUtp3I8tiPNsQvYiMbo51bpbidHEOjvkHFDqIQHCJMqkgk4VdReH6 uPuPeA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781156006; x=1781760806; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DwmtLwNQ586yD7zGJVwVTp7uqi8JKqPltGIMKxadn6Y=; b=REIOKPutPpKOjc/I9wt4lcik81IHJuNYT3KN78Qy8rZ1TR9lSPJam77YkBv2IJN4EB Rd7W8VCGgnGt/OkAyUD+D6MKOX6TuvUeecbU2KcUrDZkm6AUF2Rpqixn0eYaHqHxP+1t ZZ2AqN0FGDcxW4Q79LJgHItOAMisGBHEnDDXUofKsPKitkD5liqkvSBIWGAYOCMDwf0+ AKknRKiRiX+CFSz4XM32nIV6NkWBvyH2lwPtWVnDKqLnANa+MDRHD3ESMVYj0YTTOhuv fJ8AmlFCPf5Ykh9cqyThJQWblnegSSq66igZXYo8IFOSXHNA/0UPIaMUGUS3moib9t0p cibQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781156006; x=1781760806; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=DwmtLwNQ586yD7zGJVwVTp7uqi8JKqPltGIMKxadn6Y=; b=qP5Zhspywuc72xYNAKXtrJadwM4Ku/eXBPecTNRMAIcNcl4zDW3snlSmfcE2DxgatF w6zSa9iXd8BhZ2bZYVMgaUWWHwlG04bKRoC8cLenYe6ZKetdLx8qTmg2xK9Y8KAQKo8V NI6SFeOxE+8AQeieQocRjXKfatsTBrgSC5QJIUe6CgUrHQl57iuLrmL9szSdND1nSITR azwePfAlqRjkEdSBmsCDjjRBvV8gwF6S42rZOO3jytxpH4M/EPs0xo24Moncq9y8L+rx Qsj2Owi4CXLuYksSrq1zlDEIYix4mcGTgB57Vp0zZhcSyHUXsYn+d5gKVOoreDIBHNKp h+GA== X-Gm-Message-State: AOJu0YxIMIfpO5yC/PHfZFyHw/03FauyLFUp63UXU2uE7EAHnMVgF2Wo hhm+xMdViO6RQ+9/0LhUq5n2kZFxVIA3C5GQCjCgeTRLHeTYzCUbJFt7yQrEaJ7NLXtoBzVDWhD QweGI3J2iWW5helcDvdHvrdgrL+l9e8O5YNJz8rrtWum7d+fOFRfc/XyrNhXLMYjWAg== X-Gm-Gg: Acq92OGwXVCSTmUrbYdclCM3o3W0WVS0+CySy2XXRTBsZkI9X0aKm1FRtPkQMtzBzbb sIZS3zPRHVXcsSnkD4QxH+HETp8Zqx7Aws9GSpx2M6wjbnTxyWJnOeRaqTyh9oGBglzPYo/rsdZ 4RtZquMlRrefZRuxxVha4bvGpFcsao7poRKcagD12B+oM3EOZsjUOyfDArLg+RgXonSMgsi5L5a //ZBYwrYoefG7WJI0TETW1XTYEDzWlqPyaQ2GVM1PZ4bhAuBGF2FtzF3EYs38/dxtLbwiAYsAH9 H/e+Bs7zvS1QUE6ikKMnF3NVyFLqgbBMUuzdJ9oGtYoE9HMQME4gbGm1K/6eda5dvDR5JNSMJLQ JtgEWugN4Sjt0AuirSp5f+C/DiEuABE+rr0nWePGMgEgiOBUV7Vng3vJd+8BqLSFCUk2Kix8MYZ u7bIvx X-Received: by 2002:a05:7300:7493:b0:304:fa0d:85ba with SMTP id 5a478bee46e88-30804789220mr1180689eec.12.1781156005581; Wed, 10 Jun 2026 22:33:25 -0700 (PDT) X-Received: by 2002:a05:7300:7493:b0:304:fa0d:85ba with SMTP id 5a478bee46e88-30804789220mr1180664eec.12.1781156005111; Wed, 10 Jun 2026 22:33:25 -0700 (PDT) From: Brian Cain To: qemu-devel@nongnu.org Cc: brian.cain@oss.qualcomm.com, matheus.bernardino@oss.qualcomm.com, pierrick.bouvier@oss.qualcomm.com, ltaylorsimpson@gmail.com, philmd@mailo.org, philmd@oss.qualcomm.com, Brian Cain Subject: [PATCH v6] target/hexagon: Add pkt_ends_tb to translation Date: Wed, 10 Jun 2026 22:32:41 -0700 Message-Id: <20260611053249.3918491-21-brian.cain@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260611053249.3918491-1-brian.cain@oss.qualcomm.com> References: <20260611053249.3918491-1-brian.cain@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: wCkcjBapoFYU_PMziEU1hN95fomhN1_u X-Proofpoint-Spam-Info: AW1haW4tMjYwNjExMDA1MiBTYWx0ZWRfX7JaFRgVoCyqP APqOmpIQM02AZU+KwhyYBqMqDOKQej43tbEYhbV4D6ml2esEsjonddX4eIXDCl7tkn957Bgpbp7 30XR+7ENZab+Mgov8EtvjclKQcCczmU= X-Proofpoint-GUID: wCkcjBapoFYU_PMziEU1hN95fomhN1_u X-Authority-Analysis: v=2.4 cv=UsRT8ewB c=1 sm=1 tr=0 ts=6a2a48a6 cx=c_pps a=PfFC4Oe2JQzmKTvty2cRDw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=COk6AnOGAAAA:8 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=PUAfe4L2FItr89aHCx8A:9 a=QEXdDO2ut3YA:10 a=6Ab_bkdmUrQuMsNx7PHu:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjExMDA1MiBTYWx0ZWRfX0JLFuAxIzICu 2408yn8Wp5RY5pkMg0yOMtIYcYbohrBiAXl+F7FNLtk+PoDQZRpsrXyciWU27MmXMFTWa8NWk9a 3d4HOGIJwMF4GzbEaf3aefljsy6EgNRlh7pojS83wKl5WwIDvTCsvb7SK6nGr6cSHiZoItsZBmE lAuGEPMbCycKel42tEndLC25a3msg7KA02yt4Ktk+SxNRPJIBfq0UjrE8c1QX1kBDjGkQDhFfrv ZHXVkUHEgDWa2BnSw/fydQhYsfwK244PPHRUnGz046VCJiXOujLcLI9yek2FMdXi28KCjuRd+rP uFGE6xFjb1l54P/TAqnZXZ/w4+AmKTJuExtcSqV2tBRtUZnewy+EA1s94n3MH5OW4spXrc2xofs xKisSQ/x/knH3zCtpbYP3OGlClrPYIPsGVuhbApbTZ0VsozSdmldAAbKU2r3ZyeKMIwlGlZmlRW ysvbYuiJpZQzUc5ACcA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-11_01,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 clxscore=1015 lowpriorityscore=0 spamscore=0 adultscore=0 bulkscore=0 suspectscore=0 impostorscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606110052 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=brian.cain@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1781156321141158500 From: Brian Cain Reviewed-by: Taylor Simpson Signed-off-by: Brian Cain --- target/hexagon/translate.h | 1 - target/hexagon/translate.c | 102 ++++++++++++++++++++++++++++++++++++- 2 files changed, 100 insertions(+), 3 deletions(-) diff --git a/target/hexagon/translate.h b/target/hexagon/translate.h index f79bdedd7b6..fea88cb2db7 100644 --- a/target/hexagon/translate.h +++ b/target/hexagon/translate.h @@ -86,7 +86,6 @@ typedef struct DisasContext { TCGv branch_taken; TCGv dczero_addr; bool pcycle_enabled; - bool pkt_ends_tb; uint32_t num_cycles; } DisasContext; =20 diff --git a/target/hexagon/translate.c b/target/hexagon/translate.c index ce5bbe92d5d..35e90362880 100644 --- a/target/hexagon/translate.c +++ b/target/hexagon/translate.c @@ -270,6 +270,16 @@ static bool check_for_attrib(Packet *pkt, int attrib) return false; } =20 +static bool check_for_opcode(Packet *pkt, uint16_t opcode) +{ + for (int i =3D 0; i < pkt->num_insns; i++) { + if (pkt->insn[i].opcode =3D=3D opcode) { + return true; + } + } + return false; +} + static bool need_slot_cancelled(Packet *pkt) { /* We only need slot_cancelled for conditional store instructions */ @@ -283,6 +293,90 @@ static bool need_slot_cancelled(Packet *pkt) return false; } =20 +#ifndef CONFIG_USER_ONLY +static bool sreg_write_ends_tb(int reg_num) +{ + return reg_num =3D=3D HEX_SREG_SSR || + reg_num =3D=3D HEX_SREG_STID || + reg_num =3D=3D HEX_SREG_IMASK || + reg_num =3D=3D HEX_SREG_IPENDAD || + reg_num =3D=3D HEX_SREG_BESTWAIT || + reg_num =3D=3D HEX_SREG_SCHEDCFG; +} + +static bool has_sreg_write_ends_tb(Packet const *pkt) +{ + for (int i =3D 0; i < pkt->num_insns; i++) { + Insn const *insn =3D &pkt->insn[i]; + uint16_t opcode =3D insn->opcode; + if (opcode =3D=3D Y2_tfrsrcr) { + /* Write to a single sreg */ + int reg_num =3D insn->regno[0]; + if (sreg_write_ends_tb(reg_num)) { + return true; + } + } else if (opcode =3D=3D Y4_tfrspcp) { + /* Write to a sreg pair */ + int reg_num =3D insn->regno[0]; + if (sreg_write_ends_tb(reg_num)) { + return true; + } + if (sreg_write_ends_tb(reg_num + 1)) { + return true; + } + } + } + return false; +} +#endif + +static bool pkt_ends_tb(Packet *pkt) +{ + if (pkt->pkt_has_cof) { + return true; + } +#ifndef CONFIG_USER_ONLY + /* System mode instructions that end TLB */ + if (check_for_opcode(pkt, Y2_swi) || + check_for_opcode(pkt, Y2_cswi) || + check_for_opcode(pkt, Y2_ciad) || + check_for_opcode(pkt, Y4_siad) || + check_for_opcode(pkt, Y2_wait) || + check_for_opcode(pkt, Y2_resume) || + check_for_opcode(pkt, Y2_iassignw) || + check_for_opcode(pkt, Y2_setimask) || + check_for_opcode(pkt, Y4_nmi) || + check_for_opcode(pkt, Y2_setprio) || + check_for_opcode(pkt, Y2_start) || + check_for_opcode(pkt, Y2_stop) || + check_for_opcode(pkt, Y2_k0lock) || + check_for_opcode(pkt, Y2_k0unlock) || + check_for_opcode(pkt, Y2_tlblock) || + check_for_opcode(pkt, Y2_tlbunlock) || + check_for_opcode(pkt, Y2_break) || + check_for_opcode(pkt, Y2_isync) || + check_for_opcode(pkt, Y2_syncht) || + check_for_opcode(pkt, Y2_tlbp) || + check_for_opcode(pkt, Y2_tlbw) || + check_for_opcode(pkt, Y5_ctlbw) || + check_for_opcode(pkt, Y5_tlbasidi)) { + return true; + } + + /* + * Check for sreg writes that would end the TB + */ + if (check_for_attrib(pkt, A_IMPLICIT_WRITES_SSR)) { + return true; + } + if (has_sreg_write_ends_tb(pkt)) { + return true; + } +#endif + return false; +} + + static bool need_next_PC(DisasContext *ctx) { /* Check for conditional control flow or HW loop end */ @@ -439,7 +533,11 @@ static void analyze_packet(DisasContext *ctx) =20 static void gen_start_packet(DisasContext *ctx) { - target_ulong next_PC =3D ctx->base.pc_next + ctx->pkt.encod_pkt_size_i= n_bytes; + Packet *pkt =3D &ctx->pkt; + target_ulong next_PC =3D (check_for_opcode(pkt, Y2_k0lock) || + check_for_opcode(pkt, Y2_tlblock)) ? + ctx->base.pc_next : + ctx->base.pc_next + pkt->encod_pkt_size_in_= bytes; int i; =20 /* Clear out the disassembly context */ @@ -944,7 +1042,7 @@ static void gen_commit_packet(DisasContext *ctx) ctx->pkt.vhist_insn->generate(ctx); } =20 - if (ctx->pkt.pkt_has_cof) { + if (pkt_ends_tb(&ctx->pkt) || ctx->base.is_jmp =3D=3D DISAS_NORETURN) { gen_end_tb(ctx); } } --=20 2.34.1