From nobody Sun Jul 26 14:10:34 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1781156291; cv=none; d=zohomail.com; s=zohoarc; b=E7uVZAafW3+9ubl+1fLo1r2kyhBYL7tdrB1wnCXZc9E+7ZjRy7ff1x/O8vVzg1OUqvPuUpD46ZEm2cSk8+z1WabVtzXY6nNYIcG1zmuGcqgzsZXRYcVFbCrWzVmFCiR1MTJkzvYEtyr2LSxAnMfoAgsxd+v60BT0xcfTaqdMSKc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1781156291; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=waH0Iwwyn2Pa7GGHPmlkA8IiRkDvXv+r0yvZ5t0BDME=; b=dKjWztV+sam8hbLu8SHFp/6XZIaEyFypqrBT/Ex3qU7DvbPOA+8/AVyIOHNEpHmh4wa+/TFHVu9HxbKj/uWzKRNL1gRUD7knf4JIKGgvwcOj2+icMGPDBFYSaebs5MTsM8WJZFZLxoMMSe1qGENplfaG0KzD6rEGiZtn1c+SqxI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1781156291118881.8883564378176; Wed, 10 Jun 2026 22:38:11 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wXY2X-000165-Sd; Thu, 11 Jun 2026 01:33:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wXY2V-0000rD-8Z for qemu-devel@nongnu.org; Thu, 11 Jun 2026 01:33:15 -0400 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wXY2S-0002aM-Ua for qemu-devel@nongnu.org; Thu, 11 Jun 2026 01:33:14 -0400 Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65B5GQ773817138 for ; Thu, 11 Jun 2026 05:33:11 GMT Received: from mail-dy1-f200.google.com (mail-dy1-f200.google.com [74.125.82.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eqe6uss61-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 11 Jun 2026 05:33:11 +0000 (GMT) Received: by mail-dy1-f200.google.com with SMTP id 5a478bee46e88-3075fa5a407so14570293eec.1 for ; Wed, 10 Jun 2026 22:33:11 -0700 (PDT) Received: from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30806ee207asm720800eec.29.2026.06.10.22.33.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 22:33:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= waH0Iwwyn2Pa7GGHPmlkA8IiRkDvXv+r0yvZ5t0BDME=; b=C/U8+jHxHoMcW8fO 2EssPyikWt2tKqRiOdupSPkvkfZGDZs27gBseVa2hwJwl6vA0n7W6SR0/lj/N08e mqm2/wfwut1nrz4ZkaCnFCrytE3Ui2knoa/+dbFlWJ5voHvnMDF9siOBo22WHLNY uNbROXf712KO34Ynbw1HDhZXNBtt86dtVpA4e5FZ3NYgf+uYT3NCD2/gXcN4WTFx b2rsOQl9oWv7370vHHK/ySO5Eo2m7/AtRJjKU86N+huXHIH4/rLciY1pOxSwY4B5 uh6K5X2p+zwNTkv59q41flrLgndbelvN95TAMgWLM9gRc7y78tu2+n9QHn9Di1q8 0nFNEQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781155991; x=1781760791; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=waH0Iwwyn2Pa7GGHPmlkA8IiRkDvXv+r0yvZ5t0BDME=; b=Mf9GFAtWH4i9oa8dc5eLXkzDXSChB7VkTHgb+C35/GdpzdAB+OSXt4xVL9RBdwxnsO 8Z8+6e6+EfjxFV5JchZk7Vblp/k8BVmfLaNICaaqxvfCNYXoc9eM9RxNGZFYv6UDypL+ lKYGPao5DYCvx+tMukI51/8wHA8TtQkVf7gBan7q99K5B9Fmqtd386C+AfljZuRZuf/A YkysFQ20H3OJBNnm1TWLFYZf9CADr+VSWgr3br3Tj1QCNIlKfHBwNwq6bL5qewhaUZ5c 0zlkq7s60wWHvVGlXR8As4M+GTLBdcnPU3DPt1aUt40yuPymvCmb6e//2Z/m6XyPBI/Y Ls9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781155991; x=1781760791; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=waH0Iwwyn2Pa7GGHPmlkA8IiRkDvXv+r0yvZ5t0BDME=; b=QojaKz16QYBvG+klYPLTLHzxZvjE8Nwx06MP3eDZ7LzPNKrPY/UO96YuVKfDoId2TB RnrwgWPFW4neLHEby4bj13juCAD9JDGjhTh+ymQCyXf6XpFZeLAcQGd9Gcygxhm4XYEu wjwOf06lnadFI6dTJlLYchUl2T5YIPtD4n1bn0sQP/f31NcQzHF6cWv0fAVWuYhDxTLj 4BUnIXLCS3wbjQR7cd1U9uvGOQywQkuncKGgH71B57GyGk6fEPK+YnRGbeE/FVhRmd0u Ad2Zh9ROE9Ks4YHyUbi1bwhZGAI19MJH1zlOPNpzGUUndoGie4n3TOIqBPAyqH8+Xh6V 9bXA== X-Gm-Message-State: AOJu0Yxc2T4z4eUU2yi5rus26c5t/dpyKp+MRIXD1hHh7Ug+Eg52qn7A dAj5StcRXNSLgmAucCRR98avyN0oW+WJ9a3SRd/OKMzNQN6aupcU2kr3yKmYZVdX2cn/P82R788 7dfwFGV2jRuopYcGNJZLbbf9aNwJwDtkGRM4r3KBmKmUgqRw0SHFiYiH/EZgBOH3pyw== X-Gm-Gg: Acq92OGZe6cFrm8mJXSxwq3WZVHzqamAuS7w3fWPMaeYuijSSoSx6NNo/jOv4QldLvV WHaOifDLZP/Z815shVVCGFHMM7w2hyQDWh5KlrvxlSb/xqFHKxMsxaY6sqfClmR5Y2eT5qj2enV q1R1ugaTcbE6Yuc1adZZTY18rfUeTN0G/b2sb7MKXPSIIhoogHEFPgeEhdeJbFRclTTZQL0dpjm YwfT1f0kppW3IARIlZLH70oO7Nhi9vLAI+406E/5Qy8yJwulWBiGgYvTDpxZ4eUnlPwCuHJ1ZW5 KVU4lNDKo/O/3Me9LaJ3qihbrzyX9qOv8n0ADbYgxMm9QUmVSyEPiL0eYminzbLxehQsZuu5QBp QfiIQZxdai91VQ16WDkLPhmcXWJupdzidGoLThMTn+Uzr2e7zy7Dlj33xvTdbwoRUodf3fRHqmR OBr0/6 X-Received: by 2002:a05:7300:3213:b0:304:886b:b07a with SMTP id 5a478bee46e88-30804796cfamr1273060eec.14.1781155990854; Wed, 10 Jun 2026 22:33:10 -0700 (PDT) X-Received: by 2002:a05:7300:3213:b0:304:886b:b07a with SMTP id 5a478bee46e88-30804796cfamr1273024eec.14.1781155990286; Wed, 10 Jun 2026 22:33:10 -0700 (PDT) From: Brian Cain To: qemu-devel@nongnu.org Cc: brian.cain@oss.qualcomm.com, matheus.bernardino@oss.qualcomm.com, pierrick.bouvier@oss.qualcomm.com, ltaylorsimpson@gmail.com, philmd@mailo.org, philmd@oss.qualcomm.com, Alessandro Di Federico , Anton Johansson Subject: [PATCH v6] target/hexagon: Implement stack overflow exception Date: Wed, 10 Jun 2026 22:32:30 -0700 Message-Id: <20260611053249.3918491-10-brian.cain@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260611053249.3918491-1-brian.cain@oss.qualcomm.com> References: <20260611053249.3918491-1-brian.cain@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=FJ8rAeos c=1 sm=1 tr=0 ts=6a2a4897 cx=c_pps a=PfFC4Oe2JQzmKTvty2cRDw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=DTjK4E8Rq4C45BV92HcA:9 a=QEXdDO2ut3YA:10 a=6Ab_bkdmUrQuMsNx7PHu:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjExMDA1MiBTYWx0ZWRfX0tjS3PVqnM9D gMDBPXifb1P/NL51J02iEjWmREF8YhGtcV4yWOUeftj3QayoVYk8Q6K02HaB8kgrcwv56RYQUpO gd8/wCc3/YoNkBuGtb1TdJQ8Aa0ithw= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjExMDA1MiBTYWx0ZWRfX7TeXiMgc6Yax kbkrtiuYitGLY+YHFllNEP+sR0exEujtucMVGzz2FDBekzHgU33XaoUvojhUmkUajKHFVo7hHyC +eTelR1u4vpzbBxL1eTXsboB84fSuTt12DjyYZvLOuwp0dXojB+yXki3S7jgwwkd564Uzl74M1A kCDSmT64XLKST4dLY8fLo9E8T+vuaJr6RKxAwCHiBq80oOvE9vTez8rCazjWdX6PhYDRuRQhrAV nHEObpzK78bzpXKHzLGQYBZS1skkHIy9E+gQY9CWklzgknbgiwM0njIc0tiJKis3XbW9f4KrfCN n1ANIiIlbVDehZO9G5RZoWklazjh9Z1eOIPHyxk38/HCnRR/o5EQj+2y5O7WtPAIlQPsPWFLPGK VurkggYheyVGaOhxyR9uuYBgXfEgYBq306bKnMX3AIeWBDndB+geYf9XaVaajdGRPU35QiNocMr m0M4aLjJVa9NRs15hkA== X-Proofpoint-GUID: Ey7Kg-YuCAi8rDdAtGF2xGjt1oZGaf3Z X-Proofpoint-ORIG-GUID: Ey7Kg-YuCAi8rDdAtGF2xGjt1oZGaf3Z X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-11_01,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 priorityscore=1501 spamscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606110052 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.168.131; envelope-from=brian.cain@oss.qualcomm.com; helo=mx0a-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1781156293270158500 Implement the frame limit check for system emulation mode. When allocframe computes a new stack pointer below FRAMELIMIT, raise a precise exception (HEX_CAUSE_STACK_LIMIT). The check is skipped in monitor mode. Reviewed-by: Taylor Simpson Signed-off-by: Brian Cain --- target/hexagon/helper.h | 1 + target/hexagon/idef-parser/parser-helpers.h | 2 ++ target/hexagon/macros.h | 3 -- target/hexagon/sys_macros.h | 4 +++ target/hexagon/translate.h | 2 ++ target/hexagon/genptr.c | 18 +++++++---- target/hexagon/idef-parser/parser-helpers.c | 9 ++++++ target/hexagon/op_helper.c | 36 +++++++++++++++++++++ target/hexagon/idef-parser/idef-parser.y | 3 ++ 9 files changed, 68 insertions(+), 10 deletions(-) diff --git a/target/hexagon/helper.h b/target/hexagon/helper.h index 0ec3a099cb6..aa3604dbdc5 100644 --- a/target/hexagon/helper.h +++ b/target/hexagon/helper.h @@ -109,6 +109,7 @@ DEF_HELPER_2(probe_hvx_stores, void, env, int) DEF_HELPER_2(probe_pkt_scalar_hvx_stores, void, env, int) =20 #if !defined(CONFIG_USER_ONLY) +DEF_HELPER_3(raise_stack_overflow, void, env, i32, i32) DEF_HELPER_2(swi, void, env, i32) DEF_HELPER_2(cswi, void, env, i32) DEF_HELPER_2(ciad, void, env, i32) diff --git a/target/hexagon/idef-parser/parser-helpers.h b/target/hexagon/i= def-parser/parser-helpers.h index 2087d534a93..d3dfcec5690 100644 --- a/target/hexagon/idef-parser/parser-helpers.h +++ b/target/hexagon/idef-parser/parser-helpers.h @@ -295,6 +295,8 @@ void gen_cancel(Context *c, YYLTYPE *locp); =20 void gen_load_cancel(Context *c, YYLTYPE *locp); =20 +void gen_framecheck(Context *c, YYLTYPE *locp, HexValue *addr, HexValue *e= a); + void gen_load(Context *c, YYLTYPE *locp, HexValue *size, HexSignedness signedness, HexValue *ea, HexValue *dst); =20 diff --git a/target/hexagon/macros.h b/target/hexagon/macros.h index 041e68a150e..21ab8ae5bbf 100644 --- a/target/hexagon/macros.h +++ b/target/hexagon/macros.h @@ -538,9 +538,6 @@ static inline TCGv gen_read_ireg(TCGv result, TCGv val,= int shift) =20 #ifdef CONFIG_USER_ONLY #define fFRAMECHECK(ADDR, EA) do { } while (0) /* Not modelled in linux-us= er */ -#else -/* System mode not implemented yet */ -#define fFRAMECHECK(ADDR, EA) g_assert_not_reached(); #endif =20 #ifdef QEMU_GENERATE diff --git a/target/hexagon/sys_macros.h b/target/hexagon/sys_macros.h index 8b81e1ca0af..0b62deba5e9 100644 --- a/target/hexagon/sys_macros.h +++ b/target/hexagon/sys_macros.h @@ -95,6 +95,10 @@ #define fTRAP(TRAPTYPE, IMM) \ register_trap_exception(env, TRAPTYPE, IMM, PC) =20 +#ifdef QEMU_GENERATE +#define fFRAMECHECK(ADDR, EA) gen_framecheck(ctx, ADDR, EA) +#endif + #define fVIRTINSN_SPSWAP(IMM, REG) #define fVIRTINSN_GETIE(IMM, REG) { REG =3D 0xdeafbeef; } #define fVIRTINSN_SETIE(IMM, REG) diff --git a/target/hexagon/translate.h b/target/hexagon/translate.h index 208cf141e7e..f79bdedd7b6 100644 --- a/target/hexagon/translate.h +++ b/target/hexagon/translate.h @@ -341,4 +341,6 @@ FIELD(PROBE_PKT_SCALAR_HVX_STORES, S0_IS_PRED, 3, 1) FIELD(PROBE_PKT_SCALAR_HVX_STORES, S1_IS_PRED, 4, 1) FIELD(PROBE_PKT_SCALAR_HVX_STORES, MMU_IDX, 5, 2) =20 +void gen_framecheck(DisasContext *ctx, TCGv_i32 addr, TCGv_i32 ea); + #endif diff --git a/target/hexagon/genptr.c b/target/hexagon/genptr.c index ee69feae4b0..1ebc7471409 100644 --- a/target/hexagon/genptr.c +++ b/target/hexagon/genptr.c @@ -893,26 +893,30 @@ static void gen_load_frame(DisasContext *ctx, TCGv_i6= 4 frame, TCGv EA) tcg_gen_qemu_ld_i64(frame, EA, ctx->mem_idx, MO_LE | MO_UQ); } =20 -#ifndef CONFIG_HEXAGON_IDEF_PARSER /* Stack overflow check */ -static void gen_framecheck(TCGv EA, int framesize) +void gen_framecheck(DisasContext *ctx, TCGv_i32 addr, TCGv_i32 ea) { - /* Not modelled in linux-user mode */ - /* Placeholder for system mode */ #ifndef CONFIG_USER_ONLY - g_assert_not_reached(); + TCGLabel *ok =3D gen_new_label(); + tcg_gen_brcond_i32(TCG_COND_GEU, addr, hex_gpr[HEX_REG_FRAMELIMIT], ok= ); + gen_helper_raise_stack_overflow(tcg_env, + tcg_constant_i32(ctx->insn->slot), ea); + gen_set_label(ok); #endif } =20 +#ifndef CONFIG_HEXAGON_IDEF_PARSER static void gen_allocframe(DisasContext *ctx, TCGv r29, int framesize) { TCGv r30 =3D get_result_gpr(ctx, HEX_REG_FP); + TCGv_i32 new_r29 =3D tcg_temp_new_i32(); TCGv_i64 frame; tcg_gen_addi_tl(r30, r29, -8); frame =3D gen_frame_scramble(); gen_store8(tcg_env, r30, frame, ctx->insn->slot); - gen_framecheck(r30, framesize); - tcg_gen_subi_tl(r29, r30, framesize); + tcg_gen_subi_tl(new_r29, r30, framesize); + gen_framecheck(ctx, new_r29, hex_gpr[HEX_REG_PC]); + tcg_gen_mov_tl(r29, new_r29); } =20 static void gen_deallocframe(DisasContext *ctx, TCGv_i64 r31_30, TCGv r30) diff --git a/target/hexagon/idef-parser/parser-helpers.c b/target/hexagon/i= def-parser/parser-helpers.c index 70bfa64432d..b942d9ea16b 100644 --- a/target/hexagon/idef-parser/parser-helpers.c +++ b/target/hexagon/idef-parser/parser-helpers.c @@ -1731,6 +1731,15 @@ void gen_load_cancel(Context *c, YYLTYPE *locp) OUT(c, locp, "}\n"); } =20 +void gen_framecheck(Context *c, YYLTYPE *locp, HexValue *addr, HexValue *e= a) +{ + HexValue addr_m =3D rvalue_materialize(c, locp, addr); + HexValue ea_m =3D rvalue_materialize(c, locp, ea); + addr_m =3D gen_rvalue_truncate(c, locp, &addr_m); + ea_m =3D gen_rvalue_truncate(c, locp, &ea_m); + OUT(c, locp, "gen_framecheck(ctx, ", &addr_m, ", ", &ea_m, ");\n"); +} + void gen_load(Context *c, YYLTYPE *locp, HexValue *width, HexSignedness signedness, HexValue *ea, HexValue *dst) { diff --git a/target/hexagon/op_helper.c b/target/hexagon/op_helper.c index 2156977a487..611162c5322 100644 --- a/target/hexagon/op_helper.c +++ b/target/hexagon/op_helper.c @@ -1392,6 +1392,42 @@ void HELPER(vwhist128qm)(CPUHexagonState *env, int32= _t uiV) } =20 #ifndef CONFIG_USER_ONLY +void HELPER(raise_stack_overflow)(CPUHexagonState *env, uint32_t slot, + uint32_t badva) +{ + /* + * Per section 7.3.1 of the V67 Programmer's Reference, + * stack limit exception isn't raised in monitor mode. + */ + uint32_t ssr =3D env->t_sreg[HEX_SREG_SSR]; + CPUState *cs; + + if (GET_SSR_FIELD(SSR_EX, ssr) || + !GET_SSR_FIELD(SSR_UM, ssr)) { + return; + } + + cs =3D env_cpu(env); + cs->exception_index =3D HEX_EVENT_PRECISE; + env->cause_code =3D HEX_CAUSE_STACK_LIMIT; + ASSERT_DIRECT_TO_GUEST_UNSET(env, cs->exception_index); + + if (slot =3D=3D 0) { + env->t_sreg[HEX_SREG_BADVA0] =3D badva; + SET_SSR_FIELD(env, SSR_V0, 1); + SET_SSR_FIELD(env, SSR_V1, 0); + SET_SSR_FIELD(env, SSR_BVS, 0); + } else if (slot =3D=3D 1) { + env->t_sreg[HEX_SREG_BADVA1] =3D badva; + SET_SSR_FIELD(env, SSR_V0, 0); + SET_SSR_FIELD(env, SSR_V1, 1); + SET_SSR_FIELD(env, SSR_BVS, 1); + } else { + g_assert_not_reached(); + } + cpu_loop_exit_restore(cs, 0); +} + void HELPER(ciad)(CPUHexagonState *env, uint32_t mask) { g_assert_not_reached(); diff --git a/target/hexagon/idef-parser/idef-parser.y b/target/hexagon/idef= -parser/idef-parser.y index c6f17c6afa7..22070d8c3fe 100644 --- a/target/hexagon/idef-parser/idef-parser.y +++ b/target/hexagon/idef-parser/idef-parser.y @@ -404,6 +404,9 @@ control_statement : frame_check ; =20 frame_check : FCHK '(' rvalue ',' rvalue ')' ';' + { + gen_framecheck(c, &@1, &$3, &$5); + } ; =20 cancel_statement : LOAD_CANCEL --=20 2.34.1