From nobody Sun Jul 26 14:10:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=oss.qualcomm.com ARC-Seal: i=1; a=rsa-sha256; t=1781155795; cv=none; d=zohomail.com; s=zohoarc; b=AnJ6keF/dbRy1OoyICmQajfOi6QyfVH/z4t6Xy0iY0p+oqNObnzb3aZoWBgxZJgOZErlQ1hqOn6hZ+BDjTwZRcBEsfKDv9xsARLeWN2B21thZZqqXbF+HB6n6tA6Ygf0Ckd46RHKhiAugbWLPUBUGS6kK3MIGvtAqpBYB61+jc4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1781155795; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=3PJq1TG0I8TU78Tf0jGrc0eZLiVvKT6OxHA758wVFTs=; b=OcqmWr7egWs5mHD9KdV4rUboD2EGKyKm+9AellgLfc5TQ9zsC/24ZzSpjs0no/fRRDLN3X2x53A1ja3ZWEyptUsmCrn2WFQC8hAgP4VLFEWUp8SAMuGjqFUMJeOI2nQlOW3nBw95PHO9wN6UmIovkkXjP112e7iSat0TopSJoVI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1781155795231895.3420464070107; Wed, 10 Jun 2026 22:29:55 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wXXyq-0007fR-2i; Thu, 11 Jun 2026 01:29:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wXXye-0007ej-He for qemu-devel@nongnu.org; Thu, 11 Jun 2026 01:29:17 -0400 Received: from mx0b-0031df01.pphosted.com ([205.220.180.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wXXyc-0000n0-If for qemu-devel@nongnu.org; Thu, 11 Jun 2026 01:29:16 -0400 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65B5GUF73846385 for ; Thu, 11 Jun 2026 05:29:13 GMT Received: from mail-dl1-f71.google.com (mail-dl1-f71.google.com [74.125.82.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eqe6u1qyv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 11 Jun 2026 05:29:13 +0000 (GMT) Received: by mail-dl1-f71.google.com with SMTP id a92af1059eb24-1383975f18bso5899203c88.1 for ; Wed, 10 Jun 2026 22:29:13 -0700 (PDT) Received: from hu-bcain-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30806e8a402sm880475eec.17.2026.06.10.22.29.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 22:29:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3PJq1TG0I8TU78Tf0jGrc0eZLiVvKT6OxHA758wVFTs=; b=mo9ze3PEnkLvu3RD Rz5yAdtrrMEPJDrGTW+PLOzjahmntHG0w0Ia1SPib/E+r/XRuPiTk3cU7VTTBJgr 1ffOyqCsxDCiALgaJlx/8qrT+M1mRH2jCTIUH42JTSJLj+j2xQDWPJL7dVIOTsQL KPoVSrRF4UfxkuWxm8yD5XERwGcQdCF0tq1je7uWKd6Y4gLX0HSOo4CFm/nwnqbc 0XK4DxuD8+hCdJ4tRuAAYwRwdyZsxf9SwHfHBSCG4+50IqYu5giIw+Lstn0WjnRK lYJu0TVzlXmc83DgGXu7stB4Re8FxvZdmeznJh3DWn5kR5Sfuc1o6MuP4Z/Xdiza mCtymg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781155752; x=1781760552; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3PJq1TG0I8TU78Tf0jGrc0eZLiVvKT6OxHA758wVFTs=; b=Up9EKjdUSi4mlv/2hR+gpKqBUtL2zTkKEaa+6/nmUdcNt50sLDJbLM5ZMgqR2SnzHl mqXKHu0UkKhfUGbRLZ0PPZPhakRA/YD66Bo8bySgHCj47uD9OZ+/EVPS8Y/qHHBgHnCf dGIUPZbZrvMC0bRlOPUr4whwG+RdPWQv6P35umaD9R7xLsgWioeK/Gy26M4/SEFhKtV7 2SM2+qiBxY9KNC7ePWQQ5FAS+BWqKbtzg6Ls9cdvrjL1OdP4MtP64bIGeoIP04wJ1m8G FTzC8xtPw5T2rjZZXSFNDRCILk/RHU6zcshNkyyO+raFCmojpsx4ZIF2G+TFbHdod60+ UuhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781155752; x=1781760552; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3PJq1TG0I8TU78Tf0jGrc0eZLiVvKT6OxHA758wVFTs=; b=a5kejdtjJiKpUKe3Zj0c5lBYjvOKH+kzYJLjmwdaf9TZStm8PtgbQLtSm+uioeUCs7 v0t3SIZ5/Iup3sYwd2xzOkEF6EzOQsMYQ59FfRyEjy+E0nj9Spsl3YIJAip2Uge70ejy wExU+4xPwnucyZ+A/WbnF5rQgBwOBlw/3+I0lOO3MGh5W0Vv9UZl69NMGsVRhwdFaP5y SRVYFS1VIzdlB1QE+oKisQ2VzsgxEGXxppXsnagxfFoq/L0yR0nWX95xECxx4msGcEDx aCRFkRUgEh5uJ25ucXBgAv5H8yYijTynRdkqiIeelSb+/ZMSvK6rrPLoD+t7QCmK5Tif ExrQ== X-Gm-Message-State: AOJu0Yy3nMNsPVas7hv2+1wt89dMgWjMGJgcg9pFeefbHMzAavmh0KMq G6Obr4YJsTrAfFLFp3YfwAhAY5zeivzE1o9STTLQbZ6fhno7Hd2jRgYQcV8OOzeMjkc0aiJrmPb 762wUO/mViylz4T+K+XB629wWtpBTZUjMdA+Jg1kvS6GRmRt1olJjIlJZdu0z/CftLQ== X-Gm-Gg: Acq92OEJSEE2ameAxleBZQ3AaeYlXYx/XVmx1FmGcqcwT/Vzqai70w6vnzpaEJAf1Lx pUbWz2QYMJv0qZPQIY6gn+agyU17BMzgvqHtd4eGE1hYDR2yP+2mWjLU2lJYNjojwfQf4/H/GtB ZwYmJSky0/eS2CzFmqyTR0/HH6VBGnhzM3csgtHYXN5OK1+0D+U6q2ehVv4RWmNKXF317qc1tq9 a8vBXK7VWshtAM8DfUhv9tgCEN0AVFQW/xLg7JJlj1hbu5qqL43xbdMT+6qH2L2fwl/pjWSBwOD y+2lXruVIFNOO2BzrmyUdWKl95GMiWY19UIphqSFsz7RCk7kVAKUfOIpL5IF74giMCP/3e1aqB3 Bq0pqDFVxDCzaAo11/yNU9NxEGY5Y+GxXa0Kc7N4wWkTYYKVb56/ABW4JReB/LJ5Fem8SuWbbcx Hj3vwW X-Received: by 2002:a05:7300:dc0a:b0:304:18be:55a5 with SMTP id 5a478bee46e88-30804b8c24cmr1242823eec.22.1781155752155; Wed, 10 Jun 2026 22:29:12 -0700 (PDT) X-Received: by 2002:a05:7300:dc0a:b0:304:18be:55a5 with SMTP id 5a478bee46e88-30804b8c24cmr1242787eec.22.1781155751535; Wed, 10 Jun 2026 22:29:11 -0700 (PDT) From: Brian Cain To: qemu-devel@nongnu.org Cc: brian.cain@oss.qualcomm.com, matheus.bernardino@oss.qualcomm.com, pierrick.bouvier@oss.qualcomm.com, ltaylorsimpson@gmail.com, philmd@mailo.org, philmd@oss.qualcomm.com, Brian Cain Subject: [PATCH v8] target/hexagon: Handle system/guest registers in gen_analyze_funcs.py and hex_common.py Date: Wed, 10 Jun 2026 22:28:26 -0700 Message-Id: <20260611052857.3911981-6-brian.cain@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260611052857.3911981-1-brian.cain@oss.qualcomm.com> References: <20260611052857.3911981-1-brian.cain@oss.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=PZPPQChd c=1 sm=1 tr=0 ts=6a2a47a9 cx=c_pps a=JYo30EpNSr/tUYqK9jHPoA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=COk6AnOGAAAA:8 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=-IRm0M9p1sl727KxlF4A:9 a=QEXdDO2ut3YA:10 a=Fk4IpSoW4aLDllm1B1p-:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: h68Zs18Lk24x9be9b1_FTN6vOWdYiNQq X-Proofpoint-GUID: h68Zs18Lk24x9be9b1_FTN6vOWdYiNQq X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjExMDA1MCBTYWx0ZWRfXxOkFmH+5fwXZ OSDos4qwwniiOFsyXCnGIvBH87jy12Yy/m7K3uubhF4xVq4oMRY2C4afgZ+Fvgjn0jp1wxc+Pwa gyW1HMH5nrd21/VMg1zTtrtTZ/e0N1PH4pD55qQa2AwFqfSjchh2xeyBOm3T2JpEqBynKezMOC5 sDGf8w8tgqWI4hloKPW8rzCzayeqQPPfBfZB04u+T0fvgLXQN2qcdaKLBvB3PrtX/eYeEemSiJr zfDCiE+EP5OZBVhbZScdy26AOEaA9ysDFeKMmdw2y4NTZj/4/eUiHtUn2KVWuKMgUtOhHVpDWN6 EANUXM4XlwUdbH8YNDGki3fLhf6PqhUgqhIOGML9G2Nnd/nD4ITGWgikz4AatuAIvahBDyrSGgf ugOXFC7vd0WLhSLcbiiOMDkzcoGaQjJUQyKXMxaLv1GsYauE8rjfiubX9epJOjc4wipOrrUD00V cL5swQVFINLLKUfEhng== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjExMDA1MCBTYWx0ZWRfX37gxPY3rbaw/ 0JLOyFKOxO8TSQKDr1naEZnUkKQEWum17QfT21evHXln5lbnnokqmCUMngSsYJ8HptRZb7EqjML ww8mW1SvevJUzkf0+Cu5CtK8agqewDw= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-11_01,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 spamscore=0 suspectscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606040000 definitions=main-2606110050 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=205.220.180.131; envelope-from=brian.cain@oss.qualcomm.com; helo=mx0b-0031df01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @qualcomm.com) X-ZM-MESSAGEID: 1781155797136158500 From: Brian Cain Add register classes for guest (G) and system (S) registers to hex_common.py, and update gen_analyze_funcs.py to handle them. Guest and system registers can only appear once per packet (one transfer instruction each), so there is no read-after-write hazard to detect during the analyze phase. Source classes (GuestSource, GuestPairSource, SystemSource, SystemPairSource) provide a no-op analyze_read() since these register reads do not need tracking. Reviewed-by: Taylor Simpson Signed-off-by: Brian Cain --- target/hexagon/gen_analyze_funcs.py | 14 ++- target/hexagon/hex_common.py | 152 ++++++++++++++++++++++++++++ 2 files changed, 164 insertions(+), 2 deletions(-) diff --git a/target/hexagon/gen_analyze_funcs.py b/target/hexagon/gen_analy= ze_funcs.py index fdefd5b4b36..44bb22ed927 100755 --- a/target/hexagon/gen_analyze_funcs.py +++ b/target/hexagon/gen_analyze_funcs.py @@ -22,7 +22,6 @@ import string import hex_common =20 - ## ## Generate the code to analyze the instruction ## For A2_add: Rd32=3Dadd(Rs32,Rt32), { RdV=3DRsV+RtV;} @@ -42,6 +41,13 @@ def gen_analyze_func(f, tag, regs, imms): f.write(f"static void analyze_{tag}(DisasContext *ctx)\n") f.write("{\n") =20 + if hex_common.tag_ignore(tag): + f.write("}\n\n") + return + + if hex_common.is_sysemu_tag(tag): + f.write("#ifndef CONFIG_USER_ONLY\n") + f.write(" Insn *insn G_GNUC_UNUSED =3D ctx->insn;\n") if (hex_common.is_hvx_insn(tag)): if hex_common.has_hvx_helper(tag): @@ -58,7 +64,8 @@ def gen_analyze_func(f, tag, regs, imms): for regno, register in enumerate(regs): reg_type, reg_id =3D register reg =3D hex_common.get_register(tag, reg_type, reg_id) - reg.decl_reg_num(f, regno) + if reg.is_read() or reg.is_written(): + reg.decl_reg_num(f, regno) =20 ## Analyze the register reads for regno, register in enumerate(regs): @@ -78,6 +85,9 @@ def gen_analyze_func(f, tag, regs, imms): =20 f.write(" mark_implicit_writes(ctx);\n") =20 + if hex_common.is_sysemu_tag(tag): + f.write("#endif /* !CONFIG_USER_ONLY */\n") + f.write("}\n\n") =20 =20 diff --git a/target/hexagon/hex_common.py b/target/hexagon/hex_common.py index 280aef0df3f..79436ee29d7 100755 --- a/target/hexagon/hex_common.py +++ b/target/hexagon/hex_common.py @@ -33,6 +33,41 @@ overrides =3D {} # tags with helper overrides idef_parser_enabled =3D {} # tags enabled for idef-parser =20 + +def is_sysemu_tag(tag): + return bool(attribdict[tag] & {"A_PRIV", "A_GUEST"}) + + +def tag_ignore(tag): + tag_skips =3D ( + "Y6_diag", + "Y6_diag0", + "Y6_diag1", + ) + attr_skips =3D { + "A_FAKEINSN", + "A_MAPPING", + "A_CONDMAPPING", + } + return tag in tag_skips or attribdict[tag] & attr_skips + + +def get_sys_tags(): + return sorted( + tag for tag in frozenset(tags) if is_sysemu_tag(tag) + ) + + +def get_user_tags(): + return sorted( + tag for tag in frozenset(tags) if not is_sysemu_tag(tag) + ) + + +def get_all_tags(): + return get_user_tags() + get_sys_tags() + + # We should do this as a hash for performance, # but to keep order let's keep it as a list. def uniquify(seq): @@ -369,12 +404,16 @@ def helper_proto_type(self): return "s32" def helper_arg_type(self): return "int32_t" + def is_pair(self): + return False =20 class Pair(Scalar): def helper_proto_type(self): return "s64" def helper_arg_type(self): return "int64_t" + def is_pair(self): + return True =20 class Hvx: def is_scalar_reg(self): @@ -1010,6 +1049,109 @@ def analyze_write(self, f, tag, regno): ctx_log_qreg_write(ctx, {self.reg_num}, insn_has_hvx_helper); """)) =20 +class GuestRegister(Register): + pass + +class GuestDest(GuestRegister, Single, Dest): + def decl_tcg(self, f, tag, regno): + self.decl_reg_num(f, regno) + f.write(code_fmt(f"""\ + TCGv_i32 {self.reg_tcg()} =3D tcg_temp_new_i32(); + """)) + def gen_write(self, f, tag): + f.write(code_fmt(f"""\ + gen_log_greg_write(ctx, {self.reg_num}, {self.reg_tcg()}); + """)) + def analyze_write(self, f, tag, regno): + f.write(code_fmt(f"""\ + ctx_log_greg_write(ctx, {self.reg_num}); + """)) + +class GuestSource(GuestRegister, Single, OldSource): + def decl_tcg(self, f, tag, regno): + self.decl_reg_num(f, regno) + f.write(code_fmt(f"""\ + TCGv_i32 {self.reg_tcg()} =3D tcg_temp_new_i32(); + gen_read_greg({self.reg_tcg()}, {self.reg_num}); + """)) + def analyze_read(self, f, regno): + pass + +class GuestPairDest(GuestRegister, Pair, Dest): + def decl_tcg(self, f, tag, regno): + self.decl_reg_num(f, regno) + f.write(code_fmt(f"""\ + TCGv_i64 {self.reg_tcg()} =3D tcg_temp_new_i64(); + """)) + def gen_write(self, f, tag): + f.write(code_fmt(f"""\ + gen_log_greg_write_pair(ctx, {self.reg_num}, {self.reg_tcg()}); + """)) + def analyze_write(self, f, tag, regno): + f.write(code_fmt(f"""\ + ctx_log_greg_write_pair(ctx, {self.reg_num}); + """)) + +class GuestPairSource(GuestRegister, Pair, OldSource): + def decl_tcg(self, f, tag, regno): + self.decl_reg_num(f, regno) + f.write(code_fmt(f"""\ + TCGv_i64 {self.reg_tcg()} =3D tcg_temp_new_i64(); + gen_read_greg_pair({self.reg_tcg()}, {self.reg_num}); + """)) + def analyze_read(self, f, regno): + pass + +class SystemDest(Register, Single, Dest): + def decl_tcg(self, f, tag, regno): + self.decl_reg_num(f, regno) + f.write(code_fmt(f"""\ + TCGv_i32 {self.reg_tcg()} =3D tcg_temp_new_i32(); + """)) + def gen_write(self, f, tag): + f.write(code_fmt(f"""\ + gen_log_sreg_write(ctx, {self.reg_num}, {self.reg_tcg()}); + """)) + def analyze_write(self, f, tag, regno): + f.write(code_fmt(f"""\ + ctx_log_sreg_write(ctx, {self.reg_num}); + """)) + +class SystemSource(Register, Single, OldSource): + def decl_tcg(self, f, tag, regno): + self.decl_reg_num(f, regno) + f.write(code_fmt(f"""\ + TCGv_i32 {self.reg_tcg()} =3D tcg_temp_new_i32(); + gen_read_sreg({self.reg_tcg()}, {self.reg_num}); + """)) + def analyze_read(self, f, regno): + pass + +class SystemPairDest(Register, Pair, Dest): + def decl_tcg(self, f, tag, regno): + self.decl_reg_num(f, regno) + f.write(code_fmt(f"""\ + TCGv_i64 {self.reg_tcg()} =3D tcg_temp_new_i64(); + """)) + def gen_write(self, f, tag): + f.write(code_fmt(f"""\ + gen_log_sreg_write_pair(ctx, {self.reg_num}, {self.reg_tcg()}); + """)) + def analyze_write(self, f, tag, regno): + f.write(code_fmt(f"""\ + ctx_log_sreg_write_pair(ctx, {self.reg_num}); + """)) + +class SystemPairSource(Register, Pair, OldSource): + def decl_tcg(self, f, tag, regno): + self.decl_reg_num(f, regno) + f.write(code_fmt(f"""\ + TCGv_i64 {self.reg_tcg()} =3D tcg_temp_new_i64(); + gen_read_sreg_pair({self.reg_tcg()}, {self.reg_num}); + """)) + def analyze_read(self, f, regno): + pass + def init_registers(): regs =3D { GprDest("R", "d"), @@ -1056,6 +1198,16 @@ def init_registers(): QRegSource("Q", "u"), QRegSource("Q", "v"), QRegReadWrite("Q", "x"), + + # system regs + GuestDest("G", "d"), + GuestSource("G", "s"), + GuestPairDest("G", "dd"), + GuestPairSource("G", "ss"), + SystemDest("S", "d"), + SystemSource("S", "s"), + SystemPairDest("S", "dd"), + SystemPairSource("S", "ss"), } for reg in regs: registers[f"{reg.regtype}{reg.regid}"] =3D reg --=20 2.34.1