From nobody Mon Aug 24 20:41:42 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1781168848; cv=none; d=zohomail.com; s=zohoarc; b=keL4UKPKzA5LmNC4WBsyO415fqnwu6BgXAkA0dOnZhT+ilEsTtB+SwbMcJYwI5vqh/sYiWuRt9khXFwEKFpeZg8PfAxa7UFeut32QkjlwPoE4fyXgrvz+yHwQIfHOpVSdWFLpGeMi5hObpC0mYQVdiEJBzUshR5AuLrS2/0FeaM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1781168848; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=/NBCtQ/LDlj7bqt4GsZQ8DDG3CW8/CbEEUHOSI/t16A=; b=CGMjm/TR++XYXRwTTrhJfYMwp7An7fntuRh6d5NIZIhXepFOaCkoAuC5R8QHLNkTaAhnUVnADoKrZj6OUZYtmzlCZ9xz199nvSnBZ3BIMx02HfNdIDtBwwhwYWw1w1BotCso619hOd4VQyGbjS/u1V/ZM0tXsqAwwmf/T/2XPFU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1781168848893969.0465521518594; Thu, 11 Jun 2026 02:07:28 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wXbN8-0006Xw-9o; Thu, 11 Jun 2026 05:06:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wXbN3-0006UX-4q for qemu-devel@nongnu.org; Thu, 11 Jun 2026 05:06:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wXbN1-0005Oh-Nw for qemu-devel@nongnu.org; Thu, 11 Jun 2026 05:06:40 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-137-T3kvi46LN--9YJxVrARlIA-1; Thu, 11 Jun 2026 05:06:33 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A62E51955EB1; Thu, 11 Jun 2026 09:06:31 +0000 (UTC) Received: from localhost (unknown [10.44.24.21]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4899836512; Thu, 11 Jun 2026 09:06:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781168799; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/NBCtQ/LDlj7bqt4GsZQ8DDG3CW8/CbEEUHOSI/t16A=; b=Ih+7Wub3LTn2rJYVKCzTsff328zVQrxhFqtsAax/3/1Lz6gOwgA79vjo25CTSX/3xq+vtf DuVWmeG8cvo3nD4BZvbePzyLxB1SfBCn3vYTkIaX6MgcJjftLFkwekVCDy/dqFLPJBld3D XFDv0Oy7qjZqcnLSQj8xB32wN8vlIik= X-MC-Unique: T3kvi46LN--9YJxVrARlIA-1 X-Mimecast-MFC-AGG-ID: T3kvi46LN--9YJxVrARlIA_1781168791 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Thu, 11 Jun 2026 13:03:47 +0400 Subject: [PATCH v3 32/35] ui/console: register console in QOM tree dynamically MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260611-b4-ui-v3-32-72bcbbea0fae@redhat.com> References: <20260611-b4-ui-v3-0-72bcbbea0fae@redhat.com> In-Reply-To: <20260611-b4-ui-v3-0-72bcbbea0fae@redhat.com> To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Fabiano Rosas , Laurent Vivier , Alex Williamson , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Peter Maydell , Akihiko Odaki , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=2283; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=+6tAA5uwDh2I1DKjrGBRjiPVFRwcgi1oOVH5ZTlowwM=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqKnniMxt9fu9PYotD0qpTyNl0u5bcsrrtuk3sv exINchuFPSJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaip54gAKCRDa6OEJdZac 5X5TD/0ZyynYvj+CUVmcmQTJUj00XPrQVRtiPiWd817cRDhhMsWUk+cY3MLnXd0rk9VNovoIo9O F9ClMpLqHvIaKVwz5p1/kn1Pa70ydJvHz6Fyd9Qp3xa0mBVFl4sjrJYzXz21MmfL0rOEyo4kD9U UWZTO6nn5LfENCIQmqplzn1OcxI82NWGsA0yod+BaZyr9Q7f/7fdxn4VprbUIOLUqcn4TDSBqA7 HX7nbSV/W4zUxSOUNM7kvxBsfgglD/iHCM8hxdDU43ffz/xnzHsrVLkG0LJDyl2ClXa9Xa/yrGW /To1TNMvXrRQ7NHdRREYjCgfc/iekPmApRjQig8ww38p4aKeyHtgz0dxplNhfxBjok9CKdb2hw+ +Z4rmOhEo22ViS6H+MbJjtUx0HbwMQFiuZWw8VK+UEHjjZWWRlvCUjRxBsLBahhDQfyFqnpNr+z d7FjG6yRuClQoFYcYwqKJ64s6zqlggDSfSMrKSjCXbtuIJULE89SvHiH/hAeTCSt7VXQWEeYaUV 4XTOBiN3NBAnpjg/uIZmQYY3hKBFikTXA5KkpcJX6oWZyVmko+19ddYKmtJamzYIrnyLrARya+d ZUlHhj5XylODNHoU9CMefYYtVboTvGTYfnMDwJ18S8JcgBQfdNdnt5DwZhlLwfDWdnEQPAn/wHR cdAL6muSeL/kZoQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1781168850539158500 Consoles created after init_displaystate() (e.g. hotplugged display devices) were never added to the /backend/console[N] QOM tree. Extract qemu_console_add_to_qom() and call it from qemu_console_register() when the display is already initialized. Signed-off-by: Marc-Andr=C3=A9 Lureau --- ui/console.c | 23 +++++++++++++++++------ 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/ui/console.c b/ui/console.c index 975eaf15706..db9aaf85f59 100644 --- a/ui/console.c +++ b/ui/console.c @@ -68,6 +68,7 @@ struct DisplayState { uint64_t last_update; uint64_t update_interval; bool refreshing; + bool initialized; =20 QLIST_HEAD(, DisplayChangeListener) listeners; NotifierList console_notifiers; @@ -376,6 +377,13 @@ void qemu_text_console_put_string(QemuTextConsole *s, = const char *str, int len) } } =20 +static void qemu_console_add_to_qom(QemuConsole *con) +{ + g_autofree gchar *name =3D g_strdup_printf("console[%d]", con->index); + object_property_add_child(object_get_container("backend"), + name, OBJECT(con)); +} + static void qemu_console_register(QemuConsole *c) { @@ -413,6 +421,10 @@ qemu_console_register(QemuConsole *c) } } } + + if (c->ds->initialized) { + qemu_console_add_to_qom(c); + } } =20 static void @@ -1089,20 +1101,19 @@ void qemu_console_remove_notifier(Notifier *notifie= r) */ DisplayState *init_displaystate(void) { - gchar *name; + DisplayState *ds =3D get_alloc_displaystate(); QemuConsole *con; =20 QTAILQ_FOREACH(con, &consoles, next) { /* Hook up into the qom tree here (not in object_new()), once * all QemuConsoles are created and the order / numbering * doesn't change any more */ - name =3D g_strdup_printf("console[%d]", con->index); - object_property_add_child(object_get_container("backend"), - name, OBJECT(con)); - g_free(name); + qemu_console_add_to_qom(con); } =20 - return display_state; + ds->initialized =3D true; + + return ds; } =20 void qemu_graphic_console_set_hwops(QemuConsole *con, --=20 2.54.0