From nobody Mon Aug 24 05:04:57 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1781168849; cv=none; d=zohomail.com; s=zohoarc; b=gd0WZxDisLwz6/OpN6/cj6gL4JIL+FF11AL4I063ejG/L8D4zxmO0m4nSNVQ3Dn/QLQfhBWSHFz6x4HVJTdty3OO+wepXh9NKCJhnmSFxlAScRVaSdyRZiNAz5JxLG2Pz/5iiE0GNV7QJDdBc5cFCLy/3QuiSZ+pWcPYZqxDGfA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1781168849; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=L1PMzPwuEXW67aOzPq+tpb4RknWUk4HcTWyNDmnQBKs=; b=XdMZbVCEVuqxptDd3d5x/nNdk9vyjWwcicr2ZX339cvqZ7b4yyU0QQtc1gBHyJq0NimXi7u1Jt6XXGi4m0/qmKEvP6xBH91Vl3rB/nhdPFf1RQd6x3mljDwu1a2ezxBv1i6aK/zrrJ9v+Pv4iHOthgRScg69XSkVXyZnRTQpQfY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1781168849748280.11821467068; Thu, 11 Jun 2026 02:07:29 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wXbMV-00066S-85; Thu, 11 Jun 2026 05:06:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wXbMU-000651-1r for qemu-devel@nongnu.org; Thu, 11 Jun 2026 05:06:06 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wXbMS-0005EH-Iu for qemu-devel@nongnu.org; Thu, 11 Jun 2026 05:06:05 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-468-qIE0g4ZjNIKZ0iZ40iE9ug-1; Thu, 11 Jun 2026 05:06:00 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AE9C4180ACF5; Thu, 11 Jun 2026 09:05:58 +0000 (UTC) Received: from localhost (unknown [10.44.24.21]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2619D30A8; Thu, 11 Jun 2026 09:05:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781168763; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L1PMzPwuEXW67aOzPq+tpb4RknWUk4HcTWyNDmnQBKs=; b=Ww7O1SIHQrUWi5c44OVuHE7EeqqH3JYL0nPNikBqdua89iHkRMJv3F4aseelmQUIIk8klh 0Dx/PpSevg/upHlFauYV+T9269NNIdyCRZk6/1mW7rCDpWukJDsT8bUe9LBQ1p3S8+4ScV Z+m53eNUaRA/DyqNQYZtElMJ/itGM6o= X-MC-Unique: qIE0g4ZjNIKZ0iZ40iE9ug-1 X-Mimecast-MFC-AGG-ID: qIE0g4ZjNIKZ0iZ40iE9ug_1781168758 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Thu, 11 Jun 2026 13:03:41 +0400 Subject: [PATCH v3 26/35] ui/console-vc: fire ADDED/REMOVED notifications MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260611-b4-ui-v3-26-72bcbbea0fae@redhat.com> References: <20260611-b4-ui-v3-0-72bcbbea0fae@redhat.com> In-Reply-To: <20260611-b4-ui-v3-0-72bcbbea0fae@redhat.com> To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Fabiano Rosas , Laurent Vivier , Alex Williamson , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Peter Maydell , Akihiko Odaki , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1532; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=YapQn9Mbsz473V4fTJPToKR0zvzbCFqEf4qxDOs0Qtc=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqKnnhFSngo1bDyM927u/cfdEFlUh+pgnYfa52f ki2ZS/wu62JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaip54QAKCRDa6OEJdZac 5Tj0D/91jX0kbby7vaccX21/fQ1W4kVrW0XWdZnGZ0EnDx3gqw+skWlWy9O0lvHKRDYS82PhqCp 4Ly9ijSrbeiXXezCpgJVtcpz+mYj33SJD74ilBefs4tGr3e16L1Ov8JgJde9AGH+wiJVjDmphtP 3+q+hM1zu9WM9tHkAV2BM9FCJMNbUeJ6+wZIzVmPvS1AjwoRmkscyCt+J4h2j5K9FwFBdaGO2Su MIg50ozXpD9sBzf2gK4pg3E5v4Er9qb3JBY91VWhhzJ2sD8GYi232sgf/1LPMm3u5dtE9zoLr5X qjZXrmGIJkYtd5Zfeo0Ek+1VbXLz4VUoxhv54H79viq699XuaGL7jNYUPnm2b6xNJYm4mn7EU7E s/1yUSDH2S//4gXeJcCtbIKyKJbFKrJUVFEFzAVG+PUwvlwv0Rl6w/bkqR7sWmH9IrmuAi8HhIq ndDHK4U4PHf7ZlGiw419+TxorbKlxtcuxy878dIQZvpEPZpr7WmaNVDbsF5pTge0SK2dXu21Yhs JLVn06Su9GkD5dO32fGQB+1GN/FIAFwB/NzAy9Nrnw5JgFl4+fvS3wgM73dFkuH6EG3e9ge0YOG iU9Klf/c9LCMm0ghJQ5MPCeEdNCcAP4aEAygfRmgsqZBZXsHxQUV8c5O+sQBGmJUEhX4Ktrj58/ vMCKfF1lwDmmFqg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1781168850522158500 Fire CONSOLE_ADDED when the chardev is opened. Fire CONSOLE_REMOVED in char_vc_finalize() before dropping the console reference, so the console is still in a valid state when listeners handle the event. Also fixes a console object leak by adding the missing object_unref(). Signed-off-by: Marc-Andr=C3=A9 Lureau --- ui/console-vc.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/ui/console-vc.c b/ui/console-vc.c index 828e78c41ea..53d9e9d39b3 100644 --- a/ui/console-vc.c +++ b/ui/console-vc.c @@ -255,6 +255,7 @@ static bool vc_chr_open(Chardev *chr, ChardevBackend *b= ackend, Error **errp) } =20 qemu_chr_be_event(chr, CHR_EVENT_OPENED); + qemu_console_notify(QEMU_CONSOLE_ADDED, QEMU_CONSOLE(s)); return true; } =20 @@ -327,12 +328,24 @@ static void char_vc_init(Object *obj) vc->encoding =3D CHARDEV_VC_ENCODING_UTF8; } =20 +static void char_vc_finalize(Object *obj) +{ + VCChardev *vc =3D VC_CHARDEV(obj); + QemuConsole *con =3D QEMU_CONSOLE(vc->console); + + if (con) { + qemu_console_notify(QEMU_CONSOLE_REMOVED, con); + object_unref(con); + } +} + static const TypeInfo char_vc_type_info =3D { .name =3D TYPE_CHARDEV_VC, .parent =3D TYPE_CHARDEV, .instance_size =3D sizeof(VCChardev), .instance_init =3D char_vc_init, .instance_post_init =3D object_apply_compat_props, + .instance_finalize =3D char_vc_finalize, .class_init =3D char_vc_class_init, }; =20 --=20 2.54.0