From nobody Wed Aug 26 18:52:01 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1781168749; cv=none; d=zohomail.com; s=zohoarc; b=AHTLeMVabM8jD1DVZAj7T8USZgKNCwyzAEilUpU5mJpmZ30Xq17rK0kfsEJx/GingzNg/5rbYIiJ8HGyQVS1xPjGypSywCD/7tZWIbVQW5qkD5tzK0jNaSngRsJjlVzkX9KP3fp5RSWIqQD7zyVIeOf1h/nJFK8iu1YFnoM9C8Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1781168749; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=M99d8mm/rcGWFplxSkYyDHW5C0as6dK08CNz+VrRrRA=; b=ggIak+M9KfFJd9AQX3adoUFtTHosrJ0DSdKGPvOn6dWVXWs6NapWe0CtvytuDb412sh3jC5sdw0Pwh5xNfpd9nrebYBWfx65Fl7VLlIF9SgiStx4M/+wBwRHu57btLuLzhS9Wd7pGkUu4y9IWmjQw0cEvrHnKDm9wD8vSaZ374U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1781168749310601.2367993419138; Thu, 11 Jun 2026 02:05:49 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wXbM6-0004Xw-SQ; Thu, 11 Jun 2026 05:05:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wXbM3-0004Hm-T1 for qemu-devel@nongnu.org; Thu, 11 Jun 2026 05:05:39 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wXbM2-00056M-98 for qemu-devel@nongnu.org; Thu, 11 Jun 2026 05:05:39 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-591-2NPQ23S9O6Wcb_rwAlf5TA-1; Thu, 11 Jun 2026 05:05:33 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D0CAE1805C07; Thu, 11 Jun 2026 09:05:31 +0000 (UTC) Received: from localhost (unknown [10.44.24.21]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C3E8319541B2; Thu, 11 Jun 2026 09:05:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781168737; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=M99d8mm/rcGWFplxSkYyDHW5C0as6dK08CNz+VrRrRA=; b=T8xkisO+8BsxJfvEuFUTiKwnqOxJiMZIijPeaE9z6w8cNfhMZ9pNLZVtyeuTsOoyAXkIeh 1FZBH0uMg0VUqHPxCxPnHaF6IkFRsyiIel3k/RfICfMPNZoKzY9QvGaPehekbud6BQoOQZ 4soSAfykswOZcZYkJhlXxIsbTc5Fie4= X-MC-Unique: 2NPQ23S9O6Wcb_rwAlf5TA-1 X-Mimecast-MFC-AGG-ID: 2NPQ23S9O6Wcb_rwAlf5TA_1781168731 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Thu, 11 Jun 2026 13:03:36 +0400 Subject: [PATCH v3 21/35] ui/cocoa: implement display cleanup MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260611-b4-ui-v3-21-72bcbbea0fae@redhat.com> References: <20260611-b4-ui-v3-0-72bcbbea0fae@redhat.com> In-Reply-To: <20260611-b4-ui-v3-0-72bcbbea0fae@redhat.com> To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Fabiano Rosas , Laurent Vivier , Alex Williamson , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Peter Maydell , Akihiko Odaki , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1474; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=d2sDlDsgKSJ2TB76kf45Z764VuTYl2D5ias8y7XNs1o=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqKnngfInRmsGBHdnUkfYGRbSq6aI2MIQ6EAliV oLZElE3R3iJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaip54AAKCRDa6OEJdZac 5SWrEACjdEqMP6hdVOZZgA7nV+Sog40j1r0LJHlYDhJ6f0Ae7npXDOTOLZhe6kOUZKiBD++TC8t pFa4w8TOEkT+Nm+Fsl38tx6hd0ERiqCh1gGhcA2ZfXhs3XzLk2imctT5yV1hN1iH2xvxRvwCv6+ a9kiOwuG47F4znEyC8nrBVC33f09QMHwzMhCN1dTV2IbSFvmWVmfd6uc4E803oXyS0rKgzN2v/V xG2+O63e3guE2Rb5O7Rtus1p4eo20usMPDdKKFMKvj6/GU07AhN2sxWcVOpV7R3mq+Rur8WNvip pp5Ks97cA/PsjmAZ6ARQZpOF3Vtqdq8MtGkvNaG7Pt0Am2TQsuK1OrKyZDj8Y8arIfINPxdQgyn D6v4GTtZiTdEv4jWb1C1j/xTi92rvltZtG3NgyO0LFwfAhRVv+AY0VzkefIrwhKYJ92oAZtQLAK jZuSRWpgHbvF2iUGZd1J8MExdcYqDS38KOVtPYftxHtm3Z+qeDLuO0s8IAefRHFDFvhEnNNEv6V idIBtu2X+gjeYveW5kTou9Ms6bPXTqlvycYXUQX4FS6sRa/ejVHw7Oc9j4wbA4GfwQ+CPwW5OhM OK2lgUbOuA9tPxcAmfua8sHglYh0FriaYXuiq9ZPOVNbXSu04d6kiCho5jN+pMrSdIaTYDUfLgG XCDhGFKoSAZsBaw== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1781168749886158500 Move cbowner release from QemuCocoaAppController -dealloc to cocoa_display_cleanup(), since cbowner is allocated in cocoa_display_init() and cleanup is the symmetric teardown path. Signed-off-by: Marc-Andr=C3=A9 Lureau --- ui/cocoa.m | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index c5e639ab98d..bd0c5c6ed9e 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -1331,8 +1331,6 @@ - (void) dealloc COCOA_DEBUG("QemuCocoaAppController: dealloc\n"); =20 [cocoaView release]; - [cbowner release]; - cbowner =3D nil; =20 [super dealloc]; } @@ -2163,9 +2161,26 @@ static void cocoa_display_init(DisplayState *ds, Dis= playOptions *opts) qemu_main =3D cocoa_main; } =20 +static void cocoa_display_cleanup(void) +{ + if (!kbd) { + return; + } + + qemu_console_unregister_listener(&dcl); + g_clear_pointer(&kbd, qkbd_state_free); + qemu_remove_mouse_mode_change_notifier(&mouse_mode_change_notifier); + qemu_clipboard_peer_unregister(&cbpeer); + g_clear_pointer(&cbinfo, qemu_clipboard_info_unref); + qemu_event_destroy(&cbevent); + [cbowner release]; + cbowner =3D nil; +} + static QemuDisplay qemu_display_cocoa =3D { .type =3D DISPLAY_TYPE_COCOA, .init =3D cocoa_display_init, + .cleanup =3D cocoa_display_cleanup, }; =20 static void register_cocoa(void) --=20 2.54.0