From nobody Wed Aug 26 03:00:32 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1781168847; cv=none; d=zohomail.com; s=zohoarc; b=XPMnlfuq16HR3h2JP/kqZZDs1Lgg+ElEGXbXw8Dy7ZopEoTjm+zWQF+uGaip5zXYKkLfdx3VgOvIv1vuwxUeA136HCdAyuCru6qvZoUYyduhtezM7N5yK/I0PG+/xHXJsbUVYfoioPnGX7p8Z3KTAklMc/953+bFInIjOfSPHng= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1781168847; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=0slAZr5wYvHwbne6mZ/zPGy2Lj/fJ6NfvG10inQysxA=; b=MUyOOlGPeKbXCPT4GD5jy8ns6XUft2quJUCs3dKetMQACkgtj7yb9QjJmaHTHyDNhOlWudXrmLf9sKsgnOkQbb1P/oaoMg/yiSPr9I3sD3SVZSLuIfseA4X02CUPeT1xk2oua2N1KFVNsCx3pLq3Zyv4tWrDyc7gV6g1A6nPPzs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1781168847162161.05279745147539; Thu, 11 Jun 2026 02:07:27 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wXbLp-0002xe-SD; Thu, 11 Jun 2026 05:05:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wXbLg-0002nD-5P for qemu-devel@nongnu.org; Thu, 11 Jun 2026 05:05:16 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wXbLe-0004q0-Il for qemu-devel@nongnu.org; Thu, 11 Jun 2026 05:05:15 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-643-4OFE46a2OiemkWZbqu1srw-1; Thu, 11 Jun 2026 05:05:11 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 895001955E89; Thu, 11 Jun 2026 09:05:10 +0000 (UTC) Received: from localhost (unknown [10.44.24.21]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 894361954B0E; Thu, 11 Jun 2026 09:05:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781168713; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0slAZr5wYvHwbne6mZ/zPGy2Lj/fJ6NfvG10inQysxA=; b=K5CUgyd1yyQ7M6lQZ+V7IByM6j1lWsne7IJ//6Rz091Mige0S+GlFIjNjar29IyEeSLIYM jywkH7hfxJjm9Heoh/Tc7X77rkOOxugNYkbCl0+sgwvy2QgqfkHVAV2YJ5s6a9Ij91EwGv BVguvCxddgY/eOBWAF+jX1vCIjsPGO4= X-MC-Unique: 4OFE46a2OiemkWZbqu1srw-1 X-Mimecast-MFC-AGG-ID: 4OFE46a2OiemkWZbqu1srw_1781168710 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Thu, 11 Jun 2026 13:03:32 +0400 Subject: [PATCH v3 17/35] ui/curses: implement display cleanup MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260611-b4-ui-v3-17-72bcbbea0fae@redhat.com> References: <20260611-b4-ui-v3-0-72bcbbea0fae@redhat.com> In-Reply-To: <20260611-b4-ui-v3-0-72bcbbea0fae@redhat.com> To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Fabiano Rosas , Laurent Vivier , Alex Williamson , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Peter Maydell , Akihiko Odaki , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1612; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=CrS76SW/HLMQ3iT1E5F2L0lWK5WfDn5ZaHj1Iew5FR4=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqKnnf9yoSDjrQ4SM0UOLWZ8LvR5gsDuonYelbf A2zcfDL/u6JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaip53wAKCRDa6OEJdZac 5bgKD/91LPETvwvTdWqbMIg0W2Sidt4Z1F3MzekuTuo1gerYwgrT5R9Cx8sn+XijOXnbkIDUi0l KNwuEDwXU6gmorFRo65j+qunp0sRi0q104vqAK0AmvQh9QgbYntMCW/ZNH5q8Ni6jghTBEp89FD BJ6eUGQ5q67rSiuB73jng2sFaTrTdPZ2rYZ75FaRc2R8liTcFVrf9hY4tZw09zslG+Z0K5sKzz6 aXGZTP6cCWjHsgbSxlc2GVp4EOr5hkxd/XH/GbIayLaYp1SScJkYHh8dX8CIQcbowlkOQLDjK1V ewZg8bG824dLy4MnGpKJRSt+xZBvZJpJl6jMw+IKDgV6EMf4eFhd8T6urCEHMeyS4VEW6B539Zr yYnhDXhiHmIq0asSzUGmKtPbW1vkpD26lr6+QqDo/2pYNf5M5tHLzY3UOcLFulXQqy6QnZP2CU4 5asMQx75zXQVXLWKh/luXt0g3HUu/FUAbePNpRF1vUmE2eY4mIZ+jeU8jbL+/4SM5aYRa+znjnN 5aFD/mE2/RsYlBvpy0Y6gJeNpgJpmZV9odkkM4JoGnaagrsW4CG1E1VkxaTIpm5XvGoIeLdnEml sA/RvsmolxH8ToVB90bLEuxND5zW3mc4bD3UFsGCdEkj3shORl1clbDCxgEV/cklnzJysXnGq7/ x8KoIT/ulZVMfMQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1781168848771158500 Replace the atexit() handler with a proper cleanup callback. The new curses_cleanup() unregisters the display listener, destroy & free the allocated resources. Signed-off-by: Marc-Andr=C3=A9 Lureau --- ui/curses.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/ui/curses.c b/ui/curses.c index 24d3713e57d..4db32b6168d 100644 --- a/ui/curses.c +++ b/ui/curses.c @@ -411,11 +411,19 @@ static void curses_refresh(DisplayChangeListener *dcl) } } =20 -static void curses_atexit(void) +static void curses_cleanup(void) { + if (!dcl) { + return; + } + endwin(); - g_free(vga_to_curses); - g_free(screen); + qemu_console_unregister_listener(dcl); + g_clear_pointer(&dcl, g_free); + g_clear_pointer(&screenpad, delwin); + g_clear_pointer(&vga_to_curses, g_free); + g_clear_pointer(&screen, g_free); + g_clear_pointer(&kbd_layout, kbd_layout_free); } =20 /* @@ -799,8 +807,6 @@ static void curses_display_init(DisplayState *ds, Displ= ayOptions *opts) vga_to_curses =3D g_new0(cchar_t, 256); curses_setup(); curses_keyboard_setup(); - atexit(curses_atexit); - curses_winch_init(); =20 dcl =3D g_new0(DisplayChangeListener, 1); @@ -812,6 +818,7 @@ static void curses_display_init(DisplayState *ds, Displ= ayOptions *opts) static QemuDisplay qemu_display_curses =3D { .type =3D DISPLAY_TYPE_CURSES, .init =3D curses_display_init, + .cleanup =3D curses_cleanup, }; =20 static void register_curses(void) --=20 2.54.0