From nobody Tue Aug 25 01:42:06 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1781168740; cv=none; d=zohomail.com; s=zohoarc; b=eXOYhAwiGrs1Z9xRPHh8t8kz4ueEhaJ8Rs3ItZHaxWOHi3UTE1aBlT29881+4UmYHektuDyxuLmfLtJ9Hm/2DIKVsMKkeCJo4Ge45KcX+Sd4Zhy4FuRVLvoTy5CnN/LNsvXjK79dKshOe6RCABNGu919tE5ZhkdK69B4nG3Lx7c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1781168740; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=InEIGu5JTrAOABwltf0bG4+QBVo09YgqKmwUUPjE9PM=; b=B+sIlmX5guYK7RBdoT3ejRf/j8YKqTMsCGDTiBxDemvQ8wCFst6eheS69hEzPGRqkSz61q0Hl9sl3tg/O7tAsaA57E4UDKoiuVq1L9wIOdGYGbjc+neo6cfibH8QR+l2vm1qeUQEMvSfUyFe+B5tP2lwzAVA4Pl1JgwXeS/nW6g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1781168740122782.7251512027335; Thu, 11 Jun 2026 02:05:40 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wXbLS-00027j-RF; Thu, 11 Jun 2026 05:05:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wXbLO-0001N4-D2 for qemu-devel@nongnu.org; Thu, 11 Jun 2026 05:04:58 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wXbLM-0004nQ-W6 for qemu-devel@nongnu.org; Thu, 11 Jun 2026 05:04:58 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-343-ctAovMlnOROnmx1PbDnFVw-1; Thu, 11 Jun 2026 05:04:51 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A3CE51800591; Thu, 11 Jun 2026 09:04:49 +0000 (UTC) Received: from localhost (unknown [10.44.24.21]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 95D4C1954B0D; Thu, 11 Jun 2026 09:04:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781168696; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=InEIGu5JTrAOABwltf0bG4+QBVo09YgqKmwUUPjE9PM=; b=L1hLnZJ4Y24OZHi+2P7Yzf5KwcFfLrPBopd/J/7vsf5zRrmMiqfneXdg8N7D0WwuQ5ywzN rTDn8QN5WGWnmLujxbDP5yuySShncV1NC5/zTLCEKsJmJ+dtTB+HmZ1fB6dF3wEI2IHR35 91X2223kKXfQzngeEDdZicl0Fq3vVZ4= X-MC-Unique: ctAovMlnOROnmx1PbDnFVw-1 X-Mimecast-MFC-AGG-ID: ctAovMlnOROnmx1PbDnFVw_1781168689 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Thu, 11 Jun 2026 13:03:28 +0400 Subject: [PATCH v3 13/35] ui/console: init gl_unblock_timer in qemu_console_init MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260611-b4-ui-v3-13-72bcbbea0fae@redhat.com> References: <20260611-b4-ui-v3-0-72bcbbea0fae@redhat.com> In-Reply-To: <20260611-b4-ui-v3-0-72bcbbea0fae@redhat.com> To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Fabiano Rosas , Laurent Vivier , Alex Williamson , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Peter Maydell , Akihiko Odaki , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=1375; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=75m6XwEI/jEsuPHQxTKVuXwY/0BtApgtkgSd0IkJ6dk=; b=kA0DAAoB2ujhCXWWnOUByyZiAGoqed6hHsLwGPjrZh6NjzsoCHfrT1tFWSt9mIA/FcURHYuY6 4kCMwQAAQoAHRYhBIepvZM/h8YG0nb2Ldro4Ql1lpzlBQJqKnneAAoJENro4Ql1lpzlEqgP/1Z6 DCNn1hS1hQr105u3KXotaO2IhvfoOifUi/coCho6u6wCSSNVIc++3cmDUhJN/coc13JbpOQIKMW 7gPRZV5T8U0a7T7YdOaQp6nuDSM7G2olD2kOSxTqeZntiXHsUJUlesIJv1i0cn/XcX4tA8SKeG4 hjdRQbYjnYkFloTrufJqkUdOd/FufbdbQWMxWQ3qH6IGmstvrHqWbiqEIxdLGnC9tpgYFZU2j+w rKT91p1y/y2/b/uk7jKKcfCdyrIg+E8Z1pOBolsPR7LROSl2aqeZvmhApEApqqIhxU2GpwjzX95 kKAHgkdPP1F27IyaGExFdiWrTGGnLOG+iBVz39SfX0qM93E+huZJy7GX2GOj/ZXghvyXlUTApYF v7EqQSpidZBXKBvSSKLpnPMiba3zxYNthY3qTOVq4MUOYF84XjSfMbGsM1weDFLF1Vn+VFNoFGN 85cST7ZDJW6SKD3GC+bFWoIkiZRpXaiw0MJp4CaR9vw9OvcQqeGh9G1xwjqfTkDRUJj0xt/sS8S qnbc63n7mKFhfrJgaYBJgHG6WTd6zV4UFpCPsZjKioPRvr/IPkxaZzpB+MygAX3GlVGcAFw/jlx 78XdC/sdeL/uvc81UKMX2NfACenDG4TeBDBrrpDBty6A2OI3BEwIk2cFXb4qsFy87edx8fT8iDm F5JU+ X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1781168741821158500 Move gl_unblock_timer allocation from graphic_console_init() to qemu_console_init(), similar to what was done in commit cfde05d15b ("ui/console: allocate ui_timer in QemuConsole"). This fixes leaking timers on console recycling. Fixes: a9b1e471e17 ("ui: add a gl-unblock warning timer") Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- ui/console.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/console.c b/ui/console.c index 436444723a5..58f29e82c85 100644 --- a/ui/console.c +++ b/ui/console.c @@ -433,6 +433,8 @@ qemu_console_init(Object *obj) c->window_id =3D -1; c->ui_timer =3D timer_new_ms(QEMU_CLOCK_REALTIME, dpy_set_ui_info_timer, c); + c->gl_unblock_timer =3D timer_new_ms(QEMU_CLOCK_REALTIME, + console_hw_gl_unblock_timer, c); qemu_console_register(c); } =20 @@ -1116,8 +1118,6 @@ QemuConsole *qemu_graphic_console_create(DeviceState = *dev, uint32_t head, =20 surface =3D qemu_create_placeholder_surface(width, height, noinit); qemu_console_set_surface(s, surface); - s->gl_unblock_timer =3D timer_new_ms(QEMU_CLOCK_REALTIME, - console_hw_gl_unblock_timer, s); return s; } =20 --=20 2.54.0