From nobody Thu Aug 27 02:53:56 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1781168741; cv=none; d=zohomail.com; s=zohoarc; b=iiQDrk/g3U/4AxKilluvbr9IWtoB9ljONN7jEpUXqV+fNM1IPK22XdAEdXBsC1/HCOlf5nfW2eT2pWDkK4eCBHK0QIvg1WpWWo2hnj954QUdiGJzLFkU354NscmDoUAXx6LG5RFg2wK38mKNHvjXGXDV41e5tP9MOvZ01K3OD2Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1781168741; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=NtnkDg33MYu/ghaopwN30hvH/Rt4UQH+q1oST+NTnl8=; b=liBVhio+v+qXzCTNo7zYN+QneBMApZkp7ZtO8MAEBVUkJu+M/AT77Jehar2wv7x52Q1vtkgOuJCWZO25Ags4lM2P3SO5ElTkZFQQqYLEOKsPLQQN9OLK+8KQEB3oyAmbuyAzfIGYjUCkkEV1PkFgjwBhCAuqcXAWBlEnqwF1B+E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1781168741985860.9759527179382; Thu, 11 Jun 2026 02:05:41 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wXbLQ-0001gS-HN; Thu, 11 Jun 2026 05:05:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wXbLL-0001J4-5i for qemu-devel@nongnu.org; Thu, 11 Jun 2026 05:04:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wXbLI-0004mt-Pq for qemu-devel@nongnu.org; Thu, 11 Jun 2026 05:04:54 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-618-ZSHnaKdBPim4vr927yXueA-1; Thu, 11 Jun 2026 05:04:46 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C806A18005B6; Thu, 11 Jun 2026 09:04:44 +0000 (UTC) Received: from localhost (unknown [10.44.24.21]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6EE6A1954B0E; Thu, 11 Jun 2026 09:04:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781168691; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NtnkDg33MYu/ghaopwN30hvH/Rt4UQH+q1oST+NTnl8=; b=SgQythqBwP8MmDhMU0bsHusagAEWe9fTWmMoxxLc5LNGSM0VOS5EWtMo2IRGBR5CIqDjjb kp413mYdDyrmaOP5RUmaewsSlvOLDOU0wFNbEOvv5O4Z0CL+owi0iM9+5JkLedL4mvvJqH OuJZ13VaejsGqk4LYVsgnWfJPMXAgi0= X-MC-Unique: ZSHnaKdBPim4vr927yXueA-1 X-Mimecast-MFC-AGG-ID: ZSHnaKdBPim4vr927yXueA_1781168685 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Thu, 11 Jun 2026 13:03:27 +0400 Subject: [PATCH v3 12/35] ui: stop ui timer when closing MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260611-b4-ui-v3-12-72bcbbea0fae@redhat.com> References: <20260611-b4-ui-v3-0-72bcbbea0fae@redhat.com> In-Reply-To: <20260611-b4-ui-v3-0-72bcbbea0fae@redhat.com> To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Fabiano Rosas , Laurent Vivier , Alex Williamson , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Peter Maydell , Akihiko Odaki , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=794; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=1hj0l337W3NJOgj2iQ5HiEquhGCiA0qJG1NmyVMnuVU=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqKnneJrWucxATzN3yF9uH49DNdOPb6BNfSKtYy t12Dz+GFBeJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaip53gAKCRDa6OEJdZac 5QDjD/459XSa8SSkem2tlgPK8UBNb02TRx8K5VQlG42C+4tkRnqATTRLKgn2a3/Rdy7Om+nU1ke BlIT6m6gzujaKYPZQ/7U48IzvuCwSdBkj3GZlPf/lWGiy2aIji9bYaTcCnSsgW8dFuuZ33EWGUS fXtNCTSYxGS4IzJQ5c+K1IFLAZft9zlFtgzvfJgrUB45RxhQSo358O/Gosxm8rkLv59NnWTsB+y kC6Hj2D+fv/s/eKTuRxtgZjcjA8HIB78YijN9NczdrxWu8z1xaJOROhgc55GlOEuMvxwKSC2RtY DX4as/Mqa5ktknE1jK/WtPhqBXANu19DY4de8ZxBE+W2uAqtqDjG1x8B27iiAqrahBZ+52frSFf IKrOiz56HPSLL4JpFJf5wcqvSuKiMANV8YCsd+YCbpY19vrXL9hMqKqCQhTAvyadcGHHvI9lm0+ BJk7ElAU0UnOj03BBxOOwgWp6RAVEFxjiHrVLMVtf01nE+l/TI2Q9tz2ZziO0WZqHYmXLhVBErl cN1VdJgm+iYMVQWSlM/4VDuAoiJrIocWH/ZBIeEXnZnsup9/oflAQoj4Ah/eOne5JmJ5e0BEJ+P 9hTZBCIXHS+hAOE2LSpuMdPWM8vw59qvEnzbStmQu+umBjl4sc7DMtfI1GwXw6krWF6YGN2tvbF C87x9ZlS4Pj83/Q== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1781168743823158500 hwops is reset, so if the UI timer is pending it will crash. Fixes: 9588d67e72 ("console: minimal hotplug suport") Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- ui/console.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/console.c b/ui/console.c index a7c977d0c44..436444723a5 100644 --- a/ui/console.c +++ b/ui/console.c @@ -1136,6 +1136,7 @@ void qemu_graphic_console_close(QemuConsole *con) trace_console_gfx_close(con->index); object_property_set_link(OBJECT(con), "device", NULL, &error_abort); qemu_graphic_console_set_hwops(con, &unused_ops, NULL); + timer_del(con->ui_timer); =20 if (con->gl) { qemu_console_gl_scanout_disable(con); --=20 2.54.0