From nobody Tue Aug 25 05:34:55 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1781168658; cv=none; d=zohomail.com; s=zohoarc; b=Jph4pV1WjjB9cIKs70Ds810y36cpekZUcs8wyl2BN7dqZp85Wfm9uQGARXsF+msJkOYxwePE7yVIS2YKPQyLk0MxSeaA0qk2OeDa6QmLWanrsoAwKSJuhG9lCE56zeDQI9dxwvVO5Av/v5iEXB754tmcz9PnBZriziAZjZa3oj0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1781168658; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=9dqc3xN1aXUIUrHWS9ggdBtgBTtuuRl396MsYkRuz4Q=; b=fxQ+OqoaFUdyPapvs3GlCGIWNjttDPfBs2ptAHZKPJKIpzpFMFLEYnvf0qNanpSWIK+lHrHDG67sI9DkDsz0Ane5FOtkO2LcBaCPyj91/Lmqs6UyF6hhcQbbt4AFxlLaPXp2gtDfjNYCp8cFVliJpQCyZdkFh9vt6DKPvtUOgS4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1781168658163341.34564087790454; Thu, 11 Jun 2026 02:04:18 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wXbKK-00005k-CH; Thu, 11 Jun 2026 05:03:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wXbKI-00005W-T3 for qemu-devel@nongnu.org; Thu, 11 Jun 2026 05:03:50 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wXbKH-0004On-6i for qemu-devel@nongnu.org; Thu, 11 Jun 2026 05:03:50 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-342-y52BmiBuMTy9evHdRWebFA-1; Thu, 11 Jun 2026 05:03:45 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A9501195606E; Thu, 11 Jun 2026 09:03:43 +0000 (UTC) Received: from localhost (unknown [10.44.24.21]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 69F1436512; Thu, 11 Jun 2026 09:03:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781168628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9dqc3xN1aXUIUrHWS9ggdBtgBTtuuRl396MsYkRuz4Q=; b=SNMNt25gSm4cn78WJNM/qI0gUAi20tSUGCQPE929Tr/HQVbXF+kD3273EigEkPYb2OCihC /PmrH5RbopBc8P/R8tz2e0IllFP0fAwB6xefy7FEyC1/gJuQ2LsZYkvSVx0e+WdJXLVuDg dTSUrNsorWKfILiqPxfjYc2AxdghYso= X-MC-Unique: y52BmiBuMTy9evHdRWebFA-1 X-Mimecast-MFC-AGG-ID: y52BmiBuMTy9evHdRWebFA_1781168623 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Thu, 11 Jun 2026 13:03:16 +0400 Subject: [PATCH v3 01/35] ui/gtk: fix bad widget realize on non-GFX VC MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260611-b4-ui-v3-1-72bcbbea0fae@redhat.com> References: <20260611-b4-ui-v3-0-72bcbbea0fae@redhat.com> In-Reply-To: <20260611-b4-ui-v3-0-72bcbbea0fae@redhat.com> To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Fabiano Rosas , Laurent Vivier , Alex Williamson , =?utf-8?q?C=C3=A9dric_Le_Goater?= , Peter Maydell , Akihiko Odaki , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=847; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=yZPCBoGjIn899rr3uGbGHNkKHH9rsNhzwmZ5Ol69PMI=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqKnnci7ul/cfy0Xg8nzrxRtKUGcIs45uPXIJAg Rfe/QjzpZ2JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaip53AAKCRDa6OEJdZac 5cn4D/0ZVZWkxjM55OLT5VNlvkJfkUytixWIjtvMk5ArRGgtRn8HG3zu3Ik5Dl1onSZsuYYKejA Wp1m5Qq+Azg3UrDC0LfMuu+y178uuWwAnryGGuq45dx5IikgoeSAsr5rfoIK5/gozrjafyPhYnz otbFk6IkRJ8RC3h0uqeHP53qMeUrTxqWRcXTWA2hgODtNh82s8cwalqovij0mqrWlxDIURO04bX NJ/9BPXMFvrzCRhRM7LfZHcbzWFFSZ1wArU93szjJChpeRio75kc07vVuIjm8M4eyf77/vvBeaf d1AGOKCVY1PpvB2FueO3Ucfe7Nu8r6G6NboV3EJ0k6pP9626lC6RfxP1gi9e/eYtUCGcE/T+KeH 9x0GJQu24r7MzX6LZhS2Q0q6MbQLs0efCkO+j4uSYEXbo8C74QtGVODYzxgDRKG2pbOG+TlMMX5 yKkCGT+xxnXfKJHcmUFiOPKbIKz49NLocupDAqpOEUGiTkDBeE9xYDGQQYTp6EA5e85vGitiORI fD7RXGu+KvhVvuEkxKvGAs1aMftD6QxFQo3qWVIq2dVDWwyzKwKUsBBEbDwfNL15MTHDIcjOrF4 i7qJe29tcjKNcDH0JI4xwD70aDiF2vgaQ/KhacVezhNTRKizSPNoo/stcWenhbSaP8hw5fJ0wpL j81JB7MslGIUc7w== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1781168659882158500 The GTK VirtualConsole is a union, it may be .gfx or .vte depending on the type. Fixes: 565f85a9c2 ("ui/gtk: force realization of drawing area") Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- ui/gtk.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ui/gtk.c b/ui/gtk.c index 4f706c6bbb2..2ee826b56fb 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -2585,7 +2585,9 @@ static void gtk_display_init(DisplayState *ds, Displa= yOptions *opts) if (!con) { break; } - gtk_widget_realize(s->vc[idx].gfx.drawing_area); + if (s->vc[idx].type =3D=3D GD_VC_GFX) { + gtk_widget_realize(s->vc[idx].gfx.drawing_area); + } } =20 if (opts->u.gtk.has_show_menubar && --=20 2.54.0