From nobody Sun Jul 26 14:11:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1781124276; cv=none; d=zohomail.com; s=zohoarc; b=D8Bnd2Jz5B/1m9Lw9ty4womWH0aZqR379Dy8qlCL8ItvV8EnS7p009X9E8yKunsWow3wvY/QXy7To/ulvkmC5FDIRsHjP4keDsDT5UIbgduhA+qVFzYBI4Ac3ujtwqBL67qblc7b/9+Gv+zWFGjWXn4FZz7biqDn33NPZfDMsTE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1781124276; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=hwHZ9gYg6F3c24UR8lvzGRrX0K3Wt5/wFulUFwGmu88=; b=JcUXdUdb6S1jjwOLoRsuH0aMl+j4TrHaoucguPX9bSTotJIM4NMuR8fhZ7a9HM8ETYUX5BQxD66Chtu1pPtezr6RS2OiyYS9ASPE0kiGN5HviPYPml7j3gBKKzNM8OHf6RPMvyXM0ouKqnZj+CXCtwsnxbLuDw1Y73AkVzAj2vI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1781124276185160.451508532145; Wed, 10 Jun 2026 13:44:36 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wXPlr-0005nu-Vm; Wed, 10 Jun 2026 16:43:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wXPlp-0005lW-Ka for qemu-devel@nongnu.org; Wed, 10 Jun 2026 16:43:29 -0400 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wXPln-0003lq-HA for qemu-devel@nongnu.org; Wed, 10 Jun 2026 16:43:29 -0400 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-490be29c1c5so92154985e9.2 for ; Wed, 10 Jun 2026 13:43:27 -0700 (PDT) Received: from draig.lan ([185.124.0.195]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490dc47d4e0sm92781315e9.0.2026.06.10.13.43.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 13:43:24 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 22D7A5FA2F; Wed, 10 Jun 2026 21:43:23 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1781124205; x=1781729005; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hwHZ9gYg6F3c24UR8lvzGRrX0K3Wt5/wFulUFwGmu88=; b=BNsUMKfURb/TAYuStHJC6WuukS50fbcFkd/A5bVMlaXoUIjgSbIhbzt3GutJqrj311 NvMFudtR0SiuOqTm5dLVdC7jclcHyj+ejjA4bu8t+bl+LIlB0lmcajA0Sn2EmkHSaLbN /8opj/6RyPo9bHo41EP1HrRcA8iZc+JISSaqednEw/MG4GAE4jQhQYPapHKrcBP/yua8 DqCH7Q3LTyPySJeNoF9UqFF7DB9VS4FVflMv6zWhgBfLERXzlVSxOBSSLXCWv+GplCJp maICIBZiRX8BSp3QHwZofYnvYPUMQhnIBzFNV+RRIjOENUXiHZtD8lL+M3qHyO1pHR6K lO0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781124205; x=1781729005; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=hwHZ9gYg6F3c24UR8lvzGRrX0K3Wt5/wFulUFwGmu88=; b=nZBza6J2cDbg/TkKQ84f3hefAfWnEjic17zky40FMeTXYSkpfE21bZzY3CZrJxseOO qU6onVhe6w1VvcyJL2yz8wb5FsUTJsBfEPEwlOlzoE4+eHGJIH3yMuZdnuxG19uLpi9q 8ISz/+qwUUWDohFqKzddRcP6qKc2rdRtm9wCWoiTIUjkHc0D1jqJsT93Z9lSZnj8zUD+ 3FFAO0bHLfQD8ZM2O+5o3CIpt5Xg/ZaRmqCej2hc3lTgyWLiZfsPbXelSnmEH+FlyKBN l5UwUxqgR7KLbPkjlktaG6BrR/OH/ANW8xzCl8WEUsvnhxzmkxqhtfFXJqv8FN4YQaqU yDgg== X-Gm-Message-State: AOJu0YxoiI1YwnxOTGVOpdtLpn4fIZVbTtiz5UGomAzh1Ti0vuH34NH8 8BdzTmpeKFLYLvre7g6BAnHJYlRVf1I7idZoRZoBSoEMS3np3xx0hVbyQ0a1n5+9wbQ= X-Gm-Gg: Acq92OEXrHpE3AVd2QTKngJd0pz7GGjYOwwZYHGlOMfOSMnvRj8SCSdBQN/OImpbaC2 wSPTc2+nhaDl/iRoBygTDFBqV+dCKETFKb7IhVRjaxZ5KZXovQXIOh209pTnUbXhlqrf6n7K1SS IWI2uzVCiC2fnkE+//qjo1Lzae8d7DdUE6fpqFkCE+7eQE/t5U9WBQ7c1DO5Q8NDW34U/Umm2An cNxNymqQl+wIiU440I0yk5AUqvyk+TjgR50pBRL0zcQlVd5KU1RzxkekWGSum6gd9PaAHkyfimo ekwL7LIHXIvPlNXVChaIWpltR8jVqFXTv5CV4YddGdFaPN34ev/s8eaWSb6gW8mhx5325kdpl3C FKZydqnFvGitwq64wUrxT7ukBp8KKtxljOeborRU9KffwXuQ0E32RIK7w4QBMIYqJDPE11WiJLq tK/7WEj01YnIy6JwnU7nuv17gyQfmvSxtNvQ== X-Received: by 2002:a05:600c:8486:b0:490:e196:6574 with SMTP id 5b1f17b1804b1-490e196664fmr34202005e9.13.1781124205618; Wed, 10 Jun 2026 13:43:25 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Peter Maydell , Pierrick Bouvier , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson Subject: [PATCH v2 1/6] target/arm: split evaluation of CNTHCTL timer IRQ masks Date: Wed, 10 Jun 2026 21:43:17 +0100 Message-ID: <20260610204322.828645-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260610204322.828645-1-alex.bennee@linaro.org> References: <20260610204322.828645-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1781124278931154100 Whether the physical and virtual timer IRQs are masked are independent of each other so the checking of CNTHCTL:CNTPMASK shouldn't depend of not changing CNTVMASK. While unlikely to be seen in real life we should still make sure we behave correctly. Reviewed-by: Richard Henderson Signed-off-by: Alex Benn=C3=A9e --- target/arm/helper.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index 9dd8fdfa41b..f4aae0a4072 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -1802,7 +1802,8 @@ static void gt_cnthctl_write(CPUARMState *env, const = ARMCPRegInfo *ri, =20 if ((oldval ^ value) & R_CNTHCTL_CNTVMASK_MASK) { gt_update_irq(cpu, GTIMER_VIRT); - } else if ((oldval ^ value) & R_CNTHCTL_CNTPMASK_MASK) { + } + if ((oldval ^ value) & R_CNTHCTL_CNTPMASK_MASK) { gt_update_irq(cpu, GTIMER_PHYS); } } --=20 2.47.3 From nobody Sun Jul 26 14:11:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1781124274; cv=none; d=zohomail.com; s=zohoarc; b=hmnj3vGkUNay4zxT5AYkY5M3diLDAoxZDcoaPj59OlanVWuk9LfYCT/sdg26pThzlAZ2hQ4zQhq60GkicUaI55c7/TZyRUOz0heAxCml8R5t4kEKVLzvhcFtYAP+0DkEzTfZ24wQPAkQW0LE4lKF5kmHlqXl9+wjRSvhIb+htxw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1781124274; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=BjVdjpfOdad/VHaFqOII69qjP1mCIpEc8kf1f/xpvbs=; b=SEzKwtndzaoLqldZmaxZW+Ja2qVxDa9YHe/b8SoDZmNpv3H6BxnSyJi+Cs3GWCQjQxuuC/NKeL0X2Y8HHuQCMmUpjqgWKKAIUgGQiNd3xyU1Y0AFd3ubPs3LHTDFpIZUV+yHJgxR3SqbhonnzPasQrO0Onm6Ot7AvSfV3y5qTr4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1781124274796544.7563661756922; Wed, 10 Jun 2026 13:44:34 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wXPlq-0005mv-WF; Wed, 10 Jun 2026 16:43:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wXPlp-0005kv-5j for qemu-devel@nongnu.org; Wed, 10 Jun 2026 16:43:29 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wXPlm-0003kt-UZ for qemu-devel@nongnu.org; Wed, 10 Jun 2026 16:43:28 -0400 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-490cdae130cso25792405e9.0 for ; Wed, 10 Jun 2026 13:43:26 -0700 (PDT) Received: from draig.lan ([185.124.0.195]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f2ec711sm72388472f8f.12.2026.06.10.13.43.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 13:43:24 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 370555FA43; Wed, 10 Jun 2026 21:43:23 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1781124205; x=1781729005; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BjVdjpfOdad/VHaFqOII69qjP1mCIpEc8kf1f/xpvbs=; b=fsqwzxMlTzoygIm/FxNDijG4xGiN1A+EYV4RaCWFBKolRhkjVdqU0qur5kie5fNZ8r 35JgqMYCOciPyJ0J9v1wF3utedZWs86GuTWcrx+cr5rpTrPhfG//xgrOxVoc4MwsurcQ sgQ52EcZjNYJV2tiKL0EB511s2wvjoYKSiIt46iw4txzSsoz8VzivXnWSGb8LGVyEme1 XlQeUO1tQkosewIBlXaUsjgk4YfirR4dAtHitu4wfXcUhRw3mo3WB6LUD1cKgRe1fOxD idKpCMViaQlVBoZB8OkwTmBfo5OTHMVSD6kEsJxdsprJne2gkIw0avGgnNMkhh/HrceK JeGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781124205; x=1781729005; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BjVdjpfOdad/VHaFqOII69qjP1mCIpEc8kf1f/xpvbs=; b=W1E6bRDUs5vjuC4tpaYOmzo3fR1XAGEWcl9KluH43iKoXuhFkdPZd6wKtC8yLQ0XqU AiSFoGdLx6l23YHmEvSqPtxYk4M1UZSrNYhfE7dNRa6hMxMZ4Ijgb7VePw2r3K2qebCL vM6FFRs7vu30kCr0hRx2x2sm9RSfdXXJnadCqD7GONbp96sRKl//Hvri74JsHy1IWtKY RVMVJi7yaJOr82F+pblSWk4D0UoCFXn+ebUo3tF9eyYcP5ew6VWYQmY30fkDi7DPN66g 2ANgopVUPWWx5oU2CnV/0sBsavEsug+phSPxceXKN2Yp5Jzutb9xsTdonvxJney/1xTH Kjng== X-Gm-Message-State: AOJu0Yy5MHusChrpCm0b6cB9Qqq6+oHbsVBK/vqBBZSqXxHus9mIF5CW fscuUfGMg5P7TxDx1BTj476PWbw2bhAWhJlvJ17bCYCjsV6oWnbViML7WkOAqpWIpUs= X-Gm-Gg: Acq92OFJZksqPV2Q+SKPbEOw9I3MGrzG+pPVYF8qXen6OJoy5plN7KKOKaaU49q+a8W cqaVDMRBHPbQ0nDu1StUZ5j16B3tnKK2P/s1oh+K67wY/uxwCHJqfszMDztXf4m5wZKf8tYNOyO JpVKZ4zSctLYu1wc02nCCxGbonFWzDLM7movOrugnl6a2dyetyu8CgcvVEhZg96xQW2/fX/cglA ypnFkhswNPqjaSEGlI1wq5unslUJ2Kijpkw07B6Nfhf0/ZMw1rynshx69lOTQsEK89RjUUrDAki /qzkoZTzVSsQ8sztk7nc5oPFnD11aDWGcl7UzHO0106Y879RKOn9TAD7btprIgjZItxIXNHKGET DPjxldT0LDFrDuYpGUUdysLimEYfQZER/9BVfTOPc4fys5iaW0iPSOUmPlYQVY35nO36nM3zJPF +BP+doR54XudTBpeqFiBDFU0ooxHrG9yKjduwaIPduu2EU X-Received: by 2002:a05:600c:c0d3:b0:490:b0e0:3de2 with SMTP id 5b1f17b1804b1-490c265c148mr302919585e9.33.1781124204639; Wed, 10 Jun 2026 13:43:24 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Peter Maydell , Pierrick Bouvier , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson Subject: [PATCH v2 2/6] target/arm: trigger timer recalculation when toggling CNTHCTL:ECV Date: Wed, 10 Jun 2026 21:43:18 +0100 Message-ID: <20260610204322.828645-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260610204322.828645-1-alex.bennee@linaro.org> References: <20260610204322.828645-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1781124275825158500 When toggling the state of ECV we affect the offset applied to timers. As a result we should trigger a recalculation of the timer value to take into account the new offset. Reviewed-by: Richard Henderson Signed-off-by: Alex Benn=C3=A9e --- target/arm/helper.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target/arm/helper.c b/target/arm/helper.c index f4aae0a4072..5c640853060 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -1806,6 +1806,9 @@ static void gt_cnthctl_write(CPUARMState *env, const = ARMCPRegInfo *ri, if ((oldval ^ value) & R_CNTHCTL_CNTPMASK_MASK) { gt_update_irq(cpu, GTIMER_PHYS); } + if ((oldval ^ value) & R_CNTHCTL_ECV_MASK) { + gt_recalc_timer(cpu, GTIMER_PHYS); + } } =20 static void gt_cntvoff_write(CPUARMState *env, const ARMCPRegInfo *ri, --=20 2.47.3 From nobody Sun Jul 26 14:11:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1781124276; cv=none; d=zohomail.com; s=zohoarc; b=Jztla22+uO54C5TOIHtslfAmG9sKB5dNIHIzJ/5Cml8R66zr973i+KXFtnxdAVaNbf25AK+qE+RKEnacArMK2FJN7s5cw3VPsKmSQZnso2haKkcSBMCymKgaf1a3NyoPlBd2KTDsxzfzFqN1gm+y4BGnRiocCAosizgZd4Dlf+0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1781124276; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=9tx6DudLGT4l0C9mtb2AcxwOIfor49xO4HpzRGBE3rY=; b=V6bOwrdBfNpNUNO7y2xo52/qbzovb6+xca6fZV0HchBUE1mv5mDTkMUeEheIvARPz2qHqVT4RCc+t5noRUbjxQ54z0USnOwWVlZyY6ZeIoy71Gl/3EqgxIuPzNgoIXtdeFXyGU2zVtbv2a4lFEIVgxerloyBfvSR7AG6ljzi9F0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1781124275992266.93413330170824; Wed, 10 Jun 2026 13:44:35 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wXPlr-0005n3-71; Wed, 10 Jun 2026 16:43:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wXPlq-0005lp-Ao for qemu-devel@nongnu.org; Wed, 10 Jun 2026 16:43:30 -0400 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wXPlo-0003nP-Dr for qemu-devel@nongnu.org; Wed, 10 Jun 2026 16:43:30 -0400 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-490b3e03939so2174315e9.1 for ; Wed, 10 Jun 2026 13:43:28 -0700 (PDT) Received: from draig.lan ([185.124.0.195]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490e2cb2f4fsm11056255e9.15.2026.06.10.13.43.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 13:43:24 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 4AC7A5FADF; Wed, 10 Jun 2026 21:43:23 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1781124207; x=1781729007; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9tx6DudLGT4l0C9mtb2AcxwOIfor49xO4HpzRGBE3rY=; b=SqE1HBqmn8Dm74ms9En+AbCGfG+2My/ZHbXcsqCYOpM+k9KXzKImv+NvyhqiFCQbIj n2jeTjJobQrlbpstfmDf73rc8WITkARUBss8sJsWImVNbyXd9toktktZN0+LOYLKkwNF v2HIZEE1YxUzcsxrqdANrSLfbB95dZBzaaFJyBC+vdHj+ehw1WGHWRre4cY+pxfByHaY VCeREnzE1qrJeKEx9ChNISvzCQaOgD0cxKzR0XnsTT2rmdnPRFZl6fIEyYYbXSdAYtqa XTMBLmup4CLZizEr6sn5apgSVbA+n3D6JWtx5YWAzRI8hIu5QKkJm1u6bZdnRo2Ukd1Q D7lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781124207; x=1781729007; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=9tx6DudLGT4l0C9mtb2AcxwOIfor49xO4HpzRGBE3rY=; b=NgrDnhijMtEKaIZ+7gkAUNPIuXzmHKwEeImEFe+y11NIa2pw+QIzP943BfrQd0Hlc9 Vi3au+hiVHZ0A/g1FQF6/HTl3u5suUqy4kIKl3WSqLslBs9bvnvrjExlX7OhjtDbfwJf ttI6gknU753iplomAv5TtgaOy9it078OXEuCGJTDyCl5EmL7/fkxRuq65LPE0rlPpI0r ux0Q6M80OtQ65sAl9py2Obx+x8UFwXUQGXliKXMyXxrntkgfHQ+cL8Cd4aFxhuW3MJv3 I/M3PiKXbF1dEzuVx5o4y1Mlt4uduRmXLzF0R/8nS3RpC54t0wjAK/a4Z7R9QX85CrlQ hL0A== X-Gm-Message-State: AOJu0Yyk8v/GxxcXdd8YiqO1eeTTa9GOQvLtnUKsASoeA4x8PxmDJRZb byjtBeAQNIMq99syotubOu0RPEsnXISFVZ+BR+4AuJOYX6h6kpR3+WgLgqdhksDwZokFIZTEfsF 4B+Vf X-Gm-Gg: Acq92OFi/G37HiA+kiOgLe7nDKQkqfqScKLxA8mrObhkem2EH3+M7FNHzS1lkuRZ+Co 6eYj+HCujWw7onnhzhDli4UEtFplT5qTxQ9CAJtvut5Wt7Lf12AJmZ0c4+7+Q1MyNNpi7hFLf2k tmVkJfxOKgkX2KpD5vS6/ftkh9/o8huDUAKAdB/JxmwpaQWTRv9W9H+qa6Kqrmxup1VvVt48/Yh d0TDAJKwEMX5OHuJaCFIgdFYtwuSeFXjRYBTEBnC886ZMjbW9tQwToI/CDJZHJIPiJk33WtPEma lTCWXHjp0P2spM0d7TsqbZB7EV0PcBz8kFva2igDlPOGq4C6T5AXW5b45ba3K+fwNwXdHW7nYFz zNzIpn+gnmyv76DTC3fN+7NhJ7gWDV2U80hI7yue+YvI+Bezq8p5FGXnGSK1+Tc5PV6rYVJOUMA 3B/pOLDFafJmg9wR8556W+EvyOiiYKabDBlg== X-Received: by 2002:a05:600c:1c27:b0:48f:e230:29f5 with SMTP id 5b1f17b1804b1-490e34cb3ebmr2166545e9.16.1781124206768; Wed, 10 Jun 2026 13:43:26 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Peter Maydell , Pierrick Bouvier , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson Subject: [PATCH v2 3/6] target/arm: trigger timer recalc on SCR:ECVEN change Date: Wed, 10 Jun 2026 21:43:19 +0100 Message-ID: <20260610204322.828645-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260610204322.828645-1-alex.bennee@linaro.org> References: <20260610204322.828645-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1781124277203158500 Toggling the ECVEN state affects the offset calculated in gt_phys_raw_cnt_offset so we should trigger a re-calculation on its change. Reviewed-by: Richard Henderson Signed-off-by: Alex Benn=C3=A9e --- target/arm/helper.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/target/arm/helper.c b/target/arm/helper.c index 5c640853060..22f5117ee54 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -37,6 +37,9 @@ #include "qemu/plugin.h" =20 static void switch_mode(CPUARMState *env, int mode); +#ifndef CONFIG_USER_ONLY +static void gt_recalc_timer(ARMCPU *cpu, int timeridx); +#endif =20 int compare_u64(const void *a, const void *b) { @@ -821,6 +824,12 @@ static void scr_write(CPUARMState *env, const ARMCPReg= Info *ri, uint64_t value) changed =3D env->cp15.scr_el3 ^ value; env->cp15.scr_el3 =3D value; =20 +#ifndef CONFIG_USER_ONLY + if (changed & SCR_ECVEN) { + gt_recalc_timer(cpu, GTIMER_PHYS); + } +#endif + /* * If SCR_EL3.{NS,NSE} changes, i.e. change of security state, * we must invalidate all TLBs below EL3. --=20 2.47.3 From nobody Sun Jul 26 14:11:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1781124280; cv=none; d=zohomail.com; s=zohoarc; b=VXqTHUYcmnTuVbBzVJ+Wy7GojN/mMK/fPV2I8SfGJ1EoS9RJ6YTpjEaTe4G+pFxw8fHOq84rIFPeV4XoT5Qzyc00JphS8E/oaL2zxldZ1o28wwgdgx6Quz5h/g6I1CSVsaoNmNi1tcQ0iaz/OJDs7fdNRdMz8bAFDiVNH0tSa0Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1781124280; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=O52Kn5p/ZNY8UYAGDKH5FlpPSoLk/aGgjayJR1kkiII=; b=XsoXTzQ8pOvKYx9Ng3Z/vqDYsjwscnGPdo6NTkJ4PUOObH1QoSU7Y7TiMxa95yebTzgJYym+1vijHlLPSnG2OsgnB0k0E8bC8r5Jvrzf/GwMO42JU8qwObyPauWOa6qjgcnPe9egSYqdRy7Ov+sT4IwfcMee844oFJVkltEwRs4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1781124280200539.6335504413701; Wed, 10 Jun 2026 13:44:40 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wXPls-0005ok-RJ; Wed, 10 Jun 2026 16:43:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wXPlq-0005mt-V2 for qemu-devel@nongnu.org; Wed, 10 Jun 2026 16:43:30 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wXPlp-0003oy-Aj for qemu-devel@nongnu.org; Wed, 10 Jun 2026 16:43:30 -0400 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-490b9318997so53323065e9.2 for ; Wed, 10 Jun 2026 13:43:28 -0700 (PDT) Received: from draig.lan ([185.124.0.195]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490e2cb2f4fsm11056285e9.15.2026.06.10.13.43.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 13:43:24 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 5DD7B5FBBF; Wed, 10 Jun 2026 21:43:23 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1781124207; x=1781729007; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=O52Kn5p/ZNY8UYAGDKH5FlpPSoLk/aGgjayJR1kkiII=; b=YEzLG4Wh2zW0JqXkuegyAMXvMD7qt8OzW+MReUF2WKMEg+HkCpSfAs1trwZKe4/2fe 6Y/Vb8MT4eBa7iCDhCA4DWEVShHnnVhOxHngrsGuNgSPgIX2GqZagcaW9PGhH8dmo2Mh TLZVQC0fNRoL6iVqtOEdKJUcVpBkb+zZ4tBETTzaCibU8Fe4McRC1kUIuVpHrdHaod76 vDPw37ShFfIyBUrd0pVpVxrEbniWQaOPyKKJWaIR4czI4NWNXrALjmsGgSwbTZIiMrp7 hM9YFqQM2sfiQTnMhQlDryDVzXa7UU6xM4yS+YCsi5phzBSK86EGk+cs8Wal8EEsXR0I sJ5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781124207; x=1781729007; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=O52Kn5p/ZNY8UYAGDKH5FlpPSoLk/aGgjayJR1kkiII=; b=N7SpDYnBMc4JPqxLwFkLppb8umiZcBT7iQnsORcgz1JJko0qFDCPGNVJurzBAJueDk s1vX84sBagwqzEI+LwbzsPHOpsBWKumIvLFgM06wduRKMjgHL3fn7OtV6qgrX/vU1hqd +bUAYTEt0UxZN1m56h6EaOnpG/VBjsEWAs2F8ASmsJP/zogeBZ0VuUKwaGhgOMTrdLqX TPZ4mHoObwKo/ncFs8OwHUkD7JY1aYTrzWLhH1Ej0UaNxPJKkgVA45Ldw2ydOTZqjGIS P8vBwGeuc8bUzz2Wgm/IgYE2Ncj2G9P8UX6D6FMlMAnYTyraNM2DyWAdutjgPDKxcY0r 3zbg== X-Gm-Message-State: AOJu0YwjnQOUFSf9WN3dr298bDtbZ5P4AwoHbB3wuo7usZWA5qPP9Pnp Kt3+R0Y3ALwdK7IgXpo5FcTCmSlN0zhpyCOZ85S75NdatPxqSgLu/rMcETJQ3amxyLQ= X-Gm-Gg: Acq92OGM4c4a0qVM81wSq5jQWe3u+IYpz/Gy+tWQosT0etLp+eZoQy+QzcGWp3R916u vOjmO78VPUu7kogmPAPjNLdMan8vnsRvTz5J5mN2cR0wADgP25bjTN8hXz8OK9DJMzod9TH7M7S QsFrlfqcWW4pjkG2Wd+k7P7WCs9CJLpTJeQbEZ/OLrSJkhj1f7gESwiwOz1eDt54ish3M78AhOZ K/Q4ghMLfC51pL0uPVE7cQABFZbmkhniHU0LKwJrjg+ydIWInYlkB1Np8AxpecQFseAXXXEme6+ TFZ17vntSwrW/0cro3daOthZSB/TLbumGNcy4bgAD6O9EJEo7rrnoPQ/pGMEh2VA7BnbXmLDmm0 g3hdRkIvlmR6auca0JDU20r9fGogyvFowtfkJvAIg0SfZwTcbtcWrD/agn5BDw3d+d2iKg1hH18 IN7ISq5jqI62BKpVpKvKGFl8hY4O9vD7s+5Q== X-Received: by 2002:a05:600c:8a0d:20b0:490:e1a6:45b6 with SMTP id 5b1f17b1804b1-490e1a64634mr23037255e9.20.1781124207489; Wed, 10 Jun 2026 13:43:27 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Peter Maydell , Pierrick Bouvier , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson Subject: [PATCH v2 4/6] target/arm: gate check on scr_el3 behind ARM_FEATURE_EL3 check Date: Wed, 10 Jun 2026 21:43:20 +0100 Message-ID: <20260610204322.828645-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260610204322.828645-1-alex.bennee@linaro.org> References: <20260610204322.828645-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1781124283195154100 We shouldn't be reading SCR_EL3 unless ARM_FEATURE_EL3 is enabled for this system. If it is not there cannot be any offset so just return 0. Suggested-by: Richard Henderson Signed-off-by: Alex Benn=C3=A9e --- target/arm/helper.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/target/arm/helper.c b/target/arm/helper.c index 22f5117ee54..8946d2aad28 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -1413,6 +1413,10 @@ void gt_rme_post_el_change(ARMCPU *cpu, void *ignore= d) =20 static uint64_t gt_phys_raw_cnt_offset(CPUARMState *env) { + if (!arm_feature(env, ARM_FEATURE_EL3)) { + return 0; + } + if ((env->cp15.scr_el3 & SCR_ECVEN) && FIELD_EX64(env->cp15.cnthctl_el2, CNTHCTL, ECV) && arm_is_el2_enabled(env) && --=20 2.47.3 From nobody Sun Jul 26 14:11:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1781124287; cv=none; d=zohomail.com; s=zohoarc; b=YCMi2jm2HWSqQIQ4Cg9MhZZJ+G/ChBHpuk1+XeGartINsjfVhlJ08aYky1z+pJePK9B2VdV8y+xfTggFzEwClWa6kMB10romwAyOko7OHU/Q1OCHuJP/jPdljf3rcr5Qq6YYA+Fl/zUhm68TdJKL2oJv4NuWJig+LNgMoIxUho8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1781124287; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=IygqDsQPTooVpTpsebU6T09bbtG/PeqDx7j21Taz12c=; b=O3BkH9AmHwmEwKdw4Shd3qGgY7k4a4b3VXv70Bf6nWAOFQrXIPzhrl/iP0AJbS8HckbgpzRkYM7Zdc/5peaKEcS0k9hBGYVSp2YVXcWYf5aj5rPnw69rSGJsHgMB+uLw6h7FN8uj9bgYHDF7I+O1772RK3rvQ8OhoB2IZUwFvl8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1781124287000387.78706945005297; Wed, 10 Jun 2026 13:44:47 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wXPlv-0005rB-0k; Wed, 10 Jun 2026 16:43:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wXPls-0005oB-5Q for qemu-devel@nongnu.org; Wed, 10 Jun 2026 16:43:32 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wXPlq-0003r6-KD for qemu-devel@nongnu.org; Wed, 10 Jun 2026 16:43:31 -0400 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-45ef779c1c2so4976312f8f.1 for ; Wed, 10 Jun 2026 13:43:30 -0700 (PDT) Received: from draig.lan ([185.124.0.195]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f35133csm71854577f8f.25.2026.06.10.13.43.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 13:43:27 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 733565FC8F; Wed, 10 Jun 2026 21:43:23 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1781124209; x=1781729009; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IygqDsQPTooVpTpsebU6T09bbtG/PeqDx7j21Taz12c=; b=wPGAazCUSrrgvHlUuGrhLHUKpAN50858fQKn04MZW4PHra6DHwZgEhkEpDUV5dcaaa GL0QR1KxOv3I7YQKYM1WHkx/++E7sihDMOhzFU3ut2kS50ArddK4ZkLnxzJVuJJx+OdC 27YYldY8S39udxjqR5Q6CVQMeSrDa+IPZ7w7dPECfBl8iIn/jMCI5cOWgGjUgueJWr9k ZI4dOP1sTGvEgSu0rNRMeAjBZsaPY4HC2q0jbvtaAQ+X48wZ24TfiFbFHgE76lY5byxJ 2yC9RND7Myxq/RCOx9P1zwC5z283v43SdwmTO3fqkLeXp5EHAJS81jJWl2ipdXOe5T34 R7sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781124209; x=1781729009; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=IygqDsQPTooVpTpsebU6T09bbtG/PeqDx7j21Taz12c=; b=FoVk1evIw1ct3572jzaJMypVhodbaGQXISgLJ04ZIQ8o3rHp/EZ6KOX+IJMB8cnRxr O/rVcsiQASa0RqNEJtU+KaWXUdmpR9kjRZDruzcPHMFHSBLmq2YLyx5eucEpDLbLBfSx InSGNQM9T8MQJmfRi0wn3SuCMCgttI+7HYJXzlkCivpRpiAXbMTFtL1rL2U8EPg660fn RRnhJlPAzEF2TN5A1NXejanDp4UO7ANzSWjaBwhfK/OkJd2bgeTc3xc/01COVAkx89tK yM3coZksmhEsMh+kOtsMetsr56ByIusIKGj+zz3o1i4tCn38h8Zfjrfv1VNgfqu+5yc2 wSeA== X-Gm-Message-State: AOJu0Yw1Zh9+2EZwUj6upz66bYaX9eCqNByC+HMEa2FyWI4NL/fTJvRY 38o7FGN6aAAfx1jYq54Q1/0zIiquAO/NVZMWSSSed/46+cjysVgABsFEd2lHWL0LZUYB0MKFRI1 G04Z6 X-Gm-Gg: Acq92OEvORKQZOFAuBxF66wq4uZ+1RogwXn+klAED0dgs34puX9yFXebxvzSC5N1iM/ GOruf3Sv4nbmWwB+aSBpcTQ9eTvoTqALBaVJEsoe3/J5UQuf+GXALUCw90eobodfh6XaCTBfub8 59ZpMV8b8gTVbna9bqCKXJgq4EW3M4G36jvmTz6VJm+Q/FauPvVDW956Flh/0g3DMfWvFex/fza I11qUURltmCt1FqqvO0XjcG21QUwH9Y3RwJctS6feuGR4l9oY3WEV4Rn/yH3+Wl1v/RdL77lIKp ZhV82Abq9vniE8J9Zzp3ZIsshNCzotTJjig0w+ld6tsR3g9Tfj1kdnZM5SAn0ijfcAgkOaYdtJE TWtkNXntnxxqx0iZJifWG0jHK+FQswCaA2h/OIQchqIY5hrjOEEIpJmlU0/zSB3oR1KGDaiIopk 0S4XXOXBgk7IC1ceVWSu6IKPjkhSi19+uJSw== X-Received: by 2002:a05:6000:468b:b0:43d:7868:21f0 with SMTP id ffacd0b85a97d-460304f9e96mr27272427f8f.9.1781124209029; Wed, 10 Jun 2026 13:43:29 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Peter Maydell , Pierrick Bouvier , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson Subject: [PATCH v2 5/6] target/arm: trigger timer recalc on HCR:(E2H|TGE) changes Date: Wed, 10 Jun 2026 21:43:21 +0100 Message-ID: <20260610204322.828645-6-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260610204322.828645-1-alex.bennee@linaro.org> References: <20260610204322.828645-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1781124287353158500 Toggling the HCR state affects the offset calculated in gt_phys_raw_cnt_offset so we should trigger a re-calculation on its change. Reviewed-by: Richard Henderson Signed-off-by: Alex Benn=C3=A9e --- v2 - defer calling gt_recalc_timer until after we set hcr_el2 --- target/arm/helper.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/target/arm/helper.c b/target/arm/helper.c index 8946d2aad28..f35fe83723c 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -3712,6 +3712,7 @@ static const ARMCPRegInfo v8_aa32_el1_reginfo[] =3D { static void do_hcr_write(CPUARMState *env, uint64_t value, uint64_t valid_= mask) { ARMCPU *cpu =3D env_archcpu(env); + bool hcr_change_timer; =20 if (arm_feature(env, ARM_FEATURE_V8)) { valid_mask |=3D MAKE_64BIT_MASK(0, 34); /* ARMv8.0 */ @@ -3803,6 +3804,10 @@ static void do_hcr_write(CPUARMState *env, uint64_t = value, uint64_t valid_mask) (HCR_VM | HCR_PTW | HCR_DC | HCR_DCT | HCR_FWB | HCR_NV | HCR_NV1)= ) { tlb_flush(CPU(cpu)); } + hcr_change_timer =3D (env->cp15.hcr_el2 ^ value) & + (HCR_E2H | HCR_TGE); + + /* update */ env->cp15.hcr_el2 =3D value; =20 /* @@ -3824,6 +3829,11 @@ static void do_hcr_write(CPUARMState *env, uint64_t = value, uint64_t valid_mask) arm_cpu_update_vinmi(cpu); arm_cpu_update_vfnmi(cpu); } + if (hcr_change_timer) { +#ifndef CONFIG_USER_ONLY + gt_recalc_timer(cpu, GTIMER_PHYS); +#endif + } } =20 static void hcr_write(CPUARMState *env, const ARMCPRegInfo *ri, uint64_t v= alue) --=20 2.47.3 From nobody Sun Jul 26 14:11:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1781124284; cv=none; d=zohomail.com; s=zohoarc; b=NPl7aL0Obw3QuvX9bdddWj9d1GEEWv18FFx0TNDB4D5KHHts8rQSOkzIxFoKVcOzJ5Z+ORNWpgJYiFJG8d/HvMQX4oXw3I1HoanEPXfw2xRrTn4ZhScuAkPXb6Mg/5TZPod6uG3VmjiS21A2HRpzOjTALP5J3IBmD5oPm3AkJHs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1781124284; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ngYhxDvb+8oUas7oVCWnHd5LEJw2/QGnt9A2biWJF3g=; b=ebvudgjavWBhPqR3VGGZuQ+TODbA8/m955P7krUwhkA8qix8n2DkUR/N6NprzenCVMVJxCcbv4b5ckZgENNiSvclkvkSnpKeuhgnZcLmoNHRc7InLJZpM3PPRu08yYR0pHRcEQgN5c9EVH3FHk9fC/P/IkeWOXLsYmKvfSaKQzo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1781124284764243.41911795109104; Wed, 10 Jun 2026 13:44:44 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wXPls-0005ob-DN; Wed, 10 Jun 2026 16:43:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wXPlr-0005nC-Hd for qemu-devel@nongnu.org; Wed, 10 Jun 2026 16:43:31 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wXPlq-0003qP-3V for qemu-devel@nongnu.org; Wed, 10 Jun 2026 16:43:31 -0400 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-490b8a97b11so80459245e9.0 for ; Wed, 10 Jun 2026 13:43:29 -0700 (PDT) Received: from draig.lan ([185.124.0.195]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490e2ca1a43sm10639925e9.8.2026.06.10.13.43.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2026 13:43:27 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 88F015FC9A; Wed, 10 Jun 2026 21:43:23 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1781124208; x=1781729008; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ngYhxDvb+8oUas7oVCWnHd5LEJw2/QGnt9A2biWJF3g=; b=BCgUIZPsAhup6MJ9PfEoafB0EsgBwMSEHwAEjdpmjAn6IXc/0C1/XkkdFLH0GH3O/t Ww2m1tdywSvM9WexFZJbo8evald/md7ainjdCfwdQKmb800HcQPdruDisIZLFt2gOF/G 5/ZrdKthfClWiHb46THWJemMrzR0oGdx8P4mzYKa4jsIEbDKIDvFlt48BtgByuTomV76 vGUAQ470yIPW5fSpU8BgKW6cwxhu0vPbXuo/42g7rJoo8BEFViygV54K3nxSIqNABr2/ iiTjLjBXoTNUhuhpcynQwwWBGVCNQZfVEv6xZPh7QINTWLtBlfrUT3+btsK5qmxkl+If Mifg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781124208; x=1781729008; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ngYhxDvb+8oUas7oVCWnHd5LEJw2/QGnt9A2biWJF3g=; b=pOEKmlzoSfk/8B+RtNPIVgUKjnjae5SngTAyBNeMCdnvzqcQGQktvQTMirblwoudI9 c2YmmkGgBlzh/rAN0zJjkEcbVTqXnPjAk8qiNS+TxfrEWfJDcqS3TK30fhb989YsORl9 KxOXsaAvikcHFNhVYfOmry3eOz3xBiujTF9JmDf415kYi+xPs0kMkVXBs/JrV8/sD7tk eOFFRJBAZEy59IOnq0OglXQ40Owf2/YKlLO2SvJSY521QD8dII/+HcK7YE5pQfUUDrlQ CybXo2Hg7ASntLieI1fQcAgs5TlOL4hkb57V7UKcJFBPWFUYzL70sHBD9hff8578Cr0+ EfVQ== X-Gm-Message-State: AOJu0YwflcS74Aye2ilzJ9ZUuDtlKFVPxMzwpYleiRtu3AowJrNHUTqm qHAxXNZzoLSJGHN3PuU5e+Qcv5ntYkJj39oQVgKKxPJ8JcFmnPFQ9Yz+Jm9fQoFpO04= X-Gm-Gg: Acq92OGhWbsVmBJ5llMJQ7mYitjcknuTzVcIQjEfWCZnw8lzeWnqSxtODHfCSJkCnaJ ibT3Xv+Z1nQaSsUkznG+1mQVflSTSxZGwYYOoTw0TaG3pKXgvpYgOKz23pRjepXnkN+Bl9y4GsD hLMiUz9IBicaJ1faqhRQjeUVngaBAgaRnCVbe9PwInCMaYT/GJy8T+teMUToYEJ3WX64E6y+uDt lAbSusuP7YOwHe75ngOeMSaX6YDSb3ctrQD3YrC2H5HxLcZRc/dEF0kda0HbCQ/8wETlmoeh4gS MXCwyye9EP527dhAE5O62qHhTHNjf4ItDovtBAHlT5dF44wVmFk8L3qOTw5j1jy963FhO5KVEw7 Wj6gOa3e/a4D20EjSl2eAt1Qt7s/PNpWtLRqpMmOzgwll5KiSokdgxe7goPwVCDz06obxssdCwn 72A4qmypDmWyZbT5X1wZAtXfqel5NondJdew== X-Received: by 2002:a05:600c:6995:b0:490:b473:8f78 with SMTP id 5b1f17b1804b1-490c25dd66emr421828215e9.17.1781124208335; Wed, 10 Jun 2026 13:43:28 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Peter Maydell , Pierrick Bouvier , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson Subject: [PATCH v2 6/6] docs/system: add FEAT_ECV_POFF to the emulation list Date: Wed, 10 Jun 2026 21:43:22 +0100 Message-ID: <20260610204322.828645-7-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260610204322.828645-1-alex.bennee@linaro.org> References: <20260610204322.828645-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1781124285377158500 We already had this implemented since 2808d3b38a5 (target/arm: Implement FEAT_ECV CNTPOFF_EL2 handling) but it has its own feature name now. Add it to the list. Reviewed-by: Richard Henderson Signed-off-by: Alex Benn=C3=A9e --- docs/system/arm/emulation.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst index 18c63559679..3622e3889c7 100644 --- a/docs/system/arm/emulation.rst +++ b/docs/system/arm/emulation.rst @@ -60,6 +60,7 @@ the following architecture extensions: - FEAT_E2H0 (Programming of HCR_EL2.E2H) - FEAT_EBF16 (AArch64 Extended BFloat16 instructions) - FEAT_ECV (Enhanced Counter Virtualization) +- FEAT_ECV_POFF (Enhanced Counter Virtualization Physical Offset) - FEAT_EL0 (Support for execution at EL0) - FEAT_EL1 (Support for execution at EL1) - FEAT_EL2 (Support for execution at EL2) --=20 2.47.3