From nobody Tue Jun 9 23:12:02 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1780964942; cv=none; d=zohomail.com; s=zohoarc; b=WDO1frQ2lPjXYS8f9or0GQ2zyYu8GJmVuCV2/oYw2ICU2ESSEw157QJflGJRFgHPGc5K0UV7YvIBCy/iQXPqdoxxGf5MSHn9PD+hmd15O1z2GouHuouH6NpFkOsW9ih/R3rUfFQWLFvRTodrFxcxhmStAIDKOE5D49lZM61b6BY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780964942; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=vUWzLhoNQN6qDYBOEFREVa00KlqDNxwqxrSzVXWzJg8=; b=QrIrWaxPcE31f3X//LMQllSY2BtzgCpc0j1aTtQcpAKdNxD9nVHM35zLTQagtD5uewzGR2XzCVJtXAeMtZFpWbUXXwrZtMgFq2y/1/Kam59D+5OJ5zLhP8tTZm7HPzlcCvoIDx4RICU6/+AIUlRseZpa8msby3i53wqyXsFW7AY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178096494232314.890872714729426; Mon, 8 Jun 2026 17:29:02 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wWkK9-0005in-Mi; Mon, 08 Jun 2026 20:28:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wWkK8-0005iP-9D for qemu-devel@nongnu.org; Mon, 08 Jun 2026 20:28:08 -0400 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wWkK5-0003ed-IH for qemu-devel@nongnu.org; Mon, 08 Jun 2026 20:28:08 -0400 Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-2c0c2c7d45eso44499105ad.1 for ; Mon, 08 Jun 2026 17:28:05 -0700 (PDT) Received: from stoup.. ([71.212.142.33]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c164f6d389sm188729435ad.16.2026.06.08.17.28.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2026 17:28:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1780964884; x=1781569684; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=vUWzLhoNQN6qDYBOEFREVa00KlqDNxwqxrSzVXWzJg8=; b=c33PHnHVOZOWkt14KipMhPaSnYpWLp2UxtGEAFLa6OfqLp4U9rXVb7mmdzGcHvK7Mp CDB9T4LCBs5JHzNtUsStg9HyvOQYrjRKSE4sG0XRF9+hWca3FZD13sTwkz06mGS7eykU BZDFf4yGiufoq8xw5X4TGSspbVLctH9u8T/sO/LnzGg9iquR7omACqdO0210kwmANika hHgFY8hdqfzDO7Z0jJ1pLHXLRcytBzGzkHBgzlU923bp1zRZ9seSp/cbRdVBu2yY86Ef Z/QtvTSuDWcdUu7LQHCBZFRu9iLqLuYU1/LszoGOTIay8AMI40r4I7MUoAkxxHh/F8NA AQsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780964884; x=1781569684; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vUWzLhoNQN6qDYBOEFREVa00KlqDNxwqxrSzVXWzJg8=; b=hQr/2FdNewJT8RW+93sA5yMjYrEkz9RDaVDo9wbS9qU/6Hc3is8nuW0NuM3F/pu5Yg CQevuELuOEgq9kBt24MIuJDCn9cSlGiFamT29NLio+USRHN/QaH7qEemaA6Qi/HOTIpY 1UjtW5yItCpFawl0hRU2XuU5i0Ny/AuvDx+cl9sRl53YBNikSYuSZEc684B36rZvQtdl zZV6IN96iSdf90I74kUIifS56kztzJ1L1U75mS84jsFpNm6vx5Mev69PmIvIrFc0sc0N HZASihPg0k4tna9N/Ol23l3aYigvK+ggTqYyG8QP2NOJ8p+ywVbsl0Xc040JManAwOuW FfJQ== X-Gm-Message-State: AOJu0YxTGFtmHNXFJqS4b26YIiOsq6IZFVfZu8WPvBSD4LmfVMRCVhY7 smUYluhvucRL7oZ7zwtqFyspGxnwBcYwAWRmSZE31h5Wjt8DmO6bwBdGGQjqEWHukxm7y8ue5yJ JQqaWyHo= X-Gm-Gg: Acq92OEOJb/1om1luuHtDGhNwuuJFY7Cqs0BX7y3jnJFcHYeC49tGtdbRsqPaXBAndY mqJPKkH/w/+Ff1rVPmlLmKAwKnsSBKpzk31VAUX4fr4AgwdIJV/JUaALDOS0dhDFSfqtk8RtwOh /LAgjW/F7B7u1YxNtxHUy6pKi4fTaUTuH1sMrQygsGQEE/MoghajVeIJDAXeBdGeEIPKwK+msQh hjlGPYHMB9zWn8wbf1G5qn/7ZCTA4m4Suj5RFUapebt5umovK57BsDijn3WB+RzL4BHXLjmwINd KShKJEhLhMjJCc9CDVykKtk2RON4nzyTfu/ddOXQ6YgSRusiiOT4UxG6h3nwincjeTGNKA7jeoU RDcijklPDifMNYvswgm2WXhwUC8aVrSHWzsUBmCF3WxxSAeluH4y9e3oKoKFQEwXfQqu5aJL7Dr L/6xTHOI9HDSnKqdvp8/q458BvnMR8Gty621G6YFU= X-Received: by 2002:a17:903:3805:b0:2c1:98b7:ecf3 with SMTP id d9443c01a7336-2c1e849577emr179401765ad.23.1780964883762; Mon, 08 Jun 2026 17:28:03 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, qemu-stable@nongnu.org Subject: [PATCH] target/i386: Update cc_op for SAHF Date: Mon, 8 Jun 2026 17:28:02 -0700 Message-ID: <20260609002802.729485-1-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62c; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1780964944165158500 Content-Type: text/plain; charset="utf-8" Removing the call to gen_compute_eflags meant we no longer updated cc_op after computing EFLAGS. Cc: qemu-stable@nongnu.org Fixes: da7649c6aeef ("target/i386/tcg: do not compute all flags for SAHF") Resolves: https://gitlab.com/qemu-project/qemu/-/work_items/3537 Signed-off-by: Richard Henderson --- target/i386/tcg/emit.c.inc | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/target/i386/tcg/emit.c.inc b/target/i386/tcg/emit.c.inc index ce636b6c56..59948fe64d 100644 --- a/target/i386/tcg/emit.c.inc +++ b/target/i386/tcg/emit.c.inc @@ -3768,10 +3768,13 @@ static void gen_SAHF(DisasContext *s, X86DecodedIns= n *decode) return gen_illegal_opcode(s); } tcg_gen_shri_tl(s->T0, cpu_regs[R_EAX], 8); - gen_neg_setcc(s, JCC_O << 1, cpu_cc_src); - tcg_gen_andi_tl(cpu_cc_src, cpu_cc_src, CC_O); + gen_neg_setcc(s, JCC_O << 1, s->T1); + tcg_gen_andi_tl(s->T1, s->T1, CC_O); tcg_gen_andi_tl(s->T0, s->T0, CC_S | CC_Z | CC_A | CC_P | CC_C); - tcg_gen_or_tl(cpu_cc_src, cpu_cc_src, s->T0); + tcg_gen_or_tl(s->T0, s->T0, s->T1); + + decode->cc_src =3D s->T0; + decode->cc_op =3D CC_OP_EFLAGS; } =20 static void gen_SALC(DisasContext *s, X86DecodedInsn *decode) --=20 2.43.0