From nobody Sun Jun 7 22:18:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780723049; cv=none; d=zohomail.com; s=zohoarc; b=MmR9uzh7+U7yZuUn8TYnVKmJUDGgMt1fHu16yxYuEl1IkigtIcsXeKIPwQnwBa2PyFd+dSk9pkGRBBFki8Aq0TQ8LGGlBF7BiQhQ79sU4q3FpzBhiTc9OOeCPammT7fY1/5TmyusQjmeX2mN5hxXZihLCgFQVm+6jKARvse6itc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780723049; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=EHaYJTnNXtnP4r58RbVBZ5CHW50pjzFA4v+h6Y0CfyA=; b=NNOk8+gYBLM/I5RdnFRcyAyu2sgiSATNMCv9Dc44zkORWLQopOHRzi7IGbCCCCElF+jlBURlcxealLViVM47Weh17co4FF707n1tM41rnxFFI2q1MN9eMN23bxLdJ7KzvDU4UPtWIXf/FtL5bfyN/P8u+blcykP7pSEC4ZpL/78= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780723049367674.2927620141321; Fri, 5 Jun 2026 22:17:29 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVjOA-00025j-Kq; Sat, 06 Jun 2026 01:16:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjNv-000226-6f for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:15:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjNt-0008BG-OA for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:15:50 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-684-ocFrnxgROHmO4vAsnlspoQ-1; Sat, 06 Jun 2026 01:15:47 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 48B7F180049F for ; Sat, 6 Jun 2026 05:15:46 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 231BB18005AE; Sat, 6 Jun 2026 05:15:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780722948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EHaYJTnNXtnP4r58RbVBZ5CHW50pjzFA4v+h6Y0CfyA=; b=SUCpEv0mg9yH5MBVkArBlrQCdhylN4tzbBRraql7nDCj490gpm5/1O2p7WFS+8XqetUCeK G56BgdUstCF2Sj2mO1Pku8OjmMJLJJIsd7UjcJ7pDh+eacsG8HJsq6Fgj16zkPMUcai4az cwiDNgrH3eebctIvDu/S9I9h269biRs= X-MC-Unique: ocFrnxgROHmO4vAsnlspoQ-1 X-Mimecast-MFC-AGG-ID: ocFrnxgROHmO4vAsnlspoQ_1780722946 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 06 Jun 2026 09:15:33 +0400 Subject: [GIT PULL v2 01/23] hw/pci: handle missing bus in prop_pci_busnr_get MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260606-qom-tests-v2-1-55832d978a9f@redhat.com> References: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> In-Reply-To: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=1326; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=6du0B3+bTyiu/gIbq11MHIRY6wGGJJ3yX28+ndrVGuE=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqI6z083AKVxSQ2Bn2+Po1oO3N5hy2HrJiUrjMc xjWGmcJfrSJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiOs9AAKCRDa6OEJdZac 5eY0EACyoPCk1WI6mCKUWSftfl5QIDKaH8lRnyMNYA2XHhQ6+fCCS3WJPizIm+ZG9GscWbSIJJN YCDVfF4cMlTOrLZp4oIq53IEO/o5/agDBMKn+oQVJPbmaSOfVlz4rKIgBMW076ITFpC6/P5BxiR cT0NsSePxY21NMK5ED7KJYGd94J7dN2YggLVBHBvlJvhyqbnnCIw5IwaerGq9rVOjliompHMtpC qjLWRckzfWBFdivKOrsvjHAfX6TKZCD3dkO+2f8W52p+BssbswndH5iuK87yqkk3RVhv/gr26st 8S/24gAoijPPAF5f93q6/cPJgXAnk4aCKcrJ6cuvzs/tPZL9ybhe4RZq0j5tHyQECkvw5I89uUL aFAY9Xlex33qLB9kYFczzvsLb8++ErtyRTqGpDFQEnkE88Ehd2xN8lEFx/voOrgO609Z68faL3Y Cj4DEngsnQvwuGKQHrr/aGnVafF+MyduY/9+cxen+Oi2EWLjlyJ7qwadBgk9194z1cEVOEpmfql lx8BVF9MBkUGahR6mvwkfLveP5tWkKY229TYN5rRs+s0jMWdHD7yKMLExYQJ1MTw0/IBj9d2p6Q WHs9iKzsHnibHukCHtqXUWEOTJJRbhfzqeBoxv/rTCGlyUTrE+f9DzAz0HuQ9w3q1AzA2e7fQky QFYTOJ1vC6qLw9A== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780723051296154100 When called on an unrealized device (e.g. from qmp_qom_list_properties), pci_get_bus() returns NULL since the device has no parent bus. Check for this to avoid a NULL dereference in pci_bus_num(). Fixes: df9ac7254fd9 ("hw/pci: Add a busnr property to pci_props and use for= acpi/gi") Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/pci/pci.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 4298adf5a0a..cec065d108f 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -64,10 +64,17 @@ static void pcibus_reset_hold(Object *obj, ResetType ty= pe); static bool pcie_has_upstream_port(PCIDevice *dev); =20 static void prop_pci_busnr_get(Object *obj, Visitor *v, const char *name, - void *opaque, Error **errp) + void *opaque, Error **errp) { - uint8_t busnr =3D pci_dev_bus_num(PCI_DEVICE(obj)); + PCIDevice *dev =3D PCI_DEVICE(obj); + PCIBus *bus =3D pci_get_bus(dev); + uint8_t busnr; =20 + if (!bus) { + error_setg(errp, "device not attached to a PCI bus"); + return; + } + busnr =3D pci_bus_num(bus); visit_type_uint8(v, name, &busnr, errp); } =20 --=20 2.54.0 From nobody Sun Jun 7 22:18:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780723040; cv=none; d=zohomail.com; s=zohoarc; b=Ams9ZrEN66kmAA4nd2oVhT7a+nQdVaEYvbd0Q/4ya5umhvNGGN88k95XvbtKD43+tG7fgVAYC/tDUxZDiBk9Mz4uMTumwZZwVF8dZLxImRbCNr7FdBIaEWHOOQq2KE07AaOMA7q3VCHDPohy0G/Jch5knrO0ydSGEgEAyN4Y1Sg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780723040; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=lytCdpvdiMPurS2UAPPEkSbXcRb49Mlw8+CgeQ0/TBc=; b=RK0H1RDQ+ypm/ICm7cZxcfuzzcT4t8xJQs6sSpHx+tkOA3aRHvgkHiKRxfvhJxwYK7/2Z9v1s7WBc+b8x42Dq3SyK6taEZFLLLFWhyVl5uqwZrlbOwO3MesGK/amB4JJ2iXFBfbOPhXOihz+nESlg5OSVoYMASSnrHoROn40SNs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780723040425355.1432731643871; Fri, 5 Jun 2026 22:17:20 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVjOE-00029Z-Gf; Sat, 06 Jun 2026 01:16:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjO0-00023Q-Vr for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:15:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjNz-0008Bi-I2 for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:15:56 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-215-4Hq2w9SOPcmxU8oNgJFmcw-1; Sat, 06 Jun 2026 01:15:52 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C4BBF18004A9 for ; Sat, 6 Jun 2026 05:15:51 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A41A11800367; Sat, 6 Jun 2026 05:15:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780722954; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lytCdpvdiMPurS2UAPPEkSbXcRb49Mlw8+CgeQ0/TBc=; b=jHaDld4B3noJszH/36PGtwljOfuQm2GPOAGEn3GETjp85UuNBLqUCvw+i5g/RS/Lixn3ZM RmZWN+ADzmHIbnTGfNT2zn8bKsEzIBcFWpNasd6NAq8EmVu3BIMe+oe6+4zCfsyHgSYifb Tr7y0S9I5IvfXWcHpk+srw8PwoXKM+8= X-MC-Unique: 4Hq2w9SOPcmxU8oNgJFmcw-1 X-Mimecast-MFC-AGG-ID: 4Hq2w9SOPcmxU8oNgJFmcw_1780722951 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 06 Jun 2026 09:15:34 +0400 Subject: [GIT PULL v2 02/23] chardev/char-socket: handle NULL addr in char_socket_get_addr MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260606-qom-tests-v2-2-55832d978a9f@redhat.com> References: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> In-Reply-To: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=863; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=wplotIDRIQizQ4vLWFXXRZnYhLKWxLjUBChA2au34a0=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqI6z024yu1XzfrQixkFyYCQlKZNypOFhNkVYBc dg0GkzpdUuJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiOs9AAKCRDa6OEJdZac 5YTxD/9MPTZT2fhozjl4PqkOSNDCPKQsJW/tLZ7Jm37XW0PfZ2eclLvHXeF+f5kDKjFk9ydeCWJ OmK6to9uUmZMbDxq790AYSHFAEG6lDQhXuitGBVb8kyrrij5OgnBQy7a3yUsf4D/nSVkV39oezy JjV6NxfMz9SSVU8Qa0oDmlb4Nm+ZOMUIfzoB2FiXUcwT6lU7Pm0sSYz0GvR50NzJcnCmYsfqm8B A05/N2vZHo/lbTaW5QswTTpMEWykLI5BIU+a4be1Zwro/KY6NGHam9yfufOQ/5lzr5z3PSN28W0 0welnkx2XZmIpLz1N/i1Z8/BXZoW8XdbCAQft+RBlH8wd73Jq1o0IBZe1Jh1Tf6FPm6Lq7zTn6m C0eaRBJgYm4+LRzD3wLY4ntUvYtXikycJBNPvuSHPHN1EWwnTTVpx4uEa9cdhexCnL2gLTg6a0t g46JewdgHXGT8uoIzXR7Bz2K7QX3uUBq/TfnoiGgI6LHjqVSyNF4hK5kEj8+x3nmLa/Y2KtOm26 5gy4sy+1lJsf26hVk+p0j9QlEm313uGgj5gJcT9q7FLC3O67NNqOM+Hi9bzGG8zDS2CHPggxWAt mSWjOLMDDM5hzCdJpT2APIv0Ki6ZJh/PPmsGsspU0Fd7msUSXKvCQBxSaeWhSu2T+XmsZt2uj3+ uVdYMKs0PtOQEGA== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780723041339158500 When called on an unrealized chardev (e.g. from qmp_qom_list_properties), s->addr is NULL. Return an error instead of assert(). Fixes: 123676e9894f ("char-socket: add 'addr' property") Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- chardev/char-socket.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/chardev/char-socket.c b/chardev/char-socket.c index e064b105c50..b629575fcf8 100644 --- a/chardev/char-socket.c +++ b/chardev/char-socket.c @@ -1529,6 +1529,10 @@ char_socket_get_addr(Object *obj, Visitor *v, const = char *name, { SocketChardev *s =3D SOCKET_CHARDEV(obj); =20 + if (!s->addr) { + error_setg(errp, "socket not connected"); + return; + } visit_type_SocketAddress(v, name, &s->addr, errp); } =20 --=20 2.54.0 From nobody Sun Jun 7 22:18:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780723071; cv=none; d=zohomail.com; s=zohoarc; b=oC5Xf1w+5cMQ0LBKgyxYHc9Oy1V7i8ON0X9y6VVkqxWPF64IBwT5cggilsSPFrQVJTJrb3+F7jkABIM1+Kitw+lm/Zy86CXzHNW1+lTq44aQRlPr/iVxn1c2y7u6+VmgwYbOHjlLZ5RI+RW0PdtCdk4NmaVS9Uw5Aep4cv2EM1I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780723071; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1KSCoPhM3lk7JFhTxcjXT83QO7v9CIqkxILozb1DjS4=; b=H/Cx1ITosMq3A2x92TBbQIy0tzkwlPTx0XWZsEjcAJ5OmNdbnPGOCadIohswNZhan9yB1qVbwvgVhhso9vWkPCxnD5g7sd759eZpBMNaqQIvWqkUQKbWT1l1lobubciAgcPazmq97Vq8rWw6GZ5YmFfMrovnAW62xnnHvpxeLbE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780723071225164.4205995145652; Fri, 5 Jun 2026 22:17:51 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVjOH-0002AM-30; Sat, 06 Jun 2026 01:16:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjO5-00026E-Qe for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:16:02 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjO4-0008C2-Ff for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:16:01 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-613-0iFngg0wMNKXKuZipOa0Mw-1; Sat, 06 Jun 2026 01:15:57 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C90FE180044D for ; Sat, 6 Jun 2026 05:15:56 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D469B1800361; Sat, 6 Jun 2026 05:15:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780722959; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1KSCoPhM3lk7JFhTxcjXT83QO7v9CIqkxILozb1DjS4=; b=JgkUVTHdnLTQayZUaI4+S528i4dFdiNJJ1FpJiDwp9K7aKXLWvCrMOQieOWLueSTMFK47D Zp4IoVzSEmDGQl5OgBaE0f2fhztbT0omCzwHNRpMDl7i4X/1IqA4B3k7P0etx9/syUp75N zAVo597/QFighG0C30uJ8b2m40dk1VU= X-MC-Unique: 0iFngg0wMNKXKuZipOa0Mw-1 X-Mimecast-MFC-AGG-ID: 0iFngg0wMNKXKuZipOa0Mw_1780722956 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 06 Jun 2026 09:15:35 +0400 Subject: [GIT PULL v2 03/23] hw/pci-bridge: handle missing parent in prop_pxb_uid_get MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260606-qom-tests-v2-3-55832d978a9f@redhat.com> References: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> In-Reply-To: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=1251; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=n1HD5N4FZEYQbnTz/49cmNT99YN0r5FAVFil0pDrL3g=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqI6z0U79PgSmp2Nns1j+04YC4v4VqqR/qTKQGA Yh6bNS/tdyJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiOs9AAKCRDa6OEJdZac 5W3HD/9U6U5p5IipvEJ8ngxAS8yRWXgHwyFVluqRpjry5Oqh7yIrtbnC4wfuJgTW90X5on5p6RT 6D5BMM/GYiN9/jyIS0jia9bnFZykd3wAjLO8G6NZQAUSiR5zVdw1eOfnOXPaRO21CEIoVYApbu0 Xeiz3MiOqezadzg3B9LVimOXeIExiD2gFpFT8LYQ+bVkHPkJQN2LA95PKX5xxMVYGfPaOfN9TuS rUxL9fjluW4AB0TKdMADZ7+HmZq9Aoy4FyxQbYEH+RrLvcJvzOAJGYyLoFVXpR668Ky4GemrOar MsyoM2cciyvLOej3A5Fv9uQ5cGXjhtgHncjYvK9P8sc1DzHglHwDKnbk+hTQhPeVWpVEcrgoDJr Ax134v8XBzJFsceRaHtgk9a6s3gkoI9PhZI19UoyrB/GDDgr4gEG2RGq7CebjchcYKi9nYCL9MI r/iHnPZfKV8JKJyYpRQ7qz0LA6j/kHNnu7WwUipTrmBS+yU58q4NmWJXVUtJYkgKUce6nO0s4vI cH98UNokBYGBSlJlIR4D93x7h5i3wLZTySONxhoLDPAoD7m0hP/O/60bAVDS6jXwUYtRCg4LpId 3xvxI4wYLnWcmsiUvd4PBtmZXPXm0IQnYLWZ7ydY79YChU6iBi+/YKUjrCpKeaWN3mIICzxYXx/ lI6G/styWrW9aaQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780723073452158500 When called on an unrealized pxb bus (e.g. from qmp_qom_list_properties), bus->parent_dev is NULL. The pxb_bus_num() callback dereferences it unconditionally. Check for this to avoid a NULL dereference. Fixes: 97b9cb066e5f ("hw/pci-bridge: Add acpi_uid property to TYPE_PXB_BUS") Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/pci-bridge/pci_expander_bridge.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/pci-bridge/pci_expander_bridge.c b/hw/pci-bridge/pci_expand= er_bridge.c index 11623a5666f..40ffbc4e082 100644 --- a/hw/pci-bridge/pci_expander_bridge.c +++ b/hw/pci-bridge/pci_expander_bridge.c @@ -85,8 +85,14 @@ static uint16_t pxb_bus_numa_node(PCIBus *bus) static void prop_pxb_uid_get(Object *obj, Visitor *v, const char *name, void *opaque, Error **errp) { - uint32_t uid =3D pci_bus_num(PCI_BUS(obj)); + PCIBus *bus =3D PCI_BUS(obj); + uint32_t uid; =20 + if (!bus->parent_dev) { + error_setg(errp, "bus not attached to a device"); + return; + } + uid =3D pci_bus_num(bus); visit_type_uint32(v, name, &uid, errp); } =20 --=20 2.54.0 From nobody Sun Jun 7 22:18:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780723162; cv=none; d=zohomail.com; s=zohoarc; b=SpVWqpHwcX/inY6cyCTllqcG5XjrxPyus2yuj+W9j4QD8uevXQ6RJv+1SrysRRrUIdoEatReI5HFJzkV9X+yFCzisrJ0/6QW5EmzYgjixJaAeNxl1s8pY/ye36sm0uJ2aT+eX14VbDeBQD1HRI7H4Ne2nnl1CKXHPPPn3HpIZ0k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780723162; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=dMU+/9kJPvBI6+rr+qjuUE2o/XCGiPk1vWq0Y33MHrs=; b=cLJqHR5wAowutIly0wzvq3wEVLa5Pnz84O7vJv2GPCXDcNtZ+VSa4rMPd6HcQkxMue9ofr3h+DDKc+GaJSoh41Rpz7jTR03EE9VzoaiKhPoEHoljWtltcz0g/0l1K6sdO6IJxCstqq2mYVvpk4uSEtoywuzrk6uFBEE9TdZt2SE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780723162641692.8189957686351; Fri, 5 Jun 2026 22:19:22 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVjOH-0002AN-3S; Sat, 06 Jun 2026 01:16:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjOC-00029H-4B for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:16:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjOA-0008D1-PM for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:16:07 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-438-wFDvO_4uN8e8Cz_iQtfPaw-1; Sat, 06 Jun 2026 01:16:02 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0D35C180044D for ; Sat, 6 Jun 2026 05:16:02 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id EB2251955BC0; Sat, 6 Jun 2026 05:16:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780722966; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dMU+/9kJPvBI6+rr+qjuUE2o/XCGiPk1vWq0Y33MHrs=; b=GT3fMUNjigFa9qVTFKjprTKlGiBk15Kq06OOk2OpAAhMOzIWCXHMM8XrG44rg92dbhyRJE iz47C1qCOm+KBVwLiJmPNLS0OiJQXQt/+xdoyNVYlDUarYVzlxhAgVIuR1UABoJgWvGnEK INUzvuWOMD698hzoKmjlnKmHNtzGfQU= X-MC-Unique: wFDvO_4uN8e8Cz_iQtfPaw-1 X-Mimecast-MFC-AGG-ID: wFDvO_4uN8e8Cz_iQtfPaw_1780722962 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 06 Jun 2026 09:15:36 +0400 Subject: [GIT PULL v2 04/23] hw/pci-host/i440fx: handle NULL bus in pci-hole64 getters MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260606-qom-tests-v2-4-55832d978a9f@redhat.com> References: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> In-Reply-To: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=1993; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=OVF9SYpNWrlV6USrd7t5agr6GhrxgYTzZ+VWk9J0k8Q=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqI6z0r+HxpBIe+U43NaxusRL10a5nAxAty9WCY sZL8yNIiPaJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiOs9AAKCRDa6OEJdZac 5ZCTD/0U7ma8QVhoVM4EZ7ZTZ3bvto4ldeL/GI3Z7UA8OLDnLpB2zKKb23aE5lKNMWkn5ya78jJ 2BwJ+jxaugaA8ny+PkcqFUpGf0SSwUTEYZOquJcngrH3XP60AIPxaFB0Z3XeGHQPlBgrBdNVYxH dTlc2xmoS0FqR5kI89j1yJtlTppg8otZreV6Dpyf6U91XYkGvgpI8V03873tB2CEjNA9nEf4ioL xqx9Fc3JQozAYYVxvUaTxlvYmlK9FPmADroCEA1wu4EwsxLioYHlxBqcCC5RhxdbZTqGd8j6yl8 BLOQ3p4UQDtrCtwTHUjHe1O5QVLnuKYPpYFAAwYB4aiwe+6qdFY/vC/uN/4rtTkJHrvsrFnWPVW 9ixelYAfIBjB3zKVD7Zyi+UMHCt+t8kmSr/mspVbgb7CHy8E/CD5yNqA9px16uGN0MLny6j5tHD hj3PCOHICk/OGcpE5CcTOinWAdyf1poitPEeoBVYhVXTwYt49O87zzlAS1sbOoF9XBPPA3tb2W/ wCTm6ECgHhY6pME76xK+vhbI0P7rG4qQhVf1EWWpeVPDOhTkmAQ0QbuDLG28o+0Nr4pA5EnDTUK N4CsuGfF0r5yO6jrx373NR49xtjXbqpeGYdmrzAMgHC1Rk9FJf+gZsll7I3aXPi/ZtkFE/jGV2Y hp3n6rfSHeNQreg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780723163804158500 When called on an unrealized i440FX host bridge (e.g. from qmp_qom_list_properties), h->bus is NULL since the root bus is only created during realize. Guard against this in both pci_hole64_start and pci_hole64_end getters, reporting an error. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Daniel P. Berrang=C3=A9 --- hw/pci-host/i440fx.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/hw/pci-host/i440fx.c b/hw/pci-host/i440fx.c index e7d638b296c..c1982f7962a 100644 --- a/hw/pci-host/i440fx.c +++ b/hw/pci-host/i440fx.c @@ -189,8 +189,14 @@ static void i440fx_pcihost_get_pci_hole64_start(Object= *obj, Visitor *v, const char *name, void *opaque, Error **errp) { - uint64_t hole64_start =3D i440fx_pcihost_get_pci_hole64_start_value(ob= j); + PCIHostState *h =3D PCI_HOST_BRIDGE(obj); + uint64_t hole64_start; =20 + if (!h->bus) { + error_setg(errp, "PCI host bridge not realized"); + return; + } + hole64_start =3D i440fx_pcihost_get_pci_hole64_start_value(obj); visit_type_uint64(v, name, &hole64_start, errp); } =20 @@ -206,10 +212,15 @@ static void i440fx_pcihost_get_pci_hole64_end(Object = *obj, Visitor *v, { PCIHostState *h =3D PCI_HOST_BRIDGE(obj); I440FXState *s =3D I440FX_PCI_HOST_BRIDGE(obj); - uint64_t hole64_start =3D i440fx_pcihost_get_pci_hole64_start_value(ob= j); + uint64_t hole64_start; Range w64; uint64_t value, hole64_end; =20 + if (!h->bus) { + error_setg(errp, "PCI host bridge not realized"); + return; + } + hole64_start =3D i440fx_pcihost_get_pci_hole64_start_value(obj); pci_bus_get_w64_range(h->bus, &w64); value =3D range_is_empty(&w64) ? 0 : range_upb(&w64) + 1; hole64_end =3D ROUND_UP(hole64_start + s->pci_hole64_size, 1ULL << 30); --=20 2.54.0 From nobody Sun Jun 7 22:18:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780723123; cv=none; d=zohomail.com; s=zohoarc; b=B5B186/NqMRj67x1rU3F7KY4wBTa4IyB+2ev3nxMRdfG0ErZFq0BdRg8ptEQxkvxjN4xw9kcZgX6S/NhLlik2QvSkCY41hZfpx01Ni9Ycf5kz+xaDD2GhCvOrIDyiIOMMUEpXw1UqZcYcQnxumBZMmEqenbEHwHpzX/eQBsT6/U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780723123; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=lfyciCUtj2uYB/fKRwGsx2x9nVw//AMbGAr/gW/I5xs=; b=LG/uwWa/W8r4BqHzDuM8RxBSnpqMXZh7mID481Bu7ktb4iV5gj7fKeOzrNKRLrtkYiUGtmSFrpFfmJBi433pUf6CkAh7G3wPVSG+ifUoAAGKn57nPhEbNLyHXmCXbLv020rUGsTdzn23iDnSZxSN3W7wvccryG9Ish5s4ISIE4Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780723123520483.2795955422829; Fri, 5 Jun 2026 22:18:43 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVjOI-0002Ay-Hr; Sat, 06 Jun 2026 01:16:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjOF-0002AA-Tl for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:16:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjOE-0008DI-Fr for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:16:11 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-73-MCcH5VYnMUmrl23Ll-yp6w-1; Sat, 06 Jun 2026 01:16:08 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3DBE3180044D for ; Sat, 6 Jun 2026 05:16:07 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DAF3A300022D; Sat, 6 Jun 2026 05:16:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780722969; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lfyciCUtj2uYB/fKRwGsx2x9nVw//AMbGAr/gW/I5xs=; b=VRY8S2teeKGCM9OjxQVSimi9X5FbNv2y56Q+tFy3dkT3K284J74FyBYiZBUxOm+ojvqFEH /pAkht+5xohkXn7s8mKjujudWYY5seQZCHknrr9Dl78eQpdqmvEIp8uKp8zA6dnQsxUSFt /HvinCsr26g0D21nqbPiuBZBhvi3EXQ= X-MC-Unique: MCcH5VYnMUmrl23Ll-yp6w-1 X-Mimecast-MFC-AGG-ID: MCcH5VYnMUmrl23Ll-yp6w_1780722967 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 06 Jun 2026 09:15:37 +0400 Subject: [GIT PULL v2 05/23] hw/pci-host/q35: handle NULL bus in pci-hole64 getters MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260606-qom-tests-v2-5-55832d978a9f@redhat.com> References: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> In-Reply-To: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=1907; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=XXJqDmEBi6TiRs5PKjbn7IjQSTVVWEFFYwA+j0kMbhI=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqI6z0rsptjNi4pFJLlsaoLbu1g1Vx7ocR83dRV DH/6oDzCz6JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiOs9AAKCRDa6OEJdZac 5aXSEACbsDyYmv9zDXGzbqxJC3W/BxtfB0zcslUEKBVvmflPDD4P/0gxhu14pUMSEt6Eaxizv+j 41Zkv03PegdcGM7BkuD46JQoOVDpIMYOHkeTMnb9XLA/BwzGlyN3Ot4RIbh6ctNN1QjgKpquPlN UHbnh5e0vlBop6fd4Cc0w/URCuyVikBo8B4yY+WUFqGtBaGYWLxCWbuLD/GK3UJknPOZMcFpjiS dlNxKzBOnA9EMxUQ0+nXHpfZQoMbRALIR4XEYV1urTwHcYL+CXFgaQQnBxaFt9tXHYGFuOu8mSb L2fs7js+UQ1XjR4nkAPfSWYRIqXFcBWysMw/EEDBwgnjtPCYM9Nfpdix6ucjwTo256UMk9MsBDJ u0Fpo1HTJqN6IQwVJF/uWL3XojEVIjBwPYOg9gYe53xU5K4Ybgw5ijPEuYLh5If1rEBdbrY6Rfo trGPOkjqgfda1P+R8cJU1RWrPl+OnNmmPnwJIjNskfgcJ5dt5c1FWIbZ4V9VfcbZC+sbhOgFJTy w2oGrc/9vVPwqfzooMfH9RZaMmuFKLfzNG47u+3g3wl5ZM+2+KlpJqGfaUqcVOW2/8QyyP/uDKx FMX1IGpjlsybh6pwCNM8entAlnmcFnkQ5VeYXJvAKzAGQN/7E1F5Kqsfvm0OgRS2psu3JpYZgyX lPO5pI+PUyO+4jQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780723125649158500 When called on an unrealized Q35 host bridge (e.g. from qmp_qom_list_properties), h->bus is NULL since the root bus is only created during realize. Guard against this in both the pci_hole64_start and pci_hole64_end getters. Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/pci-host/q35.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c index e85e4227b37..355e81bfa20 100644 --- a/hw/pci-host/q35.c +++ b/hw/pci-host/q35.c @@ -132,8 +132,14 @@ static void q35_host_get_pci_hole64_start(Object *obj,= Visitor *v, const char *name, void *opaque, Error **errp) { - uint64_t hole64_start =3D q35_host_get_pci_hole64_start_value(obj); + PCIHostState *h =3D PCI_HOST_BRIDGE(obj); + uint64_t hole64_start; =20 + if (!h->bus) { + error_setg(errp, "PCI host bridge not realized"); + return; + } + hole64_start =3D q35_host_get_pci_hole64_start_value(obj); visit_type_uint64(v, name, &hole64_start, errp); } =20 @@ -149,10 +155,15 @@ static void q35_host_get_pci_hole64_end(Object *obj, = Visitor *v, { PCIHostState *h =3D PCI_HOST_BRIDGE(obj); Q35PCIHost *s =3D Q35_HOST_DEVICE(obj); - uint64_t hole64_start =3D q35_host_get_pci_hole64_start_value(obj); + uint64_t hole64_start; Range w64; uint64_t value, hole64_end; =20 + if (!h->bus) { + error_setg(errp, "PCI host bridge not realized"); + return; + } + hole64_start =3D q35_host_get_pci_hole64_start_value(obj); pci_bus_get_w64_range(h->bus, &w64); value =3D range_is_empty(&w64) ? 0 : range_upb(&w64) + 1; hole64_end =3D ROUND_UP(hole64_start + s->mch.pci_hole64_size, 1ULL <<= 30); --=20 2.54.0 From nobody Sun Jun 7 22:18:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780723039; cv=none; d=zohomail.com; s=zohoarc; b=eMpguSCZNEAlYfjDwPSfD7j3sD69gRIHt/HIXJIuh1ylsSJmlktBGrPJcLj0N8h1X0rl3n/gTLhGX3jHvC31zoVhTW0wyVrgxGoZBmAXfzbz00IFxPtPR5+2h4uyqaodcZRNGWOfSiesGk0PC0vTyzwaxhSVSzgY/upll+QxInU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780723039; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=40y9nUEM2k+DgX74L7br+FVh1cGqfh7EYiI+WllmI9w=; b=eUMbCyYAMbgJHBAYm5FlUv9jaguawhvunNEnBUtih26XosgQTXVrjN3qts31WAUO4xye7oneJAm/7Lhi4XdDKD0kxCdklVnkQ1RQ9Q/bTcne6U6jGY6wH20S8YaKraNJVk9P89fbDqy55o6vTvISQbIUaA6Z9SIomP8CwcQafWY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780723039121172.2584018006993; Fri, 5 Jun 2026 22:17:19 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVjOS-0002Bd-6j; Sat, 06 Jun 2026 01:16:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjOK-0002BE-Qr for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:16:16 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjOJ-0008Da-AR for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:16:16 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-615-xevUJlomP7KpSiBhzLqKlA-1; Sat, 06 Jun 2026 01:16:13 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5CDC81956089 for ; Sat, 6 Jun 2026 05:16:12 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 049CD1766; Sat, 6 Jun 2026 05:16:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780722974; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=40y9nUEM2k+DgX74L7br+FVh1cGqfh7EYiI+WllmI9w=; b=FbYOpK6th0sihw3mY7eLOuTW8WqjEeObP25fAtCons+LkfspeBZuh1FjlnsGbMMUVsRIMS nQfxyhDfIEaZXJHSxaPM2IieAR7qoS3zJPjL1XPN+Lhk2SXpXMKBZHG/9Zd300k2eUUc8d 645aHsKFF/a0xSxhpahT395DdJIgRoI= X-MC-Unique: xevUJlomP7KpSiBhzLqKlA-1 X-Mimecast-MFC-AGG-ID: xevUJlomP7KpSiBhzLqKlA_1780722972 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 06 Jun 2026 09:15:38 +0400 Subject: [GIT PULL v2 06/23] hw/ipmi: reject NULL 'bmc' property rather than crash MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260606-qom-tests-v2-6-55832d978a9f@redhat.com> References: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> In-Reply-To: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=767; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=mEwe7/OMVJKZh0U5KU7As11b7hk3pWmV01Cq6GcNgXU=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqI6z0Kx3lkfCikOCRNQ5lBbBNDTLznIR/ay9TO 1nggYpHv5eJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiOs9AAKCRDa6OEJdZac 5QSLEACedqZocJ8j+9GmocgwIuNIp1MDhRD3MKaT9fTW1aePMDe+KAn2SZwuIKBujjDtvGeqJeD wmTpQkZWEI5GP5eD5mUr3PlZhsboguyLsCAEok5T6kG7JvqHtQ4qwCaQSWxjBVqKUpfRpPYR6OL Fgz5KL34Wkf8q86T4JVb7qRFmf3ii2wJhuGP1gXM7bcY2CMNMV9uYqYoJwSC4aZKzQIMgtcnj4b LeWDZMwzVZTfuzVCARKHU519iKzuzDU5m84dGj8ahgWGe2O45iZ+5lsRJwRaPZmJFlUlN7VNKS9 2WUYsGnbE0NOWt6gTV+Rm1UsemZvj90qPshkLQyLn0AlFWgsPTi6Vs5u+ZjM6fjkaPDo8s8hscc fQiKTMXfgjiqzaene5ToVfBeJOgmI4WfsvqfOUYvw/7Oj1z5CRS6rXmYOYHrCt0+lDJakNzTiqQ /SGir0i6XkcAeop7KzDJwYf/2IkGXAP1UorfZN3xCtcpuBpSl3G9zbznnNUu0aJZ2XRWLdgxpSj t4Wi296pHhdKMB2nFZma4M1kg5kjfIK9bAZFIk6vdOurbNTYxNA+67t9lG5eEkeA7/KEOkvu/n5 4qMmJ/dugMjjgB+aWOcDxeRqCXrf4TWoxlG7B7mZ61ZwKftr0f3jdV56Vwt0ZN6MiqCNHXhw+/Q OTicuYPzPLx7Khg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780723039345158500 Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/ipmi/ipmi.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/ipmi/ipmi.c b/hw/ipmi/ipmi.c index b49affaccec..74818ff3cea 100644 --- a/hw/ipmi/ipmi.c +++ b/hw/ipmi/ipmi.c @@ -97,8 +97,14 @@ static void isa_ipmi_bmc_check(const Object *obj, const = char *name, { IPMIBmc *bmc =3D IPMI_BMC(val); =20 - if (bmc->intf) + if (!bmc) { + error_setg(errp, "%s cannot be set to NULL", name); + return; + } + + if (bmc->intf) { error_setg(errp, "BMC object is already in use"); + } } =20 void ipmi_bmc_find_and_link(Object *obj, Object **bmc) --=20 2.54.0 From nobody Sun Jun 7 22:18:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780723022; cv=none; d=zohomail.com; s=zohoarc; b=a/1l/oIN18nfKjhSdDtVy09thYlHmfr21PZ3eLnVf4Q/OFsnDdO9zWT9dRikiDovx88eNOs8ttcm06C2gGGF6HYtsxquqgxSz3f5D8yZJm9tlTjBc8LpFDXhFoSjfuXQ5rkEht2e3yrqwpAHjSu3cQftg4UGYzjcPuWBoZPnlTM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780723022; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=fAwFkj/6xMxLjs4eWHPsU8ZO9MF0yW+Kp2IWPAaAtK4=; b=i5KkbcNUWclWdJazjF3wida4KNAd1J/w5ckVOIrpMdclpkDbUDVTK2FLo9XboPF2wWBAhTgUdJTsV8Z4A92baPOff0WJgkM/XQ6fj83WrpsOXtU55NMQWCzhhpT4DNtKzsRplDQbBWzkiqR6oAicwM779z50EQU4Utxf6jQ2saY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780723022582940.1113687490988; Fri, 5 Jun 2026 22:17:02 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVjOc-0002D4-He; Sat, 06 Jun 2026 01:16:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjOQ-0002Bi-Pl for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:16:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjOP-0008E1-De for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:16:22 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-64-tgDJXFiONhiDUfIBISgoxw-1; Sat, 06 Jun 2026 01:16:18 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DDDB819560AA for ; Sat, 6 Jun 2026 05:16:17 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A348F195608E; Sat, 6 Jun 2026 05:16:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780722980; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fAwFkj/6xMxLjs4eWHPsU8ZO9MF0yW+Kp2IWPAaAtK4=; b=MtzJhoJ+f682+Kgh+yNZO+EHGm2qZnzjKVVlj2O1ca31HTuNcGLJxuAqNmQ/0I4oM5wUFp JXqzlOuBVpr+7dzfibziEFk/qZj90DXMUP33lYjFyjVbEF+dmrez7QQC+Z817Q09Ld2THi j9BSjuCGYaILXrUGF9ik+LKz0UFFxsg= X-MC-Unique: tgDJXFiONhiDUfIBISgoxw-1 X-Mimecast-MFC-AGG-ID: tgDJXFiONhiDUfIBISgoxw_1780722978 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 06 Jun 2026 09:15:39 +0400 Subject: [GIT PULL v2 07/23] hw/xlnx_dp: reject NULL 'dpdma' property rather than crash MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260606-qom-tests-v2-7-55832d978a9f@redhat.com> References: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> In-Reply-To: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=806; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=kJdZho7KPoZAyRTuY6SsmAMLdZDbGBB9QFQKogVkqy8=; b=kA0DAAoB2ujhCXWWnOUByyZiAGojrPSggU4DPZy6Jh+14kmslICE0ZQLk/sDHOENAJMXpG5x+ 4kCMwQAAQoAHRYhBIepvZM/h8YG0nb2Ldro4Ql1lpzlBQJqI6z0AAoJENro4Ql1lpzl288P/AkA NmaxNO5E3cPwIZEnvpEZO2r0FaASf0pxIbPXZrpN3uZX3KQ0Rb0hxdlrN3nLxn1wCAoThCvG2nw tDtQg4jwXTQbQJq3QRrT5AR9L5QXPq0u5L6pJff36QWnM2et0Ssxxfc5B2bDCK7X05EeXnm97R2 zDhjU5B911zsPU6azw2KCL0KLV2CySe/g/gySuUk4eaUZ10v42RN4jHBldgBfxZrLddxljCjZfr v/S+8XehP7KGMLQWZwy7mVjBSBcyVy916pCdDtBusPs/bU/tufzNcaWtHaU1B1Ph3rZ9pZd89py +wiUcnb95eumUOM40lSxCACgi0gDNsX0Vzt9v0SrXvn7wWafOclSDOENF8Q9Fo+MjhKjUvpoW4Z 1MKlPKPjC66ecYL/2xQln1q4abCv6Zl+Eke8xJkAEq/l+PACpEdGW9XJqkFpSdFFdSfMpAApVgO MJSxlbwElAgtFxbF8OdBO6iJ5HAIy21zxnmuFVXVkcA6ZQHjo/WHblYS0UoiUAAM/iRGZGmRqxh y0yzp5qjaTP4KKXevakTs0522ZIK1yD1jl9rYwkF1PQ+gCefC5E7R2FbQQB1byTR7dFt8YW+avm rWXpiANRHeaG7aUz9VZX7UBNSw4d8fM+H5Ds0WlZNKgwTrCYKHY5BjezIImXi2aKqKzwCtcI/vJ qlrCX X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780723025195154100 Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/display/xlnx_dp.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hw/display/xlnx_dp.c b/hw/display/xlnx_dp.c index 2486d9e5825..98126ef320d 100644 --- a/hw/display/xlnx_dp.c +++ b/hw/display/xlnx_dp.c @@ -570,6 +570,12 @@ static void xlnx_dp_set_dpdma(const Object *obj, const= char *name, Object *val, Error **errp) { XlnxDPState *s =3D XLNX_DP(obj); + + if (!s) { + error_setg(errp, "%s cannot be set to NULL", name); + return; + } + if (s->console) { DisplaySurface *surface =3D qemu_console_surface(s->console); XlnxDPDMAState *dma =3D XLNX_DPDMA(val); --=20 2.54.0 From nobody Sun Jun 7 22:18:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780723004; cv=none; d=zohomail.com; s=zohoarc; b=ZCeBq4meIx64bq1cZTjN4GneE1LWYcl1JDrVqiVzKvOgh0rd/5r03XfXTTUeATp6W0VBMcLY2vRDFd2Td8YHFOTtODckuIrZ/BIoT48f09Hb7XK4mHokE0J/sVbbMSKYlrTwUs9cGqOpUOhTwBANBzES7OUb8FXSLgboM1k7qMA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780723004; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=9oVaaSGgSCNfnHB8VrwCnrC/7/oqMdFPnrQEk3bhZys=; b=DQsG7dGUoVIIYbWetHfEULhXu/k/CRKGAf1L9pllT0UU8z80dOihKYJAFrqrTl0QrLuZ9IVQTejcGmW1tutfLtgxfhcIxGXXfXrf5xd77MGXLvJDiZ1QERr7ly2F2T2kqECLac2Zsn1qfeBy/YkoNqLS5+9b0BIZxQNe6BRwOsM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17807230037493.6231200171952196; Fri, 5 Jun 2026 22:16:43 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVjOe-0002F9-2q; Sat, 06 Jun 2026 01:16:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjOW-0002CJ-6T for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:16:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjOU-0008EN-7I for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:16:27 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-575-U3TRRJjaPbK3M6I67j3o7g-1; Sat, 06 Jun 2026 01:16:24 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4BE251956053 for ; Sat, 6 Jun 2026 05:16:23 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 12B711955BC0; Sat, 6 Jun 2026 05:16:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780722985; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9oVaaSGgSCNfnHB8VrwCnrC/7/oqMdFPnrQEk3bhZys=; b=S5VBew8jSx0fQjdg5SHmb36o3PGj/D1QqlZfLKEaobX0hqadi/d/PCFVoNtktk7fwahcxX kPflqDSGYqrdhG1FB89R0U0qXSSis6PVZyZmZBUPRF0JOKIjisUQPqorzwGJu+hh21awvV i+D5Bt/3gE3KqnlP+94MiAHxjQXzByY= X-MC-Unique: U3TRRJjaPbK3M6I67j3o7g-1 X-Mimecast-MFC-AGG-ID: U3TRRJjaPbK3M6I67j3o7g_1780722983 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 06 Jun 2026 09:15:40 +0400 Subject: [GIT PULL v2 08/23] hw/intc/apic: move checks to realize() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260606-qom-tests-v2-8-55832d978a9f@redhat.com> References: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> In-Reply-To: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=3010; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=kCq+Tor03wCqaIg7gsFcKOnzmGQyewRDM9N2xTJ00BY=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqI6z08RkAqq1MMUlG4MTMvgr4df2fJrr1z2JqT IK4iRe4TFyJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiOs9AAKCRDa6OEJdZac 5TLXD/wOFvTpA5WDR6cKD1lgrQJyV51Mm1OQToIReo4Ez55chJh9j5yOo6or1z1KihcqRxFdgSq IzFf4NAElNWPeH3wOANez4/m/IdFIE0ZXpHdJc4+BBtvdoowRMPHb4a8xtMPBa68LZCaW1bXOX0 h0xyG9mIt6nAk50pqhAfD9nHI0LO2T9N8zpqVcZ6X450iBlAsDOSfPWxVmEDTzNi9GYSt17K9n/ y4BL71BHXF7X4VDb3UzxRXC1Sn14vbu98w0hRjNboAoFKn1f4YyhrLRy8rY8ftHbR9sloMnWHvf xK9C5rzedN3oXT+7broymnhg4N5OUNN/jfhJn3v5Ghpu0XBYIPF9F/pRLye89p4YGAjZMWLPNSl JO7VtvZ72O8qnJRgnniyDqAiBV1Ephjta184LOhPDFnW4hQ9h8NlmaNxCMu+beF6V9TxECMCRmu MSqQrxjpOnU4Jw0Ff8k6BMH8/SktmlTFOMHssaJwjm3gmb5E/0I8QSxyZjnHVQFEsjTIEGXLfZZ wLvPWX3X1vse88ihItN5gz/2DIAvz7tL/WjWxYt/sEtGtLKq4Qhjo/OrtzUsZ2yJO3Von4L45rz SD9ZqcGmUGazJ+tmc1tIBhlXrzK+2WMe6SD0Lbq+tT//QuCQYyklsmD/My0LTwK/U/nekOjdQXL uaa2fqf1oknLG5A== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780723006292158500 apic_common_set_id() dereferences s->cpu to check for x2APIC support when the APIC ID is >=3D 255. On a standalone APIC object that has not been attached to a CPU, s->cpu is NULL, causing a segfault. To solve this, move validation during realize(). Fixes: b5ee0468e9d2 ("apic: add support for x2APIC mode") Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/intc/apic_common.c | 23 +++++++++++++---------- target/i386/cpu-apic.c | 6 +----- 2 files changed, 14 insertions(+), 15 deletions(-) diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c index bf4abc21d7b..49c03a5bcee 100644 --- a/hw/intc/apic_common.c +++ b/hw/intc/apic_common.c @@ -257,6 +257,19 @@ static void apic_common_realize(DeviceState *dev, Erro= r **errp) static DeviceState *vapic; uint32_t instance_id =3D s->initial_apic_id; =20 + if (!s->cpu) { + error_setg(errp, "APIC is not attached to a CPU"); + return; + } + + if (s->initial_apic_id >=3D 255 && + !cpu_has_x2apic_feature(&s->cpu->env)) { + error_setg(errp, "APIC ID %d requires x2APIC feature in CPU", + s->initial_apic_id); + error_append_hint(errp, "Try x2apic=3Don in -cpu.\n"); + return; + } + /* Normally initial APIC ID should be no more than hundreds */ assert(instance_id !=3D VMSTATE_INSTANCE_ID_ANY); =20 @@ -410,7 +423,6 @@ static void apic_common_set_id(Object *obj, Visitor *v,= const char *name, APICCommonState *s =3D APIC_COMMON(obj); DeviceState *dev =3D DEVICE(obj); uint32_t value; - Error *local_err =3D NULL; =20 if (dev->realized) { qdev_prop_set_after_realize(dev, name, errp); @@ -421,15 +433,6 @@ static void apic_common_set_id(Object *obj, Visitor *v= , const char *name, return; } =20 - if (value >=3D 255 && !cpu_has_x2apic_feature(&s->cpu->env)) { - error_setg(&local_err, - "APIC ID %d requires x2APIC feature in CPU", - value); - error_append_hint(&local_err, "Try x2apic=3Don in -cpu.\n"); - error_propagate(errp, local_err); - return; - } - s->initial_apic_id =3D value; s->id =3D (uint8_t)value; } diff --git a/target/i386/cpu-apic.c b/target/i386/cpu-apic.c index 5599a4675c5..04b7257ad12 100644 --- a/target/i386/cpu-apic.c +++ b/target/i386/cpu-apic.c @@ -56,11 +56,7 @@ void x86_cpu_apic_create(X86CPU *cpu, Error **errp) cpu->apic_state->cpu =3D cpu; cpu->apic_state->apicbase =3D APIC_DEFAULT_ADDRESS | MSR_IA32_APICBASE= _ENABLE; =20 - /* - * apic_common_set_id needs to check if the CPU has x2APIC - * feature in case APIC ID >=3D 255, so we need to set cpu->apic_state= ->cpu - * before setting APIC ID - */ + /* cpu must be set before realize, which validates the APIC ID */ qdev_prop_set_uint32(DEVICE(cpu->apic_state), "id", cpu->apic_id); } =20 --=20 2.54.0 From nobody Sun Jun 7 22:18:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780723014; cv=none; d=zohomail.com; s=zohoarc; b=Dq+eCimaS65JZPpNnyYmLPRvjJPKJQub6HUfMtDjoqiVh29dbhQLaIHjCxFCkMISoYl62Ugn61RrtulsXQNsY5AAdpgqbkTOq0Yp6Jt4KMtXqyr4wBmUgbgC4EzRQ7s0CbcI1djhOb7TOhn+0ApyGqrYyiwhV1yHzBGVQ05DOVI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780723014; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=T/Cc75KG/mGn6kld4q1FR9pIIprF3eBJYHOfuAmQ4M8=; b=F9u88HYSyKdwLfMm3DMdhg+gmxpk4Z27rX3LLKXjNVJS/XNzeOXWARS2Bg7eGh0ZZq+eezC2XlqnQe8KTgKWTdzLIkwWs6XVgVg9rmsM7W4xGQX/k6oZQG/gBzQkM3KF2WFFvxE6lycGt20ZEJuJoL+hN4tEUZoMrumx8QjB89E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178072301485271.2858298023774; Fri, 5 Jun 2026 22:16:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVjOj-0002H8-7a; Sat, 06 Jun 2026 01:16:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjOb-0002D5-Jr for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:16:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjOZ-0008Ec-Ft for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:16:33 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-691-V0DJxUo2OXiya-IWUhULBg-1; Sat, 06 Jun 2026 01:16:29 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 282B91956089 for ; Sat, 6 Jun 2026 05:16:28 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 32F33195608E; Sat, 6 Jun 2026 05:16:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780722990; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T/Cc75KG/mGn6kld4q1FR9pIIprF3eBJYHOfuAmQ4M8=; b=G9tfOYolrpoqhJ3Z/JtokvstbY30Jhs5YDd1OxMgKixGsb2NrDpAOGXTzADnmUf7mz2OIC et935r2W8V4EDwMWJyVbJXrodeYe7IwVAQwfLbZuWK8H0XLojXoJSKpyEMRlkYc8XjVjtw gzhhUP7QT57Kuy0WO9ertFf5kdGeNsk= X-MC-Unique: V0DJxUo2OXiya-IWUhULBg-1 X-Mimecast-MFC-AGG-ID: V0DJxUo2OXiya-IWUhULBg_1780722988 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 06 Jun 2026 09:15:41 +0400 Subject: [GIT PULL v2 09/23] backends/cryptodev-lkcf: skip cleanup when not initialized MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260606-qom-tests-v2-9-55832d978a9f@redhat.com> References: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> In-Reply-To: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=1242; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=ZoIQTw/8fvWMrcbUlgAsETKAbnpCOyqqMPiJiRQOO6Q=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqI6z0ySENDtZjCvfxUA925dtAedrd+vKXAProz 2Ik8tENYACJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiOs9AAKCRDa6OEJdZac 5ebaD/9cj0+XuHPMQc9KQ5h5dvoebjHrjnWeEozgXdoP4BqBCsV20WWv3vFoVkblfkodmUnfAdB HrOqhri6WdUE6lr0CIg016vDpXydWfgDE2LdoE2QtqDt3QdjGdIEPg2Oxz5aB6qb82SRcRY3Xsw 0fXeDe4j0fpcPYlFOQm7vYdNjx+8atz6q+bCSE32bHACMXkfi+Bhc7c+ZDmzs6kArYHQXN6tr2y f+WcZVunnfKdxkAF5KE4csc2n21SPLjfrO/nf7YXcfk/tGBRU66eW5+c0o8EebDhZPdA8oWbGsD z1mIS6Ba9quqc+3IZjiXobf6tBUvOaYLwvur3qROyicIHVd8fflwpIAnf7W0Gxvm9U4GmfWuBz2 eLUC77HF9ETybNfCntUC0er14Gd2kXj33hrQhECJ6EKPwfmYqx7HBK8nFVYaOfscifUFc++vFJ6 R4EJxSslu3fvHNLCItCLzf9EnPRCgpKRFGGjxypGndIMT/TKr9Sw+aRTU7VurecOUdeRthmrSUQ jPDNzlr8rD9jk4X6JuAnSirxELwQerLjRC0+y3eU6VWwUHutn1kv7UqaEnPStWSI/hw4FTb2A42 hQNefI1lS5MOSqZC/QHEa7sbFEghhdjAgVXOau63TZ06bpUqpZd+55GdSjOkleMPjdXqZJtg1DH U1tog0PMfL9h3Ng== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780723017051154100 cryptodev_lkcf_cleanup() locks a mutex that is only initialized during the init vfunc (called at realize time). When the backend is destroyed without ever being realized, the mutex is uninitialized and the lock aborts. Return early from cleanup when the backend was never started. Note: it looks like cryptodev init/cleanup callbacks should rather be regular complete/finalize overrides (calling the parent method). Fixes: 39fff6f3e8b3 ("cryptodev: Add a lkcf-backend for cryptodev") Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- backends/cryptodev-lkcf.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/backends/cryptodev-lkcf.c b/backends/cryptodev-lkcf.c index 40c7bd3c5a0..3fe29d3104c 100644 --- a/backends/cryptodev-lkcf.c +++ b/backends/cryptodev-lkcf.c @@ -255,6 +255,10 @@ static void cryptodev_lkcf_cleanup(CryptoDevBackend *b= ackend, Error **errp) CryptoDevBackendClient *cc; CryptoDevLKCFTask *task, *next; =20 + if (!cryptodev_backend_is_ready(backend)) { + return; + } + qemu_mutex_lock(&lkcf->mutex); lkcf->running =3D false; qemu_mutex_unlock(&lkcf->mutex); --=20 2.54.0 From nobody Sun Jun 7 22:18:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780723038; cv=none; d=zohomail.com; s=zohoarc; b=DXfLYujfqoqUAUTzsxTWQleSNkL8Fv5lsAce2rdv9rY211PyZPRiEcwjWIf3YWYwjXpRL3Ld28kqd5Jnqy7XqeY4F9yIwu5UhZFgaiQG8uJMBqwpfcwhQOqRfWEmv+5QNWuLxirxHezAJUZv971kV6wiAPn9IuT3fNTPRDeybfc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780723038; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=dZGdjRx4Qw+v9eLFJQiN10KyvdIUABstP/cGPr21HaY=; b=hjsgsE+6bemS9wKtVBxkEmWCdVTXf+3XKJVIcrnePYq3t5xbX7sROOyYhNkfzcWdJ7FZgEhYF+uGcQul0EpQYxtznJ+cPJm/2Wu2DOmv3LDUaF8w++U17iINzakUr/1J5CUaNKhZcvLUcv5D+lrA2wKRr0JnEYx3oM+v8fBZY2U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780723038062196.99236069172844; Fri, 5 Jun 2026 22:17:18 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVjOl-0002HT-6I; Sat, 06 Jun 2026 01:16:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjOg-0002Gb-44 for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:16:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjOe-0008Es-PZ for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:16:37 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-191-lA737s4_OSaD9iI2mRGcPw-1; Sat, 06 Jun 2026 01:16:34 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7A3FA18003FC for ; Sat, 6 Jun 2026 05:16:33 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0222B180049F; Sat, 6 Jun 2026 05:16:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780722996; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dZGdjRx4Qw+v9eLFJQiN10KyvdIUABstP/cGPr21HaY=; b=PuiQ7DRKnIm0Q/CSX9jrPWbi75P4yBBc78x2jLOm3/H2DIMopRbIBUPtsKpWWlAXe+co6K p1AMljoB/XM5taQkznTpErRuhX8krb1cE2xw2BA7fsHLDB/9uz3Xnt/Ek7zVIAiDxz4X6Z o7wchQUH8g6eVuv4uvR3oAwPGrWJxLs= X-MC-Unique: lA737s4_OSaD9iI2mRGcPw-1 X-Mimecast-MFC-AGG-ID: lA737s4_OSaD9iI2mRGcPw_1780722993 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 06 Jun 2026 09:15:42 +0400 Subject: [GIT PULL v2 10/23] system/ioport: minor code simplification MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260606-qom-tests-v2-10-55832d978a9f@redhat.com> References: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> In-Reply-To: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=1020; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=mmxLPf/mf/HIopy5JjPU/FWz41zXebmAxd8a1saOMJU=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqI6z03VaXpE+GI694XMGML00UbEihzGNxAK3d1 CR1RIflaoWJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiOs9AAKCRDa6OEJdZac 5dWmEACmxhLbrUoNQkdleZN1BtUxXQ9tfquEJf8oq10qThjbh334CXo4XGzCdqznVhPTfa+iwYk 1YsyAuCDOFEAdbMnMLXX++6EY8dD5p+x2xvqT//h/gMIne9otYeZmKnhJ6HT8BJfKua4S5zv8H2 ag1lV3b142LA9gBfz0deEoLsSy5tiOr/lgokC6AGk/nPOqWDsDr2DBKvbBA2IB7gs8ondqwJUrT OhBUz+40JuMxOcoUqJOgrrmPYDQDveUycIE2fJ4rKMhpoSEmqLP7bQJp+hR9BDP4UibpqBhXtOD Qv2dFrndpMAI371RVcYqAiynvOi8yQpsw4RJpUZGfeMJztJcXL4spJbs17TfGolLggZZ14H2AJe HaxUHXyK3aR1DkyIQCl7YW+aiNFEEkJWNAJOR8CXzoMwVN/yOGoL+a+40gif1++1c79WO5Sm3Ae 7p4eIFMNJxlUgErMu8TyfgotRoNVO+qa91C7CGNX1YkUUhQQ6V/FoKkYZhmtprMKb/vwyxe3qww ljM2CV8I+ND7wII1nFNkk0QaJzE8jDzA+LkEdUNZK+dyLNG2lirrwCx0zdyqpJI5vv3xFk20T9C jbm736wu1cZ5nDa7NUx3bHMjgNYKBNlGIa/In5QUdCYysVSpt4u7+kyHlAurJx6fG0MEX1g4SCn bFDlqJjG5qbeoOg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780723039271154100 Drop needless memset() and replace g_malloc0() with g_new(). Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- system/ioport.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/system/ioport.c b/system/ioport.c index 1a0e01fd06b..0a1b80f2994 100644 --- a/system/ioport.c +++ b/system/ioport.c @@ -230,9 +230,8 @@ static void portio_list_add_1(PortioList *piolist, mrpio =3D MEMORY_REGION_PORTIO_LIST( object_new(TYPE_MEMORY_REGION_PORTIO_LIST)); mrpio->portio_opaque =3D piolist->opaque; - mrpio->ports =3D g_malloc0(sizeof(MemoryRegionPortio) * (count + 1)); + mrpio->ports =3D g_new0(MemoryRegionPortio, count + 1); memcpy(mrpio->ports, pio_init, sizeof(MemoryRegionPortio) * count); - memset(mrpio->ports + count, 0, sizeof(MemoryRegionPortio)); =20 /* Adjust the offsets to all be zero-based for the region. */ for (i =3D 0; i < count; ++i) { --=20 2.54.0 From nobody Sun Jun 7 22:18:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780723036; cv=none; d=zohomail.com; s=zohoarc; b=GQNTv/GWHppgPOQ8UwbaKm0Gr7mKRMKbQVacGakroDsC10ku9Tgxt4h9HIc21NDsFt3SfsN96OXJVGoBe180MD0EWJBB4vO+01y+CeOXCirKJbq42dK7j9kl2w1rAKYIsCN2fjsTRKxumC4yCDSkAJPJZ/ziQU9oA/1IEOEwIA0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780723036; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=tKv7uKXevO2mwOyC4qHpjh1F8G+LrZIXjRyqb5hTmN0=; b=JXx8AJUub7NlWrU5lUZqD/aWt3LAaYJLJabz7FjMUAN2aXSo5ku0kjf/ElOOfPHkAO89s4QGLWiE0oTNfkwvfKtFrm0V9Z9Xad0dxXGc/wCFKlmNNH7CKlRlcO0eZ6FbhWpIlQyUaGKOiitQ12D5JGbNVXgGJ7zDzuSIHCk+bPk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780723036137574.4933025312065; Fri, 5 Jun 2026 22:17:16 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVjOs-0002Ju-PS; Sat, 06 Jun 2026 01:16:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjOk-0002J4-Fm for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:16:43 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjOj-0008F5-68 for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:16:42 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-522-CpXiwxtAMkCbxi90cuXC_A-1; Sat, 06 Jun 2026 01:16:38 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1718119560AA for ; Sat, 6 Jun 2026 05:16:38 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 06742180049F; Sat, 6 Jun 2026 05:16:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780723000; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tKv7uKXevO2mwOyC4qHpjh1F8G+LrZIXjRyqb5hTmN0=; b=NYfO3oWu4iOK8XfB09SRQB6ZlHSOJgnk3+BGAQvojrLmrBRY9kN8UteY/kIalg0CdRabqx SXBZSH7zdzoE81yBHP6v5lHtxfFb0Ofajp+WRUOgQhH5w0AgryO2eqViBVc+r2qkHlrLo0 Vt8tetnP2YUR2B5BYVU6u0uLg45liKE= X-MC-Unique: CpXiwxtAMkCbxi90cuXC_A-1 X-Mimecast-MFC-AGG-ID: CpXiwxtAMkCbxi90cuXC_A_1780722998 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 06 Jun 2026 09:15:43 +0400 Subject: [GIT PULL v2 11/23] hw/core/machine: free shim_filename on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260606-qom-tests-v2-11-55832d978a9f@redhat.com> References: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> In-Reply-To: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=774; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=K+iwOApmpEnOaMk0KH5HYUgH1BE9LXcBH+NmGOZb1Go=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqI6z0NrShnHLZg9ECTFbd6p6p95YrU0ZBUS0ml rgzyaE+/w+JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiOs9AAKCRDa6OEJdZac 5R51EACj8bxSuCSoTYvo/3FA8syGYoJd9u/J+uS+ebQF/lFmz6SBszMx60bBVcpxGfcJlX9bLv+ riEZipk2IUKW+d06FfV5QG3xXpCP0+y6z5poHx/0zltonN4pDHQrT9iWlFWKCCwGQHdgYuQFRMo X2TgLbuUvmtJahMl6B85QflNVRwkeIymrScw0qLyNSCclkYdxfrgiM0Hjjk+kfuHB5fz0RVbeRL VvPdTUSV1nxq77JsGrtY4Y1bGhUzaOupHUdIBR1L0vsFmes8l7c5kH+Amm3Xx5Ot/XJyNQa2Nz6 VfWkAwa1PcfAY/rcGEoO6ZxirYSOWuhwpWvXxBSqBpGAH5KNbGPJxav36FcamuFwdtksvJ78ALe 747nlp6Jy4XDfJlQhDqT4ZI0kICvMPpZwo0HMqJa02hI2sU5yOJgOaElkLgKi3GVO5VwbISwC04 zleR1nadaiF2gPhP90FP3L6Qyt1NFGGHg+M48kzRkN4bqERnTmHzasC+5mDVUJviq/AtVzcaJEY a28GN33o4VNLVWVvXxdWoQ0p8bnd8lXbkpkhzXqNcyngutP7Bu0vBRyY1gFKY846UoYuPFqWoZ1 7oFgG3VYNybFiU8qu9LmVGWeWsiPkeEnT2wHOOufRiSqyZtUQ1+KzNLMe9TVcMZA+SqCZafjTIJ vSet+4JsdMsM17Q== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780723037462158500 machine_set_shim allocates shim_filename via g_strdup, but machine_finalize did not free it. Fixes: a5bd044b1579 ("x86/loader: add -shim option") Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/core/machine.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/core/machine.c b/hw/core/machine.c index 17970b78b65..4d8b15d99e9 100644 --- a/hw/core/machine.c +++ b/hw/core/machine.c @@ -1286,6 +1286,7 @@ static void machine_finalize(Object *obj) MachineState *ms =3D MACHINE(obj); =20 machine_free_boot_config(ms); + g_free(ms->shim_filename); g_free(ms->kernel_filename); g_free(ms->initrd_filename); g_free(ms->kernel_cmdline); --=20 2.54.0 From nobody Sun Jun 7 22:18:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780723082; cv=none; d=zohomail.com; s=zohoarc; b=CG/Vs76UhmVjHfWTUhSx/F52dBXM7QjBMPPkWYGBWqaWJwPHVPxEUaEjW45Gk3/cSf7zPnA0ob4ecHfWcjt90V5Zl6QtF7duYA+QCTQqP0/+3mZxZZmKV5xgoXTcOCAwAucX/1Pdm70mWD2+bPPGXzau20a2XoGeCmlWGk+E/Ns= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780723082; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=dvtgUw0LsKgXWb3LBOponuFZWLxF4j1rwT2ki82oRjQ=; b=oLfu+g0XWUdcVXMzyaEuDcuJvgsKwUbRMLa/Uk5Z2uuG7bFgBk1oKCuw4htSrEyq9atcNtpLqfTIsR7ngEdLOqfB3LNT7+h49om8VD2adggmdA1n0Yh7gGt6Cf8nLdhq/Z2G0b0+5tmflng7o7w/tt2WqT7HIHoMXW1O0Jh72c4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780723082266520.8385178561394; Fri, 5 Jun 2026 22:18:02 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVjOy-0002cQ-SB; Sat, 06 Jun 2026 01:16:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjOr-0002RW-Py for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:16:50 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjOq-0008FQ-Br for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:16:49 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-554-6_-xlt9sOTOCsulcscj0_Q-1; Sat, 06 Jun 2026 01:16:44 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 87CEF18004A9 for ; Sat, 6 Jun 2026 05:16:43 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 345EC3000210; Sat, 6 Jun 2026 05:16:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780723007; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dvtgUw0LsKgXWb3LBOponuFZWLxF4j1rwT2ki82oRjQ=; b=dZm7xkM7n31Grmk9Iv8zNJa0WafLIiwGOb2GmZIz/MoJPm5GZLHaq26rHhJvjc/D2+FhqD b3M5W7GNbnCGiVPHIN//yAQTHsN0OLTD+5b8WMW65cRyV2bvC9B+l77RrwiFXQ4ksdj9sk jh4XVllqxW0la42Y4P2nhzxV3HvmE9g= X-MC-Unique: 6_-xlt9sOTOCsulcscj0_Q-1 X-Mimecast-MFC-AGG-ID: 6_-xlt9sOTOCsulcscj0_Q_1780723003 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 06 Jun 2026 09:15:44 +0400 Subject: [GIT PULL v2 12/23] net/filter: free old values in property setters MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260606-qom-tests-v2-12-55832d978a9f@redhat.com> References: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> In-Reply-To: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=1002; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=vSCX1oIavb9OdWbiPaCqHhj5OIrYz9DIRgOhx0so1ts=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqI6z0uT0igtgZTVqKuIeibNSbIBaln2vZQb7rz aQiPeYHsH2JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiOs9AAKCRDa6OEJdZac 5YCvEACkenz0GPDMVGfz4m4M1cM5J1t6FEZ2Ki8nkXkH8XR4OJV/mZ98Y3yMrJmCkX9ZEI3QtL7 nbay1He7CmJHVDb5D0TUIVA9fLmyrvMjbuFrfbqKSF638cho7wpWrS/BurS12ubh6aOoOo2ZZCE zksathB/R3TpwL+MLA+xzR206DM6DQL+wrOud9sc3LKuSD5tHt48NrCB/wnbnKVG7f7f6/1Qpqx RpqXJeqEM7FAFqK1BTFgThLMHCM8qjipNQQ/5Z15ywUi6ZeLTHrj4a7KfQOWlW0VCfWzsS4UOqV z+7jlNY+c6oUvZtNfF5GbkJKALl4wYRF1RWf9AqzYoRiOIuiglFLV5eZ1S1XbsC+DZM5HI6+YG9 KXFAj9sXJNkiXQ3oYy/KFf0XaBHkxsn6twFVyw4c0xyO50e3ikK86IKPWzlpf8ddWSijWbf1gqW dAt9AoLaEFffMcA2XWI95L2uzj/DRYfBpuLFodrCfXs05w8NhL7aIpzRoCeNPLmyQlcGj6p/mjI Tp6tJ0XO6dVe1t+0Jpbdg3inFzRH1c0MiozSHcgU0SuJ1f1ahzNujA9/Ag1pggR+ceBRowiEadA h6KBzbJiiBTSV61iTLUGowPkmHhFexWiEe3hvbdIJzZlg5++CUDt5F9eCP+Tl+K1p4YgFsXeoB4 hj2zZC6gbCeE3ng== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780723083752154100 netfilter_set_position and netfilter_set_netdev_id overwrote their respective fields with g_strdup without freeing the previous value, leaking memory on each property write. Fixes: fdccce459621 ("init/cleanup of netfilter object") Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- net/filter.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/filter.c b/net/filter.c index c7cc6615dc9..389f3b0bfef 100644 --- a/net/filter.c +++ b/net/filter.c @@ -130,6 +130,7 @@ static void netfilter_set_netdev_id(Object *obj, const = char *str, Error **errp) { NetFilterState *nf =3D NETFILTER(obj); =20 + g_free(nf->netdev_id); nf->netdev_id =3D g_strdup(str); } =20 @@ -182,6 +183,7 @@ static void netfilter_set_position(Object *obj, const c= har *str, Error **errp) { NetFilterState *nf =3D NETFILTER(obj); =20 + g_free(nf->position); nf->position =3D g_strdup(str); } =20 --=20 2.54.0 From nobody Sun Jun 7 22:18:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780723047; cv=none; d=zohomail.com; s=zohoarc; b=jSFpT+U3KmLpKBoaUnQ7rRKUtCxvQJuCYkQMgUUGSEoCk2suO2QtA6UUANAX0OvumKA68ajbNsSQovm9TKYRR6Zu0KyAli2ia4qRt+OBpcRIk7+VFMhi6coLFtTxQEUeOwkocVf6fEH7y4nuHmPR8wfnZL2oRmDaoB/4ocJeRSg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780723047; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=rI5KnFxPWO5qKPfQ5O52dnwywt+Y80Snw/Kjs9EvUlU=; b=gEMbU2bz/khUW7ANlU2Z1z4dh0O8fZRL0B+7nB0ikwAAx03yZf5YpKSrMr5F9iVwG61zjdj6RoYzu9Pqmj6AvtaaTZldLLcyiK9RwmjvldFGpH/Ehpf4oUszF8CKmXx9sgN2QacOYwMlJCJv11ISL/c7mV3OgRZ0XqBfoMy1QIk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178072304779559.892727996837834; Fri, 5 Jun 2026 22:17:27 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVjP2-0002kq-PV; Sat, 06 Jun 2026 01:17:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjOv-0002d5-Pi for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:16:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjOu-0008Fd-4m for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:16:53 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-221-BMWnyOKpMwyOl4GGekx9yQ-1; Sat, 06 Jun 2026 01:16:49 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0BE811800473 for ; Sat, 6 Jun 2026 05:16:49 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 363F6763; Sat, 6 Jun 2026 05:16:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780723011; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rI5KnFxPWO5qKPfQ5O52dnwywt+Y80Snw/Kjs9EvUlU=; b=eXAQ5n04PxBeRbZQwcClq/zA2FCiP9WP8qkmZvu8cKL28PzpD/ElUPmkULWZBKRoUD8ngd n8kd9uIzRmQ3SKGcAUuWD7tL/zV5OJz921rnqm1Il3DfcciwhSvW4zKmisfzYRiLJDQz3z RiXOfnnOBGD2TCoUPh1aaMuz0OsYTTo= X-MC-Unique: BMWnyOKpMwyOl4GGekx9yQ-1 X-Mimecast-MFC-AGG-ID: BMWnyOKpMwyOl4GGekx9yQ_1780723009 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 06 Jun 2026 09:15:45 +0400 Subject: [GIT PULL v2 13/23] target/i386/sev: add finalize functions and fix leaking setters MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260606-qom-tests-v2-13-55832d978a9f@redhat.com> References: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> In-Reply-To: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=4141; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=KGDSEH4kXjPQ4/HoJgAVzmsrW3Gsd6zdda1I7EVwqgE=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqI6z0tFI31t+V3+ANWsJ65VES1gSHwL/qq4Jp7 QXj7OqH/POJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiOs9AAKCRDa6OEJdZac 5TLzEACnz8Mz9QaDv01DsyjZWz4XrC30zqVFCyAY+HemFuQnUUn+97SW1l73r1TLdtn56QXYJTE PKbahIvOwV1RMPjseVp0puChuTl29nAhHosU8dvNvXwfOGFsWRTnjTdozc2PUiWkOodqHHtcq8q BdZ5VckTwPR3jLy/gY3ezcZXw6iXlqCsLtmEThvI47GD2sZnYgFquBWybPI/r6+G0PI/iUMNPKg 7PtVclzpj89FpY5jlGfEPFQ8cnuQTFg7FJefOn9suMoSfdnp0e7q1k6DANDQiA+aHiTdEJeHDw4 mWQ+Dph1AUHf6VN3OqsJ1pFIaDxKrBJhzuSS7TdOPwe/fB/xD50Jf2SKU+DYa9N3V93FATvx/lW SzYoOHXpBwFw6y1FkbbSgc0D34fAHIQiwluqT/GJPTBVPhVmIFy7phwxo+Udi1rvh9JgSTRmGZB HKX4IkcPBL6cptugFYYwTWIP1wHkTKLtttvjI9gx3dN+S/LuleewR4AcHuVMlUjKIG4/LFycoWO 88OnBilQqEh9kCp+XT7pKuG+fabes5JskvyW9q3JQLVLiUqh6asWjyukRcxj6g8XEDRDTP5vqv4 UrygWSZ//WhUoeiWEXGqE4WnjFSIiL+5P5eye/ZUkncn0fOt5Opxq+zhklUGSwn/VND1qSHuwdS eUgBcl948CwGk+A== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780723049419158500 None of the three SEV types (sev-common, sev-guest, sev-snp-guest) had instance_finalize functions, so all string fields allocated during init or by property setters were leaked on object destruction. Add sev_common_finalize, sev_guest_finalize, and sev_snp_guest_finalize to free the allocated fields. Also fix sev_common_set_sev_device, sev_guest_set_dh_cert_file, and sev_guest_set_session_file to free the old value before replacing it. Fixes: a9b4942f485 ("target/i386: add Secure Encrypted Virtualization (SEV) object") Fixes: 7b34df44260 ("i386/sev: Introduce 'sev-snp-guest' object") Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- target/i386/sev.c | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/target/i386/sev.c b/target/i386/sev.c index b44b5a1c2b9..99cf30806be 100644 --- a/target/i386/sev.c +++ b/target/i386/sev.c @@ -2526,6 +2526,7 @@ sev_common_get_sev_device(Object *obj, Error **errp) static void sev_common_set_sev_device(Object *obj, const char *value, Error **errp) { + g_free(SEV_COMMON(obj)->sev_device); SEV_COMMON(obj)->sev_device =3D g_strdup(value); } =20 @@ -2830,12 +2831,21 @@ sev_common_instance_init(Object *obj) QTAILQ_INIT(&sev_common->launch_vmsa); } =20 +static void +sev_common_finalize(Object *obj) +{ + SevCommonState *sev_common =3D SEV_COMMON(obj); + + g_free(sev_common->sev_device); +} + /* sev guest info common to sev/sev-es/sev-snp */ static const TypeInfo sev_common_info =3D { .parent =3D TYPE_X86_CONFIDENTIAL_GUEST, .name =3D TYPE_SEV_COMMON, .instance_size =3D sizeof(SevCommonState), .instance_init =3D sev_common_instance_init, + .instance_finalize =3D sev_common_finalize, .class_size =3D sizeof(SevCommonStateClass), .class_init =3D sev_common_class_init, .abstract =3D true, @@ -2855,6 +2865,7 @@ sev_guest_get_dh_cert_file(Object *obj, Error **errp) static void sev_guest_set_dh_cert_file(Object *obj, const char *value, Error **errp) { + g_free(SEV_GUEST(obj)->dh_cert_file); SEV_GUEST(obj)->dh_cert_file =3D g_strdup(value); } =20 @@ -2869,6 +2880,7 @@ sev_guest_get_session_file(Object *obj, Error **errp) static void sev_guest_set_session_file(Object *obj, const char *value, Error **errp) { + g_free(SEV_GUEST(obj)->session_file); SEV_GUEST(obj)->session_file =3D g_strdup(value); } =20 @@ -2936,12 +2948,23 @@ sev_guest_instance_init(Object *obj) sev_guest->legacy_vm_type =3D ON_OFF_AUTO_AUTO; } =20 +static void +sev_guest_finalize(Object *obj) +{ + SevGuestState *sev_guest =3D SEV_GUEST(obj); + + g_free(sev_guest->dh_cert_file); + g_free(sev_guest->session_file); + g_free(sev_guest->measurement); +} + /* guest info specific sev/sev-es */ static const TypeInfo sev_guest_info =3D { .parent =3D TYPE_SEV_COMMON, .name =3D TYPE_SEV_GUEST, .instance_size =3D sizeof(SevGuestState), .instance_init =3D sev_guest_instance_init, + .instance_finalize =3D sev_guest_finalize, .class_init =3D sev_guest_class_init, }; =20 @@ -3194,6 +3217,19 @@ sev_snp_guest_instance_init(Object *obj) sev_snp_guest->kvm_start_conf.policy =3D DEFAULT_SEV_SNP_POLICY; } =20 +static void +sev_snp_guest_finalize(Object *obj) +{ + SevSnpGuestState *sev_snp_guest =3D SEV_SNP_GUEST(obj); + + g_free(sev_snp_guest->guest_visible_workarounds); + g_free(sev_snp_guest->id_block_base64); + g_free(sev_snp_guest->id_block); + g_free(sev_snp_guest->id_auth_base64); + g_free(sev_snp_guest->id_auth); + g_free(sev_snp_guest->host_data); +} + /* guest info specific to sev-snp */ static const TypeInfo sev_snp_guest_info =3D { .parent =3D TYPE_SEV_COMMON, @@ -3201,6 +3237,7 @@ static const TypeInfo sev_snp_guest_info =3D { .instance_size =3D sizeof(SevSnpGuestState), .class_init =3D sev_snp_guest_class_init, .instance_init =3D sev_snp_guest_instance_init, + .instance_finalize =3D sev_snp_guest_finalize, }; =20 static void --=20 2.54.0 From nobody Sun Jun 7 22:18:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780723051; cv=none; d=zohomail.com; s=zohoarc; b=CtLduUmj0h1ZNF8ut8NCY+B8DMIaRfuHGUq/kf20I2WvHsME+dqLUBQwNJNmU5xEdVSTORljnzDrze0co3Q49XySkoAa3zKNIKpMKheZRO1UYJxbd08XgiS21FoOo1C1GRFY8DeGOLkRhqD22aRgtDpksVsDBZRDxumIuLHgd98= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780723051; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=oChfGW5Tq+2XS1SV5t1cQUIYoRVR7500LonYw5rznpg=; b=Ycj7zk1YydcjlxxYR1aa4AhNa6bAxfCQUEMaTN6Q5+pBXzxAkXnWwt2muitLU/pkGKX9QKlbOhPJr7cmHcePZtd2X//5A1GvtNTF9B5/S43+qeAygp+KL79ESA7K1vAGo6ed0IrQzuIB2CNxZWO9072kzHtofcXXplhFuCR4Zcs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780723051243613.894416047861; Fri, 5 Jun 2026 22:17:31 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVjP5-0002qv-5r; Sat, 06 Jun 2026 01:17:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjP0-0002jZ-7L for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:16:58 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjOy-0008GF-Pc for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:16:57 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-656-v0fzHXVePCih6PZ8VteIAQ-1; Sat, 06 Jun 2026 01:16:54 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0B0DB1800345 for ; Sat, 6 Jun 2026 05:16:54 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0309827A; Sat, 6 Jun 2026 05:16:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780723016; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oChfGW5Tq+2XS1SV5t1cQUIYoRVR7500LonYw5rznpg=; b=b2/6pe38MscO8lF95LjHCFL4yRuS26LKK0aQwWulD49Xd8UcCV97Jyr4sl8Rn6ik6rU6hy 28h6raV50VsUdCtksGNQjTjHAGZZqTIsvNGaw2W0dWFSVdiDcKh6oeQ12L1Q1LEW3if0Dz kOTZjR3WBSBuNcIiWSupHN37e8qEx3Q= X-MC-Unique: v0fzHXVePCih6PZ8VteIAQ-1 X-Mimecast-MFC-AGG-ID: v0fzHXVePCih6PZ8VteIAQ_1780723014 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 06 Jun 2026 09:15:46 +0400 Subject: [GIT PULL v2 14/23] target/i386/kvm/tdx: free strings in tdx_guest_finalize MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260606-qom-tests-v2-14-55832d978a9f@redhat.com> References: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> In-Reply-To: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=893; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=DafxdRB7/MLkueWJrLE2w1Qd3zyBZmU4Trf2EjVE458=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqI6z1c5DUMYA1MTkgkGDX9ofxiIPNp3JP6u3AM wd8hyChLy6JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiOs9QAKCRDa6OEJdZac 5cqpD/9e53MDmDNaLjlNUrxybvdST10gneJgVnyGHyRhmk8KwmmTV8aDtAScg0T19aMqHNkgupJ VKgRadhtHGSbXcYcNODy/m/dnXMjk2FakbbPLX/RlXQOGwRHKZ0rN/O/iYI742210QlaxUkI0dU vzUQFsWziqROKpT1ZtU0/xmy+rhRRovR6W7ijCbcRrXoBE/vTfk3efoMHqhFFCV92+v8qNNGkJc yUokz53ma22Lm0eJvNUjI170gonKWopOdGOlVpViWbvzH/Gkm015RHKth+q1MmI3W40TKmL+XRO Af9V94wnCLIRDU1atA8Nd4+XJkTV3adZVTGBw1eOZW6lggkklS/5AjOs1DIhowhyUrRSMgBaG2u 91gBvz35vtJf2kqDmZUm4KRxxRzLRNtPm/e0fv/o+VhFG0jvMcQ8AyCWXkMn+gdAiJwFVTeaubM 3WQJ4Sw8lKB9r5J6YGeirCYVHzIeN3+ELBfyccou7KDjrFbtRqG+ZGAcrinUBMDmTChLquZMx/7 FYzX2658pGC8B8iBPrRTQyxENwhQugVO+a26rDhnjtRNEcjTMwgbdKl7J1fH2n00T4KvRsbYbeI gXn9yJu7ecavv0eXsRgo/aaFrhApUR2aQFLZqRJ9bEoVWDbBS5EYfD3N2mlLc2SjAlXjpuBA24Z 1UExoP4eDGenonQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780723053326154100 tdx_guest_finalize was empty, so mrconfigid, mrowner, and mrownerconfig set by property setters were never freed. Fixes: d05a0858cf87 ("i386/tdx: Support user configurable mrconfigid/mrowne= r/mrownerconfig") Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- target/i386/kvm/tdx.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/target/i386/kvm/tdx.c b/target/i386/kvm/tdx.c index 4714c9d514e..df46fce7693 100644 --- a/target/i386/kvm/tdx.c +++ b/target/i386/kvm/tdx.c @@ -1585,6 +1585,11 @@ static void tdx_guest_init(Object *obj) =20 static void tdx_guest_finalize(Object *obj) { + TdxGuest *tdx =3D TDX_GUEST(obj); + + g_free(tdx->mrconfigid); + g_free(tdx->mrowner); + g_free(tdx->mrownerconfig); } =20 static ResettableState *tdx_reset_state(Object *obj) --=20 2.54.0 From nobody Sun Jun 7 22:18:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780723130; cv=none; d=zohomail.com; s=zohoarc; b=WnYLT+08sCjJ+r37dB16GEUmUIa5JSJp8VxoImJl4x+WhuQeH8npHpZLtGXo0jxzlD8XRmEuOCjzxMpvCQ4Naavy1Fh1ZJZzx5uNhDitUedBiXrMLbsPaakfzl/qzW+2s/q5wlQUFwAWbhlX7Sa40aE8dZWj4qT1EPnYIH10ruc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780723130; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=flPmDRwJi+ybUNe2kHFSb0m1RU2KLtvltS5ncicUaW0=; b=KX4vMg4ANRE43BQrvmGpFTIXEnK01Bxrxuv7MGKfWvZsTPfxp6NrlE9+zbc1tX/M5XxaVJPioWrbBwqz8/yjaeAh0ha6wBvKSSf1GXP/rzRsXp5cqBeZBkNd6Gjw+fJjGH0CtSL4dCPjbVQ5b2TD174D8bYtpDoLs8aHaDwKJiU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780723130044983.9167784541502; Fri, 5 Jun 2026 22:18:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVjPD-0003Kc-JM; Sat, 06 Jun 2026 01:17:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjP7-0002tU-1a for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:17:06 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjP4-0008Io-7i for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:17:03 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-103-fmVqxIflOKe5IAeR6YQBaQ-1; Sat, 06 Jun 2026 01:17:00 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 620F4180047F for ; Sat, 6 Jun 2026 05:16:59 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id F33BD195608E; Sat, 6 Jun 2026 05:16:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780723021; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=flPmDRwJi+ybUNe2kHFSb0m1RU2KLtvltS5ncicUaW0=; b=hraSFHqbGKe4XLlY7wJqy49L3urXE6BkBM5E+2w/dYwBvKA7kjLPqAWtsf0OsBywkno34t pVcPADdK7Z2PdNWQjGEMZJbKU7Jl2xSfyjtkoBgZPQCff5lAwR1XPcvzOV8aAxwynvByt5 vtJbRWCRKOHbyh2xbfNETvXR+1+iRG8= X-MC-Unique: fmVqxIflOKe5IAeR6YQBaQ-1 X-Mimecast-MFC-AGG-ID: fmVqxIflOKe5IAeR6YQBaQ_1780723019 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 06 Jun 2026 09:15:47 +0400 Subject: [GIT PULL v2 15/23] hw/i386/nitro_enclave: add instance finalize MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260606-qom-tests-v2-15-55832d978a9f@redhat.com> References: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> In-Reply-To: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=1483; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=3C7niU2OJQvZnNEzM2kL0E6yy2/Uxqq6Etx4xtM0Tsk=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqI6z1C+1pKyOiXXPxo684kcaeIwB11g/4Y7f48 5/qr3V6W2eJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiOs9QAKCRDa6OEJdZac 5aLeD/9+cvTDiRpLG0EFgOnzbBGHC6wsVrowTQ8kziakYf6BP4xJLSQlIAZyjFubgO6r94Jnugb 2MGtCofWZMXgfkoqbd5M9LDVmwhfdYufWoyBbFC+pbVL3pQAFNyjNjcVvfJB5XCfOYaNAF8QvL7 i9jV39Ek8iXpQPJFqmi2kjcyZ39yfJqIbpqJQCdPEQ9k6uQvcxbw0UdOSHVxBWoVKWuD21wwRTU 6EcfBZWsYnX2dLj7GtFtpTuItVHAawOdvLTDeaJ7zH+K2n4Z6GfcXeusel4MKuibkGqlMBRCzQu +mF8lL3Zjig6p4hg/8EaOZMiSk2DyQYfRpaNSPl6VAmbcCIsL+UXtfm5YDZgsdwD3tlL3flmuMn Ee0akGpIibD3zfLsLP9g/jfFz07h6I5Qs96tYcU26zM1VwvygUfitqL/pNeiwO7iiL+u1J1sndi kBZBeAhYXRcHoMAc3oGsYEedFbbfho7gA0gptqfJVuU9jIZM562d/0O44jsi4Jj6v2chuFKlJnc vIcLTsS1jmdh1+RNq0Xjy2PTSGK/ZRfiIAQyqKODqVTDVzzrImhV1Vf/rGKxbvyW4rpKKeiHMoL eTbetPUuPWHqqjOy/RBpSvTwZ6jtKeKkFZst/KwMTFXG60cO9aGY63IRITdMKaBwHeRRX4UeP+m 5FrcAzp5mb+8gVQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780723131674158500 Property setter strings (vsock, id, parent_role, parent_id) were never freed because nitro_enclave_machine_info had no instance_finalize. Fixes: f1826463d2e8 ("machine/nitro-enclave: New machine type for AWS Nitro= Enclaves") Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/i386/nitro_enclave.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/hw/i386/nitro_enclave.c b/hw/i386/nitro_enclave.c index a29f0044d0e..1ce9ee3358a 100644 --- a/hw/i386/nitro_enclave.c +++ b/hw/i386/nitro_enclave.c @@ -337,11 +337,22 @@ static void nitro_enclave_class_init(ObjectClass *oc,= const void *data) "Set parent instance identifier"= ); } =20 +static void nitro_enclave_machine_finalize(Object *obj) +{ + NitroEnclaveMachineState *nems =3D NITRO_ENCLAVE_MACHINE(obj); + + g_free(nems->vsock); + g_free(nems->id); + g_free(nems->parent_role); + g_free(nems->parent_id); +} + static const TypeInfo nitro_enclave_machine_info =3D { .name =3D TYPE_NITRO_ENCLAVE_MACHINE, .parent =3D TYPE_MICROVM_MACHINE, .instance_size =3D sizeof(NitroEnclaveMachineState), .instance_init =3D nitro_enclave_machine_initfn, + .instance_finalize =3D nitro_enclave_machine_finalize, .class_size =3D sizeof(NitroEnclaveMachineClass), .class_init =3D nitro_enclave_class_init, }; --=20 2.54.0 From nobody Sun Jun 7 22:18:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780723144; cv=none; d=zohomail.com; s=zohoarc; b=MGOytWrQLeVaiNlc605CFVFgt9mQNJ+TFW0CFWTKx5s1JbEIlu7Y2ZcUsYceVjc9RGC2kgrrGuIr/H2Ni74VKpDnBM/X0zzU08Spw2KxyZiOqo7lEQKTBGUOSytXlyvQB8Gb42IsgQyk1qUa/s5QTF+yaKeNVcxwx1+frHh1I2w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780723144; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=vs+pOjW26KjxQCHZrQ+kCzdjFkWO5ZRcdNEGFNTZkO4=; b=CkJwhmomPaZ8vGqtka3sT72fz72dN4VGk0tkHKy9FrjfsMCVJwX8sRc8URS81IajgQPwzEO1UAw9zOGSwQBLlj87PhJARd6o/C1/1qQIa05KzY3+0NqQD6LzbglEFlYZAc4OKJApigKJedwI2b3TJ1to6M2lpZ0SGbMqYl4Onv0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780723144327290.97936108632985; Fri, 5 Jun 2026 22:19:04 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVjPD-0003Ho-7k; Sat, 06 Jun 2026 01:17:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjPB-00037D-9n for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:17:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjP9-0008JU-QN for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:17:08 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-573-i7eXIUnMMeSG2wCiIUi0ew-1; Sat, 06 Jun 2026 01:17:05 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9A786195608F for ; Sat, 6 Jun 2026 05:17:04 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 56589180049F; Sat, 6 Jun 2026 05:17:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780723027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vs+pOjW26KjxQCHZrQ+kCzdjFkWO5ZRcdNEGFNTZkO4=; b=KWdzU59N9J9kKal0CvV+PEKaXHo5xrn8QGggXNNbB3O131bHomRQwQ0ah8FHgABbut3xg9 KlhUW+QykcT22glDpCEVheBwO2C60SdIyCCNl9kUK9Mjv04h6Un4RUzsmgsxLrs5xQfNuj fUu/ko3swqMuaBqMUASR/NidC61V4ws= X-MC-Unique: i7eXIUnMMeSG2wCiIUi0ew-1 X-Mimecast-MFC-AGG-ID: i7eXIUnMMeSG2wCiIUi0ew_1780723024 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 06 Jun 2026 09:15:48 +0400 Subject: [GIT PULL v2 16/23] hw/i386/pc: free pcspk on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260606-qom-tests-v2-16-55832d978a9f@redhat.com> References: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> In-Reply-To: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=1290; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=GcZTfkVfLUK9g6SdJBjC2sL2vzj7syFt54aMh0Kvqn4=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqI6z1p7dhUkeGL1FLyS8HaAzJpDmEn2SEhk/sS sI2UwAAgJCJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiOs9QAKCRDa6OEJdZac 5WfkEACy/JEeXX+4FrQl1jX8TiB1vsFpMvIfLCfq1kzVfgVw+Dt1rLB5uZgex+wIr1pL19InNTR di8VFsaGzk8IF2z7neTuQOf+Sf7+bt0uBohyenQJU6sGU6VzQKgghcTRwDQN1cwiv441Uk1YlTk UmXV/Qu66igPBPuMzne90IVklzCNqzZ6en9VFJwc7HIR6XyOLqHUm5mbqVrCH+BkuxuY0uoWnRr 3BWpcbloBsFstVMZLplQ046EI9+erkqIcAbWn81CX1HKgElUN0cNBt2mDXrZ0meZjS1fL7OfQ5X KbooWvcXkL4klhBzgwo3YSR/dqF0gwG2UwoW9/a0DFvfGrpfHRC76al0ZcGIzeimGPCfFMgP8eo TkvlqgZUY1SvQSNrIbmY11qqEtw02d3LJEBzIolSH/HLCXLWoKdppAAvW6sIp9QkC5InxPNSpqE a3ZsEI5ehYuegR3z0LbIG6A428mqoBr9ieJTRpQ38MAIXedZJ+b5BLb6QBCCEDTiG55oYliez/2 NrFrypj0E6MSYYDhd7qEqyptlYpXfPCsXw799LtJ3pe7ahmzBleKp0/onZzuYP1Lo402p/MoaTO EQFSbKPgl530SSYwZX+Ao9UcxV4LALEnvHoZD3YVDbgOmDQdYPr1k15HNZ5a6275CnYq0Edcutf MKt77HyBWB7R+DQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780723146639154100 Add pc_machine_finalize() to unref the pcspk device when it was never realized. Once realized, the bus owns it and no action is needed. Fixes: 6b8d1416482f ("audio: create pcspk device early") Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/i386/pc.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 2ecad3c503f..7b6ad97e5a9 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1610,6 +1610,15 @@ static void pc_machine_initfn(Object *obj) } } =20 +static void pc_machine_finalize(Object *obj) +{ + PCMachineState *pcms =3D PC_MACHINE(obj); + + if (pcms->pcspk && !qdev_is_realized(DEVICE(pcms->pcspk))) { + object_unref(OBJECT(pcms->pcspk)); + } +} + static void pc_machine_reset(MachineState *machine, ResetType type) { CPUState *cs; @@ -1748,6 +1757,7 @@ static const TypeInfo pc_machine_info =3D { .abstract =3D true, .instance_size =3D sizeof(PCMachineState), .instance_init =3D pc_machine_initfn, + .instance_finalize =3D pc_machine_finalize, .class_size =3D sizeof(PCMachineClass), .class_init =3D pc_machine_class_init, .interfaces =3D (const InterfaceInfo[]) { --=20 2.54.0 From nobody Sun Jun 7 22:18:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780723062; cv=none; d=zohomail.com; s=zohoarc; b=I5mMCiZ5JVUABCT+V6Yg5sGhQLWimjSzM6/4AveVvXX12q2rG2v2agH/x9UBdTgkBDZQlpCrciyCLMyN62bHVNb/YY+Ba9GOGb+zjmhZCtQY7d1TJQpbhRyln+ezYBTHWpXd+4DRmf7zQ2cNiqTgoQEFNSD1GVeWq0bYCte3CAc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780723062; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=0HsSS9H0XnFqDg98btc/iipFx5pPynADB1oSYq6cxGQ=; b=kbAtoNaQz7iEUydHrShz+v9/LWpDCZ0a2XDTztJRMYSVvUwEF1ZECcTbQJW2ZS/+v6oEh9wx4ZGhuv9tzh8WfmY4I8N7FHbFfpTuP5UvCA768dy63XNWL/o04ZQtcRZoE6cRC+jrhrG9A/R7aNPHMqoi8pMOBkk/cPyhGvD9F8k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780723062754618.2290149265386; Fri, 5 Jun 2026 22:17:42 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVjPJ-00044d-Tn; Sat, 06 Jun 2026 01:17:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjPH-0003qQ-Pb for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:17:15 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjPG-0008Kv-8q for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:17:15 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-643-Hsz2wV-HOQGDq7dr40xs7g-1; Sat, 06 Jun 2026 01:17:10 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8E2081800358 for ; Sat, 6 Jun 2026 05:17:09 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A5B51195608E; Sat, 6 Jun 2026 05:17:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780723033; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0HsSS9H0XnFqDg98btc/iipFx5pPynADB1oSYq6cxGQ=; b=bEWi47XFjORK1J9M4J390xiU//V7pmlbnIqo+vIC93kX+D49wx7V+viUVGg0GJyRlSltHd HF2vY7/TVRKb/cM3Xe4eJDaDI9rS9H6lw9m/v0Lao03Eecw5eEA3Ui8eUSKtzPxUzvDadr 88nQvJlYiL/DwaLgYgZusUaeV6bVOl8= X-MC-Unique: Hsz2wV-HOQGDq7dr40xs7g-1 X-Mimecast-MFC-AGG-ID: Hsz2wV-HOQGDq7dr40xs7g_1780723029 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 06 Jun 2026 09:15:49 +0400 Subject: [GIT PULL v2 17/23] hw/tpm: free PPI buffer on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260606-qom-tests-v2-17-55832d978a9f@redhat.com> References: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> In-Reply-To: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=1310; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=5CtS+EWJo3M/jWSkTkfccFTnWRkzlJxRsPCSKv4FqPs=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqI6z1CIhBL/yonnrB+fZWX8YtM8Nds9tzB8LMd xcDtRWoFbiJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiOs9QAKCRDa6OEJdZac 5YAZD/9tVhnbJk/LBgH6qKoiAgQ3lwq0UfEBc+PMnBqGQ+9j8ducKxvGOsiMUXLxtS+l8q8wIK9 LYbkFyR3pnG5g7SfyhP9Na7oA7SYmWywgcFtBGpZ5+z8UJEGsI5Ualk0+rl0ck8MXQi9scJnKm9 7hE1rNR+c2RR3XY8kiVHYPWd0yx4JskgKSpfdjvHt0jpERkKUNhp50VcZKq8KZis1ruHAroQFlt kx0xaP/ZdGVjIdFHNYVWFGxw7kDtTwQ9WhNHUqa2x0ACUKkx0pEudWnD+zePJPQuTGLoysua98g 376OfPqu67dPxL01WQkE0cIok0xkyklcz9LpAn+RlTmWvnviNtKcd7rdfBq5AxPYSbnJSC8c4eu QkTAcK2oz4EAmCG74sOneie6MclSKVZsvvAW0yEhWdFjfG83AfYNjiOTYxtYlOYroq2m2TwG5HD 78tPGxGbSz+cr1IkWud1s1zaJGqkfFyArG+tq0Opp1Mi0vAltgLubMOZeQHDpy1WmuUPCBg8NU7 q4m942/5Rr+otliyEpBO2O3Uw5mc4Ia/ZDKS/D91WHSyCG39yVplt8XZldRkwYjbtk5YFrv2Mck wDwnR5I5ovhC2mbURfd4U39iD85dHHTj+Z6lheWTVnqkcRPqlbcXJ5w5aYu6UoXwtLJkLdGXySZ gb+kApCn31MAK5A== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780723063542154100 The PPI buffer is allocated with qemu_memalign() in instance_init but never freed when the device is destroyed. Fixes: 46cd2c1050f0 ("hw/tpm: add PPI support to tpm-tis-device for ARM64 v= irt") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Stefan Berger --- hw/tpm/tpm_tis_sysbus.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/hw/tpm/tpm_tis_sysbus.c b/hw/tpm/tpm_tis_sysbus.c index f9cd1c8b5c6..16bb17874b8 100644 --- a/hw/tpm/tpm_tis_sysbus.c +++ b/hw/tpm/tpm_tis_sysbus.c @@ -148,11 +148,20 @@ static void tpm_tis_sysbus_class_init(ObjectClass *kl= ass, const void *data) set_bit(DEVICE_CATEGORY_MISC, dc->categories); } =20 +static void tpm_tis_sysbus_finalize(Object *obj) +{ + TPMStateSysBus *sbdev =3D TPM_TIS_SYSBUS(obj); + TPMState *s =3D &sbdev->state; + + qemu_vfree(s->ppi.buf); +} + static const TypeInfo tpm_tis_sysbus_info =3D { .name =3D TYPE_TPM_TIS_SYSBUS, .parent =3D TYPE_DYNAMIC_SYS_BUS_DEVICE, .instance_size =3D sizeof(TPMStateSysBus), .instance_init =3D tpm_tis_sysbus_initfn, + .instance_finalize =3D tpm_tis_sysbus_finalize, .class_init =3D tpm_tis_sysbus_class_init, .interfaces =3D (const InterfaceInfo[]) { { TYPE_TPM_IF }, --=20 2.54.0 From nobody Sun Jun 7 22:18:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780723124; cv=none; d=zohomail.com; s=zohoarc; b=UBiXPvaXys8joXueSl9lS85Q3AXv7AmsjB6imjWe7a7rVOWxebk615TjHXFbHxWT3DawxYm9RMbPbJvzOdx+N3SzTpBzr94HfEPZwkCHKQx7RzOaicNAYCh1qLWnd4aBTDBU0qybMG1FTh7G341rj9ShX+TyJEKHeTjJfYtvf1k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780723124; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ChO/3Bdzy1ataNflAM07S9oKMcRpR+opteLb5ymzCsk=; b=j6pZTUThSRA/I/Jhsz5PQuTdKgqwuBD+KZkxZvLburTzmuBr686+uliql6UAEg1sR+ExD3CIdU5nZqNqY9a/DQbdqm2wgJLM9hCFrY3Y1jXZG4J5MbP3ySnG/tD+vxuRC2tS3aCFiNfqOfkKFmBwULmGIqtqJRnlBqpAZ5mx7tc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780723124576565.6728517885008; Fri, 5 Jun 2026 22:18:44 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVjPO-0004ZP-Ba; Sat, 06 Jun 2026 01:17:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjPM-0004Hm-4o for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:17:20 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjPK-0008LD-3l for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:17:19 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-344-xsvch4XrNEmbde6OQB7ZDw-1; Sat, 06 Jun 2026 01:17:16 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4F5341800473 for ; Sat, 6 Jun 2026 05:17:15 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id F286A300022D; Sat, 6 Jun 2026 05:17:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780723037; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ChO/3Bdzy1ataNflAM07S9oKMcRpR+opteLb5ymzCsk=; b=O9XG8KUKpyveCuk6FvEhb78uKPTYCvTcKbPfXjJOozsLeKjfjNBYKAD424fB1jAXC4+A3T tKVb5fBZcbjmgGsxN9ybaWyILeMCwD+Jcwa1jymngXFDT4LapUVr6PoqpM69xF11FtqsRo hKvHjhW7xs7Lae/0RBLYbbopRro3oq0= X-MC-Unique: xsvch4XrNEmbde6OQB7ZDw-1 X-Mimecast-MFC-AGG-ID: xsvch4XrNEmbde6OQB7ZDw_1780723035 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 06 Jun 2026 09:15:50 +0400 Subject: [GIT PULL v2 18/23] hw/loongarch/virt: free flash devices and OEM strings on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260606-qom-tests-v2-18-55832d978a9f@redhat.com> References: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> In-Reply-To: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=1821; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=O20pvfV7LycxXxxIqAxpoTODskHXvK4B1EMEAyeU4tk=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqI6z1No10PrCy6sKXhKgzydh2xAml12bWBFotl 4zlAvO2ukWJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiOs9QAKCRDa6OEJdZac 5c9ID/0a/euTBsHrgDDCZkN701Eaie4oPpf5AWNO40tK7foKO0xNh01Pv11Q8CZdA1dMZS7TPmm zRPO87iBx7+x55UROAFC+ki9PiTSkbK3z0s1h6ht0fiB7mSEbkc4qhGQIq7QTX2cGxo/3ao/MLk H0qskwZXj8aiCkyeMQyoW62jkKGlnDmAGzyoBC2MtzdCdad2RRgixIJacCAO+HJfMEHqBepbj8U G6rWl4Jf37/Isx0aFX4js0pfQokh6s8Ak6mCPfnn2/wuUf3Z1tEmXymhcDg2gzG9x4LCHmBqU6V DuFGFKmuYZvG0xx8q3UW2F3i+Pb/+H1+kNoK6rlZEoh28lOPuI5dEtVGXEbbWwjfhbNiMY8J/4s 3GbusHREhclYwUiWs+ZwS6wCZaCdvnZvFSO81V9oc0XTXfjb+s9PAM56T6Ai+1yiBF58sa9tLEL 3Wn/MsSeWl1RUyiWD2ap6baR/VRVrQYJLvnOyboILtSI7K5ASsrItBlF46lmzdK7Nd0NJAbGv2n BFGVr0zVtYpgjuUzk+lWKrRPUgkebnLUT4jqJM8JbWAhU4hAFogn4uqT5qJN8pEP+o7w67hZTLN un+NTf1rJ092zIRq5a0HIub9vkM9jmcabQ8FsmmLukgCz5hxas5RlOmq1r27ZoQmW3jEbF9JbZo d9R8gyJHFoytwZQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780723125685158500 Flash devices created in virt_initfn() via qdev_new() hold an extra reference that is only dropped on sysbus_realize_and_unref(). When the machine is destroyed before realization, the flash objects leak. Also, the oem_id and oem_table_id strings from g_strndup() are never freed. Fixes: 445c9c645 ("hw/loongarch/virt: Allow user to customize OEM ID and OE= M table ID") Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/loongarch/virt.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c index f68ccdb12b7..6693dea647b 100644 --- a/hw/loongarch/virt.c +++ b/hw/loongarch/virt.c @@ -1566,6 +1566,19 @@ static void virt_class_init(ObjectClass *oc, const v= oid *data) #define DEFINE_VIRT_MACHINE(major, minor) \ DEFINE_VIRT_MACHINE_VERSION(false, major, minor) =20 +static void virt_instance_finalize(Object *obj) +{ + LoongArchVirtMachineState *lvms =3D LOONGARCH_VIRT_MACHINE(obj); + + for (int i =3D 0; i < ARRAY_SIZE(lvms->flash); i++) { + if (lvms->flash[i] && !qdev_is_realized(DEVICE(lvms->flash[i]))) { + object_unref(OBJECT(lvms->flash[i])); + } + } + g_free(lvms->oem_id); + g_free(lvms->oem_table_id); +} + static const TypeInfo virt_machine_info =3D { .name =3D TYPE_LOONGARCH_VIRT_MACHINE, .parent =3D TYPE_MACHINE, @@ -1573,6 +1586,7 @@ static const TypeInfo virt_machine_info =3D { .instance_size =3D sizeof(LoongArchVirtMachineState), .class_init =3D virt_class_init, .instance_init =3D virt_initfn, + .instance_finalize =3D virt_instance_finalize, .interfaces =3D (InterfaceInfo[]) { { TYPE_HOTPLUG_HANDLER }, { } --=20 2.54.0 From nobody Sun Jun 7 22:18:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780723076; cv=none; d=zohomail.com; s=zohoarc; b=CJmFY/yb5fAOH/QjVPippS0kaYPqcnUm/ZgLx+8w56fq+CC9uo+1NkI3R3JrslyszlsGpoyK0tt3CM1u8sKD+JgSfAM87cwlHUcyQhWtwoxH+T4cVcVoWg8vxkdMIzUhQFI0f56shBlMYjTyXqmGyROMjDICX8g9SEH7gANI/M0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780723076; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=xzKJ/IpdkG01bM1txdqjhoLFTRAUk3+pG2IUFauAHiA=; b=CLlq+KqPf6MhUJykd/CinaJdFdbUjDouerNYMGXhPHMy8bkbwAX/0i/eZo0uaffjAxodqTNcuqatzYN3cnN90jKZffz4Vzwn85AuV2BXSwUjCdzelXxu1QICzndfNOxIyTmgZ+cp6m3Qj8FO94oa6tyAq8tS9/kmuva3N+lS8Io= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780723076326295.05342651123965; Fri, 5 Jun 2026 22:17:56 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVjPT-0005EA-W4; Sat, 06 Jun 2026 01:17:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjPR-0004xA-C0 for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:17:25 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjPP-0008Mn-PZ for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:17:25 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-361-r78MoDlGMfCnWn5k0pQl7g-1; Sat, 06 Jun 2026 01:17:21 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7A94A18002FB for ; Sat, 6 Jun 2026 05:17:20 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 451981800480; Sat, 6 Jun 2026 05:17:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780723042; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xzKJ/IpdkG01bM1txdqjhoLFTRAUk3+pG2IUFauAHiA=; b=IhbZiOXOuZu93yjjQJqP8jNfb8cv1hqq7BhJeKIUbfJ1TklizVAOIEY6DJBws68lfAZWwl sOVwRwkuuE0qgT+ePOsKIGjntvsPSQ6ElG8nRV8cNpICRMG5I98N34szV0FCoAF8heJnUy 36PCCefXYBP62kfTe3AK1GQTTzD/gEo= X-MC-Unique: r78MoDlGMfCnWn5k0pQl7g-1 X-Mimecast-MFC-AGG-ID: r78MoDlGMfCnWn5k0pQl7g_1780723040 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 06 Jun 2026 09:15:51 +0400 Subject: [GIT PULL v2 19/23] hw/ppc/spapr: free host_model and host_serial on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260606-qom-tests-v2-19-55832d978a9f@redhat.com> References: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> In-Reply-To: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=867; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=EFDae8u7ennK5lGTEip5Z4TCCmPwbTBDCnezXm8A95s=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqI6z1WHdm3DEK/PyXaBMvb5q6PgQvRiaLD7OlO 3b08+KrJwWJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiOs9QAKCRDa6OEJdZac 5fKgD/92HsMte1XT6fHbxiDfOfvi5GlK+vN6X4wbUiq9c/ALCAMmsssOrcfI4KNhUBZGyB9qXiK uemvyWvEPPuNr52ZfGdbazWdt+xT0Ky1kLcw0SABWGADLjilyUfCfLFS5g7QBxdbEz/cNnV3fwR lwbZ248ljCILgNn4t8e07ldMVExYHFrcvkeh7QqWjQr2onlq5DlIqb1rQ/PoctLhbW9Up1/4023 TvbAajpUSDEmTi1yzqfbmO901fLLVZAke0MnJ4K0D3y7YnOgYkk2x5/wRCsZWcx2t6ZJ65Xu97n ZhWQHDqnZloE5gvrt9d0ODq9/qfvoReBqZoWOqvjDQn1z+YXa8APlzitglQ/Qdwujbcd6QXkxLI Jsv+OJd8lO0ujYke4PjDa9kEQSjYhxkbdeYjq+20Ou4jhQK+829b5N9LVAueyCHZAnJLjYbAL9l x6kDCk0lb1wT7e+ueOYyDDjpfHlJURRnaksT1XKUSu3yiKVxpDJ7FISK0B1MS/iJ/OlWGP+o/By QVCXKZkqgehdA4dxMfQoiuaFrzoIzfP0vHpxNKt1xUzXW5akrnkB6AznJqaTJvjWGgbqvVQzDqN VInmjM2P7v/PZSykGVKE+l8/WxOp4rz/7GoZoQ8V1AWi9UHINj5X00itYzD9JR7UrT7NGMmjuVR iwUBLKqeZEyzVYQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780723077701154100 The host_model and host_serial strings are allocated via g_strdup in property setters but never freed when the machine is destroyed. Fixes: 27461d69a0f ("ppc: add host-serial and host-model machine attributes= (CVE-2019-8934)") Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/ppc/spapr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 191f7431bdf..f0e99bb5be7 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -3517,6 +3517,8 @@ static void spapr_machine_finalizefn(Object *obj) SpaprMachineState *spapr =3D SPAPR_MACHINE(obj); =20 g_free(spapr->kvm_type); + g_free(spapr->host_model); + g_free(spapr->host_serial); } =20 void spapr_do_system_reset_on_cpu(CPUState *cs, run_on_cpu_data arg) --=20 2.54.0 From nobody Sun Jun 7 22:18:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780723061; cv=none; d=zohomail.com; s=zohoarc; b=EC+HiH4DRYctdvubl7M6XE78CjtkJxlBWFj8YCHgS5G1KxI0C2UKpnyznCOBjbE16qBBgA3tzsChtqaD41r+pJvmrjIke56/ax/bqn8HVu1JWDPqgiRyuSdWrpHmJTuYuRowDuIpb6aPLmdedB6DCNgRBqYM19lHcDTRMOIhvKc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780723061; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=GrHGxvWCZFyP9F/U9uEn3LFLHsakCxnRmQhrxq0JqIM=; b=j4mYUxOJDks/6AyWhL6S7iwlzOXaBJV1Gbxh50EWjgPIdvED2HnZOvySprFy3GMZan3ECDuXKJsX2lT+fdekZ5AGlPvxfC0BSuFx9OIRC1Zz6ViE542iDdKX4/PcjCbuiDj+0jPhZ92Rshi31vjZFAAHbnbMjypvZ2jNUMO6nZg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780723061205208.96915130702007; Fri, 5 Jun 2026 22:17:41 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVjPa-0005p3-1i; Sat, 06 Jun 2026 01:17:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjPX-0005eg-Na for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:17:31 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjPV-0008Oa-Ng for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:17:31 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-112-zVBi4th0M0SN4YLRYvbZmg-1; Sat, 06 Jun 2026 01:17:27 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 881B219560A3 for ; Sat, 6 Jun 2026 05:17:26 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 25D8127A; Sat, 6 Jun 2026 05:17:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780723049; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GrHGxvWCZFyP9F/U9uEn3LFLHsakCxnRmQhrxq0JqIM=; b=XA2KaCogFnlaHtpO1qrkBYCcji7TE2fqHHgQRB3T4M79p8orn8DUXftvXQgNl3kTZ4plPB OTMfboVFsALJcJ9OiZa9U8NOgG0BfFbulgJgXNxf1SAHCc3PHBC052B+dNHopFoHf20WAn k/bO/X0U1rZVpf4188rYJsKr32pM4uk= X-MC-Unique: zVBi4th0M0SN4YLRYvbZmg-1 X-Mimecast-MFC-AGG-ID: zVBi4th0M0SN4YLRYvbZmg_1780723046 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 06 Jun 2026 09:15:52 +0400 Subject: [GIT PULL v2 20/23] target/riscv: fix general_user_opts hash table leak MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260606-qom-tests-v2-20-55832d978a9f@redhat.com> References: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> In-Reply-To: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=9672; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=HxjHARniAbZ71B0WPuGb8+FlvpnOsoMgTb+xCutausA=; b=kA0DAAoB2ujhCXWWnOUByyZiAGojrPWjWXFS+LLANXzBhceNeydolH995wH2wv7RaE8uqGpGc 4kCMwQAAQoAHRYhBIepvZM/h8YG0nb2Ldro4Ql1lpzlBQJqI6z1AAoJENro4Ql1lpzlhoYP/iN5 SkHyiV56MKqKuvg0gx1oMbNm7a2tQlmzy20iOwpTjY9Xt42kCLichODMUKdtsswKKtD+IbWjzUw s89m6oD/9JDKIaHQ7rtfWaPLP+K1ZIgw1xZiZvNm5Xqy0xeZk64LN1MF5R8eibD7GXSQ7F5aUaW XX6qS0UMd/rkU2znEe7HVIabbbAnonw9qKM0/c9i+0n115om3QSyTJdqAG6GMpi1dtYynUtS6LE hRp9pRmYBWbZCffTzEqh+RqWxYK8CgluaYsFUvyobQ3x7epwx3/LuXbSZ8zDucdfjaUujiQPFjm 1bapgtSigQFvzX+1zQVEpp+6/LrMSYGC8bTsm7Gw4mPjKaqwTGyCEtNVe5/0PB+DMdkTKGco7+A xq0bodjqaGGkjydTma0D58tQU8xdg6p3NW5zXl7I7eHU9KZd8WN+RbYvGjz90ZOBtK2TYFFAP6m pKQTrxJA1y2FwgJM/0mE0RSkqyVKDQQWCSW7YBCDl2J+q4kFGpVDyWEYsxmsEAxz2JH/Lzi3x+R qin3MEiYUGtZAL2MpsBVJPIa0+nQBvgU8Qqf+vYmvU0kr1r8dOvMg1y6YGKUsp/PSWvYwo4XiEf XvyMX8vtVvaB4zWx0ExXoXIcpnSo3UMBRn0etS+vXvWRoH4YC4tzknEu0yZegHhXQPUi8P1BgRw UxLnS X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780723061582158500 The global general_user_opts hash table is recreated on every riscv_cpu_init() call, leaking the previous one. Furthermore, the CPU settings should be associated with their instance and not global. Add a finalize() to free associated instances. Fixes: d167a2247ede ("target/riscv: move 'pmu-mask' and 'pmu-num' to riscv_= cpu_properties[]") Reviewed-by: Alistair Francis Signed-off-by: Marc-Andr=C3=A9 Lureau --- target/riscv/cpu.h | 3 ++- target/riscv/cpu.c | 53 ++++++++++++++++++++++++++++--------------= ---- target/riscv/kvm/kvm-cpu.c | 8 +++---- 3 files changed, 38 insertions(+), 26 deletions(-) diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h index 7d79c7a5a7e..f7d8a08c087 100644 --- a/target/riscv/cpu.h +++ b/target/riscv/cpu.h @@ -547,6 +547,7 @@ struct ArchCPU { uint32_t pmu_avail_ctrs; /* Mapping of events to counters */ GHashTable *pmu_event_ctr_map; + GHashTable *user_options; const GPtrArray *decoders; }; =20 @@ -620,7 +621,7 @@ bool riscv_cpu_tlb_fill(CPUState *cs, vaddr address, in= t size, bool probe, uintptr_t retaddr); char *riscv_isa_string(RISCVCPU *cpu); int riscv_cpu_max_xlen(RISCVCPUClass *mcc); -bool riscv_cpu_option_set(const char *optname); +bool riscv_cpu_option_set(RISCVCPU *cpu, const char *optname); =20 #ifndef CONFIG_USER_ONLY void riscv_cpu_do_interrupt(CPUState *cpu); diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 862834b4809..57000983edd 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -27,6 +27,7 @@ #include "qapi/error.h" #include "qapi/visitor.h" #include "qemu/error-report.h" +#include "qemu/timer.h" #include "hw/core/qdev-properties.h" #include "hw/core/qdev-prop-internal.h" #include "migration/vmstate.h" @@ -59,18 +60,16 @@ bool riscv_cpu_is_32bit(RISCVCPU *cpu) return riscv_cpu_mxl(&cpu->env) =3D=3D MXL_RV32; } =20 -/* Hash that stores general user set numeric options */ -static GHashTable *general_user_opts; - -static void cpu_option_add_user_setting(const char *optname, uint32_t valu= e) +static void cpu_option_add_user_setting(RISCVCPU *cpu, const char *optname, + uint32_t value) { - g_hash_table_insert(general_user_opts, (gpointer)optname, + g_hash_table_insert(cpu->user_options, (gpointer)optname, GUINT_TO_POINTER(value)); } =20 -bool riscv_cpu_option_set(const char *optname) +bool riscv_cpu_option_set(RISCVCPU *cpu, const char *optname) { - return g_hash_table_contains(general_user_opts, optname); + return g_hash_table_contains(cpu->user_options, optname); } =20 #ifndef CONFIG_USER_ONLY @@ -1126,7 +1125,7 @@ static void riscv_cpu_init(Object *obj) "riscv.cpu.rnmi", RNMI_MAX); #endif /* CONFIG_USER_ONLY */ =20 - general_user_opts =3D g_hash_table_new(g_str_hash, g_str_equal); + cpu->user_options =3D g_hash_table_new(g_str_hash, g_str_equal); =20 /* * The timer and performance counters extensions were supported @@ -1291,7 +1290,7 @@ static void prop_pmu_num_set(Object *obj, Visitor *v,= const char *name, =20 warn_report("\"pmu-num\" property is deprecated; use \"pmu-mask\""); cpu->cfg.pmu_mask =3D pmu_mask; - cpu_option_add_user_setting("pmu-mask", pmu_mask); + cpu_option_add_user_setting(cpu, "pmu-mask", pmu_mask); } =20 static void prop_pmu_num_get(Object *obj, Visitor *v, const char *name, @@ -1333,7 +1332,7 @@ static void prop_pmu_mask_set(Object *obj, Visitor *v= , const char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.pmu_mask =3D value; } =20 @@ -1365,7 +1364,7 @@ static void prop_mmu_set(Object *obj, Visitor *v, con= st char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.mmu =3D value; } =20 @@ -1397,7 +1396,7 @@ static void prop_pmp_set(Object *obj, Visitor *v, con= st char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.pmp =3D value; } =20 @@ -1437,7 +1436,7 @@ static void prop_num_pmp_regions_set(Object *obj, Vis= itor *v, const char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.pmp_regions =3D value; } =20 @@ -1475,7 +1474,7 @@ static void prop_pmp_granularity_set(Object *obj, Vis= itor *v, const char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.pmp_granularity =3D value; } =20 @@ -1548,7 +1547,7 @@ static void prop_priv_spec_set(Object *obj, Visitor *= v, const char *name, return; } =20 - cpu_option_add_user_setting(name, priv_version); + cpu_option_add_user_setting(cpu, name, priv_version); cpu->env.priv_ver =3D priv_version; } =20 @@ -1582,7 +1581,7 @@ static void prop_vext_spec_set(Object *obj, Visitor *= v, const char *name, return; } =20 - cpu_option_add_user_setting(name, VEXT_VERSION_1_00_0); + cpu_option_add_user_setting(cpu, name, VEXT_VERSION_1_00_0); cpu->env.vext_ver =3D VEXT_VERSION_1_00_0; } =20 @@ -1625,7 +1624,7 @@ static void prop_vlen_set(Object *obj, Visitor *v, co= nst char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.vlenb =3D value >> 3; } =20 @@ -1666,7 +1665,7 @@ static void prop_elen_set(Object *obj, Visitor *v, co= nst char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.elen =3D value; } =20 @@ -1702,7 +1701,7 @@ static void prop_cbom_blksize_set(Object *obj, Visito= r *v, const char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.cbom_blocksize =3D value; } =20 @@ -1738,7 +1737,7 @@ static void prop_cbop_blksize_set(Object *obj, Visito= r *v, const char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.cbop_blocksize =3D value; } =20 @@ -1774,7 +1773,7 @@ static void prop_cboz_blksize_set(Object *obj, Visito= r *v, const char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.cboz_blocksize =3D value; } =20 @@ -2834,6 +2833,17 @@ void riscv_isa_write_fdt(RISCVCPU *cpu, void *fdt, c= har *nodename) DEFINE_RISCV_CPU(type_name, parent_type_name, \ .profile =3D &(profile_)) =20 +static void riscv_cpu_instance_finalize(Object *obj) +{ + RISCVCPU *cpu =3D RISCV_CPU(obj); + +#ifndef CONFIG_USER_ONLY + g_clear_pointer(&cpu->pmu_timer, timer_free); + g_clear_pointer(&cpu->pmu_event_ctr_map, g_hash_table_destroy); +#endif + g_clear_pointer(&cpu->user_options, g_hash_table_destroy); +} + static const TypeInfo riscv_cpu_type_infos[] =3D { { .name =3D TYPE_RISCV_CPU, @@ -2841,6 +2851,7 @@ static const TypeInfo riscv_cpu_type_infos[] =3D { .instance_size =3D sizeof(RISCVCPU), .instance_align =3D __alignof(RISCVCPU), .instance_init =3D riscv_cpu_init, + .instance_finalize =3D riscv_cpu_instance_finalize, .abstract =3D true, .class_size =3D sizeof(RISCVCPUClass), .class_init =3D riscv_cpu_common_class_init, diff --git a/target/riscv/kvm/kvm-cpu.c b/target/riscv/kvm/kvm-cpu.c index 17ba38403a3..53d88339c13 100644 --- a/target/riscv/kvm/kvm-cpu.c +++ b/target/riscv/kvm/kvm-cpu.c @@ -2034,7 +2034,7 @@ void riscv_kvm_cpu_finalize_features(RISCVCPU *cpu, E= rror **errp) } =20 if (cpu->cfg.ext_zicbom && - riscv_cpu_option_set(kvm_cbom_blocksize.name)) { + riscv_cpu_option_set(cpu, kvm_cbom_blocksize.name)) { =20 reg.id =3D KVM_RISCV_REG_ID_ULONG(KVM_REG_RISCV_CONFIG, kvm_cbom_blocksize.kvm_reg_id); @@ -2053,7 +2053,7 @@ void riscv_kvm_cpu_finalize_features(RISCVCPU *cpu, E= rror **errp) } =20 if (cpu->cfg.ext_zicboz && - riscv_cpu_option_set(kvm_cboz_blocksize.name)) { + riscv_cpu_option_set(cpu, kvm_cboz_blocksize.name)) { =20 reg.id =3D KVM_RISCV_REG_ID_ULONG(KVM_REG_RISCV_CONFIG, kvm_cboz_blocksize.kvm_reg_id); @@ -2072,7 +2072,7 @@ void riscv_kvm_cpu_finalize_features(RISCVCPU *cpu, E= rror **errp) } =20 if (cpu->cfg.ext_zicbop && - riscv_cpu_option_set(kvm_cbop_blocksize.name)) { + riscv_cpu_option_set(cpu, kvm_cbop_blocksize.name)) { =20 reg.id =3D KVM_RISCV_REG_ID_ULONG(KVM_REG_RISCV_CONFIG, kvm_cbop_blocksize.kvm_reg_id); @@ -2091,7 +2091,7 @@ void riscv_kvm_cpu_finalize_features(RISCVCPU *cpu, E= rror **errp) } =20 /* Users are setting vlen, not vlenb */ - if (riscv_has_ext(env, RVV) && riscv_cpu_option_set("vlen")) { + if (riscv_has_ext(env, RVV) && riscv_cpu_option_set(cpu, "vlen")) { if (!kvm_v_vlenb.supported) { error_setg(errp, "Unable to set 'vlenb': register not supporte= d"); return; --=20 2.54.0 From nobody Sun Jun 7 22:18:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780723070; cv=none; d=zohomail.com; s=zohoarc; b=IQWqkV/xoxSP4XXzNtRiDJqTNZMCsm4GiGJ2zoL4vCAQntpRwb8byk83YxdC/8ruD0FWOp2k64hD8VlQ1lp+3GM6g9IWJ5h+ECcIIErU2mIKhk3c/QveqPS7kisHaVR2xD/EI3PTfPHRgCp3H9o7yqTj/NnrjVsDKdcO0fgNg50= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780723070; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=EW80NPiZA0afDX2EUeVylLahlZEm44Zw2VwztJ63muo=; b=DksPyB5lCHDAQj0MzJkdCILm1BMgUNvTK25b21Cbx69Yqog6NhF4+Y+TlC3qd54aOOnnH6O4hFswoAMEwFlQY13z6MLOSGVqDuasb4Wa3H0Jms0dMNjuuKUH98BLXjBJ2iInDANo3u3SU+AJca0VLAXX+4lE9FnqNKFMFe0jfNM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780723070632850.7095231125212; Fri, 5 Jun 2026 22:17:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVjPg-0006Nc-Th; Sat, 06 Jun 2026 01:17:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjPf-0006Gv-2K for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:17:39 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjPd-0008PE-DP for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:17:38 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-127-Z8dXb08UM2C8O0_C8lREmg-1; Sat, 06 Jun 2026 01:17:32 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C313D195609D for ; Sat, 6 Jun 2026 05:17:31 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DC7F218004D4; Sat, 6 Jun 2026 05:17:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780723056; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EW80NPiZA0afDX2EUeVylLahlZEm44Zw2VwztJ63muo=; b=K3DDtKwAH/quW61HAfaPfeBA2ppotyih5xGAg6yRnBsvyklJLGvcWIVs60FUu5zmcpKfNy rvtNR8IIkrY1wd5OYU3MQaSVD8qn9GZZQJYcMlOYkICkYNoT5uDkHOueL+MXIOGcBrhBNF GCaVCMzBK0mb3Uqvvrwkz8bWeY2OIuI= X-MC-Unique: Z8dXb08UM2C8O0_C8lREmg-1 X-Mimecast-MFC-AGG-ID: Z8dXb08UM2C8O0_C8lREmg_1780723051 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 06 Jun 2026 09:15:53 +0400 Subject: [GIT PULL v2 21/23] target/riscv: use hash table as set for user_options MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260606-qom-tests-v2-21-55832d978a9f@redhat.com> References: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> In-Reply-To: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=4808; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=upzIszpg9Sqx2Er0dwvmJZ/wdllyA5oABsmXU9+/2ek=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqI6z1B7E3yeQMm6TluGsFcHfZ6FmV+6/Naid3T HdVJcluJ2WJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiOs9QAKCRDa6OEJdZac 5Xu0D/9DYJrj6VMzXmpAz7QiYEldWUv1xwfZdE5MNS2IDUeDzurBiRXPFW7p6FMlnlOpLSoj9Xm A7j2xkLPNBVzx/ZoxVT1+zuHeJy8anmrG/DD75SgMAhLvFbwhKUYIopqUID2vq4C+8/qMuanVPA cxunX9u4huIuuQJ4BZy04bMTYMxLgRrC1CdBjil7d7cK4KyoFpgjiLqkg63NrOKorAIllsq1onk aaqY08pxbeA4JEpQOcMTh9lZjZRIZOLu1R6cpB1p0XcoBhuvOqWHqgF+0ti0qPOr8lK09txz9Eq 2BrzplKoLNHyWngrGZbGVfcPWbr2ql9lyk6IZUMBYCORw+AUb10dwh9VHRQ9/sB6TBD4rk+TE/S mFgjS0N/Zpf4751r4JB9fk22Qz72/dKeR11FXluxXiIMofJ8by4eqPPDDw+sybO/lp6RlzPUIUk W02yE6R+P3QIZIAqSMRKy9ZrpYP9rJA7vL9HkR1dJwuxCDe3OjYoImSbvz0TZqscTqxy3kUpkNO lgYkiuRIzx/rK1kGBXSaWnd6NoJj3pLpvzCvSEsoszOGZkLS/RvqlIZZNREL3oGjT6Y/o4aeWMs era+lTlucfgn3zoHlG7S/qdEVID8Fw8Ufina9S7Bl9N/fwOhHPCejozxZpvWwNqQ+NtIvTmcd+d jnhajpfVrtnF33Q== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780723071778154100 The values stored in user_options are never retrieved, only key presence is checked. Use g_hash_table_add() instead of g_hash_table_insert() and drop the unused value parameter. Reviewed-by: Alistair Francis Signed-off-by: Marc-Andr=C3=A9 Lureau --- target/riscv/cpu.c | 32 +++++++++++++++----------------- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 57000983edd..5903df99548 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -60,11 +60,9 @@ bool riscv_cpu_is_32bit(RISCVCPU *cpu) return riscv_cpu_mxl(&cpu->env) =3D=3D MXL_RV32; } =20 -static void cpu_option_add_user_setting(RISCVCPU *cpu, const char *optname, - uint32_t value) +static void cpu_option_add_user_setting(RISCVCPU *cpu, const char *optname) { - g_hash_table_insert(cpu->user_options, (gpointer)optname, - GUINT_TO_POINTER(value)); + g_hash_table_add(cpu->user_options, (gpointer)optname); } =20 bool riscv_cpu_option_set(RISCVCPU *cpu, const char *optname) @@ -1290,7 +1288,7 @@ static void prop_pmu_num_set(Object *obj, Visitor *v,= const char *name, =20 warn_report("\"pmu-num\" property is deprecated; use \"pmu-mask\""); cpu->cfg.pmu_mask =3D pmu_mask; - cpu_option_add_user_setting(cpu, "pmu-mask", pmu_mask); + cpu_option_add_user_setting(cpu, "pmu-mask"); } =20 static void prop_pmu_num_get(Object *obj, Visitor *v, const char *name, @@ -1332,7 +1330,7 @@ static void prop_pmu_mask_set(Object *obj, Visitor *v= , const char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.pmu_mask =3D value; } =20 @@ -1364,7 +1362,7 @@ static void prop_mmu_set(Object *obj, Visitor *v, con= st char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.mmu =3D value; } =20 @@ -1396,7 +1394,7 @@ static void prop_pmp_set(Object *obj, Visitor *v, con= st char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.pmp =3D value; } =20 @@ -1436,7 +1434,7 @@ static void prop_num_pmp_regions_set(Object *obj, Vis= itor *v, const char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.pmp_regions =3D value; } =20 @@ -1474,7 +1472,7 @@ static void prop_pmp_granularity_set(Object *obj, Vis= itor *v, const char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.pmp_granularity =3D value; } =20 @@ -1547,7 +1545,7 @@ static void prop_priv_spec_set(Object *obj, Visitor *= v, const char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, priv_version); + cpu_option_add_user_setting(cpu, name); cpu->env.priv_ver =3D priv_version; } =20 @@ -1581,7 +1579,7 @@ static void prop_vext_spec_set(Object *obj, Visitor *= v, const char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, VEXT_VERSION_1_00_0); + cpu_option_add_user_setting(cpu, name); cpu->env.vext_ver =3D VEXT_VERSION_1_00_0; } =20 @@ -1624,7 +1622,7 @@ static void prop_vlen_set(Object *obj, Visitor *v, co= nst char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.vlenb =3D value >> 3; } =20 @@ -1665,7 +1663,7 @@ static void prop_elen_set(Object *obj, Visitor *v, co= nst char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.elen =3D value; } =20 @@ -1701,7 +1699,7 @@ static void prop_cbom_blksize_set(Object *obj, Visito= r *v, const char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.cbom_blocksize =3D value; } =20 @@ -1737,7 +1735,7 @@ static void prop_cbop_blksize_set(Object *obj, Visito= r *v, const char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.cbop_blocksize =3D value; } =20 @@ -1773,7 +1771,7 @@ static void prop_cboz_blksize_set(Object *obj, Visito= r *v, const char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.cboz_blocksize =3D value; } =20 --=20 2.54.0 From nobody Sun Jun 7 22:18:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780723105; cv=none; d=zohomail.com; s=zohoarc; b=OyDFnkF2REicCMzexf8DYrXA7xMlrBeFza+W180DZs8sYT2qEErYY3zjHgJ4gvbAm2sxJSIH9SQM/vE2ttXz0gwT6nI9Fee2tKtVKxGHSboeI9fIzR2y9i+fQT4kNyLmzD/w2OL1JGTKvrHF+GptDrpHLytvNKhgJ2/1qLF5ae8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780723105; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=7Ah0WHWmKz0+75Y+bK1794xcADk+Gy/ok0cQpjpA/gI=; b=RdVs98+3nM3z837eO+vx8QkzYGWIypj2LYrNOQdURMUPs3QKb6jsRrc5XHjqJ9HF57DlLLWMjSSksqq6SQi5R57CI/b/bVAimf5VV58aZhgqZVmGvX4MsdQq2+iqRqga9aTOPqwA0VZsVVdtE9UbY1NaAXB7wkEK5/BDFqkxbGw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178072310502179.78520141659908; Fri, 5 Jun 2026 22:18:25 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVjPj-0006UG-5G; Sat, 06 Jun 2026 01:17:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjPh-0006PN-Dh for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:17:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjPf-0008PT-Um for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:17:41 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-323-au0sKjbQM5qD8MBEv0lM3g-1; Sat, 06 Jun 2026 01:17:37 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 27E4D1956089 for ; Sat, 6 Jun 2026 05:17:37 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id ABA471800480; Sat, 6 Jun 2026 05:17:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780723059; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7Ah0WHWmKz0+75Y+bK1794xcADk+Gy/ok0cQpjpA/gI=; b=bUYFVlEVTDtW+C4L2ViJECk7fJq9H2+2IZm/0s3PG4S/Dj1aP7M76fL6h67eutOS1iuWEG rDSJnwli46s3ZDMj0+p30NBKm0YEUe0cpind7/s2mv9auhyhJc3Ikmg5lGBThbWFLsb+n/ Q4WUf4tyM8naI5SDCtORv1pXQ7Ur9DQ= X-MC-Unique: au0sKjbQM5qD8MBEv0lM3g-1 X-Mimecast-MFC-AGG-ID: au0sKjbQM5qD8MBEv0lM3g_1780723057 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 06 Jun 2026 09:15:54 +0400 Subject: [GIT PULL v2 22/23] hw/i2c/pmbus: fix undefined behavior in pmbus_direct_mode2data MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260606-qom-tests-v2-22-55832d978a9f@redhat.com> References: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> In-Reply-To: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=1287; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=lVMXoPQIwGHUW/fpGSA36uE1q5DyN8PE8U/Si618GEc=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqI6z1I0t4OrjH+WOcUsZXGxNvHPwcRgpD2Sh1F LyhC58wftSJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiOs9QAKCRDa6OEJdZac 5dseEAC5+1pva0y5WaasLMNWfptzDTVpA4EOcT0dfrxXy9FIXOQoag0eJlfMyRym7rlGVh3bu84 +BedGCS2lpCncLYhGZRoz/0oK4588uM/B+xiJ59xQHhGJ6CmBjO69tlR55jJBXkcrAtL5o/guNg Y7WFctRP0sMmX3JLzr54XwsXK+qMxFk0xiqOv90DZPPRcGdNW9o+akZfMzjlt+iTezicvDP2kH6 kVbn9GUPgZ43FNzsW3cfbydq3nq7pxK6AiwxBMCFaMZhfGx7r/7j4e154NRoKvDOW9ncRvyUFRS vOnsEAshrvKww1bAAfNgPHDXTP02OKeW9ZRw9UzE20h8yWYiXJ4Qmuqm0i9loh3EUhlYiK4W7tu YKbRKIz1ujMoUDQ7K7BxKOTAO+XfR/BTbrrS9d7pMsSQfhD0vYGwLr67i474hBxyH0tkNuXc0OU 6jkGLvsXdCnoa5D0XU+CQJRREGGBC57aW32iQjNGrBnxn4PdHAWxEk/iONjyTXOEbSKs8j69175 kM5u9QXx5rSstA+ZOyTUMYoktSvQoHxhw3DpKf9yayeMe5nAct8MUV6Lw5G5pflsb8rnDWhjPTL 9eBTbI3pq2bEOnXr15FvWxqQ9r9f5rxhQWnFM2PGkJfkls58bGmINyD6+STSlrfYl5e8m+XuSsk OZ7FMbCXR8j6qew== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780723106131154100 The intermediate result of (Y * 10^-R - b) / m can be negative when the bias (b) is large and the raw register value is small (e.g. zero on an uninitialized device). Assigning that negative double to uint32_t is undefined behavior, caught by UBSan/clang. Use a double intermediate and clamp negative results to zero (suggested by Daniel Berrang=C3=A9) Fixes: 3746d5c15e70 ("hw/i2c: add support for PMBus") Reviewed-by: Titus Rwantare Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/i2c/pmbus_device.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c index 853dc4b4342..b1f9843f52e 100644 --- a/hw/i2c/pmbus_device.c +++ b/hw/i2c/pmbus_device.c @@ -23,8 +23,10 @@ uint16_t pmbus_data2direct_mode(PMBusCoefficients c, uin= t32_t value) uint32_t pmbus_direct_mode2data(PMBusCoefficients c, uint16_t value) { /* X =3D (Y * 10^-R - b) / m */ - uint32_t x =3D (value / pow(10, c.R) - c.b) / c.m; - return x; + double x =3D (value / pow(10, c.R) - c.b) / c.m; + return (x > 0 + ? (x < G_MAXUINT32 ? (uint32_t)x : G_MAXUINT32) + : 0); } =20 uint16_t pmbus_data2linear_mode(uint16_t value, int exp) --=20 2.54.0 From nobody Sun Jun 7 22:18:58 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780723175; cv=none; d=zohomail.com; s=zohoarc; b=kUnPZb2wyr4tLU2oyQsycDaRBlygd/9r7QN3AHl9GVLzOEyJPY4YsyHqXL6nycFOSg7I6XBnlu5sbvOd7gM+9Em+EK3UV5AaNn7i0cOmWHKaVzigd7ngcyOIlx3/bTFGvy8bXYrIpYFRAPJnYv+16g/mcdQDjMEA34PGA3Wp+Kc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780723175; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=9VyZiJ2ahA2S/F2Rs8hb2fk5gvFLJAv/h8MtGmJNquk=; b=nFqoOt5dcRKoZS4r12fc30kgSbQlzijOLBUVWMqeyAZZ0zynbaBk6uYK9Z0O7HjF1CgIJoZUYyayYlj+MlfJdNqpVYwrapRPAl6fEWJokp54yxAhScqrn3bzqcUY7z2pO0St3FrcvGqxN6fcjF2J1YlMkZKZqNrHXwEkJ9N5CK8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780723175443776.1388412347267; Fri, 5 Jun 2026 22:19:35 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVjPr-0006qd-RJ; Sat, 06 Jun 2026 01:17:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjPo-0006eW-KW for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:17:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVjPm-0008RC-Ci for qemu-devel@nongnu.org; Sat, 06 Jun 2026 01:17:47 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-74-W4Y3m4VGM9ea7ZdqHqLVjg-1; Sat, 06 Jun 2026 01:17:43 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 345ED19560A3 for ; Sat, 6 Jun 2026 05:17:42 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E5F611955BC0; Sat, 6 Jun 2026 05:17:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780723065; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9VyZiJ2ahA2S/F2Rs8hb2fk5gvFLJAv/h8MtGmJNquk=; b=L1dMWXbhaxLm60jXAH7a9Ryzx3nlV/8O19iMjJQNUrVriluGFbNUAi0cWoQgq3YimEqNxz grGVuBzA1XaR3V0jDekRJPpCfMmRlPx7NcBXrOTnjGKn4Qgi5JPbo22D3ZVNG2i087j7+W QiEs0kfh25qXuso0gYCOejiKzU587S4= X-MC-Unique: W4Y3m4VGM9ea7ZdqHqLVjg-1 X-Mimecast-MFC-AGG-ID: W4Y3m4VGM9ea7ZdqHqLVjg_1780723062 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Sat, 06 Jun 2026 09:15:55 +0400 Subject: [GIT PULL v2 23/23] qtest: add "qom-tests" command MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260606-qom-tests-v2-23-55832d978a9f@redhat.com> References: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> In-Reply-To: <20260606-qom-tests-v2-0-55832d978a9f@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=4983; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=BgJPBPmH5B6RRCynYwgwnZTtBG1LgQz3rhYtKXyzYDQ=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqI6z1mCW8lMLQNLJUh6MRBhMGcMMP4ZseNfkhc FOn7UvKZRuJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiOs9QAKCRDa6OEJdZac 5bD9D/wOvKwJ6mycP7q3Yt6mad004NMXPD79GQeUydevG0HuImvbRbdZRDGqS/9L9u47b/R5JjV u8L5jrDp0y39NdN3Hugah/ufvXG61iUdc9Ah670lCv/+iMHModyLkBQocg5UYv375jcCGXkdJfp HXajRHbtrJMyXWt+odvx28cFypEgJwy3kX7hdfOm6zL/kLuYFsd2KcVr6iR09UXsrRq/n+YOqCN Tobz0UdZcYnFVX5XKKDp9fu8WTm4OJhDig96JV5AJrwr4VCT6HWnpkouBawq95YwS9H2LUbbILB Ul7FyGJjpr7RTbDmtTWn0XcF8e05Dr5rEKwQ9A+3LgHzs2cSU6BnPk58sOEFwFsgiAB+6Pv1UZM RMBVmAUlfFHfCXhYhyHZa9IZqlqkfKCUDf225ht2jdgVH16oyZsvHYV/4KIhm5L/i/C0lD2orUJ Y00D0iG80++ZbLMlai6P44d26b/D+sqFeBL0g6vI6tfyQq2vv6sLe9oK+QbigXqd8j8wXu1EBmO cvArqJfh+P7vH4eVBxbDvnhCklnNMBA3LCo9b/I2t1ZdynIlL1EaQV7GORDqdql8vg+wWgpps0F gRAAKYqB2TkRFC+ntRproimCsSWhXEV9/pxF76UprdYtdHJrUWvlHtGnyZv3HfDmU+hOTlPRyNn UZwsD/Dajuo6HoQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780723175797158500 Add a new "qom-tests" to exercise basic object lifecycle. Instantiate all non-abstract objects, get and set properties and unref. This should quickly find leaks and other related issues that are eventually triggerable at run-time with QMP qom commands. Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- tests/qtest/libqtest.h | 8 ++++++++ system/qtest.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++ tests/qtest/libqtest.c | 6 ++++++ tests/qtest/qom-test.c | 12 ++++++++++++ 4 files changed, 72 insertions(+) diff --git a/tests/qtest/libqtest.h b/tests/qtest/libqtest.h index 950ea2baafa..45217fb8dc0 100644 --- a/tests/qtest/libqtest.h +++ b/tests/qtest/libqtest.h @@ -426,6 +426,14 @@ char *qtest_vhmp(QTestState *s, const char *fmt, va_li= st ap) =20 void qtest_module_load(QTestState *s, const char *prefix, const char *libn= ame); =20 +/** + * qtest_qom_tests: + * @s: #QTestState instance to operate on. + * + * Run QOM property get/set round-trip tests on all non-abstract types. + */ +void qtest_qom_tests(QTestState *s); + /** * qtest_get_irq: * @s: #QTestState instance to operate on. diff --git a/system/qtest.c b/system/qtest.c index d6db057b0a2..fd37bcbfaab 100644 --- a/system/qtest.c +++ b/system/qtest.c @@ -31,6 +31,8 @@ #include "qemu/cutils.h" #include "qemu/target-info.h" #include "qom/object_interfaces.h" +#include "qom/qom-qobject.h" +#include "qobject/qobject.h" =20 #define MAX_IRQ 256 =20 @@ -754,6 +756,50 @@ static void qtest_process_command(CharFrontend *chr, g= char **words) new_ns =3D qemu_clock_advance_virtual_time(ns); qtest_sendf(chr, "%s %"PRIi64"\n", new_ns =3D=3D ns ? "OK" : "FAIL", new_ns); + } else if (strcmp(words[0], "qom-tests") =3D=3D 0) { + GSList *list, *l; + + list =3D object_class_get_list(NULL, false); + for (l =3D list; l; l =3D l->next) { + ObjectClass *klass =3D l->data; + const char *type_name =3D object_class_get_name(klass); + Object *obj; + ObjectPropertyIterator iter; + ObjectProperty *prop; + + obj =3D object_new_with_class(klass); + object_property_iter_init(&iter, obj); + while ((prop =3D object_property_iter_next(&iter))) { + QObject *value; + Error *local_err =3D NULL; + + value =3D object_property_get_qobject(obj, prop->name, + &local_err); + if (local_err) { + error_report("qom-tests: %s.%s: get failed: %s", + type_name, prop->name, + error_get_pretty(local_err)); + error_free(local_err); + continue; + } + + if (prop->set) { + if (!object_property_set_qobject(obj, prop->name, valu= e, + &local_err)) { + error_report("qom-tests: %s.%s: set failed: %s", + type_name, prop->name, + error_get_pretty(local_err)); + error_free(local_err); + } + } + + qobject_unref(value); + } + + object_unref(obj); + } + g_slist_free(list); + qtest_send(chr, "OK\n"); } else if (process_command_cb && process_command_cb(chr, words)) { /* Command got consumed by the callback handler */ } else { diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c index b1e06ea364e..4e22c66b754 100644 --- a/tests/qtest/libqtest.c +++ b/tests/qtest/libqtest.c @@ -1137,6 +1137,12 @@ void qtest_module_load(QTestState *s, const char *pr= efix, const char *libname) qtest_rsp(s); } =20 +void qtest_qom_tests(QTestState *s) +{ + qtest_sendf(s, "qom-tests\n"); + qtest_rsp(s); +} + static int64_t qtest_clock_rsp(QTestState *s) { gchar **words; diff --git a/tests/qtest/qom-test.c b/tests/qtest/qom-test.c index 6421f2d9d9f..cf4c6b5add5 100644 --- a/tests/qtest/qom-test.c +++ b/tests/qtest/qom-test.c @@ -227,6 +227,17 @@ static void add_machine_test_case(const char *mname) g_free(path); } =20 +static void test_qom_qtests(void) +{ + QTestState *qts; + + qts =3D qtest_initf("-machine none"); + + qtest_qom_tests(qts); + + qtest_quit(qts); +} + int main(int argc, char **argv) { char *v_env =3D getenv("V"); @@ -238,6 +249,7 @@ int main(int argc, char **argv) g_test_init(&argc, &argv, NULL); =20 qtest_cb_for_every_machine(add_machine_test_case, g_test_quick()); + qtest_add_func("qom/qom-qtests", test_qom_qtests); =20 return g_test_run(); } --=20 2.54.0