From nobody Sun Jun 7 22:19:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780674298; cv=none; d=zohomail.com; s=zohoarc; b=jLHeJmPxiRPennFBVICksdJE9wSTubf6WFBdXfjVr/D5aXMg7uwCLaLSA68Y5eS40DdgOkmbnUmub88aeqzhGQYeAK7C29MNm5hYwLF+hmCHPVnfj5eGVfNaSd577lrOjouqZhb7XOhjQ7ttOVJoGGXO/dyrGLJlRu/UYa2IiTw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780674298; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=EHaYJTnNXtnP4r58RbVBZ5CHW50pjzFA4v+h6Y0CfyA=; b=N3CXEC5PUzX+8TeuJ5s+aZoODJziDlUZr4OfNFJfnoIQHY99FG+QE60GRbzoUI+2yX9C18woqOakWyJqxzjTfXxe/dBCl6k17vdkrcMwdZNL7DL9O3XJrE0r3aYyWSaSOeUlWNC0ZAtJapZnLPtBjP99zzIZ7mZKPsG8ZcGlmWE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780674298862550.6431957519236; Fri, 5 Jun 2026 08:44:58 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVWiz-0004Rs-Si; Fri, 05 Jun 2026 11:44:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWit-0004Qy-9d for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:44:39 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWir-0005qR-JP for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:44:38 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-169-_TAwq55lOpSTf6mi1j8PyA-1; Fri, 05 Jun 2026 11:44:33 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D65221800366 for ; Fri, 5 Jun 2026 15:44:32 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8C2FB180056E; Fri, 5 Jun 2026 15:44:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780674276; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EHaYJTnNXtnP4r58RbVBZ5CHW50pjzFA4v+h6Y0CfyA=; b=i1wxzaYCzbCktlCzxO/o1fktJmE5/tbD8XdkJxcHH8l4/TpFbI7tMiMrs6EWuSs1vlpaLs dn8zx2xM6bHrGwwTNHElxmpzy24CaC+DF2C2xnDwSz38sH0sHcGUL6K3o4YjZnkT9DUZHh HDapu0NLBY0Yjgpx6OXB+1DRFRIPUcY= X-MC-Unique: _TAwq55lOpSTf6mi1j8PyA-1 X-Mimecast-MFC-AGG-ID: _TAwq55lOpSTf6mi1j8PyA_1780674272 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Fri, 05 Jun 2026 19:44:21 +0400 Subject: [GIT PULL 01/23] hw/pci: handle missing bus in prop_pci_busnr_get MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260605-qom-tests-v1-1-3f184f382c2b@redhat.com> References: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> In-Reply-To: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=1326; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=6du0B3+bTyiu/gIbq11MHIRY6wGGJJ3yX28+ndrVGuE=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqIu7USACf/VSGqmQILNlbi8RPurSEMGSIuzAuB G4tcICumyuJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiLu1AAKCRDa6OEJdZac 5a/4EAC7LU8zvluP5UzzTOnWDY820reqEDPvnFvQHSqHMnfapnQ7b05aavf1tgGeDg81qYSZC7Z wiIZpgg9ubXjOrKXipc+bA02jSqW2ArXQWPK944zv1C/JrLIEq6k0iEtrQXRNf0ILAQld9hJ+mU WTsGzzVzCUuaMnTr42cl/osSZcyADROcE07oVq2bMWoT6nu3AUHj9lrdrayb/KeWKzLg9121k+Y gU7gfvWgNsAYQe66U7t6z363vErKU5DTZlVodVNcROifAYZjOBVJrGTGgbdCYqhjazhB0i1hLQf KRHPjYfWlayzQok3Z77Q7pzeO5BANQFlqNoEWDURkHiH4ME8dX+6FtIjissnW7bmU/07NddO5gY tHpBvjcqXRNje6nfjOzq3/5Q6FhMpjO3f9Z83vr84eMrmQ040DfVSoZf6r7zagBrk84pbt8PgHK cF/SAIalnYFVFVnhsOaCzJxlL56ejZVwYbiLanbctG5u1UWmHGnqF0vkHLZdquFHd/dOkAxFPnh mrq6z5nTG9hovK6XogbVqL9zHdbtFZJH3IpthKUAJew0OUrNZNAMk3SiYlrp0UYkJR/t2/kjtpJ 7FdeMoJ+oeuxl1faMDhUgFmsplwPoVwYXFcxqKgqCB9EC4xr0pfWZj/AZudNSLHg2zJ7eP7Hy4s 28lQz8euRas9UVA== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780674301486154100 When called on an unrealized device (e.g. from qmp_qom_list_properties), pci_get_bus() returns NULL since the device has no parent bus. Check for this to avoid a NULL dereference in pci_bus_num(). Fixes: df9ac7254fd9 ("hw/pci: Add a busnr property to pci_props and use for= acpi/gi") Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/pci/pci.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 4298adf5a0a..cec065d108f 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -64,10 +64,17 @@ static void pcibus_reset_hold(Object *obj, ResetType ty= pe); static bool pcie_has_upstream_port(PCIDevice *dev); =20 static void prop_pci_busnr_get(Object *obj, Visitor *v, const char *name, - void *opaque, Error **errp) + void *opaque, Error **errp) { - uint8_t busnr =3D pci_dev_bus_num(PCI_DEVICE(obj)); + PCIDevice *dev =3D PCI_DEVICE(obj); + PCIBus *bus =3D pci_get_bus(dev); + uint8_t busnr; =20 + if (!bus) { + error_setg(errp, "device not attached to a PCI bus"); + return; + } + busnr =3D pci_bus_num(bus); visit_type_uint8(v, name, &busnr, errp); } =20 --=20 2.54.0 From nobody Sun Jun 7 22:19:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780674305; cv=none; d=zohomail.com; s=zohoarc; b=Xcv5rsDsWcQUC5fsv4XguNQ650P6JgQfzg3iWwrAabRS1INtLxPa83ATfbnEhuvvf68jrimIVOeHjAtfEKnezWpPkQsAWc13Q8Js2Uuk+AKPsIvh8TpJGvOVeiNpDd4q/R3IiEcSpzofvP5cDG9/Kx4u3ig7/wBd8E1A4DmfCfI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780674305; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=lytCdpvdiMPurS2UAPPEkSbXcRb49Mlw8+CgeQ0/TBc=; b=OzPhayVmAG3+K+gZUCCHL9ieENMBfQ4OtI33ZXAPI0LMsYb7pTCx4OlXNDLk9/7ar5dLfaOiPDseN3HikDf7OmA8hQwFq5+ck3KhBtWLKYSvROKMo3feAaiWxBjDglQQWYgesiHfHmDOWDnzb+BL9f0frX0u82vQcytMAoy6VfI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780674305249794.0057595632121; Fri, 5 Jun 2026 08:45:05 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVWj5-0004Sf-JJ; Fri, 05 Jun 2026 11:44:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWix-0004Rl-Dm for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:44:43 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWiw-0005qy-4x for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:44:43 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-94-XAHkhhkAMDOS3xpdNJxVyg-1; Fri, 05 Jun 2026 11:44:39 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1BD211956046 for ; Fri, 5 Jun 2026 15:44:38 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 15705195608E; Fri, 5 Jun 2026 15:44:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780674280; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lytCdpvdiMPurS2UAPPEkSbXcRb49Mlw8+CgeQ0/TBc=; b=cRHSCc+GF5CbPFwLmtXKquhCokNockVwxbRd9RVB/cp/jdjsJAE5tCZ8VdbkGqg4Z0iwru Ov1MnKHn/+TK/ZrzHNGdueJWZrmWyhrzEOCiFmUoXNj0JCAA2EAo49xxDwYFgRfgYBcj1+ oMYcwc9U0P3LNnrVYJY4EgwwXnzBAD8= X-MC-Unique: XAHkhhkAMDOS3xpdNJxVyg-1 X-Mimecast-MFC-AGG-ID: XAHkhhkAMDOS3xpdNJxVyg_1780674278 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Fri, 05 Jun 2026 19:44:22 +0400 Subject: [GIT PULL 02/23] chardev/char-socket: handle NULL addr in char_socket_get_addr MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260605-qom-tests-v1-2-3f184f382c2b@redhat.com> References: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> In-Reply-To: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=863; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=wplotIDRIQizQ4vLWFXXRZnYhLKWxLjUBChA2au34a0=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqIu7UnZJIbnbiOGwoQ8gZBfzXGLLK5wS1rlb8M pxE3b6VbluJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiLu1AAKCRDa6OEJdZac 5VnjEACrWYDeNQ4CWBbjsVQeWxpIxQ/DxcljWMOVYyogxESW6r7MNLw09lBT20WruwnKEgxxYyG pq8dIy8sD3YkzZO1cwQCFZQkf0UZ4XgNvJ1/8n8oeC6/e1/BMzPbdS+sZFhUPhAtvKlFTSyyL4p l4UiHYP0sfEMTD5c5bG1SshtUoISe5nTdmk9eIaYw4TIshJKkl5AuwmB5iQISMJCb4AGQjJ94ht Yi7c3PCywcA+FvG34uuCBWEW0NEEKDRHxOGRTRCHy7EZu7ER9+fcY8CJdYY3lDSirfg5XHPlQrO hcrJL7CpErp8UEs0Ih+T+okUQKXw1I4K1g0bjS/GVmKpHY75tVcNtgz9SzRrL8botlkqZI0an3P 5FG0XfnvkV5wRimNXGqn7T7HmNZZIq/2KNdDvkL8HlZFWeRw0iw4ff/fCgulR6NbFt4V9Ulj4bE CJZTstm9naMW6anFBn+fPF9pEH8XRQVdQhE4vHIpLzIYyNzUSOF8PlCLNT4vSdAZIfmElHbu8hK R6w61uUkgtke4cTLaG8H/PdU+j7oQLyEM2DyWKVUC66aMBkZaha6xfHBuk+5MKGpbO6+IB3st4n KSxV7HptLQM/9zAv9VvEhE61ODu5RHJKjf3/Ns7sYESOqOkrYsI9MIoCjhizZXkYziMpOJL8TLQ xqFsQ4WlZorxDQg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780674308343158500 When called on an unrealized chardev (e.g. from qmp_qom_list_properties), s->addr is NULL. Return an error instead of assert(). Fixes: 123676e9894f ("char-socket: add 'addr' property") Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- chardev/char-socket.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/chardev/char-socket.c b/chardev/char-socket.c index e064b105c50..b629575fcf8 100644 --- a/chardev/char-socket.c +++ b/chardev/char-socket.c @@ -1529,6 +1529,10 @@ char_socket_get_addr(Object *obj, Visitor *v, const = char *name, { SocketChardev *s =3D SOCKET_CHARDEV(obj); =20 + if (!s->addr) { + error_setg(errp, "socket not connected"); + return; + } visit_type_SocketAddress(v, name, &s->addr, errp); } =20 --=20 2.54.0 From nobody Sun Jun 7 22:19:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780674353; cv=none; d=zohomail.com; s=zohoarc; b=BCY6xXwtOXOHbkONNlqdt7XJAlHi9UOs7TuFCEVDF2ez3HFP0Fh7RKl3pv3cANyikaffEhbbW89gyOhfPe0QLudPikwUd5FersJxVXmjcSwP07u2PCfLyNELidWUx1yQkWd3SJY4M0eR7omclY9M8gp2VHIcUlNu2ZvRlX6Bp3I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780674353; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1KSCoPhM3lk7JFhTxcjXT83QO7v9CIqkxILozb1DjS4=; b=f5V53yZfqVSCcXzmuKZK8Zc1eyvNWYN6lFAku7E0HOlCBUqgDQENgli7Wk+pz5BzYG7NAvDtK5ArNPEWRvyXKKOeMz8ybUPgFwUwBLSulqWy2K67bKmhLjvJeXDxAfU74hp6pgoFrO6Txwb9xybc6hT+VN1rKFgM4KOro0ECYF4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780674353502237.941816614014; Fri, 5 Jun 2026 08:45:53 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVWj8-0004UI-4D; Fri, 05 Jun 2026 11:44:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWj3-0004Sj-63 for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:44:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWj1-0005sM-PH for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:44:48 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-564-nFCpILmSMg2IelpYtvCr2g-1; Fri, 05 Jun 2026 11:44:45 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5A6C31956046 for ; Fri, 5 Jun 2026 15:44:43 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2A1EB1800480; Fri, 5 Jun 2026 15:44:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780674286; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1KSCoPhM3lk7JFhTxcjXT83QO7v9CIqkxILozb1DjS4=; b=USsBRqX4iRUYsFXHtJEyFs1Ec75RBKTRCbJP4HBKSIM8cZbj4GAdF7B8lWbsekBD3AUjb3 vrBGJCkYyJ9ytzeFAgIthoFxIUd/gSv0lwTge9qrzY35exTo/S4dcy5l43eeT1mSUjk46L KgAge3qIIScokKWMy7AixnCDqIYrhxw= X-MC-Unique: nFCpILmSMg2IelpYtvCr2g-1 X-Mimecast-MFC-AGG-ID: nFCpILmSMg2IelpYtvCr2g_1780674283 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Fri, 05 Jun 2026 19:44:23 +0400 Subject: [GIT PULL 03/23] hw/pci-bridge: handle missing parent in prop_pxb_uid_get MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260605-qom-tests-v1-3-3f184f382c2b@redhat.com> References: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> In-Reply-To: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=1251; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=n1HD5N4FZEYQbnTz/49cmNT99YN0r5FAVFil0pDrL3g=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqIu7UGZb9oKUroYCLr2jb1iMyj7IW9mAURFV3f ENXa5AxfMyJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiLu1AAKCRDa6OEJdZac 5VcOD/wPqZQ/Mck+zohML+UIP166oAFDbQbv4t6vhsG5YRV6yKRBAHMt0AH4T760n1DHvbDNjdl TS2t/WchENZvCyncEjQFzWweEMSwkCpbuQ32WKy2CpLV39/kj1fjYzgP0O5lMqwSj706xDIrydS JgoNMc+x4rsgs35dGxMmpZ7cZF5U34ShCMLwk1IjBMH7bYPq0YgTdWzv3ERfgzp9P7eIrHVWj3r 0THxefSJucnKqy1DIO2XMswb0VJnuuWbB6YdPt3/ByCJ3ssdxw2EXq02qScbS7moFgpwKHtL4Xj F1ovlrwA/56hwSb4yOvGrCymXvhAvpKiM6aKGkhFZ8daVWrjd4P+RxMck18B2c7hJo5x+juky3Y mpJTloCqVcB2XsGlvfQJz88cC6+G6Ila6DlpK7tDSsMcpMzRy1mvykjF/UiUhV7Z8Yxc78fPoRX TAQ/HkQKLGKNuGQFWSJcsMy+FsrZ77B/9GiOUiroa19wOqTImvkqeFc//brqIJmecN+/UlJ3KeM LFKqa9TQZYddkv91Q+tqTojkLpQ7FuYKukegVRw42YG/psSkyLNB7CQCWxcQb/nvFymKmtLzXLp twAq9Y6549AEKIgUpl0CKD3udNvVO66vKv31FwJfEgcMv0Ux6ZBSSvdMGvp4tpPnPdtcJ4S3hjI SRr/c8uYJiQHGzw== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780674356130154100 When called on an unrealized pxb bus (e.g. from qmp_qom_list_properties), bus->parent_dev is NULL. The pxb_bus_num() callback dereferences it unconditionally. Check for this to avoid a NULL dereference. Fixes: 97b9cb066e5f ("hw/pci-bridge: Add acpi_uid property to TYPE_PXB_BUS") Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/pci-bridge/pci_expander_bridge.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/pci-bridge/pci_expander_bridge.c b/hw/pci-bridge/pci_expand= er_bridge.c index 11623a5666f..40ffbc4e082 100644 --- a/hw/pci-bridge/pci_expander_bridge.c +++ b/hw/pci-bridge/pci_expander_bridge.c @@ -85,8 +85,14 @@ static uint16_t pxb_bus_numa_node(PCIBus *bus) static void prop_pxb_uid_get(Object *obj, Visitor *v, const char *name, void *opaque, Error **errp) { - uint32_t uid =3D pci_bus_num(PCI_BUS(obj)); + PCIBus *bus =3D PCI_BUS(obj); + uint32_t uid; =20 + if (!bus->parent_dev) { + error_setg(errp, "bus not attached to a device"); + return; + } + uid =3D pci_bus_num(bus); visit_type_uint32(v, name, &uid, errp); } =20 --=20 2.54.0 From nobody Sun Jun 7 22:19:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780674319; cv=none; d=zohomail.com; s=zohoarc; b=Lc+Vvj1P+jY1XMybU1PfTjeHsswbkULPWo/nUb+g2Pb3h6gS9b7ko/H9R1UB/VwhnCdwnZ7zrEIChrc/nDlbDNouqfxdB2zLRBi+gykUrrg8j4lmimEuDaEHuClFQVx56o5OlbCO9yNEIvdx6T0z1tT+ECGvNjGEzjeA3LDQDVY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780674319; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=dMU+/9kJPvBI6+rr+qjuUE2o/XCGiPk1vWq0Y33MHrs=; b=b4ycnXC/9u36B46ePPPmS0rwPaNreBQEhu6Z9jbgYH4vQBhfOhc48WFesVZ3hKc+14HC/GyRdhBHN5m/l1TcBcDoUQDB59M9Lz7NMI1hNT606gvpR3wI8/ILAgB08rwNt7VpicIBat1ZJtnRMNBD8PeBPK6UUP/0hXx7XmoxRyo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780674319385593.0930667081228; Fri, 5 Jun 2026 08:45:19 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVWj9-0004Uk-4G; Fri, 05 Jun 2026 11:44:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWj8-0004UP-35 for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:44:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWj5-0005u6-KC for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:44:52 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-652-MMBUFk_jPqOKe-5G9pOMLw-1; Fri, 05 Jun 2026 11:44:49 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8C2501956094 for ; Fri, 5 Jun 2026 15:44:48 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 797DE18004D4; Fri, 5 Jun 2026 15:44:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780674290; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dMU+/9kJPvBI6+rr+qjuUE2o/XCGiPk1vWq0Y33MHrs=; b=dM+tuA+3CPPNUjLPCQLk7MzZOYhs58A0T/ji8TYjH0tkhgj11Wg6cvW1wQ2ssBiNF0kgRu d0AI+ay65Ny/B3AF+TRDlpoeewtkuTs1zMDI6qU6nj6c6DiesFTJFAQSvoUNux6GkWvRcg JsS3QFyYN1pz0cApUAKtHpYlhVC9pHU= X-MC-Unique: MMBUFk_jPqOKe-5G9pOMLw-1 X-Mimecast-MFC-AGG-ID: MMBUFk_jPqOKe-5G9pOMLw_1780674288 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Fri, 05 Jun 2026 19:44:24 +0400 Subject: [GIT PULL 04/23] hw/pci-host/i440fx: handle NULL bus in pci-hole64 getters MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260605-qom-tests-v1-4-3f184f382c2b@redhat.com> References: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> In-Reply-To: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=1993; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=OVF9SYpNWrlV6USrd7t5agr6GhrxgYTzZ+VWk9J0k8Q=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqIu7U8WhLRtfdVdEKgoWC+J+wXA98xptKvzxgX o3loMsIeR2JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiLu1AAKCRDa6OEJdZac 5ZsBD/48u9aSqkRqPL7mWf//NxeMl7nC9CGDc6wCp91NSBWfwCOVuGCL7CVasdhOEdfOCDO7dBs Au6tHY/Q2kKfblYK5gFXhYL0KNQFByeNKCLVojVo2XxO+hm2x917BzVPpyECd27sV/NHA9zGswv I+3qYcPhDAPyFhfxHzKeMRDRzGuGL4JmCJIw13kp7qeApEB67CsfqxkXphM+oC9f2A7kjuPj2l0 ZNrCRqDU5UOfBGB+AD6KI4w7pfeL/rZdCfQ2HO55rWRNeRpFpxoZemQLMrqO3uz9KdFuGrIm3Wf k8x6p7zwA80epcDcTbsgbMqEvRctFM9QME2aa+Quk+BtoJLe8Z0fB0EEO7YMotwDye9AbpX4v7z 2llV4yHoS/+W5fZl8pKYWg2QyfgyGfL7sXZIHWAqf54HuLJlDuEnlQp4mnsM4P2tEiAeEA4qb69 cy/QW0PHRBwzYcadR60m3NOuhbVUGD67aaMPu9TODEaPwwC5ss29gdfowx0Wcj8C+iB11csv5ZR wCdF6WYEu0TW2Zp4ThdR0hnLdfK7BwE3IpVmQyjnGP8RGGdjvl5ZOFbxDVM5I2DNo2Sc2QDR20H ONozmS4koIrzgbCa6tLUD+adlu/4zKpkMr+FqjR32qSuciyT7e7suUwyq3ELzjuVVF9Oq/hGDYb XKsMzhoZ4IgwaMg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780674319574158500 When called on an unrealized i440FX host bridge (e.g. from qmp_qom_list_properties), h->bus is NULL since the root bus is only created during realize. Guard against this in both pci_hole64_start and pci_hole64_end getters, reporting an error. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Daniel P. Berrang=C3=A9 --- hw/pci-host/i440fx.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/hw/pci-host/i440fx.c b/hw/pci-host/i440fx.c index e7d638b296c..c1982f7962a 100644 --- a/hw/pci-host/i440fx.c +++ b/hw/pci-host/i440fx.c @@ -189,8 +189,14 @@ static void i440fx_pcihost_get_pci_hole64_start(Object= *obj, Visitor *v, const char *name, void *opaque, Error **errp) { - uint64_t hole64_start =3D i440fx_pcihost_get_pci_hole64_start_value(ob= j); + PCIHostState *h =3D PCI_HOST_BRIDGE(obj); + uint64_t hole64_start; =20 + if (!h->bus) { + error_setg(errp, "PCI host bridge not realized"); + return; + } + hole64_start =3D i440fx_pcihost_get_pci_hole64_start_value(obj); visit_type_uint64(v, name, &hole64_start, errp); } =20 @@ -206,10 +212,15 @@ static void i440fx_pcihost_get_pci_hole64_end(Object = *obj, Visitor *v, { PCIHostState *h =3D PCI_HOST_BRIDGE(obj); I440FXState *s =3D I440FX_PCI_HOST_BRIDGE(obj); - uint64_t hole64_start =3D i440fx_pcihost_get_pci_hole64_start_value(ob= j); + uint64_t hole64_start; Range w64; uint64_t value, hole64_end; =20 + if (!h->bus) { + error_setg(errp, "PCI host bridge not realized"); + return; + } + hole64_start =3D i440fx_pcihost_get_pci_hole64_start_value(obj); pci_bus_get_w64_range(h->bus, &w64); value =3D range_is_empty(&w64) ? 0 : range_upb(&w64) + 1; hole64_end =3D ROUND_UP(hole64_start + s->pci_hole64_size, 1ULL << 30); --=20 2.54.0 From nobody Sun Jun 7 22:19:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780674315; cv=none; d=zohomail.com; s=zohoarc; b=mxFrM7ZAvdzhD6bPqC9gpo8nw+Ekz5+qnliKIZrfLq3OvsPRdHXJMdgGHWAUU55+qIrZOAepNjaoyY+++K/d1pcUffrmM5f5pUyF6hKzE3puZranmU8imxMZoQ13sm+jbDV8geP9lVgtwK9cquLWFsImDIFVkd5BUEN3yAx+seg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780674315; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=lfyciCUtj2uYB/fKRwGsx2x9nVw//AMbGAr/gW/I5xs=; b=PtK3RWOO3fRdSJQtUQzmXoluR/XfvQTmIXVa2MJ6r1Bv0A13WZ7sDyQq+DxJutyy3WoCfG+aAYNcY0RBv/ZHDgeQkuJmezSNUo3bhqHxWezBBJlb9b2Xm5jiqK//uDSq/SRgC8SYZB05xyBDPdW+hto8S5H7nRfUeAok2qnHJ4Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780674315105131.90488565090322; Fri, 5 Jun 2026 08:45:15 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVWjF-0004Yg-33; Fri, 05 Jun 2026 11:45:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWjD-0004YC-9n for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:44:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWjB-00060Y-O4 for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:44:59 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-191-x3N_fGU3Pz6VT3h0MW_9Cg-1; Fri, 05 Jun 2026 11:44:54 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BF94E1800663 for ; Fri, 5 Jun 2026 15:44:53 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9F39C3000239; Fri, 5 Jun 2026 15:44:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780674297; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lfyciCUtj2uYB/fKRwGsx2x9nVw//AMbGAr/gW/I5xs=; b=ev+xSb1x4tQYrgPCEp7ClM/7NCIwfBZW9OW6z77B7KLXYqwGpvPT6/1aqkHNRqABy/m/ZN 2YS4CDQxjcUcpvUk587Ib6+kcFZ2p4yOADHajdGIPgubKwSz+gqh2q2w2iYX9cxZRuFC/x lgNO5A431ON1C+fiHbCys0RiLdSuaps= X-MC-Unique: x3N_fGU3Pz6VT3h0MW_9Cg-1 X-Mimecast-MFC-AGG-ID: x3N_fGU3Pz6VT3h0MW_9Cg_1780674293 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Fri, 05 Jun 2026 19:44:25 +0400 Subject: [GIT PULL 05/23] hw/pci-host/q35: handle NULL bus in pci-hole64 getters MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260605-qom-tests-v1-5-3f184f382c2b@redhat.com> References: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> In-Reply-To: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=1907; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=XXJqDmEBi6TiRs5PKjbn7IjQSTVVWEFFYwA+j0kMbhI=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqIu7U4kBHXy+gwLqi75qV2C5bzDybZKeZ6WpxS Im4TK3/mteJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiLu1AAKCRDa6OEJdZac 5fUPD/sGb5IF4UZJuaxeDNU7Q9slT9smrqk+NmQqw3jUU7D0I4Tjsu/kgv0b7xji4T6sw7o1WTp dnYKrnzU4Sj0HhV37Fae0FxPLXm3hse/0ucKoGidfHl32m8NQX+HTGRqE5RMAeBUff33iEHyo8O 6Y2rQYAKYcyh0phPNp6Vx0qxnGRgnZT2EVujkIf8kOJHIgFh/F8qPCHfOep00+qToFxYaghPEJF CVlgbJUlL5U7djNMR1LZ1AaRQ+4DBwPvJogRXDsRUiKsFn+Bgo2Y2GQyj97yC6+yojd/M4yzxYO cB/fdvxksqL0DYH+7qEdY8QRQvMHGwn8chArUlpXRxTh0CiIUOOHrrhhwc7IT00eNBcp2onpH90 TxXW0MvS+AoYzdlNGn6TEloBMfzJu+bzgJRi5w6ROzfsoC7HaCRVS3YUZMG6CmY4w5edd61V/ws HaLBZPQDFROW3h+kYUVBLMxZaTR/Ern0oKJbUHUlGj6ZzIejFaLe8iN/WY3e14QkNUaMxROYSpw pQevnWFk3quBl32XFFU0FXKRHICEegO3py1Gvs1EDphlcsh05LZbMQxJ+TEI1fbi2vFPeThAQHE kHzDH8gNeTCJlOQT6lAXxD6MZfYLwui/yoyFcj/c3RuHQ4kGfaOXHpGdI2AZxhNZOBMN445cuzb 7MxzUlkGhBfTJrg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780674315571158501 When called on an unrealized Q35 host bridge (e.g. from qmp_qom_list_properties), h->bus is NULL since the root bus is only created during realize. Guard against this in both the pci_hole64_start and pci_hole64_end getters. Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/pci-host/q35.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c index e85e4227b37..355e81bfa20 100644 --- a/hw/pci-host/q35.c +++ b/hw/pci-host/q35.c @@ -132,8 +132,14 @@ static void q35_host_get_pci_hole64_start(Object *obj,= Visitor *v, const char *name, void *opaque, Error **errp) { - uint64_t hole64_start =3D q35_host_get_pci_hole64_start_value(obj); + PCIHostState *h =3D PCI_HOST_BRIDGE(obj); + uint64_t hole64_start; =20 + if (!h->bus) { + error_setg(errp, "PCI host bridge not realized"); + return; + } + hole64_start =3D q35_host_get_pci_hole64_start_value(obj); visit_type_uint64(v, name, &hole64_start, errp); } =20 @@ -149,10 +155,15 @@ static void q35_host_get_pci_hole64_end(Object *obj, = Visitor *v, { PCIHostState *h =3D PCI_HOST_BRIDGE(obj); Q35PCIHost *s =3D Q35_HOST_DEVICE(obj); - uint64_t hole64_start =3D q35_host_get_pci_hole64_start_value(obj); + uint64_t hole64_start; Range w64; uint64_t value, hole64_end; =20 + if (!h->bus) { + error_setg(errp, "PCI host bridge not realized"); + return; + } + hole64_start =3D q35_host_get_pci_hole64_start_value(obj); pci_bus_get_w64_range(h->bus, &w64); value =3D range_is_empty(&w64) ? 0 : range_upb(&w64) + 1; hole64_end =3D ROUND_UP(hole64_start + s->mch.pci_hole64_size, 1ULL <<= 30); --=20 2.54.0 From nobody Sun Jun 7 22:19:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780674372; cv=none; d=zohomail.com; s=zohoarc; b=cf2oFKCBr6vdNsLnnud97r3pPLiAibHVxUPD4W2ukaEpDVgAFqB7qvSVdMR6FO2PwCKs3i9LrIWow9Na7jn+rnDJV0MFHUUfFirBLeZtP2B7jUZNz/IvpJ2rLpXMfH+fhpjReQp70jDOSGivA/j2PL588fxyRKi3xt3xO6ZfjCo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780674372; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=40y9nUEM2k+DgX74L7br+FVh1cGqfh7EYiI+WllmI9w=; b=h4AadMt8mtB98PGTrow0WOVmx2ABG/SU5fw0gvMs5cftewicM2LOVnTqOKhtgBU6VhCt4cVW1zlFIupMdYxLZ+RTaqZ36TFmKszOPPMyv1arX8ZJm+w3cgigCZ8buAZLDFviV4SLdvM760csw20zMAI93QRUlhhI5GOR/4BmsvE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780674372603101.4252495202677; Fri, 5 Jun 2026 08:46:12 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVWjL-0004h2-OV; Fri, 05 Jun 2026 11:45:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWjJ-0004dN-Bd for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:45:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWjH-00063f-W1 for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:45:05 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-505-NVmsIupeP6WRZKHc9ydd8A-1; Fri, 05 Jun 2026 11:44:59 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E843F1944B03 for ; Fri, 5 Jun 2026 15:44:58 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id F0A7F1955BC0; Fri, 5 Jun 2026 15:44:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780674303; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=40y9nUEM2k+DgX74L7br+FVh1cGqfh7EYiI+WllmI9w=; b=gszf9gIKXyJd1OOt5kwWW4yJjHt9XBxKnoZDWCfMWiY9fe4KhlRV7nHQ+dsbjave7D/gSY Zrzs7n4Av9iiLAt9QDMAXS7XLneczh+rA/6XIOkzTikYoRgFcV6coUzFV9mC4ntPtdP7fp VepHht9x7eKjrDtci7JNqQtD/nW8LuM= X-MC-Unique: NVmsIupeP6WRZKHc9ydd8A-1 X-Mimecast-MFC-AGG-ID: NVmsIupeP6WRZKHc9ydd8A_1780674299 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Fri, 05 Jun 2026 19:44:26 +0400 Subject: [GIT PULL 06/23] hw/ipmi: reject NULL 'bmc' property rather than crash MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260605-qom-tests-v1-6-3f184f382c2b@redhat.com> References: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> In-Reply-To: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=767; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=mEwe7/OMVJKZh0U5KU7As11b7hk3pWmV01Cq6GcNgXU=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqIu7Ug6zqn1gagGfsYTXgrcLMRhhJGF4dbzm2V nVaSnuWyOmJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiLu1AAKCRDa6OEJdZac 5XExEAC5X19Hiz0hhGuUz4AjJYxBslmbDgJD/ERKuRnSawJjHzbyH8XtLRNuth4jWBuDzpYqPLY 0mfDVvX5h3r3WH/vj3f5+CGAEU0+tlR2nPxkkg/1jTjEMFDv4vqwag5yTqxlTHMd35lDwBEERij TcFcRKYxiYt1DeVHlNr0D0OleSEGZtZICodKiAh8gMSmEeUzMUwlarjTnX+IZNa7Y/HfrgOMJvQ Ujaq2zbJPvSJk/m+NRApPtZcKcU99La1lE/+NrDxKPtuYOvxlvaRK6AFGz+3TIIg96hh7NsPfMv eE03lf7k9OnnpzCtN/xKiSRajmQHH6fKIa/ZAvxzAW09T/7a06buIwwOFdWeH+lLJxT0iOpP36+ NCVqABlmDMCwsnvoca0b86iBNYF08yLpq2RMUPp7WstMlx2dDuN1mVxcyPc2DoRImFMo2Px+VOG YF1NVGrXNE6/1NK3WRHXaiLbaszFIFUqiVng1LzVM+Khi/pp+Z1Dblg44JePCVR17hosEoSkTES ChrngUpPRoZHSFgjAbmFnR1D9yNnX+5Khl/vwGRfnw1bshHHWYM5CQIZF1Zfby5s7b0zMDZx3pC Afs60EFhO06dNY2L3n72GJtr17unn9y/kfbXowbOHCaqJSZqkJXFqgKj5xvpLHmFTw/YM6Rg7E5 SYsjRIgRgZAMq9w== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780674374512154100 Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/ipmi/ipmi.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/ipmi/ipmi.c b/hw/ipmi/ipmi.c index b49affaccec..74818ff3cea 100644 --- a/hw/ipmi/ipmi.c +++ b/hw/ipmi/ipmi.c @@ -97,8 +97,14 @@ static void isa_ipmi_bmc_check(const Object *obj, const = char *name, { IPMIBmc *bmc =3D IPMI_BMC(val); =20 - if (bmc->intf) + if (!bmc) { + error_setg(errp, "%s cannot be set to NULL", name); + return; + } + + if (bmc->intf) { error_setg(errp, "BMC object is already in use"); + } } =20 void ipmi_bmc_find_and_link(Object *obj, Object **bmc) --=20 2.54.0 From nobody Sun Jun 7 22:19:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780674383; cv=none; d=zohomail.com; s=zohoarc; b=Ld9QjL/0oqpuFpfF8DpCiORQbul3STDBeaxffwfD2qNdOJp1rHHO+lRgIJVLcISbu+xAXnBjlX8kViYKNHuTUWArMiqf7VpDhMYnmVwcZbTJfI16G+bbfiTHqriLl4/03uAGtI1qH753RDNhJ3gA/sB3qcPpnQbB2ML+t5r60JA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780674383; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=fAwFkj/6xMxLjs4eWHPsU8ZO9MF0yW+Kp2IWPAaAtK4=; b=hAT6CWukaDlHXDLy0YbGjiwYmbyHB1/Z7BKbxJ6z45cBJ2TYdaNI475qQ3od8STJE9hNvAazeOOn2dwAs/llCBX5OTpDtOJ9Ri+go65zlASTlQty/vvmM/dw8HGu0FAUqHBBcoXrxyG4jd+D9Idl/gJFp/uCKYA6gayaZw0RjLw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780674383127306.27958568925885; Fri, 5 Jun 2026 08:46:23 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVWjP-0004vR-05; Fri, 05 Jun 2026 11:45:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWjN-0004lw-1s for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:45:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWjL-000647-MR for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:45:08 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-561-5eErVoFAMNak2OtehVWU7A-1; Fri, 05 Jun 2026 11:45:05 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6A6DE1800366 for ; Fri, 5 Jun 2026 15:45:04 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 746B927A; Fri, 5 Jun 2026 15:45:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780674307; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fAwFkj/6xMxLjs4eWHPsU8ZO9MF0yW+Kp2IWPAaAtK4=; b=VxQrSfIKkPZ1K58c+CLYSCjfeiTG0NhQqueO+rAt7QSVAYhdoWAWd526YdIbaUuRt2T8Iy woz55/PHMrVkXO1eKsAEaOURhLMw+wQ95LGB/xQ7L7hmaXjzdyjEbwd4DRpyyh0dkQ0D7B lexLYIiNv0o17IOfCb0OcG17Vu1AwEk= X-MC-Unique: 5eErVoFAMNak2OtehVWU7A-1 X-Mimecast-MFC-AGG-ID: 5eErVoFAMNak2OtehVWU7A_1780674304 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Fri, 05 Jun 2026 19:44:27 +0400 Subject: [GIT PULL 07/23] hw/xlnx_dp: reject NULL 'dpdma' property rather than crash MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260605-qom-tests-v1-7-3f184f382c2b@redhat.com> References: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> In-Reply-To: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=806; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=kJdZho7KPoZAyRTuY6SsmAMLdZDbGBB9QFQKogVkqy8=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqIu7U6Syq9mbRxfzMubguX3Eom1y2y/Nc2vMqc SM1pu6nS/uJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiLu1AAKCRDa6OEJdZac 5RKmEACVAPF4hf5tzIy9gvPgvaK8f8jfmL3SNWNORxKm7i7pRabIi50rRQmaz0lwSkSsvFhUu2m sNZYS1lIiTSCW3vWh4+NUOwREW6Pk/yxjhjcKm0WIuDRDHIMbOPAm6nZAB7Tx1pV5S9H5YqkWE4 5VXDVELSIxQSWCDkfm25cxKVoPWXcJ9R7L9c3GZI6bzLfMBgswiDRneKjgBhTxOrZRadaCzyjH9 BWQtKKcntZlA+71ZbDzdmozwXkrtzorlpuqes1uGtHp8kGKaNWNGYE8oQR+0aeXaM5hBRhGz+sP gsemhktO0MMP7qkrjzMrG/CHtKM9Ko+kuqWDaVw4UcUNCumABRCpcSaVbt5omG2x5jFN3pGWmGZ FX+G65d01ijMAry9HTxGgWW3NtGwPKTekkHrujqkHQI/ev2CYo2gtEOg6fs/JPq/FqdhgWaQeYr UmL3nDlQBoPkiYJTZDhCaGMO3I66VYEZ0sgqKrkFmlTJtouK2p5vu9DUuwL7zYvXqX9jKrQyCxe u0ujpHmS9xAypH7gaVI36pbFhfLaU9DnvgTBP/KNt/ulVCiMG3K0FU5dZa8iHe4lFZsda8Gir3y OzC4DtCpn7J0gklrQIp3huc1zVODowuDbBrtJmH7xr+G0Drwd+vojsLX8oN2qXovqO2UC4HuhLB wrH60pLLfrb4w3g== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780674384620154100 Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/display/xlnx_dp.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hw/display/xlnx_dp.c b/hw/display/xlnx_dp.c index 2486d9e5825..98126ef320d 100644 --- a/hw/display/xlnx_dp.c +++ b/hw/display/xlnx_dp.c @@ -570,6 +570,12 @@ static void xlnx_dp_set_dpdma(const Object *obj, const= char *name, Object *val, Error **errp) { XlnxDPState *s =3D XLNX_DP(obj); + + if (!s) { + error_setg(errp, "%s cannot be set to NULL", name); + return; + } + if (s->console) { DisplaySurface *surface =3D qemu_console_surface(s->console); XlnxDPDMAState *dma =3D XLNX_DPDMA(val); --=20 2.54.0 From nobody Sun Jun 7 22:19:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780674355; cv=none; d=zohomail.com; s=zohoarc; b=P2KwaZ0waMVdHoS25K9MZP7ZNYz59Yx8OEsQ+mSkhWqwWe5Tw0smAw7cL5houwlvXH7Zy/FV4Sty14KNxfopRmvlsADCqkmVhk7G+s69CyQ5Yl7OfIaTskRH0qCWIYDFxmozdvrG2Ia3svRNs3JWlebGftAcy6GDOTx6HNpGkWE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780674355; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=9oVaaSGgSCNfnHB8VrwCnrC/7/oqMdFPnrQEk3bhZys=; b=nKBDc0DzzP+D70KWXUlzmCCQtBGNXM3OykxPSF8vpJjPXrzkftmKP2JtMhHoZYABtkgyDcoPwYxB+g+wJD93C/xaDB0Nc5WwnNsULOOtd/XtEjQTLPfj2u+9um2o1k7wy+Zzl9bZXLiCkhFt4LcpmNqTOQLEf+WyQsBe5dMY4+M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780674355224404.0828262646178; Fri, 5 Jun 2026 08:45:55 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVWjV-0005Oj-Oj; Fri, 05 Jun 2026 11:45:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWjS-0005Hc-UG for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:45:15 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWjQ-000650-Vk for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:45:14 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-528-ldclok0OOQOyTnrH4kMW-A-1; Fri, 05 Jun 2026 11:45:10 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D515A1800366 for ; Fri, 5 Jun 2026 15:45:09 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id BED203000210; Fri, 5 Jun 2026 15:45:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780674312; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9oVaaSGgSCNfnHB8VrwCnrC/7/oqMdFPnrQEk3bhZys=; b=Igj+4ZjBHo8ugt6XV+O4lDG05Gzvj5S67XSRsEoIR1RQaquF2QqGx9fF07nH2l7BFrcBvJ kRfoq8N/WWEQzHf6XKeO1vIsJJCTDc4j0SLkIc1+HvmANnvqpK4j3q17S2lJB107LEoTC1 SeJcntyHXvSKePO9TsXM6Vqy7FABv9I= X-MC-Unique: ldclok0OOQOyTnrH4kMW-A-1 X-Mimecast-MFC-AGG-ID: ldclok0OOQOyTnrH4kMW-A_1780674310 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Fri, 05 Jun 2026 19:44:28 +0400 Subject: [GIT PULL 08/23] hw/intc/apic: move checks to realize() MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260605-qom-tests-v1-8-3f184f382c2b@redhat.com> References: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> In-Reply-To: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=3010; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=kCq+Tor03wCqaIg7gsFcKOnzmGQyewRDM9N2xTJ00BY=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqIu7Vj30kjZVWy1cai7ZYl0eTRlsqWzLKs8v2P Kn5z9/siPGJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiLu1QAKCRDa6OEJdZac 5e3HD/9YtRU/4+poxgVIEMGextn1RMvfGAOfVbqK07HGafnhAzWAhPnE8je8iLvxmNm/hX6kgnV Woo7sTRyHb2Ao8Vi5f0voE1U9Onjksyf6vg1LQVSE81Tws4UHyNEkDXf8hSYRwh17I9dHassKZa 0ft+Lv45cHW8MT0msx3qEinOJmf8eSZIaEITxUk0yaz4pqiaFcj3uOla2AAflg06vcJxbcBVCDQ SGXchhkEFgMG8dzyBZIUHpen/XakEKo4GAGQYm1rJxEheRygWM0Ji8je1WpGN0tRMQeqpdqED2m KaI6SQJx0RrNJcsHPPRom9lixjJHMr4rjTGr57k/Fd9j6X3cyk/fyGIQRug1mga6thxYN39YrB2 PnEU7KdTYbU52dRvVjz8Rbu76Jc1vwMG8r5S/aHRgSf9OQ2N3RdFGela5ymB4YwRPtV1NxeoyXR B9pv2EvZ0df3G9qHhIqsDfM8D7jlX5Sp4blwISy5c2xaacC9OAXbc4rAA9CKNiY01GLAlIkNDXd KQSDpvEFWldYlnUMWNNAKa64cD8XE/3uhGf1iZJNXJEIXkcz7F0du2ytE+o6/T9+QTp7sIwFGLK o+sZlEGOKhrAkZ/XU1r6TUYKi7umzrhKsHv5p59juT1bSQgJEkK7ygVLuE/btNbBbO4wDxSLjZp L474h6fnjDKtSXg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780674355834158500 apic_common_set_id() dereferences s->cpu to check for x2APIC support when the APIC ID is >=3D 255. On a standalone APIC object that has not been attached to a CPU, s->cpu is NULL, causing a segfault. To solve this, move validation during realize(). Fixes: b5ee0468e9d2 ("apic: add support for x2APIC mode") Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/intc/apic_common.c | 23 +++++++++++++---------- target/i386/cpu-apic.c | 6 +----- 2 files changed, 14 insertions(+), 15 deletions(-) diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c index bf4abc21d7b..49c03a5bcee 100644 --- a/hw/intc/apic_common.c +++ b/hw/intc/apic_common.c @@ -257,6 +257,19 @@ static void apic_common_realize(DeviceState *dev, Erro= r **errp) static DeviceState *vapic; uint32_t instance_id =3D s->initial_apic_id; =20 + if (!s->cpu) { + error_setg(errp, "APIC is not attached to a CPU"); + return; + } + + if (s->initial_apic_id >=3D 255 && + !cpu_has_x2apic_feature(&s->cpu->env)) { + error_setg(errp, "APIC ID %d requires x2APIC feature in CPU", + s->initial_apic_id); + error_append_hint(errp, "Try x2apic=3Don in -cpu.\n"); + return; + } + /* Normally initial APIC ID should be no more than hundreds */ assert(instance_id !=3D VMSTATE_INSTANCE_ID_ANY); =20 @@ -410,7 +423,6 @@ static void apic_common_set_id(Object *obj, Visitor *v,= const char *name, APICCommonState *s =3D APIC_COMMON(obj); DeviceState *dev =3D DEVICE(obj); uint32_t value; - Error *local_err =3D NULL; =20 if (dev->realized) { qdev_prop_set_after_realize(dev, name, errp); @@ -421,15 +433,6 @@ static void apic_common_set_id(Object *obj, Visitor *v= , const char *name, return; } =20 - if (value >=3D 255 && !cpu_has_x2apic_feature(&s->cpu->env)) { - error_setg(&local_err, - "APIC ID %d requires x2APIC feature in CPU", - value); - error_append_hint(&local_err, "Try x2apic=3Don in -cpu.\n"); - error_propagate(errp, local_err); - return; - } - s->initial_apic_id =3D value; s->id =3D (uint8_t)value; } diff --git a/target/i386/cpu-apic.c b/target/i386/cpu-apic.c index 5599a4675c5..04b7257ad12 100644 --- a/target/i386/cpu-apic.c +++ b/target/i386/cpu-apic.c @@ -56,11 +56,7 @@ void x86_cpu_apic_create(X86CPU *cpu, Error **errp) cpu->apic_state->cpu =3D cpu; cpu->apic_state->apicbase =3D APIC_DEFAULT_ADDRESS | MSR_IA32_APICBASE= _ENABLE; =20 - /* - * apic_common_set_id needs to check if the CPU has x2APIC - * feature in case APIC ID >=3D 255, so we need to set cpu->apic_state= ->cpu - * before setting APIC ID - */ + /* cpu must be set before realize, which validates the APIC ID */ qdev_prop_set_uint32(DEVICE(cpu->apic_state), "id", cpu->apic_id); } =20 --=20 2.54.0 From nobody Sun Jun 7 22:19:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780674390; cv=none; d=zohomail.com; s=zohoarc; b=Chs69i4oxONIyACcm9Th28dERZVzEQptJO5D9C2i71VWV9op9PRwTha5Utqr/6uw6WE40rYEe9Z1bfbBwkqtUo1KqXZ8bfSw06t/MAwvAbRGZz6KQ539v1cnSCPewBjlhBNw7yzO+eY4R/03CNTA/2z7yUTh9ayvKKDH8F+wi80= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780674390; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=T/Cc75KG/mGn6kld4q1FR9pIIprF3eBJYHOfuAmQ4M8=; b=Bf7jZeJoEo78lQr6EZsz+MgbzW8JNqqEKDe5X9nI6jVSZX23S3BEN4y5hS08Ml2RlZGlhNUGUctk2m/qHhGxHj+vvk0jcCFCWKce9/IVuiwmIBmTl1+G20nUZpvt6nl8GcTXn0NxKNXro0FsGm7Kir2MJ7vivL/LAY0uzXCgIOU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780674390252470.7054410338493; Fri, 5 Jun 2026 08:46:30 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVWkM-0006Tz-44; Fri, 05 Jun 2026 11:46:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWjZ-0005WO-UA for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:45:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWjW-00066w-HS for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:45:20 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-617-cuYx3mTaM-y3oIxVctntBg-1; Fri, 05 Jun 2026 11:45:16 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7698119560B0 for ; Fri, 5 Jun 2026 15:45:15 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4E85D1955BC4; Fri, 5 Jun 2026 15:45:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780674317; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T/Cc75KG/mGn6kld4q1FR9pIIprF3eBJYHOfuAmQ4M8=; b=Pethh6rk/7vXpqVhtcTSaiqOmMNe3MQtmjN9JnC5PNMefv1qDozYIR+1QUBoG+nVh//CeG 5WF2kRNCn3baJ8M5KB82DrnsEaQvqzVcIj7vS78YRwVelq6gFXstHUhLIfdojA3yHgEh3k ObYMCwbQkDRDIJRQx762yzbf5pPKRX4= X-MC-Unique: cuYx3mTaM-y3oIxVctntBg-1 X-Mimecast-MFC-AGG-ID: cuYx3mTaM-y3oIxVctntBg_1780674315 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Fri, 05 Jun 2026 19:44:29 +0400 Subject: [GIT PULL 09/23] backends/cryptodev-lkcf: skip cleanup when not initialized MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260605-qom-tests-v1-9-3f184f382c2b@redhat.com> References: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> In-Reply-To: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=1242; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=ZoIQTw/8fvWMrcbUlgAsETKAbnpCOyqqMPiJiRQOO6Q=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqIu7V6tt4x9DsVqd4cs4U4gA8swuo90MGocs/0 oKI6nHofL+JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiLu1QAKCRDa6OEJdZac 5SH4D/9xOFAIzVcWnlTCtksjuBI4jGn8iakNkrzHS9RTe7OfaVOCNcZeFlvObrY7VhL/S8vFRFv CKB0VEEvwDHqqEY/w+LYGD4Q5NBgDfaNsYuIAqmRdvgrVI37rB6Uac+kjRi+I4DRtgeo8LdH1NR BK4R38IPNnh44WPM5PauWnD3/uFjPyDRmBVv4FiKozMSqQnrs2W1WgalVmKujqaOjTcwkyVlo/p P0KTLfa8yzut93sme4EDGra8aSBo82vDwH9MqDNyU4Bnyf+5Gmihb4ZDHzPnmTCV+kqzvlxMGLL c3nQcqzn4x/QRoXxlF90ZRRPjuvXxZqLRAo3he8hZaj06Dc29K8MQXhIiA4m+ImUFUynUSccegB +CDf1p9kZMuO/hWIR6iN6yxA54E4pM4x0LtTlON6CIevhFHAjWX+eIH0l3/VNnNOnTIRmGe0swp +nhiwNSez9KZetfVWRJOjEcI/4oGJ8//FnHTPkK1bPMgL6YlxUVLoAVGdIIMKYH6ApCT0rbwenf N02uSbqp/FHk9P6LWc9DS2W3YU23pfmLjYJwoSVCdyFjgGwjFfvbd8YM4vYfc5FU8FuvKXcsRqt 3m62Lak1JstYXyvPVt9ejNY1tBZb17aJiy0Jqhnqm/L+Op0kW8+/5Mix5QsLdCLdxY/EbrktJnm EoJo0+tlslN2V7g== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780674392759154100 cryptodev_lkcf_cleanup() locks a mutex that is only initialized during the init vfunc (called at realize time). When the backend is destroyed without ever being realized, the mutex is uninitialized and the lock aborts. Return early from cleanup when the backend was never started. Note: it looks like cryptodev init/cleanup callbacks should rather be regular complete/finalize overrides (calling the parent method). Fixes: 39fff6f3e8b3 ("cryptodev: Add a lkcf-backend for cryptodev") Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- backends/cryptodev-lkcf.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/backends/cryptodev-lkcf.c b/backends/cryptodev-lkcf.c index 40c7bd3c5a0..3fe29d3104c 100644 --- a/backends/cryptodev-lkcf.c +++ b/backends/cryptodev-lkcf.c @@ -255,6 +255,10 @@ static void cryptodev_lkcf_cleanup(CryptoDevBackend *b= ackend, Error **errp) CryptoDevBackendClient *cc; CryptoDevLKCFTask *task, *next; =20 + if (!cryptodev_backend_is_ready(backend)) { + return; + } + qemu_mutex_lock(&lkcf->mutex); lkcf->running =3D false; qemu_mutex_unlock(&lkcf->mutex); --=20 2.54.0 From nobody Sun Jun 7 22:19:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780674390; cv=none; d=zohomail.com; s=zohoarc; b=Nvcd3JsxzheYyUz8YHpLzyvCB3KM3FHMb6TZYH6/ViHAwYYah8rPTOM/ji97IPjNM4NE+sCkp5ZbDjH6WCPfjNYnu+Zjafw94HTUY0iaihPjcsSIqgRqHXSpMbpVsYbrdG0XM20zp7RLmzlmMSW1PiJbjeKF83dMTkPIGGWSfxY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780674390; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=dZGdjRx4Qw+v9eLFJQiN10KyvdIUABstP/cGPr21HaY=; b=Bm59Bb7DI54bnrjVQL34BuqPOBmSQBWtptm+ClbQm7Jc28jPq+PxxsKYp/I3fnPeJaG5zxFeEaJJ4iWEEdV3sfKz9ny/ZGz4PWlxZiLFGbHzzPvdqeVJo4jvkCyo+bM65E72xqO8xfeAm9DE9K4NKzr0krLcev0Uq9e0IeYgWSE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17806743901481015.351042099055; Fri, 5 Jun 2026 08:46:30 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVWk6-0005yq-A6; Fri, 05 Jun 2026 11:45:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWje-0005Ww-IN for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:45:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWjd-0006KA-4C for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:45:26 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-152-HUv4bXuEMp-Tfd0nxydjxQ-1; Fri, 05 Jun 2026 11:45:21 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8DFC41944CC5 for ; Fri, 5 Jun 2026 15:45:20 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A33F41955BC4; Fri, 5 Jun 2026 15:45:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780674323; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dZGdjRx4Qw+v9eLFJQiN10KyvdIUABstP/cGPr21HaY=; b=hD/qI9waCQCqKI5PwWYSxvw7nrIZqG54aOc+AMF1WJgkZdITKS4tMPR040odJXGO1HsqfI Di2YXMZz9cTGjb/ihy+44BtDbTlXbkMa4muFMhEHaaJudbSr8ZuHFWwPHD/Pr9XJV8K14S 6/ZX/S2wbaM871NA2/SpG2DL1ElSBDc= X-MC-Unique: HUv4bXuEMp-Tfd0nxydjxQ-1 X-Mimecast-MFC-AGG-ID: HUv4bXuEMp-Tfd0nxydjxQ_1780674320 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Fri, 05 Jun 2026 19:44:30 +0400 Subject: [GIT PULL 10/23] system/ioport: minor code simplification MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260605-qom-tests-v1-10-3f184f382c2b@redhat.com> References: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> In-Reply-To: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=1020; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=mmxLPf/mf/HIopy5JjPU/FWz41zXebmAxd8a1saOMJU=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqIu7VYnlL1gq1N5yKmU9QEzDkJizeCByZMjBOi 4OdoZGRnv2JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiLu1QAKCRDa6OEJdZac 5ffHD/0ancSUaEAWp+MP/HSPF0IINzLuHuANkfRNbF7I0xORqeT99Z09tIH3thXRKcCC74SrGVx DZPVkyfo019aUurjkV+iKR7dawAgprbVOBMMYLtqxV5umM1qvbTD+DEbP3bSZzdgRsukaDTfBGl JMqCB9PTW+bzHTfMgkcJyBmKaasa0ClQ69vcMlc8HQmih22xL+ZnCsYl1pPuIkf2FfMq7HtJji5 vB+xQ32dlIE4Tybm0bnpPJolwY/AnMJ8R9nEXzonDnsUYCa6CJqt/zdHoJ1IS7WN/LHoWTrg2ux IJJtmsThZo15P1g1wVn6RoGVMgAzZoq/D25AIJOyWC8yKuO4e8QC7U6/giy2ueO3NUyLC5fd2O/ XMmUMvARQMNqvSrz9uLQwewdeEoxTPM1L3Gy3TXl5wzcBnwvHLWtct5Ts5mAEBW70qay2MFO+l0 CdK9BIs1wiaCHzPg8AkwlN5OYZyktLRarodzBNAvlGjhprvwUskp4ZaI4O3f2yb/u3igCS9GKyk J+8LyEy06983/657+hlOrem+/CxseHqBxFyh6fP01L8ETzh2AqMYeg7XhnH6hDz25lVHF9P8s9K 496pMt5P0IXbBY3+2Dzx9CHYGmn8cS6FTrfW1sZ6VjSe00oRtHLvfDfXYg9czvIpkYO79RZMD0o rOQGCJi2C1ofbUQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780674390856154100 Drop needless memset() and replace g_malloc0() with g_new(). Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- system/ioport.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/system/ioport.c b/system/ioport.c index 1a0e01fd06b..0a1b80f2994 100644 --- a/system/ioport.c +++ b/system/ioport.c @@ -230,9 +230,8 @@ static void portio_list_add_1(PortioList *piolist, mrpio =3D MEMORY_REGION_PORTIO_LIST( object_new(TYPE_MEMORY_REGION_PORTIO_LIST)); mrpio->portio_opaque =3D piolist->opaque; - mrpio->ports =3D g_malloc0(sizeof(MemoryRegionPortio) * (count + 1)); + mrpio->ports =3D g_new0(MemoryRegionPortio, count + 1); memcpy(mrpio->ports, pio_init, sizeof(MemoryRegionPortio) * count); - memset(mrpio->ports + count, 0, sizeof(MemoryRegionPortio)); =20 /* Adjust the offsets to all be zero-based for the region. */ for (i =3D 0; i < count; ++i) { --=20 2.54.0 From nobody Sun Jun 7 22:19:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780674372; cv=none; d=zohomail.com; s=zohoarc; b=P1jeXwTUBYfI/G5Gu+nXV2lPJX7mMBrVS5eoFkzq48uTrWS7nUMUIb5B7M+r3DCExZ0IY4Nyik5lj7nfZuGGoNJtjYymi0swGYHmBWAsVYcnyt5jv0ym9j8GwBcHX9yIStZjcecoxnU6l8luENvR6Nfd8IuwG0x53fLtFcn/N9o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780674372; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=tKv7uKXevO2mwOyC4qHpjh1F8G+LrZIXjRyqb5hTmN0=; b=iPGhQDEJGreaw3MIIRHycvPg1g6l6YBQsJIxK2nMurV0v5gBlHTi/TcA0wjSPWZRJYR3mIuB6dt8zv96Y6Wm5XfShRoagcSsgxMGhAIUVrzT490GipYQjjbzW2hA4w0FX1LG6VOy9HJIERXLfOZVh6VFcu/cqtoPvTC2da8imq4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780674372262642.0131796755054; Fri, 5 Jun 2026 08:46:12 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVWk7-00061n-6X; Fri, 05 Jun 2026 11:45:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWju-0005fO-DF for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:45:43 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWjn-0006LU-GH for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:45:42 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-219-zTZhdmQcPKK22DDvcjLlNw-1; Fri, 05 Jun 2026 11:45:26 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E9A8718002C8 for ; Fri, 5 Jun 2026 15:45:25 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C40753000210; Fri, 5 Jun 2026 15:45:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780674328; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tKv7uKXevO2mwOyC4qHpjh1F8G+LrZIXjRyqb5hTmN0=; b=Bx7vInIZrsgR949VcC6lfh7kRpaW8ljxHa6/+MnNPmMfe/6IdbBrd9afVPO89ahkG9mxbG 4+J3ZeZM5GKhgyGgHHXuY4+xF30myiFX3dBZafblmPRTTMsZ+ynhWEf3Ri/qCmzEIFKKXF 0jHTEXhkfQrYGo7fNNrKD7Ql9BG5KVQ= X-MC-Unique: zTZhdmQcPKK22DDvcjLlNw-1 X-Mimecast-MFC-AGG-ID: zTZhdmQcPKK22DDvcjLlNw_1780674326 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Fri, 05 Jun 2026 19:44:31 +0400 Subject: [GIT PULL 11/23] hw/core/machine: free shim_filename on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260605-qom-tests-v1-11-3f184f382c2b@redhat.com> References: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> In-Reply-To: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=774; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=K+iwOApmpEnOaMk0KH5HYUgH1BE9LXcBH+NmGOZb1Go=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqIu7VxxaP19nb14e9z3igFexmBc/xWBBDoeD2a B8Uf1+H90iJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiLu1QAKCRDa6OEJdZac 5b5dD/4ggTuIzstLEcFskcsbuJOienyWnGfwScDw13A0qEPP9ueQQtTwexp87f5Zf99E02awMtv HxrZAW43s2t5PbV37/aHCyXrnI5cF5uEsdriiCH2CW26wqb6rL4W4F0V8PC6UubaWKCxZ4K0p8v gpUqvZm4nPD03cVhTggDMJ5WPghbkhOUf33lP7c25JvICrzBR+JEdCnoodzhGhofL5RFLhQQHN/ RsO5mMc/1sL+lhcwAcjQ0V7QJ4ItCAB0Opt7e0MTsLaMf6L0pbLFRwyOpvQFVt9v4De4d+dLJ03 pvuW7RbLzhv6YL8Upid21TeKIefKVzkCNEvn1fwoXb+99plMZUfyw4zHU5rwRgbdU7kkpvjR2TX nVkrKNEVJH1eoZSq5Zy/jgnQgMdOUvlqwix4ncdjKVMl6KqCFRm5W0/NrewlMqfPylUzZsIZ6JZ 2lZt2ma6NQlwX68LFaWGve//TQWeM0KrWhgntapP5lo1rvRsxaiNKZaYKzlGnruuegJibqAu+pk 95YPbOdKbPNDMdwHUTiVPWtI4y+m6/AvaLaLyC/rpMlcjRTeSroDNpEkElb1JC8aNgj+/0+JXgG OjZZo3fmrET0Giu5wkYPWHr8251cK5L7yZGvv7ZW4L7ttgIVhiM63J/9LSIxas31qzfFbQih6u3 DXz5N7LV/qVfKJA== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780674374514154100 machine_set_shim allocates shim_filename via g_strdup, but machine_finalize did not free it. Fixes: a5bd044b1579 ("x86/loader: add -shim option") Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/core/machine.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/core/machine.c b/hw/core/machine.c index 17970b78b65..4d8b15d99e9 100644 --- a/hw/core/machine.c +++ b/hw/core/machine.c @@ -1286,6 +1286,7 @@ static void machine_finalize(Object *obj) MachineState *ms =3D MACHINE(obj); =20 machine_free_boot_config(ms); + g_free(ms->shim_filename); g_free(ms->kernel_filename); g_free(ms->initrd_filename); g_free(ms->kernel_cmdline); --=20 2.54.0 From nobody Sun Jun 7 22:19:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780674372; cv=none; d=zohomail.com; s=zohoarc; b=CH8++6os08tN9blSm51Eri3dNTNZs95kIa6Xm19/Y7Tdj1oCaZnWC3hOU76BMy6DNoWlENdUMXYmw05UyxBLnJq2owuW2E54vzpcMqPI1DEePsAFuXwJEGaMa+OYCaG1PT4FhnqsS01MNPP+BixxiEbDCvn1mLv6vD7cr+mvTF8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780674372; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=dvtgUw0LsKgXWb3LBOponuFZWLxF4j1rwT2ki82oRjQ=; b=Xf4b8IguIned8FmGIyhyYlG9zs3yMq7o5mcH73O22qLBeLGvewumPsC2TYayiUEPszLmuSYcRAwyZlSmczHxJ7VIajh73xLS8qo8ovGCU3f3oQSNVtzKMKpfJk6MXUln/YLzBXdSrgltcZwtLdU0cz4SKiQYsIWYVmcyZ9uR4aM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780674372197203.67154198412368; Fri, 5 Jun 2026 08:46:12 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVWkJ-0006Hc-5i; Fri, 05 Jun 2026 11:46:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWjv-0005j2-Qa for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:45:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWjt-0006MZ-1j for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:45:43 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-316-6iooWXW3MaiT-1n6tvDGPA-1; Fri, 05 Jun 2026 11:45:32 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 71DC9195608C for ; Fri, 5 Jun 2026 15:45:31 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5BB411955BC0; Fri, 5 Jun 2026 15:45:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780674336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dvtgUw0LsKgXWb3LBOponuFZWLxF4j1rwT2ki82oRjQ=; b=DRFhXor84nX9JpvYwq6Ppy2VsIYkIhHa/dsoAr+C/qhwPm2LNa9CfuWB7Lsi0ohFwleRu6 NKyL+uyBGr1O6FyGdPSj4tgIeetsUQqYZjfc7Rei8Lf+0moNDAJnOkv6vBfTmWasb2GF5t xMeW+EgjRjqLY1R8B9MkgKEt0fjESrY= X-MC-Unique: 6iooWXW3MaiT-1n6tvDGPA-1 X-Mimecast-MFC-AGG-ID: 6iooWXW3MaiT-1n6tvDGPA_1780674331 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Fri, 05 Jun 2026 19:44:32 +0400 Subject: [GIT PULL 12/23] net/filter: free old values in property setters MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260605-qom-tests-v1-12-3f184f382c2b@redhat.com> References: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> In-Reply-To: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=1002; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=vSCX1oIavb9OdWbiPaCqHhj5OIrYz9DIRgOhx0so1ts=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqIu7V0hswmctlCcN/6a9g6va7JgUe4cYdNNUxH 4aiMxjnpbeJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiLu1QAKCRDa6OEJdZac 5SKPD/9DqIXNDcuVu8Cm22ErlNw2mGiQZWo7Z/9Fk8+Q4NYV+q5c5Qx1KkJnb5A0c44QC/aybn1 q1XjNht5930SUpytBNAIQ//AIB9asZ51PPGv5mvjRGzkhJoY6bO5Jk2uXey8pnRxQh7Jf1xMQ3g rqY4Orkn5bzPPxyOBjwcLYzcVWH7IdWGvr9ZDTowSB3rU5DI8vHLTLqeH5kPOjEwVoLHVbVmjcK y94vfVUj1N4HSmcNH9O5m+b+6Gr9HJ0E+s+BZBwEBZQzBHO8Ct511EXGvHhL2DJ6ES5Y5HyjaXR VDGYspu2QOpTpnAKmcsufXF0XVh67QOjaTHo2g9aUZfRG7kYIhmAskP4ays6ktL2UQekeyKbWlP Gy+ng0HGJFpGRlKw0xfKoAm2q3wqyuyo67bULh1KA4KOsB6KYb9bw7FtgGrqQBCmNKFuT+Z4plw qiokw9lMzx+4rEay2RVQKVBAgv929cxq1HSbdjCzbb7LJITfnA1XUiP3mgDgJCxUqpU9y4sYcFh fCbaWBybXN5vgICUOLmMTGGdQGCJa3P9aNW+wRuDPOpaOu7F968mvRZ0cVtb1voWQxlz9gcPAcE 7Hp6ZxGU7iopbLN+IqHEAM/TlMGipi3E+Xa0hjQlP7ZQpAp3ZqplBNIs06Ddu4PWPSfjpMRIOff N2LFjqVHDrNZXPQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780674373942158500 netfilter_set_position and netfilter_set_netdev_id overwrote their respective fields with g_strdup without freeing the previous value, leaking memory on each property write. Fixes: fdccce459621 ("init/cleanup of netfilter object") Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- net/filter.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/filter.c b/net/filter.c index c7cc6615dc9..389f3b0bfef 100644 --- a/net/filter.c +++ b/net/filter.c @@ -130,6 +130,7 @@ static void netfilter_set_netdev_id(Object *obj, const = char *str, Error **errp) { NetFilterState *nf =3D NETFILTER(obj); =20 + g_free(nf->netdev_id); nf->netdev_id =3D g_strdup(str); } =20 @@ -182,6 +183,7 @@ static void netfilter_set_position(Object *obj, const c= har *str, Error **errp) { NetFilterState *nf =3D NETFILTER(obj); =20 + g_free(nf->position); nf->position =3D g_strdup(str); } =20 --=20 2.54.0 From nobody Sun Jun 7 22:19:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780674423; cv=none; d=zohomail.com; s=zohoarc; b=OqZKC0pzJhP1Sv//tXgxkndO6fHH6iuFFcGcp0n1rn3PyNuzB/gdYZ3fGqTYZdydTXmeKPWpDygRQ4VCgZZEHTb/dpIMa6m6pfDnbGp/jzSUWQep2i8S1GqvyFskGEltIIwhIaE2lLMmd5db828w9gL8OkCC3XGNTwsLOwDz/NQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780674423; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=rI5KnFxPWO5qKPfQ5O52dnwywt+Y80Snw/Kjs9EvUlU=; b=nq36p5DYdxrMqrubXneDYUXI6AE0tGPID5aB3JaYotBh2KuRUBbk1qOmCkJvI38WA+0lU8cFPAFdKQ9K1aSLIc0gu0Y7lwrHKpjMdQttJ7Ui9UwRIiPxuRVOCVMAj9ihn2uJG/ZP17QudPxgEAgwPtCtph7gwpeDsNvGGPUZFAY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178067442360387.18911216667425; Fri, 5 Jun 2026 08:47:03 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVWkN-0006d2-SQ; Fri, 05 Jun 2026 11:46:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWjw-0005j4-3K for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:45:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWjt-0006Mq-1O for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:45:43 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-94-rkxPAftYPfGLdGvwz9dncQ-1; Fri, 05 Jun 2026 11:45:38 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 35C4518002C2 for ; Fri, 5 Jun 2026 15:45:37 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0026418004D4; Fri, 5 Jun 2026 15:45:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780674339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rI5KnFxPWO5qKPfQ5O52dnwywt+Y80Snw/Kjs9EvUlU=; b=T6xcglxkIugOHqPteZeL7/G+yS8xy9pYAmwrIy4GNbt4zqbxtttfhqCbiLTzUZLt4F+Lyn l4QAsHCxfy1civUzS9FjQEfGQHHN+UYA5hUjtTahLh228e3ROARmCgQwcGexJ/HM4xT77i 22K5VwPz+qiYHohNkZ2dpD/YLJSUNUA= X-MC-Unique: rkxPAftYPfGLdGvwz9dncQ-1 X-Mimecast-MFC-AGG-ID: rkxPAftYPfGLdGvwz9dncQ_1780674337 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Fri, 05 Jun 2026 19:44:33 +0400 Subject: [GIT PULL 13/23] target/i386/sev: add finalize functions and fix leaking setters MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260605-qom-tests-v1-13-3f184f382c2b@redhat.com> References: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> In-Reply-To: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=4141; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=KGDSEH4kXjPQ4/HoJgAVzmsrW3Gsd6zdda1I7EVwqgE=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqIu7Vl5ZK/+nOYGg6D6RBvaVugUDEJ8eiAYEm9 PkIHKLTP8GJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiLu1QAKCRDa6OEJdZac 5WecD/0eY9hRvGrDvKK9x4mdTrLhvKAanbaLyICQE+1LrT0GwUgme/pBYX/QUVeJyRb/ozohMjt C6m2i+Co5F3jFFwZNxhzQlcw22PLTpGyC0SER3F1eTV4LQ6OpcaXyJLHFBv5zVw+ooJJ0hU1Dmt awCBt63sdVD3TsR0KJmwURsq3T88nbK8lPI0wbcobP20IzVlULUCE8EQ5dL9Vsa/cW/m2Hnepes LXMNbcb9ktafrtfjZDpALqaxVP+PJNMegSRLTm9GS0vYL+SnbIglj3AYROB+NqnHW6yV+vdntvs pgtPj0lLZeQMErR9coEbdumTrc4aE8FpQmmkttSJqx3EeFEPQqOHnmWmNI1/zLrKkE6caGu9r8t G93PfNZ2vJIQvJmtGGTBLWJTreecM5gtfRkP2ljuYo2AWGPD5pzoszyvZO4bIusS9hyVU2JHV8v 7LW+U79nFQwDrkbItAO4zD60/wB1Yt1J4PGmAtFQ84eNhzvuPC7BXCeCs50ufHRBzNsJUO7U6mj Z7+J7ZNhUsVTAASIOIg0nC35DWMZsbcQ6RFY59x30BuoDBxhipqb/3GEn7xfmMeRKQ37yKHqg+B 1giJJCgEuJsd9rhaxvMYocJgGpAADro9DGORXjR1lWP8ef1W9pQsDRZOVQ7bNPoCIhiGXhVA2Tv oketZyWBDNi6Z5w== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780674424314158500 None of the three SEV types (sev-common, sev-guest, sev-snp-guest) had instance_finalize functions, so all string fields allocated during init or by property setters were leaked on object destruction. Add sev_common_finalize, sev_guest_finalize, and sev_snp_guest_finalize to free the allocated fields. Also fix sev_common_set_sev_device, sev_guest_set_dh_cert_file, and sev_guest_set_session_file to free the old value before replacing it. Fixes: a9b4942f485 ("target/i386: add Secure Encrypted Virtualization (SEV) object") Fixes: 7b34df44260 ("i386/sev: Introduce 'sev-snp-guest' object") Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- target/i386/sev.c | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/target/i386/sev.c b/target/i386/sev.c index b44b5a1c2b9..99cf30806be 100644 --- a/target/i386/sev.c +++ b/target/i386/sev.c @@ -2526,6 +2526,7 @@ sev_common_get_sev_device(Object *obj, Error **errp) static void sev_common_set_sev_device(Object *obj, const char *value, Error **errp) { + g_free(SEV_COMMON(obj)->sev_device); SEV_COMMON(obj)->sev_device =3D g_strdup(value); } =20 @@ -2830,12 +2831,21 @@ sev_common_instance_init(Object *obj) QTAILQ_INIT(&sev_common->launch_vmsa); } =20 +static void +sev_common_finalize(Object *obj) +{ + SevCommonState *sev_common =3D SEV_COMMON(obj); + + g_free(sev_common->sev_device); +} + /* sev guest info common to sev/sev-es/sev-snp */ static const TypeInfo sev_common_info =3D { .parent =3D TYPE_X86_CONFIDENTIAL_GUEST, .name =3D TYPE_SEV_COMMON, .instance_size =3D sizeof(SevCommonState), .instance_init =3D sev_common_instance_init, + .instance_finalize =3D sev_common_finalize, .class_size =3D sizeof(SevCommonStateClass), .class_init =3D sev_common_class_init, .abstract =3D true, @@ -2855,6 +2865,7 @@ sev_guest_get_dh_cert_file(Object *obj, Error **errp) static void sev_guest_set_dh_cert_file(Object *obj, const char *value, Error **errp) { + g_free(SEV_GUEST(obj)->dh_cert_file); SEV_GUEST(obj)->dh_cert_file =3D g_strdup(value); } =20 @@ -2869,6 +2880,7 @@ sev_guest_get_session_file(Object *obj, Error **errp) static void sev_guest_set_session_file(Object *obj, const char *value, Error **errp) { + g_free(SEV_GUEST(obj)->session_file); SEV_GUEST(obj)->session_file =3D g_strdup(value); } =20 @@ -2936,12 +2948,23 @@ sev_guest_instance_init(Object *obj) sev_guest->legacy_vm_type =3D ON_OFF_AUTO_AUTO; } =20 +static void +sev_guest_finalize(Object *obj) +{ + SevGuestState *sev_guest =3D SEV_GUEST(obj); + + g_free(sev_guest->dh_cert_file); + g_free(sev_guest->session_file); + g_free(sev_guest->measurement); +} + /* guest info specific sev/sev-es */ static const TypeInfo sev_guest_info =3D { .parent =3D TYPE_SEV_COMMON, .name =3D TYPE_SEV_GUEST, .instance_size =3D sizeof(SevGuestState), .instance_init =3D sev_guest_instance_init, + .instance_finalize =3D sev_guest_finalize, .class_init =3D sev_guest_class_init, }; =20 @@ -3194,6 +3217,19 @@ sev_snp_guest_instance_init(Object *obj) sev_snp_guest->kvm_start_conf.policy =3D DEFAULT_SEV_SNP_POLICY; } =20 +static void +sev_snp_guest_finalize(Object *obj) +{ + SevSnpGuestState *sev_snp_guest =3D SEV_SNP_GUEST(obj); + + g_free(sev_snp_guest->guest_visible_workarounds); + g_free(sev_snp_guest->id_block_base64); + g_free(sev_snp_guest->id_block); + g_free(sev_snp_guest->id_auth_base64); + g_free(sev_snp_guest->id_auth); + g_free(sev_snp_guest->host_data); +} + /* guest info specific to sev-snp */ static const TypeInfo sev_snp_guest_info =3D { .parent =3D TYPE_SEV_COMMON, @@ -3201,6 +3237,7 @@ static const TypeInfo sev_snp_guest_info =3D { .instance_size =3D sizeof(SevSnpGuestState), .class_init =3D sev_snp_guest_class_init, .instance_init =3D sev_snp_guest_instance_init, + .instance_finalize =3D sev_snp_guest_finalize, }; =20 static void --=20 2.54.0 From nobody Sun Jun 7 22:19:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780674374; cv=none; d=zohomail.com; s=zohoarc; b=DSPeRj0w1oP/2ogRSlV4EVDW6oomyinC7yljhzXp/o9pglooqw38XRDoJBjqo98gP65SxbKhyzT/fTCd4c+VtKBjus+PLeDOcNdkdr+gY9u28kGNhD9A+qh10CDWF0kSVcsklLLNXbNZko/T2bKlP7dvMzvg3SVYbOKvOSfR0oA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780674374; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=oChfGW5Tq+2XS1SV5t1cQUIYoRVR7500LonYw5rznpg=; b=QUkyKmxANBaoByLUpcNjEpMuSWAPKYic58vHPG6KTDKUvK70lKzzvrU4qQxWfIqxngJsif9ZMv941ygOdbP7qyMR/0UGAEFMnsPt9IMfHxQQiL0hN5c/5CLDL6W6Jmo1riBZjl9B9V2wZqtIoMO+iEHlrMcRwH14vrGg1d8A5SQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780674374633253.58443950210176; Fri, 5 Jun 2026 08:46:14 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVWkN-0006Yc-7B; Fri, 05 Jun 2026 11:46:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWjz-0005pP-Kg for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:45:48 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWjx-0006R8-VK for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:45:47 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-677-nxvewf5uPqGNWqfNT2Hi7g-1; Fri, 05 Jun 2026 11:45:43 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7CF921944D3B for ; Fri, 5 Jun 2026 15:45:42 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 7347E180049F; Fri, 5 Jun 2026 15:45:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780674344; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oChfGW5Tq+2XS1SV5t1cQUIYoRVR7500LonYw5rznpg=; b=EBgeTEilVAEQbP5TkqsM8S8/bsYmztuVTTyp8B3LoYllWdLzecKRQ0jH9+JrhbfIkbZDir EaqVL9gFQlyKwCLyYYlz76fZ+0XD33OjGR9hk8WcKqid+u2tb9g0iIVqVFpm4F7t2yVf6t hw2wfI3qx6SoSeAkboT2jqyvdDgJjZ8= X-MC-Unique: nxvewf5uPqGNWqfNT2Hi7g-1 X-Mimecast-MFC-AGG-ID: nxvewf5uPqGNWqfNT2Hi7g_1780674342 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Fri, 05 Jun 2026 19:44:34 +0400 Subject: [GIT PULL 14/23] target/i386/kvm/tdx: free strings in tdx_guest_finalize MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260605-qom-tests-v1-14-3f184f382c2b@redhat.com> References: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> In-Reply-To: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=893; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=DafxdRB7/MLkueWJrLE2w1Qd3zyBZmU4Trf2EjVE458=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqIu7VxQnHWL0kb0HMM9DjapnsY/wpon/kfpDN3 BCyWxwOCsqJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiLu1QAKCRDa6OEJdZac 5daDD/sHBhngmO7+5ST/REwMGs9R2myXdfB/2DaWtBjj316/p2OJ/cA7cCZemqJxP7AgqgYCFvU wcqQO2pWHsdA30Wse8C77Ga2fUnJ1829EnwV5NVVaK4hEm3xLRaA7LQARq0o7MCFmdXLUpRWLeW BU6+EE3KO0rpfn6jIujygHpp+HNqtsMQG1a/YBbwqnH7lkFb5OIX00c0hNjjY/jbAS5E/585r/O bY4tiQasp/+NlYnGAaZ0OW6Mf4ELOtM0Re0uSw7vbQDeSOTXvYquxU7zUACtErTqwnWbao50YRY vbjtrPGXUgEHbAtRIToIDA+gHxgJHSmi7+zMlVlALCQ9qfSBZpLgDbaBSdfARYLI7+dDogy+JHC KKAatAriypq2M1Z/uzynr/pX4nOPpmbzbiygqxNhCblegUYPyYe2iY38uauVqtRCLGIQ5jXMBEf ufC7tBr5GDVcTg+j+UPSq6UIKB8s/pNWSpmCHNRgAyStPfEp/fONGPCtyyzyeetzeG1T8A9jkKF 3OF6lMYgbStenjs5hIeRh23DwS+n1pdLYeVDecJquMUJ8dSSpAdRxs/f36XT8G2rqRmXonZ3rXa RZ5JJc0friVVVJ0VqkWrp81Sfbcoz0/Ryl6R+Jrnf4oF4zUqSpShwj4qGcQj7trYZZHlZ7wmDNt HuZM3YoKj61lLjA== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780674376492154100 tdx_guest_finalize was empty, so mrconfigid, mrowner, and mrownerconfig set by property setters were never freed. Fixes: d05a0858cf87 ("i386/tdx: Support user configurable mrconfigid/mrowne= r/mrownerconfig") Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- target/i386/kvm/tdx.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/target/i386/kvm/tdx.c b/target/i386/kvm/tdx.c index 4714c9d514e..df46fce7693 100644 --- a/target/i386/kvm/tdx.c +++ b/target/i386/kvm/tdx.c @@ -1585,6 +1585,11 @@ static void tdx_guest_init(Object *obj) =20 static void tdx_guest_finalize(Object *obj) { + TdxGuest *tdx =3D TDX_GUEST(obj); + + g_free(tdx->mrconfigid); + g_free(tdx->mrowner); + g_free(tdx->mrownerconfig); } =20 static ResettableState *tdx_reset_state(Object *obj) --=20 2.54.0 From nobody Sun Jun 7 22:19:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780674450; cv=none; d=zohomail.com; s=zohoarc; b=UrgawZUfA5/Y0pNhCtlVahN0RVmKU5zrK7GpNKWAgTq19EvCyY9oeymxyufvmGXEkgvJnq2DwuF6wZHZGIZn3gnkE/ag6iMdhIVnN3McP6YSayimt+8rdj4JcF45xrW5CevaN2qcacQAbs96r7Q1rS0x6phLT7BoiTb3cV9spsk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780674450; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=flPmDRwJi+ybUNe2kHFSb0m1RU2KLtvltS5ncicUaW0=; b=h4LKhCWja8Z9QgjrZIWlyxvbPO6ew+8m2QEAq8BZAmWx/iusxoiqAwIOazv/AYs0OT9sdTIHA1wVclchfkc2W/6LjxZygsUAKWOEZJixt5oAAEilQlji6Hc29f5FV7E64a7VUoxya6SW10m5vL3nX1SKO5Pg0hUBqpaGt6AoEMc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780674450732565.6347165327578; Fri, 5 Jun 2026 08:47:30 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVWkL-0006Q2-8P; Fri, 05 Jun 2026 11:46:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWk6-00064r-SW for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:45:55 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWk5-0006U9-AI for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:45:54 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-355-pIOdAD00OoeGpAVa6PWr3A-1; Fri, 05 Jun 2026 11:45:48 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EA0ED1956089 for ; Fri, 5 Jun 2026 15:45:47 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A6C521955BC0; Fri, 5 Jun 2026 15:45:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780674352; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=flPmDRwJi+ybUNe2kHFSb0m1RU2KLtvltS5ncicUaW0=; b=OSxwrH1jAhKOOE/xKt37+qctQtz90InitzNV+dhzZfYxLFVk1lDhAtJvU5xE8nvgr8pQE7 DpG8klRcWsqKgHqg5Nu7Cav4KNSi5vBvKexiuwLnyUEgo4oPx3RU0lRqpS2NOQBjONsLc1 1+GAL07zfC7KLQWJwQT8H7cTEU4ulcs= X-MC-Unique: pIOdAD00OoeGpAVa6PWr3A-1 X-Mimecast-MFC-AGG-ID: pIOdAD00OoeGpAVa6PWr3A_1780674348 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Fri, 05 Jun 2026 19:44:35 +0400 Subject: [GIT PULL 15/23] hw/i386/nitro_enclave: add instance finalize MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260605-qom-tests-v1-15-3f184f382c2b@redhat.com> References: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> In-Reply-To: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=1483; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=3C7niU2OJQvZnNEzM2kL0E6yy2/Uxqq6Etx4xtM0Tsk=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqIu7VqIeUwmfQOglxCjl3kt7MTfu2svjo/Hcte quREx9aDsWJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiLu1QAKCRDa6OEJdZac 5dDNEACmqd/GqF2rzrF5Hbk/wuowy8fK2rgT28J3UPfj4j8ckYzF5I1K6eZcMFgHXrbyEXRQl/A MbPHAP1eMZ0nIoqE/E+gi7PFR+TBQbCxT/OUBOwtGMzbr2x4lUMEkQqE8WqBaQ9h8mfPlFiXqpI 9Ls+D7eTGZ8Fr17JDPoe4Y/wiR4hDu/K5ZomUHoI9c9UIFu59Mh1jkBIk/A0crOziYK0oeDjii1 QR07GtaJdiCAvZFIT+rJtyIxSpaqlRH9byRx452t61Lxy8uP9zY0ZMg7QHrQhh6WfHc+XbnkkTs pJfLUCj6qO21DMhXNN0Hgx1+Ybd8b47tVIp9eaq853og3aeEOsTRlcSjMSK/oelahQMXfy9B52A HHuGgXeHTvRD0YGU92XoWkWmpLYWih3iW8bmxNH4Q5kS4G4sbMKi5Wfh67f8SgOYc8WlVryasVv atbdj+gOdhHKoCb5HhuarESkU8UyI0acnms55E8N09z1Y2mE8VXkParspQz9VZWGLqZMahyqbTP suLUri9nXVlQm2rjrp63UpKgAmVRoWu7JSBfZ3a5K2DZL8+Nfb8/0um5DYupRn1MedFeDg3MTLt IoyDQ968henp0QLka0Us9vvqwy66WbWGSLVO6JV4+kecHK+GbKetv5CRVdBixAkp2PjDQtyzYwR N0VlWU8t9wPgpKg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780674453752154100 Property setter strings (vsock, id, parent_role, parent_id) were never freed because nitro_enclave_machine_info had no instance_finalize. Fixes: f1826463d2e8 ("machine/nitro-enclave: New machine type for AWS Nitro= Enclaves") Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/i386/nitro_enclave.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/hw/i386/nitro_enclave.c b/hw/i386/nitro_enclave.c index a29f0044d0e..1ce9ee3358a 100644 --- a/hw/i386/nitro_enclave.c +++ b/hw/i386/nitro_enclave.c @@ -337,11 +337,22 @@ static void nitro_enclave_class_init(ObjectClass *oc,= const void *data) "Set parent instance identifier"= ); } =20 +static void nitro_enclave_machine_finalize(Object *obj) +{ + NitroEnclaveMachineState *nems =3D NITRO_ENCLAVE_MACHINE(obj); + + g_free(nems->vsock); + g_free(nems->id); + g_free(nems->parent_role); + g_free(nems->parent_id); +} + static const TypeInfo nitro_enclave_machine_info =3D { .name =3D TYPE_NITRO_ENCLAVE_MACHINE, .parent =3D TYPE_MICROVM_MACHINE, .instance_size =3D sizeof(NitroEnclaveMachineState), .instance_init =3D nitro_enclave_machine_initfn, + .instance_finalize =3D nitro_enclave_machine_finalize, .class_size =3D sizeof(NitroEnclaveMachineClass), .class_init =3D nitro_enclave_class_init, }; --=20 2.54.0 From nobody Sun Jun 7 22:19:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780674458; cv=none; d=zohomail.com; s=zohoarc; b=nalb++EecU5hH3qV/JCKeTwxHHZ3+fLo42r0/89LO/v91V5rYvvZTC1Bj3juyt1fAH/VDjjVG0vGPthGHLLCSD2/YdIBYPcUA9LkFp9bOSkS+4nJ0pVyqfcuO6QWMIvEX/DFAZpRTxPaAmvTxXevQ3jOlYnqISu92CtrKAJ6yCk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780674458; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=vs+pOjW26KjxQCHZrQ+kCzdjFkWO5ZRcdNEGFNTZkO4=; b=ZYKJ18nM2xZTjaxHjCLe58giBNfPb1N3lGmbDBIjUFQ1DSoZCvNOMvIdKjClBPLMZj1MoGGSfDz6HykuuRSehBa9HurWijHdRGQ7jn8Z1N9GrudN+S5LqQo/pMPqjHXwO3PEJITWhnpbYtGHtx0xIqRv2nn7EG/i1/eSfHLyy5Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178067445807382.10213857152303; Fri, 5 Jun 2026 08:47:38 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVWkR-0006l4-1c; Fri, 05 Jun 2026 11:46:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWkA-0006BK-AP for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:45:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWk8-0006Vr-G0 for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:45:57 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-662-JKEX8Pf1NEqZbirYFSfTng-1; Fri, 05 Jun 2026 11:45:54 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A758418005A9 for ; Fri, 5 Jun 2026 15:45:53 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 83C391800480; Fri, 5 Jun 2026 15:45:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780674355; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vs+pOjW26KjxQCHZrQ+kCzdjFkWO5ZRcdNEGFNTZkO4=; b=CQby+UNq423ZQj/BSKHvpAdYW1ENXyeA3l3qt/4jR7MyIJtU7Jg9nhbdMo0VXwwEu9/2en DSrLzVyARLRaw5o5Jl53dTI7aFj6DceMa6Pr2IOxPkMwyU8pkaswELMPMc1kKUnO/BCzjt 8LV88fOLi3SoyQetsvzsN2s+4N2OzQE= X-MC-Unique: JKEX8Pf1NEqZbirYFSfTng-1 X-Mimecast-MFC-AGG-ID: JKEX8Pf1NEqZbirYFSfTng_1780674353 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Fri, 05 Jun 2026 19:44:36 +0400 Subject: [GIT PULL 16/23] hw/i386/pc: free pcspk on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260605-qom-tests-v1-16-3f184f382c2b@redhat.com> References: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> In-Reply-To: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=1290; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=GcZTfkVfLUK9g6SdJBjC2sL2vzj7syFt54aMh0Kvqn4=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqIu7VZ2F7yyVeXQPuIrwA8KgSkSvbSsiVy0BjL S3ObJJPnfWJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiLu1QAKCRDa6OEJdZac 5X7qD/4iKA2F8Q4ZK8kyng4a3FXcZLNGgapwLy+kl4r5x0xtEMc1Cc5ktwFSqG5zoiWYmTeV1L/ ETVRSGUUYL7raP9XAOweXSK44RDb2poBRZKDKzBT/iCT8d3xSfS4/ezZ4WwzWrUHTg7mfkAx3xr EkckDt9RiXTzVmyzx4lDC9x3YgyBeYGDrmJSjsPi/1zw196M+n1wZNwDWR49UH21ajfKo/6GTB1 Ky1vuLdJ4XK40cs6B8JIsxKWul3puS7aiJTXSVfsQliF2gpzLuf0iQG5zwpLOEnf21TEjK7LG3B sVIb7WOdtz5UYLYRGY7Obtge/hWiBqltIzS7qMCOZIMLXEN070gofBAtPLA3Zokr2rzZGVp+yLL CrgWM/00/AZgY2qzpfxhP0KqG5WCNc2Ll0tjhbAKWCyQ/Um4ZVclx4x09LpsR4gj5MNq5fA0bGK gTDjNefzr9hY6ox+rHS3ocVYbfAQ+yQc0EOlljTzNQkRjEm0I27jfP1Qm6LBrCEZm6lpYq8uRuH Ym/V9f0V6ST715QT2J929J7Dm52tnd0QKhsrQUbhnfDZ3I/TxMB22JGP+TaQ+KF3al4rs/DnKRY Sff9O7Hh4FR7Gv7JELIwVnGFAVCUkkgrIi+Utwxcv/TwNL/8bXJv4yIOz2L0b0evDHhyJ3EWSi8 gcZT1p5DBShQ+kg== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780674458518158500 Add pc_machine_finalize() to unref the pcspk device when it was never realized. Once realized, the bus owns it and no action is needed. Fixes: 6b8d1416482f ("audio: create pcspk device early") Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/i386/pc.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 2ecad3c503f..7b6ad97e5a9 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -1610,6 +1610,15 @@ static void pc_machine_initfn(Object *obj) } } =20 +static void pc_machine_finalize(Object *obj) +{ + PCMachineState *pcms =3D PC_MACHINE(obj); + + if (pcms->pcspk && !qdev_is_realized(DEVICE(pcms->pcspk))) { + object_unref(OBJECT(pcms->pcspk)); + } +} + static void pc_machine_reset(MachineState *machine, ResetType type) { CPUState *cs; @@ -1748,6 +1757,7 @@ static const TypeInfo pc_machine_info =3D { .abstract =3D true, .instance_size =3D sizeof(PCMachineState), .instance_init =3D pc_machine_initfn, + .instance_finalize =3D pc_machine_finalize, .class_size =3D sizeof(PCMachineClass), .class_init =3D pc_machine_class_init, .interfaces =3D (const InterfaceInfo[]) { --=20 2.54.0 From nobody Sun Jun 7 22:19:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780674424; cv=none; d=zohomail.com; s=zohoarc; b=gvhAeIY0DYlUk0NgGnEGY9cfcdC/PK4MMgyb7/F1ihalNGcyrDwCNDidZezE/DzwMTFlAsDWKKpvUyV2fg0OAcshD79xrQzSTrIXnchYc4DVUaryH6T1fQcinMzKraGQqr0CsfDh7fYq33p3dmromjtiEVQBlDXLZ5BzIYCwHkI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780674424; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=0HsSS9H0XnFqDg98btc/iipFx5pPynADB1oSYq6cxGQ=; b=Opf2xcjDz0NJPAzFQ6Xy8PUZ8CeHEB0FYOdjNAqnHICOj1dcLSuBFT+lbX/kXyPphJCuPsaNMYFYJA1XrW9EG7mxcF8olGXwQ49zuM81uGyascvv4HdTxIhWMOjDhss+n2yjK9VVqvPzrQHGyuVMG10CQAgDDYkMv1G68brJQbM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780674424244922.8685229115089; Fri, 5 Jun 2026 08:47:04 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVWkS-00072I-CL; Fri, 05 Jun 2026 11:46:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWkI-0006HD-AG for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:46:06 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWkE-0006bS-V5 for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:46:04 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-81-JZiQhlI8MHaSDdHhoP0tdA-1; Fri, 05 Jun 2026 11:45:59 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 20689180048E for ; Fri, 5 Jun 2026 15:45:59 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1874D765; Fri, 5 Jun 2026 15:45:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780674361; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0HsSS9H0XnFqDg98btc/iipFx5pPynADB1oSYq6cxGQ=; b=TrAiPpQkCQG4jC5fu7CVv+4grdsCPeg9L0EdXS+J+cw8YJtTB7ucV7rJhUf9UMtnadNBjt nLrhnNW1Dq+CCQjb3Ip4SSef25jjJni5Dv/fmP4g3PjI0pXVYl+Xos4U+GcZutzXZrOIzV txVenKRZo2hWaFEETXaqidtiu4ukmVw= X-MC-Unique: JZiQhlI8MHaSDdHhoP0tdA-1 X-Mimecast-MFC-AGG-ID: JZiQhlI8MHaSDdHhoP0tdA_1780674359 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Fri, 05 Jun 2026 19:44:37 +0400 Subject: [GIT PULL 17/23] hw/tpm: free PPI buffer on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260605-qom-tests-v1-17-3f184f382c2b@redhat.com> References: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> In-Reply-To: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=1310; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=5CtS+EWJo3M/jWSkTkfccFTnWRkzlJxRsPCSKv4FqPs=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqIu7VnS6p5r3bLN8trD0H3643Lj8IIOUiX6lML b4qow9YpnaJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiLu1QAKCRDa6OEJdZac 5UIoD/9dfPjJ6ROD5KSSe1R3CkdVfQi8Q7ZT0Ka77GfKFxyv+FnoFDCKOvy7DncBXIGbYI29cna PsNOA86iT9suJrNknSmYPRjw8qyd1DqIqAEo7+OGkRov8PDuiRWrG8eSCaaPGybnJh0ZJz97GCq /7ryvk0IyJJxqMQsZWNgVy0++ad7uSIcHjjz+anZkmqbvtrl4dMZwKrcW0Qc8oAvDrmRA18vox4 TSpLEO39KOBqrMs7PMwuVfRH4tTXJ50Zzef5lRYW66cTxGr2Sa2VfCpPo9e3HBo2S9t4JbyjF6V dyq51SZpRKL5VLIkN3U/e7h9KMwa97aFNg8muXud1h8cLZgl5ZKa4MT2zTuqKvuGwCMVJVaPJ4L sKmESGZWho1JrBnABAkUxO0FtgaLkg/e4tN1H3h2hXDsCvhXtyN9Y3+pa1/aWqyo4RlXCAKkxea rJcTUVqmSyS+o/nZ/ChgN/yyY2kacLqboUJSLvu0ajPusgTdgPznGQeX03DZtPmcZ1vcuIgc0m1 ugwqV7fO2irL7WfVe8MCD9quLSeyKTPGlLL5bBmT1V54nAcMjac9ujVAm7Pm06Z32la4/DInA0p 46thYBMraPVU83t2sduttwIcXDQJ7xKMYqjgQ/vznzxrLytblxC2dbxM5uj/77Sh8M//fnzEawO 5KJ2N0cdc7JGERA== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780674426327158500 The PPI buffer is allocated with qemu_memalign() in instance_init but never freed when the device is destroyed. Fixes: 46cd2c1050f0 ("hw/tpm: add PPI support to tpm-tis-device for ARM64 v= irt") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Stefan Berger --- hw/tpm/tpm_tis_sysbus.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/hw/tpm/tpm_tis_sysbus.c b/hw/tpm/tpm_tis_sysbus.c index f9cd1c8b5c6..16bb17874b8 100644 --- a/hw/tpm/tpm_tis_sysbus.c +++ b/hw/tpm/tpm_tis_sysbus.c @@ -148,11 +148,20 @@ static void tpm_tis_sysbus_class_init(ObjectClass *kl= ass, const void *data) set_bit(DEVICE_CATEGORY_MISC, dc->categories); } =20 +static void tpm_tis_sysbus_finalize(Object *obj) +{ + TPMStateSysBus *sbdev =3D TPM_TIS_SYSBUS(obj); + TPMState *s =3D &sbdev->state; + + qemu_vfree(s->ppi.buf); +} + static const TypeInfo tpm_tis_sysbus_info =3D { .name =3D TYPE_TPM_TIS_SYSBUS, .parent =3D TYPE_DYNAMIC_SYS_BUS_DEVICE, .instance_size =3D sizeof(TPMStateSysBus), .instance_init =3D tpm_tis_sysbus_initfn, + .instance_finalize =3D tpm_tis_sysbus_finalize, .class_init =3D tpm_tis_sysbus_class_init, .interfaces =3D (const InterfaceInfo[]) { { TYPE_TPM_IF }, --=20 2.54.0 From nobody Sun Jun 7 22:19:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780674390; cv=none; d=zohomail.com; s=zohoarc; b=lCoiS+gD84+FITmvgyKkZLarHwy/ko5TDjL77OCOY/vll6SKfl7OZ9wP8NTsfT9sw1VRjZ36tKI+wxtj5ADdo74KXyV7dhKnLZFHg5KjvFs2Rh+CSXUnvG9aShLPaRMmKbby4O18VvfUUN2O2keIGVXoZiOgPEH2E1rJnGlV+zs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780674390; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ChO/3Bdzy1ataNflAM07S9oKMcRpR+opteLb5ymzCsk=; b=nWYHxqp/eroQQmCF0qubP4jCH+cr5D0pGdJRn6KhwgAynZHyss8FIn7Lk3ZMDfaoBMgjmQjHFEiycAFUgBjkSvUDGiitPKIfnQxnLWqaK0Eu80e61C0qDHGnqjoKN1jiSbNrjGHXTOMP8Ebs507xR8RmJtKtDADp68YvQfmCyUo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780674390243196.97448107853893; Fri, 5 Jun 2026 08:46:30 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVWkV-0007LK-Fh; Fri, 05 Jun 2026 11:46:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWkM-0006aF-W5 for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:46:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWkL-0006d4-Iy for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:46:10 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-659-Dc2Z6PHfP1ig6irMCI3kIQ-1; Fri, 05 Jun 2026 11:46:06 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 82A651956048 for ; Fri, 5 Jun 2026 15:46:04 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5ADB11955BC0; Fri, 5 Jun 2026 15:46:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780674368; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ChO/3Bdzy1ataNflAM07S9oKMcRpR+opteLb5ymzCsk=; b=GVTMT6jRURzoykpzO0S6N674Sr5ytC7ptqguS3ikA58RMVT/ykRYszTPYX9caqcH/5ERxu v5d6/P2Ru1tKi1y1tYRkAL6nIMweW6pZHT4BIotDOMOhFlT7Fiq0JQ08ov/KoTVRfP2YKJ n4z86djfE9tHlUKOZr1TWkG46VwJ7iY= X-MC-Unique: Dc2Z6PHfP1ig6irMCI3kIQ-1 X-Mimecast-MFC-AGG-ID: Dc2Z6PHfP1ig6irMCI3kIQ_1780674364 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Fri, 05 Jun 2026 19:44:38 +0400 Subject: [GIT PULL 18/23] hw/loongarch/virt: free flash devices and OEM strings on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260605-qom-tests-v1-18-3f184f382c2b@redhat.com> References: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> In-Reply-To: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=1821; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=O20pvfV7LycxXxxIqAxpoTODskHXvK4B1EMEAyeU4tk=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqIu7VlXqs2qHYpT4ogNa1eS5veskmiP/8c2KGd mswqj1ZP+6JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiLu1QAKCRDa6OEJdZac 5SEAEAC4wiToxbC1E5cEHBHWcqrLbJl1ZyxUf0HAQpiun9gdqHqM75xbngL2DPbLLdZ9VANKb8g J13KAOZKkF00L201v3JnXR4L44dRawln8GZBe2tlhkUWh56zKWe/DGaKAnNuPqYpvkj2B3o0sMq R9m7LGnfkp0bN+qFx3up4GHQa9rdz9TPjMCpyG1WI17YB+aWC5JrNpRD99sBsNyMnVjU3fR2z0C wmMbq5C2MaHZznV3yGRzzcPEjAIq0IRI7NLubPLi0/z2O3Edr6bHx0lSO4LWLo17E4ucAdXcxoI oATUg57wAlKObyGJyTXG7zBJFsLQncdQ3qv80YKUFd/bt12Y6AIF2yGF78nDrkTt07uEnY00zmF e6rdOMiKw66jI9mL4Kasj1Gfr3YO4qNRNMZ4iD8TRse/65BvFf1+8AVWWYQjOBmqsNf7avIT0uv 5bkKbbpUjod6W2TfABB1xFwK5LnkiyhUA1tzXXRXYJS0skcUXb0/z2HocBuyigjqVEVvf+jEV79 qXz4wA80ZGkgMZwA/YaXk9lA9BWNfW6by68XPMg+RIdEZmhkL7RpDKjdy7mBmsEZU11Sl3cFV5I lNliOunFXVFyo2TtGlemAaco/p6lfxQ6Q4JZk4zxkQDRm78D8VrRv5AEyI9iQPBrrVq5OyRnMAO 1Od6lrWlKLe1H4Q== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780674392066158500 Flash devices created in virt_initfn() via qdev_new() hold an extra reference that is only dropped on sysbus_realize_and_unref(). When the machine is destroyed before realization, the flash objects leak. Also, the oem_id and oem_table_id strings from g_strndup() are never freed. Fixes: 445c9c645 ("hw/loongarch/virt: Allow user to customize OEM ID and OE= M table ID") Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/loongarch/virt.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c index f68ccdb12b7..6693dea647b 100644 --- a/hw/loongarch/virt.c +++ b/hw/loongarch/virt.c @@ -1566,6 +1566,19 @@ static void virt_class_init(ObjectClass *oc, const v= oid *data) #define DEFINE_VIRT_MACHINE(major, minor) \ DEFINE_VIRT_MACHINE_VERSION(false, major, minor) =20 +static void virt_instance_finalize(Object *obj) +{ + LoongArchVirtMachineState *lvms =3D LOONGARCH_VIRT_MACHINE(obj); + + for (int i =3D 0; i < ARRAY_SIZE(lvms->flash); i++) { + if (lvms->flash[i] && !qdev_is_realized(DEVICE(lvms->flash[i]))) { + object_unref(OBJECT(lvms->flash[i])); + } + } + g_free(lvms->oem_id); + g_free(lvms->oem_table_id); +} + static const TypeInfo virt_machine_info =3D { .name =3D TYPE_LOONGARCH_VIRT_MACHINE, .parent =3D TYPE_MACHINE, @@ -1573,6 +1586,7 @@ static const TypeInfo virt_machine_info =3D { .instance_size =3D sizeof(LoongArchVirtMachineState), .class_init =3D virt_class_init, .instance_init =3D virt_initfn, + .instance_finalize =3D virt_instance_finalize, .interfaces =3D (InterfaceInfo[]) { { TYPE_HOTPLUG_HANDLER }, { } --=20 2.54.0 From nobody Sun Jun 7 22:19:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780674402; cv=none; d=zohomail.com; s=zohoarc; b=jx7CFhmtgrukVrm6nThQ7demJ3odNYgXswTWCBOQWcMk3tdPBHgS5AEM69zHwpoMx7C8tC840AGbfdZv88TyQqU5BsiiurCE+hbD+zRuGqWVJ3XDV45W1BI09RIaNQdkra5Q+V7wGNREJCKOOx6LdUq3vNP6sJTeLJoZuo/nfeg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780674402; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=xzKJ/IpdkG01bM1txdqjhoLFTRAUk3+pG2IUFauAHiA=; b=X1jmZ5lgXgh3hymHMGHFbaA2A9lEnjikp9ca3Uc9Cjg/cNs56gQuueU/Ahjgi+ubO/DXs+ZA0dbsA1B4+dW2ypsTSqmPemU/OF9pzPW4dRydCgSgP8l5GKqMzgWJ1iT38yftJcB4niMtqxdhUmuevP6qsa3KO0FPXmmuUk8Z0a8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780674402640627.3564701414734; Fri, 5 Jun 2026 08:46:42 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVWkY-0007XT-JL; Fri, 05 Jun 2026 11:46:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWkU-0007IS-PC for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:46:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWkS-0006eX-V9 for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:46:18 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-507-kfrPdyUuPxOH0_SCBZ3Djg-1; Fri, 05 Jun 2026 11:46:10 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1301B19560BB for ; Fri, 5 Jun 2026 15:46:10 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id DC3743000233; Fri, 5 Jun 2026 15:46:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780674375; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xzKJ/IpdkG01bM1txdqjhoLFTRAUk3+pG2IUFauAHiA=; b=Kw0CKeGmtHG7V8wTJ8Aomhv6sQRVcBRGbKrDDIv7Qq9k/uW82FZiMwb7tfO2eiCtDqAwCw 12rYs4thrmTrH7eKD47KR/hg40Z/3ewUyvEBua6MmtsWM/cm03r7N2LpL4pfAVIF45z1Bt ktNewyVRCJ2+eQaN2WmxpvUy0as7nbk= X-MC-Unique: kfrPdyUuPxOH0_SCBZ3Djg-1 X-Mimecast-MFC-AGG-ID: kfrPdyUuPxOH0_SCBZ3Djg_1780674370 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Fri, 05 Jun 2026 19:44:39 +0400 Subject: [GIT PULL 19/23] hw/ppc/spapr: free host_model and host_serial on finalization MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260605-qom-tests-v1-19-3f184f382c2b@redhat.com> References: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> In-Reply-To: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=867; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=EFDae8u7ennK5lGTEip5Z4TCCmPwbTBDCnezXm8A95s=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqIu7VHf6B25R5xxY0+GkkSvLOUbAe5GeyT8/gz WWKsYaYacSJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiLu1QAKCRDa6OEJdZac 5SEyD/92yF+J88EJ3WpwGgllfMzVx/fK1TLKigXnT69tLFIJraqaX74SypCt48tC1lAnLwWC4ap 65NNRSiAjEFzcQluxkz2Nr/9HPCEqqrDdNVhADT43piNmAG9bi5p6tL1oiobSNr1HT+/grheCw7 WrTY1I71cR3FvDreHsD5BksvMrce/gMxdIsojCRgsq23c0QsFfCihvVJP4rdgkRJsRFomtWY1QC Zg4Gbytr5Lm6BXVscSDjF2PJGoYhBc5V7ozkh3frqRuIZ6Te5d8ZYISIZuCivxezD/HTkis/J+8 bf9ysX46ki/lVFVyq8VLVVZcn40NIB5iA2x8wP1g9E75FljJEWDOpgZNYaT9T8wX1FKHVYVwmbn vST/KTY3gNabQE/AJ92A+sz8f8BPxAqjYCZTvR6PU5OJ5e47lqrMqCVz4Vh4Rq1+jHByhbl1qX2 y+IyJAH9XMKLaxaBgX88gAqB28NGCYF7J/OPfYWwPb8qsOlm55hoSBIVNZvPeNjTdsx9jvq8a4s spAWaEzTzkQa9wFYly4mZRrijYSQCPnKqZigbWuBdzol18/nOTbmnUJH3jVdY9JMmYmwEX3asiE NodkqEBrpp9r3qjrwAi1Iw/Fxm4S1HU7mpRJdhGfMSBAqP23a30Un3X3gmEUdfTx27Xx6VgGTTk VGbUjyXxVfSklYw== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780674404966154100 The host_model and host_serial strings are allocated via g_strdup in property setters but never freed when the machine is destroyed. Fixes: 27461d69a0f ("ppc: add host-serial and host-model machine attributes= (CVE-2019-8934)") Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/ppc/spapr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 191f7431bdf..f0e99bb5be7 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -3517,6 +3517,8 @@ static void spapr_machine_finalizefn(Object *obj) SpaprMachineState *spapr =3D SPAPR_MACHINE(obj); =20 g_free(spapr->kvm_type); + g_free(spapr->host_model); + g_free(spapr->host_serial); } =20 void spapr_do_system_reset_on_cpu(CPUState *cs, run_on_cpu_data arg) --=20 2.54.0 From nobody Sun Jun 7 22:19:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780674457; cv=none; d=zohomail.com; s=zohoarc; b=WDO+HeEnBQ6hQijQfgX77IGYIa5et31rYp6OlCDbyDKT15JmqLsizNesRtsPc2y2C5+Q+3DvfgQghpIkJKT66Y0zia+3rMr59JvM4n9uM5orfalGgBpkaX4vhF/zM9gyiMHPGwDFl3qCvZx2EtthkK5599DFhf+4VX+oOkLfhH4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780674457; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=GrHGxvWCZFyP9F/U9uEn3LFLHsakCxnRmQhrxq0JqIM=; b=VSB/Drj0Bkk9Bj4SeiqoY/qGqsczs/o03+bnBjcB4dGxoX3lEEYIPh8JjFAf7ILPuDuMu6H9VnxrVpftBdbVfJhZi3KD90VVudurlaquETGvCCC2WDoGIxknNUaeQt7yzmkSP7XxFdPY9+HxrapugqGsKVc1J53MKQe1zSwG1Dg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780674457986372.69439446163653; Fri, 5 Jun 2026 08:47:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVWke-0007qb-Nd; Fri, 05 Jun 2026 11:46:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWkY-0007WE-0z for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:46:22 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWkV-0006fZ-Th for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:46:21 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-296-ipDtYzsSMkShAfDh_z4UBA-1; Fri, 05 Jun 2026 11:46:16 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3486418005A1 for ; Fri, 5 Jun 2026 15:46:15 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 32A743000210; Fri, 5 Jun 2026 15:46:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780674379; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GrHGxvWCZFyP9F/U9uEn3LFLHsakCxnRmQhrxq0JqIM=; b=EQdD/IdCl3gSSam6W8q6zWIqXRYmLdSYuqFmHUjoRXgFp9XXaMB0F2WtF3YwBzvXWwzWLm ccFBxTL9gkbpbtGb92uQ0N7X6t09a6LJrRHOWbMEL6ZcB1+4ULNEkq9Wq6ZFrzbdVwRzFr kI1a2mO83hdn34VR481vE5jbs4+bZ3U= X-MC-Unique: ipDtYzsSMkShAfDh_z4UBA-1 X-Mimecast-MFC-AGG-ID: ipDtYzsSMkShAfDh_z4UBA_1780674375 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Fri, 05 Jun 2026 19:44:40 +0400 Subject: [GIT PULL 20/23] target/riscv: fix general_user_opts hash table leak MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260605-qom-tests-v1-20-3f184f382c2b@redhat.com> References: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> In-Reply-To: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=9672; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=HxjHARniAbZ71B0WPuGb8+FlvpnOsoMgTb+xCutausA=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqIu7VlxUxyNz/zh4Pz1RHRXez4iGgGv7weNgb9 p+ZPU/XexSJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiLu1QAKCRDa6OEJdZac 5RdoEACaSNmpPDuhNGsWsPY8+kjwj0xvwECkpFd2K1hPqg6nbZ/ZNW787rPR/0OSli3WEZFJj1v YJfZdNXXmlJnf3oGD+QPh5EksZxeS2nqxnFUwDq5qG+FcyNFSH8iSVbFh8Jfi2PA0mNBlIrCHms 9ZwAoh8Tg6TbjszobH+OuXfoNIWinq7G4KCd4MwtuOTc/X2+k/VbC6e+btuW6O3rwf0mZJMy9+Z CguIYTUSyNtKjgl7YHWfGBDhLMRkGwFSPvpNC4Rbwuo4/S1pxp/SiwqYrW2oqHaiXdtogi4cMhM NFRWlavXQXz7T1ryRTfGANEnWZwxzZBOebPTbuvE9r0KTUsyq8sjLJKQORyllWJaQmm2Qz8G/qY JXVgeWU6Ip9aEJiCyLr8S1052Q6w+519JKH9TGc0K4KZrJlKDUsPojaiEmG5quu4Dx8gCzkTUxJ L+ZY4txO7ueuxqUrUW1W7/TT7f0lxRJ95mIaCmmF5qZOFfymhTZFbOFV699pt/mKBuYGe2eVQYA ZY48TPPSZiOCRTzL+MD7NsJy3sYxg18KpWFpQ+dey737DBuFfgyiDUlovhYePow+FZPPb6+0qpN y7WEc6VGilJbPNyj2D9FwpqEGSsaB31SMUhlOztvCkb1inSqiGqOxKMNOk4bpiKcwt084kK1vmA wrd4UtFWAAvYxJw== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780674461827154100 The global general_user_opts hash table is recreated on every riscv_cpu_init() call, leaking the previous one. Furthermore, the CPU settings should be associated with their instance and not global. Add a finalize() to free associated instances. Fixes: d167a2247ede ("target/riscv: move 'pmu-mask' and 'pmu-num' to riscv_= cpu_properties[]") Reviewed-by: Alistair Francis Signed-off-by: Marc-Andr=C3=A9 Lureau --- target/riscv/cpu.h | 3 ++- target/riscv/cpu.c | 53 ++++++++++++++++++++++++++++--------------= ---- target/riscv/kvm/kvm-cpu.c | 8 +++---- 3 files changed, 38 insertions(+), 26 deletions(-) diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h index 7d79c7a5a7e..f7d8a08c087 100644 --- a/target/riscv/cpu.h +++ b/target/riscv/cpu.h @@ -547,6 +547,7 @@ struct ArchCPU { uint32_t pmu_avail_ctrs; /* Mapping of events to counters */ GHashTable *pmu_event_ctr_map; + GHashTable *user_options; const GPtrArray *decoders; }; =20 @@ -620,7 +621,7 @@ bool riscv_cpu_tlb_fill(CPUState *cs, vaddr address, in= t size, bool probe, uintptr_t retaddr); char *riscv_isa_string(RISCVCPU *cpu); int riscv_cpu_max_xlen(RISCVCPUClass *mcc); -bool riscv_cpu_option_set(const char *optname); +bool riscv_cpu_option_set(RISCVCPU *cpu, const char *optname); =20 #ifndef CONFIG_USER_ONLY void riscv_cpu_do_interrupt(CPUState *cpu); diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 862834b4809..57000983edd 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -27,6 +27,7 @@ #include "qapi/error.h" #include "qapi/visitor.h" #include "qemu/error-report.h" +#include "qemu/timer.h" #include "hw/core/qdev-properties.h" #include "hw/core/qdev-prop-internal.h" #include "migration/vmstate.h" @@ -59,18 +60,16 @@ bool riscv_cpu_is_32bit(RISCVCPU *cpu) return riscv_cpu_mxl(&cpu->env) =3D=3D MXL_RV32; } =20 -/* Hash that stores general user set numeric options */ -static GHashTable *general_user_opts; - -static void cpu_option_add_user_setting(const char *optname, uint32_t valu= e) +static void cpu_option_add_user_setting(RISCVCPU *cpu, const char *optname, + uint32_t value) { - g_hash_table_insert(general_user_opts, (gpointer)optname, + g_hash_table_insert(cpu->user_options, (gpointer)optname, GUINT_TO_POINTER(value)); } =20 -bool riscv_cpu_option_set(const char *optname) +bool riscv_cpu_option_set(RISCVCPU *cpu, const char *optname) { - return g_hash_table_contains(general_user_opts, optname); + return g_hash_table_contains(cpu->user_options, optname); } =20 #ifndef CONFIG_USER_ONLY @@ -1126,7 +1125,7 @@ static void riscv_cpu_init(Object *obj) "riscv.cpu.rnmi", RNMI_MAX); #endif /* CONFIG_USER_ONLY */ =20 - general_user_opts =3D g_hash_table_new(g_str_hash, g_str_equal); + cpu->user_options =3D g_hash_table_new(g_str_hash, g_str_equal); =20 /* * The timer and performance counters extensions were supported @@ -1291,7 +1290,7 @@ static void prop_pmu_num_set(Object *obj, Visitor *v,= const char *name, =20 warn_report("\"pmu-num\" property is deprecated; use \"pmu-mask\""); cpu->cfg.pmu_mask =3D pmu_mask; - cpu_option_add_user_setting("pmu-mask", pmu_mask); + cpu_option_add_user_setting(cpu, "pmu-mask", pmu_mask); } =20 static void prop_pmu_num_get(Object *obj, Visitor *v, const char *name, @@ -1333,7 +1332,7 @@ static void prop_pmu_mask_set(Object *obj, Visitor *v= , const char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.pmu_mask =3D value; } =20 @@ -1365,7 +1364,7 @@ static void prop_mmu_set(Object *obj, Visitor *v, con= st char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.mmu =3D value; } =20 @@ -1397,7 +1396,7 @@ static void prop_pmp_set(Object *obj, Visitor *v, con= st char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.pmp =3D value; } =20 @@ -1437,7 +1436,7 @@ static void prop_num_pmp_regions_set(Object *obj, Vis= itor *v, const char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.pmp_regions =3D value; } =20 @@ -1475,7 +1474,7 @@ static void prop_pmp_granularity_set(Object *obj, Vis= itor *v, const char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.pmp_granularity =3D value; } =20 @@ -1548,7 +1547,7 @@ static void prop_priv_spec_set(Object *obj, Visitor *= v, const char *name, return; } =20 - cpu_option_add_user_setting(name, priv_version); + cpu_option_add_user_setting(cpu, name, priv_version); cpu->env.priv_ver =3D priv_version; } =20 @@ -1582,7 +1581,7 @@ static void prop_vext_spec_set(Object *obj, Visitor *= v, const char *name, return; } =20 - cpu_option_add_user_setting(name, VEXT_VERSION_1_00_0); + cpu_option_add_user_setting(cpu, name, VEXT_VERSION_1_00_0); cpu->env.vext_ver =3D VEXT_VERSION_1_00_0; } =20 @@ -1625,7 +1624,7 @@ static void prop_vlen_set(Object *obj, Visitor *v, co= nst char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.vlenb =3D value >> 3; } =20 @@ -1666,7 +1665,7 @@ static void prop_elen_set(Object *obj, Visitor *v, co= nst char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.elen =3D value; } =20 @@ -1702,7 +1701,7 @@ static void prop_cbom_blksize_set(Object *obj, Visito= r *v, const char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.cbom_blocksize =3D value; } =20 @@ -1738,7 +1737,7 @@ static void prop_cbop_blksize_set(Object *obj, Visito= r *v, const char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.cbop_blocksize =3D value; } =20 @@ -1774,7 +1773,7 @@ static void prop_cboz_blksize_set(Object *obj, Visito= r *v, const char *name, return; } =20 - cpu_option_add_user_setting(name, value); + cpu_option_add_user_setting(cpu, name, value); cpu->cfg.cboz_blocksize =3D value; } =20 @@ -2834,6 +2833,17 @@ void riscv_isa_write_fdt(RISCVCPU *cpu, void *fdt, c= har *nodename) DEFINE_RISCV_CPU(type_name, parent_type_name, \ .profile =3D &(profile_)) =20 +static void riscv_cpu_instance_finalize(Object *obj) +{ + RISCVCPU *cpu =3D RISCV_CPU(obj); + +#ifndef CONFIG_USER_ONLY + g_clear_pointer(&cpu->pmu_timer, timer_free); + g_clear_pointer(&cpu->pmu_event_ctr_map, g_hash_table_destroy); +#endif + g_clear_pointer(&cpu->user_options, g_hash_table_destroy); +} + static const TypeInfo riscv_cpu_type_infos[] =3D { { .name =3D TYPE_RISCV_CPU, @@ -2841,6 +2851,7 @@ static const TypeInfo riscv_cpu_type_infos[] =3D { .instance_size =3D sizeof(RISCVCPU), .instance_align =3D __alignof(RISCVCPU), .instance_init =3D riscv_cpu_init, + .instance_finalize =3D riscv_cpu_instance_finalize, .abstract =3D true, .class_size =3D sizeof(RISCVCPUClass), .class_init =3D riscv_cpu_common_class_init, diff --git a/target/riscv/kvm/kvm-cpu.c b/target/riscv/kvm/kvm-cpu.c index 17ba38403a3..53d88339c13 100644 --- a/target/riscv/kvm/kvm-cpu.c +++ b/target/riscv/kvm/kvm-cpu.c @@ -2034,7 +2034,7 @@ void riscv_kvm_cpu_finalize_features(RISCVCPU *cpu, E= rror **errp) } =20 if (cpu->cfg.ext_zicbom && - riscv_cpu_option_set(kvm_cbom_blocksize.name)) { + riscv_cpu_option_set(cpu, kvm_cbom_blocksize.name)) { =20 reg.id =3D KVM_RISCV_REG_ID_ULONG(KVM_REG_RISCV_CONFIG, kvm_cbom_blocksize.kvm_reg_id); @@ -2053,7 +2053,7 @@ void riscv_kvm_cpu_finalize_features(RISCVCPU *cpu, E= rror **errp) } =20 if (cpu->cfg.ext_zicboz && - riscv_cpu_option_set(kvm_cboz_blocksize.name)) { + riscv_cpu_option_set(cpu, kvm_cboz_blocksize.name)) { =20 reg.id =3D KVM_RISCV_REG_ID_ULONG(KVM_REG_RISCV_CONFIG, kvm_cboz_blocksize.kvm_reg_id); @@ -2072,7 +2072,7 @@ void riscv_kvm_cpu_finalize_features(RISCVCPU *cpu, E= rror **errp) } =20 if (cpu->cfg.ext_zicbop && - riscv_cpu_option_set(kvm_cbop_blocksize.name)) { + riscv_cpu_option_set(cpu, kvm_cbop_blocksize.name)) { =20 reg.id =3D KVM_RISCV_REG_ID_ULONG(KVM_REG_RISCV_CONFIG, kvm_cbop_blocksize.kvm_reg_id); @@ -2091,7 +2091,7 @@ void riscv_kvm_cpu_finalize_features(RISCVCPU *cpu, E= rror **errp) } =20 /* Users are setting vlen, not vlenb */ - if (riscv_has_ext(env, RVV) && riscv_cpu_option_set("vlen")) { + if (riscv_has_ext(env, RVV) && riscv_cpu_option_set(cpu, "vlen")) { if (!kvm_v_vlenb.supported) { error_setg(errp, "Unable to set 'vlenb': register not supporte= d"); return; --=20 2.54.0 From nobody Sun Jun 7 22:19:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780674485; cv=none; d=zohomail.com; s=zohoarc; b=d54D+xYESiZU4SmWkrlALrtrgk1fHeGOrAt6aUx3giFdheuerV0ZZsmM7l+mXTPEUNj6Szb0CSuxa+w8bXp+5HkhJVbT8MAZ/fNQQZpNdlwW/2ZbGD6K7cgif33Be9BFjZ5udMPS+GVaGfuKxVZm6I+bO0nIfzkGWHPns0heb5o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780674485; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=EW80NPiZA0afDX2EUeVylLahlZEm44Zw2VwztJ63muo=; b=fhwaVcuiM5XViYctMYK5J8Gr/QP34dK++gKAMqvVToicuglj+PwSp+A8ZUeeK+mcSFHP7ueM8wu53psyx/RnJyn7d9hg5SzOYxYmuEUzBmabpe1vjPdswbaUB285pPVhQZKdZ/3TCVI482wPFn8ia4RvhfX4GoUww1XIZXAcXV4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780674485319391.9648036657585; Fri, 5 Jun 2026 08:48:05 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVWl7-0008G5-6J; Fri, 05 Jun 2026 11:47:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWkb-0007ml-3b for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:46:25 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWkZ-0006gO-8A for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:46:24 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-556-Cgl9Rw_pPUiBKyL9BL2yEw-1; Fri, 05 Jun 2026 11:46:21 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 912B0195608B for ; Fri, 5 Jun 2026 15:46:20 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5B2661800480; Fri, 5 Jun 2026 15:46:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780674382; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EW80NPiZA0afDX2EUeVylLahlZEm44Zw2VwztJ63muo=; b=WW5j74UNZboTRer1CgcR51v33zVxlbRKPB2j/pdTH9gUEuGxnPfjI5EXmNhXfqXAVj9iRi vlwr7R/n2J5kALHm+Uf2ciG4Ezx/922M2Rzg0mlXOz8OjOiRaHbdfQCV31jtYLM3QdQcr9 lCcEhlvH9B9p7glR/umQBXDCxGSuXVo= X-MC-Unique: Cgl9Rw_pPUiBKyL9BL2yEw-1 X-Mimecast-MFC-AGG-ID: Cgl9Rw_pPUiBKyL9BL2yEw_1780674380 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Fri, 05 Jun 2026 19:44:41 +0400 Subject: [GIT PULL 21/23] target/riscv: use hash table as set for user_options MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260605-qom-tests-v1-21-3f184f382c2b@redhat.com> References: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> In-Reply-To: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=4808; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=upzIszpg9Sqx2Er0dwvmJZ/wdllyA5oABsmXU9+/2ek=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqIu7VC49Xtq7xfGs7Q6v9KVruKr1UbQEjfQAd2 hU/PIGoRpqJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiLu1QAKCRDa6OEJdZac 5SmpD/48QBtLwmxLgn78F/GfN6jSReRHQ8NfxCA5g7sWTw8smKk/Zrv+Kdjqk8nLz3I/Q35iuX1 DIWIE0dPAhM6dM+dMoegv4NxO6pO7hWV9q6qel4KrULr1UaaIZlsM3omtc8NBbxiOltIwPobJRm 2iD6jPwr8gLYdtgZBBxwyq7vUoHVklu92PJga9wB0NoxVwe8WXQbVDsiXmK1rDvoMshF/aQ/xVu r/IYR0lyFaz+2m2wm2jU5s24sCcqQk8jfeL8KN+YZfLEvx09Jqi1vutt50U4Je8MZkReXWjC+/n DM4tS3gz6Ibj1qzL5VquBWws1yzs5tusfck3eopbIKvPvS34aR2DSoAaRA3iMe6cD1ugU2QeX18 9vl5+sItPU8vi7iW/O/LCN92oZrVVd9N9HkIZ5wivueQXL1JCSNMlFZdfI7VgjvJ2URf1uq0MNK Tf2wtkWwiuVQAp5BLBcArZ8FGMe8LA6pLDmCDzZ83kmXEwC6NjuM6escvPfBZEDiMB0l9+TZ2UE cLgOsbx4V0vQIqEjNgze4udP6juZ62YHGCPapdkzpM4kqSzX6oAxIUo5s/z92d33+BvqaKKWNhc 6uGfDtTrW4LIHxIaW4NfXtVk8tWOKRSZeLwXdcgEryR//q6kQMF2DftXnDBfMYjJdIDw/L7HZRR sRAJZBm7bnBFgxA== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780674486674158500 The values stored in user_options are never retrieved, only key presence is checked. Use g_hash_table_add() instead of g_hash_table_insert() and drop the unused value parameter. Reviewed-by: Alistair Francis Signed-off-by: Marc-Andr=C3=A9 Lureau --- target/riscv/cpu.c | 32 +++++++++++++++----------------- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 57000983edd..5903df99548 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -60,11 +60,9 @@ bool riscv_cpu_is_32bit(RISCVCPU *cpu) return riscv_cpu_mxl(&cpu->env) =3D=3D MXL_RV32; } =20 -static void cpu_option_add_user_setting(RISCVCPU *cpu, const char *optname, - uint32_t value) +static void cpu_option_add_user_setting(RISCVCPU *cpu, const char *optname) { - g_hash_table_insert(cpu->user_options, (gpointer)optname, - GUINT_TO_POINTER(value)); + g_hash_table_add(cpu->user_options, (gpointer)optname); } =20 bool riscv_cpu_option_set(RISCVCPU *cpu, const char *optname) @@ -1290,7 +1288,7 @@ static void prop_pmu_num_set(Object *obj, Visitor *v,= const char *name, =20 warn_report("\"pmu-num\" property is deprecated; use \"pmu-mask\""); cpu->cfg.pmu_mask =3D pmu_mask; - cpu_option_add_user_setting(cpu, "pmu-mask", pmu_mask); + cpu_option_add_user_setting(cpu, "pmu-mask"); } =20 static void prop_pmu_num_get(Object *obj, Visitor *v, const char *name, @@ -1332,7 +1330,7 @@ static void prop_pmu_mask_set(Object *obj, Visitor *v= , const char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.pmu_mask =3D value; } =20 @@ -1364,7 +1362,7 @@ static void prop_mmu_set(Object *obj, Visitor *v, con= st char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.mmu =3D value; } =20 @@ -1396,7 +1394,7 @@ static void prop_pmp_set(Object *obj, Visitor *v, con= st char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.pmp =3D value; } =20 @@ -1436,7 +1434,7 @@ static void prop_num_pmp_regions_set(Object *obj, Vis= itor *v, const char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.pmp_regions =3D value; } =20 @@ -1474,7 +1472,7 @@ static void prop_pmp_granularity_set(Object *obj, Vis= itor *v, const char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.pmp_granularity =3D value; } =20 @@ -1547,7 +1545,7 @@ static void prop_priv_spec_set(Object *obj, Visitor *= v, const char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, priv_version); + cpu_option_add_user_setting(cpu, name); cpu->env.priv_ver =3D priv_version; } =20 @@ -1581,7 +1579,7 @@ static void prop_vext_spec_set(Object *obj, Visitor *= v, const char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, VEXT_VERSION_1_00_0); + cpu_option_add_user_setting(cpu, name); cpu->env.vext_ver =3D VEXT_VERSION_1_00_0; } =20 @@ -1624,7 +1622,7 @@ static void prop_vlen_set(Object *obj, Visitor *v, co= nst char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.vlenb =3D value >> 3; } =20 @@ -1665,7 +1663,7 @@ static void prop_elen_set(Object *obj, Visitor *v, co= nst char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.elen =3D value; } =20 @@ -1701,7 +1699,7 @@ static void prop_cbom_blksize_set(Object *obj, Visito= r *v, const char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.cbom_blocksize =3D value; } =20 @@ -1737,7 +1735,7 @@ static void prop_cbop_blksize_set(Object *obj, Visito= r *v, const char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.cbop_blocksize =3D value; } =20 @@ -1773,7 +1771,7 @@ static void prop_cboz_blksize_set(Object *obj, Visito= r *v, const char *name, return; } =20 - cpu_option_add_user_setting(cpu, name, value); + cpu_option_add_user_setting(cpu, name); cpu->cfg.cboz_blocksize =3D value; } =20 --=20 2.54.0 From nobody Sun Jun 7 22:19:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780674491; cv=none; d=zohomail.com; s=zohoarc; b=nYGBQ0mCRxvityQ5doE+dte7yiQMBLallBciSY/LfCmMfo4aoD4WD1suNp6HMRY3uhIW7c3qgje5D6MZ2phApQEQQbm5vxSVnX2seKv4P6Js1adXIYC1Z6NUgVNxx6Q4WwhMhf11N//mTzr1Ayxps3wko+lpzPqgZaVaZCw4Hz0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780674491; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=+NL8QctavYi5DdXdHAMIZ4f9HFFB9e2UpkzCtfuk8pk=; b=XivFN+LSLrBWY9UyIEsZ10PJXKnJ/Y7ioMGvAYVgFG0lluI/81ucLrU1QgPY4m1KLOEqXgRqvSTk4/KvoYfKtWbilt/xH1roYNLXb9pPKmL17ff7MJG8Ky1cfnncWkB/yWIByupvEXz4iZHUbH/zyPMZp/0lmYUbRtTGts90DEs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780674491852670.0746699515323; Fri, 5 Jun 2026 08:48:11 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVWlX-00009v-C3; Fri, 05 Jun 2026 11:47:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWki-000863-Ih for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:46:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWkg-0006hk-4n for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:46:31 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-131-uTogNy5ZN2uUKEgaKL74Lw-1; Fri, 05 Jun 2026 11:46:27 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 125A119560BB for ; Fri, 5 Jun 2026 15:46:27 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E511B195608E; Fri, 5 Jun 2026 15:46:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780674389; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+NL8QctavYi5DdXdHAMIZ4f9HFFB9e2UpkzCtfuk8pk=; b=GGFkYtmWEuSfPFPZzRO7wKMRg3gdjjzamO/zAxGvr3WOSDBM8m/1mZFDic8iJrq46N6KWa dK8oqiXIR97tEOEmu/tE0hd6h5aOe3xW7uQgMXgDjyrauUbz3fGOr95wVD/CzL/A5UJTOa QwQtHhKipCaNCT/eXCdwbiVU2Fu5lT4= X-MC-Unique: uTogNy5ZN2uUKEgaKL74Lw-1 X-Mimecast-MFC-AGG-ID: uTogNy5ZN2uUKEgaKL74Lw_1780674387 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Fri, 05 Jun 2026 19:44:42 +0400 Subject: [GIT PULL 22/23] hw/i2c/pmbus: fix undefined behavior in pmbus_direct_mode2data MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260605-qom-tests-v1-22-3f184f382c2b@redhat.com> References: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> In-Reply-To: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=1238; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=InibdptYukTMVdGxYJf7WVxUTmIyMdBTr0yibOubUdU=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqIu7VtJDZ1MM002NWjuH45Ig/A4MaCTf3tRxoZ Nhu2BOwa5aJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiLu1QAKCRDa6OEJdZac 5UO2EACgRyZpg+LK6l2kJyLITl2yMmEY8zHGmsSrfG7aj4LG9tiw5vJIXBwz49Aqg/9k7RtMQwi c7e3xA5UV3pcSpa4o4XVABKfRhwo6H6wwp3DUI78PWHHIy2/dlEjmf8UJ3T4MIrF92Iu2i3B1m0 ZJaNTs7cNOPgCKmOvSHxwe0FzoafssjvmDj4hNrBaYE85qRJp+tmRsnUmXcuL68Lynhfxw2iRrS 5M7XLokkv849CBCvpQkRrF/xGGg9rMjs2ogqUDHXTGzjimiHmR4M6+cgdzD+R3i7Y0lOu3K1HjJ YAV+tik/9gHZRXNe6QnuynUUplBkRSOlIhHSysXWiKI5LtwUWnVNzOYsawyzIg2gG+3F6NdaBw5 Yp+qsjfAbIftxHhxEK2Wdr5GWGKs6wE3ZHuUvmSyvy6kCgoIKiTFqoFTr6re75IGYRO12aOQx6A 3yLeOzJ34/8e8m73I/7ovFdf1W1LE1o1fMcVOprX/MezNWnsYDgCyBYw6/zVWLMyKqUTEY/PXxD Oz90HhowiHS3BjyC2uatvyyaRYK/38MtK7xJLJFgs2zJnLsioGxbHBgzIBtVmUpOpqO+JvFZcNh hWaYll8eks1ZBVzlkfIhknLys2qMt/UnAix3JeIDZ2J9QSjLWFbeM7SbgmAmB1QNGO5WoDmSmKr 2oCgWhRsonDk48g== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780674494259154100 The intermediate result of (Y * 10^-R - b) / m can be negative when the bias (b) is large and the raw register value is small (e.g. zero on an uninitialized device). Assigning that negative double to uint32_t is undefined behavior, caught by UBSan/clang. Use a double intermediate and clamp negative results to zero (suggested by Daniel Berrang=C3=A9) Fixes: 3746d5c15e70 ("hw/i2c: add support for PMBus") Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/i2c/pmbus_device.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c index 853dc4b4342..b1f9843f52e 100644 --- a/hw/i2c/pmbus_device.c +++ b/hw/i2c/pmbus_device.c @@ -23,8 +23,10 @@ uint16_t pmbus_data2direct_mode(PMBusCoefficients c, uin= t32_t value) uint32_t pmbus_direct_mode2data(PMBusCoefficients c, uint16_t value) { /* X =3D (Y * 10^-R - b) / m */ - uint32_t x =3D (value / pow(10, c.R) - c.b) / c.m; - return x; + double x =3D (value / pow(10, c.R) - c.b) / c.m; + return (x > 0 + ? (x < G_MAXUINT32 ? (uint32_t)x : G_MAXUINT32) + : 0); } =20 uint16_t pmbus_data2linear_mode(uint16_t value, int exp) --=20 2.54.0 From nobody Sun Jun 7 22:19:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1780674457; cv=none; d=zohomail.com; s=zohoarc; b=ncwckaQO8WRNhb5dTvI/SDjVSYl3xK/s8qw6/eI/FnX/0s1lSPt1t0aC0yEZYqy2vdx5KsRWj9LZqAqm9FVtF74OApb7YXuH17ixysHa+8L5yKfFTlvdoUdHv0ogJleTtqSAhCtFyO82/Mp4HdZ6qV8cA1+IwDxgI5PqGuN+s+Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780674457; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=9VyZiJ2ahA2S/F2Rs8hb2fk5gvFLJAv/h8MtGmJNquk=; b=mAD0pEFscMLrEp6T//mQXY8AAU62asXLLA5P0GYZyNGb2Rv3DmW3lMB8jpMbnF/gqX7iMjFfsuRH8RKYNhdurjWOs5ImGLYwUNB8rdOmGhzA6OePTy1BDtYktnqeYZ6c9Mr+7WZ2Fc74+OSSo3jN7rGrmeaO7fB6JVrKmBniI4s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1780674457052831.0935527166371; Fri, 5 Jun 2026 08:47:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wVWlT-000063-4T; Fri, 05 Jun 2026 11:47:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWkq-0008E4-Os for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:46:48 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wVWkn-0006in-RF for qemu-devel@nongnu.org; Fri, 05 Jun 2026 11:46:40 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-540-NC674Kd4Okq5i35htT0ldA-1; Fri, 05 Jun 2026 11:46:33 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 75F6619560A7 for ; Fri, 5 Jun 2026 15:46:32 +0000 (UTC) Received: from localhost (unknown [10.44.24.6]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6AABC18004D4; Fri, 5 Jun 2026 15:46:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780674394; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9VyZiJ2ahA2S/F2Rs8hb2fk5gvFLJAv/h8MtGmJNquk=; b=BPIN63BGYHtdP7ST7e0jUUHOkjSFH9YKOd7QYlw9tcZtMKnRmldNNOfEl6ACJjJc0Gktgu ApMlsNJax749YWPB+qN3WjOLBBvECrAffKPwmO//5UvtK48mHCYIvkoVfLi/6iNaWlxCBa uMVbA0OfRqWYti5mz5JMi0+7HuaAviY= X-MC-Unique: NC674Kd4Okq5i35htT0ldA-1 X-Mimecast-MFC-AGG-ID: NC674Kd4Okq5i35htT0ldA_1780674392 From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Fri, 05 Jun 2026 19:44:43 +0400 Subject: [GIT PULL 23/23] qtest: add "qom-tests" command MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260605-qom-tests-v1-23-3f184f382c2b@redhat.com> References: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> In-Reply-To: <20260605-qom-tests-v1-0-3f184f382c2b@redhat.com> To: qemu-devel@nongnu.org Cc: stefanha@redhat.com X-Developer-Signature: v=1; a=openpgp-sha256; l=4983; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=BgJPBPmH5B6RRCynYwgwnZTtBG1LgQz3rhYtKXyzYDQ=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqIu7V9DsUZxeuqXZ1gtj8CvKYV6xEtsOj1VTXX HlT6ogezT6JAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCaiLu1QAKCRDa6OEJdZac 5VCuEACe21iMLsPUF4B9EUQcJA/zwuCQmO1T8c4xtpJ7Gxnen0W1I7/fg7l+fDnV+cMIugBmwdd xGmCKFAVSL6Br2xEK6TI75Tm+DU6Eqol14rh7YbRknCXhqx7ocEnUOjyMzHj/BpWmgchywnvZn5 KJfR9HHZ4fhQC8HIv/JX6piC+dd0UgNaRgYJiEd6nFwoPine45dTy7HuYn+kqGXAVJ9YDhQaen+ hSO8blDuKcEwKX8qD+ED/rVK0lFFUXAue+g4r9HStErgFoLt4F0oOPrzzs9VJWzgf1PXYhnW7J9 O9jJtdeYPkWPf90vzH2E/7kb+z7zNuEJOYIKbfY+rnK3VHBAG9252AodUK/0EFH3LoE9TkX/Rhf Gaz5YgJGrTb0UYzwnVZg4K/JROt2evN6mblqOzW86cGBs+0TIe8l6yzX898V0cu1z5IjXg3n60+ R1FOq3jyYparRpntXOoyxEro00WziD1j74aH1DNR68hkN5p+0FFzpgxhkMm+Tzp3GTaBmTpIqIr BwWQE0erEe8P6gtswJ84iCWU9tWtdtJyX6/ja9sX8ODC6hmHkzjQGxuf/Vf5RQGsf2Vl2wxM5/2 grWM8wiSq55PTNBcGyOdF7QukaX1t1JrlFSrFTpUrEungSUilHe0G951DWtfwejjBuIpmzTORvl y/fS1Mxyyvht1NQ== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: 8 X-Spam_score: 0.8 X-Spam_bar: / X-Spam_report: (0.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1780674459679154100 Add a new "qom-tests" to exercise basic object lifecycle. Instantiate all non-abstract objects, get and set properties and unref. This should quickly find leaks and other related issues that are eventually triggerable at run-time with QMP qom commands. Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Marc-Andr=C3=A9 Lureau --- tests/qtest/libqtest.h | 8 ++++++++ system/qtest.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++ tests/qtest/libqtest.c | 6 ++++++ tests/qtest/qom-test.c | 12 ++++++++++++ 4 files changed, 72 insertions(+) diff --git a/tests/qtest/libqtest.h b/tests/qtest/libqtest.h index 950ea2baafa..45217fb8dc0 100644 --- a/tests/qtest/libqtest.h +++ b/tests/qtest/libqtest.h @@ -426,6 +426,14 @@ char *qtest_vhmp(QTestState *s, const char *fmt, va_li= st ap) =20 void qtest_module_load(QTestState *s, const char *prefix, const char *libn= ame); =20 +/** + * qtest_qom_tests: + * @s: #QTestState instance to operate on. + * + * Run QOM property get/set round-trip tests on all non-abstract types. + */ +void qtest_qom_tests(QTestState *s); + /** * qtest_get_irq: * @s: #QTestState instance to operate on. diff --git a/system/qtest.c b/system/qtest.c index d6db057b0a2..fd37bcbfaab 100644 --- a/system/qtest.c +++ b/system/qtest.c @@ -31,6 +31,8 @@ #include "qemu/cutils.h" #include "qemu/target-info.h" #include "qom/object_interfaces.h" +#include "qom/qom-qobject.h" +#include "qobject/qobject.h" =20 #define MAX_IRQ 256 =20 @@ -754,6 +756,50 @@ static void qtest_process_command(CharFrontend *chr, g= char **words) new_ns =3D qemu_clock_advance_virtual_time(ns); qtest_sendf(chr, "%s %"PRIi64"\n", new_ns =3D=3D ns ? "OK" : "FAIL", new_ns); + } else if (strcmp(words[0], "qom-tests") =3D=3D 0) { + GSList *list, *l; + + list =3D object_class_get_list(NULL, false); + for (l =3D list; l; l =3D l->next) { + ObjectClass *klass =3D l->data; + const char *type_name =3D object_class_get_name(klass); + Object *obj; + ObjectPropertyIterator iter; + ObjectProperty *prop; + + obj =3D object_new_with_class(klass); + object_property_iter_init(&iter, obj); + while ((prop =3D object_property_iter_next(&iter))) { + QObject *value; + Error *local_err =3D NULL; + + value =3D object_property_get_qobject(obj, prop->name, + &local_err); + if (local_err) { + error_report("qom-tests: %s.%s: get failed: %s", + type_name, prop->name, + error_get_pretty(local_err)); + error_free(local_err); + continue; + } + + if (prop->set) { + if (!object_property_set_qobject(obj, prop->name, valu= e, + &local_err)) { + error_report("qom-tests: %s.%s: set failed: %s", + type_name, prop->name, + error_get_pretty(local_err)); + error_free(local_err); + } + } + + qobject_unref(value); + } + + object_unref(obj); + } + g_slist_free(list); + qtest_send(chr, "OK\n"); } else if (process_command_cb && process_command_cb(chr, words)) { /* Command got consumed by the callback handler */ } else { diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c index b1e06ea364e..4e22c66b754 100644 --- a/tests/qtest/libqtest.c +++ b/tests/qtest/libqtest.c @@ -1137,6 +1137,12 @@ void qtest_module_load(QTestState *s, const char *pr= efix, const char *libname) qtest_rsp(s); } =20 +void qtest_qom_tests(QTestState *s) +{ + qtest_sendf(s, "qom-tests\n"); + qtest_rsp(s); +} + static int64_t qtest_clock_rsp(QTestState *s) { gchar **words; diff --git a/tests/qtest/qom-test.c b/tests/qtest/qom-test.c index 6421f2d9d9f..cf4c6b5add5 100644 --- a/tests/qtest/qom-test.c +++ b/tests/qtest/qom-test.c @@ -227,6 +227,17 @@ static void add_machine_test_case(const char *mname) g_free(path); } =20 +static void test_qom_qtests(void) +{ + QTestState *qts; + + qts =3D qtest_initf("-machine none"); + + qtest_qom_tests(qts); + + qtest_quit(qts); +} + int main(int argc, char **argv) { char *v_env =3D getenv("V"); @@ -238,6 +249,7 @@ int main(int argc, char **argv) g_test_init(&argc, &argv, NULL); =20 qtest_cb_for_every_machine(add_machine_test_case, g_test_quick()); + qtest_add_func("qom/qom-qtests", test_qom_qtests); =20 return g_test_run(); } --=20 2.54.0